[11:53]  * gmb lunches
[13:21] <gary_poster> danilos, hey.  Can I take "UI: unmute does not show dialog, just unmutes"--that is, is the kanban board accurate?  If so, what branch should I use as a base--is "Provide BugMute table and use it for muting bug subscriptions" in db-devel or is the kanban accurate again, and I need to get a branch?
[13:22] <gary_poster> Ah-ha
[13:22] <gary_poster> looks like I need to branch https://code.launchpad.net/~danilo/launchpad/proper-bug-muting
[13:22] <danilos> gary_poster, you could, but it'd be even better to branch off my nothing branch
[13:22] <gary_poster> ...uh...wha?
[13:22] <danilos> gary_poster, I've got one test to take care of there and it's going up for review
[13:22] <gary_poster> oh, your nothing branch!
[13:23] <gary_poster> heh, got it now
[13:23] <gary_poster> lp:~danilo/launchpad/bug-772763-remove-nothing
[13:23] <danilos> gary_poster, heh, yeah :)
[13:23] <gary_poster> cool thanks
[13:24] <danilos> gary_poster, I hit a bunch of test failures in the proper-bug-muting branch, fwiw, some of them related to person merging
[13:24] <gary_poster> ah, yeah, that's a pain
[13:24] <gary_poster> but resolved now, it looks like
[13:24] <danilos> gary_poster, yeah, up in ec2 again (just in case)
[13:24] <gary_poster> :-) cool
[13:26] <gary_poster> bac benji danilos gmb, kanban now-ish, skype in 4
[13:33] <gmb> https://bugs.launchpad.net/launchpad/+bug/783948
[13:33] <_mup_> Bug #783948: Entering a comment returns an error <Launchpad itself:Triaged> < https://launchpad.net/bugs/783948 >
[13:33] <gmb> https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/752193
[13:33] <_mup_> Bug #752193: Installation of the acroread package causes completion to treat directories like files with some commands <amd64> <apport-bug> <natty> <acroread (Ubuntu):Confirmed for brian-thomason> <bash-completion (Ubuntu):Won't Fix> <bash-completion (Debian):Won't Fix> < https://launchpad.net/bugs/752193 >
[13:58] <gmb> gary_poster, benji: Am I right in thinking that a LocationError from TAL basically means "You're trying to access an attribute that doesn't exist"?
[14:00] <benji> gmb: not normally; it's more often a problem finding out where an object is in the url space; e.g., it doesn't have a __parent__
[14:00] <gary_poster> yeah
[14:00] <gmb> Hmm.
[14:01] <gmb> Here's the salient bit of the OOPS:
[14:01] <gmb> LocationError: (<zope.browserpage.metaconfigure.SimpleViewClass from /srv/launchpad.net/production/launchpad-rev-13053/lib/lp/bugs/browser/../templates/bug-portlet-subscribers.pt object at 0xfe1d610>, 'current_user_mute_class')
[14:01] <gmb> I'm trying to figure out what that actually means in this case.
[14:01] <gary_poster> is there a traceback as well, or is that eaten somehow?
[14:01] <gmb> gary_poster: It's all here: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1963BC361
[14:03] <gary_poster> gmb, your initial description was correct
[14:04] <gmb> Ah.
[14:04] <gmb> Now that's very odd.
[14:04] <gary_poster> as I expect you saw,
[14:04] <gary_poster>         attr = getattr(subject, name, _marker)
[14:04] <gary_poster>         if attr is not _marker:
[14:04] <gary_poster>             return attr
[14:04] <gary_poster>         if hasattr(subject, '__getitem__'):
[14:04] <gary_poster>             try:
[14:04] <gary_poster>                 return subject[name]
[14:04] <gary_poster>             except (KeyError, TypeError):
[14:04] <gary_poster>                 pass
[14:04] <gary_poster>         raise LocationError(subject, name)
[14:04] <gmb> Saw, but didn't pay enough attention to :)
[14:04] <gary_poster> :-)
[14:05] <gmb> Hmm.
[14:06] <gary_poster> this may be one of those transitive attribute errors...sometimes they explain surprises like this
[14:06] <gary_poster> if current_user_mute_class is an @property
[14:07]  * gary_poster looks forward to having Python use mwh's wrapped exceptions, from whatever version of Python that is in
[14:09] <gmb> gary_poster: That wouldn't explain why the page still OOPSes for Gavin and I but not wgrant, though.
[14:09] <gary_poster> gmb, ForbiddenAttribute and Unauthorized both subsclass AttributeError, IIRC.  Maybe pertinent?
[14:10] <gmb> Ah, true.
[14:10] <gmb> Hmm.
[14:10]  * gmb pokes
[14:10] <gary_poster> They would be eaten by the code above
[14:10] <gmb> Yes.
[14:10] <gary_poster> and converted into LocationError
[14:10] <gmb> Quite so.
[14:10] <gmb> So, let's see if I can break it.
[14:10] <gmb> Muhahaha, etc.
[14:11] <gary_poster> heh
[15:19] <gary_poster> danilos, I'm ready anytime for our call.  This is 11 minutes early, so no rush. ;-)  Give me a Skype call when you are ready.
[15:26] <danilos> gary_poster, sure thing, I am ready myself
[15:27] <gary_poster> cool
[15:28] <gmb> gary_poster: I haven't been able to break anything and I've now been sucked into an OCR / helping out a contributor conversation. I think it might be a good time to roll back my last revision since that seems (to me) like a likely culprit.
[15:52] <gary_poster> gmb, ok, please do
[15:53] <gmb> On it now.
[16:44] <gmb> gary_poster: I can confirm that the rollback fixed the problem.
[16:45] <gmb> Now, that doesn't mean that it was actually my revision that caused the problem (we rolled back from 13050 to 13045 for logistical reasons) but it seems likely.
[16:57] <gary_poster> gmb, just saw this, but mostly good. :-)
[16:57] <gmb> Yeah.
[16:57] <gmb> Trouble is reproducing it.
[17:35] <danilos> gmb, thanks for the review
[17:35]  * danilos -> off
[17:35] <gmb> np
[18:21] <bac> hi gary_poster, benji: on this page https://bugs.launchpad.net/ubuntu/+subscriptions there is a help icon next to the "Stop my emails" link.  but we go to great pains to make it appear and disappear on hover.  why?
[18:21] <bac> i think that link only appears for team subscriptions and perhaps ones for teams you don't administer
[18:24] <benji> bac, I don't remember specifically why I did it that way; I think it was to reduce confusion because of the number of other icons visible
[18:24] <gary_poster> bac: why: the number of icons were becoming problematic.  The hover was a problematic solution that benji prototyped up and that we felt was an improvement.  [Link should appear for team subscriptions, unless team has a contact address (that last part is in progress).]
[18:25] <bac> ok.  fwiw it seemed like a browser bug when i first encountered it.
[18:25] <gary_poster> heh
[18:26] <gary_poster> making it appear gradually would reduce that impression, but not remove the underlying discoverability problem.
[18:37] <bac> gary_poster: bug 778323
[18:37] <_mup_> Bug #778323: On the subscription page, the help popup button opens up a 404 page. <story-better-bug-notification> <Launchpad itself:Triaged by bac> < https://launchpad.net/bugs/778323 >
[18:37] <bac> gary_poster: so the problem is the help file only exists for bugs.lp.net
[18:37] <gary_poster> bac, good one.  Sorry, I forget to do the bug review for you :-(
[18:37] <gary_poster> bac, is that one that we do a symlink for?
[18:37] <bac> gary_poster: but i think people are hacking urls to go to http://launchpad.net/ubuntu/+subscriptions
[18:38] <bac> gary_poster: yes, i can solve it by putting a symlink in registry/help...but if they use code.lp.net or answer.lp.net it'll break.  :(
[18:38] <bac> so, perhaps the right thing to do is to force a redirect to the bugs rootsite?
[18:38] <gary_poster> oh!
[18:39] <gary_poster> interesting
[18:39] <bac> or change the way +help works
[18:39] <bac> admittedly, coming via one of the other rootsites is pretty rare, i'd guess
[18:39] <gary_poster> bac, I'm ok with whichever is easier.  The redirect would be what I would tackle, probably.
[18:40] <bac> yeah, so how would you do that?
[18:40] <bac> the zcml seems to only configure that page for the bugs rootsite, so i'm a bit confused why the others work
[18:41] <gary_poster> Well, I would have expected to simply di a redirect during the initialize stage
[18:41] <gary_poster> do
[18:42] <gary_poster> I'm not sure about the zcml.  I can stare at it with you, if you like; it's LP zcml machinery, I think, not ye olde Zope stuff
[18:43] <bac> that's ok.  i'll bug you if i get stumped
[18:44] <gary_poster> cool
[19:29] <gary_poster> bac, ready for call whenever you are
[19:29] <gary_poster> gimme a call when you want
[19:29] <bac> gary_poster: ok.  just a sec.
[19:29] <gary_poster> np