[02:35] nigelb: cjohnston: http://www.youtube.com/watch?v=AqwJejqdQRk [02:37] that your stupid usb thing [03:16] no, that's my awesome usb thing === daker_ is now known as daker === daker_ is now known as daker [14:19] mhall119: Its *awesome* === MTecknology is now known as EvilMTeck [15:24] ? [15:35] cjohnston: the awesome usb thing ;) === daker is now known as daker_ [19:19] cjohnston: nigelb: https://code.launchpad.net/~mhall119/django-openid-auth/fixes-642132/+merge/54193 has landed in trunk! [19:20] now we just have to wait for the package to be built, and then sweet-talk IS into installing it [19:21] hopefully my other code, to give a friendlier explanation of why login fails, will land and be part of that build [19:22] \o/ [19:23] I'll need to propose my LD changes and make similar ones to summit [19:24] mhall119: do you remember which bit of changes caused the % failure? [19:24] in summit? [19:24] mhall119: I'd like to try and figure out where to start fixing render.py :\ [19:24] nigelb: start from orbit, with a nuke [19:24] mhall119: hahah. After getting 2 fixes into LP, render.py seems like a good starting point :p [19:26] true [19:26] nigelb: so the problem is that render.py builds up a string, using a combination of static strings and db values [19:26] then it takes the whole combined string and runs it through the built-in string formatting [19:27] which means that if you have a % in one of those db values, it's going to think it's a string formatting variable [19:27] so we need more escaping? [19:27] or is there a different solution to the problem [19:28] I mean, we can rewrite render.py but how can we do things differently is my question [19:29] so the easiest way is, whenever you are pulling in a value from the db, do a .replace('%', '%%') [19:30] mhall119: ah. But the way that render.py does things is not not wrong per se. [19:30] on the db value before you append it to the string [19:30] nigelb: everything about render.py is wrong [19:32] mhall119: haha, that's why I asked how would I fix it if I were interested in rewriting it. [19:32] if you're interested in rewriting it, use templates [19:32] (I am interested in rewriting it from scratch if that would give it more love) [19:33] mhall119: explain more? [19:33] instead of manually building up the entire page with a series a string concatenations, just build up the data as context variables and pass it to a template [19:34] mhall119: Are you free on Friday for a call to explain how to start? [19:34] only after noon my time [19:35] Michelle voluntold me to help out at the school in the morning [19:35] around this time? [19:35] 1400 UTC that is [19:36] bahhh [19:36] 1400 your time [19:36] mhall119: ^^ [19:36] I should be home then, yes [19:37] we can see if cjohnston is available to join in too [19:38] geez, I really need to convert readfeeder over to postgres, mysql is sloooow [19:38] (for writes anyway) [19:39] awesome [19:44] heh [19:44] yeah [19:45] postgres is awesome. [21:22] get me to do what [21:31] cjohnston: call at 1400 tomorrow. [21:31] 1400 your time [21:31] I should be able to [21:31] whats it for? render.py? [21:33] skype or somethign else?