| danilos | mmm, food :) | 13:01 |
|---|---|---|
| * danilos -> lunch | 13:01 | |
| gary_poster | danilos, sounds like you are on a very short lunch break. I started replying to your emails, but I think a call will be faster | 13:22 |
| danilos | gary_poster, sure thing | 13:26 |
| danilos | gary_poster, done now, so if you want a really short call :) | 13:26 |
| gary_poster | bac danilos gmb, kanban now-ish, call in 4, brief retrospective after that, call with danilo about branches after that, weekly call will danilo sometime after that :-) | 13:26 |
| danilos | heh | 13:26 |
| bac | ok | 13:27 |
| gary_poster | danilos, thanks but naah, should look at kanban | 13:27 |
| gmb | ok | 13:27 |
| danilos | gary_poster, thanks for adding the card, I was going to do that as well | 13:30 |
| gary_poster | cool np | 13:30 |
| gary_poster | bac, can you hear us? we can't hearyou | 13:31 |
| bac | i'm on, unmuted and talking | 13:31 |
| bac | :( | 13:31 |
| bac | i can hear | 13:31 |
| danilos | gary_poster, ok, so the changes in personIsAlsoNotifiedSubscriber are actually from gmb's branch at https://code.launchpad.net/~gmb/launchpad/bug-772609/+merge/60176 (I guess revert messed us up) | 13:35 |
| === Ursinha is now known as Ursinha-afk | ||
| danilos | gmb, heya, here's the tests that've done for your branch :) https://pastebin.canonical.com/47665/ | 14:02 |
| gmb | danilos: Thanks. I like this setup where other people do work for me. :) | 14:03 |
| danilos | gmb, if you see them as useful, you know what to do (and I am sure you know even better what to do if you don't like them :) | 14:03 |
| danilos | gmb, heh, you have a tyrant personality, that's what it is :) | 14:03 |
| gmb | :) | 14:03 |
| danilos | gmb, fwiw, I am not sure about test_subscribers_from_dupes_includes_structural_subscribers for your branch though (actually, I believe it doesn't belong there) | 14:12 |
| gmb | danilos: Okay. Without looking at the test itself just yet, I agree (based purely on what I hope is a good test title :)) | 14:14 |
| danilos | gmb, actually... | 14:14 |
| danilos | gmb, how about you try it out and see if it works :) | 14:15 |
| gmb | Heh. | 14:15 |
| gmb | Okay. | 14:15 |
| gmb | If I really have to. | 14:15 |
| gary_poster | danilos, I'm ready for our call whenever you are | 14:17 |
| danilos | gmb, I am getting thoroughly confused with these branches, so I find it best and easiest to check with a known-good slate :) | 14:17 |
| danilos | gary_poster, ready | 14:17 |
| gmb | danilos: Well, it passes :) | 14:17 |
| gary_poster | ship it! | 14:18 |
| gmb | Haha | 14:18 |
| danilos | gmb, then it's for you :) | 14:18 |
| gmb | Righto. | 14:18 |
| danilos | gary_poster, lp:~danilo/launchpad/bug-772763-edit-subscription | 14:25 |
| gmb | danilos, gary_poster: jml's lightning talk is here, by the way: http://www.youtube.com/watch?v=4Cxs9OHIBcs#t=0h17m34s The cheers will please you immensely, I have no doubt. | 14:30 |
| gary_poster | cool, I look forward to it :-) | 14:30 |
| gary_poster | video was cool | 14:49 |
| gary_poster | danilos, ok, I've stared at the branch enough to have questions :-P . Lemme know when you have a minute for them | 15:24 |
| gary_poster | Skype would probably be fastest if that is ok with you | 15:24 |
| danilos | gary_poster, ready now | 15:30 |
| danilos | except that skype is not running :) | 15:30 |
| gary_poster | http://pastebin.ubuntu.com/610640/ | 15:31 |
| bac | i mistyped and discovered http://launchpad.de | 15:45 |
| gary_poster | heh | 15:45 |
| gary_poster | I wonder what, if anything, will happen with Apple's "Launchpad" name | 15:45 |
| gary_poster | bac, when you have a moment, https://code.launchpad.net/~gary/launchpad/bug-772763-edit-subscription/+merge/61782 could use a review. danilos <- that's your branch. I'm going to go for a walk, then I'll start into bug 772754 | 16:20 |
| _mup_ | Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing <story-better-bug-notification> <Launchpad itself:In Progress by gary> < https://launchpad.net/bugs/772754 > | 16:20 |
| danilos | gary_poster, cool | 16:20 |
| danilos | gary_poster, I'll be leaving in 10, so I'll leave a message here if I don't get to the phase of ec2 landing stuff (all in review) | 16:20 |
| gary_poster | danilos, sounds good. ttyl | 16:21 |
| danilos | gary_poster, part1 (server-side stuff) in ec2 land, JS still in review (https://code.launchpad.net/~danilo/launchpad/bug-772763-remove-unmute-dialog/+merge/61780) | 16:32 |
| bac | hi gary_poster, danilos | 17:28 |
| bac | i'm exercising the unmute branch and when i unmute, the person's name is added to the subscribers list but 'No subscribers' is not removed | 17:29 |
| bac | gary_poster, danilos: i like the way you two are submitting each other's work. is that collaboration or just an attempt to confuse me? :) | 17:37 |
| gary_poster | bac, it's mostly about confusing you, of course | 17:50 |
| gary_poster | which unmute branch, bac? They are all unmute | 17:50 |
| gary_poster | maybe the JS one? I don't remember dealing with that issue | 17:50 |
| bac | gary_poster: i was referring to the one danilo submitted | 17:52 |
| gary_poster | bac, ok cool, that's the JS one. Lemme look. | 17:52 |
| bac | namely https://code.launchpad.net/~danilo/launchpad/bug-772763-remove-unmute-dialog/+merge/61780 | 17:52 |
| gary_poster | right | 17:52 |
| gary_poster | bac, I agree. It may have to be another branch though :-/ | 17:53 |
| gary_poster | since I can't merge into danilo's | 17:54 |
| bac | ah, right. so you want to land it as is and then tackle a fix? | 17:54 |
| bac | or spin up a new branch and new MP? | 17:55 |
| gary_poster | bac, actually, how about this--yeah the second one. I'll make a branch dependent on this one, so you (or whomever) only have to look at the fix, and you can approve danilo's branch conditionally on the fix branch being the one that actually lands, maybe? | 17:56 |
| gary_poster | So IOW, I don't land danilo's branch | 17:56 |
| gary_poster | but we use the review as an incremental stepping stone to the one that I do land | 17:57 |
| bac | gary_poster: a-ok | 18:04 |
| gary_poster | cool thanks | 18:04 |
| gary_poster | bac: https://code.launchpad.net/~gary/launchpad/bug-772763-remove-unmute-dialog/+merge/61806 has the very small additional change needed. | 18:35 |
| bac | ok | 18:35 |
| bac | gary_poster: i'm on https://code.launchpad.net/~gary/launchpad/bug-772763-edit-subscription/+merge/61782 atm | 18:35 |
| gary_poster | cool, thanks bac | 18:36 |
| bac | gary_poster: this looks funny. must it be written like this? | 18:43 |
| bac | if not self_subscribed and not(is_really_muted): | 18:43 |
| gary_poster | heh, dunno, lemme look | 18:43 |
| gary_poster | bac, I assume you would prefer "if not self_subscribed and not is_really_muted:" ? | 18:45 |
| bac | yeah, having the not() look like a fcn call hurts my head | 18:46 |
| gary_poster | agreed, happy to change it bac | 18:46 |
| bac | okey doke. nothing else looks awry | 18:46 |
| gary_poster | cool, thank you | 18:46 |
| bac | a passive aggressive path to r=bac | 18:46 |
| gary_poster | heh | 18:46 |
| gary_poster | bac, I'd like a pre-imp call about https://launchpadlibrarian.net/71552495/all-in-one.png--in particular, how we use links objects in portlets and...if they can do what I want them to, and if they should be challenged as the "proper way" to do things. Are you completely swamped, or could you carve out 15 minutes soon? I'd be happy to time-box it. | 19:15 |
| gary_poster | I think you would be a good choice because you have experience with these portlet things, and you might have background from Curtis. | 19:15 |
| bac | gary_poster: give me a bit. say at :30? | 19:16 |
| gary_poster | bac, sounds good, thanks | 19:17 |
| bac | gary_poster: i don't understand the fix to https://code.launchpad.net/~gary/launchpad/bug-772763-remove-unmute-dialog/+merge/61806 | 19:19 |
| bac | i've verified it works | 19:19 |
| bac | i just don't get it | 19:19 |
| gary_poster | bac, we already had a function to add a name to the list, and had logic to remove the "no subscribers" node. However, for some reason the function felt that this was unnecssary when you were subscribing the current user. I have no idea why. I would suspect that, prior to my change, "no subscribers" would have been left around when you subscribed yourself, in addition to unmuting yourself. I did not verify this | 19:23 |
| bac | so the anim run just makes it happen? | 19:23 |
| gary_poster | My change simply says "we are adding a user, so in *all* cases, let's make sure that 'no subscribers' is gone" | 19:24 |
| gary_poster | oh, no | 19:24 |
| gary_poster | The anim is just an extra bit of polish | 19:24 |
| gary_poster | We don't have to have it | 19:24 |
| bac | oh, i see, you moved it out of the conditional | 19:24 |
| bac | i missed that part | 19:24 |
| gary_poster | yeah | 19:24 |
| * bac feels better | 19:24 | |
| gary_poster | :-) | 19:24 |
| gary_poster | sorry for not making the change clearer | 19:25 |
| gary_poster | (The anim just adds the green flash on the link) | 19:25 |
| bac | gary_poster skype? | 19:34 |
| gary_poster | yeah thanks | 19:34 |
| bac | gary_poster: did you see francis marked the accessibility bug critical? | 20:51 |
| gary_poster | bac, yeah, and he told me he would. We can address it as part of our normal bug rotation duties | 20:51 |
| bac | gary_poster: ok | 20:52 |
| gary_poster | bye. have a great weekend | 22:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
