/srv/irclogs.ubuntu.com/2011/05/24/#launchpad-dev.txt

lifelesssinzui: you will laugh and cry at bug 61835600:09
_mup_Bug #618356: Person-picker takes a very long time consistently <disclosure> <lp-blueprints> <pg83> <sprints> <timeout> <Launchpad itself:Triaged by launchpad-teal-squad> < https://launchpad.net/bugs/618356 >00:09
lifelesssinzui: full text queries without a full text index are slow.00:09
sinzuilifeless: we are discussing this right now actually. Why do we do a fti searching for a person? I think we care about displayname, not homepage_content00:11
lifelesssinzui: the simplest thing would be to drop the fti lookup00:11
lifelesssinzui: but if we do /any/ fti lookups on person we will need that index00:11
lifelesssinzui: anyhow, its in your squads court; I just dug into the query from curiosity; I hope that helped.00:16
sinzuilifeless: It was a very timely query. Thank you very much00:16
wallyworld_huwshimi: http://people.canonical.com/~ianb/person-picker-extra-detail.png00:18
huwshimiUgh, my wifi is flaky00:21
LPCIBotProject windmill-db-devel build #312: STILL FAILING in 1 hr 10 min: https://lpci.wedontsleep.org/job/windmill-db-devel/312/00:38
wgrantlifeless: How does it not explain the cause?00:52
wgrantIt says there are already binaries published in the archive.00:52
wgrantIt is less than completely transparent.00:52
wgrantBut it *does* explain the cause for anybody who knows anything about Debian archives in the last 10 years.00:53
lifelesswgrant: its sufficiently opaque to confuse doko.00:53
wgrantTrue.01:03
wgrantWhy does an Icelandic volcano always erupt like a month before we go to Europe? :/01:14
wgrantDie, git, die.01:28
wgrantWedonotneedaForkbuttondammit01:28
lifelessman, users get *so* confused02:48
lifelessbug/15870202:48
wgrantYes.02:50
wgrantBut this user has a bit of karma.02:50
wgrantIt's not the normal confused brand new user case.02:50
spivAh, heh.02:50
lifelessno02:51
lifelessits a confused established user02:51
spivI think they meant question 158072?02:51
spivEr, 158702.02:51
lifelesswow03:08
lifelessbug queries with structuralsubscriptions in the are -really- slow03:08
lifelessstill running03:11
lifelessstill running03:13
lifeless!03:13
StevenKlifeless: When doing the initial work for populate-spr-changelogs, the initial query took 65 *minutes* on DF03:18
LPCIBotProject windmill-devel build #124: STILL FAILING in 1 hr 19 min: https://lpci.wedontsleep.org/job/windmill-devel/124/03:21
lifelessheh03:53
lifelessthis is up at 45 now03:53
lifelessyou can see why its timing out in prod03:54
lifeless Aggregate  (cost=816866.73..816866.74 rows=1 width=0)03:59
mwhudsonthat's quite a lot of milliseconds04:04
lifelessthats cost, not ms04:04
lifelessrunning it the time was past  45 minutes when I nuked it04:05
lifelesscost may be ms, but its actually not comparable between pg instances unless - all- the config knobs are identical (including CPU)04:05
mwhudsonah04:05
lifelessplans are evaluated by cost04:06
lifelessthe cheapest is chosen04:06
lifelessthe knobs say things like 'a block of random IO costs X'04:06
lifelessand an in-memory sort of width 500 length 200 costs Y04:07
LPCIBotProject windmill-devel build #125: STILL FAILING in 50 min: https://lpci.wedontsleep.org/job/windmill-devel/125/04:11
sinzuiwgrant: ping04:21
wgrantsinzui: Hi.04:22
sinzuiwgrant: I want to talk about bug 56138004:22
_mup_Bug #561380: /builders page is oopsing <boobytrap> <disclosure> <lp-soyuz> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/561380 >04:22
wgrantI'm not sure it requires any discussion, but OK :)04:23
wgrantThe fix is very clear and simple.04:23
lifelessdelete the page yeah ?04:24
sinzuiwgrant: Since the template is just reporting current state; I propose PackageBuildFormatterAPI return either nothing, , state thee is nothing to see, or the link the build obfuscating the private team+ppa,04:25
wgrantsinzui: We already have facilities to show private BPBs.04:25
wgrantWe just need to extend that to SPRBs.04:25
wgrantlifeless: Why?04:25
lifelesswgrant: I have a massive headache; my sense of humour gets distorted at such times04:26
sinzuiI do not see the formatters for that.04:28
wgrantlifeless: I suspected it may have been an attempt at humour, but you are not unknown for making radical proposals.04:29
wgrantsinzui: Let me see.04:33
wgrantOh, I see.04:34
wgrantThis is different from the SPRB bug.04:34
wgrantSo, yes, Julian's analysis is correct.04:35
wgrantBut hmm.04:35
wgrantI think this may be fixed.04:36
sinzuiwgrant: PackageBuildFormatterAPI think it is checking that the user can see it:04:36
sinzuiif not check_permission('launchpad.View', build):04:36
sinzui            return 'private source'04:36
wgrantIPerson's launchpad.View adapter allows commercial admins to see the person.04:36
sinzuiBut that guard predates the bug reports04:36
wgrants/the person/private teams/04:36
wgrantSure, in this case he can view the build because he can view the archive because he's a commercial admin.04:36
wgrantBut the archive is owned by a private team.04:36
wgrantWhich he can see (at least now).04:37
wgrantI guess the adapters have changed since PMTs were removed.04:37
wgrantBut let's see.04:37
wgrantHeh.04:38
wgrantYes.04:38
wgrantYou fixed this in August.04:38
wgrant11327.2.1 "Allow commercial admins to view private teams."04:38
sinzuiYes, but was bigjools the victim here?04:39
=== almaisan-away is now known as al-maisan
wgrant"You are logged in as Julian Edwards."04:40
wgrantUnless we have another Julian Edwards.04:40
sinzuiHe has also been a commercial admin for more that a year, so how did he see it04:40
wgranthmm?04:40
wgrantThis was filed in last April.04:40
wgrantWhen he could see all private PPAs due to his commercial adminity.04:40
wgrantBut couldn't see private teams.04:40
sinzuiSorry04:40
sinzuiI have no ind04:40
sinzuimind04:40
wgrantNo ind!04:41
* sinzui shuts up04:41
wgrantThis sounds disastrous.04:41
* wgrant closes ze bug.04:41
sinzuiViewBinaryPackageBuild looks sensible too04:41
wgrantYeah.04:42
wgrantSPRBs into private archives may still be problematic.04:42
wgrantBut BPBs are fine.04:42
wgrant(assuming the security adapters aren't insane, and in this case they were -- access to a subordinate object was granted without having access all the way up to the root)04:42
wgrantjtv: The conventional way to avoid this discussion is just to use ~janitor.04:43
wgrantjtv: I think that may be prudent here.04:43
jtvwgrant: been over that.  No.04:43
wgrant:(04:43
* jtv relocates04:44
wgrantlifeless: Any ideas on that maybe-bad rev?04:46
wgrantI've tested it in a few browsers and it seems to work OK.04:46
wgrantAnd bac did not respond to my cries last night.04:46
wgrantAnd the feature is as-yet unreleased.04:47
wgrantSo I think I shall qa-ok it and the two other things and organise a deployment.04:47
wgrantHm.04:47
wgrantAlthough we are LOSAless.04:47
wgrantSo I guess it doesn't matter all that much.04:47
wgrantlifeless: You were saying earlier that person.fti was unindexed, but I see a gist index on it.04:59
wgrantsinzui: Still around?05:19
sinzuiyes05:19
lifelesswgrant: where are you looking05:19
wgrantsinzui: I am attempting to install Balsamiq Mockups. They have am amd64 .deb, but I cannot locate an amd64 build of Adobe AIR. Am I missing something here, or must I hack the i386 one?05:20
lifelesswgrant: revert the bad rev05:20
wgrantlifeless: Huh, you're right, it's not on the production DB.05:20
wgrantBut is on dev.05:20
StevenKwgrant: http://kb2.adobe.com/cps/521/cpsid_52132.html05:21
wgrantlifeless: :(05:21
sinzuiyuck.05:21
lifelesswgrant: the different between theory and practice05:21
wgrantStevenK: BURN05:21
sinzuiI am using i38605:21
StevenKsinzui: The 90s called, they want their archtag back05:21
wgranti386 VM time.05:21
lifelessits ironic to be using proprietary software to build open source software05:21
lifelessby ironic I mean saddening05:22
wgrantlifeless: *cough splutter* Launchpad *cough cough*05:22
sinzuiStevenK: I gave up on 64 when I realised that the apps were only using more memory  and not providing more performance05:22
StevenKwgrant: By various hacks that I don't want to recall, I got AIR to install on amd6405:22
wgrantStevenK: Yes, but I probably don't want Adobe crap outside a VM anyway.05:23
jtvwgrant: at least we fixed Launchpad.05:23
StevenKsinzui: But it's a complete waste if you have more than 4GiB RAM05:23
wgrantjtv: This is true.05:23
sinzuinot soon enough for me. I was tired if having deadlines with a broken environemnt05:23
jtvStevenK, wgrant: mind if I kick df for an upgrade?05:24
StevenKYES05:24
wgrantI believe StevenK is currently touching it in bad ways.05:24
jtvwgrant: mind if I kick StevenK for an upgrade?05:24
StevenKI'm using it, hands off05:24
jtvWell keep the door open just in case.05:24
jtvOr do you mean "I'm using it.  Hands off."?05:25
StevenKI updated the code before lunch, so about 2 hours ago05:25
jtvLooks like that was still well before my overnight landing percolated through.  :(05:26
lifelesswgrant: so bac's rev05:27
lifelesswgrant: I think it should be reverted05:27
lifelesswgrant: i said as much in the bug05:27
wgrantI shall revert it.05:27
wgrantYou did.05:27
jtvAhhh what luck it was merely the version number that was out of date—my branch is in there.05:29
jtvStevenK: mind if I sync a few oneiric packages on df?05:29
StevenKjtv: Yes05:29
jtvhmmmgrr05:29
StevenKI'm playing with the package copier05:30
jtvAh!05:30
jtvThen maybe you can just tell me what I need to know.05:30
jtvIn fact, looks like (once I got past the timeouts just now) I've found an example of just the display I was trying to reproduce.  Thanks05:30
wgrantGnargh testfix.05:33
wgrantlifeless: Can we disable the rabbit test pls?05:33
StevenKs/test //05:33
lifelesswgrant: gavin has an improvement he is/has landed05:34
wgrantStil fails.05:34
wgrant+l05:34
lifelesswgrant: its possible that the failure is due to that improvement, or that the improvement hasn't reached bb05:34
wgrantNo, this is clearly a failure with the new code.05:34
wgrantHard to tell if it's the same failure that we've hit 20 times in the last week.05:34
wgrantBut concealed by the improvement.05:34
lifelessso sure - critical bug for disabled test, etc05:35
wgrantYou know it's failing probably near half the buildbot runs, right?05:39
lifelesswgrant: I just agreed to disabling it!05:40
wgrantYes, but your suggestion that the improvement caused the failure suggests that it hadn't already been failing every second run for weeks.05:40
lifelesswgrant: I didn't realise it was that flaky05:41
wgrantIt's actually only 1/3. But yeah.05:41
wgrantstill not great.05:41
lifeless                     ->  Bitmap Index Scan on bugtask__distribution_sourcepackage__heat__idx  (cost=0.00..567.17 rows=17172 width=0) (actual time=141.166..141.166 rows=503359 loops=164)05:41
lifelessrepeated 146 times05:42
wgrantFun.05:42
lifeless-> structural subscription scaling fail05:42
lifeless70M rows processed to get 2.5K results05:42
wgrantHmm.05:42
wgrantNot sure how best to disable this.05:42
wgrantSince it's the only test in the class.05:42
wgrantAnd the only class in the file.05:42
wgrantI guess I should rename the file.05:42
StevenKYeah, rename the file05:42
lifelesshih05:43
lifelessjust rename the test05:43
wgrantNo, then the testrunner bitches that there are no tests in the class.05:43
wgrant:(05:43
lifelesswell05:43
lifelessthats a stupid freaking test runner then isn't it05:43
lifelessdoes it support skips ?05:43
wgrantI don't think so.05:43
lifelessactually05:43
lifelesstesttools does05:44
lifelessjust do a skip05:44
lifelessself.skip('disabled')05:44
wgrant@skip?05:44
lifelesssee what happens05:44
wgrantHeh.05:44
wgrantOK.05:44
lifelessor that; 6 billion ways to spell it05:44
wgrantIt appears to succeed, but at least does not fail.05:45
wgrantThanks.05:45
lifelessnot the plan your doctor ordered:05:47
lifeless Nested Loop  (cost=2.76..17359385328490.43 rows=247357031677542 width=4)05:47
wgrant.....05:48
lifelessexactly05:51
StevenKIs that 247 trillion?05:52
lifelesswho knows05:52
StevenKLooks like it. I don't think we have that many rows in our entire db05:53
lifelessstructsubs05:53
lifelesswin05:53
lifelessgot it down to 25 seconds so far05:53
wgrant247 trillion, yeah. Awesome.05:54
lifeless25 seconds05:54
lifelessbah05:54
lifeless1505:54
lifelessserver team has 146 subscriptions05:54
lifelessthe live plan is evaluating *each one* with 5 bugtask table index bitmap scans05:55
lifelesssorry, 164 subs05:56
wgrantAdobe crap safely contained in a VM :)05:57
wgrantI like how the AIR download page tells you you'll probably need to turn off antivirus software.05:57
lifelesswin!05:59
lifelesshah, this subscription query is broken anyhow06:15
wgrantOh?06:18
lifelessactually a sub limit06:19
lifelesscan't do series + package06:19
wgrantHm.06:46
wgrantValidPersonOrTeamVocabulary is stupid.06:46
StevenKjtv: Did you copy alien-arena-data into oneiric-updates?06:51
jtvStevenK: yesterday (though I didn't get to specify a pocket)06:52
StevenKjtv: It's component is non-free06:52
wgrantBecause copies don't do overrides.06:52
StevenKYet06:52
wgrantValidPersonOrTeamVocabulary is pretty nice.06:53
jtvStevenK: did I cause a problem?06:53
StevenKYes06:53
jtvI'm sorry about that... any way in which it could have been prevented?06:53
wgrantIt seems to take the 100 most relevant results, then order them by displayname instead of relevance.06:53
wgrantHow useful.06:53
StevenKjtv: By not doing that06:54
jtv*And* get my Q/A done?06:54
StevenKBy undoing it06:54
StevenK:-)06:54
* StevenK re-publishes -updates06:55
wgrantOr by copying stuff that's in Debian main.06:55
wgrantAnd not contrib/non-free.06:55
wgrantThat's the critical bit.06:55
jtvWhy is it specifically contrib and non-free that are a problem?06:55
wgrantBecause they're not in Ubuntu.06:56
StevenKBecause Ubuntu doesn't have those components06:56
wgrantThe other Debian component is main, which Ubuntu has too.06:56
lifelesswgrant: win!06:56
jtvThen presumably the copy simply went into main?06:56
wgrantjtv: No, because that needs overrides.06:56
wgrantCopies don't do overrides.06:56
jtvSo then what happened instead?06:57
wgrantIt went into non-free.06:57
jtvSo it created a component?06:57
StevenKAnd alien-arena is in contrib06:57
wgrantit created an invalid publication.06:57
wgrantBecause that component is not publishable in that archive.06:57
jtvI suppose that will be fixed at some point though?06:58
* StevenK re-publishes -updates AGAIN06:58
wgrantlifeless: It also seems to retrieve the top N private teams separately, then merges the two and drops all the FTI info.06:58
wgrantThat whole function makes my head hurt.06:58
StevenKjtv: Copies need overrides, yes. I'm QAing it now06:58
StevenKWhich this mess didn't help at all06:58
wgrantQAing the first step of it.06:59
jtvVery sorry about that; I'll coordinate with the others next time I copy a package.06:59
StevenKOr pick a package that is in Debian main, not contrib or non-free, like wgrant said07:00
wgrantProprietary software destroys the world, again!07:00
StevenKBwaha07:00
jtvStevenK: I don't think that'll help as much: this time it's a matter of figuring out what Debian component it's in (which I guess I'd find out on packages.debian.org?) but once this particular bug is fixed, it'll be something else.07:02
StevenKjtv: rmadison is your friend07:03
jtvIt may say so on youface or whatever your kids use these days, but I'm not aware of the lady in question.07:04
StevenK% rmadison -u debian -s sid alien-arena07:04
StevenK alien-arena | 7.51-2 | sid/contrib | source, amd64, armel, hurd-i386, i386, ia64, kfreebsd-amd64, kfreebsd-i386, mips, mipsel, powerpc, s390, sparc07:04
wgrantAh, alpha/hppa are actually dead now?07:05
* jtv sheds tear for alpha07:05
wgrantOr at least on ports.07:05
StevenKThey've moved07:06
=== al-maisan is now known as almaisan-away
LPCIBotProject windmill-devel build #126: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/126/07:22
jtvHi stub!  Want to try the Ubuntu Café for going over that patch?07:24
stubUrgh.07:24
stubStill booting.07:24
stubWhere is it btw?07:25
wgrantThe BranchRevision.id doompatch?07:25
stubThe footgun, yeah.07:26
wgrantIt looked simple enough, but zomgscary.07:26
stubWith luck, it will give our toenails a lovely trim.07:26
StevenKAnd not our toes?07:26
jtvHa ha, StevenK, always the optimist07:27
* jtv relocates07:36
=== stub1 is now known as stub
=== stub1 is now known as stub
lifelessoh man, that was a tough one.07:45
lifelesswgrant: if you're interested - https://bugs.launchpad.net/launchpad/+bug/787294/comments/1107:45
_mup_Bug #787294: Person:+patches timeouts <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/787294 >07:45
=== stub1 is now known as stub
lifelessmy headache really didn't help - hard to think well about problems with a pounding going on07:45
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
adeuringgood morning08:48
allenapwgrant, lifeless: We could try increasing the time-out. I didn't change that.09:04
allenapRe. the RabbitMQ fixture test.09:04
wgrantHmm.09:04
allenapwgrant: The time-out is only 5 seconds right now, which is fairly tight. I think we should put it up to 15 seconds and see what happens.09:09
mrevellGuten morgen09:18
LPCIBotProject windmill-devel build #127: STILL FAILING in 1 hr 8 min: https://lpci.wedontsleep.org/job/windmill-devel/127/09:20
=== almaisan-away is now known as al-maisan
=== gmb changed the topic of #launchpad-dev to: Performance Tuesday! | https://dev.launchpad.net/ | On call reviewer: gmb | https://code.launchpad.net/launchpad-project/+activereviews | Critical bugs:214 - 0:[######=_]:256
LPCIBotProject windmill-devel build #128: STILL FAILING in 1 hr 17 min: https://lpci.wedontsleep.org/job/windmill-devel/128/11:02
=== al-maisan is now known as almaisan-away
lifelessoh yay11:09
lifelesslinkin invites sent to lp bugs11:09
nigelbheh11:16
nigelbhow long does a fix take to land from qa-staging to production?11:17
nigelb(after being verified)11:17
bigjoolsnigelb: depends how quickly someone presses the button11:18
nigelbbigjools: Ah, so just wait some more I guess :)11:18
bigjoolsand what other things need QA11:18
StevenKnigelb: Which revision?11:19
nigelbStevenK: "Fixed in stable r13094"11:19
StevenKAh, you're stuck behind r13092 which is qa-bad11:20
StevenKThere was a revert happening at some point11:20
StevenKgmb needs to QA r1309611:20
StevenKAnd allenap needs to QA r1310111:21
nigelbah, that's 13108, revert 1309211:21
StevenKRight, it likely hasn't hit qastaging yet11:21
StevenKAh11:21
StevenKIt has11:21
StevenKMy deployment report was old11:21
allenapStevenK: I /think/ I've done that one.11:21
nigelbI was looking at http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/changes11:22
StevenKnigelb: And you need to QA r13106 :-)11:22
nigelbStevenK: that landed a few hours back, didn't get time :D11:22
StevenK"[testfix][rs=wgrant][rollback=13092] Disable TestRabbitFixture.test_start_check_shutdown. Its days of destroying the test suite are over."11:22
* StevenK cackles11:22
nigelbhaha11:23
StevenKnigelb: So, to answer your question: "It depends"11:23
nigelbRight, so I think I'm one of the people blocking it at this point :)11:23
StevenKThere is a bunch of QA to do11:24
nigelb:)11:24
nigelbI guess I have to wait until 13108 to get QA'd because of 13092.11:24
StevenKr13108 won't get QA'd, it's a rollback11:25
StevenKIf you mean up to r13108, that's different.11:25
jmllifeless: hi11:26
nigelbI meant upto.11:26
nigelbBah, my rev isn't seeming to work.11:26
StevenKnigelb: Right, then yes, you do.11:26
nigelbHow do I know something is in qastaging for sure?11:26
nigelbwait, PQM got done with it a minute back :/11:27
lifelessjml: hi11:27
lifelessnigelb: when its on qastaging the tagger will notice and tag the bug11:27
bigjoolsnigelb: check the revision number that it landed on11:27
bigjoolscompare with the one at the bottom of every page11:28
nigelblifeless: ah, yes. Its tagged.11:28
nigelbbigjools: hrm, that seems to indicate its landed. But it isn't working. *whee* QA fail.11:28
bigjoolsnigelb: we only flag qa-bad if it should block rollout11:28
nigelbbigjools: Its not doing anything harmful, just needs more fixing.11:29
nigelbhrm, okay.  This is really random.11:29
nigelbhttps://blueprints.qastaging.launchpad.net/ubuntu/+spec/test-blueprint-mark/11:29
nigelbI don't even know what order its getting sorted :(11:29
nigelbIts working "mostly" except for the adicarlo name.  I suspect it has something to do with python's sort function.11:30
StevenKYou probably should have used .order_by() on a ResultSet?11:32
nigelbI used sort because that's what's used in the sprints too.11:32
spivnigelb: Python's sort is entirely sensible, except that the default ordering for objects that don't define how they should be compared is arbitrary (i.e. based on memory address)11:34
nigelbBah, its a problem with using sort(), it clubs all the capitals first and the small letters later.11:34
jmllifeless: hello. I'm at a cafe, but am willing to try some sort of voice comms if you're up for it11:35
lifelessthat sounds great. pick your poison11:35
lifelesssky.net?11:35
spivnigelb: Well, that's how str/unicode's sort order is defined :)11:35
spivnigelb: sort(seq, key=unicode.lower)11:35
spivnigelb: or as StevenK says use order_by on the result set11:36
LPCIBotProject windmill-db-devel build #313: STILL FAILING in 1 hr 10 min: https://lpci.wedontsleep.org/job/windmill-db-devel/313/11:36
nigelborder_by ?11:36
nigelbisn't that a query thing?11:36
jmllifeless: ok.11:36
spivnigelb: yes.  The data originates in a db query after all.11:37
nigelbspiv: yeah, but its a cached property, so we end up having to mutate that list every now and then when someone subscribes newly.11:37
bigjoolsthat's probably the most efficient place to do it11:37
nigelbhttps://code.launchpad.net/~nigelbabu/launchpad/90628-spec-sub/+merge/6200311:38
nigelb^^ that's the branch with the merge changes for this one11:38
jmllifeless: hello can you hear me speaking?11:38
jmllifeless: I can hear you11:39
jmllifeless: my mic isn't coming up in sound config, even though it's correctly configured.11:39
spivnigelb: well I guess just add .lower() to the sort key func, e.g. key=lambda sub: sub.person.displayname.lower()11:40
nigelbspiv: aha, I shall test that when I get to my computer running LP and propose merge again :)11:40
nigelbthis means I should add a test case for this.11:40
spivnigelb: I'm so glad you said that :)11:41
bigjoolsgmb: I have a branch waiting for your perusal if you're reviewing please?11:42
gmbbigjools: Sure. I'll be free to look in about ten minutes11:42
bigjoolscheers, no rush11:42
nigelbspiv: yay, it works locally. So I need to fix and push them both.11:45
nigelbSorry for breaking it :)11:46
=== henninge is now known as henninge-lunch
=== almaisan-away is now known as al-maisan
jmllifeless: http://blog.launchpad.net/general/a-cream-pie-in-the-face12:06
gmbbigjools: r=me12:10
bigjoolsgmb: cheers12:10
bigjoolspie chart - rofl12:10
=== henninge-lunch is now known as henninge
* gmb -> lunch12:33
wallyworld_benji: i've checked a mp your way. it's a redo of a recent bug fix you did to fix an issue with the picker widget. the original fix broken some windmill tests. the detail is in the mp. thanks in advance for looking :-)13:05
benjiwallyworld_: sure, I'll take a look13:06
wgrantwallyworld_: Doesn't that make the names ambiguous?13:09
wallyworld_wgrant: no. the field names are unique and hence the ids are too. uniqueness has never ever been an issue afaik13:10
wallyworld_the real issue in the bug report was the invalid chars13:10
wgrantwallyworld_: It looks to me like that just suppresses invalid characters.13:11
wgrantIf there are two names differing only by invalid characters, they are ambiguous.13:11
wallyworld_yes, that's all that's needed13:11
wallyworld_as i said, uniqueness has never been an issue, unless i am totally wrong :-)13:12
wgrantI don't see how it isn't an issue now...13:12
wallyworld_wgrant: i don't think tat's a real issue?13:12
wallyworld_we've never had bugs due to uniqueness13:13
wallyworld_or lack thereof13:13
wallyworld_in node ids for the picker widgets13:13
wallyworld_unless i'm missing something13:13
wgrantThe original change was made because some package name had a . in it.13:14
wgrantWhich means that package names are used in IDs.13:14
wallyworld_it was a "+"13:14
wgrantOr that.13:14
wgrantOne of them13:14
wgrantEven so.13:14
wgrantYou're now string that out.13:14
wgrantWhich means that a package named 'foo' and a package named 'foo+' will conflict.13:14
wallyworld_the package was gtk+13:14
wallyworld_will that be an issue in practice?13:14
wallyworld_i could replace the "+" with another char13:15
wgrantCan we not go for "probably won't break in practice if we don't have an unlucky package combination", please? :)13:15
wallyworld_i could get hit by lightning too, but the chances are not worth worring about :-)13:15
wgrantYeah, but this is easily avoidable and *will* break at some point.13:16
wallyworld_but anyway, if i replace the invalid chars with a  "-" or something, that should suffice13:16
wgrantCan't we urlencode it or something?13:16
wallyworld_probably13:17
wgrantThat's likely to be less ambiguous.13:17
wgrantReplacing them all with a constant character is still ambiguous.13:17
benjiwgrant: my original fix was to urlsafe_b64encode it13:17
wgrantRIght.13:17
wallyworld_the main point is that for tests, we need to be able to determine the id from the field name13:17
wgrantBut that's a bit too opaque.13:17
benjiyep, I see that now13:17
wgrantI don't have a problem with it, but it is slightly awkward for tests.13:17
wallyworld_more than slightly :-)13:17
wgrantThe original code was probably written when someone thought along the lines of "pfft, who is going to put a + in a package name"13:18
wgrantWe should make our code correct.13:18
wgrantNot working in most cases that we can conceive.13:18
benjiI propose we replace the non-ID-safe characters with string equivalents plus the escaping char; so "gtk+" would become "gtk-plus-" and "foo-bar" would become "foo-dash-bar"13:20
wallyworld_benji: that sounds reasonable. it won't affect the existing tests because we don't put such chars in there in the first place for testing13:20
benjia definate plus ;)13:21
wallyworld_and the node ids are still easily discoverable from the field names13:21
wgrantwallyworld_: You can't identify the nodes in the tests some other way?13:21
wallyworld_not easily13:22
wgrantAttempting our own encoding method is somewhat fraught with peril.13:22
benjihow about field names?  the base64ification was only for IDs13:22
wallyworld_and when one views page source, b64 "gibberish" is pretty yucky to look at13:22
wgrantYou could even reuse the tiny base63-encoding helper.13:22
wgrantIn the tests.13:22
wgrantWhen generating field names.13:22
wgrantThat way we have correctness and not too terrible tests.13:22
wallyworld_yik, why go to all that bother13:22
wallyworld_yuk13:22
wgrantBecause it's correct and reasonably clean.13:23
wgrantUgly source.13:23
wallyworld_i like benji's idea :-)13:23
wgrantBut cleaner than implementing our own dodgy encoder.13:23
wgrantOnly [A-Za-z0-9_:.-] are permitted in ids.13:23
wgrantSo you're going to have to manually encode a lot of stuff.13:24
wallyworld_benji: wrt field names, if they're dynamically generated from some data then we may still have an issue there13:24
wallyworld_wgrant: we could just replace with the ascii code number then13:25
benjiwallyworld_: try this one on for size: if the ID has no disallowed characters then we do nothing, if it does we base64 encode it; that way all the tests work and we still cover all the bases13:26
wallyworld_that may work :-)13:26
wallyworld_benji: it's not just current tests, it's also new ones that need to be easy to write :-)13:27
wallyworld_if ^%^@!%^%^@! windmill were not turned off then we wouldn't be having this conversation :-(13:28
benjiright, but I don't think we'll be doing too many wonky things in tests, so it won't happen very often -- back to your lightning argument ;)13:28
wallyworld_actually, i think it's the other way around. in tests, we have simple field names and we need to be able to easily know what the corresponding "show widget" element is called13:29
wallyworld_for some tests13:30
wallyworld_that need to poke that node13:30
wallyworld_benji: i'm tired now so i'll very likely rework the mp tomorrow morning13:31
benjiwallyworld_: have a good rest, re. "the other way around.": I might have miscomunicated, I intended the tests to never need to encode and only encode in real life when neccesary13:33
wgrantwallyworld_: Sorry to pedantic, but I don't think it's a really great idea to, after fixing a bug which was caused by code not handling the whole input domain, replace the good fix with one that is known not to handle the whole input domain, and presume it will be good because users won't do crazy things.13:33
wallyworld_benji: yes. i think we're both on the same page13:33
wgrantIf you are relying on users not doing crazy things, you probably have a bug.13:33
=== ihateyou1oo is now known as elmo
wgrantAnd someone will find it.13:34
wallyworld_wgrant: can't argue your points. it's been a good discussion thanks. i'm happy we've converged on a solution that's easily to implement that achieves the goals13:35
wgrantYup.13:35
benjiwgrant: the idea was to not base64 encode unless there is an invalid character in the ID, that way the tests will be fine and we'll still cover the real-world corner cases13:35
wgrantSounds reasonable.13:35
henningeadeuring: Hallo! ;)13:56
henningeadeuring: my laptop is blocked branching LP trunk ...13:56
henningeadeuring: I still have to install mumble13:56
adeuringhenninge: ok...13:57
henningeadeuring: oh, works13:57
* henninge tried to use software center but that did not start13:57
LPCIBotProject windmill-db-devel build #314: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-db-devel/314/14:07
deryckMorning, all.14:20
deryckabentley, adeuring, henninge -- you guys done with standup?14:20
abentleyderyck: morning, yes we are.14:20
deryckok, cool.14:21
henningeHi deryck!14:21
derycksorry about running late.14:21
deryckThanks for going ahead with it.14:21
deryckhenninge, bug 785637 is still marked in progress, but the linked branch is merged.  Has it passed buildbot yet?14:26
henningen14:26
henningeo14:26
henningederyck: it's in there now14:27
derycko14:27
deryckk14:27
deryck;)14:27
henninge;)14:27
jcsackettwallyworld: it14:29
jcsackettit's sort of shocking to wake up to so many cards moved across kanban. :-P14:29
jml:)14:30
bigjoolsI hope they were all pie-critical?14:31
deryckabentley, ready when you are.14:32
abentleyderyck: Coming...14:32
derycknp14:32
jcsackettbigjools: alas, we're on feature work, which doesn't hit the pie-critical queue.14:32
jcsackettor at least, doesn't hit it very often.14:32
bigjoolsa crying shame14:32
LPCIBotProject windmill-devel build #129: STILL FAILING in 1 hr 18 min: https://lpci.wedontsleep.org/job/windmill-devel/129/14:35
sinzuijcsackett: do you have time to mumble?14:37
jcsackettsinzui: i do.14:38
* jcsackett fires up mumble14:38
nigelbsinzui: Well, yesterday's sort is not qa-ok per se.15:16
nigelbI need to do a .lower() of the element.15:16
LPCIBotProject windmill-db-devel build #315: STILL FAILING in 45 min: https://lpci.wedontsleep.org/job/windmill-db-devel/315/15:16
sinzuinigelb: yes, you can do that. qa-ok means it is safe to roll out. It will not break. So you can report an new bug and show me the fix.15:16
nigelbsinzui: awesome, I'll do that :)15:17
sinzuinigelb: did you see alejandra in the listing?15:17
nigelbsinzui: which one?15:18
sinzuiIn my qa, I saw alejandra was the last user listed because she was the only lowercase display name15:19
nigelbsinzui: ah, I did a qa with some other starting with lowercase 'a'15:21
LPCIBotProject windmill-devel build #130: STILL FAILING in 50 min: https://lpci.wedontsleep.org/job/windmill-devel/130/15:26
bigjoolsit'd be really nice if bug triagers tagged bugs please15:59
sinzuibenji: I may have stepped in your review of https://code.launchpad.net/~wallyworld/launchpad/better-popup-show-widget-name/+merge/62113 . The branch appears to reimplement FormattersAPI.css_id16:00
benjisinzui: no worries; that review was paused after some discussion here about better ways to accomplish the desired result; your contribution looks valuable too16:02
sinzuibigjools: +1. I constantly revisit recently triaged bugs16:02
bigjoolssinzui: me too16:03
bigjoolsto tag them :)16:03
benjisinzui: I don't understand how css_id avoids collisions.  What if you had two strings for IDification "foo@bar" and "foo&bar"; would they not both end up as "foo-bar"?16:05
sinzuibenji: it does not. You need to think, as is done in registry.browser.product.ProductView to create widgets for a listing or projects16:06
sinzuiProject names are unique so the engineer is responsible for choosing the namespace. Since the id is used in testing and scripts. The engineer should choose a name we can read and want to maintain16:08
benjisinzui: I meant even given a namespace prefix you could still have the same ID generated.  E.g., I choose "PREFIX-" as the prefix and there is a project named "foo@bar" and another named "foo&bar" and I want to represent both on the same page, they both will have IDs "PREFIX-foo-bar".16:09
sinzuibenji: I do not think "foo@bar" and "foo&bar" are real cases in Lp name  (unique id) rules.but I can image we could support transliteration instead of substution16:10
abentleygmb: Could you please review https://code.launchpad.net/~abentley/launchpad/handle-concurrent-lint/+merge/62139 and https://code.launchpad.net/~abentley/launchpad/retry-job/+merge/62145 ?16:11
gary_postersinzui, I have a user who is a spammer (all 10 comments are spam).  I marked comments as spam.  Should I deactivate the user next?16:11
gary_posterOr is there some other procedure16:11
sinzuigary_poster: If the user has zero karma, yes. If the user has karma, you should contact him and explain that we will suspend him if he does  not confirm he has taken control of his computer, browser, and email account.16:12
gary_postersinzui, 0 karma.  Cool, thanks.16:13
sinzuigary_poster: https://wiki.canonical.com/Launchpad/DealingWithSpam#Dealing with spam16:13
sinzui\o/ an easy one16:13
gary_posterbigjools, sinzui: triaging bugs: the only tags I know if that are particularly important are critical bugs that need to be tagged regression, timeout, oops.  Are there other important tags/actions?  If so, is this documented?16:14
gary_postersinzui, I thought we had a page, but should have checked on the internal wiki.  Thanks.16:14
LPCIBotProject db-devel build #575: FAILURE in 6 hr 1 min: https://lpci.wedontsleep.org/job/db-devel/575/16:14
bigjoolsgary_poster: I have a bunch of standard soyuz-related ones that I can educate maintenance teams about if you'd like16:14
bigjoolsideally on a wiki page for sure16:14
bigjoolshey, we used to have one of those :)16:15
sinzuigary_poster: I add tags that describe the objects in play and the kind of issue eg: ppa+email, teams-ui16:15
sinzuithe tag widget is very good at suggesting16:15
gary_posterbigjools...I guess.  CHR docs are already quite long in parts, and I'm encouraging my squad to do things to make things shorter (like Danilo is going to make the translations stuff much easier hopefully)16:16
bigjoolssinzui: it is indeed16:16
bigjoolsgary_poster: I agree with making things easier - this is why I really recommend the effort of tagging up front as it reduces pain later16:16
gary_postersinzui, bigjools, ok...we can make an effort.  It feels pretty ad hoc16:17
gary_posterok, I'll hold further comments till after we try it a while :-)16:17
sinzuigary_poster: it is because the user did not know how to describe the issue into domains and uses16:18
abentleygary_poster: does https://dev.launchpad.net/BugTriage help?16:19
gary_postersinzui: ...yeah, that seems to describe my general concern...16:19
gary_posterabentley, I don't see the word "tag" on that page, which is what I'm talking about16:19
abentleygary_poster: True, but "oops" "regression" and "timeout" are there...16:20
sinzuigary_poster: I was working with question emails a few weeks ago. I search for questions+email and located all the bugs related to the code I was in. I fix 4 critical bugs and 7 low bugs. The low bugs would not have been fixed if the bugs were not properly tagged16:20
gary_posterabentley, yeah, thanks.  those are the three I'm most comfortable with, and that our squad is working with already.16:21
gary_postersinzui, I'm not questioning value, but process.  But really, let's table this discussion until my squad has given it a try for a while.16:22
sinzuigary_poster: remember that you want to tag bugs my team create a disclosure to ensure my team works them. otherwise you get extra work :)16:22
gary_posterheh16:22
sinzuis/a/as/16:22
abentleygary_poster: I've added the word "tagged" to the page :-)16:27
gary_posterabentley, lol, cool, thanks16:27
bacgmb: time for a wee review?  https://code.launchpad.net/~bac/launchpad/bug-777789-2/+merge/6215016:28
gmbbac: Sure16:28
gmbbac: r=me16:30
bacgmb: thanks16:30
LPCIBotProject windmill-devel build #131: STILL FAILING in 1 hr 11 min: https://lpci.wedontsleep.org/job/windmill-devel/131/16:37
=== salgado is now known as salgado-lunch
LPCIBotProject windmill-db-devel build #316: STILL FAILING in 1 hr 16 min: https://lpci.wedontsleep.org/job/windmill-db-devel/316/16:47
jcsackettsinzui: http://people.canonical.com/~jc/images/lp-id-screenshots/16:48
jcsacketti'm working on something better on the profile page. the current inline versions are terrible.16:48
jcsackettbut i realized it was getting on towards noon so i thought i'd ping you with the versions i have.16:48
jcsackettsinzui: after seeing them rendered it, doing it with the "Launchpad Id:" thing looks terrible.16:49
sinzuijcsackett:  would the example be clearer if there were two comments from two different Jonathans?16:49
jcsackettsinzui: on the pickers shots?16:50
sinzuiand comments. I have seen two Toms posting messages in a bug conversation16:51
sinzuiI think we should not submit the Launchpad-Id example. It really is more annoying than explict16:51
jcsackettsinzui: sure, i can set those up. and i'll just kill the Launchpad-Id, as i concur. it's just terrible.16:52
sinzuijcsackett: and the picker examples were be more convincing of the problem we are solving if the users had hidden email addresses16:52
jcsackettsinzui: dig.16:53
sinzuijcsackett: I had not thought to put the Lp-id in the profile page title. I think users may expect that though. I look forward to user feedback16:55
=== beuno is now known as beuno-lunch
jcsackettsinzui: it seems we should probably standardize where we can if we go down this road.16:59
sinzuijcsackett: that is the intent of this  excercise17:00
* sinzui is reporting a bug about IRC nicks at this moment17:00
henningegmb: Hi! Here is an easy one to send you home with .... ;)17:10
henningehttps://code.launchpad.net/~henninge/launchpad/bug-683406-xss-ppa/+merge/6215817:10
gmbhenninge: Righto!17:10
jcsackettsinzui: updated http://people.canonical.com/~jc/images/lp-id-screenshots/17:26
sinzuijcsackett: that looks good to test17:27
jcsackettsinzui: cool. email the link to mrevell (who has now been pinged, if he's listening...)17:28
jcsackett>17:28
* jcsackett fails at typing.17:28
jcsackettjust assume that last bit was a question. :-P17:28
mrevellum17:28
* mrevell reads up a bit17:28
sinzuimrevell: we want to show Launchpad-id in comments and in the person picker so user are not confused by similar user display names. We do not know how to represent the Launchpad Id17:29
mrevellAhhh17:30
mrevellcool17:30
mrevellWow, that rocks.17:30
jcsacketti can email you a zip of these images if you would prefer, mrevell.17:30
mrevelljcsackett, Nah, the link on people.c.c is fine. Thanks. Sorry I was a bit slow off the mark.17:31
jcsackettmrevell: all good. :-)17:31
jcsackettsinzui: you wanted to mumble a bit again post-mockups, yeah?17:34
=== gmb changed the topic of #launchpad-dev to: Performance Tuesday! | https://dev.launchpad.net/ | On call reviewer: - | https://code.launchpad.net/launchpad-project/+activereviews | Critical bugs:214 - 0:[######=_]:256
=== Ursinha is now known as Ursinha-lunch
LPCIBotProject windmill-db-devel build #317: STILL FAILING in 51 min: https://lpci.wedontsleep.org/job/windmill-db-devel/317/17:38
=== deryck is now known as deryck[lunch]
=== salgado-lunch is now known as salgado
=== al-maisan is now known as almaisan-away
=== beuno-lunch is now known as beuno
=== deryck[lunch] is now known as deryck
jcsackettsinzui: ready to chat again when you are.19:16
sinzuijcsackett: I was just going to try to configure sip19:16
jcsackettsinzui: cool. i think i have sip setup. at least, i am told that i do.19:17
sinzuijcsackett: I have credentials I tested 4 years ago19:18
sinzuijcsackett: http://www.youtube.com/watch?v=r711rZ4M5K0 . The fish joke stars about 1 minute 25 into the scene, but the last part is missing. Mike returns empty handed and asks "What's this fish doing in my bed", and the rest ask, "What fish?"20:03
jcsackettthat's excellent.20:07
derycklifeless, ping20:08
LPCIBotProject windmill-db-devel build #318: STILL FAILING in 1 hr 11 min: https://lpci.wedontsleep.org/job/windmill-db-devel/318/20:09
bachi sinzui, do you know anything about bug 490767?20:12
_mup_Bug #490767: Cannot post a comment on an existing bug with Konqueror. <comments> <javascript> <lp-bugs> <Launchpad itself:Triaged> < https://launchpad.net/bugs/490767 >20:12
baclifeless mentions an email thread but i cannot find it20:13
sinzuibac I think it was escalated without being confirmed it is still a problem. Check the age of the bug against the fact Konqueror got a major upgrade.20:14
sinzuiThere are no dupes or other affected users either20:14
bacsinzui: right, i cannot reproduce it with current konq in lucid or natty20:14
* bac closes20:15
sinzuiKonqueror now uses webkit20:15
baci'm just curious as to what new info caused it to be escalated20:15
sinzuibigjool, thumper, and flacoste are also kubuntu users20:15
sinzuilifeless reconnised the description as a script fault20:16
sinzuis/reconnised/recognised/20:16
sinzuiI would close it, or at the very least mark it incomplete20:16
sinzuibac: this bug may also be fixed for the same reasons: bug 45778420:17
_mup_Bug #457784: When bugs reporting tries to report bug in Kubuntu,  using Konqueror, "I am affected by this bug" popup does not works <filebug> <javascript> <lp-bugs> <ui> <Launchpad itself:Triaged> <kde4libs (Ubuntu):Invalid> < https://launchpad.net/bugs/457784 >20:17
derycksinzui, your team is doing the disclosure story now, right?20:19
sinzuibac: and If you are using konqueror right now, you can check bug 546813 and close it if it was fixed by one of our rounds to ensure empty anchors are not used20:19
_mup_Bug #546813: Bugtask table "Affects" edit icon missing in Konqueror <css> <lp-bugs> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/546813 >20:19
sinzuideryck: yes20:19
deryckok, thanks20:19
bacsinzui: will do20:19
derycksinzui, I think bug 419531 should be downgraded to high.  I'm commenting as such in the bug now.20:19
_mup_Bug #419531: project name picker search / vocabulary is hard/impossible to use (too many results on exact searches) <disclosure> <regression> <vocabulary> <Launchpad itself:Triaged> < https://launchpad.net/bugs/419531 >20:19
deryckcan it really be a regression if it was opened two years ago? ;)20:20
sinzuibac: bug 255294 is surprising if it is true.20:20
_mup_Bug #255294: Links with target=help don't render on Konqueror <javascript> <lp-web> <Launchpad itself:Triaged> < https://launchpad.net/bugs/255294 >20:20
flacostesinzui: i'm a Ubuntu user who uses a lot of KDE apps (but I'm no longer a Kubuntu user)20:21
flacosteand i don't use konqueror20:21
flacostebac: i'm not sure Critical was the right priority for this20:21
flacostebac: konqueror isn't a supported browser20:21
flacosteJS errors are critical, sure20:22
sinzuideryck: I agree. The project picker is better than it was tree years ago. It is not a regression. It just continues to suck20:22
bacflacoste: good to know20:22
flacostebut if it only affects a low-following browser, i'm not sure Critical is the right priority there20:22
flacostewe often discussed that we don't have the resources to test/support all browsers20:23
derycksinzui, exactly!  And while sucking sucks, it doesn't make it critical. :-)20:23
sinzuiThe timeout will stop the user from selecting a project in some forms unless you do the trick in the work around20:23
flacostekonqueror is 0.22% of our audience20:24
sinzuideryck: the timeout makes it critical. disclosure makes it high. My team will officially start on it in 2 weeks, but I believe one or two members of the squad will address the performance issue next week20:25
flacosteIE is 5.4%20:25
flacosteand Opera even beats it at 3.20%20:25
deryckflacoste, I also think we should downgrade bug 490767 to HIGH or LOW since we don't support Konq.20:25
_mup_Bug #490767: Cannot post a comment on an existing bug with Konqueror. <comments> <javascript> <lp-bugs> <Launchpad itself:Invalid> < https://launchpad.net/bugs/490767 >20:25
flacostederyck: it is marked invalid20:26
deryckoh, heh20:26
deryckflacoste, sorry, I had it open to ask about and never refreshed. :-)20:26
deryckI see bac is working over all the konq bugs.20:26
deryckI'm just trolling for new work and getting bugs off the list however I can! :-)20:27
sinzuibac also closed an IRC nick bug today, but landed the work last August. bac rocks.20:27
bacderyck: apparently if you launch konq you get to touch all the bugs!  :)20:27
* flacoste is amazed that 25% of our visits come from Windows client20:27
bacsinzui: what IRC nick bug?20:28
derycksinzui, should we file a new bug about the timeout as critical?  it really is two wildly, separate issues.20:28
flacostebeats Mac users who are 4.25%20:28
bacflacoste: and most of those work on launchpad20:28
bacs/those/them20:28
sinzuiflacoste: Lp has spectacular Google fu20:28
sinzuibac: the bug was about contradictory instructions when adding an irc nick, and the presentation of that nick on the profile page20:29
sinzuiWe no longer ask for irc:// nor present it20:30
sinzuideryck: The picker timeout is ultimately caused by a missing ranking, and an improper use of fti. The impelmentation causes bad UI and timeouts. So my squad will fix both20:32
derycksinzui, gotcha.  thanks for supporting my downgrading it. :-)20:32
sinzuiThis action will also permit my squad to contribute to the critical count20:33
abentleyderyck: boo.  I hoped when you touched bug 419531 that you were going to fix it. :-(20:33
_mup_Bug #419531: project name picker search / vocabulary is hard/impossible to use (too many results on exact searches) <disclosure> <regression> <vocabulary> <Launchpad itself:Triaged> < https://launchpad.net/bugs/419531 >20:33
deryckabentley, not me, sorry.  but sinzui's team is.  So some hope there, no?20:33
abentleyderyck: Yes, some hope.20:34
lifelessderyck: hi20:37
derycklifeless, hi.  See my scrollback discussion with sinzui or look at what I said/did on bug 419531.20:38
_mup_Bug #419531: project name picker search / vocabulary is hard/impossible to use (too many results on exact searches) <disclosure> <regression> <vocabulary> <Launchpad itself:Triaged> < https://launchpad.net/bugs/419531 >20:38
derycklifeless, just wanted to argue that bug should be high, but I just changed it.  and can certainly discuss if you disagree.20:38
flacostelifeless: sorry to have stood you up yesterday, but it was a public holiday in Canada20:40
lifelessderyck: its a regression20:40
lifelessflacoste: ah! no worries20:40
derycklifeless, for some value of the word "regression," no? :)20:41
flacostelifeless: in what way it's a regression?20:41
flacostei don't think this ever worked20:42
flacostethe regression tag was added 2 years after the initial bug20:42
deryckflacoste, I think he means in a world before pickers you didn't get this error.20:42
lifelessflacoste: the UI used to be a text field plus 'choose'20:42
lifelessflacoste: in that world you could select 'launchpad' as the project20:43
lifelessflacoste: now the UI is a popup20:43
flacosteah right20:43
lifelessflacoste: and its impossible to select launchpad as the project20:43
flacostei forgot about that20:43
lifelesshow is that *not* a regression20:43
lifelessderyck: I don't see it needing feature level work: oh theres tonnes that could be done but special casing an exact match is < 4 hours work20:44
lifelessderyck: anyhow, the current rule we have is 'tagged regression -> critical'20:45
derycklifeless, maybe "needing feature level work" is the wrong phrase.  it will be fixed by sinzui's team doing feature work.  or it is part of the disclosure feature anyway.  or some other phrasing.20:45
lifelessderyck: so lets finish discussing whether its a regression or not.20:45
flacostederyck: that doesn't lower it's priority nor remove the regression tag :-)20:45
deryckright20:45
deryckflacoste, right.  but I don't consider it a regression, that is my main point.20:45
lifelessDo you agree that something users could do before, and can't now?20:45
deryckbut I knew regression purists would disagree and was looking for more ammo ;)20:45
flacostederyck: it's been a long-standing regerssion20:46
lifelessderyck: And further, do you agree that it wasn't an *intentional* restriction in functionality?20:46
flacostebecause lifeless is right, the regression doesn't come from the pop-up itself, that vocabulary has always been broken20:47
flacostebut before that, the picker was optional20:47
flacostenow it's not20:47
flacostebefore the picker was used to pre-fill a text field20:47
flacostenow the text-field is gone20:48
derycksure, but that's by design.20:48
deryckthat's all I'm saying.  it's not the same kind of regression.20:48
flacosteit is20:48
deryckit's a two year old bug20:48
flacostethe bug report is actually too vague20:48
deryckno, I understand the problem perfectly.20:49
flacostethe regression is that on some specific pages, you could enter a team/project name20:49
flacostein case the picker failed you20:49
flacosteyou can't anymore20:49
deryckI know, I remember :-)20:49
flacosteit's really a different bug20:49
lifelesswell20:49
flacosteso yes, that specific bug report isn't a regression per se20:49
lifelessok, now I'm lost20:49
flacostebut there is another one (unfiled) that is20:49
lifelessflacoste: step me through this?20:50
deryckif it's this complicated, it can't be a regression.  or at least it doesn't matter.20:50
deryck:-)20:50
lifelessderyck: why do you want this to not be a regression? What does it help you with ?20:50
lifelessflacoste: also, would you like to do a call today?20:51
derycklifeless, I fear the precedent of js changes behavior, you now can't do what you did before, and it's a critical bug.20:51
flacostelifeless: i have a call with gary in 10 minutes, i could do after that, but we could have more time tomorrow as i don't have any in the afternoon20:51
deryckI just don't like the word regression for this.  maybe it's just me20:52
=== lifeless changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | https://code.launchpad.net/launchpad-project/+activereviews | Critical bugs:214 - 0:[######=_]:256
flacostelifeless: the picker was actually always broken, that's not a regression20:52
lifelessderyck: so I think if we deliberately change the UI to be nicer that the old UI going is *not* a bug in any regard.20:52
flacostethe regression is that in some case, we remove the possibility of not using the picker20:53
lifelessderyck: but if an existing bug prevents using the nicer UI to accomplish stuff, we've essentially removed a workaround and have to consider the combination of events a regression20:53
flacostebut fyi, on forms, the picker is still optional20:53
flacosteit's on inline-edit forms (new design) that it's impossible to use20:53
deryckflacoste, but we're not going to fix it so you can get an input element.  we're committed to removing the input element as an option.20:53
flacostederyck: agreed20:53
flacostebut i don't think we removed any form yet20:54
deryckso the picker is bugged, not regressed.20:54
flacosteyes20:54
lifelessderyck: thats fixable in two ways: restore the old UI (fugly) or fix the new UI to permit the old workflow20:54
flacostewe have been constant there :-)20:54
flacostelifeless: actually, i'm pretty sure that all the boomerang pages still exist20:54
flacostewith the old way of selecting things (text field + picker)20:54
lifelessflacoste: even in shiny shiny like recipes?20:54
flacostethey might not be linked to though20:54
lifelessflacoste: right20:55
derycklifeless, but we're not going to fix the ui to allow the old workflow, here.  and going back is not an option for these js workflows.  and you can still right-click your way to a real page.20:55
flacosteif it's shinny new, it's not a regression ;-)20:55
derycklifeless, therefore, I don't see us calling this a regression.20:55
lifelessso why do I want to call this a regression20:55
lifelessbecause I can't see our users considering it anything else20:55
deryckyou have a pedantic streak in you ;) :)20:55
flacostederyck: i think he's striving for clarity :-)20:56
deryckI meant that in fun, not insulting way20:56
lifelessif we change something and the result doesn't work, *and* we didn't intend to make things not work20:56
lifelessthen I think users would say that we've regressed in functionality20:56
deryckmaybe so.  but to me that's not the issue.  not what they would *say*.  I do care that they're blocked.  and I do think this should have been fixed well before now.20:57
lifelessif we explicitly said 'we don't care about folk searching for exact matches', it would be entirely different20:57
lifelessderyck: so if this is tagged regression and we had the regression-jumps-queue policy two years ago, it would have been fixed well before now.20:58
derycksure.20:58
lifelessderyck: are you worried that we have other regressions sitting in our 6K database?20:58
deryckbut even today, I wouldn't call this a regression20:58
deryckpartly, yes.  and partly, I fear the slippery slope.  especially when you start saying "a user would say this is a regression, so it is"20:58
deryckit's really that ^^ mostly20:59
deryckin that case, lp is nothing but one big regression, and for a certain class of user that is completely true and valid.20:59
bacsinzui: regarding bug 255294, the help pop-up does appear now and is readable, which is good.20:59
_mup_Bug #255294: Links with target=help don't render on Konqueror <javascript> <lp-web> <Launchpad itself:Triaged> < https://launchpad.net/bugs/255294 >20:59
lifelessI don't think thats true20:59
lifelessderyck: we can always make an explicit choice when changing something20:59
lifelessderyck: but unexpected consequences *are* regressions I think; we can say 'actually thats a consequence we like, WontFix'21:00
bacsinzui: unfortunately, most of the sprites do not appear!21:00
allenaplifeless: Hi. By any (remote) chance do you have some time in the next 30 minutes to chat about Rabbit? If not, some time tomorrow or later in the week?21:01
lifelessderyck: or 'the use case didn't work before it just looked like it did', and mark it low21:01
lifelessallenap: sure do21:01
bacsinzui: so on a project page, the help icon is not shown but if you know where it *should* be you can make the help pop-up pop.21:01
sinzuibac: okay, The real defect bug 521219 and that is really Lp making bad markup. It affects web kit to some degree too21:01
_mup_Bug #521219: Konqueror does not display sprite for empty element <css> <lp-web> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/521219 >21:01
lifelessderyck: what I don't understand is how 'could do X -> cannot do Y' can be not-a-regression21:01
derycklifeless, but every bug is an unexpected consequence.21:01
lifelessderyck: I understand that at no point did we revert out a patch21:01
allenaplifeless: Awesome :) Mumble, Skype...?21:02
lifelessallenap: in ~ 15 minutes, skype.21:02
sinzuibac: oh, update the bug then. The issue may also be a sprite on empty markup21:02
allenaplifeless: Cool, thanks.21:02
lifelessderyck: yes, but not all unexpected consequences prevent doing things21:02
bacsinzui: ok.  i'll close 25529421:02
LPCIBotProject windmill-db-devel build #319: STILL FAILING in 46 min: https://lpci.wedontsleep.org/job/windmill-db-devel/319/21:02
derycklifeless, I guess I don't see users being prevented here.  you can click through to a real form if you want in every case.21:03
deryckit's a search or picker bug.  a new bug.  with unintend consequences.  the ui changed.  it didn't regress.21:03
lifelessderyck: I assert that without user testing its impossible to agree or not agree21:03
deryckfair enough.21:03
derycklifeless, may I approach this another way?21:03
deryckdo you have the time?21:04
lifelessof course21:04
lifelessthis is kindof my job :)21:04
deryckmaybe a better way is to say, "I don't think this is a queue jumping bug"21:04
deryckeven if it happened today.21:04
deryckit shouldn't sit around for two years, and it shouldn't be released with crappy basic search not working, but I just don't think it's enough to be critical.21:05
lifelessmmm21:05
lifelessso lets say then that we had no criticals21:05
lifelessthat is, that while we have a huge number of bugs, every use case that we have implemented is working21:06
lifelessthings we haven't implemented are working, but thats fine we'll get to them21:06
lifelessnow, purple squad come along and ajaxify the PPA package copy screen21:06
lifelessthere is a bug in their js and copies from security ppas to the main archive security pocket don't work21:07
sinzuideryck: I have been saying that for many years. we cannot have more criticals or highs then we can plan to fix without interruption. The fact that we let failed to be honest about the importance of bugs, and worked on other bugs put us into this mess21:07
lifelessand they removed all visible links to the non-ajax UI21:07
lifelessderyck: when its released we find out from the ubuntu security team immediately when they go 'zomg cannot unembargo xyz disclosure'21:08
deryckthe use of "security" here makes this more important than current issue, I think.21:08
lifelessderyck: what would we do ?21:08
lifelessderyck: thats deliberate21:08
deryckI think it's critical because of "security" not because of removing old ui.21:09
deryckand it's not a regression21:09
lifelesswe have existing bugs affecting the ubuntu security team that are only high.21:09
lifelessbugs where they cannot do things21:09
lifeless[this bit isn't fictional, its real]21:09
deryckok, so maybe I'm reading too much into the word "security" and picturing ubuntu cannot make a security update.21:10
lifelessderyck: that is the scenario21:10
lifelessderyck: something they could do and now they can't, and its something very important21:10
deryckbut I'd call it critical for that reason.  the impact.  I don't consider removing a web 1.0 link in favor of js a ui regression.21:11
lifelessderyck: I think we'd rollback the UI via its feature flag until fixed21:11
derycksure21:11
deryckagreed21:11
lifelessderyck: but the bug does not say 'put the 1.0 link back'21:11
deryckright21:11
deryckbut there is no way this picker search bug is near the impact of that security bug21:11
lifelessderyck: the bug says 'trying to do X, which I could before, and I get Y (an error)'21:11
deryckno, "can't make an Ubuntu security udpate" vs. "can't search for the project I want" are worlds apart in impact.21:12
lifelessderyck: so I'm arguing that things of that pattern, unless we wanted that result, are regressions.21:12
lifelessour users, the people we write Launchpad for, don't care about the implementation choices of our system, they care about the things they can do with it.21:13
lifelessany discussion about regression that talks implementation rather than doable-things is (IMO) missing the point21:13
derycksure, we're agreed about that.  I think in practice this naming of things -- "regression" or not -- is really not that important to our users.21:13
lifelessI think its vitally important to our users because its a queue jumping mechanism (for good or bad)21:14
derycksure, I think I'm talking about doable things.21:14
lifelessderyck: but you're not: you're talking about implementation - about replacing the widgets we used21:14
deryckin order to try to define a regression.21:15
deryckhow about this....21:15
deryckif we change the UI and introduce a bug, that is not a regression to me.21:15
deryckno matter what you could do before.21:15
lifelessso for me its clearly conditional.21:15
lifelessthe conditions being:21:15
lifeless - you could do X before21:16
lifeless - we didn't intend to disable X21:16
deryckbut we did!21:16
lifeless - with a grey are for X's that were only accidentally possible in the first place21:16
lifelessderyck: we wanted to stop people selecting launchpad when asked to choose a project?21:17
deryckno21:17
lifelessthen clearly we didn't intend to disable X21:17
deryckso how are people assigning a bug to launchpad today?21:18
lifelessI don't know :). Certainly not through the 'normal' UI21:19
deryckI would describe this as: we introduce a new ui, search is broken for that ui21:19
deryckpeople can still right-click their way to the old ui and enter names directly.  it's not ideal, but you can do it that way if you want.21:19
deryckthat's why I speak of impact.21:19
lifelessbut do they know that?21:19
derycknot every Launchpad user, no.  of course not.  but I think we have fairly web savy users.  clearly they put up with a lot from us so far. :-)21:20
deryckthis is not to excuse the current behavior.21:20
deryckI just fail to see how introducing a new ui with bugs is a regression.21:20
deryckI don't think we'll ever agree about this.21:21
lifelessI'd say lets talkin Dublin21:21
lifelessbut I won't be there21:21
deryckyeah, and I don't particularly enjoy talking about things where we aren't likely to get much consensus.21:21
lifelessI intensely dislike the 'introduce new thing and its bugs get carte blanche' slope21:21
derycksure, and I don't intend to argue that.21:22
lifelessI totally get that a new thing may be worse in some ways than an old thing21:22
lifelessthats inevitable21:22
deryckI would prefer we never released this widget, and I hope that the current review process with jml's team makes this go away.21:22
lifelessderyck: right! its essentially tech debt from a prior project that didn't get to the standard it needed to be consumer ready21:23
deryckbut bugs are inevitable.  and I think we dealing with a new UI, it's easier to judge impact, then the semantics of whether or not it's clearly a regression.21:23
derycklifeless, yes, agreed.21:23
lifelessall our critical are either stakeholder escalations, things changing on us (e.g. browser support ones) or things we've done to ourselves potentially far in the past21:23
derycksure.21:24
deryckI don't see what that has to do with whether or not this sort of bug is a regression and therefore critical.21:24
lifelessin terms of judging impact21:24
lifelessI worry21:24
lifelessI think if we want an impact-based assessment for queue jumping, we should remove regression as a queue jumper - to be honest about how we assess things21:25
deryckAnd I would be ok with that. :-)21:26
deryckI think "regression" is an attempt to had objective assessment to something that always has to be subjectively assessed.21:26
deryckI think regressions are seldom clear cut for a web app.21:26
deryckwe don't do releases after all21:26
lifelessanyhow, the old UI is broken these days too21:27
lifelessgo here21:27
lifelesshttps://bugs.qastaging.launchpad.net/launchpad/+bug/419531/+editstatus21:27
_mup_Bug #419531: project name picker search / vocabulary is hard/impossible to use (too many results on exact searches) <disclosure> <regression> <vocabulary> <Launchpad itself:Triaged> < https://launchpad.net/bugs/419531 >21:27
lifelesstype bazaar into the input box for project21:27
derycktimeout and oops is easy to objectively assess.  functionality for a web app is not.21:27
lifelessclick on save changes21:27
lifeless'There are 2 errors in the data you entered. Please fix them and try again.21:27
lifeless'21:27
lifeless'Enter a project name'21:27
lifelesswith bazaar sitting there in plain text21:28
deryckhmmm, I didn't get that error.21:28
allenaplifeless: I see you're still busy. Would you have time in the morning, around 8pm your time?21:28
deryckbut I know the one you speak of21:28
lifelessallenap: no, because 6am phone call for TL meeting21:28
deryckallenap, sorry I sidelined lifeless from you.21:28
lifelessallenap: lets call now21:28
allenaplifeless: Okay.21:28
allenapRing when you're ready.21:28
allenapderyck: No worries :) He's in demand!21:29
lifelessderyck: I'm going to put this back to critical, because the OLD UI has been broken too; I'm not trying to close off the conversation - but I need to given allen a hand21:29
derycklifeless, thanks for the chat.  sorry to be so stubborn on this.  but well, I just am on ui judgements. :-)21:29
lifelessderyck: strong opinions are good - we learn from such things21:29
derycklifeless, while I strongly disagree that this is critical, I respect that you're the TA and can make that call. :-)21:29
lifelessallenap: whats your skype id ?21:29
allenaplifeless: gavinpanella21:29
lifelessah, I see it21:29
lifelessallenap: https://dev.launchpad.net/ArchitectureGuide/Services21:33
thumpersinzui: you should drop me off the kubuntu users, and add wallyworld_ :-)21:33
sinzuiI think we might want to survey ourselves at the next thunderdome. OSes, distros, browsers, editors21:35
sinzuiThe non vim/emacs can sit at the children's table with me21:35
LPCIBotYippie, build fixed!21:39
LPCIBotProject db-devel build #576: FIXED in 5 hr 24 min: https://lpci.wedontsleep.org/job/db-devel/576/21:39
=== Ursinha-lunch is now known as Ursinha
UrsinhaOOPS-1970CG45021:45
jcsackettsinzui: how would your survey handle those of us who regularly use two or more things in a given category?21:49
sinzuione moment21:50
sinzuijcsackett: this is what I collected from staging: http://pastebin.ubuntu.com/612449/21:50
jcsacketthuh. i'm surprised we don't have more people with two irc nicks, honestly.21:51
sinzuiI may hunt down the person with 24 nicks21:52
deryck24!  wow.21:52
deryckthey're not domain names21:53
jcsackettit's possible it's someone registering all the variations of their nicks. e.g. jcsackett, jcsackett-afk, jcsackett|afk, and so on.21:54
sinzuijcsackett: I think freenode is the secret here. Lp/ubuntu/debian  has a long history with one network. If I am use one of those, I may only need to list that one21:54
jcsackettstill crazy, mind you.21:54
jcsackettsinzui: that makes sense.21:54
sinzuijcsackett: Lp has a small issue in that we collection irc nick as a contact address, so listing just the freenode is correct.21:55
sinzuiI do not list the rizon net since that is for manga for example21:55
jcsackettsinzui: yeah, i have several networks not listed here, b/c they're not contextually needed.21:56
jcsackettincluding rizon, come to think of it, though i don't use that one much.21:56
sinzuijcsackett: deryck: https://launchpad.net/~ionutjula21:56
sinzuiI wish dot plan would make a comeback21:57
jcsackettwow. it really is mostly separate networks.21:58
sinzuiThis looks like a misconception that Lp is a geek dating site21:58
sinzuiI might get this: http://www.redbubble.com/people/zerobriant/art/7186582-omg-they-killed-rory-posters22:01
mwhudsonholy doodoo what happened to all the code imports overnight?22:01
sinzuijcsackett: I really think we should just drop 'network' from the formatting. just use "pting on irc.freenode.net".22:02
jcsackettsinzui: that seems reasonable to me. the network is very clearly implied.22:03
jcsackettand only people who would understand that are going to care about irc nicks as ID anyway.22:03
lifelessflacoste: hi22:04
lifelessflacoste: ping me when you are done22:04
lifeless?22:04
sinzuijcsackett: I agree. That is the salient point22:04
lifelesssinzui: irc nick isn't usable as a trustable address22:04
lifelesssinzui: we can't validate them22:04
lifelesssinzui: if this is about the trustable picker subproject22:05
sinzuilifeless: we know, but users check multiple data points when search for a user22:05
jcsackettlifeless: it's not remotely the only thing used.22:05
jcsackettbut people search on ircnicks in the picker.22:05
flacostelifeless: done22:06
lifelessjcsackett: sinzui: its not got a UNIQUE on it22:06
lifelessyou might consider searching on it but not showing it. I dunno :)22:06
sinzuiNo WAY22:06
sinzuithat is why users thing we are stupid22:06
lifelessah, ok22:07
sinzuiWe allow you to search for information then not show why it matched22:07
jcsackettlifeless: part of the reason people don't trust the picker is b/c they search on "sinzui" and get this other guy and don't know why he came up.22:07
lifelesswe could show what matched (irc/name/fulltext/email) without showing that data22:07
lifelessI don't mean to interfere here :) just riffing22:08
jcsackettwe're at the riffing stage, so this is fine. :-)22:08
jcsackettwell, partially riffing.22:08
sinzuiWe have an open bug about IPersonSet.findPerson() not supporting nick. That method has diverged from the vocabulary. I think we should consider unifying them. There will be less code to audit22:09
jcsackettworks for me.22:12
lifelessflacoste: http://queue.acm.org/detail.cfm?id=139412822:41
lifeless'BASE is diametrically opposed to ACID. Where ACID is pessimistic and forces consistency at the end of every operation, BASE is optimistic and accepts that the database consistency will be in a state of flux.'22:42
=== matsubara is now known as matsubara-afk
sinzuiwgrant: wallyworld_,  I will be 15 minutes late to the stand up meeting23:45
wallyworld_ok23:45

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!