[00:37] thanks for the reviews lifeless [00:37] will someone land my lazr.restful patch, or should i try? [00:38] I think if you set a commit message tarmac will pick it up [00:38] wow [00:38] i will then [00:38] can i just say how satisfied i am that is fixed [00:39] i should have done it ages ago [00:39] i have seen that cryptic message so many times [03:26] StevenK: you may have closed bug 117163 ? [03:26] <_mup_> Bug #117163: Soyuz email generation should be part of the LP mailnotification module

< https://launchpad.net/bugs/117163 > [03:27] lifeless: I have not, but I have made it easier to do so. [03:30] hah! [03:30] I now have a solid use case for team-subscription-muting: private bugs [03:32] lifeless: I'm completly happy to self-review this, but I wanted your opinion if it's pointless or not (hopefully I have explained myself well enough in the MP description): https://code.launchpad.net/~stevenk/launchpad/silence-rf-get/+merge/62788 [03:33] StevenK: I saw it [03:33] your logic is flawed [03:33] but I'm happy with the change [03:33] the warning was never about private branches [03:34] its for community contributors that haven't run 'bzr launchpad-login' - they will get bzr whinging [03:34] OTOH removing the crufty explanation is fine IMO [03:34] lifeless: That's not a solid use case. [03:35] lifeless: Conflation of notification and visibility is a bug. [03:35] wgrant: not with a proper overhaul in progress :) [03:35] wgrant: but till then ... [03:35] wgrant: there is a bug launchpad-bugs is subscribed too that is private and on c-i-p [03:35] Right, but it's a hacky use case. [03:35] Not a solid one :) [03:36] wgrant: even after privacy is overhauled [03:36] wgrant: cross-organisational stuff may well want it [03:36] wgrant: Having subscription *not* imply access would be weird. [03:36] bug 187837 - still relevant? [03:36] <_mup_> Bug #187837: ILinkData.sort_key should be removed once we stop using action menus

< https://launchpad.net/bugs/187837 > [03:37] wgrant: bug 185620 - perhaps fixed in your bugs-oops-crusade ? [03:37] <_mup_> Bug #185620: DebBugs comment import doesn't handle invalid senders correctly

< https://launchpad.net/bugs/185620 > [03:37] ditto 185613 [03:37] We are not planning to remove action menus, AFAICT. [03:37] They have been minimised, but still exist... [03:40] surely 182076 is fixed already,. SO MUCH CRUFT [03:40] Bug #182076 [03:40] <_mup_> Bug #182076: launchpad-form.pt doesn't present widget errors clearly

< https://launchpad.net/bugs/182076 > [03:40] Bug #185613 [03:40] <_mup_> Bug #185613: DebBugs comment import doesn't handle encoding errors correctly

< https://launchpad.net/bugs/185613 > [03:40] Probably not. [03:41] I'm trying to see if I can delete launchpad-bugs [03:42] By removing non-security private bugs? [03:42] And then seeing what's left over? [03:42] repeat for branch subscriptions etc. Yes. [03:46] also killing bugs like 173972 on the way [03:47] wgrant: what about bug 225228 ? [03:47] <_mup_> Bug #225228: checkwatches error handling needs refactoring < https://launchpad.net/bugs/225228 > [03:49] we also shouldn't *have* security bugs on ~launchpad-bugs. *sigh* [03:53] lifeless: Indeed, closed. [03:53] lifeless: Isn't using direct subscriptions for visibility awesome? :) [03:54] wgrant: what about bug 210901 ? [03:54] <_mup_> Bug #210901: Passing strings through LaunchpadValidationError results in double-escaping.

< https://launchpad.net/bugs/210901 > [03:56] lifeless: No idea. [03:56] Well, the only thing that comes to mind is "fuck IE". [03:56] But that's not much of an idea. [03:56] hhhha [03:56] how is ie related to that ? [03:57] I wonder if folk would be unhappy if I just closed all these bugs. [03:57] JavaScript can't be escaped sensibly, so our template system cannot be safe. [03:58] In HTML, that is. And IE<9 don't support XHTML. [04:01] mwhudson: bug 196345 - whats the /why/ ? [04:02] * mwhudson waits for mup [04:02] or is it private? [04:02] private [04:02] with a dead web link to a list archive whose web password I have no idea about [04:02] I think we should close bug #220625. [04:03] can you expand on why? [04:03] lifeless: trying :) [04:03] mwhudson: that was to wgrant :P [04:03] lifeless: it's all about impersonation [04:04] I probably want that [04:04] is it private these days? if not, lets make it public and copy in the discussion ? [04:04] methods like createBranch clearly act on behalf of a user, and currently rather hack to achieve that [04:05] lifeless: can't see why it would be private at all now [04:05] * mwhudson publicizes [04:05] mwhudson: done [04:05] lifeless: There are much worse things that a buildd-manager bug can do. [04:05] heh [04:05] racing changes! [04:05] mwhudson: can you add sensible content to it ? [04:05] wgrant: right, but what about other folk on the machine, for instance. [04:05] wgrant: or other services on the same machine going rogue [04:05] lifeless: let me consult my mail archives [04:06] mwhudson: thanks! [04:06] lifeless: There are far worse things that they can do too. [04:06] lifeless: If we don't trust the machine, then we have major overarching design issues. [04:06] Far beyond this bug. [04:06] wgrant: I'm fine with closing it, or not. But I think you need to explain a little about why in this case. [04:06] as its not a cosmetic test-refactoring bug :) [04:09] * mwhudson reads the thread again [04:11] ugh, this is all very confusing [04:11] and the use case from the time has disappeared [04:11] (it wasn't impersonation) [04:12] feel free to extirpate it [04:15] jtv - bug 237868 [04:15] <_mup_> Bug #237868: Contain non-ascii str objects in parsers and browser code

< https://launchpad.net/bugs/237868 > [04:15] jtv: is that done, or obsolete now? [04:15] gmb: bug 237774 [04:15] <_mup_> Bug #237774: checkwatches doesn't update many SourceForge bug watches

< https://launchpad.net/bugs/237774 > [04:15] gmb: please tell me that isn't still the case? [04:15] lifeless: it was never consciously done. It was more a "we need to take a critical look at our code someday" thing than a "here's a change we need to make" bug. [04:16] so, we're on storm today [04:16] and I'm pretty sure it + our pg driver will barf at non-unicode strings [04:17] Plenty of test code will happily store non-unicode strings in object properties AFAIK [04:18] Project db-devel build #594: FAILURE in 5 hr 37 min: https://lpci.wedontsleep.org/job/db-devel/594/ [04:18] sure, but if it does that to a db column we'll get a barf [04:22] lifeless: https://bugs.launchpad.net/launchpad/+bug/196345/comments/1 [04:22] <_mup_> Bug #196345: implement endpoint specific authentication for the private xml-rpc server

< https://launchpad.net/bugs/196345 > [04:25] mwhudson: thanks [04:25] bug 196345 [04:25] <_mup_> Bug #196345: internal xmlrpc service requires impersonation to be handled per-method rather than systematically

< https://launchpad.net/bugs/196345 > [04:26] haha [04:26] oh right, you just changed the title [04:26] and copied your prosed into the description [04:26] lock [04:26] stock [04:26] and barrel [04:26] i thought that was going to turn out to be another bug that i had reported [04:27] wow [04:27] https://launchpad.canonical.com/BugPageTwoZero [04:28] are you saying wow because the current bug page actually looks not entirely unlike that? [04:29] mwhudson: there is a bug saying we should do that [04:29] *still* open [04:29] bug 227310 [04:29] <_mup_> Bug #227310: duplicate bug handling UI is awkward and confusing < https://launchpad.net/bugs/227310 > [04:30] why is bug 300044 on sso ? [04:31] Bug #300044 [04:32] lifeless: It's in the old SSO codebase. [04:32] The rewrite uses the same project. [04:32] It's Invalid. [04:33] you sure ? [04:33] Hmm. [04:33] Retarget to Launchpad, publicise, retitle to suggest that it should be deleted. [04:33] Since we still have those properties. [04:33] Despite not being an OP any more. [04:37] The last record in the table it checks is dated 2010-04-01, so it isn't being replicated back post-rewrite. [04:37] So it can be removed. [04:41] lifeless: i think storm has a bug in Union. it rejects perfectly valid sql if the 2 queries differ in their exact select expressions, even if the resulting columns are compatible. i can run the sql manually just fine. do you know if there's a reason for this limitation? [04:41] wallyworld_: I don't, sorry. [04:42] storm is very geared towards its ORM role [04:42] which could explain it [04:42] np. i'll see if i can come up with a reasonable work around [04:42] wallyworld_: I suspect it's because it's then unclear how you would reference those columns. [04:43] wgrant: one would use "as foo" [04:44] storm should look at the alias and column type to figure out if everything is kosher and not just compare the exact select terms [04:44] Right, but that would have to be explicitly done. It won't work by default. [04:44] And given that Storm is Storm... [04:45] bug 245543 [04:45] <_mup_> Bug #245543: Call sites that use SPR.createBuild() should really be using SPPH.createMissingBuilds() < https://launchpad.net/bugs/245543 > [04:46] \o/ [04:46] * wallyworld_ has a new coffee grinder just arrived from italy. must immediately cease Storm work to try it out :-D [04:46] lifeless: Lies. [04:46] thumper: ^^^^^^^^ :-D [04:47] wallyworld_: nice [04:47] bug 172869 [04:47] <_mup_> Bug #172869: SoyuzScript needs more test coverage

< https://launchpad.net/bugs/172869 > [04:47] wallyworld_: nice [04:48] faceplant. bug 158386 [04:48] <_mup_> Bug #158386: Close all low-level cursors

< https://launchpad.net/bugs/158386 > [04:54] zomg [04:54] Linux 3.0-rc1 [04:54] The day has come. [04:58] and unlike py3 its not a disaster [05:01] Indeed. [05:01] :( [05:01] Well. [05:01] No *more* of a disaster. [05:02] If gina create builds, I will have to murder people. [05:02] StevenK: It has to when importing binaries. [05:02] (which it hasn't done since 2007) [05:02] But the feature is still there, somewhere. [05:02] Heh, and only once, I daresay. [05:03] Twice! [05:03] Once to import Ubuntu primary, and again to import -commercial (brokenly) [05:03] wgrant: mind if I restart the df app server? [05:03] jtv: Not at all. [05:03] Letter-for-letter identical to what StevenK said. :) Thanks. [05:04] wgrant: Have we fixed that broken -commercial import? [05:04] StevenK: No. [05:04] Pity. [05:05] Hm, not many callsites of SPR.createBuild() [05:05] Does archiveuploader still do it? [05:05] I forget if we removed mixed uploads. [05:05] IIRC they were too entangled with tests to kill. [05:06] Yes, nascentupload uses it [05:06] Well, nascentuploadfile [05:06] Amusingly, createMissingBuilds calls it under the covers. [05:06] Is that amusing? [05:06] Well, I found it amusing [05:07] It is intended that createMissingBuilds should be its only callsite. [05:07] Ah [05:07] A whole bunch of tests call it too [05:07] Yes [05:10] lifeless: launchpad-bugs has no contact address, but launchpad has launchpad-bugs@lists.c.c [05:11] That's the problem. [05:11] uhhhhh fail [05:11] ok [05:11] so lets remove that [05:11] thanks for digging that up [05:11] Now that PQM is out it should be fairly safe. [05:11] PQM was the main problem last time. [05:12] We'll all immediately get loads of vcs-imports spam. [05:12] But at least we won't have robots spamming. [05:12] fixed [05:12] Hm, why is canonical-bazaar in launchpad? [05:12] they were a subteam organisationally [05:12] Were. [05:13] yes. were. [05:13] But they were added just before me. [05:13] poolie: ^ [05:13] Like a month before the refactoring. [05:13] poolie: what does that team membership do for you ? [05:15] StevenK, wgrant: does either of you have time to guide me through some Q/A on dogfood? [05:15] jtv: Sure. [05:15] Thanks. I need to see (1) a pending DSDJob, and (2) a failure on a package copy job. [05:16] Ah. StevenK is possibly going to be more effective at that sort of thing. [05:16] Right ho. [05:16] Project windmill-devel build #152: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/152/ [05:17] StevenK: what can I safely to do produce a pending DSDJob to show up on +localpackagediffs? [05:17] An upload, copy or removal will create a DSDJ [05:18] I guess a removal will make the package drop off +localpackagediffs. [05:18] Maybe not [05:19] A removal will create a DSDJ. Until that DSDJ is run, the existing DSD will not be touched. [05:19] Once the DSDJ has run, the DSD will be updated to state unique to derived series or missing from derived series. [05:20] I see. [05:20] Would the easiest way though be to sync e.g. a52dec? [05:21] I guess that'd give me a copy job first, and then when that's done, a DSDJ [05:21] Right. [05:21] Do we run any of the cron jobs on df? [05:21] ISTR no. [05:21] I'm not sure. [05:22] Well, here goes. IIRC a52dec is a pretty normal package, safe to copy? [05:22] Starting a script takes like 30s of CPU time, so I hope not :/ [05:22] * jtv curses zcml once more [05:23] micahg: bug 59846 may entertain you with a flashback [05:23] Argh "same version is already building in oneiric" [05:24] * jtv looks for different arbitrary guineapig [05:24] lifeless: I don't see anything there [05:24] StevenK: acct should be safe as well, right? [05:24] micahg: retry [05:24] micahg: I was just unembargoing it [05:25] lifeless: heh, yeah [05:25] jtv: Yes. [05:25] Same error. :( [05:26] rmadison has nothing special to remark about alarm-clock either… [05:26] lifeless: You asked of bug #121538 "Can this bug be opened ?" [05:27] wgrant: made public [05:27] I think you may have been through too many this afternoon :P [05:27] Oh. [05:27] I see. [05:27] jtv: alarm-clock is already identical [05:27] Is _now_ :) [05:28] It was -1.1 vs -1ubuntu1 [05:28] It correctly shows up as "updating..." [05:29] And now it's off the list. [05:29] So we are running DSDJobs on dogfood. [05:29] lifeless: should I dupe mine to it [05:30] no [05:30] its fix released [05:31] and sufficiently long it would be a pita to reuse it [05:31] StevenK: now I'd like to try an asynchronous copy... I'll disable synchronous copying for a moment. Any objections to syncing amule, ajaxterm, or amsn? If I read rmadison output right, they have some version differences across architectures but they're not in nonfree. [05:33] Do they? [05:33] Well not ajaxterm since it's for "all" [05:33] Nor amsn. [05:33] Nor amule. [05:34] hmmm [05:34] I wonder if merging -bugs and -security would be better [05:34] wgrant: I ran e.g. $ rmadison -u debian -s sid amsn [05:34] jtv: Why Debian? [05:34] Debian binaries are not interesting. [05:35] lifeless: Possibly, if there are no non-bugs -bugs references. [05:35] Because I need to know whether I can copy it into oneiric without creating an invalid publication. [05:35] wgrant: if only we had a UI to show subscriptions [05:36] lifeless: For everything else, there's psql. [05:36] jtv: Ah, I see. [05:36] jtv: Those should indeed be safe. [05:36] And while I love the idea of being the author of an illegal publication… [05:38] ok, how to request a team merge ? [05:39] lifeless: /people/+adminteammerge, but let's check this out first. [05:40] StevenK: next I need to trigger a CannotCopy on an asynchronous copy request… is there some off-the-shelf way of getting that? [05:41] I'll try a regular run first though, to verify the common case. [05:41] lifeless: It's still bug supervisor for a couple of places. [05:42] jtv: I can't think of an easy way off the top of my head [05:43] StevenK: on the bright side, the status quo for handling that is an oops. So from a branch Q/A standpoint, just verifying that it works when there are no errors means the change is good to deploy. [05:43] What script was the processing of PPCJs hidden in again? [05:43] process-pending-packagediffs? [05:43] No [05:44] I thought one just used run_jobs. [05:54] wgrant: according to you thats not conflated with subscriptions now [05:55] lifeless: It has some structuralsubscriptions, some assigned questions and bugtasks, and is the bug supervisor and security contact on some projects. That appears to be it. [05:55] lifeless: It's not. [05:55] we should nuke the strucsubs [05:55] Right. [05:55] the rest we can tolerate [05:55] But launchpad-security may not be the correct bug supervisor for all our projects. [05:55] it shouldn't be a security contact anyway [05:55] KIndeed. [05:55] wgrant: -security and -bugs are functionally equivalent now [05:55] lifeless: OK. [05:56] https://launchpad.net/~launchpad-bugs/+structural-subscriptions [05:56] It has as few. [05:56] I suspect all should be deleted. [05:56] Before we merge. [05:56] we can't open -bugs to non-staff because of the tonne of old bugs that would need auditing [05:56] 400 odd [05:56] Yeah. [05:56] so if we want different supervisors [05:56] we can't use -bugs anyhoo, so merging won't make this worse [05:57] We should delete the structsubs first. [05:58] yes [05:58] am on it [05:58] its not ajaxy [05:58] Thanks. [05:58] malone-developers has bugs assigned, and that's all. [05:58] Might merge it into ~launchpad. [05:58] qprocd wtf [05:58] Heh [05:59] dilys?! [05:59] .. yes? [05:59] You don't remember dilys? [06:04] cleared out [06:04] lifeless: ~malone-developers isn't a celebrity, only member is ~launchpad, and only artifacts are assigned bugtasks. Any objections to merging it into ~launchpad? [06:04] Or even deleting it. [06:06] hahha [06:06] want to file this bug ? [06:06] https://bugs.launchpad.net/~malone-developers/+assignedbugs?advanced=1 [06:06] note the team portlet [06:06] wgrant: have you cleared the bug assignments ? [06:07] lifeless: No. Deletion will do that. [06:07] I can't see them [06:07] (even with closed bugs checked) [06:07] Neither. Let me find what they are. [06:07] Bug #3460 [06:07] <_mup_> Bug #3460: Bug reported as no secret is not accessible anymore. < https://launchpad.net/bugs/3460 > [06:07] It's a dupe. [06:08] doh [06:09] https://launchpad.net/~malone-developers/+adminteammerge 404s [06:09] oh [06:09] literal people [06:09] /people/+adminteammerge [06:09] Yeah. [06:09] But that team can just be deleted. [06:09] I guess it doesn't make much difference. [06:10] I think we're gtg on bugs now [06:10] yes? [06:11] As long as we don't care about bug supervisor, security contact or question/bugtask assignee, yup. [06:11] ah questions [06:11] lets see about those [06:12] 1 question [06:12] 109645 [06:12] 1 bug [06:12] unassigned [06:12] Bug #174335? [06:12] <_mup_> Bug #174335: [remote-bug-watcher] GStreamer's Trac has switched to https < https://launchpad.net/bugs/174335 > [06:13] Question unassigned [06:13] and supervisor I don't care about [06:13] I will raise that its odd [06:13] That leaves us with just bugsubscriptions and products. [06:13] So let's doit. [06:14] products? [06:14] bug supervisor and security contact. [06:14] Which you say we don't care about. [06:14] ah - shrug ;) [06:14] Which seems reasonable. [06:14] security contact should be -security [06:14]