| === Ursinha-afk is now known as Ursinha | ||
| * gmb lunches | 12:44 | |
| gary_poster | halloooo | 13:27 |
|---|---|---|
| gmb | Wotcher | 13:28 |
| gary_poster | :-) | 13:28 |
| * gary_poster wonders what schedule thing he's forgotten about with bac | 13:28 | |
| gary_poster | but meanwhile... | 13:28 |
| gary_poster | benji, danilos, gmb, kanban now, skype rsn | 13:28 |
| * danilos tries to find his skype | 13:30 | |
| gary_poster | bac, we can hear you | 13:31 |
| gary_poster | benji, you not here? | 13:31 |
| benji | darn it! | 13:31 |
| benji | ok gary, I'm signed into skype now | 13:32 |
| * benji considers putting skype in cron. | 13:37 | |
| bac | hi gary_poster, question about removing wiki_names from the web service | 14:53 |
| bac | gary_poster: any problem with just stopping the export? it will break our contract for the web service but since the field is going to be removed from the db there isn't much we can do. | 14:54 |
| gary_poster | bac, that's an interesting question | 15:03 |
| bac | gary_poster: yeah... | 15:03 |
| gary_poster | is there any easy way to keep the export and have it return nothing? | 15:03 |
| bac | i guess for 'devel' we could mock it up to return nothing, as you suggest | 15:04 |
| gary_poster | well... | 15:04 |
| gary_poster | IMO idealy we would have it exported in "beta" and "1.0" to return nothing | 15:04 |
| gary_poster | and devel would not export it at all | 15:04 |
| gary_poster | I think the version machinery supports that--in fact I'm pretty sure it does | 15:04 |
| bac | er, right, i got my releases ordered wrong | 15:04 |
| gary_poster | *ideally | 15:04 |
| gary_poster | oh ok cool | 15:04 |
| gary_poster | so does that plan work practicaly? | 15:05 |
| gary_poster | +l | 15:05 |
| bac | probably | 15:05 |
| gary_poster | ok, let's run with it then | 15:05 |
| bac | i just sent off a MP that i'll retract | 15:05 |
| gary_poster | benji I'm having trouble with test_title_ellipsisification. Is that something you know about? ISTR you looked at that | 17:19 |
| benji | gary_poster: yep, what's up? | 17:20 |
| gary_poster | cool | 17:20 |
| gary_poster | so...on Chrome | 17:21 |
| gary_poster | are you looking at the test? That would be helpful | 17:21 |
| gary_poster | When you get to the Assert in the test, | 17:21 |
| benji | yep, I'm pulling the test up | 17:22 |
| gary_poster | header is "Add a mail subscription for A very long name for the current project bugs" | 17:22 |
| gary_poster | and full_title is that except "bugs" | 17:23 |
| gary_poster | brb | 17:23 |
| gary_poster | benji, the display looks fine | 17:25 |
| gary_poster | with an ellipisis | 17:25 |
| gary_poster | an easy way to fix the test is to add ' bugs' to the end of full_title | 17:25 |
| gary_poster | but then...what the heck am I testing? | 17:25 |
| benji | I'm not understanding your problem. | 17:25 |
| gary_poster | sorry | 17:26 |
| gary_poster | the problem is that the test fails | 17:26 |
| gary_poster | on Chrome | 17:26 |
| benji | k | 17:26 |
| gary_poster | it fails because full_title does not contain all of header | 17:26 |
| benji | oh! that test shouldn't run on chrome | 17:26 |
| gary_poster | and therefore it is not a match | 17:26 |
| gary_poster | that would make sense | 17:26 |
| gary_poster | mostly :-P | 17:26 |
| benji | since Chrome implements the nice shorten-this-text-and-add-ellipsis CSS fucntionality, then doing it manually doesn't need to be done | 17:27 |
| gary_poster | I suspect the comments should also mention that "bugs" is left out intentionally as part of the test--it's not really what the comment says | 17:27 |
| gary_poster | "This is the title we would expect if there were no shortening." | 17:27 |
| benji | that would be good | 17:27 |
| gary_poster | ok | 17:27 |
| gary_poster | do you happen to know if there is a "conditionally run this test" flag in the testrunner? | 17:28 |
| gary_poster | I can always just futz within the test itself if not | 17:28 |
| benji | you might want to use (or refactor so it is usable) the test the code itself decides to run or not as your conditional | 17:28 |
| benji | I don't know if there is a way to spell that for the test runner | 17:28 |
| gary_poster | heh, good point | 17:29 |
| gary_poster | I can just do an if | 17:29 |
| gary_poster | ok thanks! | 17:29 |
| benji | cool, thanks for improving that test | 17:29 |
| gary_poster | np | 17:29 |
| * benji resumes eating the best pulled-pork sandwich he has ever had. | 17:30 | |
| gary_poster | heh | 17:30 |
| bac | benji: where are you that you find such good pork? | 18:30 |
| benji | bac: Middle Tennessee | 18:30 |
| bac | ah | 18:30 |
| benji | the local Rotary was selling smoked boston butts as a fundraiser; came with sauce in a canning jar | 18:31 |
| bac | hi gary_poster -- you have a moment to do a review? | 20:26 |
| gary_poster | bac, sure | 20:26 |
| bac | https://code.launchpad.net/~bac/launchpad/bug-186660/+merge/63029 | 20:26 |
| * gary_poster looks | 20:26 | |
| bac | gary_poster: i got bogged down on making the web service backwards compatible | 20:27 |
| bac | this branch is UI only. | 20:27 |
| gary_poster | bac ok, sounds good | 20:27 |
| gary_poster | bac, I don't understand the change in person-portlet-contact-details.pt . What does two-column-list do, and why did you wrap some new part of the template with it? | 20:30 |
| gary_poster | other than that looks good | 20:30 |
| bac | gary_poster: i moved the Code of Conduct from the first column to the middle one for balance | 20:34 |
| bac | otherwise it looked funny since the wiki names were previously in the middle column | 20:34 |
| gary_poster | bac ok. Sounds reasonable. It didn'y make sense to just remove the columns entirely--that is, the columns still add value to your eyes? | 20:35 |
| bac | gary_poster: i don't understand your question | 20:35 |
| gary_poster | ("yes" is fine; just want to ask) | 20:35 |
| gary_poster | ok... | 20:35 |
| bac | gary_poster: look at https://launchpad.net/~bac | 20:35 |
| bac | and imagine the wiki names is gone. | 20:35 |
| * gary_poster does not see wiki names | 20:36 | |
| * gary_poster will go to ~gary | 20:36 | |
| bac | sorry, it is just "Wiki" in the UI | 20:37 |
| gary_poster | Yeah, bac, I can't see "Wiki" on your page. Can you see it on mine? https://launchpad.net/~gary | 20:38 |
| bac | yes, at the top of the middle column | 20:38 |
| bac | you don't see that on mine? | 20:38 |
| gary_poster | no | 20:38 |
| gary_poster | I see IRC | 20:38 |
| gary_poster | then spave | 20:38 |
| gary_poster | space | 20:38 |
| gary_poster | then Languages | 20:38 |
| gary_poster | then Karma | 20:38 |
| bac | oh, that's b/c i don't have one | 20:39 |
| gary_poster | heh | 20:39 |
| bac | it is shown to me because i have lp.edit | 20:39 |
| gary_poster | ah | 20:39 |
| gary_poster | so... | 20:39 |
| bac | ah so? | 20:39 |
| bac | so you don't think moving the code-conduct makes sense? | 20:40 |
| gary_poster | FWIW, https://launchpad.net/~gmb | 20:40 |
| gary_poster | we can both see that he does not have a wiki | 20:40 |
| gary_poster | so yeah | 20:40 |
| bac | yes | 20:40 |
| gary_poster | I'm inclined to say that keeping the CoC where people are used to it is more valuable, but if you want to leave it as is in your branch, that's fine. this is mountain out of molehill | 20:41 |
| bac | i can revert that part. i think it is harmless but some people may have an affinity for seeing code of conduct over there | 20:41 |
| bac | hey, molehills -> mountains are what we do! | 20:41 |
| gary_poster | :-P | 20:41 |
| gary_poster | bac, otherwise looks fine. Will approve now, with or without the CoC change | 20:42 |
| bac | i'll revert the template | 20:42 |
| gary_poster | bac, my side is done | 20:45 |
| benji | gary_poster: I don't know if you have time for an ad-hoc call, but I'd like to share my progress on the syncifinator and see how best to use my remaining time with it. | 21:03 |
| * benji will be right back. | 21:03 | |
| gary_poster | Hey benji. I'm supposed to have a call with flacoste now-ish | 21:04 |
| gary_poster | Lemme check with him... | 21:04 |
| gary_poster | yeah talking now | 21:05 |
| benji | k | 21:05 |
| * benji discusses his options with a big glass of Mello Yello instead. | 21:06 | |
| gary_poster | benji, wanna talk now, or did the Mello Yello have some good advice, or is it all too late anyway? | 21:42 |
| benji | gary_poster: I was indeed enlightened by my sparkly fluorescent friend, but I'd still like to chat. | 21:43 |
| gary_poster | lol, ok | 21:43 |
| benji | gary_poster: https://code.launchpad.net/~yellow/+junk/lp2kanban | 21:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!