/srv/irclogs.ubuntu.com/2011/06/02/#launchpad-dev.txt

=== _mup__ is now known as _mup_
jtvmorning peops02:41
jtvOh how I hate this… when we're late paying the bill, my ISP regularly stops routing my packets until it's been able to redirect an http request to its "pay up or da bitch gets it" notice.  But how often do we use http these days?03:26
StevenKAh yes, my ISP does that too.03:26
StevenKThe way I notice is when my DSL connection gets assigned an internal IP03:27
jtvI wonder if this could be generalized into the same problem as those annoying redirect-all-your-browser-tabs-with-no-way-back wifi login pages, so that someday some saviour may come up with a helpful protocol.03:30
jtv"Some annoying twit insists on showing you their web page.  They may just be really proud of it, or they may want money.  I've stopped them from messing with your browser tabs, but click here to see what they have to say."03:31
lifelessjtv: you mean like all the launchpad operational pages (devpad, lpstats etc)03:34
LPCIBotYippie, build fixed!03:35
LPCIBotProject db-devel build #606: FIXED in 5 hr 30 min: https://lpci.wedontsleep.org/job/db-devel/606/03:35
jtvlifeless: yes, come to think of it it would be nice there as well.03:35
jtvLog in once, then reload all those tabs.03:35
jtvI've lost God knows how many pages to broken login redirects.03:36
jtvAnd then there's broken censorship proxies: "your license to use StalinWare™ SafeBrowse® has expired.  Please contact your nearest military dictator for new terms."03:38
lifelessrofl03:38
jtv(Although that _is_ one of the funniest things I've ever seen — proprietary commercial software and authoritarian state censorship biting each other)03:39
jtvI may have misremembered some details of the exact wording, of course.03:39
sinzuiwallyworld_: I think this fixes the badge issue in the picker: http://pastebin.ubuntu.com/616306/03:39
wallyworld_sinzui: thanks. i had the style elements similar to yours but couldn't get the override aspect to work03:41
sinzuiThis is easier to read http://pastebin.ubuntu.com/616309/03:41
sinzuiwallyworld_: I think this markup means we can show only one badge03:43
wallyworld_sinzui: that css should go in lazr-js though. do we still need it in the lp tree?03:43
sinzuiNo keep it in our tree. I am tired of that lib inject rules into Lp03:44
wallyworld_sinzui: my css was positon:relative; padding-left: 5px and that works for multiple03:44
sinzuiI am sure U1 and landscape do not want us injecting rules into their sites03:44
lifelessman, all software sucks03:45
wallyworld_sinzui: ok. i built a lazr-js tar ball with "setup sdist" but that results in lp jsbuild issues which i'm still trying to figure out03:45
sinzuiwallyworld_: I think relative will have surprising results across browsers03:45
wallyworld_sinzui: so relative isn't interpreted in a starndard way?03:46
lifelessekiga, on startup, reads something like all of /dev03:46
sinzuiwallyworld_: I have not seen it be reliable03:46
sinzuiwallyworld_: I just switched my example to relative and it is not working in webkit03:46
wallyworld_sinzui: i think we need a way of displaying multipe badges though03:47
sinzuiThere can be only one primary context03:47
wgrantsinzui: No.03:47
wgrantsinzui: Subscribing someone to a multi-task bug.03:47
wgrantMultiple contexts.03:47
wgrant(yes, there is a single root context for the page, but that is a bug)03:48
wallyworld_so we could use a div and put all the badges in there with no "posiiton" style attribute?03:48
sinzuiWell relative does not work for me and I do not think we want to tell abandon branches for one case03:50
sinzuis/branches/badges/03:50
sinzuiwallyworld_: I can make multiple appear, but they break the bound box and can only be aligned by percentage. It is very unreliable03:53
wallyworld_sinzui: ok. so just stick to one for now?03:53
wgrantCan't you just put them in a div, and stick that to the right of the li?03:53
wallyworld_that's what i was asking :-)03:54
wallyworld_sinzui: so given that img.badge is a new style and we won't be messing with u1 et al since they won't be using it, could we not include the css in lazr-js?04:00
lifelessits not a new style is it ?04:03
lifelessits a picker injected style which we're overriding04:03
wallyworld_lifeless: it is a new style04:04
wallyworld_because it pertains to badges being displayed next to the picker item title04:04
wallyworld_so css "img.badge" is new04:05
sinzuiwallyworld_: this will support a few badges, but I think we need to view it in a few rendering engines:04:06
sinzuihttp://pastebin.ubuntu.com/616323/04:06
sinzuiwallyworld_: Yes, these are new classes04:06
wgrantWhat's position: initial?04:06
wgrantI've not seen that before :/04:07
wallyworld_sinzui: thanks for the new css. so since they are new, i could reasonably put them in lazr-js?04:07
sinzuiPlease do not04:07
sinzuiI hate every person who put their sites' rules into Lp that I had ti undo. That is a contributing reason to Lp's CSS woes04:08
sinzuiThese rules belong in Lp's CSS04:08
wallyworld_ok :-)04:08
wallyworld_i guess i was just thinking that lazr-js should work sensibly "out of the box"04:09
wallyworld_and downstream could always override stuff as required04:09
sinzuiwallyworld_: This is what the sample looked like in my test: http://people.canonical.com/~curtis/badges.png04:10
wallyworld_sinzui: nice :-)04:10
sinzuiwallyworld_: The out of the box experience, much like YUI's out of the box experience imposes rules at too many levels many upgrades difficult.04:11
sinzuiAs you can see by my diff, our rules were broken last august when we updated yui04:12
wallyworld_sinzui: sure. so your philospohy is each user of lazr-js needs a stylesheet with all the necessary css rules for the lazr-js widgets defined for their app?04:13
wallyworld_wgrant: you may be able to help me. i build a lazr-js tarball with setup sdist (after changing __version__ to 1.6DEV-xxx). i change versions.cfg in lp, do a make clean build, but new new js is not being used :-(04:14
wallyworld_i put the tarball in download cache04:14
wgrantwallyworld_: rm -r lazr-js/build04:14
wgrantmake jsbuild04:14
wgrantAh.04:15
wgrantmake clean_js04:15
wgrantmake jsbuild04:15
wallyworld_wgrant:  tried that. make clean does it also04:15
wallyworld_ah didn't try make clean_js04:15
sinzuiwallyworld_: The CSS chain imposes a style, one that happen to not work well with what Lp is trying to do. We should have about 100 CSS rules, but we have about 800. Most rules are struggling to undo a rule defined before it :(04:15
* wallyworld_ tries it04:15
wallyworld_sinzui: sounds like a job for huwshimi :-)04:16
wallyworld_sinzui: but forgetting about lp, as a user of a 3rd party library like lazr-js, i expect sensible defaults that i can customise if i wish. but that's only my view. we can discuss over a beer at the epic :-)04:17
wallyworld_wgrant: something is wrong with the tarball perhaps. a compare with the working one shows only the expected source differences, but when i try and make jsbuild, i get:04:20
wallyworld_  File "/home/ian/projects/lp-sourcedeps/eggs/lazr_js-1.6DEV_r209-py2.6.egg/lazr/js/build.py", line 72, in update04:20
wallyworld_    target_fh = open(self.target_file, 'w')04:20
wallyworld_IOError: [Errno 2] No such file or directory: 'lazr-js/build/lazr.js'04:20
sinzuiwallyworld_: So who uses badge?, what are their image sizes? How many do they require? What is their picker width? How large is their text? These are the kind of questions that were not asked about previous additions, so we need to redefine them04:20
wgrantwallyworld_: Have you compared the tarballs?04:20
wallyworld_wgrant: yes04:20
wallyworld_only the expected changes from an itinial look. i'll fire up meld again04:20
wallyworld_sinzui:  all good points04:21
wgrantwallyworld_: Oh, heh.04:21
wgrantJust reread the error message.04:21
wgrantlazr-js/build shouldn't have been deleted.04:22
wgrantIt just needed to be emptied.04:22
wgrantbzr st should tell you.04:22
wallyworld_wgrant: make clean_js does a rm -f -r lazr-js/build04:22
wgrantThat's unhelpful.04:23
wallyworld_wgrant: bzr status doesn't complain04:23
sinzuiwallyworld_: the img.badge class may not be needed. I like this more http://pastebin.ubuntu.com/616332/04:24
* wallyworld_ looks04:25
wallyworld_sinzui: that looks nice and clean. i'll use it. i wasn't passing in any alt attributes. are they strictly required? i would have to modify the IHasAffiliation implementation etc to provide the extra info04:27
wgrantwallyworld_: I'd have an alt and title.04:28
wgrantI think.04:29
wgrantLike team badges do.04:29
wgrantNo alt == accessibility fail04:29
wallyworld_wgrant: ok. btw, the build.py in the latest lazr-js source tree is brooken :-(04:29
wallyworld_that's why it won't build :-(04:29
wgrantAwesome!04:30
wallyworld_i haven't yet looked to see how it happened04:30
wallyworld_mwhudson: ping!04:41
mwhudsonwallyworld_: hello04:41
wallyworld_mwhudson: hi. i'm trying to understand a change made to build.py in lazr-js. was that you per chance?04:42
wallyworld_its a change to SRC_DIR04:42
mwhudsonwallyworld_: i think that may have been me04:42
wallyworld_it seems to have broken make jsbuild for lp04:42
mwhudsonwallyworld_: iirc it was so it would work uninstalled04:42
mwhudsonwallyworld_: i'm sorry to hear that04:43
wallyworld_mwhudson: np. i'm trying to see the best way to fix it04:43
wallyworld_so that what the change fixed still works and so can lp04:43
wallyworld_what's thebest way to test your change so that i can mess with it can make both scenarios work?04:44
mwhudsonwallyworld_: put "WSGIScriptAlias /combo /path/to/lazr-js/combo.wsgi" in apache config, restart apache, does combo loader work?04:45
mwhudsonwallyworld_: i'm sure we can change our combo loader deployment to run installed in a virtualenv or something,  which might make the previous version work04:46
wallyworld_mwhudson: given the change that was made, i'm wondering if it is possible to support both scenarios?04:47
wallyworld_mwhudson:  one would be to try the new SRC_DIR and revert to the old definition if it isn't there04:48
wallyworld_a bit hacky perhaps04:48
mwhudsoni guess that works04:53
wallyworld_mwhudson: actually, i've read the source code a bit - it supports a cmdline option to override the src_dir. i'll see if i can modify the make scripts for lp to pass in the relevant directory04:55
lifelesshuwshimi: hi05:03
lifeless16:01 < micahg> lifeless: BTW, I failed to note it was private until after I posted the first reply to you, I guess I'm not used to the bar on top yet :-/05:03
lifeless16:02 < lifeless> hmm05:03
lifeless16:02 < lifeless> :(05:03
lifeless16:02 < micahg> the benefit on the bar on the side was that you could see it all the way down the page, my eyes went straight to the description05:03
lifeless16:03 < lifeless> thats worth noting on the bug I think05:03
micahglifeless: which bug did you mean for me to note it on?05:04
lifelessthere is one about the privacy banner05:04
micahgk05:04
StevenKmicahg: Personally, I find the bright red bar enough of a visual warning -- it's bright enough and large enough that my eyes are drawn to it.05:05
huwshimilifeless: Thanks05:06
micahgnot if you're ignoring the top 100px of the window (I'm on 1920x1080 at the moment)05:06
micahgbug 29152?05:07
micahgoops05:07
_mup_Bug #29152: Suggestions for FAQ guide <Ubuntu Documentation:Fix Released by robertstoffers> < https://launchpad.net/bugs/29152 >05:07
micahgbug 29815205:07
_mup_Bug #298152: privacy portlet is not visible enough for indicating private objects <disclosure> <lp-web> <oem-services> <privacy> <ui> <Launchpad itself:In Progress by huwshimi> < https://launchpad.net/bugs/298152 >05:07
micahglifeless: is that the one? ^^05:08
lifelessyes05:08
StevenKmicahg: I am also on 1920x1080, on a 22 inch LCD screen, and I don't ignore the top 100px of the window05:09
micahgmy screen is 15.6" and I still managed to miss it :)05:09
StevenKmicahg: See a doctor? :-)05:09
micahglifeless: commented in the above bug05:14
lifelessmicahg: thanks, appreciate the feedback05:14
cody-somervillelets get rid of private stuff all together, then no more problem :P05:28
lifelesscody-somerville: ^^05:29
lifelesscody-somerville: you'd be out of a job then ;)05:29
cody-somervillewe'd use bugzilla :P05:29
cody-somerville(sadly of course)05:29
lifelessI don't see it meeting your partitioned-view needs05:29
StevenKcody-somerville: Isn't that a downgrade?05:30
cody-somervilleYes but I doubt we could get approval to run our own launchpad instance :P05:30
lifelesscody-somerville: still wouldn't do what you say you need ;)05:31
lifelesscody-somerville: you'd need N separate instances05:31
lifelesscody-somerville: and I don't see how that is a usability improvement :>05:31
* cody-somerville is being entirely facetious... we'd of course use Microsoft Dynamics CRM :P05:32
cody-somervilleor maybe Microsoft's Team Foundation Server05:32
* StevenK goes to review his lunch05:33
wgrantThat sounds less than ideal.05:34
StevenKcody-somerville: I'm blaming you for that.05:35
StevenKcody-somerville: Besides, isn't using a CRM as a bug tracker a bit like using a wiki as an issue tracker?05:37
wgrant*cough* SharePoint05:37
lifelessquestion for the peanut gallery05:41
lifelessdoes the codehosting bzr+ssh server reject attempts to creation branches with experimental formats05:41
wgrantbzr: ERROR: Server sent an unexpected error: ('error', "'Bazaar development format 8\\n'")05:42
lifelessis that one *in* the bzrlib we run05:42
wgrantA good question.05:43
wgrantSeems to be.05:44
lifelesscool05:44
wgrantbin/bzr init --development-subtree works.05:44
* lifeless closes wontfix05:45
jtvstub: I got a review request message for your tests branch.  Did you request a review from me?06:04
stubI requested a review from 'launchpad'06:05
lifelesshi stub06:05
stubyo06:05
stubI should have gone out drinking last night so I have an excuse for this hangover.06:06
lifeless:)06:06
StevenKHaha06:06
lifelessgetting old ?06:07
stubFalling apart06:07
StevenKI'm reading The Last Continent, and Rincewind has staggered into the pub, hungover, and the bartender says "You look like you need the hangover cure!" "Oh, what's that?" "More beer!"06:07
jtvThanks for the spoiler.06:10
StevenKIt's one joke06:11
jtvNow I know how my next hangover is going to end.06:11
StevenK:-)06:11
lifelessstub: index repack time ?06:14
stubbug_fti? I did that just two days ago06:14
lifelesscool,t hanks06:14
lifelessso something else iz making the slow06:14
stubCould be another index... bug search again?06:15
lifeless    Hard / Soft  Page ID06:16
lifeless      98 /   38  Person:EntryResource:searchTasks06:16
lifeless      78 /   20  Distribution:EntryResource:searchTasks06:16
lifeless      59 /    8  POFile:+filter06:16
lifeless      56 /   15  Distribution:+bugs06:16
lifeless      52 /   16  MaloneApplication:+bugs06:16
StevenKHow do you repack it? Hopefully it isn't DROP INDEX, CREATE INDEX?06:16
lifelessno06:16
lifelessits create drop06:16
stubcreate drop rename06:24
lifelessstub: shall we chat ?06:25
stublifeless: sure.06:26
=== almaisan-away is now known as al-maisan
jtvDo we have a way to specify an adapter from an enumeration to an interface?07:22
jtvAdapting lazr.enum.DBItem works, but… yuck.07:23
lifelesseeeeek07:23
lifelesswouldn't a factory function be better ?07:23
jtvThat's basically what I have, except it's got the name of the interface.07:25
jtv"I have this enum for one of a number of policies; give me the matching policy implementation."07:25
jtv(It's "got the name of the interface" only when invoking, obviously, not in implementation)07:26
wgrantwallyworld_: Your query has a bug.07:38
wgrantwallyworld_: The outer EmailAddress join query needs to do the PREFERRED check too.07:38
wgrantwallyworld_: Otherwise you'll return multiple rows for teams with multiple addresses.07:39
wgrants/join query/join condition/07:39
=== jtv is now known as jtv-afk
=== al-maisan is now known as almaisan-away
=== jtv-afk is now known as jtv
mrevellGood morning09:20
jtvallenap: and when you're done with stub… https://code.launchpad.net/~jtv/launchpad/db-bug-790761/+merge/6320309:56
allenapjtv: Brillig :)09:57
StevenKjtv: I was in line first :-P09:57
=== allenap changed the topic of #launchpad-dev to: Performance Tuesday! | https://dev.launchpad.net/ | On call reviewer: allenap | Critical bugs:208 - 0:[######=_]:256
allenapStevenK: I haven't forgotten :)09:57
jtvStevenK: and you aren't any more?  Good.09:57
StevenKallenap: :-) Do you need a link?09:57
jtvI thought "brillig" was a weather condition.09:57
allenapStevenK: You seem to have something on +activereviews.09:59
StevenKallenap: If it's 'copies-use-notify', that's it09:59
allenapYes.09:59
jtvbigjools: afaict we create PPCJs in 2 places: "Sync Sources" and "Upgrade Packages."  Which should have which policy?10:05
bigjoolsjtv: sync is the "insecure", upgrade is the "sync"10:06
jtvhow perfectly straightforward (!)10:06
bigjoolsthis naming in the UI needs to be fixed10:06
bigjoolscan you do a drive-by?10:06
bigjoolsUpgrade should be "mass-sync"10:07
bigjoolsthe SyncCopyPolicy should be MassSyncCopyPolicy10:07
jtvProbably best done after Gavin finishes my review; got a sequence of branches in flight right now.10:08
lifelessevening podeans10:13
bigjoolshello lifeless10:15
jtvlifeless: *You're* an evening podean.10:15
jtvThat shut him up.  Now, what's an evening podean?10:15
lifelesspfttt10:22
bigjoolsdid lifeless just fart?10:23
lifelessblew a raspberry10:23
jtvI guess people on his side of the globe fart out the other side.10:27
lifelessGiven you're on the same side of the globe...10:28
bigjoolswell he's in between.  the mind boggles10:29
jtvNonsense.  I'm on the Northern Hemisphere, so you're upside down.10:29
lifelessdude, you're so far down you'll slide off sideways10:30
lifelessand after that, you're clearly southern :>10:30
jtvWell people did warn me about the slippery slope when I moved here...10:31
lifelessone night in bangkok10:31
bigjoolsconfucius say, man who go through check-in desks sideways going to Bangkok10:32
lifelesswhimper10:33
bigjoolsright, I have my first legitimate change to use matchers.MatchesStructure in a test \o/10:33
bigjoolschance, even10:33
=== almaisan-away is now known as al-maisan
jtvbigjools: which policy did you say we could default to?10:49
bigjoolsjtv: the old insecure10:50
jtvOld?10:50
jtvWhat's old about it?10:50
bigjoolswell you're changing the name to an enum10:50
bigjoolsbut that one10:50
jtvOh, yes I am.  So now it's INSECURE.  :)10:50
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
jtvbigjools: I've thrown in a PackageCopyJob.getPolicyImplementation() that gives you the applicable ICopyPolicy.11:19
jtv(Since you're planning to glue it all together)11:20
bigjoolscoo9l11:20
bigjoolswhy not just "getPolicy" ?11:20
jtvBecause that might cause confusion with PackageCopyPolicy.11:20
jtvHorrible, I know.11:20
bigjoolswhat confusion?11:21
jtvYou'd have copy_policy and getPolicy()11:21
jtv—and they'd give you slightly different things.11:21
bigjoolsoh, what does copy_policy return?11:21
jtvEnum value.11:21
jtvThe enum is called PackageCopyPolicy.11:21
bigjools /o\11:22
jtv?11:22
jtvOr is that just the penny of the above horror dropping?11:22
bigjoolsyes11:22
bigjoolsperhaps s/PackageCopyPolicy/PackageCopyPolicyType/ ?11:22
jtvTalk to stub — he seems to have a headache he doesn't need11:22
jtvAaaaaarrrrgh!11:23
bigjoolsPackageCopyPolicy is massively confusing11:23
jtvPackageCopyPolicyDBEnumItemsListType?11:23
bigjoolsthere's already a bunch of XXXCopyPolicy objects11:23
jtvIs there!?11:23
bigjools:p11:23
jtvDamn RIAA.11:23
jtvSorry, for XXXCopyPolicy it'd be the MPAA.11:24
jtvbigjools: ah, but those are the actual ICopyPolicy implementations.11:26
bigjoolsyes11:26
jtvSo that's not very confusing at all11:26
bigjoolsit is to me :/11:26
bigjoolsgah11:27
bigjoolswhatever, I'm too knackered to argue the toss11:27
jtvWhat I have now is: an ICopyPolicy interface, implemented by both SyncCopyPolicy and InsecureCopyPolicy.  That part does not seem difficult.11:27
bigjoolsok11:27
jtvWhat does confuse things a bit is that there's a PackageCopyPolicy enum whose items correspond to those two implementing classes.11:28
jtvBut that's about it.11:28
jtv(And there is no longer a direct inheritance relationship between SyncCopyPolicy and InsecureCopyPolicy.  They just both use a helper class for the common parts).11:29
jtvAlso, and this may help, the docstrings should be fairly clear about the relationship between the policy classes and the policy enum values.11:30
jelmerallenap: hi11:49
allenapjelmer: Hi there.11:49
jelmerallenap: are you still reviewing today?11:49
allenapjelmer: Yes. I have one review to finish then two more in the queue. I'll be able to do yours but not for a few hours.11:50
jelmerallenap: (it seems like you're always on call?)11:50
allenapjelmer: Just Thursdays :)11:50
jelmerhmm, I just must've submitted my last couple of MPs on Thursdays then.. :)11:52
=== al-maisan is now known as almaisan-away
lifelessnight everyone12:07
allenapCheerio.12:08
bigjoolsallenap: helleau, can I have a review for the override stuff plz12:24
bigjoolshttps://code.launchpad.net/~julian-edwards/launchpad/override-class/+merge/6322112:24
jtvWe may have kept him slightly busy.  :)12:24
wallyworldwgrant: just got back from soccer and saw your message. the outer email join does do the preferred check, unless i am mistaken. did you see the version of the query in the mp?12:24
wgrantwallyworld: I was looking at the latest rev of your branch at the time.12:25
wgrantwallyworld: It does that in the WHERE clause.12:25
wgrantBut not in the join condition.12:25
wgrantSo it will join all of them.12:25
wallyworldlet me take a look12:25
wgrantAnd teams are exempt from the preferred check in the WHERE, so all of their addresses will show up.12:25
wallyworldyou taking about the query in the mp?12:26
wallyworldit appears so12:27
wgrantI'm looking at r13133 of your branch.12:27
wgrantI don't have the MP nearby. Let's see.12:27
wallyworldi will have to compare it with the original version of the sql before the changes, but i don't *think* that bit of the logic has changed12:27
wgrantHmmm.12:28
wallyworldand all the tests pass so there's inadequate coverage if there is a problem12:28
wallyworldi thought there was a comment about ignoring email for teams somewhere12:28
wallyworldin the code12:29
wallyworldi will try and find that12:29
wallyworldactually, it is possible to run both versions of the query (old and new) by turning the featureflag on/off12:29
wallyworldwgrant: do you have a search term that shows the issue? is it only apparent on dogfood rather than the sample data?12:30
jtvjcsackett: good morning!  Reviewing today?  If so, https://code.launchpad.net/~jtv/launchpad/db-bug-791737/+merge/63220 :-)12:31
wgrantwallyworld: Oh, the original query has a DISTINCT.12:32
wgrantwallyworld: That would probably solve it.12:32
wallyworldah12:32
wgrantOops.12:32
wgrantAnd my extra stuff to return the rank disturbed that.12:32
wgrantNever mind me.12:32
wallyworldthat's ok. if there is a problem with the query let me know so i can fix it12:33
wallyworldwgrant: btw, the latest badges css stuff works on chrome but fails on ff4 :-( i'll look into it12:34
wgrantwallyworld: Fails how?12:34
wallyworldall the badges are aligned hard right12:34
wallyworldover the top of each other12:34
wallyworldnicely spaced on chrome through12:34
wallyworldi really thought this css shit would be sorted out in 201112:35
wallyworldsigh12:35
wallyworldwgrant: fixed the lazr-js build too. it was indeed a regression in the build.py introduced after rev 20612:36
wgrantwallyworld: Does it work both ways?12:37
wallyworldthe default is the new way and of the dir it expects isn't there (which it won't be for lp where it runs from the egg) it uses the old way12:37
wallyworlds/of/if12:38
NCommandermorning wgrant12:47
wgrantHi NCommander.12:48
NCommanderwgrant: do you plan to be up for a bit longer? I'd like to bridge the discussion on putting SUPERSEDED packages in the indices with bigjools while you are around12:49
wgrantNCommander: Not tonight, I'm afraid.12:49
bigjoolsI am too busy to have a conversation, but why do you want to do that?12:50
NCommanderbigjools: to work towards making archive skew a thing of the past. Having SUPERSEDED but still alive packages in the indices would make it extremely straightforward with the added advantage that apt-cache will also be able to show the status of a package that is still in a state of transition.12:51
bigjoolsyou're talking about packages that still have dependencies on them, right?12:52
bigjoolsI'd rather fix that properly than hacking the publisher to keep superseded packages in the repo12:53
wgrantbigjools: I think this may be the proper fix.12:53
bigjoolsURGH12:53
wgrantHm?12:53
bigjoolsplease no12:53
wgrantThese packages are superseded.12:53
wgrantBut they're not yet to be removed.12:54
wgrantWhich means they are dominated, but not judged.12:54
wgrantWe already do this.12:54
wgrantTo keep sources around when their binaries are.12:54
bigjoolsyes but the implication is that they are disappearing RSN12:54
bigjoolsit's a different situation12:55
wgrantIt's the same situation.12:55
wgrantThere is a newer version, but archive consistency constraints prevent the removal.12:55
bigjoolsit's not an archive consistency issue12:55
bigjoolsit's a dependency issue12:55
wgrantNCommander: Oh, you are still wanting full dependency checking?12:56
wgrantRather than just what Debian has?12:56
NCommanderwgrant: Debian does full dependency checking12:56
wgrantNCommander: Do you have a code pointer?12:57
wgrantThat's not what I understood.12:57
bigjoolsthere's a bug about this somewhere as well12:57
NCommanderwgrant: its handled by britney, which is where their images are built from12:57
wgrantNCommander: That's separate.12:57
* NCommander finds the spec that explains what dak does12:57
wgrantNCommander: britney handles testing migrations.12:58
wgrantIt's not what keeps unstable installable.12:58
elmonothing keeps unstable installable ;-)12:59
wgrantTrue.12:59
NCommanderwgrant: yes, but it doesn't matter if unstable is uninstallable if their images are built from testing12:59
wgrantNCommander: That's completely different from the spec you pointed at last time.12:59
NCommanderwgrant: I'm trying to find it13:00
wgranthttp://ftp-master.debian.org/wiki/projects/arch-all-tracking/13:00
=== almaisan-away is now known as al-maisan
NCommanderhttp://ftp-master.debian.org/wiki/projects/arch-all-tracking/13:01
NCommanderbah13:01
NCommanderyou beat me to it13:01
NCommanderSo to be specific, dak itself doesn't do dependency checking, but britney does.13:02
elmooh, wow, this spec13:02
elmoI suggested this *years* ago13:02
elmoI didn't actually do it though, so...13:02
wgrantNCommander: It's entirely separate.13:02
wgrantNCommander: Implementing britney-style consistency in a single suite is a thoroughly different problem.13:03
jtvbigjools: eod and everything's up for review.  Anything in particular you'd like me to pick up tomorrow morning?13:03
wgrantAnd some orders of magnitude less feasiblwe.13:03
NCommanderwgrant: fair enough13:03
NCommanderwgrant: and for what I need, overkill13:03
wgrantelmo: There are lots of XXXs from 2005 about it.13:04
elmoit's actually a really good idea13:05
elmo;-)13:05
NCommanderwgrant: I suppose its a matter if you see britney as part of Debian publishing infrastructure. I do. I realize opinions on this differ.13:05
wgrantNCommander: It's more part of their release management infrastructure.13:05
wgrantBut possibly.13:05
NCommanderThat being said, from the perspective of someone building images, having all the versions appear is desirable. Then deathrow just needs to be adjusted to make sure death only comes to packages that have been completely superseded13:07
jkakarIs there an alias for lp:~jkakar/+junk/...?  Having +junk in a branch URL always feels bad.13:26
jkakarCouldn't it just be +branches or something?13:26
wgrantPart of the point of +junk is discouragement, I believe.13:27
jkakarOr maybe +sandbox.13:27
wgrantBoth of those have been suggested. There's a bug about that...13:27
jkakarwgrant: Well, it works I guess.. but I have a number of things I will never create a project for.13:27
bigjoolsit's discouragement13:27
bigjoolswe want people to have projects13:27
jkakarwgrant: For example, I keep my emacs configuration in a branch and push it to lp:~jkakar/+junk/emacs.  I don't need (or want) a project for that.13:27
bigjoolsI keep a junk branch for some of my stuff too :)13:28
wgrantBug #14740713:28
_mup_Bug #147407: Junk sounds too harsh <lp-code> <Launchpad itself:Triaged> < https://launchpad.net/bugs/147407 >13:28
jkakarwgrant: Thanks.13:28
jkakarWhy hasn't this been marked 'Opinion'?13:29
* jkakar hides ;b13:29
wgrantI contest some of the interpretation on that bug, though.13:29
wgrantPerhaps it is a locale issue.13:30
wgrantjunk does not seem offensive or childish to me.13:30
allenapbigjools: Sure, I'll review that after I've done a few others.13:30
wgrantAnd indeed, that was the term used on a few uni systems for a similar purpose.13:30
wgrantSo who knows.13:31
bigjoolsallenap: priority interrupt? :)13:31
StevenKbigjools: No queue jumping!13:31
* StevenK waves a big stick at bigjools.13:31
bigjoolsThere has to be some sort of international directive I can invoke13:31
StevenKThe international directive of "Wait your turn, bitch"13:32
wgrantThat's probably just an EU directive.13:32
bigjoolsEU directives amount to "do what we say. oh, and give me all your money"13:34
wgrantI hoped for more of a response than that.13:34
bigjoolsEUSSR ;)13:35
=== jtv is now known as jtv-eat
StevenKIt can't the USSR, it isn't a Commuist regime.13:37
StevenKCommunist, sigh13:37
bigjoolsit has an unelected, authoritarian core, it couldn't be more communist if it tried.13:38
=== matsubara-afk is now known as matsubara
abentleybac: the buildbot failure doesn't look like something I did.  Was it you, or something intermittent? https://lpbuildbot.canonical.com/builders/lucid_lp/builds/100414:13
bacabentley: will look14:14
wgrantbac, abentley: Spurious. The librarian or other random port service decided to listen on buildd-manager's port.14:14
NCommanderbigjools: re: implementing indexing SUEPRSEDED, it has the additional side effect of allowing apt-get to grab all files on disk, which is useful when you want to grab an older source package that won't leave the archive. I'm curious on why you feel though having SUPERSEDED in th eindex is a bad thing. When they get deathrow'ed, they'll be removed from the index14:15
NCommanderso at most its still a handful of packages14:15
bigjoolsNCommander: I will not support indexing superseded.  If they are indexed, they are published.  We need to fix which packages remain published.14:16
wgrantSounds like I have some convincing to do.14:17
=== jcsackett changed the topic of #launchpad-dev to: Performance Tuesday! | https://dev.launchpad.net/ | On call reviewer: allenap, jcsackett | Critical bugs:208 - 0:[######=_]:256
bigjoolswgrant: it's a *very* strong meme in Soyuz that published = in the index14:24
wgrantbigjools: Possibly.14:24
allenapbigjools: I missed your priority interrupt earlier. It came just before X decided that I hadn't seen gdm's loveliness in a while, and that, in the absence of something that is almost, but not quite, entirely unlike tea, to abruptly and irrevocably log me out.14:24
wgrantMore that it's visible to apt, I think.14:24
bigjoolsallenap: lovely!14:26
bigjoolswgrant: superseded is a publishing state, not whether the package is actually superseded14:26
=== mrevell is now known as mrevell-lunch
wgrantbigjools: I always interpreted it as an indication that the publication was superseded.14:27
wgrantbigjools: I think we can sensibly rework this.14:28
wgrantBut it needs much discussion when you are not hideously busy.14:28
wgrantWhich could be a while.14:28
bigjoolsyes14:28
bigjoolsalso, I'm not prepared to spend that much time on it anyway unless it's been officially escalated14:28
bigjoolsbit harsh, but there's a million other things that need fixing too14:29
wgrantIndeed.14:29
allenapbigjools: I wanted to get the tea thing in even though it doesn't make any sense, and I forgot to ask if you want me to review your branch next, or if I should continue on with jtv's?14:30
bigjoolsallenap: nah, I was half joking.  I am sorta blocked on it but I can assume you'll review it with flying colours and just merge it into my dependent branch :)14:31
jcsacketttestSMTPServerIsAvailable is one of the intermittently failing tests we have right now, right?14:34
StevenKallenap: Many thanks for the review. I thought there was a function to do Person -> formattted address, but neither wgrant or myself could think of one.14:38
jcsackettsinzui: time to chat this morning?14:53
sinzuijcsackett: yes14:54
sinzuilet me get some coffee first14:54
jcsackettooo. good idea.14:55
bigjoolsallenap: I am just adding another method to the branch up for review, did you start it yet?14:55
allenapbigjools: Nope, not yet.14:56
bigjoolscoolio14:56
sinzuijcsackett: I am ready. sip?14:59
jcsackettsinzui: sure. ringing you in a moment.14:59
jcsackettsinzui: having a bit of an issue with empathy. one sec.15:02
=== mrevell-lunch is now known as mrevell
abentleyallenap or jcsackett: could you please review https://code.launchpad.net/~abentley/launchpad/ppa-api/+merge/63170 ?16:09
allenapabentley: Sure, I'll take it.16:10
abentleyallenap: Thanks.16:10
bigjoolsthanks for the review allenap16:15
bigjoolsMatchesStructure is great eh16:15
allenapbigjools: That it is.16:16
=== al-maisan is now known as almaisan-away
=== allenap changed the topic of #launchpad-dev to: Performance Tuesday! | https://dev.launchpad.net/ | On call reviewer: jcsackett | Critical bugs:208 - 0:[######=_]:256
allenapSayonara jcsackett, happy reviewing :)16:46
jcsackettciao, allenap. :-)16:47
=== matsubara is now known as matsubara-lunch
=== jelmer_ is now known as jelmer
=== dpm_ is now known as dpm
dpmthanks flacoste for testing the lp-get-ul10nstats17:28
dpmscript17:28
sinzuijcsackett: can you review https://code.launchpad.net/~sinzui/launchpad/picker-suggestion-menu-0/+merge/63260 today?17:29
jcsackettsinzui: i can do it in just a few moments, in fact. :-)17:29
jcsackettsinzui: i see text conflict on your MP.17:32
jtvjcsackett: thanks for the review — I've responded.17:38
LPCIBotProject windmill-devel build #166: STILL FAILING in 1 hr 9 min: https://lpci.wedontsleep.org/job/windmill-devel/166/18:02
jcsackettjtv: thanks for the explanation. r=me. :-)18:08
jtvthanks!18:08
=== matsubara-lunch is now known as matsubara
bigjoolsgood night all18:26
jcsackettsinzui: comment on your MP.18:36
sinzuijcsackett: I just resolved conflicts.18:36
jcsackett\o/18:36
sinzuijcsackett: I see someone listened to lint, but did not run tests. devel is broken, but my branch had the fix18:37
sinzuiyeah for running the tests manually18:37
jcsackettso the only other thing is if "field.initval-suggestions" was meant to be "field.initial-suggestions" or if initval is correct, sinzui.18:38
sinzuijcsackett: initval happens to be the name of a field in the existing test. my spell checker hates it18:38
jcsackettsinzui: dig.18:38
sinzuiI can give it a realistic name or a total nonsense one so we do not think wtf next time18:39
jcsackettsinzui: if you like. i don't know that it is necessary.18:39
jcsackettyou get an r=me without it.18:39
jcsacketti am just waiting ofr the diff to update to make it official.18:39
sinzuiWell, since you were confused, and I was too at first, I will improve the name18:40
sinzuijcsackett: I had a few questions for you in your branch as well18:41
bachi matsubara, a lot of those OOPS in your report cause a server error when i try to look them up.18:42
matsubarabac, can you give me one as an example?18:43
bacmatsubara: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1887O95718:43
matsubarabac, hmm I'll have a look at the logs to confirm, but I think those oopses are old ones that were removed by the oops-pruner but are still in the database18:45
matsubaraso, the pruner removes it from the file system and when oops-tools tries render it, it can't find the file18:45
bacmatsubara: that one i gave you dates back to march of this year18:45
bacmatsubara: how old before they are pruned?  i assume referenced ones are kept?18:45
matsubarabac, IIRC pruner is set to delete oopses older than 30 days18:46
jcsackettsinzui: i saw. i'm preparing a few fixes and will post some answers shortly.18:46
matsubarabac, yep, the ones referenced in the LP database (bug messages, answers, merge proposals, etc) are kept regardless of its age18:46
bacmatsubara: good to know, thanks18:47
LPCIBotProject windmill-devel build #167: STILL FAILING in 45 min: https://lpci.wedontsleep.org/job/windmill-devel/167/18:47
=== salgado is now known as salgado-lunch
sinzuiI think I have the fix for the windmill fail ^. The picker.js was updated to quiet link, but it was not tested. "temp_spinner !== null" will fail because the object is undefined. The code did not work as we thought it did18:58
=== deryck is now known as deryck[lunch]
=== almaisan-away is now known as al-maisan
LPCIBotProject windmill-devel build #168: STILL FAILING in 45 min: https://lpci.wedontsleep.org/job/windmill-devel/168/19:32
jcsackettsinzui: replied to your comment and pushed up some changes.19:41
matsubarabac, I filed bug 791975 for that 500 error. Fix is here: https://code.launchpad.net/~matsubara/oops-tools/791975-deleted-oops/+merge/63277. Would you like to review it? :-)19:44
_mup_Bug #791975: Oops deleted from the filesystem raises an OopsReadError rendering the page <OOPS Tools:Triaged> < https://launchpad.net/bugs/791975 >19:44
=== salgado-lunch is now known as salgado
jcsackettmatsubara: if bac can't, i can look at it.19:47
matsubarajcsackett, that'd be great. thanks!19:48
bacjcsackett: thanks, please do19:48
* jcsackett looks at it.19:48
bacthanks for the quick fix matsubara19:48
matsubarayou're welcome19:48
jcsackettmatubara: r=me.19:50
jcsackettmatsubara, rather. :-P19:50
matsubarajcsackett, thank you! :-)19:50
=== deryck[lunch] is now known as deryck
sinzuijcsackett: I approved your branch20:29
jelmermwhudson: hi20:33
jelmermwhudson: I'm trying to figure out20:33
jelmermwhudson: I'm trying to update bzr on Launchpad, but hitting a strange test failures; I was wondering if you might have an idea20:33
jcsackettsinzui: cool! thanks. :-)20:33
jelmermwhudson: http://pastebin.ubuntu.com/616992/20:34
=== al-maisan is now known as almaisan-away
lifelessmoin20:46
lifelessstatik: we're on today right ?20:46
statiklifeless, yessir20:49
mwhudsonjelmer: oh god, those tests are difficult20:54
lifelessdelete them all20:54
mwhudsonjelmer: has anything changed in bzr around breaking locks?20:56
mwhudsonjelmer: is that the only test that fails?20:56
LPCIBotProject windmill-db-devel build #357: STILL FAILING in 1 hr 11 min: https://lpci.wedontsleep.org/job/windmill-db-devel/357/20:57
james_wwasn't there something about bzr not complaining about its own stale locks?21:07
mwhudsonright, that's in the sort of area that could affect these tests21:12
mwhudsonin fact, it might make some of the games the puller plays unnecessary, and then lifeless' solution (delete the tests, but also the code) comes in to play21:13
=== Ursinha is now known as Ursinha-afk
=== salgado is now known as salgado-afk
lifelessmwhudson: I was being HHOS22:06
lifelessmwhudson: but - moving this out to a microservice would be awesome22:06
mwhudsonlifeless: HHOS?22:07
elmohaha only serious22:07
flacosteabentley: how do i get the default cover template when using lp-propose?22:21
abentleyflacoste: install lp-review-body (should be in the ppa)22:23
flacosteabentley: ok, thanks22:24
lifelessmatsubara: whats south ?22:26
matsubaralifeless, it's the schema migration tool for django22:26
lifelessthanks22:26
matsubaralifeless, http://south.aeracode.org/22:27
flacosteabentley: how does I use it afterwards? i thought lp-propose would use it automatically22:27
abentleyflacoste: It does.  It uses the target branch of the merge proposal to decide whether to supply the launchpad-specific template.22:29
flacosteabentley: any idea why it didn't pick it over here?22:30
abentleyflacoste: what target branch is it showing?22:31
flacostethe merge proposal is created with lp:launchpad22:31
flacostehttps://code.launchpad.net/~flacoste/launchpad/bug-365098/+merge/6330122:31
=== matsubara is now known as matsubara-afk
flacostewas created using lp-propose22:31
flacosteafter having installed the package22:31
flacosteoh22:32
abentleyflacoste: Do you still have the editor window up?  That gives the exact URL that was used.22:32
flacostei see that i have old lpreview and lpreview_body in my .bazaar/Plugins22:33
flacostei'll delete those22:33
abentleyflacoste: it should match 'bzr\+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/(db-)?devel'22:34
flacosteabentley: deleting the plugins in my home directory did the trick :-)22:34
flacostesorry for the noise22:34
abentleyflacoste: Oh, cool.22:34
=== jcsackett changed the topic of #launchpad-dev to: Performance Tuesday! | https://dev.launchpad.net/ | On call reviewer: - | Critical bugs:208 - 0:[######=_]:256
LPCIBotProject windmill-db-devel build #358: STILL FAILING in 1 hr 7 min: https://lpci.wedontsleep.org/job/windmill-db-devel/358/22:50
maxbIs there an email interface for opening new questions in the answers app?22:50
sinzuino22:56
sinzuimaxb: We assume the user is not an engineer and has no idea how to do it even if we built it22:56
maxbRight. Makes sense. Was just trying to be really sure about a user who was claiming to be unable to access the account that they had asked a question as22:57
wallyworldsinzui: the positional style "initial" for the badges doesn't work on ff4. however, "relative" works on both ff4 and chrome. I've not come across "initial" before. I only know about "absolute", "fixed" "relative", "static"23:07
lifelesscody-somerville: hi https://launchpad.net/bugsy/development/23:10
lifelesscody-somerville: could you check its performance for you please?23:10
cody-somervilleyay! it loads :)23:11
lifelesswhat was the render time ?23:11
lifelesscody-somerville: ^23:12
wallyworldlifeless: 1.87 seconds for me :-)23:16
lifelesswallyworld: needs to be cody to test23:17
lifelesswallyworld: it was scaling due to team membership23:17
wallyworldah sorry23:17
lifelessnothing to be sorry about23:19
lifelessjust explaining why I asked cody rather than just doing it myself :)23:19
=== wallyworld changed the topic of #launchpad-dev to: Performance Tuesday! | https://dev.launchpad.net/ | On call reviewer: wallyworld* (jtv) | Critical bugs:208 - 0:[######=_]:256

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!