| * gmb lunches | 11:54 | |
| bac | are we chatting? | 13:30 |
|---|---|---|
| gmb | bac: Gary's out until 10. | 13:30 |
| gmb | (I think). | 13:31 |
| gmb | (And I'm assuming that it's 08:30 for you) | 13:31 |
| benji | bac: heh, apparently you and I have the same taste in bugs | 13:31 |
| bac | benji: did you grab 211830 too? | 13:32 |
| benji | almost ;) | 13:32 |
| bac | gmb: yes, gary's out but his email ends with "agree among yourselves as to whether to actually have the call." | 13:32 |
| gmb | Oh. | 13:33 |
| bac | i vote a strong -0 | 13:33 |
| gmb | Yeah, I'm firmly -0. | 13:33 |
| bac | benji: the fix for that will be easy...generating the test data not so much | 13:33 |
| * danilos abstains | 13:36 | |
| gmb | danilos: Do you have any idea why I'd be seeing this: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1980STAGING71 when looking at this: https://bugs.staging.launchpad.net/ubuntu/+source/bash-completion/+bug/752193 as an anonymous user? | 15:36 |
| _mup_ | Bug #752193: Installation of the acroread package causes completion to treat directories like files with some commands <amd64> <apport-bug> <natty> <acroread (Ubuntu):Confirmed for brian-thomason> <bash-completion (Ubuntu):Won't Fix> <bash-completion (Debian):Won't Fix> < https://launchpad.net/bugs/752193 > | 15:36 |
| gmb | Wait... this makes no sense whatever. | 15:37 |
| gmb | danilos: Ignore me, I think something's broken with the OOPS machinery. | 15:37 |
| danilos | gmb, yeah, I think it seems to be the wrong oops prefix setting somewhere | 15:37 |
| danilos | gmb, actually, it seems as if staging is missing some oops configuration | 15:38 |
| gmb | Ah. | 15:38 |
| gmb | Botheration. | 15:38 |
| gmb | I shall talk to t'LOSAs. | 15:38 |
| danilos | gmb, I always get baffled when I see OOPSes like these, unfortunately, making sure that all the scripts have right oops prefixes is tedious :/ | 15:39 |
| gary_poster | danilos, approved expenses | 15:39 |
| danilos | gary_poster, cool, thanks (and welcome back :) | 15:39 |
| gary_poster | gmb, could talk to matsubara too | 15:39 |
| gary_poster | thanks :-) | 15:39 |
| gmb | danilos: Yeah. It's especially annoying since it seems to be a reproduction of the unreproducible bug. | 15:39 |
| danilos | gary_poster, I am sure you'd like to hear that with your and my branches merged, bugtask_index_portlets.js is entirely gone (along with subscriber.js) | 15:40 |
| gary_poster | yaay!!! | 15:40 |
| gary_poster | :-) | 15:40 |
| gary_poster | subscriberlist too, or is that used somewhere? | 15:40 |
| gary_poster | subscribers_list.js | 15:41 |
| danilos | gary_poster, I need to do a few more cleanups in my branches and then it's all up for review (6 branches total, not counting yours) | 15:41 |
| danilos | gary_poster, that's where I'm moving my stuff, but yes, existing methods from it are gone | 15:41 |
| gary_poster | cool :-) | 15:41 |
| gary_poster | danilos, how do you think we should get the review? I was thinking about this. When we actually merge, AIUI we'll be merging to devel | 15:41 |
| gary_poster | but setting that in the MP will create insane diffs | 15:42 |
| gary_poster | we could also review each other's branches outside of the MP system beforehand | 15:42 |
| danilos | gary_poster, right, I was thinking of getting branch-by-branch review; for me, it's going to be easy since lpreview DTRT with pipelines | 15:42 |
| gary_poster | (and then copy over the reviews when its actually time to merge) | 15:43 |
| gary_poster | danilos, well...you | 15:43 |
| danilos | gary_poster, that's an option as well :) | 15:43 |
| danilos | gary_poster, I'd be happy to review your branch | 15:43 |
| gary_poster | will need to get an MP based on my branch... | 15:44 |
| gary_poster | (I assume) | 15:44 |
| danilos | gary_poster, well, when does db-stable get merged into devel? On Monday? | 15:44 |
| gary_poster | I think so--maybe even Robert's Monday | 15:45 |
| danilos | gary_poster, (fwiw, I am not going to review your branch today, so if it's Monday, you can propose a merge against devel and it should become clean on Monday) | 15:45 |
| gary_poster | it would become clean once I merged Monday-merged-devel and pushed it | 15:46 |
| gary_poster | Which would be easy to do... | 15:47 |
| gary_poster | so yeah | 15:47 |
| gary_poster | I'll make an MP today | 15:47 |
| gary_poster | against devel | 15:47 |
| gary_poster | mark it as not ready for review | 15:47 |
| gary_poster | then my Sunday evening I'll see if db-devel has been merged with devel | 15:48 |
| gary_poster | and if it is | 15:48 |
| gary_poster | I'll merge devel in and push it and mark the MP as ready | 15:48 |
| danilos | gary_poster, shouldn't LP do this automatically? | 15:48 |
| gary_poster | I don't think so | 15:48 |
| danilos | gary_poster, (i.e. when the merge-target branch changes, it should recalculate the diff) | 15:48 |
| gary_poster | I could be wrong | 15:49 |
| gary_poster | we can find out :-) | 15:49 |
| danilos | gary_poster, ok then, you might not even have to merge anything but just do a "bzr ci --unchanged" to trigger a rescan | 15:49 |
| gary_poster | maybe so | 15:49 |
| gary_poster | danilos, the last part of this is merging in benji's rip-out-the-flag branch | 15:49 |
| gary_poster | I can do that today | 15:49 |
| danilos | gary_poster, well, than one is... "interesting"... I'd prefer to leave it for last | 15:50 |
| gary_poster | yeah, that's fine | 15:50 |
| danilos | gary_poster, (just because it's easier to re-do stuff in that branch if we get a weird conflict, then in other branches) | 15:50 |
| gary_poster | that was one of my options: make a new branch based on your last one | 15:50 |
| gary_poster | and then merge in benji | 15:50 |
| gary_poster | 's | 15:50 |
| gary_poster | benji probably doesn't want to be merged in; his family would be surprised | 15:51 |
| gary_poster | oh, btw danilos, I ran ec2 test last night on my branch. There were two errors. I didn't look at them closely, but I think they will be easy. So you'll need to get those fixes, maybe | 15:52 |
| gary_poster | so anyway, danilos, you ok with that plan for ripping out the feature flags? (1) you point me to the last branch of your work; (2) I branch it; (3) I merge in benji's branch and fix stuff up | 15:53 |
| danilos | gary_poster, right, I can re-merge your branch into the "base" of my branch | 15:54 |
| danilos | gary_poster, as for benji's branch, that'd be fine, but I'd like to do the remaining cleanups first | 15:54 |
| danilos | gary_poster, you can still get it merged with db-stable locally, but I'd only prefer not to have it landed first | 15:55 |
| gary_poster | danilos, completely agreed that it would be landed last | 15:56 |
| gary_poster | I just want us to have already handled the big changes that we have introduced | 15:56 |
| danilos | gary_poster, right, but considering we have not feature-flagged anything, I'd say that's pretty much a given | 15:57 |
| gary_poster | sorry, which part is a given? | 15:57 |
| danilos | gary_poster, big changes we have introduced should not cause too much complex merging issues with benji's branch | 15:58 |
| gary_poster | mm, maybe so. Probably just lots of those "yes, I *really* want to delete these parts, thanks" conflict resolutions | 15:59 |
| danilos | gary_poster, right, but sure, I'm pushing my final branch (well, all of them together) to lp:~danilo/launchpad/bug-772754-other-subscribers-remove-cruft | 16:01 |
| gary_poster | cool | 16:01 |
| gary_poster | danilos, if you are still around, are you planning on removing lib/lp/bugs/stories/bugs/xx-bug-personal-subscriptions.txt or on trying to make it sane in the new context? I've made it so it passes locally, but it shows how +subscribe only kinda sorta makes sense in the new world. I'm OK with that myself, and I'm inclined to check in as is, but it will affect you too, at the very least because there are "Subscribe | 17:00 |
| gary_poster | My current plan: check it in as is, have you deal with it :-P | 17:00 |
| danilos | gary_poster, sounds good to me, I am pretty sure I've still got a few tests to remove which are for all the removed views that gathered bits and pieces of all the subscriptions data | 17:01 |
| gary_poster | danilos, cool. I just pushed test fixes to lp:~gary/launchpad/bug-772754-2 . Going for walk/lunch now, so will talk to you Monday (and should have MP waiting for you then). Have a great weekend! | 17:01 |
| * benji now knows how to copy the Firefox saved password DB from one profile to another. | 17:03 | |
| danilos | gary_poster, thanks, so do you! | 17:18 |
| gmb | Is it an unproductive day if you spent it mostly fixing other peoples' problems? | 17:24 |
| danilos | gmb, it's not unproductive for them! | 17:26 |
| gmb | Fair point. | 17:27 |
| danilos | anyway, out, enjoy all | 17:27 |
| gmb | gary_poster: I just submitted my EC2 expenses for April and May. I think they need approving before the weekend, but I can't remember what the cutoff is. | 17:51 |
| * gmb EODs. | 18:11 | |
| gary_poster | gmb, benji, I approved your canonicaladmin requests | 18:47 |
| gary_poster | bac, you there? If so, do you happen to know how to look at the emails that launchpad.dev has sent out directly, via sendmail? In particular, I'm trying to validate a team's contact address so I can qa something locally that requires a team with a contact address | 21:08 |
| bac | benji: hi gary_poster | 21:08 |
| gary_poster | hi | 21:09 |
| bac | gary_poster: on my system, emails to bac@canonical.com get redirected to root@localhost | 21:09 |
| bac | so i can read them locally | 21:09 |
| gary_poster | but bad emails don't leave a log anywhere? | 21:09 |
| bac | i'm not sure what mechanism is actually doing that | 21:09 |
| gary_poster | yeah ok | 21:09 |
| bac | gary_poster: after lots of investigation i closed a couple of bugs related to OOPS and email processing | 21:17 |
| gary_poster | cool, bac | 21:17 |
| bac | gary_poster: examining the code i don't see how it is possible for an OOPS to be generated due to fixes abentley and mbp did a while back | 21:18 |
| gary_poster | great | 21:18 |
| bac | though we have seen OOPS as recent as january...so it is a bit befuddling | 21:18 |
| gary_poster | I take it abentley/mbp fixes were before then? | 21:18 |
| bac | yes but not by much | 21:19 |
| gary_poster | hm | 21:19 |
| gary_poster | no idea :-/ | 21:19 |
| bac | authenticateEmail is called from exactly one place and it is now in a try/except InvalidSignature...the exception shown in the OOPS | 21:20 |
| gary_poster | heh | 21:20 |
| bac | so, fingers crossed it is actually fixed | 21:20 |
| gary_poster | yeah, sounds reasonable to just wipe your hands | 21:20 |
| gary_poster | bac, are you @ EoD? | 22:16 |
| bac | gary_poster: still here | 22:16 |
| bac | finishing up a review then turning to a pumpkin | 22:16 |
| gary_poster | bac, how much longer? I'm seeing if I can get a branch reviewed | 22:16 |
| gary_poster | oh ok | 22:16 |
| gary_poster | cool, nm then | 22:16 |
| gary_poster | have a great weekend | 22:17 |
| bac | no, i don't mind. | 22:17 |
| bac | send it on | 22:17 |
| gary_poster | really really? | 22:17 |
| gary_poster | ok I will thanks | 22:17 |
| bac | np | 22:17 |
| gary_poster | bac, https://code.launchpad.net/~gary/launchpad/bug792493/+merge/63431 | 22:23 |
| bac | thx | 22:25 |
| gary_poster | I'll be back in about 15 | 22:26 |
| bac | gary_poster: hey do you know if we have a preference in the for either en_US or en_GB ? | 22:26 |
| gmb | bac: Do you have a second to give me a quick review for this: https://code.launchpad.net/~gmb/launchpad/bug-772609-hopefully-without-breaking-anything-this-time/+merge/63432 | 22:34 |
| gmb | Fixes a bug with the fix for 772609 | 22:34 |
| bac | gmb: done. late night! | 22:36 |
| gmb | bac: Yeah, it annoying me, so I thought I'd better fix it now rather than fixate on it over the weekend. | 22:36 |
| gmb | Thanks. | 22:37 |
| bac | gmb: while you're here... | 22:37 |
| gmb | Yarp? | 22:37 |
| bac | initialise vs. initialize in the UI? | 22:37 |
| gmb | bac: IIRC we use American English for the UI, so *ize. | 22:37 |
| bac | i mean, written on the web page | 22:37 |
| bac | there was some flip-flopping a while back and i wasn't sure where it landed | 22:37 |
| gmb | I'd go with initialize. | 22:38 |
| bac | thanks. bye. | 22:38 |
| gmb | Np. | 22:38 |
| * gmb -> exeunt, in pursuit of beer | 22:38 | |
| gary_poster | bac, I think it is US | 22:44 |
| bac | yes, that's what i went with | 22:45 |
| gary_poster | cool | 22:45 |
| bac | i do recall matthew saying something about en_GB being preferred...perhaps in the dev wiki? | 22:45 |
| gary_poster | I dunno | 22:45 |
| bac | it confused me then and i haven't gotten over it | 22:45 |
| gary_poster | heh | 22:45 |
| gary_poster | If we are supposed to use GB, I haven't gotten the memo...ever. | 22:46 |
| bac | gary_poster: the main part of your branch looks good and i don't have any comments on it. | 22:48 |
| gary_poster | cool bac. What's the non-main part of my branch? :-) | 22:48 |
| bac | but on the handler detaching, previously we thought there might be multiple handlers and your code now reads as if we know there is exactly one | 22:49 |
| bac | is that right? | 22:49 |
| gary_poster | bac, yeah | 22:49 |
| gary_poster | no one ever fires that event with multiple | 22:49 |
| bac | ok | 22:49 |
| gary_poster | and it did not handle the case of single | 22:49 |
| bac | ugh | 22:49 |
| bac | cool, let me mark it approved. | 22:49 |
| gary_poster | (which was what was actually happening, so the detach was never happening) | 22:49 |
| gary_poster | cool. thank you much, bac. have a great weekend! | 22:50 |
| bac | you too. | 22:50 |
| bac | bye | 22:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!