[13:27] <gary_poster> bac danilos gmb, kanban now, call in 3
[13:28] <gmb> k
[13:28] <bac> ok
[13:46] <gary_poster> danilos, thank you for the good review.  fwiw, the reason why I liked the many functions inside the gigantor JS function is that it lets you bind local variable *identities* cleanly and without fuss (specifically, the "overlay" var, which changes when you click it since I recreate the overlay each time).
[13:46] <gary_poster> I have a couple of alternate approaches in mind, and I'll pursue them since I know what you say has merit, but it will be more annoying.  Maybe I can make them not much more annoying, let's see.
[13:47] <danilos> gary_poster, I know, but I specifically highlighted those functions which I don't see using the overlay variable
[13:47] <danilos> well, parts of the code if not functions :)
[13:47] <gary_poster> danilos, they do, because they use make_actions, which needs to know the overlay (for the clean up function if nothing else)
[13:48] <danilos> gary_poster, oh, right
[13:48] <gary_poster> So, like I said, there are alternate approaches
[13:49] <danilos> gary_poster, sure, there are plenty of them; I am not highly opposed to you landing as is, fixing other problems (since this might require more work that you don't want to invest right now)
[13:50] <gary_poster> danilos, OK, I'll look into that for a bit and see what I can do, and punt if I don't see something I like.  Let's talk about the thing I'm more worried about: the UI issues
[13:50] <danilos> gary_poster, right
[13:50] <gary_poster> danilos, I think a <ul> is a good idea
[13:51] <gary_poster> Want me to try that, and see what your reaction is?
[13:51] <danilos> gary_poster, right, but that wouldn't work well with edit icons imho
[13:51] <gary_poster> Yeah
[13:51] <danilos> gary_poster, sure thing if you feel like that might work
[13:51] <gary_poster> I thought that's what you were suggesting though
[13:51] <danilos> gary_poster, I was, but then I am pretty sure you'd have to kill edit icons
[13:51] <gary_poster> because it would be dot-image-words?
[13:52] <danilos> yeah
[13:52] <danilos> maybe move the edit icon to the end, though there's probably no ready CSS class for that
[13:52] <danilos> 'ready' == 'already made' :)
[13:52] <gary_poster> no, there's not, and it's another precedent-breaking thing--maybe more problematic
[13:52] <danilos> true
[13:53] <danilos> gary_poster, it might be worthwhile to check if huw or mrevell have any opinion/suggestion
[13:53] <danilos> mrevell, even though not a UI designer, can sometimes come up with good ideas as well :)
[13:53] <gary_poster> danilos, yeah.  ok, I'll make a screen shot and try him
[13:53] <danilos> cool, thanks
[13:54] <gary_poster> thank you!
[14:30]  * bac found an interesting Critical bug...that i likely caused.  guess i should claim it.
[14:42] <gary_poster> heh
[14:47] <bac> it's amazing how many wrapper frameworks exist for authenticating lplib.  just discovered lpltk.  if only we'd provided 'login_with' from the beginning...
[14:54] <gary_poster> yeah :-/
[14:57] <gary_poster> danilos, I sent off a note to mrevell with some screenshots; I'll let you know what he has to say.
[14:57] <gary_poster> I have another question about the review, while I'm waiting.  You say this about BugSubscriptionPortletView.initialize:
[14:57] <gary_poster> I find this interesting.  What happens with eg. LIFECYCLE duplicate subscription? How are we to show that in the UI?  Should my code include the current user among the 'Other subscribers' if they have a duplicate subscription?
[14:58] <gary_poster> If the user has a LIFECYCLE duplicate subscription, it will simply show at the top, "You have subscriptions that may cause you to receive notifications, but you are not directly subscribed to this bug's notifications."  Then they can click on "Edit bug mail" to see details, as usual.
[14:58] <gary_poster> This seems consistent and OK with me--why should we have to tell people about duplicate subscription details here, but not the details of other subscriptions, like assignee or all the other variants?
[14:58] <gary_poster> Because of that, my answer to your last question is "no".  :-)
[14:58] <gary_poster> Thoughts?
[15:02] <gary_poster> biab
[15:52] <gary_poster> (been back for quite awhile fwiw, in case you wre waiting forme danilos :-P )
[16:00] <gary_poster> CHR!
[16:07] <gary_poster> anyone remember the name of the project we are supposed to use when we are just trying to make a bug go away?  I have searched for "nothing" "none" and "empty" and have not found it.  bac, do you remember?
[16:07] <bac> null
[16:07] <bac> ?
[16:08] <bac> https://launchpad.net/null
[16:08] <gary_poster> ah-ha, yes, thanks bac
[16:48] <gary_poster> gmb, danilos, I just asked deryck why the following feedback ticket has no reply on it for the entire last week while the poor guy was emailing us repeatedly, but I also want to ask you if you had seen it when you looked at RTs this morning?
[16:48] <gary_poster> https://support.one.ubuntu.com/Ticket/Display.html?id=2120
[16:48] <gary_poster> It seems like I always have a lot of spam RTs to delete too
[16:49] <gmb> gary_poster: I completely forgot to check the RT queue this morning; my bad - I got sidetracked by needing to get an RC for my branch.
[16:49] <gary_poster> gmb, understood
[16:54] <danilos> gary_poster, sorry, got completely immersed in my branches and haven't noticed the pings
[16:54] <danilos> gary_poster, going through your questions in order :)
[16:55] <danilos> gary_poster, the problem with *your* duplicate subscription in "Other subscribers" is that, well, it's not "other" but yours :)
[16:57] <gary_poster> danilos, gotcha, I think: yes, my intent was that the current user would not be listed in "Other subscribers" anywhere: people should go to "Edit my bugs" for that
[16:57] <danilos> gary_poster, and it's also the only other one where you can have a specific bug_notification_level for that particular bug (i.e. it applies just as much as a direct subscription does; unlike eg. bug supervisor or product owner: for assignee, we make a direct subscription)
[16:57] <gary_poster> structural subscriptions can also have a level danilos
[16:57] <danilos> gary_poster, right, so how is the current user to know that they do have a subscription to a duplicate unless they go to the "edit bug mail" page?
[16:58] <danilos> gary_poster, right, but that's not "for that particular bug"
[16:59] <gary_poster> danilos, not following.  Wanna call?
[16:59] <danilos> gary_poster, yep
[16:59] <gary_poster> When's your EoD anyway? :-)
[16:59] <danilos> gary_poster, yesterday? :)
[16:59] <gary_poster> heh
[17:00] <danilos> gary_poster, let's chat now about this and then I'll be EoDing soon :)
[17:00] <gary_poster> heh, ok
[17:07] <gary_poster> https://dev.launchpad.net/MaintenanceRotationSchedule
[17:29] <gary_poster> lunching
[18:45] <bac> why can i never remember that
[18:45] <bac> AttributeError: 'NoneType' object has no attribute 'makefile'
[18:45] <bac> reported from launchpadlib means:
[18:45] <bac> Apache is not running
[18:45] <bac> ?
[18:45] <bac> it's so damned obvious
[19:06] <bac> gary_poster: argh!  look at this logo: http://www.blogcdn.com/www.engadget.com/media/2011/06/stevejobswwdc2011liveblogkeynote0425.jpg
[19:06] <gary_poster> bac, heh, yeah that looks prettttty familiar
[19:06] <bac> geez