/srv/irclogs.ubuntu.com/2011/06/07/#launchpad-yellow.txt

=== Ursinha is now known as Ursula
=== Ursula is now known as Ursinha
gary_posterbenji and bac, hi.  are either of you looking for a bug to tackle?13:20
bacgary_poster: i will be shortly13:20
gary_posterbac, cool.  benjim welcome to the other channel :-P13:21
benjigary_poster: tag, you're it13:21
gary_poster:-)13:21
benji:P13:21
gary_posterbac, benji, just forwarded you an email13:23
* bac just made a rule to zap vcs-import mail and can see clearly again13:23
gary_posterheh13:23
gary_postergood idea13:23
benjiyeah, my rule got 400+ messages when I made it; that seems like something we should fix13:24
gary_postergmb, for bug 772609, question for the call lest I forget: what does status of bug 772609 mean to deployment?  Is it worthwhile talking about whether we can make the fix on top of the branches Danilo and I are working on for after the db deployment?13:29
gary_posterbac benji danilos gmb: kanban now, call really close to now13:29
gmbgary_poster: The fix has been rolled back and we can happily make the fix on top of yours and Danilo's branches.13:29
gary_posterok cool13:29
gary_postercause I think I might have ripped out some or all of the bits you are talking about in the most recent traceback13:30
gmbAh, okay.13:30
gary_posterthat Skype experience was weird13:31
gary_posterbenji, there's actually a bug number in there13:31
gmbNice, skype won't let me sign in...13:32
gary_posterhmmmmm....13:32
gary_posterSkype is not happy....13:32
* gmb restarts skype13:32
benjiyeah, my skype isjust spinning13:32
gmbGlad it's not just me...13:32
gary_posterI can't log on now...13:33
gary_posteruh, danilo, how's the mumble going :-D13:33
bacmy skype launched but says none of my contacts are online13:33
gary_posterI wonder how it would work on Windows :-P13:34
gary_posterbac benji danilos gmb, everyone join me on mumble who can, please13:34
* benji installs mumble13:35
* danilos tries and hopes for the best13:35
gary_postermeh13:35
bacok.  haven't mumbled since upgrading to natty13:35
danilosgary_poster, nope, it's blocked13:36
gary_posterI see danilos, but he is muted and deafened13:36
danilosgary_poster, what it used to do was kill my entire audio stack until I reboot (maybe playing with unloading/loading modules might work, but I never spent time to debug that)13:36
danilosgary_poster, hum, let me try something13:37
danilosnope, it seems to have problems with localized sound card names that it seems to get from pulseaudio13:39
gary_posterbenji, (1) how goes mumble, (2) did you happen to run test suite with your "rip out feature flag" branch?13:39
benji"The remote host closed the connection."13:39
benji2) I ran -m lp.bugs13:40
gary_posterdanilos we can hear you13:40
benjimumble is not connecting for me13:43
=== Ursinha is now known as Ursula
=== Ursula is now known as Ursiha
=== Ursiha is now known as Ursinha
bacempathy?13:51
gary_posterbenji, try skype again?13:52
baci think you can do empathy voice-only calls but i've not tried13:52
gary_posterok13:53
bacif not i have some electrical tape i can put over my camera13:53
gary_posterlol13:53
benjitrying skype13:53
gary_posterk13:53
benjiworking on email incedent too13:53
gary_posterbenji, well...that's one of the things I want to talk to you about :-)13:53
benjigary_poster: if need be we can have a POTS call13:54
gary_posterbenji...that's unthinkable!13:55
benjiheh13:56
gary_posterbenji, I'm logged into Skype, but I'm guessing either you can't, or they have some weird split thing going on.13:56
benjimine keeps spinning like it's trying to connect13:57
danilosmy skype seems to be fine, and I can see Gary and gmb14:23
danilosthough, I haven't logged off since yesterday14:23
gary_posterI see you but that's it14:23
gary_posterI've logged on and off several times, and for awhile there was noone at all14:23
danilosinteresting, have you tried calling someone even if they appear offline?14:24
gary_posternot lately14:55
gary_posterdanilos, when you get a chance, would you please take a look at https://devpad.canonical.com/~gary/mockup.png and give me your opinion?  I prefer B and B-1 for consistency with the structural subscription options.  Option A variants are slightly more usable because of fewer clicks, but then my original was even easier in that regard.  I'll ask mrevell too.14:57
gary_posteranyone else is welcome to chime in too, btw :-)14:57
* danilos looks14:58
benjigary_poster: I think the A family is slightly better because I think it'll be easier for people to choose from a linear set of options instead of a branching set (i.e., the check box)15:00
gary_posterbenji, I agree about usability, what about consistency?15:02
danilosgary_poster, I kind of like the explicit "or" in B-1 combined with a linear set of options (i.e. in A-1 "Remove your subscription" doesn't seem distinct enough)15:02
gary_posterdanilos, A-3?15:02
danilosgary_poster, right, it's a very wide image, haven't noticed it so far :)15:03
gary_poster:-)15:03
gary_posterdanilos, the only diff is that A-3 has the current option as a radio button15:03
gary_posterwhile A-1 has the current option as text15:03
benjigary_poster: Isn't option A consistent with how we ask about direct subscriptions?15:04
gary_posterA-3 seems the best of the A-line15:04
benjiI don't think we need the "or"; all of them are "or" options15:04
danilosgary_poster, A-3 also has the separation between "unsubscribe" and "choose level" options, no?15:04
danilosbenji, but they are clearly actions of the distinct nature, and one might simply be looking for "unsubscribe"15:05
gary_posterdanilos, yeah, sorry, I meant, A-1 with "or" is still different than A-3 because of the radio button thing15:05
danilosnot distinct per se, but it kind of feels as if unsubscribe is the most common action15:05
gary_posterbenji is arguing for the A line I think, not A-1 in particular15:05
danilosgary_poster, right, understood15:06
danilosgary_poster, fwiw, I don't mind the B-1 either, I just find it a bit confusing and hard to clearly present, but then there's the consistency argument15:07
danilos== hard to clearly present available options15:07
gary_posterbenji, what I have right now in the branch under review (and that is regarded as confusing) is consistent with "edit your bugs": action links.  I can put up a mockup in case inspiration might strike.  Option B is consistent with structural subscription options.  option A I'd argue is consistent with not much :-)15:07
danilosgary_poster, hehe, A is consistent with static +subscribe page :) not that it's relevant15:08
gary_posterdanilos, lol :-P15:08
danilosgary_poster, I think the only problem I have with B-1 is that I'd prefer the checkbox to read "Exclude comments" if the choice above it is "everything"15:09
benjimaybe it's because I haven't had my coffee yet, but option A looks a lot like what I see if I visit a bug and click "Subscribe" (the words are a little different and the options are in a different order, but that's fixable)15:09
gary_posterbenji, right, but that's what we are replacing :-)15:09
gary_posterbenji, fwiw: https://devpad.canonical.com/~gary/PastedGraphic-1.png https://devpad.canonical.com/~gary/PastedGraphic-2.png15:10
benjiwell then, that changes things :)15:10
danilosbenji, because that's coming from the static +subscribe page by loading the form using ajax15:10
danilosgary_poster, benji: I think we should just agree that B-3 is to everybody's taste and go with that15:11
gary_posterdanilos: exclude comments: yeah, that's a "too many cooks" issue we have from structural subscriptions.  Jono wanted the checkbox as it is there too, because he wants checkboxes to be positive choices, not exclusions15:11
gary_posterdanilos: +1 :-)15:11
benjiI really like the links-as-actions approach here, especially PastedGraphic-2.15:12
gary_posterheh, I did too :-P15:13
gary_posterdanilos was confused though15:13
gary_posterand Huw agrees that radio buttons should rule the world :-)15:14
gary_poster(not so strongly that we couldn't override, I think, but still)15:14
gary_posterThe link approach is also faster to use, as danilo pointed out15:15
gary_posterand it is consistent with "edit your bugs"15:15
gary_posterEdit bug mail, I mean15:16
danilosbenji, radio boxes clearly indicate to anyone who's been using computer UIs that there's one selected option of all the potential choices15:16
=== Ursula is now known as U
=== U is now known as Ursinha
danilosbenji, for instance, in PastedGraphic-2, if I didn't know the underlying implementation details, I don't think I'd ever have guessed that the middle text indicates the selected option15:16
danilosgary_poster, benji: perhaps it'd be much better if the "choice" (plain text) was moved to the top15:17
gary_posterThat would be easy to do, and I think an improvement.15:18
gary_poster(I had it where it is so you could easily see relative subscription levels)15:18
danilosgary_poster, right, so my preferences would be A-3, B-1 and then that :) we know which one is the simplest to implement ;)15:19
gary_posterheh15:19
gary_posterbenji, do you care to do a ranking?15:20
benjigary_poster: A-1, A-2, A, B, A-3, B-3, B-215:25
benji(my guess as to how they will perform in user testing from best to worst))15:26
gary_posterbenji, where does PastedGraphic-2 fit into that?15:27
benjihmm...15:27
gary_posterand did you really mean B-3, the absent choice? :-)15:27
danilosyeah, you can't rank it that low!15:28
gary_posterOr do the last two have an off-by-one error15:28
benjigary_poster: fixed ranking: PastedGraphic-2, A-1, A-2, A, B, A-3, B-2, B-115:28
gary_poster:-) ok got it, thanks15:29
gary_posterbased on that, you two average out to me doing nothing at all!  woo hoo!  ;-)15:29
gary_posterI'll mention this to mrevell.  I'm inclined to do the "move the text to the top of PastedGraphic-2 and move on" as you might expect.15:30
bachi gary_poster -- looking at the MP mbp did (https://code.launchpad.net/~mbp/launchpad/788874-mail-oops/+merge/63343) i'm not sure why it was rejected.  i think lifeless was wrong in his assessment.15:55
bacgary_poster: well, i *do* understand why you rejected it...i just think it is a viable solution afterall15:56
gary_posterbac, ok.  yeah, I was just going on the conversation.  You are the engineer on it, and I'm happy for you to make a call.  I'm also happy to dig into it if you'd like me to.15:58
bacgary_poster: there have been other suggested actions to take but i think martin's approach makes sense15:59
gary_posterCHR!16:07
bacgary_poster: have you been running the lp2kanban script?  i never see my cards updated.  am i doing something wrong?16:12
gary_posterbac, no, I haven't. :-P  benji said I had to change something or other in order to point to the proper board, and while I'm sure that is super easy, it has kept me from pursuing it yet.  Sorry. :-(  I'll get on it.16:14
benjigary_poster: my mumble problems look like a networking problem; I did a packet capture and see lots of retransmissions and duplicate ACKs16:14
bacgary_poster: was just curious16:14
gary_posterbeji, weird16:14
gary_posterbac, cool16:14
gary_posterok, chr done16:35
gary_posterrunning to anniversary lunch :-)16:35
gary_posterbiab16:35
* danilos -> out16:57
bacgary_poster: you have a moment to do an inflight sanity check / pre-review?19:24
gary_posterbac, heh, sure19:24
bachttp://pastebin.ubuntu.com/621121/19:24
bacit should be pretty much complete....modulo me not understanding option 1 mbp presented in the bug19:24
gary_posterk19:25
baci'd like to get your interpretation of his #1 and robert's response19:25
gary_posterk, lemme get bug up19:26
gary_posterbac, I understand poolie's option 1 by omitting ", or the in-application limit up,".  I'm guessing that is a mistake.19:29
bacah, so unify them at 10MB or 50MB19:30
gary_posteryeah19:30
bacok, so that is outside the scope of this bug fix...and our app should be robust enough to live in a messed up world like we currently have19:30
bacthat sounded more philosophical than i intended.19:31
gary_posterbac, one thought I had so far was wondering about 64K as a good default (maybe bigger), and whether it ought to be implemented in terms lpconfig19:31
gary_poster:-)19:31
gary_posteragree, though19:31
gary_posterbac, my question is a "wondering," not an opinion19:32
bacactually for returning  a message that caused an OOPS i think 64K should be sufficient19:32
bacand i can easily make it a config variable though i don't know what it buys us since we'd not want to tune it across environments19:33
gary_posterin doc, "outgoing message will be too big" I'd maybe ike a parenthetical ref to this bug, or the incident, or at least an explanation of what is actually enforcing our limit19:33
baci mean lp.dev vs production19:33
gary_posterconfig var: only to change quickly19:33
bacah, right, they are handled in a different more easily deployed branch.  i always forget that19:34
bacOK, well if you think the branch is sound i'll make that change and get it rolling19:34
gary_poster64K sufficient: I have no idea...I don't have a clear idea of all the ways this is used tbh19:35
bacthanks for the thoughts19:35
gary_posterbut I'm happy to go along with it19:35
gary_postersure, np.  it looks good to me!  thank you19:35
benjigary_poster: have we told whomever is doing this DB deploy to turn on the feature flags for everyone after the deploy?19:45
gary_posterbenji, robert knows, and he also wants to wait an hour even with the email, which was fine w/me19:46
gary_postereven with email change I mean19:46
gary_posteryou know, we could have made +subscriptions redirect to the main page if the feature flag was off19:47
benjicool; in that case I'll send him a pointer to the "what to do to turn off the message" wiki page19:47
gary_postercool thanks19:47
benjiyeah, that would have been good, if we'd thought of it19:48
* benji does CHR.20:00
bacgary_poster: is there a way to QA email processing before it hits production?20:18
=== Ursinha is now known as Ursula
gary_posterbac, was20:26
gary_posteror even, yes20:27
gary_posterlooking20:27
gary_posterwe talked about it in our weekly notes20:27
gary_posterbac, oh, you mean *incoming* processing20:28
gary_posterI suspect there is20:28
bacyeah20:28
gary_posterI think it is something like this20:28
bacgary_poster: can you do the actual review for https://code.launchpad.net/~bac/launchpad/bug-788874/+merge/63750 ?20:29
gary_poster1) find something on production that you could email to20:29
gary_postersure20:29
gary_postermake sure that it is also on staging20:29
gary_posterconvert the prod address20:29
gary_posterby adding staging. at the start20:29
gary_poster(of domain of course)20:29
gary_poster2) run the pertinent cronscript with -vv and hope that it is hooked up to give you the detail you need20:30
gary_poster(the one we used for our last feature was)20:30
gary_posterThe End20:30
gary_posterbac, why don't we need code to rip out the original message?  I only see where we add the truncated one, not where we delete the original20:33
bacdelete from where?20:33
bacyou'll note i delete it from the mailbox before doing the send-oops20:34
bacline 13920:34
bacgary_poster: ^^20:34
gary_posterbac, when we assemble the message to send, leading up to line 62 of diff20:34
bacline 60 redefines original_msg to be the truncated version20:35
* bac admits that is a little confusing20:35
gary_posteroh, duh, got it20:35
gary_posterrenaming truncated_msg to truncated_msg_str *might* have helped me.20:36
gary_posterbut probably not :-P20:36
gary_posterapproved bac20:37
bacgood idea20:38
bacthanks20:38
gary_posternp20:38
gary_posterbenji, you around?21:51
benjigary_poster: yep21:52
gary_posterhey21:52
gary_posterbug 77260921:52
_mup_Bug #772609: bug subscription mute link is not shown for membership in a team with a direct or structural subscription <bad-commit-13003> <bad-commit-13154> <bad-commit-13164> <qa-bad> <story-better-bug-notification> <Launchpad itself:Triaged by gmb> < https://launchpad.net/bugs/772609 >21:52
gary_posterI take it gmb suggested that you not focus on it right now?21:52
gary_posterbenji: ^^21:53
benjigary_poster: I don't recall a conversation like that.  Oh, I remember, I claimed it in LP and he already had put a card up for it previsouly.21:54
gary_posterbenji, you are not assigned it in LP either21:54
gary_posteryou are working on it?21:54
gary_posterI need to know fairly quickly--maybe quick Skype call?21:55
gary_posterbenji ^^21:55
benjinope, I unassigned myself and he assigned himself21:55
gary_posteroh21:55
benjiI'm up for a call.21:55
benji(but I think that's the extent of my knowleg (sp) on it)21:55
gary_posterand you aren't on Skype :-P21:56
gary_posterok21:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!