/srv/irclogs.ubuntu.com/2011/06/10/#launchpad-dev.txt

sinzuiStevenK: mumble?00:07
jcsackettsinzui: mp is finally up. https://code.launchpad.net/~jcsackett/launchpad/picker-patcher-picked-a-patch-of-personpickers/+merge/6409400:07
lifelessbac: if you're still around, bug 794802 is addressed on qastaging00:13
_mup_Bug #794802: many bug activities timing out due to contention on bugsummary <canonical-losa-lp> <regression> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/794802 >00:13
StevenKhttps://bugs.launchpad.net/launchpad/+bug/40869800:33
_mup_Bug #408698: Search when reporting a bug fails when spaces are used <lp-bugs> <package> <package-picker> <vocabulary> <Launchpad itself:Triaged> < https://launchpad.net/bugs/408698 >00:33
StevenKhttps://bugs.launchpad.net/launchpad/+bug/37667100:33
sinzuiStevenK: I agree that th use case for 408698  is fixed. mark it as release00:38
sinzuis00:38
sinzuid00:38
bachi lifeless01:34
baclifeless: do you cowboy the fix for bug 794802 to qastaging b/c the bug branch does not show that it has been deployed01:35
_mup_Bug #794802: many bug activities timing out due to contention on bugsummary <canonical-losa-lp> <regression> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/794802 >01:35
bacs/do you/did you01:35
lifelessbac: yeah, its live01:35
baclifeless: darn01:35
lifelesscowboy of the year01:35
lifelessit wasn't when you were qaing01:35
baclifeless: my QA is still failing01:35
baci just tried01:36
lifelessah01:36
lifelesson qastaging ?01:36
bacyes01:36
lifelesstimeout? what statement is timing out ?01:36
bacOOPS-1987QASTAGING701:36
bacjust happened so it01:36
bacwill be a while before it shows up01:37
baclifeless:  my OOPS from earlier today is https://lp-oops.canonical.com/oops.py/?oopsid=1986QASTAGING12001:39
lifelessbac: yeah, that not biug 79480201:40
baclifeless: i'll prepare a rollback01:40
lifelesswhat was the change you made ?01:41
lifelessfound it01:42
wgrantfindSimilarBugs timeouts aren't exactly uncommon...01:42
wgrantI'm not sure bac's change is relevant here.01:42
lifelessyeah01:42
lifelessthats what I want to assess01:42
lifelessgaaarh lint fixes01:42
* lifeless still looking for the actual change01:42
lifelessbac: don't rollback01:43
StevenKsinzui: Ready when you're back.01:43
lifelessbac: the actual issue - a security error - is fixed01:43
wgrantYeah, this is unrelated, assuming that it's the hunk starting at line 82 of the MP diff.01:43
lifelessbac: this remaining issue wasn't introduced by your change.01:44
bacok01:44
lifelesspre existing condition; like the old guy that goes into the doctor complaining that other people smell bad01:45
baclifeless: how do you want me to mark that bug?01:45
lifelessdoctor removes wax from his ear, and can hear is own flatulence01:45
lifelessboom-tish01:45
bacqa-smell-old-guy01:45
lifelessbac: I think its qa-ok01:45
baclifeless: done01:46
pooliespiv, did your failing-faster twisted get released, or can it get into lp?02:03
pooliere https://bugs.launchpad.net/launchpad/+bug/74075902:03
_mup_Bug #740759: creating bzrdir on launchpad is slow (BzrDirFormat.initialize_ex_1.16) <codehosting-ssh> <hpss> <lp-code> <performance> <Launchpad itself:In Progress by jameinel> < https://launchpad.net/bugs/740759 >02:03
spivpoolie: I think it's been on LP for a while02:06
spivHmm, maybe not, just the workaround branch.02:07
=== Ursinha is now known as Ursula
sinzuiStevenK: I am looking at createBug in model.bug02:15
lifelessok, it could have been worse - * 1548 Time Outs02:19
=== wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: wallyworld (*jtv) | Critical bugs:209 - 0:[######=_]:256
=== Ursula is now known as Ursinha
jtvhi wallyworld_ — I'm afraid I'm not well today05:05
pooliehi wallyworld_05:10
poolieget well soon jtv05:18
jtvthanks05:18
wallyworld_jtv: hi, sorry to hear that06:42
wallyworld_hi poolie06:42
wallyworld_jtv: there's only been one or two reviews posted and they were taken so nothing for you to check so far anyway06:44
adeuringgood morning07:18
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: wallyworld (*jtv), adeuring | Critical bugs:209 - 0:[######=_]:256
cody-somervilleHey. I was going to land https://code.launchpad.net/~timrchavez/launchpad/set_ppa_private_from_api_724740-2/+merge/63950 but I notice some benign changes to utilities/sourcedeps.cache (looks like maybe a script regenerated it?). I assume I should ask timrc to get rid of that cruft before I land?07:56
lifelessits fine07:57
lifelessthe cache is well, a cache.07:57
=== almaisan-away is now known as al-maisan
cody-somervillealrighty, I'll go ahead and land it then.07:58
StevenKcody-somerville: If you could suggest to Tim in future that he uses self.assertIs(<something>, None) or self.assertIsNot(<something>, None) when comparing to None?08:04
cody-somervilleStevenK, Sure thing. I'll pass that on in our next standup.08:05
=== Ursinha is now known as Ursula
=== Ursula is now known as Ursinha
=== Ursinha is now known as Ursula
jtvcody-somerville, StevenK: in launchpad we pass the expected value first, actual value second.08:42
lifelessor assertThat(thing, Is(None))08:51
cody-somervilleHas anyone else noticed how signing into the AWS Management Console defaults to the S3 tab, incurring you a list operation (which of course gets rounded up and you get charged atleast a cent that month even if all you did was login to the management console).08:51
cody-somervilleHow long does the test suite take to run these days on ec2?08:55
jtvI would say about 4 hours.  Wild guess.08:56
* StevenK kicks buildbot until pieces fall off.10:00
=== al-maisan is now known as almaisan-away
LPCIBotProject windmill-devel build #198: STILL FAILING in 1 hr 6 min: https://lpci.wedontsleep.org/job/windmill-devel/198/11:44
lifelessnight everyone11:51
bigjoolshello, is anyone feeling brave enough to review an 800 line soyuz branch?12:56
bigjoolsadeuring? :)12:57
adeuringbigjools: sure, but let me first have a lunch break :)13:15
=== bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring, bac | Critical bugs:209 - 0:[######=_]:256
=== Ursula is now known as Ursinha
=== matsubara-afk is now known as matsubara
Ursinhaconferencing system is nice, but only for the first five minutes13:49
Ursinhamatsubara, jml, want to join me there?13:49
jmloh hi13:49
Ursinha*conferencing system music13:50
jmlmatsubara: is that you?13:52
benjiUrsinha: we should write a script to pull new on-hold music from http://freemusicarchive.org every day13:56
jmlor some kind of U1 streaming thing.13:57
adeuringbac: could you have a look at this MP: https://code.launchpad.net/~adeuring/launchpad/bug-735991/+merge/64171 ?14:10
bacadeuring: sure14:10
adeuringthanks!14:11
flacostejames_w: hi, can i request your help for qa (should take 5 mins at most)14:52
james_wflacoste, yep14:54
james_wmight have to delay by 30 minutes, but I'm happy to help14:54
flacostejames_w: can you just try setting a Ubuntu official branch on qastaging14:55
flacostejames_w: just to make sure that the package-importer will continue working after my permission change is rolled up14:55
flacostejames_w: there is no hurry, so 30 mins delay is fine14:56
flacostethanks14:56
flacosteit works for me on the ensemble distribution, but i'd like a confirmation for the Ubuntu case14:56
bachi adeuring14:59
bigjoolsadeuring: did my branch scare you?15:00
baclooking at getBugSubscriberPackages i don't see how it filters based on the user15:00
adeuringbigjools: well, a bit, but I'm still reading..15:03
adeuringbac: let me check...15:03
jmlgror. still haven't eaten :(15:03
adeuringbac: self.structural_subscriptions_clause . That's StructuralSubscription.subscriberID == self.id15:04
bacadeuring: it might be enlightening to change test_getBugSubscriberPackages to create other subscribed DSPs for another user15:05
adeuringbac: sure, good idea15:05
bacadeuring: thanks, i didn't see that ref to self.structural_subscriptions_clause15:06
bacadeuring: and i don't really see the benefit of it either...  saves some typing but adds confusion.  but it is an existing pattern.15:07
adeuringbac: the idea is that we want all DSP for which a structural subscription exists, i.e., things that are related to the result of structrural_subscriptions, but without calling this property15:08
bacadeuring: i understand15:09
bacmy point is using self.structural_subscriptions_clause replaces a one line constraint that is obvious with a one-line property use that is not clear15:10
bacor at least easily overlooked15:10
bacadeuring: i suggest you undo that change15:12
danilosadeuring, bac: hi guys, anyone fancy reviewing some JS code? a few branches available, so feel free to pick one and make sure to claim it so somebody else doesn't do it before you guys :)15:12
adeuringbac: yeah... ok15:12
bacdanilos: ok, i'll grab one when free15:13
danilosbac, cool, thanks15:13
danilossome are oversized but mostly due to tedious JS test code :/15:14
=== vednis is now known as mars
bacadeuring: approved.  a *really* nice piece of work!15:21
adeuringbac: thanks!15:21
james_wflacoste, still works15:26
flacostejames_w: awesome, thanks!15:26
deryckHi, everyone.15:31
flacostehey deryck15:41
adeuringbigjools: r=me15:57
bigjoolsadeuring: cool, thanks.  Any questions on what's going on?15:57
adeuringbigjools: I tried to figure it out by looking around in the sourceode, outside the plain diff15:58
bigjoolsadeuring: it's not the easiest of branches to grok15:58
danilosbac, adeuring: I am about to leave now, I'd still appreciate a review or two, but if you don't feel like doing it with me not available for questions, I won't mind; thanks again :)16:02
bacdanilos, adeuring: i am about to start on https://code.edge.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-activity/+merge/6418016:02
danilosbac, cool, thanks16:03
bacdanilos: is that the one i should start with?16:03
danilosbac, the best one to start with is probably -sections, then -subscribers and then -activity, but I did split them up so they could be looked at separately, so any is good16:04
danilosbac, the order of dependencies is listed in bug 772754 (i.e. earliest ones are near the top of linked branches), fwiw16:04
_mup_Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing <qa-ok> <story-better-bug-notification> <Launchpad itself:In Progress by gary> < https://launchpad.net/bugs/772754 >16:04
bacdanilos, adeuring: ok, i've claimed https://code.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-sections/+merge/6417616:06
bacdanilos: have a good weekend16:06
LPCIBotProject devel build #794: STILL FAILING in 5 hr 43 min: https://lpci.wedontsleep.org/job/devel/794/16:09
adeuringdanilos: sorry, I'd like to cop out from a review. It's quite late for me, and I did not sleep that well last night.16:13
danilosadeuring, that's ok, thanks16:13
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: bac | Critical bugs:209 - 0:[######=_]:256
LPCIBotProject windmill-db-devel build #377: STILL FAILING in 1 hr 7 min: https://lpci.wedontsleep.org/job/windmill-db-devel/377/16:16
LPCIBotProject parallel-test build #25: STILL FAILING in 1 hr 18 min: https://lpci.wedontsleep.org/job/parallel-test/25/16:39
LPCIBotProject windmill-db-devel build #378: STILL FAILING in 42 min: https://lpci.wedontsleep.org/job/windmill-db-devel/378/16:58
LPCIBotProject windmill-devel build #199: STILL FAILING in 1 hr 7 min: https://lpci.wedontsleep.org/job/windmill-devel/199/17:46
=== salgado is now known as salgado-lunch
=== matsubara is now known as matsubara-lunch
LPCIBotProject windmill-devel build #200: STILL FAILING in 42 min: https://lpci.wedontsleep.org/job/windmill-devel/200/18:29
benjibac: Will do do a pre-review of https://pastebin.canonical.com/48394/ for me?  I'm going to switch from an attribute on the exception to a marker interface and move the monkey patch from lib/lp/app/__init__.py to lib/lp_sitecustomize.py per Gary's suggestions but I wanted your opinions while I'm moving things around.19:03
bacbenji: ok, just a sec?  i'm trying to finish up danilo's JS review19:04
benjiabsolutely, thanks19:04
=== salgado-lunch is now known as salgado
bachi benji i've read your paste19:13
bacbenji: i'm confused by some terminology.  you said above you were going from an attribute on the exception to a marker interface...but that isn't what i see in the paste19:14
benjibac: sorry, I meant that the paste uses an attribute on the exception and I'm changing that to a marker interface on the exception instead19:15
bacbenji: ok, so the paste is what, a first attempt that you're abandoning in favor of a marker interface?19:16
=== matsubara-lunch is now known as matsubara
benjibac: right, but not quite abandoning, refactoring19:17
bacok19:17
bacbenji: well, what you have in the paste looks reaonsable to me19:17
benji(well, "refactoring" isn't technically the right word either, make that "reworking")19:17
benjibac: cool, thanks for looking at it for me19:17
bacbenji: will it be done today?  i look forward to seeing how it morphs19:18
benjiI hope it will be.19:18
LPCIBotProject windmill-devel build #201: STILL FAILING in 42 min: https://lpci.wedontsleep.org/job/windmill-devel/201/19:28
gary_posterbac, you'll see in https://code.launchpad.net/~gary/launchpad/bug553368/+merge/64108 that lifeless and I had a conversation that significantly changed the goal of the branch, but I think he'd be comfortable now with someone else--say, you--giving a code review, if you are willing and able.19:43
bacgary_poster: i'll do so now19:43
gary_posterthank you19:43
bacgary_poster: your replacement fixture has a comment that it won't work with the appserverlayer.  can you enforce that?20:16
gary_posterbac, uh, I hadn't thought of that. um....I don't remember if the layer is a global accessible sanely.  I don't think it is.  The test suite knows, I think: I can check if fixtures have access to the test suite.20:17
bacmight be nice20:18
bacunclear what the failure mode currently would look like20:18
bacif it is informative then i'd say not to bother20:18
bacneat branch, though.  i'll approve it momentarily.  thanks.20:18
gary_posterbac, failure mode is that your replacement doesn't seem to work--you've replaced the view locally, but not in the other process or whatever that the appserverlayer uses, so nothing happens.  The fixture does not get access to the test class, so I don't know of a way to do it right now.20:21
bacok20:21
bacthe devs have been warned!20:21
gary_poster:-)20:22
lifelessmorning20:30
lifelessgary_poster: you can check whether the layer is setup I guess, but FWIW not-working is pretty clear :)20:31
gary_posterlifeless, yeah I guess the layer itself is a global :-)  but yeah, I'm inclined to leave it20:33
lifelessand yeah, *totally* happy for another person to do the review; FWIW I agree with bac's comments20:35
gary_postercool, changed them, pushing20:36
=== Ursula is now known as Ursinha-lunch
bachi sinzui, can you briefly remind me of the process for unsuspending a user?21:00
lifelessstatik: hi21:00
lifelessstatik: how did your microservice go?21:01
bacsound like you had a tiny funeral21:01
gary_posterheh21:02
gary_posteror very small communion, wedding, etc.21:02
lifelesshe was hacking on a node.js microservice based on the gpg signature checking requirements21:03
lifelessbac: http://twitter.com/#!/sstatik/status/7683112965465702421:06
statiklifeless: i have not had time to get back to it, i have vagrant building the whole machine and node.js/coffee script spitting out some boilerplate JSON, next I need to wire in some tests, a gpg layer, and connect it all together.21:08
statiklp:~statik/+junk/gpg-val21:09
statikit's probably horrible in 5 or more ways21:09
lifelessstatik: http://vagrantup.com/ ?21:12
lifelessstatik: I think its a great experiment21:12
statikvagrant is a gem that autobuilds a VM using virtualbox (atm, libvirt support planned) and then provisions it using chef, puppet, or bash21:13
lifelessthe vagrant aspect surprises me a little but its neither here nor there21:13
lifelessstatik: vagrantup.com looks like it21:13
statikyep, thats the one.21:13
statiksubst vagrant for ensemble, openstack, whatever the appropriate tech is when the time comes. for now it's the only one that actually works ;)21:14
statikit automated the entire process from a raw CD install21:14
lifelessyeah21:14
statikit's only for devs though, doesn't work for managing production. it does give a nice way to try out puppet or chef recipes though, and provides a nice isolated environment to work in.21:15
lifelessI guess for me, for dev environment, we want 15-20 services on one dev laptop21:15
lifelessVM's just seem too heavyweight21:15
lifelessone VM - sure, thats how I do my dev for LP, but one-per-service, mmmm, perhaps I'm too cautious21:15
lifelessthat said, the idea I have of having a network fake for each microservice means doing one VM per service would work21:16
statikwell, i'm only prototyping one service :) it could easily be one VM with LXC containers inside it to wall of each individual service21:16
lifelessjust need to bring the fake into different VM's21:16
lifelessand one can shutoff a VM when finished hacking on that service21:17
statikoh thats a nice idea too21:17
lifelessstatik: anyhow, its a good thing to play with; we don't do nearly enough playing21:17
statikyep, my goal was to make it dead simple for someone else to bring up the experiment and poke at it without polluting their machine21:18
lifelessbenji: hi21:30
lifelessbenji: I'm confused by the duplicating of bug 795180 (about the subscription popup UI) onto bug 772754 (about us not showing the list of bug subscribers)21:31
benjilifeless: hmm, let me look... oh, it looks like more work is being done under the auspices of that bug than the description would suggest21:33
benjiI'll now wonder out loud if my above interpretation is correct so gary_poster can verify for me.21:33
gary_posterla la la21:35
gary_posterme wonders where mup is21:35
lifelesssulking?21:36
gary_poster:-)21:36
* benji secretly hates mup.21:36
gary_posterhhe21:36
gary_posterheh21:37
lifelessbenji: also, separately, what makes the mute text bug critical ?21:38
gary_posterlifeless, benji, yes, in order to address bug 772754 we had to address what mpt describes.  More properly, perhaps, you would say that the branches we have addressing that bug also address bug 795180.21:38
_mup_Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing <qa-ok> <story-better-bug-notification> <Launchpad itself:In Progress by gary> < https://launchpad.net/bugs/772754 >21:38
gary_posterso there you are21:39
benjilifeless: it seemed like an actual bug that we (yellow) would likely do soon (being on maintenance rotation)21:39
gary_poster(you == mup)21:39
lifelessbenji: ah21:39
gary_posterbenji rules are if oops, regression or security, critical21:40
gary_posterotherwise high or low21:40
gary_posterthis could maybe be high21:40
lifelessor operational FUBAR21:40
gary_posteryeah21:40
benjik21:40
lifelessbenji: we're trying to make queue jumping work evidence based21:41
lifelessbenji: high/low are whether we're planning on working on it in < 6 months or not21:41
lifelessand then folk pulling work from a bucket (critical/high/low) can choose whatever bit of work they want subject to however the squad is internally doing stuff21:42
lifelessbenji: https://dev.launchpad.net/BugTriage and https://dev.launchpad.net/BugTriage/Background21:42
benjiah, I confused High and Critical21:42
lifelessbenji: gary_poster: thanks; -> afk21:50
LPCIBotYippie, build fixed!21:51
LPCIBotProject devel build #795: FIXED in 5 hr 20 min: https://lpci.wedontsleep.org/job/devel/795/21:51
lifelesssinzui: hi; bug 794008 - I don't know if you noticed but one of the screenshots is from LP itself, so its both c-i-p and lp22:00
_mup_Bug #794008: Opera displays Launchpad _without text_ <opera> <Canonical SSO provider:Triaged> <Launchpad itself:Triaged> < https://launchpad.net/bugs/794008 >22:00
sorenA bit earlier today I attempted to create a new package set. The tool I used didn't make it obvious that it wasn't archive, but rather distribution specific. Wondering why it failed I went and looked at the code implementing the packagesets.new method in the API, and I'm really having trouble spotting the bit of code the rejects my request. Can anyone provide some hints?22:02
LPCIBotProject windmill-devel build #202: STILL FAILING in 1 hr 17 min: https://lpci.wedontsleep.org/job/windmill-devel/202/22:03
sinzuilifeless: that page, with css and markup was not served my lp22:04
sinzuilifeless: so if there is a browser issue the fix will be in c-i-p22:04
lifelesssinzui: there is a broken page served by lp22:04
lifelesshttps://bugs.launchpad.net/launchpad/+bug/794008/+attachment/2159063/+files/loool.png22:04
_mup_Bug #794008: Opera displays Launchpad _without text_ <opera> <Canonical SSO provider:Triaged> <Launchpad itself:Triaged> < https://launchpad.net/bugs/794008 >22:04
lifelesssinzui: link 222:04
lifelessbah22:04
lifelesssinzui: comment two22:04
sinzuisorry, I did not see that one22:05
sinzuisorry22:05
lifelesssinzui: no worries; thats why I'm bringing it to your attention22:05
lifelessclearly something is wrong, and I suspect their browser22:05
lifelessbut it might be something we're doing22:05
sinzuiWhat does this mean? It does not work with Lp's or c-i-p's markup and css. They are not related anymore22:05
sinzuiha. I see the sprites render. opera had issues with that in the past22:06
sinzuiph22:06
sinzuilifeless: both lp and c-i-p must have the same font rules per UX. I wonder if the browser dies on "UbuntuBeta Regular",Ubuntu,"Bitstream Vera Sans","DejaVu Sans",Tahoma,sans-serif22:08
lifelesssinzui: yeah, I thought that was common22:08
sinzuilifeless: look at the image again. only the monospace font renders!22:08
lifelessyeah22:08
sinzuiI suspect the user has messed with his fonts because sans-serif is the ultimate failover22:09
sinzuiNow might be the time to switch to oneiric. I am at EOD and I have confirmed html5browser runs on both lucid and natty.22:14
lifeless\o/22:18
lifelessEOW even22:18
LPCIBotProject windmill-db-devel build #379: STILL FAILING in 1 hr 6 min: https://lpci.wedontsleep.org/job/windmill-db-devel/379/22:33
LPCIBotProject parallel-test build #26: STILL FAILING in 1 hr 4 min: https://lpci.wedontsleep.org/job/parallel-test/26/22:55
=== Ursinha-lunch is now known as Ursinha
LPCIBotProject windmill-devel build #203: STILL FAILING in 1 hr 6 min: https://lpci.wedontsleep.org/job/windmill-devel/203/23:40

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!