[00:07] StevenK: mumble? [00:07] sinzui: mp is finally up. https://code.launchpad.net/~jcsackett/launchpad/picker-patcher-picked-a-patch-of-personpickers/+merge/64094 [00:13] bac: if you're still around, bug 794802 is addressed on qastaging [00:13] <_mup_> Bug #794802: many bug activities timing out due to contention on bugsummary < https://launchpad.net/bugs/794802 > [00:33] https://bugs.launchpad.net/launchpad/+bug/408698 [00:33] <_mup_> Bug #408698: Search when reporting a bug fails when spaces are used < https://launchpad.net/bugs/408698 > [00:33] https://bugs.launchpad.net/launchpad/+bug/376671 [00:38] StevenK: I agree that th use case for 408698 is fixed. mark it as release [00:38] s [00:38] d [01:34] hi lifeless [01:35] lifeless: do you cowboy the fix for bug 794802 to qastaging b/c the bug branch does not show that it has been deployed [01:35] <_mup_> Bug #794802: many bug activities timing out due to contention on bugsummary < https://launchpad.net/bugs/794802 > [01:35] s/do you/did you [01:35] bac: yeah, its live [01:35] lifeless: darn [01:35] cowboy of the year [01:35] it wasn't when you were qaing [01:35] lifeless: my QA is still failing [01:36] i just tried [01:36] ah [01:36] on qastaging ? [01:36] yes [01:36] timeout? what statement is timing out ? [01:36] OOPS-1987QASTAGING7 [01:36] just happened so it [01:37] will be a while before it shows up [01:39] lifeless: my OOPS from earlier today is https://lp-oops.canonical.com/oops.py/?oopsid=1986QASTAGING120 [01:40] bac: yeah, that not biug 794802 [01:40] lifeless: i'll prepare a rollback [01:41] what was the change you made ? [01:42] found it [01:42] findSimilarBugs timeouts aren't exactly uncommon... [01:42] I'm not sure bac's change is relevant here. [01:42] yeah [01:42] thats what I want to assess [01:42] gaaarh lint fixes [01:42] * lifeless still looking for the actual change [01:43] bac: don't rollback [01:43] sinzui: Ready when you're back. [01:43] bac: the actual issue - a security error - is fixed [01:43] Yeah, this is unrelated, assuming that it's the hunk starting at line 82 of the MP diff. [01:44] bac: this remaining issue wasn't introduced by your change. [01:44] ok [01:45] pre existing condition; like the old guy that goes into the doctor complaining that other people smell bad [01:45] lifeless: how do you want me to mark that bug? [01:45] doctor removes wax from his ear, and can hear is own flatulence [01:45] boom-tish [01:45] qa-smell-old-guy [01:45] bac: I think its qa-ok [01:46] lifeless: done [02:03] spiv, did your failing-faster twisted get released, or can it get into lp? [02:03] re https://bugs.launchpad.net/launchpad/+bug/740759 [02:03] <_mup_> Bug #740759: creating bzrdir on launchpad is slow (BzrDirFormat.initialize_ex_1.16) < https://launchpad.net/bugs/740759 > [02:06] poolie: I think it's been on LP for a while [02:07] Hmm, maybe not, just the workaround branch. === Ursinha is now known as Ursula [02:15] StevenK: I am looking at createBug in model.bug [02:19] ok, it could have been worse - * 1548 Time Outs === wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: wallyworld (*jtv) | Critical bugs:209 - 0:[######=_]:256 === Ursula is now known as Ursinha [05:05] hi wallyworld_ — I'm afraid I'm not well today [05:10] hi wallyworld_ [05:18] get well soon jtv [05:18] thanks [06:42] jtv: hi, sorry to hear that [06:42] hi poolie [06:44] jtv: there's only been one or two reviews posted and they were taken so nothing for you to check so far anyway [07:18] good morning === adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: wallyworld (*jtv), adeuring | Critical bugs:209 - 0:[######=_]:256 [07:56] Hey. I was going to land https://code.launchpad.net/~timrchavez/launchpad/set_ppa_private_from_api_724740-2/+merge/63950 but I notice some benign changes to utilities/sourcedeps.cache (looks like maybe a script regenerated it?). I assume I should ask timrc to get rid of that cruft before I land? [07:57] its fine [07:57] the cache is well, a cache. === almaisan-away is now known as al-maisan [07:58] alrighty, I'll go ahead and land it then. [08:04] cody-somerville: If you could suggest to Tim in future that he uses self.assertIs(, None) or self.assertIsNot(, None) when comparing to None? [08:05] StevenK, Sure thing. I'll pass that on in our next standup. === Ursinha is now known as Ursula === Ursula is now known as Ursinha === Ursinha is now known as Ursula [08:42] cody-somerville, StevenK: in launchpad we pass the expected value first, actual value second. [08:51] or assertThat(thing, Is(None)) [08:51] Has anyone else noticed how signing into the AWS Management Console defaults to the S3 tab, incurring you a list operation (which of course gets rounded up and you get charged atleast a cent that month even if all you did was login to the management console). [08:55] How long does the test suite take to run these days on ec2? [08:56] I would say about 4 hours. Wild guess. [10:00] * StevenK kicks buildbot until pieces fall off. === al-maisan is now known as almaisan-away [11:44] Project windmill-devel build #198: STILL FAILING in 1 hr 6 min: https://lpci.wedontsleep.org/job/windmill-devel/198/ [11:51] night everyone [12:56] hello, is anyone feeling brave enough to review an 800 line soyuz branch? [12:57] adeuring? :) [13:15] bigjools: sure, but let me first have a lunch break :) === bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring, bac | Critical bugs:209 - 0:[######=_]:256 === Ursula is now known as Ursinha === matsubara-afk is now known as matsubara [13:49] conferencing system is nice, but only for the first five minutes [13:49] matsubara, jml, want to join me there? [13:49] oh hi [13:50] *conferencing system music [13:52] matsubara: is that you? [13:56] Ursinha: we should write a script to pull new on-hold music from http://freemusicarchive.org every day [13:57] or some kind of U1 streaming thing. [14:10] bac: could you have a look at this MP: https://code.launchpad.net/~adeuring/launchpad/bug-735991/+merge/64171 ? [14:10] adeuring: sure [14:11] thanks! [14:52] james_w: hi, can i request your help for qa (should take 5 mins at most) [14:54] flacoste, yep [14:54] might have to delay by 30 minutes, but I'm happy to help [14:55] james_w: can you just try setting a Ubuntu official branch on qastaging [14:55] james_w: just to make sure that the package-importer will continue working after my permission change is rolled up [14:56] james_w: there is no hurry, so 30 mins delay is fine [14:56] thanks [14:56] it works for me on the ensemble distribution, but i'd like a confirmation for the Ubuntu case [14:59] hi adeuring [15:00] adeuring: did my branch scare you? [15:00] looking at getBugSubscriberPackages i don't see how it filters based on the user [15:03] bigjools: well, a bit, but I'm still reading.. [15:03] bac: let me check... [15:03] gror. still haven't eaten :( [15:04] bac: self.structural_subscriptions_clause . That's StructuralSubscription.subscriberID == self.id [15:05] adeuring: it might be enlightening to change test_getBugSubscriberPackages to create other subscribed DSPs for another user [15:05] bac: sure, good idea [15:06] adeuring: thanks, i didn't see that ref to self.structural_subscriptions_clause [15:07] adeuring: and i don't really see the benefit of it either... saves some typing but adds confusion. but it is an existing pattern. [15:08] bac: the idea is that we want all DSP for which a structural subscription exists, i.e., things that are related to the result of structrural_subscriptions, but without calling this property [15:09] adeuring: i understand [15:10] my point is using self.structural_subscriptions_clause replaces a one line constraint that is obvious with a one-line property use that is not clear [15:10] or at least easily overlooked [15:12] adeuring: i suggest you undo that change [15:12] adeuring, bac: hi guys, anyone fancy reviewing some JS code? a few branches available, so feel free to pick one and make sure to claim it so somebody else doesn't do it before you guys :) [15:12] bac: yeah... ok [15:13] danilos: ok, i'll grab one when free [15:13] bac, cool, thanks [15:14] some are oversized but mostly due to tedious JS test code :/ === vednis is now known as mars [15:21] adeuring: approved. a *really* nice piece of work! [15:21] bac: thanks! [15:26] flacoste, still works [15:26] james_w: awesome, thanks! [15:31] Hi, everyone. [15:41] hey deryck [15:57] bigjools: r=me [15:57] adeuring: cool, thanks. Any questions on what's going on? [15:58] bigjools: I tried to figure it out by looking around in the sourceode, outside the plain diff [15:58] adeuring: it's not the easiest of branches to grok [16:02] bac, adeuring: I am about to leave now, I'd still appreciate a review or two, but if you don't feel like doing it with me not available for questions, I won't mind; thanks again :) [16:02] danilos, adeuring: i am about to start on https://code.edge.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-activity/+merge/64180 [16:03] bac, cool, thanks [16:03] danilos: is that the one i should start with? [16:04] bac, the best one to start with is probably -sections, then -subscribers and then -activity, but I did split them up so they could be looked at separately, so any is good [16:04] bac, the order of dependencies is listed in bug 772754 (i.e. earliest ones are near the top of linked branches), fwiw [16:04] <_mup_> Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing < https://launchpad.net/bugs/772754 > [16:06] danilos, adeuring: ok, i've claimed https://code.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-sections/+merge/64176 [16:06] danilos: have a good weekend [16:09] Project devel build #794: STILL FAILING in 5 hr 43 min: https://lpci.wedontsleep.org/job/devel/794/ [16:13] danilos: sorry, I'd like to cop out from a review. It's quite late for me, and I did not sleep that well last night. [16:13] adeuring, that's ok, thanks === adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: bac | Critical bugs:209 - 0:[######=_]:256 [16:16] Project windmill-db-devel build #377: STILL FAILING in 1 hr 7 min: https://lpci.wedontsleep.org/job/windmill-db-devel/377/ [16:39] Project parallel-test build #25: STILL FAILING in 1 hr 18 min: https://lpci.wedontsleep.org/job/parallel-test/25/ [16:58] Project windmill-db-devel build #378: STILL FAILING in 42 min: https://lpci.wedontsleep.org/job/windmill-db-devel/378/ [17:46] Project windmill-devel build #199: STILL FAILING in 1 hr 7 min: https://lpci.wedontsleep.org/job/windmill-devel/199/ === salgado is now known as salgado-lunch === matsubara is now known as matsubara-lunch [18:29] Project windmill-devel build #200: STILL FAILING in 42 min: https://lpci.wedontsleep.org/job/windmill-devel/200/ [19:03] bac: Will do do a pre-review of https://pastebin.canonical.com/48394/ for me? I'm going to switch from an attribute on the exception to a marker interface and move the monkey patch from lib/lp/app/__init__.py to lib/lp_sitecustomize.py per Gary's suggestions but I wanted your opinions while I'm moving things around. [19:04] benji: ok, just a sec? i'm trying to finish up danilo's JS review [19:04] absolutely, thanks === salgado-lunch is now known as salgado [19:13] hi benji i've read your paste [19:14] benji: i'm confused by some terminology. you said above you were going from an attribute on the exception to a marker interface...but that isn't what i see in the paste [19:15] bac: sorry, I meant that the paste uses an attribute on the exception and I'm changing that to a marker interface on the exception instead [19:16] benji: ok, so the paste is what, a first attempt that you're abandoning in favor of a marker interface? === matsubara-lunch is now known as matsubara [19:17] bac: right, but not quite abandoning, refactoring [19:17] ok [19:17] benji: well, what you have in the paste looks reaonsable to me [19:17] (well, "refactoring" isn't technically the right word either, make that "reworking") [19:17] bac: cool, thanks for looking at it for me [19:18] benji: will it be done today? i look forward to seeing how it morphs [19:18] I hope it will be. [19:28] Project windmill-devel build #201: STILL FAILING in 42 min: https://lpci.wedontsleep.org/job/windmill-devel/201/ [19:43] bac, you'll see in https://code.launchpad.net/~gary/launchpad/bug553368/+merge/64108 that lifeless and I had a conversation that significantly changed the goal of the branch, but I think he'd be comfortable now with someone else--say, you--giving a code review, if you are willing and able. [19:43] gary_poster: i'll do so now [19:43] thank you [20:16] gary_poster: your replacement fixture has a comment that it won't work with the appserverlayer. can you enforce that? [20:17] bac, uh, I hadn't thought of that. um....I don't remember if the layer is a global accessible sanely. I don't think it is. The test suite knows, I think: I can check if fixtures have access to the test suite. [20:18] might be nice [20:18] unclear what the failure mode currently would look like [20:18] if it is informative then i'd say not to bother [20:18] neat branch, though. i'll approve it momentarily. thanks. [20:21] bac, failure mode is that your replacement doesn't seem to work--you've replaced the view locally, but not in the other process or whatever that the appserverlayer uses, so nothing happens. The fixture does not get access to the test class, so I don't know of a way to do it right now. [20:21] ok [20:21] the devs have been warned! [20:22] :-) [20:30] morning [20:31] gary_poster: you can check whether the layer is setup I guess, but FWIW not-working is pretty clear :) [20:33] lifeless, yeah I guess the layer itself is a global :-) but yeah, I'm inclined to leave it [20:35] and yeah, *totally* happy for another person to do the review; FWIW I agree with bac's comments [20:36] cool, changed them, pushing === Ursula is now known as Ursinha-lunch [21:00] hi sinzui, can you briefly remind me of the process for unsuspending a user? [21:00] statik: hi [21:01] statik: how did your microservice go? [21:01] sound like you had a tiny funeral [21:02] heh [21:02] or very small communion, wedding, etc. [21:03] he was hacking on a node.js microservice based on the gpg signature checking requirements [21:06] bac: http://twitter.com/#!/sstatik/status/76831129654657024 [21:08] lifeless: i have not had time to get back to it, i have vagrant building the whole machine and node.js/coffee script spitting out some boilerplate JSON, next I need to wire in some tests, a gpg layer, and connect it all together. [21:09] lp:~statik/+junk/gpg-val [21:09] it's probably horrible in 5 or more ways [21:12] statik: http://vagrantup.com/ ? [21:12] statik: I think its a great experiment [21:13] vagrant is a gem that autobuilds a VM using virtualbox (atm, libvirt support planned) and then provisions it using chef, puppet, or bash [21:13] the vagrant aspect surprises me a little but its neither here nor there [21:13] statik: vagrantup.com looks like it [21:13] yep, thats the one. [21:14] subst vagrant for ensemble, openstack, whatever the appropriate tech is when the time comes. for now it's the only one that actually works ;) [21:14] it automated the entire process from a raw CD install [21:14] yeah [21:15] it's only for devs though, doesn't work for managing production. it does give a nice way to try out puppet or chef recipes though, and provides a nice isolated environment to work in. [21:15] I guess for me, for dev environment, we want 15-20 services on one dev laptop [21:15] VM's just seem too heavyweight [21:15] one VM - sure, thats how I do my dev for LP, but one-per-service, mmmm, perhaps I'm too cautious [21:16] that said, the idea I have of having a network fake for each microservice means doing one VM per service would work [21:16] well, i'm only prototyping one service :) it could easily be one VM with LXC containers inside it to wall of each individual service [21:16] just need to bring the fake into different VM's [21:17] and one can shutoff a VM when finished hacking on that service [21:17] oh thats a nice idea too [21:17] statik: anyhow, its a good thing to play with; we don't do nearly enough playing [21:18] yep, my goal was to make it dead simple for someone else to bring up the experiment and poke at it without polluting their machine [21:30] benji: hi [21:31] benji: I'm confused by the duplicating of bug 795180 (about the subscription popup UI) onto bug 772754 (about us not showing the list of bug subscribers) [21:33] lifeless: hmm, let me look... oh, it looks like more work is being done under the auspices of that bug than the description would suggest [21:33] I'll now wonder out loud if my above interpretation is correct so gary_poster can verify for me. [21:35] la la la [21:35] me wonders where mup is [21:36] sulking? [21:36] :-) [21:36] * benji secretly hates mup. [21:36] hhe [21:37] heh [21:38] benji: also, separately, what makes the mute text bug critical ? [21:38] lifeless, benji, yes, in order to address bug 772754 we had to address what mpt describes. More properly, perhaps, you would say that the branches we have addressing that bug also address bug 795180. [21:38] <_mup_> Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing < https://launchpad.net/bugs/772754 > [21:39] so there you are [21:39] lifeless: it seemed like an actual bug that we (yellow) would likely do soon (being on maintenance rotation) [21:39] (you == mup) [21:39] benji: ah [21:40] benji rules are if oops, regression or security, critical [21:40] otherwise high or low [21:40] this could maybe be high [21:40] or operational FUBAR [21:40] yeah [21:40] k [21:41] benji: we're trying to make queue jumping work evidence based [21:41] benji: high/low are whether we're planning on working on it in < 6 months or not [21:42] and then folk pulling work from a bucket (critical/high/low) can choose whatever bit of work they want subject to however the squad is internally doing stuff [21:42] benji: https://dev.launchpad.net/BugTriage and https://dev.launchpad.net/BugTriage/Background [21:42] ah, I confused High and Critical [21:50] benji: gary_poster: thanks; -> afk [21:51] Yippie, build fixed! [21:51] Project devel build #795: FIXED in 5 hr 20 min: https://lpci.wedontsleep.org/job/devel/795/ [22:00] sinzui: hi; bug 794008 - I don't know if you noticed but one of the screenshots is from LP itself, so its both c-i-p and lp [22:00] <_mup_> Bug #794008: Opera displays Launchpad _without text_ < https://launchpad.net/bugs/794008 > [22:02] A bit earlier today I attempted to create a new package set. The tool I used didn't make it obvious that it wasn't archive, but rather distribution specific. Wondering why it failed I went and looked at the code implementing the packagesets.new method in the API, and I'm really having trouble spotting the bit of code the rejects my request. Can anyone provide some hints? [22:03] Project windmill-devel build #202: STILL FAILING in 1 hr 17 min: https://lpci.wedontsleep.org/job/windmill-devel/202/ [22:04] lifeless: that page, with css and markup was not served my lp [22:04] lifeless: so if there is a browser issue the fix will be in c-i-p [22:04] sinzui: there is a broken page served by lp [22:04] https://bugs.launchpad.net/launchpad/+bug/794008/+attachment/2159063/+files/loool.png [22:04] <_mup_> Bug #794008: Opera displays Launchpad _without text_ < https://launchpad.net/bugs/794008 > [22:04] sinzui: link 2 [22:04] bah [22:04] sinzui: comment two [22:05] sorry, I did not see that one [22:05] sorry [22:05] sinzui: no worries; thats why I'm bringing it to your attention [22:05] clearly something is wrong, and I suspect their browser [22:05] but it might be something we're doing [22:05] What does this mean? It does not work with Lp's or c-i-p's markup and css. They are not related anymore [22:06] ha. I see the sprites render. opera had issues with that in the past [22:06] ph [22:08] lifeless: both lp and c-i-p must have the same font rules per UX. I wonder if the browser dies on "UbuntuBeta Regular",Ubuntu,"Bitstream Vera Sans","DejaVu Sans",Tahoma,sans-serif [22:08] sinzui: yeah, I thought that was common [22:08] lifeless: look at the image again. only the monospace font renders! [22:08] yeah [22:09] I suspect the user has messed with his fonts because sans-serif is the ultimate failover [22:14] Now might be the time to switch to oneiric. I am at EOD and I have confirmed html5browser runs on both lucid and natty. [22:18] \o/ [22:18] EOW even [22:33] Project windmill-db-devel build #379: STILL FAILING in 1 hr 6 min: https://lpci.wedontsleep.org/job/windmill-db-devel/379/ [22:55] Project parallel-test build #26: STILL FAILING in 1 hr 4 min: https://lpci.wedontsleep.org/job/parallel-test/26/ === Ursinha-lunch is now known as Ursinha [23:40] Project windmill-devel build #203: STILL FAILING in 1 hr 6 min: https://lpci.wedontsleep.org/job/windmill-devel/203/