| fagan | morning | 09:21 |
|---|---|---|
| nessita | hello crowd! | 12:06 |
| fagan | nessita: your here | 12:07 |
| fagan | nice | 12:07 |
| nessita | fagan: yes :-) | 12:07 |
| nessita | how is it going? | 12:09 |
| fagan | good good | 12:09 |
| fagan | how was the trip back | 12:09 |
| nessita | it was good, and we were really lucky, since our flights operated normally, but the airport closed a couple hours after we landed | 12:11 |
| Chipaca | nessita: ralsina is still stuck in brazil | 12:11 |
| nessita | Chipaca: yeah, I figured from his tweets :-( | 12:12 |
| Chipaca | nessita: yeah. I thought you weren't working today? | 12:12 |
| nessita | Chipaca: I am, I wasn't working yesterday | 12:12 |
| Chipaca | nessita: kewl | 12:12 |
| nessita | so, I just checked lan.com and the buenos aires-córdoba flight right next to mine was cancelled on Sunday | 12:13 |
| nessita | I feel special :-P | 12:13 |
| Chipaca | nessita: cue mandel singing 'i feel pretty' | 12:13 |
| facundobatista | nessita, you're special :) | 12:13 |
| facundobatista | (good morning) | 12:13 |
| nessita | Chipaca: lol | 12:13 |
| Chipaca | nessita: i need to go over some dates/planning stuff wiv you | 12:14 |
| Chipaca | nessita: when would be a good time? | 12:14 |
| mandel | nessita: I have been looking at trunk of control panel and u10client and all tests seem to pass, did they get fixed? | 12:14 |
| mandel | or am I doing something wrong? | 12:15 |
| facundobatista | mandel, pign | 12:15 |
| nessita | Chipaca: depending on your lunch, it can be as soon as I finish catching up with stuff, like in 30 minutes? | 12:15 |
| facundobatista | *ping | 12:15 |
| mandel | facundobatista: pong | 12:15 |
| nessita | mandel: I would say your machine is either too slow or too fast and the timing issues are not presenting there | 12:15 |
| Chipaca | nessita: sure. ping me. | 12:15 |
| nessita | mandel: as far as I know, everything is still "broken" re tests | 12:15 |
| nessita | which is :-( | 12:16 |
| nessita | mandel: unless dobey fixed that yesterday? though I think he wasn't working yesterday | 12:16 |
| mandel | nessita: really? dammed I ran them several times in my vm and worked.. that is annoying | 12:16 |
| nessita | mandel: do you have u1-devtools up to date? because that is were the issue is (we fixed the base test case) | 12:17 |
| mandel | nessita: good point, I think I reverted to r33 at some point to find out when all this started | 12:18 |
| nessita | mandel: right | 12:18 |
| * mandel looks at the r version | 12:18 | |
| facundobatista | mandel, just a reminder of that branch for you to run the tests in windows :) | 12:18 |
| mandel | facundobatista: oh, I forgot, can I have the url? | 12:18 |
| mandel | facundobatista: I'll do it right now | 12:18 |
| facundobatista | mandel, this one https://code.launchpad.net/~facundo/ubuntuone-client/waiting-send-id/+merge/63979 thanks! | 12:20 |
| mandel | np | 12:20 |
| nessita | mandel: how is it going the SyncDaemonTool for windows? (trying to build a mental map of our pending assignments re wcp) | 12:23 |
| mandel | nessita: goo progress but I'm waiting for the test to fix and land the new code that has been blocked for a while, I'll like to have something ready for this evening tom morning | 12:24 |
| mandel | facundobatista: since running al tes tests on windows atm is a pain, which test are the ones you wrote for that branch you gave me? | 12:24 |
| nessita | mandel: ack, I'll work on the tests as soon as I finish with what Chipacaa needs | 12:25 |
| facundobatista | mandel, actually, didn't write a new test for the windows part: changed what windows/ipc.py receives in some part, and fixed the code so the *current* tests go ok | 12:26 |
| facundobatista | mandel, see line 90/91 of the LP diff | 12:26 |
| mandel | facundobatista: ok, then I know which to run :) | 12:28 |
| mandel | facundobatista: looks like the tests pass if I merge it with https://code.launchpad.net/~mandel/ubuntuone-client/provide_credentials_management which has been blocked due to the tests situation.. | 12:30 |
| mandel | major PITA... | 12:30 |
| ralsina | morning! | 12:34 |
| nessita | hi ralsina | 12:34 |
| nessita | ralsina: how/where are you? :-) | 12:34 |
| ralsina | hi nessita, greetings from foggy sao paulo | 12:35 |
| ralsina | Or rather Atibaia, wherever that is | 12:35 |
| nessita | ralsina: and your family, where are they? | 12:36 |
| ralsina | nessita: in another hotel in Sao Paulo proper | 12:36 |
| nessita | ralsina: have you get together? | 12:37 |
| ralsina | since the airlines are paying we can't change hotels, and I am 1 hour by car away from them | 12:37 |
| nessita | oh | 12:37 |
| ralsina | and neither can leave the hotels since the airlines want us near when the plane gets scheduled | 12:37 |
| ralsina | so, maor suckage | 12:37 |
| ralsina | s/maor/major/ | 12:37 |
| nessita | ralsina: are you getting back to ARG in the same flight? | 12:38 |
| ralsina | nessita: nope | 12:38 |
| nessita | mayor oh | 12:38 |
| ralsina | nessita: not even the same airline :-( | 12:38 |
| nessita | major* | 12:38 |
| ralsina | I wonder how I describe this on canonicaladmin (yes, I had swap scheduled for today but I am stuck in another country) | 12:40 |
| nessita | ralsina: you should ask your boss ;-) | 12:42 |
| ralsina | I'm so down I am about to go on a free-shop chocolate binge while watching friends reruns :-( | 12:42 |
| * mandel walking dog | 12:44 | |
| * fagan break | 12:54 | |
| === teknico is now known as teknico_away | ||
| nessita | mandel: let me know when you get back | 13:16 |
| fagan | store bought scones are not as good as the ones from london :( | 13:38 |
| dobey | nessita: i had yesterday and today as swap, so no i didn't work on the tests. :-/ | 13:42 |
| nessita | dobey: ack. Is tarmac running? | 13:48 |
| dobey | yes | 13:48 |
| dobey | but u1client is broken; and i don't want my workstation crashing because the tests ate all my RAM | 13:48 |
| alecu | hello #ubuntuone! | 13:54 |
| nessita | hi alecu | 13:55 |
| alecu | hi nessita. I thought you were on swap today. | 13:55 |
| nessita | alecu: not, only yesterday | 13:55 |
| nessita | :-) | 13:55 |
| * fagan needs to head off for a few hours for errands | 13:58 | |
| nessita | stand up in 2' | 13:59 |
| nessita | fagan: stand up first! | 13:59 |
| fagan | nessita: will do | 13:59 |
| nessita | me | 14:00 |
| nessita | alecu, mandel, fagan, thisfred? | 14:00 |
| fagan | me | 14:00 |
| alecu | me | 14:01 |
| thisfred | me | 14:01 |
| fagan | dont think mandel is back yet | 14:02 |
| nessita | DONE: london sprint | 14:02 |
| nessita | TODO: windows control panel | 14:02 |
| nessita | BLOCKED: tests are not passing on u1client | 14:02 |
| nessita | NEWS: we're going back to the "work only on bugs". IE, do not submit a branch without a bug attach to it, idelly created before the branch was started :-) | 14:02 |
| nessita | NEXT: fagan | 14:02 |
| fagan | DONE | 14:02 |
| fagan | * played about more with that branch | 14:02 |
| fagan | TODO | 14:02 |
| fagan | * Get the branch merged in and the tests finished | 14:02 |
| fagan | Blocked | 14:02 |
| fagan | * by stupidity | 14:03 |
| fagan | next alecu | 14:03 |
| alecu | DONE: team sprint | 14:03 |
| alecu | TODO: catch up with windows port | 14:03 |
| alecu | BLOCKED: no | 14:03 |
| alecu | NEXT: thisfred | 14:03 |
| * fagan should have added the team sprint to the done item :D | 14:03 | |
| nessita | mandel, alecu: we're having a mumble meeting re the windows port right after the stand up (well, a couple of mins later so we can grab some tea) | 14:04 |
| thisfred | DONE: worked on ubuntuone-couch release TODO: get ubuntuone-couch uploaded, help anyone with anything BLOCKED: no | 14:04 |
| alecu | nessita, ack. Do you know if anyone besides ralsina is on leave? | 14:05 |
| nessita | alecu: ralsina and dobey are on leave, though dobey may do some work today to try to fix the tests | 14:06 |
| nessita | everyone: please say "ack" if you understood what I meant regarding "work only on bugs" | 14:08 |
| nessita | mandel, alecu, fagan, thisfred: ^? | 14:10 |
| fagan | ack | 14:10 |
| nessita | mandel, alecu: meeting in mumble in 20 minutes | 14:11 |
| alecu | ack | 14:11 |
| thisfred | ack | 14:11 |
| nessita | thanks! | 14:11 |
| * thisfred files bug: Work On Stuff | 14:11 | |
| thisfred | :P | 14:11 |
| nessita | lol | 14:11 |
| dobey | guess i should maybe make a thing for tarmac to require a linked bug with --fixes to land stuff | 14:13 |
| nessita | mandel: you back? | 14:22 |
| nessita | does anyone has the cell phone number from mandel? if so, please tell me in private | 14:29 |
| === m_conley_away is now known as m_conley | ||
| nessita | I repeat: does anyone has the cell phone number from mandel? if so, please tell me in private (the one in the directory is old from Belgium) | 14:34 |
| nessita | ralsina: ping | 14:34 |
| dobey | nessita: directory? | 14:34 |
| dobey | oh | 14:34 |
| nessita | :-) | 14:34 |
| nessita | rodrigo_: ping | 14:39 |
| nessita | alecu: until we have the meeting, what are you planning on working on? | 14:52 |
| alecu | nessita, right now I'm catching up with warthogs, and will do my pending expenses and will start looking into the pending gnome keyring 3 bug. | 14:57 |
| alecu | nessita, what about you? | 14:57 |
| nessita | alecu: I just filed a couple of bugs and I'm trying to remember where I left the cloud-folders tab, to create the merge proposal | 14:58 |
| nessita | alecu: the keyring 3 bug will have to be postponed, we have some hard dates on the windows port | 14:58 |
| nessita | alecu: that was the meeting about, I'm "desperately" looking for mandel to have the meeting and sync up | 14:58 |
| alecu | nessita, I know that the keyring 3 bug can wait, but I was planning on taking a look at it while we are idle on the windows side... | 15:00 |
| nessita | alecu: let's un-idle you in the windows side! :-D | 15:00 |
| nessita | alecu: do you have any pending branch? | 15:00 |
| nessita | alecu: I'll review now https://code.edge.launchpad.net/~alecu/ubuntuone-control-panel/more-devices-tab/+merge/63292, what about you starting with the preferences/settings tab? | 15:02 |
| alecu | nessita, https://code.launchpad.net/~alecu/ubuntuone-control-panel/more-devices-tab | 15:02 |
| alecu | that one | 15:02 |
| nessita | on it | 15:02 |
| alecu | nessita, I don't like that we keep building and have not tried this on windows yet. | 15:03 |
| nessita | alecu: I agree. But until we have a proper planning meeting with mandel, who for now we depend on, there is not clear path for testing this on windows | 15:04 |
| mandel | nessita: sorry I'm back had an emergency to sort out... | 15:04 |
| nessita | and as far as we foresee there should not be (tm) differences for that code (assuming we have the SyncDaemonTool) | 15:04 |
| nessita | mandel: mumble please? | 15:04 |
| mandel | nessita: sure on it | 15:05 |
| nessita | alecu: mumble please? | 15:08 |
| alecu | one minute | 15:08 |
| === teknico_away is now known as teknico | ||
| nessita | sure! thanks | 15:08 |
| rodrigo_ | nessita, pong | 15:12 |
| nessita | rodrigo_: is ok, no need now :-) | 15:12 |
| rodrigo_ | nessita, ok :) | 15:14 |
| nessita | thanks! | 15:14 |
| nessita | alecu, mandel: first bug tagged with u1-zomg-windows! bug #797199 :-P | 16:13 |
| ubot4 | Launchpad bug 797199 in ubuntuone-control-panel "Implement cloud folders tab in the QT version (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/797199 | 16:13 |
| nessita | and the tag is now official | 16:13 |
| nessita | is also official for u1client | 16:14 |
| Uber_Geek | is there anyone in here that works on the windows client? | 16:14 |
| nessita | Uber_Geek: yes :-) | 16:15 |
| nessita | mandel: ping | 16:15 |
| mandel | nessita: pong | 16:15 |
| Uber_Geek | Sweet, i would like to get involved, and help make the windows version work better. | 16:15 |
| nessita | mandel: what's with the https://code.launchpad.net/~mandel/ubuntu-sso-client/use_txnamedpipes/+merge/61935? wasn't ralsina doing reviews for it? | 16:16 |
| mandel | nessita: no one was I'm going to go through by ranches and take a look, when done I'll send an email to you guys | 16:16 |
| mandel | I have not been bossy enough with the reviews | 16:17 |
| nessita | Uber_Geek: that's great! right now we're really hard on having a complete new version, using the same daemon as the one we use in linux. So I would advice waiting until we release this code, and then help us test it and improve it | 16:17 |
| nessita | mandel: PLEASE! :-) | 16:17 |
| nessita | mandel: also, if not present, add test instructions to the merge proposal so we can actually test the stuff (even if you already EOD'd) | 16:17 |
| Uber_Geek | nessita: anything I can do to help in the meantime? | 16:17 |
| mandel | ok | 16:17 |
| nessita | Uber_Geek: well, are you familiar with QT and css styling for QT? | 16:18 |
| Uber_Geek | no :( | 16:19 |
| nessita | Uber_Geek: is ok :-) | 16:19 |
| nessita | Uber_Geek: then there is not much you can help with at the immediate moment. Could you please re-ping us after June, 24th? | 16:19 |
| nessita | (if you're still available) | 16:19 |
| nessita | mandel: can I mark as approved this one https://code.launchpad.net/~mandel/ubuntuone-client/provide_credentials_management/+merge/62627 ? | 16:20 |
| Uber_Geek | I plan on following this for the forseable future. | 16:20 |
| nessita | nice | 16:20 |
| mandel | nessita: let me take a look | 16:21 |
| mandel | nessita: go ahead, it looks correct | 16:22 |
| mandel | actually I can do it, face palm | 16:22 |
| nessita | mandel: well, I trust you will update all your branches, so I'll now stop digging into them :-P | 16:24 |
| * nessita goes back to her stuff | 16:24 | |
| mandel | hehehe | 16:24 |
| mandel | alecu: ping | 16:40 |
| mandel | nessita: ping | 16:44 |
| nessita | mandel: pong | 16:44 |
| mandel | nessita: can you review the following: https://code.launchpad.net/~mandel/ubuntuone-control-panel/use_correct_reactor/+merge/62961 | 16:44 |
| nessita | mandel: sure! | 16:44 |
| mandel | nessita: allows to use the correct reactor according to the platform. Later we can add a bug that states that the reactor is no needed on linux | 16:45 |
| mandel | that way we try to fix the dbus issue | 16:45 |
| nessita | right | 16:45 |
| mandel | nessita: ping | 17:06 |
| nessita | mandel: pong | 17:07 |
| nessita | mandel: Text conflict in ubuntuone/controlpanel/gui/qt/gui.py | 17:07 |
| nessita | 1 conflicts encountered. | 17:07 |
| mandel | nessita: hm, something must have changed, will fix right now before I forget | 17:08 |
| mandel | nessita: this is a hard one, but can you take a look at: https://code.launchpad.net/~mandel/txnamedpipes/add_qt_integration/+merge/61923 | 17:08 |
| mandel | nessita: if you feel you are not sure about it tell me and I'll get ralsina + alecu do it | 17:08 |
| nessita | mandel: I will certainly try | 17:08 |
| alecu | to do what? | 17:08 |
| alecu | oh, to review it. | 17:09 |
| mandel | alecu: review https://code.launchpad.net/~mandel/txnamedpipes/add_qt_integration/+merge/61923 | 17:09 |
| mandel | :) | 17:09 |
| alecu | ack | 17:09 |
| nessita | mandel: also https://code.launchpad.net/~mandel/ubuntuone-control-panel/use_correct_reactor/+merge/62961 for alecu, right? | 17:09 |
| mandel | yes | 17:10 |
| mandel | nessita: but let me fix the stupid conflict :) | 17:10 |
| nessita | mandel: why calling QObject.__init__(self) instead of super()? | 17:11 |
| nessita | mandel: and why is this for "type(data) == type(False)"? | 17:12 |
| dobey | alright, now where are we, so i can get back to my stuff :) | 17:13 |
| dobey | mandel: ah your branch failed for other reasons :) | 17:13 |
| iheartubuntu | does U1 have a mobile site for smartphone users? im not really interested in streaming music, just accessing my data. | 17:14 |
| mandel | dobey: ok going to look | 17:14 |
| nessita | dobey: what was it this time? | 17:14 |
| dobey | nessita: it's mucking up permissions on stuff under _trial_temp, so trying to remove some things fails | 17:15 |
| dobey | or maybe that also happens in trunk? | 17:15 |
| nessita | dobey: but is that mandel's changes? I don't think so... | 17:15 |
| nessita | dobey: I would guess your tarmac trunk has a dirty _trial_temp, can that be it? | 17:16 |
| dobey | no | 17:16 |
| nessita | dobey: any other idea? | 17:16 |
| dobey | or well, it's dirty now, becuase of mandel's branch | 17:16 |
| nessita | dobey: mandel's branch does not play with dir perms, so is odd | 17:16 |
| mandel | well also because if I dif play it would be for windows | 17:18 |
| dobey | well i don't know what it is. i am just reporting the facts. empty dir, merge mandel's branch, run tests, boom. | 17:18 |
| dobey | mandel: well, and linux doesn't have a "hidden" file permission :) | 17:18 |
| mandel | dobey: ok, I'm going to take a look locally :) | 17:18 |
| dobey | i'm trying trunk to see what happens there | 17:19 |
| mandel | dobey: what do you mean with hidden ? | 17:19 |
| dobey | mandel: on windows, files can be "hidden" via an attribute/permission thing. i was just trying to think of some actual file permission that exists on windows that's in the FS :) | 17:20 |
| mandel | dobey: oh, yes true, and you also have other strange ones… | 17:20 |
| mandel | let me first fix conflict I've got in a diff branch and then take a look at that | 17:20 |
| dobey | mandel: hooray for using utf-8! | 17:21 |
| mandel | dobey: you found the issue? | 17:21 |
| dobey | mandel: no, your sentence ended with "…" :) | 17:22 |
| mandel | haha | 17:22 |
| nessita | mandel: I asked you 2 questions before re your qt integration branch: why calling QObject.__init__(self) instead of super()? and why is this for "type(data) == type(False)"? | 17:23 |
| iheartubuntu | does U1 have a mobile site for smartphone users? im not really interested in streaming music, just accessing my data. | 17:23 |
| dobey | i wonder if we can parallelize tests | 17:23 |
| dobey | iheartubuntu: there is a files app coming for android if that's what you're looking for | 17:24 |
| iheartubuntu | aawww im still stuck with an iphone | 17:24 |
| mandel | nessita: QObject.__init__ in most cases you cannot use super in PyQt, but I've just tested it and it works, so no real reason for this exact class | 17:25 |
| mandel | nessita: the type is that I want to make sure it is a <type bool> | 17:26 |
| nessita | mandel: then you should use type(True) == bool\ | 17:27 |
| nessita | type(something) == bool | 17:27 |
| mandel | nessita: what's the diff? | 17:27 |
| nessita | mandel: https://code.launchpad.net/~mandel/txnamedpipes/add_qt_integration/+merge/61923 line 89 | 17:28 |
| mandel | nessita: I have a question about the FakeSdtool class in control panel, what is it for? | 17:28 |
| nessita | mandel: before going to that, let's have a conversation at a time :-) Are you ficing the type() thingy? | 17:29 |
| nessita | fixing* | 17:29 |
| dobey | nessita, mandel: i am also seeing the file permissions things in trunk | 17:30 |
| nessita | dobey: you fixing it as well? :-D | 17:30 |
| dobey | if i knew what was wrong i'd fix it, but i don't | 17:30 |
| nessita | mandel: please answer me before I swicth my attention to something else :-) | 17:31 |
| dobey | problema por chicharros :) | 17:31 |
| nessita | dobey: can you please cry outloud for help to chicharreros? | 17:31 |
| mandel | nessita: let e think about the answer | 17:31 |
| mandel | nessita: I really do not see the difference between the code you propose and the one is present? is it a matter of style? | 17:33 |
| nessita | mandel: not only style but confusing people | 17:33 |
| nessita | mandel: someone can easily do: False = 'a; | 17:33 |
| nessita | False = 'a' | 17:33 |
| nessita | and then your code will be checking against the string type | 17:34 |
| dobey | nessita: hrmm, i wonder if some weird condition is being hit due to the broken tests setup/teardown/super usage all over the place | 17:34 |
| mandel | nessita: well, yes that is the same arg used when doing c, but if the assing Fals to a string, wel they are stupid… I can change it if you want | 17:34 |
| nessita | mandel: yes please | 17:35 |
| nessita | ok, I need to reboot due to font update breakage | 17:36 |
| mandel | alecu: nessita: I need to walk we dog will be back soon | 17:37 |
| nessita | mandel: I'm back | 17:44 |
| nessita | mandel: ping? | 17:45 |
| nessita | mandel: please ping back when you're here | 17:52 |
| dobey | nessita: am running tests on your testingit branch to see if it also has perms errors | 17:55 |
| nessita | dobey: let me know | 17:56 |
| dobey | nessita: not sure. your branch ate all my ram, and i got the inotify "too many open files" in it :( | 18:02 |
| dobey | it was 1.4G and climbing when i killed it just now :( | 18:02 |
| nessita | dobey: ouch | 18:02 |
| nessita | dobey: if you review the changes, you can check that they make sense... anyways, not funny to ran out of RAM | 18:02 |
| nessita | alecu: you're back! :-) I was feeling lonely | 18:02 |
| dobey | nessita: check what changes? | 18:03 |
| nessita | dobey: those from my branch | 18:03 |
| alecu | jajaja | 18:04 |
| dobey | nessita: i'm not saying they don't, but stuff is obviously broken :) | 18:07 |
| dobey | exceptions.AttributeError: 'FakeNetworkManager' object has no attribute 'busName' | 18:07 |
| dobey | like that | 18:07 |
| nessita | dobey: is that u1client trunk? :-( | 18:08 |
| nessita | dobey: yes things are broken. Not sure how to escalate this, can I suggest you try to define a plan of action with phil? | 18:08 |
| dobey | that was from your branch. some of the tests were failing with that, intermixed with the inotify issues | 18:09 |
| nessita | dobey: I would love to help, I like fixing this kind of messes. But for now, I can't | 18:09 |
| nessita | dobey: oh | 18:09 |
| nessita | weird | 18:09 |
| nessita | hum I think I removed that because as far as I saw it was not needed | 18:09 |
| dobey | well, that's fine, but we do need to fix the perms issue that's in trunk, and blocks branches now | 18:09 |
| nessita | yes | 18:09 |
| mandel | nessita: pong | 18:13 |
| mandel | tell me :) | 18:13 |
| * pfibiger just noticed he got pinged. | 18:13 | |
| nessita | mandel: I added comments for both branches for minor fixing, the test request is not that minor and I would like to read your opinion on that one | 18:14 |
| dobey | i don't know if i'd call that a ping, so much as a dereferencing :) | 18:14 |
| pfibiger | hehe | 18:14 |
| mandel | nessita: which branch is the test request one? | 18:15 |
| nessita | mandel: in the txnamedpipes | 18:15 |
| mandel | nessita: ok, well that is a complicated thing to do… we could fake the integration, but I'm not happy about that. | 18:16 |
| mandel | nessita: other thing to do would be to test the logic of the diff test, which also seems a little off for me, but more doable | 18:16 |
| nessita | mandel: what about tetsing the class you're developing? not the integration itself. Can that be done? | 18:16 |
| mandel | nessita: yes, we could test the implementation of the event, eventFilter and postevent methods | 18:17 |
| nessita | mandel: would that be quickly doable? | 18:18 |
| mandel | nessita: not nice because is not very tdd, but we can do that… the problem is that that class does the interleave of the reator which I have no clue of how to test.. maybe if I look in twisted trunk .. | 18:18 |
| mandel | nessita: yes, is doable, and will brin some coverage to the code, it would stop from other people braking it, but I'm not a happy camper on how the test would look | 18:19 |
| mandel | nessita: I dont know how to explain it, but they will look artificial | 18:19 |
| nessita | mandel: not sure what that means at code level | 18:19 |
| nessita | I mean, when applied to code | 18:19 |
| mandel | nessita: fragile tests | 18:19 |
| nessita | mandel: can't we do plain unit tests where we don't depend on other components such as twisted? | 18:20 |
| mandel | nessita: yes, I'll write classic unittest that ensure the logic on the methods used for the inegration work as expected | 18:20 |
| mandel | should not be too much work | 18:21 |
| dobey | nessita: seems like facundo is only chicharros around today; and i don't see him on irc :( | 18:21 |
| nessita | mandel: thanks (do not spend too much time on that please) | 18:21 |
| nessita | dobey: facundo is on swap day today, now that you mention | 18:21 |
| mandel | nessita: wont | 18:21 |
| dobey | nessita: then nobody is around; lucio and verterok are on holiday, and the new guy is, well, new :) | 18:21 |
| mandel | nessita: I'll do that in an hour, I was going to go to rugby, tom I'll move to the argetina timetable | 18:21 |
| nessita | mandel: ok. Is there any chance you fix the conflict first? (in the other branch) | 18:22 |
| nessita | so alecu and I can do the review | 18:22 |
| mandel | nessita, dobey: before I go, in the test case of the sd in the tear down one of the methods ensures that the readonly files are read-write so that they can be deleted, maybe the issue is there | 18:22 |
| mandel | nessita: just pushing it right now | 18:22 |
| nessita | mandel: great | 18:23 |
| dobey | mandel: maybe; i suspect it's probably not getting called now, with the changes to devtools or something :( | 18:23 |
| dobey | ugh, there are lots of chmod calls | 18:24 |
| mandel | dobey: I think that the base test case they use for that does not inherit from the dev-tools test case, but I'm saying this from the top of my head | 18:24 |
| mandel | dobey: yes, lots of the, for each time you create the dirs used by the sd integration tests | 18:25 |
| nessita | dobey: I would guess the chmod-cleanup is being done in tearDown instead of inside a self.addCleanup call, so if there is a failure, tearDown is not called | 18:25 |
| mandel | s/the,/them | 18:25 |
| nessita | dobey: (but those cleanup functions registered with self.addCleanup will be called even in case of errors) | 18:25 |
| mandel | nessita: one question, the test_install_bookmarks_extension, does it always fai? | 18:25 |
| nessita | what I meant was: tearDown is not called if there is an exception inside setUp | 18:26 |
| nessita | mandel: it never fails, it has nothing in it (I would guess) | 18:26 |
| * nessita checks | 18:26 | |
| dobey | nessita: tearDown should be called still; afaik twisted adds tearDown with an addCleanup() | 18:26 |
| mandel | nessita: I get a timeout | 18:26 |
| nessita | mandel: where's the error? | 18:26 |
| nessita | dobey: I'm pretty sure tearDown is not added as a addCleanup | 18:27 |
| nessita | 768 d.addBoth(self.deferRunCleanups, result) | 18:28 |
| nessita | 769 d.addBoth(self.deferTearDown, result) | 18:28 |
| mandel | nessita: ubuntuone.controlpanel.integrationtests.test_dbus_service.OperationsTestCase.test_install_bookmarks_extension | 18:28 |
| nessita | dobey: is not added as a cleanup :-) | 18:28 |
| mandel | nessita: I just get tiral telling me that is still running after 3 | 18:28 |
| mandel | seonds | 18:28 |
| dobey | nessita: ok, whatever, doesn't matter, because we're not hitting the case you're talking about, since the tests are passing :) | 18:28 |
| nessita | mandel: are you up to date? and I mean every single package (u1devtools) | 18:28 |
| dobey | nessita: ie, the tests pass and tearDown itself is failing, it seems | 18:29 |
| dobey | or just not ever getting run | 18:29 |
| nessita | dobey: ok, then I better focus on this windows thingy | 18:29 |
| dobey | similar to the problem we are having with the InvalidDBusSession thing :( | 18:29 |
| mandel | nessita: yes.. but I;ve got strange issues with my testing vm, when I get back from rugby I'll test in a real up to date natty | 18:29 |
| nessita | mandel: ack | 18:30 |
| mandel | nessita: I'll ping you with the results :) | 18:30 |
| mandel | don't hate windows too much | 18:30 |
| nessita | mandel: please | 18:30 |
| nessita | too late! | 18:30 |
| nessita | :-P | 18:30 |
| dobey | hmm | 18:37 |
| dobey | need to buy more ram :( | 18:49 |
| dobey | nessita: hrmm, i've got part of it fixed it seems, at least :) | 19:06 |
| nessita | dobey: yeah? great. What was it? | 19:06 |
| dobey | nessita: what i last suspected; inlinecallbacks/setup/teardown fiasco :( | 19:06 |
| nessita | hu | 19:07 |
| nessita | uh | 19:07 |
| dobey | i don't know if i understand the dbus tests in syncdaemon well enough to fix it right though | 19:07 |
| nessita | dobey: if you have specific questions I can try to help you | 19:08 |
| dobey | http://pastebin.ubuntu.com/626733/ | 19:09 |
| dobey | those are the 2 failures i'm currently getting (some other weirdness as well, but this is the big blocker atm) | 19:10 |
| nessita | looking | 19:10 |
| dobey | i changed the tests to yield d and use inlineCallbacks, but didn't help | 19:11 |
| nessita | dobey: I would add several prints inside the if reply_handler: block to see what branch is entering in and what's the value of args_list | 19:13 |
| nessita | dobey: seems like what the dbus call is returning is not what the test expects. Can you please show me what changes you made re: inlinecallbacks+setup+teardown? | 19:14 |
| dobey | hmm | 19:20 |
| * dobey tries | 19:22 | |
| dobey | nessita: seems those two tests block on the " config.get_user_config().set_udf_autosubscribe(not result) calls in the disabled reply handler | 19:26 |
| nessita | dobey: I'm lost, can you rephrase using two "? :-D | 19:27 |
| dobey | http://pastebin.ubuntu.com/626742/ | 19:27 |
| dobey | current diff | 19:27 |
| dobey | nessita: sorry, paste issue; closing " should have been after the (not result) | 19:27 |
| dobey | "config.get_user_config().set_udf_autosubscribe(not result)" | 19:27 |
| nessita | dobey: I know what the problem is | 19:28 |
| nessita | dobey: you removed the BaseTwistedTestCase as parent class, which takes care of restoring the user config | 19:28 |
| nessita | dobey: which is in turn used as a precondition (to be in a given state, the default) for the tests | 19:29 |
| dobey | hrmm, ok | 19:29 |
| nessita | dobey: the tests are failing because they assume they have an initial config that is not being there | 19:29 |
| nessita | (since that config is being messed up by other tests and no one is restoring it) | 19:30 |
| nessita | dobey: makes sense? | 19:30 |
| dobey | yes; but doesn't make sense that they were the only 2 that failed there :) | 19:30 |
| nessita | dobey: well, it depends on the order the tests executed, this time the previous tests left the config in a way ionly 2 are broken | 19:31 |
| nessita | only* | 19:31 |
| nessita | dobey: the easy fix is to restore the config at setUp, for example | 19:31 |
| dobey | well i've fixed that by fixing the inheritance | 19:31 |
| nessita | like BaseTwistedTestCase does in its setUp. So you can define the config default setting outside and call that from the 2 test cases, without inheriting from both | 19:32 |
| nessita | ok | 19:32 |
| dobey | now i have stuff like this all over the place: http://pastebin.ubuntu.com/626749/ | 19:32 |
| nessita | looking | 19:32 |
| dobey | DBusExceptions but tests still pass | 19:32 |
| nessita | dobey: ah, that is another bug that I think we need to report and ask chicharreros to fix. The test itself is not waiting for all the dbus communication to finish | 19:34 |
| nessita | dobey: but enough communication happened so the assertion pass OK | 19:34 |
| nessita | dobey: I would go ahead and leave that in place filing a High bug | 19:34 |
| dobey | ok | 19:39 |
| dobey | am making sure running all tests pass now with no perms errors from rm | 19:40 |
| nessita | dobey: yey! | 19:41 |
| dobey | whoot | 19:49 |
| Uber_Geek | silly question, when I Check out a working copy of the windows installer, I get 3 empty folders, am I doing something wrong? | 19:55 |
| dobey | nessita: https://code.launchpad.net/~dobey/ubuntuone-client/test-trial/+merge/64591 | 19:56 |
| === zyga is now known as zyga-afk | ||
| nessita | dobey: looking | 20:09 |
| nessita | dobey: changes make sense, running suite now | 20:11 |
| * thisfred as well | 20:19 | |
| nessita | test ran surprisingly fast | 20:27 |
| nessita | dobey: did you remove most of them? :-P | 20:27 |
| nessita | dobey: big approve | 20:27 |
| dobey | lol, i wish | 20:29 |
| dobey | yay, perfect timing. just about time for another tarmac pass :) | 20:30 |
| nessita | dobey: we owe you cake, you know | 20:30 |
| nessita | though I would happily trade windows work for fixing tests :-D | 20:30 |
| alecu | nessita, we'll get cake as well for you working on windows. | 20:31 |
| nessita | alecu: that's encouraging, thanks :-) | 20:31 |
| dobey | mmm, cake | 20:32 |
| thisfred | nessita: hmm, tests are SUPERslow here. Weird | 20:35 |
| nessita | thisfred: you broke it!?!?!?!? :-P | 20:35 |
| thisfred | nessita: I'm running tests for dobey's branch as well. They've been going for half an hour or so... | 20:35 |
| nessita | thisfred: that is not good: Ran 2220 tests in 288.987s | 20:36 |
| thisfred | ah AND I get errors: | 20:36 |
| nessita | thisfred: is you u1devtools up to date? | 20:36 |
| thisfred | maybe not | 20:36 |
| thisfred | damn | 20:36 |
| nessita | Version: 0.1.3+r36-10~natty1 | 20:36 |
| thisfred | yep, one revision behind | 20:37 |
| nessita | thisfred: the key one | 20:37 |
| thisfred | maybe they'll be fast now too! | 20:37 |
| * thisfred retries | 20:37 | |
| nessita | let us know | 20:38 |
| dobey | nessita: landed; and set mandel's back to approved, so it should land now on the next run in a few minutes :) | 20:41 |
| nessita | great! | 20:41 |
| dobey | and i guess i'll just have to have another day as my swap day instead | 20:41 |
| dobey | since at this point i'm about a half hour shy of being here a full day :P | 20:42 |
| dobey | nessita: and mandel's branch hath landed | 20:54 |
| nessita | that's great | 20:55 |
| dobey | so i am off. :) | 20:58 |
| dobey | later | 20:58 |
| nessita | bye! | 20:58 |
| thisfred | Ran 2220 tests in 1266.447s | 21:06 |
| thisfred | PASSED (skips=6, successes=2214) | 21:06 |
| thisfred | still 5 times slower. On my 8GB i7, but there you go. Are you using a quantum computer, nessita? :) | 21:07 |
| nessita | thisfred: nopes, an i5 with 8G ram | 21:12 |
| nessita | food time! | 21:18 |
| * nessita chews some almonds | 21:19 | |
| Uber_Geek | nummy | 21:20 |
| * fagan is back but has to go again :/ | 21:24 | |
| fagan | Uber_Geek: what installer are you talking about? | 21:25 |
| * fagan just read the scroll back | 21:26 | |
| fagan | The installer is old I wouldnt be supprised if it was broken in some way | 21:27 |
| nessita | fagan: were you delayed because of the ashes as well? :-P | 21:27 |
| fagan | nessita: the ashes? | 21:27 |
| alecu | Ok. So it's Kung Fu Panda right now, and a bit more Windows joy later. | 21:27 |
| * alecu waves | 21:27 | |
| Uber_Geek | fagan: I was wanting to look at the source for the windows installer. Nessita mentioned a complete rebuild of the windows version, but I was hoping to look to see why it was doing some specific activities on my system. | 21:27 |
| nessita | bye alecu, please remember to send your email at your final eod :-) | 21:28 |
| fagan | Uber_Geek: yeah that installer hasnt been updated for months so there wouldnt be much point in looking at it | 21:29 |
| fagan | bye alecu | 21:29 |
| fagan | nessita: oh you mean cricket | 21:29 |
| fagan | Ive never watched a game in my life | 21:29 |
| fagan | :) | 21:29 |
| fagan | Ok gtg will make up the 2 hours tomorrow | 21:30 |
| nessita | ok, I'm off bye all! | 22:21 |
| === m_conley is now known as m_conley_away | ||
| iheartubuntu | question: there was some ubuntuone updates today, which I installed, and now U1 will not connect. Anything I can do? thanks! | 22:42 |
| iheartubuntu | question: there was some ubuntuone updates today, which I installed, and now U1 will not connect. Anything I can do? thanks! | 23:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!