/srv/irclogs.ubuntu.com/2011/06/15/#launchpad-dev.txt

sinzuiStevenK: mumble?00:06
sinzuisorry.00:13
StevenKsinzui: http://pastebin.ubuntu.com/626955/00:47
sinzuiI think I have isolated the cause of several X session crashes. Typing certain number sequences in email and my editor causes me to drop into the console01:38
sinzuiI am going to test this now in IRC by typing my phone number, which I cannot do in email.01:39
sinzui301.346.922901:39
sinzuiokay. I can type it here.01:39
LPCIBotProject parallel-test build #38: STILL FAILING in 1 hr 11 min: https://lpci.wedontsleep.org/job/parallel-test/38/01:40
wgrantSo can't test/release the pickers further :(02:14
wgrantBad buildbot.02:14
wgrantBlocking codeimport QA :(02:14
lifeless*blink* 1209 Time Outs02:31
wgrantI would tend to doubt that.02:32
wgrantBut I guess.02:32
lifelessyesterday was ndt-fail was't it02:32
StevenKIt was02:33
wgrantIt was. I'd expected more.02:34
wgrantI guess it was a quiet time.02:34
* wgrant cleans up dogfood's shelf.02:41
LPCIBotProject windmill-devel build #222: STILL FAILING in 14 min: https://lpci.wedontsleep.org/job/windmill-devel/222/02:41
StevenKUh oh02:47
StevenKbzrlib.errors.ConnectionError: Connection error: while sending GET /~launchpad-pqm/bzr-git/devel/.bzr/repository/packs/8dff80eb7a417959127398ef4268cdd3.pack: [Errno 110] Connection timed out02:48
StevenKWhee!02:48
LPCIBotProject windmill-devel build #223: STILL FAILING in 7.1 sec: https://lpci.wedontsleep.org/job/windmill-devel/223/02:49
StevenKSigh02:49
* StevenK shoots the builder in the face02:50
wgrantsinzui: Have you updated buildbot and convinced StevenK to fix jenkins?03:01
wgrant(although jenkins might fix itself if you've fixed launchpad-dependencies)03:01
StevenKIt ought to03:01
spivStevenK: incidentally the package importer got some timeouts from Launchpad a few minutes before you said that.03:03
wgrantspiv: Is it OK now?03:03
spivwgrant: yes, it just had a few at 01:41 (jubany time)03:07
wgrantErk.03:08
spivwgrant: see the most recent failures on http://package-import.ubuntu.com/status/03:08
wgranthttp://package-import.ubuntu.com/status/libgit-ruby.html03:10
wgrant        <h1>Sorry</h1>03:10
wgrant        <p>03:10
wgrant          Launchpad is offline for scheduled maintenance.03:10
wgrant          We should be back soon.03:10
wgrantWhat.03:10
wgrantLOSA ping.03:10
hloeungwgrant: hi03:11
wgranthloeung: Did something happen to the network/haproxy/something at 11:41?03:11
hloeungI don't think so03:12
hloeungwhat's the problem?03:13
wgranthloeung: jubany got a scheduled maintenance 503 from haproxy.03:13
wgrantAnd jenkins (on canonicloud) got a connection timeout to crowberry.03:13
=== jtv changed the topic of #launchpad-dev to: Performance Tuesday ! | https://dev.launchpad.net/ | On call reviewer: jtv | Critical bugs: 202 - 0:[######=_]:256
wgranthuwshimi: Hi.04:01
huwshimiwgrant: Hey there04:02
wgranthuwshimi: Have ytou looked at the new person picker?04:03
wgranthuwshimi: Try searching in the assignee picker on https://bugs.qastaging.launchpad.net/launchpad/+bug/123404:03
_mup_Bug #1234: Gina is an unmaintainable mess of command line options, environment variables and shell scripts <lp-foundations> <Launchpad itself:Fix Released by debonzi> < https://launchpad.net/bugs/1234 >04:03
wgranthuwshimi: I'm wondering about the "Details..." link... it seems less than ideal.04:03
huwshimiwgrant: No I haven't. I'll take a look04:03
huwshimiwgrant: Is it supposed to open in a new window?04:05
wgranthuwshimi: I believe that is the intention. I'm not convinced it's the ideal solution, but it was the easiest at the time.04:06
huwshimiwgrant: It shouldn't be a green link then04:06
wgrantThat's what I said.04:06
wgranthuwshimi: But it also doesn't navigate away from the current page.04:06
wgrantSo it might not be blue either.04:07
huwshimiwgrant: I believe green links are for doing an action that will affect the current page.04:08
huwshimiwgrant: Also the ellipsis would imply that it's going to an action on the page too04:12
huwshimiwgrant: So this is to help people get some further information about who the person and to know they are selecting the correct person?04:17
wgranthuwshimi: I believe so.04:26
wgranthuwshimi: I think it should really expand the picker entry inline.04:26
wgrantBut that's a bit difficult, AIUI.04:26
huwshimiwgrant: What's the difficulty?04:27
wallyworld___wgrant: huwshimi: sinzui wants to navigate to the person page since we can't pre-guess the info they will need to make their decision04:27
wgrantJumping out of an inline picker into a new page seems... questionable.04:28
wallyworld___green was chosen as the colour because the action of clicking does not navigate away from the current page - that's what was communicated to me anyway04:28
wallyworld___questionable maybe, but how else do we do it?04:28
wallyworld___it's not that uncommon a paradigm04:29
wallyworld___a lot of the web pages i visit do that04:29
wgrantPopups that spawn new pages? Odd.04:30
wgrantI mean, these popups exist just to return data to the original page.04:30
wallyworld___yes, but you need to be able to tell you are picking the correct thing - that's one of the tenants of the disclosure work04:31
jtvNot quite the same, but doesn't the help system already face this problem?  Any ideas that could be cribbed from there?04:31
jtvwallyworld___: tenets, I hope.  :)04:31
* wallyworld___ can't spell04:32
=== wallyworld___ is now known as wallyworld
* jtv was worried about LCP for a moment04:32
LPCIBotProject windmill-devel build #224: STILL FAILING in 1 hr 4 min: https://lpci.wedontsleep.org/job/windmill-devel/224/04:32
wallyworldjtv: i haven't used the help system. that would be RTFM and men don't read instructions :-)04:33
jtvwallyworld: eerie how you identify the reason for my uncertainty there04:34
jtvBut still04:34
jtvI think it also pops up a window with text that may have links, which may open new browser windows.04:34
jtvIn which case, crib copy & steal!04:34
wallyworldjtv: well the picker does that now so there's no need to steal anything04:35
jtvWhat I mean is, doing whatever it does would technically make it a UI pattern.  :)04:36
wallyworldah right04:37
huwshimiOpening a new window is certainly suboptimal. Can someone can give me some more information on why we can't guess what info might be useful for making this descision?04:41
wallyworldhuwshimi: what info is needed depends on the context of what is being picked and what it is being picked for, and also the user's prior knowledge04:44
wallyworldthere's no easy 2 or 3 lines of info what can be displayed in every case that is guaranteed to be what the current user wants to see04:45
wallyworldso we have to take them to the indx page of the thing they think they want to pick so they can poke around and see if it's what they want04:46
huwshimiwallyworld: Can you give me an example?04:46
wallyworldpicking an assignee for a bug task04:47
wallyworldor a source package for ....04:47
wallyworldi haven't got a good example of the latter one04:47
huwshimiwallyworld: And what is the difference in information that might be required between those two?04:48
wallyworldso picking an assignee, you may want to check what other bugs they've worked on before giveng them the new one04:48
wallyworldhuwshimi: i know little about source packages in lp so can't really given a good example04:48
wallyworldhuwshimi: i'm more or less paraphrasing what was told to me when i asked these questions04:49
huwshimiwallyworld: No problems, I'm just trying to understand the problem.04:49
wallyworldsure, that's offering additional info :-)04:49
wallyworld/that's/just04:50
wallyworldhuwshimi: you maybe want to join our standup tomorrow and we can discuss :-)04:50
huwshimiSo really this is more about a convenient link to the person's profile rather than just providing additional info for the picker04:51
huwshimiWhich is outside the scope of what you'd want to accomplish with the picker04:51
wallyworldyes04:52
huwshimiAs in, it's not the job of the picker to provide that level of information about the user. That's additional work you might want to do to figure out who this person is.04:52
wallyworldbecause there's no one size fits all solution for what extra info could or should be displayed in the picker for each context04:52
wallyworldyes04:53
wallyworldi think you have it :-)04:53
wallyworldthe picker should try and provide as much as it can so the user doesn't have to click the link :-)04:53
wallyworldand we do that with the newly added work to show the nicks and correct ordering and badges etc04:54
wallyworldbut we also need to offer a way to get extra info if what's there doesn't suffice04:54
huwshimiOK, I think the "Details..." link implies that you're going to get a little bit more information and what might need to happen is just to rename the link and drop the ellipses and change the colour. I'm not sure what our pattern should be for external links.04:55
wallyworldhuwshimi: we can implement whatever is deemed necessary, just let us know what is needed in terms of styling :-)04:57
huwshimiSo that link could be something like "View profile"04:57
wallyworldand get agreement from the stakeholders04:57
wallyworldsounds reasonable for a person picker04:57
huwshimiAnd make the link blue04:57
wallyworldperhaps different wording is needed for other vocabularies04:57
huwshimiwallyworld: Sure.04:58
StevenKhuwshimi: But not pink with purple polka dots? :-)04:58
wallyworldhuwshimi: i was told not to make the link blue, so that would need to be a discussion point :-)04:58
huwshimiStevenK: Only under a feature flag just for you.04:58
StevenKI don't know about that :-)04:58
StevenKBut nice comeback :-P04:58
wallyworldwhat's wrong with pink and purple?04:58
huwshimiwallyworld: I think it does need to be blue because it _does_ take you to a new page04:58
huwshimiwallyworld: It just doesn't change the url of the current page04:59
wallyworldhuwshimi: but it *doesn't* trash the current page04:59
huwshimiwallyworld: Unless you have your browser set up to not open new window links in new windows04:59
wallyworldhuwshimi: yes, but even if you do (why anyone would nowadays with tabbed browsing is beyond me), your current page is still there04:59
huwshimiwallyworld: And I think that breaks the "do something to the current page" which is what the green links are supposed to represent05:00
wallyworldhuwshimi: that was my argument initially too.05:00
StevenKwallyworld: Er. So, we still support IE6. And IE6 has no tabs.05:00
wallyworldStevenK: and why anyone still uses IE6...... (i know, i know brain dead corporates)05:01
wallyworldhuwshimi: anyways, it's just a css attribute. i'm sure we will do whatever the stakeholders say we need to :-)05:02
huwshimiwallyworld: I think it needs a wording change too05:02
wallyworldok05:02
wallyworldhuwshimi: so you watching SOO tonight? I know StevenK and wgrant aren't man enough to enjoy it :-P05:05
StevenKMeh, SoO05:08
StevenKwallyworld: http://www.theie6countdown.com/default.aspx is telling, but I suspect you've seen it.05:08
huwshimiwallyworld: I'm catching up with some friends and then probably catch the end of it... if seeing friends doesn't mean watching SOO with them05:08
* wallyworld looks05:08
StevenKPutting the banner on would make me happy, but only if it links to getfirefox or so05:09
wallyworldStevenK: wow, china and india surprise me05:10
StevenKwallyworld: And South Korea05:10
wallyworldStevenK: that's because south koreas has a propriatary encryption solution for online banking that *requires* IE6 and is incompatible with every standard05:11
wallyworldAFAIUI05:11
wgrantMost South Korean bank sites use ActiveX, yeah :/05:11
StevenKThen I'd expect a higher percentage, TBH05:12
wallyworldor maybe it's just *requires* IEx05:12
StevenKwallyworld: If you want to know the funniest thing -- that website was written by the IE team themselves05:12
wallyworldwell, i think even they realise now what they did :-)05:13
LPCIBotProject windmill-devel build #225: STILL FAILING in 41 min: https://lpci.wedontsleep.org/job/windmill-devel/225/05:14
StevenKIE6 was during Microsoft 3-E approach to the Internet, wasn't it?05:14
StevenK(Embrace. Extend. Extingush.)05:14
wallyworldyep05:15
wallyworldi think of it as s/Extinguish/Exterminate (said with a Darlec accent)05:16
lifelessSoO ?05:16
wallyworldState Of Origin05:16
wallyworldQLD vs NSW05:16
wallyworldthe ultimate battle :-)05:16
StevenKlifeless lived in NSW for a number of years, he probably got quite good at filtering it out.05:18
huwshimiwallyworld: Well not really. It would have to be a little more evenly matched to be the ultimate battle.05:18
wallyworld:-D05:18
StevenKAnd not be based on thugby05:18
wallyworldi can watch NSW get beaten anytime. I don't care if it's even or not :-)05:18
huwshimiwallyworld: haha05:19
wallyworldwhat's wrong with Rugby League|Union05:19
wallyworlddoes StevenK prefer watching soccer? or netball? perhaps synchronised swimming?05:19
lifelesswallyworld: oh, league. Not union :>05:19
wallyworldlifeless: yes, SOO is League05:20
StevenKwallyworld: AFL05:20
mwhudsonit's even more slabs of beef running into each other than most league afaict05:20
wallyworldah, the game of tight shorts05:20
wallyworldmwhudson: you mean AFL?05:20
mwhudsonwallyworld: state of origin05:21
wallyworldmwhudson: ah yes, the intensity is pretty high. and they hit *hard*05:21
wallyworldlifeless: i may have found a bug with the bug subscription portlet - specifically the team membership check. well it's an issue in dev, but not production perhaps due to the really small batch size in dev05:53
wallyworldthe client makes an ajx call to a team's member_details property via the web service05:54
wallyworldbut this only returns the first batch of members05:54
wallyworldand so the membership check may erroneously fail05:54
wallyworldif the person being checked is not in the first batch of results05:54
wallyworldthat's what's happening on my dev setup anyway05:55
LPCIBotProject windmill-devel build #226: STILL FAILING in 39 min: https://lpci.wedontsleep.org/job/windmill-devel/226/05:55
wallyworldthe membership check is done in javascript by loading the team members. not sure why it was implemented that was instead of asking the server "is this person a member". it's still an RPC either way05:57
wallyworldhas something changed recently to limit gets to web service CollectionField attributes to return only one batch at a time? or is this a long standing issue that we have avoided hitting in prod?05:58
wgrantwallyworld: Don't go near that code.06:01
wgrantwallyworld: Yellow is still rewriting it.06:01
wgrantI fixed it myself a couple of weeks ago, but set the branch aside once Danilo informed me that it was being completely reworked.06:01
wallyworldshit. i've based the blueprint subscription stuff on it. that's where i've found the bug06:01
wgrantwallyworld: CollectionFields have always been batched.06:01
wallyworldwgrant: so the code was broekn to begin with :-(06:02
wgrantOf course.06:02
wgrantThat code is nauseating and buggy.06:02
wallyworldbollocks06:02
wgranteg. you can't AJAX-subscribe someone with the same displayname as an existing subscriber.06:02
wallyworldmy version is very much trimmed down to the bare essentials since there's no direct vs indirect subscriptions etc06:03
wgrantAnd it spends longer working out where to place the spinner (three HTTP requests, IIRC) than it does between showing the spinner and finishing the operation (one HTTP request).06:03
wallyworldyes, all true :-(06:03
lifelessGary and I both had doubts about that spinner stuff06:03
lifelessif its the one I think it is ;)06:04
wallyworldi didn't realise the code i was reusing was so new :-(06:04
wgrantwallyworld: Hm, it's not new.06:04
wgrantwallyworld: It's just yet to be reworked as part of the... completed and released feature.06:04
=== almaisan-away is now known as al-maisan
wallyworldwell, i may just clean up this issue in my new blueprints stuff then and revisit it later when bugs is done06:05
wallyworldit's also impossible to fully test without resorting to windmill06:06
LPCIBotProject windmill-db-devel build #391: STILL FAILING in 1 hr 7 min: https://lpci.wedontsleep.org/job/windmill-db-devel/391/06:19
StevenKWindmill, you make me sad.06:20
lifelessgmb: yo06:43
lifelessgmb: in https://code.launchpad.net/~gmb/launchpad/bug-61531/+merge/63672 I had a question for you; can has answer?06:43
lifelesswallyworld: is https://code.launchpad.net/~wallyworld/launchpad/blueprint-subscriptions-tales-refactor/+merge/63949 or needs-another-review ?06:53
poolielifeless, hi06:59
pooliethanks for resolving those mps, that's so great06:59
poolie\heart06:59
lifelessnp07:01
pooliei don't know if you saw the conversation on bzr recently07:08
pooliebut i think wip mps are a graveyard07:08
poolieyou might as well just reject community contributions than put them there07:09
lifelessI saw it07:09
lifelessI don't agree07:09
lifeless:)07:09
poolietherefore, specifically, i would flip nigelb's mp back to needsreview07:09
poolieok :)07:09
lifelessthat said, even if I ungreed unreservedly, we are not yet in a patch-pilotable position07:09
lifelessso for now, I would still move stuff to WIP, to get a clean slate so we can get a drive-to-zero thats approachable, and bring up a patch pilot model.07:10
wgrantHmm, I've always seen WIP as coming before Needs Review. And it's something that I think should be toggled by the owner.07:10
lifelesswgrant: did you see the discussion poolie is referencing ?07:10
wgrantNo.07:11
pooliehttps://lists.ubuntu.com/archives/bazaar/2011q2/073028.html07:11
lifelessso for bzr, with a patch pilot, WIP conflates 'can be piloted' and 'someone is hacking on this'07:11
poolieyes07:11
poolieideally lp would separate these07:11
lifelesswith apilot working through proposals that were nearly-there this conflation is arguably a problem07:11
poolieby, hypothetically, having assignment on mps07:12
poolieyes07:12
wgrantlifeless: Regarding launchpad-reviewers' contact address, isn't that necessary to stop all review mail from going to everyone (since it's the default reviewer, and reviewers always get mailed)?07:12
lifelessI say that I don't agree; its more nuanced than disagreement, but not something I want to drill into today.07:12
poolieit's ok07:12
lifelesswgrant: I don't believe so07:12
wgrantlifeless: What stops the mail?07:13
pooliei'm confident enough that it's worth trying in bzr, but not so much i'd advocate it to every one else yet07:13
lifelesswgrant: not being subscribed. IMBW07:13
pooliewe can see if it changes things07:13
wgrant--07:13
wgranthttps://code.launchpad.net/~cr3/launchpad/hwsubmissionset_search/+merge/6376807:13
lifelesswgrant: we can see how bzr's experiment turns out before changing anything in LP; I believe it is done.07:13
wgrantYour team Canonical Launchpad Engineering is requested to review the proposed merge of lp:~cr3/launchpad/hwsubmissionset_search into lp:launchpad/db-devel.07:13
lifelesswgrant: anyhow, we need to figure something out. the backscatter is pissing folk off ;)07:14
wgrantlifeless: Yes. We should stop working around our bugs :/07:14
pooliewhich one is done?07:18
pooliefwiw i think removing that list along the lines you describe makes sense07:19
lifelesspoolie: the bazaar codereviewers thing07:19
lifelesspoolie: wgrant is saying that you may still find all new MP's trigger mail to ~bzr07:19
lifelessdarn, where is that bug about pushing-to-make-releases gone07:20
=== al-maisan is now known as almaisan-away
poolieit would be hard for me to tell07:21
pooliethat change has been made, anyhow07:22
lifelesswgrant: I had the wrong team07:30
lifelesswgrant: its launchpad-canonical-reviewers I want to contact-ectomy07:30
wgrantOh, those are separate lists.07:31
wgrant"WTF kill it kill it" is the answer that comes to mind.07:31
wgrantlifeless: I no longer think you are crazy :)07:32
lifelesswgrant: I'm so glad ;)07:33
pooliejust curious why you say "not yet in a patch-pilotable position"07:35
lifelesshttps://code.launchpad.net/launchpad-project/+activereviews07:35
lifelessjust the size of the queue vs the time allotted to reviews07:35
LPCIBotProject windmill-db-devel build #392: STILL FAILING in 14 min: https://lpci.wedontsleep.org/job/windmill-db-devel/392/07:38
StevenKAnd another redirect.07:39
StevenKbzrlib.errors.RedirectRequested: http://bazaar.launchpad.net/~launchpad-pqm/bzr-builder/trunk/.bzr/repository/indices/aa01e422f8699f10641354d6fa588e29.cix is redirected to https://launchpad.net07:39
lifelessI think there is a bug on that07:42
lifelessit *should* 40407:43
lifelesssomeone needs to tweak the apache rules07:43
lifelessstub: hiya07:43
stublifeless: Hi07:43
stubJust looking at 0mq07:43
lifelessstub: I had a question for you in https://code.launchpad.net/~cr3/launchpad/hwsubmissionset_search/+merge/6376807:43
lifelessstub: nice07:44
lifelessstub: http://zguide.zeromq.org/page:all is a pretty good read about it07:44
stublifeless: I mentioned in my comment that we could apply the patch live. I didn't want to complicate Marc's life though by splitting patches out of his branch and stuff unless necessary.07:49
stublifeless: Although now I've decided to start giving out -1 style patch numbers even if we aren't planning on applying them live, just to make it easier if we change our minds.07:50
lifelessstub: Right, I'm not suggesting splitting07:50
lifelessstub: merely to use a -1 :)07:51
stubRight. I guess it doesn't matter which branch they land on, just as long as they land and don't get lost.07:51
lifelessstub: I heartily endorse your decision07:51
stubI'll add a comment and request a renumbering07:51
stublifeless: So on initial skim, 0mq might be suitable for an RPC mechanism, but not suitable without effort for our async jobs as we would need to build a queue with it.08:01
stublifeless: Kestrel sounded nice. You looked at that yet?08:01
lifelessstub: huh, It queues08:01
lifelessstub: it does spill to disk08:01
lifelessstub: high water thresholds, pub-sub etc08:02
lifelessstub: I'm not saying we should use it, but a quick skim won't touch its facilities enough to assess08:02
lifelessI need to reply to gavin08:02
lifelessyes, I've looked at kestrel08:02
lifelessand its also very interesting08:02
lifelesssimple api08:02
stublifeless: I thought it queued at the receiver or client, which assumes the receiver is up, and the client doesn't go down.08:02
stublifeless: So for the 'fire and forget reliable messages' story, we would need a persistent queue in the middle.08:03
stub(But maybe that is trivial with the spill-to-disk behaviour)08:04
lifelessstub: right, I haven't finished getting to grips with it08:04
lifelesselliot has got me in contact with some rabbit staff08:05
lifelessto pull on rabbits ha story08:05
lifelessand gavin has landed a new stab at the test fixture08:05
stubI'll still vote for an API for implementation agnostic messaging so we can run with whatever-works-with-the-testsuite first for potentially unreliable delivery and move up from there.08:07
lifelessI'm not objection to that, but there are risks08:07
lifelessthey centre around the definition of agnostic messaging :)08:07
stubgetUtility(IMessageQueue, 'logging').send(python_object)08:08
lifelessif its that minimal its low risk; getting into priorities, persistence, etc - thats where I was worrying :)08:10
stubRight. Stuff priorities for now, and persistence is hidden by 'implementation agnostic' and irrelevant anyway because of 'potentially unreliable'08:12
rvbalifeless: Hi ... Thanks for the review!08:15
lifelessand, we're done: approximately all reviews done08:16
lifelesshttps://code.launchpad.net/launchpad-project/+activereviews08:16
rvbawgrant: Hi William, what did you think about my replies/code changes for https://code.launchpad.net/~rvb/launchpad/init-series-bug-789091-devel/+merge/63676 ?08:17
LPCIBotProject parallel-test build #39: STILL FAILING in 1 hr 18 min: https://lpci.wedontsleep.org/job/parallel-test/39/08:30
wgrantrvba: Looking now.08:32
wgrantrvba: Re-reviewed. Much better, but there are still a few issues.08:37
rvbawgrant: Thanks a lot, I'll address your issues today.08:40
wgrantrvba: Thanks!08:40
wgrantIs blog.launchpad.net meant to feature stuff that is only relevant to Launchpad developers?08:44
lifelesssure08:50
wgrantHmm.08:50
lifelesseveryone can be an lp dev :)08:50
wgrantWhy?08:50
lifelessmore seriously08:50
lifelessstuff for the front page should be more carefully selected08:51
lifelessmost stuff for devs is at least interesting for highly technical folk08:51
wgrantWe could perhaps put them in another category.08:51
lifelessand most LP-as-host-decision-makers are highly technical08:52
wgrant"Initializing page JavaScript from the JSONCache" would be nice on a LP planet or something.08:52
wgrantBut it's not useful for users.08:52
wgrantSo it shouldn't drown out other stuff on the blog, IMO.08:52
lifelessmrevell would be a good person to talk to about this08:53
lifelessmy understanding is that its meant to just get communication out there08:53
lifelessbreaking the code of silence we got into for a few years ;)08:53
wgrantThis sounds like blogging every day for the sake of blogging.08:53
lifelessI don't think thats very useful08:54
lifelessOTOH we have 20ish folk08:54
wgrantIt was a serious proposal two months ago.08:54
lifelessI think we have interesting things to say; one per person per month at least08:54
LPCIBotProject devel build #806: FAILURE in 6 hr 3 min: https://lpci.wedontsleep.org/job/devel/806/08:58
adeuringgood morning08:59
bigjoolsmorning all09:02
lifelesshi bigjools09:09
bigjoolswotcher09:09
lifelessbigjools: is there anything you'd like from me at the moment ?09:09
bigjoolsall your base09:09
lifelessbelong to me!09:10
bigjoolsyou can fix all my bugs so I can just go to the beach?09:10
lifelessdo I look like miracle max ?09:11
lifeless :)09:11
bigjoolsalso, it's very disconcerting to find a load of earwigs in my keyboard today09:11
lifelessugh09:11
lifelessseen khan recently ?09:11
bigjoolsheh09:11
lifeless8 days to my new desktop. shiiiiny09:12
bigjoolsI shall feed them to the 5cm-across spider who's made a nest just above me09:12
wgrantbigjools: Only 5cm?09:15
=== almaisan-away is now known as al-maisan
nigelblifeless: Its on my list, just that life took a bigger priority :)09:23
nigelbI'll make the change today and request merge again09:23
bigjoolswgrant: yes, it's a small one09:23
lifelessstub: my ec2 land failed to start up for https://code.launchpad.net/~stub/launchpad/bugsummary/+merge/6458310:05
lifelessstub: so you probably want to do that yourself10:05
LPCIBotProject windmill-devel build #227: STILL FAILING in 1 hr 5 min: https://lpci.wedontsleep.org/job/windmill-devel/227/10:33
cjwatsonCould somebody be reviewer for https://code.launchpad.net/~cjwatson/launchpad/germinate-lubuntu?  Fairly trivial change ...10:36
bigjoolscjwatson: you need a merge proposal10:36
cjwatsonyup, creating now10:37
cjwatsonhttps://code.launchpad.net/~cjwatson/launchpad/germinate-lubuntu/+merge/6465010:42
wgrantcjwatson: Approved. Want it landed now?10:44
cjwatsonthat would be good, thanks10:47
cjwatsonI can't start building CDs right away because I'm blocked on disk space, but that's supposed to get sorted out this week10:47
wgrantcjwatson: cocoplum updates still require downtime.10:48
cjwatsonwhen's the next one due?10:48
wgrantProbably 3 weeks.10:48
wgrantThe last was a week ago today.10:48
wgrantBut we can do cocoplum separately in a few minutes of poppy downtime.10:48
cjwatsonHmm.  Lubuntu wants to be building CDs in time for Alpha 2; three weeks would blow that, I think10:49
cjwatson(my fault for not getting this trivial tweak in earlier)10:49
wgrantJuly 13 is the next scheduled downtime. I'll get a downtime window for cocoplum for probably Fri/Mon and deploy then.10:50
stublifeless: k10:51
wgrantcjwatson: It has landed (r13238)10:51
lifelessstub: are my estimates for getting the (disable access, do a single schema patch, restore db access) realistic (I'm thinking if we go down -fast- [e.g. pg_cancel_backend all backends in parallel and don't restart pg itself], we should be down to sub-minute of overhead10:54
stublifeless: So one thing I realized - it takes about 7 seconds to startup one of our scripts. So overhead due to zcml cruft is 21 seconds to start with.10:55
lifelessstub: one of the admin scripts?10:55
stublifeless: update.py, fti.py, security.py10:56
lifelessstub: lets kick zcml out of them10:56
stubYes, so we need to restructure that stuff.10:56
stubOtherwise I think we are fine for subminute, assuming negligable time to run the actual DDL.10:57
rvbawgrant: Just so you know, I've replied to your comments on https://code.launchpad.net/~rvb/launchpad/init-series-bug-789091-devel/+merge/63676.10:57
rvba(I'm a little bit pushy with this because I have two branches that depends on this one ... but let me say that I really appreciate your detailed reviews on this rather complicated (at least to me) matter).10:57
cjwatsonwgrant: great, thanks11:00
wgrantrvba: Thanks, I've replied.11:07
rvbawgrant: Thanks.11:08
lifelessstill, 21 seconds in the first round is tolerable, it still leaves 4 minutes for the schema + disable + enable + kill backends11:08
henningewhen did we remove Blog information from a user's profile page?11:08
lifelessstub: perhaps we should make up a tag for things to make this better, and/or things that we need to get started11:08
wgranthenninge: It was never there, AFAICR...11:08
wgranthenninge: Wiki information was removed a week or two ago.11:08
henningewgrant: maybe that is what I remember.11:09
henningeI am aware that it can easily be included in the description.11:09
stublifeless: Sounds sane.11:09
rvbawgrant: About the 1-based counter: the only problem I see is that the db column defaults to 1.11:11
lifelessgmb: oh hai11:11
henningewgrant: was spam the reason to remove it?11:11
gmblifeless: Hi.11:11
wgranthenninge: No. Bug #18666011:11
_mup_Bug #186660: Launchpad shouldn't store wiki names <lp-registry> <qa-ok> <users> <Launchpad itself:Fix Committed by bac> < https://launchpad.net/bugs/186660 >11:11
rvbawgrant: But of course, if I explicitly set it, I can make it start with 0 and everything is good (apart for the sql comments that says the counter starts at 1 :( )11:12
henningewgrant: thanks, I wonder why it is not "Fixed Released", though.11:13
wgranthenninge: I have avoided closing it because they are not entirely gone.11:13
rvbawgrant: My only argument is that to fix that properly, a db-patch will be needed.11:13
wgranthenninge: They are merely hidden from the UI.11:13
wgrantI hope bac will garden it soon :)11:14
henningeok11:15
bigjoolslifeless: something I'd like to discuss is script startup time11:18
henningeCould somebody with bugs foo please have a look at this question? I don't think I understand what the problem is.11:26
lifelessgmb: yeah, that branch - do you agree with my point about unintention explicit subscriptions11:26
henningehttps://answers.launchpad.net/launchpad/+question/16150311:26
lifelessbigjools: I'd love to discuss that; not right now (TL meeting tomorrow)11:27
bigjoolslifeless: ok.  AIUI it's to do with zcml parsing but I think we can fix that11:27
gmblifeless: You mean "is it a no-op if you're subscribed via a team?" Yes - good call. I'm updating it now to make sure that being in a subscribed team means you won't be subscribed directly.11:28
lifelessgmb: ah, just saw your mail11:28
lifelessgmb: cool11:28
lifelessbigjools: feel free to fix it ;)11:28
bigjoolslifeless: well it's not trivial :)11:29
bigjoolsbut the basic problem is that why should a script need to worry about browser zcml for example11:29
=== danilos changed the topic of #launchpad-dev to: Performance Tuesday ! | https://dev.launchpad.net/ | On call reviewer: jtv, danilos | Critical bugs: 202 - 0:[######=_]:256
danilosjtv, hi, do you think you'd have time to review https://code.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-actions/+merge/64187 (it's slightly over-sized, but mostly due to JS tests)11:36
bigjoolslifeless: still around?11:40
lifelessbigjools: barely; whats up?11:40
bigjoolsI'm looking at this rabbit test failure11:41
bigjools        self.useFixture(EnvironmentVariableFixture('HOME', '/nonsense/value'))11:41
bigjoolswtf?11:41
LPCIBotProject windmill-devel build #228: STILL FAILING in 40 min: https://lpci.wedontsleep.org/job/windmill-devel/228/11:41
bigjoolsgiven that the test is failing trying to write cookies, that looks very suspect :)11:41
lifelessbigjools: see the 3 line comment before that11:41
lifelessbigjools: the fixture is meant to self isolate and export HOME itself whenever it runs erlang stuff11:42
lifelessbigjools: this makes it fail-fast if the fixture doesn't do that.11:42
lifelessbigjools: the test fails intermittently, so that isn't the issue.11:42
bigjoolsah ok11:42
bigjoolsthe comment didn't say that11:42
lifelessbigjools: I added that in after I found that the soyuz test fixtures chdired11:42
bigjoolsyay for soyuz11:42
lifelessnn11:43
bigjoolsthanks lifeless, nn11:43
lifelessuhm11:43
lifelessI suggest getting it to fail locally :)11:43
lifelessor getting more data on what goes on when it fails.11:43
lifelessthe current code *can* pass, in a full test run. It can also fail in a full test run : so its not trivially broken or trivially correct.11:44
lifelesselliot has put me in touch with vmware11:44
lifelessI will be dropping one of their guys a brain dump tomorrow11:44
lifelessbigjools: I'm happy that you're looking at it, just noting we have some backup coming in.11:45
lifelessanyhow, *nn* for reals, I'm hosting tomorrow, so can't sleep through it :>11:45
bigjoolslifeless: yeah well I'm not looking too hard, just curious11:45
bigjoolslifeless: that's ok we'll sleep through it too11:45
bigjoolsdoes our test runner always run tests in the same order?11:50
danilosbigjools, my experience is that it does11:50
bigjoolsok ta11:50
bigjoolsallenap: so in the "daemon" function there's a few print statements that are not in the test output11:55
bigjoolssome of them trying to print $HOME11:55
allenapbigjools: I'm looking but I have to go now.12:04
LPCIBotProject windmill-devel build #229: STILL FAILING in 41 min: https://lpci.wedontsleep.org/job/windmill-devel/229/12:27
adeuringbigjools: do you have time to talk about bug 793630?13:13
_mup_Bug #793630: better cronscript setup: remove hard-coded paths from cronscripts/publishing/cron.base-ppa <Launchpad itself:Triaged> < https://launchpad.net/bugs/793630 >13:13
bigjoolsadeuring: not right now I am heading to lunch, later is ok13:13
adeuringbigjools: ok; ping me when you have time13:13
bigjoolsok13:13
danilosjtv, I am going to suppose you are off already since you haven't responded to my review request ;) cheers13:18
=== danilos changed the topic of #launchpad-dev to: Performance Tuesday ! | https://dev.launchpad.net/ | On call reviewer: danilos | Critical bugs: 202 - 0:[######=_]:256
=== matsubara-afk is now known as matsubara
=== Ursula is now known as Ursinha
Ursinhagood morning launchpadders13:39
danilosUrsinha, good morning :)14:07
cr3interesting, some site proxying launchpad but adding its own javascript is being indexed by google: http://www.anticensure.com/?__new_url=aHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQvbHAtdXBzdHJlYW0tdG9vbHMvK2J1Zy8zMzQ0NTY=14:30
benjithey could use a robots.txt file14:35
dobeynice; a big red box covering everything up14:38
=== abentley changed the topic of #launchpad-dev to: Performance Tuesday ! | https://dev.launchpad.net/ | On call reviewer: danilos, abentley | Critical bugs: 202 - 0:[######=_]:256
jcsackettsinzui: up for mumbling?14:47
* sinzui tries14:47
LPCIBotProject windmill-devel build #230: STILL FAILING in 1 hr 4 min: https://lpci.wedontsleep.org/job/windmill-devel/230/14:48
jcsackettsinzui: is sip working better for you?14:49
danilosmrevell, hi14:50
danilosmrevell, how's it going?14:50
mrevellHello danilos14:50
mrevellI'm okay thanks, how are you danilos?14:50
danilosmrevell, pretty good as well, thanks :)14:51
mrevellThat is excellent news.14:51
danilosmrevell, that's all I needed from you, thank you :P14:51
danilosmrevell, but then again, do you have a minute or two to discuss one nice little branch I've got going14:51
mrevellYes, certainly :) Some kind of phone call, or is IRC okay ?14:52
danilosmrevell, phone call is probably easier for start14:52
danilosmrevell, you can pick mumble or skype :)14:52
danilosmrevell, this is about bug 772754, fwiw14:53
_mup_Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing <qa-ok> <story-better-bug-notification> <Launchpad itself:In Progress by gary> < https://launchpad.net/bugs/772754 >14:53
mrevellI'll strike a blow for freedom and go with Mumble. Just a sec.14:53
mrevelldanilos, What channel are you in?14:54
danilosmrevell, yellow, but it seems mumble doesn't work for me14:54
mrevellSkype it is.14:55
danilosmrevell, yeah :/14:55
LPCIBotProject devel build #807: STILL FAILING in 6 hr 0 min: https://lpci.wedontsleep.org/job/devel/807/14:59
jmlsinzui: ping15:27
sinzuihi jml15:27
jmlsinzui: I'm otp atm, but would you be able to have a call w/ me sometime in the next hour and a half?15:28
sinzuiyes15:28
jmlsinzui: cool. ok if I ping you when I'm ready?15:30
sinzuiyep15:30
jmlUrsinha: https://dev.launchpad.net/Projects/Disclosure15:31
jmlbah15:37
cr3hi folks, I would appreciate if someone could land the branch that was just approved in this merge request: https://code.launchpad.net/~cr3/launchpad/hwsubmissionset_search/+merge/6376815:42
jmlsinzui: https://dev.launchpad.net/PolicyAndProcess/FeatureDevelopmentCheckpoint15:57
bachi bigjools -- care to chat/pre-imp about bug 77643716:13
_mup_Bug #776437: Enable ARM builders for PPA via API <api> <escalated> <not-pie-critical> <oem-services> <ppa> <Launchpad itself:Triaged> < https://launchpad.net/bugs/776437 >16:13
bigjoolsok16:13
bacbigjools: so are you ok with lifeless' suggestion, which is basically to do the thing your first comment said not to do ?  :)16:13
bigjoolsheh16:13
* bac needs to review the lp.commercial explosion16:14
bigjoolsgiven the fact they're desperate for this, JFDI16:14
bigjoolslp.commercial is a pox16:14
* bac hopes no one 'bzr blames' that one16:14
bigjools;)16:15
bacwell, i created it...i didn't over use it.16:15
bigjoolswell I think it's fine for commercial stuff16:15
bigjoolsbut to use it for anything else is simply crazy16:15
bacso the basics for this bug should be straightforward, i assume16:15
bigjoolslet me see16:16
bigjoolsbac: see enabled_restricted_families in the model16:18
bigjoolsexpose it on the API.  It already has a setter/getter16:18
bigjoolsand ensure the usual privileges16:19
bacbigjools: rt16:19
=== al-maisan is now known as almaisan-away
timrcI keep running into problems... when I type 'make run' now I get the following error: http://paste.ubuntu.com/627411/16:26
timrchas anyone seen this?  I think it started when I started running launchpad out of multiple branches on the same system16:27
jmlhmm.16:27
jmltimrc: is there another Launchpad instance running?16:27
timrcjml, no, and I've rebooted the VM16:28
jmltimrc: I haven't encountered the problem before, so I'm winging it... does /var/tmp/mailman/data/master-qrunner.pid exist? what about /var/tmp/mailman/data/?16:28
timrcjml, the directory does indeed exist, but not the pid file16:29
jmlok, so first up that's a lousy error from get_pid, probably bug report worthy16:29
jmltimrc: I guess I don't know why 'make run' is trying to stop mailman.16:30
flacostebigjools: i'm trying to fix bug 79708816:36
_mup_Bug #797088: Launchpad has removed privileges that UDD importer requires to function <regression> <udd> <Launchpad itself:In Progress> <Ubuntu Distributed Development:New> < https://launchpad.net/bugs/797088 >16:36
flacostebigjools: and my simple tests isn't reproducing the problem16:36
flacostethe security uses checkUpload16:36
flacostesecurity checker16:36
flacosteyou can see it in security.py:260016:37
bigjoolsflacoste: is this the updates pocket that you need to pass?16:37
flacostebigjools: couldn't I just use verifyUpload() and not bother with the pockets check in that case?16:38
flacostesince i think that's the difference between verifyUpload and checkUpload, no?16:38
flacostewhich is very confusing to be honest16:38
bigjoolsupload permissions are confusing generally16:38
bigjoolsso yes use verifyUpload16:39
jmlflacoste: sorry about the names. I  was running out of ideas.16:39
jmltimrc: oh sorry, I got distracted. I'm not sure how to help further though :(16:39
timrcjml, I think mailman is a red herring... the exception is actually occurring w/ /var/tmp/development-librarian.pid16:40
bigjoolsflacoste: checkUpload is the same as verifyUpload but with the pocket check16:40
flacostei know16:40
jmltimrc: ahh16:41
timrcthe file exists, but it's empty, which is why we get the ValueError and not the IOError16:41
flacostebigjools: after reading the implementation code :-)16:41
bigjoolsflacoste: shit, we can READ!16:41
jmltimrc: man that's a lousy error16:41
jmlflacoste: fix the docs! change the names! storm the castle!16:41
bigjoolsman, the damn air force is dogfighting over my house again16:41
flacostebigjools: time to move ;-)16:41
timrcjml, I'll file the bug on improving the exception to at least include the file name... is there a make command that removes all the pid files?16:42
flacostejml: but why two different checks in the first place? why not one with pocket=None for when you don't care about the pocket? or does the client should always care about the pocket16:42
bigjoolsflacoste: good idea16:42
timrc(not that removing the file solved my problem,  argh)16:43
jmltimrc: not that I know of.16:43
bigjoolsflacoste: it's a conflict of requirements16:43
jmlflacoste: can't recall, sorry. maybe I was trying to minimize the size of the change16:43
bigjoolssome stuff cares deeply about the pocket, other stuff doesn't give a rats16:44
bigjoolsand I suspect it's a half-done refactoring16:44
flacoste76 references to checkUpload16:46
flacoste8 to verifyUpload16:46
flacosteso I think yeah, it's a minimize changes kind of thing16:46
flacostewould be better to only use checkUpload with pocket=None for when you want to skip the pocket check16:47
bigjoolscheckUpload is more fopr the use of the upload processor16:47
bigjoolsand package copier16:47
bigjoolsnothing else is going to have a pocket16:47
flacostethe only client of verifyUpload are bugnomination! and test_branch?16:48
flacoste!!!16:48
LPCIBotProject windmill-devel build #231: STILL FAILING in 1 hr 4 min: https://lpci.wedontsleep.org/job/windmill-devel/231/16:48
flacosteand archive.checkUpload16:48
jmlflacoste: ahh, bugnomination16:49
jmlflacoste: yeah, I remember this.16:49
jmlflacoste: it was too hairy to change at the time, and I was already deep in yak shaving by giving soyuz an actual API for checking this stuff.16:49
bigjoolssomething in the bugs code is using SPPH directly too.  it needs smacking16:50
jmlbigjools: package branches have pockets.16:50
bigjoolsoh boy16:51
jmlwell, some of them do.16:51
bigjoolsI can see the generalised suite work getting bigger and bigger :(16:51
jmlwhich sort of makes sense because writing to certain package branches is (will be?) equivalent to an upload16:51
bigjoolsright16:51
jmlbigjools: I like to think of it as becoming more and more valuable16:51
bigjoolsas in costing more? :)16:52
jmlno, that other thnig16:52
jmlbenefit.16:52
bigjoolsmore work is benefit?16:52
flacostebigjools: translations is also referencing SPPH direclty16:52
bigjoolsflacoste: RARGH16:52
flacostejml: how package branches are tied to pockets?16:53
bigjoolswe need better APIs between components16:53
jmlflacoste: SeriesSourcePackageBranch16:53
timrcso odd, make start_librarian and make stop_librarian seem to work just fine :/16:53
jmlflacoste: official branches are tied to a pocket16:53
jmltimrc: check to see if a librarian is running, kill them all, delete the pid files, try again.16:53
jmlbigjools: *sigh*16:53
bigjoolsjml: tired? :)16:54
jmlbigjools: having a Suite object would be a good start toward having better APIs between components16:54
bigjoolstotally16:54
bigjoolsbut I was referring to stuff in bugs and translations poking around with publishing records, that's just wrong16:55
jmlyeah. that's often because it's the only way provided by existing APIs to do a thing, and because sometimes it feels easier to use existing APIs than add new ones.16:56
bigjoolswe need to better differentiate between internal and external APIs then16:58
matsubarajml, lunch just arrived. could you give me a few to eat and then we can have our 1-on-1?16:59
jmlmatsubara: sure.16:59
matsubarathanks, brb16:59
=== matsubara is now known as matsubara-lunch
jmlbigjools: that'd be nice17:00
bigjoolsjml: services-orientated architecture! :)17:00
jmlbigjools: Ooh. I read about those in _Wired_17:00
jmlbigjools: I hear they're really cloudy.17:00
bigjoolslol17:01
flacostebigjools: are you -1 on getting rid of verifyUpload and allowing pocket=None to checkUpload for case where you only care about SourcePackage (and not the SuiteSourcePackage)?17:08
flacosteif you are not, i can shave that yak on my branch17:09
bigjoolsflacoste: I'd favour renaming the methods so that the confusion is removed.  I'm a bit wary of someone making a change to the upload processor and forgetting to pass pocket.17:09
bigjoolsbecause it *is* required in that case or trouble will ensue17:09
bigjoolssomething like verifyIncomingUpload() and the other one could be personCanUpload()17:11
flacostebigjools: actually, currently if you pass pocket=None, it works :-)17:11
flacosteiow, there is no check that pocket is actually a valid one :-)17:11
flacosteso if the distro isn't in SUPPORTED or CURRENT, it's basically fine :-)17:11
flacoste(return True)17:11
bigjools /o\17:12
bigjoolswhat a mess17:12
flacostethere are 800 checkUpload reference17:12
flacostenot all of them are to IArchive.checkUpload but still17:12
flacostei'm not shaving that yak today :-)17:13
bigjoolsit's a hairy yak17:13
flacostei could be convinced of renaming verifyUpload17:13
flacosteonly 8 references17:13
bigjoolsright17:13
flacostecheckUploadWeDontCareAboutPocket?17:13
flacostewould make it obviously silly17:13
bigjoolslooking at it, that one is called from the upload processor as well.  Hooray.17:14
bigjoolsso it needs to be doesPersonHaveUploadRights or similar I think17:14
flacostebigjools: indirectly though17:14
bigjoolsnaming is hard :)17:15
flacostebigjools: i don't see references to verifyUpload in lib/lp/archiveuploader17:15
bigjoolsbut you get my drift I hope17:15
bigjoolsyeah it's indirect17:15
flacostethrough checkUpload17:15
flacostebecause checkUpload is verifyUpload + pocket check17:15
bigjoolsverifyPersonCanUpload() maybe?17:15
flacostei really don't think two APIs here pull their weight to be honest17:16
bigjoolsI like that one17:16
flacostecheckUpload and verifyPersonCanUpload17:16
flacostenot sure it makes a lot of sense17:16
bigjoolsit would if you knew soyuz code more :)17:17
flacosteespecially when you grep17:17
flacosteand see that everything uses checkUpload apart 3 call sites17:17
flacosteactually 217:17
flacostebugnomination17:17
bigjoolsyeah those are the ones that just need to know that person is an uploader17:17
flacosteand that new launchpad.Edit permission checker on sourcepackage17:17
timrcjml, looks like I had to use a big stick approach and just whack everything in /var/tmp17:17
bigjoolswhich is why I suggested verifyPersonCanUpload17:17
flacostebut that's also what checkUpload does17:18
bigjoolsnot exactly17:18
flacosteverify that the person has upload permission17:18
flacosteplus a pocket check17:18
flacostewhich is person independant17:18
bigjoolsit checks that the person can upload that package at that time17:18
=== matsubara-lunch is now known as matsubara
flacostethe series status representing time here?17:18
bigjoolsyes17:18
matsubarajml, I'm back. voip?17:19
jmlmatsubara: sure.17:19
jmlmatsubara: 760817:20
bigjoolsflacoste: so for me these are 2 conceptually different things.  One is "is this person an uploader?", the other is "should we let this upload in?"17:23
bigjoolsit's just that the parameter list is quite similar17:23
flacostebigjools: there is another API for should we let this upload in, it's the checkUpload(upload) method in the archiveuploader17:23
flacostewhich makes more sense as a signature17:24
flacosteand why the heck are we always passing sourcepackage and suitesourcepackage as tuples?17:24
bigjoolsflacoste: no, those are policies17:24
flacoste(distroseries, sourcepackagename) or (distroseries, sourcepackagename, pocket)17:25
bigjoolspolicy checks are completely different beasts17:25
bigjoolsthey are one aspect of the overall check17:25
flacostewouldn't the policy check delegate to the archive.checkUpload at some point?17:25
bigjoolsthe other way around17:25
flacostei don't see any call to policy checks in archive.checkUpload17:26
bigjoolsyou were talking about the one in archiveuploader I thought?17:26
bigjoolsthe code is in a bit of flux at the moment since we're ripping out a lot of the policy stuff in archiveuploader and replacing it with a more general framework that works with derived distros syncing17:27
=== salgado is now known as salgado-lunch
LPCIBotProject parallel-test build #40: STILL FAILING in 1 hr 2 min: https://lpci.wedontsleep.org/job/parallel-test/40/17:28
bigjools.checkUploadToPocket() is a policy check, it's just hard-coded instead of using the policy framework17:28
flacosteah17:29
flacostethen that's the real fix17:29
flacostemove checkUploadToPocket to a policy17:29
jml'<bigjools> flacoste: so for me these are 2 conceptually different things.  One is "is this person an uploader?", the other is "should we let this upload in?"' – that's a really good way of putting it.17:30
flacosteand at that point IArchive.checkUpload and IArchive.verifyUpload are identical17:30
flacosteand we can merge them (and possibly rename it)17:31
flacostebigjools: does that sound sensible?17:31
flacostebigjools, jml: if any of you want to review https://code.launchpad.net/~flacoste/launchpad/bug-797088/+merge/6471117:32
bigjoolsflacoste: yes but I think I'd prefer you left it TBH since I want to do more than that17:32
flacostebigjools: don't worry, i wasn't goind to tackle it17:33
bigjoolsthe work to make the uploader use the new policy framework is not trivial17:33
bigjoolsflacoste: ok :)17:33
flacostejust wanted to have a clear conscience by leaving this mess behind :-)17:33
flacostei saw the mess, didn't do anything about it17:33
flacostebut it's because the professionals are coming in to clean it up ;-)17:34
bigjoolsha17:34
bigjoolsit's one of the smallest messes in soyuz :)17:34
bigjoolsflacoste: failUnless -> assertTrue17:35
flacostebigjools: ok, think positive ;-)17:36
bigjoolsright :)17:36
flacostei can change that17:36
bigjoolsI think we deprecated the failXXX methods17:36
* flacoste wasn't aware17:37
flacosteand fixed17:37
bigjoolsflacoste: r=me!17:41
flacostebigjools: thanks!17:41
jmlmatsubara: https://dev.launchpad.net/Projects/DerivativeDistributions17:43
bigjoolsjml: did you see this: https://dev.launchpad.net/Soyuz/DerivativeDistributions17:44
jmlbigjools: no,  I hadn't.17:48
bigjoolsmostly written for devs but useful for techy users17:49
jmlcool. I'll look at that soon.17:49
bigjoolsah balls, call in an hour17:49
LPCIBotProject db-devel build #637: FAILURE in 6 hr 1 min: https://lpci.wedontsleep.org/job/db-devel/637/17:51
LPCIBotProject windmill-db-devel build #393: STILL FAILING in 1 hr 4 min: https://lpci.wedontsleep.org/job/windmill-db-devel/393/17:52
timrclifeless, ping18:03
jmltimrc: he's out.18:08
* jml is off for the day.18:08
Ursinhabye jml18:12
timrcjml, thanks...18:12
jmlg'bye18:12
timrcabentley, you there?18:12
abentleytimrc: hi.18:17
timrcabentley, I'm trying to adapt the archive api to enable setting of the private attribute, this method seems to break a lot of unrelated tests... can you easily identify anything I may be doing wrong?  It's not a lot of code, http://paste.ubuntu.com/627484/18:21
timrcthe tests I'm failing are: http://paste.ubuntu.com/627486/ -- it's odd, I'm able to create ppas from launchpad.dev and I'm able to set them private via the api18:22
abentleytimrc: I'd expect Archive.private is used in composing a lot of Storm expressions, and a python property that's not a Storm column wouldn't work for that.18:23
timrcabentley, how would it know any differently if I expose private as a getter / setter ?18:26
timrcwould think it would be completely transparent18:26
timrcbut I don't know much of anything about Storm, so... :/18:27
abentleytimrc: It's not at all transparent.  You're dealing with the class of the attribute, not the attribute itself in a Storm expression.18:27
timrcabentley, let me ask you this, do you know of any other places in launchpad where we try to keep the internal and external interface to an attribute consistent with Python properties?  I originally implemented this with a mutator but lifeless suggested this other approach with the Python property18:28
abentleytimrc: e.g. IStore(Archive).find(Archive, Archive.private == True) is used to find all private archives.18:28
abentleytimrc: generally a property is better than a mutator, and a storm column is better than a property.18:30
abentleytimrc: I've used properties myself, but that was before I found out about storm_validator, which allows columns to be used in many places where properties would otherwise be required.18:31
abentleytimrc: e.g. Job.status used to be a property, but was recently changed to use a storm_validator instead.18:32
cody-somervilleHey. I'm getting "ProgrammingError: text search configuration "default" does not exist" when my local dev instance attempts to execute sql. Anyone know what I need to do to fix this?18:35
=== salgado-lunch is now known as salgado
abentleycody-somerville: perhaps you need to run utilities/launchpad-database-setup18:38
abentleycody-somerville: beware that this will trash any existing Postgres databases on your system.18:38
cody-somervilleabentley, Yea. It doens't look like there is anything new in there for me to run18:39
cody-somervilleit has to do with the text search stuff I think that lifeless did18:39
abentleycody-somerville: And have you done "make schema"?18:40
cody-somervilleYes.18:40
abentleycody-somerville: Okay, I've never seen the error you describe, so I don't know what the problem is.18:40
abentleygenerally, those two are enough to hard-reset your database.18:41
timrcabentley, so to make this work for Storm expressions I'll need to use storm_validator?  Did you encounter this issue I'm having when you used properties?  Is there a work around?18:41
abentleytimrc: I didn't experience the issue you're having, because I originally implemented Job.status as a property, so there were no existing uses to break.18:42
timrcabentley, ah hah18:42
abentleyI don't believe there's a work around.18:43
timrcabentley, I think I'd need to basically rename private to _private18:43
abentleyI don't know whether it's appropriate for a validator to have side-effects.18:43
timrcabentley, but that seems like a big change18:43
abentleyIf it is, then a validator would be the right solution.  If not, then I'd go back to the mutator.18:44
timrcThere are 15 places that need to be updated, I'll try that, re-test and submit a merge proposal and see where that goes :)18:45
abentleytimrc: The motivation for changing Job.status from a property to a column was so that Job.status could be used in storm expressions, instead of Job._status.  It's certainly possible that a branch which introduced Archive._private into Storm expressions would be rejected.18:48
timrcabentley, ok18:51
timrcabentley, I will look at Job.status for how to use storm_validator18:51
jcsackettsinzui: up to chat a bit?18:51
=== Ursinha is now known as Ursula
=== Ursula is now known as Ursinha
=== Ursinha is now known as Ursinha-nom
jcsackettsinzui: time to chat about some package-picker stuff?19:59
sinzui I do.19:59
sinzuiis mumble working?20:00
jcsacketti heard you.20:00
jcsackettsinzui: i can hear you. it would appear you can't hear me.20:01
sinzuisip?20:02
sinzuiI have empathy back up20:02
jcsackettcalling now.20:04
jcsackettsinzui: bug 698020 bug 698022 and bug 69802420:06
sinzuijcsackett, http://pastebin.ubuntu.com/627558/20:09
jcsackettsinzui: disconnected. calling you again now.20:20
sinzuiokay20:20
matsubaradanilos, hi20:51
matsubaradanilos, could you review two small oops-tools branch for me?20:52
LPCIBotProject devel build #808: STILL FAILING in 5 hr 57 min: https://lpci.wedontsleep.org/job/devel/808/20:56
cody-somervilleDoes that mean trunk is broken ^^?20:59
lifelessmaybe21:01
matsubaraabentley, hi there, could you review two small oops-tools branch for me?21:08
abentleymatsubara: sure.21:08
matsubaraabentley, first one: https://code.launchpad.net/~matsubara/oops-tools/html-report-urls-broken/+merge/6473121:08
matsubaraabentley, second one: https://code.launchpad.net/~matsubara/oops-tools/update-deprecated-setttings/+merge/6473921:08
abentleymatsubara: Any reason not to use the URL generation stuff in Python?21:11
matsubaraabentley, how do you mean?21:14
abentleymatsubara: get_absolute_url uses string concatenation rather than actual url handling to generate its urls, which makes it more brittle.  Is there a reason why that's a good tradeoff?21:16
matsubaraabentley, just seemed like the easiest thing to do and it seems to be the recommended way in django docs: https://docs.djangoproject.com/en/dev/ref/models/instances/?from=olddocs#get-absolute-url21:18
abentleymatsubara: in that example, they're dealing with an int, so it's not string concatenation.21:21
matsubaraabentley, I didn't add the get_absolute_url method to the model as suggested in the docs because the dbsummary.py code doesn't use the Oops object itself. It has some optimization to fetch all necessary oopses using a single SQL query and the data structure returned doesn't have the oops object, just the oops id21:21
matsubaraabentley, or you mean I should be using urlparse.urljoin()?21:23
abentleymatsubara: Yes, but ideally you'd be escaping the oops-id.21:23
=== Ursinha-nom is now known as Ursinha
abentleymatsubara: e.g. with urllib.urlencode21:26
flacostewhat does it mean when i do ec2 land and after21:26
flacosteRunning tests... (output is available on http://ec2-50-19-153-15.compute-1.amazonaws.com/)21:26
flacostei get21:26
flacoste     8kB     1kB/s /21:26
flacostelike a stalled bzr progress bar21:27
flacostethat's two run that are stalled like that21:27
bacec2 instance is having difficulty talking to LP?21:28
lifelessyup21:30
flacosteso i should just kill the run and try again later?21:33
lifelessor let it continue21:34
flacostesinzui: do you recall why you mapped NoSuchSeries exception to 400 on the webservice (i would have expected 404)?21:48
sinzuiflacoste, typo?21:48
flacostehttps://code.launchpad.net/~sinzui/launchpad/api-additions/+merge/632921:48
flacostewell, it's spelled BAD_REQUEST21:49
flacosteso that's a pretty big typo :-)21:49
mwhudsonjelmer: what's the story with lots of large bzr-svn imports failing after the last rollout?21:49
mwhudsonhttps://code.launchpad.net/~vcs-imports/gcc/trunk failing is bad news for linaro21:49
flacoste"21:49
flacosteWhen calling distribution.getSeries() with an invalid name or version I get21:49
flacostean "HTTP Error 500: Internal Server Error". The content of the exception21:49
flacoste('NoSuchDistroSeries') is correct about the fact that there is no such21:49
flacostedistro series but I would have preferred if the method returns [400]21:49
flacoste"21:49
jelmermwhudson: it's the new fetching of tags :-/21:50
mwhudsonjelmer: ah21:50
mwhudsonjelmer: is there a bug for it?21:50
flacostesinzui: if you can't recall the justification for this, i'll just file a new bug and change it to 40421:51
flacostehttps://bugs.launchpad.net/launchpad/+bug/35833221:51
_mup_Bug #358332: [API] OOPS when distribution.getSeries() is called with an invalid name or version <api> <lp-registry> <oops> <story-series-milestones-releases> <Launchpad itself:Fix Released by sinzui> < https://launchpad.net/bugs/358332 >21:51
flacosteseems that the user suggested 40021:52
flacostematsubara suggested NotFound, but you went ahead and took the user suggestion21:52
jelmermwhudson, not that I'm aware of, please file one21:52
jelmermwhudson, when does a user timeout happen on the import slaves exactly/21:53
jelmer?21:53
mwhudsonjelmer: when there is no progress reported for ... the value of some config variable ... seconds21:53
mwhudsonjelmer: i think it's an hour21:53
sinzuiflacoste, I cannot think of reason, so file a new bug21:53
jelmeroh, wow21:54
mwhudsonjelmer: well, no output on stdout, and we have a special progress bar thing21:54
lifelessflacoste: +1 on making it 40421:54
* flacoste gets the razor out21:54
mwhudsonjelmer: although, um: http://launchpadlibrarian.net/73372571/vcs-imports-gcc-trunk.log21:55
mwhudsonjelmer: yeah, it's an hour21:58
mwhudsonjelmer: https://bugs.launchpad.net/launchpad/+bug/79791521:59
_mup_Bug #797915: large bzr-svn imports failing <code-import> <regression> <Launchpad itself:Triaged> < https://launchpad.net/bugs/797915 >21:59
LPCIBotProject windmill-db-devel build #394: STILL FAILING in 1 hr 4 min: https://lpci.wedontsleep.org/job/windmill-db-devel/394/22:01
LPCIBotProject parallel-test build #41: STILL FAILING in 1 hr 5 min: https://lpci.wedontsleep.org/job/parallel-test/41/22:02
jelmermwhudson: thanks22:02
mwhudsonjelmer: i've also seen imports crash with MemoryError -- is that possibly related?22:03
=== abentley changed the topic of #launchpad-dev to: Performance Tuesday ! | https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 202 - 0:[######=_]:256
jelmermwhudson: possibly - finding the tags requires more history analysis so possibly more memory usage22:08
lifelessflacoste: I'm planning on splitting my day into two today; there is a sale on in the city for various things we need22:11
flacostelifeless: sure, no problem22:19
flacostelifeless: changing from 401 to 404 will break backward incompatible change22:19
flacosteunless we versioned the exception error code, which i suspect we don't22:19
flacostedo we care?22:19
=== matsubara is now known as matsubara-afk
* flacoste does not22:32
sinzuiwgrant, wallyworld_, StevenK. I am told I am picking up a child. I believe I will more than an hour late. I will make a showing when I return to see if I am needed.23:35
wallyworld_sinzui: we can delay the call till you return?23:35
thumperhi hackers23:36
wallyworld_thumper: how's they hanging?23:39
mwhudsonjelmer: https://code.launchpad.net/~vcs-imports/gcc/trunk seems pretty stuck23:39
jelmermwhudson, I'm trying it locally, but it seems to be working here23:39
mwhudsonjelmer: oh good!23:40
jelmermwhudson, no :(23:40
mwhudsonyeah23:40
mwhudsonjelmer: tdb vs sqlite or something?23:40
mwhudsonjelmer: it doesn't seem to be using a lot of cpu https://pastebin.canonical.com/48542/23:43
jelmermwhudson: hmm23:44
jelmermwhudson, swapping a lot perhaps?23:44
mwhudsonyeah23:44
jelmermwhudson, the home directories are just on local disk right?23:45
mwhudsonjelmer: yeah23:45
mwhudsonmaybe we should be scaling the concurrency down a bit23:46
mwhudsonjelmer: see #launchpad-ops for, well, ops stuff23:46
LPCIBotProject db-devel build #638: STILL FAILING in 5 hr 55 min: https://lpci.wedontsleep.org/job/db-devel/638/23:47
thumperwallyworld_: hanging mostly normally, you?23:50
wallyworld_thumper: mired in javascript. plus kindle screen just gone bad :-(23:51
thumperwallyworld_: what's the problem with your kindle?23:51
thumperwallyworld_: Rachel suggests charging it23:51
wallyworld_screen is all messed up. about 1/4 of the screen is all corrupt23:51
wallyworld_displays garbage, random pixels23:52
thumperwallyworld_: have you tried rebooting?23:52
wallyworld_holding power button across for 15 seconds before releasing? yes. aything else?23:52
* thumper shrugs23:52
thumpersend it back?23:52
wallyworld_bit hard since it was bought over the counter in dallas23:53
thumperwallyworld_: but amazon still handle the warrenty23:53
wallyworld_i don't think i can find the receipt :-(23:53
thumperyou shouldn't have to find it23:53
thumperthey have serial numbers23:53
wallyworld_ah right. i'll email them and see what they say23:54
* wallyworld_ wonders if there's a place to stick a paperclip23:54

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!