| danilos | total for landing (including benji's removal of feature flags): 11718 line diff ;) easy, peasy, right | 13:17 |
|---|---|---|
| benji | heh | 13:18 |
| danilos | still need one review, so I'll have to bother team yellow for that since I am the other OCR today, and jtv has not responded to review earlier today (and he's probably gone by now) | 13:19 |
| bac | benji, gmb, danilos: skype at :30 | 13:27 |
| danilos | ack | 13:28 |
| danilos | bac, btw, you don't have to review the branch if you don't feel like it, I'll just wait for the next OCR to show up or get it reviewed tomorrow morning | 13:37 |
| bac | danilos: no, it'll be good as i haven't started a new task yet. which MP? | 13:37 |
| danilos | bac, https://code.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-actions/+merge/64187 | 13:38 |
| bac | gmb: you still going to have time for a lp2kanban day this week? | 13:38 |
| danilos | bac, it's mostly JS, slightly oversized, and mostly ugly JS unit tests for ajax calls :/ | 13:38 |
| gmb | bac: I think so, but it's likely to be tomorrow or Friday. | 13:39 |
| gmb | Probably tomorrow. | 13:39 |
| gmb | ] | 13:39 |
| === Ursula is now known as Ursinha | ||
| bac | hi danilos -- your branch looks good | 14:42 |
| bac | but when i was playing with it i saw this for the first time | 14:42 |
| bac | http://people.canonical.com/~bac/youaresubscribed.png | 14:42 |
| bac | that edit icon mid-sentence sure looks funny | 14:42 |
| danilos | bac, right, that's part of Gary's branch which is way to the bottom of the stack :) | 14:42 |
| bac | danilos: ok | 14:43 |
| danilos | bac, I'll note that down (I have some more reservations about the approach he took for different subscription levels, but we've discussed those already :)) | 14:43 |
| bac | danilos: ok, i just wanted to ensure that wasn't a done deal | 14:44 |
| danilos | bac, this is a pretty big change altogether, and basically a rewrite of the entire subscribing functionality for the bug page | 14:44 |
| bac | danilos: no, i understand, i just didn't know where that part fit in the big picture | 14:44 |
| danilos | bac, well, I assume it's going to stay that way unless these issues get raised as critical in the user testing or something like that | 14:44 |
| bac | and since the reviews have been spread around no one but you and gary have a clear view, so i asked. | 14:44 |
| danilos | bac, yeah, I reviewed that branch for Gary, but didn't find that much of an issue (I miss radio boxes much more instead) | 14:45 |
| bac | danilos: r=bac | 14:45 |
| danilos | bac, cool, thanks | 14:45 |
| bac | danilos: sorry, i couldn't find anything to complain about. :) | 14:45 |
| danilos | bac, heh, that's ok, I'll live by with it :) | 14:46 |
| danilos | bac, thanks again, now you are all equal in having reviewed two branches each :)) | 14:46 |
| * bac is relieved | 14:46 | |
| danilos | oh, in the combined gigantic branch, I did review two as well, yay :) | 14:47 |
| bac | gmb, benji: fwiw the lp2kanban seems to be working really well now. we're only making ~5 calls to kanban no faster than 1/sec. I'm going to write the dude and tell him we'd like to run it hourly. | 16:23 |
| gmb | Cool. | 16:24 |
| benji | very nice | 16:24 |
| gmb | I'll try not to break it tomorrow, then :) | 16:24 |
| bac | so a new card just has to have "sync:" as the title and the bug number. | 16:25 |
| benji | gmb: you might want to look at the tests tomorrow, a test run of a fresh build fails for me | 16:32 |
| gmb | benji: Right. Since I don't know the code at all, the tests seemed like a good place to start anyway. | 16:33 |
| benji | gmb: the test failure was shallow, I just fixed it so you'll have passing tests to look at, even better | 16:35 |
| gmb | Excellent, thanks. | 16:35 |
| bac | benji, gmb: somehow i overlooked those tests and thus they rotted. there are a couple of new functions that could use some unit testing. | 16:50 |
| bac | gmb: if you get around to adding the cronjob would you reply to stephen? | 16:52 |
| gmb | bac: Sure. | 16:52 |
| === Ursinha is now known as Ursula | ||
| === Ursula is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-nom | ||
| === Ursinha-nom is now known as Ursinha | ||
| bac | hi benji, you about? | 21:33 |
| benji | bac: yep | 21:33 |
| bac | benji: hey i'm stuck trying to do some API exporting | 21:34 |
| bac | you're the new leonard right? | 21:34 |
| benji | bac: I consider it an honor to carry his mantle. | 21:36 |
| bac | that's the spirit. when did you last watch "Big Lebowski"? | 21:36 |
| bac | so, i'm trying to export this thing for soyuz called enabled_restricted_families, which is a collection of processor families, arm, etc | 21:37 |
| bac | OEM needs it so they can change their archives to get build support for ARM | 21:37 |
| benji | once, fairly recently -- one too many times, I'm afraid | 21:37 |
| bac | that field is a collection of IProcessorFamily, which i must also export | 21:38 |
| bac | it's all here: http://pastebin.ubuntu.com/627617/ | 21:38 |
| bac | but when i do a 'make build' i get | 21:38 |
| bac | ZopeXMLConfigurationError: File "/home/bac/launchpad/lp-branches/bug-776437/lib/lp/services/messages/configure.zcml", line 38.2-41.6 | 21:38 |
| bac | ConfigurationError: ('Invalid value for', 'factory', "('The Processor Family Name', (<type 'int'>, <type 'long'>)) in canonical.launchpad.browser.message.message_to_canonical_url_data") | 21:38 |
| benji | looking | 21:38 |
| bac | can't figure out why that is complaining. perhaps some zcml goodness i've neglected? have you seen that error before? | 21:39 |
| benji | I haven't seen that one, but I think it's only incidentally a ZCML thing (after all, you did't make any ZCMl changes) let me look at the code that generates that error to see what it might be unhappy with | 21:40 |
| bac | i'm confused why the IMessage subsystem is even involved | 21:42 |
| benji | hmm, I wonder if it's because of the single/plural bit that collections do | 21:43 |
| bac | what do you mean? | 21:47 |
| bac | i know of singular_name and plural_name but those are optional | 21:47 |
| benji | ah, indeed, you're not using those | 21:48 |
| benji | wow, I have no clue why it's saying that | 21:53 |
| benji | still looking | 21:53 |
| benji | bac: you have a real stumper there; I think I'd need to build your branch to help any more, just looking at it isn't helping | 22:03 |
| bac | let me push it | 22:03 |
| bac | benji: on a related note, i wonder if i'm going about this wrong | 22:05 |
| benji | how so? | 22:05 |
| bac | if IProcessorFamily name attribute is unique, perhaps the call should just return and take lists of name strings | 22:05 |
| bac | i think there is precedence for that | 22:05 |
| bac | the call to the requested export of enabled_restricted_families, i mean | 22:06 |
| benji | makes sense | 22:08 |
| bac | the branch, as is, lives at lp:~bac/launchpad/bug-776437 if you're interested in puzzle solving | 22:12 |
| benji | bac: well, at the moment I'm interested in dinner ;) maybe we can get back together tomorrow (ooh, well, if I don't have jury duty) | 22:14 |
| bac | good luck. when is your phone call to find out? | 22:14 |
| bac | or do you definitely have to go? | 22:14 |
| benji | 45 minutes | 22:14 |
| bac | actually i tried really hard last time to be seated | 22:15 |
| bac | i figured that jury pool needed all the help it could get | 22:15 |
| benji | it's not definate yet but I think there's a good chance because I got a call yesterday reminding me that unless canceled I would have to serve | 22:16 |
| benji | well, I normally wouldn't mind much but it's far away (about an hour and 15 minute drive one way) and my wife's pregnancy isn't doing so hot (had to go to the ER last night) | 22:18 |
| benji | ok, off to make dinner | 22:18 |
| bac | bye | 22:18 |
| bac | just read the part about your wife. hope she's ok. | 22:18 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
