| === yaili_ is now known as yaili | ||
| czajkowski | yay adding CC to a bug gets me my theme sorted for the LC blog! | 16:03 |
|---|---|---|
| cjohnston | so i need to add the cc to get the naming convention done | 16:05 |
| czajkowski | no the naming has nothing to do with them | 16:09 |
| czajkowski | it's being changed under a policy | 16:09 |
| cjohnston | the theme had nothing to do with them | 16:09 |
| czajkowski | there are 2 distinctions cjohnston 1) the pretty name on the LD and 2) in general | 16:10 |
| nigelb | Not pretty. | 16:10 |
| nigelb | IEasy to find names. | 16:10 |
| nigelb | This was based on proper feedback at UDS. | 16:10 |
| cjohnston | in general the list looks like crap.. so its general.. so the cc can handle it | 16:11 |
| czajkowski | yeah adn we're working on it | 16:11 |
| czajkowski | cjohnston: what is your problem, we're getting teams to change it | 16:11 |
| czajkowski | sorry it's not happening over night | 16:11 |
| czajkowski | but you're kinda getting bogged down on one area we look after | 16:11 |
| nigelb | that's the one area we want help :) | 16:12 |
| czajkowski | well we;re helping and all I'm getting is grief | 16:12 |
| YoBoY | can't we try a country list instead of a team names list? easier to find the right team that way, every one is used to country lists in the commercial websites to find the right localised site. | 16:39 |
| nigelb | mars: ping. Do you have a few free minutes today or would you prefer tomorrow? | 16:49 |
| mars | nigelb, I have a few minutes now. What's up? | 16:49 |
| nigelb | mars: I was planning on setting up tests slowly for summit. | 16:50 |
| nigelb | Do I use the unittest module or nose, which one would you suggest? | 16:50 |
| mars | nigelb, for the code? | 16:51 |
| mars | nigelb, or as a testrunner? | 16:51 |
| nigelb | mars: okay, I don't know what's the difference between the two :) | 16:52 |
| mars | nigelb, nose is most often used as a testrunner on the command line. But since this is a Django project, you will probably want to use the 'manage.py test' command | 16:54 |
| mars | nigelb, here is how I run the tests: | 16:55 |
| mars | python summit/manage.py test summit.schedule | 16:55 |
| nigelb | ah | 16:55 |
| nigelb | I was a bit confused where to star | 16:56 |
| nigelb | *start | 16:56 |
| mars | nigelb, here, let me push my changes, you can try them out. The commands are simple. | 16:56 |
| mars | nigelb, do you use ubuntu for your dev work? | 16:56 |
| nigelb | mars: yeah, lucid | 16:57 |
| mars | ok | 16:57 |
| nigelb | heh, I use ubuntu for everything I guess ;) | 16:57 |
| mars | nigelb, take a look at this branch, it is my changes and tests: https://code.launchpad.net/~mars/summit/reschedule-command-tests | 17:07 |
| nigelb | mars: looking, thanks :-) | 17:08 |
| mars | nigelb, I use virtualenv for the development work and 'python summit/manage.py test summit.schedule' to run the suite | 17:08 |
| nigelb | mars: okay, I'll test this out right away | 17:08 |
| mars | nigelb, you will need to install 'model-mommy' (check the requirements.txt) to run the tests. Saves a bunch of boilerplate test code - very nice. | 17:09 |
| nigelb | oooh! | 17:10 |
| mars | nigelb, I need to go to lunch now. I should be back in an hour or so. I can talk more then | 17:10 |
| nigelb | mars: Cool, I'll play with this in the meantime :) | 17:10 |
| nigelb | zomg | 17:25 |
| nigelb | We have factory. | 17:25 |
| nigelb | This is so comfortable. | 17:26 |
| nigelb | Its like workign with launchpad code | 17:26 |
| nigelb | mars: I love it. It reminds me of writing tests for launchpad code. | 17:38 |
| mars | nigelb, cool, I'm glad you like it | 18:36 |
| nigelb | mars: This is painful for the first time, but I think it gives lots of changes, like setting up jenkins. | 18:37 |
| nigelb | *chances | 18:38 |
| === daker is now known as daker_ | ||
| mars | nigelb, what did you find painful about it? | 18:39 |
| nigelb | mars: making sure at least 60% code has coverage bit :) | 18:39 |
| nigelb | I'll probably be writing tests for the next few weeks :) | 18:40 |
| mars | nigelb, that is a good goal | 18:44 |
| mars | I started with trying to write a test for the new reschedule command functionality | 18:45 |
| mars | the bug was that meetings were rescheduled for past days. I figured a good test was to write a test for the bugfix | 18:45 |
| nigelb | :) | 18:46 |
| nigelb | will all our tests be in this one file now? | 18:46 |
| nigelb | is it wise to create a tests folder as a module? | 18:46 |
| mars | nigelb, probably not. Once the file hits 1000-2000 lines you will probably want to make it into a package. | 18:46 |
| nigelb | :) | 18:47 |
| mars | nigelb, did you get the tests to run successfully? Or get a virtualenv set up? | 18:48 |
| nigelb | mars: yes and yes :) | 18:49 |
| mars | cool | 18:49 |
| mars | nigelb, I can submit a merge proposal for this branch if you would like. I don't think it has any impact on the production code. | 18:54 |
| nigelb | mars: please do :) | 18:55 |
| nigelb | mars: I saw a conflict when I tried to merge. Could you rebase to make sure your branch is clean? | 19:01 |
| nigelb | ideally, I just want to use tarmac :) | 19:01 |
| mars | nigelb, sure, I'll update from trunk before submitting | 19:02 |
| nigelb | \o/ | 19:02 |
| daker | mhall119, cjohnston nigelb Ronnie can we merge this https://code.launchpad.net/~daker/loco-directory/fix.708995/+merge/63308 ? | 22:57 |
| cjohnston | nigelb: I know your not asleep.. now that I added a commit message will https://code.launchpad.net/~daker/loco-directory/fix.708995/+merge/63308 work? | 23:04 |
| daker | cjohnston, yes just added a commit message + status to Approved | 23:06 |
| cjohnston | daker: hopefully it will work now then | 23:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!