=== yaili_ is now known as yaili [16:03] yay adding CC to a bug gets me my theme sorted for the LC blog! [16:05] so i need to add the cc to get the naming convention done [16:09] no the naming has nothing to do with them [16:09] it's being changed under a policy [16:09] the theme had nothing to do with them [16:10] there are 2 distinctions cjohnston 1) the pretty name on the LD and 2) in general [16:10] Not pretty. [16:10] IEasy to find names. [16:10] This was based on proper feedback at UDS. [16:11] in general the list looks like crap.. so its general.. so the cc can handle it [16:11] yeah adn we're working on it [16:11] cjohnston: what is your problem, we're getting teams to change it [16:11] sorry it's not happening over night [16:11] but you're kinda getting bogged down on one area we look after [16:12] that's the one area we want help :) [16:12] well we;re helping and all I'm getting is grief [16:39] can't we try a country list instead of a team names list? easier to find the right team that way, every one is used to country lists in the commercial websites to find the right localised site. [16:49] mars: ping. Do you have a few free minutes today or would you prefer tomorrow? [16:49] nigelb, I have a few minutes now. What's up? [16:50] mars: I was planning on setting up tests slowly for summit. [16:50] Do I use the unittest module or nose, which one would you suggest? [16:51] nigelb, for the code? [16:51] nigelb, or as a testrunner? [16:52] mars: okay, I don't know what's the difference between the two :) [16:54] nigelb, nose is most often used as a testrunner on the command line. But since this is a Django project, you will probably want to use the 'manage.py test' command [16:55] nigelb, here is how I run the tests: [16:55] python summit/manage.py test summit.schedule [16:55] ah [16:56] I was a bit confused where to star [16:56] *start [16:56] nigelb, here, let me push my changes, you can try them out. The commands are simple. [16:56] nigelb, do you use ubuntu for your dev work? [16:57] mars: yeah, lucid [16:57] ok [16:57] heh, I use ubuntu for everything I guess ;) [17:07] nigelb, take a look at this branch, it is my changes and tests: https://code.launchpad.net/~mars/summit/reschedule-command-tests [17:08] mars: looking, thanks :-) [17:08] nigelb, I use virtualenv for the development work and 'python summit/manage.py test summit.schedule' to run the suite [17:08] mars: okay, I'll test this out right away [17:09] nigelb, you will need to install 'model-mommy' (check the requirements.txt) to run the tests. Saves a bunch of boilerplate test code - very nice. [17:10] oooh! [17:10] nigelb, I need to go to lunch now. I should be back in an hour or so. I can talk more then [17:10] mars: Cool, I'll play with this in the meantime :) [17:25] zomg [17:25] We have factory. [17:26] This is so comfortable. [17:26] Its like workign with launchpad code [17:38] mars: I love it. It reminds me of writing tests for launchpad code. [18:36] nigelb, cool, I'm glad you like it [18:37] mars: This is painful for the first time, but I think it gives lots of changes, like setting up jenkins. [18:38] *chances === daker is now known as daker_ [18:39] nigelb, what did you find painful about it? [18:39] mars: making sure at least 60% code has coverage bit :) [18:40] I'll probably be writing tests for the next few weeks :) [18:44] nigelb, that is a good goal [18:45] I started with trying to write a test for the new reschedule command functionality [18:45] the bug was that meetings were rescheduled for past days. I figured a good test was to write a test for the bugfix [18:46] :) [18:46] will all our tests be in this one file now? [18:46] is it wise to create a tests folder as a module? [18:46] nigelb, probably not. Once the file hits 1000-2000 lines you will probably want to make it into a package. [18:47] :) [18:48] nigelb, did you get the tests to run successfully? Or get a virtualenv set up? [18:49] mars: yes and yes :) [18:49] cool [18:54] nigelb, I can submit a merge proposal for this branch if you would like. I don't think it has any impact on the production code. [18:55] mars: please do :) [19:01] mars: I saw a conflict when I tried to merge. Could you rebase to make sure your branch is clean? [19:01] ideally, I just want to use tarmac :) [19:02] nigelb, sure, I'll update from trunk before submitting [19:02] \o/ [22:57] mhall119, cjohnston nigelb Ronnie can we merge this https://code.launchpad.net/~daker/loco-directory/fix.708995/+merge/63308 ? [23:04] nigelb: I know your not asleep.. now that I added a commit message will https://code.launchpad.net/~daker/loco-directory/fix.708995/+merge/63308 work? [23:06] cjohnston, yes just added a commit message + status to Approved [23:06] daker: hopefully it will work now then