| mhall119 | doctormo: I got an error while running your branch, commented on the MP | 00:01 |
|---|---|---|
| mhall119 | I'll be around in a bit if you want help debugging | 00:02 |
| doctormo | mhall119: You have events with no venue? | 00:02 |
| cjohnston | probably.. it needs to support that | 00:02 |
| doctormo | cjohnston: Your request makes no sense to me, everything I can consider to be a commit, has a comment. | 00:02 |
| doctormo | mhall119: Pushed 437 to fix that issue. | 00:04 |
| cjohnston | doctormo: http://dl.dropbox.com/u/2494160/Selection_016.png | 00:04 |
| doctormo | cjohnston: What does that do? | 00:04 |
| cjohnston | For tarmac.. sets the commit message when it is comitted to trunk | 00:05 |
| doctormo | Done anyway *shrug* | 00:05 |
| doctormo | I guess it should be the same as the description, or similar to it. I guess i should update ground control to cover that. | 00:05 |
| cjohnston | It's needs to be something you would put into bzr commit -m "text" | 00:06 |
| cjohnston | doctormo: I commented on it | 00:07 |
| doctormo | cjohnston: Interesting, the commits themselves all have messages. | 00:09 |
| cjohnston | I know.. but tarmac needs that commit message for comitting to trunk.. otherwise, its possible to have multiple bzr commit -m's in one MP to fix issues and such | 00:10 |
| cjohnston | so what would it use | 00:10 |
| doctormo | cjohnston: i already added the decription as the commit message. | 00:13 |
| doctormo | And fixed the 'with' issue. | 00:13 |
| cjohnston | doctormo: which commit message are you referring to? | 00:13 |
| doctormo | cjohnston: The one on the merge request, the one you showed in your screen shot? | 00:16 |
| cjohnston | right.. i was explaining why it was needed | 00:16 |
| doctormo | OK so I was thinking about cleaning up some of the code for team/auth interaction. The is_admin and is_member items should probably be methods in the team models, so we don't have to create them for each view we want to use them in. | 00:33 |
| mhall119 | doctormo: your MP might have multiple commits, with multiple different messages | 01:02 |
| mhall119 | the commit message in LP tells the person merging it what all of the commits, taked collectively, will do | 01:03 |
| mhall119 | /taked/taken/ | 01:03 |
| mhall119 | doctormo: once we get Django 1.2 or 1.3, we'll be able to replace those is_admin and is_member checks with generic user.has_perm calls | 01:04 |
| mhall119 | doctormo: the new code looks and works great, thanks for the contribution! I know a lot of people will appreciate this convenience. | 01:06 |
| doctormo | mhall119: OK, that plan with django 1.3 seems like the right way to go. good to know you're on top of it. | 01:15 |
| cjohnston | mhall119: ping | 01:22 |
| cjohnston | I never realized before.. the edit team page has an email address field.. is that for a mailing list or something? | 02:01 |
| mhall119 | cjohnston: I think so, yes | 03:09 |
| mhall119 | cjohnston: is loco-directory waiting on anything before we roll a new release? | 20:53 |
| doctormo | mhall119: :-) | 22:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
