/srv/irclogs.ubuntu.com/2011/06/20/#launchpad-dev.txt

=== al-maisan is now known as almaisan-away
* wallyworld_ off to a funeral. back later today01:56
lifeless:(01:57
wallyworld_yeah. sad.01:59
lifeless\o/ deleting code02:17
wgrantlifeless: Oh?02:21
lifelessgetBugCounts02:25
lifelessunused02:25
lifelessand getBugContextWhereSQLClause too, or however it was spelt02:25
wgrantAh, yeah, I noticed that looked a bit duplicated when I did the initial query rewrite.02:30
lifeless_getBugTaskContextClause02:31
lifelessactually02:31
lifelessI could use a teddy bear02:31
lifelessgot 5?02:31
lifelesswgrant: ^02:32
wgrantSure.02:33
lifelessskype>02:33
wgrantIf it stops segfaulting...02:33
lifeless\o/02:33
lifelessI can ring your landline if thats easier?02:34
wgrantNah, just give me a sec to boot my laptop.02:35
wgrantHmm. Nobody is online... not even Skype Test Call.02:37
wgrantAh, there we go.02:37
StevenKCockatoos need to die.03:32
StevenKWashing out on the balcony, and they attacked the pegs, so now the clean clothes need re-washing :-(03:33
StevenKStewart Smith03:34
StevenKhave noticed over $timeperiod improvements in #launchpad responsiveness and stability. #awesome03:34
StevenKlifeless: ^03:35
lifelessStevenK: hanging out in #drizzle ? :)03:38
StevenKlifeless: No, that was from Failbook03:38
lifelessoh cool03:38
lifelesshe was going to tweet it03:38
lifelessalso expecting a blog post too03:38
wgrant:/ big deploy queue03:42
wgrantAnd nothing we can do about it :(03:42
lifelesswgrant: because of the subscribers thing?03:46
wgrantYeah.03:46
lifelesshow many revs apart was the initial landing and the fix?03:47
wgrantLanded 13243, reverted 13247, relanded 13248, first fix 13258, still not OK.03:47
lifelessoh? I thought danilo landed a fix?03:48
wgrantIt's OK for anonymous users now, sure.03:48
wgrantDoesn't mean it's OK :)03:48
lifelesshow isn't it ok?03:48
wgrantIt's a 12000 line diff, so we can't be even slightly sure it's OK.03:48
wgrantAnd IMO it's a regression.03:49
wgrantI can't see who is subscribed to a bug any more :/03:49
wgrantOh, actually, I can, but it's not at all obvious.03:49
wgrant("Notified of all changes" is direct subscriptions, "Maybe notified" isn't valid English and is structural subscriptions, and the other categories are something else that I forget)03:50
lifelessso, why can't we deploy ?04:06
wgrantLast I heard they were still QAing it.04:08
lifelessugh04:08
lifelesshow can we help them04:09
wgrant22:33 < danilos> matsubara, right, so we still haven't marked it as qa-ok because I'd prefer to get a little bit more QA done first04:09
wgrantThat was Friday night.04:09
lifelesswhat defines when a view does/doesn't have a self.user ?05:15
lifelessor more precisely05:15
lifelesswhy would a view not inherit from LaunchpadView ?05:15
lifelessBugTargetBugListingView is what I'm staring at05:17
lifelessok, random q #205:24
lifelessis there a way to say 'any class that implements this Interface should allow the interface to be used'05:24
lifelessrather than explicit <allow interface=xxx> statements for each implementing class?05:24
mwhudsonlifeless: i think "being incredibly ancient" is the only reason to not inherit from LaunchpadView?05:26
mwhudson-?05:26
lifelesswell, who knows05:35
wgrantmwhudson's understanding is the same as mine.05:35
lifelessand on the second point ?05:37
wgrantNo. Why?05:37
lifelessreducing duplication05:39
lifelessgrrrrrrrrrrrrrah06:33
lifelessBugSummary.tag in [BugSummary.milestone_id]06:33
lifelessTrue06:33
wgrantYeah...06:35
mwhudsonjust by fluke?  or because types are being strange?06:35
lifelessI'm guessing some of the query builder magic either has a corner case or a bug06:35
wgrantIt's the same Storm misfeature that wiped out part of the primary archive last year when I used in instead of is_in.06:35
wgrant__contains__ returns an expression.06:36
wgrantWhich evaluates to True.06:36
wgrantWait, no.06:36
lifelessbut thats not applicable here06:36
wgrant__eq__ returns the expression.06:36
wgrantWhich evaluates to true.06:36
lifelessbug 79960206:36
wgrants/expression/Expr/06:36
_mup_Bug #799602: something funky in comparisons makes introspecting things tricky <Storm:New> < https://launchpad.net/bugs/799602 >06:36
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
lifelessand, I have bugsummary2 enabled stats portlet07:39
wgrantThese version numbers are a bit Chromy.07:45
lifeless?07:49
wgrantVersion 2 after like a month :P07:53
StevenKHaha07:54
lifelesswgrant: well, it won't be versioned live07:56
lifelessits just a handle07:56
=== StevenK changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 205 - 0:[######=_]:256
lifelessI can has review ? https://code.launchpad.net/~lifeless/launchpad/bug-793848/+merge/6515808:14
StevenK1,110 lines at 5:20pm? Uh, no.08:17
lifelessits mainly deletes08:17
lifeless 21 files changed, 215 insertions(+), 337 deletions(-)08:18
lifelessthe way we assess patch size is pretty crazy08:18
StevenKYou only complain about that when you go over08:19
lifelessof course08:19
lifelessits crazy all the time08:19
lifelessbut doesn't come up in conversation otherwise08:19
StevenKI shall pass, sorry. I'm developing a headache from DSP/DSPR/DSBP.08:19
lifelessno worries08:20
lifelessI'm getting one just reading those abbreviations08:20
StevenKWelcome to my day.08:20
StevenKhenninge: O hai, Mr OCR.08:24
henningeHi StevenK! ;)08:25
=== henninge changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: henninge | Critical bugs: 205 - 0:[######=_]:256
henningeStevenK: what can I do for you?08:25
lifeless\o/08:25
lifelesshenninge: https://code.launchpad.net/~lifeless/launchpad/bug-793848/+merge/65158 when you have a chance ;)08:25
StevenKhenninge: https://code.launchpad.net/~stevenk/launchpad/db-add-bprc/+merge/64783 . I don't mind you if review lifeless' first, or mine, but my branch is smaller. :-)08:26
henningewow, 1110 lines of diff ...08:26
lifelessyes yes08:26
lifelessdeletes do that :)08:26
henningeoh, deteles are cool ;)08:26
lifelessDiff against target: 1110 lines (+215/-337) 21 files modified08:27
lifelessis a more useful metric I think08:27
lifelessgiven the vast chunk of the line count is context08:27
henningeyes yes :-P08:27
lifeless:)08:27
lifelessI think StevenK's was up first, you should save mine for later :>08:28
lifeless(especially as I just noticed a spelling error to fix)08:28
StevenKMy DB review was on Friday, I spent most of the weekend doing the interfaces and model08:29
wgrantStevenK: Reviewed.08:29
wgrantBah, you just roped henning into it, I see.08:29
henningewgrant: I was about to start ...08:30
henningewgrant: that's what the "claim review" button is for :-P08:30
wgrantI don't trust buttons.08:31
adeuringgood morning08:31
henningeHi adeuring!08:32
adeuringmoin henninge!08:32
StevenKwgrant: Thanks.08:32
wgrantlifeless: How can column.__eq__(column) evaluate immediately?08:35
lifelesswgrant: perhaps it can't08:36
lifelesswgrant: I have a headcold. I'm excused from thinking.08:36
wgrantTrue, true.08:36
StevenKwgrant: Sadly, it is not a full path name, it is 'bin/true', for example.08:43
wgrantStevenK: So it is. How stupid.08:44
lifelesson the unicode thing08:45
lifelessunicode(foo) is always unsafe08:45
wgrantUnless it's always an ASCII string, yes.08:45
lifelessyes08:46
StevenKIt's a path name08:46
wgrantSo using it on a potentially non-ASCII string is wrong.08:46
wgrantStevenK: Paths aren't ASCII.08:46
lifelessthere are some source packages with non-utf8 paths around; I don't know about binary packages offhand08:46
StevenKQuery the conflict checker?08:47
lifelessjust check a current Contents.gz08:47
lifelesseasier08:47
StevenKI don't know how to check for UTF-808:47
lifelessfor line in thing: line.decode('utf8')08:48
lifelessif it goes boom it wasn't utf808:48
rvbawgrant: Hi William, if you have time to take a look at my MP before you EOD it would make me happy ;) (https://code.launchpad.net/~rvb/launchpad/init-series-bug-789091-devel/+merge/63676)08:50
rvbaI've worked with jtv on Friday on the perforance and I plan to do that again with Julian (testing real world queries) today. But if perf needs improvement I'd like to do that in another branch.08:50
StevenKIt goes boom08:51
lifelesswell then :)08:51
lifelessso we need to change the db patch08:51
StevenKWhich is fine, it hasn't landed yet08:51
wgrantOr say that if people have non-UTF-8 paths then they should die.08:52
lifeless-or- we need to say that we'll exclude such things from the contents.gz08:52
wgrantrvba: Looking, thanks for the reminder.08:52
lifelessI'd favour talking to the distro now and then excluding non-utf808:52
lifelessit will make it a lot easier to work with.08:52
StevenKusr/lib/OpenVerse/language/Espanoles                        universe/net/openverse08:52
StevenKusr/lib/OpenVerse/language/Espa<F1>oles                     universe/net/openverse08:52
* StevenK facepalm08:52
lifelessbtw I'm pretty sure you can read the files straight out of the ar08:54
lifelesslemme have a quick look08:54
wgrantar then tar, yeah.08:54
wgrantIt's easy enough to do.08:54
wgrantBut apt_pkg can do it for us..08:54
wgrant(but the tarball may be compressed in several different ways)08:55
StevenKIt does?08:55
StevenKwgrant and I already had this discussion08:55
StevenKapt.debfile.DebPackage.filelist08:55
StevenKlifeless: Your MP is out of date?08:56
wgrantrvba: bigjools accepts the orphaned binary issue?08:56
wgrantrvba: And the binary and source file conflict issue?08:56
rvbawgrant: Hum ... since I now apply the same copying method to binary and source those two problems are not really there any more ...08:58
wgrantrvba: they're still very much there.08:58
lifelessStevenK: apt_inst.debExtract(open(local_file.name), capture_filepaths, "data.tar.gz")08:59
wgrantOr apt.debfile.DebPackage.filelist...09:00
rvbaIIRC Julian was not really concerned by the orphaned binary issue right now since it's ugly but not an imminent danger to the integrity of the data.09:00
lifelessStevenK: perhaps09:00
StevenKlifeless: And I say again, what's wrong with apt.debfile.DebPackage.filelist ?09:00
lifelessrefreshing the page :)09:00
wgrantI already complained at him for using subprocess, and he fixed it.09:00
StevenKwgrant had this argument 5 hours ago.09:00
rvbawgrant: can you elaborate on the "binary and source file conflict issue" ?09:00
wgrantrvba: Orphaned binaries are ungood but do not cause irreparable damage. Binary and source file conflicts do.09:00
StevenKwgrant: 13 is the number of files in pmount.deb, excluded directories. Do you want a comment or me to calculate it in the test?09:01
wgrantrvba: Say I have hello 1.2-3 in some old series.09:01
lifelessStevenK: wasn't meaning to cause extra work, was just looking at the need for a temp dir09:01
wgrantStevenK: I'd like some verification that the filenames are right.09:01
StevenKwgrant: Right, fair enough.09:01
StevenKlifeless: I'm switching to tempfile.TemporaryFile()09:02
wgrantrvba: So, from that I'll probably have a hello_1.2-3_i386.deb. That gets superseded in these series.09:02
StevenKOr, attempting to.09:02
wgrantrvba: What happens if I now initialise a new series in my distribution from another distro with a different hello_1.2-3_i386.deb?09:02
lifelessTempDir is fine if we don't expect to be kill -9ing the process09:02
lifelessbut we may end up doing that :>09:02
rvbawgrant: then only the package present in the *first* parent will be copied.09:02
rvbas/package/packages/09:03
lifelessStevenK: NamedTemporaryFile is as safe (or unsafe) as TempDir, FWIW09:03
wgrantrvba: But that's enough.09:03
wgrantrvba: Because the package present in the first parent is different from the one already in the archive.09:03
rvbawgrant: each time we copy a parent into the (new) archive, we exclude from the copy any package with a name (sourcepackagename or binarypackagename) already present in the destination archive.09:04
wgrantrvba: In the destination archive *and suite*.09:04
danilosrvba, hi, do you think you'd be able to QA 795396 fix soon? allenap, how about you and 798263? :)09:04
rvbadanilos: hi! one sec.09:04
danilosrvba, cheers09:04
StevenKDamn it, does NamedTemporaryFile() delete the file on close?09:05
allenapdanilos: Okay, I'll do that now.09:05
lifelessStevenK: yes09:05
lifelessStevenK: it can't unlink it before then09:05
StevenKBah09:05
danilosallenap, thanks a bunch!09:05
lifelessStevenK: if a regular temporary file onw't work, then use your current code.09:05
wgrantlifeless: Why use TempDir when a NamedTemporaryFile is fine?09:06
rvbadanilos: I'll be able to QA 795396 right now (if DF is up to date)09:06
* rvba checks DF09:06
lifelesswgrant: shrug, was saying 'do the simplest thing'09:06
StevenKNamedTemporaryFile() currently isn't, since I'm using copy_and_close() to grab the contents of the filename from the librarian.09:06
lifelesswgrant: they are functionally equivalent09:06
lifelesswgrant: in terms of diskspace and leaks09:07
wgrantlifeless: They are. But creating a file is probably simpler than creating a directory and then creating a file.09:07
StevenKAnd so copy_and_close() close()'s the temporary file and it gets deleted.09:07
wgrantThat's rather antisocial of it.09:07
lifelesswgrant: I think StevenK has found a difference :>09:07
rvbaStevenK: Hi Steven, can you update DF?09:08
danilosrvba, just let me know when it's done because I have a mixture of revisions landed that should only be rolled out together, and I can't mark the earlier one qa-ok until everything in between is qa-ok :)09:08
wgrantrvba: I'm there already. Will do it now.09:08
rvbadanilos: sure, I will.09:08
rvbawgrant: thanks.09:08
danilosthanks all09:08
StevenKUnless I can use something other than copy_and_close() to copy from the librarian?09:08
lifelessyou can, theres a pump_file in bzrlib.osutils09:09
wgrantrvba: Should be coming back now.09:10
rvbawgrant: so your point is that since I check that the package is already there in the destination archive and suite, it's still possible to have the exact same *file* (in two different archives) ... right?09:10
rvbawgrant: thanks.09:10
StevenK% grep -c pump_file eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/osutils.py09:10
StevenK009:10
rvbas/two different suites/two different suites/09:10
wgrantrvba: Right.09:10
rvbas/two different archives/two different suites/ even09:11
wgrantIt may not be in the current suite.09:11
rvbawgrant: right, I get it ... that's the point ou already made last week but I guess I did not understand it properly ...09:11
wgrantIt's an edge case, but this is the sort of place that an edge case will crop up and nomnomnom goes the primary archive. And we want primary archives to not be eaten alive.09:11
lifeless+109:11
rvbawgrant: right.09:12
rvbadanilos: QA ok for 795396.09:13
danilosrvba, great, thanks!09:13
rvbanp09:13
bigjoolsmorning all09:14
StevenKLooks like copy_and_close() is it. :-(09:15
lifelessStevenK:     pumpfile(from_file, to_file, read_length=-1, buff_size=32768, report_activity=None, direction='read')09:17
lifeless        Copy contents of one file to another.09:17
lifeless        09:17
lifeless        The read_length can either be -1 to read to end-of-file (EOF) or09:17
lifeless        it can specify the maximum number of bytes to read.09:17
lifeless        09:17
lifeless        The buff_size represents the maximum size for each read operation09:17
lifeless        performed on from_file.09:17
lifelessStevenK: (bin/py -m pydoc bzrlib.osutils)09:17
StevenKlifeless: It seems NamedTemporaryFile() has a delete parameter09:17
rvbawgrant: Thanks for the clarification, I'll work on this today.09:18
lifelessStevenK: at which point its no longer a temporary file09:18
wgrantrvba: Thanks. This isn't an easy thing, unfortunately :(09:18
rvbawgrant: right, but with your help I'll see it through and land the 2500+ SLOC which depend on this ;)09:19
lifelessStevenK: check the implementation - both the __del__ handler and the context manager will leave the file behind if you pass delete=False09:20
lifelessStevenK: which is very much not what you want09:20
lifelessmyself, I'd use the tempdir and get on with my life ;). If you want to do something different, pumpfile will let you copy things around relatively sanely.09:20
StevenK    self._debfile = apt_inst.DebFile(open(self.filename))09:22
StevenKSystemError: E:Archive is too short09:22
StevenKThat's right after calling pumpfile()09:22
wgrantseek(0)09:23
lifelessyou have a file already09:24
lifelessseek(0) and pass the file in rather than a new file object.09:24
lifelesshenninge: I hope my review isn't frying your brain09:24
henningelifeless: no, it won't ...09:25
lifelessdo we have a list of supported browsers ?09:26
jmlgood morning launchpadders09:26
lifeless(bug 799491)09:26
_mup_Bug #799491: Posting a comment in rekonq does not insert it into the page <Launchpad itself:New> < https://launchpad.net/bugs/799491 >09:26
jmlhuwshimi & I are in Millbank09:26
lifelesshola jml09:26
jmllifeless: umm... I *thought* we did. huwshimi, do you know about such a list?09:26
huwshimilifeless: Yeah I think there is something like that around. Let me dig it out09:27
huwshimilifeless: This is what I was thinking of: https://dev.launchpad.net/GradedBrowserSupport09:29
lifelessKLMN - its 2 years old?09:29
lifelessanyhow09:30
lifelesswhat I really care about is09:30
lifelessdo we consider bugs w/js on rekonq important, or do we say 'thanks for noticing, now please give us a patch' ?09:30
lifeless[paraphrasing obviously]09:30
bigjoolsrekonq uses webkit FWIW09:31
lifelessyeah09:31
lifelessstill manages to fail - multiple different bugs open for it09:31
bigjoolsnot sure why the KDE people thought we needed another browser09:31
StevenKwgrant: So, unicode() is wrong, what you prefer I use? filename.encode('utf8') and catch the encoding exception?09:34
lifelessStevenK: if you're willing to not put non-utf8 stuff in the contents file, then yes.09:34
lifelessStevenK: the alternative is to change the column from text to a byte array09:34
StevenKAnd then use RawStr() ?09:35
jmllifeless: if it's just a rekonq bug & not a webkit bug, it's the latter.09:46
lifelessdefinitely not webkit; chrom* is fine09:46
jmlhuwshimi: btw, I'm done w/ email stuff.09:48
huwshimijml: I'm almost there. 5-10 mins if that's ok?09:49
jmlhuwshimi: sure.09:49
StevenKwgrant: What would you prefer?09:52
huwshimijml: OK, done for now'09:58
jmlhuwshimi: cool. want to come over here?09:58
huwshimijml: OK, coming09:58
lifelessStevenK: excluding some files will need an ack from the distro I think10:01
lifelessStevenK: that might be easy to get10:01
lifelessI would prefer to drag stuff into the unicode-only world10:02
lifelessso encourage you to seek that ack10:02
StevenKlifeless: Given nothing uses this, and isn't likely to until I write a population script are you personally happy with me leaving it as is and landing it while I wait for the ack.10:15
lifelessStevenK: I'd be happy with you doing .decode('utf8'), catching errors and skipping those files, and seeking the ack async10:16
lifelessStevenK: I wouldn't be happy with the cast-as-is landing10:16
StevenKRight10:16
jmljelmer: do you need anything from me wrt build-from-branch-into-(archive|primary)?10:42
daniloslifeless, whatever fails on webkit browsers is likely to fail on safari as well (I've hit a few problems like that with epiphany as well)10:46
danilosfor instance, use of "class" keyword for a variable fails in webkit browsers10:46
jelmerjml: No, though thanks for checking. (I'm waiting to double check with poolie, then I'll send an announcement of the LEP to the list)10:49
jmljelmer: ok cool.10:49
lifelessbigjools: have you put any thought into query schemas for soyuz ?11:19
bigjoolsnone at all11:19
lifelessk11:19
bigjoolssorry - too busy with DDs11:19
bigjoolswhen we start maintenance I will11:20
lifelessno need to apologise11:20
lifelessI ask so that if I get some time to look at it, I'm not reinventing already thought out stuff11:20
bigjoolssure11:20
danilosbigjools, hi, do you know if jtv will show up today or if there's someone who can help QA bugs 394645, 537335?11:31
bigjoolsdanilos: he's having a day off11:33
danilosbigjools, ah, ok, thanks; seems a pretty big change so I don't feel comfortable doing the QA, and if we can't find anyone else to do it, I suppose we won't have a rollout today11:35
bigjoolsdanilos: are they his changes ?11:36
danilosbigjools, yeah11:38
bigjoolslet me checkl11:38
danilosbigjools, spread over 3-4 revisions in the deployment report11:38
danilosbigjools, https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html11:38
danilosbigjools, (the first blocking revision is QAd but I need 13258 to be included in the deployment before I can mark it as qa-ok)11:40
lifelessdanilos: I think its your patch blocking atm :)11:40
daniloslifeless, see above, it's not11:41
lifelessdanilos: ah I see11:41
daniloslifeless, I mean, I am keeping it like that on purpose11:41
danilos(haven't used proper metadata in the commit message)11:41
lifelessits fine, just a tad confusing11:41
lifelessgnight everyone11:44
huwshimiallenap: Hi, are you around?11:51
allenaphuwshimi: Yes, hi.11:51
allenaphuwshimi: Want to have a chat?11:52
huwshimiallenap: Do you have a minute and want to talk about the initialization errors UI?11:52
allenaphuwshimi: What's your preference? Skype, Mumble, phone?11:52
jmllifeless: g'night.11:53
huwshimiallenap: Skype or Mumble is fine. I might try and trigger the error first though.11:53
huwshimiallenap: Unless you have a screenshot?11:53
allenaphuwshimi: The error does not display anywhere in the page; it's an error in an job that runs outside of the app server.11:54
=== dpm_ is now known as dpm
huwshimiallenap: Ah I see11:54
allenaphuwshimi: I'm online in Mumble, in Launchpad/Red.11:55
huwshimiallenap: OK, one minute11:55
huwshimiallenap: Let me know if you have any more questions about that.12:11
huwshimiallenap: I would also like to have a chat after you've implemented it to see how it went and how easy it was to do the UI side of things12:12
allenaphuwshimi: Cool, okay, thanks.12:13
=== Ursinha is now known as Ursinha-brb
=== henninge is now known as henninge-lunch
=== benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: henninge, benji | Critical bugs: 205 - 0:[######=_]:256
* jml afk13:54
henningeadeuring: I won't make it to the call be fore :1513:56
henningeHi deryck, I wont make it until :1513:58
deryckhi henninge.  see my #launchpad-ops message. :)13:58
henningenot on there atm13:59
adeuringhenninge: everything postponed for >30 minutes :)14:01
henningecool14:01
deryckhenninge, yeah, sorry.  I need to wait to bottom of hour for standup.14:02
=== henninge-lunch is now known as henninge
deryckabentley, adeuring -- ping for standup14:31
Ursinha-brbthis is taking forever, argh14:35
maxbHi all - is r13249 deployable, and when is the next nodowntime deploy likely to occur?14:38
=== salgado is now known as salgado-doctor
danilosUrsinha-brb, hi, is there a way for me to mark a revision as fixed by one of the subsequent commits? (i.e. 13243/13248 is fixed by 13258)14:54
maxbAh, that half-answers my question :-)15:00
Ursinha-brbdanilos, if the revision referencesthe same bug, it'll be marked as needstesting and the first revision should be fine15:03
Ursinha-brbwhat links the revisions are the bugs they refer to15:03
Ursinha-brbmaxb, we generally do the nodowntime deployments when we reach more than 5 revisions ready to deploy15:05
Ursinha-brbwhen we reach five, I mean15:05
maxbUrsinha-brb: amount of ready revisions isn't really the problem right now :-)15:06
Ursinha-brbhehe15:06
maxbIt seems there's some deployability firefighting going on15:06
Ursinha-brblet me see15:06
Ursinha-brbhm15:14
danilosUrsinha-brb, right, but they are linked to different bugs, and I don't want the first revision to be deployable before the latter one is :) I was hoping there'd be a qa tag like "qa-fixed-in-XXX" :)15:15
Ursinha-brbthere's not, unfortunately15:16
danilosmaxb, fwiw, I am intentionally blocking on r13243 before everything becomes deployable up to and including 13258, but there are some complex revisions that I can't QA myself15:17
danilosUrsinha-brb, ok, then I'll just have to keep an eye on the deployment report, thanks15:18
maxb13260 is a rollback og 13521, so presumably we have to go all the way from 13242 -> 13260 at least, in one hop :-/15:19
maxbPerhaps I should check back tomorrow :-)15:20
danilosmaxb, yeah15:20
wgrantdanilos: Please keep lifeless and myself up to date... we will attempt to deploy tomorrow.15:20
wgrantSince you can't keep the tagger up to date :(15:21
daniloswgrant, well, there's not much I can do: jtv's revisions need QA and it seems complex enough a change that I couldn't QA it this morning; if we decide to ignore the anon user problem, we can just mark qa-ok bug 772754, but that will only bring us two revisions forward15:22
_mup_Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing <qa-needstesting> <story-better-bug-notification> <Launchpad itself:Fix Committed by gary> < https://launchpad.net/bugs/772754 >15:22
wgrantArgh15:22
wgrantAnd no bigjools.15:23
daniloswgrant, I did bring it up this morning with Julian, fwiw15:23
henningeHi benji!15:44
benjihi henninge15:44
henningebenji: Are you already working on a review?15:44
henningeI just did Bryce.15:44
benjihenninge: not at the moment, I'm helping on something else15:45
henningeok15:45
adeuringhenninge, benji: could one of please review this MP: https://code.launchpad.net/~adeuring/launchpad/bug-796867/+merge/65209 ? (~100 lines diff)15:51
henningeadeuring: I can do it in a minute15:52
adeuringhenninge: great, thanks!15:52
jmlsinzui: hi15:59
sinzuihi jml15:59
jmlsinzui: huwshimi & I are going to go into a room with a conference phone16:00
jmlsinzui: oh yeah, I've invited huwshimi to join us :)16:00
sinzuiI saw16:00
sinzuiread16:00
jmlsinzui: umm... can we dial a landline or voip number for you?16:01
sinzuisip 764216:01
jmlsinzui: thanks.16:01
jmlsinzui: "the number you have dialled is currently unavailable"16:02
sinzuijml: call again16:02
=== henninge changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: benji | Critical bugs: 205 - 0:[######=_]:256
=== Ursinha-brb is now known as Ursinha
=== salgado-doctor is now known as salgado
jmlsinzui, huwshimi: “The perfect search engine would understand exactly what you mean and give back exactly what you want.”16:48
jcsackettbenji: can you take another look at my MP? i believe the diff had been out of date, which confused the issue of your comment. https://code.launchpad.net/~jcsackett/launchpad/package-pickers-navigation-jumps/+merge/6522216:53
benjijcsackett: sure, it'll be a little while though16:54
jcsackettbenji: no worries. thanks. :-)16:54
* jml is off for the day16:57
henningeadeuring: approved. Sorry, I thought I had already done that.17:32
cjwatsonwgrant: any progress on deploying my germinate-lubuntu branch?17:40
adeuringhenninge: thanks!17:48
jelmerabentley: hi17:52
=== beuno-honeymoon is now known as beuno
=== matsubara is now known as matsubara-lunch
jelmerabentley: can bug 586944 be closed? AFAICT it's fixed18:01
_mup_Bug #586944: Launchpad should provide a ui for daily builds <lp-code> <Launchpad itself:Triaged> < https://launchpad.net/bugs/586944 >18:01
abentleyjelmer: hi.18:02
abentleyjelmer: I have no idea.18:03
jelmerabentley: You filed it, and there's a merged branch associated with it.18:03
abentleyjelmer: okay, that's a different issue than I thought.  Yes, that bug could have been closed a year ago.18:04
jelmerabentley: ok, I'll close it. Thanks18:04
benjijcsackett: I finally got to look at your branch, it looks fine.  Please file a bug for the bad JS building.18:29
jcsackettbenji: will do, thanks!18:30
sinzuiHail jcsackett. Do you have time to mumble?18:42
jcsackettsinzui: sure. mumble or sip?18:43
sinzuimumble?18:43
=== matsubara-lunch is now known as matsubara
gary_posterabentley, could you either handle https://answers.launchpad.net/launchpad/+question/160629 or tell me what I can do about it?19:15
gary_posterderyck, someone wants to delete a hwdb submission.  Any ideas on what to tell them?19:17
abentleygary_poster: Now that 13241 has been deployed, the next scan of the branch should succeed.19:20
gary_posterGreat news abentley, thanks.  I'll pas that on19:20
gary_posters19:20
abentleygary_poster: in fact, it looks like that has already happened, as the last revision is from 3 hours ago.19:21
gary_posterabentley, yeah, I had just come to the same conclusion.  Thanks again19:22
abentleygary_poster: no problem.19:22
deryckgary_poster, I thought they could delete it from their user profile on lp, but would need to poke at code or urls to confirm.19:38
gary_posterderyck, ok.  I'll pass that on to the next CHR person :-)  Thanks19:39
derycknp :)19:39
bachi sinzui, would you have a couple of minutes to chat with me for a pre-imp for bug 776437?20:04
_mup_Bug #776437: Enable ARM builders for PPA via API <api> <escalated> <not-pie-critical> <oem-services> <ppa> <Launchpad itself:In Progress by bac> < https://launchpad.net/bugs/776437 >20:04
sinzuiokay20:04
sinzuibac: I am on mumble now20:05
bacsinzui: ok, let me mumble up20:05
abentleybenji: could you please review https://code.launchpad.net/~abentley/launchpad/memlimit-jobs/+merge/65256 ?20:19
benjiabentley: sure20:20
abentleybenji: thanks.20:20
LPCIBotProject windmill-devel build #252: STILL FAILING in 1 hr 6 min: https://lpci.wedontsleep.org/job/windmill-devel/252/20:29
=== matsubara is now known as matsubara-afk
bacsinzui: is bug 760849 the root cause of this problem?  if i hadn't exported the collection (IProcessorFamilySet) would the error not have been seen?20:33
_mup_Bug #760849: No way to restrict export_as_webservice_collection to a given API version <api> <lazr.restful:Triaged> < https://launchpad.net/bugs/760849 >20:33
bacjcsackett: ^^20:34
abentleysinzui: is it expected that bin/test --layer=YUITestLayer may segfault?20:34
jcsackettbac: not sure of the question. there is the problem that once you export a collection it is exported on all versions of the API. which is a pain.20:37
bacjcsackett: so is the solution to claim each entry first appeared in 'beta', as you did for IQuestion?20:37
jcsackettbac: that is *a* solution. i don't know that it's *the* solution.20:38
bacjcsackett: by "solution" i mean unholy work-around20:38
jcsackettbac: ah, yes. it's definitely that. :-P20:38
jcsackettbac: as it was explained to me (though i can't recall by who), the main thing is to make certain that the smallest possible set of stuff gets exported as of 'beta', and to make sure you don't export anything to it that's going to change.20:39
bacjcsackett: rt20:39
sinzuiabentley, no. I was hoping deryck would follow up on the new package I build20:40
derycksinzui, I wasn't clear we had a new package, sorry.  I tired from devel last we talked and still seg faulting....20:40
derycksinzui, shall I update and try again?20:40
benjiUrsinha: do you know where I can find the disable_project.py script mentioned in https://dev.launchpad.net/Registry/ProjectReview?20:40
sinzuiabentley, The segfault is not seen on lucid or the natty/oneiric computers I have. I beleieve the issue a is a combination of libs20:41
jcsackettbenji: lp-dev-utils, i think.20:41
sinzuibenji, lp-dev-utils20:41
benjicool, thanks guys20:41
abentleysinzui: I'm running oneiric.20:42
* benji edits said wiki page.20:42
abentleysinzui: sorry, natty.20:42
sinzuideryck, please do, but maybe it is pointless since abentley is seeing it now20:42
sinzuiabentley, were you seeing this last Thursday when we talked about import gtk?20:42
abentleysinzui: No, I wasn't running YUITestLayer then.20:43
abentleysinzui: I was running twisted tests, and they were interacting badly with the import of html5browser.20:43
lifelessmoin20:44
sinzuiabentley, When I looked at deryck's report, the segfault happens in the first test of the second app (bugs)20:44
sinzuiabentley, the tests were never played in the same order, all app/ tests completed, bugs dies on the first test20:45
abentleysinzui: http://pastebin.ubuntu.com/629993/20:45
sinzuiabentley, do you have the version of python-html5-browser that landed Saturday?20:46
abentleysinzui: I do see an upgrade available.  I'll install it.20:48
sinzui0.0.4-0~18-920:48
sinzuiabentley, the new packaging tries to avoid mixing gtk2/3 libs that can be implied by gir20:49
sinzuiI suspect that is the origin of the segfults20:49
abentleysinzui: same result after upgrade.20:51
sinzui:(20:54
sinzuiabentley, I am uncertain as to how to proceed. Have you tried ./bin/test -vvc --layer=YUI -t lp/bugs20:55
sinzuito see if those tests complete20:55
derycksinzui, no luck still.  on latest package.  http://pastebin.ubuntu.com/629997/21:01
abentleysinzui: I get segfault from your suggestion.21:02
benjiabentley: I'm done with https://code.launchpad.net/~abentley/launchpad/memlimit-jobs/+merge/65256, it looks good21:02
abentleybenji: cool, thanks.21:02
sinzuiWell you gentleman agree that is does not work. I have no clue. ec2 and jenkins run it, though I can see that there webkit lib behaves differently from what we use21:03
sinzuiabentley, deryck: I still suspect that there is an interaction with gtk221:04
abentleybenji: I see your suggestion to use utilities/format-new-and-modified-imports, but it has no effect.21:04
sinzuiabentley, deryck: Mixing the two libs will always cause problem. My packaging efforts center21:04
sinzuiaround be very precise about what must be installed21:05
benjiabentley: darn, I thought it worked like bin/lint.sh in that it used the branch info to figure out which files to examine21:05
abentleybenji: "utilities/format-new-and-modified-imports -r submit:" does the trick.21:06
benjicool21:06
sinzuideryck, abentley: I have another project that also needs to ensure libs do not mix. I am waiting for the builds to  so that I can test them. Maybbe that will help be find the right mix of gobject/pygtk/webkit21:07
deryckok, cool21:07
sinzuideryck, !21:07
sinzuiI just saw compared your paste to http://pastebin.ubuntu.com/629993/21:08
sinzui^ abentley's21:08
sinzuiI think then that changes to tests/libs have mutated when/where we get a segfault21:08
deryckI don't follow, sorry21:09
sinzuideryck, I see three tests cases in that test_lp_names. maybe there is something naughty in that file21:10
sinzuiMaybe you could comment out some of the tests to identify an issue with how we write the test21:11
derycksinzui, ah, since we had the same test to fail.21:11
derycksinzui, FWIW, the failure is still dependent on order for me....still always the 7th regardless of which test.21:12
sinzuideryck, I believe the test changed thursday/friday21:12
sinzuiah21:12
deryckok, I'll comment out some stuff, though.  I don't mind trying.21:12
sinzuibad things come in sevens21:13
derycksinzui, a couple more just now to demonstrate:  http://pastebin.ubuntu.com/630006/21:13
sinzuideryck, there are seven app tests, what happens when you add -t lp/bugs?21:15
derycksinzui, bugs passes.21:16
derycktrying app by itself21:16
deryckbugs has 6 tests ;)21:16
sinzuiho theres a shock21:16
deryckapp fails the same way at test 7.21:17
* deryck is trying all the app names....21:17
cr3is there a function to blacklist pillar names like 'projects' and 'people'?21:29
abentleysinzui: In my Natty vm, I get a different failure mode: http://pastebin.ubuntu.com/630014/21:30
* sinzui looks21:30
sinzuiabentley, and like deryck. The failure is in the seventh test.21:31
sinzuiI could sort the tests to take the confusion out of future analysis21:31
derycksinzui, so I've tested each module.... and only app fails.  and it's the only module with more than 7 tests.21:32
sinzuideryck, it has exactly seven tests21:32
deryckhmmm, exactly 721:32
deryckright21:32
sinzuiI see that bugs and app setup the tests identically21:32
sinzuionly the name App/Bugs names change21:33
derycksinzui, so I removed one test from app and the 7th still seq faults.  this time being the first bugs test.21:35
deryck7 is the magic number21:35
sinzuideryck, I was thinking of changing YUIUnitTestCase.checkResults() return immediately to see if the tests return21:36
derycksinzui, ok.  you want me to try that as well?21:37
sinzuideryck, please21:37
deryckok21:37
derycksinzui, just return at the top of the method?  Do nothing in the method?21:38
sinzuiReturn immediately. I wonder if the json parsing is a mess21:39
derycksinzui, same seq fault.  same test 7.  even with the return.21:39
sinzuiah, but we do json parsing in setup()21:39
sinzuiI am not thinking clearly21:39
derycksinzui, hmm, it's not as consistent now, though.  12th test fails now sometimes.  so getting further in some runs.21:42
sinzuiDeryck. I was thinking of make setup() return early by to see if browser/json is the issue21:44
sinzuiself._yui_results = dict(testing=dict(result='pass'))21:44
sinzuireturn21:44
deryckok, trying that now....21:44
sinzuideryck, abentleyI just brought another natty machine online to test withc21:48
sinzuiThis has a rushed setup of deps.21:48
sinzuiWhile all the tests pass, I see something surprising in stderr before the tests start21:49
sinzuiFailed to load gnomesegvhandler21:49
derycksinzui, so playing in setup a bit.  and `page = client.load_page(html_uri, timeout=self.js_timeout)` seems to cause the seq fault...21:50
derycksinzui, at least I can return before that line, no issue.  return after it, boom.21:50
sinzuideryck, okay, that is my-lib > webkit+gtk > gtk2/3 | libwebkit21:51
sinzuideryck, are you running another webkit app at the moment? Empathy, Gwibber perhaps21:52
derycksinzui, both actually ;)21:52
derycksinzui, shall I kill them all and see... ?21:52
sinzui:( so am I21:52
sinzuiI was hoping they were setuping up something right in my env21:52
sinzuiI am not running them in the new machine that reported gnomesegvhandler was not found21:53
deryckah, I see.21:53
=== salgado is now known as salgado-afk
sinzuideryck, I am distracted now. My son was just stung by a bee22:04
derycksinzui, no problem.  I'm at EOD anyway.  We can chat again tomorrow about it.22:04
sinzuiabentley can you run22:14
sinzuiGTK_DEBUG=ALL ./bin/test -vv --layer=YUI -t lp/app 2>1 >  _test.log22:14
sinzuiand send/pastebin me the log22:15
abentleysinzui: sure.22:15
abentleysinzui: haven't dcced in ages.  Is it working?22:16
sinzuiI see the window after I accepted it, but I see no progress22:17
abentleysinzui: mailed.  Must go.22:18
sinzuiThank you very much22:18
=== Ursinha` is now known as Ursinha
=== _mup__ is now known as _mup_
=== Ursinha is now known as Guest75959
mwhudsonjelmer: 203+ except Exception, e:22:55
mwhudson204+ if e.__class__ in self.unsupported_feature_exceptions:22:55
mwhudsonyou know you can write this except  self.unsupported_feature_exceptions: ?22:55
mwhudsonalthough that gets subclasses i guess22:56
jelmermwhudson: no, I didn't realize that - thanks :) Subclasses would be nice to handle in this case too22:56
mwhudsonjelmer: or even isinstance(e, self.unsupported_feature_exceptions)22:56
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
=== lifeless changed the topic of #launchpad-dev to: Performance Tuesday | https://dev.launchpad.net/ | On call reviewer: benji | Critical bugs: 205 - 0:[######=_]:256
=== benji_ changed the topic of #launchpad-dev to: Performance Tuesday | https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 205 - 0:[######=_]:256
=== Guest75959 is now known as Ursinha
=== Ursinha is now known as Guest67245
=== Guest67245 is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!