=== al-maisan is now known as almaisan-away [01:56] * wallyworld_ off to a funeral. back later today [01:57] :( [01:59] yeah. sad. [02:17] \o/ deleting code [02:21] lifeless: Oh? [02:25] getBugCounts [02:25] unused [02:25] and getBugContextWhereSQLClause too, or however it was spelt [02:30] Ah, yeah, I noticed that looked a bit duplicated when I did the initial query rewrite. [02:31] _getBugTaskContextClause [02:31] actually [02:31] I could use a teddy bear [02:31] got 5? [02:32] wgrant: ^ [02:33] Sure. [02:33] skype> [02:33] If it stops segfaulting... [02:33] \o/ [02:34] I can ring your landline if thats easier? [02:35] Nah, just give me a sec to boot my laptop. [02:37] Hmm. Nobody is online... not even Skype Test Call. [02:37] Ah, there we go. [03:32] Cockatoos need to die. [03:33] Washing out on the balcony, and they attacked the pegs, so now the clean clothes need re-washing :-( [03:34] Stewart Smith [03:34] have noticed over $timeperiod improvements in #launchpad responsiveness and stability. #awesome [03:35] lifeless: ^ [03:38] StevenK: hanging out in #drizzle ? :) [03:38] lifeless: No, that was from Failbook [03:38] oh cool [03:38] he was going to tweet it [03:38] also expecting a blog post too [03:42] :/ big deploy queue [03:42] And nothing we can do about it :( [03:46] wgrant: because of the subscribers thing? [03:46] Yeah. [03:47] how many revs apart was the initial landing and the fix? [03:47] Landed 13243, reverted 13247, relanded 13248, first fix 13258, still not OK. [03:48] oh? I thought danilo landed a fix? [03:48] It's OK for anonymous users now, sure. [03:48] Doesn't mean it's OK :) [03:48] how isn't it ok? [03:48] It's a 12000 line diff, so we can't be even slightly sure it's OK. [03:49] And IMO it's a regression. [03:49] I can't see who is subscribed to a bug any more :/ [03:49] Oh, actually, I can, but it's not at all obvious. [03:50] ("Notified of all changes" is direct subscriptions, "Maybe notified" isn't valid English and is structural subscriptions, and the other categories are something else that I forget) [04:06] so, why can't we deploy ? [04:08] Last I heard they were still QAing it. [04:08] ugh [04:09] how can we help them [04:09] 22:33 < danilos> matsubara, right, so we still haven't marked it as qa-ok because I'd prefer to get a little bit more QA done first [04:09] That was Friday night. [05:15] what defines when a view does/doesn't have a self.user ? [05:15] or more precisely [05:15] why would a view not inherit from LaunchpadView ? [05:17] BugTargetBugListingView is what I'm staring at [05:24] ok, random q #2 [05:24] is there a way to say 'any class that implements this Interface should allow the interface to be used' [05:24] rather than explicit statements for each implementing class? [05:26] lifeless: i think "being incredibly ancient" is the only reason to not inherit from LaunchpadView? [05:26] -? [05:35] well, who knows [05:35] mwhudson's understanding is the same as mine. [05:37] and on the second point ? [05:37] No. Why? [05:39] reducing duplication [06:33] grrrrrrrrrrrrrah [06:33] BugSummary.tag in [BugSummary.milestone_id] [06:33] True [06:35] Yeah... [06:35] just by fluke? or because types are being strange? [06:35] I'm guessing some of the query builder magic either has a corner case or a bug [06:35] It's the same Storm misfeature that wiped out part of the primary archive last year when I used in instead of is_in. [06:36] __contains__ returns an expression. [06:36] Which evaluates to True. [06:36] Wait, no. [06:36] but thats not applicable here [06:36] __eq__ returns the expression. [06:36] Which evaluates to true. [06:36] bug 799602 [06:36] s/expression/Expr/ [06:36] <_mup_> Bug #799602: something funky in comparisons makes introspecting things tricky < https://launchpad.net/bugs/799602 > === almaisan-away is now known as al-maisan === al-maisan is now known as almaisan-away [07:39] and, I have bugsummary2 enabled stats portlet [07:45] These version numbers are a bit Chromy. [07:49] ? [07:53] Version 2 after like a month :P [07:54] Haha [07:56] wgrant: well, it won't be versioned live [07:56] its just a handle === StevenK changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 205 - 0:[######=_]:256 [08:14] I can has review ? https://code.launchpad.net/~lifeless/launchpad/bug-793848/+merge/65158 [08:17] 1,110 lines at 5:20pm? Uh, no. [08:17] its mainly deletes [08:18] 21 files changed, 215 insertions(+), 337 deletions(-) [08:18] the way we assess patch size is pretty crazy [08:19] You only complain about that when you go over [08:19] of course [08:19] its crazy all the time [08:19] but doesn't come up in conversation otherwise [08:19] I shall pass, sorry. I'm developing a headache from DSP/DSPR/DSBP. [08:20] no worries [08:20] I'm getting one just reading those abbreviations [08:20] Welcome to my day. [08:24] henninge: O hai, Mr OCR. [08:25] Hi StevenK! ;) === henninge changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: henninge | Critical bugs: 205 - 0:[######=_]:256 [08:25] StevenK: what can I do for you? [08:25] \o/ [08:25] henninge: https://code.launchpad.net/~lifeless/launchpad/bug-793848/+merge/65158 when you have a chance ;) [08:26] henninge: https://code.launchpad.net/~stevenk/launchpad/db-add-bprc/+merge/64783 . I don't mind you if review lifeless' first, or mine, but my branch is smaller. :-) [08:26] wow, 1110 lines of diff ... [08:26] yes yes [08:26] deletes do that :) [08:26] oh, deteles are cool ;) [08:27] Diff against target: 1110 lines (+215/-337) 21 files modified [08:27] is a more useful metric I think [08:27] given the vast chunk of the line count is context [08:27] yes yes :-P [08:27] :) [08:28] I think StevenK's was up first, you should save mine for later :> [08:28] (especially as I just noticed a spelling error to fix) [08:29] My DB review was on Friday, I spent most of the weekend doing the interfaces and model [08:29] StevenK: Reviewed. [08:29] Bah, you just roped henning into it, I see. [08:30] wgrant: I was about to start ... [08:30] wgrant: that's what the "claim review" button is for :-P [08:31] I don't trust buttons. [08:31] good morning [08:32] Hi adeuring! [08:32] moin henninge! [08:32] wgrant: Thanks. [08:35] lifeless: How can column.__eq__(column) evaluate immediately? [08:36] wgrant: perhaps it can't [08:36] wgrant: I have a headcold. I'm excused from thinking. [08:36] True, true. [08:43] wgrant: Sadly, it is not a full path name, it is 'bin/true', for example. [08:44] StevenK: So it is. How stupid. [08:45] on the unicode thing [08:45] unicode(foo) is always unsafe [08:45] Unless it's always an ASCII string, yes. [08:46] yes [08:46] It's a path name [08:46] So using it on a potentially non-ASCII string is wrong. [08:46] StevenK: Paths aren't ASCII. [08:46] there are some source packages with non-utf8 paths around; I don't know about binary packages offhand [08:47] Query the conflict checker? [08:47] just check a current Contents.gz [08:47] easier [08:47] I don't know how to check for UTF-8 [08:48] for line in thing: line.decode('utf8') [08:48] if it goes boom it wasn't utf8 [08:50] wgrant: Hi William, if you have time to take a look at my MP before you EOD it would make me happy ;) (https://code.launchpad.net/~rvb/launchpad/init-series-bug-789091-devel/+merge/63676) [08:50] I've worked with jtv on Friday on the perforance and I plan to do that again with Julian (testing real world queries) today. But if perf needs improvement I'd like to do that in another branch. [08:51] It goes boom [08:51] well then :) [08:51] so we need to change the db patch [08:51] Which is fine, it hasn't landed yet [08:52] Or say that if people have non-UTF-8 paths then they should die. [08:52] -or- we need to say that we'll exclude such things from the contents.gz [08:52] rvba: Looking, thanks for the reminder. [08:52] I'd favour talking to the distro now and then excluding non-utf8 [08:52] it will make it a lot easier to work with. [08:52] usr/lib/OpenVerse/language/Espanoles universe/net/openverse [08:52] usr/lib/OpenVerse/language/Espaoles universe/net/openverse [08:52] * StevenK facepalm [08:54] btw I'm pretty sure you can read the files straight out of the ar [08:54] lemme have a quick look [08:54] ar then tar, yeah. [08:54] It's easy enough to do. [08:54] But apt_pkg can do it for us.. [08:55] (but the tarball may be compressed in several different ways) [08:55] It does? [08:55] wgrant and I already had this discussion [08:55] apt.debfile.DebPackage.filelist [08:56] lifeless: Your MP is out of date? [08:56] rvba: bigjools accepts the orphaned binary issue? [08:56] rvba: And the binary and source file conflict issue? [08:58] wgrant: Hum ... since I now apply the same copying method to binary and source those two problems are not really there any more ... [08:58] rvba: they're still very much there. [08:59] StevenK: apt_inst.debExtract(open(local_file.name), capture_filepaths, "data.tar.gz") [09:00] Or apt.debfile.DebPackage.filelist... [09:00] IIRC Julian was not really concerned by the orphaned binary issue right now since it's ugly but not an imminent danger to the integrity of the data. [09:00] StevenK: perhaps [09:00] lifeless: And I say again, what's wrong with apt.debfile.DebPackage.filelist ? [09:00] refreshing the page :) [09:00] I already complained at him for using subprocess, and he fixed it. [09:00] wgrant had this argument 5 hours ago. [09:00] wgrant: can you elaborate on the "binary and source file conflict issue" ? [09:00] rvba: Orphaned binaries are ungood but do not cause irreparable damage. Binary and source file conflicts do. [09:01] wgrant: 13 is the number of files in pmount.deb, excluded directories. Do you want a comment or me to calculate it in the test? [09:01] rvba: Say I have hello 1.2-3 in some old series. [09:01] StevenK: wasn't meaning to cause extra work, was just looking at the need for a temp dir [09:01] StevenK: I'd like some verification that the filenames are right. [09:01] wgrant: Right, fair enough. [09:02] lifeless: I'm switching to tempfile.TemporaryFile() [09:02] rvba: So, from that I'll probably have a hello_1.2-3_i386.deb. That gets superseded in these series. [09:02] Or, attempting to. [09:02] rvba: What happens if I now initialise a new series in my distribution from another distro with a different hello_1.2-3_i386.deb? [09:02] TempDir is fine if we don't expect to be kill -9ing the process [09:02] but we may end up doing that :> [09:02] wgrant: then only the package present in the *first* parent will be copied. [09:03] s/package/packages/ [09:03] StevenK: NamedTemporaryFile is as safe (or unsafe) as TempDir, FWIW [09:03] rvba: But that's enough. [09:03] rvba: Because the package present in the first parent is different from the one already in the archive. [09:04] wgrant: each time we copy a parent into the (new) archive, we exclude from the copy any package with a name (sourcepackagename or binarypackagename) already present in the destination archive. [09:04] rvba: In the destination archive *and suite*. [09:04] rvba, hi, do you think you'd be able to QA 795396 fix soon? allenap, how about you and 798263? :) [09:04] danilos: hi! one sec. [09:04] rvba, cheers [09:05] Damn it, does NamedTemporaryFile() delete the file on close? [09:05] danilos: Okay, I'll do that now. [09:05] StevenK: yes [09:05] StevenK: it can't unlink it before then [09:05] Bah [09:05] allenap, thanks a bunch! [09:05] StevenK: if a regular temporary file onw't work, then use your current code. [09:06] lifeless: Why use TempDir when a NamedTemporaryFile is fine? [09:06] danilos: I'll be able to QA 795396 right now (if DF is up to date) [09:06] * rvba checks DF [09:06] wgrant: shrug, was saying 'do the simplest thing' [09:06] NamedTemporaryFile() currently isn't, since I'm using copy_and_close() to grab the contents of the filename from the librarian. [09:06] wgrant: they are functionally equivalent [09:07] wgrant: in terms of diskspace and leaks [09:07] lifeless: They are. But creating a file is probably simpler than creating a directory and then creating a file. [09:07] And so copy_and_close() close()'s the temporary file and it gets deleted. [09:07] That's rather antisocial of it. [09:07] wgrant: I think StevenK has found a difference :> [09:08] StevenK: Hi Steven, can you update DF? [09:08] rvba, just let me know when it's done because I have a mixture of revisions landed that should only be rolled out together, and I can't mark the earlier one qa-ok until everything in between is qa-ok :) [09:08] rvba: I'm there already. Will do it now. [09:08] danilos: sure, I will. [09:08] wgrant: thanks. [09:08] thanks all [09:08] Unless I can use something other than copy_and_close() to copy from the librarian? [09:09] you can, theres a pump_file in bzrlib.osutils [09:10] rvba: Should be coming back now. [09:10] wgrant: so your point is that since I check that the package is already there in the destination archive and suite, it's still possible to have the exact same *file* (in two different archives) ... right? [09:10] wgrant: thanks. [09:10] % grep -c pump_file eggs/bzr-2.3.3-py2.6-linux-x86_64.egg/bzrlib/osutils.py [09:10] 0 [09:10] s/two different suites/two different suites/ [09:10] rvba: Right. [09:11] s/two different archives/two different suites/ even [09:11] It may not be in the current suite. [09:11] wgrant: right, I get it ... that's the point ou already made last week but I guess I did not understand it properly ... [09:11] It's an edge case, but this is the sort of place that an edge case will crop up and nomnomnom goes the primary archive. And we want primary archives to not be eaten alive. [09:11] +1 [09:12] wgrant: right. [09:13] danilos: QA ok for 795396. [09:13] rvba, great, thanks! [09:13] np [09:14] morning all [09:15] Looks like copy_and_close() is it. :-( [09:17] StevenK: pumpfile(from_file, to_file, read_length=-1, buff_size=32768, report_activity=None, direction='read') [09:17] Copy contents of one file to another. [09:17] [09:17] The read_length can either be -1 to read to end-of-file (EOF) or [09:17] it can specify the maximum number of bytes to read. [09:17] [09:17] The buff_size represents the maximum size for each read operation [09:17] performed on from_file. [09:17] StevenK: (bin/py -m pydoc bzrlib.osutils) [09:17] lifeless: It seems NamedTemporaryFile() has a delete parameter [09:18] wgrant: Thanks for the clarification, I'll work on this today. [09:18] StevenK: at which point its no longer a temporary file [09:18] rvba: Thanks. This isn't an easy thing, unfortunately :( [09:19] wgrant: right, but with your help I'll see it through and land the 2500+ SLOC which depend on this ;) [09:20] StevenK: check the implementation - both the __del__ handler and the context manager will leave the file behind if you pass delete=False [09:20] StevenK: which is very much not what you want [09:20] myself, I'd use the tempdir and get on with my life ;). If you want to do something different, pumpfile will let you copy things around relatively sanely. [09:22] self._debfile = apt_inst.DebFile(open(self.filename)) [09:22] SystemError: E:Archive is too short [09:22] That's right after calling pumpfile() [09:23] seek(0) [09:24] you have a file already [09:24] seek(0) and pass the file in rather than a new file object. [09:24] henninge: I hope my review isn't frying your brain [09:25] lifeless: no, it won't ... [09:26] do we have a list of supported browsers ? [09:26] good morning launchpadders [09:26] (bug 799491) [09:26] <_mup_> Bug #799491: Posting a comment in rekonq does not insert it into the page < https://launchpad.net/bugs/799491 > [09:26] huwshimi & I are in Millbank [09:26] hola jml [09:26] lifeless: umm... I *thought* we did. huwshimi, do you know about such a list? [09:27] lifeless: Yeah I think there is something like that around. Let me dig it out [09:29] lifeless: This is what I was thinking of: https://dev.launchpad.net/GradedBrowserSupport [09:29] KLMN - its 2 years old? [09:30] anyhow [09:30] what I really care about is [09:30] do we consider bugs w/js on rekonq important, or do we say 'thanks for noticing, now please give us a patch' ? [09:30] [paraphrasing obviously] [09:31] rekonq uses webkit FWIW [09:31] yeah [09:31] still manages to fail - multiple different bugs open for it [09:31] not sure why the KDE people thought we needed another browser [09:34] wgrant: So, unicode() is wrong, what you prefer I use? filename.encode('utf8') and catch the encoding exception? [09:34] StevenK: if you're willing to not put non-utf8 stuff in the contents file, then yes. [09:34] StevenK: the alternative is to change the column from text to a byte array [09:35] And then use RawStr() ? [09:46] lifeless: if it's just a rekonq bug & not a webkit bug, it's the latter. [09:46] definitely not webkit; chrom* is fine [09:48] huwshimi: btw, I'm done w/ email stuff. [09:49] jml: I'm almost there. 5-10 mins if that's ok? [09:49] huwshimi: sure. [09:52] wgrant: What would you prefer? [09:58] jml: OK, done for now' [09:58] huwshimi: cool. want to come over here? [09:58] jml: OK, coming [10:01] StevenK: excluding some files will need an ack from the distro I think [10:01] StevenK: that might be easy to get [10:02] I would prefer to drag stuff into the unicode-only world [10:02] so encourage you to seek that ack [10:15] lifeless: Given nothing uses this, and isn't likely to until I write a population script are you personally happy with me leaving it as is and landing it while I wait for the ack. [10:16] StevenK: I'd be happy with you doing .decode('utf8'), catching errors and skipping those files, and seeking the ack async [10:16] StevenK: I wouldn't be happy with the cast-as-is landing [10:16] Right [10:42] jelmer: do you need anything from me wrt build-from-branch-into-(archive|primary)? [10:46] lifeless, whatever fails on webkit browsers is likely to fail on safari as well (I've hit a few problems like that with epiphany as well) [10:46] for instance, use of "class" keyword for a variable fails in webkit browsers [10:49] jml: No, though thanks for checking. (I'm waiting to double check with poolie, then I'll send an announcement of the LEP to the list) [10:49] jelmer: ok cool. [11:19] bigjools: have you put any thought into query schemas for soyuz ? [11:19] none at all [11:19] k [11:19] sorry - too busy with DDs [11:20] when we start maintenance I will [11:20] no need to apologise [11:20] I ask so that if I get some time to look at it, I'm not reinventing already thought out stuff [11:20] sure [11:31] bigjools, hi, do you know if jtv will show up today or if there's someone who can help QA bugs 394645, 537335? [11:33] danilos: he's having a day off [11:35] bigjools, ah, ok, thanks; seems a pretty big change so I don't feel comfortable doing the QA, and if we can't find anyone else to do it, I suppose we won't have a rollout today [11:36] danilos: are they his changes ? [11:38] bigjools, yeah [11:38] let me checkl [11:38] bigjools, spread over 3-4 revisions in the deployment report [11:38] bigjools, https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html [11:40] bigjools, (the first blocking revision is QAd but I need 13258 to be included in the deployment before I can mark it as qa-ok) [11:40] danilos: I think its your patch blocking atm :) [11:41] lifeless, see above, it's not [11:41] danilos: ah I see [11:41] lifeless, I mean, I am keeping it like that on purpose [11:41] (haven't used proper metadata in the commit message) [11:41] its fine, just a tad confusing [11:44] gnight everyone [11:51] allenap: Hi, are you around? [11:51] huwshimi: Yes, hi. [11:52] huwshimi: Want to have a chat? [11:52] allenap: Do you have a minute and want to talk about the initialization errors UI? [11:52] huwshimi: What's your preference? Skype, Mumble, phone? [11:53] lifeless: g'night. [11:53] allenap: Skype or Mumble is fine. I might try and trigger the error first though. [11:53] allenap: Unless you have a screenshot? [11:54] huwshimi: The error does not display anywhere in the page; it's an error in an job that runs outside of the app server. === dpm_ is now known as dpm [11:54] allenap: Ah I see [11:55] huwshimi: I'm online in Mumble, in Launchpad/Red. [11:55] allenap: OK, one minute [12:11] allenap: Let me know if you have any more questions about that. [12:12] allenap: I would also like to have a chat after you've implemented it to see how it went and how easy it was to do the UI side of things [12:13] huwshimi: Cool, okay, thanks. === Ursinha is now known as Ursinha-brb === henninge is now known as henninge-lunch === benji changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: henninge, benji | Critical bugs: 205 - 0:[######=_]:256 [13:54] * jml afk [13:56] adeuring: I won't make it to the call be fore :15 [13:58] Hi deryck, I wont make it until :15 [13:58] hi henninge. see my #launchpad-ops message. :) [13:59] not on there atm [14:01] henninge: everything postponed for >30 minutes :) [14:01] cool [14:02] henninge, yeah, sorry. I need to wait to bottom of hour for standup. === henninge-lunch is now known as henninge [14:31] abentley, adeuring -- ping for standup [14:35] this is taking forever, argh [14:38] Hi all - is r13249 deployable, and when is the next nodowntime deploy likely to occur? === salgado is now known as salgado-doctor [14:54] Ursinha-brb, hi, is there a way for me to mark a revision as fixed by one of the subsequent commits? (i.e. 13243/13248 is fixed by 13258) [15:00] Ah, that half-answers my question :-) [15:03] danilos, if the revision referencesthe same bug, it'll be marked as needstesting and the first revision should be fine [15:03] what links the revisions are the bugs they refer to [15:05] maxb, we generally do the nodowntime deployments when we reach more than 5 revisions ready to deploy [15:05] when we reach five, I mean [15:06] Ursinha-brb: amount of ready revisions isn't really the problem right now :-) [15:06] hehe [15:06] It seems there's some deployability firefighting going on [15:06] let me see [15:14] hm [15:15] Ursinha-brb, right, but they are linked to different bugs, and I don't want the first revision to be deployable before the latter one is :) I was hoping there'd be a qa tag like "qa-fixed-in-XXX" :) [15:16] there's not, unfortunately [15:17] maxb, fwiw, I am intentionally blocking on r13243 before everything becomes deployable up to and including 13258, but there are some complex revisions that I can't QA myself [15:18] Ursinha-brb, ok, then I'll just have to keep an eye on the deployment report, thanks [15:19] 13260 is a rollback og 13521, so presumably we have to go all the way from 13242 -> 13260 at least, in one hop :-/ [15:20] Perhaps I should check back tomorrow :-) [15:20] maxb, yeah [15:20] danilos: Please keep lifeless and myself up to date... we will attempt to deploy tomorrow. [15:21] Since you can't keep the tagger up to date :( [15:22] wgrant, well, there's not much I can do: jtv's revisions need QA and it seems complex enough a change that I couldn't QA it this morning; if we decide to ignore the anon user problem, we can just mark qa-ok bug 772754, but that will only bring us two revisions forward [15:22] <_mup_> Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing

< https://launchpad.net/bugs/772754 > [15:22] Argh [15:23] And no bigjools. [15:23] wgrant, I did bring it up this morning with Julian, fwiw [15:44] Hi benji! [15:44] hi henninge [15:44] benji: Are you already working on a review? [15:44]