[00:01] <karni> Have a great afternoon/evening everyone!
[00:11] <nessita> karni: you too!
[00:11] <nessita> I'm off as well
[00:29] <nessita> thisfred: if you're back, and if you're still working, I would strongly appreciate a review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/better-folder-mgmt/+merge/65281
[00:29] <nessita> thisfred: if not possible, is OK :-)
[00:30] <thisfred> nessita: will do, and then I'm EOD too, have to cook
[00:30]  * nessita too
[00:30] <nessita> thisfred: is long, so you're allowed to not to it
[00:30] <nessita> to not to do it*
[00:30] <thisfred> nah, I have a little time yet, I'll do it
[00:32] <nessita> thisfred: YOU ROCK, genial!
[00:32] <nessita> :-D
[00:32] <nessita> ok, all emails sent, all branches submitted, all energy wasted
[00:32] <nessita> bye all!
[00:32] <thisfred> see you tomorrow!
[00:32] <nessita> :-)
[00:33]  * nessita realizes that wasted was not the proper term
[00:33] <nessita> "all energy ran out"
[00:33] <nessita> thisfred: is that better? ^ (englishly speaking)
[00:33] <thisfred> nessita: yes, wasted implies it was all for nothing :)
[00:34] <nessita> right, and it was not the case (luckily)
[00:34] <nessita> ok, I'm gone
[00:34] <nessita> bye!
[01:10] <thisfred> reviewed, few minor issues
[01:11] <thisfred> now it's cook or be cooked
[02:17] <adorilson> rye: hi
[02:18] <adorilson> hi, folks
[02:44]  * karni EODs, for real this time
[11:40] <duanedesign> morning all
[11:41] <karni> hi duanedesign
[12:22]  * fagan break
[12:33] <nessita> hello all!
[12:41] <duanedesign> o/
[12:44] <nessita> hi duanedesign!
[12:44] <nessita> ralsina: you back to duties? :-)
[12:46] <nessita> mandel: good morning. You walking the beast?
[13:16] <nessita> ralsina: ping
[13:34] <ralsina> good morning!
[13:34] <ralsina> nessita pong
[13:34] <mandel> nessita: yes, I was, but I'm back :)
[13:34] <nessita> ralsina: volviste!
[13:35] <ralsina> nessita: back in business, just a tad late because of kid's school parents meeting
[13:36] <nessita> ralsina: when you have a moment, I need a review form you in a branch where I'm having some QT issues
[13:36] <ralsina> nessita: right now is a god time :-)
[13:36] <nessita> ralsina: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/better-folder-mgmt/+merge/65281/comments/141693/+reply
[13:36] <nessita> ah no
[13:36] <nessita> ralsina: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/better-folder-mgmt/+merge/65281
[13:37] <ralsina> nessita: ok, branching
[13:37] <nessita> ralsina: please read the merge proposal description and run the branch on linux
[13:37] <ralsina> nessita: ok
[13:38] <mandel> ralsina, nessita: a review for this will be very appreciated
[13:38] <mandel> https://code.launchpad.net/~mandel/ubuntuone-client/legal_linux_chars/+merge/65285
[13:38] <nessita> mandel: already approved, running tests still
[13:38] <ralsina> mandel: right after nessita's
[13:38] <nessita> ralsina: I need to solve the "QLayout: Attempting to add QLayout "" to SomePanel "Form", which already has a layout" warning, to understand where is coming from, please see the __init__ of the UbuntuOneBin class
[13:38] <ralsina> nessita: hmmmm that's pretty harmless
[13:38] <mandel> nessita: cool :)
[13:39] <nessita> ralsina: ... I know the code is not correct, so I would like to know how's the proper way of doing it
[13:39] <ralsina> nessita: ok, I'll take a look
[13:40] <ralsina> probably you need to set to no layout on designer on the container, or setLayout(None) somewhere
[13:40] <ralsina> *or* you are setting the layout of the wrong kind of widget. Will know in 5'
[13:42] <nessita> ralsina: you browse the source, I don't think is that simple, I'm trying to build a widget from an .ui, then make that widget parent of other widgets that are also built from an .ui
[13:43] <cjohnston> nessita: ping
[13:43] <nessita> cjohnston: pong
[13:43] <ralsina> nessita: ok, I am looking now
[13:43] <nessita> ack
[13:44] <cjohnston> nessita: I was told you may be the correct person to talk to.. I don't know if you have seen status.ubuntu.com yet... On the teams page there are 6 Ubuntu One teams.. Some with only 2 or 3 work items.. I wanted to see about reducing it to just the one core team, and then create topics (like what is seen on the main page of status.ubuntu.com) for any other breakdowns that may be needed. http://status.ubuntu.com/ubuntu-o
[13:46] <nessita> cjohnston: I'm definitely not the person to talk to, you may wanna talk about that with Chipaca`, he is our engineering manager and handles all the "sub teams" (ubuntuone-desktop, ubuntuone-foundations, ubuntuone-web)
[13:46] <cjohnston> Ok.. Thanks nessita
[13:46] <nessita> cjohnston: that url is giving me 404, btw
[13:47] <cjohnston> Odd.. it's working just fine for me.. Try http://status.ubuntu.com ?
[13:47] <ralsina> nessita: ok, stupid question, qtreactor url please?
[13:47] <nessita> that works, thanks :-)
[13:47] <nessita> ralsina: git clone https://github.com/ghtdak/qtreactor
[13:47] <cjohnston> Chipaca`: ping.. Same comment/question as I asked nessita ^ :-)
[13:48] <ralsina> nessita: thx!
[13:50] <Chipaca`> cjohnston: looking
[13:50] <cjohnston> ty
[13:50] <Chipaca`> cjohnston: the page looks "interesting", but not particularly useful
[13:50] <Chipaca`> cjohnston: what *should* i be seing?
[13:51] <ralsina> nessita: have you considered doing that using promoted widgets instead?
[13:51] <Chipaca`> ralsina: welcome back!
[13:51] <nessita> ralsina: I'm not familiar with promoted widget, so no
[13:51] <cjohnston> These are burndown charts... If you go to the Teams page, you will see many different Ubuntu One teams.. Chipaca` http://status.ubuntu.com/ubuntu-oneiric/teams.html
[13:52] <ralsina> Chipaca`: thanks!
[13:52] <ralsina> nessita: basically, you use a placeholder widget on designer, right click and tell it promote to WhateverWidget that is on module whatever
[13:52] <cjohnston> So for example: http://status.ubuntu.com/ubuntu-oneiric/ubuntuone-hackers.html  The ubuntuone-hackers team... (The trendline is off, I'm waiting to a new bzr pull to fix it)
[13:52] <Chipaca`> cjohnston: i'm using chromium, and all i see are dots (and, well, the header with "teams", but clicking it gives me dots also)
[13:52] <cjohnston> ahh
[13:52] <nessita> ralsina: I don't think that is what I need, from that explanation
[13:52] <cjohnston> You have a defined font siz
[13:52] <cjohnston> size
[13:52] <ralsina> nessita: and you don't have to load and insert each manually. But since you already did that I will try to make the warning go away :-)
[13:53] <Chipaca`> cjohnston: I have a what?
[13:53] <Chipaca`> alecu: just the person i was looking for!
[13:53] <ralsina> nessita: hmmm.... maybe I am not understanding the problem then. Give me 5' more to see if I get it.
[13:53] <alecu> hello Chipaca-prima
[13:53] <nessita> ralsina: I need a base panel to be parent of all the other panels. This parent need to implement some common functionality, and has an empty container to pack another widget in it
[13:53] <nessita> ralsina: sure
[13:54] <alecu> hello also ralsina, everybody!
[13:54] <nessita> dobey, mandel, thisfred, fagan, alecu, ralsina: stand up in 6'
[13:54] <nessita> hi alecu!
[13:54] <ralsina> nessita: oooooook I get the idea now. Have never done it this way, so it will take me a bit to untangle it
[13:54] <mandel> alecu: morning!
[13:54] <cjohnston> Chipaca`: https://bugs.launchpad.net/launchpad-work-items-tracker/+bug/795623 is affecting you..
[13:54] <ubot4> Launchpad bug 795623 in launchpad-work-items-tracker "Can not use minimum font size and can not zoom page (affects: 1) (heat: 5)" [Undecided,Confirmed]
[13:54] <ralsina> alecu: 'elo
[13:54] <Chipaca`> alecu: i'm trying to bring up the control panel on windows, and failing. what do i need to fix?
[13:55] <cjohnston> I'm not sure how to fix that in Chromium.. /me is looking
[13:55] <alecu> Chipaca`, got any error?
[13:55] <Chipaca`> cjohnston: I can look in firefox also :_)
[13:55] <Chipaca`> alecu: "no module named gi.repository" :-/
[13:55] <cjohnston> If you could try that.. That might be easier than checking settings, although I did just figure the fix in Chrome if FF doesnt work. :-)
[13:56] <alecu> Chipaca`, oh, yes. I saw that one. Let me check.
[13:56] <ralsina> nessita: where are you setting UbuntuOneBin.ui_class ?
[13:58] <ralsina> nessita: nevermind, found it
[13:58] <nessita> :-)
[13:58] <alecu> Chipaca`, try this branch: lp:~alecu/ubuntuone-control-panel/run-windows-run
[13:58] <Chipaca`> cjohnston: I'm not sure how these are generated
[13:58] <Chipaca`> cjohnston: but they seem wrong on several axes
[13:58] <cjohnston> Yes.. I'm waiting on IS to update the config file for me
[14:00] <Chipaca`> alecu: now i got a window, but tracebacks about 'get_root_dir' being missing
[14:00] <alecu> Chipaca`, welcome!
[14:00] <cjohnston> If you look at the teams page though, there are 6 Ubuntu One teams, that I want to take down to just one team... We can do topics, which is pretty much grouping blueprints together, to futher specify the blueprints into categories..
[14:00] <alecu> ralsina, nessita just called me; her flat has run out of electrical power.
[14:01] <ralsina> alecu: ok
[14:01] <Chipaca`> cjohnston: ok. what do you want from me?
[14:01] <dobey> cjohnston: the only team that should be there is "ubuntuone-team"
[14:02] <thisfred> me
[14:02] <mandel> me
[14:02] <mandel> alecu: can I have a review: https://code.launchpad.net/~mandel/ubuntuone-client/legal_linux_chars/+merge/65285
[14:02] <cjohnston> dobey: ubuntuone-team only has 22 work items, whereas ubuntuone-hackers has 123....
[14:02] <Chipaca`> cjohnston: I'm not sure I understand what you expect to be in the burndowns. Currently I'm seeing a bunch of apparently unrelated blueprints
[14:02] <alecu> Chipaca`, sd_client is still missing some bits, and for that my branch needs to comment a few broken bits, and we need to ignore some other broken bits like that.
[14:03] <Chipaca`> cjohnston: for example, why is https://blueprints.launchpad.net/ubuntu/+spec/desktop-o-gtk3-gnome3 under "ubuntu one team"?
[14:03] <dobey> cjohnston: because ubuntuone-hackers includes other people who aren't necessarily on the u1 team
[14:03] <cjohnston> Because it has a work item that is assigned to a member of the "ubuntu one team"
[14:03] <cjohnston> ok..
[14:03] <nessita> and we're back!!!
[14:03] <nessita> me
[14:03] <Chipaca`> dobey: they *all* include other people
[14:03] <Chipaca`> I don't know what's expected, what *should* be in the burndowns
[14:03] <dobey> Chipaca`: ubuntuone-team shouldn't
[14:04] <alecu> me
[14:04] <nessita> ralsina: are we standing up?
[14:04] <cjohnston> So... dobey, remove all but ubuntuone-team... Do you want any topics, like what is on the overview page?
[14:04] <Chipaca`> dobey: https://blueprints.launchpad.net/ubuntu/+spec/community-o-developer-ubuntu-dot-com-plans is under ubuntuone-team
[14:04] <alecu> nessita, welcome back!
[14:04] <dobey> Chipaca`: joshuahoover made that team explicitly for the purpose of burndown charts
[14:04] <ralsina> nessita: sure
[14:04] <nessita> alecu: :-)
[14:04] <ralsina> everyone, standup!
[14:04] <dobey> Chipaca`: because rodrigo is in it still?
[14:04] <thisfred> DONE: #779851 slight return (rewrote some parts of the branch to make the progress as informative as it can be) TODO: next unity integration bug I guess. BLOCKED: no LIKED: http://outloud.fm/u1rocks NEXT: mandel
[14:05] <mandel> DONE: Fixed bug 800077 bug 798641 bug 799722 bug 799751. Discovered bug 800091 which is very high priority atm because it simply blocks everything. Reviewd alecus branch for bug 799827
[14:05] <mandel> TODO: bug 800091 and propose SDTool only when all tests pass (includes fixin the previously mentoned bug)
[14:05] <mandel> BLOCKED: no, but I need to have lunch :)
[14:05] <mandel> nessita, please
[14:05] <dobey> and why is yaili there?
[14:05] <ubot4> Launchpad bug 800077 in ubuntuone-client "There is no bin that allows to start sd on Windows (affects: 1) (dups: 1) (heat: 12)" [High,In progress] https://launchpad.net/bugs/800077
[14:05] <dobey> me
[14:05] <ubot4> Launchpad bug 798641 in ubuntuone-client "The windows IPC should be using named pipes and not sockets (affects: 1) (heat: 133)" [Medium,In progress] https://launchpad.net/bugs/798641
[14:05] <ubot4> Launchpad bug 799722 in ubuntuone-client "IPC on windows uses the old CredentialsManagementTool and has an import error (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/799722
[14:05] <ubot4> Launchpad bug 799751 in ubuntuone-client "The file system notifications on windows do not convert the legal utf8 chars to ilegal windows chars (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/799751
[14:05] <ubot4> Launchpad bug 800091 in ubuntuone-client "Tritcask has an issue when opening files on windows that were closed in a different session (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/800091
[14:05] <nessita> DONE: bug #798964, tons reviews, windows port pushing/metting
[14:05] <nessita> TODO: bug #798413, maybe bug #800161
[14:05] <nessita> BLOCKED: nopes
[14:05] <nessita> NOTE: will run to university after the morning meetings, I'll be back after lunch
[14:05] <nessita> NEXT: alecu
[14:05] <ubot4> Launchpad bug 798964 in ubuntuone-control-panel "Add new folders tweaks (affects: 1) (heat: 24)" [Medium,Triaged] https://launchpad.net/bugs/798964
[14:05] <ubot4> Launchpad bug 798413 in ubuntuone-control-panel "Provide a method in backend to list only devices info without querying local settings from syncdaemon (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/798413
[14:05] <ubot4> Launchpad bug 800161 in ubuntuone-control-panel "Do no allow folder creation in a folder containing an UDF (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/800161
[14:05] <alecu> DONE: fixed #799827, found #799958 and started working on it
[14:05] <alecu> TODO: fix that bug, keep pushing u1cp-windows forward
[14:05] <alecu> BLOCKED: no
[14:05] <alecu> NEXT: None
[14:05] <ralsina> me
[14:05] <alecu> *DONE: fixed bug #799827, found bug #799958 and started working on it
[14:06] <ubot4> Launchpad bug 799827 in ubuntuone-client "find_credentials expects a proxy but gets a deferred (windows) (affects: 1) (heat: 6)" [Critical,Fix committed] https://launchpad.net/bugs/799827
[14:06] <ubot4> Launchpad bug 799958 in ubuntuone-client "windows ipc is not using the credentials management tool (affects: 2) (heat: 12)" [Critical,In progress] https://launchpad.net/bugs/799958
[14:06] <ralsina> DONE: nothing, vacation!
[14:06] <ralsina> TODO: finding out right now
[14:06] <ralsina> NEXT: noone
[14:06] <Chipaca`> ralsina: TODO: styling
[14:06] <dobey> λ DONE: people chasing
[14:06] <dobey> λ TODO: fix more stuff
[14:06] <dobey> λ BLCK: None.
[14:06] <nessita> ralsina: NEXT: fagan
[14:06] <ralsina> Chipaca`: ok, will do that after the two reviews I have pending
[14:07] <nessita> Chipaca`: wasn't ralsina our installer dev?
[14:07] <ralsina> nessita: that too
[14:07] <ralsina> nessita: now there is code I can steal ^w reuse
[14:07] <dobey> Chipaca`, cjohnston: and also, yes, those pages seem wrong on some levels :)
[14:07] <Chipaca`> ralsina: nessita: alecu: mandel: let's have a mumble so we can organize ourselves
[14:07] <mandel> ack
[14:07] <ralsina> Chipaca`: sure
[14:07] <thisfred> nessita: one last tiny comment on your branch, but I understand why the unicode is there in the first place now :) (I would still like to see a test with a path that is and encoded string with non-ascii chars)
[14:07] <nessita> ralsina, alecu, Chipaca`, mandel: mumble in 8 minutes? (ie a las y cuarto)
[14:08] <ralsina> nessita: ok
[14:08] <mandel> ok
[14:08] <nessita> thisfred: we can't build a Qstring with that kind of strings
[14:08] <ralsina> nessita: I don't quite understand how you use setupUi on that branch
[14:08] <nessita> ralsina, alecu, Chipaca`, mandel: so we can build mate :-P
[14:08] <Chipaca`> dobey: the shim work got pushed forwards a week
[14:08] <nessita> ralsina: neither do I :-)
[14:08] <Chipaca`> dobey: so, no news on that yet
[14:08] <thisfred> nessita: well what happens when the filesystem hands you a path like that then?
[14:08] <ralsina> nessita: you are calling it twice on the same widget? You are not supposed to do that :-)
[14:08] <dobey> Chipaca`: by forward you mean back?
[14:09] <Chipaca`> dobey: I'm looking into the future, future is that ways
[14:09] <alecu> already on mumble.
[14:09] <dobey> Chipaca`: ok, so what do we do for lucid?
[14:09] <dobey> because i'm pretty sure the lucid freeze hasn't moved :)
[14:09] <Chipaca`> dobey: for 10.04.3 you mean? nothing
[14:10] <dobey> yeah
[14:10] <ralsina> nessita: if the UI in ubuntuonebin.ui has a placeholder, then you have to call setupUi(sel.ui.placeholder)
[14:10] <dobey> nothing is great. i like nothing.
[14:10] <Chipaca`> dobey: we don't have the resources to do what we'd have to do to do it right, and to do things wrong we might as well leave wrong enough alone
[14:11] <nessita> ralsina: I tried that, is does not work
[14:11] <nessita> ralsina: the setupUI expects something with setObjectName method, and the placeholder does not have that
[14:12] <nessita> thisfred: that is handled by QT. The call to getExistingDirectory handles all that
[14:12] <ralsina> nessita: alternative is to use a promoted widget to provide the common part of the UI (title, progressbar) in each tab's UI
[14:12] <nessita> thisfred: we're given a QString which inside has a unicode
[14:12] <nessita> thisfred: and syncdaemon expects an unicode encoded with utf8 and transforms all that is needed
[14:13] <ralsina> nessita: the *other* alternative is to ignore the warning because it's not a real problem, but I know that's hard ;-)
[14:13] <nessita> thisfred: the QString given is also a unicode encoded with utf8, as far as I understand
[14:13] <thisfred> nessita: ok, excellent!
[14:13] <thisfred> nessita: unicode is not encoded :)
[14:13] <thisfred> you can be one or the other
[14:13] <nessita> thisfred: True, sorry for mixing that up
[14:14] <thisfred> nm, branch is great
[14:14] <Chipaca`> alecu: nessita: mandel: any other branch i should merge into u-c-p before showing it around the office?
[14:14] <Chipaca`> i won't show it to mpt, though
[14:14] <nessita> Chipaca`: yeah, several not done yet?
[14:14] <nessita> Chipaca`: is not showable, not close, you know that, do you?
[14:14]  * mpt pouts
[14:14]  * nessita freaks
[14:15] <Chipaca`> mpt: I've never seen you go postal, but this would definitely push you towards that edge
[14:15] <Chipaca`> nessita: i need to show it, i will show it, my question is: is there anything else done i should merge before that?
[14:16] <ralsina> nessita: tried it, it works
[14:16] <nessita> Chipaca`: the current control panel does not communicate with syncdaemon. LEt's talk in mumble
[14:17] <ralsina> nessita: basically, added a placeHolder widget in data/qt/ubuntuonebin.ui and did self.ui.setupUi(self.bin_ui.placeHolder)
[14:18] <ralsina> logging into mumble, going slowly!
[14:22] <fagan> sorry was helping my da with his computer and lost track of time
[14:23] <fagan> me
[14:23]  * fagan writes some notes
[14:24] <fagan> DONE
[14:24] <fagan> * Looked at the code for the keyring in sso to see where exactly its going wrong on my system
[14:24] <fagan> * Looked at the keyring api a bit to figure out how to debug it
[14:24] <fagan> TODO
[14:24] <fagan> * See what I can do to fix it
[14:24] <fagan> Blocked
[14:24] <fagan> * nope
[14:46] <mandel> alecu, nessita, ralsina: I'm away for about 20 min for lunch
[14:46] <nessita> mandel: enjoy that!
[14:46] <alecu> mandel, buen provecho!
[14:46]  * nessita will grab the bolied water and make some tea instead
[14:49] <ralsina> mandel: take 40, don't choke, dude :-)
[14:55] <alecu> nessita, mandel, ralsina: hey, all: I need to be afk for 1h30, starting in 30' aprox. Amelia woke up with lots of fever, so she's not going to kinder, and I'll need to take care till the nanny arrives.
[14:55] <ralsina> alecu: ack
[14:58] <nessita> alecu: ok
[15:10] <nessita> damn power supplier
[15:25]  * alecu will be afk for ~ 1h30m
[15:37] <nessita> mandel: were you able to dump all tritcask issues to guillermo?
[15:37] <nessita> mandel: any pending reviews from you to us?
[15:37] <mandel> nessita: yes, he is taking care of them
[15:37] <nessita> great!
[15:38] <mandel> nessita: let me take a look at the reviews, one min
[15:38] <verterok> nessita: "all"? I'm only aware of one
[15:38] <nessita> mandel: I'm then reassigning bug #800091 to verterok
[15:38] <ubot4> Launchpad bug 800091 in ubuntuone-client "Tritcask has an issue when opening files on windows that were closed in a different session (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/800091
[15:38] <nessita> verterok: yeah, that one, that seems big enough to be a lot :-P
[15:38] <verterok> nessita: yes, windows is broken beyond any possible fix :p
[15:39] <nessita> lol
[15:39]  * nessita agrees
[15:39] <mandel> nessita: I need a +1 for this https://code.launchpad.net/~mandel/ubuntuone-client/legal_linux_chars/+merge/65285 which I already ask for to ralsina and alecu...
[15:39] <dobey> nah, the fix for all windows problems is to reinstall :)
[15:39] <ralsina> mandel: I'll look at it in 5'
[15:39] <nessita> mandel: can you please re ask ralsina and Chipaca`? alecoo said he was afk for a while
[15:40] <verterok> nessita, mandel: how on earth adding a print before an self.assertEqual call might fix a test?
[15:40] <nessita> verterok: timing issue
[15:40] <dobey> lol
[15:40] <verterok> nessita: it's an update of a dict!
[15:41] <nessita> verterok: is it done from a deferred?
[15:41] <dobey> the classic "let's add a print '\a' statement to fix it"
[15:41] <verterok> nessita: no threads, no twisted, no nothing...just plain old python
[15:41] <nessita> verterok: show me the code
[15:41] <nessita> (I'm not buying it then :-P)
[15:41] <verterok> nessita: tests/syncdaemon/test_tritcask.py # KeydirStatsTests.test_remove
[15:42] <dobey> verterok: there can be other twisted-based tests causing timing issues (and by could be, i mean are)
[15:42] <mandel> Chipaca`: cn I get a review for this: https://code.launchpad.net/~mandel/ubuntuone-client/legal_linux_chars/+merge/65285
[15:42] <Chipaca`> mandel: yes
[15:42]  * Chipaca` reviews`
[15:42] <mandel> verterok: no clue, windows is a weird thing...
[15:42] <mandel> and python on windows even more
[15:43] <ralsina> mandel: looks good to me, of course not actually knowing that remove_illegal_windows_whatever does ;-)
[15:44] <mandel> ralsina: converst ?/ etc in utf8 chars that look the same
[15:44] <ralsina> mandel: ok then +1
[15:44] <nessita> mandel: what else you need reviewed?
[15:44] <mandel> ralsina: did you run the test?
[15:45] <ralsina> mandel: you need it on windows, right?
[15:45] <mandel> ralsina: yes
[15:46] <ralsina> mandel: don't set to approved then
[15:47] <mandel> nessita, ralsina: this should be an easy one https://code.launchpad.net/~mandel/ubuntuone-client/use_txnamedpipes/+merge/65317
[15:47] <nessita> mandel: looking
[15:47] <ralsina> mandel: cool, will get to it after this one
[15:48] <nessita> ralsina: while you run mandel's tests, could you please finish https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/better-folder-mgmt/+merge/65281? (your placeholder fix is now there)
[15:48] <ralsina> nessita: sure
[15:48] <nessita> thanks
[15:50] <ralsina> Manuel, I get ImportError: No module named ubuntu_sso.main.windows
[15:52] <ralsina> mandel: ^
[15:52] <mandel> ralsina: then you do not have sso installed in the system, do you?
[15:53] <ralsina> mandel: looks like it. Just setup.py install from sso?
[15:54] <mandel> ralsina: yes
[15:54] <ralsina> mandel: ok, will do that and get back to you in 5'
[15:56] <verterok> nessita, mandel, ralsina: https://code.launchpad.net/~verterok/ubuntuone-client/fix-800091/+merge/65357
[15:57] <mandel> verterok: on it!
[15:57] <ralsina> verterok: well, the fix looks reasonable ;-)
[15:57] <mandel> verterok: is that correct, we do not need to flush ?
[15:58] <ralsina> mandel: it should flush on process death regardless of how it dies
[15:58] <verterok> mandel: no need to flush/fsync on read-only files
[15:58] <ralsina> and that too, of course
[15:58] <verterok> mandel: ImmutableDataFile instances represents ro files, which are opened using 'rb'
[15:58] <mandel> ok, let me test it in a real life case :)
[15:58] <nessita> verterok: an you please add that clarification as a comment?
[15:59] <verterok> nessita: comment where? it's in the class docstring
[15:59] <nessita> verterok: in the close() implementation, anyone reading that def will wonder why the parent class is not called
[16:01] <verterok> nessita: ok, somethig like: "I don't call parent close, as I'm a read-only file and there is no need to call flush nor fsync (and windows hate it and dies in horrible ways)"?
[16:01] <nessita> verterok: for instance :-D
[16:01] <mandel> verterok: just tested it in a real env (my account syncing) and it works!!!
[16:02] <verterok> mandel: cool
[16:02] <verterok> nessita: added comment & pushed
[16:02] <mandel> nessita, verterok: I thin windows is actually doing something right here, if you flush in a readonly file you should get an exception telling you something like 'you have no w you fool'
[16:02] <mandel> with an ascii mr.t if possible :)
[16:03] <thisfred> CardinalFang: could you have a brief look at the pastebin attached to bug #800179
[16:03] <ubot4> Launchpad bug 800179 in desktopcouch "Desktopcouch unable to find listening port? Evolution CouchDB addressbooks still not available [http://askubuntu.com/q/49060/13049] (affects: 1) (heat: 6)" [Undecided,Incomplete] https://launchpad.net/bugs/800179
[16:03] <ralsina> nessita: yes that fixes the stuff with the warning, but have you looked at eric's comment about unicode stuff? Need a hand with that?
[16:04] <thisfred> ralsina: seems that was a non-issue
[16:04] <nessita> ralsina: I replied to all, did you read my responses to check if they make sense?
[16:04] <thisfred> CardinalFang: Looks like desktopcouch's couchdb crashes because it can't find the remote dbs. Never seen that before...
[16:04] <ralsina> nessita: I see no response to the last one
[16:05] <nessita> ralsina: the only one that has not response is "I will set this to approve, to not hold this up in case I'm not around to re-review, but please fix the last two concerns (or explain why I'm wrong about them ;) "
[16:05] <ralsina> nessita: but yes, basically, QString(u"whatever") is the correct thing
[16:05] <ralsina> nessita: weird, I see no response for "It does, but here you're passing in a unicode string..."
[16:06] <ralsina> nessita: then again, I may need to reload the page ;-)
[16:06] <nessita> ralsina: ah I replied to that here
[16:06] <ralsina> nessita: ok then :-)
[16:06] <ralsina> nessita: yes, your responses about unicode make sense, so +1ng it.
[16:07] <nessita> thanks!
[16:07] <ralsina> mandel: the test_dir_create seems to be stuck forever on windows :-(
[16:08] <mandel> ralsina: is not flushing the changes from the chace… do tyou remember my long email...
[16:08] <mandel> ralsina: how are you running the tests?
[16:08] <ralsina> mandel: run-tests as usual. No I don't remember the long email, sorry :-(
[16:09] <mandel> ralsina: look at the description of the branch, it tell you which tests to run exactly, the cache issue with the file system is something to fix later… which I dont know how :P
[16:09] <ralsina> mandel: ok, will do that
[16:11] <ralsina> mandel: ok, tests pass
[16:12] <mandel> :)
[16:12] <ralsina> mandel: so, you could set it to approved now
[16:12] <mandel> just did :P
[16:15] <CardinalFang> thisfred, looking.
[16:17] <thisfred> thx!
[16:17]  * ralsina wonders if the windows-installer project should have linux support. Probably not.
[16:17] <nessita> ralsina: yes!
[16:18] <nessita> ralsina: the wizard should be multiplatform unless it delays you a lot
[16:18]  * ralsina was kidding ;-)
[16:18] <nessita> ralsina: since we will use it on linux as well
[16:18] <ralsina> nessita: I am actually doing it on linux, so...
[16:18] <nessita> ralsina: ack
[16:18] <nessita> (great)
[16:18] <ralsina> we should rename the project maybe
[16:19] <nessita> ralsina: so, as an FYI, let me share with you that the feelings of the windows team are very sensitive right now, so we need to be careful with the jokes (general notice)
[16:19] <mandel> nessita, ralsina: did you have the chance to look at: https://code.launchpad.net/~mandel/ubuntuone-client/use_txnamedpipes/+merge/65317
[16:20] <nessita> mandel: yes, runinng tests now
[16:20] <mandel> cool
[16:20] <ralsina> nessita: oops, ok, will be sensitive from now on.
[16:20] <nessita> :-)
[16:20] <nessita> mandel: all green, approving. PLease seek a windows review with IRL testing, maybe Chipaca` so ralsina can code :-)
[16:21] <Chipaca`> which branch is it now?
[16:21] <Chipaca`> didn't get to review the last one, mandel, my vm was in use (and i understood ralsina gave you a review, if not please ping)
[16:21] <nessita> Chipaca`: https://code.launchpad.net/~mandel/ubuntuone-client/use_txnamedpipes/+merge/65317
[16:21] <mandel> Chipaca`: yes, no worries, I ping people as I need :)
[16:21] <nessita> Chipaca`: I would love if you could run thar IRL
[16:22] <nessita> that*
[16:22] <nessita> (on windows, of course)
[16:22] <dobey> lunch, bbiab
[16:22] <Chipaca`> what is "IRL" in this context
[16:22] <Chipaca`> nessita: ?
[16:22] <nessita> in real life. Like grabbing syncdaemon and making it run
[16:22] <nessita> mandel: is thata possible, right? ^
[16:23] <Chipaca`> um
[16:23] <Chipaca`> mandel: how do i run tests on windows?
[16:24] <mandel> nessita: Chipaca`: using this you can make it run IRL
[16:24] <mandel> Chipaca`: how to run the tests is given in the proposals
[16:28] <Chipaca`> mandel: you're right, apologies
[16:28] <mandel> Chipaca`: no worries, is normal :)
[16:30] <Chipaca`> ugh, no storageprotocol
[16:30]  * Chipaca` branches
[16:33] <CardinalFang> thisfred, I don't see crashes in that attached pastebin log.
[16:34] <rodrigo_> rye, is there a bug # for the dc brokenness in oneiric?
[16:35] <thisfred> CardinalFang: hmm, maybe I was thrown off by the 'Crash report'
[16:35] <thisfred> CardinalFang:  ok, then it seems it's just running? On 10.10 we didn't have the threeway fork and respective logs yet or did we?
[16:36] <CardinalFang> thisfred, yeah, those are crashes, but normal erlang way of handling errors.  Nothing that causes it not to listen on a port.
[16:37] <thisfred> right
[16:37] <CardinalFang> thisfred, only two then.
[16:37] <thisfred> ok
[16:37] <CardinalFang> one for replication, one for DBus server.
[16:40] <thisfred> I guess the dbus is what we need
[16:40] <Chipaca`> rodrigo_: what brokenness?
[16:41] <rodrigo_> Chipaca`, couldn't authenticate errors, rye told me it was broken in oneiric
[16:41] <rodrigo_> Chipaca`, the keyring access, iirc
[16:46] <Chipaca`> rodrigo_: hmm... is this keyring issue different from the ubuntu sso issue around the keyring changing its api?
[16:46] <rodrigo_> Chipaca`, not sure, it might be the same
[16:46] <rodrigo_> Chipaca`, I just get 'unauthenticated' errors when accessing it from evolution
[16:52] <Chipaca`> rodrigo_: right, i don't know what bit is giving you that. We have some issues with several system services changing their api (for no good reason, i must add)
[16:53] <rodrigo_> Chipaca`, yeah :)
[16:53] <mandel> ralsina: can you take a look at https://code.launchpad.net/~mandel/ubuntuone-client/use_txnamedpipes/+merge/65317
[16:53] <Chipaca`> mandel: tests run and work ok. on to IRL testing ...
[16:53] <ralsina> mandel: wasn't chipaca looking at it?
[16:54] <mandel> Chipaca`, ralsina: oh cool, I'll wait then
[16:54] <Chipaca`> ralsina: i am
[16:54] <Chipaca`> mandel: how do i test IRL?
[16:55] <Chipaca`> mandel: just running u1-syncdaemon?
[16:55] <Chipaca`> probably not :)
[16:55] <mandel> Chipaca`: you can do it with the following branchhttps://code.launchpad.net/~mandel/ubuntuone-client/provide_windows_start_script
[16:56] <mandel> Chipaca`: you will need to get your credentials for u1 and put the in the fault, you need sso running for that
[16:56] <Chipaca`> mandel: half through that you started sounding like "no, you can't do IRL testing yet"
[16:57] <Chipaca`> nessita: how important are IRL tests?
[16:57] <Chipaca`> nessita: if I have to do all the above, IRL tests fail :)
[16:57] <nessita> Chipaca`: I'd say very, but I see your point. I guess we can make IRL "mandatory" after that last branch (the one that provides de start script) is in place
[16:58] <nessita> what puzzles me is how we were testing branches before having a start script! :-)
[16:58] <nessita> mandel: how do you run your syncdaemon without the start script?
[16:58] <mandel> nessita: I walways had the start script with the credentials harcoded for test, that is why I create the next branch
[16:59] <nessita> ah...
[17:01] <Chipaca`> mandel: +1
[17:05] <nessita> dobey: seems like you have u1client nightlies outdated? tarmac fails with: "Instance of 'SyncDaemonTool' has no 'is_autoconnect_enabled' member" and the branch that provides that landed last week
[17:05] <nessita> dobey: can you please confirm and re-approve https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/better-folder-mgmt/+merge/65281 ?
[17:05]  * mandel walks dog
[17:07] <nessita> can I have a couple of reviews for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/simpler-devices-backend/+merge/65368 ?
[17:10] <Chipaca`> GASP!
[17:10] <Chipaca`> syncdaemon running on windows
[17:11] <Chipaca`> I don't know if it's *working*, but it's running :)
[17:11] <ralsina> Can I have two reviews for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/ui_files_1/+merge/65371 ? Runs only on Linux ATM
[17:11] <Chipaca`> and it certainly looks like it works :)
[17:11] <ralsina> nessita: on it!
[17:11] <nessita> ralsina: looking
[17:12] <ralsina> nessita: sorry about the length but I did the minimum I could :-(
[17:12] <nessita> ralsina: under 1000 is completly ok
[17:12] <nessita> yours is 809
[17:12] <ralsina> nessita: forget it, it has a lot of cruft in ubuntuone_installer/gui/__init__.py that shouldn't be there
[17:12] <Chipaca`> nessita: reviewing
[17:12] <Chipaca`> ralsina: also
[17:13] <nessita> ralsina: so, your branch needs fixing then?
[17:13] <ralsina> nessita: or rather, lots of it *should* be there but I don't know which parts yet
[17:13] <nessita> ralsina: I'm not following, can you please restart from the top? :-)
[17:13] <ralsina> nessita: it has too many constants, other than that it should be ok-ish
[17:14] <ralsina> nessita: ok, that branch replicates most of the structure of the controlpanel project into windows-installer. I may have copied a bit too much ;-)
[17:14] <nessita> ralsina: right, can you please clean up a bit?
[17:15] <ralsina> nessita: I can remove most of ubuntuone_installer/gui/__init__.py. I will ask again in a few minutes
[17:15] <nessita> ralsina: please. Also, we do not versionate (under bzr) the ui.py generated files, so you need to remove those and set a .bzrignore rule
[17:15] <ralsina> nessita: ok
[17:19] <Chipaca`> ralsina: you didn't link your branch to a bug
[17:19] <ralsina> Chipaca`: oops, will do in 1'
[17:20] <Chipaca`> ralsina: also, no such file "ubuntuone-installer-qt"
[17:20] <nessita> ralsina: bzr ci --fixes=lp:123456
[17:20] <Chipaca`> ralsina: maybe you forgot to add it?
[17:21] <ralsina> Chipaca`: very likely!
[17:21] <Chipaca`> no é así, loco, no é
[17:21] <Chipaca`> :-p
[17:21] <Chipaca`> ralsina: let me know when to re-pull
[17:22] <ralsina> Chipaca`: now
[17:22]  * ralsina is so rusty his chair is getting red
[17:23] <nessita> ralsina: can I also repull?
[17:23] <ralsina> nessita: sure
[17:23] <nessita> ralsina: I mean, did you clean up already?
[17:23] <ralsina> nessita: yes
[17:23] <nessita> great
[17:23]  * nessita is leaving in 10 minutes
[17:24] <nessita> ralsina: the ui dir is still there:
[17:24] <nessita> +N  ubuntuone_installer/gui/qt/ui/
[17:24] <nessita> +N  ubuntuone_installer/gui/qt/ui/__init__.py
[17:24] <ralsina> nessita: yes... shouldn't it be there, not even empty?
[17:25] <nessita> ralsina: nopes
[17:25] <nessita> you can check the controlpanel tree
[17:25] <nessita> nessita@dali:~/canonical/u1/controlpanel/trunk$ bzr st ubuntuone/controlpanel/gui/ui
[17:25] <nessita> nonexistent:
[17:25] <nessita>   ubuntuone/controlpanel/gui/ui
[17:25] <nessita> bzr: ERROR: Path(s) do not exist: ubuntuone/controlpanel/gui/ui
[17:25] <ralsina> ok, removing it completely then
[17:26] <nessita> ralsina: let me know
[17:26] <Chipaca`> ralsina: import error: from ubuntuone_installer.gui.qt.main import windows: cannot import name windows
[17:26] <ralsina> Chipaca`: only on linux right now
[17:27] <ralsina> windows in an hour or two after I have a page in it
[17:27] <ralsina> nessita: ui folder gone
[17:28] <nessita> ack
[17:29] <ralsina> nessita: did you set PYTHONPATH=. ?
[17:29] <nessita> eh?
[17:29] <nessita> ralsina: clicking on cancel does not stop the reactor
[17:29] <dobey> nessita: just finished an apt-get upgrade
[17:30] <nessita> you need to fix that in the same way that controlpanel does
[17:30] <ralsina> nessita: this just opens a wizard. I'll file a bug for that one
[17:30] <nessita> ralsina: ack
[17:30] <nessita> dobey: does that mean I can re approve?
[17:31] <dobey> nessita: i just did
[17:31] <nessita> ah, you did
[17:31] <nessita> thanks
[17:31] <nessita> ralsina: can you please clean up all the copied docstrings? """The user interface for the control panel for Ubuntu One.""" :-)
[17:31] <ralsina> nessita: filed bug #800282
[17:32] <ubot4> Launchpad bug 800282 in ubuntuone-windows-installer "Closing the window should stop the reactor (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/800282
[17:32] <nessita> ralsina: grepping -i for "control panel" should give nothing ;-)
[17:32] <ralsina> nessita: sure thing!
[17:32] <nessita> ralsina: also remove def uri_hook(uri):
[17:32] <ralsina> nessita: if control panel uses it, we probably need it on installer too
[17:33] <nessita> ralsina: don't think so, is too specific
[17:33] <nessita> anyways, is better practice to add the stuff we need when we need it
[17:33] <ralsina> nessita: ok
[17:33] <nessita> otherwise we can easily forget and crowd the project with unedeed stuff
[17:33]  * alecu is back
[17:34] <nessita> hey alecu!
[17:36] <ralsina> nessita: removed references to control panel, removed the hook
[17:36] <nessita> yeyyyy
[17:39] <nessita> ralsina: approving but I'm hating the code duplication in logger,py, can you please file a bug to improve that later? :-)
[17:39] <ralsina> nessita: we really should have a libary of random useful stuff
[17:39] <nessita> indeed
[17:41] <ralsina> nessita: filed bug #800284
[17:41] <ubot4> Launchpad bug 800284 in ubuntuone-windows-installer "logger.py is duplicated from the control panel (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/800284
[17:41] <nessita> great
[17:41] <nessita> approved
[17:42] <dobey> nessita, ralsina: btw, are we putting a "[] Start Ubuntu One at Log-in" option to cp this week?
[17:42] <ralsina> dobey: this week? doubt it
[17:42] <ralsina> nessita: thanks!
[17:42] <dobey> hmm
[17:43] <nessita> ok, I'm off to the Uni
[17:43] <nessita> bye all, see ya in a couple of hours!
[17:43] <ralsina> bye nessita
[17:44] <fagan> EOD for me I think
[17:44] <fagan> ralsina: did you see that im doing something for josh
[17:44] <ralsina> fagan: didn't, please tell me! :-)
[17:45] <fagan> ralsina: im reformatting the FAQ from moin to rst
[17:46] <ralsina> fagan: cool
[17:46]  * ralsina hearts rst
[17:46] <fagan> ralsina: never heard of it
[17:46] <ralsina> fagan: check rst2pdf.googlecode.com :-)
[17:47] <fagan> but its not the first time I had to convert stuff, I had to change the quickly docs from html to docbook
[17:47] <fagan> ralsina: nice
[17:47]  * mandel back
[17:47] <ralsina> well, compared to docbook, rst is heaven
[17:48] <fagan> ralsina: I did it by hand :)
[17:48] <ralsina> there is something called pandoc that may save you some effort. Not sure it understands moin though
[17:49] <fagan> ralsina: it was a problem with the code we had in the docs. It messed with all the automated tools
[17:49] <ralsina> fagan: it happens. Hopefully this time it's easier
[17:49] <alecu> mandel, ping
[17:49] <fagan> and there was some othr formatting bits too that I forget :)
[17:50] <mandel> alecu: pong
[17:50] <alecu> mandel, in provide_windows_start_script, in run_test.bat: how do I make u1trial use the correct reactor?
[17:50] <fagan> ralsina: yeah well its not too hard by the looks of it so I can sort it fast enough and get back to figuring out how the keyring bits are not working in 11.10
[17:50] <alecu> mandel, in my env it's trying to use the glib reactor :-(
[17:50] <mandel> alecu: you have to use the —reactor parameter
[17:50] <fagan> anway EOD later all
[17:51] <fagan> anyway
[17:51] <mandel> alecu: so, u1trial —reactor=txnp test_path
[17:51] <ralsina> bye fagan!
[17:51] <alecu> mandel, perhaps it should be inside the .bat?
[17:51] <mandel> alecu: yes, it should, I must have forgotten to update it
[17:51] <mandel> stupid me...
[17:52] <mandel> alecu: but I need to fix that branch conflicts first, your CredsManagementTool landed first and got some stupid conflicts, easy to solve, but has to be done :P
[17:52] <alecu> mandel, sure, go ahead.
[17:53] <alecu> anyway, I'm getting "the path to test does not exist" now :-(
[17:53] <mandel> alecu: shall we add a bug stating that run-test is bad and we add it to that branch?
[17:53] <alecu> mandel, sure, I'll add it and I'll get to work on it later.
[17:54] <mandel> alecu: superb
[17:55] <ralsina> ok, lunch break for me, be back in 30 or so
[17:56] <alecu> mandel, I'll work on in on another branch. Didn't realize that the .bat was there before your branch.
[17:57]  * alecu brbs
[17:57] <mandel> Chipaca`: can you re-give me the +1 for this https://code.launchpad.net/~mandel/ubuntuone-client/provide_windows_start_script/+merge/65376
[17:58] <mandel> Chipaca`: I had to resubmit the merge proposal because the dependencie sin the branches were given very strange conflicts
[17:58] <Chipaca`>  mandel ther eyou go
[17:58] <mandel> Chipaca`: txh!
[17:58] <mandel> thx :P
[18:02] <mandel> alecu: can you test this branch: https://code.launchpad.net/~mandel/ubuntuone-client/provide_windows_start_script/+merge/65376
[18:02] <mandel> alecu: is a milestone, it means that in truck we have sd working on windows, we just have to make it easy for people to have the credentials
[18:03] <alecu> mandel, sure, I was already taking a look at that branch.
[18:04] <ralsina> dobey: is tarmac merging ubuntuone-windows-installer?
[18:04] <mandel> alecu: awesome, I'm going for rugby (is 7 pm here) but I'll be back in a few hours and will propose the sdtool branch, will try to ping you and nessita about it
[18:04] <dobey> ralsina: no
[18:04] <alecu> mandel, ack
[18:04] <mandel> alecu: if you are ok with that branch, can you approve it so that it lands while I'm at rugby?
[18:04] <ralsina> dobey: ok
[18:06] <ralsina> dobey: could it? ;-)
[18:07] <dobey> ralsina: maybe? i don't know anything about u1-windows-installer's requirements for landing branches. are there tests we have to run? what else does it require? can it be done on linux?
[18:07] <ralsina> dobey: yes to linux, no tests yet, just pep8 and u1lint
[18:08] <dobey> ok
[18:08] <ralsina> dobey: requirements same as for control panel
[18:08] <dobey> then i guess we can add it to tarmac, sure
[18:08] <ralsina> dobey: cool thx
[18:09] <dobey> hrmm
[18:09] <dobey> i wonder if there is an easy way to do a mass deactivation of milestones on lp
[18:09] <dobey> probably "write a script"
[18:10] <ralsina> dobey: cool, right now is only me working on it but that may/will change eventually and tarmac would be handy
[18:11] <dobey> ralsina: i understand. i don't care how many people are contributing to it. all i care about are the requirements for landing branches in it :)
[18:12] <dobey> contrib agreement, tests, etc… stuff
[18:12] <ralsina> dobey: ok. Will this be dome soonish (say, next day or two) or should I figure out how to manually merge to trunk? ;-)
[18:14] <dobey> hrmm, need to move the branches too.
[18:15] <dobey> ralsina: i would say by eod today
[18:15] <ralsina> dobey: cool then, thanks you so much
[18:16] <dobey> sure
[18:18] <dobey> ralsina: don't propose any other merges to it until i get stuff moved around and tarmac set up though. :)
[18:18] <ralsina> dobey: sure thing
[18:19] <ralsina> I can push branches but not propose merges, right?
[18:20] <dobey> ralsina: let's hold on that too, but should only take me a few minutes to get this set up
[18:21] <ralsina> dobey: ok, sorry then because I pushed one a few minutes ago. No more, I promise
[18:21] <dobey> heh, ok
[18:24] <ralsina> dobey: that was quick :-)
[18:26] <dobey> i haven't set up tarmac yet. i merged your branch by hand to avoid a slew of other migration problems :)
[18:32] <dobey> ralsina: do you have a branch that adds run-tests/run-tests.bat which only do the pep8/u1lint checks (preferably using USE_PYFLAKES=1)?
[18:32] <ralsina> dobey: don't have it
[18:32] <ralsina> dobey: could have it!
[18:32] <dobey> that's the spirit! :)
[18:33] <dobey> ralsina: i've got trunk moved to the right team ownership, and set up tarmac to merge the branches. but there's no run-tests yet, so haven't set it up to run one :)
[18:33] <dobey> ralsina: but as soon as there's a branch adding that, i can add the config option to run it
[18:33] <ralsina> dobey: that's ok for today I will have one useful tomorrow
[18:34] <dobey> ok, well it's set up :)
[18:35] <ralsina> dobey: cool, thanks!
[18:35] <dobey> np
[18:35] <dobey> now back to evil dbus API changes
[18:36] <dobey> hrmm, and calling this landscaping co.
[19:02] <alecu> hey all, I'm having a configglue issue on windows: http://pastebin.ubuntu.com/630494/
[19:02] <alecu> anybody has any idea about that?
[19:03] <alecu> Chipaca`, ^ did you have that issue running mandel's branches?
[19:30] <dobey> hrmm. having trouble understanding some of the txsecrets tests
[19:36] <ralsina> Can I get two quick linux reviews for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/ui_files_2/+merge/65388 ?
[19:46] <ralsina> alecu, nessita: ^ ? pretty please?
[19:46] <alecu> looking
[19:48] <dobey> +1
[19:48] <ralsina> alecu: thx!
[19:48] <ralsina> dobey: awesome
[19:49] <dobey> can i steal alecu after he does that review, for a bit? the txsecrets tests in sso are confusing me
[19:50] <ralsina> dobey: fine by me if alecu is willing
[19:52] <dobey> ok
[19:56] <alecu> ralsina, I see that you branch has pylint annotations. How are you running pylint on it?
[19:56] <dobey> alecu: have you a few minutes to help with that?
[19:56] <ralsina> alecu: manually
[19:56] <ralsina> alecu: u1lint ubuntuone_installer
[19:57] <alecu> ralsina, perhaps you should make that part of the run_tests.bat for the installer.
[19:57] <alecu> ralsina, anyway, approving.
[19:57] <ralsina> alecu: yes, have a bug for that
[19:57] <ralsina> alecu: thanks!
[19:57] <alecu> cool
[19:57] <alecu> dobey, tell me
[19:58] <dobey> alecu: so i'm working on fixing the properties issue in txsecrets (bug #800294), and running the tests i'm getting a few failures/errors, but can't really tell why
[19:58] <ubot4> Launchpad bug 800294 in ubuntu-sso-client (Ubuntu) (and 2 other projects) "Support new fdo secrets API property names (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/800294
[19:59] <dobey> hold on, phone
[20:02] <ralsina> I have a weird problem with https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/ui_files_2/+merge/65388  .. I can only set it to work in progress or merged
[20:02] <dobey> alright
[20:03] <dobey> alecu: these are the current errors i have: http://pastebin.ubuntu.com/630510/
[20:03] <dobey> alecu: i'm not sure why the first one is failing, it seems like it is expecting the wrong thing, from my reading of the code
[20:04] <dobey> ralsina: oh, right, one second, i need to fix up the reviewers
[20:04] <dobey> forgot to do that :)
[20:05] <alecu> dobey, is this happening on your new branch?
[20:05] <dobey> alecu: yes
[20:05] <dobey> ralsina: fixed; you should be able to set it now after you reload the page
[20:06] <alecu> dobey, do you want to push it, so I can take a look?
[20:06] <ralsina> dobey: thanks!
[20:07] <dobey> alecu: lp:~dobey/ubuntu-sso-client/new-kr-props
[20:13] <ralsina> No rush, trivial branch for review: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/stop_reactor/+merge/65391
[20:15] <dobey> ralsina: does super() not work right in Qt?
[20:16] <ralsina> dobey: I am old fashioned
[20:16] <dobey> well, you are writing Qt and Python, so yes :)
[20:20] <dobey> alecu: any ideas
[20:20] <dobey> ?
[20:20] <alecu> dobey, get_default_collection creates a new collection if it can't find it on the default path. The first test creates a sample collection on the default, then tests get_default_collection.
[20:21] <alecu> dobey, since the collection was already created at the start of the tests (before the first assert), calling get_default_collection should not create a new one.
[20:21] <alecu> dobey, so I think that testing twice for 1 is right.
[20:22] <dobey> alecu: but why would my changes affect that, given i'm not changing that path?
[20:23] <alecu> looking again.
[20:29] <alecu> dobey, I have not followed it properly, but I would suspect it's related to the splitting of LABEL_PROPERTY into ITEM_LABEL_PROPERTY and CLXN_LABEL_PROPERTY
[20:32] <ralsina> another trivial branch for review: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800346/+merge/65397
[20:33] <dobey> alecu: huh
[20:34] <dobey> ralsina: approved
[20:34] <ralsina> dobey: thanks!
[20:38] <alecu> ralsina, approved both
[20:38] <ralsina> alecu: thanks!
[20:38] <dobey> hmmm
[20:42]  * nessita is back
[20:42] <ralsina> hello nessita
[20:42] <dobey> alecu: i'm not sure, since i also updated the usage of that constant appropriately as well
[20:43] <ralsina> nessita: I looked and control panel does have the gui/qt/ui/__init__.py file you made me delete :-)
[20:44] <nessita> ralsina: it has the file but is not versioned
[20:44] <ralsina> nessita: you lost me
[20:44] <ralsina> apparently you just run into a hole in my bzr knowledge
[20:44] <nessita> I just got here
[20:44] <nessita> :-D
[20:45] <nessita> ralsina: hum, I see what you mean. Then you were right, somehow bzr told me is was not versioned but actually is
[20:45] <nessita> ralsina: sorry for the confusion
[20:45] <ralsina> nessita: no problem whatsoever
[20:46] <alecu> dobey, right. But I guess that the mocks rely on both being the same, for looking up the objects in their dicts
[20:46] <alecu> or something like that.
[20:47] <ralsina> yet another very simple review: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800330/+merge/65400
[20:47] <nessita> ralsina: can you please review https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/simpler-devices-backend/+merge/65368 ?
[20:47] <ralsina> nessita: sure, trade you ;-)
[20:47] <nessita> sure!
[20:48] <nessita> ralsina: are you using --fixes?
[20:48]  * nessita guesses not
[20:48] <ralsina> nessita: yes, unless I forgot in one branch
[20:48] <dobey> alecu: i haven't found anywhere that suggests that :-/
[20:48] <nessita> ralsina: the 800330 is not bind to the bug report, can you please ci --fixes --unchanged, please?
[20:49] <nessita> ralsina: and I'm not sure that we're having a GTK version of the installer, aren't we?
[20:49] <ralsina> nessita: we are probably never going to have one
[20:49] <ralsina> nessita: but better safe than sorry
[20:49] <nessita> ralsina: can we delete all the GTK specific bits?
[20:50] <nessita> we can add them later, and ideally in a way we ran tests for both all the time
[20:50] <ralsina> nessita: ok, file a bug and I will do it. I will still keep the directory structure so we can add a gtk/ later
[20:50] <ralsina> nessita: bug linked
[20:50] <nessita> ralsina: makes sense about the file dir. But the GTK bits please remove them in this branch
[20:50] <nessita> ralsina: since it will make the diff smaller ;-)
[20:51] <ralsina> nessita: ok
[20:51] <nessita> (is not like is big, but I see no point in adding stuff that we will not use)
[20:52] <ralsina> nessita: removed and pushed
[20:52] <nessita> thanks
[20:53] <nessita> ralsina: hey! do not assign me to bugs from the installer, assign yourself! :-P for example: bug #800284
[20:53] <ubot4> Launchpad bug 800284 in ubuntuone-windows-installer "logger.py is duplicated from the control panel (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/800284
[20:53] <ralsina> nessita: hey, you own logger.py ;-)
[20:53] <nessita> ralsina: nopes, you own installer till friday at least
[20:53] <ralsina> nessita: ok, I will reassign to me
[20:53] <nessita> ralsina: also, please be sure to not leave the bugs in NEW. So, please set importance and status to either TRiaged or In Progress
[20:54] <nessita> already changed assignee
[20:54] <nessita> ralsina: and also, to measure the work done/pending till Friday, we're tagging bugs with u1-zomg-windows, like I mentioned in the first email I send you last week
[20:55] <ralsina> nessita: ok, will tag
[20:55] <nessita> that way we can search globally and not only by project
[20:55] <dobey> grr, i don't understand why this is breaking :(
[20:55] <ralsina> I thought they changed to in progress when you attached a branch. Oh well.
[20:56] <dobey> ralsina: nope, but change to fix committed when tarmac lands branches that are attached to bugs
[20:56] <ralsina> dobey: ok
[20:56] <dobey> ralsina: so given the ideal velocity of our branches, the "in progress" is not as useful if you've already made the branch to fix it :)
[20:56] <ralsina> dobey: yeah, in an ideal world ;-)
[20:57] <dobey> well in an ideal world we wouldn't be touching windows :)
[20:57] <dobey> and i wouldn't be writing python ;)
[20:58] <nessita> ralsina: in the script in your last branch does: `which xvfb-run` u1trial --ignore-paths $QT_TESTS_PATH "$MODULE"
[20:58] <dobey> now why is this thing breaking :(
[20:58] <nessita> ralsina: I don't think we want to ignore the wt tests
[20:58] <nessita> qt*
[20:59] <ralsina> oops, deleted wrong line, I suppose
[20:59] <dobey> i don't think we want to run the tests on linux?
[20:59] <ralsina> dobey: there are no tests yet, but yes, they will have to run
[20:59] <dobey> ralsina: we'll have to run windows installer tests on linux?
[21:00] <ralsina> dobey: it's actually a setup wizard
[21:00] <dobey> right. for windows. :)
[21:00] <ralsina> dobey: should work just the same on Linux
[21:00] <nessita> dobey: no, for both
[21:01] <dobey> how many control panels do we need? :P
[21:01] <dobey> is it an installer or what?
[21:01] <nessita> ralsina: I would suggest to remove the definition of QT_TESTS_PATH altogether since we don t need that
[21:01] <ralsina> dobey: not a control panel. Just a setup wizard. You know they are not the same thing :-)
[21:01] <nessita> dobey: is a wizard to setup Ubuntu One
[21:01] <ralsina> nessita: makes sense
[21:01] <dobey> what does "setup" mean here?! install? sign up on sso?
[21:02] <nessita> dobey: you can see the wireframes between our (canonical) google docs
[21:02] <ralsina> dobey: choose what to sync, buy storage/streaming, sign in, a few other things. Check the workflow on gdocs
[21:02] <dobey> *facepalm*
[21:02] <nessita> dobey: we really need to get things moving on and we don't have time to argue, sorry
[21:03] <ralsina> dobey: not constructive. This has been discussed for months. Facepalms were only allowed until april.
[21:03] <nessita> dobey: you are welcome to send an email to the list, though
[21:04] <ralsina> nessita: removed the variable and pushed
[21:04] <nessita> ralsina: ack. Any news on my branch? :-)
[21:04] <nessita> (I'm depending on it)
[21:04] <ralsina> nessita: reading it
[21:04] <nessita> thanks!
[21:04] <ralsina> nessita: it's a tad longer than mine ;-)
[21:05] <ralsina> nessita: do you need any specific testing?
[21:05] <nessita> no, the next one will expose this in the IO
[21:05] <nessita> UI
[21:05] <ralsina> nessita: ok
[21:06] <nessita> ralsina: approved and globally approved (we decided with the rest of the windows team that trivial branches can land with one review)
[21:06] <ralsina> nessita: cool
[21:06] <ralsina> nessita: +1 on your branch
[21:06] <nessita> thanks!
[21:06] <ralsina> I just ran the tests and did a quick code review, though
[21:07]  * ralsina adds bugs for each page on the installer now
[21:18] <dobey> ah-ha
[21:18] <dobey> stupid string literals
[21:23] <mterry> If I wanted to ask U1Files to return a special error code for "out of space", where do I file that bug?
[21:28] <dobey> mterry: ubuntuone-servers i suspect (presuming you mean the REST API)
[21:29] <dobey> hrmm, so it seems like these properties changes work ok with gnome-keyring 2.x also
[21:30] <mterry> dobey, thanks; filed bug 800384
[21:30] <nessita> ralsina, alecu: do you know if mandel landed everything he had to? does he need reviews?
[21:30] <ubot4> mterry: Bug 800384 on http://launchpad.net/bugs/800384 is private
[21:31] <dobey> hrmm, and i wonder if i can make dnsmasq give out both ipv6 and ipv4 to the same MAC
[21:31] <ralsina> nessita: not sure. Don't remember him asking for reviews except one that chipaca was doing
[21:32] <ralsina> nessita: that was https://code.launchpad.net/~mandel/ubuntuone-client/use_txnamedpipes/+merge/65317 and it's merged now
[21:32] <nessita> right, he also needed to propose the start script
[21:33] <ralsina> nessita: checking...
[21:33] <ralsina> nessita: that one is approved
[21:33] <nessita> Chipaca`: any idea if the start script for syncdaemon, from mandel branch, is working? asking differently, did he request a review from you for that branch?
[21:33] <ralsina> nessita: https://code.launchpad.net/~mandel/ubuntuone-client/provide_windows_start_script/+merge/65376
[21:33] <ralsina> but... HAS NO COMMIT MESSAGE
[21:34] <ralsina> oops, sorry about the capshouting
[21:35] <nessita> ralsina: let me set it
[21:35] <alecu> ralsina, nessita: I've just set it
[21:35] <nessita> oh
[21:35] <alecu> nessita, you won.
[21:35] <nessita> oh
[21:36] <ralsina> jajaja
[21:36] <nessita> alecu: did you explain to mandel that CredentialsManagementTool is not meant to be used like that?
[21:47] <nessita> ralsina: I hope you don't get tired of this but, you're referencing "2nd page of the installer design" in the bug reports (which are publics) and the design specs are not visible
[21:47] <ralsina> nessita: I intend to fill those up with screenshots from the wireframe when I start them
[21:47] <ralsina> nessita: I had to file 14 of those :-(
[21:48] <nessita> ralsina: is there any chance to not reference the spec but to describe very shortly what the tab does? Example: "Show licence agreement on 2nd tab, cancel if not accepted"
[21:48] <nessita> "Show folder list so user can subscribe/unsubscribe as s/he wishes"
[21:48] <nessita> etc?
[21:48] <ralsina> nessita: yes there is a chance
[21:48] <ralsina> nessita: I'll do it, even
[21:48] <nessita> thanks
[21:48] <nessita> ralsina: no need to fix what's done
[21:49] <nessita> ralsina: only what's coming next
[21:49] <ralsina> nessita: so  only 13 of those ;-)
[21:49] <nessita> :-D
[21:49] <ralsina> nessita: don't wprry I will make all the bug reports pretty
[21:49] <nessita> I'm glad I noticed soon enough!
[21:49] <nessita> ralsina: or you can make teh bug reports as you work on the tabs
[21:50] <ralsina> nessita: I wanted to create them even if as placeholders so there was a visible goal
[21:50] <nessita> right, makes sense
[21:50] <ralsina> nessita: I can flesh them up as I work on them though
[21:50] <nessita> right
[22:10] <ralsina> nessita: what's the proper way to start the control panel? I am guessing it's not Popen(['/usr/bin/control-panel-gtk'])
[22:10] <nessita> ralsina: start it from where?
[22:10] <ralsina> nessita: the installer, after it finishes
[22:10] <ralsina> it shows a button saying "start the dashboard"
[22:11] <nessita> then yes, subprocess.Popen, but you can't hardcode the abspath
[22:11] <nessita> assuming the controlpanel is installed in both systems, they should be in the PATH (the .msi should take care of that in windows)
[22:11] <ralsina> I can use shell=True... but that's not usually recommended
[22:11] <ralsina> ok
[22:11] <nessita> ralsina: why would you use shell=True?
[22:12] <ralsina> nessita: because if you don't do that, the PATH is ignored
[22:12] <nessita> lies
[22:12] <nessita> :-)
[22:12] <nessita> In [1]: import subprocess
[22:12] <nessita> In [2]: subprocess.Popen(('ubuntuone-control-panel-gtk',))
[22:12] <nessita> works
[22:12] <nessita> it does not work on windows, assuming the panel is in the PATH env?
[22:13]  * ralsina checks
[22:13] <ralsina> shocking! ;-)
[22:13] <ralsina> nessita: should be exactly the same on windows. Seems I was just wrong. It happens :-)
[22:14] <nessita> yes, it happens. Anyways, we should confirm this works on W
[22:14] <ralsina> OTOH, the *name* ubuntuone-control-panel-gtk is platform dependent (not really but kinda)
[22:14] <ralsina> yes, works on windows
[22:15] <nessita> right
[22:15] <nessita> ralsina: you need to use ubuntuone-control-panel-qt on linux and ubuntuone-control-panel-qt.exe on windows
[22:15] <ralsina> we should use alternatives to set a ubuntuone-control-panel
[22:15] <nessita> that is what you mean?
[22:16] <ralsina> no, the "-gtk" part is currently linux only
[22:16] <nessita> right, that is why I said -qt
[22:16] <ralsina> ok then, yes that.
[22:16] <ralsina> eventually you can do -qt on linux too, of course
[22:17] <ralsina> Can I connect a branch to a bug in a way that doesn't say "this branch fixes the bug"?
[22:17] <nessita> ralsina: no... sorry
[22:17] <ralsina> nessita: no problem
[22:17] <nessita> you need to manually set it to In progress
[22:17] <nessita> or create finner grained branches or bugs
[22:18] <nessita> bugs, I mean
[22:23]  * alecu heads for the pediatric. bbl
[22:28] <ralsina> last review request of the day: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800383/+merge/65416
[22:32] <dobey> https://code.launchpad.net/~dobey/ubuntu-sso-client/new-kr-props/+merge/65419
[22:32] <dobey> my review request :)
[22:33] <nessita> ralsina: you need to add tests :-)
[22:33] <ralsina> nessita: yes i do!
[22:34] <nessita> great! we; re in sync then
[22:34] <dobey> ralsina: needinfo about the subprocess.Popen bit :)
[22:34] <ralsina> dobey: such as? ;-)
[22:34] <dobey> Should this not be ubuntuone-control-panel-qt, given that we're running it from a qt gui? Also, should we not rely on IPC activation to just start the correct one for the user's environment, instead of running it directly?
[22:34] <nessita> ralsina: our policy is to add tests for all the code we write, not about what we do in designer. Anyways, we don't need to add any complex bit in designer other than layout and widgets packing
[22:35] <ralsina> nessita: there is no logic in designer
[22:35] <nessita> dobey: for now we will be running it directly, since we won't be doing a IPC activation for QT
[22:36] <nessita> ralsina: right, which is good
[22:36] <nessita> I was explaining the policy
[22:36] <nessita> dobey: I agree we should open the -qt panel
[22:36] <ralsina> nessita: so yes, I will add tests, but I need to get a handle on how and how much and "have the time" :-(
[22:36] <nessita> ralsina: hem...
[22:37] <nessita> ralsina: let's drop the tests when we really need to
[22:37] <nessita> ralsina: I think that today, we can ask you to write tests :-) (still)
[22:37] <ralsina> nessita: ok, will try to do it tonight late
[22:37] <nessita> ralsina: thanks, you can check our current test suite to have a guide
[22:37] <nessita> they are not long nor complicated
[22:38] <nessita> but they are a safety net that I think is very important for "it just works"
[22:38] <dobey> my branch already has tests and i updated them ;)
[22:38] <ralsina> nessita: agreed
[22:39] <ralsina> ok, time to be a dad
[22:39] <ralsina> dobey: I will try to do a review later, sorry :-(
[22:39] <dobey> no worries. i'm happy i got the branch working ;)
[22:40] <ralsina> :-D
[22:40] <thisfred> oops, dogs need to be walked, later all
[22:40] <ralsina> see you later/tomorrow all!
[22:40] <dobey> well i'm off. have a good evening all
[22:40] <nessita> ralsina: wait
[22:40] <nessita> ralsina: if you eod, please send the report
[22:41] <nessita> is very important, we're very very tight with the schedule
[22:41] <nessita> dobey: I will review your branch pretty soon