[01:18] <karni> alecu: I'll be happy if you would take a look at this for me lp:~karni/+junk/ubuntu-sso-java-api and let me know what you think/comments. It's very fresh. The API is pretty straight forward, but I'll make a sample android app anyway. As far as SSO is concerned, it'll be an Android library using that ubuntu-sso-java-api.
[01:18] <karni> CardinalFang: Whenever you have time, I'll be happy to hear your thoughts on lp:~karni/+junk/ubuntu-sso-java-api
[01:19] <CardinalFang> karni, I'll look tonight or after a sleep.
[01:19] <karni> CardinalFang: Awesome. No rush.
[01:20] <karni> Man time passes by fast. And MAN it's hot in here!
[01:20]  * karni opens the window winder
[01:25] <alecu> karni, looks very nice.
[01:25] <alecu> karni, one comment regarding pingUbuntuOne
[01:26] <alecu> perhaps it should be moved out of the SingleSignOnAPI
[01:27] <alecu> I think it should reside in a class that inherits from UbuntuSingleSignOnAPI, in a com.ubuntuone package
[01:27] <alecu> since it's very specific to our use case.
[01:27] <karni> alecu: yes, I will move it out definitely
[01:27] <karni> alecu: and it uses HMAC singer, whilst SSO uses Plaintext singer
[01:27] <alecu> signer, right.
[01:27] <karni> alecu: btw thanks :)
[01:27] <karni> haha
[01:27] <karni> signer :)
[01:28] <karni> at 2:30 AM I feel like singing! ;)
[01:28] <alecu> karni, I've only looked at the SingleSignOnAPI interface, though :-)
[01:28] <alecu> hahahaa
[01:28] <karni> alecu: haha :) cool. take your time, I just wanted to update you I'm making progress with it.
[01:29] <alecu> karni, another thing: perhaps pingUbuntuOne should be called silently, by the validateEmail in the UbuntuOne class
[01:29] <karni> alecu: upon success. good idea :)
[01:29] <alecu> karni, so it gets called automatically and the user of the library does not need to remember to do it.
[01:29] <alecu> yes.
[01:29] <karni> alecu: however, it may be the case the email is properly validated, but the ping fails (say, U1 is down ;) )
[01:30] <karni> alecu: what then? should we throw?
[01:30] <alecu> karni, good point.
[01:30] <karni> alecu: we have to be careful. I wanted to include the ping to make our life easier, but, like you notied, it's not integral part of SSO itself.
[01:30] <alecu> karni, perhaps we should ask nessita tomorrow for the details of it, to see how the ubuntu-sso-client does it.
[01:31] <karni> alecu: sure. I referenced ubuntu-sso-client code quite a few times, but I don't recall when/how ping details.
[01:31] <karni> alecu: validate_email() does not call ping directly
[01:32] <karni> in ubuntu-sso-client
[01:32] <karni> probably somewhere higher
[01:32] <karni> higher as "not in accounts.py" :D
[01:32] <alecu> ok
[01:34] <karni> alecu: it pings upon successful login ( credentials.py : _login_success_cb() )
[01:34] <alecu> oh, right!
[01:35] <alecu> karni, you should definitely ask nessita about that, because she'll remember the details
[01:35] <karni> alecu: ok :)
[01:35] <alecu> karni, I think it had to do with updating the sso pinged credentials on every login... or something. but it makes sense to do it there.
[01:36] <karni> alecu: yeah, I'll definitely ask her to be sure
[01:36] <karni> I don't know the details.
[01:36] <karni> alecu: We're still caching SSO tokens in app servers, aren't we?
[01:36] <karni> alecu: I believe this is what we want to fix (avoid) in the future.
[01:37] <karni> alecu: But that doesn't concern us (us playing with Android apps)
[01:37] <alecu> karni, we've been doing it at least for the past six months, and we'll probably be doing it in the foreseeable future.
[01:37] <karni> right
[03:49] <tntc> hey guys. I'm having an issue with playlists on ubuntuone music for android. Every time I tap the playlist button, I get an error. "A network error occurred. Try again later."
[03:49] <tntc> everything else works. I can view my music library and stuff, and play music
[03:50] <tntc> any thoughts on what could be causing this?
[05:16] <karni> tntc: Hi!
[05:16] <karni> tntc: So, we're having problems with the database that backed this functionality.
[05:16] <karni> tntc: The programmer who was looking into it left just a while ago
[05:17] <karni> tntc: But I'll ask him tomorrow if there's anything new on the subject.
[05:17] <karni> tntc: Sorry for any inconveniance you have due to this issue!
[09:27] <duanedesign> morning all
[09:30] <JohnTeddy> Is this a beta program?
[09:33] <duanedesign> JohnTeddy: some clients are, like the windows client. The Linux client is not. afaik.
[10:00]  * duanedesign wonders if mr. rye is around?
[10:00] <rye> duanedesign, yes, today i am around
[10:00] <JohnTeddy> duanedesign: I mean server side.
[10:01] <JohnTeddy> I looked on the status page, there are service disruptions and service outages.
[10:02] <duanedesign> rye: hope all is well today. Trying to track the possible reason for an error. Thought I might ask if you had seen a common reason for this. http://ubuntuforums.org/showthread.php?t=1781451
[10:03] <duanedesign> JohnTeddy: i read their was a problem with a database that backed a particular function causing a temporary outage.
[10:29] <duanedesign> brb
[11:19]  * mandel getting some coffee 
[11:30]  * mandel back
[11:39]  * duanedesign waves at mandel 
[11:40] <mandel> duanedesign: hello :)
[12:22]  * mandel walking dog
[12:26]  * fagan break 
[12:29] <nessita> hello everyone!
[12:29] <fagan> yo nessita
[12:30] <nessita> fagan: you're awake! :-P
[12:30] <fagan> nessita: yeah for hours :)
[12:30] <nessita> lol
[12:32] <facundobatista> Hola nessita
[12:32] <nessita> hola facundobatista
[12:51] <duanedesign> rye: /5
[12:51] <duanedesign> oops
[12:53] <rye> duanedesign, so, i downgraded one of my system to natty default/updates and my evolution is working properly. I wonder whether the user is using nightlies
[13:06]  * mandel early lunch
[13:18] <ralsina> hola
[13:19]  * ralsina is officially an old man. He fell down on the street last night
[13:21] <fagan> awh ralsina you ok?
[13:22] <ralsina> Anyway, I didn't break my hip, but I twisted my knee. So I have a pressure bandage, taking some magic pain pill and can't walk. Yay.
[13:22] <ralsina> fagan: worse case, I'll use a peg leg and live a pirate's life. Best case it will stop hurting in a few hours.
[13:23] <ralsina> BTW: jumping up to my 1st floor home on one leg... not as easy as it sounds
[13:23] <fagan> pirate legs are cool
[13:23] <ralsina> fagan: but they make you use those rubber thingies at the bottom soyou don't scratch the floor and kills all the tap dance effect
[13:24] <fagan> no fun :/
[13:27] <duanedesign> rye: hmmm. Ok, thank you! All the bug reports I can find with this error are Fix Released...
[13:28] <ralsina> ok, back to coding what I should have coded last night :-(
[13:30] <nessita> can I have a couple of reviews for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/greet-and-report-quota/+merge/65598 ?
[13:31]  * thisfred is on it
[13:31] <nessita> ralsina: also, question. Is there any easy way to do transparent overlays in QT? (if you need to google, don't, I'm asking to the top of your head)
[13:31] <nessita> thisfred: thanks!
[13:32] <thisfred> wow, we can handle YiBs! :)
[13:36] <ralsina> nessita: yes there is, but I can't give you a recipe. Look for setMask in the docs
[13:37] <ralsina> nessita: reviewing...
[13:37] <ralsina> nessita: is it for the spinner thingy? I need one too for the wizard
[13:38] <ralsina> nessita: OTOH I may not have understood what you want
[13:39] <nessita> ralsina: if you look lisete's windows share, go to:
[13:39] <nessita> U1_design_work / Windows / client / PSD :
[13:39] <nessita> and see:
[13:39] <nessita> win_client_008_please_wait.png
[13:39] <nessita> win_client_008_please_wait002.png
[13:40] <nessita> ralsina: she proposed those, and before agreeing to that, I wanted to see if there is a way to implement it
[13:40] <nessita> ralsina: I'll google
[13:40] <nessita> and see if I can create a widget
[13:40] <ralsina> looks like I don't have lisette's only Ivanka and Claire's
[13:40] <ralsina> lisette: ping
[13:40] <nessita> ralsina: did you subscribed the share?
[13:40] <nessita> ralsina: go to the linux control panel and subscribe it
[13:40] <ralsina> nessita: I'll check
[13:41] <nessita> (maybe you have to accept it first?_
[13:41] <nessita> )
[13:41] <lisette> ralsina: hi
[13:41] <ralsina> lisette, I don't seem to have your share on Ubuntu One, could you re-invite me?
[13:41] <ralsina> nessita: nope, no email about it either
[13:42]  * ralsina may have lost it
[13:42] <lisette> ralsina: sure, i will uninvite and reinvite you :)
[13:42] <ralsina> lisette: cool, thx
[13:43] <ralsina> lisette: got it, thanks!
[13:43] <lisette> ralsina: done
[13:44] <facundobatista> nessita, dobey, I fixed the problem of ubuntuone-client in Oneiric, the one from bug #798979
[13:44] <ubot4> Launchpad bug 798979 in ubuntuone-client (Ubuntu Oneiric) (and 2 other projects) "ubuntuone-syncdaemon crashed with KeyError in add_watch(): '/home/caravena/Ubuntu One' (affects: 7) (dups: 7) (heat: 68)" [High,Triaged] https://launchpad.net/bugs/798979
[13:45] <nessita> facundobatista: yey?
[13:45] <ralsina> nessita: the second is really easy
[13:45] <nessita> ralsina: from my pov both are the same
[13:45] <facundobatista> nessita, dobey, note that after the quick fix it now fails with NoAccessToken: CredentialsNotFound
[13:46] <ralsina> nessita: basically, disable the whole tab, add a child widget to the tab (the square), place it in the middle, that's it
[13:46] <ralsina> nessita: the first one is the same, but don't disable, make the child widget cover the whole tab
[13:46] <nessita> ralsina: ack, I'll try. I'll build the widget so you can later reuse
[13:47] <ralsina> The child widget can be just a plain QLabel with a QMovie in it
[13:47] <nessita> ralsina: so we don't duplicate work
[13:47] <ralsina> nessita: here's a C++ example http://www.developer.nokia.com/Community/Wiki/CS001434_-_Creating_a_loading_animation_with_GIF,_QMovie,_and_QLabel
[13:48] <dobey> facundobatista: that's fine. i'm working on a fix for that :)
[13:49] <ralsina> nessita: but that seems quite complicated for what it does, though
[13:50] <ralsina> standup in 10' people
[13:51]  * mandel back
[13:51] <ralsina> nessita: +1 on greet-and-report-quota
[13:52] <nessita> thanks!
[13:53] <facundobatista> dobey, great, thanks
[13:57] <fagan> standup in  3
[13:59] <alecu> hello!
[13:59] <fagan> yo alecu
[13:59] <fagan> moi
[14:00] <facundobatista> Hola alecu
[14:01] <nessita> me
[14:01] <fagan> mandel, thisfred, dobey, ralsina, alecu standup
[14:01] <ralsina> me
[14:02] <mandel> me
[14:02] <nessita> alecu, dobey?
[14:02] <nessita> thisfred: ?
[14:02] <dobey> me
[14:02] <thisfred> me
[14:02] <alecu> me
[14:02] <fagan> ok go me
[14:02] <fagan> WORK IN PROGRESS
[14:02] <fagan> rst port of the FAQ pages
[14:02] <fagan> Blocked
[14:02] <fagan> * nope
[14:02] <fagan> nessita: go
[14:02] <nessita> DONE: bug #800683, failed attempts to have syncdaemon running on win XP due to SSO failures, meetings
[14:02] <nessita> TODO: Review Lisette's proposal for "loading" messages, try to have XP working with SSO? nail some other UI bug?
[14:02] <nessita> BLOCKED: freaking out
[14:02] <nessita> NEXT: ralsina
[14:02] <ubot4> Launchpad bug 800683 in ubuntuone-control-panel "Storage use and user greetins should be shown in the QT control panel (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/800683
[14:03] <ralsina> DONE: Windows catchup call, Windows+design call, bunch'o'reviews, fixed bug #800381 (needs 2 reviews), fixed #800715 (needs 2 windows reviews), did most of bug #800359 (SSO on wizard)
[14:03] <ralsina> TODO: Finish the SSO on wizard integration, start syncdaemon on wizard stuff, hopefully get that mostly done, then whatever I can fit in.
[14:03] <ralsina> BLOCKED: not yet, but if syncdaemon doesn't work on windows today I will be
[14:03] <ralsina> NEXT: mandel
[14:03] <ubot4> Launchpad bug 800381 in ubuntuone-windows-installer "Add "sync now or later" page to the installer (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/800381
[14:03] <ubot4> Launchpad bug 800359 in ubuntuone-windows-installer "Add sign in page to the installer (affects: 1) (heat: 6)" [Undecided,Triaged] https://launchpad.net/bugs/800359
[14:03] <mandel> DONE: Partially complited all tests for window_sdtool. Looked at my windows XP vm and updated the setup env to later test txnamedpipes on it.
[14:03] <mandel> TODO: Complete the test and provide them as an example for nessite to use sdtool.
[14:03] <mandel> BLOCKED: no
[14:03] <mandel> COMMENT: Will be here longer than usually so I can help
[14:03] <mandel> dobey: go
[14:03] <dobey> λ DONE: update for amz on server, more work on bug #800294, closed old sso milestones
[14:03] <ubot4> Launchpad bug 800294 in ubuntu-sso-client (Ubuntu) (and 2 other projects) "Support new fdo secrets API property names (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/800294
[14:03] <dobey> λ TODO: finish bug #800294, fix more stuff, chase people
[14:03] <dobey> λ BLCK: None.
[14:04] <dobey> thisfred: your turn
[14:04] <dobey> la la la
[14:05] <thisfred> DONE: Rethinking the launcher and doing some experiments with counters/quicklists TODO: turn that thinking into bugs and branches BLOCKED: nope NEXT: alecu
[14:05] <alecu> DONE: calls and more calls, worked on bug #800669, found bug #800887, a few reviews
[14:05] <alecu> TODO: calls, debug CredentialsManagementTool
[14:05] <alecu> BLOCKED: no kinder still; but less planned interruptions than yesterday
[14:05] <alecu> NEXT!
[14:05] <thisfred> sry
[14:05] <ubot4> Launchpad bug 800669 in ubuntu-sso-client "InsecureJelly exception thrown when SD requests credentials (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/800669
[14:05] <ubot4> Launchpad bug 800887 in ubuntu-sso-client "UbuntuSSOClient fails when starting the SSO process (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/800887
[14:05] <alecu> thisfred, "doing some experiments with counters/quicklists" <- cooool!
[14:06] <thisfred> alecu: yeah, for new udfs I think counters may make more sense than the messaging menu for instance
[14:06] <ralsina> thisfred: nice!
[14:06] <thisfred> and the quicklists for all subscribed folders, I'm thinking
[14:07] <nessita> any closing comments?
[14:07] <fagan> nope
[14:08] <thisfred> Be excellent to each other!
[14:08] <dobey> looking for closure?
[14:08] <fagan> ok dont be nice be excellent
[14:08] <ralsina> dobey, thisfred we need to talk about keeping u1 working on oniric, could you guys give me a status update on that by email?
[14:08] <fagan> ralsina: its broken on my machine in 11.10
[14:08] <thisfred> ralsina: uh ok: I have not been able to install O yet
[14:09] <thisfred> will try again on the laptop
[14:09] <ralsina> I mean talk between you then send me a short list of things that are completely broken. Ok, thisfred, then just dobey I guess ;-)
[14:09] <ralsina> or if you can get it installed today, send me the report late today
[14:09] <dobey> ralsina: uh, after i fix these tests again in my branch, and it gets approved/landed, we should be good to go if facundobatista's fix has already landed
[14:09] <thisfred> sure
[14:10] <ralsina> dobey: cool then, it should be a very short report
[14:10] <ralsina> dobey: also we need to squeeze "port everything that stays gtk to gtk3" somewhere in the next 4 or 5 months :-(
[14:11] <ralsina> and from pygtk to the (currently semibroken, right) gtk-via-introspection-thing
[14:11] <dobey> which is mostly not really an issue at this point
[14:11] <dobey> couple of minor things to change, but we should be good for the most part
[14:12] <ralsina> dobey: cool, not bad there then. Hopefully things won't diverge too quickly
[14:13] <dobey> the only big thing with that is the banshee/rhythmbox issue
[14:13] <dobey> because banshee is not gtk3 yet, and rbox is
[14:13] <nessita> ralsina, mandel, alecu, Chipaca: mumble in 2 minutes?
[14:13] <thisfred> ralsina: 4 or 5 months? I thought we had like 3 more weeks or so :)
[14:13] <ralsina> nessita: ack
[14:13] <Chipaca> nessita: no can do, got the web thing in 2 minutes
[14:13] <ralsina> thisfred: well... that's one way to look at it. gtk2 is leaving the CD n the next cycle
[14:13] <mandel> nessita: at 15 pass, sure
[14:13] <dobey> thisfred: well, more like 2 months
[14:13] <nessita> Chipaca: ah, ok. How long then? we can reschedule?
[14:14] <Chipaca> I've got the checkpoint on my calendar at :30
[14:14] <Chipaca> that's a bit tight, i'd rather :45
[14:14] <ralsina> thisfred: OTOH the nautilus plugin probably will have to be ported in three weeks yes
[14:14] <nessita> Chipaca: ok, :45 it is
[14:14] <dobey> and there's that whole *other* issue to deal with
[14:14] <nessita> mandel, alecu, ralsina: mumble at :45  (in 30 minutes)
[14:14] <dobey> ralsina: the nautilus plug-in already works, it just gets installed to the wrong directory, i think
[14:14] <thisfred> dobey: you mean the shiv? ;)
[14:14] <ralsina> nessita: ack^2
[14:15] <nessita> :-)
[14:15] <dobey> thisfred: yes
[14:15] <alecu> ack
[14:15] <mandel> nessita: sure
[14:15] <dobey> shivs and shanks
[14:15] <ralsina> dobey: well, that is good news
[14:15]  * ralsina should get oneiric installed too :-(
[14:16] <facundobatista> nessita, dobey, https://code.launchpad.net/~facundo/ubuntuone-client/avoid-double-watch/+merge/65661 (feel free to review)
[14:19] <dobey> facundobatista: interesting diff. :) are there no unit tests for that block of code?
[14:19] <facundobatista> dobey, it's just a removal of a duplicated line... but the duplicated line is not even in that file
[14:20] <facundobatista> (this is just dirtiness left ages ago, when VM took the responsibility on setting up 'root')
[14:20] <dobey> right
[14:20] <alecu> mandel, any ideas on this? bug #801145
[14:20] <ubot4> Launchpad bug 801145 in ubuntu-sso-client "I won't stop right on windows/txnp (affects: 1) (heat: 6)" [Critical,Confirmed] https://launchpad.net/bugs/801145
[14:21] <dobey> facundobatista: approved
[14:21] <mandel> alecu: let me take a look
[14:22] <dobey> ralsina: ^^ one branch down for oneiric :)
[14:22] <ralsina> dobey: yay!
[14:23] <facundobatista> dobey, thanks
[14:24] <mandel> alecu: the bug is in line 56 of bin/windows-ubuntu-sso it is telling the reactor to stop when it should be telling that to the QApplication and not the reactor
[14:24] <mandel> alecu: shutdown function here: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntu-sso-client/trunk/view/head:/bin/windows-ubuntu-sso-login
[14:24] <alecu> mandel, nice, thanks
[14:24] <mandel> alecu: np
[14:27] <ralsina> mandel: I am integrating the SSO into the wizard and it is working, but I have the strange feeling that I am using it completely wrong. Could you take a quick look at https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800359 ?
[14:28] <mandel> ralsina: sure,, on it
[14:29] <ralsina> mandel, basically http://bazaar.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800359/view/head:/ubuntuone_installer/gui/qt/gui.py
[14:31] <mandel> ralsina: looks good to me, you are passing the controller to the ui so that it hooks it up, that is the idea
[14:32] <ralsina> mandel: ok
[14:32] <ralsina> mandel: I am not really happy because I am putting lots of logic in something that depends on Qt but well, it's much harder the other way around.
[14:32] <mandel> ralsina: what do you mean?
[14:33] <ralsina> oh, wait, all the controller stuff in sso is qt-specfic! Nevermind :-)
[14:35] <facundobatista> dobey, "There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions."
[14:35] <facundobatista> dobey, and that's only because nessita gave me an approve after you approved the MP
[14:36] <facundobatista> dobey, I'm approving the MP again... but it seems that Otto is wrong there
[14:37]  * nessita wanted to help
[14:37] <mandel> ralsina: that is the entire point of the controller, they have no notion of the framework, they just want to add cb to the signals :)
[14:38] <ralsina> mandel: cool, hacking it some more then ;-)
[14:39] <dobey> facundobatista: no i think what happened was that the empty commit you added for --fixes showed up after i'd approved the branch (so the old revision was approved, and not the new), and launchpad was being a bit slow, and i wasn't expecting another revision to show up :)
[14:39] <dobey> nessita: had nothing to do with your +1
[14:39] <nessita> ok
[14:40] <facundobatista> dobey, nop, my empty commit is 22 minutes ago, and your approve is 18 minutes ago
[14:40] <dobey> facundobatista: yes, but that has nothing to do with when launchpad actually completed the rescanning
[14:41] <facundobatista> dobey, mmm... and Otto checks when the scanning was done, and not when the commit was done?
[14:41] <dobey> facundobatista: if the lp page had no idea of the second commit at the time, then when i approved, it couldn't have chose the later revno, but only the latest one it knew at the time.
[14:42] <dobey> facundobatista: tarmac just tries to merge the revision that is approved in launchpad. if that revision is not the tip of that branch, it complains
[14:42] <facundobatista> dobey, ok
[14:43] <dobey> facundobatista: and launchpad can be slow at times, and it doesn't help when unexpected revisions pop up :)
[14:43] <dobey> HUZZAH!
[14:43] <dobey> PASSED (skips=1, successes=494)
[14:46] <dobey> facundobatista: also, there are two rescan processes. the rescan of the branch for the bracnh data page in lp, and the rescan/regeneration of the diff for the merge proposal. and the merge proposal one happens after the branch one, and is the one we have to wait for, so that the revisions are all up to date there.
[14:47] <dobey> nessita: can you re-review https://code.launchpad.net/~dobey/ubuntu-sso-client/new-kr-props/+merge/65419 please? :)
[14:47] <alecu> nessita, mandel, ralsina: I see that Chipaca is already on our mumble channel
[14:47] <alecu> shall we?
[14:47] <adorilson> rye: hi
[14:48] <ralsina> ok, let's!
[14:48] <Chipaca> it's :45 :)
[14:48] <Chipaca> bah, it was when i mvoed in
[14:48] <adorilson> can you help me with this  https://wiki.ubuntu.com/UbuntuOne/RunClientFromTrunk ?
[14:48] <rye> adorilson, hi
[14:49] <rye> adorilson, hm, this is first time i see this page but make install will most likely not work
[14:49] <rye> adorilson, it can be ran w/o installation, that's what chicharra team does, actually
[14:50] <dobey> hrmm, yeah, i'd avoid the make install bit there
[14:50] <rye> Thanks to Roman??? Hmmmm
[14:51] <adorilson> rye: someone told me you had written this page. did not you?
[14:51] <dobey> maybe he was talking about Pilot
[14:51] <dobey> i don't think rye wrote that page :)
[14:52] <dobey> at least, i don't think he's crazy enough yet to be thanking himself on his own wiki pages
[14:52] <thisfred> hmm, update-manager fails wil an OSError (No such file or directory) ...
[14:53] <rye> adorilson, i am listed there as "Thank you" but i don't recall having the discussion of running the client from trunk, other than that it is really simple - bzr fetch for protocol and client, build client specifying the protocol location and then run the client specifying correct PYTHONPATH
[14:54] <thisfred> and now, my laptop is AGAIN in limbo between natty and oneiric
[14:54] <rye> facundobatista, by the way, i have now a test client (natty, latest updates, no nightlies) that cannot upload flv file because it claims ubuntuone.SyncDaemon.StorageClient - TRACE - start - processMessage: id: 13 type: ERROR error {   type: UPLOAD_CORRUPT   comment: "Deflated size does not match hint." }
[14:55] <facundobatista> rye, size?
[14:59] <rye> facundobatista, 96380073 bytes, BUT, this is completely different to my current issue of 180Mb file which keeps being uploaded on 100% and hangs, this just fails with upload corrupt and requires client restart to try uploading again
[14:59] <facundobatista> rye, and it always happen?
[15:00] <facundobatista> verterok, ^ we did have an issue with persistent corruptness in resumable, is it fixed now?
[15:00] <adorilson> rye, see this http://paste.ubuntu.com/631200/ please
[15:00] <verterok> facundobatista: yes, we have...and isn't fixed yet
[15:01] <verterok> rye: could you add the node details to bug #778805
[15:01] <ubot4> verterok: Bug 778805 on http://launchpad.net/bugs/778805 is private
[15:01] <verterok> ?
[15:01] <facundobatista> verterok, ok, thanks
[15:01] <verterok> rye: upload_id, share_id, node_id and hash please :)
[15:04] <rye> verterok, added
[15:04] <verterok> rye: thanks!
[15:05] <rye> adorilson, apt-get install gobject-introspection
[15:07] <dobey> hmm
[15:15]  * fagan break for an hour
[15:16] <fagan> joshuahoover: Looks like ill take a long day to get this done. I have a few done now but there are good few pages
[15:16] <joshuahoover> fagan: ok, thanks for the update...can you make sure you commit what you have done to your branch by eod (for you)?
[15:17] <fagan> joshuahoover: sure will do, ill hang around till around 9 UTC id say.
[15:17] <joshuahoover> thanks :)
[15:17] <dobey> alecu: fix the lint warnings before setting back to approved!
[15:19] <adorilson> rye: installing. but I need to tell a secret: I'm on Fedora 15
[15:20] <dobey> adorilson: it may be prudent to make RPMs in proper order :)
[15:21] <rye> adorilson, another thing is that you will need to have ubuntu-sso package too since syncdaemon depends on it to get the credentials
[15:21] <dobey> well, will need a lot of things
[15:21] <adorilson> dobey: I searched, but I dont found ubuntuone's RPMs
[15:22] <rye> adorilson, or, if you like hack-driven approach to make it work first and think how make it better later you may want to use the command line script to get the credentials from Ubuntu SSO and put them to oauth= config variable
[15:22] <dobey> adorilson: right. keyword in my statement was "make" :)
[15:25] <adorilson> dobey: sure. but I dont have a minimal idea how to make RPMs
[15:26] <adorilson> rye: gobject-introspection is already installed.
[15:27] <adorilson> rye: any ideia?
[15:29] <rye> adorilson, do you have pkg-config? try pkg-config  --print-errors "gobject-introspection-1.0" --modversion
[15:31] <adorilson> rye
[15:31] <adorilson> $ pkg-config  --print-errors "gobject-introspection-1.0" --modversion
[15:31] <adorilson> Package gobject-introspection-1.0 was not found in the pkg-config search path.
[15:31] <adorilson> Perhaps you should add the directory containing `gobject-introspection-1.0.pc'
[15:31] <adorilson> to the PKG_CONFIG_PATH environment variable
[15:31] <adorilson> No package 'gobject-introspection-1.0' found
[15:32] <alecu> dobey, great, thanks.
[15:32] <verterok> rye: one way to workaround the upload corrupt bug, is to move the file out of u1, wait for the client to delete the file on the server, and move it back
[15:32] <rye> verterok, this file has not been uploaded to the server for this account
[15:33] <verterok> rye: the file was created, but not uploaded
[15:33] <verterok> rye: the "node" exists in the server, but with no content
[15:33] <adorilson> rye: gobject-introspection version is 0.10.8
[15:33] <verterok> rye: moving the file out of u1 will trigger a unlink of the node, so the stalled upload will be cleanedup
[15:33] <dobey> adorilson: you need the -devel packages of things
[15:35] <adorilson> dobey: installing gobject-introspection-devel...
[15:37] <rye> verterok, RROR error {   type: UPLOAD_CORRUPT   comment: "Deflated size does not match hint."
[15:38] <rye> verterok, the file is already uploaded under a different user
[15:38] <dobey> hrmm
[15:38] <verterok> rye: if the same file is already uploaded it shouldn't upload it again
[15:38] <verterok> rye: magic uploads!
[15:39] <verterok> rye: so, it might be in a different shard
[15:39] <rye> verterok, the original file was uploaded this february, before magic
[15:39] <verterok> rye: ah, ok
[15:39]  * alecu will be afk for 30'
[15:40] <verterok> rye: try moving it out of u1, wait for the client to delete/unlink it, and move it back
[15:41] <rye> verterok, for the original account?
[15:43] <verterok> rye: from the account you'r getting the upload corrupt error
[15:43] <adorilson> rye, dobey: what is lndir ?
[15:44] <rye> verterok, already done that, unlink sent to the server, sd got IDLE, moved the file back in... UPLOAD_CORRUPT
[15:45] <verterok> rye: it tried to resume the upload?
[15:45] <verterok> rye: look for BEGIN_UPLOAD message in the logs, offset should be 0
[15:45] <dobey> adorilson: install xutils-devel
[15:46] <rye> verterok, BEGIN_CONTENT begin_content {   offset: 0
[15:46] <dobey> although we can probably remove that at this point
[15:46] <verterok> rye: ok, so this isn't the same bug...something else is going on
[15:47] <verterok> facundobatista: ^ isn't resuming the upload...so isn't the stalled resumable uploads issue :/
[16:04] <rodrigo_> can someone on natty send me some screenshots of the contacts picker?
[16:05] <rye> rodrigo_, contact picker from ubuntuone?
[16:05] <fagan> joshuahoover: the links will probably be wrong is that ok
[16:05] <rodrigo_> rye, yes
[16:06] <joshuahoover> fagan: links to?
[16:06] <fagan> joshuahoover: the other pages
[16:06] <mandel> alecu: ping
[16:07] <joshuahoover> fagan: maybe muffinresearch has ideas on how to handle links (if there is any way to handle it better than just leaving them be wrong for now)
[16:07] <fagan> joshuahoover: yeah he would be the one to ask
[16:07] <fagan> muffinresearch: ^
[16:07] <fagan> oh and I just finished the first 2 sections
[16:08] <muffinresearch> fagan: do you have examples?
[16:08] <fagan> muffinresearch: sec
[16:08] <rye> rodrigo_, http://ubuntuone.com/p/10om
[16:09] <fagan> muffinresearch: https://wiki.ubuntu.com/UbuntuOne/Tutorials/Setup/Maverick#Already%20have%20an%20Ubuntu%20One%20account
[16:09] <dobey> rye: ugh, contacts picker --
[16:09] <fagan> taht kind of thing, should I just leave it or should I guess what the link would be or something
[16:10] <rodrigo_> rye, thanks, but don't you have more contacts? It's for showing other people what it does :)
[16:11] <dobey> rodrigo_: i think he was pointing out the disconnect between the search field contents, and that there are any results at all :)
[16:11] <rodrigo_> dobey, :)
[16:11] <muffinresearch> fagan: the faq itself will be at /help/faq/ - The table of contents as shown on that page should be auto generated by ReST using the directive for that. http://docutils.sourceforge.net/docs/ref/rst/directives.html#table-of-contents
[16:12] <fagan> muffinresearch: hmmmm well in the interest of speed ill leave them and sort out all the links tomorrow
[16:13] <fagan> ill give it a shot anyway and if they are wrong you guys can sort it since its a small thing to fix
[16:15] <rye> rodrigo_, well, i can create more contacts
[16:15] <rodrigo_> rye, please, if it's not too much hassle :)
[16:15] <rodrigo_> rye, although I'd prefer to get contacts with photos
[16:15] <rodrigo_> dobey, do you have?
[16:16] <dobey> rodrigo_: i have no friends dude :)
[16:16] <rodrigo_> heh
[16:16] <rodrigo_> no even ennemies with photos in your addressbook? :D
[16:16] <rodrigo_> so, anyone else please?
[16:16] <rye> rodrigo_, hm, the photo part is tricky, replication is disabled for my shard
[16:16] <dobey> no
[16:16] <facundobatista> rye, can you send me the logs of that session? thanks
[16:16] <dobey> but i don't see why it matters
[16:17] <dobey> the bug i'm seeing in that screenshot has nothing to do with photos
[16:17] <rodrigo_> rye, don't worry then, I'll try to find someone with contact photos
[16:17] <rodrigo_> dobey, it's for showing people designing a contact picker for gnome how ours look like
[16:17] <rodrigo_> so yes, I'd prefer photos
[16:18] <rodrigo_> I have photos myself for lots of contacts, but u1 doesn't work on oneiric yet
[16:18] <rodrigo_> joshuahoover might have it
[16:18] <rodrigo_> joshuahoover, do you have photos for contacts that are displayed in the contacts picker in nautilus?
[16:19] <dobey> rodrigo_: so rye wasn't showing you a bug in that screenshot?
[16:19] <rye> dobey, nope
[16:19] <dobey> oh, because all i saw was "look at this bug" :)
[16:19] <joshuahoover> rodrigo_: let me check
[16:19] <rodrigo_> dobey, no, not a bug
[16:20] <joshuahoover> rodrigo_: doesn't look like it...hmmm
[16:20] <rodrigo_> ok
[16:21] <dobey> rodrigo_: the thing is, almost nobody has photos of contacts in evolution
[16:21] <rodrigo_> dobey, I have, they get imported from facebook
[16:21] <rodrigo_> not for u1 contacts though
[16:21] <dobey> rodrigo_: the only people that do are people who added photos to demo the fact that photos can be used in evo :)
[16:21] <rodrigo_> :)
[16:22] <dobey> rodrigo_: how did you get fb contacts in evolution if not through u1?
[16:22] <rodrigo_> joshuahoover, ok, so can you take a screenshot please?
[16:22] <rodrigo_> dobey, via pidgin plugin, iirc
[16:23] <dobey> oh, weird
[16:23] <joshuahoover> rodrigo_: i don't have any photos or contacts here :(
[16:23] <rodrigo_> joshuahoover, I'll replace it with one with photos as soon as u1 works here
[16:23] <joshuahoover> rodrigo_: only via the web
[16:23] <rodrigo_> joshuahoover, doesn't mind, if you have more than 1 contact, it's enough :)
[16:23] <joshuahoover> rodrigo_: ah, ok...let me get that for you then
[16:23] <dobey> rodrigo_: didn't the design mock-up have fake contacts with photos?
[16:23] <rodrigo_> joshuahoover, cool, thanks
[16:24] <rodrigo_> dobey, the design mockups are different from what we implemented
[16:24] <rodrigo_> and they are not public, afaik
[16:24] <rodrigo_> aren't they?
[16:24] <dobey> i thought they were, but no idea
[16:25] <dobey> *shrug*
[16:25] <dobey> i'm surprised gnome isn't just using the OSX design
[16:25] <rodrigo_> https://live.gnome.org/action/subscribe/Design/Apps/Contacts <- this is what's up for now
[16:25] <dobey> although, i'm sure they will settle on that, but it will have the gtk3 theme
[16:26] <dobey> yeah i've seen that
[16:26] <dobey> but i never did like os x
[16:26] <rodrigo_> me neither :)
[16:28] <dobey> what happened to nessita?
[16:28] <joshuahoover> rodrigo_: http://ubuntuone.com/p/10ow/
[16:28] <nessita> dobey: I'm here, why?
[16:29] <dobey> nessita: can you re-review https://code.launchpad.net/~dobey/ubuntu-sso-client/new-kr-props/+merge/65419 please?
[16:29] <nessita> dobey: sure, in a couple of minutes
[16:29] <rodrigo_> joshuahoover, thanks! do you have any problem in making that screenshot more public? that is, adding it to https://live.gnome.org/action/subscribe/Design/Apps/Contacts ?
[16:29] <dobey> nessita: you've been silent for the last hour. it is unlike you :)
[16:29] <dobey> nessita: thanks
[16:29] <joshuahoover> rodrigo_: no, that's fine...just names shown there
[16:29] <nessita> dobey: I'm coding like a monkey
[16:29] <rodrigo_> joshuahoover, ok!
[16:32] <dobey> lunch time, bbiab
[16:33] <adorilson> dobey: yum dont found xutils-devel. And I can't found in another place. :-/
[16:35] <thisfred> runtime directory /run/udev not writeable. That sounds ungood.
[16:36] <duanedesign> verterok:do you know what is the bug number for 'persistent corruptness in resumable'? I have a couple bugs with that issue and have been looking for a bug to dupe them too.
[16:36] <verterok> duanedesign: depends on what 'persistent corruptness in resumable' means :), looks like we have 2 different issues
[16:36] <duanedesign> verterok: aha
[16:36] <duanedesign> verterok: glad you said that. i was thinking we might looking at the conversation
[16:37] <verterok> duanedesign: if the client get a BEGIN_CONTENT with offset > 0 and the upload fails with UPLOAD_CORRUPT, it's bug #778805
[16:37] <ubot4> verterok: Bug 778805 on http://launchpad.net/bugs/778805 is private
[16:37] <verterok> duanedesign: you need TRACE logs to see the BEGIN_CONTENT msg
[16:39] <duanedesign> ahh. you predicted my next question :)
[16:40] <duanedesign> thank you for info
[16:40] <verterok> heh, np :)
[16:44] <mandel> nessita: running the test on linux and will ask you to re-review
[16:44] <nessita> mandel: ack
[16:47] <thisfred> ok, my laptop is severly screwy now. can anyone with a working oneiric send me the output of dpkg --get-selections ?
[16:52] <alecu> mandel, pong. sorry, was afk
[16:55] <mandel> alecu: did the change in the shutdown function work?
[16:55] <alecu> mandel, I'm just working on that right now. I'll let you know in 15'
[16:56] <mandel> alecu: cool, the idea is that you just get the QApp instance and close it there, and there should be no need to tell the reactor to do it at all
[16:57] <alecu> mandel, cool, I understood.
[16:57] <mandel> :)
[16:59] <nessita> ralsina: ping
[16:59] <ralsina> nessita: pong
[17:00] <nessita> ralsina: in GTK I can connect a signal to a widget and pass extra arguments like this: button.connect('clicked', my_callback, data1, data2, data3, ...) and then, when the button is clicked, my_callback will be called with the follwoing params: button, data1, data2, data3, ...
[17:01] <nessita> ralsina: can I do something like that in PyQt? I've tried with QtCore.QObject.connect(button, ... but I can't pass extra args
[17:01] <ralsina> no, no extra args
[17:01] <ralsina> you can use a lambda
[17:01] <nessita> ralsina: hum... no I can't...
[17:02] <ralsina> button.clicked.connect(lambda : recipient(bla, foo, bar))
[17:02] <nessita> I'm inside a loop, and I need the extra  params (bla, foo, bar) be those from the loop
[17:02] <nessita> so, I have code that looks like:
[17:02] <nessita> for bla, foo, bar in data:
[17:02] <nessita>     QtCore.QObject.connect(button, QtCore.SIGNAL('clicked()'), lambda: my_callback(bla, foo, bar))
[17:02] <nessita> that will not work
[17:03] <nessita> bla, foo, bar will always be the last ones from the loop run
[17:03] <ralsina> nessita: pass them as arguments to the lambda: lambda foo=foo, bar=bar: recipient(foo, bar)
[17:03] <ralsina> that way, the foo inside the lambda is the name of the arg, which is bound to the current value in the loop
[17:04] <nessita> trying that, but is EXTREMELY DISGUSSING :-)
[17:04] <nessita> disgusting *
[17:04] <ralsina> nessita
[17:05] <nessita> yes?
[17:05] <ralsina> nessita, at least it's not lambda bar=foo, foo=bar: f(foo,bar) ;-)
[17:05] <nessita> does not seems to work... and I can see why
[17:05] <nessita> ah no, wait
[17:06] <ralsina> there are cleaner solutions using signalmapper but it's really verbose
[17:06] <nessita> it works
[17:06] <nessita> thanks
[17:06]  * ralsina remembers doing this
[17:06] <nessita> is uglier than mestre
[17:06] <ralsina> glad to help!
[17:07] <ralsina> it's poor man's python closures
[17:08] <nessita> dobey: reviewing
[17:09] <alecu> mandel, so, after calling app.quit it just wont finish
[17:10] <alecu> mandel, I even tried calling a shutdown function that calls app.quit and then reactor.stop, just in case.
[17:11] <mandel> alecu: bummer… that looks like there is a thread being evil somewhere...
[17:11] <alecu> mandel, absolutely. It must be the threaded reactor thread.
[17:11] <alecu> mandel, but for now, we'll raise the value of the sso timeout to infinity-1
[17:12] <alecu> mandel, so the sso client will keep running forever and that's it.
[17:12] <alecu> mandel, we'll fix this properly later.
[17:13] <mandel> alecu: sure.. it should not be a major issue for the time being
[17:25] <mandel> nessita, alecu: please can you look at https://code.launchpad.net/~mandel/ubuntuone-client/windows_sdtool/+merge/65493
[17:26] <nessita> yes
[17:29] <nessita> dobey: branch works very good, approved
[17:29] <nessita> dobey: I would like alecu's doing the second review
[17:29] <dobey> nessita: great, thanks
[17:29] <dobey> sure
[17:29] <dobey> alecu: can you review https://code.launchpad.net/~dobey/ubuntu-sso-client/new-kr-props/+merge/65419 please?
[17:29] <alecu> sure
[17:33] <alecu> dobey, why do you abbreviate collection as CLXN?
[17:35] <dobey> alecu: PEP8
[17:35] <alecu> mandel, I'll review your megabranch after lunch.
[17:35] <mandel> alecu: sure, np
[17:36] <nessita> mandel: instead of raise Exception('Not implemented.')
[17:36] <nessita> mandel: can you please raise NotImplementedError?
[17:36] <mandel> sure
[17:38] <nessita> mandel: and class ErrorSignal(Exception): needs a docstring (and then remove the "pass")
[17:39] <mandel> nessita: can you write all this in a comment so that we can keep track?
[17:39] <nessita> mandel: I could, but adding a needs fixing and waiting for your fixes use to take too much roundtrip
[17:39] <nessita> mandel: if I stare at you while you fix this it goes faster :-D
[17:40] <alecu> dobey, I don't see anything on pep 8 regarding that kind of abbreviations. But I find it confusing that in some constants it's spelled COLLECTION, and on others CLXN
[17:40] <mandel> nessita: ok
[17:40] <alecu> dobey, would you mind changing the CLXN to COLLECTION?
[17:41] <dobey> alecu: line length limit
[17:42] <nessita> mandel: let me know when those 2 are fixed and pushed
[17:42] <nessita> mandel: should be quick, right?
[17:42] <dobey> alecu: having to do 'FOO = \\\n"some long string"' is lame
[17:43] <dobey> alecu: and there isn't really any raeson for those to be used outside of txsecrets.py anyway, aside from the fact that the tests also use them
[17:43] <mandel> nessita: yes, just done it and pushing, I'll ping you when done
[17:43] <nessita> thanks!
[17:43] <nessita> I'll have lunch after that
[17:45] <mandel> nessita: done, r1061
[17:49] <ralsina> nessita: ran into some trouble making SSO show the right buttons on the wizard, will take another 60, 90 minutes
[17:50] <nessita> ralsina: OH NO! what are we doing now! NOOOOOO :-P
[17:50] <nessita> ralsina: ok, let me know :-)
[17:50] <nessita> ralsina: need help?
[17:50] <ralsina> nessita: sure. I am trying to make it good enough not to have to work on it again tomorrow after design sees it ;-)
[17:50] <nessita> good choice
[17:50] <karni> nessita: Every time we authenticate the user (and then save oauth tokens, naturally) we add some, name it, host token - "Ubuntu One @ foobar". Is there a way to authenticate a user and reuse such token instead of creating new oauth tokens if the user, say, uninstalls U1 software, and then installs it again?
[17:51] <alecu> dobey, why did you change the out_signature of SecretServiceMock.CreateCollection ?
[17:51] <karni> nessita: I'm trying to be precise, but it's a tricky question that blajk just asked.
[17:51] <nessita> mandel: approving. When I get a windows env I'll test it IRL, and I'll file bugs if necessary
[17:52] <nessita> karni: nopes
[17:52] <karni> nessita: Say, we authenticated with "Ubuntu One @ foobar" token once. We remove the software completely. Then we install it and re-authenticate - can we request previously generated oauth tokens or we need to create new once?
[17:52] <mandel> nessita: ok, I'm writing the script you asked atm
[17:52] <karni> nessita: So a new one is neccessary, right?
[17:52] <karni> nessita: That's what I thought. Thanks!
[17:53] <nessita> karni: you're welcome!
[17:53] <karni> :)
[17:53] <alecu> dobey, the code looks fine otherwise. The only doubt I have is with that out_signature change.
[17:53]  * alecu will have lunch now.
[17:53] <dobey> alecu: one second my firefox went nuts
[17:54] <fagan> joshuahoover: did a big push of a few pages
[17:54] <fagan> joshuahoover: about halfway there
[17:54] <joshuahoover> fagan: cool, thank you!
[17:55] <fagan> joshuahoover: you know where the branch is?
[17:56] <joshuahoover> fagan: yep
[17:56] <fagan> joshuahoover: cool ill do some more then and should be almost done for tomorrow morning
[17:56] <dobey> alecu: hrmm, no idea. changed it back, and pushed
[17:56] <joshuahoover> fagan: excellent
[17:57] <fagan> ok changing location brb
[17:57] <fagan> ]/quit
[17:59] <mandel> alecu: this is new: http://paste.ubuntu.com/631291/ is it on purpose?
[17:59]  * mandel walks dog, will me back in 30 min
[18:11] <nessita> ok, lunchtime!
[18:18] <nessita> ok, no luch yet, firs, merge proposal: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/explore-folder/+merge/65697
[18:18] <nessita> can I have a couple of reviews for? ^ please
[18:18] <nessita> now yes, lunchtime!
[18:24]  * thisfred reviews
[18:26] <dobey> i'm not good at doing reviews. rebuking on the other hand, i am ace at.
[18:32] <alecu> dobey, there are a few error messages shown while running the tests that are not shown on trunk: http://pastebin.ubuntu.com/631316/
[18:33] <alecu> dobey, the tests pass fine though.
[18:33] <dobey> alecu: maybe that's why i changed it to v. no idea why those are happening, or why they're not causing failures
[18:35] <dobey> hrmm, though those must be coming from a different call
[18:35] <ralsina> mandel: ping
[18:35] <mandel> ralsina: pong
[18:36] <ralsina> mandel: not for now, not for soon, but using buttons inside the pages for controlling the wizard is not really good for integrating it with other code
[18:36] <mandel> ralsina: I agree, the issue here is the design..
[18:37] <ralsina> for example, the same effect can be achieed (as long as you hae less than three "action" buttons, using the custom buttons of the wizard view
[18:37] <mandel> ralsina: the problem is the location, not the number of buttons, that I know how to do
[18:38] <mandel> ralsina: the actual best thing for you to do if it is a problem is to reuse the controllers and just provide the same interface for the UI
[18:38] <ralsina> mandel: well, the thing is ... I prefer them to be located in the wizard :-)
[18:38] <ralsina> mandel: yes, I will probably do that eventually
[18:39] <mandel> ralsina: the problem is that certain buttons they placed in the UI cannot be in the wizard, but have to be in the page, remember the wireframes?
[18:39] <ralsina> mandel: yes for some, but for example "create account" on the signup page is clearly a "Next" in disguise
[18:40] <ralsina> anyway, I think it's looking ok, een if it doesn't quite follow the wireframes to the letter
[18:40] <mandel> ralsina: if you but it as a next, how would you ensure that is placed where they wanted?
[18:41] <mandel> ralsina: you would have to play with the button layout of the wizard that can be everything but flexible
[18:41] <ralsina> it is at the bottom right corner, where the next button usually is. I mean in the page with the captcha
[18:42] <ralsina> but yes, the "choose sign in" page's wireframes mean no wizard buttons there
[18:42] <alecu> dobey, it looks like it's the "Get" dbus methods on the Mock, being called with the wrong propname. They don't match the propname, and end up returning None, which can't be converted to a dbus value, and this error is caught by your new code and ignored (and that's fine). Please open a bug for this, and assign it to me.
[18:42] <mandel> ralsina: exactly, so we have to fight between design and the QWizard implementation
[18:42] <ralsina> mandel: exactly
[18:43] <ralsina> which is why, I will probably (later) sit down with design and move a few buttons around :-)
[18:43] <dobey> alecu: ah right. guess I should make it raise an exception
[18:44] <mandel> ralsina: feel free to do so :)
[18:44] <ralsina> mandel: hahaha
[18:44] <alecu> dobey, right, rising a new "NotFoundException" would be the right thing there.
[18:46] <dobey> alecu: well i was thinking a custom "InvalidProperty" exception
[18:46] <mandel> alecu: ping
[18:46] <dobey> or DBusException("Invalid properties") or something
[18:47] <alecu> dobey, "InvalidPropery" sounds fine. It will be translated by dbus automatically into a DBusException on the other side.
[18:47] <dobey> right
[18:47]  * dobey fixes that
[18:49] <alecu> dobey, approved
[18:50] <alecu> mandel, still need the huuuuuge review?
[18:50] <mandel> alecu: yes, but is not for that, go a question, when I try to run sd on my machine, which used to work, I now get the following: http://paste.ubuntu.com/631291/
[18:51] <mandel> alecu: looks like credentials related, which is strange.. sd should be able to run even without the credentials, the state machine does include the state (with no user, with network)
[18:51] <alecu> mandel, oh, right.
[18:52] <dobey> alecu: great, thanks
[18:53] <mandel> alecu: oh, right? suena peligroso ;)
[18:53] <alecu> mandel, "peligroso" is my middle name.
[18:54] <nessita> alecu, mandel: syncdaemon has a setting which is autoconnect
[18:54] <nessita> so it will ask the keyring for the credentials
[18:54] <nessita> mandel: do you have SSO working?
[18:54] <nessita> running, I meant
[18:55] <mandel> nessita: no, it was not running, but I wanted to check if the sd would work from trunk, it should be able no matter if there are creds or not
[18:55]  * mandel tries with sso
[18:55] <nessita> alecu: I know what's mandel issue, he updated his syncdaemon to the latest, which now handles credentials "properly" (after your fix)
[18:56] <nessita> mandel: the thing is that before alecu's branch, the connect() method was buggy and was not doing what is should, which is, seek for credentials
[18:56] <mandel> nessita: so why do we have a state in the state machine that allows to have no user with network, it does not make much sense..
[18:57] <mandel> does it?
[18:57] <nessita> mandel: so, it was working before for you because connect() was doing kinda nothing
[18:57] <nessita> mandel: it does not make sense, but you can not connect by setting autoconnect to False in the conf file
[18:57] <nessita> I does* make sense, I mean :-D
[18:58] <mandel> alecu, nessita: ok, so now I get the jelly serialization error.. whic I'm guessing we have to fix
[18:59] <nessita> mandel: please do not overlap work with alecu. I think you should work on having the start() method implemented
[19:00] <nessita> alecu: you're dealing with the jellyfish, right? :-)
[19:00] <alecu> I am
[19:00] <alecu> I am the walrus
[19:00] <nessita> great
[19:00] <alecu> choo-choo-choo-choo
[19:00] <nessita> mandel: so, you work now on the SDTool.start()
[19:00] <nessita> yes?
[19:01] <mandel> nessita: yes, I wanted to test sdtool agains trunk, but seems impossible…
[19:01] <nessita> mandel: WELCOME TO MY WORLD :-P
[19:01] <nessita> and alecu's
[19:02]  * mandel cries 'but it was working….'
[19:03] <nessita> mandel: using hard code credentials does not mean it was working ;-)
[19:04] <nessita> coded*
[19:04] <nessita> or hard core credentials, as well
[19:07] <mandel> details, details...
[19:07] <nessita> heh
[19:07] <alecu> mandel, I found the solution to the jelly, but the branch is missing some bits still
[19:08] <alecu> mandel, anyway, I'm reviewing your megabranch right now.
[19:08] <mandel> alecu: awesome, what was the issue for the jelly thing?
[19:09] <alecu> mandel, self.sso_proxy.find_credentials(APP_NAME, {}, reply_handler=reply_handler, error_handler=error_handler)
[19:10] <alecu> mandel, both reply_handler and error_handler were set to NO_OP
[19:10] <alecu> mandel, but sso_proxy was a pb proxy, not a dbus one
[19:10] <ralsina> mandel, alecu, nessita: Can I get two kind reviews for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800359/+merge/65703
[19:10] <alecu> mandel, so both NO_OP ended being sent thru pb as keyword parameters
[19:10] <mandel> alecu: yes, but there is a decorator that should ensure that the callbacks are Referenceable objects, right?
[19:11] <nessita> ralsina: I'll get one
[19:11] <alecu> mandel, well, they were being *sent* thru pb
[19:11] <nessita> mandel: let's trade https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/explore-folder/+merge/65697
[19:11] <ralsina> nessita: there is no test for the constants because the tests don't work on any platform. On Linux SSO doesn't install teh qt stuff, and on windows I get a reactor problem when trying to use u1trial
[19:12] <alecu> mandel, instead, they should not be sent thru pb, but instead the corresponding callbacks are already being connected to the remote signals.
[19:12] <alecu> mandel, so, some bits are missing there, and a bit more debugging.
[19:12] <alecu> mandel, but please let me finish your megareview first.
[19:12] <nessita> ralsina: the tests DO work on linux, we ran them yesterday
[19:12] <mandel> alecu: true, the pb returns a deferred
[19:12] <nessita> ralsina: what error you mean by "On Linux SSO doesn't install teh qt stuff"?
[19:12] <alecu> mandel, pb returning a deferred has nothing to do with this!
[19:12] <ralsina> nessita: importing sso qt stuff breaks them
[19:12] <mandel> ralsina., nessita: I'll take a look at your proposals
[19:13] <nessita> ralsina: let's set a pythonpath
[19:13] <nessita> ralsina: and on windows, what reactor problem are you having?
[19:13] <ralsina> nessita: since ubuntu-sso-client doesn't install the SSO things, tests don't run. It doesn't even compile the .ui files unless you hack setup.py
[19:13] <alecu> mandel, that deferred returned by pb only means that the find_credentials was correctly handled on the other side.
[19:13] <alecu> mandel, it is not the return value of the find_credentials.
[19:13] <ralsina> nessita: will show you in 2'
[19:13] <ralsina> oops/SSO things/qt things/
[19:14] <alecu> mandel, the return value of find_credentials is sent thru a signal; but that signal should be "subscribed" first with "register_to_signals".
[19:14] <ralsina> nessita: I get "The specified reactor is not supported." on windows. With both qt4 and txnp reactors
[19:14] <mandel> alecu: yes, you are right
[19:14] <alecu> mandel, and btw: register_to_signals/unregister_to_signals is braindead to me as an API.
[19:14] <nessita> ralsina: are you u1devtools updated?
[19:15] <mandel> ralsina: you do not have them installed, you are getting an import error and is printing that
[19:15] <alecu> mandel, so, bits and pieces missing. I'll keep working on it later.
[19:15] <ralsina> nessita: trunk
[19:15] <dobey> ralsina: are you pulling stuff from wrong PYTHONPATH?
[19:15] <mandel> alecu: ok, I'll get back to reviews and sdtool
[19:15] <nessita> ralsina: do you have them installed, like mandel says?
[19:15] <ralsina> mandel: ok, will look into the tests then
[19:15] <nessita> ralsina: right, no test is not an option (still! :-))
[19:15] <mandel> ralsina: also, as dobey said, check your path is ok
[19:15] <ralsina> I am pretty sure I have the qt4 one installed since it works ;-)
[19:16] <ralsina> but yes, could be PYTHONPATH crazyness
[19:17] <ralsina> I would like some IRL testing to know if it only works for me though :-)
[19:17] <nessita> ralsina: what thing may work only for you?
[19:18] <ralsina> nessita: the whole ubuntuone-windows-installer thing
[19:19] <nessita> ralsina: I'll do an IRL, but I would like you to work on adding tests, and having them running. Since the next work is going to be more complex and we need to have tests for those for sure.
[19:19] <ralsina> nessita: yep, tests the rest of the day, in principle
[19:20] <ralsina> and if sdtool is looking good, start the syncdaemon/cntrolpanel integration tonight
[19:21] <nessita> ralsina: well, ideally I would expect you to have the tests done before you eod, and then start integrating u1cp widgets. You think that's doable?
[19:21] <ralsina> nessita: what I said
[19:21] <nessita> ralsina: ah, I understood something else
[19:21] <ralsina> I will have the tests on before EOD, and then in my couple of late hours will look at u1cp widget integration
[19:22]  * ralsina has two eods a day now ;-)
[19:22] <dobey> grr lp
[19:22] <nessita> ralsina: ah, thanks for the clarifiaction, I misunderstood before
[19:22] <nessita> ralsina: sounds great then
[19:22] <dobey> yay finally
[19:23] <ralsina> anyone need a second review on something? I dn'twant to code for 3 0 minutes :-)
[19:24] <nessita> ralsina: did you do mine? :-) (LP does not show any review from you)
[19:25] <ralsina> nessita: probably got an idea on how to fix something and forgot. Link?
[19:26] <nessita> https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/explore-folder/+merge/65697
[19:26] <ralsina> nessita: ok, on it for real this time
[19:27] <nessita> thisfred: I share your concerns from the review, but all those will be cleared up with the design team when they see this
[19:27] <mandel> nessita: I just finished this : https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/explore-folder/+merge/65697
[19:27] <thisfred> nessita: that's what I figured, so I approved
[19:28] <nessita> mandel: oh thanks
[19:28] <nessita> ralsina: no need then
[19:29] <ralsina> nessita: oooook then.
[19:29] <nessita> how can I have a cmd.exe on w7? start -> run command is gone and I can't find it in less than 3 seconds
[19:29] <nessita> (so I better ask the experts here)
[19:29] <ralsina> nessita: yes, windows key -> r and type cmd
[19:30] <ralsina> or type cmd in the search line and press enter.
[19:30] <nessita> great
[19:30] <nessita> worked
[19:30] <ralsina> Any other important reviews pending?
[19:30] <mandel> ralsina: line 253 in https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800359/+merge/65703 is that print on purpose?
[19:30] <ralsina> mandel: surely not.
[19:30] <alecu> nessita, if the windows key is captured by unity, try using "Ctrl-Esc"
[19:31] <nessita> alecu: is not, but thanks!
[19:31] <mandel> ralsina: also, line 268, if you do nothing with the exception, at least log it so that we know it occurs, right?
[19:31] <nessita> ralsina: most of the news docstrings have no ending dot, can you please add those
[19:32] <ralsina> mandel: ok. The exception is a bug in PyQt when nothing is connected to the signal
[19:32] <ralsina> nessita: ok.
[19:33] <mandel> ralsina: oh, then we should have a comment so that the next guy knows about it
[19:33] <ralsina> mandel: it's ok, I will log it and add a comment
[19:33] <mandel> ralsina: lines 434 and 441, why did you comment out the imports?
[19:34] <mandel> I mean, if you do not need them then dd, right?
[19:34] <nessita> ralsina: going back to have the tests running on linux, is there a chance to have the running if we set PYTHONPATH to the proper ussoc source code, where all the QT stuff is available?
[19:34] <ralsina> mandel: yes, will delete
[19:35] <ralsina> nessita: possibly, but you need to edit setup.py to make it compile the .ui files
[19:35] <mandel> ralsina: the title passed to the controllers should be translated via getted, lines 469 and 483
[19:36] <nessita> ralsina: but... ./setup.py is al;ready building the qt ui for sso. What do you mean exactly?
[19:36] <ralsina> nessita: last I checked, on Linux, it didn't
[19:37] <ralsina> nessita: I may be remembering wrong, of course
[19:37] <alecu> mandel, def is_running(bus=None): does not use bus for anything, right?
[19:37] <nessita> mandel, ralsina: if you use the proper constant from u1client no translation should be needed, right?
[19:37] <mandel> alecu: no, left it to be compatible with linux, no other reson
[19:38] <mandel> nessita: true, but is the header of the page, I don't know if we have that in the contansts… probably we do
[19:38] <alecu> mandel, oh, so the api is the same, right_
[19:38] <alecu> ?
[19:38] <ralsina> nessita: there is no constant for this, I think
[19:38] <nessita> ralsina: which string is it?
[19:38] <ralsina> "Sign In"
[19:39] <mandel> alecu: yes, that is the idea, so that nessita does not have to do weird things with it
[19:39] <alecu> mandel, but start() in (the huge and perhaps wrongly named) SyncDaemonTool sends a self.bus to it. Which is not used in any other place...
[19:39] <alecu> mandel, (it should have been named SyncDaemonSwissTool)
[19:40] <mandel> alecu: hahaha
[19:40] <alecu> thank you, thank you. I'll be here for the remaining of the week.
[19:41] <mandel> alecu: ein?
[19:42] <alecu> mandel, SyncDaemonTool.start: "if not is_running(self.bus)"... but self.bus is not defined anywhere!
[19:43] <ralsina> mandel, nessita: added periods, removed commented code, added comment for exception catch, translated "Sign In".
[19:43] <mandel> alecu: oh, that is a bug, let me check 'cause I though that was fixed...
[19:43] <thisfred> dog is acting weird I think she needs to go, bbiab
[19:46] <alecu> mandel, another thing: reply_handler inside get_current_downloads already has access to "d" (thru the closure), so no need to receive it as an arg, and no need for the lambda that calls reply_handler
[19:47] <mandel> alecu: ok, let me check
[19:48] <mandel> alecu: true, that is ugly, I would remove the use of the lambda, what do you think?
[19:48] <alecu> mandel, that sounds perfect.
[19:49] <alecu> mandel, also, inside get_current_downloads too: since no error handlers are attached to downloads_d, any error would be lost.
[19:49] <alecu> mandel, it would be *much* safer to rewrite all this using inlineCallbacks.
[19:49] <alecu> mandel, but perhaps nessita will agree that we should better do this as a refactor later.
[19:50] <nessita> alecu: if those are 15-20 minutes changes, let s do them now
[19:50] <nessita> alecu: I agree with your suggestions, they will ease tracking busg later if needed (let's hope not!)
[19:51] <alecu> mandel, same thing with the lambdas and inlineCallbacks in get_current_uploads
[19:51] <alecu> mandel, and in pretty much every function in that module.
[19:52] <mandel> alecu: ok, I'll move all the possible methods to use the inlineCallbacks decorator
[19:52] <alecu> well, not every function :P
[19:52] <mandel> alecu: well, you understood what I meant :P
[19:52] <alecu> right!
[19:54] <alecu> mandel, so, every function that's creating an returning a Deferred is candidate to rewrite with inlineCallbacks, and it would be much safer written that way.
[19:55] <alecu> mandel, please let me know if you need help with that. And if you consider that it's too much trouble let's file a bug and do it next week.
[19:57] <mandel> alecu: then all those that are using the pb code directly to, like all the config ones
[19:57] <mandel> that is why there are lots of them
[19:57] <ralsina> A few minutes ago I tried to stand up and my knee didn't let me. I am going to see another doctor now, I should be back in IRC in 30 minutes or so from the cell phone on the waiting room, and  back at coding in 90 minutes.
[19:58] <nessita> ralsina: looking your branch
[19:59] <ralsina> nessita: cool, thanks.
[19:59] <nessita> ralsina: good luck in the doctor
[19:59] <ralsina> nessita: even more thanks :-)
[20:04] <alecu> ralsina, you should only stand up at 10AM sharp!
[20:05] <ralsina> alecu: seems doing it twice a day is too much formy old bones ;-)
[20:05]  * ralsina will live in a bath tub from now on
[20:06] <ralsina> BTW: quasseldroid rocks!
[20:13] <nessita> mandel: ping
[20:13] <mandel> nessita: pong
[20:13] <nessita> mandel: I'm trying to install bzr, but for that I need to install its dependencies, but for that I need pycurl-ssl-bla, but when trying to install I'm getting an error:
[20:14] <thisfred> back
[20:14] <nessita> "The program can't be started  becasue MSVCR71.dll is mising from your computer"
[20:14] <nessita> mandel: what the heck is that?
[20:14] <mandel> nessita: nest thing is to install the bundle version, the complain is about a dll that comes with vs
[20:15] <nessita> mandel: ok, the wiki should said so, I'll add it
[20:15] <mandel> nessita: yes, mea culpa
[20:15] <nessita> is ok, we'll improve it together
[20:20] <mandel> nessita, alecu, ralsina: I'm going to call it a EOD since its 21:20 here.. I might be back later, but I'm not sure
[20:20] <mandel> laters!
[20:21] <nessita> mandel: question
[20:21] <nessita> mandel: did you finish the branch alecu was reviewing?
[20:22] <ralsina> mandel: c u tomorow!
[20:23] <dobey> trivial review on https://code.launchpad.net/~dobey/ubuntuone-client/fix-headers/+merge/65714 please?
[20:33] <thisfred> on it
[20:33] <thisfred> dobey: done
[20:34] <dobey> thanks
[20:34] <alecu> dobey, approved.
[20:35] <jeroen-> ping rye
[21:12] <ralsina> ok, gt x-rays, turns out I have what the doctor calls "heck of a bump" in the knee, and it's swelling, and it's probably nothing, except it's going to hurt like crazy for a few days.
[21:13] <dobey> ralsina: morphine ftw
[21:13] <ralsina> dobey: good band!
[21:13] <ralsina> ;-)
[21:19] <nessita> what program can I use to tar xzv?
[21:20] <nessita> 7zip!
[21:27] <dobey> also have https://code.launchpad.net/~dobey/ubuntuone-client/fix-headers-1-6/+merge/65723 and https://code.launchpad.net/~dobey/ubuntuone-client/fix-headers-1-4/+merge/65728 that are trivial if anyone can take a quick look and approve :)
[21:30] <ralsina> dobey: on it!
[21:30] <dobey> and thisfred needs another review on https://code.launchpad.net/~thisfred/ubuntuone-client/better-progress-bar/+merge/64887
[21:31] <thisfred> not urgent though, any windows work should go first
[21:33] <dobey> well, would be nice to put it in the release for oneiric
[21:33] <ralsina> thisfred: I really want to use Linux for 5' so, reviewing ;-)
[21:34] <ralsina> dobey +1 on the two trivial ones
[21:34] <thisfred> awesome!
[21:34] <dobey> thanks!
[21:35] <ralsina> thisfred: so this makes the progressbar go by bytes instead of files?
[21:36] <thisfred> ralsina: exactly
[21:36] <ralsina> thisfred: nice!
[21:37] <ralsina> thisfred: works too! ;-)
[21:37] <thisfred> yay!
[21:38] <ralsina> thisfred: +1'd
[21:38] <thisfred> thx!
[21:39] <ralsina> thisfred: now if the unity folks make a visible progressbar we are good with it! ;-)
[21:39] <thisfred> heh
[21:39] <ralsina> I made a zoom in mine, it has 4 pixels of border and 2 pixels of actual progress thingie between them.
[21:42] <dobey> noice
[21:53] <ralsina> InsecureJelly exception? Some developers should really joke less and give descriptive names more :-(
[22:00] <thisfred> sounds like the bad old twisted days. They had error msges like: "Your opulent throne will be your undoing."
[22:01] <thisfred> Slightly less informative than "guru meditation #00000004.0000AAC0"
[22:02] <thisfred> also: http://www.youtube.com/watch_popup?v=EVwlMVYqMu4&vq=medium#t=125
[22:07] <dobey> alright, i'm out. later all!
[22:07] <thisfred> later dobey
[22:26] <ralsina> thisfred: that error is from twisted, so it's still the bad old days over there ;-)
[22:31] <thisfred> he
[22:32] <thisfred> ok, gonna walk the dogs, may be back later, ping me if anyone needs reviews or anything
[22:46] <ralsina> ok, first EOD, tests are almost there, will resume work in a couple of hours
[22:54] <nessita> bye all