| * nessita -> eod'd | 00:26 | |
| adorilson | hi, dobey | 01:17 |
|---|---|---|
| duanedesign | *yawn* | 09:46 |
| duanedesign | morning all | 09:46 |
| ralsina | morning! | 10:38 |
| ralsina | So to speak. | 10:38 |
| * fagan break | 11:51 | |
| duanedesign | rye: ping | 11:54 |
| rye | duanedesign, pong | 11:54 |
| duanedesign | hello rye ! | 11:54 |
| rye | duanedesign, hello! | 11:54 |
| duanedesign | rye: umm. had a post i have been putting off answering...because i have never downgrdaded an account so I am unsure of the expected behaviour | 11:55 |
| rye | duanedesign, by downgrading you mean? | 11:55 |
| duanedesign | rye: so if you had a 20 GB pack and where downgrading to the free 2 GB account | 11:56 |
| rye | duanedesign, the data will stay intact, if your usage is more than 2Gb then it will simply prevent you from uploading more | 11:56 |
| duanedesign | ok, great. that is exactly what I needed to know | 11:57 |
| duanedesign | rye: thank you much | 11:57 |
| * mandel walking dog | 12:25 | |
| karni | hi duanedesign | 12:39 |
| karni | hi rye | 12:39 |
| nessita | hello everyone! | 12:41 |
| duanedesign | o/ | 13:02 |
| ralsina | hello nessita! | 13:04 |
| nessita | hola ralsina! | 13:04 |
| nessita | and duanedesign | 13:04 |
| duanedesign | :) | 13:05 |
| ralsina | nessita: I should have fixed your needsfixings at https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800376/+merge/66194 | 13:07 |
| nessita | yes you should have :-) | 13:07 |
| ralsina | nessita: hmmm... I may have? ;-) | 13:10 |
| === teknico is now known as teknico_away | ||
| ralsina | Anyway, I think I fixed them :-) | 13:11 |
| nessita | ralsina: you lost me. Shall I re-review? :-) | 13:11 |
| nessita | ok | 13:11 |
| ralsina | nessita: yes, please | 13:11 |
| * nessita on it | 13:11 | |
| nessita | ralsina: last night I was tired, and I missed that the docstring for CalculateSize is not pep-257 compliant. Can you please fix? | 13:15 |
| ralsina | nessita: sure. Sorry about that. | 13:15 |
| nessita | np :-) | 13:16 |
| nessita | can I have a second review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/isolate-create-folder/+merge/66220 ? | 13:16 |
| nessita | ralsina: same for docstring for show_hide_offer | 13:17 |
| ralsina | nessita: yes, I am checking all docstrings now | 13:17 |
| nessita | is there a chance that there us a typo here? "The folders you have selected to sync take over your %s space. You can remove some folders or add some extra space" | 13:18 |
| nessita | this part sounds weird " take over your 2GB space" | 13:18 |
| ralsina | nessita: that is copied from the wireframe, I will file a bug to re-check them all with the final texts I have in a google doc | 13:18 |
| nessita | thanks! | 13:19 |
| alecu | hello, hello. Hola! | 13:20 |
| ralsina | hola alecu! | 13:20 |
| nessita | hi alecu! | 13:21 |
| nessita | alecu: so, I've had a talk with Chipacaa last night about reactors, and we decided that we should go with the socket scenario by using a fixed port without any further port handling until we have all the pieces working together | 13:21 |
| nessita | alecu: given what you said last night in your email, we should be start moving to a working solution today | 13:22 |
| nessita | alecu: does that make sense? | 13:22 |
| alecu | nessita, sounds reasonable. | 13:22 |
| === teknico_away is now known as teknico | ||
| ralsina | nessita: pep-257-ized | 13:23 |
| nessita | alecu: so, for now, no special port handling but a fixed (hardcoded) one, aiming to have the 3 main pieces (sso, sd, cp) working together | 13:23 |
| nessita | ralsina: re-looking | 13:23 |
| nessita | alecu: and finger cross, as well :-P (figuratively, we need to type) | 13:24 |
| alecu | nessita, jajajajajajajajaa | 13:24 |
| ralsina | nessita: pep257says we should leave a whole blank before the closing """ in multiline docstrings? No wonder I was not writing compliant ones :-( | 13:26 |
| ralsina | nessita: so they are still not compliant. Re-fixing :-( | 13:26 |
| nessita | ralsina: the extra blank line is optional, and I'm +1 to have it but some others don't like it | 13:26 |
| nessita | (optional only when closing, not between the summary and the description) | 13:27 |
| ralsina | nessita: Oh, ok, then they are compliant (/me double-checks) | 13:27 |
| nessita | ralsina: did you push the change to docstring in show_hide_offer? | 13:36 |
| nessita | LP still shows a non pep257 | 13:37 |
| ralsina | I have """Show or hide the offer to buy space according\nto the size of the currently selected folders.\n""" | 13:38 |
| ralsina | It's too long for a oneliner but not enough for a summary/blank/description | 13:38 |
| nessita | ralsina: the docstring needs to be either the one liner, or the summary/blank/description | 13:39 |
| nessita | ralsina: that docstring, as is, is not pep257 | 13:39 |
| ralsina | nessita: grmbl, ok, making it shorter | 13:39 |
| ralsina | nessita: pep257 suggests blank lines before docstrings for classes, and we are not doing that anywhere, I think. | 13:42 |
| nessita | ralsina: we should, one empty line before and one after | 13:43 |
| ralsina | nessita: I am looking at control panel, and it's not done, same in SSO. I will add them in the wizard, but we seem to need a pep257.py and a day off to fix them everywhere. | 13:44 |
| nessita | ralsina: +100 | 13:45 |
| nessita | ralsina: where can I delete my credentials in w? | 13:45 |
| ralsina | nessita: open control panel, search for credentials, open it, look arund, click on the one you want to delete, click "remove" | 13:46 |
| mandel | nessita, ralsina: if you guys have time: https://code.launchpad.net/~mandel/ubuntuone-client/fix-802738/+merge/66292 | 13:46 |
| ralsina | mandel: on it! | 13:46 |
| * mandel super quick lunch | 13:47 | |
| ralsina | nessita: just as personal opinion, I agree we need to follow a convention and this is the one we have, but the PEP257 style is really ugly :-( | 13:48 |
| nessita | ralsina: I accept that as you personal opinion :-). I, personally, love it. | 13:48 |
| ralsina | nessita: also, our module docstrings are really lacking by that standard. | 13:49 |
| ralsina | After things settle I may take a dy or two for docstring checks | 13:50 |
| nessita | ralsina: you mean at syntax level or content? | 13:50 |
| ralsina | nessita: content | 13:50 |
| nessita | True | 13:50 |
| nessita | standup in 5', crowd | 13:54 |
| nessita | mandel: I've had several issues trying to test your normpath branch, but none directly related to the code | 13:54 |
| nessita | mandel: still trying | 13:54 |
| nessita | (mostly VM issues) | 13:54 |
| mandel | nessita: ok, that I guess is good.. | 13:55 |
| nessita | mandel: well, I haven't been able to run the code yet :-) | 13:55 |
| nessita | mandel: can you do a review, please? | 13:56 |
| mandel | nessita: ofcourse | 13:56 |
| nessita | https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/isolate-create-folder/+merge/66220 | 13:56 |
| nessita | thanks! | 13:56 |
| mandel | np | 13:56 |
| === m_conley_away is now known as m_conley | ||
| * ralsina gets coffee, updates notes | 13:57 | |
| mandel | nessita: in line 38, is_link does exist in platform, why does it complain? | 13:58 |
| nessita | mandel: it complains because the definition of is_link is not in that module (but imported to it) | 13:59 |
| mandel | ah, ok, pylint is stupid ;) | 13:59 |
| fagan | moi | 14:00 |
| thisfred | me | 14:00 |
| ralsina | me | 14:00 |
| nessita | me | 14:00 |
| nessita | alecu, mandel, dobey? | 14:00 |
| dobey | me | 14:00 |
| mandel | me | 14:00 |
| nessita | alecu ? | 14:01 |
| alecu | me | 14:01 |
| fagan | WORK IN PROGRESS | 14:01 |
| fagan | rst port of the tutorial pages | 14:01 |
| fagan | Blocked | 14:01 |
| fagan | * nope | 14:01 |
| fagan | go thisfred | 14:01 |
| thisfred | DONE: Bug #803062 Bug#762722 TODO: wrap Bug#762722 BLOCKED: no NEXT: ralsina | 14:01 |
| ubot4 | Launchpad bug 803062 in ubuntuone-control-panel (and 2 other projects) "Unsurprisingly, sys.platform == "linux2" check no longer works on linux 3 (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/803062 | 14:01 |
| ralsina | DONE: mgmt call, windows call, administrivia, fixed things/worked on branches proposed for bug #800376 and bug #800381 | 14:01 |
| ralsina | TODO: The other half of 800376, polish the workflow, ping design about assets, start fixing UI of SSO client | 14:01 |
| ralsina | BLOCKED: no | 14:01 |
| ubot4 | Launchpad bug 800376 in ubuntuone-windows-installer "Add "syncing your computer to the cloud" page to the installer (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/800376 | 14:01 |
| ubot4 | Launchpad bug 800381 in ubuntuone-windows-installer "Add "sync now or later" page to the installer (affects: 1) (heat: 19)" [Undecided,In progress] https://launchpad.net/bugs/800381 | 14:01 |
| ralsina | next nessita | 14:01 |
| nessita | DONE: Bug #800161, Bug #802517, lots of reviews, meetings, attempts to do windows testing but VM is not being nice to me | 14:01 |
| nessita | TODO: Bug #803228, run syncdaemon a lot on w7 testing, mostly, mandel's branches | 14:01 |
| nessita | BLOCKED: the VM I'm using is, suddenly, very slow | 14:01 |
| nessita | NEXT: dobey | 14:01 |
| dobey | λ DONE: reviews, fixed distutils-extra backport to lucid, started on autotriage tool, discovered broken deps on lucid for lazr | 14:01 |
| ubot4 | Launchpad bug 800161 in ubuntuone-control-panel "Do not allow folder creation in a folder containing an UDF (affects: 1) (heat: 12)" [Medium,Triaged] https://launchpad.net/bugs/800161 | 14:01 |
| ubot4 | Launchpad bug 802517 in ubuntuone-control-panel "QT UI: Split the "add folder" button out from the folders panel (affects: 1) (heat: 57)" [High,In progress] https://launchpad.net/bugs/802517 | 14:01 |
| ubot4 | Launchpad bug 803228 in ubuntuone-control-panel "Make test run and pass on windows (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/803228 | 14:01 |
| dobey | λ TODO: more bug fixing/triage | 14:01 |
| dobey | mandel | 14:01 |
| dobey | λ BLCK: None. | 14:01 |
| mandel | DONE: finished tests for bug 802738 moved to look at bug 708652 and found how to solve it. | 14:02 |
| mandel | TODO: review for nessita, but 802726 and bug 802628 | 14:02 |
| mandel | BLOCKED: no | 14:02 |
| ubot4 | Launchpad bug 802738 in ubuntuone-client "KeyError on the root folder inside volume manager (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/802738 | 14:02 |
| ubot4 | Launchpad bug 708652 in ubuntuone-client "Tritcask does not support the use of long paths on windows (affects: 1) (heat: 7)" [Medium,Triaged] https://launchpad.net/bugs/708652 | 14:02 |
| ubot4 | Launchpad bug 802628 in ubuntuone-client "Shares dir does not use the long path prefix: \\?\ (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/802628 | 14:02 |
| nessita | bug 802726 | 14:02 |
| mandel | alecu: go | 14:02 |
| ubot4 | Launchpad bug 802726 in ubuntuone-client "KeyError in ubuntuone\syncdaemon\filesystem_notifications.py (affects: 1) (heat: 8)" [Medium,Triaged] https://launchpad.net/bugs/802726 | 14:02 |
| nessita | any comments? | 14:03 |
| alecu | DONE: compared twisted 10 and 11 behaviour with txnamedpipes, researched txnamedpipes+iocpreactor+threadedselect reactor, found more txnamedpipes issues | 14:03 |
| alecu | TODO: change ubuntu-sso-client to use qtreactor back (bug #803433) | 14:03 |
| alecu | BLOCKED: no | 14:03 |
| ubot4 | Launchpad bug 803433 in ubuntu-sso-client "Use qt-reactor (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/803433 | 14:03 |
| nessita | mandel, ralsina, alecu, Chipaca: meeting "a las y media"? | 14:03 |
| alecu | nessita, ack | 14:03 |
| ralsina | nessita: ok for me | 14:03 |
| mandel | nessita: genial | 14:03 |
| nessita | ok, thanks everyone! | 14:03 |
| nessita | eom | 14:03 |
| * alecu has just tagged bug #803062 with "funniest-bug-titles" | 14:03 | |
| ubot4 | Launchpad bug 803062 in ubuntuone-control-panel (and 2 other projects) "Unsurprisingly, sys.platform == "linux2" check no longer works on linux 3 (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/803062 | 14:03 |
| nessita | mandel, ralsina: does the check ys.platform == "win32" works on non-32 windows? | 14:04 |
| ralsina | nessita: good question. let me check! | 14:04 |
| ralsina | yes | 14:05 |
| thisfred | for now | 14:05 |
| ralsina | That is, yes, if I am on windows 7 64 bits, which I am not sure of ;-) | 14:05 |
| mandel | ralsina: right click on the My Computer in the menu and look at properties | 14:05 |
| thisfred | I discovered linux2 also still works on linux 3, though it may change soon, so it's good we fixed it | 14:05 |
| mandel | ralsina: will tell you what os is running | 14:06 |
| ralsina | yep, 7 home premium 64 | 14:06 |
| ralsina | thisfred: misleading bug! | 14:06 |
| thisfred | yep, I misremembered the thread on python-dev ;) | 14:07 |
| nessita | ralsina: to fix: docstring in test_credential_parameters (is the only ds left to fix) | 14:08 |
| thisfred | ralsina: fixed the bug title and description | 14:08 |
| mandel | nessita: line 69 in the diff, can that path have \\?\ in it, if it does we have an issue when we expand ~ because the expansion won't have \\?\ and therefore will not work | 14:09 |
| nessita | looking | 14:10 |
| mandel | nessita: there is a expanduser function in os_helper that will do that for you, that is expand the user and add \\?\ but I dont know if you need it in this case | 14:10 |
| nessita | mandel: well, I guess we'll need it since the volume info, sent from syncdaemon, will have the \\?\ prefix | 14:11 |
| dobey | brb | 14:11 |
| nessita | mandel: can I file a bug a fix that in a second branch, and check all the project to handle that? | 14:11 |
| mandel | nessita: sure, if there are more places to check it makes sense | 14:12 |
| nessita | bug #803437 | 14:13 |
| ubot4 | Launchpad bug 803437 in ubuntuone-control-panel "Confirm that paths are properly handled using ubuntuone.platform os helper functions (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/803437 | 14:13 |
| mandel | nessita: besides code review and tests, is there anything I should do? | 14:18 |
| nessita | mandel: nopes | 14:22 |
| mandel | +1 then | 14:23 |
| nessita | thanks! | 14:23 |
| nessita | mandel: I can't have syncdaemon running, I'm getting errors such as: | 14:27 |
| nessita | mandel: ah, no, sorry, PICNIC | 14:27 |
| nessita | my credentials are not in place... somehow syncdaemon is not handling that, I may file a but later | 14:28 |
| mandel | no worries, PINIC happens to everyone, even to nessita | 14:28 |
| mandel | nessita: not it places as in the sso is not getting them? | 14:28 |
| nessita | and lately very often :-/ | 14:28 |
| ralsina | alecu, mandel: I need a second review for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800376/+merge/66194 | 14:29 |
| nessita | mandel: syncdaemon is just calling find_credentials, and sso says CredentialsNotFound. Yet, syncdaemon keeps going and send the empty credentials to the server | 14:29 |
| mandel | alecu: I'm on ralsina branch before I do context switch to a diff bug | 14:29 |
| ralsina | mandel: thanks! | 14:29 |
| nessita | mandel, alecu, Chipaca: mumble? | 14:30 |
| mandel | nessita: surely we should be getting that error and die.. file a bug and lets see if we can get your sd running | 14:30 |
| nessita | yeap | 14:30 |
| nessita | running show_gui now | 14:30 |
| mandel | ralsina: I hate your merge proposal descriptions ;) | 14:30 |
| ralsina | mandel: I can change! Why? ;-) | 14:31 |
| mandel | ralsina: is sooooo much work to do hehehe :) | 14:31 |
| ralsina | mandel: I would make them easier if I could, trust me | 14:32 |
| ralsina | alecu: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800381/+merge/65502 | 14:49 |
| alecu | ralsina, ping | 15:00 |
| alecu | ralsina, I'm trying to test irl, but I'm getting the sso screen with no labels | 15:00 |
| alecu | ralsina, what it was that am I doing wrong???? :-( | 15:00 |
| ralsina | alecu: did you start the sso client before this? | 15:00 |
| alecu | ralsina, yes | 15:00 |
| ralsina | alecu: no idea then ;-( | 15:00 |
| ralsina | s/;/:/ | 15:01 |
| ralsina | I only get that when I don't start SSO | 15:01 |
| ralsina | you could try the page of this branch by moving it to the beginning of the wizard | 15:01 |
| ralsina | wait:the "login as existing user" page has no labels on the lineedits. It should have "sign in" in the button, though | 15:03 |
| ralsina | alecu: ^ | 15:03 |
| alecu | ralsina, right | 15:03 |
| alecu | ralsina, well, I'm seeing some pb errors on the log, so it might be the iocp reactor acting up. | 15:04 |
| ralsina | alecu: darn | 15:04 |
| alecu | ralsina, ok, since run-tests.bat has run successfully, I'll approve stating that my dev env is borked. | 15:04 |
| ralsina | alecu: ok | 15:05 |
| alecu | ralsina, and hopefully we'll switch the wizard to use qtreactor tomorrow too. | 15:05 |
| ralsina | alecu: if there are IRL problems they will show up in the next branch for this bug anyway | 15:05 |
| alecu | cool | 15:05 |
| ralsina | alecu: does that involve anything other than changing the main? I can do that. | 15:06 |
| alecu | ralsina, approved. | 15:06 |
| ralsina | alecu: yay! | 15:06 |
| alecu | ralsina, we need to change the main to use the qtreactor, and change the calls to sso to use some code that will start sso if it's not running. I still need to think a bit on how to do that. | 15:09 |
| ralsina | yes, the activation is tricky | 15:09 |
| alecu | ralsina, I'll first change -sso and u1-client, and then we'll use the same on u1cp and the wizard. | 15:09 |
| ralsina | alecu: sure | 15:10 |
| alecu | anyway, I'll probably do the activation after seeing all the pieces working together. | 15:10 |
| ralsina | mandel: on your branch, the os_helper tests pass, the code is OK, but I have no idea if it fixes the underlying problem because I don't know if you caught it everywhere that it happened. So, I am not sure if my approve is worth anything. | 15:26 |
| mandel | ralsina: lets get ask verterok | 15:26 |
| ralsina | nessita, mandel, alecu, thisfred, dobey: OBJECTIVES! | 15:27 |
| thisfred | ah, yes | 15:27 |
| ralsina | nessita, mandel, alecu, thisfred, dobey: can each of you make a first draft, then we chat a bit to polish? Due tomorrow? | 15:28 |
| dobey | oh yeah, we have to do that thing today | 15:28 |
| thisfred | I misread that as 'chat a bit in Polish', and thought, wow they don't make it easy | 15:28 |
| mandel | ralsina: objective => holidays, survive windows | 15:28 |
| dobey | bother. i totally forgot about that :( | 15:28 |
| mandel | ralsina: is that ok? | 15:28 |
| dobey | lol | 15:28 |
| ralsina | mandel: doesn't fill the year ;-) | 15:28 |
| mandel | ralsina: holidays can surely fill the year :) | 15:29 |
| thisfred | surviving hopefully does ;) | 15:29 |
| nessita | ralsina: AAAAAAAAAAAAAAAAHHHHHHHHHHHHHHHHHH | 15:29 |
| ralsina | nessita: agreed :-( | 15:29 |
| thisfred | ralsina: draft in the admin system or in email? | 15:30 |
| alecu | mandel, what does "survive windows" mean? not falling thru any? | 15:31 |
| mandel | alecu: and gates too | 15:32 |
| ralsina | thisfred: email would be easier for me | 15:33 |
| thisfred | kk | 15:34 |
| ralsina | damn 30-day months! | 15:34 |
| dobey | hi adorilson | 15:40 |
| adorilson | dobey: can you see my proposal merge? | 15:41 |
| adorilson | https://code.launchpad.net/~adorilson/ubuntuone-control-panel/fix-802069/+merge/66227 | 15:41 |
| dobey | adorilson: i haven't seen one yet, but i wanted to discuss with you, because i haven't been able to find the default compiler flags for fedora anywhere on google | 15:41 |
| dobey | adorilson: and i would very much like to know whwat those are | 15:42 |
| adorilson | dobey: ok, but this patch is not about this. is about another bug. | 15:43 |
| dobey | alecu: this is surviving windows: http://www.youtube.com/watch?v=zlMUswe8wY8 | 15:43 |
| dobey | oh | 15:44 |
| dobey | adorilson: oh, this seems incorrect | 15:44 |
| nessita | ralsina: is there any chance you buy us some time re: goals? | 15:47 |
| ralsina | nessita: sure | 15:47 |
| ralsina | nessita: monday is good? I can try to get that much | 15:48 |
| nessita | ralsina: well, Tuesday, since MOnday I'm not coming. Which reminds me, I need to swap this friday swap to later in time | 15:48 |
| ralsina | nessita: ok, will try to get tuesday. | 15:49 |
| Chipaca | ralsina: ping | 15:52 |
| ralsina | Chipaca: pong | 15:52 |
| mandel | dobey: this one is for you http://i.imgur.com/aqzMu.png | 15:54 |
| dobey | mandel: ^5 | 15:54 |
| mandel | :D | 15:54 |
| mandel | ralsina: uper quick easy review: https://code.launchpad.net/~mandel/ubuntuone-client/fix-708652/+merge/66322 | 15:55 |
| mandel | s/uper/super | 15:55 |
| ralsina | mandel: checking! | 15:57 |
| mandel | ralsina: one question, when you call the __init__ of your parent class, should that always be the first thing you call? | 15:58 |
| ralsina | mandel: no | 15:58 |
| ralsina | mandel: but you can't use anything from the parent class before that | 15:58 |
| ralsina | mandel: I am under strict suggestions to not approve anything without tests ;-) | 15:59 |
| mandel | ralsina: how the hell do i test that? | 15:59 |
| mandel | ralsina: that was in a polite tone, no screaming etc.. | 15:59 |
| ralsina | mandel: hahaha, beats me. Let me see some context. | 16:01 |
| ralsina | nah, no way to test it, +1 | 16:01 |
| mandel | :D | 16:02 |
| ralsina | it's a temporary value right in the middle of a method, so whatever | 16:02 |
| nessita | ralsina: I m having a terrible time tryng to have things running in the VM. Was alecu able to run your branch? | 16:02 |
| ralsina | nessita: he got reactor errors | 16:05 |
| ralsina | nessita: In any case, the IRL for that branch can be re-done after the next branch for the same bug | 16:05 |
| ralsina | nessita: but the tests passed! ;-) | 16:07 |
| nessita | ralsina: right, I ll approve then | 16:07 |
| ralsina | nessita: col, thx | 16:08 |
| nessita | ralsina: wait, did you fix test_credential_parameters docstring? LP may be lying | 16:08 |
| nessita | (it doesn't look fixed after a reload) | 16:09 |
| * ralsina checks | 16:09 | |
| ralsina | nessita: no, will fix before merging | 16:09 |
| ralsina | always one gets away :-( | 16:09 |
| nessita | ack | 16:10 |
| ralsina | nessita: pushed | 16:10 |
| nessita | gaaaaah I can't use ussoc twice in a row!!! | 16:12 |
| ralsina | nessita: 'stale reactor" error? | 16:13 |
| nessita | ralsina: no, ussoc just do not answer any request | 16:13 |
| nessita | ... | 16:13 |
| nessita | anyways, let's start over again! :-) | 16:13 |
| nessita | I'll grab some snack first | 16:14 |
| ralsina | food! good idea! | 16:16 |
| === ralsina is now known as ralsina_lunch | ||
| dobey | oh it's about that time | 16:16 |
| mandel | ralsina_lunch: ping? | 16:19 |
| mandel | ralsina_lunch: well, for later, seems that you approved https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_800376/+merge/66194 before you had a second review (I was on it) I have approved it but I suppose that tarmac will complain, but I'm not sure | 16:20 |
| ralsina_lunch | mandel: oh, damn, didn't notice | 16:21 |
| * ralsina_lunch confused two branches :-( | 16:22 | |
| ralsina_lunch | mandel: could you actually see it? | 16:22 |
| mandel | ralsina_lunch: yes, development has moved from dependency hell to branch hell | 16:22 |
| mandel | ralsina_lunch: the approve or the dialog? | 16:22 |
| ralsina_lunch | mandel: the dialog? | 16:22 |
| ralsina_lunch | ralsina_lunch: I mean, the dialog :-) | 16:23 |
| mandel | ralsina_lunch: yes, I had some issue but I think is because I did not follow the instructions | 16:23 |
| mandel | let me recheck | 16:23 |
| mandel | ralsina_lunch: yes, works | 16:24 |
| ralsina_lunch | mandel: ok, great | 16:24 |
| adorilson | dobey: I saw your comment. | 16:24 |
| ralsina_lunch | so, after luch, I can add the last page, then hack it all together | 16:24 |
| ralsina_lunch | yay! | 16:24 |
| adorilson | dobey: You means that we write just one line? | 16:26 |
| dobey | adorilson: i also commented on the make error bug. can you provide the default compiler flags on that bug report, from fedora? | 16:26 |
| dobey | adorilson: no, i mean the string literal should remain the way it was before your change, and you should only change the second line of that function call, to use the % (foo, bar) instead | 16:27 |
| dobey | adorilson: or preferrably use .format() notation instead of %-notation | 16:28 |
| dobey | since %-notation is deprecated | 16:28 |
| nessita | mandel: good news, seems like your fix to normapth is working (I still need to go thru the logs to confirm no exceptions are there) | 16:31 |
| dobey | ok, am off to lunch. bbiab | 16:31 |
| nessita | mandel: also, images are not corrupted, so yey!!!! | 16:31 |
| nessita | mandel: one down side is that I deleted a folder in the web UI, but that change is not being reflected locally in windows\ | 16:31 |
| nessita | mandel: any clues? | 16:32 |
| adorilson | dobey: ok. I'll fix | 16:32 |
| mandel | nessita: first time I see that… is it a udf or a folder inside root? | 16:32 |
| nessita | mandel: folder inside root, I haven't tested UDF's yet. Hum, looking at the logs I see an exception | 16:33 |
| nessita | OSError | 16:33 |
| nessita | mandel: will file bug | 16:33 |
| mandel | nessita: ok, that is good :) | 16:33 |
| nessita | mandel: yes! | 16:33 |
| nessita | you need reviews from me, for the normpath thingy? | 16:33 |
| mandel | nessita: let me check | 16:34 |
| nessita | (or anything else) | 16:34 |
| mandel | nessita: yes please normpath is here: https://code.launchpad.net/~mandel/ubuntuone-client/fix-802738/+merge/66292 | 16:34 |
| nessita | ralsina_lunch: swap day re-swapped | 16:35 |
| nessita | mandel: looking | 16:35 |
| mandel | nessita: there is an explanation of why abspath is used as a TODO, the branch that fixes tritcask is approved so I'll file a low level bug pointing to those todo comments | 16:35 |
| nessita | mandel: please! | 16:36 |
| mandel | nessita: also, can you let me know your bug, I think i'll fix that one faster than the one of the events | 16:36 |
| mandel | which seems to be easy.. and event mask is missing | 16:36 |
| nessita | mandel: the OSError? yes, will report that before the review, on sec | 16:37 |
| mandel | nessita: do you know which changes where made regarding pyinotify? it could be realted since I use the same masks | 16:37 |
| nessita | mandel: no idea, no | 16:37 |
| nessita | mandel: bug #803507 | 16:43 |
| ubot4 | Launchpad bug 803507 in ubuntuone-client "OSError when deleting a folder (windows version) (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/803507 | 16:43 |
| nessita | brb | 16:45 |
| mandel | nessita: great! that is a piss of cake, os.listdir is appending / instead of os.path.sep, we have to apend it so that listdir does not behave like a retard :) | 16:45 |
| nessita | :-) | 16:57 |
| thisfred | even when he's not trying to be offensive... ;) | 16:58 |
| thisfred | o wait, strike that I didn't read the whole sentence. | 16:58 |
| mandel | thisfred: I should have said piece, I dont know what I was thinking... | 17:02 |
| * mandel looks at the second monitor… no piss porn there... | 17:02 | |
| nessita | mandel: for future coding, I've notice you use different names for the test cases. I've seen FooTestCase, FooTests and TestFoo | 17:03 |
| nessita | mandel: if possible, please let's use FooTestCase | 17:03 |
| mandel | nessita: ok | 17:03 |
| nessita | mandel: setUp in TestSpecialOSCalls is not needed, can you please remove? | 17:03 |
| mandel | nessita: yes | 17:04 |
| nessita | mandel: that would be all from eye-review, now I'll branch and run tests | 17:07 |
| mandel | nessita: I'll wait to push the branchin case you have more omments | 17:07 |
| nessita | mandel: while tests run, I would like you to analize http://pastebin.ubuntu.com/635142/, that log is from this last run in w7. The OSError is the reported above, but there are several WindowsError: [Error 2] The system cannot find the file specified: '\\\\?\\C:\\Users\\Test\\Ubuntu One\\empty' | 17:12 |
| mandel | nessita: sees to be a diff issue… I wonder did you get those paths in your machine when you performed the sync? | 17:14 |
| nessita | yes | 17:14 |
| mandel | nessita: hm.. interesting, is there a way were we can find a better trace for one of those? | 17:15 |
| mandel | nessita: I'd say that is a diff bug altogether, but at leadt we not that _idx_path has the correct info | 17:15 |
| nessita | mandel: what do you mean by better trace? those logs are in DEBUG mode, not sure what else I can provide :-) | 17:16 |
| mandel | nessita: true… I'd like to know who is callig the stat method | 17:17 |
| mandel | seems to be VM, I'll grep for it | 17:17 |
| nessita | mandel: good news is that the only other Error there is the already known | 17:19 |
| nessita | 23:736:exceptions.KeyError: 'Unhandled Event in INotify: <Event dir=True mask=0x40000020 maskname=IN_OPEN|IN_ISDIR name=images path=. pathname=\\\\?\\C:\\Users\\Test\\Ubuntu One\\images wd=0 >' | 17:19 |
| nessita | mandel: so, :-) | 17:19 |
| nessita | mandel: I'll work a little on running the control panel tests on windows, to detect all possible paths issues. Then I'll do some testing with UDF and shares | 17:19 |
| mandel | nessita: yes, I do you know why is that one? we are dealing with opening folders, which is something that pyinotify does not care about :) | 17:20 |
| mandel | nessita: I'm working on that event one right now | 17:20 |
| nessita | mandel: not sure what you're asking me if I know about. Can you please re-ask? Also, branch approved, so please push fixes before landing (beh, actually seeking another review) | 17:21 |
| mandel | nessita: nothing, I was saying I know how to fix it :) | 17:22 |
| nessita | great! | 17:22 |
| ralsina_lunch | nessita: swap-swap-day ap-ap-proved | 17:28 |
| nessita | :-) | 17:28 |
| nessita | no, lunchtime! | 17:29 |
| * nessita -> brbs | 17:29 | |
| === ralsina_lunch is now known as ralsina | ||
| mandel | ralsina, alecu: I need one more review here: https://code.launchpad.net/~mandel/ubuntuone-client/fix-802738/+merge/66292 | 17:42 |
| ralsina | mandel: on it ASAP | 17:43 |
| mandel | ralsina: I think you already did it, is the one you were not sure about | 17:44 |
| ralsina | yes, want to see the new diff and that's all | 17:44 |
| ralsina | mandel: +1 | 17:45 |
| mandel | cool | 17:46 |
| * mandel afternoon dog walk | 17:58 | |
| dobey | meh | 18:18 |
| * nessita is back | 18:18 | |
| ralsina | nessita: small problem using the "add folder" button: https://pastebin.canonical.com/49186/ | 18:19 |
| nessita | looking | 18:20 |
| nessita | ralsina: right, we don't have (yet) integration with syncdaemontool in windows | 18:20 |
| nessita | ralsina: let me build a branch for that right now | 18:21 |
| ralsina | nessita: ok, then it works ;-) | 18:21 |
| === alecu is now known as alecu-lunch | ||
| nessita | ralsina: can you plaese file a bug so I work on that? | 18:24 |
| ralsina | nessita: sure, bug #803560 | 18:27 |
| ubot4 | Launchpad bug 803560 in ubuntuone-control-panel "AddFolderButton calls unimplemented get_root_dir method in sd_client (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/803560 | 18:27 |
| nessita | thanks | 18:27 |
| nessita | ralsina: great work setting the tag properly! :-) | 18:29 |
| * ralsina learns eventually | 18:29 | |
| karni | You Android guys! Check out Ubuntu One Files for Android :) https://market.android.com/details?id=com.ubuntuone.android.files | 18:29 |
| thisfred | nessita: alecu-lunch dobey: no idea why or for how long, but the launcher does not work for me on natty in that I never get to see the progress bar, or anything else I set on it, even though the code does not fail. Even when I don't use our own code. Can any of you test this script: http://paste.ubuntu.com/635202/ | 18:38 |
| thisfred | did we change/break the .desktop file maybe? | 18:38 |
| dobey | thisfred: well i don't have an 11.04 system with unity. does the same problem occur in oneiric? | 18:38 |
| nessita | thisfred: not that I know of | 18:39 |
| thisfred | dobey: please try it on oneiric too | 18:39 |
| thisfred | I'll do the same | 18:39 |
| nessita | (ie I don't think we broke the .desktop file) | 18:39 |
| nessita | thisfred: I can test when I boot my natty VM, where I run unity | 18:39 |
| dobey | thisfred: maybe i'm not understanding the problem them. are you saying that this code itself doesn't work? | 18:39 |
| thisfred | dobey: it does not error, but no progress bar shows up | 18:39 |
| adorilson | dobey: do you means this: http://paste.ubuntu.com/635188/ ? | 18:40 |
| dobey | thisfred: so there is no main loop set up in that script... | 18:40 |
| dobey | thisfred: which tells me the dbus stuff doesn't actually get called there | 18:40 |
| thisfred | oh god | 18:40 |
| thisfred | thx :) | 18:40 |
| thisfred | nessita: false alarm, most likely | 18:40 |
| thisfred | I'm testing out of context again | 18:40 |
| nessita | thisfred: OH | 18:41 |
| thisfred | dobey: still weird that the properties get set though | 18:41 |
| nessita | thisfred: let me know | 18:41 |
| dobey | adorilson: hi, no, that is also incorrect | 18:41 |
| thisfred | dobey: and I still don't see a progress bar when uploading/downloading | 18:41 |
| thisfred | but that may have a different cause then | 18:41 |
| dobey | adorilson: 'some string {} says something {}'.format(first, second) for example | 18:41 |
| dobey | thisfred: they objects internally probably get properties set, but those properties probably don't sent over the bus to the server :) | 18:42 |
| dobey | thisfred: fait accompli of python :) | 18:42 |
| thisfred | dobey: when I add DBusGMainloop(set_as_default=True) it still does not work | 18:43 |
| thisfred | dobey: fait accompli? | 18:43 |
| ralsina | nessita: is your new branch like "milanesas para todos"? ;-) | 18:44 |
| nessita | lol | 18:44 |
| adorilson | dobey: ok. a second | 18:44 |
| dobey | thisfred: did you create and run a main loop? | 18:45 |
| dobey | thisfred: or just make that one call? | 18:45 |
| thisfred | I just made that call | 18:46 |
| thisfred | so do I need a gtk mainloop? | 18:46 |
| dobey | thisfred: so, the Unity stuff is going through a C library, not through Python, so the DBus bits don't complain like they would normally | 18:46 |
| dobey | thisfred: the DBusGMainLoop isn't going to do anything in this case, really. but you do have to create and run a glib main loop | 18:46 |
| thisfred | or complain when they wouldn't normally. The counter is wonky for instance | 18:47 |
| dobey | thisfred: mistakes would probably be more obvious were you using C instead. using gir through python can be odd sometimes :) | 18:48 |
| thisfred | dobey: yeah works with glib MainLoop, never mind the dolt in the corner | 18:52 |
| thisfred | eating the paste | 18:52 |
| dobey | thisfred: if it's not working from syncdaemon, i think maybe there's another issue | 18:54 |
| dobey | i know i've definitely seen it working before :) | 18:54 |
| thisfred | yeah, me too, so I wonder | 18:54 |
| ralsina | nessita: done adding the u1cp widgets to the wizard, I will be blocked on bug #803560 pretty soon. No worries though, I can switch to improving the SSO UI until you have it ready. | 18:55 |
| ubot4 | Launchpad bug 803560 in ubuntuone-control-panel "sd_client code should be multiplatform (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/803560 | 18:55 |
| nessita | ralsina: ack | 18:56 |
| dobey | thisfred: have you compared nightlies vs. what's in 11.04? | 18:56 |
| nessita | ralsina: did you implement all the calling the backend to validate and creating a folder? (if so, wow) | 18:56 |
| ralsina | nessita: no, because since it throws exception when I click the button there's no point | 18:56 |
| ralsina | nessita: I will do it for the default folders I add, and then I am blocked | 18:57 |
| thisfred | dobey: not yet, but I'm not 100% convinced there is a problem yet. Trying to find a good test case | 18:57 |
| nessita | ralsina: ack | 18:57 |
| adorilson | dobey: and now? http://paste.ubuntu.com/635218/ | 18:57 |
| adorilson | see that I'm respect the 80 columns | 18:58 |
| dobey | adorilson: you don't need the \ continuation there; and the .format( should be on the same line that the string literal ends on, and put the arguments to format() on the next line | 18:58 |
| adorilson | dobey: like this | 19:00 |
| adorilson | 'Unable to generate python module {py_file}' | 19:00 |
| adorilson | ' for resource file {qrc_file}'.format( | 19:00 |
| adorilson | py_file=py_file, qrc_file=qrc_file) | 19:00 |
| adorilson | ? | 19:00 |
| dobey | yep | 19:00 |
| adorilson | finally... | 19:01 |
| dobey | with correct whitespace alignment. if you have pep8 and pylint (ubuntuone-dev-tools) installed, you should run ./run-tests and it will run both | 19:01 |
| * mandel back | 19:09 | |
| nessita | ralsina: so, I'm pushing the branch with the needed changes. You should notice that this will no work on windows just yet, since we need to have all the pieces working (and we need the HUGE work that alecu is doing). What I mean is: in order this to work, you'd need both ussoc and latest syncdaemon running in your env to be able to run this code (I'm not sure that is possible at the moment) | 19:14 |
| nessita | on the other hand, I'll be testing that shortly | 19:15 |
| ralsina | nessita: no problem, I have the code written on my side, block on that and can context switch | 19:15 |
| nessita | perfect | 19:15 |
| ralsina | Any reviews pending? I have a free hour! | 19:16 |
| nessita | ralsina: I'm about to | 19:16 |
| ralsina | nessita: good. I'll go set up the mate | 19:17 |
| nessita | ralsina: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/sd-client-for-everyone/+merge/66368 | 19:17 |
| nessita | :-) | 19:17 |
| nessita | mandel: ping | 19:17 |
| nessita | mandel: any reviews for ralsina or me? | 19:17 |
| === alecu-lunch is now known as alecu | ||
| nessita | mandel: I just reported bug #803591 as Medium, so you can fix when possible (no priority) | 19:19 |
| ubot4 | Launchpad bug 803591 in ubuntuone-client "Windows: Logs shoul not be stored under "Temporary Internet Files" (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/803591 | 19:19 |
| mandel | nessita: nearly done with the events bug, trying to find a decent wayt to test it | 19:20 |
| nessita | mandel: no problem | 19:20 |
| adorilson | dobey: I'm having problems with ./setup build (and ./run-tests too) :-/ | 19:22 |
| nessita | ralsina: I'll give the current code in windows-installer a IRL round of tests, so be prepared | 19:23 |
| * nessita wants to use this last hour of ralsina's time :-P | 19:23 | |
| * ralsina looks for his helmet | 19:24 | |
| dobey | adorilson: what problems? | 19:24 |
| adorilson | dobey: Segmentation fault (core image recorded) | 19:25 |
| nessita | ralsina: ẁhat should I install for 'intlool-update'? | 19:25 |
| ralsina | nessita: no idea. Works anyway. | 19:25 |
| dobey | adorilson: oh. uhm, do you have backtraces? | 19:25 |
| dobey | nessita: intltool | 19:25 |
| ralsina | nessita: although of course that means we don't have translations | 19:26 |
| nessita | dobey: as with easy_install? | 19:26 |
| dobey | nessita: no, it is not a python thing | 19:26 |
| ralsina | dobey: I installed intltool on windows and I have no idea where intltool-update is :-) | 19:26 |
| ralsina | nessita: it's a gettext thing | 19:26 |
| dobey | ralsina: how did you install it? | 19:26 |
| * ralsina reads notes... | 19:27 | |
| nessita | ralsina: ARGH, the reactor exploded | 19:28 |
| ralsina | nessita: that sounds bad | 19:28 |
| dobey | well, building it on windows requires mingw/cygwin and all the autotools stuff; but the scripts should run if everything is installed | 19:28 |
| ralsina | forget about intltool on windws. I had installed gettext | 19:28 |
| adorilson | dobey: no. this is the only output | 19:29 |
| ralsina | hahaha, "I will make a release for windows son" (dobey, 2005) :-D | 19:29 |
| ralsina | http://osdir.com/ml/freedesktop.intltool/2005-04/msg00003.html | 19:29 |
| ralsina | s/son/soon/ | 19:29 |
| dobey | ralsina: release != build for win32 :) | 19:30 |
| nessita | ralsina: http://pastebin.ubuntu.com/635246/ | 19:30 |
| dobey | ralsina: intltool now works on win32 (as of that release), though | 19:30 |
| nessita | alecu: ping | 19:31 |
| dobey | was one of the requirements to making evolution builds on windows, back in the day :) | 19:31 |
| alecu | nessita, pong | 19:31 |
| ralsina | nessita: whoa. | 19:31 |
| nessita | dobey: SO YOU KNOW WINDOWS | 19:31 |
| dobey | anyway | 19:31 |
| nessita | alecu: I'm getting this when running ralsina's installer, is what you got as well? http://pastebin.ubuntu.com/635246/ | 19:31 |
| nessita | :-) | 19:32 |
| dobey | i know some of my games require windows to run :) | 19:32 |
| alecu | nessita, yes. That looks like txnamedpipes repeating some lines | 19:32 |
| ralsina | anyway, we don't really need intltool on windows, we can use it on linux | 19:32 |
| adorilson | dobey: BTW, can you aprove this? http://paste.ubuntu.com/635239/ | 19:34 |
| dobey | ralsina: well, don't need it now, but if we want to provide translations… :) | 19:34 |
| dobey | adorilson: did you commit and push it, in your branch? | 19:34 |
| nessita | ralsina, alecu: in case this adds up any info, I'll say that this happens every single time for me. But I don't think that gives any further clue. | 19:35 |
| ralsina | dobey: why would we have to do the translations on the windows boxes? We can extract the strings and translate as usual. | 19:35 |
| dobey | adorilson: the whitespace alignment looks alightly off, but i can't tell if that's due to the diff formatting or not | 19:35 |
| nessita | ralsina: is it intended that the "close this window and setup later" in in the left corner, instead pf right corner? | 19:35 |
| dobey | ralsina: well i'm sure chinese users might want to see chinese in the UI for example :) | 19:35 |
| ralsina | nessita: yes. Wireframe. | 19:36 |
| nessita | ralsina: and then, the sign in screen shows 2 entry text widgets and a button, but everything is "blank" (no text anywhere) | 19:36 |
| dobey | ralsina: but i think translations are an aside at the moment, as well. we've not been particularly good about keeping them updated | 19:36 |
| ralsina | nessita: the empty labels/buttons are because your SSO is not running, AFAK | 19:36 |
| nessita | ralsina: it is | 19:37 |
| nessita | I can triple confirm it is | 19:37 |
| ralsina | nessita: then it's not connecting to it. Do you get ENOENT on the wizard console? | 19:37 |
| nessita | ralsina: nopes, I keep getting the KeyError: 2 | 19:37 |
| adorilson | dobey: the formatting is ok. do you means the 11 and 12 lines ? | 19:37 |
| ralsina | nessita: Then it's crashing before connecting, I suppose | 19:38 |
| dobey | adorilson: yes, it's not aligned with the previous line. | 19:38 |
| nessita | ralsina: okis. Question, does your code check for current credentials in the system? is asking me to login and I'm already logged in to Ubuntu One | 19:38 |
| ralsina | nessita: doesn't check because you are not supposed to run it after you have credentials, and because it makes it harder to test | 19:39 |
| nessita | ralsina: ok, I'll file a bug to fix this later, since we can't expect people not running this without credentials. Is not needed to tweak now. | 19:40 |
| adorilson | dobey: review http://paste.ubuntu.com/635249/ | 19:40 |
| ralsina | nessita: that line has probably one or two nots too many for my parser, but ... ok? ;-) | 19:40 |
| dobey | adorilson: can you commit/push in your proposed branch please | 19:40 |
| nessita | ralsina: hehe, I meant we can deal with this later, but I'll file the bug to not forget | 19:41 |
| ralsina | nessita: sure, assgn to me as triaged | 19:41 |
| nessita | :-) | 19:41 |
| * ralsina doesn't want to add 'clear credentials' step to his already excessive IRL test instructions yet | 19:42 | |
| nessita | ralsina: nonono, i agree | 19:42 |
| adorilson | dobey: ok. I'll change the others %-notation in this same method, before. all right? | 19:42 |
| dobey | adorilson: i don't think it's necessary to do that, as they are unrelated to the bug | 19:43 |
| nessita | bug #803595 | 19:43 |
| ubot4 | Launchpad bug 803595 in ubuntuone-windows-installer "Wizard does not check for credentials already in the system (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/803595 | 19:43 |
| adorilson | dobey: ok. I do this after | 19:43 |
| nessita | ralsina: did you got my link for review? may be lost since you went for mate when I pasted it | 19:44 |
| ralsina | nessita: missed it. On it now1 | 19:44 |
| nessita | thanks! | 19:44 |
| dobey | adorilson: i think it's something we need to do in all our projects, so probably should have some grandiose bug for converting everything to use .format() instead | 19:45 |
| mandel | nessita, ralsina: can you merge this: lp:~mandel/ubuntuone-client/fix-802726 with trunk and test that is solves the issue with the events? | 19:53 |
| nessita | mandel: sure | 19:53 |
| ralsina | mandel: I don't think I will have time before I have to stop | 19:53 |
| mandel | nessita, ralsina: I'v added tests, but they are the filesystem ones and will be annoying | 19:53 |
| mandel | ralsina: EOD? | 19:53 |
| ralsina | mandel: I have to EOD very early because of E_NO_NANNY | 19:54 |
| mandel | ralsina: ouch | 19:54 |
| nessita | mandel: I can try it | 19:54 |
| mandel | nessita: cool :) | 19:54 |
| ralsina | nessita: I am trying your sd_client branch and there is still some linuxisms there: https://pastebin.canonical.com/49192/ | 19:55 |
| ralsina | nessita: or it may be just a case of me not having something in PATH | 19:56 |
| nessita | ralsina: looking | 19:57 |
| nessita | ralsina: is a bug! let me fix it, I need to import from platform | 19:57 |
| dobey | hmm, goals eh | 19:58 |
| adorilson | dobey: pushed | 20:01 |
| dobey | nessita: http://pastebin.ubuntu.com/635265/ <- any ideas about this? happening on lucid in sso trunk | 20:03 |
| nessita | dobey: looking | 20:04 |
| mandel | nessita: ping | 20:04 |
| nessita | ralsina: running tests, about to push | 20:04 |
| nessita | mandel: pong | 20:04 |
| mandel | nessita: have you been using the zomg tag in the latests bug you reported? | 20:04 |
| nessita | dobey: httplib2 backport/sru issue? | 20:05 |
| mandel | nessita: I remember one about an illegal path but I cannot find it | 20:05 |
| nessita | dobey: looks like a dns(ish) issue or similar | 20:05 |
| mandel | nessita: it was of the form WindowsError illegal\path\like\this/*.* | 20:05 |
| nessita | mandel: yes, I have. How are you searching? | 20:05 |
| ralsina | dobey: the only way for urllib2 to give that error is have "ftp:" as the URL, AFAIK | 20:05 |
| mandel | nessita: by tag | 20:05 |
| nessita | mandel: under which project? | 20:05 |
| dobey | nessita: why is it trying to hit the network at all in the test though? :) | 20:06 |
| dobey | and i haven't backported httplib2 | 20:06 |
| mandel | nessita: ubuntuone-client | 20:06 |
| dobey | and lucid has 0.6.0-1 | 20:06 |
| nessita | mandel: http://bit.ly/laUrZs | 20:08 |
| nessita | mandel: anyways, the bug was bug #803507 (and it has the tag) | 20:08 |
| ubot4 | Launchpad bug 803507 in ubuntuone-client "OSError when deleting a folder (windows version) (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/803507 | 20:08 |
| dobey | nessita: and all the changes in 10.10/11.04 to python-httplib2 are all packaging changes afaict "build with python3 support, use dh_python2, etc…" | 20:09 |
| nessita | dobey: oh, is that a test run? sound weird | 20:09 |
| dobey | nessita: yep, see line 1 in the pastebin :) | 20:09 |
| mandel | nessita: your launchpad foo is better than mine :) | 20:09 |
| nessita | dobey: so looks like a patching issue, maybe setUp/tearDown not correctly used? | 20:09 |
| dobey | hrmm, maybe | 20:09 |
| nessita | dobey: we patch urllib in setUp | 20:09 |
| nessita | dobey: so this smells like related to that. I can help debug, but not today, sorry :-( | 20:10 |
| dobey | nessita: is the patch from mocker, or from twisted? | 20:10 |
| nessita | dobey: twisted | 20:10 |
| dobey | ok | 20:10 |
| nessita | ralsina: pushing | 20:11 |
| nessita | ralsina: Pushed up to revision 178. | 20:11 |
| ralsina | nessita: cool, pulling :-) | 20:11 |
| nessita | mandel: OH. I created a folder from windows, and added a bmp in it. The directory was created in my cloud, but the file was not :-( | 20:13 |
| nessita | mandel: gathering logs now | 20:13 |
| nessita | mandel: syncdaemon seems to be stucked somehow, since is still in WORKING state, but nothing is being actually done | 20:15 |
| mandel | nessita: that could be tha cache… but 100 other things too :( | 20:15 |
| ralsina | nessita: goes further, get this: https://pastebin.canonical.com/49193/ --- and I have to go pick up the kid | 20:16 |
| nessita | ralsina: ack] | 20:16 |
| ralsina | See you later #ubuntuone! | 20:16 |
| nessita | ralsina: if you read this later, that is now related to syncdaemon code | 20:17 |
| nessita | ralsina: so, is the thing I mentioned before, we need all the pieces of the puzzle running together in order to the control panel to work | 20:18 |
| mandel | nessita, ralsina, alecu: EOD for me, 21:21 see you all tom | 20:21 |
| === mandel is now known as mandel_resting | ||
| dobey | hrmm | 20:23 |
| dobey | we don't patch urllib | 20:23 |
| nessita | dobey: we do! let me find that for you | 20:24 |
| dobey | not in test_account.py anyway, but i am debugging :) | 20:24 |
| dobey | and it's a file:// url on 11.04 in the test at least, so hrmm | 20:25 |
| nessita | oh | 20:25 |
| dobey | i at least do have lucid available to test a few things on, since i have a server :) | 20:33 |
| dobey | huh | 20:34 |
| dobey | and it's a file:// url on lucid too | 20:34 |
| dobey | wtf. | 20:34 |
| dobey | hrmm | 20:48 |
| dobey | adorilson: you didn't need to resubmit the proposal, btw | 20:49 |
| thisfred | dobey: I'm trying to test on oneiric, but having some weird trouble: I cannot connect: I threw away the token, then I thought I had the wrong password maybe to authenticate the device, asked for and got a new one, but whenever I enter it, I see the string 'An exception representing an authentication failure' in red, which is a terrible error message. (Looks like we're showing an exception doc string??) | 20:50 |
| thisfred | this is the control panel, obviously | 20:50 |
| thisfred | I also see *two* icons in the launcher, does the login dialog really need its own icon? | 20:51 |
| dobey | thisfred: and you have the latest stuff? | 20:51 |
| thisfred | I am dist upgraded with nightlies | 20:51 |
| dobey | thisfred: the SSO dialog is a separate process/application/not-specific-to-u1 | 20:51 |
| thisfred | hm ok | 20:51 |
| thisfred | ugly, but I suppose we have to live with that | 20:52 |
| dobey | so yes it does need its own icon, but the icon it has might suck | 20:52 |
| dobey | and we should fix that icon | 20:52 |
| thisfred | oh, and now my machine rebooted itself. I'm thinking the control panel is the least of my worries | 20:52 |
| thisfred | I still get: runtime directory '/run/udev' not writeable | 20:53 |
| thisfred | on every boot | 20:53 |
| dobey | i do too | 20:53 |
| thisfred | oh ok | 20:53 |
| dobey | i think it's trying to do something before root is remounted | 20:53 |
| nessita | alecu, someone else, can I have a couple of reviews for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/sd-client-for-everyone/+merge/66368 ? | 20:53 |
| thisfred | also it seems to take a random selection of indicators to show each section | 20:54 |
| thisfred | nessita: I'll take one | 20:54 |
| nessita | thisfred: GENIAL! | 20:55 |
| nessita | thisfred: test IRL would be to confirm both -gtk and -qt panels are working properly | 20:55 |
| thisfred | kk | 20:55 |
| alecu | nessita, can we trade? https://code.launchpad.net/~alecu/ubuntu-sso-client/use-qtreactor/+merge/66380 | 20:59 |
| nessita | alecu: of course! | 20:59 |
| * nessita reviews | 20:59 | |
| nessita | alecu: question, shouldn't we calling app.exit() the same? | 21:08 |
| nessita | on shutdown, that is | 21:08 |
| alecu | nessita, I think not, but let me check. | 21:08 |
| nessita | ack | 21:08 |
| nessita | alecu: other question, shouldn't the show_gui use the qtreator? (importing only from twisted.internet import reactor will install the default reactor) | 21:10 |
| alecu | nessita, I think we should not, but let me check. | 21:16 |
| ralsina | Calling app.quit() is not necessary unless you called app.exec_() | 21:17 |
| adorilson | dobey: ok. it is my first time with bazar and code.launchpad | 21:18 |
| dobey | adorilson: sure. good time for you to learn then :) | 21:19 |
| adorilson | yeap | 21:19 |
| alecu | nessita, I just double checked, and roberto is right: we don't need the app.exit anymore. | 21:25 |
| nessita | alecu: thanks for checking. Any thoughts on the show_gui question? | 21:26 |
| alecu | nessita, show_gui.py does not need the qt reactor, because it does not show any gui. | 21:26 |
| alecu | nessita, it just calls sso thru pb+tcp | 21:27 |
| nessita | alecu: you, clever. Thanks. | 21:27 |
| nessita | alecu: approving | 21:27 |
| ralsina | alecu: need a second review? | 21:27 |
| thisfred | I also like the new feature in oneiric where when the screenaver locks your screen, and you don't enter your password in time, it's locked forever, saying 'time expired' | 21:27 |
| nessita | ralsina: did you see my comment re your last paste? I mostly want to be sure you understand where we're at with this integration | 21:28 |
| alecu | nessita, anyway: I tested if the qtreactor needed the app.exit by adding the qtreactor to show_gui, and watching it shut down cleanly. | 21:28 |
| nessita | alecu: right | 21:28 |
| alecu | ralsina, sure, a second review is appreciated: https://code.launchpad.net/~alecu/ubuntu-sso-client/use-qtreactor/+merge/66380 | 21:28 |
| ralsina | nessita: yes, I was just seing how far that went. I think it may go a bit farther if syncdaemon were running at the time | 21:28 |
| nessita | ralsina: lol | 21:28 |
| ralsina | nessita: so, I am about to +1 that branch | 21:28 |
| nessita | alecu: I was asking since the controlpanel, which only calls reactor.stop, does not stops when closing the app, but between 10 seconds to 60 seconds later | 21:29 |
| nessita | on linux | 21:29 |
| alecu | nessita, on linux! | 21:29 |
| nessita | I added app.quit when doing a test and that will not work either, and what you and ralsina say, explain why it did not help | 21:29 |
| nessita | alecu: yeap (controlpanel that is) | 21:30 |
| nessita | alecu: I *think* (hand waving) that the webclient is preventing the reactor to fully stop | 21:30 |
| alecu | nessita, hmmm... no ideas yet. | 21:30 |
| * ralsina proposes killing our own PID (jk) | 21:30 | |
| nessita | becasue when I ctrl+c the process, I get webclient traces | 21:30 |
| alecu | ralsina, os.seppuku? | 21:31 |
| nessita | but who knows if that is just coincidence | 21:31 |
| ralsina | alecu: exactly! | 21:31 |
| ralsina | nessita: is that with the qt-based web client? | 21:31 |
| nessita | ralsina: yes, control-panel-qt on linux | 21:31 |
| ralsina | nessita: that uses threads, I think | 21:31 |
| nessita | ralsina: threads where? | 21:32 |
| alecu | ralsina, we never ended up moving to the qt-based web client, I think. We'll probably revisit that after moving all to qtreactor. | 21:32 |
| ralsina | Ok, forget it ithen ;-) | 21:32 |
| alecu | we are currently using the twisted web client. | 21:32 |
| dobey | ah-hah! | 21:32 |
| nessita | thisfred: I will leave the name StatusMockDBusSyncDaemon since is from existent code... if that's ok with you | 21:32 |
| dobey | nessita: i found the problem, but no idea why it was working on newer versions of ubuntu :( | 21:33 |
| nessita | alecu: no review needed, thisfred made one and ralsina is approving as well | 21:33 |
| thisfred | nessita: yeah sure | 21:33 |
| nessita | dobey: shoot | 21:33 |
| ralsina | reactor.stop() is supposed to kill any pending perations, right? | 21:33 |
| alecu | nessita, cool, thanks. | 21:33 |
| ralsina | nessita: +1 on https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/sd-client-for-everyone/+merge/66368 | 21:34 |
| alecu | ralsina, yes, reactor.stop should cancel pending operations. Anyway, I'll check it tomorrow when I get to control panel on windows. | 21:34 |
| ralsina | alecu: ok | 21:35 |
| ralsina | alecu: +1 on https://code.launchpad.net/~alecu/ubuntu-sso-client/use-qtreactor/+merge/66380 | 21:35 |
| nessita | alecu: I loved that last sentence from you! | 21:35 |
| dobey | nessita: 'file:///%s' % path | 21:35 |
| nessita | ralsina: if you still have a review slot, a trivial one: https://code.launchpad.net/~nataliabidart/ubuntuone-client/fix-803598/+merge/66383 | 21:36 |
| ralsina | nessita: sure, kid fell asleep because he had swimming lessons today :-) | 21:36 |
| nessita | ralsina: I need to clean up the logs in windows a bit, if we want to debug stuff that are happening | 21:36 |
| ralsina | yes, the debug logs are monstrous | 21:36 |
| nessita | ralsina: swimming + ear infection is not a winner combo, but what do I know, I'm not a parent :-D | 21:36 |
| ralsina | nessita: earplugs! | 21:37 |
| nessita | ah! | 21:37 |
| nessita | dobey: @more | 21:37 |
| alecu | :-) | 21:37 |
| ralsina | It's that or he was not going to school | 21:37 |
| * ralsina was a competitive swimmer with chronic ear infections for ohh.... 3 years. | 21:37 | |
| dobey | nessita: it doesn't like having 4 slashes | 21:38 |
| ralsina | nessita: +1 seems trivial to me | 21:38 |
| nessita | dobey: you fixing please? | 21:38 |
| nessita | dobey: nessita reviews | 21:38 |
| ralsina | that should use urljoin instead of % | 21:38 |
| * alecu was a /competent/ swimmer once upon a time. | 21:39 | |
| dobey | nessita: yes, filing a bug and fixing | 21:39 |
| nessita | dobey: thanks! | 21:39 |
| ralsina | alecu: well, I competed, doesn't mean I won much ;-) | 21:39 |
| alecu | ralsina, I know you competed, was just joking :-) | 21:39 |
| ralsina | alecu: :-) | 21:40 |
| dobey | swimming is for fish | 21:41 |
| ralsina | dobey: fishes are for eating. Therefore, swiming is for eating? | 21:42 |
| dobey | things that swim are for eating | 21:42 |
| dobey | also, some things that don't swim | 21:43 |
| ralsina | the saying here is "anything that walks can be barbecued". Then again, we do barbecue fish also. | 21:44 |
| dobey | well, some fish can walk | 21:45 |
| dobey | so it's a win | 21:45 |
| nessita | alecu: any special instruction to install qt4reactor on windows? or just install git and clone inside the repo? | 21:46 |
| ralsina | nessita: installing git on windows is not exactly trivial :-( | 21:46 |
| dobey | download snapshot tarball from github | 21:47 |
| dobey | extract, move on | 21:47 |
| nessita | dobey: makes sense, thanks | 21:47 |
| ralsina | alecu: merge failed with lint about qt4 reactor import error | 21:48 |
| alecu | nessita, since I share my linux fs with the VM, I just symlink the cloned folder. | 21:49 |
| nessita | alecu: ah... | 21:49 |
| alecu | nessita, I guess that you can install it on lib/site-packages | 21:49 |
| nessita | right | 21:49 |
| nessita | ok, I'm eoding now since I need to cook dinner for some guests | 21:55 |
| nessita | see ya tomorrow, crowd! | 21:55 |
| * nessita will send report in a few minutes | 21:55 | |
| alecu | bye! | 21:55 |
| ralsina | bye nessita! | 21:59 |
| === m_conley is now known as m_conley_away | ||
| thisfred | dog o'clock! | 22:31 |
| thisfred | later all | 22:31 |
| dobey | nessita: https://code.launchpad.net/~dobey/ubuntu-sso-client/fix-urlerror/+merge/66392 is trivial when you see it. :) | 22:33 |
| dobey | ok, i am off. good evening all! | 22:33 |
| Monotoko | hey guys...has Ubuntu One Contact for the iPhone been pulled? | 22:42 |
| beuno | Monotoko, it has | 22:52 |
| Monotoko | beuno, ahhh...how come? | 22:52 |
| beuno | Monotoko, http://voices.canonical.com/ubuntuone/?p=943 | 22:54 |
| Monotoko | beuno, I see...thank you very much | 22:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
