[00:45] <nessita> dobey: approved, but with a comment to fix a wrong docstring
[03:47] <tntc> The ubuntu one mobile player supports m4a, but doesn't grab album info and stuff?
[03:47] <tntc> (on Android)
[04:44] <igormorgado> hello! how can I mount/sync my ubuntu one storage in a computer without X/Gnome? any howtos? which package? i cannot find u1sync in 11.04. any tips?
[08:25] <mandel> morning
[08:56] <fagan> be back in an hour need to get milk
[08:56] <fagan> (and other bits and bobs but wont be that long)
[09:50] <mandel> Chipaca: ping
[09:50] <Chipaca> mandel: pong
[09:51] <mandel> Chipaca: do you have any clue of a mode similar to r+w to be used with os.fdopen? r+w is an illegal mode on windows..
[09:51] <Chipaca> mandel: 1 sec
[09:53] <Chipaca> mandel: r+w is an unspecified mode anywhere
[09:53] <Chipaca> mandel: you want either r+, w+, or a+
[09:53] <Chipaca> w+ truncates the file, a+ is read-and-append. You probably want r+.
[09:54] <mandel> Chipaca: ok, I wonder how has r+w has worked 'til now...
[09:54] <Chipaca> mandel: massive good luck?
[09:54] <Chipaca> mandel: also, it works on ubuntu :)
[09:54] <Chipaca> but it's not specified
[09:54] <Chipaca> so up to the platform coders
[09:55] <Chipaca> unix people seem to have taken the DWIM approach
[09:55] <Chipaca> bah, i dunno
[09:55] <Chipaca> r+w has two different possible interpretations, you see
[09:55] <Chipaca> so erroring out is quite reasonable :)
[09:55] <mandel> Chipaca: yes, I suppose we meant r+ I'll change it and will run the tests to see
[09:58] <duanedesign> morning!
[09:58] <duanedesign> .5
[09:58] <Chipaca> .5?
[09:59] <duanedesign> Chipaca: was supossed to be /5 :P
[09:59] <Chipaca> heh
[09:59] <duanedesign> not awake 10 minutes and i have my first typo
[10:00] <Chipaca> duanedesign: that sounds about right
[10:06] <Chipaca> mandel: r+b, right?
[10:06] <mandel> Chipaca: yes, stupid EOL on windows..
[10:08] <Chipaca> mandel: here: http://www.youtube.com/watch?v=ZJfZTr8zMsc
[10:10] <mandel> Chipaca: que grande!
[10:57] <karni> We broke 1000 downloads of the files app in less than 16 hours
[10:57] <karni> Currently 1068 total installs :)
=== Iroslaw_ is now known as Iroslaw
[11:05] <mandel> karni: well done!
[11:05] <karni> mandel: Thanks Mandel!
[11:05] <mandel> karni: but why do you own that many phones?
[11:05] <mandel> :P
[11:05] <karni> mandel: :D
[11:36] <duanedesign> karni: awesome \0/
[11:37] <karni> duanedesign: \o/ :)
[11:37] <duanedesign> karni: i was just about to tweet about that
[11:37] <karni> =)
[11:39]  * mandel at the bank will be back soon
[11:46] <ralsina> morning!
[11:53] <duanedesign> o/
[11:54] <ralsina> hi duanedesign
[11:55] <duanedesign> howdy
[11:56] <duanedesign> going to be a hot one here today
[11:56] <duanedesign> 103F
[12:02]  * mandel walks dog....
[12:43] <nessita> good morning everyone!
[12:44] <nessita> mandel: I'm reviewing your branch
[12:50] <mandel> nessita: great
[12:50] <nessita> mandel: trivial needs fixing:
[12:50] <nessita> Docstring should be written as a command, so these two needs fixing:
[12:50] <nessita> """Performs the file...
[12:50] <nessita> """Returns if an...
[12:51] <mandel> nessita: which branch?
[12:51] <nessita> https://code.launchpad.net/~mandel/ubuntuone-client/fix-802726/+merge/66373
[12:51] <mandel> ack
[12:54] <ralsina> mrning nessita
[12:54] <mandel> ralsina, nessita: can I also get reviews for https://code.launchpad.net/~mandel/ubuntuone-client/fix-803507/+merge/66418
[12:54] <ralsina> mandel: sure!
[12:54] <nessita> ralsina: hello
[12:56] <mandel> nessita: changes made
[12:56] <ralsina> nessita: I am a bit blocked because design has told me there are updates for the wireframes, because they were working directly on the visual designs, and there is no "master document" we can refer to right now. I am waiting to see what the changes are, and should have them soon.
[12:57] <nessita> ralsina: hum
[12:57] <nessita> ralsina: ideally, we should not be getting updates from design right now, we can't be changing the UI at this point... do you know what kind of changes are they?
[12:58] <ralsina> nessita: not yet. I hope it's nothing major. It was mentioned in the context of the installer, though. And since the installer doesn't yet match the wireframes...
[12:58] <mandel> yes, is kinda late for that...
[12:59] <nessita> ralsina: your work so far on the installer, was based on signed off wireframes?
[13:00] <ralsina> nessita: I had on one hand signed off texts, and on the other, the 2.5 wireframes, which I asked design whether those were the ones I should follow, ad was told yes.
[13:00] <nessita> ralsina: was that conversation via email?
[13:00] <ralsina> nessita: let me check
[13:02] <ralsina> nessita: apparently not mail. I think it was in mumble in budapest, in our room?
[13:02] <ralsina> "our" I mean my, with you present
[13:03] <nessita> ralsina: if it was, I wasn't there, I left for the airport as soon as we finish the control panel wireframes
[13:03] <nessita> ralsina: ok, we need to confirm we're working on signed off specs, otherwise is our bad to have things moving without that :-/
[13:03] <ralsina> agreed.
[13:03] <nessita> ralsina: let's talk about that in the mumble. In the mean time, what are you working on while blocked?
[13:04] <ralsina> I will take care of this. However, this is only about the installer, so it's not TERRIBLY hard to fix right now.
[13:04] <ralsina> nessita: can't mumble, kid asleep next room :-(
[13:04] <nessita> ralsina: in "the mumble", the one we have after the stand up :-)
[13:05] <ralsina> nessita: oh, ok
[13:05] <ralsina> I may have something more solid by that time
[13:05] <ralsina> What I can work with: there are some pretty basic things in the SSO UI that need work, that should fill a couple of hours
[13:05] <nessita> ralsina: such as?
[13:06] <ralsina> like the error dialog shows the repr of the error dict
[13:06] <nessita> oh, right
[13:06] <nessita> ralsina: do you have any spec about how to handle that?
[13:07] <nessita> mandel: also: Text conflict in ubuntuone/platform/windows/filesystem_notifications.py
[13:07] <mandel> ralsina: and some review for me :)
[13:07] <ralsina> nessita: I thinkI have it on lisette's docs. I am looking now
[13:07] <ralsina> mandel: yes, and reviews :-)
[13:07] <mandel> nessita: hmm ok I'll take are of that/
[13:08] <mandel> ha, is an empty line.. lame
[13:09] <mandel> ralsina, nessita: I really do not see how I can add extra tests for this: https://code.launchpad.net/~mandel/ubuntuone-client/fix-803622/+merge/66425 it is covered by the action_q tests...
[13:09] <nessita> mandel: if you had to fix something then it was obviously not covered :-P (haven't seen the diff yet)
[13:10] <ralsina> nessita: r+w is undefined, but it works on Linux
[13:10] <ralsina> and by "it works" I mean "it works like r+b"
[13:11] <nessita> mandel: I think you should add a test and confirm that os.fdopen was called with r+b instead r+w
[13:11] <ralsina> So on linux the change is a no-op
[13:12] <nessita> ralsina: right, but we need to avoid the possible regression
[13:12] <ralsina> exactly, so patch open and see the args
[13:12] <mandel> aggg
[13:12] <nessita> mandel: os.fdopen can be patched with no further issues
[13:13] <mandel> nessita: I know.. but I'm lazy
[13:13] <mandel> anyway, conflict resolved
[13:13] <nessita> mandel: DON'T be :-)
[13:13] <nessita> mandel: trust me, everything can be tested. Chipaca taught me that. But you the right to complain about that for a while (not for toooo long)
[13:14] <nessita> you "have"...
[13:14] <mandel> I'll do it… still a PITA
[13:15] <ralsina> mandel: for every test we write, a little kitten gets its wings or something like that.
[13:16] <nessita> mandel: can you please remove the extra line you added in platform/windows/filesystem_notifications.py, right before
[13:16] <nessita>      @longpath(paths_indexes=[1])
[13:16] <nessita>     def _path_is_dir(self, path):
[13:16] <ralsina> OTOH, since this change is platform-dependent, we could just instantiate that class in a windows-specific test. If it passes, it's not regressed ;-)
[13:17] <mandel> nessita: ok
[13:17] <nessita> ralsina: explicit is better than implicit :-) so, having a dedicated test stating what we are about, is easy for the next one reading and understanding the code
[13:18] <mandel> nessita, ralsina: we also have the start method implemented looking at the reg to get the installation path: https://code.launchpad.net/~mandel/ubuntuone-client/sdtool_start_method/+merge/66448
[13:18] <ralsina> nessita: yes, but basically, if the tests were ran on windows, this *would* have been caught by all of them.
[13:18] <nessita> ralsina: True
[13:19] <ralsina> So the underlying problem was "tests didn't work on windows", not lack of coverage.
[13:19] <mandel> exactly :)
[13:20] <nessita> ralsina: yes, I agree. But when committing a fix to the repo, is even better if we have a test ensuring that the change is correct (and remains correct in the future)
[13:20] <nessita> so, I think we all agree :-)
[13:20] <ralsina> nessita: ok, convinced :-)
[13:20] <mandel> nessita, ralsina: one of the main issue for not running the tests is bug 760518
[13:20] <ubot4> Launchpad bug 760518 in ubuntuone-client "All tests are broken on Windows when trying to remove the tests files (affects: 1) (heat: 9)" [Medium,Triaged] https://launchpad.net/bugs/760518
[13:20] <mandel> I could move to fix that one so that we can see most of the tets running and passing
[13:21] <nessita> mandel: do you have something else in your plate before that?
[13:21] <nessita> like, any other pending bug
[13:21] <mandel> nessita: I have 4 branches for review and I think bug 802498 should be addressed first
[13:21] <ubot4> Launchpad bug 802498 in ubuntuone-client "Error when doing a partial commit on windows (affects: 1) (heat: 6)" [Critical,Triaged] https://launchpad.net/bugs/802498
[13:22] <mandel> nessita: also, I'd like to see if after those merges we start uploading files, maybe they were making the q to screw up for some reason
[13:23] <nessita> mandel: hum, so I'm not understanding what you will be working next
[13:23] <mandel> nessita: add tests for r+b and move to bug 802498
[13:23] <ubot4> Launchpad bug 802498 in ubuntuone-client "Error when doing a partial commit on windows (affects: 1) (heat: 6)" [Critical,Triaged] https://launchpad.net/bugs/802498
[13:23] <mandel> nessita: if I have time, make tests run on windows
[13:23] <mandel> or some other bug if needed
[13:24] <nessita> mandel: makes sense. I'm testing branches on windows as well (IRL), so I'm a bit slower today
[13:25] <mandel> nessita: ok, no problem when the bug fixes I have added land I'd like to do a IRL to see if we do update files or is a diff bug
[13:25] <mandel> I'm going to grab some early food, will be back in 20 min or so
[13:25]  * mandel lunch
[13:26] <nessita> ack
[13:38] <ralsina> mandel: +1 on https://code.launchpad.net/~mandel/ubuntuone-client/fix-803507/+merge/66418
=== m_conley_away is now known as m_conley
=== teknico is now known as teknico_away
[13:54] <nessita> 6 minutes to stand up!
[13:59] <spacebug-> Hello again. I still have the problems with big files not being uploaded. (from the program that is. Web upload works great). Last time I was here, my files said to have been uploaded to the server but had 0 bytes content. Now I installed the ubuntu one file app for my android yeterday and when loggin in on that I also the my big files uploaded with 0 bytes content. The u1sdtool and my ubuntyuone indicator both tells me file
[13:59] <spacebug-> is being uploaded and I see the % go up to 100%. 'u1sdtool --current-transfer' gives bytes written = deflated size. Still the folder never gets synced and transfer is never really done. Sometimes (at random it seems), moving the file out of the dir 'Ubuntu One' and restarting with 'u1sdtool -q; u1sdtool -c' seems to work, and sometimes not. Small files always work, they get uploaded and synced instantly (even during a big file
[13:59] <spacebug-> 'hang')
[14:00] <fagan> moi
[14:00] <nessita> me
[14:00] <nessita> alecu, ralsina, mandel, dobey, thisfred?
[14:00] <ralsina> me
[14:00] <dobey> me
[14:00] <thisfred> me
[14:00] <mandel> me
[14:00] <spacebug-> oh, a meeting going on?
[14:00] <fagan> spacebug-: for a few mins
[14:00] <nessita> spacebug-: yeah, no worries
[14:00] <ralsina> spacebug: it's our daily standup, will take 10 minutes or so
[14:01] <spacebug-> ok
[14:01] <spacebug-> I waint ;)
[14:01] <fagan> go?
[14:01] <nessita> go!
[14:01] <fagan> WORK IN PROGRESS
[14:01] <fagan> * rst port of the tutorial pages
[14:01] <fagan> Blocked
[14:01] <fagan> * nope
[14:01] <fagan> nessita:  go
[14:01] <nessita> DONE: lots of syncdaemon @ windows testing! finally. Also: bug #803598, bug #803560
[14:01] <nessita> TODO: bug #803228, more IRL testing and debugging
[14:01] <nessita> BLOCKED: nopes
[14:01] <nessita> NEXT: ralsina
[14:01] <ubot4> Launchpad bug 803598 in ubuntuone-client "Windows: log is too crowded with "Processing events with threashold" messages (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/803598
[14:01] <ubot4> Launchpad bug 803560 in ubuntuone-control-panel "sd_client code should be multiplatform (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/803560
[14:01] <ubot4> Launchpad bug 803228 in ubuntuone-control-panel "Make test run and pass on windows (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/803228
[14:01] <ralsina> DONE: reviews, worked on bug #800376 (blocked by sd_client), finished bug #800381, started bug #803661 and bug #803677
[14:01] <ralsina> (blocked by design updates), expense report, cleaned Canonicaladmin queue.
[14:01] <ralsina> TODO: check updates from design, finish pending bugs, continue SSO cleanup or wizard workflow, whatever unblocks first.
[14:01] <ralsina> BLOCKED: mostly
[14:01] <ralsina> NEXT: dobey
[14:01] <dobey> λ DONE: bug #803638, reviews, bug #803475
[14:01] <dobey> λ TODO: objectives, more bug fixing/triage
[14:01] <dobey> λ BLCK: None.
[14:01] <ubot4> Launchpad bug 800376 in ubuntuone-windows-installer "Add "syncing your computer to the cloud" page to the installer (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/800376
[14:01] <ubot4> Launchpad bug 800381 in ubuntuone-windows-installer "Add "sync now or later" page to the installer (affects: 1) (heat: 19)" [Undecided,Fix committed] https://launchpad.net/bugs/800381
[14:01] <ubot4> Launchpad bug 803661 in ubuntu-sso-client "The Qt existing user login widget is incomplete. (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/803661
[14:01] <ubot4> Launchpad bug 803677 in ubuntuone-windows-installer "Make the "current user sign in" page match the design wireframe (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/803677
[14:01] <ubot4> Launchpad bug 803638 in ubuntu-sso-client "[nightlies] Tests failing on Lucid (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/803638
[14:01] <dobey> thisfred: your roll
[14:01] <ubot4> Launchpad bug 803475 in lazr.restfulclient (Ubuntu) "Missing dependency on python-simplejson (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/803475
[14:01] <thisfred> DONE: Bug #762722 TODO: Test and wrap #762722 fix BLOCKED: no NEXT: mandel
[14:01] <ubot4> Launchpad bug 762722 in ubuntuone-control-panel (and 1 other project) "Opening the Control Panel during sync removes progress indicator (affects: 1) (heat: 9)" [High,In progress] https://launchpad.net/bugs/762722
[14:02] <nessita> mandel?
[14:02] <nessita> alecu?
[14:03] <nessita> iuuuuhuuuu
[14:03] <mandel> one sec
[14:03] <mandel> DONE: fix for bug 801277 bug 803828 bug 803507 bug 803622 and bug 802726
[14:03] <mandel> TODO: add tests for bug fix 803622 and bug 802498
[14:03] <mandel> BLOCKED: no
[14:03] <ubot4> Launchpad bug 801277 in ubuntuone-client "The start method is not implemented in the windows sdtool (affects: 1) (heat: 62)" [Medium,In progress] https://launchpad.net/bugs/801277
[14:03] <ubot4> Launchpad bug 803828 in ubuntuone-client "Tests in test\windows\tests_tools do not restore the mocked objects (affects: 1) (heat: 6)" [Low,In progress] https://launchpad.net/bugs/803828
[14:03] <ubot4> Launchpad bug 803507 in ubuntuone-client "OSError when deleting a folder (windows version) (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/803507
[14:03] <ubot4> Launchpad bug 803622 in ubuntuone-client "ValueError: InvalidMode ('r+w') (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/803622
[14:03] <ubot4> Launchpad bug 802726 in ubuntuone-client "KeyError (Unhandled Event in INotify) in ubuntuone\syncdaemon\filesystem_notifications.py (affects: 1) (heat: 8)" [Medium,In progress] https://launchpad.net/bugs/802726
[14:03] <ubot4> Launchpad bug 802498 in ubuntuone-client "Error when doing a partial commit on windows (affects: 1) (heat: 6)" [Critical,Triaged] https://launchpad.net/bugs/802498
[14:04] <nessita> alecu: you around?
[14:04] <nessita> any closing comments anyone?
[14:04] <nessita> mandel, ralsina, alecu, Chipaca: meeting in 25 minutes?
[14:04] <mandel> sure thing
[14:04] <joshuahoover> fagan: ping
[14:04] <fagan> joshuahoover: ping
[14:04] <joshuahoover> fagan: how are faqs and tutorials to rst going?
[14:04] <nessita> smells like EOM and snal time
[14:04] <nessita> snack
[14:05] <ralsina> nessita: ack
[14:05] <nessita> spacebug-: hey there, I've pinged verterok for help
[14:05] <verterok> spacebug-: hi
[14:05] <spacebug-> nessita: ah ok tnx
[14:05] <fagan> joshuahoover: still working on it im going pretty slow today so will have something for friday to show
[14:05] <nessita> spacebug-: he may be able to help debug your issue
[14:05] <spacebug-> ok tnx
[14:05] <spacebug-> hi verterok
[14:05] <fagan> joshuahoover: its a good bit different to the faq since there are pics too
[14:05]  * fagan needs a nap 
[14:05] <verterok> spacebug-: is the upload at 100% for a long time?
[14:05] <alecu> hello!
[14:06] <alecu> let me write my notes, and then I'll go "me!"
[14:06] <spacebug-> verterok: yes, this one has been for 8 hours ort so
[14:06] <verterok> spacebug-: ok, you'r hitting bug in the server
[14:06] <joshuahoover> fagan: right, with pics, i got those and put in a branch for muffinresearch...
[14:06] <verterok> spacebug-: it's a known issue that sometines big uploads get stuck at 100%, we are working on a fix
[14:06] <joshuahoover> muffinresearch: any thoughts on how fagan should reference the pics in the tutorials as he converts to rst?
[14:06] <Chipaca> Neoti: yes
[14:06] <Chipaca> um
[14:06] <ralsina> I need two reviews for https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix_803661/+merge/66456 it's pretty simple
[14:06] <Chipaca> nessita: yes
[14:06] <spacebug-> verterok: ah ok, well good its known and its been worked on
[14:07] <verterok> spacebug-: sadly, there is no woraround :/
[14:07] <fagan> joshuahoover: ah ok I thought id stick them in the branch wit mine
[14:07] <verterok> *workaround
[14:07] <fagan> joshuahoover: its cool though
[14:07] <ralsina> joshuahoover: if the images have a known full URL, use that, it's easiest
[14:07] <joshuahoover> ralsina: right, make sense
[14:07] <spacebug-> verterok: so I just wait till someone fix the bug?
[14:07] <ralsina> joshuahoover: you can use relative URLs but it gets very annoying very quick
[14:07] <verterok> spacebug-: I'm fixing it
[14:08] <muffinresearch> joshuahoover: is there a merge proposal for your images branch?
[14:08] <joshuahoover> fagan: here's the branch i gave to muffinresearch: lp:~joshuahoover/ubuntuone-servers/tutorial_images
[14:08] <spacebug-> verterok: ok ;)
[14:08] <fagan> ralsina: ah so use full urls thats a good suggestion
[14:08] <verterok> spacebug-: we arelady have a proposed fix, we are testing it and will be rolledout to productin "soon"
[14:08] <joshuahoover> muffinresearch: no, i wasn't sure if you wanted me to propose the merge or if you were managing merges on your branch and then doing a bigger merge to trunk
[14:08] <verterok> spacebug-: "soon" depends on the tests :)
[14:08] <fagan> joshuahoover: cool will use those names for reference
[14:09] <alecu> me
[14:09] <alecu> DONE: a branch to move ubuntu-sso-client from txnamedpipes to qtreactor (bug #803433). Started a branch to move ubuntuone-client from txnamedpipes to plain windows reactor (bug #803640)
[14:09] <alecu> TODO: finish moving ubuntuone-client, move ubuntuone-control-panel to qtreactor (bug #803641)
[14:09] <alecu> BLOCKED: no
[14:09] <ubot4> Launchpad bug 803433 in ubuntu-sso-client "Use qt-reactor (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/803433
[14:09] <ubot4> Launchpad bug 803640 in ubuntuone-client "Replace txnamedpipes with the standard twisted reactor (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/803640
[14:09] <fagan> (the names of the images I mean)
[14:09] <ubot4> Launchpad bug 803641 in ubuntuone-control-panel "Replace txnamedpipes with the qtreactor (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/803641
[14:09] <muffinresearch> joshuahoover: it'll be easier to get this into trunk so we can roll it out - that way we'll get the rst pointing at the images on the media server directly
[14:09] <alecu> sorry I missed the standup.
[14:09] <spacebug-> verterok: ok good. Just wanted to know that someone knew the problem. I really like the service ;)
[14:09] <spacebug-> well tnx for now, have a great day everyone!
[14:11] <fagan> so cool then ill finish it by tomorrow but going for a break now since I need to sleep for a bit
[14:11] <ralsina> dobey: while I don't usually ask for the second u1-hackers review, I don't approve the branches without it :-)
[14:11] <ralsina> dobey: just to avoid getting two identical mails
[14:12] <ralsina> fagan: sleep? it's 2PM!
[14:12] <dobey> ralsina: if it needs two reviws, you should request it
[14:12] <ralsina> dobey: ok, will do
[14:12] <fagan> ralsina: tired, got actually no sleep last night
=== teknico_away is now known as teknico
[14:12] <ralsina> fagan: working?
[14:12] <joshuahoover> muffinresearch: care to review? https://code.edge.launchpad.net/~joshuahoover/ubuntuone-servers/tutorial_images/+merge/66461
[14:13] <fagan> slept after work yesterday threw my cycle off a bit
[14:13] <fagan> ralsina: slow and steady today :)
[14:13] <fagan> ill get back after a quick rest and get more of this rst port done
[14:14] <nessita> alecu: FYI, control panel already uses qtreactor
[14:14] <ralsina> fagan: grmbl. You know, it's part of our job to be *at* our job on the hours we are supposed to. Sleeping regular hours is important.
[14:15] <fagan> ralsina: Well I will be just taking a break for an hour or 2
[14:15] <alecu> nessita, did you change it? or did we never ported it to txnamedpipes?
[14:15] <ralsina> fagan: just something to keep in mind.
[14:15] <nessita> alecu: we never port it
[14:15] <fagan> ralsina: sorry about it but id say it would make me a little more productive
[14:15] <nessita> alecu: hum now that you mention, windows. main may be txn
[14:15] <alecu> nessita, nice.
[14:15] <nessita> sorry
[14:15]  * nessita checks
[14:15] <ralsina> nessita, alecu; efficiency through procrastination
[14:16] <alecu> ralsina, I think I better take a nap too
[14:16] <nessita> alecu: you are right :-) windows.main uses txn
[14:17] <fagan> but yeah regular sleep is a good thing (I think thats what ralsina was trying to get across)
[14:17] <fagan> for waking up and being productive and all that
[14:18] <ralsina> fagan: basically, that sleeping at night and being awake at 2PM is part of being a responsible adult, which is part of the job description :-)
[14:18] <ralsina> Of course we all have bad nights/days/whatever, so... it happens.
[14:19] <fagan> ralsina: yeah bad night that sums it up
[14:44] <thisfred> ralsina: what should we set for target dates? april 12 or oct 12?
[14:48] <dobey> thisfred: December 21, 2012. You won't be able to do anything after that anyway
[14:49] <thisfred> can I just put 'rapture'
[14:49] <dobey> Quetzlcoatl will return
[14:49] <thisfred> ?
[14:49] <thisfred> Popocatepetl
[14:50] <dobey> "Survive the impending alien invasion."
[14:50] <thisfred> July 4 is X-day, I'm not making any plans beyond that
[14:51] <thisfred> July 5 I mean
[14:51] <dobey> heh
[14:51] <thisfred> July 4 is something else. I forget
[14:51] <dobey> july 4 is us holiday
[14:51] <thisfred> Yeah, I lied, I know that
[14:52] <dobey> something to do with Jeff Goldblum saving us all
[14:55] <thisfred> with an Apple laptop
[14:55] <thisfred> and a copy of TDL-4
[14:56] <dobey> yep
[14:56] <ralsina> thisfred: it's objectives for the next 12 months.
[14:56] <thisfred> ralsina: awesome
[14:57] <dobey> so i got a mail today from someone wanting to buy one of my domains… for $15
[14:58] <dobey> i think i'll pass
[15:01] <mandel> nessita: can you re-review this guy: https://code.launchpad.net/~mandel/ubuntuone-client/fix-802726/+merge/66373
[15:02] <nessita> sure!
[15:03] <mandel> nessita: regarding this https://code.launchpad.net/~mandel/ubuntuone-client/sdtool_start_method/+merge/66448 the test were ran on windows, right?
[15:04] <nessita> mandel: of course :-)
[15:04] <mandel> oh, that is strange...
[15:05] <nessita> mandel: hum, maybe PYTHONPATH issues?
[15:05] <nessita> let me re try
[15:05] <nessita> mandel: it worked!
[15:06] <nessita> mandel: seems like I had the PYTHONPATH unset
[15:06] <nessita> mandel: what I don't like about the test is that notepad is actually, really, opened
[15:07] <mandel> nessita: I actually wanted to do that to test that with the real subprocess would work
[15:07] <mandel> with the deferred and all
[15:07] <nessita> mandel: but we don't want to test subprocess, "subprocess works" is True for us
[15:07] <nessita> mandel: can we please mock subprocess.Popen? otherwise is not longer a unittest
[15:08] <mandel> nessita: I can mock it if you want to, is not too hard
[15:08] <nessita> please... if we want to run this in a bot we may not be able to open IRL stuff
[15:09] <ralsina> we need a windows port of /bin/true to test that :-)
[15:09] <nessita> ralsina: mocking Popen will do for now :-) (luckily)
[15:09] <mandel> ok, I'll do that then :)
[15:10] <mandel> nessita: the other review, the one about w+b, does it look ok?
[15:10] <nessita> mandel: yes, about to try it on windows
[15:11] <mandel> great :)
[15:11] <mandel> nessita: those tests are broken, make sure you run the command with the -t and the regexp of the tests
[15:11] <mandel> do you know the commands?
[15:11] <nessita> mandel: no, can you please add that to the MP?
[15:11] <mandel> sure
[15:12] <nessita> mandel: for now I'm testing the IRL syncdaemon
[15:13] <mandel> nessita: command added
[15:13] <nessita> syncdaemon running
[15:13] <nessita> and I see tons of AQ_UPLOAD_STARTED!
[15:16] <nessita> mandel: guh, uploads are not succeding
[15:16] <nessita> mandel: but they are going further than before
[15:16] <mandel> nessita: ok, can you add a bug for that, and I'll do that one right now after the fixes in the merges
[15:18] <nessita> mandel: sure
[15:20] <nessita> mandel: ok, I need to run the magic command now :-)
[15:22] <mandel> nessita: great, landing that will get us a step closer, I have also just pushed the sdtool branch with subprocess being mocked.
[15:22] <nessita> mandel: yeah. About the upload error I will ask help to facundo, so you keep working in the same path we agreed on
[15:22] <mandel> ralsina: what about a review for the spaniard: https://code.launchpad.net/~mandel/ubuntuone-client/sdtool_start_method/+merge/66448
[15:23] <mandel> nessita: sure, I'll try to reproduce the partial  file commit error then
[15:23] <ralsina> mandel: trade! https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix_803661/+merge/66456
[15:23] <nessita> mandel: great
[15:23] <mandel> ralsina: ok
[15:24] <mandel> nessita: which is the bug you filled, jus tto take a quick look and see if there is any thing that rings a bell
[15:24] <nessita> mandel: can't fill it yet, VM was out of contorl
[15:24] <nessita> control
[15:25] <nessita> mandel: I'll let you know, but basically every single UPLOAD was failing with TRY_AGAIN
[15:25]  * facundobatista is glad to help
[15:25] <mandel> weird...
[15:29] <nessita> mandel: does the magic command line need a reactor?
[15:29] <mandel> nessita: no, did you get an error?
[15:29] <nessita> yeap, pasting now
[15:30] <nessita> mandel: paste.ubuntu.com/635813
[15:33] <mandel> nessita: looks like I do get the tests to run without passing the reactor
[15:33] <mandel> nessita:  add —reactor=txnp to the command, and please provide the regexp I have and not the name of the testcase, otherwise it won't run any tests
[15:33] <mandel> u1trial is not that smart, it looks at test names and ignores testcases names
[15:33] <nessita> why not? -t TestCaseName works on linux
[15:33] <nessita> mandel: that's a lie! :-)
[15:34] <nessita> I use test case names all the time
[15:34] <nessita> or is this a windows thing?
[15:34] <mandel> nessita: maybe I did a typo, but in mine it did not work...
[15:34]  * mandel double checks
[15:35] <nessita> it worked here (passing --reactor=txnp)
[15:35] <mandel> nessita: ha, I'm stupid I was in the wrong branch…
[15:35] <nessita> :-)
[15:36] <ralsina> mandel: about https://code.launchpad.net/~mandel/ubuntuone-client/sdtool_start_method/+merge/66448 all tests pass but I *don't* see notepad
[15:36] <mandel> ralsina: yes, nessita wanted to have that mocked :)
[15:36] <mandel> ralsina: so you are not meant to see it
[15:37] <ralsina> mandel: cool then ;-)
[15:37]  * nessita is always guilty
[15:37] <ralsina> didn't know it was already mocked, had the old diff
[15:38] <ralsina> mandel: +1
[15:43] <ralsina> nessita: this is the current wireframe for the installer, which will be signed off and finalized tomorrow morning https://docs.google.com/a/canonical.com/drawings/d/10Io1nRr0mGr_EW5mHTKErS6s2oxVnF7uCDdIzuqYB50/edit?hl=en_US
[15:43] <ralsina> And renamed "Final spec we promise not to change."
[15:44] <nessita> ralsina: so, that is not the one you've been using :-/
[15:44] <ralsina> nessita: it's a new copy of the one I have been using + design work + 3 changes
[15:44] <ralsina> 1) per-folder checkboxes on the local folders page
[15:44] <ralsina> 2) A wizard-progress widget on the left
[15:45] <ralsina> 3) there is design, so I can use the assets (or not and leave it for later)
[15:46] <nessita> ralsina: I will have to trust you on this one (re the amount of changes). Let's remember this for future developments, so we all (I know I didn't confirm this was signed off) work on signed off specs
[15:46] <nessita> :-)
[15:46] <ralsina> Live and learn.
[15:46] <ralsina> Better than all the alternatives.
[15:47] <nessita> or, like fagan would say, live and sleep :-P
[15:47] <ralsina> ;-)
[15:49] <nessita> mandel: ./tests/syncdaemon/test_action_queue.py:
[15:49] <nessita>     5653:  local variable 'tmp' is assigned to but never used
[15:49] <mandel> O_o on it
[15:49] <nessita> mandel: from https://code.launchpad.net/~mandel/ubuntuone-client/fix-803622/+merge/66425
[15:53] <nessita> mandel: also, did you catch this trivial needs fixing? https://code.launchpad.net/~mandel/ubuntuone-client/fix-803507/+merge/66418
[15:53] <mandel> yes, on it
[15:54] <mandel> nessita: do you know which comment to add when you want to disable the var not use message with pyflakes?
[15:55] <nessita> mandel: I don't think there is a way
[15:56] <nessita> mandel: can't you assert something on tmp?
[15:56] <nessita> mandel: or remove "tmp = " altogether
[15:56] <dobey> mandel: you can't disable specific warnings in pyflakes
[15:57] <dobey> mandel: if the variable isn't being used, remove the variable :)
[15:59] <mandel> ok
[15:59] <mandel> super lame
[15:59] <dobey> mandel: don't write useless code :)
[15:59] <dobey> why would you assign to a variable you're not using, anyway?
[16:01] <mandel> wanted to be clear, but not a big deal
[16:02] <nessita> mandel: hit me baby one more time!
[16:02] <nessita> (with reviews)
[16:03] <mandel> that + twitter status == mandel scared
[16:03] <mandel> nessita: unused var fixed
[16:03] <nessita> mandel: approving (the rest will be take care by tarmac)
[16:03] <dobey> at least it's not google+ status
[16:05] <nessita> google+: sometimes I'm scared of you!
[16:06] <mandel> dobey: I wonder how that good that things is… have you seen it?
[16:06] <dobey> google+? yeah, i am on it. but i don't understand it
[16:09] <mandel> dobey: what do you mean?
[16:09] <ralsina> alecu, nessita: I could use a second review of https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix_803661/+merge/66456
[16:09] <mandel> nessita: https://code.launchpad.net/~mandel/ubuntuone-client/fix-803507/+merge/66418 updated
[16:09] <nessita> ralsina, mandel: on those
[16:09] <ralsina> nessita: thx
[16:10] <dobey> mandel: i mean google+ is very weird. it has this thing called "circles"
[16:10] <dobey> mandel: "friend circle" "family circle" etc…
[16:11] <dobey> mandel: and the UI is annoying
[16:11] <mandel> dobey: circles as in circles of friends?
[16:12] <dobey> right
[16:12] <ralsina> dobey: like facebook lists
[16:12] <dobey> instead of groups, they called them circles i guess, and made the UI suck
[16:13] <dobey> ralsina: yeah, but you can't use lists in fb to restrict privacy; you can use circles for that in google+
[16:14] <ralsina> dobey: yes you can, in facebook. http://www.facebook.com/help/?page=768
[16:14] <ralsina> dobey: specifically, http://www.facebook.com/help/?faq=12074
[16:15] <dobey> second one is not relevant since it's assumed if you know what friend lists are, you already have them :)
[16:16] <thisfred> nessita: re: control panel auth:
[16:16] <dobey> but ok, so the UI sucks for doing that on FB, so nobody uses it, because it's insanely hard to use
[16:16] <thisfred> nessita: I cannot connect: I threw away the token, then I thought I had the wrong password maybe to authenticate the device, asked for and got a new one, but whenever I enter it, I see the string 'An exception representing an authentication failure'  in red, which is a terrible error message. (Looks like we're showing an exception doc string??)
[16:16] <nessita> mandel: directory removed!!!!
[16:16] <mandel> nessita: is that good or bad?
[16:16] <nessita> mandel: good, OsError went waya
[16:17] <mandel> toma
[16:17] <mandel> !!
[16:17] <dobey> thisfred: that isn't a docstring
[16:17] <thisfred> It sure looks like one
[16:17] <nessita> away
[16:17] <nessita> thisfred: you have the time wrong?
[16:17] <nessita> I agree terrible error to show, is not a docstring, is coming from the SSO server
[16:17] <nessita> thisfred: most likely, your time is off
[16:17] <dobey> thisfred: well is't a horrible string, yes
[16:17] <thisfred> nessita: maybe, I have no indicators :)
[16:18] <nessita> thisfred: bug #703507
[16:18] <ubot4> Launchpad bug 703507 in ubuntu (and 1 other project) "I can't log in - "an exception representing an authentication failure" (affects: 4) (heat: 42)" [Undecided,Confirmed] https://launchpad.net/bugs/703507
[16:18] <nessita> thisfred: "date" on a terminal
[16:18] <thisfred> nessita: yep it's an hour off
[16:18] <nessita> thisfred: that, plus all the errors you got re auth failures, indicates time is off
[16:18] <dobey> problem solved
[16:18] <nessita> thisfred: oauth does not work without the problem time
[16:19] <nessita> thisfred: the time thing is way out of our reach. Yes, we should be showing better error messages.
[16:19] <ralsina> thisfred: meta-whatever, xterm -e "watch date"
[16:20] <mandel> thisfred: do you still need a review for https://code.launchpad.net/~thisfred/ubuntuone-client/add-counter
[16:21] <thisfred> mandel: sure, not urgent, but if you're bored :)
[16:22] <thisfred> yay u1 works again
[16:29] <dobey> ralsina: "watch ddate" is more fun
[16:29] <nessita> ralsina: running you branch on windows now. Can I have some intructions about running tests and IRL test in the MP?
[16:29] <ralsina> nessita: sure, in 1'
[16:30] <thisfred> man ddate | grep X-Day
[16:35] <dobey> ok, lunch. bbiab
[16:37] <ralsina> nessita: added IRL instructions. However, it doesn't show you the page subtitle, because the default is an empty string.
[16:38] <ralsina> I should add a test that the subtitle is set as the right property of the QWizardPage, right?
[16:40] <ralsina> dobey, thisfred, one of you who has oneiric, can check bug #803930 please?
[16:40] <ubot4> Launchpad bug 803930 in ubuntuone-control-panel (Ubuntu) "Services tab fails with: Value could not be retrieved. (Unauthorized: ('unauthorized', 'Authentication required.')) (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/803930
[16:40] <thisfred> ralsina: was just looking at that
[16:40] <ralsina> thisfred: cool
[16:42] <nessita> ralsina: ok, thanks. I tried to run the installer with the new sso, to see if I got the text in the window (I still don't), and I notice that sso complains about the installer trying to register twice. I filed bug #803952
[16:42] <ubot4> Launchpad bug 803952 in ubuntuone-windows-installer " Client tried to register twice (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/803952
[16:43] <nessita> ralsina: maybe that's Invalid, I'm not sure, I'm letting you know to debug and triage
[16:43] <ralsina> nessita: checking that bug right now
[16:43] <nessita> not urgent, I think
[16:43] <ralsina> nessita: if you use the installer instead of show_gui you should have a subtitle
[16:43] <nessita> ralsina: I got no text at all
[16:43] <nessita> ralsina: and this time they did connect, but SSO complained with that bug
[16:43] <ralsina> nessita: still not connecting :-(
[16:43] <ralsina> oh, ok
[16:44] <nessita> ralsina: you are running latest uSSOc?
[16:44] <ralsina> nessita: as of early this morning
[16:44] <ralsina> I'll pull
[16:44] <nessita> ralsina: I need to ask this: you sure you don't have an older version installed in site-packages?
[16:44] <ralsina> nessita: I actually install sso every day
[16:45] <nessita> ralsina: ok, I'll let you debug that bug (is not top priority, can be later). I'll use show_gui for now
[16:45] <ralsina> nessita: ok, cool
[16:48] <nessita> ralsina: oh, tests do not pass on windows
[16:48] <ralsina> sso tests?
[16:49] <ralsina> nessita: confirmed that trunk sso and trunk installer don't work together: I get this on the installer console: Failure: twisted.internet.error.ConnectionRefusedError: Connection was refused b
[16:49] <ralsina> y other side: 10061: WSAECONNREFUSED.
[16:50] <ralsina> That's because we are not in the same transport/reactor right now. So, need to fix that first
[16:50] <nessita> ralsina: ok
[16:51] <ralsina> alecu: do you have moving the installer to qt4 reactor in your TODO? I am doing it myself now
[16:51] <nessita> ralsina: yes, sso tests
[16:51] <ralsina> nessita: ok, put the error in a needsfixing, I'll get to it soon
=== beuno is now known as beuno-lunch
[16:53] <nessita> ack
[16:53] <nessita> dobey: did you sso branch landed yesterday?
[16:54] <nessita> dobey: I see it did. That broke tests on windows :-/
[16:55] <mandel> nessita: the thing with the logs being stored in Temporary Internet Files is driving me crazy, I'm gonna fix that before I move on, the thing is that the bug is from +junk branch I have, should I add that code in the u1client code as a window module to be installed when needed?
[16:55] <nessita> mandel: we can't add that to the u1client source tree
[16:56] <mandel> nessita: not even in contrib?
[16:56] <nessita> mandel: we need to so something about it, but not adding it to the source tree. No contrib, anyone branching in linux will be confused
[16:56] <nessita> since xdg is already provided. That needs to be a dependency
[16:57] <nessita> mandel: please remind me to talk about this tomorrow in the mumble, yes?
[16:57] <mandel> nessita: I can create a small project called winxdg that is installed as xdg, is not too much overhead, what do you think?
[16:57] <mandel> nessita: yes, I'll remind you
[16:57] <nessita> mandel: let's talk tomorrow. Thanks!
[16:57] <mandel> well, I need to take the dog out, bbl
[16:58] <nessita> ack
[16:59] <nessita> dobey: I've filled bug #803958, if you could please help us having the test working on windows as well, it would be great
[16:59] <ubot4> Launchpad bug 803958 in ubuntu-sso-client "urllib2.URLError when running the tests in windows (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/803958
[16:59] <nessita> dobey: (I assigned it to you)
[17:10] <nessita> ralsina: test failure added (the one not related to ^). Also, I requested tests (as usual) :-).
[17:11] <ralsina> nessita: cool, thx
[17:13] <Cerrdor> how do I install ubunut one thing for banshee?
[17:14] <nessita> mandel, facundobatista: seems like syncdaemon can't rotate logs on windows :-(
[17:14] <nessita> I'll file a bug
[17:15] <facundobatista> nessita, why is that?
[17:15] <dobey> nessita: weird
[17:15] <facundobatista> nessita, maybe because the old is still open and windows locks it?
[17:15] <alecu> ralsina, pong. Here's the bug for qtreactor in installer: bug #803675
[17:15] <ubot4> Launchpad bug 803675 in ubuntuone-windows-installer "Replace txnamedpipes with qtreactor (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/803675
[17:15] <nessita> facundobatista: why? no idea... but I ran with TRACE, which generated a huge amount of info
[17:15] <ralsina> alecu, ok thanks!
[17:16] <bert_voegele> Cerrdor : sudo aptitude install banshee-extension-ubuntuonemusicstore
[17:16] <Cerrdor> thar ya go
[17:16] <Cerrdor> shanks
[17:16] <alecu> ralsina, feel free to asign it to yourself, etc.
[17:16] <nessita> facundobatista: and I only have a syncdaemon.log file, which is evidently not the "first one"
[17:16] <Cerrdor> and ubuntu one in my application menu?
[17:17] <nessita> dobey: the "weird" refers to the log not rotating or the bug report re test in window?
[17:17] <bert_voegele> Cerrdor : should be under Preferences
[17:17] <nessita> facundobatista: sorry, I was wrong!
[17:18] <nessita> mandel: ^
[17:18] <Cerrdor> you tha man
[17:18] <nessita> facundobatista, mandel: seems like listing all the *.log files will not include others such as bla.log.bar
[17:19] <dobey> nessita: windows tests
[17:19] <nessita> dobey: ah. I pasted the trace, so if you could help us in that end it will be highly appreciated
[17:20] <facundobatista> nessita, listing where?
[17:20] <nessita> facundobatista: on a cmd.exe
[17:21] <facundobatista> nessita, ok
[17:21] <Cerrdor> I want a banshee plugin that will send what im listening to into an IRC room anyone know where to find that?
[17:21] <dobey> nessita: i think the test was already broken on windows, based on that error. it doesn't seem to have the full path
[17:22] <dobey> Cerrdor: i doubt there is one. but there might be a plug-in for your IRC client that can get the current playing song from banshee. you should ask in the banshee channel through probably
[17:23] <Cerrdor> I tried banshee and it is abandoned
[17:23] <Cerrdor> lol
[17:23] <bert_voegele> Cerrdor : solution depends on your IRC client
[17:23] <Cerrdor> xchat
[17:23] <dobey> Cerrdor: banshee's irc channel is on gimpnet, not freenode
[17:23] <Cerrdor> ohhh
[17:23] <Cerrdor> wtf for lol
[17:25] <nessita> dobey: but the test_account is mutiplatform, we don't have special cases for windows
[17:25] <nessita> facundobatista: logs sent, I'll report the bug while you see the logs
[17:26] <dobey> nessita: well clearly that's wrong
[17:26] <nessita> dobey: I have too many things in my head, can you please be more specific?
[17:26] <nessita> define "that"
[17:27] <dobey> nessita: it looks like os.path.abspath, and os.path.curdir, are not working on windows?
[17:27] <dobey> or something.
[17:28] <dobey> hwy is the path '' in the traceback?
[17:28] <ralsina> alecu, nessita, mandel: reviews for very small branch? https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803675/+merge/66491
[17:28] <dobey> nessita: can you print the url being passed to urlopen() right before it's called to see what it's passing in?
[17:29] <dobey> nessita: i'm guessing maybe it's not escaped properly or something
[17:29] <bert_voegele> I'm getting "Service Temporarly Unavailable" (503)  for https://couchdb.one.ubuntu.com since a couple of weeks and desktop logs grow huge. someone know a solution?
[17:34] <nessita> dobey: I can, after lunch, I'll ping you bak
[17:34] <nessita> back*
[17:34] <dobey> ok
=== beuno-lunch is now known as beuno
[17:52] <nessita> lunchtime@!
[17:53] <ralsina> nessita: https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix_803661/+merge/66456 ready for re-review
=== teknico is now known as teknico_away
[18:38] <mandel> ralsina: have you tested that branch?
[18:38] <ralsina> mandel: the one for nessita? Yes, on windows.
[18:38] <mandel> ralsina: I think it wont work, I have not tried it yet, but I have a very string feeling about that
[18:39] <mandel> ralsina: I meanhttps://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803675/+merge/66491
[18:39]  * nessita is back
[18:39] <ralsina> mandel: looking...
[18:39] <ralsina> mandel: yes, tried it IRL and it works
[18:40] <ralsina> mandel: even get credentials and everything
[18:40] <mandel> ralsina: If I remember correctly you have to create the instance of the QApplication before you install the reactor https://github.com/thisfred/qtreactor
[18:41] <mandel> ralsina: look at Using the Qt4Reactor
[18:41] <mandel> and in the diff is after
[18:41] <mandel> ralsina: am I missing something?
[18:41] <ralsina> mandel: hmmmm makes sense. Wonder why it seems to work, though
[18:42] <thisfred> thisfred?
[18:42] <mandel> thisfred: first hit in google when I looked for qtreactor ;)
[18:42] <thisfred> git clone https://github.com/ghtdak/qtreactor
[18:42] <thisfred> lol
[18:43] <thisfred> all I did was fork it
[18:43] <ralsina> mandel: I; ll flip it
[18:43] <mandel> ralsina: so there is something wrong… I have not tried it but looks like it should be using a QCoreApplication and not a QApplication meaning that the UI could not be isntantiated
[18:43] <mandel> ralsina: that should fix the possible issue, but it would be nice to now why it works on your machine...
[18:44] <ralsina> mandel "would be nice", sure
[18:45] <mandel> ralsina: also, your removed the interleaver, but did not remove the app.exec call which is wrong, in the diff I should be able to see a reactor.run()
[18:46] <mandel> like here: https://github.com/thisfred/qtreactor/blob/master/ghtTests/trivialscript.py
[18:46] <thisfred> STOP PINGING ME :)
[18:46] <mandel> thisfred: your fault, stop forking projects!
[18:46] <thisfred> fork you!
[18:47] <mandel> that is what she said
[18:47] <mandel> ralsina: did I make sense?
[18:48] <ralsina> but without the exec how do I start the event loop?
[18:48] <dobey> hmmmm
[18:48] <ralsina> oh, run(), sure
[18:49] <ralsina> mandel: did the changes, seems to work exactly the same to me. But hey, you know better.
[18:49] <mandel> ralsina: and really_quit is wrong too, since you do not have to call app.quit but reactor.stop
[18:50] <ralsina> mandel: yes, but it made sense because I had app.exec() :-)
[18:50] <ralsina> those go in pairs
[18:50] <mandel> ralsina: yes, I was mentioning it in case you forgot it in the run change :)
[18:50] <ralsina> There, pushed :-)
[18:59] <ralsina> alecu, mandel: reviews for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803675/+merge/66491 would make me super happy for about 10 minutes
[19:00]  * ralsina is starting to have too many branches piling
[19:01] <mandel> ralsina: this approved: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803675/+merge/66491
[19:01] <ralsina> mandel: yay!
[19:01] <mandel> ralsina: but check that in your python path you were not using the old code because it did not work in my machine
[19:01] <ralsina> checking...
[19:02] <ralsina> mandel: verified via a huge print in the main()
[19:02] <alecu> ralsina, on it
[19:04] <mandel> weird....
[19:11] <nessita> ralsina: I'm back to your review now
[19:11] <ralsina> nessita: cool
[19:12] <nessita> dobey: can you please add a comment in the bug report asking what thing you want printed where? otherwise I'm a bit lost
[19:12] <alecu> ralsina, probably not related to your latests changes, but I get this: https://pastebin.canonical.com/49234/
[19:13] <ralsina> alecu: yes, separate problem
[19:14] <ralsina> alecu: probably one branch or the other merged incomplete :-(
[19:14] <ralsina> alecu: is that on the fix_803675 branch?
[19:15] <alecu> ralsina, yes
[19:15] <dobey> nessita: https://bugs.launchpad.net/ubuntu-sso-client/+bug/803958/comments/2
[19:15] <ralsina> ok, will push a fix in 1'
[19:15] <ubot4> Launchpad bug 803958 in ubuntu-sso-client "urllib2.URLError when running the tests in windows (affects: 1) (heat: 6)" [High,Triaged]
[19:15] <nessita> ralsina: are the test suite passing in your fix_803661 branch? (except those from generate)captcha)
[19:15] <nessita> ralsina: I get 2 failures
[19:15] <ralsina> nessita: they pass for me
[19:15] <ralsina> nessita: paste the errors please?
[19:15] <nessita> sure
[19:17] <nessita> ralsina: paste.ubuntu.com/635920/
[19:18] <ralsina> nessita: ack
[19:18] <alecu> ralsina, again, probably not related, but when pressing enter on the password, the "Sign in" button should be activated.
[19:18] <ralsina> alecu: accelerators are not implemented yet. Had a question about them in last night's report
[19:18] <alecu> ralsina, also, when entering bad login info, a dialog pops up with the webservice error.
[19:19] <alecu> ralsina, I'm sure you know about that :-)
[19:19] <ralsina> alecu: popups not done yet either :-)
[19:19] <ralsina> nessita: I was running the tests wrong :-( Should have a fix in 15' or so
[19:20] <alecu> ralsina, finally: clicking on "Sign In" should disable said button while the webservice call is active, otherwise I can keep clicking on it.
[19:20] <nessita> ralsina: ack
[19:20] <alecu> ralsina, other than that, branch approved ! :-)
[19:20] <ralsina> alecu: blocking the UI while busy is not implemented yet ;-)
[19:20] <alecu> hahahaah
[19:20] <nessita> ralsina: I know you asked about accelerators, but those are not related with default buttons, no?
[19:20] <alecu> ralsina, do you have bugs for this items to be done? or do you keep some list?
[19:20] <nessita> ralsina: clicking <enter> on a text entry should activate the default button
[19:21] <ralsina> nessita: kinda. In a wizard, the default button can't be one inside the page
[19:21] <nessita> ralsina: ok... not sure how that answers my question re: accelerators are not directly related to default buttons
[19:22] <ralsina> Basically, that I need to do a whole review of how to interact with the keyboard. And that one way to fix it is override the default [enter] shortcut
[19:22] <alecu> ralsina, what about making the "Sign In" button be part of the wizard buttons?
[19:22] <ralsina> alecu: have to ask design, and change SSO
[19:22] <alecu> ralsina, ok
[19:23]  * alecu gets back to code
[19:28] <nessita> dobey: url printed and added
[19:29] <dobey> ah
[19:29] <dobey> the C: needs to be changed to C|
[19:29] <nessita> mandel: you gone?
[19:29] <dobey> not sure the best way to do that, though
[19:30] <dobey> other than to make that test partially platform-dependent
[19:32] <ralsina> alecu: can you tell me what is the result of  type(1337) in your python?
[19:32] <alecu> ralsina, __elite__
[19:33] <ralsina> alecu: seriously :-)
[19:33] <ralsina> if it's long, that's why the test fails for you (it's int here)
[19:33] <ralsina> And in ay case, I have to fix a line of code
[19:34] <alecu> Python 2.7.1 (r271:86832, Nov 27 2010, 18:30:46) [MSC v.1500 32 bit (Intel)] on
[19:34] <alecu> win32
[19:34] <alecu> Type "help", "copyright", "credits" or "license" for more information.
[19:34] <alecu> >>> type(1337)
[19:34] <alecu> <type 'int'>
[19:34] <alecu> ralsina, does it help?
[19:35] <nessita> ralsina: besides the test failure, there are lint issues on linux (added to the MP)
[19:37] <ralsina> alecu: ok, no idea of *why* it fails, but it may be fixed now.
[19:37] <ralsina> nessita: on SSO? Yes, those were there already but I can fix them.
[19:37] <dobey> ralsina: hrmm, int vs long should only matter if it's a very large number, or the byte ordering is different. and i don't think windows deals with the latter well at all :)
[19:38] <nessita> ralsina: on *linux* (they were not there)
[19:38] <ralsina> dobey: basically if it's a number, I have to call humanize() on it
[19:38] <ralsina> nessita: I didn't touch anything on the linux files
[19:38]  * ralsina pinky-swears he didn't
[19:38] <nessita> ralsina: I know. When running the test suite in linux, there are lint issues on the windows code that needs to be fixed
[19:39] <nessita> ralsina: if you look the comment, those are pretty fixeable issues
[19:39] <ralsina> nessita: ok, that makes more sense. Will check.
[19:57] <ralsina> nessita: fixed https://code.launchpad.net/~ralsina/ubuntu-sso-client/fix_803661/+merge/66456 -- because of PYTHONPATH I was running the tests on trunk :-(
[19:59] <nessita> ralsina: ack
[20:02] <nessita> facundobatista: nested branch approved
[20:03] <facundobatista> nessita, nice!
[20:04] <nessita> ralsina: ubuntu_sso/qt/tests/test_windows.py:
[20:04] <nessita>     132:  [C0301] Line too long (91/79)
[20:04] <facundobatista> nessita, well, the not-nested one, right? ;)
[20:04] <nessita> :-)
[20:04] <ralsina> nessita: grrrrrr on me
[20:04] <nessita> ralsina: indeed! :-P
[20:04] <facundobatista> ralsina, 91????
[20:04] <facundobatista> ralsina, not 80, or 81... 91??? jajaj
[20:04] <nessita> bad news is that syncdaemon is stuck in windows :-/
[20:04] <nessita> has 2 items left in the queue, and is doing nothing else
[20:06] <alecu> nessita, remember that the txnamedpipes reactor for windows is broken even when connecting thru tcp. That means that random errors you see on windows may be atributable to that.
[20:06] <alecu> nessita, just a few more hours :-)
[20:07] <nessita> alecu: right... good point. I will see thru the logs, so far all errors were, well, real errors in the code :-)
[20:07] <alecu> nessita, well, that makes sense as well :-)
[20:08] <ralsina> nessita: I had fixed that, I forgot to push it :-(
[20:08] <nessita> ralsina: oh!
[20:08] <alecu> nessita, ralsina: please, can you review my first u1client branch? https://code.launchpad.net/~alecu/ubuntuone-client/pipe-refactor/+merge/66514
[20:08] <ralsina> nessita: so there, ready for re-re-review. I am starting to feel incredibly stupid today.
[20:09] <ralsina> alecu: yessir!
[20:09] <nessita> alecu: sure, after I finish with ralsina's
[20:09] <alecu> nessita, ralsina: this branch is only refactor, so I can move the code from txnamedpipes to qtreactor in a smaller branch
[20:09] <dobey> ralsina: it's called realizing you're just a puny human. :)
[20:10] <ralsina> dobey: I am hardly puny compared to most humans (eric excepted). I do feel stupid, but there is nothing wrong with my size :-)
[20:12] <dobey> ralsina: stomach size != brain size :)
[20:13] <thisfred> BRAAAAINS
[20:13] <nessita> ralsina: APPROVED, finally
[20:13] <ralsina> nessita: yay, I guess
[20:13] <nessita> alecu: your turn sweety
[20:14]  * nessita is in the mood "thanks" to babasonicos
[20:15] <nessita> alecu: can you please merge trunk in?
[20:15] <nessita> Text conflict in tests/platform/windows/test_tools.py
[20:15] <nessita> 1 conflicts encountered.
[20:16] <alecu> uhhh
[20:36] <nessita> alecu: you let me know when is done?
[20:37] <alecu> nessita, sure. I found another thing that broke after merging reactor and running tests, so I'm fixing it.
[20:37] <nessita> ack
[21:00] <alecu> nessita, fix and pushed (hopefully!)
[21:01] <nessita> looking
[21:02] <ralsina> alecu, nessita: I have a much smaller branch I hope can pass without 5 re-reviews. You can approve it by looking at pictures if you want ;-) https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803677/+merge/66466
[21:02] <alecu> ralsina, will look at pictures and approve.
[21:02] <alecu> ralsina, I trade for one review of mine
[21:02] <alecu> https://code.launchpad.net/~alecu/ubuntuone-client/pipe-refactor/+merge/66514
[21:02]  * ralsina adds pictures of pretty blondes
[21:02] <ralsina> alecu: was looking at it already :-)
[21:02] <alecu> ralsina, approved!
[21:03] <nessita> ralsina: queueing that up
[21:03] <ralsina> nessita: ok, no rush for this one
[21:12] <alecu> ralsina, I'm getting this: http://pastebin.ubuntu.com/635990/
[21:12] <alecu> ralsina, and the fields are empty :-(
[21:13] <nessita> alecu: branch looks good, running tests
[21:13] <alecu> ralsina, my path is set right, and the sso is running
[21:13] <alecu> ralsina, perhaps it's because the sso on trunk is not qtreactor based?
[21:13] <ralsina> alecu: old SSO
[21:13] <ralsina> alecu: and you need to run setup.py build on SSO before testing this branch, as well
[21:14] <alecu> aha
[21:14] <nessita> ralsina: is this https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803677/+merge/66466 as WIP for some reason?
[21:15] <nessita> ralsina: so, aren't there tests that test the calls you're making to CurrentUserController and related?
[21:15] <ralsina> nessita: I don't know how to remove it :-)
[21:15] <alecu> ralsina, building sso worked.
[21:16] <ralsina> nessita: there are tests for how CurrentUserController works, on SSO
[21:16] <alecu> ralsina, now I get the labels, I get no stacktrace, but I get this warning on stdout: QWizardPage::addField: Duplicate field 'email_address'
[21:16] <ralsina> alecu: harmless
[21:16] <nessita> ralsina: right, but within the installer we should have tests about how the installer calls the CurrentUserController
[21:17] <alecu> ralsina, cool
[21:17] <nessita> ralsina: we should have every piece of non-generated code tested\
[21:17] <ralsina> nessita: hmmmm ok, easy to add. But I can only test that I am setting the right title/subtitle. And I would have to import those from gui.py... I will add it ayway.
[21:17] <nessita> ralsina: yes, that's the perfect test
[21:18] <nessita> ralsina: seems silly, but pays in the long term
[21:18] <ralsina> So, import two constants, call the function with them, and see I get them back? That's exactly the SSO test for title/subtitle :-)
[21:18] <alecu> ralsina, one tiny nitpick: "...with your existing Ubuntu Oneusername": there's no space between "Ubuntu One" and "username"
[21:18] <alecu> ralsina, other than that, approved.
[21:18] <ralsina> nessita: ok, I see the possible regression now (changing the call and forgetting to set the subtitle)
[21:19] <ralsina> alecu: fixing the typo, nessita, adding the test
[21:19] <nessita> ralsina: the assert is about the call being properly made, not the label being set with the proper string
[21:19] <nessita> ralsina: the test about the label having the proper string is in SSO, and I agree there is no point in duplicating
[21:20] <nessita> is also discouraged, since we may change the subtitle to be added as, crazy example, a tooltip
[21:20] <ralsina> nessita: but the only arguments I am passing are those two strings.
[21:20] <nessita> and in that case we should change 2 places <- crazy
[21:20] <nessita> ralsina: I can go and change those string to 'perro' and 'gato' and I expect a test to fail
[21:20] <nessita> not the constants, but the args in the call
[21:21] <ralsina> nessita: hmmmm ok, I think I get it now. let me write the test.
[21:21] <nessita> ralsina: can you see my point?
[21:22] <ralsina> So, I have to check that MainWindow.current_user_controller._title is the right constant and the same for subtitle.
[21:22] <nessita> ralsina: well, not _title since is not a public attr. YOu can patch the class and assert about the args passed
[21:23] <ralsina> right
[21:23] <ralsina> it's faked already so I can do that
[21:23] <nessita> great!
[21:23] <nessita> alecu: approving
[21:23] <alecu> woohoo!
[21:23]  * alecu is rushing to finish u1client
[21:30] <ralsina> nessita: added test
[21:32] <nessita> ack
[21:32] <ralsina> alecu: +1
[21:33] <alecu> ralsina, thanks!
[21:46] <ralsina> I'm about to EOD now. report being sent in a bit, but all things considered, not really productive today :-(
[21:47] <alecu> bug #803672
[21:47] <ubot4> Launchpad bug 803672 in ubuntu-sso-client "Do not start two instances of this process (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/803672
[21:48] <dobey> hrmm, i just remembered something regarding perf reviews
[21:48] <dobey> but i can bug tomorrow
[21:52] <nessita> ralsina: I'll leave the review result in the MP
[21:52] <ralsina> dobey shoot
[21:52] <nessita> hopefully is an approve and nothing is left in that area
[21:52] <ralsina> nessita: if it's approve mark it for approval so I start with only one open branch tomorrow :-)
[21:52] <nessita> of course
[21:58] <nessita> ralsina: approved. Did you see alecu's comment? Please just remove the space between the app_name and the text "username"          Reply
[22:01] <ralsina> nessita: checking...
[22:02] <ralsina> nessita, alecu: is that in the subtitle?
[22:02] <nessita> yes
[22:03] <nessita> "Sign in with your existing Ubuntu One username and password."
[22:03] <alecu> can't find any .srt file!
[22:03] <nessita> sounds better to say
[22:03] <nessita> "Sign in with your existing username and password."
[22:03] <nessita> alecu: .srt?
[22:03] <nessita> lol
[22:03] <nessita> I'm SO slow at this point
[22:04] <alecu> brb
[22:04] <ralsina> nessita: the texts came from design. Anyway, I asked for final signoff on these, because the SSO screens were not in the final texts document
[22:05] <nessita> ok
[22:07] <ralsina> report sent
[22:07] <ralsina> and EOD achieved :-)
[22:07] <nessita> ralsina: amen
[22:07]  * nessita eoding as well
[22:12]  * alecu is about to push...
[22:13] <nessita> boy or girl?
[22:13] <nessita> :-P
[22:14] <alecu> we'll find out soon...
=== m_conley is now known as m_conley_away
[22:15] <dobey> alright, i'm off. good evening all!
[22:16] <ralsina> alecu, I must be too tired but I don't understand the comment about the space in https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803677/+merge/66466 :-(
[22:17] <alecu> ralsina, let me take a look.
[22:18] <nessita> oh, I approved that already
[22:18] <alecu> ralsina, it seems you have already fixed it here: http://bazaar.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803677/revision/16
[22:18] <nessita> because of what you've said about signing off the texts
[22:19] <ralsina> oh, it's ADD the space :-)
[22:19] <ralsina> the comment says REMOVE the space
[22:19] <ralsina> nessita: yes, this is idle curiosity
[22:19] <alecu> doh
[22:19] <alecu> ralsina, sorry! too sleepy today.
[22:19] <nessita> ok, I'm off
[22:19] <nessita> bye!
[22:20] <alecu> nessita, ralsina: https://code.launchpad.net/~alecu/ubuntuone-client/use-standard-reactor/+merge/66521
[22:20] <ralsina> bye nessita!
[22:20] <alecu> for review, tomorrow :-)
[22:20] <nessita> alecu: will review that later
[22:20] <nessita> bye!
[22:20] <ralsina> alecu: put it in the report, I will do mine early and awake
[22:20] <alecu> bye!!!!
[22:25] <beuno> that's a lot of candidates!
[22:25] <beuno> that's great
[22:25] <beuno> (ignore that)
[22:25]  * ralsina whistles, looks up and pushes those two lines under the rug
[22:32] <thisfred> dog o'clock, later all
[23:36]  * alecu eods
[23:36] <alecu> bye all