| === m_conley is now known as m_conley_away | ||
| === agent00tai|AFK is now known as agent00tai | ||
| didrocks | good morning | 06:46 |
|---|---|---|
| oSoMoN | good morning | 07:03 |
| === agent00tai is now known as agent00tai|AFK | ||
| MacSlow | greetings everyone | 07:18 |
| === agent00tai|AFK is now known as agent00tai | ||
| === hunger_ is now known as hunger | ||
| === API is now known as API_afk | ||
| === Jens is now known as Guest1099 | ||
| === Guest1099 is now known as jbache | ||
| andyrock | njpatel, ping | 09:44 |
| njpatel | andyrock, hey | 09:44 |
| njpatel | andyrock, dude, I recompiled your branch yesterday and none of my branches were showing up! | 09:44 |
| njpatel | branches? | 09:44 |
| njpatel | devices | 09:44 |
| andyrock | njpatel, in ccsm the device option is Only Mounted right? | 09:45 |
| njpatel | andyrock, yes, i tried all the device options | 09:45 |
| andyrock | njpatel, how do you start unity? | 09:46 |
| njpatel | andyrock, also, you connect to GSettings automatically, but we have FavouriteStore to hide the implementation (and provide a nicer interface) | 09:46 |
| njpatel | andyrock, compiz --replace | 09:46 |
| andyrock | njpatel, from tty? | 09:46 |
| njpatel | andyrock, from gnome-terminal | 09:46 |
| andyrock | njpatel, this is weird... | 09:47 |
| andyrock | njpatel, sometimes if i start unity (and compiz) form tty (alt+ctrl+f1) gio stuff doesn't work | 09:49 |
| njpatel | andyrock, yeah, I'll try the branch again with clean compile in a couple of hours (in the office and have some meetings) | 09:49 |
| njpatel | andyrock, interestin | 09:49 |
| njpatel | andyrock, could you take a look at the favoritestore thing and i'll ping you once I've had a chance to rebuild? | 09:50 |
| andyrock | njpatel, i think the problem is in gio/glib... but i start unity from gnome-terminal it should work... | 09:50 |
| njpatel | andyrock, I'll also try logging out and logging in | 09:50 |
| andyrock | njpatel, of course... | 09:50 |
| njpatel | andyrock, I always start from gnome-terminal, that's why I was a bit worried | 09:50 |
| andyrock | njpatel, so DevicesSettings should be derived from favoritestore right? | 09:51 |
| andyrock | njpatel, i will look it this afternoon... i have to go to gym now :) | 09:52 |
| njpatel | andyrock, I think use the FavoritesStore instance (I think it's a singleton) | 09:53 |
| njpatel | andyrock, okay, have fun! :) | 09:53 |
| andyrock | njpatel, you too (meetings etc. :P ) | 09:53 |
| === agent00tai is now known as agent00tai|AFK | ||
| === agent00tai|AFK is now known as agent00tai | ||
| === MacSlow is now known as MacSlow|lunch | ||
| === agent00tai is now known as agent00tai|AFK | ||
| === agent00tai|AFK is now known as agent00tai | ||
| === agent00tai is now known as agent00tai|AFK | ||
| === MacSlow|lunch is now known as MacSlow | ||
| === m_conley_away is now known as m_conley | ||
| andyrock | njpatel, do you have a moment? | 13:27 |
| njpatel | andyrock, somewhat, what's up? | 13:28 |
| andyrock | njpatel, about FavoriteStore... | 13:29 |
| andyrock | njpatel, FavoriteStoreGSettings derive from FavoriteStore | 13:29 |
| andyrock | DeviceSettings could derive from FavoriteStore... | 13:29 |
| === m_conley is now known as m_conley_away | ||
| andyrock | but in FavoriteStore.cpp we have: | 13:30 |
| andyrock | FavoriteStore& FavoriteStore::GetDefault() | 13:30 |
| andyrock | { | 13:30 |
| andyrock | static internal::FavoriteStoreGSettings instance; | 13:30 |
| andyrock | return instance; | 13:30 |
| andyrock | } | 13:30 |
| njpatel | andyrock, yeah | 13:30 |
| andyrock | njpatel, it'a a bit weird as a super class :) | 13:31 |
| andyrock | njpatel, maybe i can join DeiviceSettings in FavoriteStoreGSettings... | 13:32 |
| njpatel | andyrock, agreed :) | 13:33 |
| njpatel | andyrock, it's thumper's doing ;) | 13:33 |
| njpatel | andyrock, it's nice to have them sepeaate to be able to test them separately | 13:34 |
| njpatel | separate* | 13:34 |
| andyrock | njpatel, i don't understand.... can you make an example? | 13:35 |
| andyrock | njpatel, please :) | 13:35 |
| njpatel | andyrock, I just mean that, in devices settings, when you change the gsettings stuff, you should just be using FavoriteStore instead | 13:38 |
| njpatel | andyrock, i.e. there should be no "GSettings" in DeviceSettings, just FavoriteStore | 13:38 |
| andyrock | njpatel, but FavoriteStore is an abstract/virtual class... | 13:42 |
| njpatel | andyrock, FavoriteStore::GetDefault () gives you the singleton that you need to work on | 13:43 |
| njpatel | work with * | 13:43 |
| === _LibertyZero is now known as LibertyZero | ||
| === m_conley_away is now known as m_conley | ||
| andyrock | seb128, around? | 14:05 |
| seb128 | yes | 14:05 |
| andyrock | seb128, about this bug: https://bugs.launchpad.net/ubuntu/+source/unity/+bug/806485 | 14:06 |
| ubot5 | Ubuntu bug 806485 in unity (Ubuntu) "[oneiric] unity::PanelIndicatorObjectEntryView::Refresh() is leaking" [High,New] | 14:06 |
| seb128 | yes? | 14:06 |
| andyrock | seb128, a g_object_unref(stream) in make_pixbuf should be good... | 14:07 |
| seb128 | right | 14:07 |
| seb128 | we discussed it with thumper earlier and that's what he suggested as well | 14:07 |
| andyrock | seb128, but i have a question for you :) can you give me the right valgrind command to collect information? :) | 14:08 |
| seb128 | but feel free to do a merge request to fix it ;-) | 14:08 |
| seb128 | andyrock, https://wiki.ubuntu.com/Valgrind | 14:08 |
| seb128 | use the command from there on "compiz --replace" | 14:09 |
| andyrock | seb128, g_input_stream_close doesn't unref the stream... | 14:09 |
| andyrock | seb128, ok thx | 14:09 |
| seb128 | right, the api documentation is not really clear, it could suggest that it needs to be freed | 14:10 |
| andyrock | agreed | 14:12 |
| === agent00tai|AFK is now known as agent00tai | ||
| === agent00tai is now known as agent00tai|AFK | ||
| === daker is now known as daker_ | ||
| === oubiwann is now known as oubiwann-lunch | ||
| jcastro | Hi! | 19:06 |
| jcastro | anyone here for the unity contributor meeting? | 19:06 |
| jcastro | ok, looks like no one has pending issues, so I'll just stand by if people have questions | 19:10 |
| === Hodge is now known as Hodgestar | ||
| === yofel_ is now known as yofel | ||
| === oubiwann-lunch is now known as oubiwann | ||
| === m_conley is now known as m_conley_away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!