=== m_conley is now known as m_conley_away === agent00tai|AFK is now known as agent00tai [06:46] good morning [07:03] good morning === agent00tai is now known as agent00tai|AFK [07:18] greetings everyone === agent00tai|AFK is now known as agent00tai === hunger_ is now known as hunger === API is now known as API_afk === Jens is now known as Guest1099 === Guest1099 is now known as jbache [09:44] njpatel, ping [09:44] andyrock, hey [09:44] andyrock, dude, I recompiled your branch yesterday and none of my branches were showing up! [09:44] branches? [09:44] devices [09:45] njpatel, in ccsm the device option is Only Mounted right? [09:45] andyrock, yes, i tried all the device options [09:46] njpatel, how do you start unity? [09:46] andyrock, also, you connect to GSettings automatically, but we have FavouriteStore to hide the implementation (and provide a nicer interface) [09:46] andyrock, compiz --replace [09:46] njpatel, from tty? [09:46] andyrock, from gnome-terminal [09:47] njpatel, this is weird... [09:49] njpatel, sometimes if i start unity (and compiz) form tty (alt+ctrl+f1) gio stuff doesn't work [09:49] andyrock, yeah, I'll try the branch again with clean compile in a couple of hours (in the office and have some meetings) [09:49] andyrock, interestin [09:50] andyrock, could you take a look at the favoritestore thing and i'll ping you once I've had a chance to rebuild? [09:50] njpatel, i think the problem is in gio/glib... but i start unity from gnome-terminal it should work... [09:50] andyrock, I'll also try logging out and logging in [09:50] njpatel, of course... [09:50] andyrock, I always start from gnome-terminal, that's why I was a bit worried [09:51] njpatel, so DevicesSettings should be derived from favoritestore right? [09:52] njpatel, i will look it this afternoon... i have to go to gym now :) [09:53] andyrock, I think use the FavoritesStore instance (I think it's a singleton) [09:53] andyrock, okay, have fun! :) [09:53] njpatel, you too (meetings etc. :P ) === agent00tai is now known as agent00tai|AFK === agent00tai|AFK is now known as agent00tai === MacSlow is now known as MacSlow|lunch === agent00tai is now known as agent00tai|AFK === agent00tai|AFK is now known as agent00tai === agent00tai is now known as agent00tai|AFK === MacSlow|lunch is now known as MacSlow === m_conley_away is now known as m_conley [13:27] njpatel, do you have a moment? [13:28] andyrock, somewhat, what's up? [13:29] njpatel, about FavoriteStore... [13:29] njpatel, FavoriteStoreGSettings derive from FavoriteStore [13:29] DeviceSettings could derive from FavoriteStore... === m_conley is now known as m_conley_away [13:30] but in FavoriteStore.cpp we have: [13:30] FavoriteStore& FavoriteStore::GetDefault() [13:30] { [13:30] static internal::FavoriteStoreGSettings instance; [13:30] return instance; [13:30] } [13:30] andyrock, yeah [13:31] njpatel, it'a a bit weird as a super class :) [13:32] njpatel, maybe i can join DeiviceSettings in FavoriteStoreGSettings... [13:33] andyrock, agreed :) [13:33] andyrock, it's thumper's doing ;) [13:34] andyrock, it's nice to have them sepeaate to be able to test them separately [13:34] separate* [13:35] njpatel, i don't understand.... can you make an example? [13:35] njpatel, please :) [13:38] andyrock, I just mean that, in devices settings, when you change the gsettings stuff, you should just be using FavoriteStore instead [13:38] andyrock, i.e. there should be no "GSettings" in DeviceSettings, just FavoriteStore [13:42] njpatel, but FavoriteStore is an abstract/virtual class... [13:43] andyrock, FavoriteStore::GetDefault () gives you the singleton that you need to work on [13:43] work with * === _LibertyZero is now known as LibertyZero === m_conley_away is now known as m_conley [14:05] seb128, around? [14:05] yes [14:06] seb128, about this bug: https://bugs.launchpad.net/ubuntu/+source/unity/+bug/806485 [14:06] Ubuntu bug 806485 in unity (Ubuntu) "[oneiric] unity::PanelIndicatorObjectEntryView::Refresh() is leaking" [High,New] [14:06] yes? [14:07] seb128, a g_object_unref(stream) in make_pixbuf should be good... [14:07] right [14:07] we discussed it with thumper earlier and that's what he suggested as well [14:08] seb128, but i have a question for you :) can you give me the right valgrind command to collect information? :) [14:08] but feel free to do a merge request to fix it ;-) [14:08] andyrock, https://wiki.ubuntu.com/Valgrind [14:09] use the command from there on "compiz --replace" [14:09] seb128, g_input_stream_close doesn't unref the stream... [14:09] seb128, ok thx [14:10] right, the api documentation is not really clear, it could suggest that it needs to be freed [14:12] agreed === agent00tai|AFK is now known as agent00tai === agent00tai is now known as agent00tai|AFK === daker is now known as daker_ === oubiwann is now known as oubiwann-lunch [19:06] Hi! [19:06] anyone here for the unity contributor meeting? [19:10] ok, looks like no one has pending issues, so I'll just stand by if people have questions === Hodge is now known as Hodgestar === yofel_ is now known as yofel === oubiwann-lunch is now known as oubiwann === m_conley is now known as m_conley_away