[07:52] <mandel> morning all
[07:52] <mandel> fagan: happy bday
[07:52] <fagan> morning mandel thanks :)
[07:59]  * mandel is really tired...
[08:45]  * fagan takes a quick break to get some milk 
[09:24] <fagan> connection issues mandel? :)
[09:27] <mandel> fagan: 3G, so it sometimes decides to go… also adium is a bit shit regarding irc...
[09:28] <fagan> mandel: my ma has one of those yokes and IRC doesnt even work on it
[09:30] <mandel> fagan: in my case, I don't know why it just decides to crash...
[09:32] <fagan> mandel: weird
[09:37] <mandel> fagan: yes.. is a PITA but I can deal with it, 3G so far has been working very well, can browse etc… and Windows has updated several times so far...
[09:50] <czajkowski> mandel: how is your brother???
[09:51] <mandel> czajkowski: he is ok, apparently he decided to slid downhill with a plastic and water or something like that… went to hospital had an MIR and got told he was lucky :)
[09:52] <mandel> czajkowski: is in our blood we are dangerously stupid :)
[09:58] <czajkowski> mandel: spanish :p
[10:00] <mandel> czajkowski: yes hehe
[10:22] <lalejand> Hi, I have ubuntuone-sync and ubuntuone-indic both oscilating between 65 an 95% CPU :/
[10:23] <lalejand> and u1sdtool is "processing the command pool"
[10:24] <lalejand> Is ti normal taht it takes so much CPU ? Nautilus is barely usable
[10:24] <mandel> lalejand: no, it is not normal at all
[10:25] <mandel> lalejand: if you fill like taking a look on what is going on I recomend you use https://launchpad.net/magicicada
[10:26] <ralsina> morning!
[10:26] <mandel> lalejand: is a front end for sdtool that should make more sense and can show you WTF is syncdaemon doing...
[10:26] <mandel> ralsina: morning!
[10:26] <mandel> ralsina: fancy a nice mumble about utf8, file systems and their different mothers...
[10:26] <mandel> ralsina: at least before I take a swim/walk to think about it...
[10:26] <mandel> actually better skype
[10:27] <ralsina> My son is asleep 2meters from here
[10:27] <ralsina> so no talking for at least 90 miutes sorry :-(
[10:27] <mandel> ralsina: then we type
[10:27] <ralsina> basically, file names are bytes, andnot guaranteed to decode correctly in any way
[10:28] <mandel> ralsina: exactly, so we can use unicode in all the windows operations with no problem
[10:28] <mandel> ralsina: but sd wants bytes.. so we can deal with the diff paths but when we encode, we are fucked...
[10:29] <ralsina> well...
[10:29] <mandel> ralsina: we could use url encoding, is ugly but will fix that issue but then users can type paths like that
[10:29] <ralsina> we could be bytes all the way
[10:29] <mandel> which is when I'd tell them to stop screwing up with me :)
[10:29] <fagan> oh hi ralsina
[10:29] <ralsina> as in, taking the file names as-is
[10:30] <mandel> ralsina: waht do you mean?
[10:30] <ralsina> the problem you have is that you take a str from the filename, convert it to unicode, modify, and then you need to re-convert to str to use it on the fs again, right?
[10:31] <ralsina> Or maybe I am understading the problem itself wrong
[10:31] <ralsina> because if sd wants bytes, and windows gives you bytes... let's just use bytes
[10:31] <mandel> ralsina: no, what I do is, convert to unicode, modify it and write it to the fs with no problem
[10:32] <mandel> and windows can always give be utf8 with no problem
[10:32] <ralsina> so, the problemis converting to bytes to give to sd?
[10:32] <mandel> ralsina: actually know that I think about it I'm stupid… I know how to sort it out...
[10:32] <lalejand> mandel : no deb for magicicada ?
[10:32] <ralsina> a utf-8 string *is* bytes
[10:35] <mandel> ralsina: actually, I'm lying, I do not know how to fix it… we can talk in 90 min, over irc is hard to explain the issue
[10:35] <mandel> or solution for that matter
[10:35] <ralsina> mandel: ok
[10:36] <mandel> lalejand: let me look for it
[10:36] <ralsina> I don't understand what you mean by "sd" for example, sice your code *is* in sd ;-)
[10:36] <mandel> lalejand: which letter? M, N or O?
[10:37] <lalejand> mandel : wich letter ? I don't understand
[10:37] <lalejand> mandel : I downloaded the tgz and lauched it
[10:37] <mandel> lalejand: Maverik, Natty or Oneric :)
[10:37] <lalejand> what should I check in it ?
[10:38] <lalejand> mandel : ah sorry, N
[10:38] <mandel> lalejand: :)
[10:38] <mandel> lalejand: looks like it is in universe: http://packages.ubuntu.com/natty/magicicada
[10:38] <mandel> lalejand: if you launch it and connect to sd you should be able to see the diff operations going on
[10:40] <mandel> ralsina: the problem I have is the following, if you tell os_helper to give the abspath it must return byte with the illegal chars, and next os_helper operation should take those, change back to utf-8 and perform the operation.. and I think that would solve the issues
[10:41] <mandel> ralsina: the annoying part is that we will move to unicode in the future, lo que me toca los huevos un poco...
[10:41] <lalejand> mandel : yes I see them. meta queue --> a loooot of unlink, content queue --> a looot of upload
[10:41] <ralsina> mandel: you know who knows a lot about unicode and such? facundobatista. And he also knows a lot about syncdaemon. Win win! ;-)
[10:42] <mandel> ralsina: which is the person I was arguing with yesterday :)
[10:42] <mandel> in a friendly manner, of course, you know me
[10:42] <lalejand> mandel : the U1 indicator shows the same since almos 1h now : uploading 3 files : 8%, 0% and 0%
[10:42] <mandel> lalejand: is that what you expected to see?
[10:43] <mandel> lalejand: from magicicada you can tell to stop with those uploads (I think)
[10:43] <lalejand> mandel : I suppose, yes. But it looks like it is stuck now. I am generating and regenerating a lot of files
[10:43] <mandel> lalejand: lets see if the debugging god is around, rye are you here?
[10:43] <rye> lalejand, mandel yep, looking
[10:44] <mandel> lalejand: rye is way more intelligent than me, I'm just a code monkey, rye you take care of it? :)
[10:44] <rye> lalejand, try killing ubuntuone-indicator first - that might be causing excessive SD interrupts in some weird cases
[10:45] <mandel> ralsina: I'm of for 30 min to think about the utf8 but I think I got it
[10:45] <rye> lalejand, are you uploading/downloading a large number of files?
[10:45] <lalejand> rye : ok I will disconnect U1, but I was leaving it in case you needed some information about its actual state
[10:45]  * rye needs to rate-limit some operations in indicator
[10:45] <rye> lalejand, no no no
[10:45] <rye> lalejand, killall ubuntuone-indicator
[10:45] <rye> lalejand, it is an external process so it will not affect anything if it is killed
[10:46] <lalejand> rye : I think so, yes. And worst than that : generating and regenerating a large number of files that are being uploaded
[10:46] <lalejand> rye : u1-indicator ok
[10:47] <lalejand> rye : U1-indic killed
[10:47] <mandel> ralsina: we will fix it, but on Windows we are doing a stupid amount of extra work I do not like… and I wonder how it works in other OS...
[10:47] <mandel> anyway I go, will be back soon
[10:47] <lalejand> rye :u1sync is at 46% cpu right now
[10:48] <lalejand> rye : now 3% :)
[10:48] <lalejand> rye : indic was the problem
[10:49]  * fagan calls mandel mande from now on :)
[10:49] <lalejand> rye : oh no, 65% now
[10:49] <ralsina> fagan, you don't want to
[10:49] <ralsina> fagan: "mande" means "give me an order" :-)
[10:49] <ralsina> fagan: btw, happy birthday
[10:50] <fagan> ralsina: thanks :0
[10:50]  * fagan even learns a bit of spanish
[10:51] <lalejand> rye : 90% buuu :(
[10:52] <rye> lalejand, okay, i think i know what can be causing this in indicator, sd is scanning the folders/queueing up things. Every single item being added causes SD to emit notification that something has changed. Indicator listens on these notifications and queries sd about the changes.
[10:53] <rye> lalejand, could you please check how crazy is ~/.cache/ubuntuone/log/syncdaemon.log is being written? (tail ~/.cache/ubuntuone/log/syncdaemon.log)
[10:53] <rye> lalejand,  tail -f
[10:58]  * fagan break
[10:59] <lalejand> rye : quite calm now
[11:00] <rye> lalejand, and still using the cpu ?
[11:03] <lalejand> rye : nope, not now
[11:04] <lalejand> rye : but using 42% mem
[11:06] <lalejand> rye : nothing happens in magicicada, no move
[11:06] <lalejand> rye : 52% mem now
[11:10] <rye> lalejand, could you please try tunning u1sdtool --waiting | wc -l
[11:11] <lalejand> rye : 90% cpu, 69% mem now
[11:11] <lalejand> rye : ok
[11:13] <rye> lalejand, it should print out a number
[11:13] <lalejand> rye : magicicada shows same list o meta & content queue
[11:14] <rye> lalejand, ah, could you please try shutting down magicicada too?
[11:14] <lalejand> rye : Traceback (most recent call last): Failure: dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken. 2
[11:14] <rye> lalejand, and run u1sdtool --waiting | wc -l in terminal
[11:16] <lalejand> rye : it says what I copi-pasted above
[11:16] <lalejand> rye : 99%, 51%. Nautilus totally stuck
[11:16] <facundobatista> Muy buenos días a todos!
[11:17] <rye> lalejand, so it is too busy doing something and something is not right. Could you please pastebin the output of grep MARK ~/.cache/ubuntuone/log/syncdaemon.log* ?
[11:17] <lalejand> rye : it returns me nothing
[11:18] <lalejand> rye : 7% 56%
[11:18] <rye> lalejand, okay, so now neither ubuntuone-indicator nor magicicada is running, am I correct?
[11:19] <lalejand> rye : correct
[11:19] <lalejand> rye : nautilus still frozen
[11:20] <rye> lalejand, hm, could you please pastebin the last 10 lines of ~/.cache/ubuntuone/log/syncdaemon.log - they may contain filenames (tail -n 10 ~/.cache/ubuntuone/log/syncdaemon.log) - feel free to remove the filenames from there if they are sensitive
[11:23] <lalejand> rye : http://pastebin.com/0LU9d7gM
[11:24] <lalejand> rye : nautilus is usable now
[11:25] <rye> lalejand, is syncdaemon idle now (u1sdtool --status)
[11:27] <lalejand> rye : can't check it : Oops, an error ocurred: Traceback (most recent call last): Failure: dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[11:40] <duanedesign> mandel: that is one thing that really annoys me about Windows is the updates. I only boot my windows box once a month or so and it always wants to spend 30 minutes doing updates
[11:41] <rye> duanedesign, the same would have happened if we booted ubuntu once a month... not 30 minutes though... probably
[11:42] <mandel> duanedesign: yeah.. is a major PITA, yesterday I wasted a stupid amount of time due to that
[11:42] <rye> facundobatista, how often does sd react on dbus requests? I mean is this a separate thread for serving dbus or just an idle handler?
[11:47] <facundobatista> rye, for the deepest detail I'll need to check code or ask verterok, but it's immediate, as it's integrated in twisted's reactor
[11:48] <rye> facundobatista, ah, ok, so if e.g. u1sdtool --waiting results in NoReply dbus exception it may mean that the amount of data being collected is quite large, right?
[11:49] <facundobatista> rye, yes
[11:50] <facundobatista> rye, see #754050 that will prevent that
[11:50] <facundobatista> rye, feel free to upgrade it to "high" if you think it's important
[11:53] <nessita> good morning everyone!
[11:53] <facundobatista> Hola nessita
[11:53] <ralsina> good morning nessita!
[11:54] <nessita> hola facundobatista, ralsina
[11:54] <rye> facundobatista, well, yes. I'd still like the remaining upload/download amount too though
[11:54] <nessita> facundobatista, mandel: did you guys have sync regarding branches?
[11:55] <lalejand> rye : sorry I can't see the status. Trying, but I walways get an error message. And everything is very slow
[11:55] <rye> lalejand, ok, let's try this - "tail -f ~/.cache/ubuntuone/log/syncdaemon.log* | grep MARK" and keep it running for some minutes (it won't affect the performance more than SD)
[11:55] <rye> lalejand, i am trying to find out the number of files in the queue
[11:56] <facundobatista> nessita, I answered the mail yesterday evening
[11:56] <rye> facundobatista, should --status be less memory-heavy ^
[11:56] <nessita> mandel: were you able to appply changes?
[11:56] <facundobatista> rye, status is not memory-heavy at all
[11:57] <facundobatista> rye, if SD is not answering then it may be working really too hard doing something else (maybe processing and trashing because the previous --waiting?)
[11:57] <rye> facundobatista, ah, that can be it, and waiting request blocks all other operations, right?
[11:58] <mandel> nessita: I'm on the middle of a big branch that ensures that all paths are byte and with the correct chars in every os_helper method + pyinotify, that should fix the listdir, stat etc errors… but I did not talk with facundobatista yet
[11:58] <facundobatista> rye, not block, but make it to work too much to answer dbus in a timely manner
[12:00] <nessita> mandel: ok, When you can context swicth, please try to have those 2 branches moving in the land queue (were those 2 or only 1?)
[12:04] <mandel> nessita: there are 2, yet if the fix I'm doing know works correctly one of them will be supeseeded by it since the solution is cleaner, the other is regarding the test complexity
[12:04] <nessita> mandel: yeah, and we talked about that yesterday in the meeting, so if you have any doubts about how to fix the test, please ping me
[12:05] <mandel> nessita: yep, will do :)
[12:06] <nessita> mandel: basically, when you need to replace something with a no-op, do not use mock but patch, yes?
[12:06] <mandel> nessita: yep, got it
[12:06] <nessita> mandel: for the tests you're doing mock gives you nothing better than using self.patch
[12:07] <mandel> nessita: in that test precisely you are right.. also I wonder why removing 'b' did not brake the test correctly
[12:08] <nessita> mandel: so, when you finish this branch you're currently working on, I will suggest removing all the mock calls and replace that by patchs (In the branch you need to fix)
[12:08] <mandel> yep
[12:14] <lalejand> rye : 2011-07-07 14:08:58,328 - ubuntuone.SyncDaemon.Main - NOTE - ---- MARK (state: <State: 'QUEUE_MANAGER'  (queues WORKING  connection 'With User With Network')>; queue: 59481; hash: 0)
[12:14] <rye> omg
[12:14] <nessita> ralsina: hey there! can I ask if sent your report yesterday? I'm worried since I only got alecu's, and maybe thunderbird is acting weird on me
[12:14] <rye> 60k queue items. lalejand were these files originally in Ubuntu One or you have added them recently?
[12:15] <ralsina> nessita: no, didn't, felt horrible so stayed in bed :-(
[12:15] <nessita> ralsina: oh, you feeling better now?
[12:15] <rye> facundobatista, do we have any benchmarks regarding cpu usage/upload eta of a large number of files (where large is 60k) ?
[12:15] <ralsina> nessita: not really, but I have stuff to do :-)
[12:16] <facundobatista> rye, we did a couple like 10 months ago
[12:16] <nessita> ralsina: any chance you send your report now?
[12:17] <ralsina> nessita: sure, in 2'
[12:17] <nessita> thanks
[12:18] <rye> lalejand, could you please wait for about 2 minutes more so that we see how the queue is progressing and can plot an approximate eta for files upload?
[12:22] <ralsina> alecu, nessita, mandel: no hurry, this is for any time today, can I get reviews for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_805290/+merge/66739 and https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803929/+merge/66827 please?
[12:23] <nessita> ralsina: queueing that up by opening tabs in FF
[12:23] <ralsina> nessita: thanks!
[12:24] <nessita> ralsina: that cancel message should be shown every single time the user clicks cancel, right?
[12:24] <ralsina> nessita: yes
[12:24] <nessita> ok
[12:29] <nessita> ralsina: can you please add tests for side_widget? basically everything not in an xml file or a generated ui files should have tests
[12:29] <ralsina> nessita: it has no logic. It instantiates the .ui and sets the window caption
[12:30] <nessita> ralsina: you can have typos, someone can screw something up. All the paths should be exercised by tests.
[12:30] <nessita> ralsina: also, I can argue you have logic :-)
[12:30] <ralsina> ok, I'll add a test for it. Checking that the title is right?
[12:30] <nessita> ralsina: stage should 0 when started
[12:30] <nessita> the stage should be assigned when calling set_stage
[12:30] <ralsina> nessita: actually, no, because the wizard will reset it
[12:31] <ralsina> ok, will check
[12:31] <nessita> ralsina: when you call set_stage, you're doing 6 stuff, and each one should have have it's own test
[12:32] <ralsina> nessita: ok, will add tests for that too
[12:32] <nessita> ralsina: also, is there any chance you make test_stage_progression be a unit test? that means, splitting that test in several tests trying to test a single change
[12:32] <ralsina> ok, will do that too
[12:32] <nessita> thanks!!!
[12:33] <ralsina> I think splitting test_stage_progression in 13 tests is overkill, but anything to make you happy!
[12:34] <nessita> ralsina: well, do you have 13 different options when calling on_currentIdChanged?
[12:34] <ralsina> nessita: yes
[12:35] <nessita> ralsina: then is expected to have 13 tests :-)
[12:35] <nessita> when reading that code as is, using "new" eyes, is hard to understand (just happened to me)
[12:41] <ralsina> nessita: ok
[12:42] <nessita> ralsina: for the are you sure branch, I added a needs fixing (requested tests) and a question
[12:42] <ralsina> ok, checking
[12:42] <alecu> hello Ubuntu One!
[12:42] <nessita> hi alecu!
[12:43] <fagan> hey alecu
[12:44] <alecu> hi there all :-)
[12:45] <fagan> 15 mins to standup
[12:48] <ralsina> nessita: I can set the text from python, sure. It will have a bit of HTML, but will be just a <br>
[12:48] <nessita> ralsina: a '\n' will not work?
[12:49] <ralsina> nessita: no, because there is a link: https://launchpadlibrarian.net/74511342/are_you_sure.png
[12:49] <ralsina> nessita: in fact, a <h3> or similar is needed too.
[12:50] <fagan> ralsina: could you not do that in 2 labels?
[12:50] <nessita> ralsina: can we split that in a title, that the string definition has no tag, and when setting in the dialog you add the h3?
[12:50] <ralsina> nessita: yes, I can do that, too. I can split it in paragraphs, too.
[12:50] <nessita> and then the rest of the message without the link, and then you add the link, which is not translatable, at the end?
[12:50] <nessita> something like:
[12:51] <nessita> "If you need more go to %(ubuntu_one_link)s."
[12:51] <nessita> and then you use that passing named parameters
[12:51] <ralsina> yeah yeah
[12:51] <nessita> that will ease the job for translators a lot
[12:52] <ralsina> Ok
[12:52] <ralsina> pushed the other one with 13 tests, and now it checks all the way up to the right labels being enabled for each possible value of page_id on a separate test.
[12:54] <nessita> ralsina: could it be that you forgot to add test_side_widget?
[12:54] <thisfred> standup in 6!
[12:55] <fagan> thisfred: 5 :D
[12:55] <nessita> all: Diego is taking an exam, so he sent me his standup, I will pasting that soon
[12:56] <ralsina> nessita: the side widget is tested completely with 100% coverage over each path (I checked!) by the test_stage_progression tests.
[12:56] <nessita> ralsina: since we're developing independent widgets, we need to have unit tests for that independent widget
[12:56] <ralsina> but sure, I can do the exact same tests passing 1 through 6 for set_stage
[12:57] <nessita> let me see the test_stage_progression in detail, we should no be crossing boundaries
[12:57] <ralsina> nessita: sideWidget is not an independent widget. It can't be used anywhere else except as a side widget in this wizard, but don't worry, I'll repeat the tests.
[12:58] <nessita> ralsina: ok
[13:00] <lalejand> rye : "60k queue items. lalejand were these files originally in Ubuntu One or you have added them recently?" --> I think they have been added
[13:00] <fagan> moi
[13:00] <nessita> me
[13:00] <thisfred> me
[13:00] <alecu> me
[13:00] <fagan> mandel ralsina dobey
[13:00] <nessita> Diego says:
[13:00] <nessita> DONE
[13:00] <nessita> Some corrections in the branch has been applied.
[13:00] <nessita> TODO
[13:00] <nessita> Create Tests, Modified Loading animation with the new specification,
[13:00] <nessita> polish minor ui details.
[13:00] <nessita> BLOCKED
[13:00] <nessita> no
[13:00] <ralsina> me (no notes yet)
[13:00] <dobey> me
[13:00] <rye> lalejand, any more MARK items?
[13:01] <nessita> mandel: ?
[13:01] <nessita> fagan: go
[13:01] <fagan> lets just go he can catch up
[13:01] <fagan> DONE
[13:01] <fagan> * Got some more finished but the refactoring still is taking ages.
[13:01] <fagan> TODO
[13:01] <fagan> * Finish off the branch (id say it will be done monday)
[13:01] <fagan> Blocked
[13:01] <fagan> * nope
[13:01] <fagan> NOTE: Birthday today so started work a little earlier so I could head off an hour early for errands for a party im having you all are invited but the plane journey would be a little expensive for even the best of parties :)
[13:02] <fagan> nessita: go
[13:02] <nessita> DONE: IRL reviews @ windows, meetings, tested UDF creation noticing that is not working, need to debug further. Reported lots of bugs in different projects.
[13:02] <nessita> TODO: more IRL testing, meeting with design team
[13:02] <nessita> BLOCKED: nopes
[13:02] <nessita> NEXT: thisfred
[13:02] <thisfred> DONE: Bug #762722 Bug #806668 Bug #806500 TODO: Bug #762722 BLOCKED: No NEXT: alecu
[13:02] <ubot4> Launchpad bug 762722 in ubuntuone-control-panel (and 1 other project) "Opening the Control Panel during sync removes progress indicator (affects: 1) (heat: 9)" [High,In progress] https://launchpad.net/bugs/762722
[13:02] <ubot4> Launchpad bug 806668 in ubuntuone-client "Tests inheriting from DBusTwistedTestCase must yield setUp when calling super() (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/806668
[13:02] <ubot4> Launchpad bug 806500 in ubuntuone-client "logging in status/aggregator.py is broken (affects: 1) (heat: 6)" [Low,Fix committed] https://launchpad.net/bugs/806500
[13:02] <alecu> DONE: started a branch for TCP activation for SSO and SD; will take care of inhibiting multiple activations as well; objectives; some reviews
[13:02] <alecu> TODO: keep working on activation
[13:02] <alecu> BLOCKED: no
[13:02] <alecu> NEXT: ralsina
[13:02] <ralsina> DONE: windows call, call with beuno about embedding pages in u1cp and wizard, bug #805405 started working on bundles, objectives with nessita, alecu
[13:02] <ralsina> TODO: push with bundles, merge two branches I have pending on installer, calls, approve objectives.
[13:02] <ubot4> Launchpad bug 805405 in ubuntu-sso-client "In the Qt UI, errors are shown as dictionaries in popups. (affects: 1) (heat: 46)" [Undecided,Fix committed] https://launchpad.net/bugs/805405
[13:02] <ralsina> BLOCKED: no
[13:02] <ralsina> next: dobey
[13:02] <dobey> λ DONE: triage, discussion on #806163
[13:02] <dobey> λ TODO: start the shiv^Hm?, more fixes/triage/etc
[13:02] <dobey> λ BLCK: None.
[13:03] <dobey> mandel: donde es?
[13:03] <nessita> any comments anyone?
[13:03] <alecu> I've got two turn tables and a microphone!
[13:03] <nessita> alecu: yey!
[13:03] <fagan> alecu: nice
[13:03] <nessita> fagan: happy birthday
[13:03] <thisfred> alecu: w00t!
[13:03] <mandel> me
[13:03] <fagan> nessita: thanks
[13:03] <mandel> sorry
[13:04] <nessita> mandel: go!
[13:04] <mandel> DONE: Looked and the branches that need fixing. Though about how to deal with unicode and byte path representations so that sd deal with byte but we use unicode when dealing with the Windows fs. Implemented most of it in os_helper
[13:04] <mandel> TODO: Fix test in branch refarding open_file. Finish implementation of previously mentioned solution.
[13:04] <mandel> BLOCKED: no, should have unicode, byte support this afternoon
[13:04] <alecu> thisfred, nessita, fagan: sorry, bad joke. It was a reply to "donde es?"
[13:04] <thisfred> I thought I heard a beck quote in there :)
[13:04] <fagan> alecu: :D
[13:04] <nessita> Chipaca: can you meet a las y media?
[13:04] <Chipaca> Neoti: yes
[13:04] <nessita> lol
[13:04] <Chipaca> Neoti: o hi.
[13:04] <Chipaca> nessita: yes
[13:05] <nessita> mandel, Chipaca, ralsina, alecu: meeting in 25 minutes (as scheduled on the calendar, I re-added the event so we don't need to sync the time every day :-))
[13:05] <ralsina> nessita: ack
[13:05] <alecu> ack
[13:06] <nessita> ralsina: so, I got no ack from the deisgn crowd, did you?
[13:06] <ralsina> no
[13:06] <thisfred> alecu: at least it wasn't: "Get crazy with the Cheese Wizz"
[13:06] <nessita> pinging people will not work, they may be having lunch I guess
[13:06] <nessita> ok, mate time before mumble!
[13:06] <mandel> nessita: ok, I'm going for lunch now then
[13:06] <nessita> mandel: ejoy!
[13:06] <nessita> n*
[13:06] <lalejand> rye : "lalejand, any more MARK items?" --> didn't move since a long time
[13:07] <mandel> thx
[13:07] <rye> lalejand, could you please ctrl+c that command and then run again
[13:07] <lalejand> rye : I just deleted almost all the new files (it was cache files for some packaging operations I'm doing)
[13:10] <ralsina> nessita: pushed with separate tests for side_widget
[13:10] <lalejand> rye : for the moment it returns nothing
[13:12] <rye> lalejand, the log files are being rotated and so they disappear. could you please retry with "tail --follow=name  ~/.cache/ubuntuone/log/syncdaemon.log | grep MARK
[13:22] <lalejand> rye : nothing neither for the moment
[13:22] <alecu> nessita, ping. Again: what's the convention for the message in assertTrue?
[13:23] <alecu> nessita, the message should say what should happen? or what was the error?
[13:23] <nessita> alecu: "This condition must hold"
[13:23] <alecu> ack
[13:23] <alecu> nessita, thanks!
[13:23] <nessita> alecu: :-)
[13:23] <ralsina> nessita: pushed the "are you sure" branch with translator-friendly strings
[13:24] <nessita> ralsina: great! what about the tests for the are_you_sure dialog?
[13:24] <dobey> nessita: did diego fix all the issues you had in his branch?
[13:24] <alecu> nessita, so the message rather than "the connection is dropped" should read "the connection must be dropped" instead. The "must" makes it clearer, right?
[13:24] <nessita> dobey: not all, he will finish today, he's taking an exam now
[13:24] <dobey> ah ok
[13:25] <nessita> ralsina: usually we define all the constants to be translated on a separated file, and import and use that from the code and from the tests. That approach has the advantage of gathering all string in one place, and ease re-use and testing
[13:25]  * ralsina reads backlog to figure out what tests he missed on "are you sure"
[13:25] <nessita> alecu: exactly
[13:25] <nessita> ralsina: is on the MP
[13:25] <alecu> great
[13:26] <ralsina> nessita: adding the tests now.
[13:26] <lalejand> rye : still nothing
[13:26] <nessita> alecu: so, if the assertion blows up, you get: AssertionError: the connection must be dropped <- since is an assertion-error, the assertion (which uses must) is not holding
[13:27] <nessita> the water is about to boil!!!!
[13:30] <ralsina> nessita: please file a bug for moving the strings to a separate file, it's not in the scope of this branch
[13:30] <nessita> ralsina: yeah, I was saying for the new string, since you need to re use it for building the tests
[13:31] <rye> lalejand, and u1sdtool --waiting errors out, right?
[13:31] <ralsina> nessita: makes sense, will do it for the "are you sure" strings at least
[13:31] <nessita> thanks
[13:32] <nessita> ralsina, mandel, alecu, Chipaca, mumble?
[13:33] <alecu> nessita, I'm coming
[13:34] <nessita> mandel: ping
[13:35] <lalejand> rye : yes. Error
[13:37] <mandel> Neoti: sorry, I'm back
[13:37] <nessita> mandel: mumble!
[13:38] <mandel> nessita: booting
[13:38] <mandel> I mean luanching
[13:59] <lalejand> rye : I'm going to stop and restart u1, hoping that it will be ok. My PC is to slow
[14:15] <dobey> oh, i need to take a couple days off
[14:17] <nessita> dobey: we all do! :-)
[14:18] <dobey> well, need to take several days off at some point too. :P
[14:20] <nessita> ralsina: ping
[14:20] <ralsina> nessita: pong
[14:20] <nessita> ralsina: any reason why the images are not in the installer? I'm referring to U1logo, and the icons for each "step" in the left
[14:21] <ralsina> nessita: I was expecting Diego to add those after he was finished with the u1cp
[14:21] <nessita> ralsina: ok, is that added programatically or with css?
[14:21] <dobey> ugh @ duplicating locations of things
[14:22] <ralsina> nessita: mostly CSS
[14:22] <ralsina> or designer in some cases
[14:22] <ralsina> but I don't think he will have to touch code anywhere
[14:22] <nessita> ralsina: ok, fair enough. Can you please file a bug to add those images? And assign to him :-)
[14:22] <ralsina> nessita: cool, on it
[14:23] <ralsina> nessita: BTW, both branches should be up to testing standards now ;-)
[14:23] <nessita> ralsina: great, I'm already IRL testing the side_widget now
[14:38] <ralsina> There is no bug for the bundles, is there?
[14:45] <nessita> ralsina: nopes, can you make some please?
[14:47] <nessita> ralsina: ah, I forgot to ask, any feedback on my goals?
[14:48] <ralsina> nessita: +1 on them from me
[14:48] <ralsina> So load them up and I will approve them
[14:48] <nessita> ack
[14:51] <dobey> hmm
[14:52] <ralsina> dobey: yours too
[14:52]  * ralsina wants to minimize cntext switches ;-)
[14:54]  * fagan EOD/EOW
[14:54] <fagan> see you guys monday
[14:54] <fagan> gtg go party
[14:56] <dobey> ralsina: i already put mine in allhands last week :)
[14:56] <ralsina> dobey: I meant that I will approve them
[14:57] <dobey> ok
[15:04] <DiegoSarmentero> ralsina, nessita hi! I'm back... I will finish the ui for ubuntuone-control-panel today, make the tests and propose a new merge
[15:04] <ralsina> DiegoSarmentero: cool
[15:04] <nessita> DiegoSarmentero: hey there! how did the exam go?
[15:05] <DiegoSarmentero> nessita, 9 :D
[15:05] <nessita> DiegoSarmentero: groso! what subject?
[15:05] <DiegoSarmentero> nessita, Tecnologia de Software de Base
[15:05] <DiegoSarmentero> nessita, java... *escalofrios*
[15:05] <DiegoSarmentero> jejej
[15:05] <nessita> AAAAAHHHHH
[15:05] <nessita> DiegoSarmentero: did you shower after that? :-P
[15:05] <DiegoSarmentero> nessita, not yet jeje
[15:06] <ralsina> nessita: we all n mumble now!
[15:17] <dobey> DiegoSarmentero: you can just fix in the existing merge, you don't need to propose it again, btw
[15:17] <dobey> unless you are making massive other changes, anyway
[15:18] <DiegoSarmentero> dobey, ah ok.... yes, i was planning to use the same that i've created
[15:21] <dobey> ok, i'm off to get some lunch. bbiab
[15:38] <facundobatista> generic question: how do I share a folder using nautilus? I chosen "Ubuntu One" -> "Compartir", but then I get a dialog that tells me to search something (I don't know what), it always says "found 0" nomatter what I search, and don't know how to continue
[16:06]  * mandel walking dog
[16:08] <facundobatista> ralsina, a friend of mine has the issue described in #576408
[16:08] <facundobatista> ralsina, is it really "in progress"?
[16:08] <ralsina> bug #576408
[16:08] <ubot4> Launchpad bug 576408 in ubuntuone-client ""Share on Ubuntu One" and "Stop synchronizing on Ubuntu One" menu items disabled (affects: 10) (heat: 44)" [High,In progress] https://launchpad.net/bugs/576408
[16:09] <ralsina> facundobatista: I have half-a-branch on it
[16:09] <ralsina> facundobatista: then got sidetracked for a few months
[16:10] <ralsina> facundobatista: but the honest answer is "no"
[16:13] <dobey> facundobatista: hrmm, have we always allowed sharing from a UDF?
[16:19] <dobey> hrmm, i guess so
[16:20] <dobey> oh i see what's wrong
[16:28] <dobey> facundobatista: does your friend have the UDF that folder is in, subscribed, on the machine where this bug is happening?
[16:32] <ralsina> nessita: remember the 3PM thing for the bundles? Reschedule it for 6PM because I have to have lunch and have not advanced much.
[16:32] <nessita> ralsina: ack.
[16:32] <nessita> LUNCH!
[16:32] <nessita> :-)
[16:38] <alecu> facundobatista, in the dialog that tells you to search for something, the list of contacts from evolution-data-server are shown.
[16:38] <alecu> facundobatista, you can just enter an email address, and it will be used and added to e-d-s.
[16:53] <facundobatista> dobey, asking him right now
[16:54] <facundobatista> alecu, I don't use evolution
[16:54] <alecu> facundobatista, Me neither! You can just enter an email address.
[16:55] <facundobatista> alecu, where? in the search field?
[16:56] <alecu> right
[16:57] <dobey> yeah, the contact picker UI sucks. and i think one of the requirements for TB being default in Oneiric, was integrating with EDS
[16:57]  * dobey wonders why anyone is still running maverick anyway :)
[16:58] <facundobatista> alecu, oh, "magically" appears one button that wasn't there before
[16:59] <alecu> facundobatista, yeah, it's awful. And I've been doing some tests connecting e-d-s with canonical's ldap, and now that dialog is painfully slow.
[17:00] <lalejand> Hi, U1 began to upload some large files. I deleted them, but U1 indicator still shows that U1 is uploading those files
[17:00] <alecu> I'll open a bug for that.
[17:00] <lalejand> alecu : which package ?
[17:01] <alecu> lalejand, sorry, was talking about a different issue.
[17:01] <dobey> lalejand: i think he's talking about something else
[17:02] <dobey> lalejand: if you want to open a bug against u1 indicator, i think you need to file against one-indicator
[17:04] <alecu> facundobatista, bug #807111. Perhaps you want to open a bug for the "magical" button.
[17:04] <ubot4> Launchpad bug 807111 in ubuntuone-client "The share contact picker is slow for 400 contacts (affects: 1) (heat: 6)" [Medium,Confirmed] https://launchpad.net/bugs/807111
[17:04] <nessita> mandel: ping
[17:05] <lalejand> dobey : I don't know if it is u1-indicator's fault or not
[17:06] <mandel> nessita: pong?
[17:07] <dobey> lalejand: no, but filing a bug against the thing where you see the problem is a good start. if it's not the indicator applet's fault, then the bug can be moved. it's more about documenting it, than solving it
[17:07] <nessita> mandel: how are branches going? (I'm catching up since you said 2 hours after the meeting)
[17:08] <mandel> nessita: changes have been done but I have a failing test in test_vm due to having no access rights for some strange reason, I'm debugging right now
[17:09] <nessita> mandel: that is for the unicode branch, right? any news on the in-review branch?
[17:09] <mandel> nessita: I'm stuck with the unicode one, is more important since it should fix lots of issues
[17:10] <lalejand> dobey : okay
[17:16] <Chipaca> nessita: ping-u
[17:21] <nessita> Chipaca: pong
[17:21] <Chipaca> nessita: mumble plz?
[17:21] <nessita> Chipaca: I'm about to have lunch (nuddles almost ready). Is it talkable in less than 3 min? :-)
[17:22] <Chipaca> nessita: have lunch. try noodles instead nuddles next time.
[17:22] <nessita> Chipaca: :-)
[17:22]  * nessita -> lunch, brb
[17:24] <ralsina> http://www.nuddleblanket.com/Celebs.html
[17:31] <ralsina> LUNCH!
[17:42] <nessita> Chipaca: I'm back, logging in...
[17:44] <nessita> Chipaca: ready when you are
[17:45] <Chipaca> nessita: ok, let's do this
[17:45] <nessita> let's!
[17:57] <dobey> https://code.launchpad.net/~dobey/ubuntuone-client/no-pycentral/+merge/67231
[17:57] <dobey> pretty trivial review if anyone wants to do it :)
[17:59] <Chipaca> ralsina: when you return, mumble plz
[18:01] <ralsina> chipaca, now is ok?
[18:01] <Chipaca> ralsina: depends, are you still chewing?
[18:01] <ralsina> Chipaca: no, just having coffee
[18:02] <ralsina> So don't worry!
[18:02] <nessita> ralsina: when you finish your mumbling and chewing, I have a question/suggestion re: bandwith settings
[18:02] <ralsina> nessita: ok!
[18:02] <facundobatista> alecu, ping
[18:02] <alecu> facundobatista, pong
[18:03] <facundobatista> alecu, maybe you saw something like this when setting up your windoze vm?
[18:03] <facundobatista> pywintypes.error: (1332, 'LookupAccountName', 'No se ha efectuado ninguna asignaci\xf3n entre los nombres de cuenta y los identificadores de seguridad.')
[18:03] <alecu> facundobatista, while running the tests?
[18:03] <facundobatista> alecu, I get that when starting ubuntuone-client, mandel has no idea of what could be happening
[18:04] <mandel> alecu: first time I see it, sounds like chinese too me… or an exchange thing, but I have no idea
[18:04] <alecu> mandel, isn't that related to the pywin32 module you've recompiled?
[18:05] <ralsina> nessita: finished chewing and mumbling
[18:05] <alecu> facundobatista, I have no further idea than the pywin32 module that mandel fixed.
[18:05] <ralsina> dobey: checking!
[18:05] <nessita> ralsina: that was fast :-)
[18:06] <ralsina> nessita: yes it was!
[18:06] <ralsina> Or "that's what she said" to preempt dobey & mandel
[18:06] <nessita> ralsina: so, I was looking at the installer wireframes (https://docs.google.com/a/canonical.com/drawings/d/10Io1nRr0mGr_EW5mHTKErS6s2oxVnF7uCDdIzuqYB50/edit?hl=en_US), in particular wireframe 19
[18:07] <dobey> heh
[18:07] <ralsina> nessita: give me 1' to reach the right thingy
[18:07] <ralsina> 19, yes!
[18:07] <nessita> ralsina: if we could agree with design crowd to change the button "Check bandwidth settings" to "Check file sync settings", and show as frame 19 the same screen as the Preferences tab (from https://docs.google.com/a/canonical.com/drawings/d/1O_Q9EIJNbvnimroBTvoxvpFXuawEp8pA01iyfW-lHn4/edit?hl=en_US), we could save A  LOT of work
[18:08] <nessita> ralsina: otherwise, separating the BW settings gets hairy due to the "restore default settings" and "apply" buttons
[18:08] <nessita> ralsina: you think proposing that is a good idea?
[18:08] <ralsina> nessita: I can always override the text on the wizard, if needed
[18:08] <nessita> ralsina: override what?
[18:08] <ralsina> Because in this case, "bandwidth" makes more sense (to me at least)
[18:08] <mandel1> dobey: I think we are doing quite well when the n-1 ihas started with the jokes too :)
[18:09] <nessita> ralsina: not sure if you understood my proposal (given that comment)
[18:09] <dobey> :)
[18:09] <ralsina> nessita: wait a sec, haven't checked the other wireframe you mentioned, o I may nort make sense right now
[18:09] <nessita> right :-)
[18:09] <ralsina> I am "the n-1"?
[18:10] <ralsina> nessita: I get it now. With the extra options, it makes sense to keep the text
[18:10]  * ralsina of course, has a perfectly hackish solution for this problem that would work perfectly
[18:10] <nessita> ralsina: to keep or to change the text? (I'm proposing changing the text)
[18:10] <ralsina> keep control panel's, change the wizard's
[18:11] <nessita> ralsina: wait, I still think you are not following me :-)
[18:11] <ralsina> You want to replace wireframe 19 with your perferences tab widget
[18:11] <nessita> ralsina: well, we embed the preferences tab into that step
[18:11] <ralsina> And the button in 18 with another text
[18:12] <nessita> ralsina: right, so no change of text needed in the control panel
[18:12] <nessita> ralsina: and within 18, you remove the checkbox under folders
[18:12] <nessita> since we provide that in 19
[18:12]  * mandel1 has to go to the roof.. dont ask
[18:12] <ralsina> I am ok with both changes. If, however, design says it's not good because it's too geeky or whatever, there is another way to do it, which is "use the widget from u1cp, and hide the parts you don't want visible "
[18:13]  * ralsina ducks
[18:13] <nessita> ralsina: that can work, yes, but each you click on Apply, the whole settings will be changed (hidden and not hidden)
[18:14] <nessita> ralsina: so I will strongly discourage that
[18:14] <ralsina> but the hidden settings will not change anything, since they will contain the value from the config file anyway?
[18:14] <ralsina> But I only propose that as a last resource if we can't make the change
[18:14] <nessita> ralsina: it depends, are you offering to change settings somewhere else? like in frame 18?
[18:14] <nessita> if so, we have a mismatch there
[18:14] <ralsina> nessita: good question
[18:14] <mandel1> facundobatista: ping
[18:15] <ralsina> I agree that the setting in page 18 should move to 19 and the button's wording change
[18:15] <ralsina> *at least*
[18:15] <mandel1> verterok: ping
[18:15] <facundobatista> mandel1, pong
[18:15] <ralsina> And I don't think design is going to have problems with that
[18:15] <nessita> ralsina: great. Can you please email/talk this with design people? (they already left, I think)
[18:15] <mandel1> facundobatista: one question, the share.path is that unicode or byte?
[18:15] <ralsina> afk, brb
[18:16] <nessita> ralsina: or better, can you implement it that way (is very easy) and see what they say by looking at that?>
[18:17] <facundobatista> mandel1, it should be bytes, IIRC (verterok?)
[18:17] <mandel> facundobatista: also, udf.ancestors, are those meant to be using local paths, look at test_udf_ancestors in test_vm (line 1333)
[18:17] <facundobatista> mandel, stop being schyzofrenic
[18:17] <mandel> facundobatista: the expected result uses / is that correct for windows too?
[18:18] <mandel> facundobatista: ein?
[18:18] <facundobatista> mandel / mandel1 :)
[18:18] <mandel> facundobatista: yes, stupid irc client seems to have a bad day...
[18:19] <facundobatista> mandel, the expert in that area is verterok, but I think that udf.ancestors is all local path, so we really should be using os.path.sep, no '/'
[18:19] <mandel> facundobatista: I though so too.. verterok is that correct?
[18:19] <mandel> I know suggested path is correct and should be using /
[18:20] <ralsina> nessita: you mean maybe they won't otice? ;-)
[18:20] <ralsina> s/otice/notice/
[18:20] <nessita> no! :-)
[18:20] <nessita> I meant they may like better by looking at it
[18:20] <nessita> not by trying to imagine it
[18:20] <ralsina> agreed. Since it's much MUCH easier, we can hack if it is not good enough
[18:21] <ralsina> In fact, I think that page is meaningless as part of the first setup, but hey, what do I know
[18:21] <facundobatista> mandel, he was having lunch
[18:21] <mandel> facundobatista:  np :)
[18:22] <mandel> facundobatista: so, share.path is that byte of unicode, I was let down my irc just a second after I asked you the question...
[18:25] <nessita> alecu: ping
[18:26] <nessita> alecu: does this ring any bell? bug #807146 (I've assigned it to you for now, we'll see later who has an empty slot to work on that)
[18:26] <ubot4> Launchpad bug 807146 in ubuntu-sso-client "Windows: twisted.spread.pb.DeadReferenceError: Calling Stale Broker (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/807146
[18:26] <alecu> nessita, pong. looking
[18:26] <alecu> nessita, yes, it rings
[18:27] <nessita> alecu: is that already reported?
[18:27] <alecu> nessita, I think that happens when a client disconnects and the server still wants to call the signals.
[18:27] <alecu> nessita, I think it's reported, yes, but let me check.
[18:27] <nessita> makes sense, given what I described happened
[18:28] <ralsina> nessita: I get that all the time with SSO, it answers only one cnnection
[18:28] <nessita> ralsina: you reported it somewhere? (is not good, it should answer to several)
[18:29] <ralsina> nessita: no, because I thought it was related to the reactor problems we were having and later I forgot
[18:29] <nessita> ok
[18:31] <mandel> verterok: ping
[18:31] <mandel> facundobatista: ping
[18:31]  * mandel hates his irc client...
[18:31] <alecu> nessita, I'm not sure again if it's the same bug, but it happens under similar conditions: bug #806539
[18:31] <ralsina> what version of ubuntu-client are we to be shipping on windows?
[18:31] <ubot4> Launchpad bug 806539 in ubuntuone-client (and 1 other project) "Cleanup API to connect to services (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/806539
[18:31] <ralsina> ubuntuone-client that is
[18:31] <alecu> nessita, for now let's keep this as two separated bugs.
[18:32] <nessita> alecu: right, the error does not look the same, so yes
[18:34] <nessita> alecu: FYI, the last report is 100% reproducible (at least here(
[18:34] <nessita> ))
[18:35] <alecu> great
[18:36] <nessita> ralsina: still reviewing your side-widget branch. Question: right after I logged in, the installer skipped the "Choose services" section marked in the left5
[18:36] <nessita> and went thru directly to Select sync folders
[18:37] <nessita> ralsina: also, the "add folder" does nothing, is that correct?
[18:37] <alecu> nessita, ralsina: can I get reviews on this first branch of tcp activation? https://code.launchpad.net/~alecu/ubuntu-sso-client/tcp-activation/+merge/67240
[18:37] <ralsina> Choose services is the one where we will embed the browser
[18:37] <alecu> this branch has all of the functionality; in a coming branch I'll make sso use it.
[18:37] <ralsina> And "add folder" is waiting for the branch that embeds the actual u1cp widgets
[18:37] <alecu> but first, lunch.
[18:37] <ralsina> branch which I should finish now that u1cp can talk to syncdaemon :-)
[18:38] <nessita> ralsina: ok, so I'm lost :-D both "issues" are expected and "normal"?
[18:38] <ralsina> As of that branch ,yes, expected and normal
[18:41] <nessita> ralsina: and the folders tab is also outdated, in that branch, right?
[18:42] <ralsina> nessita: yes
[18:42] <ralsina> Damn distiutils-extra doesn't work if your setup.py is not called "setup.py"!!!!
[18:42] <nessita> what?
[18:43] <ralsina> nessita: http://pastebin.ubuntu.com/639665/
[18:43] <ralsina> I will just do it without distutils-extra
[18:47] <nessita> ralsina: in the tests for the sidewidget branch, in all the test_stage_progression_X, I'm not why you have all the assertion over the state of self.ui.sideWidget(). From my POV, all the test_stage_progression_X shoul assert only over the sideWidget.stage value, and the rest is ensure by the sideWidget API and functionality
[18:48] <nessita> otehrwise you're duplicating assertions that, if we sightly change what the sidewidget does, we need to modify them all
[18:48] <ralsina> nessita: because those were done first, before the other ones. I can remove that, no problem.
[18:49] <nessita> ralsina: thanks! it will make that code much easier to read and understand (and maintain)
[18:49] <ralsina> nessita: ok, changing and pushing
[18:49] <facundobatista> mandel, pong
[18:49] <facundobatista> mandel, which irc client is yours?
[18:51] <verterok> mandel: pong
[18:53] <dobey> ralsina: were you reviewing my branch btw?
[18:53] <ralsina> dobey: sorry, got sidetracked
[18:53] <ralsina> dobey: reviewing now
[18:54] <dobey> ralsina: hrmm, why would you not call the setup.py "setup.py"?
[18:54] <ralsina> nessita: pushed without all those asserts
[18:54] <nessita> ralsina: great!
[18:54] <ralsina> dobey: because I don't want someone running it on linux
[18:54] <ralsina> so I was calling it setup-windows.py
[18:55] <dobey> if sys.platform == 'win32': setup(); else: print "GTFO."
[18:55] <dobey> :)
[18:56] <dobey> ralsina: hrmm, that's in ubuntuone-client? :(
[18:56] <ralsina> dobey: yes
[18:56] <ralsina> dobey: it's basically to build the exe
[18:57] <czajkowski> mandel: how do
[18:57] <dobey> ralsina: yeah, i know. but still. :(
[18:57] <dobey> trying to think of a solution that makes sense, but alas
[19:02] <nessita> ralsina: the branch looks great. Is pretty much approved, I just listed some lint and pep8 issues
[19:02] <ralsina> nessita: I will try to get pep8 0.5 in windows because I got no pep8 issues here, again :-(
[19:02] <nessita> ralsina: yeah, I imagine. I ran it in linux though
[19:03] <ralsina> nessita: ok, will fix them soonish
[19:03] <dobey> nessita, ralsina: i wonder what the acceptable requirements are for building u1client stuff on windows.
[19:03] <ralsina> dobey: don't understand the question
[19:03] <nessita> dobey: not sure what you mean. The acceptable requirements would be that "it builds and installs" :-)
[19:05] <dobey> ralsina, nessita: i mean as far as fixing the build system issue. there are some things there which i think we still need to do on windows, but which aren't so easily doable from bzr checkout, but aren't an issue when installing from tarball, for example
[19:05] <ralsina> dobey: such as?
[19:05] <nessita> DiegoSarmentero: ping
[19:06] <dobey> ralsina: PNG icon generation from the SVG
[19:07] <ralsina> dobey: how's that converted now?
[19:07] <mandel> verterok: ping again, sorry I missed the pong
[19:07] <dobey> ralsina: running inkscape during 'make' to generate the icons inside the build tree
[19:07] <mandel> facundobatista: ping again..
[19:07] <verterok> mandel: hi
[19:07] <mandel> czajkowski: how do?
[19:07] <facundobatista> mandel, pong
[19:08] <facundobatista> mandel, which irc client is yours?
[19:08] <ralsina> dobey: we are making inkscape a build dependency? Whoa.
[19:08] <mandel> verterok: question, the ancestors from udf, do the use local paths (that is os.path.sep) or do they always use /
[19:08] <mandel> facundobatista: adium… terrible client
[19:08] <dobey> ralsina: it has been for a long time
[19:08] <ralsina> still
[19:09] <dobey> ralsina: well, to build from trunk, not from tarballs
[19:09] <verterok> mandel: I think the ancestors are calculated from the local path
[19:09] <mandel> facundobatista: share.path is that meant to be unicode?
[19:09] <mandel> verterok: ok, so in the test_ancestors in test_vm we should be using os.path.sep, right?
[19:10] <verterok> mandel: no idea, need to look at the code :)
[19:10] <mandel> verterok: hehe, want the file and line number?
[19:10] <verterok> mandel: no need to, gimme a few minutes to wrap what I'm doing
[19:11] <mandel> verterok: gracias!
[19:14] <nessita> ralsina: a couple of extra needs fixing in the areyousure branch, after code review
[19:14] <ralsina> nessita: ok
[19:15] <nessita> ralsina: also, maybe you forgot to add the test_are_you_sure file? I don't see it
[19:16] <ralsina> nessita: turns out I did forget it. Pushed it.
[19:16] <nessita> great
[19:23] <verterok> mandel: the path should be the "native" path, as it's used during local rescan to add pyinotify watches to the udf ancestors
[19:23] <mandel> verterok: ok, so I fixed the test :)
[19:24] <mandel> looks like this branch is looking good :)
[19:24]  * mandel dinner, will be back later
[19:24] <nessita> ralsina: SyntaxError: invalid syntax (test_are_you_sure.py: 38)
[19:25] <verterok> mandel: and probably you need to check the ancestors property in volume_manager.py @ line 316
[19:25] <ralsina> nessita: uh? Let me check
[19:26] <dobey> ok, gotta run to an appt. be back in a few
[19:26] <nessita> ralsina: also, when running that branch and clicking on "Yes I want to cancel", I get an error in the terminal saying "QWaitCondition: Destroyed while threads are still waiting"
[19:26] <ralsina> nessita: so sorry, seems I had not actually finished that branch before I started eith the phone calls
[19:27] <nessita> ralsina: is ok, let me know when is done :-)
[19:28] <ralsina> nessita: pushed with the fix and tests pass now
[19:28] <ralsina> nessita: but let's try again that branch tomorrow ;-)
[19:30] <nessita> ralsina: not sure what that means :-)
[19:30] <ralsina> nessita: that I dn't want to waste your time before double-checking the branch again
[19:30] <nessita> ralsina: I'm trying to have a screenshot of the latest installer since DiegoSarmentero will start working on that tomorrow
[19:31] <ralsina> the changes should not affect screenshots :-)
[19:31] <nessita> ralsina: well, having the latest may be better, specially the side widget
[19:31] <nessita> but yes, is not mandatory
[19:32] <ralsina> nessita: ok, pushed , passes pep8, pylint, pyflakes and tests ;-)
[19:32] <nessita> DiegoSarmentero: https://wiki.ubuntu.com/UbuntuOne/Contribute/WindowsTesting <- a new section for the installer was added, running it is extremely similar to running the control panel
[19:32] <nessita> ralsina: is that for side widget or are you sure? :-D
[19:32] <ralsina> no, the areyousure
[19:32] <nessita> ralsina: are you sure? :-P
[19:32] <nessita> ack
[19:33] <ralsina> I'll fix the sidewidget one now so diego can have that one, which is more important
[19:33] <nessita> ralsina: ack
[19:33] <DiegoSarmentero> ralsina, ack
[19:34] <nessita> ralsina: is tarmac landing your installer branches?
[19:36] <nessita> ralsina: in the are you sure branch... did you apply the latest needs fixing from https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_805290/+merge/66739/comments/145569 ? (I don't have them)
[19:40] <ralsina> nessita: had not seen them. Will fix and push. The problem with using clientdefs is that I basically import all of control panel to get a string, because of how the package is organized. But I'll do it anyway.
[19:44] <nessita> ralsina: all the control panel? wow, why?
[19:44] <nessita> (clientdefs is inside client)
[19:44] <ralsina> nessita: because it imports the ubuntuone namespace, which imports controlpanel, sso, client and whatever else is in there because it has no __ALL__
[19:45] <nessita> ralsina: I see. Anyway, installer already depend on control panel, right?
[19:45] <ralsina> nessita: yes, which is why I did it anyway ;-)
[19:45] <nessita> :-)
[19:50] <ralsina> nessita: fixed the needs_fixing in https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_805290/+merge/66739/
[19:50] <ralsina> moving onto the other one
[19:50] <nessita> ack
[19:55] <ralsina> nessita: you are using pylint? We moved to pyflakes for this one
[19:55] <nessita> ralsina: why?
[19:55] <ralsina> dobey suggested it
[19:55] <nessita> ralsina: errors from pylint makes sense here
[19:55] <ralsina> pylint ignores don't work on windows
[19:55] <nessita> I mean, those errors are not false positives
[19:55] <ralsina> which means I have to re-check all the sources in another OS
[19:55] <ralsina> but ok, I can do it
[19:56] <nessita> ralsina: well, checking the sources in all platform is a requirement for all of us
[19:56] <nessita> anyways, I wasn't aware pylint ignores the ignore
[19:56] <ralsina> the style checks should not be platform dependent?
[19:56] <nessita> should not be
[19:57] <nessita> ralsina: running the tests in all paltform is the requirement, I mean. But if the ignore switch is not working, I see the problem there
[19:57] <ralsina> exactly. pylint gives about 1200 lines of output on windows
[19:58] <ralsina> complaining about gtk, dbus, how QWidget is not a valid parent class, how all tests are using super in old style classes and all sorts of wacky stuff
[19:59] <nessita> ralsina: pylint --help does not list the ignore swicth :-/
[19:59] <ralsina> it's on the pylintrc
[19:59] <nessita> so seems like is not implemented, at least in the version I'm suing
[19:59] <nessita> using*
[20:00] <nessita> ralsina: what is in the pylintrc?
[20:00] <ralsina> which is, of course, undocumented everywhere
[20:00] <ralsina> the ignore option
[20:01] <nessita> ralsina: right, but the pylint --help do not list that as a valid option, so seems like is not implemented in w :-/
[20:01] <ralsina> it's not implemented as an option in the CLI, only from the pylintrc config file
[20:01] <ralsina> in Linux, too
[20:02] <nessita> ralsina: I beg to differ, you can use pylint --ignore=something, that is what we use in the control panel
[20:03] <ralsina> nessita: did you try pylint --help on linux?
[20:03] <nessita> yes
[20:03] <nessita>     --ignore=<file>     Add <file or directory> to the black list. It should
[20:03] <nessita>                         be a base name, not a path. You may set this option
[20:03] <nessita>                         multiple times. [current: CVS]
[20:04] <ralsina> the help in windows says exactly the same thing: http://pastebin.ubuntu.com/639703/
[20:05] <ralsina> Except it didn't work when I tried it, and that's why I talked with dobey and switched to pyflakes
[20:05] <ralsina> or rather, added USE_PYFLAKES for u1lint
[20:05] <nessita> ralsina: and it seems to work on windows: I just ran pylint --ignore="ui,reactor" ubuntuone_installer and I got only failures/errors for the rest of the project
[20:05] <ralsina> (maybe it was a u1lint bug, not a pylint one)
[20:05] <nessita> ralsina: maybe you're mixing u1lint with pylint?
[20:07] <nessita> right
[20:07] <nessita> ralsina: ok, we can leave using pylint and fixing the errors in another branch
[20:07] <ralsina> nessita: this is what I get running pylint directly, with --ignore="ui,reactor"
[20:07] <ralsina> http://pastebin.ubuntu.com/639705/
[20:07] <alecu> BTW: if anybody wants review a nice branch... https://code.launchpad.net/~alecu/ubuntu-sso-client/tcp-activation/+merge/67240
[20:07] <nessita> alecu: right, sorry, I'll do it
[20:08] <alecu> nessita, thanks!
[20:08] <ralsina> nessita: I think you'll agree it's not a very useful output :-)
[20:09] <nessita> ralsina: is very useful right below the PyQT4 import, and we alrady fixed that (we need to import QtCore before QTGui or something similar)
[20:09] <nessita> I mean, a lot of errors there make sense, o no?
[20:10] <ralsina> nessita: from line 60 until 265 they don't
[20:10] <ralsina> actually from 60 until the end
[20:10] <nessita> ralsina: I'm not sure why you have that, look at my output http://pastebin.ubuntu.com/639707/
[20:11] <nessita> maybe some installation is a bit busted?
[20:11] <ralsina> nessita: well, that's the problem, how do I figure that out? Should I fight pylint for a couple of hours?
[20:11] <nessita> anyways, that can be done later. Can you at least fix the unused variables I reported?
[20:12] <nessita> W0612: 57:CalculateSize.run: Unused variable 'dirnames'
[20:12] <nessita> W0612:149:LocalFoldersPage.stop_threads: Unused variable 'path'
[20:12] <nessita> and all the missing docstrings
[20:12] <ralsina> I added all the missing docstrings. What's a variable name I can use that doesn't give that warning besides _?
[20:13] <nessita> ralsina: to not using it? no other... are those unused variables, needed?
[20:13] <ralsina> for example, when you use listdir() it returns tuples.
[20:13] <ralsina> I am doing for dirpath, dirname, filenames in os.walk(self.path_name):
[20:14] <nessita> right, so you can use _ there
[20:14] <nessita> for _ , _, filenames in ...:
[20:14] <ralsina> but then it complains I am overriding _ from the outer scope, which I can probably fix by moving strings to another file.
[20:15] <nessita> right, which is even better! :-D (so we have all the to-translate-variables together)
[20:22] <ralsina>  Invalid name "bad" .... pylint I hate you ;-)
[20:25] <alecu> guys and gals: got to run to kinder. See you laters.
[20:34] <ralsina> nessita: pushed sidewidget with the style fixes, pylint seems clean to me now, but I may be missing something in the noise
[20:35] <nessita> ralsina: great
[20:36] <dobey> nessita: because pylint is a royal PIA, and I'd like us to switch everything over to pyflakes if possible
[20:37] <ralsina> dobey: OTOH pyflakes doesn't detect some real problems (like missing docstrings)
[20:37] <dobey> ralsina: missing docstrings isn't a functional one, but a style issue.
[20:37] <ralsina> dobey: yes, but we were using pylint for style checks
[20:38] <ralsina> (too)
[20:38] <dobey> well we were using pylint because it's what we started with 3 years ago
[20:38] <dobey> we weren't exactly using *for* style checks per se, it just also does them
[20:40] <dobey> ralsina: is the docstring thing the only additional thing here? i'd really like to get us a solution that moves us completely off of pylint, because it's a pain
[20:41] <ralsina> dobey: bad top-level variable names, at least
[20:41] <ralsina> I don't have a full list, as you may imagine :-)
[20:41] <dobey> ralsina: well the toplevel variable names aren't bad necessarily either. it is just a style thing we're imposing via pylint :-/
[20:42] <dobey> ralsina: also, pep8 is extensible, so we could presumably add these additional style checks to our pep8 checks
[20:42] <ralsina> dobey: yes, but consistent style in a team is a good thing. I don't have strong feelings. I was happy with pyflakes because it never complained ;-)
[20:44] <ralsina> DiegoSarmentero: in case it's not merged whe you want to start working on styling the wizard: you should really use trunk merged with https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_803929/+merge/66827
[20:44] <ralsina> so you should branch from that, and use it as a prerequisite for your (eventual) merge proposal
[20:45] <DiegoSarmentero> ralsina, ok! I will clone that repo
[20:45] <ralsina> There are two or three other branches that will affect you but that one is a big thing visible on all pages :-)
[20:48] <nessita> ralsina: let's merge those babies!
[20:48] <nessita> ralsina: I'll re-review
[20:49] <ralsina> nessita: do sidewidget, the other one is going to conflict like crazy now
[20:49] <nessita> oooohhhoook
[20:49] <ralsina> because sidewidget grew tentacles with the style fixes :-)
[20:50] <nessita> ralsina: looks great, approving!
[20:50] <ralsina> nessita: should I merge?
[20:50] <nessita> ralsina: I guess so, yes
[20:50] <nessita> I think I meeds with your head enough :-D
[20:50] <nessita> messed*
[20:50] <ralsina> hehehe
[20:51] <ralsina> My excuse is that we were not using the same stylechecks
[20:51] <ralsina> after this one merges, I should have areyousure de-conflicted quickly
[20:52] <nessita> ralsina: ping me when that's done
[20:52] <ralsina> nessita: sure
[20:53] <ralsina> where's ubuntuone.storageprotocol supposed to come from? is it generated?
[20:53]  * ralsina misses grep so much
[21:00] <nessita> ralsina: from the project ubuntuone-storage-protocol. See https://wiki.ubuntu.com/UbuntuOne/Contribute/WindowsTesting
[21:00] <nessita> ralsina: instructions are there
[21:00] <ralsina> nessita: cool, fetching
[21:05] <dobey> facundobatista: did you ever get an answer from your friend?
[21:05] <facundobatista> dobey, it was in an UDF, yes, a locally created UDF
[21:05] <facundobatista> dobey, which should be subscribed, but he didn't have access to that computer at that time to check that
[21:06] <dobey> facundobatista: ok, weird
[21:14] <ralsina> nessita: the syncdaemon bundle is close, i think.
[21:14] <nessita> ralsina: you got your setup-windows.py working? :-)
[21:14] <ralsina> nessita: it's mostly building, checking what module fails, add, retry
[21:14] <ralsina> I am having problems with storageprotocol, yet
[21:15] <nessita> ah, you need protoc
[21:15] <nessita> and the protobuf module
[21:15] <ralsina> it works, it doesn't bundle
[21:16] <ralsina> but it's probably because of zipped eggs
[21:17] <nessita> ah
[21:17] <ralsina> need to hack some more, will try to have it by tomorrow early
[21:17]  * nessita no idea
[21:17] <nessita> ralsina: good luck
[21:17] <ralsina> thx!
[21:17] <ralsina> will EOD for a little bit
[21:18] <thisfred> facundobatista: not much luck yet with bug #807005, but I'm pretty sure that the problem originated with the original upload (i.e. '2011-07-06.191137-0300ART.txt'). You did not see a notification for that one right? (I know you may have missed it, but if you did happen to see it, it will disprove my current theory)
[21:18] <ubot4> Launchpad bug 807005 in ubuntuone-client "Filename in notification does not reset. (affects: 1) (heat: 6)" [Medium,Confirmed] https://launchpad.net/bugs/807005
[21:19] <thisfred> The actual showing of the notification resets everything, so my guess is, sometimes notifications are not shown (you indicated that that happened as well) and then the state is never reset
[21:20] <thisfred> even if that is the case, no idea why that would happen yet. I'm digging through a forest of Twisted callback timeouts
[21:21] <facundobatista> thisfred, it was too early (those files are cron-moved into u1)
[21:21] <facundobatista> thisfred, also, not all notifications go to a bubble
[21:21] <thisfred> If you happen to have the part of the log that deals with that file, it may help
[21:21] <facundobatista> thisfred, I do
[21:22] <thisfred> facundobatista: I know, but if they don't, the reset should still happen
[21:22] <thisfred> this could be where the bug is
[21:22] <facundobatista> thisfred, the part of the syncdaemon's log, or status'?
[21:23] <thisfred> facundobatista: both, if there is anything in status, but I doubt that
[21:24] <thisfred> I think I'm going to add errbacks to everything, as I don't think they are there
[21:24] <facundobatista> thisfred, I'm using your branch since midday, not early morning, so I have only syncdaemon's log
[21:24] <thisfred> and have them log
[21:24] <thisfred> facundobatista: that's fine
[21:25] <nessita> ok, I'm off for the day
[21:25] <nessita> bye all!
[21:27] <facundobatista> thisfred, no, I have both logs
[21:27] <facundobatista> thisfred, I have to tell you... status log lines are not very informative :|
[21:27] <thisfred> facundobatista: I know, working on that too
[21:28] <thisfred> like adding a metric shitton more of them
[21:29] <facundobatista> thisfred, logs sent
[21:29] <dobey> adorilson: hi
[21:30] <adorilson> hi, dobey
[21:30] <thisfred> facundobatista: thanks! will continue investigating tonight or tomorrow, have to walk the dog first
[21:30] <dobey> adorilson: can you change your diff in bug #801938 into a branch committed with --fixes=lp:801938 and propose it for merging please?
[21:30] <ubot4> Launchpad bug 801938 in ubuntuone-client (Ubuntu Oneiric) (and 3 other projects) "Make command gets error: variable 'result' set but not used (affects: 1) (heat: 8)" [Medium,Triaged] https://launchpad.net/bugs/801938
[21:30] <facundobatista> thisfred, thank you!
[21:33] <adorilson> dobey: of course
[21:33] <dobey> adorilson: thanks!
[22:01] <dobey> alright, i am out of here. good evening all
[22:21] <karni> huh. why is this channel not listed on https://wiki.ubuntu.com/IRC/ChannelList ?
[22:57] <karni> If you guys haven't yet, I strongly encourage to "Preview Gmail's new look", I love it.