wgrantcjwatson: How are we going to produce the C translations files?00:00
wgrant(also, your LongDescription interpretation is inverted, AFAICS)00:00
cjwatsonC as opposed to en?00:00
wgrantWell, do we produce the ones it's going to look for by default?00:00
cjwatsoninverted> oh bugger, you're right, silly inscrutable docs00:02
=== sidnei_ is now known as sidnei
cjwatsonapt-ftparchive defaults to writing to Translation-en, and mvo told me he'd just stop uploading -en in the i18n custom uploads.  But perhaps it ought to be C, or perhaps the client ought to be a bit smarter here ...00:08
wgrantNote that it is currently not possible to create these files with apt-ftparchive.00:09
wgrantFrom the manpage.00:09
cjwatsonNot in my version00:09
wgrantAhem. I was looking at carob accidentally.00:10
wgrantIndeed, natty's is a bit more encouraging.00:10
cjwatsonhmm.  I wonder if this is going to need YA lucid backport though ...00:11
wgrantThat stuff should be somewhat self-contained, if we want to convince mvo to backport the patch...00:12
cjwatsonI'll discuss the question of using Translation-C with mvo.  At worst it would just be a matter of setting TreeDefault::Translation / Tree::blah::Translation00:12
cjwatsonbackporting the patch will happen00:13
cjwatsonboth mvo's manager and his tech lead want this :-)00:13
cjwatsonI'll fix the inversion.  Should I rename the database column as well?  I kind of like having the new column be False by default, though00:14
cjwatsonso split_long_descriptions True => LongDescription "false"00:15
wgrantI'm not sure. Possibly include_long_descriptions defaulting to True would work...00:15
cjwatsonoh, there's default= in Bool00:16
cjwatsonI'm OK with that if it seems less confusing00:17
cjwatsonanything else from a first pass that I should sort out?00:17
wgrantcjwatson: Looks reasonable.00:19
cjwatsonCool, thanks.  I'll work on that tomorrow then00:25
wgrantwallyworld_: Is your last comment in bug #803996 a regresion on qastaging?00:29
_mup_Bug #803996: person picker widget doesn't show link to unassign myself <disclosure> <exploratory-testing> <person-picker> <Launchpad itself:Triaged> < https://launchpad.net/bugs/803996 >00:29
wallyworld_wgrant: not sure if it's a regression00:29
wallyworld_but it pertains to that bug so i added it as a comment to ensure the full scope of the issue was fixed00:30
wgrantStevenK: How goes the vocab?01:02
StevenKwgrant: *RARGH*01:09
wgrantAs expected!01:10
lifelesswallyworld_: should it hold up deploying?01:13
wallyworld_lifeless: not imho. it's a minor usability issue (page refresh fixes it) and i'm not even sure it's a regression01:14
wallyworld_i just noticed it doing some unrelated qa01:14
lifelesswallyworld_: then you might like to file a new bug for it, to fit the qa process01:14
wallyworld_lifeless: there's a bug already. i just augmented the bug details to provide extra info01:15
lifelesswallyworld_: but its the bug that will be closed when we deploy on thursday01:15
lifelesswallyworld_: if you land another incremental branch for it between now and then, we'll be unable to qa it, and the downtime deploy will get more hairy01:16
wallyworld_lifeless: ? the bug is associated with a kanban card that is in the todo list01:16
lifelessand... we're qa-bad for it now01:16
lifelessrev 13392 is broken01:16
wgrantI thought it would be.01:17
wgrantBut where?01:17
lifelesscompare https://launchpad.net/~launchpad-dev/+members and https://qastaging.launchpad.net/~launchpad-dev/+members and then click next in both on the 'active member' batch01:17
wallyworld_lifeless: bug 803996 is only triaged. that's the one i added the extra info for based on by observations when playing with qas01:17
_mup_Bug #803996: person picker widget doesn't show link to unassign myself <disclosure> <exploratory-testing> <person-picker> <Launchpad itself:Triaged> < https://launchpad.net/bugs/803996 >01:17
wgrantlifeless: Ah, indeed.01:18
lifelesswallyworld_: ah, cool01:18
lifelesswallyworld_: sorry for my confusion01:18
wallyworld_lifeless: np. it was well worh the question01:18
lifelesswgrant: the memo is not being adapted, so the memo for nav A is affecting the content for nav B01:18
wgrantRevert or fix?01:19
wgrantI think revert.01:19
lifelessunknown number of instances01:19
lifelesswgrant: how would you feel if I asked you to do the honours ?01:19
lifelessI've been chasing emails and stuff so far today - I only just got to doing qa on this01:20
wgrantLike I've done that a bit too much in the last week, but okay.01:20
* wgrant does it.01:20
lifelessI will dig up the MP and explain the situation on it01:20
=== mwhudson__ is now known as mwhudson
wgrantI have 6 reversion branches in ~/launchpad/lp-branches :(01:21
wgrant:( conflicts01:21
lifelessin a .txt file01:21
wgrantWhich is merged.01:22
lifelessits shallow - just keep the trunk version01:22
lifelessthe change was from explicit url to ...01:22
lifelessbut oh the pain - if it makes your eyes bleed, I will do it01:22
lifelessthe alternative is to not back this out01:23
lifelesslets talk through it for a second:01:23
lifeless - for any given navigator, it will work to navigate it as long as you don't switch navigators half way through things01:24
lifeless - multi-navigator pages are the exception01:24
lifeless - and switching should be rarer still01:24
wgrantBut if we revert now, we can deploy it on Friday and be able to easily revert if something goes wrong.01:24
lifelessso, what about filing a critical and rolling forward01:24
wgrantThis change is scary and hard to verify completely.01:25
lifelessthere may be other unintended side effects01:26
lifelessor this one may go deeper than thought01:27
wgrantWe lose little by reverting it now.01:27
wgrantWe gain flexibility.01:27
wgrantAnd, given the mess that the last 1.5 weeks have been, I think that is a good thing.01:28
lifelessI'm not worried about it landing later01:29
lifelessI was thinking about the headache of the reversion branch01:29
lifelessthats all01:29
lifelesswgrant: how fugly does the reversion look ?01:30
wgrantNot very. Just running the tests now.01:30
lifelessso bug batches look fine01:32
lifelessthough 'Last' still times out (because the order reversing stuff is not yet hooked up to any lp batches)01:32
wgrantlifeless: Shall I land the revert?01:47
lifelesswgrant: it was fairly clean? if so yes.01:48
wgrantI just --take-other on the story, and it passes fine.01:49
* wgrant lands.01:52
wgrantBah, forgot r-c01:54
=== lifeless changed the topic of #launchpad-dev to: devel in RC until r13403 deployable | Performance Tuesday | https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 220 - 0:[######=_]:256
lifelessjtv: this may be fallout from red's current work - https://bugs.launchpad.net/launchpad/+bug/80895002:18
_mup_Bug #808950: DistroSeries:EntryResource:searchTasks AssertionError: wrong You exported name as an IChoice based on an SQLObjectVocabularyBase, you should use lazr.restful.fields.ReferenceChoice instead <api> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/808950 >02:18
lifelessjtv: I don't know if it is|isn't02:19
lifelessmpt: hi02:21
lifelessmpt: how would you feel if your transcribed talk was edited - treated as a live doc? E.g. where you give the example of having the word 'should', I would like to add 'add', 'remove', 'change', and perhaps more as other 'words to be wary of'02:22
=== wgrant changed the topic of #launchpad-dev to: devel in RC until r13405 deployable | Performance Tuesday | https://dev.launchpad.net/ | On call reviewer: wgrant | Critical bugs: 220 - 0:[######=_]:256
wgrantwallyworld_: Around?02:51
wgrantlifeless: Can I add X-Lazr-OopsId headers to webapp OOPSes too?03:09
wgrant(to display less useless errors when pickers fail)03:10
lifelesswgrant: can you rename it?03:11
wgrantThe other one is set in lazr.restful, I believe.03:11
lifelesswgrant: X-LP-OOPSID everywhere would make me happy.03:11
wgrantSadly I guess clients may depend on it.03:12
wgrantAnd it is not overridable without lazr.restful changes.03:12
lifelessso there are I guess 3 q's03:15
lifelesscan we add a header: absolutely03:15
lifelessshould it be the same as the API one? I dunno03:15
lifelessdoes the name matter? not really, but X-LP-OOPSID is or even X-OOPSID would be a lot better03:15
lifelesswgrant: you could add whatever name and rename it later03:17
lifelesswgrant: I don't mean to inflae the work you have to do03:17
wgrantI hate Soyuz.03:21
wgrantStop deleting evidence.03:22
lifelessno sequitur ?03:24
wgrantSoyuz will let you delete a publication multiple times.03:25
wgrantEach attempt will overwrite the last date.03:25
wgrantSo I can't see what this user actually did to break their archive.03:25
lifelesshttps://dev.launchpad.net/LEP/FastDowntime for those liking 'agile'03:33
wgrantpoolie_: I'm pretty sure both frontends are broken mimetype-wise.03:44
wgrantpoolie_: But not all of them have the bad data cached all the time.03:44
wgrantI've seen text/html from both.03:44
lifelessstub: hiya03:44
wgrantpoolie_: Indeed, there are logs in the bug to show it happening from both.03:45
lifelessstub: I'm just filing bugs for fastdowntime at the moment03:46
lifelessstub: Thanks for landing batchnav! however we've had to roll it back - found a corner case03:46
lifelesswhen we have two navs on one page the new variables need their name mangled03:46
stubI think the pgbouncer config on prod is setup, but waiting on pgbouncer installation on sourcherry to proceed. Silly losas think testing is a good thing or something!03:47
spmmad buggers03:47
lifelessspm: can we get it on sourcherry then ?03:47
stubWe have 2 batchnavs on one page?03:47
lifelessstub: yeah - e.g. ~launchpad-dev/+members03:47
stublast I heard the rt was with stephan03:47
lifelessso its an easy fix, I commented in the MP03:48
poolie_wgrant, oh i see03:48
spmstub: installed03:48
poolie_that is easier to explain than having persistently different behaviour between what should be identical machines03:49
stubspm: And permissions on /etc/pgbouncer contents set so I can configure it?03:49
spmi assume at this stage we're not pulling pgbouncer into the lp-db-deps?03:49
wgrantpoolie_: Yes. :/03:49
wgrantPerhaps we should go poking in squid caches or logs or something.03:50
stubspm: No. Maybe one day if the rollout script is tested with out test suite in the -dev packages.03:50
spmnormally we object violently to 'install package' unless it's in the meta, but I'll let this ride for once.03:50
spmwhere violently == 4x2.03:50
poolie_wgrant, in that case it actually is a dupe03:50
spmwhere violently == 4x2/ip03:50
wgrantpoolie_: I've already fixed that up :)03:51
stubspm: I'm not fussed, but we will only need it installed on at most two machines so similar to haproxy.03:51
poolie_it occurred to me it would be interesting to have a losa look directly at the backend and see what it answers03:51
poolie_presumably always the correct thing03:51
wgrantpoolie_: We've never seen the backend return bad data.03:51
wgrantpoolie_: But it possibly only does it in response to certain request headers.03:51
spmstub: have at it03:52
poolie_how would you know if the backend returned bad data?03:52
wgrantpoolie_: With manual testing, this is.03:53
poolie_iow what i said has already been tried?03:53
spmstub: I'm not sure of your  meaning wrt machines similar to haproxy, wrt staging?03:53
wgrantpoolie_: Yes.03:53
stubspm: At most, we want pgbouncer running on two production machines + staging, similar to our HAProxy dependency. So putting it in the -db meta package didn't occur to me.03:54
stubProbably more a puppet thing since it one package + several customized configs03:56
spmoh I see. right.03:56
lifelesswhats the name of the codebrowse url mapper thingy?03:58
stublifeless: Are you expecting me to sort the batch navigator branch or is it punted to a bugs team?03:58
wgrantlifeless: branch-rewrite03:59
lifelessstub: Its in limbo03:59
lifelessstub: a bugs team working on batch related timeouts would have motivation to do it03:59
=== poolie_ is now known as poolie
lifelessstub: if you want to do it, be my guest; not expecting you to do so (or not to do so)03:59
stublifeless: It is a dependency of a bug abel is assignedl04:00
stubI'll checkout the required work after breakfast.04:00
lifelessstub: I think abel should do it then, it should be pretty easy.04:00
lifelessbut sure, EIDONTCARE :)04:01
stubI'm going to pull out our reliance of transaction-persistent cursors from garbo.py so we can run pgbouncer in transaction mode rather than session mode.04:02
stubWhich is a bit sucky, as I thought that code was rather cool ;)04:03
stubThink I'll need to replace it with two connections to remain efficient.04:03
lifelessstub: it was cool, but I totally endorse that change04:04
lifelessstub: could we do a brief voice call ?04:06
lifelessstub: I want to check I didn't miss anything for round one of fast downtime04:07
stubSure. I'll just plug stuff in.04:07
lifelesswgrant: has lazr.amqp had its non-longpoll expunged? ready for rename ?04:40
wgrantlifeless: It hasn't.04:41
wgrantI might look at that this afternoon.04:42
lifelessbug 80913204:42
_mup_Bug #809132: lazr.amqp is overly broad <longpoll> <lazr.amqp:New> < https://launchpad.net/bugs/809132 >04:42
=== Ursinha is now known as Ursinha-afk
wallyworld_wgrant: hi. i had to go out and sort out some car issues :-( back now04:56
wgrantwallyworld_: Was wondering how to mock out HTTP requests in the picker for unit testing.04:58
wallyworld_wgrant: we have about 3 different Y.io mocks04:58
wallyworld_the bugs js uses one style04:59
wgrantI saw MockIo, but it's only used in one place.04:59
wgrantSeems to be from lazr-js.04:59
wallyworld_there's also mickio.js brought across from lazr-js04:59
wallyworld_in other places, a js object is constructed with just the method (eg patch) that is to be patched implemented05:00
wallyworld_in most cases, the mock io object is passed to the js business logic05:00
wgrantpickerpatcher uses Y.io directly.05:00
wgrantI want to test the handling of errors.05:00
wallyworld_yes, see ^^^05:00
wallyworld_the most common approach seems to be to pass an optional io object to the business lgoic05:01
wallyworld_if io===undefined, use Y.io05:01
wallyworld_else use the mock05:01
wallyworld_there's implementations in out code base that allow the expected api call to be chacked and a return result to be provided05:01
wallyworld_if you search for IOStub you'll see some examples05:02
wallyworld_but I'd rather get a good, reusable implentation into our testing framework05:02
wallyworld_and have everything use that05:02
lifelesswgrant: where is longpoll deployment at?05:02
wgrantlifeless: Yes.05:03
lifelesswould a bug be helpful ?05:03
* lifeless makes one05:03
pooliewgrant, huh, well spotted with the 30405:07
pooliethat's pretty perverse05:07
pooliedoes it give you a body, or just the header?05:07
wgrantpoolie: lifeless did the real diagnosis :)05:08
wgrantIt just gives the header.05:08
lifelessok, ciao05:09
wgrantWell, that lazr.amqp pruning was easy.05:15
sidneipoolie, hi!05:15
pooliehi sidnei05:16
sidneipoolie, i had a question about branch splitting earlier, not sure you saw it05:17
pooliethere is 'bzr split'05:18
pooliewgrant, couldn't it just not give a content-type header?05:18
wgrantpoolie: Possibly very true.05:20
sidneipoolie, so after splitting a directory from the tree, does it get removed from the original tree or does that need to be done manually?05:20
wgrant"Any HTTP/1.1 message containing an entity-body SHOULD include a Content-Type header field defining the media type of that body."05:21
wgrantpoolie: So, looks like we can omit it.05:21
wgrantParticularly since we have no entity-body.05:21
wgrantJust ran into this bug when trying to build lazr.amqp :(05:21
pooliei thought it was normally omitted05:23
wgranttwisted.web.server.Request.process sets it to text/html at the start of the request :/05:23
wgrantSo we'd need to delete it...05:23
pooliesidnei, you will then have one tree with the subdirectory excised, and underneath it another checkout with that tree present05:23
pooliehm that's a bit presumtuous05:23
pooliei guess it depends if you want to fix this in twisted or to work around it05:24
wgrantWould be nice to fix it in Twisted, but not sure how to do that in a backwards-compatible manner.05:24
wgrantOr we could just declare the existing behaviour broken.05:25
poolie304 could perhaps just squash the ct05:25
poolieit seems unlikely anyone would really want that behaviour05:25
wgrantProbably a good idea.05:25
wgrantA self.responseHeaders.setRawHeaders("content-type", []) after the self.setResponseCode(NOT_MODIFIED) seems to work sensibly.05:28
wgrantIs a little ew, though.05:28
sidneitwisted was designed with POMA in mind (as opposed to POLA - http://en.wikipedia.org/wiki/Principle_of_least_astonishment)05:29
pooliesidnei, anyhow i suggest you at least try split05:30
pooliewhat are you going to want to do with these branches in future?05:30
pooliewgrant,  it should possibly be more general than just c-t and 304 but ...05:31
pooliethis would be the main case i guess05:31
sidneipoolie, https://bugs.launchpad.net/graphite/+bug/50182805:32
_mup_Bug #501828: Create separate branches for the webapp, carbon, and whisper <Graphite:Triaged by chrismd> <Graphite 1.0:Triaged by chrismd> < https://launchpad.net/bugs/501828 >05:32
sidneipoolie, which, btw, is still using pack-0.92. guess it's time for upgrade :)05:34
* wgrant stabs buildout in the eye.05:36
wgrantlifeless: txamqplongpoll, maybe?05:38
lifelesswgrant: sure05:51
lifelessthough txlongpoll is a bit snappier05:51
wgrantlifeless: It is, but it's also more generic.05:51
wgrantAlthough possibly reasonable.05:52
lifelesstxhttpamqp ?05:53
wgrantThat's even more syllables.05:54
wgrantPerhaps we should just do txlongpoll, as you say.05:54
wgrantMaybe we should just run txlongpoll from a package.06:20
wgrantSince all its runtime deps are in main.06:20
wgrantHm, no, python-txamqp is not in main, but it's in some PPA I have, but I can't think which.06:21
wgrantMust have been u1 or something.06:21
lifelesswgrant: no, because we can't sanely upgrade from packages (now, if ever)06:29
spivdanilos: bmp-inline-diffs has the wrong cursor for the expander link... it looks to me like perhaps the CSS needs to be adjusted so that .expander-node.js-action has the cursor:pointer style, or something like that?06:30
spivdanilos: or is there something my branch is missing?06:30
lifelesswgrant: we need to address that eventually, but I'd rather not put 'fix python packaging upstream' in our criticalpath06:33
lifelesswgrant: btw, has your revert landed ?06:34
wgrantlifeless: It passed buildbot 10 minutes ago.06:35
lifelesshow are we on assessing 1339106:35
wgrantAn indeterminate point between "handwave" and "kill me now"06:36
wgrantIt says "Remove Person", when it shouldn't be talking about removing people and should be sentence case.06:38
wgrantI don't trust it any more.06:38
wgrantTempting to revert.06:38
wgrantAny person chooser on a traditional form. eg. the bug supervisor field on https://launchpad.net/launchpad/+configure-bugtracker06:40
wgrantOr assignee on +filebug06:40
lifelesswallyworld_: ^ is that intentional ?06:40
wallyworld_i think so06:41
wgrantSentence case looks and is wrong.06:41
wgrant"remove person" is a bit violent.06:41
wgrantBut it seems to mostly work.06:41
wallyworld_it's config - it can be changed06:41
lifelessPerson is wrong too06:41
lifeless(teams are not people outside of LP's schema :))06:41
wallyworld_it should say Remove Assignee for bug task pickers and whatever the default text is elesewhere (unless overridden)06:42
wallyworld_so i guess the default text is wrong plus some overrides are required06:43
lifelessoh, there is a regression06:43
wgrantI've just been reading the code so far.06:43
lifelesson https://qastaging.launchpad.net/launchpad/+configure-bugtracker06:43
wgrantWhat's the regression?06:43
lifelessgo to the bottom - e.g. security contact06:43
lifelessclick on 'Choose...'06:43
wgrantIf you reopen it goes away.06:43
lifelessthen click on the search widget (don't change the text)06:43
lifelessnow try to remove the assignee06:43
lifelesshowever the regression is live on prod already06:44
lifelessso its not a new problem06:44
lifelessah, except06:44
lifelesson prod if you reopen the picker06:44
lifelessyou get the buttons back to remove assignee etc06:44
lifelessI have to run - can you two - wallyworld_ , wgrant - decide if this is really a regression or not, and revert or file a bug accordingly? cheers,06:45
* lifeless goes06:45
wallyworld_that issue i am looking at now - the remove/pick me buttons not reappearing after a search06:45
wallyworld_it's not a regression06:45
wgrantwallyworld_: They also don't appear if you reopen the picker while the textbox is empty, AFAICT.06:45
wgrantIt is very odd.06:45
wallyworld_they won't appear if a search has been done06:46
wgrantSo, the UI text is pretty bad and needs fixing, but rolling back is expensive...06:46
wallyworld_it's not a regression, so rolling back won't help06:46
wallyworld_the issue was present in the original work john did afaict06:47
wgrantWhich isn't a regression?06:47
wallyworld_the buttons disappearing06:47
wallyworld_after a search06:48
wallyworld_i have a simple fix for the disappearing buttons issue but writing a test is a bitch06:48
wallyworld_without any io stubs :-(06:48
wallyworld_the wrong Remove Person text is also not a regression06:48
wallyworld_i can'r recall when that branch landed06:48
wgrantIt's currently "Remove assignee" on production.06:49
wgrantWhich is correctly capitalised, and only questionably worded, not outright wrong :)06:49
wallyworld_Removee assignee everywhere?06:49
wallyworld_ok. the branch that changed the wording was done to address a bug that said "Remove assignee" was wrong06:50
wgrantIt's less than ideal.06:50
wallyworld_so it's wrong differently06:50
wgrantBut "Remove Person" is doubly wrong.06:50
wallyworld_don't be a case nazi :-). we can live with "incorrect" case, no?06:51
wgrantIt is terribly ugly.06:51
wallyworld_it's just the use of the word Person in cases where it's a team?06:51
wgrantThat too.06:51
wallyworld_beauty is in the eye of the beholder06:51
wallyworld_i honestly can't see why this is such a showstopper06:51
wallyworld_it's easily fixed i'm sure06:52
wgrantBecause I don't trust the branch and am looking for excuses to revert it.06:52
wallyworld_why don't you trust the branch?06:52
wallyworld_besides cosmetics, is there anything *functionally* wrong?06:53
wgrantBecause I've had to revert it once already, along with 6 other things in the last week, it uses string concatenation to create HTML, the text is wrong, there are underlying bugs with the previous branch that aren't yet resolved, suggesting everything is more fragile than we can imagine...06:54
wallyworld_there was one reverted due to a true/True issue but this is a different branch now afaik. the concat and etc and text don't warrent a rollback. they can be fixed06:55
wgrantThis is a relanding of the true/True issue branch.06:56
wallyworld_not exactly - it also has other stuff in there if i am correct06:56
wgrantBut it is a superset of the branch that was rolled back.06:57
wgrant+ fixes06:57
wallyworld_yes, believe so06:57
wallyworld_so we have 3 outward facing issues - text, wording and the disappearing buttons issue.06:58
wallyworld_disappearing buttons i have a fix for but need to figure out what effort i should expend writing the %@^!$ test without a io stub06:58
wallyworld_the text case is ugly but cosmetic06:59
wallyworld_the wording is unfortunate and we can land a fix quickly06:59
wgrant(three *known* outward facing issues, but OK)06:59
wallyworld_i don't think any others have come up so far?07:00
wgrantRight, so any other problems are as-yet unknown.07:00
wallyworld_there's only a finite number of use caases to check07:00
wallyworld_where finite is not that large07:00
wallyworld_i mean in terms of how pickers are wired up07:01
wallyworld_rather than actual instances on all lp pages07:02
jtvlifeless: hi.  That API bug you ran into looks like a Bugs problem, not apparently related to our derivation work.07:26
wgrantjtv: You haven't been playing with distroseries vocabs at all?07:32
jtvhi wgrant: you're talking about that Bugs API problem?07:33
wgrantjtv: Yeah.07:33
wgrantIt looks like it may be a distroseries vocab change, which rvba has been touching a bit lately IIRC.07:33
jtvI think so, yes07:34
=== pjdc_ is now known as pjdc
adeuringgood morning07:59
mrevellBom dia08:01
wgrantI think I almost understand buildout!08:07
wgrantbigjools: Morning.08:15
bigjoolsmorning wgrant08:15
StevenKwgrant: Are we deployable *now*?08:16
wgrantStevenK: Has qastaging updated?08:16
=== almaisan-away is now known as al-maisan
wgrantbigjools: lazr.amqp is to be torn apart and renamed.08:16
StevenKqas is running r1340508:16
wgrantAs we don't use anything except for lazr.amqp.async08:17
wgrantlifeless suggests deleting everything else and renaming to txlongpoll08:17
wgrantYay, batchnav is no longer broken.08:23
wgrantWe may be deployable.08:24
wgrantIf we are very lucky.08:24
stubDid batchnav get fixed or are you talking about the rollback?08:54
wgrantstub: The latter.08:55
stubwgrant: Nah. Never seemed worth the trauma or load.08:57
lifelessjtv: its a bugs call, but it looks like a distroseries thing09:15
jtvlifeless: yes — you could ask le stigue if his vocab work might have played a role, but he's unavailable today.09:15
jtvlifeless: the method smelled like IHasBugTasks.09:18
lifelesssure, I was just grabbing the closest red teamer :)09:18
* jtv wonders idly what connotations "red teamer" might have in English09:18
jtvStill, probably safer than "scarlet brigade."  That sounds positively filthy.09:19
lifelessnight night09:19
danilosadeuring, hi, I suppose you don't want to finish reviewing https://code.launchpad.net/~danilo/launchpad/replace-expanders-2/+merge/67314 and I should reassign back to lp-reviewers?09:35
adeuringdanilos: sure, I can do it09:35
danilosadeuring, cool, thanks (I've fixed the problem with the focus event, should be fine now)09:46
adeuringdanilos: yes, I already noticed it!09:46
danilosadeuring, yeah, the problem was not fixing the issue, but keeping the keyboard focus behaviour :)09:47
adeuringdar=me (had to raid my desk to find my notes from friday ;)09:48
adeuringdanilos: r=me09:50
danilosadeuring, cool, thanks09:50
wgrantallenap, bigjools: Any objections to the pruning, renaming, and removal from LP?10:03
bigjoolswgrant: of amqp?10:03
wgrantbigjools: Yes.10:03
mptlifeless, I'm not sure how I feel about others editing it, but it's quite short, so perhaps there could be a Comments/Discussion section underneath? W.r.t. "add"/"remove"/"change", really any imperative summary falls into that category ("Make this work this way"). Excellent for issues classed as to-dos, not so good for issues classed as defects.10:04
wgrantI have a deployment strategy now too.10:04
StevenKwgrant: For lazr.whatevernameyoupicked or LP itself?10:09
wgrantStevenK: txlongpoll (née lazr.amqp)10:09
bigjoolswgrant: what's the "tx" bit?10:11
wgrantbigjools: Twisted extensions10:11
bigjoolsis it moving out of lazr?10:12
wgrantThat's apparently the plan.10:12
wgrantIt is de-Zoped and now entirely twisted.10:12
wgranttxamqp is the AMQP library it uses.10:13
bigjoolswhich begs a question ...10:13
bigjoolsWTF didn't anyone think to use tx-something in the first place!10:13
wgrantWell, it had all the Zopey crap in it initially.10:13
bigjoolswhere anyone == landscape guys10:13
bigjoolsanyway, all's well10:14
wgrantI also now understand buildout.10:15
wgrantWhich is handy for this sort of thing.10:15
al-maisanis anything special going on at present? I am trying to add a tag to https://bugs.launchpad.net/openquake/+bug/803419 but launchpad will not let me10:21
_mup_Bug #803419: permission denied for relation geography_columns <database> <OpenQuake:Confirmed> < https://launchpad.net/bugs/803419 >10:21
bigjoolsyes, something Is Bad10:22
al-maisanalso, when I refresh the bug page it will say "Log in/Register" although I *am* logged in..10:23
StevenKal-maisan: You're not anymore10:23
StevenKThe session DB was just ... cleansed10:23
al-maisanhow interesting ;)10:24
StevenKAh no, we do have an issue10:24
StevenKal-maisan: Wait a few?10:24
wgrantal-maisan: Should be OK now, if you log in again.10:32
al-maisanwgrant: thank you!10:32
wgrantThe session DB switch was a little more troublesome than expected.10:32
danilosmrevell, hey, I wonder if I should say things like "they is" for the "singular they" :P10:33
al-maisanI was able to add the tag FWIW .. thanks again !!10:33
danilosmrevell, also, are we seriously on British English for LP?10:33
mrevelldanilos, Singular they is perfectly acceptable English :) As for British English ... well ... maybe this needs more discussion on the list but the company standard is British English and we are rebranding LP to fit more in line with the company brand.10:35
wgrantCanonical code seems to be American English, while our text seems to be British English... I don't know why we'd use American anywhere :/10:35
mrevellFor a long time, I think the interface text was a case of personal choice, then we settled on a policy of American English (I forget the reasons why) but for a couple of years now our company policy has been explicitly to use British English.10:35
danilosmrevell, "they is" sounds very weird to me, but then again, my English is better than yours :P10:36
jpdsThere's.... a singular they?10:36
danilosmrevell, should we make use of the scripts different en_GB teams have to switch the hood to the bonnet across the board?10:37
mrevelldanilos, Oh, I thought you were joking. Singular they still takes "are". It's a compromise. It's better than using "he" everywhere, it's also better than using "she" every now then as a token effort.10:37
mrevelldanilos, Such scripts exist?10:37
danilosmrevell, right, I was joking but I didn't realise you were as well :)10:37
danilosjpds, a recent invention, I am sure :)10:38
* mrevell goes to find the Oxford Style Manual10:38
bigjoolscan we please nuke the Oxford Comma from orbit?10:38
danilosmrevell, good excuse to be gone for hours, good luck and enjoy the beer :)10:38
nigelbOn a positive note, we'll have lots of "How do I fix the color for that box?" "Add a u"10:38
mrevellIt was right next to me. I'm just finding the right page.10:38
henningeIs there such a thing as a "webservice console"10:38
henningeI mean a script that uses launchpad lib to query the webservice for testing?10:39
daniloshenninge, I've seen it mentioned a few times, if there is, it's probably hosted as a project on LP :)10:40
daniloshenninge, perhaps lpshell by poolie10:40
* henninge looks10:40
pooliehenninge, there is a gui client in wrested10:41
poolieand there is lpshell in lptools10:41
poolieit depends what specifically you want to do10:41
henningepoolie: lpshell sounds like what I am looking for. Thanks10:42
henningepoolie: only there is no lpshell in lptools10:44
maxbhenninge: lp-shell10:44
maxboh, and ubuntu-dev-tools10:44
mrevelldanilos, Basically, singular they, otherwise known as "generic they" has been used in English for hundreds of years. The alternative is to use generic "he", which is nowadays unacceptable for appearing to refer to one gender only (rather than being used in place of a neuter). From what I've read over the years, dislike of singular they appears to be an American hang-up.10:48
wgrantpoolie: Thanks for forwarding that.10:49
danilosmrevell, oh, that's nice, I've only seen increased use of it in the last few years in the day-to-day communication (I've seen it used in literary works from way past)10:50
poolie+1 to they10:51
poolies//hooray for they10:51
mrevelldanilos, I think it's used increasingly as a way to avoid any unintended gender bias. I think it works well for that and it's a bonus that Shakespeare used it.10:51
danilosmrevell, anyway, what I was trying to say with the comment was that you may want to explain that "singular they" is still used with "are" for those non-English developers such as me, just so we don't have to think twice :)10:51
=== al-maisan is now known as almaisan-away
danilosmrevell, I used to use "they" just as if it were the plural they, so the term "singular they" confused me10:52
mrevelldanilos, Ah, thanks, yes.10:52
mrevelldanilos, I shall change it to "generic they" and give a usage example.10:53
wgrantjml: What is https://blueprints.launchpad.net/lazr.amqp/+spec/silly-blueprint?10:53
danilosmrevell, cool, thanks10:53
henningedanilos, maxb, poolie: lp:ubuntu-dev-tools/lp-shell is what I was looking for. Thanks!10:53
pooliemrevell, the more examples actually taken from lp text, the better, imo10:54
mrevellpoolie, Cool. I'm always tempted to use "That and a pair of testicles" as an example of what we're trying to move away from.10:56
wgrantHas that been removed yet?10:56
mrevellBut, yeah, I'll use some real world examples. Any suggestions gratefully received :)10:56
wgrantI recall its abolition was considered a couple of years back.10:56
mrevellwgrant, Yeah, it went quite a long while back AFAICR>10:57
wgrantGood, good.10:57
pooliemrevell, that is a perfect example10:57
pooliei might have even excised them10:58
mrevellpoolie, I'm probably missing something but I'm not sure I understand the problem with "Read about uploading"-style links.11:02
mrevellCan you help me understand?11:02
pooliei will try11:02
poolieshould it be "Tell me about uploading" or "Read about uploading"?11:03
poolieit's not a critical bug11:03
poolieit just kind of sticks out to me as possibly inconsistent11:03
poolieor should it be "Help on uploading"11:03
mrevellOh, I see.11:04
pooliethe question is, is it just a noun phrase describing what's at the end of the link, or is either lp or the user the subject of an imperative11:04
mrevellI think that in line with mpt's guidance "As a user, you interact with the control, so it speaks as your voice", it should be "Tell me about..." The imperative seems to make the link more personal; maybe even friendlier.11:06
poolieright, though perhaps "tell me about" is verging on too cute11:07
pooliebut i think the essential thing is that most hyperlinks, as opposed to buttons, don't have verbs at all11:08
poolie(is this true?)11:08
mrevellpoolie, We have "Report a bug", "Ask a question" etc as hyperlinks, rather than buttons.11:09
mrevellSo, if there is a tendency not to have verbs in links then we don't have it as rule, I'd say.11:10
poolieyeah, i was just thinking that11:10
pooliewe have a weak pattern of links that appear in button-like places being phrased more like actions, and those that appear in text being more like real hyperlinks11:11
mrevellWe tend to use a verb, I think, where there's a definite action, rather than just a request to list information.11:11
mrevells/definite action/something that changes data11:11
poolieright, perhaps that's the rule11:11
pooliethat it shouldn't be "Tell me about blah" or "show blah" or "list blah"11:12
pooliemaybe there's even a rule for that?11:12
mrevellI don't think it's a written rule. I'll trawl the dev wiki and elsewhere for anything else and attempt to bring it all together. I'm also going to go read up on what other people have done with the wording of help links :)11:13
pooliei don't want to cause people to get stuck on that particular question11:14
mrevellI think it's an interesting point though and I bet other people have handled it in ways that we can borrow.11:15
pooliethere are probably a lot of other style guides that cover it11:17
poolieit seems like the current wording page assumes that only buttons are actions, which is not ture11:18
danilosmrevell, btw, you should talk to en_GB people about the script, I am sure they have a few handy11:20
mrevelldanilos, Cheers. Do you have an idea of who I should speak to?11:22
danilosmrevell, http://live.gnome.org/BritishEnglish is a good starting point (there's a script there as well)11:23
=== wgrant changed the topic of #launchpad-dev to: devel in RC until r13405 deployable | Performance Tuesday | https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 220 - 0:[######=_]:256
=== mrevell is now known as mrevell-lunch
jmlwgrant: you noticed my attempt to get top contributor :)12:17
wgrantjml: Heh12:17
wgrantThen I turned off blueprints.12:17
jmlgood thought.12:19
benjiflacoste: I think lp:~benji/launchpad/bug-781600 is ready for you to look at; do you want to do a formal review or an informal one?12:23
=== matsubara-afk is now known as matsubara
=== almaisan-away is now known as al-maisan
cjwatsonOK, how do I sign files in lib/lp/archiveuploader/tests/data/suite/?  The existing ones are signed with key ID 6C64A8C5, and I *know* I've done this before but I can't remember how.  I've found lib/canonical/launchpad/ftests/gpgkeys/foo.bar@canonical.com.sec, but it has a password I don't know, and lib/canonical/launchpad/ftests/gpgkeys/foo.bar@canonical.com-passwordless.sec has a different key ID.12:44
cjwatsonlib/lp/archiveuploader/tests/data/secring.gpg looked plausible but doesn't contain this key.12:45
=== mrevell-lunch is now known as mrevell
cjwatsonthat's confusing, the last time I did this apparently I got it from lib/canonical/launchpad/ftests/gpgkeys/ - but where did I get the passphrase?12:53
henningewhich script do I need to run on dev to create a diff for a merge proposal?12:53
cjwatsonbigjools,wgrant: do either of you know the answer to my gpg question?12:54
bigjoolscjwatson: the password is "test"12:54
wgrantThat is also my recollection.12:55
bigjoolsNFI why someone decided it was a good idea to add a password12:55
cjwatsonaha!  thank you12:55
bigjoolshenninge: run_jobs in the right job source12:56
cjwatson(I'm fixing up dpkg-xz-support)12:56
bigjoolsI forget the name but you have powers to find out :)12:56
=== dobey_ is now known as dobey
henningebigjools: thanks, looking12:57
bigjoolshenninge: there's a mergeproposaldiffpreview or similar12:58
bigjoolsjob, I mean12:58
wgranthenninge: make sync_branches12:58
wgrantOr cronscripts/mergeproposaljobs.py12:58
wgrantOr you could run the job directly, but I don't know if that actually works these days.12:58
bigjoolsah that's it12:59
henningewgrant: cronscript/merge-proposal-jobs does not do it, neither does make sync_branches :(13:00
wgranthenninge: We found during the sprint that some occasionally got stuck somehow... perhaps the job has failed?13:00
wgrantTry resubmitting or deleting and recreating.13:00
=== Ursinha-afk is now known as Ursinha
bigjoolsok I can't stare at this issue any longer, I need help.  What are the usual reasons a security adapter is not called?13:03
wgrantbigjools: The object is not proxied.13:03
bigjoolsit is13:03
bigjoolsI am fixing an existing problem I found when realising a permission test was in the zopeless layer13:04
bigjoolsmakePlainPackageCopyJob() is returning a proxied object13:05
wgrantDoes test_extendMetadata_is_privileged still pass?13:06
bigjoolsnot any more13:07
bigjoolsthat's the one that was in the zopeless test layer13:07
bigjoolsit only passed because the zcml was fucked13:07
wgrantHmm. Possibly relevant is that your adapter is for IPackageCopyJobEdit. It should normally be for IPackageCopyJob, but that's hopefully not what's breaking this.13:07
wgrantIt's still odd and should be fixed.13:07
bigjoolslet's see13:08
bigjoolsdidn't fix it, no13:09
wgrantTry the adaption manually, and see if gets the right adapter?13:09
bigjoolsI can't remember the runes13:11
wgrantLet me see.13:12
bigjoolssleep deprivation does that13:12
wgrantI've been up since 3am :)13:13
wgrant(Pdb) queryAdapter(pcj, IAuthorization, name='launchpad.Edit')13:13
wgrant<canonical.launchpad.security.EditPackageCopyJob object at 0xeff4c90>13:13
bigjoolsso that worked, but ... :/13:17
wgrantIt's really like it's running with PermissiveSecurityPolicy...13:17
bigjoolsthe zcml looks ok though13:19
gary_posterflacoste, https://bugs.launchpad.net/launchpad/+bug/775691 : should we contact david planella with danilos's analysis or should we treat the migration as escalated?  danilo says the migration will be pretty tough, and there are workarounds13:20
_mup_Bug #775691: Empty translations on one side do not get translated by the other side <escalated> <not-pie-critical> <upstream-translations-sharing> <Launchpad itself:Triaged by yellow> < https://launchpad.net/bugs/775691 >13:20
wgrantbigjools: Ahahahah13:24
wgrantbigjools: It's a PlainPackageCopyJob, not a PackageCopyJob.13:25
wgrant    <!-- PlainPackageCopyJob -->13:25
wgrant    <class class=".model.packagecopyjob.PlainPackageCopyJob">13:25
wgrant      <allow interface=".interfaces.packagecopyjob.IPackageCopyJob" />13:25
wgrant      <allow interface=".interfaces.packagecopyjob.IPlainPackageCopyJob" />13:25
wgrant    </class>13:25
bigjoolsof course - it's bloody delegating13:26
bigjoolsthanks wgrant13:26
cjwatsonHmm, I'm trying to fix my dpkg-xz-support branch and getting very confused about tests.  I have a testXZDebUpload test defined right after testLZMADebUpload, and basically cargo-culted from it.  testLZMADebUpload tests for package uploads in the NEW queue, so I did the same in testXZDebUpload.  But apparently the upload ends up in ACCEPTED instead, suggesting that something isn't being torn down properly.  How do I get ...13:26
cjwatson... rid of the stale state from the previous test?13:26
cjwatsonthis is in lib/lp/archiveuploader/tests/test_uploadprocessor.py13:26
bigjoolscjwatson: it's likely to be the upload policy, not test isolation13:27
cjwatsonwouldn't the same policy apply to both lzma and xz uploads?13:27
bigjoolspaste a diff13:28
wgrantcjwatson: You're sure you cloned the right upload?13:28
wgrantAll DB state should be reset between tests, unless scripts are doing something bad.13:28
bigjoolsit's probably a package with ancestry13:28
cjwatsonI *think* so ...13:28
bigjoolsso gets auto-accepted13:28
cjwatsoner, bollocks, that's stale, one moment13:29
cjwatsonbigjools: the MP's being slow to update, but http://paste.ubuntu.com/642636/ is my current diff against devel13:37
flacostebenji: i'll do a formal one13:41
flacostegary_poster: let's leave that decision to david13:42
benjiflacoste: cool, in that case I'll write up an MP and ping you when it's ready13:42
=== matsubara is now known as matsubara-afk
flacostebenji: great13:42
cjwatsonoh, yes, and it doesn't look like test isolation because 'bin/test --pdb -t lp.archiveuploader.tests.test_uploadprocessor.TestUploadProcessor.testXZDebUpload' shows the same thing13:42
bigjoolscjwatson: the one in accepted will be the source13:42
gary_posterflacoste: ack will do13:43
bigjoolscjwatson: looks like a genuine upload failure13:43
bigjoolscheck what processUpload returns13:44
cjwatsonAha.  Is the upload log left anywhere, or do I just need to pdb it?13:44
bigjoolsit probably gets cleaned up unless you can see something hiding in /tmp13:44
bigjoolsI'd pdb it13:45
cjwatsonOK, thanks13:46
cjwatsonSystemError: "E:This is not a valid DEB archive, it has no 'data.tar.gz', 'data.tar.bz2' or 'data.tar.lzma' member"13:57
cjwatsonWe need an apt backport too, it seems :-(13:57
=== danilo_ is now known as danilos
bigjoolscjwatson: bugger14:21
benjiflacoste: ok, the MP and MP-inspired polishing is done: https://code.launchpad.net/~benji/launchpad/bug-781600/+merge/6770414:29
bigjoolscjwatson: heh, that point was raised in April on the MP as well14:31
cjwatsonbigjools: that was python-apt, and I'm testing with that14:33
cjwatsonbut there's a bit of relevant code in apt too14:33
bigjoolsah ok, thought you meant the former14:33
=== al-maisan is now known as almaisan-away
flacostebenji: i'll probably only review after lunch14:55
benjisounds good14:55
henningeadeuring: I found the error cause.15:34
henningeadeuring: it is not revision ids.15:34
adeuringhenninge: cool, what was the problem?15:35
henningeadeuring: diffstat is defined as a Text field but it contains a dict.15:35
henninge{u'__init__.py': (1, 0)}15:35
adeuringhenninge: argh...15:35
henningeadeuring: the standard marshaller applies a blanket unicode cast to all values.15:36
henningeso it becomes u"{u'__init__.py': (1, 0)}"15:36
adeuringhenninge: interesting... I'm wondering why nobody noticed this before in API applications...15:36
henningeadeuring: as I said, it simply converted to unicode which our marshaller doesn't do15:37
henningeI guess nobody ever used this particular value15:37
adeuringhenninge: right, seems so15:38
henningeadeuring: I have to leave now, I will think about a proper fix tomorrow.15:38
henningeprobably just do the same thing ...15:38
adeuringhenninge: schönen feierabend15:38
=== beuno is now known as beuno-lunch
=== deryck is now known as deryck[lunch]
=== salgado is now known as salgado-lunch
=== deryck[lunch] is now known as deryck
=== beuno-lunch is now known as beuno
=== salgado-lunch is now known as salgado
jtvNobody here to review https://code.launchpad.net/~jtv/launchpad/bug-809211/+merge/67731 ?17:08
jmljtv: tl;dr. sorry.17:14
m4n1shis valc-0.14 actually vala git HEAD?17:18
m4n1shwrong channel17:18
jmlcross-posted from canonical/#tech, is there a way of using virtualenv without it downloading packages from the internet all the time?17:24
jmlgary_poster: you know about this stuff, right?17:26
jcsackettjml: as in someone wants to use virtualenv and locally install eggs themselves?17:27
jmljcsackett: yeah. I've got the eggs from *previous* runs of virtualenv, and sometimes like creating new branches and hacking on them without internet access.17:28
gary_posterjml, somewhat.  Making a new virtualenv without downloading packages might or might not be supported.  Once it is installed,17:28
gary_posterI'm pretty sure that setuptools/distribute allows you to specify where to look for eggs17:28
gary_posterbuildout uses those options itself17:28
gary_posterI'm not sure what those options are, but that's where I'd start17:29
jmlgary_poster: ok, thanks.17:29
=== Ursinha is now known as Ursinha-lunch
flacostesinzui: http://approvaltests.sourceforge.net/18:19
flacostesinzui: pycharm includes image diff support in 1.5, so would probably be possible to have good tool support there18:32
=== thekorn_ is now known as thekorn
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
nigelalready? Unfair!19:30
lifelessnigel: happens like clockwork19:31
lifelessflacoste: ping19:40
* abentley finds it depressing that "[] !== []" in JavaScript. Also finds !== depressing.19:56
* maxb blinks, and cries19:57
maxbseriously, wtf?19:57
maxbOh, because Array does define sensible equality :-/19:58
jtvIn python, "[] is []" also evaluates to false.  Makes sense to me.19:58
cjwatson!== is object identity rather than equality IIRC19:58
jtvThat's right.19:59
nigelIsn't !==, the not of === which is object equality?20:00
abentleycjwatson, jtv: No, !=== is object identity.  !== is no-coerce object inequality, != is coerce object inequality.20:01
cjwatsonoh dear god how many operators20:01
cjwatsonand I'm speaking as somebody who likes writing perl20:01
flacostehi lifeless20:02
flacostebenji: i sent you a bunch of comments on your branch20:02
benjiflacoste: thanks, I'm looking at them now20:03
flacostebenji: let me know if there is anything confusing in them20:03
lifelessflacoste: I forgot to ask you about my emeritus idea on the call yesterday20:03
abentleycjwatson: I tell a lie.  You are correct.  However, [] != [] too.20:03
benjiflacoste: on first reading everything looked good20:03
flacostelifeless:  i liked it!20:03
lifelessI'll take it to -dev ?20:04
lifelessmaxb: btw, I think that duping you did is incorrect20:05
lifelessmaxb: before I undo it, can you explain why they are dupes?20:05
maxbThe merged proposed team membership?20:05
maxbIt seemed like both bugs were complaining about being unable to operate on merged proposed team members20:06
lifelessbug 204002 is about proposals after doing  amerge20:06
_mup_Bug #204002: can't approve/decline a member with a merged user <404> <lp-registry> <merge-deactivate> <Launchpad itself:Triaged> < https://launchpad.net/bugs/204002 >20:06
lifelessbug 393914 is about actual membership after a merge20:06
_mup_Bug #393914: ~team membership of ~X-merged can not be deactivated <404> <canonical-losa-lp> <lp-registry> <merge-deactivate> <Launchpad itself:Triaged> < https://launchpad.net/bugs/393914 >20:06
lifelessAFAICT that is20:07
lifelessmaxb: ^20:10
maxbOh. I figured they both must be talking about proposed membership, on the assumption that actual memberships would have been fixed up by the merge process20:11
lifelessbenji: on bug 809470, did you mean 'triaged low' ?20:24
_mup_Bug #809470: Wishlist: Time and Taskplanning <gantt> <pert> <planning> <task> <time> <Launchpad itself:Won't Fix> < https://launchpad.net/bugs/809470 >20:24
lifelessbenji: I only ask because setting an importance seems redundant when wontfixing :)20:25
benjilifeless: I meant "N/A" but that wasn't an option20:25
lifelessgmb: oh hai :P20:26
benjiI almost used "Wishlist" but I don't think we really wish it to happen, and Undecided didn't seem to make sense.20:26
gmblifeless: Wotcher.20:26
lifelessbenji: it may be a linaro request;20:26
lifelessgmb: since you are hanging around, want to sort out this linked_branches thing?20:26
gmblifeless: I won't be around for much longer, but we can give it a stab, sure.20:27
lifelessbenji: If rephrased into a symptom based report, I think that that bug would look closer to jmls timelines/todo lists/thingy concept, which we do want to do20:27
lifelessgmb: so its a bait-and-switch on the implementation, the contract stays unaltered20:27
lifelessgmb: make new getter with one parameter(user); unpublished linked_branches in the API, publish the new thing as linked_branches with the user parameter auto-bound20:28
gmblifeless: Okay. I don't know enough about how the API is exposed in WADL, etc., but might that not break callsites?20:29
benjilifeless: could be20:29
gmbif it's currently:20:29
gmbbranches = bug.linked_branches20:29
lifelessgmb: stays the same, because you're publishing it as a getter, not as a function20:29
gmbWon't that break when we turn it into a getter? (i.e. wouldn't it require linked_branches())?20:29
gmblifeless: I think there's a cognitive gap here that I need to fill in, but I'm with you now.20:30
lifelessthere are examples that can be cargo culted, its the API version of 'property(get_fn)'20:30
gmblifeless: Okay. I'll dig up an example and rip it off liberally tomorrow am.20:30
gmbThanks for taking the time to explain things :)20:30
lifelessI'm probably describing it slightly wonky ;)20:31
lifelessbenji: I might put it incomplete and follow up with some questions20:32
gmblifeless: Well, we'll see. If I get it right first thing tomorrow then I was paying attention wonkily :)20:32
lifelessgmb: \o/20:33
* gmb goes to do evening stuff20:33
lifelessbenji: I'm confused by 809508 vs 80951120:33
benjilifeless: how so?20:34
lifelessaren't they the same thing ?20:34
benjithat would be confusing :)  nope, one is about viewing a bug and associating it with a branch, the other is about viewing a branch and associating it with a bug20:35
benjisame result, different contexts20:35
lifelessah, cool20:36
flacostelifeless: deployment-stable.html shows 13405 as QA-OK, are we good to deploy and reopen PQM?20:41
lifelesscr3: have you tried your API yet ?20:42
flacostelifeless: -emeritus and asking -dev, good idea20:43
lifelessflacoste: I need to touch base with wallyworld/wgrant, rev 13391 also had some questions around it20:43
flacostelifeless: ok, thanks, would have been nice to have an email to the list about the status of the queue20:43
flacosteas everything was green20:43
flacosteit wasn't clear without reading the IRC backscroll what was the status20:43
lifelessflacoste: indeed; I asked wallyworld and wgrant to decide and sort it out last night20:44
lifelessI had parenting class20:44
flacostethat was one thing that having a rotating release manager eased out20:44
lifelessagreed, its easier for that to be lost now20:44
cr3lifeless: yep, I commented on bug #801334 and set the tag to qa-ok20:48
_mup_Bug #801334: IHWSubmissionSet.search should be available in the API <qa-ok> <Launchpad itself:Fix Committed by cr3> < https://launchpad.net/bugs/801334 >20:48
lifelesscr3: great, thanks20:48
lifelessdoes anyone remember what jmls .., ah dashboards20:52
cr3benji: if you happen to have a moment, might you know how a project is able to find a project_series under it when accessing /<project.name>/<project_series.name> in the api? wouldn't IProduct have to define a default collection for that to work?20:54
lifelesscr3: project.active_series20:54
lifelesssinzui: isn't bug 95419 in your todo list ?20:56
_mup_Bug #95419: Record dependencies between bugs <lp-bugs> <oem-services> <Launchpad itself:Triaged> < https://launchpad.net/bugs/95419 >20:56
cr3lifeless: aha! lazr.restful probably calls upon ProductNavigation which has: traverse(name): return self.context.getSeries(name)... that must be it21:04
flacostelifeless: btw, we have the green-light from statik on killing the lazr brand21:04
lifelessflacoste: sweet21:05
cr3what's this about killing lazr?21:05
lifelessflacoste: I'll document creating projects on the wiki shortly21:05
lifelesscr3: not killing as such, but de-emphasising its use for new projects21:05
lifelesscr3: aiming for good snappy names, avoiding issues with namespace packages21:06
cr3lifeless: for my edification, what's wrong with namespace packages?21:06
lifelessthat they exist?21:07
lifelesscr3: in debian/ubuntu they can't be imported unless the package above exists, but the upstream packaging doesn't include that, or if it does include that multiple packages are then including the same file on disk.21:07
lifelesscr3: its a right PITA21:08
cr3lifeless: I was planning to split my launchpad-results project into namespace packages, for client and server to share a common name for example, it was a pain indeed and I'm reassured that it wasn't just me :)21:09
rockstarWhy are the fonts on Launchpad so small now?21:22
sinzuilifeless, it is not truly in scope. I hope that a simple enum can be used so that dependencies are cheap to do (a week of work)21:22
lifelesssinzui: could you unpack that for me ?21:23
sinzuirockstar, the css is now Ubuntu Web Guidelines.21:23
sinzuirockstar, There may be a switch back to em's which is easy to do after the normalisation I did to get it to px.21:24
rockstarsinzui, so are you saying there are bugs with sizing that need to be worked out, or that they are correct (because I debate that)21:24
lifelessrockstar: they are correct per the guidelines we're getting. Some users (e.g. me and you :P) find them impossible to read.21:24
sinzuilifeless, we are making a is b, a duplicate that is not presented as a duplicate because we want separate conversations21:25
rockstarlifeless, than the guidelines are wrong.  :) I like small fonts, and those are still painful to read on my 23" 1080p monitors.21:26
sinzuirockstar, no. I *believe* that the Canonical accessibility/WAI drive requires a review of the px rule21:26
rockstarsinzui, okay.  Just as long as someone is looking to correct that.21:26
rockstarI first noticed it on "Propose for merging" which seems the LAST thing you want to be tiny and out of the way.21:27
lifelesssinzui: hmm, I had thought we were doing 'a depends on b' which combined with privacy addresses the OEM use case as well, but is more generally useful21:27
sinzuirockstar, the assumption of px was that all browsers have fixed the zooming rules for control++ and control+-. The assumption did not consider that users do not know about the feature21:27
sinzuilifeless, you and I want directionality, but stakeholders have only discussed confidential conversations.21:28
lifelesssinzui: concretely, I think an 'a is b' relation is something we wouldn't do if we did 'a depends on b', and so its a false economy to build it - we'll have to undo the work later21:29
rockstarsinzui, well, I think there should be sensible defaults as well though.21:29
sinzuilifeless, We will review and revise the requested feature in a few weeks.21:29
lifelesssinzui: ok; if its ok with you I'd like to be part of that review21:29
sinzuirockstar, the default happens to be the same as the Ubuntu OS defaults. The issue is that browsers always apply their own scaling rules based on 16pt.21:30
sinzuilifeless, yes please21:30
lifelesssinzui: \o/ - ok, ping me whenever and I'll come to you.21:30
sinzuilifeless, If we can agree that the bug.duplicate column does not scale, that we need a relational table, we can solve a lot of problems once we have the migration script settled21:31
lifelesssinzui: we need to know the answer to questions like 'do we need to search on the relation?' 'is it a tree (A is unique in the set of all existing (A,B) tuples), or a graph (there can be many (A,B) tuples for a given A'21:33
wgrantlifeless: I believe it is not worth rolling back.21:33
lifelessso we're green21:33
rockstarsinzui, I'd assert that this is a problem with CSS: http://ubuntuone.com/p/14Ad/21:33
lifelesswgrant: one of us should hav emailed the list about the status21:34
lifelesswgrant: not saying you or wally specifically, but as a group we dropped the ball21:34
rockstarThe line height is 18px, to make space for the sprite, but then the text is 12px.  At least make it fill the line-height a bit more.21:34
wgrantlifeless: I had failed to notice that the downtime was a day earlier than normal.21:34
wgrantlifeless: So I thought we still had >24 hours.21:34
flacoste    English ▼21:36
flacosteCopyright ©1999-2011 SurveyMonkey21:36
sinzuirockstar, most of Lp sprite issues were solved by the CWG's normalised font/line-height rules. Lp's sizes were impossible to predict using YUI-font21:37
rockstarsinzui, I guess I'm still unclear as to whether or not this is a known bug or a "this is acting as advertised and if you have a problem with it, tough"21:38
sinzuirockstar, I believe there are a few places trying to make the text very small in Lp. I changed the rules to ensure they could never be less than 10px. I am not sure any text other than the footer should ever be smaller than the base font.21:38
sinzuirockstar, it is not a bug. It is by design21:39
=== salgado is now known as salgado-afk
lifelesswgrant: I mean a status update, not a conclusion21:39
lifelesswgrant: we left everyone hanging not sure21:39
lifelesswgrant: and not sure if they should be not sure21:39
rockstarsinzui, so it's going to be left like that?21:39
lifelessrockstar: unless the canonical design department change the rules, or we make a case for not following the rules21:40
flacosterockstar: for the moment yes21:40
lifelessrockstar: we believe they are doing a review now, so there is little point making a specific case right now21:40
sinzuiYou sample page was reviewed two weeks ago and it needs a redesign. When that page knows it is working with a temporary or permanent branch, the repetitive and odd heading, list, actions will be gone21:41
flacosterockstar: we are working on a visual refresh of Launchpad, I'll let huwshimi know about the font issue21:41
rockstarOkay, so I guess the take-away is that I need to STFU for a few weeks and let things wiggle out.21:42
sinzuiflacoste, huwshimi discussed the WAI+font-size issue with me 4 weeks ago.21:42
rockstarAm I correct here?21:43
flacosterockstar: might be a few months unfortunately :-)21:43
flacosterockstar: you have a too big monitor anyway :-)21:43
rockstarflacoste, okay, as long as there's an acknowledgement that we're not "done" yet.21:43
flacosteget a normal size screen like the rest of us21:43
flacostewho needs more than 12"!21:43
wgrantThis hasn't changed in months, anyway.21:43
rockstarwgrant, maybe my cache just got cleared then, because it wasn't like this yesterday when I submitted my branches for review.21:44
sinzuirockstar, the fonts *are* done. The rules for the fonts *may not* be done. The refresh id the opportunity to get CWG revised21:44
lifelessflacoste: my new monitor - 24" 1080p :P21:45
lifelessflacoste: and I know poolie has larger :>21:45
* rockstar highfives lifeless 21:45
flacosteyou damn gamers!21:45
pooliemines' 2721:46
rockstarsinzui, okay, let me just register my opinion as "No call to action should ever be that small"21:46
flacoste27" that's bigger than my TV21:46
sinzuirockstar, exactly!21:46
poolieah canada :)21:46
rockstarpoolie, I have 2 23" monitors, does that mean I win?21:46
pooliei'm thinking about retiring the smallest one and going to the largest dell model21:46
poolieonly if you have two heads21:46
rockstarsinzui, okay, you agree, so I'll STFU and go back to work.21:46
pooliei can not get used to having a gap in the middle of my visual field21:46
pooliethough you do win from having a standing desk21:46
rockstarYeah, I was trying to think of a condescending way to let you know I'm still in the standing desk club, so obviously better than you.  :)21:47
lifelesspoolie: smallest one ?21:48
wgrantrockstar: Are you sure you didn't zoom out or something?21:49
poolieS has my old 24in21:49
rockstarwgrant, positive.21:49
poolierockstar: i stood up with my laptop on a bar yesterday21:50
pooliethat was pretty good21:50
pooliemay take some getting used to21:50
rockstarpoolie, it certainly does.  Once you get used to it, you'll need to pick up barefoot running.  That's the next step in being condescendingly forward thinking.  :)21:50
wgrantrockstar: The last font size changes were made at the start of March.21:51
wgrantrockstar: And there have been none at all for at least a month.21:51
wgrants/last/last significant/21:51
lifelesswe did reset the session db over night21:51
rockstarYes, and I did have to log back in.21:51
lifelesswhich also should have been announced - we've users affected by it21:51
wgrantWith spectacular side-effects, but this shouldn't be one of them.21:51
lifelessnever say shouldn't ;)21:52
wgrantlifeless: It was also entirely avoidable.21:52
wgrantIt would have taken roughly 120 seconds to copy the contents of the DB over.21:52
rockstarI sent a branch page example out to others who all agree it's too small, so it's not just me.21:53
wgrantrockstar: A page, or a screenshot?21:53
rockstarwgrant, page.21:53
flacosterockstar: standing desk is so passé, the future is threadmill desk!21:54
flacostewhich you should obviously use barefoot :-p21:54
rockstarflacoste, threadmill? Like, multiple treadmills with some mutex?21:54
flacosterockstar: ask gary for some pictures :-)21:55
wgrantlifeless: Did you see my txlongpoll deployment proposal?22:40
lifelessbuildout.cfg? sure, I don't care particularly how its done.22:41
lifelessIt will still be rsync based22:41
wgrantI'm wondering how we should approach OOPS integration in general.22:43
wgrantSince we really don't want to force *oops into every upstream project we come across..22:43
lifelesssure we do22:43
lifelesscatchall exception handler for most stacks is doable22:43
lifelessI looked at using wsgi-oops but its *sob* a namespace package, doesn't selftest for me, and has all sorts of unrelated stuff (like storm glue) in it.22:44
wgrantMaybe we can inject into sitecustomize or something.22:44
lifelessits a http stack specific thing22:45
lifelesswsgi being one stack, twistd anther22:45
lifelesstwisted another22:45
lifelessjava and scala containers have analagous concepts22:45
lifelessits a small amount of work compared to manually checking log files22:45
lifelesswallyworld_: hi22:46
wallyworld_lifeless: hello22:50
lifelesswallyworld_: I'm curious why in https://code.launchpad.net/~wallyworld/launchpad/private-branch-unsubscribe-283167/+merge/67651 owner members cannot unsubscribe people ?22:52
wallyworld_lifeless: i thought that it would be too permissive22:52
wallyworld_but i can change it22:53
lifelesswallyworld_: its inconsistent with what owner means elsewhere22:53
wallyworld_ok. i'll fix it22:53
wallyworld_np. thanks for pointing it out22:53
lifelessno worries22:53
lifelessits really awesome we're polishing so many privacy related things22:54
wallyworld_there's a *lot* more to do22:54
wallyworld_one step at a time22:54
sinzuiStevenK, mumble?23:02
cjwatsonphew.  finally have dpkg-xz-support working, with a combination of lucid-proposed, mvo's PPA, and a further python-apt change of my own23:07
cjwatson(the last not in oneiric yet ...)23:07
wgrantcjwatson: Excellent. How much work is this going to be to backport?23:18
cjwatsonwgrant: I've just sent mail about that23:28
cjwatsonwe might as well deal with this and the LongDescription configuration work at the same time23:29
cjwatsonLP machines pull from lucid-updates, don't they?23:30
lifelesspossibly, same as other dc machines23:31
wgrantI believe they do.23:32
sinzuiStevenK, http://pypi.python.org/pypi/zope.formlib23:32
cjwatsonthe xz support will go there (min delay a week from when mvo processes my mail, though); not sure about the LongDescription change, we might ask that that go into the LP PPA instead23:33
cjwatsonbut mvo's already backported it23:33
cjwatsonif we do that in a PPA, the xz support will have to be merged into it23:34
StevenKwallyworld_: Seriously, your microphone sounds like a *kettle*23:54
wallyworld_StevenK: i was muted for most of the time unless i wa speaking23:55
wgrantNo, it's a sonic screwdriver.23:55
wallyworld_wgrant: did you raise a bug to fix the person picker wording issues?23:56
wgrantNot yet.23:58
wgrantlifeless: Are we out of RC yet?23:58
lifelessask losa; I requested it a while back23:58
=== Ursinha-lunch is now known as Ursinha
wgrantLOSA pingaling23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!