=== poolie_ is now known as poolie
=== cparrino is now known as cparrino-QBR
karniHello ubuntuone!10:07
faganHeya karni10:07
facundobatistaHola karni, fagan10:54
facundobatistaBuen día!10:54
faganhey facundobatista10:55
karniHello facundobatista , fagan10:55
karnifacundobatista: Tutu bien (I probably failed miserably)10:55
facundobatistakarni, "all" is "todo"10:55
facundobatistakarni, "todo bien" :)10:55
karnifacundobatista: todo bien!! \o/10:55
fagantodo :)10:55
duanedesignmorning all10:58
facundobatistaHola duanedesign11:11
faganralsina: hey11:17
* fagan break11:27
* mandel present11:28
ralsinahi mandel!11:42
mandelralsina: buenas!11:46
mandelralsina: so, in 5 min we have the encoding fixed :)11:46
mandelralsina: I just need to run the tests on linux11:46
mandelralsina: nothing like a day of not thinking about a problem to get it fixed11:47
mandelralsina: did you get my email about mumble + standup and report?11:47
ralsinamandel: got it11:48
mandelralsina: does it make sense what I say?11:49
ralsinain your case, the separation between the mumble and EOD is too small11:49
mandelralsina: exactly, and standup is more or less the exact same thing...11:49
ralsinaso the three are closer than for us. About mumble, I am trying to make them much shorter (about 15 minutes)11:50
mandelralsina: yeah, that is another thing… an hour which is more or less what we have done does not make sense… we end up talking about everything and about nothing11:51
ralsinayes 1 hour is way too long11:52
duanedesignanyone speak Portuguese?12:02
adorilsonduanedesign: I'm12:03
adorilsonI means I'm brazilian12:03
duanedesignadorilson: thank you, I think i got it :)12:07
duanedesignadorilson: I had an email in Portuguese and was trying to determine if it was spam or not. It was spam :\12:08
adorilsonduanedesign: :-/12:11
mandelralsina: killer branch https://code.launchpad.net/~mandel/ubuntuone-client/pyinotify-non-unicode/+merge/6795512:25
duanedesignrye: do you have a moment to help me with a syncdaemon.log?12:25
ryeduanedesign, sure, i am going through my tickets so need to tune in12:25
mandelralsina: it solves lots of bugs because they all had the same root :P12:26
ryeduanedesign, shoot (as nessita says :) )12:26
ralsinamandel: \o/12:26
duanedesignrye: https://pastebin.canonical.com/49735/12:27
duanedesignrye: I had never seen that many failure: Connection to the other side was lost in a non-clean fashion before12:28
mandelralsina: we will need to go through the bugs and close them accordingly, I think there are some more closed but I'm not 100% sure12:28
ralsinamandel: you have a print in there12:28
ralsinaline 19 of the diff (I do that all the time too :-)12:29
ryeduanedesign, i have never seen any such kind of warnings... facundobatista, ping - https://pastebin.canonical.com/49735/ - it shows lots of Unlink warnings with "Connection to the other side was lost in a non-clean fashion before" - how does this happen (i thought if connection fails we just halt the queues and reconnect)12:30
ralsinajoder, me ha quedado el reporte en drafts?12:30
ryefacundobatista, this is 11.0412:30
facundobatistarye, they're normal if the command fails, tells you why it failed (in this case, a disconnection)12:31
facundobatistarye, OTOH, Unlinks are normally fast, so you really need to throw a lot of them and disconnect in the exact moment to see a lot of warnings there12:32
mandelfacundobatista: please tell a look at this: https://code.launchpad.net/~mandel/ubuntuone-client/pyinotify-non-unicode/+merge/6795512:32
ralsinamandel, after you finish linking bugs, maybe I can get a review of https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/6789412:32
mandelfacundobatista: fixes the encoding stuff12:33
mandelralsina: sure, although I dont know if I'll have time, I'm been here since 8:45 :P12:33
ralsinamandel: nevermind12:33
ryefacundobatista, aha, so this is the part where the user has asked to disconnect12:33
ralsinamandel: I can get a review later, it's ok12:33
mandelralsina: I'm done with the bugs12:34
ralsinadamn, launchpad logged me out again12:34
mandelor at least all I know about, so Ill take a look now12:34
adorilsonduanedesign: how U1 cliente uses the apt ?12:35
ralsinamandel: I am adding test instructions IRL, and since it involves having ussoc import a module from the installer they are necessary,sorry12:35
mandelralsina: first question, why does the bin/ubuntuone-installer-qt use the defaul reactor from twisted?12:35
ralsinamandel: why not? It only needs to send a few messages to ussoc, which does the rest.12:36
ralsinamandel: it's almost the same as show_gui, but with a custom ui12:36
mandelralsina: so, you send the message and how do you show the UI from the isntaller?12:37
mandelthat bin does not need a QApplication?12:37
ralsinamandel: no, it doesn't12:37
facundobatistamandel, ok12:37
ralsinamandel: ussoc imports a custom UI and displays it12:37
ralsinamandel: and that's the installer. In a way, it's a *huge* code injection :-)12:38
mandelralsina: ah, ok, s you provide ussoc the ui class and it takes care of it, smart..12:38
ralsinamandel: and makes things a lot simpler on the installer's side, even if it feels very weird12:39
faganralsina: do you have any tasks that are intern sized at the moment. I had a look at the bug list this morning for some inspiration but not much jumped out.12:39
ralsinafagan: yes!12:39
ryeduanedesign, so, the part of the logs we have is only the last one, that is just before disconnection. We don't know why he has disconnected12:39
faganralsina: cool12:39
ryeduanedesign, this is US#3057, right?12:39
ralsinafagan: I need you to test this on XP: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/6791112:39
ralsinafagan: much improved version of the bundle script12:39
mandelralsina: makes sense, I think I'm done with the code review, have you written the instructions?12:39
ralsinafagan: then setupa clean XP (just install it) and try the generated installer12:40
ralsinamandel: almost there12:40
faganralsina: cool will do12:40
ralsinamandel: there they are. This one is actually easier to test using a bundle, the imports are a bit dense ;-)12:41
duanedesignrye: yes12:42
duanedesignrye: i looked through all of them and does not seem to have been captured (why he has disconnected)12:43
* ralsina is going to be sorry to say this, but that branch has enough tests that nessita can't complain about it12:44
ryeduanedesign, ok, all my logs are being kept for an indefinite period...12:44
mandelralsina: ok12:44
nessitahello everyone!12:44
ralsinahello nessita!12:45
ryeralsina, assertEqual(this.__doc__, "This is a function description") ?12:45
duanedesignadorilson: I think to install Bindwood, the bookmark sync extension12:45
ralsinanessita, I had the report written last night andI have proof that it got stuck in drafts: http://www.screencast.com/t/CXZyzZmXa12:46
ralsinarye: damn, missed that one!12:46
nessitaralsina: :-)12:46
ryeduanedesign, so, [logging] ... file_size = 0 - that will keep all the files, however what I think is happening is that due to a massive amount of files to sync SD does not keep up with dbus requests, which makes it look like it is not doing anything12:46
ralsinaAnd nessita: a branch that I am almst sure you will not have issues with: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/6789412:47
nessitaralsina: so, we need to talk a bit more, last night before sleep I spent some time thinking in what we talked about yesterday, and I realized a couple of issues12:47
nessitamandel: are you staying for the stand up and the daily call?12:48
ralsinanessita: ok, but I can't do voice calls yet (kid asleep next door)12:48
adorilsonduanedesign: then it runs something seems "apt-get install bindwood" ?12:49
mandelnessita: yes12:49
ralsinamandel, alecu,nessita, dobey, fagan: standup in 10'12:50
ralsinaAnd DiegoSarmentero has finished his contract, but he's invited ;-)12:50
DiegoSarmenteroralsina, thanks12:53
faganhola alecu12:55
* fagan does know some spanish :)12:56
alecuDia is Muire dhuit, fagan12:56
faganalecu: very good :)12:57
duanedesignadorilson: i think that is correct. "gksudo apt-get...."12:57
* alecu knows no irish at all :-) http://wikitravel.org/en/Irish_phrasebook12:57
faganI learned about the word todo in spanish this morning12:57
faganalecu: yeah it actually  means god and mary abe with you12:58
faganbut thats how we say hello12:58
faganor respond to saying hello in that case12:58
faganIrish is such an interesting language when you start translating it12:59
alecufagan, right :-). And I'm impressed about "Conas atá tú?"12:59
ralsinafagan: how catholic!12:59
faganralsina: yeah I know12:59
alecufagan, it sounds just like in spanish: "Cómo estás tu"12:59
ralsinahere, old coutry people used to say hi saying "good and holy!" so...12:59
faganalecu: yeah the language is kinda half english half latin and half some other weird nordic languages13:00
nessita DONE: bug #809363, started with bug #810100 and bug #81044013:01
nessitaTODO: finish those bugs, careful review to mandel's encoding branch, IRL test od that branch13:01
nessitaBLOCKED: I'm having serious connectivity issues, looking for alternatives ATM13:01
nessitaNEXT: fagan13:01
ubot4Launchpad bug 809363 in ubuntuone-control-panel "FileSyncStatus needs to be updated to the current design (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/80936313:01
ubot4Launchpad bug 810100 in ubuntuone-control-panel "Windows: Folder display name is ugly (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/81010013:01
fagan* bundled the dist folder with the exes and gave it to ralsina.13:01
fagan* went looking for some bugs (didnt find any within my range)13:01
fagan* test ralsina's installer branch13:01
ubot4Launchpad bug 810440 in ubuntuone-control-panel "QT UI: 'explore' button is too wide and looks ugly (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/81044013:01
fagan* no13:01
faganralsina:  go13:01
faganwhoops that was a little bit early :)13:01
ralsinaDONE: proposed branches for bug #809873, bug #810053, closed bug #81009613:01
ralsinaTODO: signed urls, embed webkit, bug #80037613:01
ralsinaBLOCKED: no13:01
ubot4Launchpad bug 809873 in ubuntuone-windows-installer "Add a script to create a bundle and installer for all the related software (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/80987313:01
ralsinanext DiegoSarmentero13:01
ubot4Launchpad bug 810053 in ubuntuone-windows-installer "Credentials obtained by the installer don't work. (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/81005313:01
ubot4Launchpad bug 810096 in ubuntu-sso-client "The windows port doesn't expose the ui_module parameter of login_or_register_to_get_credentials (affects: 1) (heat: 6)" [Undecided,Fix committed] https://launchpad.net/bugs/81009613:01
ubot4Launchpad bug 800376 in ubuntuone-windows-installer "Add "syncing your computer to the cloud" page to the installer (affects: 1) (heat: 9)" [Undecided,In progress] https://launchpad.net/bugs/80037613:01
DiegoSarmenteroU1 Windows Installer UI complete (Waiting for review). Tests for U1 installer ui improved.13:01
DiegoSarmenteroFix issues in UI if necessary.13:01
DiegoSarmenteromandel, go13:01
mandelDONE: Rested, though about encoding and fixed the bloody bug!!! Canonical HR (I forgot to do my objectives, ups!)13:02
mandelTODO: Look at local_rescan, there are tests failing but are easy to fix, a diff event is raised from the fs on windows.13:02
mandelBLOCKED: not that much anymore13:02
mandeldobey, go13:02
dobeyλ DONE: took stock of duplicate assets, discussed bzr locking, more issues in #809561 to fix13:02
dobeyλ TODO: finish bug #809561, start the shim13:02
ubot4Launchpad bug 809561 in ubuntuone-dev-tools "Support ignoring paths in u1lint (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/80956113:02
dobeyλ BLCK: None.13:02
alecuDONE: landed fix for bug #806539; started working on bug #80665513:02
alecuTODO: finish branch for second bug13:02
alecuBLOCKED: no13:02
ubot4Launchpad bug 806539 in ubuntuone-client (and 1 other project) "Cleanup API to connect to services (affects: 1) (dups: 1) (heat: 12)" [Medium,Fix committed] https://launchpad.net/bugs/80653913:02
ubot4Launchpad bug 806655 in ubuntuone-control-panel (and 1 other project) "Windows: SyncDaemonTool should provide a way of registering a callback for status changed notifications (affects: 1) (heat: 56)" [High,Triaged] https://launchpad.net/bugs/80665513:02
ralsinano comments?13:03
* ralsina waits the regulation 30 seconds13:03
dobeyi've always got comments13:03
dobeybut i also have restraint13:03
ralsinadobey: no you don't :-)13:03
mandelalecu, ralsina, nessita I'd like as many revies as possible for https://code.launchpad.net/~mandel/ubuntuone-client/pyinotify-non-unicode/+merge/6795513:03
* mandel lunch13:03
ralsinamandel: working on it13:03
dobeyralsina: no comments? or restraint?13:04
ralsinadobey: restraint?13:04
nessitaralsina, alecu, mandel, Chipaca`: I left my home early this morning hunting for internet and I forgot my headset, so, 2 things: 1- I'd need (please) to have the meting thru skype, and 2- I'd need (please) to have it earlier than usual so I can use the laptop's mic and speakers and do not overlap with the meting of my "office mate", if possible13:04
ralsinadobey: OTOH, if you do, I am more impressed13:04
ralsinanessita: mandel just left for lunch13:05
nessitaralsina: oh, I see13:05
nessitaI typed too slow :-)13:05
dobeyi do. :)13:05
nessitaralsina: ok, I can grab the laptop and walk around when we have the meeting13:05
Chipaca`nessita: skype, and we call you on your cell?13:05
nessitaso I guess that...13:05
ralsinaChipaca` nessita: +1 for that13:06
nessitaChipaca`: sounds expensive! :-) I can walk away from Matias and use the laptop's mic and speakers13:06
Chipaca`nah, it's not13:06
ralsinaBTW, Chipaca` you are not Chipaca's derivative, your apostrophe is the wrong one!13:06
ralsinanessita: if there is a fixed phone it works better and is very cheap13:07
nessitaralsina, Chipaca`: *thanks*. But let's try the cheap option first, if it does not work, let's go with the cell13:07
nessitathere is!13:07
ralsinaThen it's 2 cents a minute :-)13:07
nessitaok, then... meeting a las y 45 :-)13:07
ralsinawhich is why calling land lines using skype from my cellphone is cheaper than calling with my phone.13:08
dobeyi thought skype call-out pricing was based exponentially on time used13:08
nessitaralsina: let me know when you can talk, and I share what I was thinking last night re sso + wizard13:08
ralsinanessita: I will close the door andcall you13:08
nessitaralsina: no rush on my end13:09
ralsinanessita: and I was so happy I had it working (with tests too!)  ;-)13:09
Chipaca`ralsina: note skype also has a per-call cost as well as the per-minute cost13:09
nessitaralsina: is not your code, is the sso design that may misbehave13:09
=== Chipaca` is now known as Chipaca
dobeyprice = 0.0001 * minutes^2 + 4213:10
=== m_conley_away is now known as m_conley
adorilsonduanedesign: ok. We have a yum version from file http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-control-panel/trunk/view/head:/ubuntuone/controlpanel/gui/gtk/package_manager.py13:14
mandelnessita, ralsina, alecu: mumble?13:43
nessitamandel: skype this time13:44
nessitamandel: can you please join skype?13:44
mandelnessita: ok, on it13:44
joshuahooverfagan: ping13:46
alecunessita, mandel: skype is on.13:46
mandelmine too13:47
nessitaChipaca: can you start the conference?13:47
Chipacanessita: yus13:47
Chipacanessita: PM me your cell please13:47
nessitaChipaca: try my skype first,13:48
nessitaI'm already in the yard13:48
nessitais sunny today!13:49
dobeywatch out for coronal mass ejections13:49
faganjoshuahoover: pong13:55
ralsinaChipaca: just checking, tom means tom haddon?14:35
* ralsina sucks at names14:35
Chipacaralsina: yes14:41
Chipacaralsina: and yes14:41
dobeynessita: https://code.launchpad.net/~dobey/ubuntuone-dev-tools/lint-ignores/+merge/67758 does work now, if you can re-review please :)14:45
nessitadobey: sure!14:46
nessitaralsina: will you please remind me the 2 branches that need your review?14:46
ralsinathat need my review?14:46
nessitaralsina: sorry, I meant, that need my review :-D14:47
ralsinahehe, https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/67894 https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/6791114:47
ralsinaThe second one is probably not for you :-)14:47
dobeylas chicharras es fuerte14:48
ralsinadobey: "son fuertes" if you mean cicadas are buff14:48
ralsina"están fuertes" if you mean they are loud14:49
* ralsina hopes for the second, but is willing to accept our new cicadan overlords14:49
nessitaralsina: "están fuertes" means they are hot! :-)14:51
ralsinanessita: that too :-)14:52
dobeyralsina: http://half-life.wikia.com/wiki/Animal_King14:52
ralsinanessita: I am pretty sure this is a typo, right? http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/windows/ipc.py#L29614:53
ralsinaAlso on line 30114:54
nessitaralsina: yes sir, typo + lack of tests it seems14:54
ralsinaBoth or just the one in 296?14:55
nessitaralsina: I don't know, mandel can answer, or you can look at the spec of the class, what signals it promises to throw14:56
ralsinaok, will check14:56
ralsinaI'll assign to Manuel. AFAICS those signal names or the "corrected" ones are never used anywhere in our code (says grep)14:59
dobeyalright. time to get some lunch. bbiab15:16
alecunessita, ralsina: there is some styling issue when clicking on buttons in the control panel, because there's no visible change in the button while it's "pressed".15:19
nessitaalecu: yes, I saw that too15:20
nessitaalecu: can you please file a bug?15:20
alecunessita, surely!15:20
alecunessita, bug #81054315:22
ubot4Launchpad bug 810543 in ubuntuone-control-panel "Style does not change while buttons are pressed (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/81054315:22
DiegoSarmenteronessita, hi! did you have the chance to review my branch for u1 windows installer?15:23
alecunessita, should I assign it to DiegoSarmentero?15:23
alecuDiegoSarmentero, you may want to take a look at this bug ^15:23
nessitaDiegoSarmentero: not yet15:23
nessitaalecu: yes please, we'll see if he can fix it if not we'll seek alternatives15:24
nessitaralsina: question re your fix-810053 branch15:25
ralsinanessita: sure15:25
DiegoSarmenteronessita, alecu yes, i'm taking a look at that bug right now15:26
alecuDiegoSarmentero, thanks!15:26
nessitaralsina: I see you removed some constant imports but not all, APP_NAME and TC_URL are still there. What are we using those in the wizard?15:26
DiegoSarmenteroalecu, question: is there any image how the button should looks like when it is pressed?15:27
DiegoSarmenteroalecu, just to know if there is any special specification about that15:28
alecuDiegoSarmentero, I don't know. nessita do you have any idea? ^15:29
DiegoSarmenteronessita, alecu, or maybe I can use the same as hover... what do you think?15:29
ralsinanessita: SSO expects the SSOGui.view to have them15:30
alecuDiegoSarmentero, probably we should darken a bit the buttons, like the default windows 7 theme does... But I don't know for sure, we may ask lisette as well.15:30
aleculisette, ping15:30
ralsinanessita: in other words, if I remove those two, I get an exception about them being missing15:30
DiegoSarmenteroalecu, ok, i'll do it darken a bit the buttons, let me know if this change15:31
aleculisette, is there a design for the "pressed" state of buttons in the control panel? This is so the user gets visual feedback while a button is being pressed.15:31
lisettealecu: no, not one that I did. Are you using Ubuntu buttons?15:32
aleculisette, we are using the orange Qt buttons in the windows control panel.15:33
aleculisette, and they get a bit lighter orange color when they are hovered.15:34
aleculisette, but it would be useful to have them a "different color" or "a different shading" or even "move the text a few pixels down and right" while they are clicked15:35
lisettealecu: so there is no click status in those buttons?15:35
nessitaalecu: I have no design for that, so asking lisette is the best option :-)15:35
nessitaralsina: oh! k15:36
aleculisette, sorry, don't understand about "click status". Do you mean "click feedback" ?15:36
aleculisette, I was just wondering if there's any design for that, or if we should just "darken" like the default windows 7 theme.15:36
aleculisette, let me rephrase...15:37
lisettealecu: no there is no design for that, because we were going to use buttons exactly as they appear in Ubuntu15:37
aleculisette, oh, ok.15:37
lisettealecu: do you know what the behaviour of buttons in Ubuntu is?15:37
aleculisette, I think the current buttons in ubuntu are a very different shade of orange, but let me check.15:38
=== rodrigo__ is now known as rodrigo_
lisettealecu: hmm. I assumed we´d use Ubuntu buttons, and this is why I haven´t specced or cropped any button backgrounds. but I can have a look at it now. If so, do you know hex values / have image backgrounds for the hover state?15:40
nessitalisette: I'm trying to follow the conversation but I'm a bit lost :-) What does it mean that you use Ubuntu buttons if this design is for windows?15:42
DiegoSarmenterolisette, i don't know if the hex values for the hover state are the correct ones right now, when you hover over a button you can see it brighter15:42
aleculisette, I'm looking at ubuntu buttons in natty, and they are usually gray, only "default" buttons appear orange. (default button is the one that's activated when you press <Enter>)15:42
aleculisette, also, buttons in ubuntu use dark font, but the current control panel buttons use white font.15:43
aleculisette, also, the buttons in ubuntu "move the text to the right and down" when clicked; standard windows 7 buttons "darken the button" when clicked.15:43
lisettealecu: i will have to discuss this with the team and get back to you15:44
aleculisette, sure! for now, I'll ask DiegoSarmentero to just make the button darker when they are clicked, so the user gets some feedback when they are clicked.15:45
alecuDiegoSarmentero, is that ok?15:45
DiegoSarmenteroalecu, yep!15:46
lisettealecu, DiegoSarmentero: cool15:46
* DiegoSarmentero is away: Not here... send me an e-mail! :P15:48
ralsinanessita: correct way to get the credentials in controlpanel is ubuntuone.controlpanel.login_client.get_credentials()?15:48
nessitaralsina: yessir!15:49
nessitaralsina: that will not popup anything15:49
ralsinaand that's a deferred15:49
ralsinanessita: it's ok, don't want it to :-)15:49
nessitawill return {} or the credentials when the deferred is fired15:49
ralsinanessita: ok, thanks15:52
ralsinaI feel like an ignrant, but why is this returning a deferred instead of a value?http://pastebin.ubuntu.com/644202/15:54
ralsinaalecu, nessita ^15:54
nessitaralsina: looking15:55
nessitacredentials = yield get_credentials()15:55
nessitathat can block15:55
nessitaget_credentials() returns a deferred, yielding on it make sthe main loop "advance" until the deferred is fired15:56
dobeyralsina: because the yield + inlineCallbacks makes it a generator that returns a deferred15:56
nessitaralsina: is that makes you see the light, yey, if not, I can explain further15:56
ralsinanessita: I meant the whole sign_url returns one15:56
dobeyralsina: yes, because of what i said :)15:57
ralsinaso I suppose I need some remedial deferred teaching again :-(15:57
nessitaralsina: becasue in its implementation you're yielding over a method that returns a deferred15:57
lisettealecu, DiegoSarmentero: making the button darker (instead of moving it) is cool with all of us here; I will have a look at hex values for over and hit.15:57
ralsinanessita: ok, makes sense15:57
dobeyralsina: using yield inside a function makes that function a generator15:57
nessitaralsina: and you're decorating the method with inlineCallbacks, that, like dobey says, makes the method return a deferred15:57
dobeyinlineCallbacks loops through the list, and returns the deferreds15:58
aleculisette, great, thanks!15:58
ralsinanessita, dobey: ok, I think I got it now, thanks for your patience15:58
dobeyralsina: no problem. it was just as confusing as when i had to have tcole explain it to me in regards to the test cases :)16:00
ralsinaI don't think I get how to actually *do* what I want but I'll probably figure it out ;-)16:01
alecuralsina, just call the method, it will return a deferred.16:01
ralsinaalecu: yes, and then?16:01
alecuralsina, then .addCallback() and .addErrback() with two functions that you want to be called.16:01
ralsinaI need to check the return value, so how do I wait on it?16:01
dobeyralsina: i think you need to add a callback16:01
ralsinaok, yikes, complicated tests16:02
ralsinacallbacks was what I was avoiding :-)16:02
ralsinabut it's ok, let's do that16:02
alecuralsina, you won't be able to avoid callbacks as long as get_credentials is async...16:03
alecuralsina, there are no other bits in that function that are async16:03
nessitache ralsina, can you please remove "print "creds found", args" from the 'found' callback?16:03
ralsinanessita: sure16:03
ralsinanessita: damn, I had hopes for that branch to go without needsfixingseseses16:04
alecuralsina, so you may get away with "passing" the credentials to that function, and avoiding the deferreds in the signing function.16:04
=== beuno is now known as beuno-lunch
nessitaralsina: regarding tests and deferreds, they are amazing once you understand them. You can try proposing some code and we can give you the "enhanced" version of it, and that way I'm sure you will get an idea16:04
ralsinanessita: ok, will have that in a few minutes16:05
nessitaralsina: or what alecu says, too, but I'm not sure you have the credentials before calling that function16:05
ralsinano, I don't16:05
ralsinaSo callbacks16:05
alecuralsina, well, separating the "getting the credentials" from the "signing stuff" makes for simpler tests anyway,.16:06
ralsinaalecu: yes, but then everywhere I call this I have to get the credentials first. It's easier to test but harder to use16:06
alecuralsina, and +1 to nessita's "amazing" comment. Make sure to look at some other tests that are testing similar code.16:06
ralsinaalecu: any suggestions?16:07
alecuralsina, any function in sso that has at least a yield on it :-)16:08
ralsinaalecu: ok16:08
nessitaralsina: or, look at pretty much any test in test_backend.py in the controlpanel16:09
mandelralsina: ping16:09
ralsinamandel: pong16:09
ralsinanessita, alecu: cool, thx16:09
nessitamandel: hey there!16:09
mandelralsina: so when is the sprint?16:09
mandelnessita: hola :)16:09
mandelnessita: I'm staring the split fo rthe branch right now, I found a internetcafe :)16:10
nessitamandel: while you work on splitting the big encoding branch, please check out some comments that facundo added since he already made a eye-code-review over that branch16:10
ralsinamandel: not next week16:10
nessitamandel: so you can apply the fixes while splitting, and save some roundtrip time :-)16:10
mandelnessita: cool :)16:10
alecunessita, do we plan to make the "username" field editable in the control panel?16:11
alecunessita, do we even have a webservice call for that?16:11
mandelralsina: can you tell me when asap, flight tickets are a hard thing to get16:11
nessitaalecu: nopes, we can't edit user info16:11
ralsinamandel: should know later today, early tomorrow16:11
nessitaalecu: we should make those fields not to be text entries, actually, I'm waiting for some feedback from blajk16:12
nessitaalecu: and we may even remove that tab altogether16:12
alecunessita, cool.16:12
nessitaralsina: what did you agree with clarita re: web page for services tab?16:13
nessita(if any agreement happened)16:13
dobeyis there some way we can avoid having binaries stored in bzr?16:13
mandelralsina: ok, if you send me a tweet I'l start moving16:13
ralsinanessita: the agreement was that it will happen, and she's not thrilled by it, but it's what we can do16:13
alecunessita, your latest mail seems to suggest otherwise: "Yes in the sense that we have no plans to change that."16:13
ralsinamandel: moving to argentina? ;-)16:13
alecunessita, I read that we'll keep the text entries16:13
mandelralsina: mocing to get a flight ticket, the other thing will take longer :P16:14
nessitaalecu: hem... I meant we have no plans to change it as in we have no bug nor task for that16:14
ralsinamandel: you are a mommy's boy ;-)16:14
nessitaalecu: I can see how that can be read differently16:14
mandelralsina: she is a spaniard, remember hehe16:14
nessitaalecu: I will clarify, thanks for pointing that out16:15
alecunessita, no problem16:15
blajknessita, alecu, I write you an email right now!16:17
alecublajk, cool, thanks!16:18
* alecu goes to have lunch, and then to the bank.16:18
=== alecu is now known as alecu-lunch
nessitablajk: oh, I just send a carification :-)16:18
dobeyralsina: is there no good way to do PNG generation from a big SVG, on windows, for icons/etc?16:22
ralsinadobey: well, install inkscape for windows and write a .bat I suppose16:23
dobeyi am not porting icontool to .bat :)16:23
dobeyhow are we doing icons on windows anyway? just loading specific ones off disk from a specific location?16:24
nessitaralsina: another request: can you please replace self.assertEqual(isinstance(self.ui.view, FakeMainWindow), True) by16:25
nessitaself.assertIIinstance(self.ui.view, FakeMainWindow)16:26
nessitaself.assertIsIinstance(self.ui.view, FakeMainWindow)16:26
ralsinanessita: sure, didn't know that one16:26
nessitaralsina: :-)16:27
facundobatistaralsina, is new for me too16:27
nessitafacundobatista: because of my bad typing? :-)16:28
dobeyralsina: also, assertTrue is better than assertEqual(foo, True) :)16:28
nessitaralsina: jic, correct method name is self.assertIsInstance(self.ui.view, FakeMainWindow)16:28
nessitaralsina: and what dobey says as well16:28
facundobatistanessita, no, I mean, the real name16:28
ralsinadobey: I prefer small APIs instead of a new methd for every kind of comparison, but that's just personal taste16:28
dobeyralsina: "assert foo" :)16:29
nessitaralsina: that's not-pythonic. If you need to choose between 2 APIs:16:29
nessitayou should alays go with the second16:30
dobeyneither of those are pythonic16:30
nessitaeven if for the implementation you use an internal _set_foo16:30
dobey@property ftw16:30
ralsinanessita: in that case there are only 2 methods, there are an infinity of possible assert* methods :-)16:30
nessitadobey: it was an example16:30
nessitadobey: and yes, @property FTW16:30
dobeyjust saying :)16:30
dobey@property makes it a single API point, that abstracts those two away :)16:30
dobeyralsina: well, it's better than writing a lambda every time, to get the result down to true or false to do an assert on :)16:31
dobeyduplicate code FTL16:32
ralsinanessita: there are some huge test failures in that branch so hold it a bit (I swear I tested this last night :-( )16:32
nessitaralsina: np16:32
=== beuno-lunch is now known as beuno
ralsinanessita: ok, and lunchtime, too16:33
nessitaralsina: and lunchtime here too16:33
ralsinaSo I'll ping you when it's ready16:34
nessitaralsina: please16:34
nessitathough I have tons to do, so no rush :-P16:34
ralsinaOh, cool, deleting oneline fies 24 tests ;-)16:34
dobeynessita: did you get to look at my branch again? :)16:56
dobeyhmm, i should have taken today as holiday too. the weather is too nice outside16:59
* DiegoSarmentero is back (gone 01:14:43)17:03
nessitadobey: not yet, but is in the queue! :-) popping it up right now17:11
=== alecu-lunch is now known as alecu
nessitadobey: is not working that well, I ran ./run-tests and the u1lint was printed instead of the lint report, see17:17
nessitadobey: and, u1lint -i bin/ gives me lint issues in bin/17:18
dobeynessita: did you run u1lint -i bin or bin/u1lint -i bin?17:20
nessitadobey: DOH :-)17:20
dobeyoh i see what the issue is with the pylint output17:24
dobeyi am an idiot again :)17:24
dobeynessita: fixed and pushed17:26
dobeynessita: wb :)17:27
dobeynessita: fixed and pushed the pylint output issue, in case you didn't see17:28
nessitadobey: I didn't, the desktop froze. I tried unity reset in the text terminal with no luck17:29
dobeynessita: no worries. :)17:30
nessitaany idea why the test output is shown twice?17:30
nessita(not related with u1lint I think)17:31
nessitadobey: ^17:33
=== zyga is now known as zyga-afk
nessitadobey: the rest looks good, and works fine now17:35
nessitaso I'll approve17:35
dobeynessita: run-tests is running u1trial twice, once with glib reactor and once with twisted17:36
nessitaralsina, DiegoSarmentero (only if you have spare minutes, no worries otherwise since you're of the hook now): can you please review https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/fix-810440/+merge/67998 ?17:45
DiegoSarmenteronessita, yes, no problem!17:46
nessitaDiegoSarmentero: there is a screenshot attached in case you can't branch that17:46
DiegoSarmenteroyes, i'm watching it17:47
nessitaDiegoSarmentero: any hints about how can I remove the frame borders there? (honestly I made no googling yet, so feel free to send me to do that ;-))17:48
DiegoSarmenteronessita, mmmm it seems to be taking the border from the header... did you try to group those frames in the qss and set the border: none or border-width: 0px; ?17:50
nessitaDiegoSarmentero: that screenshot is using the same qss as the windows one, are you doing that there? :-)17:51
nessitaif not, I will try that17:51
DiegoSarmenteronessita, nop... it was just an idea.... if you want i can give it a try here17:51
nessitaDiegoSarmentero: nono, I can try it17:52
nessitaDiegoSarmentero: I prefer to squeeze your talent when absolutely needed17:52
DiegoSarmenteronessita, jeje ok ok17:52
nessitaralsina, alecu: I just realized we haven't implemented the 'delete this device' functionality, yet!!! I will add that to my queue17:59
DiegoSarmenteronessita, about your review18:00
DiegoSarmenteronessita, about the review of your branch..... i mean18:00
nessitaDiegoSarmentero: tell me18:00
alecunessita, ack with the "delete this device", but priority lower than the rest :-)18:00
nessitaalecu: "rest"?18:01
alecunessita, the rest of stuff we are working on! :-)18:01
DiegoSarmenteronessita, it looks fine by me.... there is just one line that you can delete if you want, because it is unnecessary, but it doesn't affect anyway.... line 9 in the diff: <string notr="true"/>18:01
DiegoSarmenteronessita, +118:01
nessitaalecu: ah!!! I thought we were on vacations already! :-P18:02
* alecu +1s vacations18:02
nessitaDiegoSarmentero: removing that now...18:03
DiegoSarmenteronessita, in fact you can delete the property for "styleSheet" really.... line 7 to 10 in diff18:03
* nessita obeys18:03
DiegoSarmenteronessita, jejee18:03
alecunessita, cparrino owes us vacations on the caribean beaches after this.18:03
nessita(from time to time, do not get used to that :-P)18:03
nessitaalecu: *at least*18:03
DiegoSarmenteronessita, no no.... i wasn't expecting that18:03
ralsinaI'm back sorry about the long lunch!18:04
nessitaralsina: relatives finally arrived? :-)18:05
ralsinanessita: yeah18:06
alecuralsina, http://bit.ly/longest-lunch18:07
nessitaralsina: for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix_809873/+merge/67911, is there any chance that you grab the logging.conf and the syncdaemon.conf from launchpad or a repo? I think is not good to have that duplicated in that project, since those files can be easily changed in u1client trunk18:07
ralsinanessita: I can do that for syncdaemon.conf but logging.conf requires variables18:08
nessitaralsina: hum... the loggin level, right?18:08
nessitaralsina: can't we replace the vriable for the logging level we want for the installer? :-)18:09
ralsinaI could generate it with some obvious code, of course :-)18:09
nessitaso, when releasing betas, we set DEBUG, for finals, INFO18:09
nessitayeah, just a silly 'something'.replace()18:09
ralsinanessita: pushed test fixes on  the bug #810053 branch18:09
ubot4Launchpad bug 810053 in ubuntuone-windows-installer "Credentials obtained by the installer don't work. (affects: 1) (heat: 6)" [Undecided,In progress] https://launchpad.net/bugs/81005318:09
ralsinanessita: ok, will do it now18:09
ralsinanessita, alecu: did any of you try the encodings branch to see if it fixes UDFs / shares?18:11
alecuralsina, not me18:11
nessitaralsina: no, is in my queue18:12
nessitaralsina: I'm waiting for people using this net conn to release it18:12
nessitaralsina: should happen soonish (in the next hour)18:12
ralsinanessita: ok, will wait for it then18:13
nessitaDiegoSarmentero: FYI, all the empty style tags were removed18:14
DiegoSarmenteronessita, nice!! i probably insert some too... when i was trying the styles in the designer... now i double check even the xml :P18:15
nessitaDiegoSarmentero: ;-)18:15
nessitaralsina: did you ever confirmed with design that it was ok to replace frames 18 and 19 with current "preferences" tab from control panel?18:16
ralsinanessita: let me check18:16
ralsinanessita: argh, no I haven't, se me traspapeló18:17
ralsinanessita: will do it by email18:17
dobeyralsina: can you tell me about how our bundle things work on windows?18:17
ralsinadobey: sure18:17
nessitaralsina: ok, I'm just bringing that to your plate again. Mail sounds good.18:18
dobeyralsina: do we build a separate bundle for each project? (sso, cp, client, etc)18:18
ralsinadobey: no, that's extremely inefficient18:18
ralsinadobey: basically if we do that, each bundle will contain lots of duplication (for example, control-panel will have most of syncdaemon and sso in it)18:19
dobeyralsina: oh, we can't make a bundle of just cp without its deps? the bundle has to have everything in it?18:19
ralsinadobey: a bundle with everything is about 30% of the size of bundles for each18:20
ralsinaalso, because of ussoc's design, it needs to see parts of the installer (to make the "replacement ui module" work, so that's not even doable with separate bundles18:20
dobeythat didn't quite answer those two questions :)18:20
dobeyralsina: do we have to pull everything from bzr and build it from branch to bundle it?18:21
ralsinadobey: it's how I did it, to make it reproduceable18:21
* ralsina knows that's probably not a word18:21
ralsinadobey: but if you have trunk branched (or any branch) you just put it in sources/ and it doesn't download anything18:22
nessitaDiegoSarmentero: did you +1 my branch? (I just reloaded and LP seems not to know that if you did)18:22
DiegoSarmenteronessita, ahhhhh i'll do it in the page now :P18:22
dobeyralsina: i'm curious if we can make it pull a tarball/zip file as a means of acquiring source for a couple things, vs pulling from branches18:23
ralsinadobey: sure, it18:23
nessitaralsina: did you got my review request while you were having lunch?18:23
ralsinadobey: sure, it's a python script, it can do anything we want ;-)18:24
ralsinanessita: nope, will get to it in ... 10 minutes18:24
DiegoSarmenteronessita, ready!18:24
DiegoSarmenteronessita, please later if you have a minute review my branch :P18:24
nessitaralsina: thanks! next to that I have this trivial one: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/add-asset/+merge/6800218:25
nessitaDiegoSarmentero: yes sir, is in the queue18:25
* ralsina goes for the trivial18:25
dobeyralsina: that makes it a bit easier to deal with the icon generation issue, i think18:25
* nessita realizes that suddenly "The queue" is starting to sound mysterious18:25
ralsinanessita: +1 on the trivial one18:25
DiegoSarmenteronessita, thanks! :D18:25
ralsinadobey: ok, we'll talk about details after it's landed, good for you?18:26
dobeyralsina: sure i guess. i'm just asking about this right now, as i'm drawing up a bit of a minor re-org plan for some of our code, to make things easier for the cross-platform case, as well as the shim case on ubuntu18:27
ralsinadobey: sounds useful18:28
ralsinadobey: basically, there is a "FetchCode.run" function that has to produce a tree of code. How we do that is irrelevant.18:28
dobeyralsina: yeah, i'm not worried so much about that implmeentation at the moment. just the possibility, and what we're currently doing :)18:29
dobeysince i have no idea how the windows port bits work really :)18:29
ralsinadobey: I think the bundling thing is pretty flexible so it's probably not the part that's going to cause problems :-)18:29
dobeyralsina: sure, but it is relevant to my current thinking :)18:31
ralsinanessita: pushed suggested changes in the branch for bug #80987318:39
ubot4Launchpad bug 809873 in ubuntuone-windows-installer "Add a script to create a bundle and installer for all the related software (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/80987318:39
alecunessita, ping18:39
alecunessita, I remember you were discussing some things with mandel regarding the "start" method that was the last to be done, or something like that.18:40
mandelalecu: in sdtool?18:40
alecumandel, around!18:41
alecumandel, yes! is that this? http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/linux/dbus_interface.py#L146118:41
nessitaalecu: yes, it was done as far as I know18:42
mandelalecu: yes, start is there…18:42
nessitaalecu: the "start" on windows was the one needed18:43
nessitaalecu: I mean, the one that mandel coded18:43
alecumandel, the thing is that I'm hitting a bug when "disconnect" is being called from control panel18:43
alecumandel, and I started tracing all the way down to sd, and that bit looks weird, because that push in disconnect I expected it to be in "interaction interfaces"18:43
alecumandel, is that right? or am I missing something?18:44
alecumandel, hmmm..... not sure. the thing is, that there's a disconnect both in class SyncDaemon (in windows/ipc.py) and both in class IPCInterface18:45
alecuand the one that's getting called (and fails) is the one in class SyncDaemon.18:46
mandelalecu: there are 2 disconnect, the actual method and the interface...18:47
mandelalecu: can you paste the error?18:47
alecumandel, http://pastebin.ubuntu.com/644295/18:48
ralsinaalecu: the TIMEOUT_INTERVAL in SSO is used by both windows and linux?18:49
mandelalecu: one sec, I think I know the issue18:49
alecumandel, cool18:49
alecuralsina, don't know. checking18:49
mandelalecu: I'm looking for the code right now18:49
alecuralsina, it looks like it's used on both.18:50
mandelalecu: you want to call this: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/windows/ipc_client.py#L26418:50
mandelalecu: which is called from this remote object http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/windows/ipc_client.py#L70118:51
ralsinaSo ... ugh. We do it for both, or I put that back to 10000 and override on the windows side, if at all possible, or put a platform if there18:51
mandelalecu: so you are sking the root object http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/windows/ipc.py#L944 to execute a method that he does not have18:51
nessitaralsina: is not the same, I think...18:52
mandelalecu: root provides you access to all the different exposed interfaces, being the syncdaemon one of them, so you either request root the correct remote or you use the wrapper I wrote, one of those18:52
nessitaralsina: oh, it's18:52
alecumandel, I think on the control panel side the right method is being called. let me check.18:52
mandelalecu: let me know if I make sense before I go out18:52
ralsinanessita: yep18:52
nessitaralsina: well, you can duplicate that in the main/windows.py file18:52
nessitaralsina: instead of importing and re-using18:53
ralsinanessita: right18:53
ralsinaand I put this back to 10000 msec18:53
alecumandel, I think the right method on syncdaemon is being called.18:53
mandelalecu: then the issue is here: SyncdaemonService18:54
nessitamandel: how's branch splitting going? (I'm asking since you mention you may be going out)18:54
nessitamandel: how's branch splitting going? (I'm asking since you mention you may be going out)18:54
mandelalecu: this: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/syncdaemon/interaction_interfaces.py#L70218:54
ralsinanessita: not even, it's only used in the __init__.py not on the platform-specific ones.18:55
mandelalecu: looks like he is not getting the correct service object, and instead of getting the actual remote on is getting an IPCRoot, you should check in wither main of platform IPC to see how that class is instantiated18:55
nessitaralsina: ooooohhhhhuuuuuccchhh18:55
ralsinanessita: I will set it on the platform modules andimport it in __init__18:55
mandelnessita: most of it done, I had to think a little in the way I wanted to split it, should be ready for tom morning18:55
nessitamandel: AR morning or your morning?18:56
mandelnessita: my morning, as in 10/11 am, so ready for review in the AR morning18:56
nessitamandel: great!18:57
alecumandel, it's created here, right? http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/windows/ipc.py#L34818:57
alecumandel, and called from here: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/windows/ipc.py#L97918:58
mandelalecu: indeed, so the instantiation of the class is wrong and is getting IPCRoot in the constructor instead of the correct class to relay the calls too18:59
mandelalecu: looks like a trivial bug to fix18:59
mandelthe relay of the methods should work when the correct instance is passed18:59
mandelalecu: does it make sense?19:00
alecumandel, not entirely. Probably in your head does, but I can't keep all the layers in my head yet.19:00
ralsinanessita: +1 on https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/fix-810440/+merge/6799819:00
mandelalecu: indeed that part is a little ugly hehe to many layers in some points...19:01
nessitaralsina: ack, I'm not bringing up the VM from cheepaca, I got some better net conn now :-)19:01
ralsinanot or now?19:01
alecumandel, you say "the instantation of the class is wrong" <-  which one of the classes is instantiated wrong?19:01
nessitaralsina: now!~:-)19:01
alecuhow should we instantiate it?19:01
ralsinanessita: is that your head-is-smoking emoticon? Nice!19:01
nessitaralsina: see? I'm unstoppable today (?)19:02
alecumandel, if you can post of a diff of the fix, and I'll fix and do the tests.19:02
ralsinanessita, alecu: trivial sso timeout branch, https://code.launchpad.net/~ralsina/ubuntu-sso-client/live-forever/+merge/6801019:02
dobeyhmm, i should get a snack19:03
mandelalecu: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/syncdaemon/interaction_interfaces.py#L702 should create a SyncDaemon remote object that simply provides the communication layer for SyncdaemonService which is the guy who knows how to disconnect etc...19:04
mandelalecu: on the linux side we have a similar object that SyncdaemonService (I think is the same name, I cannot remember) that does the same thing with dbus19:05
mandelalecu: so those objects are the diff platform communication layers whose only concert is to expose the method from the SyncdaemonService which is the class that knows how to do the job19:05
mandelalecu: in this case it seems that the class calls another remove object (kinda ugly if you ask me) to disconnect19:06
alecumandel, "remove object" or "remote object"?19:06
nessitamandel: by SyncdaemonService you mean SyncDaemonTool? (I'm trying to understand)19:06
mandelalecu: typo, is a remoTe object19:06
mandelnessita: no, SdTool is a convinient class that puts together some logic plus dbus/spread calls19:07
* nessita browses code then19:07
mandelnessita: the ones we are talking about are the interaction interfaces and their wrappers19:07
mandelalecu, nessita: super quick mumble and I explin it fast so that you can work19:08
mandelI have 15/20 min19:08
alecumandel, please, lets.19:08
mandelnessita: or skype :)19:08
nessitamandel: skype! ;-)19:08
mandelok, I'll cll you both19:08
mandelalecu, nessita: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/syncdaemon/interaction_interfaces.py19:11
mandelalecu, nessita: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/linux/dbus_interface.py19:17
mandelalecu, nessita: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/linux/dbus_interface.py#L43419:18
mandelalecu, nessita: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/syncdaemon/main.py#L12919:30
alecumandel, nessita: http://pastebin.ubuntu.com/644295/19:37
mandelnessita: http://bazaar.launchpad.net/~ubuntuone-control-tower/ubuntuone-client/trunk/view/head:/ubuntuone/platform/windows/ipc.py#L94419:37
ralsinanessita, when you have a minute: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/fix-806654/+merge/68014  [URL signing, I want to explain why I am not mocking oauth on the tests, though]19:43
dobeyralsina: why would one mock oauth?19:46
ralsinadobey: it's URL signing, so it's time dependent19:46
ralsinadobey: so, if you want a repeatable output of oauth'ssigning, you have to mock it19:46
ralsinaInstead, I only test the invariant parts of the URL, that way I also test we are calling oauth correctly19:47
dobeyralsina: even without the time, nonce is supposed to be unique every time :)19:47
ralsinaPlus we will know if oauth changes something on tests instead of on deployment ;-)19:47
dobeyi don't think we should mock oauth, since it doesn't do any network connection itself19:47
ralsinadobey: since you know oauth,could you review that branch?19:48
ralsinait's pretty trivial, but I don't know all that much about it19:48
dobeyralsina: i don't know why you didn't use throwaway generic readable strings for the token in the test though19:49
dobeylike 'key' and 'secret' instead of 'XfdaXfdsafdkL' stuff :)19:49
ralsinadobey: because we already use that set of credentials in a few other tests19:49
ralsinaSo I am just copying myself ;-)19:49
dobeyugh, copy/pasted junk is even worse. especially if they're real tokens, which they look like they are :)19:50
* ralsina took them from SSO ;-)19:50
ralsinabut it's ok, I can change that19:50
dobeyit's just weird and i think it makes it a bit harder to read :)19:51
ralsinadobey: tokens have to be a fixed length or are just arbitrary?19:51
dobeyralsina: arbitrary, i usually use 'consumer_key' and 'consumer_secret' and such for tests19:52
dobeyas long as they're ASCII, it's fine19:52
dobeyralsina: did you run pep8 on this?19:53
ralsinadobey: yep19:53
ralsinadobey: if I put a readablestring on token or token_secret:19:53
ralsinaexceptions.TypeError: character mapping must return integer, None or unicode19:53
dobeyralsina: and it didn't complain about lack of space between string and \?19:54
ralsinadobey: no, but may be because I have a newer pep819:54
ralsinabesides, it's a continuation line, you can't *ask* for spaces before it19:54
dobeyralsina: nah, it probably doesn't complain. i don't know if it's pep8 or not. it's just ugly19:54
dobeycontinuation characters suck :)19:55
dobeyuse parens instead :P19:55
ralsinadobey: personal taste dude.19:57
* dobey writes a PEP for it19:57
ralsinaPEP-dobey: "it should look like C" :-)19:57
alecunessita, mandel: before finding this, my head was hurting. Now it's pul-sa-ting!19:58
ralsinadobey: there, pushed with spaces and readable keys where those don't break it19:58
* ralsina is suddenly scared of what nessita alecu and mandel have been talking about on skype19:58
nessitaralsina: you need to put an space before \! ;-)19:58
nessitaso, "a string" \19:59
ralsinanessita: pep8 didn't complain, but I already pushed that anyway just because I am nice ;-)19:59
dobeyralsina: see, nessita and i agree on it!19:59
ralsinaoh, get a room you too. Nazis.19:59
nessitaralsina: we were debugging an issue that alecu was having, and we saw some code is not trivial to see :-)20:00
dobeyo/~ deutscheland deutscheland uber alles! o/~20:00
nessitathat said, I can die in piece20:00
nessitapeace also20:00
ralsinaYes, we all can die in pieces. :-)20:00
nessitamy brain is shortcutting :-D20:00
alecuralsina, it's not called a room. It's called a "bunker"20:00
dobeyalecu: nice20:01
dobeyralsina: heh, you didn't change the token/token_secret too, only the consumer :P20:01
nessitaralsina: I have 4 tabs opened with reviews for you. Which one I should do first? :-D20:01
ralsinadobey: see above. If I change the tokens,oauth complains20:01
ralsinanessita: random is ok20:01
dobeyit does?20:02
nessitaralsina: which one is easier?20:02
ralsinathe sso timeout one20:02
dobeyralsina: what version of python-oauth is complaining, btw?20:02
dobey(just wonder if that's a new thing)20:02
ralsinadobey:  1.0.120:03
dobeymust be a new thing then :(20:03
ralsinait makes sense, since the tokens are not just random strings20:03
dobeythe tokens are just random strings20:04
dobeybut it's also python-oauth :(20:04
dobeyralsina: anyway, looks ok to me20:05
ralsinadobey: cool, thx20:05
nessitaralsina: I think that the signing url branch should not be attached to bug #806654, right?20:10
ubot4Launchpad bug 806654 in ubuntuone-control-panel "QT UI: replace current Services tab with an embedded browser (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/80665420:10
ralsinanessita: it was sort of necessary for that bug, since we needed to display the signed URL20:10
ralsinait doesn't *fix* it though20:10
nessitaralsina: also, that same bug should be closed as won't fix after what we talked with design by email20:10
nessitaralsina: so, I think we should have a bug to only solve the url signing thingy20:11
nessitaand close the embed a browser20:11
ralsinaI can just change the description to "create a function to yadda yadda20:11
nessitaralsina: hum, I would like to keep track of the history of the bug, we may re-open in the future20:11
ralsinaok, will add another one and reattach20:12
nessitawe usually edit the title for typos or better descriptions, not for completely change the goal of the bug :-P20:12
nessitaralsina: approved timour thingy, going for oauth signing20:14
nessitaralsina: question. Why do you sign the uri = 'https://one.ubuntu.com/api/1.0/from_oauth' instead of the url itself, and pass a 'next': url param to the oauth request?20:16
ralsinanessita:IIRC the from_oath page sets the cookie so the other pages see you are logged in20:17
ralsinaand then you are redirected20:17
nessitaralsina: but... I thought we were signing each page that needed to be sign with credentials...20:18
nessitaI don't understand the cookie thing (in the sense why we need to set a cookie)20:18
ralsinanessita: if we do that, when you click on a link, you are going to be not-siged-in20:18
ralsinabecause the links on the page point to the not-signed pages20:18
nessitaah... I see20:19
nessitaralsina: fail cut & paste! +# Authors: Roberto Alsina <alecu@canonical.com>20:20
nessita(been there, done that)20:20
ralsinanessita: hahaha, I'm modest20:20
nessitaalso, this is other fail! +"""Tests for the humanize function."""20:21
ralsinathere, pushed both. And you uncovered my cunning plan to have alecu answer questions about my code!20:22
nessitaralsina: hum that method will no work if the url has a query string20:25
ralsinanessita: it should!20:25
nessitaralsina: if the given url has a query string, that does not work :-)20:25
ralsinaremember it's put on the "next" argument, url-encoded20:25
* ralsina has not checked, of course ;-)20:26
ralsinanessita: added test for that, works just fine20:29
nessitaah, let me think this again, then20:30
nessitaralsina: I'm askin because I struggled with this in the past20:30
ralsinanessita: pushed that test in r19220:30
nessitabut I may have slightly different issue /me thinks20:30
ralsinaIn fact, we always sign urls with parameters (next)20:31
nessitaralsina: right, my confussion comes when signing url without the next20:38
nessitathat is, signing the url for rest api call, for example20:38
nessitaralsina: branching the last version to run tests, and approving after that20:39
ralsinanessita:  cool, thx20:39
nessitaralsina: hum, I got several lint issues20:43
ralsinanessita: checking lint is pretty hard on my machine because of the amount of noise I get from the test classes, sorry20:43
ralsinanessita: if you could pastebin, I'll fix them immediately20:44
ralsinanessita: I did introduce a pep8 error in the last test (for urls with query) which I fixed now20:46
nessitaralsina: ^20:48
ralsinaThe last one is fixed, the others I have to disable20:49
ralsinaSince it's pylint who's wrong :-(20:49
ralsinaand on my notebook.... doesn't give me those. Gives me 200 others, though.20:50
nessitaralsina: right20:50
ralsinanessita: pushed the disable20:51
nessitaralsina: yey20:52
ralsinaWow, pushing the disabled sounds nasty :-)20:52
dobeythis is why i want to switch to pyflakes :)20:52
nessitaralsina: GUESS WHAT :-D20:53
nessitaubuntuone/controlpanel/gui/tests/test_url_sign.py:40:1: E302 expected 2 blank lines, found 120:54
nessitaralsina: I'll approve, you can globally approve once ou fix that so tarmac will not reject20:54
ralsinanessita: http://pastebin.ubuntu.com/644366/20:54
ralsinabut thanks!20:55
nessitaralsina: I believe you....20:55
ralsinaI swear I am testing things first :-(20:55
dobeypep8 --repeat20:58
dobeybut pep8 also doesn't exit non-zero on warnings20:58
ralsinadobey:  --repeat doesn't make a difference if it didn't find any problems in the file21:01
ralsinaooooooook it does21:01
ralsinafreaking crap21:02
dobeypep8 is weird21:02
dobeyit will find other problems after you fix some, sometimes21:02
dobeyeven if you do --repeat :(21:02
nessitaralsina: --repeat does not repeat the same error globally, not per file21:02
ralsinanessita: Iam having to stop for a while and be a parent. Are you getting to test shares/udfs today?21:04
ralsinaIf not, I may do them late tonight21:05
nessitaralsina: yes if I delay your windows installer branch review which I was starting21:05
ralsinayes, delay it21:05
dobeywell, i am off. i'll see you all on tuesday. have a good weekend and friday/monday :)21:05
nessitaI can swap and re-start the review tomorrow21:05
nessitaok, on it!21:05
nessitaralsina: I'll send the result of the test in the report21:05
ralsinanessita: I know it works IRL,so I can send today's installer with it anyway21:05
nessitaralsina: ack21:06
nessitaralsina: if you're still around, using mandel's branch syncdaemon won't start at all21:13
ralsina:-( indeed21:13
nessitaralsina: I'll file a bug and send an email to the windows-group21:13
nessitaI just confirmed in trunk syncdaemon is starting21:13
=== m_conley is now known as m_conley_away
=== zyga-afk is now known as zyga
nessitahum, laptop battery is almost dead, I need to  plug a cable21:25
DiegoSarmenteroalecu, are you there?22:13
alecuDiegoSarmentero, here I am22:13
DiegoSarmenteroalecu, i'm at home right now, i was going to fix the issue about the check state of the buttons........  question22:14
DiegoSarmenteroalecu, all the buttons needs to has a checked state??22:14
alecuDiegoSarmentero, I think no button needs a checked state22:14
alecuDiegoSarmentero, this is not about "checked state"22:14
DiegoSarmenteroalecu, i'm confuse22:14
alecuDiegoSarmentero, this is the visual indicator that a button is "being clicked"22:15
DiegoSarmenteroalecu, ahhhhhhhhhh ok ok22:15
DiegoSarmenteroalecu, i though it was an indicator that the button is pressed22:15
alecuDiegoSarmentero, try pressing the mouse over a button and holding the button for a few seconds...22:15
DiegoSarmenteroalecu, yes, i know what you mean22:15
alecuDiegoSarmentero, that's the small visual indication that you have clicked.22:15
alecuDiegoSarmentero, cool.22:15
DiegoSarmenteroalecu, ok, ready then! working on that!22:16
ralsinaDiegoSarmentero: sorry I didn't get to call you today at noon. Are you free a little bit now?22:19
DiegoSarmenteroralsina, yes22:20
DiegoSarmenteroralsina, at home in peace!!22:20
ralsinaok, calling...22:20
ralsinaDiego, PM me the number please?22:21
nessitaDiegoSarmentero: I did not forget about your review, but I ran out of time today, a complicated branch took much time from me22:38
nessitaDiegoSarmentero: I'll do it tomorrow22:38
nessitaralsina: long email about UDF tetsing was sent by email22:38
karniduanedesign: omg... are you here still?22:39
nessitaI'm gone now, I'm a little burnt out22:39
karniduanedesign: I accidentally generated an autoresponse to a support request. I just wanted to give it to joshuahoover :<22:39
karnijoshuahoover: please have a look at RT 337922:39
joshuahooverkarni: k22:39
karnijoshuahoover: thank you22:39
nessitabye all!22:40
csgeekwhen I run u1sdtool I get a GtkWarning: could not open display  how can I run it the cli tool w/o a gui setup?22:48
alecucsgeek, at the moment you can't, because currently u1 gets the credentials from the gnome keyring22:58
alecucsgeek, it might be possible to run it inside an xvfb22:58
csgeekokay... then I probably should install gnome at the very least22:59
alecucsgeek, not sure if the whole of gnome is needed; just installing ubuntuone-client should get the necessary dependencies.23:04
alecuralsina, ping?23:08
csgeekokay.  is there a guide on how to connect / associate with an UbuntuOne account?23:13
csgeekusing the u1sdtool23:13
ralsinaalecu: pong23:13
alecuhi ralsina: I'm getting an error with trunk of sso+sd+control panel; it says sd can't connect because of an auth error.23:14
alecuralsina, nessita describes the same in an email.23:14
alecuralsina, are you getting that?23:14
alecu(control panel says sd can't connect, that is)23:14
ralsinaalecu: haven't tried syncdaemon in a while, I was working on u1cp and installer23:14
ralsinaand in u1cp onthings without UI :-(23:15
alecuralsina, then don't worry; we'll see about that later.23:15
ralsinanothing landed on sycdaemon today, right?23:15
DiegoSarmenteroalecu, are you there? i've submited a request merge for the pressed effect on buttons23:44
alecuDiegoSarmentero, great!23:44
alecuDiegoSarmentero, want to pass me the link to the merge proposal?23:44
DiegoSarmenteroalecu, https://code.launchpad.net/~diego-sarmentero/ubuntuone-control-panel/button-pressed/+merge/6803923:45
DiegoSarmenteroalecu, let me know if the colors are not the right one..... i use another in the same scale but darker23:46
alecuDiegoSarmentero, the code looks fine; please set the "commit message" in the merge proposal.23:46
DiegoSarmenteroalecu, ok23:47
alecuDiegoSarmentero, (it can be the same as "description of the change")23:47
alecuDiegoSarmentero, I'll test it right away.23:47
DiegoSarmenteroalecu, ready23:49
alecuDiegoSarmentero, it works fine, but looks a bit weird. We should ask the designer for the exact colors.23:54
DiegoSarmenteroalecu, yep! i had the same feeling23:54
DiegoSarmenteroalecu, i don't have the best taste in colors :P23:54
alecuDiegoSarmentero, the designer supposedly does :-)23:55
DiegoSarmenteroalecu, ok, let me know when the colors are defined :D23:55
alecuDiegoSarmentero, let's try the same color gradient that the "non highlighted" button, but with the darker color on top and the lighter below it.23:55
DiegoSarmenteroalecu, ok....... give a sec23:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!