wgrantlifeless: Ah, that's right. WAL won't allow us to read from slaves that are partly migrated, but it will allow us to detach a slave. Which means we could do very cheap read-only, which makes handling appserver requests much easier.00:09
wgrantDoesn't help for scripts, but they're less noticable.00:09
wgranthttp://dev.launchpad.net/Soyuz/HowToUseSoyuzLocally has instructions on getting a buildd and buildd-manager up.00:11
wgrantBest to run lp-buildd in a VM, of course.00:11
wgrantBut you do anyway.00:11
lifelesswgrant: thanks00:11
lifelesswgrant: selfreview that00:25
wgrantlifeless: What?00:25
wgrantOh, the sreg thing?00:25
wgrantWas considering it.00:25
wgrantlifeless: Yay, batchnav QA.00:34
lifelessit looks ok t obe00:51
lifelesslooks ok to me00:52
wgrantIt does.00:52
lifelessI don't konw what abel found00:52
wgrantAnd we are qa-bad.00:54
wgrantNot on that rev, though.00:54
lifelesswgrant: what on ?00:58
wgrantExpander thingy.00:59
wgrantBug #80743400:59
_mup_Bug #807434: Replace source package files, publishing history and similar bug expanders <bad-commit-13438> <qa-bad> <tech-debt> <Launchpad itself:Fix Committed by danilo> < https://launchpad.net/bugs/807434 >00:59
lifelessmissing bad-commit-XXX00:59
lifelessno its not01:00
lifelessjust mup formatting confused me01:00
wgrantWill rollback in a sec, just checking to see whether the other one needs doing too.01:00
wgrantIt's not pretty, but it doesn't seem to be broken.01:00
StevenKspiv: O hai, you haz QA01:00
* wgrant rolls back.01:03
spivStevenK: for #702024 ?01:04
StevenKspiv: Yup01:04
spivThe only QA I can think to do replicates the automated tests, and the change is cosmetic rather than functional.01:06
wgrantBug #70202401:06
wgrantIs that the Unavailable thing?01:06
spiv(And would require l-osa interaction I think)01:06
wgrantLet me poke at it.01:06
wgrantwgrant@mawson:~$ curl http://bazaar.qastaging.launchpad.net:8022/01:07
wgrant0 connections:01:07
wgrantLooks OK.01:07
spivwgrant: thanks!01:08
* spiv goes and takes some cold&flu pills to celebrate01:08
wgrantStevenK: Poor amd64.01:25
wgrantHm, only 3200 OOPSes from the session incident.01:28
wgrantNot so bad.01:28
wgrantlifeless: Are you investigating the abel thing?01:29
wgrantStevenK: Can I have DF01:32
lifelesswgrant: I've emailed him01:33
lifelesswgrant: but he didn't seem to have written anything down other than the lazr.batchnavigator MP, which is approved.01:33
wgrantYes, I saw that yesterday and wondered what was going on.01:33
wgrantHoped you knew.01:33
lifelessme too :>01:34
wgrantStevenK: What do you know about +initseries?01:36
wgranthttps://dogfood.launchpad.net/deribuntu/grar/+initseries defaults to initialising from natty.01:36
wgrantDespite there being existing series in that distro.01:36
StevenKwgrant: "Oh God, it's full of JS!"01:36
wgrantIt also won't let me add any series from the current distro...01:37
wgrantOh, perhaps the parent series thing there is not for initialisation, just for DSDs.01:38
wgrantThis is confusing *me*. This isn't good...01:38
wgrantAh, yeah, the form changes subtly.01:41
wgrantStevenK: Do I use run_jobs to run IDS jobs?01:43
wgrantThe logging leaves something to be desired.01:47
StevenKThe logging infrastructure that the job system provides is non-existant.01:47
StevenKThere is no way to get at the logger object inside the job's run() method01:48
lifelesswgrant: ever seen:02:12
lifeless~$ virsh console lp-builder02:12
lifelessConnected to domain lp-builder02:12
lifelessEscape character is ^]02:12
lifelesserror: internal error cannot find character device (null)02:12
lifelessStevenK: ^02:12
wgrantBut it doesn't surprise me.02:13
wgrantDo you have a console-capable domain?02:13
wgrantKVM normally isn't.02:13
wgrantWhy is the URL of a packageset /package-sets/${distroseries.name}/${packageset.name}...02:15
poolie_lifeless, i have seen that, i didn't work out why02:18
StevenKSurely it should be distribution/distroseries/packageset?02:18
poolie_i like the sound of "downtown deploy"02:18
wgrantStevenK: You would think.02:18
StevenKThat sounds good02:19
lifelesspoolie_: where is that typo?02:19
poolie_also bug 81069402:20
_mup_Bug #810694: mirror prober failed after trying to shutdown during a downtown deploy <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/810694 >02:20
lifelesspoolie_: what was the initial password resulting in your ubuntu-vm-builder recipe ?02:37
lifeless(the one from dev.l.n)02:37
spivlifeless: 'ubuntu' perhaps?02:38
lifelesstried already :P02:40
poolie_i don't recall02:42
lifelessah, it totally ignored the parameter to control the user02:47
lifelesspresumable ubuntu-vm-builder -> vmbuilder fallout02:47
lifelessalso, hooray for network X02:48
StevenKwgrant: Your rollback just hit buildbot03:17
wgrantlifeless: We don't do backward navigation yet, do we?04:03
lifelesswgrant: next, prev04:03
wgrantBut does that actually use the new backward navigation stuff?04:03
lifelesswgrant: yes04:03
lifelessits only broken in the corner case of less than a full batch at the start04:04
lifelesswhich I expect would occur only with changing data today04:04
lifelessbecause all the current navigators will be offset based.04:04
lifeless[or with url hacking]04:04
lifelesss/which I expect would occur only with changing data today/which cannot happen today/04:05
wgrantAre we OK to deploy with it, then?04:05
lifelessAFAICT yes, but its friday ... figuring abel can answer what he found when he shows up04:06
LPCIBotYippie, build fixed!04:25
LPCIBotProject devel build #891: FIXED in 5 hr 37 min: https://lpci.wedontsleep.org/job/devel/891/04:25
=== michaelh1 is now known as michaelh1|away
lifelesswgrant: are you and free sorting out the tc* name?04:36
lifelesslong poll project name.04:37
wgrantI haven't discussed it since it was mentioned last night.04:37
lifelessI'm going to ignore it from now on; AIUI he would like a implementation agnostic name.04:37
wgrantIt will probably end up as txwebnotify, but we'll see :)04:37
lifeless(some arbitrary suffixes to play with)04:38
spiv(it's a long pole!)04:43
lifelesskill me now04:43
wgrantThat's a very Twisted name, though.04:44
LPCIBotProject db-devel build #723: STILL FAILING in 5 hr 43 min: https://lpci.wedontsleep.org/job/db-devel/723/04:44
lifelessspiv: (nice one)04:44
lifelesswgrant: overly cute pehraps04:45
spivlifeless: :)04:46
wgrantlifeless: Yes, very Twisted.04:50
=== almaisan-away is now known as al-maisan
StevenKHm, how do we QA r13437?05:31
lifelessits live05:33
lifelesstherefore its ok05:33
StevenKlifeless: Marking as qa-ok, then05:33
StevenKThen aside from r13413 and the pending rollback of r13438, we look in okay shape05:34
lifelesswhen abel gets up, someone should ask him about 41305:35
lifelessI should be around05:35
StevenKRight, and the only QA to do will be one rev of wgrant's, but that won't be for roughly four hours.05:36
StevenKBut then it's probably too late to deploy until Monday morning.05:36
* StevenK wishes qas didn't take an hour to update05:57
spmpatches accepted06:14
=== al-maisan is now known as almaisan-away
* StevenK waits for wallyworld_ to review his branch, since he's already claimed it.06:44
StevenKwallyworld_: I've just pushed a new rev that removes one line of extraneous whitespace06:45
wallyworld_StevenK: thans, just about to +1 it :-)06:45
wallyworld_sorry for stealing it, it's my first and only one today06:46
spmwallyworld_: may I suggest a -1 due to excessive impatient impertinence?06:46
StevenKwallyworld_: I am of the opinion that it's too large to self-review, so it's perfectly fine.06:46
* spm promotes peace and understanding via the application of a nail studded club, amongst LP developers06:47
wallyworld_ooh, studs. now you're talking06:47
spm... tmi.06:47
StevenKNow. Look. What. You've. Done.06:47
spmclearly it's all your fault StevenK. you started this.06:47
nigelbI thought some bored LOSA started it :P06:50
* nigelb yawns and stretches06:50
wallyworld_StevenK: i assume you changed the vocab because the users of the vocab wanted to pass in spn instead of dsp?06:50
nigelbI wish a very painful death to telemarketeers who wake you up the day you pull an all-nighter06:51
* wallyworld_ wishes the same thing to *ant* telemarketer06:51
StevenKwallyworld_: I changed it due to sinzui's e-mail of this morning.06:51
* wallyworld_ looks at email06:52
wallyworld_makes sense now :-)06:53
StevenKwallyworld_: You'll prod jtv to mentor?07:06
wallyworld_StevenK: yes07:33
wallyworld_StevenK: you may want to cut'n'paste a bit of the email which mentioned the need for the change into the mp description07:34
wallyworld_StevenK: jtv is away today (national holiday). maybe wgrant can +107:38
=== wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 232 - 0:[######=_]:256
adeuringgood morning08:06
lifelessadeuring: hi08:11
lifelessadeuring: so batchnav08:11
lifelessadeuring: you should land your patch and do a release :) - but more importantly, is lp ok at the moment with the simple offset based batches?08:12
lifelessadeuring: (thinking qa for Revision 13413 )08:12
adeuringlifeless: yeah... real QA is hard for such a change that affects each batched view. Any suggestions?08:13
StevenKjtv: Can you please mentor wallyworld_'s review of https://code.launchpad.net/~stevenk/launchpad/dsp-vocab-use-spn/+merge/68046 ?08:15
lifelessadeuring: play with as many as we can - its how I found the change needed in 1.2.508:16
lifelessadeuring: I have been playing since that hit qastaging and couldn't break it (without url hacking)08:16
lifelessadeuring: I grepped for similar things too08:16
adeuringlifeless: ok.08:16
lifelessadeuring: how did you find that direction=forwards issue ?08:17
adeuringlifeless: by reading the source code08:17
lifelessadeuring: ah, fresh eyes!08:17
adeuringlifeless: can you tell me how to do a release of for lazr.batchanv?08:18
=== jam is now known as jam-other
=== almaisan-away is now known as al-maisan
lifelessadeuring: https://dev.launchpad.net/ReleaseChecklist08:19
lifelessits pretty much what I followed08:19
lifelessuhm, you will need to be added to the pypi maintainer list for projects08:19
lifelessI need to spend family time, so perhaps you can get flacoste to do that in ~ 4 hours08:20
lifelessthe pypi registration step is the last step so its not a blocker for updating LP08:20
bigjoolswgrant: hi - did you get a chance to look at my copyPackage branches?08:28
wgrantbigjools: I think we should confirm that PCJs work first.08:30
bigjoolsthey do08:31
wgrantI doubt it.08:32
wgrantI don't see how some cases work.08:32
wgranteg. announcements of copies into Ubuntu.08:32
bigjoolsso, rather than a blanket "they don't work" I think I'd appreciate it if you were more specific like that from the start08:33
wgrantWell, AFAICT PCJs had a few missing bits hacked together by Steve, then he was repossessed by our squad and nobody verified that PCJs were actually complete.08:34
StevenKAh. ENOJTV08:34
wgrantAnd this will enable copying into Ubuntu, so a thorough verification of their correctness needs to be performed.08:34
StevenKWho wants to mentor wallyworld_'s review, then? :-)08:34
bigjoolswgrant: can you name any specific parts that you know don't work as expected?08:39
wgrantbigjools: I need to leave for a while in a moment, but will return in an hour or so.08:40
wgrantbigjools: But things like build notifications, copy announcements, etc. for copies into the Ubuntu primary archive are, I'm pretty sure, not going to work.08:41
wgrantWe've already seen that notifications are not reliable.08:41
wgrantIn some cases they crash.08:41
wgrantThey are likely to email the wrong people, because we have no way to track who the right people are.08:41
wgrantThe security code has not been checked since the last few rounds of improvements were made.08:42
bigjoolssecurity code?08:42
wgrantThe interfaces are weak so it's hard to verify that everything is going to work, but we need to try.08:42
wgrantThis moves security into the model.08:42
wgrantFrom the security adapters.08:42
wgrantThis is scary.08:42
StevenKadeuring: O hai, you're fine to do OCR today?08:42
bigjoolsthe adapter can never work08:42
wgrantBut the new approach needs to be approached with great skepticism.08:43
bigjoolswe are now using the very tried and very tested checks that have always been there08:43
wgrantTheir integration is not tried, tested, nor trustworthy.08:43
bigjoolsyes, that's exactly why I wanted your opinion08:43
bigjoolsbut this is counterproductive08:43
StevenKI think you just got his opinion, in spades.08:44
wgrantThe recent implementations of PCJs and series initialisation need a lot of checking, because they were developed by hacking existing code to pieces and reassembling it and grafting on other refactorings until they did roughly what was required.08:45
wgrantWe are now trying to push them out without cleaning them up or checking that they work.08:46
bigjoolssorry but you are talking out of your arse08:46
adeuringStevenK: sure, need a review?08:46
StevenKadeuring: Sort of. A mentor of wallyworld_'s review -- https://code.launchpad.net/~stevenk/launchpad/dsp-vocab-use-spn/+merge/6804608:47
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring | Critical bugs: 232 - 0:[######=_]:256
adeuringStevenK: ok, I'll look08:47
StevenKadeuring: Thank you.08:47
adeuringStevenK: +        dsp = self.context.getSourcePackage(spn)09:22
StevenKadeuring: What about it?09:22
adeuringStevenK: this assumes that self.context is not None, but: def __init__(self, context=None):09:23
StevenKIt does, yes09:23
adeuringso, this breaks if no context is given09:23
StevenKadeuring: This vocab is used nowhere else yet09:23
adeuringStevenK: ok, so, then we can drop the "=None" from the __init__() parameters?09:24
StevenKHm, sure09:25
adeuringStevenK: I mean, the =None is an invitation to create the vocab without a context, but that would explode :)09:25
adeuringStevenK: r=me with this change09:29
StevenKadeuring: Thanks! Changes pushed.09:30
adeuringStevenK: cool09:30
wgrantbigjools: Are PCJs tested with binaries at all?09:32
wgrantIt seems they allow binary copies, but only source overrides.09:32
wgrantNot sure what is going to blow up if someone copies binaries into Ubuntu without overrides...09:32
wgrantThe security seems OK.09:33
bigjoolswgrant: this is the first 2 branches in a pipeline, I need to make some other changes yet, like feature flag checking and binary copying.  Thank you for checking the security.09:37
wgrantbigjools: Oh, so this is to be behind a feature flag?09:38
bigjoolsin fact I will probably deny binary copying for distros for now; eventually we want to use it for security uploads09:38
bigjoolsthat's the plan09:39
* bigjools curses code that passes logger objects around09:39
wgrantIf I'd known you'd not planned to land this as is, I would have been far less likely to decry it as dangerous madness. As presented, the branches suggested that you considered the functionality complete and finished and ready for widespread use, which seems somewhat premature given the complexity of the issues at hand.09:42
wgrantI still contend that PackageCopyJobs are, in their present form, a hackjob with only slightly fewer special cases than delayed copies, but at least they have good promise for being cleaned up and destroying delayed copies :)09:43
wgrantI also need to think about how copy/build notification recipients should work.09:45
wgrantHave you considered that at all?09:45
wgrantThere is potential for great misdirected spammage.09:45
wgrantI was hoping StevenK could look at that after the initial notification fixup, but that was not to be :(09:46
jtvwgrant: I suspect that for the foreseeable future, soyuz changes will always be immature.09:47
jtvPointing it out with words like "hackjob" is a bit like pressing a "panic" button too often though; it can distract from the work that needs doing to make things better.09:48
jtvLots of stress involved.09:48
jtvI find it takes a substantial mental effort to get past those terms and into constructive detail.09:49
jtvwgrant: Wouldn't be an issue in low-blood-pressure situations, but as long as we're not in one, please beware of the inadvertent damage from blanket judgments!09:52
wgrantjtv: Soyuz changes will always be immature, yes. But for copies, perhaps more than anything else in this project, it must be avoided. They are complex, fragile, badly understood, and most mistakes are of great consequence. Perhaps one day we will unify and clean the copiers up... but until then calling them by any positive term would be a dangerous misrepresentation of the situation.10:08
jtvwgrant: not arguing any of that; I believe you.  I'm saying that in this situation of pressure and uncertainty, you need to be careful how you say these things.  Be specific about your concerns, keep them somewhere visible, state them in terms of what needs doing about them so that people can see progress towards their goals and aren't made to feel (unintentionally I know, but I'm pointing out that pressure isn't rational!) that they do a bad job, 10:16
jtvTrust me, I'm middle-aged now.10:17
nigelbCan't argue that ^10:18
* nigelb ducks10:18
jtvHey, I can say it; you are supposed to go "you don't look a day over 39½!"10:18
wgrantjtv: Is it worth adding the config setting?10:20
bigjoolsjtv: you've always been middle-aged10:20
wgrantjtv: Given that it is deprecated?10:20
jtvIt's _almost entirely_ deprecated.10:21
wgrantIsn't the migrator the only thing that remains?10:21
wgrantAny reason not to hardcode it and delete it in three weeks?10:21
wgrantOh, tests, I guess.10:22
jtvThe tests went across with remarkable ease, though it's nice to know that the migration itself can be tested and automated.10:22
LPCIBotYippie, build fixed!10:27
LPCIBotProject db-devel build #724: FIXED in 5 hr 42 min: https://lpci.wedontsleep.org/job/db-devel/724/10:27
daniloswgrant, hi, if you are still around, perhaps you'd want to review a very simple fix for DSP:+index expanders?10:47
daniloswgrant, fwiw, you rolled back the wrong revision :(10:49
wgrantdanilos: Argh, sorry. The bug was linked, and I saw distributionsourcepackage-publishinghistory in there, and mistook it for distributionsourcepackage-index.10:51
daniloswgrant, no worries, I'll reland that revision, and a fix for the problem you noticed as soon as it goes through ec2 (just to be extra careful, some tests might be expecting IMG tag in there which we don't need anymore)10:52
wgrantdanilos: Have you checked all the others?10:52
wgrantI only checked up to the first issue.10:52
wgrantAnd unless we're sure it's all fine we should roll it all back.10:52
daniloswgrant, what do you mean? I can't QA the revision until it is on qastaging, and it's already up to your rolled-back revision10:53
wgrantdanilos: Well, this sort of stuff is fairly QAable locally.10:53
daniloswgrant, as for the problem in previous revision, how do I look for other togglers on packages?10:53
daniloswgrant, well, I did QA everything locally, but I missed it because same JS integrated in the archive-macros.pt was used on two different pages implicitely10:54
wgrantAhh, fun fun.10:54
daniloswgrant, I QAd only the PPA:+packages page10:54
daniloswgrant, thinking I am good10:54
wgrantI am glad we are cleaning this stuff up.10:54
wgrantSo, I guess see if you can grep around a bit further, and if not I will just look everywhere on Monday, I guess.10:55
daniloswgrant, I did grep for treeCollapsed, but I guess I missed this one case :/ (there are a few others left which I am not fixing because of the lack of time, and this one was in registry as well :/)10:56
wgrantStill, I am impressed at the lack of any other breakage.10:58
wgrantConsidering all the cleanup.10:58
daniloswgrant, heh, thanks, I did try to be very careful with QA, and you can look at QA URLs in my MPs to see the number of URLs I had to get to to test stuff out (finding proper places for that was sometimes harder than migrating the template/JS)11:01
wgrantdanilos: Yes. I opted to check all the expanders I knew about, because it's all so intertwined.11:01
wgrantLittle other choice :(11:01
wgrantStill, progress!11:02
daniloswgrant, indeed11:02
daniloswgrant, I suppose you don't have time to review https://code.launchpad.net/~danilo/launchpad/fix-806925/+merge/68070 then? :)11:05
danilosadeuring, can you please look at https://code.launchpad.net/~danilo/launchpad/fix-806925/+merge/68070 (it's very short)11:05
adeuringdanilos: sure11:05
=== al-maisan is now known as almaisan-away
adeuringdanilos: r=me11:18
danilosadeuring, thanks11:19
danilosadeuring, I've stuck in another expander replacement in the same template fwiw, can you please glance at it and check if it's ok as well?11:27
adeuringdanilos: sure11:27
danilosadeuring, it's in diff from line 27 onwards, QA on https://launchpad.dev/ubuntu/+source/iceweasel (because there are PPAs for that)11:28
adeuringdanilos: still looks good!11:31
danilosadeuring, heh, thanks (again :))11:31
sumanahhi, bac, still working on that summary and will get it to you in the next hr11:57
sumanahhttps://dev.launchpad.net/UI/Reviews?action=show&redirect=UserInterfaceReviewNotes#Tips%20for%20reviewers will be pretty useful I think!11:57
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
maxbstub: problems? :-)12:01
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== matsubara-afk is now known as matsubara
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
bigjoolsadeuring: hi, can I get a review please! https://code.launchpad.net/~julian-edwards/launchpad/pcj-requester-bug-810957/+merge/6808112:18
=== stub1 is now known as stub
=== stub1 is now known as stub
=== bac changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring,bac | Critical bugs: 232 - 0:[######=_]:256
bacmorning adeuring12:22
adeuringhi bac12:22
bacadeuring: i am grabbing ian's first branch, unless you've already started it12:26
adeuringbac: no, I haven't  (working purely "Interrupt dirven" this morning )12:27
bacadeuring: ok.  claimed.12:27
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
=== stub1 is now known as stub
sumanahbac: working on a summary of how Launchpad does code review & deployment -- can you give me a link about the template merge proposal that you can do via email?  I look at https://help.launchpad.net/Code/Review and it links to http://doc.bazaar-vcs.org/bzr.dev/en/user-guide/index.html#sending-changes which does not exist12:56
* bac looks12:57
sumanahand http://doc.bazaar.canonical.com/bzr.dev/en/user-guide/sending_changes.html does not mention the template12:57
bacsumanah: https://dev.launchpad.net/Code/BzrSend12:57
sumanahaha! thanks bac12:57
sumanahyou can see how far I've gotten in Gobby12:57
sumanah"The lpreview_body plugin will pre-populate the message body with our standard template, plus lint output." ooh, I'm going to look at that plugin to see what your template is!12:59
deryckMorning, all.13:01
sumanahhttp://bazaar.launchpad.net/~launchpad/lpreview-body/trunk/view/head:/body_callback.py got it.13:02
abentleybac, sumanah: bzr send hasn't worked for a couple of years.13:06
bacabentley: what is the replacement then?13:07
abentleybac: there is no replacement.13:08
abentleybac: The technical issue is that installing a bundle is incompatible with stacked branches.13:09
adeuringrvba: your branch init-series-not-close-bugs looks good but I think it could have at least one more test: the new test test_multiple_parents_close_bugs should check that the bug created in the test is not closed (and... shouldn't the test method's name include a 'nit'?)  . And do we already have tests that ensure that the other callsite of the packagecopier does indeed close bugs?13:09
rvbaadeuring: Thanks for reviewing this branch. I think I'll add the check to the existing test.13:11
adeuringrvba: thanks!13:11
rvbaadeuring: about the other callsites, I'm not really sure ... but I *suppose* we do have check for this.13:11
rvbaI'll have a look, just to make sure.13:11
adeuringrvba: cool, thanks13:11
bacabentley: i'm confused between 'bzr send' and lpreview/lpreview_body13:12
abentleybac: bug #71872313:12
_mup_Bug #718723: fetch from merge directive to stacked branch unable to fill in chk pages <oops> <regression> <Bazaar:Confirmed> <Launchpad itself:Triaged> < https://launchpad.net/bugs/718723 >13:12
=== almaisan-away is now known as al-maisan
bacabentley: i've continued using 'bzr send --no-bundle' to create my MPs13:12
rvbaadeuring: BTW, the branch we are talking about depends on ~rvb/launchpad/perm-distributionjob-bug-808680/+merge/68059.13:13
abentleybac: Yes, if you use --no-bundle, that probably works, but it means you have to manually upload the branch first.13:13
rvbaadeuring: If you have time, I'll be glad to have a review for this branch as well.13:13
bacabentley: i always push first.13:14
* bac assumed that was standard workflow13:14
abentleybac: However, lp-propose does it all over the API instead of using email, and it does the push for you, so it's more convenient and has basically replaced "send"13:14
abentleybac: lp-propose also supports prerequisite branches, unlike "send".13:14
bacabentley: ok.  is there a wiki page?13:14
sumanahabentley: does it include a template for the merge proposal?13:14
abentleysumanah: the lpreview_body plugin provides the template for lp-propose (as well as send).13:15
abentleybac: for lp-propose? No, it's a bzr command.13:15
abentleybac: Part of the launchpad plugin which ships with bzr.13:16
adeuringrvba: sure, I'll look at that one too13:16
rvbaadeuring: thanks/13:16
bacabentley: ok.  thanks.  we should dismantle the wiki page i posted13:17
abentleybac: There is https://lists.launchpad.net/launchpad-dev/msg06026.html13:17
sumanahbac, abentley - & point to http://doc.bazaar.canonical.com/plugins/en/launchpad-plugin.html ?13:18
abentleysumanah: That's the standard command help.13:19
sumanahabentley: sure seems like it, yes :-)13:19
abentleysumanah: I would not point at it, because people can get it from the commandline, and it will be the help that is accurate for their version.13:20
sumanahabentley: I'm documenting how Launchpad does its code review process, so my colleagues can use it as an example, so I need to point them to documentation of the tool support/infrastructure that you use as well13:20
abentleybac: did you see my messages yesterday?13:21
sumanahabentley: the people reading my summary will not have bzr installed, much less this plugin, so I would rather point them to a webpage with relevant documentation of this part of the process13:22
bacabentley: i did13:23
abentleysumanah: If it's your documentation, then of course it's your call.13:23
bacabentley: i've worked through most of the hurdles on that branch13:23
sumanahabentley: seems like you'd want reasonable documentation in the public eye -- on the web somewhere -- for the community devs, no?13:24
abentleybac: excellent.13:24
sumanahabentley: and point to it from the dev.launchpad wiki?13:25
abentleysumanah: If you want to document it for us, please put it on the wiki, rather than pointing to it.13:25
sumanahabentley: I'm surprised you didn't update https://dev.launchpad.net/Code/BzrSend when you sent that msg in Dec 201013:26
abentleysumanah: I'm not.  I was just trying to get the word out.  And at that point, I had some hope that "send" would eventually be fixed.13:26
sumanahabentley: what's inaccurate about http://doc.bazaar.canonical.com/plugins/en/launchpad-plugin.html ?13:26
abentleysumanah: If you're using an older version of bzr, lp-find-proposal won't exist, for example.13:28
abentleyI wrote that in the last year.13:28
sumanahI am the least expert person in this conversation and likely to introduce errors in any documentation I write about this plugin, but .... aaand I get an error even trying to log in to the dev.launchpad wiki.13:30
henningederyck: still travelling but almost back13:31
sumanahaha, it's because I have an OpenID. http://moinmo.in/MoinMoinBugs/OpenID%20login%20to%20Ubuntu%20wiki%20fails?highlight=%28\bCategoryMoinMoinBug\b%2913:31
deryckhenninge, ok, np13:31
sumanahbac: ok, I cannot log into the dev.launchpad MoinMoin wiki (bug filed), so thanks for updating https://dev.launchpad.net/Code/BzrSend13:49
sumanahor rather, even though I am logged in, I can't edit13:49
abentleybac: I don't know what happened, but when you merged from me today, you didn't get three revisions that I committed yesterday.13:53
bacabentley: sorry, i did see your note yesterday but haven't done the merge yet.  didn't know you'd be grabbing my branch.13:54
baci'll do it now13:54
abentleybac: Oh, my bad.  The merge I'm looking at wasn't today.13:54
abentleybac: If you could, that would be great, so we can get synced up.13:55
bacabentley: merging from yours now.  will let you know when i've pushed13:56
adeuringrvba: r=me for your init-series-not-close-bugs branch14:03
bacabentley: pushed, though i've still got work to do on the branch.14:12
abentleybac: I have it working (with some hacks to the old version of your code) on the translation sharing details page.14:13
rvbaadeuring: Thanks (sorry for the delay, OTP). Instead of checking the bug's status I'll use the fakemethod trick to make sure the close_bugs_... method has not been called. It's best to do that because that is precisely what this test wants to check (as opposed to calling the method and failing with a permission denied error)14:17
bigjoolsadeuring: hi, can I get a review please! https://code.launchpad.net/~julian-edwards/launchpad/pcj-requester-bug-810957/+merge/6808114:17
adeuringrvba: sure, makes sense14:17
adeuringbigjools: sure14:18
abentleybac: Your latest changes work for me, with this patch: http://pastebin.ubuntu.com/644806/14:26
bacabentley: yeah, that makes sense14:27
sumanahbac: it's a bit difficult to search for information about how you deploy Launchpad -- is there an overview I am missing about your deploy/release process14:36
sumanahbac: I see https://dev.launchpad.net/QAProcessContinuousRollouts  -- aha, points to https://dev.launchpad.net/MergeWorkflow .  Is that reasonably accurate?14:37
* bac reads14:39
bacsumanah: https://dev.launchpad.net/QAForContinuousRollouts?highlight=%28qa%5C_reports%2914:39
bacer, https://dev.launchpad.net/QAForContinuousRollouts14:40
sumanahthank you bac!   I should be looking for "rollout" and its variations rather than "deploy"14:41
=== al-maisan is now known as almaisan-away
sumanahmrevell: I appreciate the wordplay & graphics in your blog posts :-)14:52
mrevellthanks sumanah :)14:53
=== flacoste changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring,bac | Critical bugs: 218 - 0:[######=_]:256
adeuringbigjools: your branch looks good. I don't see any usage of the job.requester, but I assume that will follow in another branch?14:54
bigjoolsadeuring: correct!14:54
bigjoolswas just doing this separately for ease of review14:54
adeuringbigjools: ok, so r=me (I appreciate that your deferred implementing the usage here -- would have made the branch even longer ;)14:55
bigjoolsadeuring: well the other reason is that I have another branch in progress but it depends on this before I can fix it further. :)14:55
bigjoolsadeuring: thanks for reviewing14:55
sinzuideryck, I want to nuke lib/lp/scripts/utilities/lpwindmill.py and its only caller, bin/jstest. Are these oversites from our removal of windmill?14:59
derycksinzui, yes, just oversite.  I mean to go back and remove them.  Kill at will. :)15:01
flacostedanilos: what's the story behind qa-bad of bug 806925?15:18
_mup_Bug #806925: Replace bug task, ppa details and package details expanders <bad-commit-13421> <qa-bad> <tech-debt> <ui> <Launchpad itself:Fix Committed by danilo> < https://launchpad.net/bugs/806925 >15:18
flacostethere are is no comment on the bug15:18
gary_posterflacoste, what I know is this: a branch is landing now, and will hopefully be ready for qa later today15:31
gary_posterthat's according to our kanban board and morning call15:31
gary_posterhenninge, am I right that a question about why https://translations.launchpad.net/babelenterprise/+imports has not been approved should be transferred to the babelenterprise project?15:33
=== jpds_ is now known as jpds
flacostegary_poster: thanks15:34
gary_posteroh, no, this guy asking is the owner of the project15:34
henningegary_poster: No, approvals still need to be done either automatically by the script or by a lp engineer15:34
henninge"the autoapprover script"15:34
gary_posterhenninge, so should it have shown up here for lp devs to review https://code.launchpad.net/+code-imports?field.review_status=NEW ?15:35
henningegary_poster: that's code imports, you were asking about transltion imports.15:36
gary_posterand henninge, can I just approve this poor guy so he can move on with his life, or do I need to...check something first?15:36
gary_posterhenning, aygh!  https://translations.launchpad.net/+imports/+index?field.filter_target=[PRODUCT]&field.filter_status=NEEDS_REVIEW&field.filter_extension=pot15:37
gary_posteraugh I mean15:37
henningegary_poster: yes, you can approve. That is part of CHR duties (until we fix that)15:37
gary_posterlooks like there has been some confusion about who needs to do what since the thunderdome15:37
henningegary_poster: I was told orange did CHR last week (I was on leave)15:37
henningegary_poster: but I can work down that queue fairly quickly I think15:38
gary_poster(yeah henning, I think danilos did not realize we were on CHR this week somehow, even though we talked about it :-( )15:38
gary_posterthank you henninge!  I'd really appreciate it15:39
henningeargh ...15:40
henningebad file naming15:40
henningegary_poster: actually, I will not approve them and you shouldn't either15:44
gary_posterok henninge15:44
gary_posterhenninge, is there a quick reason why?15:45
gary_poster(I'd like to reply to the question too, https://answers.launchpad.net/launchpad/+question/163067)15:46
henningegary_poster: I will ask the uploader to rename the files so that the template name is extracted automatically15:46
henningeall the files are named translations/translations.pot15:47
henningebut they should be modulename.pot15:47
gary_posterok henninge.  So I can close the question, saying that we have replied to the translation request with details on what to fix?15:47
henningegary_poster: hang on, let me look at the question first15:47
henningegary_poster: there is only one file in their queue and it is not approved automatically because es_es.po is not supported by Launchpad, it should be es.po.15:49
gary_posterah ok15:50
henningegary_poster: you can either approve it to spanish or ask them to re-upload with the correct name.#15:50
=== flacoste changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: adeuring,bac | Critical bugs: 242 - 0:[######=_]:256
gary_posterhenninge, to approve I would go to https://translations.launchpad.net/+imports/5558326 and selevct "Spanish (es)" and click approve, yeah?  I can do taht and then suggest a change for the future in the reply15:53
henningeyes, you can do that.15:53
gary_posterok thanks very much henninge!15:54
henningegary_poster: you also need to pick the template15:54
henningethere is only one15:54
gary_posterok that makes it easy, got it :-)15:54
sumanahbac, flacoste - draft sent.  Brad, I know I am getting it to you later than I said I would; can you still review today for inaccuracies?15:56
=== salgado is now known as salgado-lunch
=== beuno is now known as beuno-lunch
jcsackettcan someone point me to where LP.cache.context gets setup?16:28
abentleyjcsackett: We're in the process of changing that.  Right now, it's set up in lib/lp/app/templates/base-layout-macros.pt16:31
jcsackettabentley: ah, thanks.16:31
abentleyjcsackett: In my branch, it comes out of lib/canonical/launchpad/webapp/publisher.py, getCacheJSON.16:32
jcsackettabentley: that's as part of your ++cache++ stuff, right?16:32
abentleyjcsackett: Right.16:32
jcsackettcool. i'm just trying to understand the current picture i'm working with. i look forwards to seeing your work land. :-)16:33
abentleyjcsackett: (though we're calling it ++model++ to try to reflect its real significance)16:33
jcsackettabentley: that does seem like a better namespace.16:33
abentleyjcsackett: my branch is ~abentley/launchpad/json-serialization16:33
sumanahbac: just checking -- do you think you'll be able to get me a critique today?  just looking for inaccuracies & gross omissions16:41
jcsackettabentley: do you know of any gotchas about the json cache (aside from it not working for anonymous users) that would lead to me placing something in it only to find nothing there on the page?16:48
jcsackettfor context, in lib/lp/app/widgets/popup.py i'm trying to add in some global picker config options, but nothing i put in can be found once i'm on a page with a picker.16:49
jcsackett(actually, right now i'm scaled back to just trying to put a random string in).16:49
bacsumanah: yes16:49
=== matsubara is now known as matsubara-lunch
=== salgado-lunch is now known as salgado
=== adeuring changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: bac | Critical bugs: 242 - 0:[######=_]:256
=== beuno-lunch is now known as beuno
abentleyjcsackett: Nothing comes to mind off the top.  Are these basic python types or exported web service entry types?17:33
jcsackettabentley: basic types. i think it may have something to do with trying to do it in the widget, rather than a view's initialize method (where every other example of adding to the cache seems to do it).17:35
abentleyjcsackett: I'm not sure of the order of operations, but it's conceivable that the widget is rendered after the jsoncache.17:36
jcsackettabentley: yes, i think that's the case.17:37
jcsackettoh well, this is what i get for doing something weird. i think i'll look into other approaches.17:38
=== deryck is now known as deryck[lunch]
jcsackettme(g) is starting to have a bad day. 14:1418:14
=== matsubara-lunch is now known as matsubara
abentleyderyck[lunch]: do we have a story for where test helpers go?18:56
=== deryck[lunch] is now known as deryck
deryckabentley, in lib/lp/app/javascript/testing/19:03
abentleyderyck: Ah, okay.19:05
* jcsackett sighs, having just noticed that somehow is empathy chats have been redirected into IRC.19:25
m4n1shwhat is this dependency granite for maya?19:59
m4n1sherr sorry again wrong window :919:59
=== matsubara is now known as matsubara-afk
=== wgrant changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: bac | Critical bugs: 239 - 0:[######=_]:256
wgrantLots of checks, looks like it's checking 44 times whether the user administers any more teams.21:42
wgrantI suspect the bugsubscription stuff.21:42
wgrantWhich we both identified as suspect.21:42
wgrants/bugsubscription/structural subscription/21:42
lifelessjust cause we're paranoid doesn't mean we're right...or wrong21:42
wgrantAlthough you put a workaround in there to stop it from executing multiple times.21:44
lifelessand tuned it somewhat as well21:44
wgrantHalf the code says "administrated", another half "administered"21:45
lifelessthat looks like either a change, or a different code path21:45
lifelessperhaps late evaluation ?21:45
wgrantLet's see if it renders on DF.21:46
wgrantAnd if so, traceback time.21:46
lifelessnew bug time too21:46
lifelesscan't see a match21:46
wgrant  [r=jcsackett][bug=809841] 'All-Ubuntu-derivatives' option for21:48
wgrant  process-accepted script.21:48
wgrantWhat could go wrong.21:48
wgrantOTOH, we are now below 300 lines of mochikit-using JS.21:50
wgrantsinzui: Does that mean we no longer depend on the hacked spidermonkey package?21:55
sinzuiwgrant, correct21:56
wgrantExcellent news.21:56
sinzuiI just removed the last vestiges of it 10 minutes ago21:56
wgrantAnd excellent deletion of embedded code.21:56
wgrantIt is gone from launchpad-dependencies?21:56
sinzuiit is21:56
sinzuiupdate and upgrade to 9421:56
wgrantPerhaps I will investigate YUI3 calendar widgets.21:57
wgrantBecause this YUI2 embedded in the tree irks me greatly.21:57
wgrantThe tour embeds jQuery.21:59
wgrantHow unpleasant.21:59
sinzuiwgrant, there were non last year21:59
sinzuiwgrant, we paid for the tour, and jquery is the defacto standard or js libs21:59
wgrantsinzui: Yes, and I like it, but I do not like embedding external dependencies in our tree :)21:59
sinzuiWe use datetime sometimes, but I wonder if that need can be factored out. datetime leads to bad notices that a release it overdue.22:02
wgrantsinzui: Are you sure you can remove python-profiler?22:05
wgrantsinzui: It provides pstats.22:05
wgrantWhich the test suite uses in two places.22:05
sinzuiit is identical to the pstats in py2.622:06
wgrantYes, but it's in a separate package because it's non-free.22:06
sinzuiwgrant, I saw only comment changes in the diff22:06
wgrantIt's the only part of stdlib that's in a separate package.22:06
wgrant$ dpkg -L python2.6 | grep pstats | wc -l22:07
sinzuioh ?22:07
=== rockstar` is now known as rockstar
wgrantpython-profiler is part of the standard library, but it's a separate package in multiverse because the 'profile' and 'pstats' modules are non-free.22:07
sinzuiI get 122:07
wgrantI am on natty.22:07
wgrantPerhaps oneiric has regressed.22:07
wgrantLet me see.22:08
james_wit's free now22:08
james_wso it's in the python packages in oneiric22:08
wgrantWas declared free, or was made free?22:08
wgrantsinzui: Depend on 'python2.6 (>= whatever version) | python-profiler', I guess.22:08
wgrant2.7.2-2 made the change.22:09
wgrantOh, nice.22:09
sinzuiwgrant, maybe I should fork lp-deps to only require python-profiler for natty/lucid22:09
wgrantthey got Disney to agree to relicense it.22:09
wgrantsinzui: No, just use the versioned disjunction.22:09
LPCIBotProject devel build #893: FAILURE in 5 hr 40 min: https://lpci.wedontsleep.org/job/devel/893/22:10
wgrantsinzui: odd, it's not in your 2.6, surely?22:11
wgrantI can only see the diff in 2.7.22:11
wgrantAh, no, there it is.22:11
wgrantThis also means we can remove the awful component checking stuff from rocketfuel-setup in 12 months.22:18
wgrantsinzui: So, are you fixing that up, or should I?22:22
sinzuiwgrant, I was trying to. I do not know how to write a ored statement that essential say, don't bother22:23
sinzuiwgrant, can you do it. I will read your change to know how?22:28
sinzuiwgrant, I am guessing that we also need to state Lp requires python 2.622:29
wgrantsinzui: Just depend on 'python2.6 (>= 2.6.7-2ubuntu1 | python-profiler'22:29
wgrant'python2.6 (>= 2.6.7-2ubuntu1) | python-profiler'22:29
wgrantIn addition to the usual python2.6 dependency.22:29
sinzuiThere is no python2.6 dep22:30
wgrantPerhaps we should fix that.22:30
wgrantLet me see.22:30
wgrantWe should really port to 2.7 in the next month or two. But I guess adding a 2.6 dep for now wouldn't hurt, as we now only get it accidentally.22:32
sinzuiwgrant, Is this the line to add theN22:34
sinzuipython2.6, python2.6 (>= 2.6.7-2ubuntu1) | python-profiler22:34
sinzuiI feel like a idiot writing it.22:34
wgrantsinzui: That would indeed work.22:35
wgrantIt feels odd, but is not uncommon.22:36
sinzuiI will proceed.22:36

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!