alecuDiegoSarmentero, I tried it like this00:00
alecu        stop: 0 #e44e19,stop: 1.0 #fecfc2);00:00
DiegoSarmenteroalecu, i tried00:00
DiegoSarmenteroalecu, looks nice00:00
DiegoSarmenteroalecu, do you want me to submit that?00:00
alecuyup, it's not perfect but will do till they choose a better combination.00:00
alecuDiegoSarmentero, sure00:00
DiegoSarmenteroalecu, definitly looks better00:00
DiegoSarmenteroalecu, ready!00:03
alecuDiegoSarmentero, cool, I've approved it. thanks!00:05
DiegoSarmenteroalecu, :D00:05
duanedesignkarni: ok :)00:07
karniduanedesign: Josh took care of it00:07
duanedesignaha, i was just about to ask :P00:10
duanedesignkarni: i updated the wiki to reflect the change to mobile contacts...it will be nice when the site reflects it as well00:11
karniduanedesign: Josh takes care of these kind of support messages (concerning contacts)00:12
faganmorning all, ill probably not be too attentive on IRC today since im working on 1 monitor because im waiting for a package downstairs but im working on testing the bundle maker all day anyway08:27
JamesTaitGood morning all!08:37
faganhappy friday JamesTait08:38
* fagan break09:46
faganWow windows takes bloody ages to install10:19
faganI gave it 2 processors and all and its still taking an hour10:19
fagan~, ];10:20
* fagan just made an emoticon by dropping his keyboard10:21
faganooh its working on the clean install of XP10:34
faganIll wait till ralsina_ gets in to +1 the branch just in case10:35
ralsina_fagan: here I am :-)10:47
faganralsina_: working perfect10:53
=== ralsina_ is now known as ralsina
faganralsina_: so I can +1 the branch if thats all thats needed10:54
faganralsina: so is it ok to +1 the branch then since its working or do I need to code review too10:56
ralsinaDo a +1, I will get a code review from nessita in a bit10:57
fagankk cool10:57
faganralsina: so whats the task now?10:59
faganI was thinking if there isnt any task I can do up some examples on using the APIs or what ever if you dont have any task in mind11:00
ralsinafagan: could you uninstall, and re-try with the latest version of that branch? It has a few changes11:00
faganralsina: what do you mean by uninstall?11:00
fagandid you update the branch more?11:01
ralsinaoh,right, you tried the bundles11:01
faganyep did11:01
ralsinaok, now try the installer :-)11:01
ralsinaGet bitrock installbuilder qt edition and follow the README11:01
faganralsina: will do11:01
ralsinacreate an installer, try it n the clean VM11:01
duanedesignmorning all11:25
faganmorning duanedesign11:27
* duanedesign needs to install the Windows Client today11:29
=== teknico is now known as teknico_away
faganduanedesign: I can give you the .exes for it if you want11:30
faganyou just need to unzip it and double click to test11:30
faganill pm you a link11:30
duanedesignfagan: cool, thank you11:31
* fagan break11:35
nessitagood morning everyone!11:57
ralsinagood morning nessita12:02
ralsinanessita, we have (another) big problem, and sorry to start the day this way :-(12:02
ralsinabasically, logging is broken in the way we use it on windows12:02
ralsinabug #81100612:03
ubot4Launchpad bug 811006 in ubuntuone-client "Problem with logfile rollover on windows (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/81100612:03
ralsinaWe are using a RotatingFileHandler and we are spawning subprocesses. That mix is a no-no.12:03
facundobatistaHola nessita12:04
facundobatistaralsina, spawning subprocesses?12:05
ralsinafacundobatista: yes, to activate ussoc from syncdaemon.12:05
ralsinafacundobatista: we don't have dbus to do it for us :-(12:06
facundobatistaralsina, so, SD spawn a process for the sso part, why it complicates the logging?12:07
ralsinafacundobatista: basically that doesn't work on windows, it's complicated and I understand half of it: http://bugs.python.org/issue4749#msg10182212:08
facundobatistaralsina, ah, because the other process also wants to log in the same file?12:09
ralsinafacundobatista: not even needs to do that,it seems12:09
ralsinafacundobatista: it seems the file handle is inherited by the child process and then it's broken for the parent12:09
nessitamy phone went deade for 10 minutes, if anyone spoke to me, please repeat :-)12:11
ralsinanessita: bug #81100612:15
ubot4Launchpad bug 811006 in ubuntuone-client "Problem with logfile rollover on windows (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/81100612:15
nessitaralsina: hey there!12:15
ralsinaI guess my hello was missing too :-)12:15
nessitaralsina: by any chance, did you cacth up with mandel? I Was wondering if he said something related to the email I sent last inght12:16
ralsinadidn't see him12:16
jo-erlend_is there a ubuntu one openid url I can use?12:16
faganralsina: he was online from 8-10:30 ish and then left12:17
ralsinafagan: thx!12:17
faganjo-erlend_: https://login.ubuntu.com12:17
faganjo-erlend_: im pretty sure thats it12:17
jo-erlend_fagan, I mean in order to identify to other sites.12:17
faganThen try login.ubuntu.com/~yourlaunchpadid12:18
* fagan checks too 12:18
fagannope doesnt work12:19
facundobatistanessita, ralsina: http://bugs.python.org/issue4749#msg8921812:19
ralsinafacundobatista: I can try that, see if it helps12:20
nessitafacundobatista: does syncdaemon call subprocess? :-/12:20
facundobatistanessita, no that I'm aware of12:20
facundobatistanessita, but ralsina tells me that we're spawning subprocesses12:21
nessitanot within syncdaemon12:21
nessitaralsina: ^12:21
ralsinanessita: it calls Popen for the tcp activation of ussoc?12:21
faganjo-erlend_: could you not do it with lp instead?12:21
facundobatistaralsina, where?12:21
nessitaralsina: but that's syncdaemon itself...12:21
nessitaralsina: I'm not sure that counts... does it?12:22
ralsinanessita: well, since the bug happens it might12:22
ralsinaI am about to test it and tell you ;-)12:22
ralsinaNo, doesn't help12:23
nessitaralsina: how it happened? I mean, it happened when closing syncdaemon? when running a new syncdaemon? or in the middle of a run?12:23
ralsinanessita: I apparently left syncdaemon running12:23
ralsinaSo I probably have a big log12:23
ralsinaAnd now when I start it, I get that12:23
facundobatistaralsina, I'm lost, where SD is spawning other process?12:23
faganjo-erlend_: actually putting  https://login.ubuntu.com  works12:24
nessitaralsina: syncaemon always rotates logs at startup. YOu may have another syncdaemon running12:24
ralsinanessita: I don't12:24
nessitaralsina: how do you kill the a running syncdaemon?12:24
nessitas/the a/a12:24
ralsinanessita: with the process manager12:24
faganBut it doesnt have a fancy page like on lp when you click the link12:24
nessitaralsina: hum...12:25
jo-erlend_fagan, nice! Thanks :)12:27
facundobatistaralsina, I'm lost, where SD is spawning other process?12:29
ralsinafacundobatista: I don't know how it's done, but on windows, when sd needs ussoc, it's started.12:30
ralsinafacundobatista: I am trying to follow that code now12:30
ralsinafacundobatista: when sd calls UbuntuSSOClient.connect() that checks if the sso port is unused, and starts sso using subprocess.Popen12:32
ralsinanessita: ^12:32
ralsinaunless I completely misunderstood the code, of course12:32
ralsinaAnd if I start ussoc manually before sd, it works perfectly. So I think that's it.12:36
nessitaralsina: but...12:36
nessitaralsina: ah! I understand12:36
facundobatistanessita, do you?12:36
nessitafacundobatista: yes, let me explain quickly12:36
nessitafacundobatista: on linux, we acess the SSO service by dbus activation, yes?12:36
nessitafacundobatista: on windows, there is no such thing, so we need to start the SSO service "by hand", that is done via subprocess.Popen12:37
nessitafacundobatista: and sso may be inheriting syncdemon fds, which has no practical sense12:37
ralsinabad news is, making it close_fds doesn't fix it12:38
nessitaralsina: you should kill sso now12:39
nessitaralsina: since sso already has access to the file12:39
facundobatistanessita, yes12:39
ralsinaI killed it first.But I'll try again12:39
facundobatistaralsina, so, you tried close_fds on the Popen of tcpactivation.py, line 130 ?12:40
ralsinafacundobatista: right12:40
ralsinagood news, that does fix it!12:41
nessitaok, telecom my cut off my phone line any minute now12:41
facundobatistaralsina, -.-12:41
nessitafor a couple of minutes they say12:41
facundobatista<ralsina> bad news is, making it close_fds doesn't fix it12:41
facundobatista<ralsina> good news, that does fix it!12:41
facundobatistanessita, we'll miss you12:41
ralsinafacundobatista: would you prefer it to be the other way around? ;-)12:41
facundobatistaralsina, I don't understand what works and what doesn't12:42
ralsinafacundobatista: looks like I had a stale process somewhere12:42
facundobatistaralsina, ah, ok, ok12:42
ralsinaso adding close_fds makes the logging problem go away12:42
facundobatistaso, close_fds works12:42
facundobatistamakes sense12:42
facundobatistaralsina, what you will *not* be able to do is to log from that new process into the same file, but we don't want that, so we're happy12:43
ralsinacool, this really scared me. The proposed "real" solution sounds like a lot of work.12:43
facundobatistaralsina, there's no "real" solution more than this12:44
ralsinafacundobatista: yes, do a socketlog server12:44
facundobatistaralsina, the other thing that is proposed in the python bug tracker12:44
ralsinafacundobatista: and use a sockethandler12:44
facundobatistaralsina, is for spawning different processess that all wants to log12:44
facundobatistain the same file12:44
facundobatistaso, as there's no good way to synchronize them all to use the same file12:44
ralsinafacundobatista: or if you need access to stdin/out/err, which close_fds closes too12:45
facundobatistayou need to log from a single process, and all the other ones to send the log lines to that one12:45
faganstandup in 1012:49
ralsinafagan: alecu and mandel won't be here, DiegoSarmentero finished his contract, nessita has obvious connectivity issues. Short standup! :-/12:50
faganralsina: yeah sounds like it12:51
faganAnd dob_ey is off12:52
nessitahello again!!!12:53
ralsinahello nessita! It seems using close_fds works12:53
nessitafacundobatista, ralsina: I missed everything from12:53
nessita(09:41:36 AM) facundobatista: <ralsina> bad news is, making it close_fds doesn't fix it12:53
nessita(09:41:41 AM) facundobatista: <ralsina> good news, that does fix it!12:53
faganhey nessita standup with you, ralsina and I in 712:53
ralsinanessita: *but* it means the spawned processes can't write to stdout/stderr. That should not be a problem, right?12:54
facundobatistanessita, pasting in private12:54
nessitaralsina: well, nothing too serious I guess12:54
ralsinanessita: at least we won't see it ;-)12:55
ralsinanessita: also, while telecom lets you see it, is this one known,or I file it? https://pastebin.canonical.com/49806/12:56
nessitaralsina: I just got a call from a Mr Telecom saying that I should not get more issues today (tm)12:57
ralsinaNice of Mr Telecom :-)12:57
nessitaralsina: we had one like that that mandel said it was fixed12:57
nessitaralsina: so, please file a new one12:57
ralsinanessita: ok, will file it12:57
nessitasince it may be the same not fixed or may be a new onw12:57
fagannessita and ralsina standup13:00
=== teknico_away is now known as teknico
nessitafagan: go13:01
fagan* test the updated py2exe script IRL13:01
fagan* do the bitrock bit before that and test that bit13:01
fagan* Nope13:01
fagannessita: go13:01
nessitaDONE: bug #810440, bug #810640, reviews, UDF testing + long report, meetings13:01
nessitaTODO: interview windows candidate, UDF debugging by looking at logs13:01
nessitaBLOCKED: nopes13:01
nessitaNEXT: ralsina13:01
ubot4Launchpad bug 810440 in ubuntuone-control-panel "QT UI: 'explore' button is too wide and looks ugly (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/81044013:01
ubot4Launchpad bug 810640 in ubuntuone-control-panel "QT UI: we need an asset for file sync error/alert (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/81064013:01
nessitaralsina: iuhu?13:02
fagannessita: what does iuhu mean?13:02
nessitafagan: like "iuuuuuhhhuuuuuu"13:03
fagannessita: hah13:03
Chipacafagan: yoohoo, i guess you'd write13:03
* fagan thought it was some spanish thingy 13:03
faganChipaca: yep that would parse better13:04
Chipacafagan: you parse in your lexer! that explains a lot13:04
nessitathat's cheating!13:05
* fagan is worried he might have to work downstairs on monday again if the package doesnt get here 13:06
nessitaralsina: you too? :-/13:09
ralsinanessita: yes13:10
nessitaralsina: go!13:10
ralsinanessita: but at least quassel saves my backlog :-)13:10
ralsinaDONE: * Windows call13:10
ralsina* Fixed bug #810719 (url signing)13:10
ralsina* Fixed bug #810674 (SSO timeout)13:10
ralsina* Improved #809873 (bundle-and-installer-making script)13:10
ralsina* Improved #810053 (credentials dont ping)13:10
ralsina* Lots of reviews13:10
ubot4Launchpad bug 810719 in ubuntuone-control-panel "Provide a function to oauth-sign URLs using the user's credentials (affects: 1) (heat: 6)" [Undecided,Fix committed] https://launchpad.net/bugs/81071913:10
ubot4Launchpad bug 810674 in ubuntu-sso-client "SSO-Client should live forever on windows (affects: 1) (heat: 6)" [Undecided,Fix committed] https://launchpad.net/bugs/81067413:10
ralsinaFound a few bugs earlier13:11
ralsinaTODO: fix bug #81100613:11
ubot4Launchpad bug 811006 in ubuntuone-client "Problem with logfile rollover on windows (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/81100613:11
ralsinaMergemy peding branches, then finish the installer13:11
ralsinaand by "installer" y mean the wizard13:11
ralsinaBLOCKED: no13:11
ralsinaOh, and I interviewed the candidate!13:12
* nessita -> interview, brb13:14
faganralsina: that job listing has been up for a long while it seems13:15
ralsinaoh, yes13:15
faganI suppose hr is a careful process13:15
ralsinafagan: no, it's just hard to find the right person13:16
faganralsina: yeah I could only guess13:16
* fagan has just been on the wrong side of the interview process13:16
ralsinathere is no right side of the interview process13:17
ralsinait has only wrongsides13:17
faganralsina: haha13:17
faganIm glad to see that a manager sees interviews as painful as the candidates13:18
ralsinaOk, adding to my TODO: move the freaking process forward in Taleo before it all rots13:19
=== zyga is now known as zyga-afk
lisettenessita: do you know if the installer & client use images for buttons?13:59
nessitalisette: I don't but I can find out, one sec :-)14:00
nessitalisette: nopes, just CSS. Example: background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1, stop: 0 #fedad1,stop: 1.0 #e47a55);14:01
lisettenessita: cool, thank you!14:01
=== m_conley_away is now known as m_conley
ralsinafacundobatista: just as a note, syncdaemon also spawns a subprocess on linux once: platform/linux/messaging.py14:10
facundobatistaralsina, that is aberrant :|14:12
ralsinafacundobatista: ?14:13
facundobatistaralsina, that there is code in the syncdaemon to start the ubuntuone-control-panel is very very ugly14:16
ralsinaoh, ok14:16
ralsinaHola alecu!14:27
nessitahi alecu14:28
alecuhi all14:28
alecuralsina, nessita: sorry again for the short notice. Luli told me about it yesterday noon, and I totally forgot.14:29
ralsinaalecu: no problem14:29
faganLuli is a great name14:30
alecuralsina, so, is trunk running for you still this morning?14:30
ralsinaalecu: ran into bug #81100614:30
ubot4Launchpad bug 811006 in ubuntuone-client (and 1 other project) "Problem with logfile rollover on windows (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/81100614:30
alecufagan, her name is Lucila, but we call her Luli.14:30
alecuralsina, ok.14:30
alecunessita, is trunk still broken for you?14:30
faganalecu: awh :)14:30
ralsinahow do I run one part of the test suite in ubuntuone-client?14:31
alecuralsina, python c:\python27\scripts\u1trial --reactor=twisted tests\platform\windows\test_ipc.py14:33
ralsinaalecu: thanks14:33
alecuralsina, I think u1trial also has a param to run a "match" of some tests... let me check.14:34
nessitaalecu: let me confirm, I haven't re tried14:34
alecunessita, please try trunk of sso, sd, u1cp14:34
nessitaalecu, ralsina, Chipaca: shall we mumble now?14:34
alecunessita, or whatever was broken for you better.14:34
alecunessita, mandel proposed to do it 3~4pm art14:34
nessitaalecu, ralsina, Chipaca: I can catch up with mandel later14:34
ralsinaok, then, let's14:35
alecunessita, mumble or skype?14:35
nessitamumble! :-D14:35
ralsinaalecu: argh, https://pastebin.canonical.com/49818/14:35
nessitaalecu: I'm at home, phone works *for now*14:36
nessitaChipaca: you available?14:36
ralsinaalecu: adding close_fds=True in ubuntuone-client/ubuntuone/platform/windows/tools.py line 443 breaks a test in a way I am not even close to understanding :-(14:51
CardinalFangIt doesn't even have fork(), right, so what does close_fds even mean?14:52
CardinalFang...assuming it's only run under Windows.14:52
CardinalFangEr, exec(), I mean.14:53
ralsinaCardinalFang: yes, it's windows only14:53
nessitaralsina: trace of the failure?14:53
nessitaralsina: is probably a tgrace from MOck that are *no-understandable*14:54
ralsinanessita: it's from mock alright14:54
nessitaralsina: show me! :-)14:54
ralsinanessita: I am trying to pick it up in the 17 tests that fail there14:55
alecuralsina, can you paste it?14:55
ralsinaalecu, nessita: https://pastebin.canonical.com/49822/14:56
ralsinaI am changing start, so I assume it should make test_start fail ;-)14:56
nessitaralsina: the test is expecting... notepad to be pass to subprocess.Popen14:56
nessita=> subprocess.Popen(['notepad'])  - Performed fewer times than expected.14:56
ralsinaI am adding one argument to Popen. If I add that in the mock,I get 23 test fails14:57
nessitayou need to tell mocker that you will call subprocess.Popen(['notepad'], close_fds=True)14:57
alecuralsina, that .start() is not used by the tcp activation.14:57
ralsinaalecu: oh, even beter14:57
alecuralsina, I think it could only be used by u1sdtool14:57
alecu(which we have not in windows yet)14:57
ralsinaalecu: then I am confused about how tcp activation works for sd14:58
ralsinaI know I fixed it in ussoc because it makes the error go away, I just assumed in sd it was done the same way14:58
alecuralsina, it uses ubuntu_sso/utils/tcpactivation.py14:58
ralsinaOh,cool, so it's only one fix14:59
alecuralsina, very likely!14:59
ralsinaalecu, could you review https://code.launchpad.net/~ralsina/ubuntu-sso-client/close_fds_sso/+merge/68101 ?15:07
alecuralsina, sure15:07
ralsinaIt's trivial only in appearance15:07
alecuralsina, I'm approving, but I have not tested it IRL.15:11
ralsinaalecu: the only possible bad side effect would be if sso or sd wrote to stdout/stderr, those will be closed15:12
ralsinaOk, I'm off to see the taxman!15:13
vividviolinI'm not sure that this is the right place for this, but I seem to be having trouble downloading music I bought from the ubuntu one music store15:17
vividviolinI bought an album and one of the songs downloaded fine, but the rest have been stuck as "queued" for about 15 minutes now15:18
vividviolinsimilar to what was described in http://ubuntuforums.org/showthread.php?t=149620015:18
nessitaralsina: shall the installer show the terms and conditions or that is not done yet?15:20
faganvividviolin: could you send a message to our support and they can sort it out for you https://one.ubuntu.com/support/contact/15:22
vividviolinokay, I'll do that.  Thanks!15:22
faganvividviolin: np15:22
nessitaralsina: bug #81109915:26
ubot4Launchpad bug 811099 in ubuntuone-windows-installer "Terms and conditions is not shown (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/81109915:26
* DiegoSarmentero is away: Not here... send me an e-mail! :P15:29
nessitaralsina: bug #81110315:32
ubot4Launchpad bug 811103 in ubuntuone-windows-installer ""Set up Account" can not be clicked and there is no indication of what's wrong (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/81110315:32
nessitaralsina: bug #81110915:43
ubot4Launchpad bug 811109 in ubuntuone-windows-installer "The sign in form can be submitted even if no captcha solution was entered (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/81110915:43
nessitaralsina: bug #81111115:45
ubot4Launchpad bug 811111 in ubuntuone-windows-installer "There is no visual indication that the form is being processed (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/81111115:45
nessitaralsina: bug #81111615:49
ubot4Launchpad bug 811116 in ubuntuone-windows-installer "Last screen shows "are you sure" dialog when closing the wizard (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/81111615:49
nessitaDiegoSarmentero: I finished the review, I added a couple of needs fixing, but very little ones15:50
nessitaDiegoSarmentero: also attached some screenshots of some weird effects I see in the VM I tested that in15:50
nessitaDiegoSarmentero: let me know if you have any question!15:50
=== nessita1 is now known as nessita
nessitaDiegoSarmentero: did you see my messages? my internet went crazy for a couple of mins15:53
faganralsina: ok tested and working fine15:54
faganthe installer works nicely :)15:55
=== nessita1 is now known as nessita
faganralsina: I can give you the installer I built if you want15:56
=== nessita1 is now known as nessita
faganralsina: ill pm you the link anyway since you dont seem to be around16:02
fagan(and since im just about to EOW16:02
nessitaok, I'm off for lunch16:07
* fagan EOW16:10
=== beuno is now known as beuno-lunch
* DiegoSarmentero is back (gone 01:04:22)16:34
Chipacaralsina: ping16:53
ralsinaChipaca: pong17:13
ralsinanessita: I'll check the bugs you mentioned now17:16
ralsinathanks fagan!17:16
nessitaralsina: no need to do it now, I just noticed all those when reviewing the installer branch from diego17:16
=== beuno-lunch is now known as beuno
ralsinanessita: "Setup new account" should not be enabled until you accept the terms17:21
nessitaralsina: hum, that is not happening to me, unless the theme is hiding that?17:22
ralsinanessita: the theme can not enable a disabled button. Here' how it looks for me: http://screencast.com/t/EchuDTVm17:23
ralsinanessita: and here is the TOS being displayed17:24
nessitaralsina: can you please try with the branch from Diego?17:24
ralsinanessita: sure17:24
nessitaralsina: about the TOS, I attached a screenshot as well, and my wins since it does not work :-P17:24
nessitaralsina: also, ping again about the bandwidth/file sync setting modification. Did you send the email yesterday?17:26
ralsinano, sending it now17:26
ralsinanessita: TOS with diego's branch17:28
nessitaralsina: did you see my screenshot?17:28
ralsinaAnd "Setup Account is disabled"17:28
ralsinanessita: dn't see links t screenshot in the backlog17:29
nessitaralsina: is in the bug report17:29
nessitaralsina: how can we debug my env? because that is not working here (in the VM)17:29
ralsinanessita: that could be just that the page didn't load for some reason17:30
ralsinaDiegoSarmentero, nessita: a real problem is that the disabled button looks exactly like an enabled one ;-)17:31
nessitaralsina: then we need to handle that, otherwise the suer experience is ugly17:31
nessitaralsina: also, I would expect some sort of spinner while the TOS loads17:31
nessitacan we do that?17:31
* beuno chears for nessita 17:31
DiegoSarmenteroralsina, yes, we could specialized the buttons with an object name17:31
ralsinanessita: of course we can17:32
nessitaDiegoSarmentero: I think what ralsina says is that we need a specific style for disabled buttons... (I *think*)17:32
DiegoSarmenteronessita, ahhhh17:32
ralsinaDiegoSarmentero: it's just the disabled state, it's not specific to a button17:32
DiegoSarmenteroralsina, yes... it's kind of confusing actually17:32
nessitabeuno: thanks, you must know people is hating me already :-D17:32
nessitaso I'm doing a great work! (?)17:33
beunonessita, if nobody hates you, you're not trying hard enough!17:33
ralsinanessita: bug #811116 is actually a design bug17:33
ubot4Launchpad bug 811116 in ubuntuone-windows-installer "Last screen shows "are you sure" dialog when closing the wizard (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/81111617:34
ralsinanessita: since the only call to action is "start the dashboard", closing the window is cancelling.17:34
nessitaralsina: design asked us to show the are you sure button in that specific screen?17:34
nessitaralsina: ...17:34
nessitaI disagree17:34
nessitathe user may open the dashboard later17:34
ralsinanessita: and the request is that the dialog shouldappear at any attempt to cancel the installer17:34
ralsinanessita: then we need to offer a finish  button17:34
nessitaI agree to that, but closing the last window is not cancelling17:35
nessitaclosing the last window is not canceling! :-)17:35
ralsinanessita: closing a dialog is calling it's "reject" method17:35
nessitaralsina: I think you're mixing implementation details with design spec17:35
ralsinaBut yes, I can specialcase it17:35
ralsinabug #811111 is actually a SSO-qt bug.17:37
ubot4Launchpad bug 811111 in ubuntuone-windows-installer "There is no visual indication that the form is being processed (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/81111117:37
nessitaralsina: ok, I'll re-assign that one17:37
nessitadone: bug #81111117:38
=== zyga-afk is now known as zyga
ralsinanessita: you agree to merge https://code.launchpad.net/~ralsina/ubuntu-sso-client/close_fds_sso ? Without that I can't test much :-(17:39
nessitaralsina: looking17:39
alecutwo branches, two! https://code.launchpad.net/~alecu/ubuntuone-client/status-changed/+merge/68116 and https://code.launchpad.net/~alecu/ubuntuone-control-panel/use-status-changed/+merge/6811717:39
DiegoSarmenteroralsina, about that last issue, you can use the dot animation i created for control panel, that animation doesn't need and extra window or space between the widgets, it's going to appear above the actual form.... just a thought17:39
ralsinaDiegoSarmentero: yes, I was thinking about that17:40
nessitaralsina: yes with a request: can you please add a huge comment before setting close_fds= True? point to the python bug report as well, so later no one revert that17:40
ralsinaI can hook the signals from the webview to show/hide it17:40
ralsinanessita: sure!17:40
nessitaralsina: thanks17:40
DiegoSarmenteroralsina, right17:40
nessitaalecu: groso! and they work as well?!?!?! :-D17:51
nessitaalecu: I think you also fixed bug #811007 in the client branch17:54
ubot4Launchpad bug 811007 in ubuntuone-client "Syncdaemon is not exposing the "connect" method on windows (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/81100717:54
nessitaalecu, ralsina, Chipaca, man<tab completion failure>: mumble  in 6 minutes17:55
ralsinaman<tab completion failure> will be there? ;-)17:55
nessitaralsina: I reply to the email cc'ing the address he requested17:56
nessitaralsina: so, I hope so17:56
nessitaI'm killing some easy bugs while I wait for the mumble, ralsina, could you review? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/use-u1lint/+merge/6812017:57
ralsinanessita: sure17:57
* alecu is having a real quick lunch17:58
ralsinanessita: +1 on that last one17:59
ralsinanessita: couldyou take a look at https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/67894 ?18:02
ralsina nessita: you did the code review yesterday, IIRC, it had a small issue running tests which I just fixed18:03
nessitaralsina: yes, I owe you that one18:03
nessitaalecu: can you mumble?18:14
alecuI'm joining mumble18:15
mandelnessita, alecu, ralsina: I'm back to work :)18:18
nessitamandel: mumble?18:19
ralsinamandel, mumble?18:19
mandelnessita: sure, sorry I was a little late, I could not find a cibercafe18:19
mandellaunching t right now,...18:19
ralsinaalecu: trade you one of yours for this silly one: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-811116/+merge/6812519:07
nessitaalecu: -client approved, -control-panel with simple needs fixings19:17
ralsinanessita: TDD fix for #811116 ---^19:18
nessitaralsina: ack, I 'll first do the "old" one I owe you19:18
* ralsina actually wrote the test first in this one19:19
ralsinaalecu: +1 on  -client19:20
nessitaralsina: question... in the fix-810053 MP you say:19:28
nessitaset PYTHONPATH=..\fix-810053;..\ubuntuone-control-panel;.19:28
nessitapython bin\windows-ubuntu-sso-client19:28
nessitaI'm not sure what you mean with that pythonpath19:28
nessitaralsina: I need to run ussoc using what branches exactly?19:28
ralsinaYou need to run ubuntu-sso-client having this branch in its PYTHNPATH so it can import the custom GUI19:28
ralsinaussoc can be trunk19:29
nessitaah... tricky19:30
ralsinathat whole branch is tricky19:30
nessitaralsina: but why the control panel?19:30
nessita(in the pythonpath)19:31
ralsinabecause installer imports controlpanel19:31
nessitaI see19:34
nessitaI see == euphemism("ouch!") :P19:35
nessitaralsina: can't make it work :-( I will try to grab a screenshot of what is happening19:37
ralsinanessita: yes, this whole architecture is based on something that, were it done in other languajes, would be called "code injection vulnerability" :-)19:37
nessitaralsina: ok, in the PATH for running ussoc you need to also add u1client19:41
mandelralsina: code injection is good, the problem is that in python it can be a problem… in a casted lang is not ;)19:41
* mandel waits for arguments from the python fans...19:42
nessitaalecu: let me know when the needs fixing are fixed, I ll re-review19:42
ralsinamandel: ok, "arbitrary code execution" :-)19:42
mandelralsina: much better hehe19:42
nessitaralsina: I'm getting this traceback within sso: http://paste.ubuntu.com/64497219:45
* ralsina looks19:45
ralsinanessita: ok, it's one of those attributes. Pushig a fix in 1'19:45
nessitaralsina: also, the installer should also add callbacks to credentials_not_found and user_cancellation19:46
nessitaralsina: so the binary stops running if the user cancels19:46
nessitaralsina: not sure if you understand what I mean19:46
ralsinanessita: you mean if the user cancels in the UI, make the installer binary stop19:46
ralsinamakes sense, didn't try that19:47
nessitaralsina: in ubuntuone_installer/gui/qt/main/windows.py, you need to also add code like this;19:47
nessitaclient.sso_cred.on_credentials_found_cb = found19:47
nessitafor not found and user cancellation19:47
ralsinaok, will do that and the help_text fix in a few minutes19:47
nessitaI'll review the simple one19:48
nessitaralsina: do we have a bug report to be able to open  subprocess.Popen(["ubuntuone-control-panel-qt", ]) in windows?19:54
mandelalecu, nessita, ralsina: I'm of, I found the issue with the import error yet I have not fixed it, will be done early morning on moday so I can get your revies19:54
ralsinanessita: no, we don't.19:54
mandelhave a good weeked!!!!19:54
nessitamandel: ack19:54
nessitaralsina: ok, I'll fill it19:54
ralsinanessita: if we can assume it's being run from the installed version, it's trivial19:55
nessitaralsina: trivial how?19:56
ralsinanessita: it's in the same folder as the installer binary and ussoc's binary so, use __file__19:57
nessitaralsina: that will not work on linux, so if we do that let's please file a bug to make it, later, multiplatform19:58
ralsinanessita: agreed. On Linux we can trust PATH, so as it is it should work on Linux19:58
ralsinaSo, in thebug put "don't break linux" :-)19:58
nessitaralsina: hehe19:59
nessitaralsina: another thing: the "Add folder" button does not work, but I did not file a report19:59
nessitaI guess you mentioned you still have to work on that?19:59
ralsinanessita: no, that has a bug already19:59
nessitabug #81124619:59
ubot4Launchpad bug 811246 in ubuntuone-windows-installer "The Control Panel is not opened in the last step (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/81124619:59
ralsinabug #80037619:59
ubot4Launchpad bug 800376 in ubuntuone-windows-installer "Add "syncing your computer to the cloud" page to the installer (affects: 1) (heat: 8)" [High,In progress] https://launchpad.net/bugs/80037620:00
nessitaralsina: I swear I'm running your branch fix-811116, with proper PYTHONPATH and all, I double check. Hitting close with bring the Are you Sure dialog20:06
nessitawill grab screenshot20:07
ralsinanessita: ok20:07
ralsinanessita: check your PYTHONPATH for ussoc, though. If ussoc is picking up the other branch you were reviewing, then this branch is not being used at all :-)20:07
nessitaralsina: but..20:08
nessitaralsina: the fix-811116 does not have the 053 in it20:08
ralsinaok, yes, you are right20:08
nessitaso what you say is not true, I think20:08
nessitaI thought about that too...20:08
nessitaralsina: is it working for you?20:08
nessitaI'm clicking the red cross at the right top corner20:08
nessitaralsina: forget what I said20:09
ralsinare-checked, yes, it works for me20:09
nessitait was a major PICNIC20:09
ralsinahope you had nice sandwiches :-)20:09
nessitaI branched trunk and forgot to merge your branch in it ;-)20:10
nessitaralsina: it works!!! sorry for the false alarm20:13
ralsinanessita: np20:13
ralsinanessita: I had absolute faith in the test anyway ;-)20:13
nessitaralsina: that's my boy!20:13
nessitaI'm so happy you say that20:13
nessitaralsina: approved20:14
ralsinanessita: Ithik you may have noticed a marked improvement in the quality of my branches this week20:14
nessitaralsina: yes, and I'm very happy about that20:14
ralsinanessita: it was 50% rust20:14
nessitaok, I have a medical appointment I need to attend to20:14
nessitaralsina: I'll be back to re-review your branch20:15
ralsinaok, good luck!20:15
nessitaand then I'll call it a wekk20:15
ralsinanessita: hope I get it in good shape, it's getting tricky20:15
* nessita -> away20:15
jo-erlend_in the couchdb "contacts", I see a field called application_annotations. It contains "Evolution" and a revision date. What does that do, and is it special for that database or is it a general thing?20:17
DanRabbitthreeve: hey dude, I got TestFlight installed and that, but it says I'm waiting for approval from the dev team :)20:28
threeveDanRabbit: hi Dan.  I think all that means is that I haven't published a build that you can install yet.20:28
DanRabbitthreeve: okay cool, just making sure I'm all set up.20:28
threeveDue to the way iOS provisioning works you'll only have access to new builds20:29
threeveDanRabbit: yeah, I got some emails so you should be all set.20:29
DanRabbitthreeve: so how do you want to do this thing? I know that the typical Canonical design pattern is to just kind of hand of wireframes and flow charts and stuff. But what's important for you guys?20:30
threevehmm...  "everything"?  wireframes and flows are good to get started, but if you want to provide more detailed visual comps I'm down with that too, down to precise control placement, etc.20:31
DanRabbitthreeve: okay cool. I just want to make sure that whatever I'm doing is for the benefit of helping you guys code the app and not just busy work20:32
threeveI'm open to receiving as much input and guidance as you want to provide given your work load.  If we cross the line into busy work I won't hesitate to let you know ;)20:33
DanRabbitokay awesome. Where are you guys at with it right now?20:33
threevesquare 1.  I will be starting dev on Monday.20:33
DanRabbitokay cool, so clean slate :)20:34
threevevery much so.  We aren't basing this app off of some other project/app so we have lots of flexibility I think20:34
* threeve likes clean slates20:35
DanRabbitthreeve: sweet. I starting working on some login stuff yesterday, so I'll keep going with that and I'll send you some mocks and a flowchart so you have something to work with on Monday :)20:35
* DanRabbit does as well ;)20:36
threevesounds great, look forward to seeing what you come up with!20:36
DanRabbitfor sure :D20:36
DanRabbitthreeve: I have some ideas about some visual styling for elements too. I dunno how far you want to go into it, but I figure I'll show it off and see what you think ;)20:37
threeveDanRabbit: I've done quite a bit of UI customization on iOS, so I can probably handle most anything you can come up with. :)  Once I see it I'll be able to give you a idea of the effort.20:38
DanRabbitthreeve: sweeeeeeet :D20:38
* threeve could tell you horror stories about UI customization on iOS.20:38
DanRabbitwell it's not anything maddening. Just want to get something that feels like iOS but also feels like Ubuntu20:39
threeveIf you can come up with a good, for lack of a better word, "theme" then we could maybe backport it to the other apps too.20:40
karniduanedesign: thanks for letting me know about RTs :)20:58
duanedesignkarni:  your welcome :)21:05
karniduanedesign: That one (as quite few of them) was easy. We just have to surface few more configuration settings.21:06
duanedesigni need to go back and read them. Maybe i can help you with some of the easier ones21:07
karniduanedesign: Most frequest are "Login failed" which will be solved with the SSO I implemented, and how to upload all pictures once user asked to upload "Future only" pictures [by deleting configuration files :)]21:09
karniduanedesign: That's ok, they hardly take me any time to reply :)21:10
karniduanedesign: Fell free to answer them, if you know the answer, though :) Of course it's a team effort :)21:10
jo-erlendI need a little help. Because desktopcouch sync has been down, I asked support for a copy so I could install it again here. I had deleted it because I knew I had a copy on u1. In the reply, I got a copy of my database. The instructions told me to shutdown desktopcouch by running /usr/lib/desktopcouch/desktopcouch-stop, replace the file and then run this script: http://paste.ubuntu.com/645028/21:30
jo-erlendas far as I can tell, the only thing that does it so launch the futon web ui. And that works. All my contacts are there. But now Evolution cannot use that database anymore. It gives me this error: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._e_2ddata_2dbook_2derror.Code100: Cannot open book: Could not create DesktopcouchSession object21:31
jo-erlendto me, it sounds like desktopcouch isn't running or something. But using futon works as well as it always has. Any ideas?21:33
alecuralsina, ping21:37
ralsinaalecu: pong21:38
alecuralsina, what does "print sys.platform" shows on your 7-64bits?21:38
ralsinawin32 butmay be because I have 32-bit python21:38
alecuralsina, cool, thanks.21:38
jo-erlendany ideas at all? It's kinda important to me to get this fixed quickly.21:43
alecuralsina, the fixes that nessita requested on my latest u1cp branch are ready, so you may want to re-review: https://code.launchpad.net/~alecu/ubuntuone-control-panel/use-status-changed/+merge/6811721:46
jderoseCardinalFang: what CouchDB version is going to ship in Oneiric?21:52
karninessita: I've sent you the talk with Ricardo regarding the link the email VS oauth signed validate_email call22:10
karnialecu: ping22:22
karnirye: ping22:22
alecukarni, pong!22:22
karnirye: unping22:22
karnialecu: hi :D!22:22
alecuhey there :-)22:23
karnialecu: I have one question about the api.ping() call22:23
karnialecu: The rough documentation says that the token must be in a form of22:23
karnialecu: "Ubuntu One @ foobar"22:23
karnialecu: Why the requirement? Is it really a must?22:23
karnialecu: If I created "Ubuntu One Files @ foobar" and pinged U122:23
karniwould it get the token correctly?22:23
alecukarni, I'm prety sure the ping server parses the " @ " somehow. Let me check.22:24
karnialecu: much thanks22:24
karniI love the timezone difference. I can ask a question after midnight, and you guys are still available =D22:25
alecukarni, I'm not supposed to be here at 19.30 on a friday, but anyway... :-)22:26
karnialecu: Neither am I =D But I'm happy you're here :)22:26
alecukarni, I'm looking at the server code, and not only the @ but the whole "Ubuntu One @ " is mandatory22:26
karnialecu: :<22:26
alecukarni, that's because there can be a few different services requesting credentials from sso, ie: the software center22:27
karnialecu: so, the api.ping() call with only succeed on Ubuntu One side, if the SSO contains an "Ubuntu One @ xxx" token?22:27
karnialecu: right. and that service can have multiple applications (how about that ;) )22:27
alecukarni, and when a ping happens on the server side we get all credentials from sso, filter the ones not starting with "Ubuntu One @ " and only copy those to our local databases.22:28
karnialecu: I worked it around and named my tokens like "Ubuntu One @ NexusOne Files" or "Ubuntu One @ NexusOne whatever_fancy_app_name" so they're readable22:28
alecukarni, it makes sense.22:28
karnialecu: awesome, I'm happy to know that22:28
karnialecu: okidoki, much thanks!22:29
* nessita is back22:38
nessitaalecu: on it!22:38
alecuwelcome back!22:39
alecuso, did the doctor find you "sane" ?22:39
nessitanot at all, of course22:40
nessitaalecu: I'm still hunting a doctor that will tell me that I can eat wheat with no problems22:41
nessitaI'm not succeeding22:41
=== m_conley is now known as m_conley_away
nessitathis doctor was nice, but he redirected me to another22:42
karninessita: I'm seeing a 'doctor' keyword, I hope you're healthy!22:52
nessitakarni: doctor says I need to eat gluten-free meals, but is too hard so I'm trying to find a doctor that says that the other doctors are wrong :-)22:53
karninessita: Sounds like a good plan!22:53
karninessita: Quiek question - does pinging staging U1 pull tokens from Staging SSO? Or you only tested ping on production U1 with production SSO?22:59
alecukarni, no idea about how staging u1/sso works related to credentials.23:03
karnialecu: Roman played with it recently, I'll ask him :)23:04
alecuyeah, probably he's awake right now, it's only 2AM in kiev :-)23:04
karnialecu: yeah, he's in the next timezone to me :)23:06
* nessita -> eod23:10
nessitaunless you alecu need me for something?23:10
alecunessita, have a nice weekend :-)23:16
nessitayou too!23:16
nessitabye all23:16
karnizomg.. Now it takes 9 hours to travel ~420km on express train in Poland x_O23:16
karnibye nessita, take care23:16

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!