| daker | mhall119, cjohnston nigelb does anyone have a log of bug 806005 ? | 11:47 |
|---|---|---|
| ubot4 | Launchpad bug 806005 in loco-directory "Error (as opposed to validation error) given if person enters more than 32,000 for 'number of guests' (affects: 1) (heat: 7)" [Undecided,New] https://launchpad.net/bugs/806005 | 11:47 |
| coalwater | sounds like some sort of overflow mabye? | 11:58 |
| coalwater | sadly i don't have access to test it | 12:03 |
| coalwater | daker, can u tell me where the validation is ? | 12:05 |
| daker | coalwater, first we need the backtrace | 12:06 |
| coalwater | well, if i had access i would have tried it my self | 12:07 |
| daker | coalwater, access to what ? | 12:07 |
| coalwater | 32k sounds like the int limit | 12:07 |
| coalwater | create an event my self | 12:08 |
| coalwater | :D | 12:08 |
| daker | the validation should be added here http://bazaar.launchpad.net/~loco-directory-dev/loco-directory/0.2/view/head:/loco_directory/events/forms.py#L156 | 12:08 |
| coalwater | "You can not add a new team event. You are not a member of any LoCo Teams." | 12:08 |
| coalwater | it's a server side validation ? | 12:09 |
| daker | coalwater, and you are not a member of any LoCo Teams ? | 12:09 |
| coalwater | not really, i don't respect my loco team :D lol | 12:10 |
| daker | ok | 12:10 |
| daker | yep we need to add a server side validation or maybe both | 12:10 |
| nigelb | daker: limitation of the variable | 12:14 |
| coalwater | yea, i thought so | 12:18 |
| Ronnie | daker, coalwater: i think that django should be solve this. Its a common IntergerField() provided be django itself | 12:22 |
| coalwater | yea but python it self doesn't have int, double big int and such | 12:23 |
| coalwater | double and big int are separate lol | 12:23 |
| Ronnie | django itself does checking on input fields (for example IntergerField() is a normal textfield, but django checks if it is really a number, not a string). in the same checking functions i think django should check if the number does niet exceed 32-bit-ints | 12:26 |
| daker | Ronnie, nigelb what do you this is the max number of guests? 100 ? | 12:57 |
| daker | s/this/think | 12:58 |
| coalwater | guests per user? | 13:02 |
| coalwater | so loco direcotry thinks my name is coalwater2 | 13:03 |
| Ronnie | daker i think more than 10 is a really exception and when this happens, there is something wrong. but the only reason for limiting the number is the ValueError. Limiting the number to 50 should be more than enough i think | 13:04 |
| nigelb | daker: I'll defer to what mhall119 has to say. I think ther are events with 5K participants. But definitely LC is not up for it in its current UX | 13:07 |
| coalwater | the wrong name on logon is a known bug right ? | 13:08 |
| nigelb | coalwater: yeah, the fix is waiting on IS. | 13:08 |
| coalwater | sorry but what does IS mean ? | 13:08 |
| Ronnie | coalwater: infra structure team | 13:09 |
| coalwater | hm i see | 13:09 |
| nigelb | IS is the canonical system admin team. They manage the server we run loco.ubuntu.com | 13:09 |
| daker | nigelb, well i think the number of guest should be fixed | 13:46 |
| mhall119 | morning | 14:28 |
| mhall119 | nigelb: daker: are you guys talking about people entering too large of a number for guests? | 14:28 |
| daker | yep | 14:28 |
| daker | mhall119, morning | 14:29 |
| daker | https://code.launchpad.net/~daker/loco-directory/fix.806005/+merge/68173 | 14:29 |
| mhall119 | daker: cool, do you know how to write tests for Django? | 14:39 |
| daker | no :/ | 14:39 |
| mhall119 | I think I need to hold a team classroom session on how to write tests for django | 14:41 |
| daker | that would be awesome! | 14:43 |
| mhall119 | daker: okay, I'm going to grab your branch and add a test case to it, then propose it back to yours so you can see it before we merge, ok? | 14:49 |
| daker | ok | 14:49 |
| mhall119 | but right now, I've got to go mow the lawn in 90F temperatures :( | 14:50 |
| mhall119 | I'll be back later | 14:50 |
| daker | tyt | 14:51 |
| cjohnston | mornin | 15:12 |
| daker | morning cjohnston | 15:22 |
| coalwater | morning | 15:22 |
| coalwater | and bye :D gotta go | 15:23 |
| cjohnston | daker: https://code.launchpad.net/~daker/loco-directory/fix.707614/+merge/65124 pleas eadd a commit message | 15:24 |
| cjohnston | Please start adding a commit message to the MP any time you make one | 15:24 |
| daker | ok | 15:26 |
| daker | done | 15:27 |
| cjohnston | ty | 15:27 |
| cjohnston | im getting ready to review it | 15:28 |
| cjohnston | daker: https://code.launchpad.net/~daker/loco-directory/ltp-dj-1.3 | 15:35 |
| daker | what ? | 15:35 |
| cjohnston | will that still work on older versions of django (ie.. what is used on the server its hosted on?) | 15:35 |
| daker | i have just start porting it to django 1.3 | 15:36 |
| daker | brb | 15:45 |
| cjohnston | mhall119: "Get user TZ from launchpad, use it for default TZ settings when applicable" I'm not sure that this is required anymore for LoCo Directory now that we have the default team TZ and all | 15:52 |
| cjohnston | thoughts? | 15:52 |
| mhall119 | it's not necessary | 17:40 |
| cjohnston | sweet | 17:49 |
| cjohnston | removed | 17:49 |
| cjohnston | wb daker | 17:54 |
| daker | yo | 17:54 |
| cjohnston | mhall119: you still around? | 17:55 |
| cjohnston | daker: https://code.launchpad.net/~chrisjohnston/loco-directory/contact/+merge/66404 any chance you can take a look? | 18:01 |
| daker | sure | 18:02 |
| cjohnston | daker: what is https://code.launchpad.net/~akshaytayal/loco-directory/608289/+merge/51963 still missing? | 18:03 |
| daker | i think verbose_name for the country field is missing | 18:05 |
| cjohnston | ok.. | 18:05 |
| cjohnston | I'm going to just make the change myself if you will review it and then we can get it pushed | 18:06 |
| daker | ok | 18:06 |
| daker | one other thing make the import like this : from teams.models import Country, Continent | 18:06 |
| cjohnston | ok | 18:07 |
| cjohnston | will that require a new migration script? | 18:07 |
| daker | no | 18:09 |
| daker | look at the diff lines 75,65 | 18:10 |
| daker | from teams.models import Country | 18:10 |
| daker | 76+from teams.models import Continent | 18:10 |
| cjohnston | yup | 18:10 |
| daker | just combine them : | 18:11 |
| daker | from teams.models import Country, Continent | 18:11 |
| mhall119 | daker: ping | 18:13 |
| cjohnston | the verbose name was what I wasn't sure about | 18:13 |
| daker | mhall119, pong | 18:13 |
| daker | cjohnston, the verbose name doesn't affect the db | 18:14 |
| mhall119 | daker: https://code.launchpad.net/~mhall119/loco-directory/fix.806005/+merge/68181 is a merge proposal to your branch which adds a test case | 18:14 |
| cjohnston | hey mhall119.. 2 things... any chance you can take a look at the issues I had with your test, and any chance we can deploy summit today to get some of the work items closed? | 18:14 |
| cjohnston | thanks daker | 18:14 |
| mhall119 | daker: you can run it with "python manage.py test events" | 18:14 |
| daker | ok | 18:14 |
| mhall119 | once you're happy with it, commit it to your ranch and push it back to LP, and I'll approve your MP into trunk | 18:14 |
| daker | ok | 18:14 |
| cjohnston | I didnt know daker had a ranch | 18:14 |
| cjohnston | ;-) | 18:14 |
| daker | LoL | 18:15 |
| mhall119 | cjohnston: what issues did you have with my tests? | 18:15 |
| cjohnston | they are pasted in the mp | 18:16 |
| cjohnston | daker: https://code.launchpad.net/~chrisjohnston/loco-directory/608289/+merge/68182 | 18:16 |
| cjohnston | mhall119: https://code.launchpad.net/~mhall119/loco-directory/fixes-805280/+merge/66736 | 18:17 |
| mhall119 | cjohnston: commented on the MP | 18:18 |
| cjohnston | ok.. mhall119 if i do python manage.py test venues it works | 18:18 |
| mhall119 | yeah, the teams tests are from dholbach's time or before, they need to be fixed or replaced | 18:18 |
| cjohnston | done | 18:19 |
| daker | cjohnston, https://code.launchpad.net/~chrisjohnston/loco-directory/contact/+merge/66404 | 18:20 |
| * cjohnston upgraded to oneiric last night | 18:20 | |
| cjohnston | I have no idea what that means | 18:21 |
| mhall119 | it means you upgraded to oneiric | 18:21 |
| daker | LoL | 18:21 |
| cjohnston | i didnt do anything | 18:21 |
| cjohnston | lol | 18:21 |
| cjohnston | nothing that i changed would be effected by that | 18:22 |
| mhall119 | daker: looks like a db error | 18:22 |
| mhall119 | maybe you need to try with a fresh database? | 18:22 |
| mhall119 | daker: did you run the migration that is part of that MP? | 18:23 |
| daker | yep | 18:23 |
| mhall119 | any error when the migration ran? | 18:23 |
| daker | no http://paste.ubuntu.com/645970/ | 18:24 |
| mhall119 | huh | 18:24 |
| mhall119 | cjohnston: I've got some errands to run this afternoon, but I can do some reviews or write some tests this evening, and then maybe we'll be ready to file for a deployment on Monday | 18:25 |
| cjohnston | ok | 18:25 |
| mhall119 | cjohnston: also, what would you think about me doing a classroom session on writing tests for LD? | 18:25 |
| cjohnston | i dont think there is really anything outstanding that is ready | 18:25 |
| cjohnston | sounds good to me mhall119 | 18:25 |
| mhall119 | cjohnston: we've got some bug fixes and also teh teams page speed improvements | 18:26 |
| mhall119 | that have already landed | 18:26 |
| cjohnston | mhall119: ? | 18:26 |
| cjohnston | I was talking deploying summit | 18:26 |
| mhall119 | oh, I'm talking LD | 18:27 |
| cjohnston | daker: i just tried my mp for the event contact with no issues again | 18:27 |
| mhall119 | when did we switch to talking about summit? | 18:27 |
| cjohnston | i asked two different questions | 18:27 |
| cjohnston | ;-) | 18:27 |
| daker | ok cjohnston i'll try a fresh a db | 18:27 |
| cjohnston | one was deploy summit, the other was tests for your ld mp | 18:27 |
| mhall119 | well there's your problem, I can't handle that many things | 18:27 |
| mhall119 | it's walk or chew gum, not both | 18:27 |
| cjohnston | mhall119: as far as LD goes, daker's bug which you did tests for needs to land, and i have two branches that need to land | 18:28 |
| cjohnston | other than that I think LD is good to go.. no? | 18:28 |
| mhall119 | yeah | 18:28 |
| cjohnston | what tests need to be done? | 18:29 |
| mhall119 | what do yuo mean? | 18:29 |
| cjohnston | but I can do some reviews or write some tests this evening, and then maybe we'll be ready to file for a deployment on Monday | 18:30 |
| mhall119 | oh, I meant write test cases for some of the MP's that are landing | 18:30 |
| mhall119 | like your adding of the contacts field | 18:30 |
| cjohnston | does it need to hold based upon not having a test? | 18:30 |
| mhall119 | I just wrote one for daker's MP | 18:30 |
| cjohnston | right.. i saw that | 18:30 |
| mhall119 | cjohnston: it doesn't need to, but I do want to get them in at some point | 18:31 |
| cjohnston | ok | 18:31 |
| mhall119 | if daker approves your MP, go ahead and let it land | 18:31 |
| cjohnston | im going to try to get everything landed and try to get out the translations | 18:31 |
| mhall119 | good idea, I can write tests while we wait for translations to come in | 18:31 |
| daker | mhall119, cjohnston does anyone of you got a fresh db ? | 18:33 |
| mhall119 | daker: I made one friday | 18:33 |
| mhall119 | daker: http://people.ubuntu.com/~mhall119/loco-directory/ | 18:33 |
| mhall119 | loco_directory.db | 18:33 |
| cjohnston | whats admin mhall119 ? admin password? | 18:34 |
| mhall119 | hmm, I don't think I made one | 18:34 |
| mhall119 | run "python manage.py createsuperuser" once you have the db | 18:35 |
| cjohnston | ok | 18:35 |
| mhall119 | ok, I'm off, talk to you guys later | 18:37 |
| cjohnston | cya | 18:38 |
| daker | cjohnston, same error :/ | 18:47 |
| daker | i am using django 1.1.1 | 18:47 |
| cjohnston | hmm | 18:47 |
| cjohnston | can you update to 1.1.2 which is the recommended? | 18:48 |
| daker | ok | 18:48 |
| daker | good it works | 18:52 |
| cjohnston | sweet | 18:53 |
| cjohnston | makes me feel better | 18:53 |
| cjohnston | daker: have you worked on summit? | 18:53 |
| daker | i have an item on the BP which on standby | 18:54 |
| daker | s/which/which is | 18:54 |
| cjohnston | ? | 18:54 |
| daker | putting the color as field | 19:00 |
| daker | cjohnston, https://code.launchpad.net/~daker/loco-directory/fix.806005/+merge/68173 | 19:08 |
| daker | cjohnston, this https://code.launchpad.net/~chrisjohnston/loco-directory/608289/+merge/68182 will not work | 19:13 |
| daker | running the migrate command will give you this : | 19:14 |
| daker | from south.v2 import SchemaMigration | 19:14 |
| daker | ImportError: No module named v2 | 19:14 |
| daker | i think the migration script was created with v0.7 | 19:15 |
| daker | any update on this https://code.launchpad.net/~rorymcc/loco-directory/bug-600134/+merge/33995 ? | 20:00 |
| cjohnston | not that im aware of | 20:18 |
| cjohnston | daker: http://bazaar.launchpad.net/~loco-directory-dev/loco-directory/0.2/view/head:/requirements.txt#L10 | 20:18 |
| daker | cjohnston, what version used to create the migration script used here https://code.launchpad.net/~chrisjohnston/loco-directory/contact/+merge/66404 ? | 20:21 |
| cjohnston | i dont remember | 20:22 |
| cjohnston | i didnt create the migration for 608289 | 20:23 |
| cjohnston | i just used the one that was there | 20:23 |
| daker | yes i know | 20:23 |
| daker | cjohnston, can you reverse the order of the fields ? | 21:05 |
| daker | like this : | 21:05 |
| daker | continent = models.ForeignKey(Continent, verbose_name=_('Continent'), null=True) | 21:05 |
| daker | country = models.ForeignKey(Country, verbose_name=_('Country'), null=True) | 21:05 |
| cjohnston | sure | 21:05 |
| cjohnston | daker: could you look at an error im getting on summit? | 21:05 |
| daker | shoot | 21:06 |
| cjohnston | Could someone please help me with this error: NoReverseMatch: Reverse for 'summit.schedule.decorators.inner' with arguments '('',)' and keyword arguments '{}' not found. my code is at http://pastebin.com/b63AWSXU I can't figure out why it's throwing the NoReverseMatch. | 21:06 |
| mhall119 | daker: we have South 0.7 available on the loco-directory server, so v2 migrations scripts should be okay, can you upgrade to 0.7 and try it again? | 21:07 |
| daker | cjohnston, that's the same error i was getting when i was working on the color field :/ | 21:07 |
| daker | mhall119, that's ok it works with 0.7.3 | 21:07 |
| mhall119 | cjohnston: uds.ubuntu.com is wordpress, right? | 21:08 |
| cjohnston | yes mhall119 | 21:08 |
| cjohnston | mhall119: maybe you can help me with my error ^ | 21:08 |
| cjohnston | mhall119: I just posted a little bit ago another mp for summit | 21:08 |
| mhall119 | cjohnston: we made something in ISD for exporting a WP menu and importing it into Django | 21:08 |
| cjohnston | daker: the change has been pushed | 21:08 |
| cjohnston | ok | 21:08 |
| cjohnston | thats cool | 21:08 |
| cjohnston | i still dont like ahving both sites seperatly | 21:09 |
| cjohnston | seems counterproductive | 21:09 |
| mhall119 | oh wait, ours used Drupal as the source, no WP | 21:09 |
| mhall119 | nevermind | 21:09 |
| cjohnston | boo | 21:09 |
| cjohnston | lol | 21:09 |
| mhall119 | can maybe make a WP component | 21:10 |
| cjohnston | my statement still stands though about the seperate sites | 21:10 |
| cjohnston | I personally would rather put the effort into merging the site | 21:10 |
| mhall119 | it would make sense if they moved summit to live at uds.ubuntu.com/schedule or something like that | 21:10 |
| cjohnston | I still don't know how well they would integrate | 21:10 |
| daker | cjohnston, there some spaces there it's generating an error | 21:10 |
| daker | cjohnston, | 21:11 |
| daker | + spr = models.CharField(_("State/Province/Region"), max_length=50, null=True, blank=True) | 21:11 |
| cjohnston | pushed daker | 21:11 |
| cjohnston | mhall119: i mean, if nothing else the themeing is different | 21:12 |
| mhall119 | right, summit isn't 960px is it | 21:12 |
| cjohnston | correct | 21:12 |
| cjohnston | that's why I'd like to move everything to summit | 21:12 |
| mhall119 | I'd like to make summit 960px | 21:12 |
| cjohnston | i dont know how good it will look | 21:13 |
| cjohnston | it already doesnt look great | 21:13 |
| cjohnston | i wonder if it would look worse | 21:13 |
| mhall119 | we can look into a Django CMS, we're doing that in ISD anyway | 21:13 |
| cjohnston | how much work would that be? is the code already there? | 21:13 |
| cjohnston | mhall119: any idea about that error? | 21:14 |
| daker | cjohnston, you getting that error when you touch the models, right ? | 21:15 |
| daker | are* | 21:15 |
| mhall119 | cjohnston: no idea | 21:17 |
| daker | run run tarmac è_é !! | 21:19 |
| cjohnston | daker: i edited the url and edited views | 21:20 |
| cjohnston | mhall119: no idea to the error or the work/code being there? | 21:20 |
| mhall119 | nope | 21:21 |
| cjohnston | im still confused... both? | 21:21 |
| mhall119 | ok | 21:22 |
| daker | i stoped working on the color field because of this error. | 21:23 |
| cjohnston | I blame mhall119 | 21:24 |
| mhall119 | me too | 21:24 |
| mhall119 | we shouldn't let that guy do any more work on these projects | 21:24 |
| cjohnston | no.. we should make that guy do all the work | 21:25 |
| daker | we should ban him from the channel :) | 21:25 |
| cjohnston | and make him do all the work | 21:26 |
| daker | g'night | 21:52 |
| cjohnston | mhall119: if I push the code thats giving me the error, can you take a look? | 21:56 |
| mhall119 | cjohnston: it's in a branch right? I can merge it locally and test it | 23:28 |
| mhall119 | wait, did you mean push to LP, or push to trunk? | 23:28 |
| cjohnston | lp | 23:42 |
| cjohnston | mhall119: https://code.launchpad.net/~chrisjohnston/summit/today | 23:44 |
| mhall119 | cjohnston: ok, I'll give it a look and see what I can find | 23:50 |
| cjohnston | ty | 23:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!