| * mandel installing crappy OS updates :( | 08:24 | |
| fagan | Morning | 08:34 |
|---|---|---|
| fagan | hmmm no tasks at the moment ill go do some blog posts | 08:50 |
| * rye is waiting for karni | 08:57 | |
| fagan | Waiting for packages is really annoying | 09:01 |
| Chipaca | duanedesign: pgraner: let me know how the deleted files thing went | 09:31 |
| gord | hrm, i just noticed that if i right click a file in my phones instant upload directory (using the ubuntu one files app on android) on my desktop, i can't use the right click context menu to public the files or copy the web link, anyone know if thats expected or if i can fix that? | 10:02 |
| fagan | gord: you would have to ask karni that but he isnt online yet | 10:03 |
| fagan | gord: he should be around very soon but cant give you an exact time | 10:04 |
| gord | cool cool | 10:05 |
| karni | Good morning! | 10:18 |
| ralsina | morning! | 10:19 |
| fagan | morning karni and ralsina | 10:20 |
| karni | hi guys! | 10:20 |
| fagan | karni: gord has a question | 10:20 |
| karni | gord: I hear you had a question? | 10:20 |
| fagan | 11:02 < gord> hrm, i just noticed that if i right click a file in my phones instant upload directory (using the ubuntu one files app on android) on my desktop, i can't use the right click context menu to public the files or copy the web link, anyone know if thats expected or if i can fix that? | 10:20 |
| fagan | Oh thats a desktop question | 10:21 |
| fagan | My bad | 10:21 |
| karni | gord: ↑ I would say that's a quesiton to rye | 10:21 |
| karni | I had a similar issue. Didn't have time to debug, but reconnecting to U1 / rebooting helped. | 10:22 |
| * fagan just saw android and thought karni | 10:22 | |
| karni | :) | 10:22 |
| karni | That's a good correlation. | 10:22 |
| fagan | hah | 10:22 |
| rye | gord, aha, so your nautilus does not pick the new directory, what ubuntu version are you running? | 10:23 |
| gord | rye, O right now, also rebooting doesn't help | 10:23 |
| rye | gord, ok, you do have context menus in Ubuntu One directory, right? | 10:25 |
| gord | rye, yup, and some my other u1 directories, just not the pictures from my phone one | 10:26 |
| rye | gord, ok, could you please pastebin the output of u1sdtool --list-folders ? | 10:27 |
| gord | rye, http://paste.ubuntu.com/646385/ | 10:28 |
| fagan | ralsina: have any intern work to do for me | 10:28 |
| ralsina | fagan: not yet, let's think about it! | 10:29 |
| fagan | ralsina: Im looking at the bug list in the meantime | 10:29 |
| ralsina | fagan: could you check for new+unassigned bugs in the last 3 months? | 10:29 |
| ralsina | Those we have to assign... | 10:30 |
| fagan | ralsina: sure will do | 10:31 |
| rye | gord, let's do clean start, could you please restart nautilus - nautilus -q | 10:33 |
| gord | rye, done, doesn't help :) | 10:34 |
| rye | gord, good, that's interesting now | 10:34 |
| gord | rye, i get all the "interesting" problems ;) | 10:40 |
| * fagan break for a few | 10:40 | |
| rye | gord, i just subscribed to Pictures - Liquid UDF for my phone and it is working, which may mean something broke in Oneiric | 10:41 |
| duanedesign | morning all | 10:42 |
| * mandel walking dog | 10:43 | |
| gord | rye, i don't think so, on my laptop (also on O) it works okay | 10:43 |
| Chipaca | duanedesign: morning! | 10:43 |
| rye | gord, oh, that is even more interesting | 10:46 |
| rye | gord, do you have the access to the laptop now? | 10:46 |
| gord | rye, sure | 10:46 |
| rye | gord, could you please pastebin the u1sdtool --list-folders from there? | 10:47 |
| Chipaca | ralsina: morning! | 10:49 |
| ralsina | hello Chipaca | 10:50 |
| gord | rye, looks about the same to me http://paste.ubuntu.com/646401/ | 10:50 |
| duanedesign | Chipaca: i think pgraner got all his folders back | 10:50 |
| Chipaca | duanedesign: what was it? | 10:51 |
| Chipaca | ralsina: mumble plz? | 10:51 |
| ralsina | Chipaca: in 1' | 10:51 |
| duanedesign | Chipaca: ill PM you | 10:51 |
| Chipaca | ralsina: here's hoping that's one minute and note one light-foot | 10:52 |
| ralsina | Chipaca: have to close the office door. Kid asleep :) | 10:52 |
| Chipaca | good | 10:53 |
| Chipaca | let sleeping babes lie. Or lying babes sleep. Or something. | 10:53 |
| ralsina | On mumble now | 10:53 |
| * mandel back | 11:35 | |
| mandel | ralsina: ping | 11:35 |
| ralsina | pong! | 11:35 |
| facundobatista | Hola! | 11:36 |
| ralsina | Hola facundobatista! | 11:36 |
| facundobatista | Hola ralsina! | 11:36 |
| facundobatista | I have two posavasos for you! | 11:36 |
| ralsina | mandel: pong (just in case) | 11:37 |
| ralsina | facundobatista: I know I know | 11:37 |
| mandel | ralsina: did you get the morning report? | 11:37 |
| ralsina | facundobatista: We meet the 30th, right? | 11:37 |
| ralsina | mandel: got it | 11:38 |
| ralsina | mandel: I was about to check your 1st branch | 11:38 |
| facundobatista | ralsina, yeap | 11:38 |
| ralsina | facundobatista: bring them along :-) | 11:38 |
| mandel | ralsina: ok, I think this way of working is waaaaay better to solve diff time zone issues | 11:39 |
| ralsina | mandel: cool! | 11:39 |
| ralsina | mandel: sometimes it takes time to figure out processes :-) | 11:39 |
| mandel | ralsina: yeah, looks like it, specially when we are not in an office, that makes things more interesting | 11:40 |
| ralsina | mandel: yeah, working from home is great but it tends to lead to bad habits. | 11:41 |
| mandel | ralsina: he, tell me about it, has been a year working from home alone, I'm like and old craky geek | 11:42 |
| mandel | full of bad habits | 11:43 |
| ralsina | mandel: as long as you don't start eating chicken standing up, in the sink, like an animal, you're recoverable ;-) | 11:43 |
| nessita | hello everyone!!! | 11:44 |
| facundobatista | Hola nessita | 11:44 |
| mandel | ralsina: hmmm I could have been doing worse :) | 11:45 |
| facundobatista | jajaja | 11:45 |
| fagan | morning nessita | 11:45 |
| nessita | hi fagan | 11:45 |
| facundobatista | our brains have good reasons to block some memories | 11:46 |
| nessita | mandel: reviewing your fix-os-helper now | 11:46 |
| ralsina | good morning nessita! | 11:46 |
| mandel | nessita: thx! | 11:46 |
| nessita | hi ralsina! | 11:46 |
| ralsina | nessita: I have not 2, not 3, not 4, but 6! small branches for review ;-) | 11:47 |
| nessita | ralsina: I read that from the report. I will review, but I will prioritize mandel's, if that's ok | 11:48 |
| ralsina | I couldn't sleep on friday, hopefully the code is not full of comments like "# that pink elephant is looking funny at me' | 11:48 |
| ralsina | nessita: they are all much less important than mandel's | 11:48 |
| nessita | ralsina: did you see that movie? is aweful | 11:48 |
| ralsina | nessita: which one? | 11:48 |
| nessita | the one with the pink elephant looking at another character | 11:49 |
| nessita | and people thought that other character was crazy | 11:49 |
| ralsina | nessita: no, didn't see it :-) | 11:49 |
| mandel | nessita: is that dumbo? | 11:50 |
| ralsina | I did see theone with jimmy stewart and the giant invisible bunny though | 11:50 |
| nessita | mandel: no, dumbo was grey and "cute" | 11:50 |
| mandel | nessita: but there was a pink drunk elephant in it :) | 11:50 |
| ralsina | oh, back in the day, when kids movies could contain drunkard jokes | 11:51 |
| mandel | ralsina: and lots of sex related ones… which explains how I turned out... | 11:53 |
| mandel | roger rabit was great :) | 11:53 |
| ralsina | If you ever actually see Disney's pinochio... it's scary | 11:53 |
| ralsina | I started watching it with my kid, he got so freaked out we had to stop | 11:54 |
| mandel | facundobatista: ping | 11:55 |
| facundobatista | mandel, pong | 11:55 |
| facundobatista | ralsina, I'm in a fight for my kid to don't watch Disney content, it's a very evil corporation | 11:56 |
| mandel | facundobatista: super stupid question: I'm getting some error in the test that use the memento handler because some paths have \\\\ instead of \\ and it seems to happen when I do '~/Test'.replace('/','\\') since the repr of that turns out to be '~\\\\Test', do you know what amd I doing wrong? | 11:58 |
| facundobatista | mandel, mmmm, see: | 11:59 |
| facundobatista | >>> '~/Test'.replace('/','\\') | 11:59 |
| facundobatista | '~\\Test' | 11:59 |
| facundobatista | this is different to what you're supposing its happening | 11:59 |
| mandel | facundobatista: and the repr | 12:00 |
| facundobatista | mandel, the response of the interactive interpreter is the repr | 12:00 |
| facundobatista | >>> print repr('~/Test'.replace('/','\\')) | 12:00 |
| facundobatista | '~\\Test' | 12:00 |
| mandel | facundobatista: I sear to god, this is what I get: | 12:01 |
| mandel | >>> repr('~/Test'.replace('/', '\\')) | 12:01 |
| mandel | "'~\\\\Test'" | 12:01 |
| facundobatista | mandel, there you're doing repr() *twice* | 12:01 |
| mandel | facundobatista: oh, because python in doing it for me already.. got it | 12:02 |
| facundobatista | mandel, the response of the interactive interpreter is the repr | 12:02 |
| nessita | mandel: ping | 12:02 |
| mandel | nessita: pong | 12:02 |
| ralsina | facundobatista: you know that also means no pixar, right? | 12:03 |
| karni | Anybody has Droid X phone? | 12:03 |
| nessita | mandel: in the test_filesystem_notifications, in setup, you add: | 12:03 |
| nessita | self.basedir = LONG_PATH_PREFIX + os.path.abspath(... | 12:03 |
| nessita | mandel: isn't it better to use the abspath from os_helpers? | 12:04 |
| facundobatista | ralsina, damn :) | 12:04 |
| ralsina | facundobatista: and no ESPN, while we are at it ;-) | 12:04 |
| mandel | nessita: let me take a look closer | 12:04 |
| facundobatista | ralsina, see, that's why they associated to Cablevision in .ar, evil with evil | 12:05 |
| nessita | mandel: last week, if I understood you correctly, we agreed LONG_PATH_PREFIX should never be used outside os_helpes | 12:05 |
| nessita | os_helpers* | 12:05 |
| mandel | nessita: which line of the diff are you looking at? | 12:06 |
| mandel | nessita: is it 18? | 12:06 |
| nessita | 18 | 12:06 |
| nessita | hum | 12:06 |
| nessita | wait | 12:07 |
| nessita | mandel: you're removing that | 12:07 |
| nessita | I was using meld and looking the diff "al revés" | 12:07 |
| nessita | mandel: so let me rephrase my question :-) | 12:07 |
| mandel | nessita: sure, we start from 0 :) | 12:08 |
| nessita | mandel: shouldn't abspath from os_helper be needed in the setUp? | 12:08 |
| nessita | mandel: I don't understand why we sometimes we use os.path.something and some other time those from os_helpers | 12:09 |
| mandel | nessita: the real reason why we are using os_helpers abspath is because within sd we use os.abspath(suggested_path) when suggested_path uses the unix separator and not the windows one | 12:11 |
| mandel | nessita: in this case we really dont care becuase it should be the filesystem_notification that deal with the fact of the path being to long | 12:12 |
| nessita | mandel: I thought we had our own abspath because os.path.abspath will not do anything is the path was literal | 12:12 |
| mandel | nessita: yes, but that got removed as soon as we no longer use literal paths in sd, right? | 12:15 |
| mandel | nessita: so if we get a literal path from sd is that something is broken | 12:15 |
| nessita | mandel: ok, that makes sense. I didn't know that abspath from os_helpers was removed | 12:15 |
| mandel | nessita: it is there, just does the replace('/', '\\') for whenever is called from sd with a udf suggested path | 12:16 |
| mandel | nessita: maybe callign it udf_abspath is a smarter thing to do, it can be done in that same branch | 12:16 |
| nessita | mandel: yes please, and move that to vm_helper | 12:16 |
| nessita | instead of being in os_helper | 12:17 |
| mandel | nessita: sure, on it right now | 12:17 |
| nessita | mandel: so, the new test_abspath that is added in diffline 99 will be removed? | 12:21 |
| mandel | nessita: hmm very good point I forgot about the illegal paths!! | 12:23 |
| mandel | nessita: we need to keep it there so that the illegal paths are removed... | 12:23 |
| nessita | mandel: ... I'm very confused at the moment | 12:23 |
| nessita | mandel: why would be removed illegal paths on abspath? | 12:24 |
| nessita | those should be 2 separated ops | 12:24 |
| mandel | nessita: because you can try to do abspath('./illegalpath?') | 12:24 |
| nessita | mandel: and that is ok, isn't it? | 12:24 |
| mandel | nessita: where we perform os.path.abspath('./illebalpath%utf8_char') | 12:25 |
| mandel | nessita: with the current implementation doing that is correct, that is why we have abspath in os_helper, and I forgot about it (ouch!!) | 12:25 |
| mandel | nessita: the test in line 99 is testing that you can do that | 12:26 |
| mandel | nessita: creates a path with illegla chars and performs abspath on it | 12:26 |
| nessita | mandel: I did, and it worked | 12:27 |
| nessita | let me paste that | 12:27 |
| mandel | nessita: please do | 12:27 |
| nessita | mandel: http://pastebin.ubuntu.com/646464/ | 12:28 |
| mandel | nessita: ok, so I cleary had that wrong, cool I'll move it to vm_helper | 12:29 |
| mandel | nessita: will do a grep first just in case | 12:30 |
| nessita | mandel: does that work like that in your vm? | 12:30 |
| mandel | nessita: it does, I should have tested tha irl before implementing it | 12:31 |
| mandel | nessita: also, we added it to have \\?\ but since we do not need it we should not use os_helper abspath anymore | 12:32 |
| mandel | nessita: removing it right away | 12:33 |
| nessita | mandel: ack | 12:34 |
| nessita | mandel: also, we agreed we won't be landing the magic decorators _get_windows_valid_path and _get_syncdaemon_valid_path as is, so why are they in the diff? | 12:41 |
| mandel | nessita: ouch, sorry, mea culpa | 12:42 |
| karni | nessita: How do you handle situation if, for any remote reason, you authenticate the user, get the tokens, but pingU1() fails? | 12:45 |
| nessita | karni: remove tokens from the keyring and tell the user there was a problem, and offer to login again | 12:46 |
| karni | nessita: Thank you | 12:46 |
| nessita | welcome! | 12:46 |
| karni | nessita: ^ ^ Also, I hope you're feeling better (the diet thing) | 12:46 |
| nessita | karni: thanks | 12:46 |
| fagan | standup in 10 | 12:50 |
| Chipaca | nessita: morgen! and, ping :) | 12:53 |
| nessita | Chipaca: morgue! | 12:53 |
| nessita | and pong | 12:54 |
| mandel | me | 12:59 |
| fagan | moi | 12:59 |
| nessita | me | 13:00 |
| fagan | ralsina ? | 13:00 |
| ralsina | me | 13:00 |
| * fagan thinks this is more or less it | 13:00 | |
| nessita | mandel: go! | 13:01 |
| mandel | DONE: splited mega branch into a pipeline. Started looking at why some test brake when the Memento handler is sued. | 13:01 |
| mandel | TODO: Remove abspath from os_helper. Test changes and push for review. | 13:01 |
| mandel | BLOCKED: no | 13:01 |
| mandel | fagan: go | 13:01 |
| fagan | DONE | 13:01 |
| fagan | * Looked at the bug list a little | 13:01 |
| fagan | * got started on blog reports for the past few weeks | 13:01 |
| fagan | * wrote up notes for a meeting later | 13:01 |
| fagan | TODO | 13:01 |
| fagan | * Last 3 months unassigned bugs | 13:01 |
| fagan | BLOCKED | 13:01 |
| fagan | * Nope | 13:01 |
| fagan | nessita: go | 13:01 |
| nessita | DONE: interviewed windows candidate, UDF debugged (had not a lot of info to do this), bug #810724, several reviews | 13:01 |
| nessita | TODO: be-ready-to-review mandel's branches, review ralsina's 6 (!!!) branches, bug #810656 and maybe bug #810662 | 13:01 |
| nessita | BLOCKED: nopes | 13:01 |
| nessita | NEXT: ralsina | 13:01 |
| ubot4 | Launchpad bug 810724 in ubuntuone-control-panel "Should use u1lint instead of pylint (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/810724 | 13:01 |
| ubot4 | Launchpad bug 810656 in ubuntuone-control-panel "QT UI: Preferences tab do not show the loading overlay (affects: 1) (heat: 6)" [Medium,Triaged] https://launchpad.net/bugs/810656 | 13:01 |
| ubot4 | Launchpad bug 810662 in ubuntuone-control-panel "QT UI: "Delete" button in the devices tab does not work (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/810662 | 13:01 |
| ralsina | DONE: closed bug #811006 bug #811116, proposed branches for bug #811109 bug #811099 bug #811246 bug #811111 bug #807828 bug #805460 | 13:01 |
| ubot4 | Launchpad bug 811006 in ubuntuone-client (and 1 other project) "Problem with logfile rollover on windows (affects: 1) (heat: 6)" [High,Invalid] https://launchpad.net/bugs/811006 | 13:01 |
| ubot4 | Launchpad bug 811116 in ubuntuone-windows-installer "Last screen shows "are you sure" dialog when closing the wizard (affects: 1) (heat: 8)" [Medium,Fix committed] https://launchpad.net/bugs/811116 | 13:01 |
| ubot4 | Launchpad bug 811109 in ubuntu-sso-client "The sign in form can be submitted even if no captcha solution was entered (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/811109 | 13:02 |
| ubot4 | Launchpad bug 811099 in ubuntuone-windows-installer "Terms and conditions is not shown (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/811099 | 13:02 |
| ubot4 | Launchpad bug 811246 in ubuntuone-windows-installer "The Control Panel is not opened in the last step (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/811246 | 13:02 |
| ralsina | TODO: fix bug #800376 | 13:02 |
| ubot4 | Launchpad bug 800376 in ubuntuone-windows-installer "Add "syncing your computer to the cloud" page to the installer (affects: 1) (heat: 8)" [High,In progress] https://launchpad.net/bugs/800376 | 13:02 |
| ralsina | BLOCKED: no | 13:02 |
| nessita | any comments? | 13:02 |
| fagan | nope | 13:02 |
| ralsina | no | 13:02 |
| * mandel lunch | 13:02 | |
| nessita | ok then | 13:02 |
| nessita | eom! | 13:02 |
| * ralsina ======>coffee | 13:03 | |
| * fagan ==========>tea | 13:04 | |
| fagan | oh alecu is here now | 13:04 |
| alecu | hello! | 13:04 |
| fagan | hey alecu | 13:04 |
| fagan | (just missed standup by 1 minute) | 13:04 |
| * alecu is writing standup notes | 13:04 | |
| nessita | alecu: go when ready! | 13:05 |
| tcole | bleah, what's the staging username/password again? | 13:05 |
| tcole | er | 13:05 |
| tcole | wrong dinwo | 13:05 |
| tcole | er, wrong window | 13:05 |
| alecu | me | 13:07 |
| alecu | DONE: branches for bug #806655; found bug #811307 and started working on it | 13:07 |
| alecu | TODO: finish branch for second bug above | 13:07 |
| alecu | BLOCKED: no | 13:07 |
| ubot4 | Launchpad bug 806655 in ubuntuone-control-panel (and 1 other project) "Windows: SyncDaemonTool should provide a way of registering a callback for status changed notifications (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/806655 | 13:07 |
| ubot4 | Launchpad bug 811307 in ubuntuone-client "CredentialsManagementTool.register tries to send a function thru PB (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/811307 | 13:07 |
| nessita | mandel: needs fixing added to the MP | 13:14 |
| alecu | O thunderbird. Why can't you handle a handful of imap without choking! | 13:18 |
| nessita | alecu: amen | 13:18 |
| nessita | ralsina: ping regarding https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/show_spinner/+merge/68145 | 13:28 |
| ralsina | nessita: pong | 13:29 |
| nessita | ralsina: the test def test_overlay_connections(self): is not the best choice because a single item can do the 6 connections itself, so the test will pass even if what you're expecting to happen does not happen. Can you please split in isolated test for each _ui? | 13:29 |
| ralsina | sure, I had my doubts about that one :-) | 13:29 |
| nessita | ralsina: thanks! | 13:29 |
| ralsina | oh, wait | 13:29 |
| nessita | ralsina: also, question: in self.assertEqual(self.ui.overlay.hide_counter, 2) <- why "2"? | 13:30 |
| ralsina | the conenctions are not done in the .ui files, they are all done in a single function | 13:30 |
| ralsina | nessita: because we hide the overlay on __init__ | 13:30 |
| nessita | ralsina: can you add a comment in the test, something like "we hide the overlay once in __init__, and once when calling hide()" | 13:31 |
| ralsina | nessita: so, one for the __init__() call, one for the next() | 13:31 |
| ralsina | ok, will add | 13:31 |
| nessita | ralsina: not sure what you meant with "the conenctions are not done in the .ui files, they are all done in a single function" | 13:31 |
| ralsina | nessita: the 6 connections are done in __init__ | 13:31 |
| nessita | ralsina: but you're testing against clicking a given button | 13:31 |
| nessita | so, one test can be:L | 13:32 |
| nessita | self.ui.setup_account.ui.set_up_button.click() | 13:32 |
| ralsina | oh, you are right, I got confused | 13:32 |
| nessita | assert.... | 13:32 |
| ralsina | I remembered the test wrong | 13:32 |
| nessita | ralsina: also, any reason to call self.ui.setup_account.ui.set_up_button.clicked.emit(False) instead of self.ui.setup_account.ui.set_up_button.click() | 13:32 |
| nessita | ? | 13:32 |
| ralsina | Yes, basically, it complained if I called click() | 13:33 |
| ralsina | Qt complained I mean | 13:33 |
| nessita | ralsina: complained how? | 13:37 |
| nessita | ralsina: I'm usually use click(), and I haven't seen any complain, maybe I missed them? | 13:38 |
| ralsina | let me check, this branch is getting fuzzy :-) | 13:38 |
| nessita | thanks | 13:38 |
| fagan | ralsina: should I be assigning the bugs reported by you and the other team members as well? | 13:38 |
| ralsina | No, I just used clicked() because I was testing signal connections, so I just tested it from signal emition | 13:38 |
| * mandel back | 13:38 | |
| ralsina | I remembered it complaining about clicked requiring an argument, thus the confusion | 13:39 |
| ralsina | fagan: no, not those | 13:39 |
| fagan | cool | 13:39 |
| ralsina | fagan: are there many? | 13:39 |
| fagan | ralsina: more than the community ones tbh | 13:40 |
| ralsina | fagan: don't follow you | 13:41 |
| nessita | ralsina, alecu, mandel, Chipaca: meeting in 4' | 13:41 |
| ralsina | nessita: pushed with the suggested changes | 13:41 |
| mandel | nessita: ack | 13:41 |
| fagan | ralsina: there seem to be more bugs reported by us than community ones it seems so far | 13:41 |
| alecu | nessita, mumble or skype? | 13:41 |
| ralsina | fagan: yes, that's usually so for us | 13:41 |
| nessita | alecu: mumble :-) | 13:41 |
| nessita | seems like my phone line is stable since the weekend | 13:42 |
| * alecu crosses fingers | 13:43 | |
| * nessita too | 13:43 | |
| === m_conley_away is now known as m_conley | ||
| VEndix | hello, can someone help me with logging into Ubuntu One section? | 14:37 |
| fagan | Hmmmmm what project was the tb plugin? | 14:38 |
| fagan | I cant remember the name | 14:38 |
| fagan | VEndix: what problem are you having? | 14:38 |
| alecu | ralsina, the filenames in fat32 are stored with the "Long File Names" extension to standard fat, and use two bytes in disk per character: http://home.teleport.com/~brainy/lfn.htm | 14:49 |
| ralsina | alecu: arghhhh I am starting to believe NOONE knows this crap :-) | 14:50 |
| CardinalFang | "Boy, IRC sure is quiet today. .... Oh, parenthesis around channel names. I'm connected, but not in any channels? Thanks, Xchat." | 14:50 |
| fagan | CardinalFang: hahahaha | 14:50 |
| alecu | ralsina, I do :-) | 14:51 |
| fagan | most of the bugs im running into now are windows client ones | 14:52 |
| mandel | ralsina: choose a flight! they are bloody expensive! | 14:52 |
| fagan | im just saying update coming and assigning to mandel if thats cool | 14:52 |
| VEndix | fagan: http://img827.imageshack.us/i/nuotrauka.png/ | 14:53 |
| fagan | VEndix: interesting one | 14:54 |
| fagan | ralsina: is there something going on server side at the moment? | 14:54 |
| fagan | ^^ | 14:54 |
| ralsina | fagan: not that I know of. Ask on the other side of the fence :-) | 14:54 |
| fagan | ralsina: will do | 14:54 |
| ralsina | fagan: the windows ones are handled, don't worry | 14:55 |
| VEndix | fagan: what should i do in that case? | 14:55 |
| fagan | VEndix: Just checking with the server people | 14:56 |
| fagan | ralsina: ah ok I was just assigning them to mandel | 14:56 |
| ralsina | fagan: if they are about the windows beta, that's ok | 14:56 |
| mandel | fagan: are you spamming me? | 14:56 |
| fagan | mandel: yeo | 14:56 |
| fagan | ralsina: yeah tis | 14:57 |
| fagan | VEndix: id say try again later | 14:59 |
| fagan | that would be my best guess | 15:00 |
| fagan | spam spam spam I love bug mail :D | 15:02 |
| VEndix | why can't i login now? | 15:03 |
| fagan | VEndix: is a server side issue it seems | 15:04 |
| VEndix | a problem in the server? | 15:04 |
| fagan | VEndix: I asked our server people and they will look at it later | 15:04 |
| fagan | VEndix: looks like something with the login server yes | 15:04 |
| VEndix | a yes | 15:05 |
| VEndix | be carefull | 15:05 |
| VEndix | with that thing | 15:05 |
| VEndix | Ubuntu One | 15:05 |
| VEndix | ! | 15:05 |
| fagan | VEndix: yep we are | 15:05 |
| nessita | ralsina: you approved your own branch? :-) https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/67894 | 15:33 |
| ralsina | I liked it so much! ;-) | 15:35 |
| ralsina | No idea, probably opned the wrong tab in chrome or something. | 15:36 |
| nessita | :-) | 15:38 |
| nessita | ralsina: you in the hotel already? :-) | 15:38 |
| ralsina | nessita: yes | 15:42 |
| ralsina | but on the phone waiting for the manager, so not for long | 15:42 |
| ralsina | will probably be testing the wifi for real soonish | 15:42 |
| nessita | ralsina: I'm re-reviewing fix-810053, and I just notice you're passing these arguments: | 15:55 |
| nessita | 310+ yield client.sso_cred.login_or_register_to_get_credentials('Ubuntu One', | 15:55 |
| nessita | 311+ 'http://www.google.com', | 15:55 |
| nessita | 312+ 'This is a test.', 0, | 15:55 |
| nessita | can you please replace those with the proper constants from ubuntuone.credentials? APP_NAME, TC_URL and DESCRIPTION? | 15:55 |
| ralsina | oh, yes | 15:55 |
| ralsina | copy&paste :-( | 15:55 |
| * fagan EOD | 16:19 | |
| === beuno is now known as beuno-lunch | ||
| nessita | lunchtime! | 16:49 |
| === beuno-lunch is now known as beuno | ||
| nessita | alecu: can I haz a review please? https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/fix-810656/+merge/68285 | 17:55 |
| ralsina | nessita: I am reviewing already! | 18:00 |
| nessita | ralsina: yey! I did not know you were here :-)( | 18:01 |
| * ralsina is ninja-like :-) | 18:01 | |
| ralsina | Or rather kung fu panda-like, but hey | 18:02 |
| ralsina | nessita: +1 | 18:03 |
| nessita | ralsina: thanks | 18:03 |
| nessita | ralsina: you let me know when the fixes I mentioned for both branches are pushed | 18:04 |
| nessita | I ll re-review then | 18:04 |
| ralsina | nessita: for 810053 they are pushed already | 18:04 |
| nessita | ralsina: ack | 18:04 |
| ralsina | nessita: if the other one was the one with the sextuple test, I pushed that one too | 18:05 |
| nessita | it was | 18:05 |
| nessita | ack then | 18:05 |
| ralsina | cool, thx | 18:05 |
| nessita | ralsina: tests are failing for me in 0053 | 18:15 |
| ralsina | nessita: ok, let me check! | 18:15 |
| nessita | ralsina: also, pep8 reports errors over the _ui.py files, so you need to tweak this line: | 18:17 |
| nessita | IF EXIST "%PYTHONEXEPATH%\Scripts\pep8.exe" "%PYTHONEXEPATH%\Scripts\pep8.exe" --repeat ubuntuone_installer | 18:17 |
| nessita | to be: | 18:17 |
| nessita | IF EXIST "%PYTHONEXEPATH%\Scripts\pep8.exe" "%PYTHONEXEPATH%\Scripts\pep8.exe" --repeat --exclude="*_ui.py,*_rc.py" . | 18:17 |
| DanRabbit | urbanape, threeve: ping | 18:24 |
| threeve | DanRabbit: pong | 18:24 |
| DanRabbit | threeve: good morning :) how's it going? | 18:24 |
| threeve | DanRabbit: I'm well into afternoon over here, but going well :) how about you? | 18:25 |
| DanRabbit | threeve: doing well, doing well. | 18:25 |
| urbanape | DanRabbit: heya | 18:25 |
| DanRabbit | threeve: I was trying to wait for some feedback on some iOS designs from other design team members, but I dunno if that's gonna happen :p | 18:25 |
| threeve | DanRabbit: I'm open to looking at anything you're willing to show me | 18:26 |
| DanRabbit | threeve: okay cool. I'll send you some stuff in email in just a second | 18:27 |
| DanRabbit | threeve: is there anything in particular you want sooner than later? | 18:27 |
| threeve | DanRabbit: Nothing specific, but I would say anything that is going to involve lots of customization, so I can give some thought as to how to implement it while you finish designs/create assets. | 18:28 |
| nessita | ralsina: I filed bug #812468, I hit that while doing a review | 18:28 |
| ubot4 | Launchpad bug 812468 in ubuntuone-windows-installer "Entering invalid email address shows no error in the UI (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/812468 | 18:28 |
| DanRabbit | threeve: okay sounds like a plan | 18:28 |
| ralsina | nessita: we need a decent email validation function. The one currently on SSO is 'if "@" in email' | 18:29 |
| nessita | ralsina: it's proven that we can't do any better, we need to handle errors from SSO | 18:29 |
| threeve | DanRabbit: and anything that might use non-trivial interactions, e.g. long press, swipe-menu rows like twitter has, etc. | 18:29 |
| nessita | ralsina: the regex to validate email address is extremely big | 18:29 |
| threeve | DanRabbit: I don't expect a whole lot of that for the files app, but maybe you've come up with something I won't expect :) | 18:30 |
| nessita | ralsina: when we designed this, we made the settlement that we'll do a very simple validation (@ in email) and handle validation from SSO | 18:30 |
| DanRabbit | haha | 18:30 |
| ralsina | nessita: ok, I'll fix that soonish | 18:30 |
| nessita | thanks | 18:30 |
| ralsina | nessita: pushed test fixes. I am not really happy with the callback test now, because of visibility problems, but I think it's barely adequate | 18:31 |
| nessita | ralsina: ok. On other front, I'm never getting the captcha downloaded the first time I enter the sign in form | 18:32 |
| nessita | ralsina: I always have to click refresh | 18:32 |
| ralsina | nessita: ugh | 18:32 |
| nessita | ralsina: is it loading for you? | 18:32 |
| ralsina | nessita: it is in trunk | 18:32 |
| ralsina | let me check it on this branch | 18:32 |
| ralsina | Yes, worked. Took a few seconds, so I need to add some delay feedback there | 18:33 |
| ralsina | nessita: I do get an error message for invalid emails: http://screencast.com/t/l7ARg0J3Jt | 18:37 |
| nessita | ralsina: can you please try without captcha? | 18:38 |
| nessita | ralsina: ie, an empty captcha | 18:38 |
| ralsina | nessita: ok | 18:38 |
| nessita | ralsina: the message appears "sometimes" | 18:38 |
| ralsina | nessita: but there is another branch that doesn't let you submit with an empty captcha :-) | 18:38 |
| nessita | so I'm guessing we have some timing issue, which is not food | 18:38 |
| nessita | ralsina: it does not matter, I want to see if you can reproduce what I hit | 18:39 |
| nessita | I definitely had no message | 18:39 |
| ralsina | ok, trying | 18:39 |
| nessita | (the first time, the second I did) | 18:39 |
| ralsina | nessita: I get both errors: asdasdads@asdasdasd | 18:40 |
| ralsina | oops | 18:40 |
| ralsina | I get both errors in a popup | 18:40 |
| ralsina | http://screencast.com/t/ehA4Zr4PLk | 18:40 |
| nessita | ralsina: they should be 3 errors | 18:40 |
| ralsina | why? | 18:40 |
| nessita | u'errors': {u'captcha_solution': [u'This field is required.'], u'email': [u'Enter a valid e-mail address.'], u'__all__': [u'Wrong captcha solution.']} | 18:40 |
| ralsina | Ok, I get all three :-) | 18:41 |
| nessita | ralsina: so, 2 things: | 18:41 |
| nessita | * I swear I did not got the message the first time, so we may have a timing thing there | 18:42 |
| nessita | * the "This field is required" message is very confusing for the user :-) | 18:42 |
| ralsina | nessita: yes, that should not be a popup | 18:42 |
| nessita | ralsina: neither the "email invalid" | 18:42 |
| ralsina | nessita: that should go into the error labels next to each field, and is not done yet | 18:43 |
| nessita | ralsina: I'll adjust the bug description | 18:43 |
| nessita | yes | 18:43 |
| mandel | ralsina: ping | 18:47 |
| ralsina | mandel: pong | 18:47 |
| mandel | ralsina: do you remember that crazy bzr command to show the history of the branch in a qt ui? | 18:48 |
| ralsina | bzr qlog? | 18:48 |
| mandel | ralsina: the one we used in london... | 18:48 |
| ralsina | mandel: what, have a too interesting one? ;-) | 18:48 |
| mandel | ralsina: maybe :P | 18:49 |
| mandel | ralsina: I used bzr qversion, which is a shitty dialog hehehe | 18:50 |
| nessita | ralsina: you need to add the directory to scan to pep8, I suggested to use '.' | 18:55 |
| ralsina | nessita: ? I copied/pasted your line, I think | 18:56 |
| nessita | "%PYTHONEXEPATH%\Scripts\pep8.exe" --repeat --exclude="*_ui.py,*_rc.py" . <- see the dot :-) | 18:56 |
| ralsina | he | 18:56 |
| ralsina | ok, adding the dot | 18:56 |
| nessita | thanks | 18:56 |
| ralsina | nessita: pushed | 18:57 |
| ralsina | nessita: have 5 miutes for a short mumble? I am stuck with something related to controlpanel | 19:06 |
| nessita | ralsina: sure, give me 2 minutes | 19:07 |
| ralsina | ok, thx | 19:07 |
| nessita | so I finish answering aquarius | 19:07 |
| DanRabbit | threeve, urbanape: I just sent you guys some mockups and such. Let me know if there's any questions or suggestions :) | 19:12 |
| threeve | DanRabbit: looks good, though for "I'm new" we will be able to offer in-app sign up for files. We just can't do that for music due to requiring a paid subscription. | 19:18 |
| DanRabbit | threeve: excellent. In that case, I'll go mock up the in-app sign up stuff :D | 19:19 |
| DanRabbit | that's definitely a relief | 19:19 |
| threeve | DanRabbit: also, for the login screen, keep in mind that when the keyboard shows it will all have to be shifted up, so you might want to consider what that will look like | 19:19 |
| threeve | DanRabbit: that is, what parts are visible, whether it scrolls or is fixed, etc. | 19:20 |
| threeve | Let me know if you need me to grab keyboard dimensions or anything for you | 19:20 |
| karni | duanedesign: Hi, I'm a user that needs help :P My UBuntu One is not working lolz ;) | 19:21 |
| karni | duanedesign: When I open U1CP, and it shows me the login screen | 19:21 |
| karni | duanedesign: I type in my credentials (I triple checked'em) | 19:21 |
| karni | duanedesign: I click Connect, and after short moment it tells me | 19:21 |
| karni | "An exception representing an authentication failure." in red, just above the username (email) field | 19:22 |
| karni | nessita: ↑ | 19:22 |
| DanRabbit | threeve: that's definitely a great point! I know the previous designer had the U1 logo up top there, but IMHO it's not really needed. I'll try to get back to him and if he doesn't respond we can keep on trucking ;) | 19:22 |
| karni | duanedesign: I removed the Ubuntu One token from seahorse before trying what I described. | 19:22 |
| nessita | karni: we've talked about this already :-) | 19:22 |
| nessita | bug #703507 | 19:23 |
| ubot4 | Launchpad bug 703507 in ubuntu (and 1 other project) "I can't log in - "an exception representing an authentication failure" (affects: 4) (heat: 37)" [Undecided,Confirmed] https://launchpad.net/bugs/703507 | 19:23 |
| urbanape | DanRabbit: also, threeve put together an in-app sign in for the U1 Music app. We should definitely standardize at least this interaction across our apps. | 19:24 |
| DanRabbit | urbanape: good idea. Is that somewhere I can test? | 19:25 |
| urbanape | also also, I really applaud elementary. That shiz looks good. | 19:25 |
| karni | nessita: I should consider taking holiday :/ Thanks <3 | 19:25 |
| urbanape | DanRabbit: did you sign up on TestFlight? | 19:25 |
| nessita | karni: :-P | 19:25 |
| DanRabbit | urbanape: indeed | 19:25 |
| DanRabbit | urbanape: thanks :) | 19:25 |
| * karni bitchslaps himself | 19:25 | |
| urbanape | DanRabbit: okay, we can get you a recent build that will be equiv to what we're submitting | 19:26 |
| DanRabbit | urbanape: awesome, I would appreciate that | 19:26 |
| urbanape | threeve: want to add him to the r18 build? | 19:27 |
| threeve | urbanape: I don't have access to add him to the provisioning profile. | 19:27 |
| urbanape | oh, right | 19:27 |
| urbanape | yeah, okay, few minutes. | 19:27 |
| threeve | DanRabbit: have you done iOS design before? | 19:27 |
| urbanape | man, I wish Apple would adopt a roles-based security model. | 19:27 |
| DanRabbit | threeve: not really no haha | 19:28 |
| threeve | urbanape: they did, it's called an "agent". Unfortunately there can be only one ;) | 19:28 |
| DanRabbit | I'm quite new to mobile ;) | 19:28 |
| threeve | DanRabbit: okay, so just FYI, iOS doesn't support calibrated color spaces, and colors will tend to appear darker on the device than you may have intended. | 19:28 |
| urbanape | threeve: well, I wish Apple would adopt a more flexible roles-based security model. | 19:28 |
| DanRabbit | threeve: ah okay. How can we work around this? | 19:29 |
| threeve | DanRabbit: I've had designers shoot for "gold" that came out looking... well, "brown" or even salmon colored, etc. | 19:29 |
| DanRabbit | ah that's unfortunate | 19:29 |
| DanRabbit | I guess testing will be important here :p | 19:30 |
| threeve | DanRabbit: there isn't a terribly good way other than testing. if you want to spot-check some colors you can make a quick PNG palette or something and I can run it on device and do a screen grab or something. | 19:30 |
| threeve | or really, just email yourself a PNG and open it on your device, should give you a reasonable idea. | 19:30 |
| DanRabbit | threeve: that's a really good idea :) | 19:31 |
| threeve | make sure to turn off embedded color profiles when you export | 19:31 |
| DanRabbit | threeve: as far as implementing the orange UI and such, I'm not sure how iOS does its theming. Would it be better to provide you with images or with hex values or? | 19:32 |
| threeve | DanRabbit: it depends on the particular widget. sometimes an rgb color is fine, other times we'll create a stretchable image to use as a background. | 19:33 |
| threeve | buttons typically use images in order to get exact gradients and caps. | 19:33 |
| DanRabbit | threeve: okay, so I guess just let me know what you need and I'll get it ;) | 19:33 |
| threeve | yeah, once we get one screen ready we'll go through how to slice up assets and then you'll know for all screens. | 19:34 |
| DanRabbit | threeve: excellent | 19:34 |
| urbanape | DanRabbit: I've also got code that already wraps up our color palette | 19:37 |
| urbanape | for use in Cocoa code. | 19:37 |
| DanRabbit | urbanape: oh sweet. that'll be helpful | 19:37 |
| urbanape | and our fonts (well, font, until the monospace font is finalized) | 19:37 |
| nessita | ralsina: have you tried the latest version of the installer (fix-810053)? | 19:39 |
| nessita | ralsina: I'm getting odd traces | 19:39 |
| ralsina | nessita: yes I have, but not extensively | 19:39 |
| nessita | ralsina: I'll try to record a screencast | 19:40 |
| ralsina | nessita: about to try it now | 19:41 |
| ralsina | nessita: just went all through the setup new account process without any strance traces | 19:43 |
| nessita | ralsina: can you try logging in? | 19:43 |
| nessita | ralsina: hum, I know what happened | 19:44 |
| nessita | ralsina: there was a problem pinging the server | 19:44 |
| nessita | so the credentials were deleted and CredentialsError was emitted | 19:44 |
| nessita | so the installer closed | 19:44 |
| ralsina | There is no real handler for CredentialsError yet | 19:44 |
| nessita | ralsina: so, HIgh TODO, handle properly CredentialsError | 19:44 |
| nessita | right | 19:44 |
| nessita | ralsina: can you please file a bug? | 19:44 |
| ralsina | sure | 19:44 |
| ralsina | nessita: bug #812506 | 19:46 |
| ubot4 | Launchpad bug 812506 in ubuntuone-windows-installer "Handle CredentialsError correctly on the Qt UI (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/812506 | 19:46 |
| ralsina | nessita: I'll follow the gtk UI's behaviour, and do it right after this branch | 19:46 |
| nessita | thanks | 19:46 |
| amorphous1 | Hello everyone, can you teel me if there are any implications when using symlinks in U1? | 19:47 |
| amorphous1 | as an example, I'm symlink the Documents folder to U1 for syncing... | 19:47 |
| ralsina | amorphous1: U1 doesn't follow your symlinks. You shuld just sync ~/Documents | 19:48 |
| DanRabbit | threeve: how do you feel about something more like this? http://imagebin.org/163676 | 19:49 |
| DanRabbit | should give plenty of room for the keyboard, no? | 19:49 |
| threeve | DanRabbit: that should be just about right, as the keyboard will nestle right up under the "sign in" button | 19:49 |
| threeve | DanRabbit: I should say I didn't dislike the old version either, just that it needs to account for how it looks when the text fields and buttons are moved up when the keyboard shows. | 19:50 |
| threeve | But this one is nice | 19:50 |
| DanRabbit | yea, I think it'd much rather not have the UI jump all around when the keyboard pops up | 19:51 |
| threeve | s/jump/animate smoothly/, but yeah :-P | 19:51 |
| nessita | ralsina: ping does not work, email is empty | 19:57 |
| nessita | ralsina: I'll show you the logs | 19:58 |
| ralsina | nessita: ok | 19:58 |
| nessita | ralsina: http://pastebin.ubuntu.com/646770/ | 20:01 |
| nessita | ralsina: see lines 42 and below | 20:01 |
| * ralsina looks | 20:01 | |
| nessita | in 42 the email is set | 20:01 |
| nessita | 2011-07-18 19:55:54,359:359.999895096 - ubuntu_sso.main.windows - DEBUG - SSOLogin: emitting LoggedIn with app_name "Ubuntu One" and result 'nataliabidart+0@gmail.com' | 20:01 |
| nessita | in 44 is no longer set | 20:02 |
| DanRabbit | threeve, urbanape: just to be clear the mockups I've shared haven't been signed off on. So I think we have to run them back past the design team before we can implement | 20:02 |
| nessita | 2011-07-18 19:55:54,368:368.999958038 - ubuntu_sso.credentials - INFO - Login/registration was successful for app 'Ubuntu One', email '' | 20:02 |
| nessita | ralsina: I think this has to do with the wizard using the widgets "independently" | 20:02 |
| ralsina | no, it's the same problem of CredentialsError, I think | 20:02 |
| threeve | DanRabbit: that's fine, I'm working on the network stuff now anyway. | 20:03 |
| nessita | ralsina: nopes | 20:03 |
| nessita | ralsina: the CredentialsError occur in the "future" | 20:03 |
| nessita | ralsina: the first problem is that the ping fails | 20:03 |
| nessita | and why it fails? because the url is "bad" | 20:03 |
| nessita | why the url is bad? because the url does not have any email | 20:03 |
| DanRabbit | threeve: okay great. Sorry for the delay | 20:04 |
| nessita | ralsina: and why the url doesn't have any email? because the email is '' | 20:04 |
| threeve | DanRabbit: no worries, plenty of other stuff to do in the meantime. | 20:04 |
| ralsina | nessita: ok, that should be caught by the validator in a pending branch | 20:04 |
| ralsina | nessita: the logic for enabling the "submit" button was very limited | 20:04 |
| ralsina | I don't understand why it's getting to the ping with an empty email | 20:05 |
| nessita | ralsina: I did enter a valid email address | 20:05 |
| nessita | a real one, in fact | 20:05 |
| nessita | ralsina: the email was lost in the layers in the code | 20:05 |
| nessita | ralsina: this is not a validation issue | 20:05 |
| ralsina | ugh | 20:05 |
| nessita | ralsina: see line 42, please | 20:05 |
| nessita | ralsina: the email is there | 20:06 |
| nessita | ralsina: but then see line 44, email is, all the sudden, '' | 20:06 |
| nessita | so then, we have this line: | 20:06 |
| ralsina | ok, let me check that... | 20:06 |
| nessita | 2011-07-18 19:55:54,384:384.999990463 - ubuntu_sso.credentials - INFO - Pinging server for app_name "Ubuntu One", ping_url: "https://one.ubuntu.com/oauth/sso-finished-so-get-tokens/", email "". | 20:06 |
| nessita | and that equals boom | 20:06 |
| urbanape | threeve: where, by design team, you mean our folks: lisette, claire, and andrews? | 20:06 |
| urbanape | er, DanRabbit ^^ | 20:06 |
| DanRabbit | urbanape: indeed | 20:07 |
| ralsina | nessita: I get the ping right: http://pastebin.ubuntu.com/646778/ | 20:09 |
| nessita | ralsina: were you trying to register or login? | 20:13 |
| ralsina | nessita: login | 20:13 |
| * mandel back | 20:14 | |
| nessita | ralsina: well, is not working here, so this may indicate timing issues | 20:14 |
| mandel | ralsina: ping | 20:14 |
| ralsina | mandel: pong | 20:14 |
| nessita | ralsina: like things are not waiting for another things, and your computer may be faster than this VM | 20:14 |
| ralsina | nessita: it probably is faster, yes | 20:14 |
| mandel | ralsina: logistics question, can you buy a sim for my phone in AR? | 20:14 |
| ralsina | mandel: sure | 20:14 |
| ralsina | for phone, no problem, for data, it's a bit expensive | 20:15 |
| mandel | nessita: adding those missing tests now | 20:15 |
| nessita | mandel: ack | 20:16 |
| * mandel found a way to sleep in the plain: http://imgur.com/JUzY8 | 20:16 | |
| nessita | ralsina: so, can you try using Cheepaca's VM? | 20:17 |
| nessita | ralsina: or you can log in an I can show you | 20:17 |
| nessita | ralsina: so you debug there, this is a "serious" issue | 20:17 |
| ralsina | nessita: I don't have password for it, and can't connect to vnc-over-ssh from windows AFAIK | 20:17 |
| nessita | ralsina: ok, ideas then? | 20:17 |
| ralsina | but sure, let me start my natty VM and tell me how to login via PM | 20:17 |
| nessita | alecu: ping | 20:20 |
| alecu | nessita, pong | 20:21 |
| nessita | alecu: can you please review a branch from ralsina, which is failing when testing IRL for me? | 20:21 |
| nessita | https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/67894 | 20:21 |
| alecu | ralsina, if you ssh using putty on windows you'll probably be able to make a ssh tunnel and vnc to it. | 20:21 |
| nessita | alecu: when trying to login, the email field inside the sso layers become the empty string so the pinging always fail | 20:22 |
| ralsina | nessita: I'm on chipaca's VM, testing now | 20:22 |
| ralsina | nessita: let's not play cursor hockey :-) | 20:22 |
| alecu | nessita, I can't test it right now; I'm leaving in 5 minutes to pick up amelia. I might test it later in the evening. | 20:22 |
| nessita | ralsina: ping | 20:25 |
| nessita | alecu: ack | 20:25 |
| nessita | ralsina: so you could not replace self.ui.reset_password.ui.reset_password_button.clicked.emit(False) by self.ui.reset_password.ui.reset_password_button.click()? | 20:35 |
| ralsina | nessita: no, I just don't see why. I am testing signal connection, so I emit the signal and expect the result, instead of doing a click that may have other effects. | 20:36 |
| ralsina | it's more "unit" this way, IMHO | 20:36 |
| nessita | ralsina: but the goal of the test is "when user clicks on X button, the loading overlay appears" | 20:36 |
| nessita | ralsina: you're using an implementation detail of QT, IMHO. QT provides an API to click a button | 20:37 |
| ralsina | nessita: no, the goal of the test is ensure the signal is connected. Triggering the signal is Qt's work, and I trust it. Or else, I have to test a millin other things, like "when the user clicks on scrollbar, things scroll" :-) | 20:37 |
| nessita | no | 20:37 |
| ralsina | nessita: no, that click emits clicked() is the implementation detail. The thing I am using is the signal, not the button. | 20:37 |
| nessita | ralsina: that click emits clicked() is the implementation detail <- exactly, so you need to mimic what the user will do, which is clicking a button | 20:39 |
| nessita | the user will not emit a signal | 20:39 |
| ralsina | nessita: this is supposed to be a unit test, not a UI test | 20:39 |
| nessita | ralsina: it is | 20:39 |
| nessita | I mean, is as much unit test as possible without mocking QT | 20:40 |
| nessita | QT is a black box for us | 20:40 |
| nessita | right on top of that, we write the unit tests | 20:40 |
| ralsina | nessita: if the code says whatever.connect() I think the right thing to test is that whatever is connected, not that clicking on a button emits whatever. I think this is just a difference of opinion, but anyway, if you tell me "change it", I will. | 20:41 |
| nessita | ralsina: what if you change your code from whatever.connect() to on_whatever_clicked()? | 20:42 |
| ralsina | nessita: then the test will fail, of course. | 20:42 |
| nessita | we should be able to change that without any code breaking since is a implementation detail | 20:42 |
| nessita | (a detail in our project) | 20:42 |
| nessita | without any test* breaking, I mean | 20:43 |
| ralsina | nessita: ok, I don't want to argue this | 20:44 |
| nessita | ralsina: can I at least point out readability of the test? :-/ | 20:44 |
| ralsina | no you can't. (j/k) | 20:44 |
| nessita | ralsina: I don't want you to change this because I say so... | 20:44 |
| ralsina | ok, if I change them to click() they all work except test_overlay_connection_setup_account that fails. So I'll debug that now. | 20:50 |
| nessita | thanks | 20:59 |
| mandel | nessita: I added the tests for can_write, pushing now and going to bed | 21:13 |
| nessita | mandel: ack! | 21:14 |
| ralsina | nessita: calling click() may or may not require entering the event loop for the clicked() signal to be triggered. | 21:14 |
| nessita | ralsina: eh?!?!?!?! | 21:15 |
| mandel | nessita: and my main reason to leave is that I'm being attack by mosquitos the size of a plain :( | 21:15 |
| nessita | ralsina: I'm tempted to say "False", but I guess I need to look at some code first | 21:15 |
| ralsina | nessita: click() queues the signal for emition, doesn't emit it directly. | 21:15 |
| nessita | ralsina: have a branch I can debug? | 21:15 |
| ralsina | nessita: sure, let me push it. | 21:16 |
| ralsina | nessita: check test_overlay_connection_setup_account in the show_spinners branch | 21:16 |
| ralsina | it's exactly the same as the others, but it only works with clicked.emit() and not with click() | 21:17 |
| === m_conley is now known as m_conley_away | ||
| nessita | ralsina: checking | 21:17 |
| nessita | ralsina: I see all tests using clicked.emit | 21:19 |
| nessita | ralsina: did you push the click()? | 21:19 |
| ralsina | nessita: yes, and the first one fails for me | 21:19 |
| mandel | nessita: laste version is in in lp, so if you review it I'll take a look tom early EU time | 21:20 |
| mandel | everyone, have a great evening | 21:20 |
| nessita | mandel: ack | 21:20 |
| * mandel hides from mosquitos | 21:20 | |
| nessita | ralsina: as far as I know, widget sets execute all the callbacks connected to a signal before returning execution | 21:22 |
| ralsina | if that's so, I have no idea whatsoever why that test fails. It's the same as all the others | 21:22 |
| nessita | I ll debug it a bit | 21:23 |
| ralsina | plus, it works IRL | 21:23 |
| ralsina | I just read the C++ code for QAbstractButton and it does emit clicked() immediately. | 21:30 |
| nessita | ralsina: so... puzzle! | 21:32 |
| ralsina | nessita: I had guessed that about the event loop because on test_choose_signin_cancel I had to add a processEvents in the middle of the test or it failed (using click, too) | 21:33 |
| nessita | ralsina: I ve been there with GTK, and that smeells | 21:33 |
| nessita | ralsina: let's keep the emit() for now, let's no waste more time | 21:33 |
| ralsina | ok, I'll keep it for that test | 21:33 |
| ralsina | Ok, I get it | 21:34 |
| ralsina | click() is hiding the overlay, but then next() is also getting called. | 21:34 |
| ralsina | Or maybe not. Let me check ;-) | 21:34 |
| ralsina | No, it's not that. Back to puzzled | 21:35 |
| ralsina | nessita: pushed with the clicked.emit() back in it | 21:37 |
| ralsina | + a puzzled comment | 21:37 |
| nessita | ack | 21:38 |
| ralsina | nessita: sorry about the harsher-than-necessary comments a while ago, this has been a very frustrating day, and I apologize | 21:41 |
| nessita | ralsina: is ok :-) | 21:41 |
| ralsina | nessita: when I screwup i public, I apologize in public :-) | 21:42 |
| nessita | makes sense | 21:43 |
| === statik` is now known as statik | ||
| duanedesign | karni: sorry i missed you. Was booted into windows for a bit | 22:18 |
| karni | duanedesign: no probs :) nessita helped out my tired memory ;) | 22:19 |
| nessita | duanedesign: OMG! are you ok after that?!?!?! | 22:19 |
| nessita | :-P | 22:19 |
| karni | duanedesign: FYI the answer is: make sure your system clock is synced with NTP or just make sure it's not too much off :) | 22:19 |
| duanedesign | nessita: ha! :D It is definetly a frustrating experience. | 22:20 |
| duanedesign | anyoone have a PowerPoint ppt file i can use for a test? | 22:24 |
| karni | duanedesign: Who uses that, yuck! ;) | 22:24 |
| karni | duanedesign: Use google docs and export some sample to .ppt | 22:24 |
| karni | duanedesign: I'm pretty sure they have that. | 22:24 |
| duanedesign | ohhhhh really | 22:24 |
| * duanedesign looking | 22:24 | |
| ralsina | Ok, I am taking a break now, will probably do a couple more hours tonight. If anyone needs me, email me. | 22:29 |
| ralsina | nessita, alecu, I sent the email to marianna, there is a nice hotel near my home that has room | 22:29 |
| ralsina | http://parajedealmas.com | 22:29 |
| ralsina | b-b-b-b-b-ye | 22:29 |
| nessita | ralsina: and that hotel has internez? | 22:31 |
| ralsina | nessita: allegedly, wifi everywhere | 22:31 |
| ralsina | fibertel, 10MB | 22:31 |
| nessita | ralsina: sounds good | 22:31 |
| ralsina | So, expect good downloads, not-so-good uploads | 22:31 |
| ralsina | anyway, it's not like it's 30 of us, so it should manage :-) | 22:32 |
| alecu | hmpf. Will need to pause my downloads. | 22:32 |
| alecu | nessita, I didn't notice you were still here | 22:33 |
| nessita | alecu: I'm! :-) | 22:33 |
| nessita | I was investing some extra time trying to get SSO (qt version) building on linux | 22:33 |
| nessita | (extra time of my own ;-)) | 22:33 |
| nessita | is building, but it will not run, windows is all over the place in the controllers implementation | 22:34 |
| duanedesign | thanks karni i was able to export a ppt file | 22:39 |
| karni | duanedesign: yw | 22:39 |
| nessita | ok, I'll run some errands now | 22:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
