/srv/irclogs.ubuntu.com/2011/07/19/#ubuntuone.txt

DiegoSarmenteronessita, hi, are you there?00:00
nessitaDiegoSarmentero: I am!00:25
DiegoSarmenteronessita, Hi, I having some problems trying to test windows installer on linux00:26
DiegoSarmenterothe dependency that i show you today......00:26
nessitaDiegoSarmentero: why?00:26
DiegoSarmenteronessita, that it says that there isn't a module named qt.gui00:27
DiegoSarmenteroin test_gui.py00:27
nessitaDiegoSarmentero: you trying on linux or windows?00:27
DiegoSarmenterolinux00:27
nessitaDiegoSarmentero: installer will not work on Linux :-(00:28
DiegoSarmenteronessita, neither the tests?00:28
DiegoSarmenteronessita, i'm only want to run the tests00:28
nessitaDiegoSarmentero: with what we have in trunk, not even the test. I just build a branch that I'm about to propose that allows you to:00:29
nessita1- build the QT ui modules in sso (the thing that is failing for you)00:29
nessita2- run the tests in the installer00:30
nessitaDiegoSarmentero: wanna try it?00:30
DiegoSarmenterosure!00:30
DiegoSarmenteronessita, ^00:30
nessitaDiegoSarmentero: so, for building SSO in linux please branch the following:00:31
nessitalp:~nataliabidart/ubuntu-sso-client/build-on-linux00:31
nessitaDiegoSarmentero: enter that dir and run ./setup.py build in it00:31
DiegoSarmenterook00:31
DiegoSarmenterodoing it :P00:31
nessitathen, go to the installer code, and set PYTHONPATH like this:00:32
nessitaPYTHONPATH=../../../ussoc/build-on-linux/:../../controlpanel/trunk/:. ./run-tests00:32
nessitaDiegoSarmentero: that will fail with00:33
nessitaexceptions.AttributeError: 'module' object has no attribute 'windll'00:33
nessitai'm building  a branch to fix it, but basically grab ubuntuone_installer/gui/qt/local_folders.py and make default_folders return a fixed list of one folder00:33
DiegoSarmenteronessita, ok... i'll try it!00:35
DiegoSarmenteronessita, because in windows i couldn't run the test ever00:35
DiegoSarmenteronessita, i'm setting up some other environments in different vms, with win7 too00:35
nessitaDiegoSarmentero: the needed changes in the windows-installer branch are lp:~nataliabidart/ubuntuone-windows-installer/run-test-in-linux00:42
DiegoSarmenteronessita, ok, downloading that now.......00:43
DiegoSarmenteronessita, question.....00:43
nessitaDiegoSarmentero: shoot00:43
DiegoSarmenteronessita, where do i have to set the pythonpath in the installer?00:43
DiegoSarmenteronessita, it is loaded in a file property anywhere?00:44
nessitaDiegoSarmentero: when running the tests, for example:00:44
DiegoSarmenteroor just at the os level?00:44
nessitaPYTHONPATH=../../../ussoc/build-on-linux/:../../controlpanel/trunk/:. ./run-tests00:44
DiegoSarmenteronessita, ahhhhhhhh okok00:44
nessitaDiegoSarmentero: if that works for you, would you review https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/build-on-linux/+merge/68311 and https://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/run-test-in-linux/+merge/68310 ?00:47
DiegoSarmenteronessita, ok!00:47
nessitaralsina: if you have time, I would reviews from you for those above ^ :-)00:47
DiegoSarmenteronessita, YES!! IT WORKS!!!00:50
DiegoSarmenteronessita, that was... LEGEN.. wait for it... DARY! jeejjejej00:50
nessitaDiegoSarmentero: lolol00:51
nessitaDiegoSarmentero: all HIMYM is great until season 6, when the sitcom becomes SO boring00:51
DiegoSarmenteronessita, wait wait!! i'm in season 2!!!!!00:52
DiegoSarmenteroejejjeje00:52
nessitaDiegoSarmentero: ooooooh enjoy then, just up to season 5 is all way up00:52
DiegoSarmenteronessita, jeje ok...... i'll do that :P00:52
DiegoSarmenteronessita, now i'll review the branch00:52
DiegoSarmenteroboth00:53
nessitagreat00:53
nessitaDiegoSarmentero: most of the changes are to match up the controlpanel's  build class00:53
karniNight everyone!00:53
nessitaralsina: estás?01:56
DiegoSarmenteronessita, are you still there?02:30
DiegoSarmenteronessita, i have submitted more code in my windows installer branch....... now the tests are ok!! :D02:31
nessitaDiegoSarmentero: ok, I'll re-review tomorrow02:34
nessitaI m very tired now, I'm about to go to sleep02:34
DiegoSarmenteronessita, great! :P02:34
nessitaDiegoSarmentero: see ya tomorrow!02:34
DiegoSarmenteronessita, bye02:34
nessitabye all!02:34
alecuralsina, ping?03:57
pgranery-2-kids05:04
j0nrhello folks06:53
j0nrI have a question - is it possible to unsync a folder within a synced folder?06:53
mandelmorning all!!!08:40
karniMorning!09:42
faganmorning karni09:43
karni\o09:43
duanedesign*yawn* morning all10:38
faganmorning duanedesign10:38
* mandel away, bbl10:45
=== mandel is now known as mandel_afk
duanedesignhello fagan10:48
duanedesignrye: good morning!11:18
duanedesignrye: updating some of my canned responses. When a user needs to remove their Ubuntu One Token is it still necessary for them to not only remove the token in Seahorse but also visit https://one.ubuntu.com/account/machines/ and remove the computer?11:20
ryeduanedesign, when a user is removing the machine on Natty the control panel will notice this and ask for reauthorization, when machine is removed from earlier releases from ubuntuone-preferences this is not happening and the token needs to be removed from the server too11:23
duanedesignrye: thank you that answers it11:36
=== mandel_afk is now known as mandel
* mandel back11:40
nessitamandel: hi there!11:40
mandelnessita: hello11:40
faganoh hey nessita11:41
mandelnessita: shall we take a look at the brach?11:41
nessitamandel: have some minutes to talk about the listdir implementation?11:41
nessitayeap11:41
mandelnessita: we think alike :)11:41
nessita:-)11:41
mandelnessita: primate chat in spanish?11:41
mandelrather than making noise here :)11:41
nessitalol11:41
nessitasure11:41
mandel:)11:41
faganwell really im the only regular in here at the moment that doesnt speak spanish at all11:55
faganso it would only be noise to me11:56
fagan:)11:56
mandelrye: here you go: http://ubuntuone.com/p/10qw/12:36
mandelrye: ups, wrong channel, but is no a big problem :)12:37
faganwow holy crap I responded to a bug report and a guy's auto responder is flooding emails back and forth12:37
faganOh lp deletes posts that are spamming didnt know that12:38
faganthats pretty awesome12:38
ryefagan, it may not be deleting them but we need lp people to unsubscribe him12:39
ryefagan, because lp is sending notification back to his mailbox and it autoresponds12:39
ryeand we send notification again12:39
=== 77CAAV1DS is now known as karni
ryefagan, i asked on #launchpad12:41
faganrye: well I went to the bug and it was gone so I just presumed lp deletes them12:41
faganill go ask12:41
=== m_conley_away is now known as m_conley
faganStandup in 412:56
faganI think only mandel, nessita and I are actually here though12:56
mandellazy people….12:59
mandelvagos, que sois unos vagos!12:59
mandel:P12:59
faganmandel: we would all prefer to be sleeping I know it12:59
faganmoi13:00
nessitame13:00
faganoh alecu nice timing13:00
mandelme13:00
nessitaralsina: you feeling better?13:00
faganalecu: say me13:00
nessitadobey, ralsina: stand up?13:01
faganoh dobey is back forgot about that13:01
alecume13:02
nessitafagan: go13:02
faganwe might as well go and let the others catch up13:02
faganDONE13:02
fagan* Did some bug reports (mainly just changing statuses of bugs that affected ubuntuone-client and ubuntuone-client in ubuntu so they can time out)13:02
fagan* Phone call13:02
faganTODO13:02
fagan* More of the 3 months unassigned bugs (if nothing else is needed)13:02
faganmandel: go13:02
faganBLOCKED13:02
fagan* Nope13:02
mandelDONE: Fix fix-os-helper based on the comments form nessita. Played around with the idea of using FlushFileBuffers to ensure that the file system notification work on the tests... failed miserable at it.13:02
mandelTODO: Finish changes in fix-os-helper after a long chat with nessita about ? :P13:02
mandelBLOCKED: no13:02
mandelalecu, te toca!13:02
* alecu is writing notes13:03
mandelor nessita, don't know...13:03
nessitamandel: my turn was before you :-)13:03
nessitaDONE: bug #810656, syncdaemon-analysis mumble, daily mumble, lots of reviews, proposed a couple of branches for having SSO building on linux and installer tests passing on linux13:03
nessitaTODO: bug #810662, push forward mandel's branches, meetings13:03
nessitaBLOCKED: nopes13:03
nessitaNOTE: I'll leaving right after mumble to go to the Uni to evaluate some students13:03
nessitaNEXT: mandel^W alecu13:03
ubot4Launchpad bug 810656 in ubuntuone-control-panel "QT UI: Preferences tab do not show the loading overlay (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/81065613:03
ubot4Launchpad bug 810662 in ubuntuone-control-panel "QT UI: "Delete" button in the devices tab does not work (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/81066213:03
mandelalecu: tu13:03
alecuDONE: a branch to fix #811307; helped __lucio__; reviews13:04
alecuTODO: probably work on one of bug #803672 and bug #80366913:04
alecuBLOCKED: no13:04
ubot4Launchpad bug 803672 in ubuntuone-client (Ubuntu) (and 2 other projects) "Do not start two instances of this process (affects: 1) (heat: 6)" [Undecided,Invalid] https://launchpad.net/bugs/80367213:04
ubot4Launchpad bug 803669 in ubuntuone-client (and 1 other project) "Get the port numbers from the users' registry (affects: 1) (heat: 6)" [Low,Triaged] https://launchpad.net/bugs/80366913:04
nessitaalecu: I think you fixed bug #811007 with one of your latests branches, did you?13:04
ubot4Launchpad bug 811007 in ubuntuone-client "Syncdaemon is not exposing the "connect" method on windows (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/81100713:04
nessitaalecu: and I reviewed the unbreak-connect, I asked some info there13:04
alecunessita, then I wrote the wrong number in my report13:05
alecunessita, nice13:05
nessitaalecu: I think you got the numbers right, that bug report may have been fixed as a side effect13:05
alecunessita, mandel: I need to take amelia to kinder right now; I'll be back for the mumble meeting13:05
mandelalecu: cool, I'll be at lunch :)13:05
ralsinamorning13:09
alecunessita, you were right: the bug you mention was fixed in a previous u1-client branch.13:09
ralsinasorry about being late, I had a bad case of gastritis last night, standup coming up in 1'13:09
dobeyholas al todos13:09
alecuok, I'm off: see you guys in half an hour or so.13:10
nessitaalecu: ack13:10
nessitaralsina: feeling better?13:11
ralsinanessita: yeah13:11
dobeyλ DONE: holiday, finished bug #809561, started reorg plan13:11
dobeyλ TODO: reorg plan, shim code13:11
dobeyλ BLCK: None.13:11
ubot4Launchpad bug 809561 in ubuntuone-dev-tools "Support ignoring paths in u1lint (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/80956113:11
ralsinanessita: after I get the medicine it goes away in 2 hours or so, the problem is I was hurting from 2 to 6 AM :-(13:11
nessitaralsina: you don't have some medicine at home?13:11
ralsinanessita: I do, but sometimes I need a shot13:12
ralsinanessita: usually, a pill is enough, but last night I had the pill and was feeling worse and worse so I ended going to the doctor at 4-something AM13:13
ralsinanessita: Got the shot, was well in 5 minutes13:13
ralsinaDONE: sprint planning, worked in bug #800376 (making some progress), calls13:14
ubot4Launchpad bug 800376 in ubuntuone-windows-installer "Add "syncing your computer to the cloud" page to the installer (affects: 1) (heat: 8)" [High,In progress] https://launchpad.net/bugs/80037613:14
ralsinaTODO: fix what needs fixing on my pending branches, finish 80037613:14
ralsinablOCKED: no13:14
ralsinaOk, work. Nessita, do you still need reviews on the branches you mentioned last night?13:18
nessitaralsina: yessir13:20
ralsinanessita: ok, I have the mgmt call in 5' will check them right after13:25
=== zyga is now known as zyga-food
nessitaralsina: okis13:26
* nessita -> panadería, brb13:31
=== mbarnett` is now known as mbarnett
* nessita is back13:41
ryefacundobatista, hi, do you recall the bug # for syncdaemon saturating the link due to bw throttling code logic?13:41
nessitarye: bug #72070713:43
ubot4Launchpad bug 720707 in ubuntuone-storage-protocol "Bandwidth limit is not correctly enforced: Transmission delays are inserted between data chunk writes (of arbitrary sizes) (affects: 22) (dups: 5) (heat: 82)" [Medium,Confirmed] https://launchpad.net/bugs/72070713:43
ryenessita, awesome, thanks!13:43
nessita:-)13:43
alecuand I'm back!13:44
mandelalecu, nessita, mumble, right?13:45
alecunessita, mandel, ralsina, Chipaca: mumble?13:45
nessitaralsina: you off the management call?13:45
ralsinaalecu: Chipaca and I are n another call13:45
ralsinaprobably until about 11:30 ART13:45
nessitawe always forget...13:46
mandelwho wants to crash a conference call?13:46
alecuralsina, so, in 45 more minutes. cool13:46
facundobatistarye, ah, I was searching for it13:46
ralsinaalecu: I answered your needs info in https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/6789413:46
alecuralsina, cool, will look at it.13:47
ryefacundobatista, my awesomebar has forgotten some of the bug reports so I am relying on search which does not include storage protocol :(13:47
facundobatistarye, I filtered #chicharra for ubuntuone-client, too, that's why I wasn't finding it :(13:47
* nessita uses firefox search engine13:51
fagan /win 1113:56
fagandamn irssi13:56
nessitafagan: I bet irssi thinks the same ;-)13:56
ryenessita, ok, i know you know this one - the failure to create UDF in case other folder startswith the same characters.13:56
nessitarye: you should know that is fixed in trunk, but let me grab the bug for you13:57
ryefirst i lost half of bugs during migration to ff4 then some more to ff613:57
ryeevery time i upgrade firefox i become dumber13:57
fagannessita: I love irssi but I do tend to make mistakes changing window sometimes which is very funny :)13:57
nessitabug #64994513:57
ubot4Launchpad bug 649945 in ubuntuone-client "Incorrect FolderCreateError (UDF's can not be nested) (affects: 4) (dups: 1) (heat: 23)" [High,Fix committed] https://launchpad.net/bugs/64994513:57
nessitarye: ^13:57
ryenessita, thanks again!13:58
nessita:-)13:59
nessitaalecu: when you have a moment, let me know about https://code.launchpad.net/~alecu/ubuntuone-client/unbreak-connect/+merge/6830914:01
alecunessita, sure.14:03
mandelalecu: if I wanted to see if an object is iterable we agreed that getattr(blah, '__iter__', None) is what we want to do, right?14:11
alecumandel, ???14:11
alecumandel, did we agree on that?14:11
mandelalecu: well, in using getattr rather than hasattr, right?14:12
mandelI always get confused with this...14:12
alecumandel, oh, yes. hasattr == caca14:12
alecumandel, the bit about "iterable" is up to you.14:13
mandelalecu: ok, I though so..14:13
alecumandel, well, strings are iterable, but they don't have __iter__14:13
alecumandel, and unicode objects don't have __iter__ either.14:13
alecumandel, on the other hand, lists, dicts, sets, tuples and custom made sequences do have __iter__14:14
=== zyga-food is now known as zyga
mandelalecu: yeah. I was going after list, dicts, setc etc… and ignoring str and unicode because they do not have __iter__, is that hacky?14:16
alecumandel, I don't understand what you'll be using this for, so I don't know if it's hacky :-)14:17
alecumandel, if you want to consider str and unicode, you should do this:14:17
alecutry: iter(n); return true; except TypeError: return false14:18
alecubut use True and False :P14:18
mandelalecu: I'm writing a decorator that will make sure that all os_helper method that return paths or a list of paths do return them as str and wanted to use a single decorator...14:18
mandelyou record I should use two diff decorators?14:19
mandelnessita: input welcome ^14:19
alecumandel, two, absolutely.14:19
mandelalecu: ok14:19
alecumandel, I don't like apis in python that take a string or a list of strings as the same parameter.14:19
nessitamandel: I agree with 2, but for future reference: from collection import Iterable14:19
nessitaisinstance(something, Iterable)14:20
mandelnessita: oh, nice14:21
alecumandel, http://stackoverflow.com/questions/1952464/in-python-how-do-i-determine-if-a-variable-is-iterable14:22
nessitaalecu: they copied me! :-P14:22
alecumandel, I like the idea of doing this in a decorator, because (in a few months) we may short-circuit it when we need more speed, and only leave the check if DEBUG=True14:25
alecumandel, but again, let's do that in a few months, after we have seen this all is working for some time.14:25
mandel:)14:25
nessitamandel: did you chat with alecu re: listdir?14:26
dobeyhmm14:26
alecuyes, we are turning python into a static typed language.14:27
nessitaalecu: so we have no option other than doing bytes -> unicode -> listdir -> bytes?14:28
mandelnessita: I did not...14:28
nessitamandel: you should! :-) alecu knows a lot, and I'm not 100% happy with the idea of building unicodes to listdirs14:29
mandelalecu: main problem is that you use listdir(byte) you loose some information that is needed to mangle the path so that illegla paths are synced to windows14:29
mandelalecu: let me get you the branch with the implementation14:29
mandelalecu: https://code.launchpad.net/~mandel/ubuntuone-client/fix-os-helper/+merge/6822714:30
alecumandel, looking14:31
mandelcheers!14:31
mandelalecu: the problem that we are working around is shown here: http://paste.ubuntu.com/647224/14:34
mandelthe evil detail is in the alst line14:37
mandels/alst/last14:37
alecumandel, I don't understand what's the evil in that14:41
mandelalecu: mumble? it does make more sense spoken than writen… nessita and I have already gone through that pain :)14:43
alecumandel, ok14:43
nessitaI'll join you14:43
nessitaralsina: you available for mumble now?14:52
nessitaChipaca: ^14:52
ralsinanessita: on the phone, will be in 5'14:52
nessitaralsina: you still in the management meeting?14:58
ralsinanessita: no, phone with my mother14:58
ralsinathere. done :-)14:58
nessitaChipaca: you available to join us?14:59
Chipacanessita: now i am15:00
nessitaChipaca: awesome!15:00
Chipacanessita: yes, I am.15:00
ralsinamandel: mumble ping?15:01
mandel1nessita: so, my internet went nuts… did I miss something, is everyone in silience?15:01
nessitamandel1: we're waiting for you, can you hear uis?15:02
mandel1no...15:02
mandel1let me restart mumble15:02
nessitayeap15:02
mandel1seems that its reconnect function is not great15:02
mandel1ya oigo!15:03
mandelhow to loose a team member in the first day => make him share a room with mandel15:08
fagan also mandel how to kill a team member drink with mandel15:10
mandel:P15:12
mandelnessita, alecu: pushing the branch15:15
mandelalecu, nessita: in spanish: ralsina no se quire quedar con el culo al aire…15:17
mandel:P15:17
mandelralsina: I think is possible for tuesday :)15:17
mandelor earlier15:17
mandelnessita, alecu: I'm going to run the tests on linux, if lint and tests are ok, the branch is ready for review15:30
dobeybbiab, lunch15:40
faganNeed to head out a tad early ill make it up tomorrow morning I have to run to get something before 515:42
mandelalecu, nessita: please take a look at the smaller yet monster MP: https://code.launchpad.net/~mandel/ubuntuone-client/fix-os-helper/+merge/6822715:46
nessitamandel: looking15:47
nessitamandel: this branch is bigger and bigger!15:48
mandelnessita: thx!15:48
nessitamandel: can you please split this in:15:48
alecumandel, reluctantly looking!15:48
mandelnessita: yes… it started small but we kept improving it15:48
nessita* remove abspath only one branch15:48
nessita* add tests for access and can_write, another branch15:48
nessita* add decorators to os_helper, another branch15:49
nessitais that doable without too much trouble?15:49
* mandel cries...15:49
mandelnessita: well, I can take a look at how to do it.. but is 17:50 here and I prefer not ro delay this anymore15:50
nessitamandel: ok, I can propose a couple of smaller branches based on yours15:51
nessitaotherwise we can make mistakes reviewing since this is too big15:51
mandelnessita: how can I help?15:52
nessitamandel: keep working on your other branches :-), I may ping you for reviews15:52
mandelnessita: ok, will do that then15:52
nessitaalecu: I'll split mandel's branches in smaller ones, so you may wanna pause the review15:54
Chipacakarni: http://askubuntu.com/q/53654/711 (btw)15:56
* karni opens15:56
karniChipaca: ummm...... My post has been deleted. "We have this on our TODO list as it has also been requested via support email. Stay tuned!" - I suck at answering?15:57
karniMaybe I should have started with "Hi! I'm Software Developer at Canonical"15:57
Chipacakarni: meh15:58
Chipacakarni: let me figure what's up with that15:58
karniChipaca:  I can repy again, in a more formal way.15:59
karniChipaca: the author removed the answer15:59
karniChipaca: I improved my answer.16:01
Chipacakarni: looks like he deleted it again?16:03
karniChipaca:  I edited the deleted answer and clickd "undelete" for the moderator to look at16:03
karniChipaca: I think getting this undeleted rather than answering again should be better?16:04
* mandel is happy , the assertions in os_helper have started to be useful :)16:04
karniChipaca: Not to mention it's not even really a question heh ;) But that's just me picking on the guy. It should get undeleted soon.16:05
nessitamandel, alecu: trivialish -> https://code.launchpad.net/~nataliabidart/ubuntuone-client/no-custom-abspath/+merge/6841816:06
* mandel goes fast as lighting 16:06
alecuack16:07
Chipacakarni: check it out now :)16:08
mandelnessita: looks great, but can you remove comment in line 50 of the diff, I should have done it but I for got, the one that starts with '# TODO: because tritcask does not work well with \\?\ we are adding it16:11
karniChipaca:  hahahah :) good16:15
nessitamandel: sure!16:15
alecunessita, the branch looks great. I'm running the tests now.16:16
nessitamandel: comment removed (I removed a couple similar ones) and pushed to revno 105716:18
mandelnessita: ok, I've checked it on windows and you have a +1 from me16:18
nessitagreat16:19
mandelI'll be away 10 min, will be back though16:19
=== mandel is now known as mandel_bbl
ralsinanessita: Diego's branch has a needsfixing from you: https://code.launchpad.net/~diego-sarmentero/ubuntuone-windows-installer/installer-ui/+merge/6778816:26
nessitaralsina: hum, let me confirm16:26
nessitaralsina: not anymore!16:26
ralsinanessita: have links to your branches handy? I can do some reviews now16:28
nessitaralsina: sure!@16:28
nessitahttps://code.launchpad.net/~nataliabidart/ubuntu-sso-client/build-on-linux16:28
nessitahttps://code.launchpad.net/~nataliabidart/ubuntuone-windows-installer/run-test-in-linux16:28
nessitaralsina: ^16:28
ralsinanessita: on it!16:29
ralsinanessita: +1 on both, I took the liberty of setting them to approve16:35
nessitaralsina: awesome!16:35
dobeythisfred: did you see my note on your branch re: the merge failure?16:35
alecunessita, approved the abspath branch.16:36
nessitaalecu: thanks!16:36
thisfreddobey: yup, fixed, just rerunning the tests16:36
dobeythisfred: ah ok, cool16:36
thisfreddobey: and fixed16:37
thisfreddobey: so could you remove your needs fixing? :)16:39
ralsinaalecu: sorry to bother you, but could you check https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/6789416:40
ralsinaalecu: it's my "big" pending branch, I don't want that one to diverge16:41
ralsinanessita: you promised me an approval for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/show_spinner/+merge/68145 (the one with the puzzling click/clicked thing)16:42
alecuralsina, looking16:42
ralsinaalecu: thanks!16:42
nessitaralsina: you're right16:43
ralsinanessita: thanks!16:44
dobeythisfred: done16:47
thisfredthx16:48
alecuralsina, can I ask you to review this smallish branch? https://code.launchpad.net/~alecu/ubuntuone-control-panel/use-status-changed/+merge/6811716:49
ralsinaalecu: of course!16:49
ralsinaalecu: I tested that on friday! MUst have forgotten to add the review :-(16:50
alecuralsina, nessita: sorry to be bothersome, but I still don't understand why we need to have the ubuntuone-windows-installer running in the ubuntu-sso-client process:16:54
alecuhttps://code.launchpad.net/~ralsina/ubuntuone-windows-installer/fix-810053/+merge/6789416:54
ralsinaalecu: re-tested and +116:54
ralsinaalecu: because it's how SSO works.16:54
nessitaalecu: is a mix about how sso is designed and how ralsina designed the wizard16:54
ralsinaalecu: the SSO UI always runs in the SSO process.16:54
ralsinaAnd since we need to have the SSO widgets inside the wizard...16:55
nessitaalecu: basically, in the SSO API, we state16:55
nessitaalecu: "give me your app name, your tc_url, etc, *and* your UI class and module and I take care of everything"16:55
alecuugh!16:55
nessitaalecu: the problem is that the UI module from the wizard is the wizard itself16:55
alecunessita, ok, I understand that.16:56
ralsinain gtk this is not so bad because you can embed widgets across apps16:56
nessitainstead of having the auth process "separated" from the rest, which from my POV is what we should do16:56
alecuralsina, right16:56
ralsinaThe other way to do it would be to do most of ussoc's job in the installer process (which is how it was) but that was failing because it didn't do the ping. Rather than add the ping, we decided to go this way.16:57
alecunessita, ralsina: anyway, I agree that the UI for this looks fine. I just wanted to understand why we are introducing this weird module dependency loopback16:57
ralsinaalecu: well, it's not really a loop16:57
ralsinaalecu: since sso nly depends on installer when used *by* installer16:57
dobeyralsina: you can't embed the qt widget in the qt app? :)16:57
ralsinadobey: not accross process boudaries16:58
nessitamandel_bbl, alecu: another split from mandel's branch at https://code.launchpad.net/~nataliabidart/ubuntuone-client/add-tests-access-can-write/+merge/6842816:58
alecuralsina, hmm.... ok.16:58
dobeyralsina: surely qt has a plug/socket API16:58
alecuralsina, approving.16:58
ralsinadobey: nope. I mean, I *could* use ActiveX on windows to do this, but, really?16:58
dobeyalthough i don't know what you mean by "boundaries" there16:58
ralsinadobey: instantiating one widget on one process and its parent widget on another16:59
dobeyralsina: why would you use activex? is that what qt uses on windows to provide XEmbed functionality?16:59
ralsinadobey: you understand xembed doesn't work on windows, right? ;-)16:59
ralsinathe way to provide "embedded apps" in windows is activex, yes. Or some variation of what used to be OLE17:00
alecuralsina, approved.17:00
ralsinaalecu: cool, thanks17:01
dobeyralsina: xembed itself doesn't (well, unless you have X running also), but surely there is some API that provides the same functionality in qt, like there is in gtk+17:01
ralsinadobey: not that I know of17:02
ralsinadobey: google tells me there is a reparent() call though17:03
ralsinadobey: but only works inside a process :-(17:04
dobeyoh, hmm17:05
dobeygtk+ only has plug/socket on X11 target it seems. guess it isn't ported to win32 then :(17:05
ralsinadobey: that is really non-trivial to do on windows. SDL has it, though17:07
dobeyralsina: nevermind me then. but could stick the widget in a library and just talk to the backend over IPC, and embed the widget17:07
dobeyralsina: i wouldn't call it trivial to do on X11, either :)17:07
nessitaralsina: I'm testing the show_spinner IRL, can you please confirm when I should see the overlay 'loading'?17:07
ralsinanessita: when you click on "login"  for example, or in "set up account"17:08
nessitaralsina: when loading the TOS as well?17:08
ralsinanessita: that is another branch17:08
nessitaah ok17:08
nessitaralsina: and when the overlay should go away?17:09
nessitabecause I submitted the form with empty fields, got the loading, got the errors, clicked on "ok" in the error warnings and the overlay will never go away17:09
ralsinanessita: ohhhhhhhh ok, didn't try that!17:10
ralsinanessita: nevermind then ;-)17:10
nessitaralsina: always try as many workflows as you can think of, remember 2 things: - users are "evil" - we don't have a separated QA process17:12
nessitaralsina: so we need to ensure the quality ourselves17:12
ralsinanessita: yeah17:12
ralsinanessita: I tried all the "positive" paths, missed the error ones17:12
* mandel_bbl back17:15
ralsinamandel: just a quick question: https://bugs.launchpad.net/ubuntuone-client/+bug/81052117:16
mandel_bblnessita: I'm back doing some work in the other branches, if you need a review et me know17:16
ubot4Launchpad bug 810521 in ubuntuone-client "Typo in signal name (affects: 1) (heat: 343)" [High,Triaged]17:16
nessitamandel_bbl: I do, https://code.launchpad.net/~nataliabidart/ubuntuone-client/add-tests-access-can-write/+merge/6842817:16
ralsinamandel_bbl: if you tell me the names of those signals I will fix it :-)17:16
nessitamandel_bbl: there are some test failures in windows in listdir, the rest is green17:17
=== mandel_bbl is now known as mandel
mandelnessita: you mean in that branch?17:18
mandelralsina: what's the problem17:18
nessitamandel: I need reviews for that branch, yes17:18
mandelnessita: and in that branch, there are errors in listdir, right?17:18
ralsinamandel: one signal is written "on_equest" and I am guessing that's a missing r. Another one is called "request_queue_removed" which doesn't seem to follow the convention for the others ("on_request_whatever")17:19
nessitamandel: yeah, also in trunk17:19
nessitamandel: but all that is without your os_helper fixes17:19
nessitaso I guess it makes sense?17:19
mandelnessita: sounds like it17:19
mandelralsina: indeed, those look like typos17:21
ralsinamandel: ok, I was not sure about the second one17:21
mandelteh signal is on_...17:22
ralsinamandel: ok, will propose the trivial fix in a few minutes17:22
mandelralsina: hurray!17:23
ralsinamandel, alecu, nessita, DiegoSarmentero: we will have lots of syncdaemon help in the sprint from chicharra visitors17:23
alecuwoohoo!17:24
mandeltoma!!!17:26
mandelDiegoSarmentero: do not get scared by the spaniard while at the sprint, I'm like that always :P17:26
mandelnessita: running tests, if the pass will approve17:26
nessitamandel: well, they all will not pass17:27
nessitamandel: listdir test is failing here, remember17:27
mandelnessita: the ones you added do not pass?17:27
nessitathey do!17:27
mandelok, then if those pass :)17:27
=== beuno is now known as beuno-lunch
wh1zz0Hello whitehats.. Hi guys.. does anyone here know if my synced files will get deleted from the ubuntu one cloud server upon subscription expiration?17:32
ralsinamandel: trivial branch for review: https://code.launchpad.net/~ralsina/ubuntuone-client/fix-810521/+merge/6843517:33
ralsinawh1zz0: no they won't. You won't be able to upload anything until you are under the free 2GB though17:33
alecuwh1zz0, they won't be deleted right now, but this may change in the future.17:33
wh1zz0Okie.. so if I have like 20gb and subsciption expires, I won't lose anything right, only thing is I might not be able to upload more, how about download existing files?17:34
ralsinawh1zz0: that should still work17:36
wh1zz0Thanks a bunch ralsina :) Ubuntu rocks!17:36
DiegoSarmenteromandel, jejeje sorry i was eating..... spookie! jeje17:41
mandelnessita: still waiting for the branc to finish… dammed 3g!17:42
mandelestupida isla sin internet!17:42
mandelDiegoSarmentero: :P17:43
mandel1ralsina: did you run the test on windows?17:51
mandel1nessita: approved, or so I believe...17:51
mandel13g, not reliable...17:51
ralsinamandel1: I did but I never know which ones *should* work today17:51
mandel1ralsina: ok, I can give a code review.. but branching is taking aaaaaages :(17:52
ralsinaDiegoSarmentero: when you propose a branch, always remember to set the commit message field, or things never merge17:52
DiegoSarmenteroralsina, ok... sorry about that17:53
ralsinaDiegoSarmentero: we all forget every now and then :-)17:53
mandel1that is what she said...17:53
mandel1ralsina: I dare you to guess what I'm talking about ;)17:53
ralsinamandel1: that's what you get for dating alzheimer-addled senior citizens17:54
mandel1ralsina: hehe good one, but mine was waaaay dirtier :P17:54
mandel1ralsina: and I don't like sushi when talking about this things..17:54
mandel1creo que me pase con esa...17:54
* ralsina points in the general direction of the employee manual17:55
mandel1I guess that is the EOD for me or I might be spelled due to the code of conduct...17:55
mandel1ralsina: hahaha17:55
mandel1a2!17:56
DiegoSarmenteroralsina, i saw that there are some conflicts trying to merge the branch, i'll review it as soon as i reach home18:02
DiegoSarmenteroralsina, is that ok?18:02
duanedesignrye: i have a user that is getting I/O error with tritcask metadata on an encrypted $HOME. Is the best workaround to delete the offending metadata and do a rescan?18:06
ralsinaDiegoSarmentero: sure18:08
duanedesignrye: found what i needed.18:25
ryeduanedesign, no no no, wait, is he on ecryptfs?18:26
nessitaralsina: can you review https://code.launchpad.net/~nataliabidart/ubuntuone-client/add-tests-access-can-write/+merge/68428 ?18:27
ralsinanessita: can it wait 1 hour? I am about to have lunch18:28
nessitaralsina: sure18:28
duanedesignrye: yes, i believe so18:28
ryegr18:28
* rye is grrring18:28
duanedesignrye: i traced some of his error messages to bug #37201418:28
ubot4Launchpad bug 372014 in ecryptfs-utils (Ubuntu Karmic) (and 4 other projects) "errors in dmesg (dup-of: 509180)" [Low,Confirmed] https://launchpad.net/bugs/37201418:29
ubot4Launchpad bug 509180 in linux (Ubuntu Oneiric) (and 5 other projects) "ecryptfs sometimes seems to add trailing garbage to encrypted files (affects: 115) (dups: 9) (heat: 334)" [Medium,Fix released] https://launchpad.net/bugs/50918018:29
=== beuno-lunch is now known as beuno
ryeduanedesign, awesome bug report, ecryptfs... why, oh why?18:39
ryeduanedesign, finished reading. splendid :-/18:46
ryeverterok, in case tritcask file cannot be opened due to I/O Error, what happens?18:47
verterokrye: I think there is a bug about that /me search for it18:48
verterokrye: if I remeber correctly I think it dies if the broken file is the live data file18:48
duanedesignrye:  yeah i just finished reading 509180 . Looks like a mess18:48
ryeverterok, okay, so it dies... so it does not write to that file? ecryptfs appends garbage to the file under some circumstances, which later on introduce IOErrors when reading.18:49
verterokrye: garbage is not the same as broken18:49
nessitabeuno: I couldn't debug my issue, but I've found bug #813071 in the way of analysis the code18:49
ubot4nessita: Bug 813071 on http://launchpad.net/bugs/813071 is private18:49
ryeduanedesign, have you understood how can this be recovered, is unmounting the private directory enough?18:49
verterokrye: tritcask should survive reading a file with garbage, it will not survive if it can't open the file18:50
ryeverterok, kernel sends IOError on open, nothing to read in this case18:50
beunonessita, so not a total loss!  I'll assign it to vds`18:50
nessitabeuno: :-)18:50
verterokrye: then, the file is broken :)18:50
ryeverterok, ok, in the worst case, can we delete live tritcask metadata w/o some really awful consequences?18:51
verterokrye: it will cause the loss of that metadata18:52
verterokrye: image not being able to open a sqlite journal :)18:52
verterokall those changes are gone18:52
ryeverterok, well, yeah, what will happen next? :)18:53
duanedesignrye: one of the comments mentions "copying the lower file somewhere else allows me to recover the original file"18:53
verterokrye: need to manually recover? :)18:53
verterokrye: there is a bug about a specifc error where the live data file is broken (python can't open the file), which should be simple to fix18:54
ryeduanedesign, somewhere else?... Hard to imagine what "recover" means in this case, copy is just a read()...18:54
verterokrye: how to recover from that? the only way is to loss data or start over (remove everything and resync )18:54
verterokrye: with data I mean "metadata" :)18:54
ryeverterok, in our case it can't open a file because it is overencrypted (i.e. encrypted and then a set of zero bytes appended)18:55
verterokrye: the kernel can't open the file?18:55
ryeverterok, the ecryptfs layer returns I/O error during open18:56
verterokrye: so, it's broken :)18:56
verterokas fopen fails :)18:57
verterokrye: remove the file, it's the only way to make it work18:58
verterokrye: the fix for the bug will be to discard the file, and create a new one18:59
verterokand log a big warning message18:59
ryeduanedesign, so yes, it looks like removal and creating new file is a workaround19:00
ryebeuno, you recently encountered a big crash of ecryptfs, has anything went missing or IOErroring ?19:01
beunorye, not AFAICT19:03
duanedesignrye: thank you19:03
duanedesignbug #77638619:06
ubot4Launchpad bug 776386 in ubuntuone-client "File Sync error (IOError with tritcask metadata) (affects: 9) (dups: 2) (heat: 36)" [High,Incomplete] https://launchpad.net/bugs/77638619:06
duanedesignis the U1 bug on this issue^19:08
nessitaalecu: can you do a review for me? https://code.launchpad.net/~nataliabidart/ubuntuone-client/add-tests-access-can-write/+merge/68428 actually is mandel's code19:13
alecunessita, approved.19:23
nessitaalecu: thanks!19:24
alecuand now I'll get me some food.19:24
nessitaalecu: enjoy19:24
ralsinanessita: I pushed show_spinner again with fixes for the error cases (all I could find, at least). https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/show_spinner/+merge/6814519:41
nessitaralsina: with tests for those cases? :-)19:42
ralsinaI added a "critical" method that is used for popups19:42
ralsinaand that method is tested19:42
ralsinaI added a new controller for "forgottenpassword" that hides the overlay. That needs a test (sorry)19:43
ralsinaI noticed as I was writing that ;-)19:44
nessitaralsina: is ok, let me know when that's done19:44
ralsinanessita: sure19:44
ralsinanessita: pushed show_spinner with the missing test19:54
nessitaralsina: ack19:55
ralsinanessita: need any reviews ? I have a slot now19:57
nessitaralsina: yes!19:57
nessitahttps://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/letmeremove/+merge/6844419:57
ralsinanessita: on it19:57
nessitathanks19:57
ralsinanessita: I get an insecurejelly error when running that branch IRL20:08
ralsinahttp://pastebin.ubuntu.com/647596/20:08
ralsinais this the thing about clearing credentials failing that you mentioned in email?20:09
nessitaralsina: the traceback under 2011-07-19 17:06:49,773 - ubuntuone.controlpanel.backend - ERROR - process_unauthorized (clearing credentials): is this bug #81306620:09
ubot4nessita: Bug 813066 on http://launchpad.net/bugs/813066 is private20:09
nessitaralsina: what comes next, is clear_credentials failing, yes20:10
ralsinanessita: if not, it looks much like it20:10
nessitaalecu: have you gathered enough  jellyfish-foo to confirm or deny that ^?20:10
ralsinaI do have tons and tons of repeated devices here, though, so may be unique to me20:11
alecunessita, ralsina: that *should* be fixed when my latest branch lands20:36
ralsinaalecu: cool20:36
alecunessita, ralsina: btw: do you have a windows 7 64bits and an xp?20:36
ralsinaI have a 7 64 bits and a xp20:36
nessitaalecu: only 32bits win 720:36
ralsinabut my 7 has 32 bit python20:36
alecuralsina, cool. Can you try this on both 764 and xp? http://pastebin.ubuntu.com/647568/20:37
ralsinaalecu: sure20:37
ralsinaalecu: on 7, I get 100120:37
alecuralsina, it should print the user id (for instance "1001" on my 732)20:37
ralsinaxp is going to take a few minutes20:38
alecuralsina, I can wait :-)20:38
ralsinaalecu: I forgot , my xp VM is "clean" and has n python20:39
ralsinano python20:39
alecuralsina, ok, got it. Don't worry, I'll just assume this works on xp as well :-)20:40
ralsinaalecu: leave a message for fagan to try and tell you early tomorrow20:40
ralsinahe has a XP devenv setup20:40
alecuralsina, cool20:41
ralsinanessita: when you got 5 minutes I need to cry in your shoulder :-/20:41
nessitaralsina: any other hint, so I can prepare psychologically?20:41
ralsinanessita: have control panel trunk and lp:~ralsina/ubuntuone-windows-installer/fix_800376_2 handy20:43
ralsinaI *think* I am not doing anything wrong but I get a crash, without traceback, somewhere inside controlpanel when I use volumes_info20:43
nessitaralsina: why would you use volumes_info in the wizard?20:44
nessita:-)20:44
ralsinanessita: it's called by validate_path_for_folder20:44
ralsinathen volumes_info calls sd_client.get_root but that fails20:44
nessitaralsina: do you have sd running?20:45
ralsinanessita: I thught we had activation for that20:45
ralsinabut I have tried it with sd running20:45
nessitaralsina: not sure about the activation thingy20:45
nessitaralsina: ok, let me branch those20:45
ralsinanessita: ok20:45
alecuok, I need to be afk for 40 minutes or so.20:46
alecuwill be back laters20:46
alecucheers!20:46
ralsinabye alecu!20:46
nessitaralsina: did you pushed to that branch?20:48
nessitaI'm getting20:48
nessita ** Merging the branch20:48
nessitaNothing to do.20:48
ralsinahmmm20:48
nessitaah wait20:48
nessitaI have a typo20:48
nessitaralsina: false alarm20:48
ralsinanessita: just in case, I did forget to push20:49
nessitalol20:49
ralsinapushed now20:49
nessitaralsina: merging that branch in installer trunk generates 3 conflicts20:50
nessitaText conflict in ubuntuone_installer/gui/qt/gui.py20:50
nessitaText conflict in ubuntuone_installer/gui/qt/local_folders.py20:50
nessitaText conflict in ubuntuone_installer/gui/qt/main/windows.py20:50
ralsinaargh20:50
ralsinathen just branch the branch20:50
nessitaralsina: can you fix the conflicts? I think is better if I debug "the latest" code. If it's too much trouble, I ll branch the branch20:51
ralsinanessita: it's ok, I'll fix them20:51
nessitaralsina: new review comments and questions added to show_spinner20:57
ralsinanessita: ack20:57
=== m_conley is now known as m_conley_away
ralsinanessita: pushed fix_800376_2 with the conflicts solved21:04
nessitaack, branching21:05
dobeyalright all, i'm out. have a good evening :)21:06
nessitaralsina: ok, wanna point me to some piece of code?21:07
ralsinanessita: to make it as easy as possible, comment out the call to _load_folders in line 9321:08
ralsinaThen try it, and when you get to the local folders page, click on "add a folder". That will cause the crash21:08
nessitaralsina: parethesis: why you overwrote my changes to def default_folders(self)? :-)21:08
nessitaralsina: that was needed to be able to run the tests in linux21:08
ralsinanessita: oops, sorry, I will revert that21:08
nessitasince this ctypes.windll.shell32 is too window oriented :-)21:09
nessitaralsina: ok, I'll branch this in windows, I though no IRL was needed21:09
ralsinanessita: well, unless you can figure out why it crashes by looking at it :-)21:09
nessitaralsina: well, the first thing I see is that you're not yielding on _load_folders21:10
ralsinathat's why I said, ignore it21:10
ralsinaI mean, comment it21:10
nessitaralsina: but if I comment that out, what crash will we have? commenting out that line is commenting out the crash, no?21:11
nessitaralsina: or I'm misunderstanding?21:11
ralsinajust using the button I take from controlpanel crashes it21:11
nessitaah, let's see21:11
nessitaralsina: I'm haivng delays since sso is now crashing21:14
ralsinaok, if I let it crash there, I do get a traceback about not connecting to syncdaemon :-/21:14
ralsinaso it seems the problem is activation is not working (http://pastebin.ubuntu.com/647641/)21:16
ralsinanaty, diego's branch has conflicts he was fixing them later at home21:19
ralsinanessita: ^21:19
nessitaralsina: ah, oh21:19
nessitaralsina: I saw 2 approves and I approved :-/21:19
ralsinayeah, I had tried that earlier :-)21:19
nessitaralsina: you marked as neesd fixing again?21:19
nessitathere. I marked it21:20
nessitaralsina: this is almost impossible to test: I need to have credentials in order to have syncdaemon running, but I can't have credentials in order to the installer to show up :-/21:21
ralsinanessita: well, you should be able to start syncdaemon on the "successful login" page21:21
nessitaralsina: I think is time we fix this nightmare, and I think I have a quick-to-implement idea21:21
nessitaralsina: ok, idea -> later, I'll do that21:22
ralsinanessita: that is, of course, even better ;-)21:22
ralsinanessita: I am cnvinced with my latest trace that it's just not connecting to syncdaemon so I'd say it's not worth checking this21:24
nessitaok21:24
nessitais crashing for me too, with no trace at all21:24
ralsinaas long as it's not failing because of something I do wrong. Should I start syncdaemon manually before showing that page?21:25
nessitaralsina: not sure what you mean21:25
ralsinanessita: u1cp manages to connect to sd. Obviously it's doing something installer is not doing21:25
nessitaralsina: not really, is just using SyncDaemonTool which, works...21:27
nessitaralsina: I'm not sure that the control panel activates SD though, I personally never tested it21:27
ralsinanessita: ok21:27
ralsinaI know it does, because I can start control panel without anything else running, and it works21:31
ralsinaand syncdaemon starts running21:31
ralsinabut that's because I have .exes and the right keys in the registry21:31
ralsinaok, I'll write the report and call it a day21:32
ralsinaThere, reported, and EODing. I may put a couple hours late, depending on how sleepy I am (I slept like 4 hours last night)21:36
ralsinaHave a good evening and see you all tomorrow!21:37
nessitaralsina: you too21:38
nessitaok, I'm off crowd22:01
nessitasee ya tomorrow!22:01
=== zyga is now known as zyga-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!