[08:49] morning all! [09:09] Morning sorry about being a bit late had to make like 8 phone calls to locate my package [09:09] but found it [09:09] \o/ [09:10] The post system in ireland is so weird they didnt recognise my address even though they delivered to the same place the week before so they sent it to my mother's house [09:10] so weird [09:18] fagan: don't worry I think I'm the only one who notices at this time :P [09:19] fagan: fancy to see a good code review? [09:25] mandel: sure [09:25] * fagan was grabbing tea [09:25] fagan: https://code.launchpad.net/~mandel/ubuntuone-client/fix-os-helper/+merge/68530 nessita does really good ones :) [09:26] mandel: well I dont think I was asked to do anything more than ./run_tests and IRL tests too so never needed to go into that much detail [09:26] holy shit though she doesnt like your code :D [09:26] fagan: nah, dont worry, this is just for you to learn, part of the internship ;) [09:26] fagan: is more the dialog, since I do have my comments as well hehehe [09:27] mandel: haha well being nessita would be pretty hard to be in 6 months [09:28] fagan: will certainly be impossible [09:28] mandel: im sure there would be some mind altering drugs or something that would help [09:30] nah, to dangerous [09:54] fagan: will be out some mins, I need to go to the internet cafe to be able to do some updates, should be back online in 15/20 min [09:54] mandel: cool [09:54] Ill hold the fort [09:56] * fagan takes 10 minutes to write up some notes to talk about with matthew later === teknico is now known as teknico_away [11:25] * fagan takes a break [11:26] hello everyone! [11:27] nessita: hey, if you are looking for mandel he is at a cyber cafe doing updates and cant get onto freenode [11:27] fagan: ack, thanks for the info [11:27] nessita: he had to reboot but should be back soon on the private irc [11:55] good morning! [11:55] morning ralsina [11:56] ralsina: im looking down the bug list to have a look at the triage policies if thats cool [11:57] wanted to see how the big bugs get attention [11:59] policy is a bad word I mean more what logs are needed for specific things and all that [11:59] procedure is a better one [12:00] fagan: good idea [12:00] hi ralsina! you feeling better? [12:00] nessita: MUCH! [12:00] nessita: even slept 8 hours and everything [12:12] welcome back mandel [12:12] :) [12:12] fagan: yes :) [12:13] there was something failing in the handsake.. I hate the internet :P [12:13] mandel: lets make a replacement :D [12:14] fagan: I do have a theory that proves that spaniards had wireless 1000 years ago :) [12:14] mandel: smoke signals? [12:15] fagan: yelling! [12:15] im good at that :D === teknico_away is now known as teknico [12:17] hi, I've just set up a new oneiric machine, but don't have an ~/Ubuntu One folder on it [12:18] other folders are synced fine, and the control panel says that it is synced [12:18] I've even seen notifications of files being downloaded [12:18] james_w: thats really weird [12:18] double clicking the folder in the control panel does nothing, but works for other folders [12:18] any clues? [12:19] nessita: ^ [12:19] I dont have a clue I didnt even thing the verson in oneiric was actually working properly yet [12:21] james_w: on the website is the folder there? [12:22] hmm, seems not [12:22] james_w: thats even more weird [12:22] check your bin [12:23] but it's on my natty machine [12:23] james_w: hmmm and there is stuff in it? [12:23] * fagan realised that doesnt really matter [12:23] there are two files in the trash on the oneiric machine, both of which would be somewhere under my ~/Ubuntu One [12:24] james_w: aha [12:25] it's still on my natty machine, but some files may be missing, and there's a u1conflict dir [12:25] which would be the dir containing the files in the trash on the oneiric machine [12:26] and there's a whole bunch of the files in the trash on the natty machine [12:26] james_w: well it sounds like some sort of sync issue but id need rye or someone to help debug it [12:26] it seems like a rather unfortunate failure mode [12:26] yeah its definitely something strange [12:27] fagan, reading [12:29] james_w, no Ubuntu One folder in ~home ??? [12:29] correct [12:31] nessita: morning, answering on the MP the questions and commenting on the tests [12:36] mandel: I answered, did you see that? [12:40] nessita: yes, ill get an answer for that in some min :) [12:40] mandel: could we mumble in 5'? Short! [12:40] mandel: in the mean time, I'll make a branch for the rename of the remove_windows_illegal_chars only [12:40] mandel: so your branch gets smaller [12:41] ralsina: can't, can it way 'til after the tandup, I'm having lunch :) [12:42] mandel: sure [12:42] nessita: very well, pass me the merge proposal if you will :) [12:44] james_w, well, i am pretty sure ubuntuone cannot work w/o a root folder [12:45] james_w, ummm... could you please check whether ~/.cache/ubuntuone/log/syncdaemon-exceptions.log exists and whether there is something interesting there? [12:46] Failure: twisted.internet.error.ConnectionDone: Connection was closed cleanly. [12:47] TypeError: unsupported operand type(s) for +: 'int' and 'NoneType' [12:48] Im going to give my standup now since ill be on skype during [12:48] me [12:48] DONE [12:48] * Read the triage process for high and critical bugs [12:48] TODO [12:48] * More reading of triage stuff (unless someone has some task) [12:48] BLOCKED [12:48] * Nope [12:48] NOTE: On skype at the moment talking about bug assigning will be a few mins [12:48] next probably nessita [12:49] rye, there's lots of that second exception. I also see it creating the root dir in the start of syncdaemon.log [12:50] james_w, could you please pastebin it? [12:50] rye, syncdaemon.log? [12:51] the first one, or the current one? [12:51] (it's been rotated three times) [12:51] jamalta, syncdaemon exceptions, with int + NoneType [12:53] :q [12:56] fagan dobey alecu nessita DiegoSarmentero mandel:standup in 4' [12:56] ralsina: already did mine [12:57] and I though DiegoSarmentero's contract is up [12:57] fagan: why did you do it 12 minutes early? [12:58] ralsina: going on skype in a minute for lp usability testing [12:58] And yes, his contract is up. He's still doing some stuff though, and he's welcome to join :-) [12:58] fagan: ok [12:58] ralsina: ping, and ingnore the other channel one :) [12:58] alecu is not going to make it but I have his notes [12:58] mandel: pong [12:58] ralsina: so, we do mumble after stan up? [12:58] yes please [12:59] ralsina: or can we multitask, I don't think I can :P [12:59] me neither [12:59] ralsina: so after standup then :) [12:59] ralsina, I made it! [12:59] alecu: welcome and say me then :-) [12:59] alecu: heeeeeey! [12:59] ralsina, the connection on the ferry is better than I thought [13:00] me [13:00] me [13:00] me [13:00] me [13:00] mandel: https://code.launchpad.net/~nataliabidart/ubuntuone-client/rename-method/+merge/68676 (trivial) [13:00] dobey: ? [13:00] DONE: bug #813099, bug #813157, reviews, meetings, QT learning [13:00] TODO: ultimate details for bug #813099, make syncdaemon branches land [13:00] BLOCKED: nopes [13:00] NEXT: mandel [13:00] Launchpad bug 813099 in ubuntuone-control-panel "QT UI: tweak account tab to match GTK's account tab (affects: 1) (heat: 47)" [High,Triaged] https://launchpad.net/bugs/813099 [13:00] Launchpad bug 813157 in ubuntuone-client "Windows: no need to customize expanduser (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/813157 [13:01] DONE: More fix-os-helper changes, saw nessitas replay, started writing a reply for questions and comments about the tests. Added an smaller branch that adds asserts for the events returned from the fs so that the do use the correct data type in paths [13:01] TODO: Probably chat a little with nessita to see where we agree :), review her branch. Reporpose fix-os-hlper and others [13:01] BLOCKED: no [13:01] alecu, go go [13:01] DONE: almost ready branches for bug #803669, using the windows user id [13:01] TODO: finish branches for bug #803672 [13:01] BLOCKED: need one more review for the unjelly branch: [13:01] https://code.launchpad.net/~alecu/ubuntuone-client/unbreak-connect/+merge/68309 [13:01] NEXT: ralsina [13:01] Launchpad bug 803669 in ubuntuone-client (and 1 other project) "Get the port numbers from the users' registry (affects: 1) (heat: 6)" [Low,Triaged] https://launchpad.net/bugs/803669 [13:01] Launchpad bug 803672 in ubuntuone-client (Ubuntu) (and 2 other projects) "Do not start two instances of this process (affects: 1) (heat: 6)" [Undecided,Invalid] https://launchpad.net/bugs/803672 [13:01] me [13:01] DONE: calls. I was not feeling/coding well, went to the doctor, took the evening off because of that. TODO: reviews, installer fixes. BLOCKED: no [13:01] dobey, please [13:02] λ DONE: Registered ubuntuone-credentials and ubuntuone-client-gnome projects, started reorg splitting work [13:02] λ TODO: reorg work, shim code, applly for motu, apply for ~ubuntu-desktop [13:02] λ BLCK: None. [13:02] ok, comments? [13:02] ralsina: feeleing ok today? [13:02] uhhh [13:02] lots of lag [13:02] mandel: feeling perfect [13:03] that is what she said [13:03] * mandel is getting very good at this :) [13:03] they *always* say that to me :-) [13:03] mandel: not really [13:03] ralsina, stop eating crap! [13:03] mandel, ^ [13:03] alecu: definition of crap varies. [13:03] hahaha [13:03] alecu: tha tis all yours :) [13:04] ralsina: launching mumble right now [13:04] ok, so I assume there are no comments relative to the standup, thus EOM [13:06] eom! [13:08] nessita, ralsina: we're arriving at the port soon; I'll find a bar with wifi and I'll try to get to the meeting. But it's very crowded today because of the winter holidays, so please start if I don't show up. [13:09] alecu: ack [13:09] ralsina: felt from mumble :( [13:09] ralsina: but ok, I'll got to the admin page and will add it [13:13] mandel: cool [13:16] nessita: can you please take a llok at my comment in the MP and let me know what you think [13:20] mandel: sure [13:21] alecu, ralsina: one more: https://code.launchpad.net/~nataliabidart/ubuntuone-client/rename-method/+merge/68676 [13:21] mandel: on it! [13:28] mandel: I read your comment, and my proposal would be to have the 2 tests I outlined there, plus 2 more with only the assertFalse(any()) [13:29] mandel: since in a test, it doesn't make much sense to have an assertFalse and before exiting a builtin assert [13:29] nessita: why is thaT? [13:29] mandel: yes? [13:29] nessita: we can swap the around, right? [13:30] mandel: not really.... as far as I can see [13:30] mandel: wanna show me a code snnipet? [13:30] nessita: sure, give me a sec [13:30] of what are you thinking on, I may be missing something [13:30] IMVHO: if the function replaces, then you should test replacement, not removal [13:31] ralsina: very good point [13:31] mandel: also the rename of the method should be to replace_foo [13:31] nessita: ok [13:31] ralsina: ^ so I guess I can change that in my branch about renames [13:33] nessita: yeah, we should.. I wonder if it is better to merge both methods in a single one, that way the logic of swtiching from one to other is encapsulated and we call it replace_illegal_chars(path, platform='windows') [13:33] for example [13:33] mandel: no, 2 methods is always preferred and more pythonic [13:34] nessita: but then you have issues if one method changes and the other does not... [13:34] yeah, replace_foo and 2 methods makes sense [13:34] mandel: what do you mean? [13:34] mandel: with proper tests, that should not happen [13:34] really? I guess my brain is wired in a diff way [13:35] mandel: they are instrinsically different, let me explain: [13:35] * when you have a valid path in linux and you need to mangle it to be valid in windows, you need to: [13:35] - grab the linux path, which is bytes, and create a unicode string with it [13:36] - do the replace in the unicode string [13:36] - return that [13:36] * when you have a valid path in windows and you need to mangle it to be valid in linux, you need to: [13:36] - grab the windows path, which is unicode, and create a bytes sequence with it [13:36] * fagan back [13:36] sorry, that last is not correct [13:37] - grab the windows path, which is unicode, do the inverse replace and *then* create a bytes sequence with it [13:37] - return that [13:37] mandel: yes? [13:38] nessita: yes, that is correct [13:38] so they return different types. That's enough to have two methods [13:39] nessita: I was thinking of this order for the tests: http://paste.ubuntu.com/649110/ [13:39] ralsina: so.. are we using python as if it was typed? [13:39] mandel: not at all [13:40] mandel: but you need to have a clear API [13:40] mandel: taking different types is good. Returning different types depending on unclear assumptions is not. Remember listdir :-) [13:40] nessita: honestly, I dont care that much, lets leave it in two [13:41] ralsina: so listdir is not pythonic? [13:41] mandel: is sad that you don't care :-( [13:41] mandel: it's confusing, is what it is :-) [13:41] ralsina, mandel: new rename was pushed: restore_illegal_chars is now replace_unicode_with_illegal_chars, and remove_illegal_chars is now replace_illegal_chars_with_unicode [13:42] nessita: sounds good [13:42] ralsina: and now that I see those names, I wonder if path_name_from_linux path_name_to_linux isn't a better choice :-P [13:43] hehe [13:43] I guess no, I don't like the name 'linux' in the method names [13:43] nessita: aint sad, I'm being pragmatic, you have your point of view, I have mine. It is already implemented by me in two methods, so why discussing? I did consider the two methods already, ergo I know its good and bad points. I'm challenging that implementation because we are writing very similar tests, which smells... [13:43] is too restrictive [13:43] the long ones are mre explicit, and "linux" reeks of "you know what I mean" [13:43] nessita: don't use linus, in mac os x is the same, as with bsd etc... [13:43] use unix if you like [13:44] mandel: let's stick with the one I pushed already [13:44] nessita: ok, specially because we removed windows from the name for a reason, right? [13:44] mandel: yes [13:45] mandel: in the last rename, some lines go over 80 columns. I did not fixed that to avoid creating more conflicts with your branch, ok? [13:45] mandel: so, when you merge, you will need to fix some conflicts... [13:45] nessita: so, do you understand why I say I don't care? is more of a 'I consider both to have ts good and bad points' [13:46] mandel: I understand what you said, but worries me that you consider having a single method is a good option === m_conley` is now known as m_conley [13:46] nessita: yes, 'cause in ensures the encapsulation of the logic in a single location, rather than in several places, even if internally in that method is implemented in 2 diff one [13:47] to make it even cleaner you could hide the maps in the implementation so that people are not tempted to use it [13:47] mandel: bsd sucks man :D [13:47] mandel: if you have 2 internal, different, implementations then you're not encapsulating any logic! :-) [13:47] mandel: of course, +100 to hide the char map [13:48] nessita: yes, since both operations are within the same method, let me show you (although this is just for the mental exercise, we wont be changing a thing :) ) [13:50] mandel: regarding the code snippet, I still see it and think the goal of the test is not the last assert. But I guess that got cleared up after ralsina pointed out that we're not removing but replacing [13:50] mandel: so I would advice using the 2 code snippets I added in the MP for the 2 tests [13:53] mandel: the concern about the methods getting out of sync is fixed by roundtrip tests and maybe a comment on each method mentioning that the roundtrip should be invariant. [13:53] ralsina, are we mumbling soon? [13:54] alecu: good question. Oh, the time! [13:54] ralsina: I'm there [13:54] alecu, nessita, mandel, Chipaca: quick windows status mumble? [13:54] nessita, It’s Time to Activate! [13:55] nessita, got that mail? [13:55] Activia? [13:55] alecu: yes.... [13:55] IT ENDS... TONIGHT [13:55] hahaha [13:56] I love this line: "Best wishes for your software development projects." [13:56] alecu, mandel: mumble? [13:56] yeah, right. [13:56] ralsina: going sorry [13:56] mandel: I forgot too :-) [13:56] * ralsina feels left out and did not get that email [13:57] ralsina, nessita: this is waht I mean: http://paste.ubuntu.com/649128/ [13:58] ralsina: main idea, ensure that the function has the commutative property [13:58] ralsina: OTP [13:58] nessita: look at my comment ^ [14:14] nessita: I cannot hear you… :( [14:14] nessita: but I think its my network the problem [14:15] mandel: can you hear ralsina? [14:15] nessita: mumble is done, I'll be back asap [14:15] ralsina, can hear! what do I need to know? [14:26] nessita: so what is the summary of the changes to be made in fix-os-helper, add the tests as you mentioned + a test that simply tests self.assertFalse(any for each of them, is that right? [14:26] nessita: did the decorator explanation help you? [14:28] mandel: yes to the decorator explanation [14:29] mandel: pending stuff: fix the tests as per my code snippets, no need to add an extra test for assertFalse(any(...)) since we agreed that is not needed because of the nature of the function (it does not perform removes but replacements) [14:30] nessita: ok, and merge with trunk and resolve merge issues, ok? [14:34] yes [14:34] DiegoSarmentero: welcome to Canonical! (just got the official "new starter" email :-) [14:34] ralsina, THANKS!! :D [14:35] DiegoSarmentero: heeeeeeeey! welcome! [14:35] welcome DiegoSarmentero [14:35] nessita, thanks everyone! :D I'm very happy! [14:35] DiegoSarmentero: I have send an email confirming your flight to the agency, we'll have the electronic ticket tomorrow [14:35] nessita, awesome [14:35] DiegoSarmentero: traé alfajores al sprint [14:35] DiegoSarmentero: bienvenido!!! [14:36] ralsina, will do! [14:36] mandel, gracias! [14:36] DiegoSarmentero, bienvenido! [14:36] alecu, gracias!! [14:36] mandel, ralsina, DiegoSarmentero: please, I need one more review on this branch: https://code.launchpad.net/~alecu/ubuntuone-client/unbreak-connect/+merge/68309 [14:36] And today, canonicaladmin magically looks ok on chromium. yay! [14:37] alecu: on it! [14:37] nessita, alecu, ralsina: did you get an email from msdn? [14:37] alecu: I tested it yesterday and forgot to approve it, sorry! [14:37] mandel: yeap [14:37] I did not, but I have windows licenses already [14:37] mandel, yes! [14:38] ralsina, ok... please, approve it!!!!!! [14:38] superb! [14:38] alecu: done! [14:51] man, ppa builds are slow today [14:53] ralsina: I'm leaving to sign that thingy at the university [14:53] I'll be back ASAP [14:53] nessita: ok [14:53] nessita: have lunch too [14:53] (but it will take one hour approx) [14:53] just coordinate mandel's handoff... [14:54] mandel: how long are you staying? [14:54] nessita: more or less when will you be back, we can coordinate it so I have a small break and I'm back to talk with you guys [14:55] mandel: I can be here in approx one hour, depending on the traffic [14:55] nessita: I can take a break and connect back at my 8 for example [14:55] mandel: or I can do this tomorrow... [14:55] let me do some phone calls [14:56] nessita: look dont worry, do your stuff at uni, worst worst case scenario, tom I start at you 9 and we do then the hand off [14:57] nessita: If not, we can do it later 2night, I have no problem what so ever [14:57] mandel: I'm making some phone calls [14:59] nessita: ok, but you seriously don't have to [15:01] mandel: ok, I moved my thing for tomorrow [15:01] nessita: ok [15:02] mandel: let me know as soon as you can make the hand off to me [15:02] mandel: I'm not in a hurry, but maybe is late for ytou [15:02] nessita: sure [15:03] nessita: is not, I started one hour later today, so we are fine :) [15:03] mandel: I imagine, I read you were drinking with 18-years old last night until 4am your time! [15:03] nessita: I'm pushing the changes to fix-os-helper, will run tests on linux and will let you know [15:03] ;-) [15:03] mandel: ack [15:04] nessita: yes, but I sleep an average of 4 hours… and with their conversation, I felt sleep earlier than usual :) [15:05] lol [15:12] so… while I wait for the branch to be done over 3g… ralsina, nessita, alecu, DiegoSarmentero want anything from Spain that I can legally travel with from Spain, *?/: are illegal by the way :P [15:12] mandel: so are cured meats, sadly [15:13] BTW: expect marianna's mail soonish, but the hotel will be http://www.hoteljacaranda.com.ar [15:13] mandel, a knife from toledo? [15:13] ralsina: really? that is lame... [15:13] mandel: corn noddles, they are sold in "Al campo", and they are very tasty and gluten free! [15:13] ralsina, it seems nice! :P [15:13] alecu: hahaha I'll be in madrid so no idea i I could :) [15:13] nessita: I can get you those for sure! [15:14] mandel, oh, then perhaps I can ask you for some board game. [15:14] mandel: you sure? only if it's not that much trouble [15:14] alecu: shoot, but dont make it too complicated [15:14] mandel: of course I will pay for them, they cost something like 1.5 euros the 500g the package [15:14] nessita: no trouble at all, and you have to get something out from the reviews, right? [15:15] nessita: but do send me an email with the details, I don't want to bring the wrong stuff [15:15] ralsina: oh nice [15:15] nessita: too bad you are not here on saturday. 2 minutes from the hotel a friend of mine has a organic producers market, I am sure they have any kind of noodles made of weird grains :-) [15:15] mandel, try to see if you can get the main "battlestar galactica" board game in spanish. The base one, make sure it's not one of the expansions :-) [15:15] nessita: I may go there this saturday and get you amaranth noodles. I always wanted to ask somene to try those ;-) [15:15] mandel, I can trade that for asado [15:16] ralsina: bring them on! [15:16] mandel, I mean, using you as a mule: I'll pay for the game :-) [15:16] alecu: sure, I think I know where to get that... [15:16] alecu, noooo, battlestar galactica is awesome!!!! [15:16] jejje [15:16] cool [15:17] DiegoSarmentero, where did you play it? at toote's? [15:17] nessita: we went there with rayis last saturday. I'll try to convince the wife to go again :-) [15:17] i am sad i won't be there [15:17] nono...... i didn't play the board game, i mean the tv show........ and........... everything related :P [15:18] dobey: next time! [15:18] * alecu had to look up "Amaranth", because he pictured "Amanith", and it did not made sense for a noodle. [15:18] alecu, i answer above... :P [15:18] DiegoSarmentero, hahaha [15:18] alecu: amanith noodles would be so much fun! :-) [15:18] answered* [15:20] mandel, so, remember "battlestar galactica". That or a leg of "pata negra" [15:21] alecu: 5 J I suppose... [15:25] mandel, right! jajaja [15:28] alecu, nessita, ralsina: please: https://code.launchpad.net/~mandel/ubuntuone-client/fix-os-helper/+merge/68530 [15:28] DiegoSarmentero, nessita: which airport are you arriving to and when? we might be able to share a taxi... [15:29] nessita, ? [15:29] mandel, i don't know yet [15:29] mandel: they arrive at the local one, you at the internationa [15:29] mandel: we arrive to Aeroparque, at almost 11pm [15:29] mandel: and you arrive to Ezeiza, at 20pm, right? [15:29] mandel: looking [15:29] nessita: indeed, so no point to share [15:30] mandel: right [15:34] * DiegoSarmentero is away: Not here... send me an e-mail! :P [15:35] mandel: what IRC client do you use on your mac? [15:35] * fagan was wondering what is a good one [15:35] fagan: adium [15:35] fagan: I use it for a set of diff protocols [15:35] nice [15:35] googled but I got bad ones [15:36] mandel: expect to pay $250 for the car to the hotel (about 45 euros or so) [15:36] mandel: I strongly advice to arrange the price before hiring the service, inside the same airport [15:36] right after the custom control [15:36] ralsina: joder!!! how far is it? [15:36] nessita, DiegoSarmentero: you can expect to pay about $100 from your airport depending on how much they rob you :-( [15:36] mandel: 50km [15:36] nessita: yeah, I did learn about that last time :) [15:36] ralsina: right [15:37] ralsina: I may call a remis company from here just to see how much they will charge. Do you recommend any from your area? [15:37] * mandel small brake, will be back in 10 min [15:38] nessita: you can call (011) 47435658 [15:38] nessita: that's one from near my home, so not too far from the hotel [15:38] right [15:38] nessita: I will ask them [15:41] nessita: $85 but no factura [15:41] ralsina: we need factura... is it more expensive with the receipt? [15:41] nessita: they can make you an unofficial one, but if they have to do an official one, it's 100 so... no point [15:43] ralsina: ok, is a good reference to negociate there [15:43] If you don't mind walking 6 blocks or so, you can go to the Maipú station of the "tren de la costa" and then $4 for the train, but I am not sure if they work so late [15:44] that's about half of the way [15:44] yay [15:44] sso nightlies on maverick working again [15:44] ok, time to get some lunch. bbiab [15:45]