| benji | gary_poster: Dublin expense report comin' atcha | 12:13 |
|---|---|---|
| gary_poster | cool | 12:13 |
| gary_poster | benji, could you give me a summary of how you calculated your per diem--what days got what meals? This makes it easier for me to see where the money is coming from and if it matches up with the schedule I know about. I'll paste whatever yu give me in the expense claim | 12:29 |
| gary_poster | bac benji danilos call momentarily | 12:30 |
| benji | gary_poster: sure: 1st Saturday: 1 dinner; Sunday: lunch & dinner; M T W F: dinner; last saturday: lunch and dinner | 12:31 |
| benji | please double-check me, but I think that's "right" | 12:31 |
| benji | the hotel per diem is 80 euro per night, six nights | 12:32 |
| gary_poster | benji, when was yellow team dinner? I paid for that for everybody else, and I think for you too? | 12:32 |
| benji | oh! | 12:32 |
| benji | you're right | 12:32 |
| benji | thanks for catching that | 12:32 |
| benji | if you can fix it, please do, if not reject it and I'll take care of it | 12:33 |
| gary_poster | benji, (1) that was Wed., right? (2) what was our dinner per diem again? :-P | 12:45 |
| benji | 1) IIRC, 2) 20 euro | 12:45 |
| gary_poster | thanks | 12:45 |
| benji | gary_poster: I can't find the no downtime deploy instructions, do you have a pointer | 12:56 |
| danilos | benji, it's something like ProductionChangePolicy | 12:56 |
| gary_poster | benji https://wiki.canonical.com/Launchpad/PolicyandProcess/ProductionChange | 12:56 |
| benji | thanks guys | 12:57 |
| gary_poster | np | 12:57 |
| gary_poster | benji, please no rush to answer this, but for https://bugs.launchpad.net/launchpadlib/+bug/752282, would the change in comment 7 be sufficient? | 15:02 |
| _mup_ | Bug #752282: terminates python with "cannot connect to X server" <regression> <launchpadlib :Triaged> < https://launchpad.net/bugs/752282 > | 15:02 |
| * benji looks | 15:03 | |
| gary_poster | benji, also, would that be a super easy one to fix? Would you like me to try to do it, with your guidance, so that you feel someone is helping with that stuff, or would you rather just fix it yourself for speed's sake? | 15:04 |
| benji | gary_poster: for the life of me, I don't see a fix suggested in comment 7 | 15:05 |
| gary_poster | benji sorry :-( comment 6 from Markus Korn | 15:06 |
| gary_poster | I guess that's actually a modification of your comment 5 | 15:07 |
| gary_poster | so it would be comment 5 + 6 | 15:07 |
| benji | re. ease of fix: the "sniff the environment" fix shouldn't be too bad | 15:07 |
| gary_poster | then we have to roll it out though, right? | 15:08 |
| benji | gary_poster: re. comment 6: I don't think it'll be that easy. keyringlib is structured in a stupid way, the client has no choice over which backend will be chosen and is given no notice of which will be chosen either, so backend-specific bits like that will have to be done in the keyring library itself (i.e., not in launchpadlib) | 15:09 |
| gary_poster | benji, yeah, that's what I understood. Make small change in keyring library; publish it to Ubuntu; declare success | 15:10 |
| benji | right, once we change keyringlib we'll have to get that revision into Ubuntu; I don't think that'll be hard, just prolonged | 15:10 |
| benji | right | 15:10 |
| * gary_poster wonders when oneiric closes | 15:10 | |
| gary_poster | benji, if you'll coach me on this, I'll do it; or I can leave it for you. | 15:11 |
| benji | go get'em tiger! (that's me coaching) | 15:12 |
| gary_poster | heh | 15:12 |
| gary_poster | ok | 15:12 |
| benji | gary_poster: to check it out you do hg clone https://bitbucket.org/kang/python-keyring-lib | 15:15 |
| gary_poster | benji, wow, so this is easy but annoying, eh? Yeah, I was just working that out | 15:15 |
| gary_poster | benji, tests are very noisy with lots of tests that seem like they are spewing failures, but end with "Ran 34 tests with 0 failures and 0 errors in 0.255 seconds." That's as you expect? | 15:19 |
| benji | there will be lots of noise, and several skipped tests (unless you have the right crypto libraries installed (or KDE) for example) | 15:21 |
| gary_poster | ok benji, cool. So...can I do this with TDD? Looking at keyring/tests/test_backend.py no | 15:21 |
| gary_poster | w | 15:21 |
| benji | yep, you should be able to TDD it; I added some test infrastructure that should make that route not too painful | 15:22 |
| benji | no downtime deploy done | 15:23 |
| gary_poster | benji, great | 15:23 |
| benji | that was really easy; more people should be forced to do that, a little aversion therapy for deployments | 15:24 |
| gary_poster | benji, :-) it's nice if you go through the bugs you deployed and change their statuses | 15:24 |
| benji | ok; is that something I should add to the procedure? | 15:25 |
| gary_poster | benji, dunno. wgrant did it and I appreciated it, so I was reciprocating. uh, pay it forward, uh. | 15:26 |
| benji | I'll add it then. | 15:26 |
| benji | ok, 19 bugs marked Fix Released | 15:28 |
| benji | gary_poster: I just realized that that probably wouldn't be a good policy; a single revision might not actually fix a bug, we could prematurly mark them as fix released | 15:30 |
| benji | I doubt I just marked any prematurely because they were all "Fix Comitted" before I marked them, but I don't think this is actually something we should do | 15:31 |
| gary_poster | benji, we have different statuses for this | 15:31 |
| * gary_poster doesn't recall off-hand | 15:32 | |
| gary_poster | but in theory it should be something we can do deterministically and correctly, if the people working on the branch have done the right thing. | 15:32 |
| benji | so the rule should be: mark all fix-committed bugs as fix-released and leave the rest alone? | 15:32 |
| benji | it'd really be nice if the qa bot (or similar) did this | 15:32 |
| gary_poster | benji, I think so. I'm not sure if qa bot moves bugs to fix-committed if the commit is regarded as partial, but I don't think so... So, "yes" :-) people can correct it later if needed | 15:33 |
| benji | k, I'll add that rule | 15:34 |
| benji | I'm hungry. | 15:38 |
| gary_poster | benji, kwalitee: | 15:49 |
| gary_poster | def test_supported(self): | 15:49 |
| gary_poster | """Test the keyring's supported value. | 15:49 |
| gary_poster | """ | 15:49 |
| gary_poster | self.assertEqual(self.keyring.supported(), self.supported()) | 15:49 |
| gary_poster | return self.keyring.supported() | 15:49 |
| gary_poster | sorry that last line was supposed to be two | 15:50 |
| gary_poster | def supported(self): | 15:50 |
| gary_poster | return self.keyring.supported() | 15:50 |
| gary_poster | so IOW for gnome keyring, we are asserting that self.keyring.supported() == self.keyring.supported() . Mm, yeah, I'm keen to use this. :-P | 15:51 |
| benji | heh, I hadn't noticed that one; unfortunately I'm not surprised | 16:36 |
| gary_poster | lunch | 17:34 |
| gary_poster | benji, I'm confused about bitbucket. I have a mercurial branch with changes I want. I now have an account at bitbucket. What now? I've tried various incantations, most recently "hg push ssh://garyposter@bitbucket.org/garyposter/python-keyring-lib" | 18:47 |
| gary_poster | Also tried "hg push ssh://hg@bitbucket.org/garyposter/python-keyring-lib" | 18:48 |
| benji | two things: first, this is the command you want: hg push ssh://hg@bitbucket.org/kang/python-keyring-lib (it took me *forever* to figure that out) | 18:48 |
| gary_poster | benji, even though I don't want to mutate his branch yet? | 18:49 |
| benji | second, unless you've been given committer access that won't work | 18:49 |
| gary_poster | benji I just wanted to put the branch up somewhere for review | 18:49 |
| gary_poster | and then make a pull request and all that | 18:49 |
| benji | I've never done that. I just got committer privaleges. ;) | 18:49 |
| benji | If you can figure it out, I can act on your pull request. | 18:50 |
| gary_poster | ok cool benji thx | 18:51 |
| gary_poster | benji https://bitbucket.org/kang/python-keyring-lib/pull-request/3/do-not-try-to-connect-to-the-gnome-keyring | 19:02 |
| benji | gary_poster: did you note what Markus Korn said about DBUS_SESSION_BUS_ADDRESS and DISPLAY? Some values of DBUS_SESSION_BUS_ADDRESS are valid even if there is no DISPLAY. | 19:05 |
| benji | so... hmm; we might just leave out the DISPLAY check and be good | 19:06 |
| gary_poster | benji, I must have misread. I thought he was saying that DBUS... will only be true of DISPLAY is true, so this was overkill | 19:06 |
| * gary_poster goes to reread | 19:06 | |
| gary_poster | benji, "some value in DBUS_SESSION_BUS_ADDRESS implies a non empty DISPLAY." | 19:07 |
| gary_poster | benji, so my inclusion of DISPLAY is paranoia from his perspective | 19:07 |
| gary_poster | which was my intent :-) | 19:07 |
| benji | right, and it's not logically required, but implies to me that some other values of DBUS_SESSION_BUS_ADDRESS are still fine even though DISPLAY is empty | 19:08 |
| benji | in other words a non-empty DBUS_SESSION_BUS_ADDRESS is all we need to check for (and can ignore DISPLAY alltogether) | 19:08 |
| gary_poster | benji, what implies to you? his message, or my code? | 19:08 |
| benji | his message | 19:08 |
| gary_poster | benji, I agree, but my intent was to be paranoid. | 19:09 |
| gary_poster | benji, I have no personal knowledge that what he said is correct | 19:09 |
| benji | we can relax the requirement for DISPLAY later if need be I guess | 19:09 |
| gary_poster | benji, I am pretty comfortable saying, on a personal knowledge basis, that DISPLAY is necessary | 19:09 |
| gary_poster | benji, I don't feel strongly about it actually, but I am clarifying that this was my intent | 19:10 |
| gary_poster | if you feel strongly the other way, eh, I can remove it | 19:10 |
| gary_poster | obviously I prefer it the way it is | 19:10 |
| gary_poster | but...eh. :-) | 19:10 |
| benji | gary_poster: here's an experiment that shows that what I read through the lines seems to be true: http://pastebin.ubuntu.com/657425/ | 19:13 |
| benji | since we are talking about server systems, I can't decide if it is more or less important to allow the gnome keyring stuff to work without a DISPLAY | 19:14 |
| gary_poster | benji...that implies to me that what I've done is what we want, yeah? We don't want the gnome keyring to pop up in that case, right? | 19:14 |
| benji | see above, I can't decide :) | 19:14 |
| gary_poster | benji, does the gnome keyring work on server systems? | 19:14 |
| benji | that's a good question | 19:15 |
| gary_poster | I would think not | 19:15 |
| gary_poster | what with the GUI and all | 19:15 |
| benji | I'm persuaded that the code as you have it is the way to go. | 19:15 |
| gary_poster | cool | 19:15 |
| benji | heh, Tarek beat me to accepting your pull request | 19:46 |
| gary_poster | benji, they call me Firstname Lastname around these parts | 19:50 |
| benji | gary_poster: what? | 19:51 |
| gary_poster | benji, see https://bitbucket.org/kang/python-keyring-lib/overview | 19:51 |
| benji | LOL! | 19:51 |
| gary_poster | pretty clearly I didn't set up hg properly somehow | 19:51 |
| benji | that is hilarious | 19:51 |
| gary_poster | benji, yeah I think I was glazing over some of the set up instructions--this is my .hgrc: | 19:52 |
| gary_poster | [ui] | 19:52 |
| gary_poster | username = Firstname Lastname <firstname.lastname@example.net> | 19:52 |
| gary_poster | verbose = True | 19:52 |
| gary_poster | oops | 19:52 |
| benji | I figured it was something like that. I bet that happens a lot. They should have code to reject that user name. | 19:53 |
| benji | I'm still laughing about that. | 19:53 |
| gary_poster | yeah | 19:53 |
| gary_poster | :-) | 19:53 |
| gary_poster | benji, what do I do to get that python-keyring change in oneiric? | 20:08 |
| benji | hmm, let me check my notes | 20:08 |
| benji | gary_poster: The Debian maintainer/packager of python-keyring is Carl Chenet <chaica@ohmytux.com> | 20:08 |
| benji | also, Barry maintains the launchpadlib packages in Debian, so he might be useful at some point | 20:09 |
| benji | Carl was very helpful last time I communicated with him (although Debian was frozen at the time so there wasn't much he could do for me). | 20:10 |
| benji | also, I can do a keyring release, which I think Carl will want to feed into the packaging machinery | 20:11 |
| gary_poster | benji, so I just write him a nice email saying, hey, could you please get this in Debian? And then hope that...oh ok | 20:11 |
| gary_poster | benji, if it is not in Debian then Ubuntu can't get it, or at least it is a much bigger pain? | 20:11 |
| bac | gary_poster: i'm trying to find where an event gets handled but can't find the registration. | 20:12 |
| bac | notify(BugBecameQuestionEvent(self, question, person)) | 20:12 |
| benji | that's my understanding; last time Leonard suggested/encouraged/something the Debian to Ubuntu route | 20:12 |
| gary_poster | ack benji | 20:12 |
| gary_poster | bac, ok lemme look | 20:13 |
| bac | gary_poster: i expected to find a <subscriber> in the zcml for IBugBecameQuestionEvent but don't see one | 20:13 |
| benji | bac: notifications to subscribers are handled synchronously, so you can pdb into the notify call and the looping over and calling the actual subscribers isn't too far down that rabbit hole | 20:13 |
| bac | benji: i've done that in the past...but figured this should be discoverable by looking in the zcml | 20:14 |
| gary_poster | bac, this doesn't look there is a listener, I agree | 20:15 |
| benji | some times inheritance stymies the grep-the-zcml approach | 20:15 |
| bac | urgh. i guess rabbit hole diving it is | 20:15 |
| gary_poster | bac, I would be paranoid enough to do what benji describes, I must admit | 20:15 |
| gary_poster | but my guess is that it is a no-op | 20:16 |
| bac | gary_poster: really? that's hard to believe | 20:16 |
| bac | b/c i don't see the actions wired elsewhere | 20:16 |
| benji | and very few admit to being as paranoid as I | 20:16 |
| gary_poster | :-) | 20:16 |
| bac | but let me go pdb-ing | 20:16 |
| bac | gary_poster: i told you benji would say that! | 20:16 |
| benji | heh | 20:17 |
| gary_poster | :-) | 20:19 |
| bac | gary_poster: looks like it is a noop | 20:23 |
| gary_poster | cool | 20:24 |
| bac | we've got considerable code supporting that no-op | 20:24 |
| gary_poster | heh | 20:34 |
| gary_poster | rip it out! | 20:35 |
| benji | I really want to get ec2 land chugging on this branch, anyone want a small (and possibly even slightly fun) JS review? https://code.launchpad.net/~benji/launchpad/bug-809511/+merge/70219 | 20:36 |
| gary_poster | I'll do it benji | 20:52 |
| benji | gary_poster: great, thanks | 20:53 |
| gary_poster | :-) | 20:53 |
| gary_poster | benji, feel free to ignore this bikeshed color, but I suggest that you make the digit limit for a bug number 5, not 6. We do have branches to fix older bugs. Launchpad has three five digit bugs that are still open (https://bugs.launchpad.net/launchpad/+bugs). | 20:57 |
| gary_poster | https://bugs.launchpad.net/ubuntu/+bugs has 1 (not counting bug 1). | 20:57 |
| gary_poster | It's not a big deal, but my suggestion. | 20:57 |
| _mup_ | Bug #1: Microsoft has a majority market share <iso-testing> <ubuntu> <Clubdistro:Confirmed> <Computer Science Ubuntu:Confirmed for compscibuntu-bugs> <dylan.NET.Reflection:Invalid> <dylan.NET:Invalid> <EasyPeasy Overview:Invalid by ramvi> <GenOS:In Progress by gen-os> <GNOME Screensaver:Won't Fix> <Ichthux:Invalid by raphink> <JAK LINUX:Invalid> <LibreOffice:In Progress by bjoern-michaelsen> <The Linux OS Project:In Progress> <metacity:In P | 20:57 |
| gary_poster | mm, I got the branch to try and look at it locally, but I'd have to hack the code to make that two | 20:58 |
| gary_poster | benji, is there a way to check it out locally, or should I just stare at code? :-) | 20:58 |
| gary_poster | by "check it out" in this case I mean "look at it" | 20:59 |
| gary_poster | ...in action... | 20:59 |
| benji | gary_poster: unfortunately the test data isn't condusive to actually trying it | 20:59 |
| gary_poster | yeah | 20:59 |
| gary_poster | ok | 20:59 |
| benji | you could hack it just a little and see it work | 20:59 |
| gary_poster | eh, it's about EoD and I'm tired. I'll see it on qastaging :-) | 21:00 |
| benji | :) | 21:00 |
| gary_poster | benji, did you consider updating "Y.DOM.byId('field.bug')" to "Y.one('#field.bug")"? | 21:02 |
| gary_poster | benji, approved, with the two questions I asked. Answer them as you see fit. :-) | 21:06 |
| * gary_poster runs away now. Bye! | 21:06 | |
| benji | gary_poster: I did, but it didn't work; I was too lazy to figure out why | 21:06 |
| benji | thanks! | 21:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!