=== daker_ is now known as daker
=== daker is now known as daker_
mhall119cjohnston: daker_: nigelb: http://www.informit.com/articles/article.aspx?p=173916316:39
dakermhall119, nice17:16
nigelbmhall119: nice17:28
nigelbcjohnston: pleaes go ahead with whatever you want to fix.17:28
cjohnstonnigelb: you here?18:42
nigelbcjohnston: sort of. Just about to step out for coffee. What's up?18:42
cjohnstonneed help writing tests18:44
nigelbwhich one specifically?18:46
cjohnstonthe one your making me to18:46
cjohnstonthe edit pad link18:46
nigelbcjohnston: okay, so I wont write code for you18:52
nigelbI'll explain the basics of what the test should do18:52
nigelbthere's already an existing test.18:53
cjohnstonIt should put an output that fails and fail and an output that passes and pass18:53
nigelbCheck that out18:53
nigelbcreate a new summit, and other things you'd need to use in that function18:53
nigelbpass the parameters you generated to your function18:53
nigelbnow, you know what the output should be18:53
nigelbconstruct it maully18:54
nigelbcheck if your manually constructed output = output from function18:54
nigelbmhall119: ^ comments?18:54
mhall119without knowing the specifics, that sounds about right18:55
mhall119if this is something that's going to be on a page, use self.client.get('/url/') to make sure it's in the resulting html18:57
nigelbmhall119: this is constructing the URL.19:01
mhall119will the URL to into a page output?19:01
nigelbYes, but that's not the point of the test.19:03
mhall119as long as there is *a* test that does that19:03
mhall119cjohnston: line 17 of the pad19:10
mhall119what's that url?19:11
mhall119 /uds-test-test-meeting?19:11
cjohnstonmhall119: the way the url works is /summit-name-meeting-name, so the summit name is uds-test and the meeting name is test-mmeting19:12
mhall119hmmmm, that doesn't look right, don't we prefix it with /meeting/ or something?19:13
cjohnstonI think we should prefix it...19:14
nigelbmhall119: shouldn't we be splitting tests into logical files?19:14
mhall119that's the etherpad url19:14
* nigelb is used to seeing it done in LP.19:14
mhall119self.client.get only makes calles to the Django instance19:15
cjohnstonsee.. heres what i dont get.. why do a test when ive already done the work19:17
mhall119because when nigel breaks your work 5 revisions from now, the test will catch that19:18
cjohnstoncause i can make the test work, but my code not work, and i can make code that works and a test not work19:18
mhall119that's why you should write the test first19:18
mhall119if the test is correct, then it will only pass once the code is correct19:18
mhall119this make more sense in the case of bugs, where you write a test that reproduces the bug, then you write code to fix the bug until the test passes19:19
nigelbWriting test cases is like insurance.19:20
nigelbYour code still works, but there's not guarantee about tomorrow19:20
nigelb(that's the closest analogy I could find)19:20
cjohnstonnigelb: whats the url to edit a pad?19:25
cjohnston(slider etc)19:25
mhall119cjohnston: give me an example of a summit link where this code is used19:27
nigelbnewz2000: I see that you <3 Drupal ;)19:28
newz2000I don't know the story, but while running it locally my computer suddenly is going a lot slower19:29
mhall119nobody loves drupal19:29
dakermhall119, you are the "nobody"19:30
newz2000maybe xdebug is hindering apc19:30
mhall119cjohnston: then the url for self.client.get should be '/uds-test/metting/{{meeting.id}}/test-meeting/'19:31
mhall119except spelling correcting19:31
cjohnstonisnt it supposed to be testing the link to edit the the pad19:31
mhall119the equivilent of /uds-o/meeting/16334/foundations-o-releaseprocess/ for the test data you created19:31
mhall119you'll be testing that the link is in that page19:32
cjohnstonmhall119: https://code.launchpad.net/~chrisjohnston/summit/etherpad/+merge/6890119:45
cjohnstonmhall119: http://paste.ubuntu.com/657448/19:46
mhall119cjohnston: ah, it's your migration script blowing up19:47
mhall119it's not even getting to the testing stage19:47
cjohnstonthis is still the stupid 1.x migration issue19:48
cjohnstonso i need to do this against trunk19:48
cjohnstonmhall119: https://code.launchpad.net/~chrisjohnston/summit/pad-edit/+merge/70216 test it and get rid of it pleasE!19:55
cjohnstonmhall119: please?20:06
nigelb--> bed20:20
cjohnstonnigelb: review my mp20:24
dakerand my MPs ?20:25
dakerno one to review them :/20:25
cjohnstondaker: is there more than just one?21:09
dakerthis one https://code.launchpad.net/~daker/loco-directory/fix.818373/+merge/6989821:10
cjohnstonthe date one? im looking at that one right now21:11
cjohnstontheres no tests21:11
ubot4Factoid 'fail' not found21:11
dakerthis is a javascript21:12
cjohnstonwanna make another mp for me? ;-)21:12
dakerfor what ?21:12
cjohnstondaker: with the new date code, when I click in the End Date box, the date picker doesn't come up21:17
dakeryou are using oneric or natty, right ?21:18
dakerthe path of the jquery datepicker has changed since maverick21:21
cjohnstonthe begins date the calendar picker shows up21:23
cjohnstondaker: the begins date the calendar picker shows up, the ends date doesnt, nor do the times.21:26
dakerthat's because of the timepickr21:28
daker $("#id_date_begin_0").datepicker();21:29
daker-       $('#id_date_begin_1').timepickr({ trigger: 'focus', convention: 24 }); <----- the script blocks here21:29
daker-       $("#id_date_end_0").datepicker();21:29
daker-       $('#id_date_end_1').timepickr({ trigger: 'focus', convention: 24 });21:29
cjohnstonso your saying it can be one or the other?21:30
dakerwhat do you mean ?21:30
cjohnstonI don't understand what you mean by blocking21:31
dakerblocking the execution of the other calls21:32
daker$('#id_date_end_1').timepickr({ trigger: 'focus', convention: 24 });21:32
cjohnstoncan you fix it?21:32
dakeryou are getting this error because of the timepickr call isn't compatible with jquery (i think) present on m, n and o21:34
dakerit works only only lucid21:34
dakerare you getting the same date on the two fields ?21:35
dakerso that's good21:35
cjohnstonand no ability to pick a time21:35
cjohnstonit should default to the same date, but i shouldnt have to type to change it21:35
cjohnstonin order to change the ends date, i have to type it in21:37
dakercjohnston, they have deployed the SSO choices21:46
dakeri don't understand cjohnston if you want to change the ends date you will have to type it21:53
dakercjohnston, ^21:53

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!