[16:39] <mhall119> cjohnston: daker_: nigelb: http://www.informit.com/articles/article.aspx?p=1739163
[17:16] <daker> mhall119, nice
[17:28] <nigelb> mhall119: nice
[17:28] <nigelb> cjohnston: pleaes go ahead with whatever you want to fix.
[18:42] <cjohnston> nigelb: you here?
[18:42] <nigelb> cjohnston: sort of. Just about to step out for coffee. What's up?
[18:44] <cjohnston> need help writing tests
[18:46] <nigelb> ah
[18:46] <nigelb> which one specifically?
[18:46] <cjohnston> the one your making me to
[18:46] <cjohnston> the edit pad link
[18:52] <nigelb> cjohnston: okay, so I wont write code for you
[18:52] <nigelb> I'll explain the basics of what the test should do
[18:53] <nigelb> there's already an existing test.
[18:53] <cjohnston> It should put an output that fails and fail and an output that passes and pass
[18:53] <nigelb> Check that out
[18:53] <nigelb> create a new summit, and other things you'd need to use in that function
[18:53] <nigelb> pass the parameters you generated to your function
[18:53] <nigelb> now, you know what the output should be
[18:54] <nigelb> construct it maully
[18:54] <nigelb> *manually
[18:54] <nigelb> check if your manually constructed output = output from function
[18:54] <nigelb> mhall119: ^ comments?
[18:55] <mhall119> without knowing the specifics, that sounds about right
[18:57] <mhall119> if this is something that's going to be on a page, use self.client.get('/url/') to make sure it's in the resulting html
[19:01] <nigelb> mhall119: this is constructing the URL.
[19:01] <mhall119> will the URL to into a page output?
[19:03] <nigelb> Yes, but that's not the point of the test.
[19:03] <mhall119> as long as there is *a* test that does that
[19:04] <nigelb> ah
[19:10] <mhall119> cjohnston: line 17 of the pad
[19:11] <mhall119> what's that url?
[19:11] <mhall119>  /uds-test-test-meeting?
[19:12] <cjohnston> mhall119: the way the url works is /summit-name-meeting-name, so the summit name is uds-test and the meeting name is test-mmeting
[19:13] <mhall119> hmmmm, that doesn't look right, don't we prefix it with /meeting/ or something?
[19:14] <cjohnston> http://pad.ubuntu.com/uds-o-foundations-o-releaseprocess
[19:14] <cjohnston> I think we should prefix it...
[19:14] <nigelb> mhall119: shouldn't we be splitting tests into logical files?
[19:14] <mhall119> that's the etherpad url
[19:14]  * nigelb is used to seeing it done in LP.
[19:15] <mhall119> self.client.get only makes calles to the Django instance
[19:17] <cjohnston> see.. heres what i dont get.. why do a test when ive already done the work
[19:18] <mhall119> because when nigel breaks your work 5 revisions from now, the test will catch that
[19:18] <cjohnston> cause i can make the test work, but my code not work, and i can make code that works and a test not work
[19:18] <mhall119> that's why you should write the test first
[19:18] <mhall119> if the test is correct, then it will only pass once the code is correct
[19:19] <mhall119> this make more sense in the case of bugs, where you write a test that reproduces the bug, then you write code to fix the bug until the test passes
[19:20] <nigelb> Writing test cases is like insurance.
[19:20] <nigelb> Your code still works, but there's not guarantee about tomorrow
[19:20] <nigelb> (that's the closest analogy I could find)
[19:25] <cjohnston> nigelb: whats the url to edit a pad?
[19:25] <cjohnston> (slider etc)
[19:26] <nigelb> /ep/pad/view/PADNAMEHERE/latest
[19:27] <mhall119> cjohnston: give me an example of a summit link where this code is used
[19:28] <nigelb> newz2000: I see that you <3 Drupal ;)
[19:29] <newz2000> I don't know the story, but while running it locally my computer suddenly is going a lot slower
[19:29] <nigelb> heh
[19:29] <mhall119> nobody loves drupal
[19:30] <daker> mhall119, you are the "nobody"
[19:30] <cjohnston> http://summit.ubuntu.com/uds-o/meeting/16334/foundations-o-releaseprocess/
[19:30] <nigelb> daker++
[19:30] <nigelb> ZING
[19:30] <newz2000> maybe xdebug is hindering apc
[19:31] <mhall119> cjohnston: then the url for self.client.get should be '/uds-test/metting/{{meeting.id}}/test-meeting/'
[19:31] <mhall119> except spelling correcting
[19:31] <cjohnston> isnt it supposed to be testing the link to edit the the pad
[19:31] <mhall119> the equivilent of /uds-o/meeting/16334/foundations-o-releaseprocess/ for the test data you created
[19:32] <mhall119> you'll be testing that the link is in that page
[19:45] <cjohnston> mhall119: https://code.launchpad.net/~chrisjohnston/summit/etherpad/+merge/68901
[19:46] <cjohnston> mhall119: http://paste.ubuntu.com/657448/
[19:47] <cjohnston> uggh
[19:47] <cjohnston> conflict
[19:47] <mhall119> cjohnston: ah, it's your migration script blowing up
[19:47] <mhall119> it's not even getting to the testing stage
[19:48] <cjohnston> this is still the stupid 1.x migration issue
[19:48] <cjohnston> so i need to do this against trunk
[19:55] <cjohnston> mhall119: https://code.launchpad.net/~chrisjohnston/summit/pad-edit/+merge/70216 test it and get rid of it pleasE!
[20:06] <cjohnston> mhall119: please?
[20:20] <nigelb> --> bed
[20:24] <cjohnston> no
[20:24] <cjohnston> nigelb: review my mp
[20:24] <daker> lol
[20:25] <daker> and my MPs ?
[20:25] <daker> no one to review them :/
[21:09] <cjohnston> daker: is there more than just one?
[21:10] <daker> this one https://code.launchpad.net/~daker/loco-directory/fix.818373/+merge/69898
[21:11] <cjohnston> the date one? im looking at that one right now
[21:11] <daker> ok
[21:11] <cjohnston> theres no tests
[21:11] <cjohnston> !fail
[21:11] <ubot4> Factoid 'fail' not found
[21:12] <daker> this is a javascript
[21:12] <daker> code
[21:12] <cjohnston> :-P
[21:12] <cjohnston> wanna make another mp for me? ;-)
[21:12] <daker> for what ?
[21:17] <cjohnston> daker: with the new date code, when I click in the End Date box, the date picker doesn't come up
[21:18] <daker> you are using oneric or natty, right ?
[21:19] <cjohnston> o
[21:19] <daker> ?
[21:21] <daker> the path of the jquery datepicker has changed since maverick
[21:22] <cjohnston> oneiric
[21:23] <cjohnston> the begins date the calendar picker shows up
[21:26] <cjohnston> daker: the begins date the calendar picker shows up, the ends date doesnt, nor do the times.
[21:28] <daker> that's because of the timepickr
[21:29] <daker>  $("#id_date_begin_0").datepicker();
[21:29] <daker> -       $('#id_date_begin_1').timepickr({ trigger: 'focus', convention: 24 }); <----- the script blocks here
[21:29] <daker> -
[21:29] <daker> -       $("#id_date_end_0").datepicker();
[21:29] <daker> -       $('#id_date_end_1').timepickr({ trigger: 'focus', convention: 24 });
[21:29] <daker> -
[21:30] <cjohnston> so your saying it can be one or the other?
[21:30] <daker> what do you mean ?
[21:31] <cjohnston> I don't understand what you mean by blocking
[21:32] <daker> blocking the execution of the other calls
[21:32] <daker> $("#id_date_end_0").datepicker();
[21:32] <daker> $('#id_date_end_1').timepickr({ trigger: 'focus', convention: 24 });
[21:32] <cjohnston> can you fix it?
[21:34] <daker> you are getting this error because of the timepickr call isn't compatible with jquery (i think) present on m, n and o
[21:34] <daker> it works only only lucid
[21:34] <cjohnston> ok
[21:34] <daker> s/only/in
[21:35] <daker> are you getting the same date on the two fields ?
[21:35] <cjohnston> yes
[21:35] <daker> so that's good
[21:35] <cjohnston> and no ability to pick a time
[21:35] <cjohnston> it should default to the same date, but i shouldnt have to type to change it
[21:37] <daker> ?
[21:37] <cjohnston> in order to change the ends date, i have to type it in
[21:37] <cjohnston> -1
[21:46] <daker> cjohnston, they have deployed the SSO choices
[21:47] <daker> mhall119,
[21:53] <daker> i don't understand cjohnston if you want to change the ends date you will have to type it
[21:53] <daker> cjohnston, ^