=== daker_ is now known as daker === daker is now known as daker_ [16:39] cjohnston: daker_: nigelb: http://www.informit.com/articles/article.aspx?p=1739163 [17:16] mhall119, nice [17:28] mhall119: nice [17:28] cjohnston: pleaes go ahead with whatever you want to fix. [18:42] nigelb: you here? [18:42] cjohnston: sort of. Just about to step out for coffee. What's up? [18:44] need help writing tests [18:46] ah [18:46] which one specifically? [18:46] the one your making me to [18:46] the edit pad link [18:52] cjohnston: okay, so I wont write code for you [18:52] I'll explain the basics of what the test should do [18:53] there's already an existing test. [18:53] It should put an output that fails and fail and an output that passes and pass [18:53] Check that out [18:53] create a new summit, and other things you'd need to use in that function [18:53] pass the parameters you generated to your function [18:53] now, you know what the output should be [18:54] construct it maully [18:54] *manually [18:54] check if your manually constructed output = output from function [18:54] mhall119: ^ comments? [18:55] without knowing the specifics, that sounds about right [18:57] if this is something that's going to be on a page, use self.client.get('/url/') to make sure it's in the resulting html [19:01] mhall119: this is constructing the URL. [19:01] will the URL to into a page output? [19:03] Yes, but that's not the point of the test. [19:03] as long as there is *a* test that does that [19:04] ah [19:10] cjohnston: line 17 of the pad [19:11] what's that url? [19:11] /uds-test-test-meeting? [19:12] mhall119: the way the url works is /summit-name-meeting-name, so the summit name is uds-test and the meeting name is test-mmeting [19:13] hmmmm, that doesn't look right, don't we prefix it with /meeting/ or something? [19:14] http://pad.ubuntu.com/uds-o-foundations-o-releaseprocess [19:14] I think we should prefix it... [19:14] mhall119: shouldn't we be splitting tests into logical files? [19:14] that's the etherpad url [19:14] * nigelb is used to seeing it done in LP. [19:15] self.client.get only makes calles to the Django instance [19:17] see.. heres what i dont get.. why do a test when ive already done the work [19:18] because when nigel breaks your work 5 revisions from now, the test will catch that [19:18] cause i can make the test work, but my code not work, and i can make code that works and a test not work [19:18] that's why you should write the test first [19:18] if the test is correct, then it will only pass once the code is correct [19:19] this make more sense in the case of bugs, where you write a test that reproduces the bug, then you write code to fix the bug until the test passes [19:20] Writing test cases is like insurance. [19:20] Your code still works, but there's not guarantee about tomorrow [19:20] (that's the closest analogy I could find) [19:25] nigelb: whats the url to edit a pad? [19:25] (slider etc) [19:26] /ep/pad/view/PADNAMEHERE/latest [19:27] cjohnston: give me an example of a summit link where this code is used [19:28] newz2000: I see that you <3 Drupal ;) [19:29] I don't know the story, but while running it locally my computer suddenly is going a lot slower [19:29] heh [19:29] nobody loves drupal [19:30] mhall119, you are the "nobody" [19:30] http://summit.ubuntu.com/uds-o/meeting/16334/foundations-o-releaseprocess/ [19:30] daker++ [19:30] ZING [19:30] maybe xdebug is hindering apc [19:31] cjohnston: then the url for self.client.get should be '/uds-test/metting/{{meeting.id}}/test-meeting/' [19:31] except spelling correcting [19:31] isnt it supposed to be testing the link to edit the the pad [19:31] the equivilent of /uds-o/meeting/16334/foundations-o-releaseprocess/ for the test data you created [19:32] you'll be testing that the link is in that page [19:45] mhall119: https://code.launchpad.net/~chrisjohnston/summit/etherpad/+merge/68901 [19:46] mhall119: http://paste.ubuntu.com/657448/ [19:47] uggh [19:47] conflict [19:47] cjohnston: ah, it's your migration script blowing up [19:47] it's not even getting to the testing stage [19:48] this is still the stupid 1.x migration issue [19:48] so i need to do this against trunk [19:55] mhall119: https://code.launchpad.net/~chrisjohnston/summit/pad-edit/+merge/70216 test it and get rid of it pleasE! [20:06] mhall119: please? [20:20] --> bed [20:24] no [20:24] nigelb: review my mp [20:24] lol [20:25] and my MPs ? [20:25] no one to review them :/ [21:09] daker: is there more than just one? [21:10] this one https://code.launchpad.net/~daker/loco-directory/fix.818373/+merge/69898 [21:11] the date one? im looking at that one right now [21:11] ok [21:11] theres no tests [21:11] !fail [21:11] Factoid 'fail' not found [21:12] this is a javascript [21:12] code [21:12] :-P [21:12] wanna make another mp for me? ;-) [21:12] for what ? [21:17] daker: with the new date code, when I click in the End Date box, the date picker doesn't come up [21:18] you are using oneric or natty, right ? [21:19] o [21:19] ? [21:21] the path of the jquery datepicker has changed since maverick [21:22] oneiric [21:23] the begins date the calendar picker shows up [21:26] daker: the begins date the calendar picker shows up, the ends date doesnt, nor do the times. [21:28] that's because of the timepickr [21:29] $("#id_date_begin_0").datepicker(); [21:29] - $('#id_date_begin_1').timepickr({ trigger: 'focus', convention: 24 }); <----- the script blocks here [21:29] - [21:29] - $("#id_date_end_0").datepicker(); [21:29] - $('#id_date_end_1').timepickr({ trigger: 'focus', convention: 24 }); [21:29] - [21:30] so your saying it can be one or the other? [21:30] what do you mean ? [21:31] I don't understand what you mean by blocking [21:32] blocking the execution of the other calls [21:32] $("#id_date_end_0").datepicker(); [21:32] $('#id_date_end_1').timepickr({ trigger: 'focus', convention: 24 }); [21:32] can you fix it? [21:34] you are getting this error because of the timepickr call isn't compatible with jquery (i think) present on m, n and o [21:34] it works only only lucid [21:34] ok [21:34] s/only/in [21:35] are you getting the same date on the two fields ? [21:35] yes [21:35] so that's good [21:35] and no ability to pick a time [21:35] it should default to the same date, but i shouldnt have to type to change it [21:37] ? [21:37] in order to change the ends date, i have to type it in [21:37] -1 [21:46] cjohnston, they have deployed the SSO choices [21:47] mhall119, [21:53] i don't understand cjohnston if you want to change the ends date you will have to type it [21:53] cjohnston, ^