| slide | In a lot of my folders there is this header for Ubuntu One. Is there any way to remove it? I dont want to sync those folders | 05:05 |
|---|---|---|
| slide | How do i get the nautilus integration to shut up? lol | 07:01 |
| slide | i dont want to share these folders | 07:01 |
| duanedesign | hello slide | 07:07 |
| slide | hello | 07:07 |
| duanedesign | slide: i think it is right-click in the folder and select Ubuntu One > Hide Ribbon | 07:09 |
| slide | aaah yea thanks! | 07:10 |
| JamesTait | Good morning all! | 08:09 |
| duanedesign | hello JamesTait | 08:09 |
| * fagan break | 10:22 | |
| === teknico is now known as teknico_away | ||
| ralsina | good morning people! | 11:50 |
| fagan | morning ralsina | 11:51 |
| fagan | So weird not having anyone online till lunchtime | 11:52 |
| fagan | now I know how mandel felt :) | 11:52 |
| karni | fagan: It's because everybody's busy working :P | 11:55 |
| fagan | karni: and in argentina :) | 11:56 |
| * fagan was working too | 11:56 | |
| karni | fagan: you work with people from Argentina only? | 11:56 |
| fagan | karni: mandel is in spain | 11:56 |
| karni | fagan: what do you mean 'in argentina', a sprint? | 11:56 |
| ralsina | Mandel had some plane problems and will probably not be around today either | 11:57 |
| ralsina | karni: mandel is the only other european in desktop+ | 11:57 |
| fagan | karni: well the entire team is in Argentina except me and mandel normaly | 11:57 |
| karni | ralsina: hah! :) | 11:57 |
| fagan | but yeah there was a sprint too so was pretty lonely for me last week but I found stuff to do and learn | 11:58 |
| ralsina | And he was in argentina until like 3AM your time today | 11:58 |
| fagan | ralsina: I didnt actually tell you what I did last week either did I, I was reading those books I got like the twisted one | 11:59 |
| fagan | ralsina: and writing up my report that I have to submit to my college | 11:59 |
| fagan | which is pretty huge | 11:59 |
| karni | ralsina: I see | 11:59 |
| ralsina | fagan: cool | 11:59 |
| fagan | ralsina: I was actually doing a bit of that earlier today too since I didnt have a specific thing to do | 12:00 |
| karni | fagan: I guess interns can do that - I would feel guilty if I read (even Android related) books on company time ;) | 12:00 |
| fagan | karni: yeah I was kinda in need of learning | 12:00 |
| fagan | karni: and I didnt have any assignments so made sense :) | 12:01 |
| karni | fagan: I'm in need of learning all the time. | 12:01 |
| ralsina | karni: well, interning *is* an educational thing | 12:01 |
| karni | ralsina: Indeed :) | 12:01 |
| fagan | ralsina: exactly ive learned stuff even when I wasnt expecting which is awesome | 12:02 |
| fagan | like mainly how companies work internally is great to learn alone | 12:02 |
| ralsina | karni: and I am supposed to be training him and not doing much of it :-( | 12:02 |
| karni | ralsina: Then he's excused for reading books! hahah ;D | 12:03 |
| fagan | ralsina: well it is incredibly busy because of the windows client | 12:03 |
| nessita | buenos días! | 12:03 |
| ralsina | ok, gotta reboot back to windows, be back in a bit | 12:03 |
| fagan | I read a great book written by a guy who worked as a project manager at digital the company that flopped in the 80s | 12:03 |
| karni | hi nessita , and bye! =D | 12:04 |
| karni | oh crap, it was ralsina rebooting lol | 12:04 |
| fagan | It was all about software development practices that were used and how to budget, manage and all that | 12:04 |
| karni | scratch that nessita , hello! :D | 12:04 |
| fagan | hey nessita | 12:04 |
| nessita | hi karni, fagan | 12:05 |
| karni | fagan: srsly? that must have been boring. I'm reading up recently on TDD and testing practices, exciting!! | 12:05 |
| karni | fagan: I mean, budget, manage.. bleh ;d | 12:05 |
| fagan | karni: well this was pretty interesting because it gave me insight into how people in upper management work to o | 12:05 |
| fagan | *too | 12:05 |
| fagan | like how they make the decision to go with a project | 12:06 |
| fagan | or not go with a project | 12:06 |
| fagan | and loads of other stuff | 12:06 |
| karni | fagan: I had a separate class about organizations and management in college. Man that was boring. | 12:06 |
| fagan | karni: well this one had a load of stories and all that too | 12:06 |
| karni | uhh.. peculiar bug me haz | 12:06 |
| fagan | so it was fairly interesting to read | 12:06 |
| karni | fagan: cool! | 12:06 |
| fagan | and I could skip over the bits I did learn in college | 12:07 |
| fagan | like who needs to read about waterfall | 12:07 |
| fagan | :D | 12:07 |
| * fagan prays he never has to do waterfall | 12:07 | |
| * fagan grabs some lunch before standup | 12:08 | |
| alecu | hello #ubuntuone! | 12:13 |
| karni | hello alecu ! | 12:14 |
| fagan | buenos ddos alecu | 12:16 |
| fagan | :D | 12:16 |
| alecu | fagan, "good distributed-denial-of-services"??? | 12:17 |
| fagan | alecu: yep :) | 12:17 |
| alecu | fagan, what does ddos mean to you? | 12:17 |
| fagan | alecu: well it ruined my favorite game but I was changing the spanish language for comic effect :D | 12:18 |
| alecu | oh, right. | 12:19 |
| ralsina | buen dia alecu! | 12:19 |
| * alecu laughes | 12:19 | |
| alecu | ralsina, buen día jefe! | 12:19 |
| ralsina | how you doing today alecu? Better? | 12:19 |
| alecu | ralsina, yup. better. not muuuuuch, but better. | 12:20 |
| ralsina | alecu: I missed the explanation because of IRC trouble | 12:21 |
| karni | alecu: For Android 2.0+, this is what we'll be using in Ubuntu One Files as far as login/registration is concerned: lp:ubuntu-sso-java-client lp:ubuntu-sso-android-client (latter is an Android Library). They still need some love, but you can see how they're used in lp:ubuntuone-android-files - apart from regular Android library usage (pasting stuff to AndroidManifest etc), I did use a separate activity to tell the user (s)he needs to ... | 12:21 |
| karni | ... add an account. Also, since this uses AccountManager, if there's U1Files or (soon) U1Music installed on the device already, there's even no need to use any of the two - a 3rd party app can simply request the token directly from AccountManager, and once the user grants access, it can use the OAuth token cached in AccountManager. Currently, although implemented, we've disabled registration in lp:ubuntu-sso-android-client, because it ... | 12:21 |
| karni | ... requires copying the token from email, and pasting into the app, which is not user friendly. Instead, we pop the browser, until we have better SSO registration experience via the API. | 12:21 |
| alecu | ralsina, yup, I saw you disconnecting just as I said "hello!" | 12:21 |
| karni | wow, that's a beefy message! | 12:21 |
| alecu | karni, nice!!!! | 12:22 |
| karni | alecu: :) | 12:23 |
| alecu | karni, it makes me want to start up eclipse again and change droidcouch to use it. | 12:23 |
| * alecu has not started eclipse in at least 4 or 6 months. | 12:24 | |
| karni | alecu: I spent a little time making it also Ant friendly :) All the instructions are in HACKING.txt in each project | 12:24 |
| karni | alecu: hah =) | 12:24 |
| alecu | ralsina, so, I've seen that mandel left a few branches up for review... | 12:25 |
| nessita | alecu: hi there! | 12:25 |
| nessita | alecu: yes, we're needing a review for https://code.edge.launchpad.net/~mandel/ubuntuone-client/fix-aq-tests-windows/+merge/69997 | 12:25 |
| ralsina | alecu: yes | 12:25 |
| alecu | nessita, looking | 12:25 |
| ralsina | and he won't be around today, so we should try to move them without him if needed | 12:25 |
| alecu | ack | 12:26 |
| alecu | ralsina, btw, regarding bug #803672 | 12:27 |
| ubot4 | Launchpad bug 803672 in ubuntuone-client (Ubuntu) (and 2 other projects) "Do not start two instances of this process (affects: 2) (heat: 22)" [Undecided,Invalid] https://launchpad.net/bugs/803672 | 12:27 |
| alecu | ralsina, did it happen when running sd using python, or using an .exe bundle? | 12:28 |
| * ralsina is all ears | 12:28 | |
| ralsina | alecu: python, but I have the exe in the place where the registry says | 12:28 |
| ralsina | haven't tried it with just exe | 12:29 |
| alecu | ralsina, cool. I'll take a look after reviewing these branches. | 12:29 |
| alecu | ralsina, I have not tried with the .exe yet either, so I was curious, because using python I didn't got that error. | 12:29 |
| alecu | ralsina, but I'll try with trunk first, because some other thing might have changed. | 12:30 |
| DiegoSarmentero | ralsina, question: now that we are reimplementing setTitle and setSubTitle, should I remove the "title" and "subtitle parameters in the constructors and use just that function from outside the class, or leave both options, and use setTitle, etc inside the class too? | 12:30 |
| ralsina | alecu: ok | 12:30 |
| nessita | DiegoSarmentero: we should avoid all code duplication, and so I think that we need to remove all the parameters from the classes otherwise we need to repeat the if to hide/show the labels in every class, right? | 12:32 |
| ralsina | I say leave the parameters and then call setTitle / setSubtitle | 12:32 |
| nessita | ralsina, DiegoSarmentero: can we have those methods named with snake_case#? | 12:33 |
| DiegoSarmentero | ralsina, yes, that was what i was doing... so i leave the parameters and call that function instead the if | 12:33 |
| DiegoSarmentero | nessita, we could named with snake_case in the controller | 12:33 |
| DiegoSarmentero | not in SSOWizardPage | 12:34 |
| nessita | DiegoSarmentero: this is the sso-client branch, right? | 12:34 |
| DiegoSarmentero | because we are reimplementing Qt methods to hide the actual behaviour | 12:34 |
| DiegoSarmentero | nessita, sso and wizard | 12:34 |
| DiegoSarmentero | not yet ready | 12:34 |
| nessita | DiegoSarmentero: so, the setTitle is a method we define, right? | 12:34 |
| nessita | or is it inherited from Qt? | 12:35 |
| DiegoSarmentero | nessita, redefine | 12:35 |
| DiegoSarmentero | inherited | 12:35 |
| nessita | ah, ok | 12:35 |
| j0nr | hey folks | 12:35 |
| j0nr | am having problems with 'save to phone' | 12:35 |
| j0nr | simply its not really working for me | 12:35 |
| j0nr | if I just check one song, then hit 'save to phone' the downloading icon appears next to the track but keeps stopping and starting | 12:36 |
| j0nr | and struggles to complete. | 12:36 |
| j0nr | I find the only way i can get tracks onto my phone is to 'play' them, which caches them on the phone, (is that what the orange star means?) then, whilst cached, check and save to phone. | 12:37 |
| ralsina | nessita: inherited methods, so camelCase | 12:38 |
| fagan | karni: ^ | 12:40 |
| nessita | alecu: do not bother doing the second review, I don t know why mandel proposed that since we agreed we'll skip file_shelf test suite | 12:40 |
| karni | hmm | 12:40 |
| karni | fagan: thank you | 12:41 |
| karni | j0nr: You have filed a bug about this, right? | 12:44 |
| karni | j0nr: Yes, orange star == song is cached | 12:44 |
| karni | j0nr: I'll pass this on to Chad, who's been taking care of Ubuntu One Music. He might already know what's wrong. | 12:45 |
| karni | j0nr: Thank you for reporting this. | 12:45 |
| alecu | nessita, by second review you mean this? https://code.edge.launchpad.net/~mandel/ubuntuone-client/fix-file-shelf-windows | 12:47 |
| nessita | alecu: yes | 12:47 |
| alecu | nessita, and I don't recall either: why skip it? | 12:47 |
| nessita | alecu: file_shelf is something used in old versions of u1client | 12:47 |
| nessita | alecu: and I'm not comfortable with the fix that mandel added using os.path.split | 12:48 |
| fagan | 10 minutes to standup | 12:49 |
| nessita | since is hiding the fact that fd.name returns different things in windows and in linux | 12:49 |
| alecu | nessita, also, that branch is missing the dependency on the previous one. | 12:52 |
| j0nr | karni: ok :) | 12:52 |
| alecu | nessita, I can work on a branch to skip those tests after the fix that ralsina requested for activation. | 12:52 |
| karni | j0nr: his nick is CardinalFang, he should be around soon. | 12:52 |
| nessita | alecu: thanks, but I'm adding that to my fix-tests branch. I have another task for you, if interested | 12:53 |
| alecu | nessita, shoot | 12:54 |
| nessita | alecu: either set_dir_readwrite and/or set_dir_readonly are not doing what they should. Calling readonly and then readwrite, do not restore the perms in a dir | 12:54 |
| nessita | alecu: I need to file a bug | 12:54 |
| alecu | nessita, great, point it to me, and I'll take a look. | 12:55 |
| nessita | alecu: bug #820350 | 12:56 |
| ubot4 | Launchpad bug 820350 in ubuntuone-client "WIndows: either set_dir_readwrite and/or set_dir_readonly are not doing what they should (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/820350 | 12:56 |
| fagan | me | 13:00 |
| ralsina | me | 13:00 |
| DiegoSarmentero | me | 13:00 |
| fagan | dobey, nessita, alecu | 13:00 |
| === m_conley_away is now known as m_conley | ||
| nessita | me | 13:00 |
| alecu | me | 13:01 |
| alecu | fagan, go | 13:01 |
| fagan | DONE | 13:01 |
| fagan | * more of my report for college | 13:01 |
| fagan | * Tried to figure out what was going on with 11.10 on my computers so I can file bugs (still haven't figured it out but going to fresh install and see if its still a problem) | 13:01 |
| fagan | TODO | 13:01 |
| fagan | * finish my report | 13:01 |
| fagan | * help with what ever any one wants | 13:01 |
| fagan | BLOCKED | 13:01 |
| fagan | * By bugs in 11.10 | 13:01 |
| fagan | ralsina: go | 13:01 |
| DiegoSarmentero | ralsina, ? | 13:02 |
| nessita | DiegoSarmentero: go! | 13:02 |
| alecu | DiegoSarmentero, go | 13:02 |
| fagan | might be having a connection issue again | 13:02 |
| DiegoSarmentero | DONE: | 13:02 |
| DiegoSarmentero | Modify SSO and Wizard to work with a reimplementation of "setTitle" and "setSubTitle". Test to validate this new implementation almost complete. | 13:02 |
| DiegoSarmentero | TODO: | 13:02 |
| DiegoSarmentero | Keep working on Installer with embed Control Panel branch. And UI bugs from Installer. | 13:02 |
| DiegoSarmentero | BLOCKED: | 13:02 |
| DiegoSarmentero | No. | 13:02 |
| ralsina | DONE: bug #819917 bug #819878 bug #811246 bug #810053 TODO: bug #814686 and more | 13:02 |
| ralsina | BLOCKED: no, NEXT: DiegoSarmentero | 13:02 |
| DiegoSarmentero | nessita, go | 13:02 |
| nessita | DONE: half day off, reviews, more fixing test_vm: found out that either set_dir_readonly and/or set_dir_readwrite are not doing what they should, so shares dir can not be removed | 13:02 |
| nessita | TODO: make more tests pass | 13:02 |
| nessita | BLOCKED: nopes | 13:02 |
| nessita | NEXT: alecu | 13:02 |
| alecu | DONE: took a sick day | 13:02 |
| alecu | TODO: reviews, work on bug #820350 | 13:02 |
| alecu | BLOCKED: not today | 13:02 |
| alecu | NEXT: dobey | 13:02 |
| ubot4 | Launchpad bug 819917 in ubuntu-sso-client "show_gui.py doesn't work anymore (affects: 1) (heat: 6)" [Undecided,Fix committed] https://launchpad.net/bugs/819917 | 13:02 |
| ubot4 | Launchpad bug 819878 in ubuntu-sso-client "On windows: "python setup.py install" fails (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/819878 | 13:02 |
| ubot4 | Launchpad bug 811246 in ubuntuone-windows-installer "The Control Panel is not opened in the last step (affects: 1) (heat: 10)" [High,Fix committed] https://launchpad.net/bugs/811246 | 13:02 |
| ubot4 | Launchpad bug 810053 in ubuntuone-windows-installer "Credentials obtained by the installer don't work. (affects: 1) (heat: 9)" [Critical,Fix committed] https://launchpad.net/bugs/810053 | 13:02 |
| ubot4 | Launchpad bug 814686 in ubuntu-sso-client "QT UI: 'Sign in' button can be clicked even if not values were entered, same happens with verification code (affects: 1) (heat: 13)" [Medium,In progress] https://launchpad.net/bugs/814686 | 13:02 |
| ubot4 | Launchpad bug 820350 in ubuntuone-client "WIndows: either set_dir_readwrite and/or set_dir_readonly are not doing what they should (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/820350 | 13:02 |
| ralsina | LAGGGGGG | 13:03 |
| alecu | ralsina, stop leeching! | 13:03 |
| fagan | alecu: hehe | 13:03 |
| === teknico_away is now known as teknico | ||
| fagan | I never asked how is the internet in AR? | 13:04 |
| nessita | any comments? | 13:04 |
| nessita | alecu, ralsina, Chipaca: are we having mumble today? | 13:04 |
| alecu | nessita, I'm -0 to that | 13:05 |
| fagan | Na I dont have comments | 13:05 |
| ralsina | I'm ok with a mumble | 13:05 |
| fagan | Oh ralsina do you want to proof read my report when I have it done | 13:05 |
| ralsina | fagan: usually, the same thing as everywhere else. In fact my IRC problems are because of a server in the US that is acting up | 13:06 |
| fagan | ralsina: ahhh ok | 13:06 |
| ralsina | fagan: sure, send it over | 13:06 |
| fagan | ralsina: the report doesnt have anything internal on it its just a brief about the company | 13:06 |
| fagan | ralsina: cool | 13:06 |
| fagan | the only thing that would have been dodgy I asked about and im not going to write about it | 13:07 |
| dobey | me | 13:12 |
| dobey | λ DONE: yet more shim work | 13:12 |
| dobey | λ TODO: finish initial shim | 13:12 |
| dobey | λ BLCK: None. | 13:12 |
| nessita | brb | 13:28 |
| * nessita back | 13:39 | |
| nessita | alecu, ralsina, Chipaca: shall we mumble? | 13:50 |
| dobey | grr, python-aptdaemon is being super annoying. | 13:56 |
| dobey | if it ain't one thing... | 13:57 |
| nessita | alecu, ralsina, Chipaca: hello? | 13:57 |
| Chipaca | nessita: in futures call | 13:58 |
| ralsina | nessita: can it be in a while? I am having some local trouble and chipaca is in another call anyway | 13:58 |
| nessita | Chipaca, ralsina: would you please let us know when you're available? | 13:59 |
| === m_conley is now known as m_conley_away | ||
| ralsina | I will be in about 30 minutes | 14:00 |
| DiegoSarmentero | nessita, ralsina I need reviews for this branches: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/titles-on-pages/+merge/70169 AND https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/titles-on-pages/+merge/70157 | 14:16 |
| ralsina | DiegoSarmentero: on it! | 14:17 |
| DiegoSarmentero | ralsina, thanks | 14:17 |
| nessita | DiegoSarmentero: sure | 14:17 |
| DiegoSarmentero | nessita, great... now everything should be ok | 14:18 |
| DiegoSarmentero | ralsina, nessita mmmmm it seems that launchpad didn't rescan my branch yet | 14:19 |
| nessita | DiegoSarmentero: no problem, I'm branching locally | 14:19 |
| ralsina | DiegoSarmentero: it takes a while sometimes | 14:19 |
| nessita | DiegoSarmentero: is mumble working for you? | 14:19 |
| DiegoSarmentero | nessita, no, about that...... is there a wiki or something where it explains how to configure... i don't know if you have to setup any special server or something... and i couldn't find it on the wiki | 14:20 |
| nessita | DiegoSarmentero: yes, let me give details in private | 14:20 |
| nessita | Chipaca, ralsina: hello bosses! any news re: mumble so we can schedule our lunches? | 15:14 |
| ralsina | nessita: I am free now | 15:15 |
| dobey | lunch time here. bbiab :) | 15:16 |
| ralsina | launchpad is not scanning branches. That means we can't merge stuff easily, right? | 15:18 |
| nessita | ralsina: not sure if LP is that related to tarmac | 15:20 |
| ralsina | Anyway, if it ever comes back... https://code.launchpad.net/~ralsina/ubuntu-sso-client/validate-harder/+merge/70320 | 15:21 |
| nessita | ralsina: so, shall we schedule a time for mumble? | 15:21 |
| nessita | Chipaca: ^ | 15:21 |
| Chipaca | nessita: 39 minutes from now would wfm | 15:21 |
| nessita | Chipaca: sounds great. alecu, DiegoSarmentero, ralsina: meeting at 1pm ART? | 15:23 |
| DiegoSarmentero | nessita, ack | 15:23 |
| alecu | nessita, ack. Let's get some lunch then. | 15:23 |
| nessita | yeah! | 15:23 |
| ralsina | As I said, I am free now | 15:23 |
| nessita | ralsina: would you be at 1pm? | 15:24 |
| ralsina | ok, 1PM it is | 15:24 |
| alecu | nessita, ralsina, DiegoSarmentero: anybody has seen this? http://pastebin.ubuntu.com/658005/ | 15:45 |
| ralsina | alecu: I did. You need to remove your xdg and install as the wiki says | 15:46 |
| alecu | ralsina, great, thanks. | 15:46 |
| nessita | alecu: ping | 15:50 |
| alecu | ralsina, great, thanks. | 15:51 |
| nessita | alecu: test_eq_inotify is failing for me in trunk, with a scary error regarding threads and a thread pool: http://pastebin.ubuntu.com/658012/ | 15:51 |
| nessita | alecu: any clues? | 15:51 |
| nessita | @ping | 15:52 |
| ubot4 | pong | 15:52 |
| alecu | nessita, there's nothing scary! | 15:53 |
| nessita | alecu: is scary to me | 15:53 |
| nessita | alecu: do you understand what's wrong? | 15:53 |
| alecu | nessita, the threadpool part of the stacktrace just says that it's failing in the bit that's being run on the watch thread | 15:54 |
| alecu | nessita, the other error I remember seeing it with mandel, when trying to open *something*. Not necesarily a file, but something. | 15:54 |
| nessita | alecu: so, shall the watch thread handle that? | 15:56 |
| alecu | nessita, so: it's trying to open the directory to set up the watch, and either the path is bad or the directory is no longer there. | 15:56 |
| alecu | nessita, it's the watch thread that's failing. | 15:56 |
| nessita | right | 15:56 |
| alecu | nessita, _watch is the function being run inside the thread. | 15:56 |
| nessita | right | 15:56 |
| alecu | nessita, and on the first line of that function it's failing | 15:56 |
| alecu | nessita, so, yes: we should somehow handle this error. | 15:57 |
| alecu | nessita, but right now it looks like an issue in the way the test was set up. | 15:57 |
| alecu | nessita, is that happenning on trunk to you? | 15:57 |
| nessita | alecu: yes | 15:57 |
| nessita | alecu: is it for you? | 15:57 |
| alecu | nessita, I'm running those tests now. | 15:58 |
| alecu | ouch, I forgot TRIAL_TEMP_DIR | 16:00 |
| alecu | nessita, all tests passed on trunk | 16:01 |
| nessita | alecu: among other things, I see calls to add_watch that are not being yield on | 16:01 |
| nessita | alecu: you up to date? seems like an ugly timing issue | 16:01 |
| nessita | mumble! | 16:01 |
| alecu | nessita, can you try setting TRIAL_TEMP_DIR to a clean folder? | 16:02 |
| nessita | alecu: yes, already did it, but I will do it again | 16:02 |
| alecu | nessita, what calls to add_watch are not being yielded on? | 16:02 |
| alecu | nessita, don't worry about that, I just tried with the same TRIAL_TEMP_DIR and it seems to be working. | 16:02 |
| nessita | alecu: confirmed is failing in a new temp dir | 16:03 |
| nessita | alecu: calls to add_watch inside test_eq_inotify | 16:03 |
| nessita | Chipaca: mumble? | 16:04 |
| === m_conley_away is now known as m_conley | ||
| === beuno is now known as beuno-lunch | ||
| mandel | ralsina: ping | 16:30 |
| alecu | hola mandel! | 16:30 |
| alecu | mandel, where are you now? | 16:31 |
| mandel | alecu: hola!!! | 16:31 |
| ralsina | mandel: pong! | 16:31 |
| mandel | alecu: in madrids airport trying to get back home… I lost my connection flight and have to wait for 3 more hours | 16:31 |
| alecu | mandel, :-( | 16:31 |
| mandel | ralsina: hello, did you guys take look at my branches, I'm going to put some hours from the airport :P | 16:32 |
| alecu | mandel, we approved the first one, and rejected the second | 16:32 |
| mandel | alecu: yeah, is a pain, but I'm getting used to it, only bad things is that I smell a little hehehe | 16:32 |
| alecu | mandel, we are mumbling right now | 16:32 |
| alecu | mandel, hahahaha | 16:32 |
| alecu | mandel, yes, it sucks. | 16:32 |
| mandel | alecu: what was wrong with the second one? | 16:33 |
| * mandel goes to launchpad | 16:33 | |
| alecu | mandel, nessita reminded us that the bits in the second branch are only used in old versions of syncdaemon. | 16:34 |
| mandel | alecu: funny thing, is my bday and I'm spending it at the airport, I feel like a real business man :P | 16:34 |
| alecu | mandel, oh!!!! right!!!! | 16:34 |
| alecu | happy birthday, Mr. Vice-President of Windows! | 16:35 |
| mandel | alecu: yes, indeed they are just used in old version, but there are tests everywhere that depend on those, and I think is better to have as many green ligths as possible :) | 16:35 |
| mandel | alecu: hehe, I'm vc of nothing ;) | 16:35 |
| alecu | mandel, she suggested skipping those tests on windows | 16:35 |
| mandel | alecu: that involves skipping tests for fsm too, which is a pain and is suppose to be multplatform | 16:36 |
| mandel | also, having deprecated code that does not work is dangerous in the case we ever want to use it, specially when it has already been fixed | 16:36 |
| alecu | mandel, and also she commented there's an issue with masking a filename that's absolute on windows, but relative on linux. | 16:36 |
| alecu | mandel, or something like that. | 16:36 |
| nessita | mandel: I don't like the adding to os.path.split | 16:36 |
| mandel | nessita: why? | 16:37 |
| nessita | mandel: if fd.name is returning different stuff in each platform, we need a more complex solution | 16:37 |
| mandel | nessita: is just in the test of a fake unpickle method, not in the actual code | 16:37 |
| nessita | not just masquerading this with os.path.split | 16:37 |
| nessita | mandel: then why fd.name returns different stuff in each platform? | 16:37 |
| nessita | (if it's a fake) | 16:38 |
| * DiegoSarmentero brb... lunch! | 16:38 | |
| mandel | nessita: because open_file has the windows decorator which converts the path in an abspath with the \\?\ | 16:38 |
| nessita | mandel: and also, I don't understand how the test_fsm depends on stuff that are not being used un windows | 16:39 |
| mandel | nessita: yes, that is why I started fixing fileshelf, otherwise I would have not touched it | 16:39 |
| nessita | mandel: can we make test_fsm not depend on file_shelf for code that is currently being used | 16:39 |
| nessita | ? | 16:39 |
| mandel | nessita: we could, indeed | 16:39 |
| nessita | mandel: I think that is the solution | 16:39 |
| nessita | otherwise we're not testing what we're running | 16:40 |
| mandel | nessita: better than a solution that has already been implemented? | 16:40 |
| ralsina | I think I am going to take a rather long lunch and put back the hours later, because I have some errands. I should be back in 2 or 3 hours :-( | 16:40 |
| mandel | nessita: I'd say we are testing all the API that sd provies, that it is not used I really don't care much (to a level ofcourse) | 16:40 |
| nessita | mandel: but, 2 things: | 16:40 |
| mandel | ralsina: before you go, swap day tom for me? | 16:41 |
| nessita | * fd.name should return the same in every platform. If that is not the case, we should fix why and not hide the issue using os.path.split | 16:43 |
| nessita | * you said that if we skip the file_shelf tests, we need to also skip test_fsm becasue test_fsm depends on that. So, I say, how come we're depending on running tests for test_fsm, which is a feature we do use in windows, on things that we're not running in windows (file_shelf)? | 16:43 |
| nessita | we want test_fsm to run all the suite using the features we will run in windows, no? | 16:43 |
| alecu | nessita, regarding the issue in the _watch function: can you print self._path before calling CreateFile? Also, print os.path.exists(self._path) and os.path.isdir( | 16:43 |
| alecu | self._path) | 16:43 |
| mandel | alecu: what is the problem with _watch? | 16:44 |
| ralsina | mandel: sure, poor baby ;-) | 16:44 |
| nessita | alecu: in which file should I add the print for self._watch? | 16:44 |
| alecu | nessita, ubuntuone/platform/windows/filesystem_notifications.py | 16:45 |
| mandel | nessita: fd.name does return the same in every platform, the issue here is that the fd returns the path that was passed to open, because we use open_file, for reasons we both know, we call open with an abs path with \\?\, which makes fd to set the name to the abspath, we can change the code to call open with the abspath and then you will have the same tests, which is a compromise I'm willing to have | 16:45 |
| alecu | nessita, at the start of def _watch(), just before the call to CreateFile | 16:45 |
| mandel | nessita: since maybe using os.path.split was not the correct way to fix the tests | 16:45 |
| alecu | nessita, btw: CreateFile is in fact being used to "open a directory". talk about api naming... | 16:46 |
| nessita | mandel: that makes sense, but, I'm now worried that test_fsm will not work without file_shelf. We need test_fsm to work without it, since we will use it without or | 16:46 |
| nessita | alecu: on it | 16:46 |
| mandel | nessita: indeed, there ate tests in test_fsm that probable do not belong there, they seem to be testing metadata issues that should clearly be placed somewhere else, but we should ask chicharra about that | 16:47 |
| nessita | mandel: so we can skip those since are not fsm-related | 16:47 |
| mandel | nessita: yes, we skip the metadata ones in fsm and move forward, yet we fix the fileshelf tests no to use os.path.split (easy fix) and once those to are landed we talk with chicharra about why do we have this types of tests mixed | 16:48 |
| mandel | nessita: maybe moving them to test_metadata.py is a better approach rather than having them in tst_vm and test_fsm | 16:49 |
| mandel | I recall there were some metadata tests in test_vm too, but I might be wrong | 16:49 |
| nessita | mandel: vm metadata and fsm metadata are different metadata | 16:50 |
| nessita | *very* different | 16:50 |
| mandel | nessita: are they… joder!!!! care to explain me the diff? | 16:50 |
| nessita | mandel: let me confirm I'm not lying to you | 16:51 |
| nessita | facundobatista: ping | 16:51 |
| mandel | nessita: ok :) | 16:52 |
| nessita | mandel: it used to be for sure, but now with tritcask I'm in doubt | 16:52 |
| mandel | nessita: yeah, would be nice to have deprecation warnings etc.. so that we could know, could be an easy bug for chicharra | 16:53 |
| nessita | alecu: http://pastebin.ubuntu.com/658041/ | 16:54 |
| nessita | alecu: anyways, I see bad setupping in that test... | 16:54 |
| nessita | ok, lunchtime for me | 16:54 |
| mandel | alecu, nessita: that is easy to fix, call CreateFileW | 16:56 |
| mandel | alecu: the issue is that you are calling a unicode path with the CreateFile function instead of the unicode one from COM, which ends in W | 16:57 |
| mandel | alecu: mainly, puto COM, puto Windows, puto MSDN, yet easy to fix | 16:57 |
| === jderose1 is now known as jderose | ||
| mandel | alecu: in case you need the docs: http://msdn.microsoft.com/en-us/library/aa363858(v=vs.85).aspx do a search for unicode (if the page is in english) | 17:01 |
| alecu | mandel, the very weird thing is that it works ok for me, and I'm also using unicode literal paths there. | 17:01 |
| mandel | alecu: really? dammed, well nevertheless we should be using CreateFileW | 17:02 |
| mandel | alecu: I though that nessita was using E: as here volume label, am I wrong? | 17:02 |
| alecu | nessita, let's do what mandel says: changing CreateFile to CreateFileW | 17:05 |
| mandel | @ping | 17:10 |
| ubot4 | pong | 17:10 |
| mterry | aquarius, heyo. I'm getting not infrequent 500 (and even occasionally 503) errors when uploading deja-dup backup files to U1. How do I go about helping to fix that? | 17:19 |
| aquarius | mterry, I know vds has been working on a problem with upload failures -- vds? | 17:19 |
| aquarius | mterry, what's the body of the error responses? | 17:19 |
| === beuno-lunch is now known as beuno | ||
| mterry | aquarius, I haven't dug that out yet, would have to do some work to get it | 17:20 |
| aquarius | mterry, a 503 is a temporary error on the server (that is: it might be due to overloaded database or something), and can be retried. | 17:20 |
| mterry | Which I'm happy to do, just haven't yet | 17:20 |
| mterry | aquarius, we do retry 5 times and take the last error | 17:20 |
| mterry | so I guess should just wait a bit | 17:20 |
| mterry | or back off longer | 17:20 |
| aquarius | perhaps, yeah. We're working on some DB overload issues exactly now. Maybe exponential backoff or something rather than 5 in quick succession? | 17:21 |
| mandel | mterry, aquarius: I thin vds is off for 2day, maybe you can add somewhere a question for him to take a look… | 17:21 |
| aquarius | a 500 -- it would be most useful to have the error body so we can see what the U1 server is complaining about | 17:21 |
| mterry | aquarius, I also note that last I checked the server returned generic 500 for "out of space". I think I filed a bug about that. Though that's unrelated to this issue | 17:22 |
| vds | mterry, do you have an oops id? | 17:22 |
| mandel | vds: o/ hello | 17:22 |
| vds | mandel, hello! :) | 17:22 |
| vds | mterry, that means you're out of quota | 17:23 |
| mterry | vds, not on hand. I assume that would be in the body? | 17:23 |
| vds | mterry, yes | 17:23 |
| mterry | vds, 500 always should mean out of quota? I seem to be getting it when not | 17:23 |
| aquarius | vds, do we return oops ids in JSON responses? | 17:23 |
| vds | mterry, having an oops id would be very useful | 17:23 |
| mterry | At least, disk quota | 17:23 |
| mterry | vds, can you lookup recent oops ids for a given account? | 17:23 |
| vds | mterry, out of space can mean out of quota | 17:23 |
| mterry | vds, else give me a bit and I can get one | 17:24 |
| vds | mterry, I wish I could do that, would make my life much better! :) | 17:24 |
| mterry | vds, are there quotas besides disk space? | 17:24 |
| vds | mterry, not sure what you mean | 17:25 |
| vds | mterry, I meant that for a while we returned a 500 when out of quota | 17:25 |
| vds | now we return a 507 | 17:26 |
| mterry | vds, oh you do!? /me hugs vds | 17:26 |
| mterry | vds, I filed a bug about that, let me go close it then | 17:26 |
| nessita | mandel: I'm not using E: for the temp dir, but C:\Temp\something | 17:26 |
| mterry | vds, or maybe you can to verify we're talking the same thing: bug 800384 | 17:26 |
| ubot4 | mterry: Bug 800384 on http://launchpad.net/bugs/800384 is private | 17:26 |
| mandel | nessita: ok, try with CreateFileW since we are using unicode, if it is not that we have to look closer... | 17:27 |
| mandel | nessita: which volumes do you have working in the vm? | 17:27 |
| nessita | mandel: not sure what you mean | 17:27 |
| mandel | nessita: as in, tests code is in E but temp is in C for example | 17:28 |
| nessita | mandel: that is correct | 17:28 |
| mandel | nessita: ok.. alecu is that correct for you? ^^^ | 17:28 |
| alecu | mandel, nessita: I also have code on E, temp on C | 17:32 |
| mandel | alecu, nessita: I wonder what is the diff for one to work and the other not to... | 17:32 |
| nessita | alecu: so, the whole test_eq_inotify is passing for you? | 17:35 |
| nessita | alecu: I changed to CreateFileW and I have a lot of more errors | 17:36 |
| nessita | bad things like calling os.symlink are failing | 17:36 |
| nessita | which should be failing for you... | 17:36 |
| * vds looks at the bug | 17:37 | |
| alecu | nessita, all the tests in test_filesystem_notifications.py pass: http://pastebin.ubuntu.com/658066/ | 17:37 |
| nessita | alecu: but the issue is in test_eq_intify | 17:38 |
| nessita | alecu: test_eq_inotify * | 17:38 |
| alecu | hmm | 17:38 |
| nessita | alecu: I said that from the beginning :-) | 17:38 |
| alecu | nessita, doh | 17:38 |
| nessita | :-P | 17:38 |
| mandel | alecu: we might want to update the tests from filesystem notifications to use illegal unicode chars | 17:39 |
| * mandel does not have time to do it today... | 17:39 | |
| nessita | mandel, alecu: all the calls to add_watch in test_eq_inotify are not being yield on, I'm fixing that | 17:41 |
| mandel | nessita: oh, that would be a very good thing to do :) | 17:42 |
| alecu | nessita, now I'm getting the CreateFile error that nessita mentioned, :P. | 17:43 |
| nessita | mandel: does the removal of watches return a deferred as well :-) | 17:43 |
| nessita | ? | 17:43 |
| nessita | mandel: I mean ? not :-) :-P | 17:43 |
| * mandel looks | 17:43 | |
| nessita | alecu: if you change CreateFile to CreateFileW, do you get a lot more of other errors? | 17:43 |
| mandel | nessita: no, it does not | 17:44 |
| alecu | nessita, I'm testing that, and it looks like it returns a lot more errors. | 17:45 |
| alecu | nessita, but running without W gets stuck in the second test, like forever. | 17:45 |
| nessita | alecu: yes. I'm checking if yielding on the add_watch makes things better | 17:45 |
| alecu | and on the second run trial aborts when trying to delete old folders, and I have to set a new temp folder | 17:45 |
| mandel | alecu: may I see the errors when using the W? | 17:47 |
| alecu | mandel, sure | 17:47 |
| mandel | alecu: I don't have much time left, but I might be able to give you a hint of where to look | 17:47 |
| alecu | mandel, http://pastebin.ubuntu.com/658074/ | 17:50 |
| * mandel looks | 17:50 | |
| nessita | mandel, alecu: I bet most of the errors are caused by the lack of yield | 17:50 |
| alecu | mandel, (you should ignore the first run of trial) | 17:50 |
| mandel | alecu: ok | 17:51 |
| nessita | mandel, alecu: so do not spend time on that until I add all the yields | 17:51 |
| mandel | alecu: I wonder why do you have an AlreadyCalledError.. I though we fixed that in the FileSystemNotifications, do you have the last trunk? | 17:52 |
| mandel | alecu, nessita: I need to run though T4 in Madrid airpot to my gate, I'll connect again if I have time | 17:54 |
| mandel | bye! | 17:54 |
| dobey | https://code.launchpad.net/~dobey/ubuntuone-installer/install-pages/+merge/70346 | 17:57 |
| dobey | ^^ can i get a couple reviews? | 17:57 |
| dobey | bbiab, have an appointment to get to | 18:18 |
| mterry_ | vds, still here? I have a 500-status oops id for you: 2041updownZaAeFGbcdbDCJEIFdaFfeFfGBAJfDGedG15380 | 19:12 |
| vds | mterry_, I'll take a look | 19:14 |
| vds | mterry_, it's a new one? | 19:16 |
| vds | I can't find it yet... | 19:16 |
| mterry_ | vds, a few minutes old | 19:16 |
| vds | mterry_, it's going to take a while before I'll be able to look at it, I'll let you know, thanks for the moment | 19:17 |
| mterry_ | vds, cool | 19:17 |
| alecu | nessita, ralsina: ping | 19:20 |
| nessita | alecu: desperate pong | 19:21 |
| nessita | :-) | 19:21 |
| dobey | i wonder if anyone reviewed my branch. probably not | 19:21 |
| alecu | nessita, desperate? | 19:21 |
| nessita | alecu: tests are driving me crazy, they are way more broken than expected :-/ | 19:21 |
| alecu | oh, ralsina is gone | 19:21 |
| alecu | :-( | 19:21 |
| nessita | alecu: how can I help you? | 19:21 |
| alecu | nessita, regarding permissions: "it's complicated" | 19:22 |
| nessita | alecu: I bet very | 19:22 |
| nessita | alecu: can we fix it? :-D | 19:22 |
| alecu | nessita, don't know. | 19:22 |
| alecu | nessita, the current code is setting access for some groups, and that looks right. But... | 19:22 |
| alecu | but the groups are not the default groups that are set when the file is created from scratch | 19:23 |
| DiegoSarmentero | nessita, the method "login_email_password" from CredentialsManagerTool not longer exists, isn't it? | 19:23 |
| nessita | alecu: I narrowed the problem to this IRL test: | 19:23 |
| alecu | and I can't find the reason why this is being done this way. | 19:23 |
| alecu | nessita, and I can't find the right windows api call to get the "default" permissions for a file. | 19:23 |
| alecu | nessita, plus, this won't work at all on a drive formatted on anything other than ntfs | 19:24 |
| nessita | alecu: when I try to remove a dir that was set to readonly with our code, the explorer tells me I need to switch to admin to do taht, I say yes, but then it complains it needs the test user privileges to do that | 19:24 |
| nessita | alecu: ouch! | 19:24 |
| nessita | DiegoSarmentero: is new | 19:24 |
| nessita | DiegoSarmentero: what error do you have? | 19:24 |
| alecu | (it's not very common, but it's the same that's happening to us with E:) | 19:24 |
| alecu | nessita, I got that same warning too | 19:25 |
| DiegoSarmentero | nessita, i'm trying to login with the installer but i receive that this method doesn't exist..... i'm going to try to update ubuntuone-client | 19:25 |
| nessita | DiegoSarmentero: yes, please update the whole dependencies and set PYTHONPATH properly | 19:25 |
| nessita | alecu: I'm very close to advice the following: | 19:26 |
| nessita | alecu: on windows, we don't set shares to readonly. Period. :-) | 19:26 |
| alecu | nessita, sounds reasonable for the time being | 19:26 |
| DiegoSarmentero | nessita, in other news :P did you have the chance to review my branches? or launchpad is not working properly yet? | 19:26 |
| nessita | alecu: I think syncdaemon should filter events inside RO shares | 19:26 |
| alecu | nessita, I would really like to discuss mandel to understand how did he approach this, because the way he is doing it looks reasonable. | 19:26 |
| alecu | but it does not work yet :-( | 19:27 |
| nessita | DiegoSarmentero: I did not have the chance, I will later today. Are they blocking you? | 19:27 |
| nessita | alecu: right. ANyways, we need to support fat | 19:27 |
| nessita | so... | 19:27 |
| alecu | nessita, not sure if we need to support fat | 19:27 |
| DiegoSarmentero | nessita, nop... i have merged the other branch locally to keep working | 19:27 |
| nessita | alecu: why not? | 19:27 |
| alecu | nessita, syncdaemon runs from the home folder only | 19:27 |
| nessita | DiegoSarmentero: great | 19:28 |
| nessita | alecu: and we can't have home folders with fat? | 19:28 |
| alecu | nessita, I think it should be uncommon, since the default for xp has always been ntfs. | 19:28 |
| alecu | nessita, so it really should be a question of if we want to drop support for that. | 19:29 |
| alecu | nessita, probably this should be a problem for a computer that was updated to xp from a previous version that used fat. | 19:29 |
| nessita | alecu: can you please write an email to the windows team about that? including the bosses | 19:29 |
| alecu | nessita, sure. | 19:29 |
| nessita | alecu: and I ll reply proposing dropping this | 19:30 |
| nessita | this == setting stuff to readonly | 19:30 |
| alecu | nessita, ack | 19:30 |
| dobey | thisfred, alecu, nessita: care to review https://code.launchpad.net/~dobey/ubuntuone-installer/install-pages/+merge/70346 ? :) | 19:35 |
| thisfred | dobey can do, in a few | 19:35 |
| nessita | dobey: I have 2 queued reviews and tons of failing tests to fix, I can do it tomorrow morning, sorry :-/ | 19:35 |
| alecu | nessita, when does syncdaemon set stuff to "read-only"? | 19:58 |
| nessita | alecu: because there are shares that are read-only | 19:58 |
| alecu | nessita, and also: is the user supposed to be able to delete those files? | 19:58 |
| nessita | alecu: to prevent regular users to modify stuff | 19:58 |
| alecu | nessita, oh, ok. | 19:58 |
| alecu | hmmm | 19:58 |
| alecu | ok | 19:58 |
| nessita | alecu: no, the user should not be able to remove | 19:58 |
| dobey | i better put these pringles away | 20:02 |
| diverse_izzue | upload on U1 seems to be very slow. it's true my connection doesn't seem to have more than about 0.6mbps upstream, but u1 is uploading at about 30 kB/s and then not even uninterruptedly. is that normal? | 20:28 |
| nessita | diverse_izzue: yes, we have noticed some delays in our service, we're working on that | 20:29 |
| nessita | diverse_izzue: sorry for the inconveniences :-( | 20:29 |
| diverse_izzue | apology accepted, but isn't it time now that U1 reaches a stably stable state? the service has been around for what, two years now? | 20:30 |
| dobey | diverse_izzue: at that connection speed, you're probably not going to get much more than 30kB/s upload | 20:31 |
| diverse_izzue | dobey, interesting, why? if i do the math i should have 2 to 3 times that, no? | 20:31 |
| nessita | diverse_izzue: we're not having issues as in crashes, but server overloads. We're working on expanding our capabilities. | 20:31 |
| dobey | diverse_izzue: right, 2x that is not much more. but you're not talking directly to the server. you have lots of routes to go through, and depending on your connection type, other people on your ISP might be consuming lots of bandwidth too, which would affect you | 20:33 |
| diverse_izzue | okay, but when i say 0.6mbps upstream then that's not a number my isp gives me, but one i obtained right now using a speedtest on the connection | 20:34 |
| dobey | right | 20:34 |
| dobey | if it's speedtest.net, it does some checks to pick a fast server near you, before doing the actual test | 20:35 |
| diverse_izzue | it was, so that's what happened | 20:36 |
| dobey | i'm sure others do similarly | 20:36 |
| dobey | so while it's a useful number to know, lots of other factors come into play when actually talking to servers. especially if they're very far away :) | 20:36 |
| diverse_izzue | ok, i get it. out of curiosity, is all of U1 data geographically in the same place, or distributed over the planet? | 20:37 |
| nessita | ralsina: you back? | 20:59 |
| ralsina | nessita: yes | 21:02 |
| nessita | ralsina: everything ok? | 21:02 |
| ralsina | nessita: errands took much longer than expected :-( | 21:02 |
| ralsina | nessita: I am reorganizing in my old company and have to sell stock, that kind of thing. Bureaucratic nightmare | 21:03 |
| === yofel_ is now known as yofel | ||
| nessita | alecu: can you please confirm that you have nearly 22 errors when running test_action_queue, and those errors are for the CreateFile stuff in _watch? | 21:05 |
| alecu | nessita, checking | 21:11 |
| nessita | alecu: but only when running the whole test_action_queue module, and is definitely a timing-related bug | 21:11 |
| nessita | alecu: I have between 5 and 20~ tets failing, depending on the run | 21:12 |
| nessita | alecu: and some test suite pass something and fail some other times | 21:12 |
| nessita | the error is: | 21:12 |
| alecu | nessita, probably they are missing a yield on add_watch as well. | 21:12 |
| nessita | pywintypes.error: (2, 'CreateFileW', 'The system cannot find the file specified.') | 21:12 |
| nessita | alecu: checking | 21:12 |
| * dobey leers sternly at thisfred | 21:12 | |
| alecu | nessita, were you able to fix the pyinotify errors with that? | 21:12 |
| thisfred | dobey oops, sry | 21:13 |
| nessita | alecu: I haven't ran that suite again, let me try | 21:13 |
| nessita | alecu: ah, I remember. Yes, I was able to run the suite, and the following happened: | 21:14 |
| thisfred | dobey +1, got distracted | 21:14 |
| nessita | alecu: the CreateFile error is gone, but now there are tons of failures of triggered events that are not expected | 21:15 |
| alecu | nessita, I see that many tests are throwing an error, and they also are calling add_watch, so it's very likely the same error we saw before. | 21:15 |
| nessita | alecu: highly related to what you and mandel fixed last week, let me paste that | 21:15 |
| dobey | ralsina: you care to review? :) https://code.launchpad.net/~dobey/ubuntuone-installer/install-pages/+merge/70346 | 21:15 |
| ralsina | dobey: sure! it won't happen right away, I have a backlog :-( | 21:16 |
| dobey | you people and your backlogs | 21:16 |
| ralsina | dobey: how's gir+gtk3 treating you? | 21:16 |
| nessita | alecu: so I'm guessing the windows-version of the file system monitor is not quite working as syncdaemon expects it | 21:16 |
| dobey | ralsina: eh, i changed the way the code works, so the crash i was hitting with gir+gtk2 doesn't happen even on gtk2 any more :) | 21:17 |
| nessita | alecu: http://pastebin.ubuntu.com/658235/ | 21:17 |
| nessita | apparently event order is very important (which makes sense) and somehow the windows version is emitting events in a different order | 21:18 |
| alecu | nessita, I'm getting 9 errors on the first run. I don't this means much :-) | 21:18 |
| nessita | alecu: 9 errors on which test module? | 21:18 |
| alecu | nessita, on test_action_queue.py | 21:19 |
| alecu | nessita, so: yes, between 5 and 20 :-) | 21:19 |
| nessita | alecu: right. So, let's put test_action_queue in the failing tests queue, and let's focus on test_eq_inotify. I think that if we don't get the proper events, is not worth it to debug other modules | 21:20 |
| alecu | sounds reasonable. | 21:21 |
| nessita | the proper events from event queue that gets events from filesystemmonitor | 21:21 |
| nessita | alecu: can I put that fixing in your plate? I'm reporting a proper bug for that | 21:21 |
| alecu | nessita, I think I don't understand. My guess is that we won't be able to have windows returning the events in a different order. | 21:22 |
| nessita | alecu: then we have serious issues, since the syncdaemon logic depends on events in a given order | 21:23 |
| nessita | alecu: "more" serious issues than before, let's say | 21:23 |
| dobey | alright, well i am off. good evening all! | 21:24 |
| ralsina | nessita, alecu, dobey, I have to stop again, I'll put another half-a-day late tonight, so leave me review requests or whatever here or on email :-( | 21:24 |
| nessita | ralsina: isn't more realistic that you take half day off? putting 4 hours at night may not be good for you health | 21:24 |
| dobey | ralsina: just the one i already linked needs one more review. :) | 21:24 |
| dobey | cheers | 21:24 |
| ralsina | dobey, you will have it before you login tomorrow | 21:25 |
| ralsina | nessita: I'll put two and take two for tomorrow then :-) | 21:25 |
| nessita | alecu: you passed out after my events comment? | 21:29 |
| alecu | nessita, I probably should | 21:30 |
| nessita | alecu: did you take a look to the output I linked? | 21:32 |
| alecu | nessita, I've just found another bug with add_watch | 21:32 |
| alecu | nessita, yes, I looked at the output, and I've been following the code | 21:32 |
| nessita | alecu: oh, nice | 21:33 |
| alecu | nessita, the thing is that if we add two watches on the same path, very closely on time, it will fail | 21:33 |
| nessita | hum | 21:33 |
| nessita | alecu: I think I should submit my branch that fixes tons of failures so we can work on fixing"new stuff"... | 21:33 |
| alecu | nessita, this may impact your branch. | 21:34 |
| nessita | alecu: you proposing doing the other way around? | 21:34 |
| alecu | nessita, because the first add_watch will return a deferred that will be fired when the watch *is running*. But the second call will return a defer.succeed(True) | 21:34 |
| nessita | :-( | 21:34 |
| alecu | it should be *waiting* for the watch to be running too. | 21:34 |
| nessita | indeed | 21:35 |
| alecu | so, threads. | 21:35 |
| alecu | I hate them. | 21:35 |
| * nessita hates them too | 21:35 | |
| alecu | nessita, go ahead, propose your branch. | 21:35 |
| nessita | alecu: ok | 21:35 |
| === m_conley is now known as m_conley_away | ||
| nessita | alecu: this the merge proposal, most changes are in tests https://code.launchpad.net/~nataliabidart/ubuntuone-client/fix-tests/+merge/70373 | 22:09 |
| nessita | alecu: please do not get scared by the length of the branch :-/ | 22:09 |
| nessita | ralsina: you around? | 22:09 |
| nessita | ok, I'm gone for today | 22:15 |
| nessita | bye all! | 22:15 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!