| rogerk_ | I seem to have a problem with some stuff in my One-folder being synched, and some not. For example moved a couple of folder into another, those were not synched. Renamed a folder at the same location, that gets synched. | 07:33 |
|---|---|---|
| rogerk_ | renamed one of the moved folders, that one got synched properly, but still not the other one. | 07:34 |
| somethinginteres | hi all, just did a reinstall of my netbook. Trying to sync files from the cloud., My local Documents folder is empty, it says sync is up to date but won't let me sync | 08:06 |
| somethinginteres | "this folder cannot be syncronized because it contains one or more folders that are already syncronised" | 08:07 |
| somethinginteres | sorry got disconnected. Any solutions? | 08:19 |
| JamesTait | Buenos dias! | 08:36 |
| somethinginteres | tried removing my PC, removing the password from the Passwords & Encryption Keys section. Still no luck. Says I'm already synced u1sdtool --status shows everything as fine | 08:39 |
| duanedesign | somethinginteres: hello | 09:07 |
| somethinginteres | duanedesign: hi | 09:08 |
| duanedesign | somethinginteres: can you run the command : u1sdtool --list-folders | 09:14 |
| somethinginteres | duanedesign: http://paste.ubuntu.com/658537/ | 09:17 |
| duanedesign | somethinginteres: ok. Your Documents folder is set to sync with Ubuntu One. However Subscribed is set to False. So it will not sync | 09:20 |
| duanedesign | you are wanting to make this Documents folder a cloud folder, crrect? | 09:21 |
| somethinginteres | duanedesign: how do I subscribe it? I've tried right click "Ubuntu One --> Sync" that doesn't fix it. | 09:21 |
| duanedesign | ok | 09:21 |
| somethinginteres | duanedesign:: I am wanting to d/l my files from the cloud to my PC | 09:21 |
| somethinginteres | duanedesign: from my cloud "Documents" folder to my local | 09:22 |
| duanedesign | did you copy any of the contents of your old computers Home directory to this new computer? | 09:23 |
| somethinginteres | duanedesign: nope, this is a fresh install | 09:23 |
| duanedesign | ok, ust making sure | 09:23 |
| duanedesign | just* | 09:24 |
| duanedesign | u1sdtool --subscribe-folder=24637050-d981-49f7-bdfd-00ec310c24f4 | 09:24 |
| duanedesign | can you run that command | 09:25 |
| somethinginteres | duanedesign: run the cmd. No error or other output | 09:25 |
| duanedesign | somethinginteres: what version of Ubuntu? | 09:25 |
| somethinginteres | duanedesign: 11.04 | 09:25 |
| duanedesign | good | 09:25 |
| somethinginteres | duanedesign: the error I spoke of before has disappeared. The folder is empty but the sync tickbox on the ribbon is now not ghosted out | 09:26 |
| somethinginteres | I believe a sync is taking place | 09:26 |
| duanedesign | we could of also acheived that by opening the Ubuntu One control Panel, selecting Cloud Folders | 09:26 |
| duanedesign | and ticking the box next to Documents | 09:27 |
| duanedesign | can you runt he command: u1sdtool --waiting | wc -l | 09:27 |
| somethinginteres | duanedesign: Output is "1014" | 09:27 |
| duanedesign | ok, that is how many items are now queued to sync | 09:28 |
| somethinginteres | duanedesign: OK may take some time. :) Any insight into why it thought the folder contained synced files? | 09:28 |
| somethinginteres | duanedesign: Also I need to disconect very shortly, will disrupting this proccess cause a problem? | 09:29 |
| duanedesign | somethinginteres: it is a poorly worded error. It just means this folder is set to sync | 09:30 |
| somethinginteres | duanedesign: Right | 09:30 |
| duanedesign | your are definetly not the first confused by it :) I need to make sure their is a bug filed on that | 09:31 |
| somethinginteres | duanedesign: : safe to disconnect at this point? | 09:31 |
| somethinginteres | duanedesign: ah, I see :) | 09:31 |
| duanedesign | somethinginteres: yes you should be fine now. If you have any other problems let me know | 09:32 |
| somethinginteres | duanedesign: Will do. Thanks very much. | 09:32 |
| duanedesign | o/ | 09:32 |
| duanedesign | rogerk_: just saw you needed help. I am going to step out for 45 minutes. I can help when I get back. | 09:33 |
| rogerk_ | duanedesign: Oh, nice, thanks! I'm at work so might not be available at that time, but I'll try to sync up at some time after that. :-) | 09:38 |
| DiegoSarmentero | hi everyone | 10:18 |
| fagan | hey DiegoSarmentero | 10:18 |
| duanedesign | rogerk_: no problem just ping me | 10:32 |
| duanedesign | hello fagan DiegoSarmentero | 10:32 |
| DiegoSarmentero | hi duanedesign fagan | 10:32 |
| DiegoSarmentero | how are you this morning? (morning for me :P) | 10:33 |
| fagan | hey duanedesign | 10:33 |
| duanedesign | DiegoSarmentero: doing well. Trying to decide on a new laptop. too many choices :/ | 10:34 |
| DiegoSarmentero | duanedesign, alienware! :P | 10:35 |
| fagan | duanedesign: id suggest lenovo | 10:35 |
| duanedesign | fagan: i think i narrowed it down to lenovo or system76 | 10:36 |
| fagan | duanedesign: I cant buy system76 so never was an option | 10:36 |
| fagan | I have a acer desktop, msi wind netbook and a macbook | 10:36 |
| duanedesign | fagan: the first lenovo model I looked at did not have usb3.0, though I do not know if i would even miss it | 10:36 |
| fagan | duanedesign: yeah you dont really need usb 3 yet | 10:37 |
| fagan | nearly everything is still usb 2 | 10:37 |
| * duanedesign nods | 10:37 | |
| duanedesign | the model w/ out 3.0 usb is about $300-400 cheaper | 10:37 |
| fagan | then its an easy choice | 10:38 |
| duanedesign | and the more expensive model has a graphics card that uses Optimus | 10:38 |
| duanedesign | though I hear lenovo has a setting in the bios to deal with this. | 10:38 |
| fagan | duanedesign: interesting do you play games or do anything graphically difficult? | 10:40 |
| * fagan has a nvidia card that cost an arm and a leg but I play lots of games so was an investment | 10:40 | |
| duanedesign | occasionaly...but not often. | 10:40 |
| fagan | duanedesign: well then the optimus thing isnt really a huge priority if you dont :) | 10:41 |
| duanedesign | Just enough that i am interested in a graphics card. But not often enough to really make it essential | 10:41 |
| duanedesign | :P | 10:41 |
| duanedesign | fagan: I think you are right | 10:41 |
| fagan | duanedesign: well if it was me id be cheaping out :) | 10:41 |
| duanedesign | fagan: considering technology becomes old so fast it is hard to justify spending too much money | 10:43 |
| duanedesign | knowing you wil have to but a new computer in 3 years | 10:43 |
| duanedesign | fagan: do you run Ubuntu on your macbook? | 10:44 |
| fagan | duanedesign: well im a funny person when it comes to moores law, I say get an ok computer and just replace it often it costs about the same in the long run | 10:44 |
| fagan | duanedesign: yeah I do but im not using it at the moment | 10:44 |
| fagan | im on Mac OS | 10:44 |
| fagan | But its pretty easy to dual boot | 10:44 |
| fagan | I have to say the keyboard is bloody nice to use | 10:45 |
| duanedesign | :) | 10:45 |
| duanedesign | the macbooks are down right sexy | 10:45 |
| fagan | duanedesign: have you thought about getting a desktop? | 10:46 |
| fagan | and then getting a netbook | 10:46 |
| fagan | so you can have something to travel with | 10:46 |
| fagan | that worked out so well for me | 10:46 |
| fagan | Although my netbook was a little trash | 10:46 |
| duanedesign | fagan: yeah, not a terrible idea. Would be nice to have something more portable then a 6 pound laptop | 10:47 |
| fagan | duanedesign: well desktops seem to keep their value longer because they have faster processors and better graphics cards | 10:48 |
| fagan | and they are cheaper | 10:48 |
| * duanedesign nods | 10:48 | |
| fagan | so I paid 500 euro for my desktop it has 4 processors and a great graphics card | 10:49 |
| fagan | and a netbook that cost 250 and it makes up for the fact I cant move my desktop | 10:49 |
| fagan | and 750 is cheaper than most netbooks with similar specs | 10:50 |
| duanedesign | fagan: ahhh, more choices :) | 10:51 |
| duanedesign | fagan: i will look at that...sounds reasonable | 10:52 |
| fagan | duanedesign: well I love complicating things for other people :D | 10:52 |
| * fagan errands | 11:00 | |
| * fagan back | 11:27 | |
| nessita | hello all! | 11:35 |
| nessita | ralsina: ping | 11:35 |
| DiegoSarmentero | nessita, hello | 11:36 |
| nessita | hi DiegoSarmentero, how is it going? yes, I'm doing your reviews now :-) | 11:38 |
| DiegoSarmentero | nessita, jejejee i'm fighting with page 18 of the installer :@..... | 11:40 |
| nessita | DiegoSarmentero: question, why did you add the #pylint: disable=C0103 and the enable comment for set_title and set_subtitle? | 11:40 |
| DiegoSarmentero | nessita, ahhhhhhhhh my bad...... that methods were first setTitle and setSubTitle... but then I realize that setTitle and setSubTitle only were neeeded on SSOWizardPage | 11:41 |
| DiegoSarmentero | changing... | 11:41 |
| nessita | DiegoSarmentero: thanks! | 11:42 |
| DiegoSarmentero | nessita, done | 11:46 |
| nessita | DiegoSarmentero: another question, why do you call | 11:46 |
| nessita | self.controller._title = JOIN_HEADER_LABEL % {'app_name': self.app_name} | 11:46 |
| nessita | self.controller._subtitle = self.help | 11:46 |
| nessita | at the beginning of the test_titles if you later call set_title and set_subtitle in the same test? | 11:46 |
| nessita | same question for ErrorControllerTestCase.test_set_ui | 11:47 |
| DiegoSarmentero | let me check | 11:48 |
| nessita | (and same question for SuccessControllerTestCase.test_set_ui) | 11:48 |
| DiegoSarmentero | nessita, :S yes... self.controller_title, etc is no longer needed... that was from before the second change to user a reimplementation of setTitle... removing..... | 11:50 |
| nessita | DiegoSarmentero: thanks! | 11:50 |
| nessita | DiegoSarmentero: the rest looks great | 11:50 |
| DiegoSarmentero | nessita, i removed some of them, in Error and Success they are needed because the method setupUI actually use _title and _subtitle so i have to set that values in the controller | 11:54 |
| DiegoSarmentero | so i need to set that values, and call then set_title and set_subtitle to record the execution | 11:54 |
| DiegoSarmentero | nessita, done | 11:56 |
| nessita | DiegoSarmentero: looking | 11:56 |
| nessita | DiegoSarmentero: hum, is there any chance you push any extra changes? I think I'm seeing something I did not see before, but maybe I was too sleepy 5 minutes ago :-P. What I see that I don't like is the duplication of the def set_title(self, title='') and def set_subtitle(self, subtitle='') | 12:00 |
| nessita | DiegoSarmentero: what we talked with ralsina was not to duplicate that code anywhere, but defining it in a single class | 12:00 |
| nessita | DiegoSarmentero: I personally would like to have that as another widget, but he mentioned it may be overkill doing it that way. Anyway, the requirement is that the logic is not duplicated anywhere, so if you find yourself writing the same piece of code twice, we need to refactor | 12:01 |
| DiegoSarmentero | nessita, ok... i didn't in that way... because i wasn't sure if EVERY page is will have a title and subtitle... but it is a easy fix | 12:03 |
| DiegoSarmentero | is going to* | 12:03 |
| nessita | DiegoSarmentero: well, you can make some pages inheriting this "new title'd class" and some other no, right? | 12:03 |
| DiegoSarmentero | nessita, yes, we could have two different SSOWizardPage... let me make the change and test if it doesn't broke anything and i will be pushing it in a few minutes | 12:05 |
| DiegoSarmentero | nessita, meanwhile... is syncdaemon working? i keep receiving an error when i try to sync the folders in the installer | 12:05 |
| nessita | DiegoSarmentero: no two different SSOWizardPage... but 2 different base class and having mulitple inheritance? | 12:06 |
| nessita | DiegoSarmentero: what error? | 12:06 |
| ralsina | good morning | 12:06 |
| DiegoSarmentero | ralsina, good morning | 12:07 |
| nessita | hi ralsina | 12:07 |
| DiegoSarmentero | nessita, http://paste.ubuntu.com/658606/ | 12:07 |
| nessita | ralsina: any news regarding the review I sent to you yesteday? | 12:07 |
| nessita | DiegoSarmentero: is syncdaemon running in that machine? | 12:08 |
| ralsina | nessita: finally I followed your advice and took the night off, so starting it now | 12:08 |
| DiegoSarmentero | nessita, i'm running the sso-client without any problem, but when syncdaemon keeps giving me this error: http://paste.ubuntu.com/658608/ | 12:10 |
| nessita | DiegoSarmentero: the sso you're pointing to syncdaemon is ols? | 12:11 |
| nessita | old*? | 12:11 |
| DiegoSarmentero | nessita, i updated it yesterday | 12:11 |
| DiegoSarmentero | both | 12:11 |
| nessita | DiegoSarmentero: try this: | 12:11 |
| nessita | set PYTHONPATH=..\ubuntu-sso-client | 12:12 |
| nessita | python | 12:12 |
| nessita | from ubuntu_sso.main.windows import UbuntuSSOClient | 12:12 |
| nessita | and let me know how it goes | 12:12 |
| DiegoSarmentero | ok | 12:12 |
| DiegoSarmentero | nessita, ImportError: No module named ubuntu_sso.main.windows (I'm inside ubuntuone-client) | 12:15 |
| DiegoSarmentero | nessita, wait!.... | 12:17 |
| DiegoSarmentero | nessita, nevermind....... | 12:17 |
| DiegoSarmentero | found the problem | 12:18 |
| nessita | DiegoSarmentero: what was it? | 12:20 |
| DiegoSarmentero | nessita, it was pointing to another branch of sso-client :( | 12:20 |
| oimon | hello. i have a folder in ubuntu one folder which is showing the refreshing icon, but u1sdtool thinks it is up to date. website doesn't show the file - how can i fix? | 12:35 |
| fagan | duanedesign: ^ | 12:44 |
| ralsina | nessita: +1 on the epic branch! | 12:44 |
| nessita | ralsina: great! thanks! | 12:45 |
| duanedesign | hello oimon | 12:45 |
| oimon | i also have other folders that i've copied into u1 folder that do sync with the website but still show refreshing icon on the folder, even when it's synced | 12:45 |
| ralsina | I mean +1 as soon as I finish reading the test changes, but the main stuff looks great | 12:45 |
| duanedesign | oimon: what do you get when you run the Terminal command: u1sdtool --waiting | wc -l | 12:46 |
| nessita | ralsina: is ok, I still need to wait for alecu | 12:46 |
| oimon | duanedesign: i'm on lucid | 12:46 |
| oimon | waiting-content and metadata are both 0 lines | 12:46 |
| duanedesign | oimon: ok | 12:46 |
| ralsina | nessita: could you take a look at https://code.launchpad.net/~ralsina/ubuntu-sso-client/validate-harder/+merge/70320 ? It's very boring ;-) | 12:46 |
| nessita | ralsina: sure | 12:47 |
| oimon | duanedesign: my home dir is mounted over NFS, not sure if that is relevant at all | 12:48 |
| nessita | ralsina: in _validate, shouldn't you call is_correct_password? | 12:48 |
| ralsina | nessita: in which one? | 12:48 |
| nessita | the first one | 12:48 |
| duanedesign | oimon: could you check if this file has anything in it: ~/.cache/ubuntuone/log/syncdaemon-exceptions.log | 12:48 |
| ralsina | nessita: I am not calling intentionally, because suppose someday we change the password requirements, that would mean you can't login with the old password | 12:49 |
| oimon | duanedesign: nope, the exceptions log files are all 0 butes | 12:49 |
| ralsina | oh, wait, that one is the forgtten password. Yes, on that one I should | 12:50 |
| nessita | ralsina: is that validation for login or forgotten password? | 12:50 |
| beuno | nessita, ralsina, that is already the case. My existing SSO password doesn't conform to the nre guidelines | 12:50 |
| nessita | ah, that | 12:50 |
| beuno | *new | 12:50 |
| beuno | we did that in Android and had to revert it | 12:50 |
| duanedesign | oimon: ok. can you check what you get with the command: u1sdtool -s | 12:50 |
| nessita | beuno: right, for login it makes no sense, but for password change it does | 12:50 |
| ralsina | nessita: tke it back, the first one is "Sign In", on that one we should not call it. | 12:50 |
| duanedesign | oimon: and pastebin the contents at http://pastebin.ubuntu.com/ | 12:50 |
| oimon | http://pastebin.ubuntu.com/658624/ | 12:51 |
| ralsina | nessita and that is there, in line 124 | 12:51 |
| nessita | ralsina: ok. Another thing, suffixing number in variable/method/test cases is not recommended since when reading, is confusing what does it mean. Can you please change CurrentUserControllerTest2 to something more explicit? probably CurrentUserControllerValidationTestCase | 12:52 |
| duanedesign | oimon: hmm. ok, could you please post the syncdaemon log ~/.cache/ubuntuone/log/syncdaemon.log | 12:54 |
| oimon | duanedesign: here's a summary of the situation. copied 1 folder (.liferea_1.6) from another pc with the same home dir mounted via NFS. this doesn't appear on website. then on my main PC , copied "building" and ".liferea_1.2" which do appear on website but still show refresh icon as per http://i.imgur.com/zkJ0c.png | 12:54 |
| ralsina | nessita: Now it's about validation but I want to do any new tests there instead of with mocker. I'll figure out a generic name. | 12:55 |
| nessita | ralsina: ideally you should have a dedicated testcase for each "grouping" of functionality being tested. Is common to group into a validation tests vase | 12:55 |
| nessita | test case* | 12:55 |
| nessita | ralsina: so I would advice a validation test case and then add any other needed test case | 12:55 |
| nessita | with a accurate name | 12:56 |
| ralsina | Cool, will do that then | 12:56 |
| nessita | great | 12:56 |
| duanedesign | oimon: yeah the nautilus integration in Ubuntu One is less then ideal in Lucid. So the emblems are sometimes not very accurate | 12:57 |
| oimon | yeah i've also had nautilus crashes with u1 too | 12:58 |
| oimon | duanedesign: so back to the original issue, could it be because i copied the folder while on another machine? u1 should still poll the directory though? | 12:59 |
| duanedesign | .2 | 13:00 |
| nessita | ralsina, alecu, dobey, DiegoSarmentero, mandel, fagan: standup! | 13:00 |
| nessita | me | 13:00 |
| DiegoSarmentero | me | 13:00 |
| dobey | me | 13:00 |
| ralsina | me | 13:00 |
| fagan | me | 13:01 |
| nessita | ralsina: I know no mandel today, but we do have an alecu today, right? | 13:01 |
| nessita | DiegoSarmentero: have you tried to register "gato" as your irc nickname? | 13:01 |
| ralsina | nessita, AFAIK yes | 13:02 |
| nessita | DiegoSarmentero: you current one is too long to type it in the daily stand up! | 13:02 |
| DiegoSarmentero | nessita, no... i will try! :P | 13:02 |
| nessita | DONE: finished and proposed epic branch | 13:02 |
| nessita | TODO: hunt reviews for epic branch, do reviews for Diego and ralsina, propose old branch with controlpanel ui improvements | 13:02 |
| nessita | BLOCKED: nopes | 13:02 |
| nessita | NEXT: DiegoSarmentero | 13:02 |
| DiegoSarmentero | DONE: | 13:02 |
| DiegoSarmentero | Some refactoring in the use of Title and Subtitle | 13:02 |
| DiegoSarmentero | TODO: | 13:02 |
| DiegoSarmentero | Finish Pages: 18 and 19 from Wizard. Fix UI bugs from installer | 13:02 |
| DiegoSarmentero | BLOCKED: | 13:02 |
| DiegoSarmentero | no | 13:02 |
| DiegoSarmentero | dobey, go | 13:02 |
| dobey | λ DONE: yet more shim work | 13:03 |
| dobey | λ TODO: finish initial shim | 13:03 |
| dobey | λ BLCK: None. | 13:03 |
| dobey | ralsina: go | 13:03 |
| ralsina | DONE: half day off, windows call, reviews, proposed a couple of branches. TODO: IRL testing and bug reporting, BLOCKED: no | 13:04 |
| ralsina | fagan go | 13:04 |
| fagan | DONE | 13:04 |
| fagan | * more report for college | 13:04 |
| fagan | TODO | 13:04 |
| fagan | * Finish the report | 13:04 |
| fagan | * If anyone needs anything do that | 13:04 |
| fagan | Blocked | 13:04 |
| fagan | * nope | 13:04 |
| fagan | comments? | 13:04 |
| nessita | is cooold! | 13:04 |
| fagan | Its hot in ireland | 13:04 |
| fagan | or maybe its the flu im coming down with | 13:05 |
| === DiegoSarmentero is now known as gato | ||
| fagan | gato: new nick? | 13:05 |
| gato | fagan, yep... shorter... and it is an usual nickname for me :P | 13:06 |
| fagan | gato: well everything is just letter tab so it doesnt really matter about length | 13:06 |
| nessita | gato: congrats on the nickname! (?) | 13:07 |
| gato | nessita, jejeje | 13:07 |
| dobey | lol | 13:07 |
| dobey | gato gordo? :) | 13:07 |
| fagan | Ok thats what she said (in honor of mandel) | 13:07 |
| fagan | about my last statement | 13:07 |
| gato | jejeje | 13:07 |
| alecu | hello #ubuntuone! | 13:08 |
| gato | dobey, trying not to be fat!! :P | 13:08 |
| gato | hello alecu | 13:08 |
| alecu | sorry I'm late; me (no notes) | 13:08 |
| * fagan break | 13:08 | |
| nessita | gato: so, can you please refresh my memory regarding what we talked in the plane about setting properties to widgets? | 13:08 |
| nessita | alecu: go!!! | 13:08 |
| alecu | hola gato! got new nick? | 13:08 |
| dobey | hehe | 13:08 |
| gato | alecu, yep :P | 13:08 |
| gato | nessita, yes, you can do it in the designer in the property editor.... or just through code: setProperty("stringId", value) | 13:09 |
| gato | brb | 13:10 |
| alecu | DONE: worked on bug #820350, perhaps found a simple solution | 13:11 |
| alecu | TODO: discuss a better solution for the above bug, review new issues with bug #803672 | 13:11 |
| alecu | BLOCKED: no | 13:11 |
| ubot4 | Launchpad bug 820350 in ubuntuone-client "WIndows: either set_dir_readwrite and/or set_dir_readonly are not doing what they should (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/820350 | 13:11 |
| ubot4 | Launchpad bug 803672 in ubuntuone-client (Ubuntu) (and 2 other projects) "Do not start two instances of this process (affects: 2) (heat: 22)" [Undecided,Invalid] https://launchpad.net/bugs/803672 | 13:11 |
| alecu | nessita, still needing the epic review? | 13:11 |
| nessita | alecu: yes please, a lot | 13:12 |
| * alecu rolls up his sleeves | 13:12 | |
| nessita | alecu: thanks!!! | 13:12 |
| === m_conley_away is now known as m_conley | ||
| === DiegoSarmentero is now known as gatox | ||
| * gatox sad... gato was already in use | 13:20 | |
| nessita | gatox: chem, help. How can I set in a stylesheet something equivalent to self.setLayoutDirection(QtCore.Qt.RightToLeft)? | 13:22 |
| * gatox looking... | 13:23 | |
| gatox | nessita, why you need to do that in qss? | 13:24 |
| fagan | gatox: sounds sharper | 13:24 |
| gatox | fagan, :P | 13:24 |
| gatox | nessita, i think you can't do that with stylesheet :S | 13:25 |
| nessita | gatox: no problem then | 13:25 |
| rogerk_ | duanedesign: I was dragged into a rather lengthy meeting, but now I'm available. Are you? | 13:34 |
| gatox | ralsina, do yu have a minute? | 13:35 |
| ralsina | gatox: sure | 13:36 |
| gatox | ralsina, is there any reason why "SuccessController" in gui.py (sso-client) doesn't extend from "BackendController" as the others? | 13:36 |
| gatox | just to know.... because it will be better for something that i'm testing to make all of them extend from BackendController | 13:37 |
| ralsina | gatox: probably just a mistake | 13:37 |
| gatox | ralsina, great...... i will modify it! :D | 13:38 |
| duanedesign | rogerk_: yes | 13:43 |
| duanedesign | rogerk_: what version of Ubuntu are you on? | 13:43 |
| rogerk_ | duanedesign: 11.04 | 14:02 |
| nessita | ralsina, alecu, Chipaca, gatox: shall we mumble? | 14:03 |
| gatox | nessita, ack | 14:04 |
| nessita | alecu: che, I can't make syncdaemon start, I'm getting a CannotListenError (http://pastebin.ubuntu.com/658660/). I don't have any other instance running, and I never installed a installer in this vm | 14:05 |
| nessita | alecu: any ideas? | 14:05 |
| alecu | weirddddd | 14:05 |
| alecu | nessita, trunk_ | 14:05 |
| alecu | nessita, trunk? | 14:05 |
| nessita | alecu: my branch, let me confirm trunk | 14:06 |
| alecu | nessita, this looks suspicious: self.dbus_iface.shutdown(with_restart) | 14:06 |
| alecu | nessita, that's from the paste. | 14:06 |
| alecu | nessita, very likely that shutdown is not stopping the ipc listener before restarting | 14:07 |
| alecu | nessita, do you know why is syncdaemon trying to restart? | 14:07 |
| nessita | alecu: the dbus_iface is code located in ubuntuone/platform/windows/__init__.py | 14:08 |
| duanedesign | nessita: could you take a look at this https://pastebin.canonical.com/50744/ | 14:08 |
| alecu | nessita, right. But did you tell syncdaemon to restart? | 14:08 |
| duanedesign | nessita: do you know what package is missing | 14:09 |
| alecu | nessita, look at this, also from your paste: self.main.restart() | 14:09 |
| nessita | alecu: not at all, I'm looking at the logs to see what happened | 14:09 |
| nessita | alecu: there was a SYS_UNKNOWN_ERROR pushed to the state machine, which triggers a restart | 14:10 |
| duanedesign | rogerk_: can you run the command: u1sdtool --waiting | wc -l | 14:10 |
| nessita | becasue there was a transition Transition SET_CAPABILITIES --[SYS_SET_CAPABILITIES_OK]--> AUTHENTICATE, which makes no sense! | 14:11 |
| nessita | alecu: I'll debug further, sorry for pinging you so early | 14:11 |
| nessita | duanedesign: looking | 14:11 |
| alecu | nessita, I don't understand that, but do you know how we can "simulate" this to reproduce this error? | 14:11 |
| nessita | alecu: the restart is pretty easy to simulate in a test | 14:12 |
| nessita | alecu: this particular transition makes no sense | 14:12 |
| alecu | nessita, anyway, it's very likely that restarts are broken at the ipc level. | 14:12 |
| nessita | duanedesign: what system is that? | 14:12 |
| nessita | alecu: Oh. Syncdaemon uses restart when in despair | 14:12 |
| nessita | alecu: in trunk, syncdaemon will not move from READY, even if the SSO service returns the credentials :-/ | 14:14 |
| duanedesign | nessita: they are running 10.10, but i think they might be using a PPA version of U1 | 14:22 |
| nessita | duanedesign: looks like they are missing the gir-1.<something>-unity-<something> package | 14:27 |
| rogerk_ | duanedesign: result i 0. | 14:27 |
| nessita | ralsina: so, are we mumbling today? | 14:30 |
| duanedesign | rogerk_: have you tried restarting the syncdaemon to see if that helps. the command would be" u1sdtool -q; u1sdtool -c | 14:32 |
| nessita | ralsina: ping? | 14:34 |
| nessita | alecu: in trunk syncdaemon is also transitioning from [SYS_SET_CAPABILITIES_OK]--> AUTHENTICATE :-/ | 14:34 |
| nessita | alecu: is it working for you/ | 14:34 |
| nessita | ? | 14:34 |
| ralsina | sorry, was afk | 14:35 |
| ralsina | I don't think we have much news since yesterday, do we/ | 14:35 |
| alecu | nessita, let me check | 14:35 |
| nessita | ralsina: we can skip the mumble, but I want to be sure you and Chipaca know that we're getting behind schedule | 14:36 |
| nessita | ralsina: and that ATM, syncdaemon is not working for me, still debugging why | 14:36 |
| nessita | alecu: actually, the problem is not that transition but the SYS_UNKNOWN_ERROR taht is pushed after that | 14:37 |
| ralsina | nessita: I know we are behind, I will make sure Chipaca knows too | 14:37 |
| ralsina | BTW: on linux: ['/home/ralsina/.config/ubuntuone', '/etc/xdg/ubuntuone'], on windows: ['/.config\\ubuntuone'] yikes | 14:37 |
| nessita | ralsina: one of the things that worry me most, today, is the thing I mentioned about events out of order/missing/etc in the email from eysterday | 14:38 |
| ralsina | Yes, that is really bad, and new :-( | 14:39 |
| nessita | ralsina: well, is new becasue before the fsm tests were not run because all the issues with threads that alecu and mandel fixed last week | 14:43 |
| alecu | nessita, found the issue in trunk: | 14:43 |
| ralsina | nessita, the config file location problems for syncdaemon are because xdg is (as usual) broken for windows. I am going to reimplement some pieces of it like you did for xdg_cache_home | 14:43 |
| alecu | 2011-08-04 11:38:39,907 - ubuntuone.SyncDaemon.ActionQueue - INFO - The request | 14:43 |
| alecu | 'oauth_authenticate' failed with the error: oauth_authenticate() takes exactly 3 | 14:43 |
| alecu | arguments (4 given) and was handled with the event: SYS_UNKNOWN_ERROR | 14:43 |
| nessita | alecu: yeah, I just saw that too :-/ | 14:43 |
| nessita | I think there was an update i storage protocol | 14:43 |
| nessita | that I don't have | 14:43 |
| nessita | indeed: Now on revision 136. | 14:44 |
| alecu | nessita, yup, it looks like that. | 14:44 |
| nessita | ralsina: there was a new update to storage protocol, and is mandatory for u1client to work, FYI (for the installer) | 14:45 |
| nessita | alecu: thanks a lot :-) | 14:45 |
| alecu | this sucks | 14:45 |
| nessita | alecu: how's the review going? | 14:45 |
| nessita | ralsina: same question ^ | 14:45 |
| alecu | nessita, almost there | 14:45 |
| ralsina | So we all need to update ubuntuone-storage-protocol? | 14:45 |
| nessita | ralsina: and re build and re install | 14:45 |
| ralsina | nessita: I gave you the +1 a while ago, forgot to mention it | 14:45 |
| nessita | gatox: ^ | 14:45 |
| nessita | ralsina: thanks! | 14:45 |
| alecu | nessita, why re-build? | 14:46 |
| gatox | nessita, update storage? | 14:46 |
| gatox | or something else? | 14:46 |
| gatox | ahhhh ok..... | 14:46 |
| nessita | alecu: python setup.py build install? | 14:47 |
| gatox | updating...... | 14:47 |
| alecu | nessita, I think that just "python setup.py install" in ubuntuone-storage-protocol should be enough | 14:47 |
| nessita | alecu: maybe, I never knew exactly what's build for :-D | 14:47 |
| alecu | nessita, I think that "install" depends on "build", and does it automatically if needed. | 14:47 |
| nessita | alecu: is working now!!! :-) | 14:50 |
| ralsina | nessita, alecu: basically every line in xdg.BaseDirectory is broken. Should I just rewrite it? | 14:54 |
| alecu | nessita, really? got a pointer to the code? | 14:55 |
| alecu | I mean, ralsina. | 14:55 |
| ralsina | I can't copy it into our tree because of copyright assignments, right? | 14:55 |
| alecu | ralsina, I think we can't, right. | 14:55 |
| nessita | ralsina: we can't | 14:55 |
| nessita | ralsina: why every line is broken? | 14:55 |
| ralsina | alecu: let me pastebin it | 14:56 |
| nessita | ralsina: syncdaemon only uses | 14:56 |
| nessita | 30 load_config_paths, | 14:56 |
| nessita | 31 save_config_path, | 14:56 |
| nessita | 32 xdg_data_home, | 14:56 |
| nessita | 33 xdg_cache_home, | 14:56 |
| nessita | ralsina: so we need only that | 14:56 |
| ralsina | alecu, nessita: http://pastebin.ubuntu.com/658675/ | 14:56 |
| ralsina | because everything assumes it's linux | 14:56 |
| ralsina | and it's not that big beyond what syncdaemon uses. I would reimplement just those bits | 14:56 |
| ralsina | it uses the wrong separators, home by default is "/" (literally) | 14:57 |
| nessita | ralsina: it does not look sooo-linux specific, it uses os.path.join | 14:57 |
| nessita | this is home: os.environ.get('HOME', '/') | 14:57 |
| alecu | nessita, it | 14:58 |
| alecu | it's pretty much linux specific: | 14:58 |
| alecu | split(':') | 14:58 |
| ralsina | nessita: all the paths by default have "/" in them | 14:58 |
| ralsina | yes, on windows there is no $HOME | 14:58 |
| ralsina | it splits paths using ":" instead of os.PATHSEP | 14:58 |
| alecu | and also it's getting everything from the XDG_* env vars, that will not be set on a windows. | 14:59 |
| nessita | alecu, ralsina: all that is already fixed in our implementation, we only need load_config_paths to work | 14:59 |
| nessita | alecu: we have all that fixed already | 14:59 |
| ralsina | in windows I have to do like get_special_folders. So I don't think any of the parts we use is actually correct for windows. It's not big though | 15:00 |
| alecu | nessita, ok. where is that? already in our tree? | 15:00 |
| nessita | and perhaps save_config_path | 15:00 |
| alecu | nessita, or in mandels +junk? | 15:00 |
| nessita | alecu: yes, platform/xdg_base_directory | 15:00 |
| ralsina | load_config_paths uses everything else | 15:00 |
| ralsina | nessita: so yes, I will add those two there | 15:01 |
| alecu | cool | 15:01 |
| nessita | ralsina: I forgot about you review after I mentioned the name change for the testcase, restarting it now. Can you please add an ending dot to """Tests for CurrentUserController, but without Mocker""" | 15:02 |
| ralsina | sure | 15:09 |
| CardinalFang | Tracking Oneiric has been the most painful dogfood-eating release cycle I've seen yet. :( | 15:10 |
| ralsina | nessita: pushed the "." | 15:11 |
| nessita | ralsina: all the '.'? I see that several tests cases have the same docstring | 15:11 |
| ralsina | je, no, just the one you mentioned, will fix that in 1' | 15:12 |
| nessita | ralsina: I added a couple of needs fixing and a question | 15:13 |
| nessita | brb | 15:14 |
| ralsina | nessita: cool, thx | 15:14 |
| alecu | nessita, why did you merge test_deleting_open_files_is_no_cause_for_despair and test_stomp_deleted_file_is_no_cause_for_despair_either ? | 15:17 |
| alecu | nessita, nevermind, it's the same test :P | 15:18 |
| nessita | alecu: is the same test! :-) | 15:20 |
| nessita | alecu: I confirmed it with facu | 15:20 |
| alecu | great | 15:21 |
| dobey | gah. found a nice bag, but it's apparently only available in australia | 15:21 |
| nessita | alecu: At first I tried to make it work on windows, but I couldn't, so I just made it more readable and skipped it | 15:21 |
| nessita | dobey: bug or bag? :-D | 15:21 |
| dobey | nessita: camera/laptop bag :) | 15:21 |
| nessita | ah! :-P | 15:21 |
| ralsina | nessita: about the needsfixing, unicode and QStrings compare correctly | 15:25 |
| nessita | ralsina: then why are we coercing to unicode everywhere? | 15:26 |
| nessita | ralsina: either we do it everywhere, or nowhere, otherwise confuses the reader | 15:26 |
| ralsina | QStrings are not unicodes in the sense that you can't use them interchangeably, but you can say if QString == unicode and it does the right thing | 15:27 |
| ralsina | But sure, I will add it, just mentioning it | 15:27 |
| dobey | ok, must get lunch. bbiba | 15:36 |
| dobey | bbiab | 15:36 |
| gatox | ralsina, nessita i've finished with title and subtitle... i've applied several improves in the code i've just submitted... i'm waiting to launchpad to rescan my branches to give you the url... i'll keep working on pages 18 and 19 now | 15:39 |
| nessita | gatox: ack! | 15:39 |
| ralsina | gatox: cool! | 15:40 |
| ralsina | gatox: I just noticed we have a SSOWizardEnhancedEditPage and a SSOWizardPage | 15:42 |
| ralsina | I think we should merge them | 15:42 |
| gatox | ralsina, maybe... it seems that SSOWizardEnhancedEditPage is only being used by SetupAccounnt | 15:42 |
| gatox | ralsina, let me check.... and i will apply that change in this branch too if you want | 15:43 |
| ralsina | gatox: it should be used by every page that has EnhancedLineEdits, and we should use those for all line edits that need validation | 15:43 |
| ralsina | I think that's for another branch not this one :-( | 15:43 |
| gatox | ralsina, ok! better | 15:44 |
| alecu | nessita, a couple of very small need fixings in https://code.launchpad.net/~nataliabidart/ubuntuone-client/fix-tests/+merge/70373 | 15:44 |
| * alecu breathes again | 15:44 | |
| nessita | alecu: looking! | 15:47 |
| gatox | nessita, ralsina both branches are ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/titles-on-pages/+merge/70169 --- https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/titles-on-pages/+merge/70157 | 15:49 |
| ralsina | nessita: responded to your needfixings and fixed them, too. | 15:49 |
| ralsina | gatox: cool! | 15:50 |
| gatox | nessita, at the end of installer changes test_gui.py it appears to have some merge problems... but that changes are not in the file if you download the branch... it might be some merge problem with trunk | 15:50 |
| gatox | i'm looking if i can fix it locally and upload | 15:51 |
| gatox | nessita, ralsina merge problems fixed... the branches are complete | 15:55 |
| ralsina | gatox: the sso branch is much nicer now | 15:56 |
| gatox | ralsina, :D | 15:57 |
| ralsina | gatox: I think we should make BaseController take the optional messagebox, title, subtitle arguments and handle them. They are always used the same, anyway | 15:57 |
| gatox | ralsina, ok....... i will remove it from the specialized controller and pass this arguments to the parent in the super statement | 15:59 |
| nessita | alecu: I used it the or returning a lambda for consistency sake, is how facundobatista does it in other tests. I agree is aweful. | 16:01 |
| nessita | alecu: not sure if preserve consistency or improve some of those only | 16:02 |
| ralsina | gatox: and of course if the __init__ is now just a super, remove it ;-) | 16:02 |
| ralsina | gatox: Then, since the controller always will have a title/subtitle, maybe the SSOWizardPage can just use it and the controller doesn't have to call set_title and whatever. | 16:03 |
| gatox | do you mean moving the initialization of title and subtitle from controller to SSOWizardPage??...... because BackendController is a controller... so it will work as usual in that way | 16:05 |
| gatox | ralsina, ^ | 16:05 |
| gatox | ralsina, but some controllers are using the set_title, because they have another title based on validation or something like that | 16:07 |
| === beuno is now known as beuno-lunch | ||
| ralsina | gato: ok, then how about moving it into the BaseController's __init__? If a specific controller wants to set them different, it does it after super() | 16:08 |
| ralsina | gatox: ^ | 16:09 |
| gatox | ralsina, ok... it almost ready... testing... | 16:10 |
| gatox | it's* | 16:10 |
| ralsina | nessita: use a lambda that return a tuple instead. Slightly cleaner... | 16:14 |
| nessita | ralsina: we don't need two results, but an append and a defer returned. I know how to fix it, I'm not sure I want to break consistency with other tests, but I guess we have to | 16:15 |
| ralsina | nessita: oooook, missed that. If the other tests are the same I say leave it as is. | 16:16 |
| gatox | ralsina, I can't move set_title and set_subtitle from setupUI in controllers to __init__ in BackendControllers, because the header is created after the controller | 16:16 |
| ralsina | gatox it's ok then | 16:17 |
| gatox | ralsina, i could do it maybe in initializePage | 16:17 |
| gatox | ralsina, what do you think? | 16:17 |
| gatox | ralsina, ah..... no, same problem..... | 16:17 |
| gatox | because the controllers are overwriting that method | 16:18 |
| ralsina | nah, we have 3 "sort-of-line-init" methods, leave it as it is | 16:18 |
| ralsina | the controllers are overwriting initializePage????? | 16:18 |
| gatox | SSOWizardPage is overwriting initializePage..... and calling pageInitialize in the controllers... | 16:20 |
| gatox | ralsina, we made this last week | 16:20 |
| gatox | ralsina, do you remember? to handle default buttons | 16:20 |
| ralsina | oh yeah, that | 16:21 |
| ralsina | I just had a code cache overflow :-) | 16:21 |
| gatox | ralsina, i'll try to put set_title there.... just one controller is overwriting this method... do you agree? | 16:21 |
| ralsina | no, let's stop fiddling with this branch, I take that objection back ;-) | 16:23 |
| gatox | ok | 16:23 |
| gatox | i will submit the first modification.... that it is really small..... and its working properly...... | 16:24 |
| nessita | alecu: re: lambdas with ors, would you prefer maintain consistency or change some of them? | 16:25 |
| alecu | nessita, +1 to fix the new ones, and fix the others later. | 16:26 |
| nessita | ack | 16:26 |
| gatox | ralsina, done... both branches are updated. | 16:28 |
| ralsina | gatox: looking... | 16:30 |
| ralsina | gatox: +1 with a little star on top | 16:31 |
| gatox | ralsina, :D | 16:32 |
| nessita | alecu: everything fixed and pushed | 16:35 |
| nessita | (and re-scanned by LP) | 16:36 |
| alecu | nessita, cool | 16:37 |
| === beuno-lunch is now known as beuno | ||
| ralsina | nessita, alecu, gatox: I am going to change our windows-xdg thing so that it considers these as xdg_config_dirs: ['C:\\Users\\ROBERTO\\AppData\\Local', 'C:\\ProgramData'] | 17:11 |
| nessita | ralsina: you sure about the last one? | 17:11 |
| alecu | ralsina, cool. How are you going to build those paths? | 17:11 |
| alecu | ralsina, are you using some win32 apis? | 17:12 |
| nessita | ralsina: didn't gatox mentioned something about c:\\allusers\\ for config? | 17:12 |
| alecu | or getting them from the registry, or something? | 17:12 |
| ralsina | That seems to me like the common practice, according to the ton of apps I have installed | 17:13 |
| ralsina | nessita: it seems all apps put stuff there (including ubuntuone-protocol | 17:16 |
| ralsina | alecu: I got them using win32com, just like we were getting them before | 17:16 |
| nessita | ralsina: ok then :-) | 17:17 |
| alecu | great | 17:17 |
| ralsina | c:\users\allusers\appdata seems to be a ""'link" to c:\programdata | 17:17 |
| alecu | ralsina, I saw that. Seven uses much saner directory names than previous versions, but it puts links around so old paths can still be used. | 17:18 |
| ralsina | alecu: I am getting "CSIDL_COMMON_APPDATA" which should point to logical places on all versions | 17:19 |
| ralsina | anyone has a XP handy to run 3 lines of python? | 17:20 |
| alecu | ralsina, perhaps fagan does? | 17:21 |
| ralsina | alecu: yes, but we don't have a fagan until tomorrow :-) | 17:24 |
| ralsina | Anyway, it's supposed to work n Windows millenium and higher ;-) | 17:24 |
| ralsina | nessita, alecu, gatox: small branch for review: https://code.launchpad.net/~ralsina/ubuntuone-client/find_config_files/+merge/70472 | 17:41 |
| gatox | ralsina, on it | 17:49 |
| ralsina | gatox, thanks! | 17:50 |
| nessita | gatox: can please refresh my memory: how can I load the qss in the designer? | 17:55 |
| gatox | nessita, not load.... you press right click in the dialog/widget (whatever) and choose "change styleSheet" option | 17:57 |
| gatox | nessita, and you can play around with that | 17:57 |
| nessita | gatox: but can I load the stylesheet from the qss in disk? | 17:58 |
| gatox | nessita, honestly... i don't know... i've never done that..... but you can copy/paste all the content :P | 17:58 |
| gatox | nessita, i assume this is just for testing | 17:59 |
| nessita | ack, thanks | 17:59 |
| gatox | nessita, it's kind of ugly (from my point of view) leave qss styles in the ui | 17:59 |
| nessita | gatox: of course, I wanted the qss to load visually, not to modify any xml | 17:59 |
| gatox | ralsina, +1 (review) | 18:03 |
| ralsina | gatox: thanks! | 18:04 |
| nhaines | ralsina: I can run some Python on WinXP SP3 if you need. :) | 18:04 |
| ralsina | nhaines: thanks for the offer but it would probably involve a couple of hours of setup before you can run them ;-) | 18:05 |
| nhaines | ralsina: oh, best not then... they expect me to get *some* reports out today at work. ;) | 18:06 |
| nessita | gatox: have handy the doc for the button "build" guide? | 18:09 |
| gatox | nessita, ?? from qt assistant for style sheet or you are talking about something else? | 18:10 |
| nessita | gatox: I'm talking about the spec for styling our buttons :-) (sorry for being so cryptic) | 18:10 |
| gatox | nessita, jeje..... let me check | 18:10 |
| fagan | ralsina: whats up, I can give you a little time if its important I dont mind | 18:10 |
| * gatox searching... | 18:10 | |
| ralsina | fagan: cool! | 18:11 |
| ralsina | fagan: let me do a pastebin of the python code I need running on XP | 18:11 |
| fagan | ralsina: Oh crap ill have to do it tomorrow I broke my ubuntu install that that VM is on and forgot to fix it | 18:11 |
| fagan | ralsina: paste it and ill say if its working for when you guys get up tomorrow | 18:12 |
| * fagan fixed one ubuntu but not the other | 18:12 | |
| ralsina | fagan: http://pastebin.ubuntu.com/658780/ | 18:14 |
| fagan | ralsina: cool whats the expected output? | 18:14 |
| gatox | ok people... i'll take a break (i'm here since 7 :P)... i'll be back around 17/18 to try to close some installer stuff if anyone needs anything | 18:14 |
| fagan | gatox: enjoy :) | 18:15 |
| ralsina | fagan: surprise me ;-) (should be a list of paths) | 18:15 |
| fagan | ralsina: cool | 18:15 |
| ralsina | nessita, alecu: if I could get a second review of https://code.launchpad.net/~ralsina/ubuntuone-client/find_config_files/+merge/70472 -- I checked it IRL, syncdaemon can now start without passing config files in the command line with that patch | 18:29 |
| nessita | ralsina: the branch needs tests... | 18:31 |
| dobey | trivialish: https://code.launchpad.net/~dobey/ubuntuone-installer/launch-cp/+merge/70479 | 18:33 |
| ralsina | nessita: I will do them. I note that I am replacing something that had no tests and was brokn with something that has no tests but works, though ;-) | 18:35 |
| ralsina | fagan: got the results yet? | 18:35 |
| nessita | ralsina: the thing that had no tests is a 3rd party lib. And I thought we agreed that every single piece of code *we* add, will have tests | 18:36 |
| ralsina | nessita: yes, we agreed, and I slipped. | 18:36 |
| ralsina | I will add tests for the kazillion other things in that module that don't have it while I am at it | 18:37 |
| nessita | ralsina: *thanks* | 18:38 |
| alecu | nessita, your branch is making tarmac unhappy. see: https://code.launchpad.net/~nataliabidart/ubuntuone-client/fix-tests/+merge/70373 | 18:43 |
| nessita | alecu: looking | 18:44 |
| alecu | nessita, it looks to me that tarmac is not set to a utf8 locale | 18:44 |
| nessita | dobey: help? ^ | 18:44 |
| alecu | nessita, try "unset LANG; unset LANGUAGE; u1trial tests/syncdaemon/test_vm.py" and you get the same error that tarmac throws | 18:45 |
| alecu | nessita, the thing seems like a bug in the branch | 18:46 |
| dobey | are you using translated strings in tests? | 18:46 |
| nessita | dobey: nopes | 18:46 |
| alecu | nessita, the branch is sending unicode to the os functions on linux | 18:46 |
| nessita | dobey: but I'm using non ascii chars | 18:46 |
| nessita | alecu: right, and that is intended | 18:46 |
| alecu | nessita, why? | 18:46 |
| dobey | why are you doing that? | 18:46 |
| nessita | alecu: did you read the comment in the MP? | 18:46 |
| alecu | nessita, it should be sending bytes on linux | 18:46 |
| nessita | why? | 18:47 |
| alecu | nessita, because if not, then we get this kind of errors | 18:47 |
| nessita | 78+ # path is a byte sequence encoded with utf8. If we pass this to os.walk, | 18:47 |
| nessita | 79+ # in windows, we'll get results encoded with mbcs | 18:47 |
| nessita | alecu: we need unicode becasue of that ^ | 18:47 |
| alecu | nessita, on windows, it makes sense, but on linux we can't | 18:47 |
| nessita | alecu: if we pass bytes to os.walk we'll get other encoded bytes as result | 18:48 |
| nessita | alecu: that makes no sense... how come we can't pass unicode to os.walk? | 18:48 |
| alecu | nessita, the native way to use os.* on linux is by passing bytes | 18:49 |
| nessita | alecu: what if we have a latin1 linux FS? syncdaemon will transform that to utf, and if we pass that to os.walk... | 18:49 |
| alecu | nessita, if we pass unicode, python will *try* to convert it to bytes before calling the operating system | 18:49 |
| dobey | alecu: either should work | 18:49 |
| dobey | nessita: latin1 probably won't work | 18:49 |
| alecu | dobey, no: it depends on the os encoding | 18:49 |
| dobey | the problem is that you can't convert utf8 to ascii, unless you're only using ascii characters | 18:50 |
| alecu | nessita, and when python tries to convert unicode into "ascii" bytes, we get that error. | 18:50 |
| alecu | dobey, wrong, that is not *this* problem. | 18:50 |
| alecu | dobey, this is "unicode" to ascii | 18:51 |
| dobey | exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\xf1' in position 161: ordinal not in range(128) | 18:51 |
| dobey | alecu: that is what i just said :) | 18:51 |
| alecu | no | 18:51 |
| nessita | alecu: so you're saying that python is trying to encode to ascii and not to utf8? | 18:51 |
| alecu | dobey, you said "utf8" | 18:51 |
| alecu | nessita, right. It's trying to convert unicode to the default encoding | 18:51 |
| alecu | nessita, since LANG is not set, the default encoding is ascii | 18:52 |
| alecu | nessita, and that is *right* | 18:52 |
| nessita | alecu: then we need our defaults encoding to be utf8, included tarmac | 18:52 |
| alecu | nessita, no | 18:52 |
| nessita | alecu: why is right? :-) | 18:52 |
| nessita | dobey: unicode != utf8 | 18:52 |
| dobey | yes i know that | 18:53 |
| alecu | nessita, because we'll get the same error if the user has other encoding | 18:53 |
| alecu | nessita, it's ok to have another encoding | 18:53 |
| nessita | dobey: ah, from your last sentence I thought you were mixing them, sorry | 18:53 |
| nessita | alecu: but this is a tearDown... | 18:53 |
| dobey | eh, it's not my fault windows is the red headed step child that it is | 18:54 |
| nessita | alecu: you propose is better to have an ifplatform there instead of us, devs, have default encoding to utf8? | 18:54 |
| nessita | alecu: I will trust you on this one, of course | 18:54 |
| alecu | nessita, right. I propose we stick to the convention | 18:54 |
| alecu | nessita, the convention being "os.* gets unicode on windows, bytes on linux" | 18:55 |
| dobey | why would os.* get unicode on windows? is that a convention we're enforcing ourselves? i thought python2.x used bytes by default everywhere, and python3 uses unicode by default | 18:55 |
| alecu | dobey, os.* needs unicode on windows, otherwise it starts doing funky stuff. Like os.listdir returning a list where some items are str and some are unicode. | 18:56 |
| dobey | well, if you know how to fix it, i'll let you fix it then :) | 18:58 |
| nessita | alecu: fixing | 18:58 |
| nessita | alecu: we may consider running the whole tests suite with lang and language unset | 18:58 |
| alecu | nessita, it seems that tarmac already does that. Or it uses a LANG with no ".UTF-8" appended. | 19:01 |
| dobey | it doesn't use a lang | 19:01 |
| dobey | it's run from cron, which basically has no env | 19:01 |
| alecu | great | 19:04 |
| dobey | the problem is developers expecting everyone else's env to be exactly like theirs ;) | 19:04 |
| ralsina | gotta go put a contract in the mail, will be back in about one hour | 19:14 |
| dobey | you shouldn't use mail for that. it's traceable | 19:19 |
| alecu | nessita, do you need a re-review on the "bytes on linux" change? | 19:32 |
| nessita | alecu: is pushed, I was waiting for LP to rescan to approve | 19:32 |
| nessita | alecu: but yes, a re-review is welcomed! | 19:32 |
| dobey | nessita, alecu, thisfred: quick, pretty trivial review on https://code.launchpad.net/~dobey/ubuntuone-installer/launch-cp/+merge/70479 please? :) | 19:35 |
| nessita | dobey: I can't say no again ;-) | 19:37 |
| nessita | dobey: looks good! Question, does ubuntuone.installer.gui import Window exists? | 19:38 |
| nessita | dobey: also, how are we handling the fact that we're moving to the -qt control panel? I see the gtk version 'hardcoded' | 19:39 |
| alecu | nessita, tested with LANG unset, and approved again. | 19:40 |
| dobey | nessita: yes; define "moving to" more explicitly. is there a timeline for making those changes on Ubuntu? because the qt stuff isn't even packaged yet | 19:40 |
| dobey | nessita: and i was thinking we'd do some stuff to make it work with alternatives or something, so that either would work | 19:41 |
| nessita | dobey: right, it won't happen in ubuntu for oneriric, but the plan is to happen soonish. So, I was thinking, if this is the entry point for every ubuntu version to have the latest, are we needing a SRU to have older ubuntu running the qt version? | 19:42 |
| dobey | nessita: it is hardcoded right now, to make stuff work. there will be many changes in the next couple of weeks leading up to UI freeze, but for now, making it work is priority :) | 19:42 |
| nessita | dobey: ah, that explains it | 19:42 |
| nessita | dobey: ok, approving | 19:55 |
| nessita | alecu: thanks! | 19:56 |
| dobey | nessita: thanks | 20:01 |
| nhaines | I can see the omgubuntu headline now. "Ubuntu One CP moving to QT... in time for oneiric?" And then the copy says "so far there are no plans to have this included in oneiric, but who can tell what the future will bring?" | 20:02 |
| karni | irk3z: osom | 20:08 |
| irk3z | :x | 20:08 |
| ralsina | nessita, got 2' for a quick mumble? | 20:28 |
| nessita | sure | 20:28 |
| ralsina | nessita: lost you in "pongamos que el control panel" | 20:39 |
| nessita | dobey: seems like tarmac may be in that state were it stops landing sutff | 20:47 |
| nessita | dobey: my branch is approved 49 minutes ago | 20:47 |
| dobey | oh, right, because it failed before. ok | 20:48 |
| nessita | ralsina: question re validate-harder: | 20:51 |
| ralsina | nessita: shoot! | 20:52 |
| dobey | nessita: should get picked up in ~8.5min | 20:52 |
| nessita | pylint complains with several lines like this: | 20:52 |
| nessita | 1161: [E1103, ResetPasswordControllerValidationTest.test_invalid_confirm] Instance of 'FakeResetPasswordPage' has no 'confirm_password_line_edit' member (but some types could not be inferred) | 20:52 |
| nessita | so I went to look to FakeResetPasswordPage and I see that the errors is "real" since FakeResetPasswordPage doesn't not have that attr but a: | 20:52 |
| nessita | self.ui.confirm_password_line_edit | 20:52 |
| nessita | ralsina: so, shouldn't the test call | 20:52 |
| nessita | self.controller.view.ui.confirm_password_line_edit | 20:52 |
| nessita | instead of | 20:53 |
| nessita | self.controller.view.confirm_password_line_edit? | 20:53 |
| ralsina | nessita: indeed that's a bug | 20:53 |
| nessita | ralsina: is repeated a lot for several classes | 20:54 |
| nessita | ralsina: I can paste the whole output if you don't have a linux handy | 20:54 |
| ralsina | yes, copy& paste mistake :-) | 20:55 |
| ralsina | I mean :-( | 20:55 |
| ralsina | It's ok, let me change it and push it | 20:55 |
| nessita | ack | 20:55 |
| ralsina | Actually the tests work because I am using the same object for view and view.ui, anyway | 20:57 |
| ralsina | so lint is actually wrong... | 20:57 |
| dobey | don't look at me, i told you to use pyflakes | 20:58 |
| ralsina | I get "has no 'email_edit' member (but some types could not be inferred)" | 20:58 |
| ralsina | nessita: ^ | 21:00 |
| nessita | ralsina: and does it have an email_edit attr? | 21:03 |
| ralsina | nessita: indeed | 21:04 |
| nessita | ralsina: can you please ignore globally E1103 in that test file? | 21:05 |
| ralsina | Check FakeCurrentUserPage, for example. self.ui = self and then self.ui.email_edit = FakeLineEdit() | 21:05 |
| ralsina | Maybe if I do self.fake_line_edit = FakeLineEdit() pylint will see it | 21:06 |
| nessita | ralsina: nah, just ignore globally the E1103. there are a couple of valid C0103 though | 21:06 |
| ralsina | nessita: ok, will look for those | 21:07 |
| === yofel_ is now known as yofel | ||
| ralsina | nessita: pushed with the C0103s fixed | 21:14 |
| nessita | ralsina: running tests in windows and after that approving | 21:23 |
| === m_conley is now known as m_conley_away | ||
| ralsina | nessita: cool, thx! | 21:23 |
| nessita | ralsina: are the tests in windows passing for you? | 21:25 |
| nessita | I got 35 errors :-/ | 21:25 |
| ralsina | 35???? | 21:25 |
| ralsina | I get 2, about the captcha | 21:25 |
| nessita | ralsina: let me use a fresh branch JIC | 21:26 |
| nessita | ralsina: is your trunk up to date? | 21:27 |
| ralsina | nessita: it was a while ago, let me pull again | 21:27 |
| ralsina | nessita: no revisions to pull | 21:28 |
| nessita | ralsina: I really gotta go, I'll paste the errors and maybe you can help me see what's wrong with my env tomorrow morning? | 21:29 |
| ralsina | nessita: sure thing | 21:29 |
| ralsina | nessita: if you have any reviews left, I can do them in a bit | 21:29 |
| nessita | http://pastebin.ubuntu.com/658890/ | 21:29 |
| nessita | ralsina: those are the failing tests ^ | 21:30 |
| ralsina | weeeeeird | 21:30 |
| ralsina | nessita: besides, they are in places unrelated to the changes, too | 21:31 |
| nessita | right | 21:32 |
| nessita | ralsina: I'll try to debug this tomorrow first thing. In the mean time, would you try running the tests in a clean branch of your branch, without setting any env var? just running make tests | 21:33 |
| nessita | run-tests.bat, sorry :-P | 21:33 |
| ralsina | sure! | 21:33 |
| ralsina | nessita: clean cmd, clean branch merged to trunk from launchpad, I get two or 3 failing tests, as usual. Here is a run with 3 failures: https://pastebin.canonical.com/50774/ | 21:36 |
| nessita | ralsina: any ideas what can be run with my env? | 21:38 |
| ralsina | nessita: not really, never seen that :-( | 21:39 |
| nessita | (FYI, this failure is not usual: ubuntu_sso.main.tests.test_windows.SSOLoginTestCase.test_emit_login_error, only the generate captcha ones) | 21:39 |
| ralsina | nessita: what's your PYTHONPATH? | 21:39 |
| nessita | ralsina: nothing | 21:39 |
| nessita | ralsina: the tets should take care of that | 21:39 |
| nessita | the bat file set it, right? | 21:40 |
| ralsina | yes, sets it to "." | 21:40 |
| nessita | right | 21:40 |
| nessita | weird | 21:40 |
| nessita | ok, I'm out of here, I'll continue tomorrow | 21:40 |
| nessita | bye all! | 21:40 |
| ralsina | but it should not even need that | 21:40 |
| ralsina | just in case, are you sure it's unset? | 21:40 |
| ralsina | bye! | 21:40 |
| nessita | ralsina: yeap, I confirmed | 21:40 |
| nessita | I'll re-check tom | 21:40 |
| ralsina | reboot! ;-) | 21:41 |
| ralsina | 3 times! | 21:41 |
| nessita | lol | 21:41 |
| dobey | more triviality: https://code.launchpad.net/~dobey/ubuntuone-installer/le-appertif/+merge/70499 | 22:08 |
| ralsina | dobey: got it! | 22:12 |
| dobey | cheers | 22:17 |
| === gato is now known as gatox | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
