| tntc | are playlists still broken on android? | 02:27 |
|---|---|---|
| duanedesign | tntc: i am not sure. Most the people who could help answer that are not on right now | 02:37 |
| === m_conley_away is now known as m_conley | ||
| === m_conley is now known as m_conley_away | ||
| === m_conley_away is now known as m_conley | ||
| === m_conley is now known as m_conley_away | ||
| Tbruff13 | hey can someone help me i cannot paste pictures into my ubuntu one folder why when i try to move them over from another folder they say permission denied | 03:18 |
| duanedesign | that is odd | 03:20 |
| duanedesign | Tbruff13: is the folder you are moving from in your HOme directory? | 03:20 |
| Tbruff13 | it is my Home | 03:21 |
| Tbruff13 | if i am root it works hey how long after they are in ubuntu one folder does it take to put them online | 03:23 |
| duanedesign | Tbruff13: sounds like their is a permission issue | 03:34 |
| duanedesign | Tbruff13: i would run the Terminal commands: ls -la ~/Ubuntu\ One | 03:35 |
| duanedesign | and run the same command on the folder that has the pictures | 03:35 |
| duanedesign | should look like: | 03:36 |
| duanedesign | -rw-r--r-- 1 duanedesign duanedesign 77789 2010-08-02 11:17 ubuntu_reference.pdf | 03:36 |
| duanedesign | with your username | 03:36 |
| Tbruff13 | duanedesign, i am ok | 03:36 |
| duanedesign | Tbruff13: the files should start syncing right away. How long it takes after it starts depends on size and nmber of files | 03:37 |
| Tbruff13 | drwxrwxr-x 2 lindseyjacks lindseyjacks 4096 2011-08-03 15:08 . | 03:40 |
| Tbruff13 | drwxr-xr-x 35 lindseyjacks lindseyjacks 12288 2011-08-04 22:05 .. | 03:40 |
| Tbruff13 | lrwxrwxrwx 1 lindseyjacks lindseyjacks 48 2011-08-03 15:08 Shared With Me -> | 03:40 |
| Tbruff13 | i am on my friends laptop | 03:40 |
| Tbruff13 | hey duanedesign i have an idea be back | 03:42 |
| duanedesign | that folder looks good. Must be the other folder | 03:57 |
| rogerk_ | Anyone know where I can find the logs for the windows client? | 07:20 |
| JamesTait | Good morning everyone! | 08:16 |
| feasty | Does anyone know why my UbuntuOne account would be showing that I have 74GB of data sync'd when my local machine (using du) only says I have 64GB of data? | 08:27 |
| feasty | It's ok, I found it on the FAQ. It's a known issue. | 08:50 |
| mandel | Hello!1 sorry for the late arrival, internet issues at home :( | 09:20 |
| mandel | duanedesign: forgot to tell you, wellcom! | 09:20 |
| fagan | oh welcome back to europe mandel | 09:56 |
| mandel | fagan: hello, took a while but I'm back | 09:57 |
| mandel | crazy airplanes... | 09:57 |
| fagan | mandel: well its argentina even if the flights were all on time it still would have taken nearly a day of travel | 10:00 |
| gatox | hi mandel | 10:04 |
| fagan | Morning gatox | 10:04 |
| mandel | gatox: ha, I wa looking for a diff nickname… you changed it? | 10:05 |
| mandel | fagan: yeah, but I ended up in an airport over 10 hours… major pain in the ass | 10:05 |
| fagan | mandel: yeah that sounds bad :/ | 10:05 |
| fagan | I would just go drinking or shopping or something | 10:05 |
| mandel | gatox: do you know what is the problem with the RO shares? I saw a mail thread about it but I have no idea of what is going on | 10:06 |
| mandel | fagan: yeah.. but I had not much money or energy to do anything | 10:07 |
| gatox | mandel, me neither.... :S | 10:07 |
| gatox | mandel, are you talking about roberto last night e-mail? | 10:08 |
| fagan | Wow I really dont have any look with Ubuntu on my computers at the moment | 10:16 |
| fagan | ubiquity keeps crashing on the only disk I have in the house | 10:16 |
| fagan | Might go down to buy a usb stick so I can install it | 10:17 |
| fagan | Actually I will be back in a few minutes | 10:17 |
| * mandel back1 | 10:24 | |
| Chipaca | mandel: no you're not, we can't read what you type | 10:24 |
| mandel | Chipaca: you cannot? | 10:27 |
| mandel | really :P | 10:27 |
| mandel | Chipaca: on question, do you know what is the bug that nessita has regarding RO shares? | 10:28 |
| Chipaca | mandel: not beyond what was in the email | 10:29 |
| Chipaca | mandel: so i can't answer your questions from your email, either | 10:29 |
| mandel | Chipaca: :( | 10:31 |
| mandel | Chipaca: 'cause we might be trying to do more than we need, since RO is something we create and no the user | 10:32 |
| Chipaca | mandel: yeah, and we ignore file properties anyway, so ... dunno | 10:35 |
| mandel | Chipaca: I'll wait to talk with nessita, right now we are simply expeculating.. at some point our os layer is going to be bigger than sd itself :( | 10:36 |
| ralsina | Good morning! | 11:06 |
| ralsina | mandel: what's that you replied to alecu about txnamedpipes? Is that an ancient mail that just got sent? | 11:07 |
| fagan | morning ralsina ill have that result in about half an hour ubiquity kept crashing on the CD I was trying to reinstall from so got a usb stick to try a later version of ubuntu | 11:10 |
| ralsina | fagan: ok | 11:11 |
| ralsina | gotta take the kid to school, will be back in 50 minutes | 11:11 |
| fagan | ralsina: cool should be ready by the time you get back | 11:11 |
| mandel | ralsina: is probably and old email since I have not sent anything that I know of... | 11:20 |
| mandel | ralsina: by the way, what is the problem with the RO shares, is this just because of the test dir not being deleted? | 11:21 |
| mandel | ralsina: because, if it is that they are looking to the completely wrong direction | 11:23 |
| mandel | can_wrtie is the issue, no the attr | 11:23 |
| duanedesign | mandel, thank you! | 11:46 |
| fagan | Wow this week went by really fast | 11:49 |
| fagan | it feels like tuesday | 11:50 |
| * fagan really needs to get some lunch but will wait till after standup since I have to go out and get some lunch type food | 11:56 | |
| Balaji_TVR | My UbuntuOne account is not connecting at all. I get this error >>>'NoneType' object has no attribute 'makefile'<<<. Any help on how to fix this? | 11:58 |
| fagan | Balaji_TVR: im pretty sure thats in the FAQ ill go grab a link | 11:59 |
| fagan | Balaji_TVR: are you behind a proxy server? | 12:00 |
| fagan | https://wiki.ubuntu.com/UbuntuOne/FAQ/WhyDoIGetNoneTypeErrorWhenLoggingIn | 12:00 |
| Balaji_TVR | yep | 12:00 |
| fagan | Balaji_TVR: yeah we dont support proxies yet | 12:00 |
| fagan | Balaji_TVR: its on the list of things to do but its a complicated feature | 12:00 |
| Balaji_TVR | I see. | 12:01 |
| Balaji_TVR | Even from home, If is set my connection to "Direct connection" (ie, no proxy), still its not honoring my proxy settings. | 12:02 |
| Balaji_TVR | so, without proxy also not working :( | 12:02 |
| Balaji_TVR | Sorry, I'm going for some meeting will go thru ur link for more details. Thanks for your input. | 12:03 |
| Balaji_TVR | brb | 12:03 |
| nessita | hello everyone | 12:05 |
| fagan | hey nessita | 12:05 |
| nessita | hi fagan! | 12:05 |
| gatox | nessita, hi | 12:08 |
| fagan | I completely ballsed up my Ubuntu install | 12:08 |
| fagan | Lost my VM | 12:08 |
| fagan | I can set one up pretty fast to test on though since ive done it so many times | 12:09 |
| fagan | I had an image locally that I had as a backup for my VM but didnt copy it properly :/ | 12:10 |
| fagan | Ok so ill have my vm up after lunch | 12:13 |
| fagan | thats not so bad | 12:13 |
| tntc | fagan: what are you using for virtualization? | 12:14 |
| tntc | What's the deal with the playlists? Any idea what caused the server error that's preventing some users from syncing? | 12:21 |
| fagan | tntc: virtual box | 12:24 |
| tntc | fagan: no snapshots? | 12:24 |
| fagan | tntc: I had one to use but what happened was I was running into a weird ubiquity bug that stopped the install so I had to do a clean install instead but messed up backing up the files | 12:25 |
| tntc | yikes! That sucks. | 12:25 |
| fagan | its cool just a little set back | 12:25 |
| tntc | I keep bouncing back to windows because my friends want to game, but I really really dislike it. | 12:26 |
| fagan | I havent heard of any issues with playlists maybe duanedesign can diagnose whats going on | 12:26 |
| tntc | oh, yeah it's a known outage or something I think | 12:27 |
| tntc | I just can't save them | 12:27 |
| fagan | tntc: I dont have a clue | 12:31 |
| fagan | :/ | 12:31 |
| tntc | Oh, no biggie! duanedesign is the one to ask? | 12:35 |
| fagan | tntc: well he could bring it further than I could :) | 12:36 |
| mandel | nessita: I believe my connectin should be ok now, do you mind getting in mumble a sec to test it? | 12:43 |
| nessita | mandel: can we do it after the stand up? | 12:49 |
| alecu | hello #ubuntuone! | 12:49 |
| mandel | nessita: sure | 12:49 |
| alecu | nessita, mandel: what are you doing after the standup? | 12:49 |
| * alecu needs to run for 30' after the standup | 12:50 | |
| nessita | alecu: mandel wants to try if his mumble works | 12:50 |
| mandel | nessita: when do we have mumble, is it a .45 after the stand up, right? | 12:50 |
| alecu | ah, ok. | 12:50 |
| nessita | alecu: will you make it for the mumble? | 12:50 |
| nessita | mandel: yes | 12:50 |
| nessita | mandel: we can do it later if you need | 12:50 |
| alecu | nessita, I think I will, yes. | 12:50 |
| mandel | nessita: time is ok for me, I'm more interested in testing the connection, that is all :) | 12:50 |
| fagan | Ok windows installed and python + pywin32 installed so im ready to test that script I think | 12:51 |
| mandel | nessita: lets test the connection 10 mins before the mumble, is that ok? | 12:51 |
| nessita | sure | 12:52 |
| mandel | alecu: I'm going to ignore the RO issues, yet take a look at this: http://msdn.microsoft.com/en-us/library/aa446637(v=vs.85).aspx | 12:54 |
| mandel | alecu: take a look at DisplayAccessMask implementation | 12:54 |
| alecu | mandel, let's see... | 12:55 |
| fagan | Ok the script is working as expected I think | 12:56 |
| fagan | Ill pastebin it | 12:56 |
| mandel | alecu: ideally that is how access and can_write should be working (not at the moment) yet I don't know the tests you guys did wih set_readonly and set_readwrite | 12:56 |
| alecu | mandel, I tested it from the python prompt | 12:57 |
| alecu | mandel, first, I imported os_helper | 12:57 |
| alecu | mandel, then I used with some freshly created files and folders on disk | 12:57 |
| alecu | mandel, first I tried on the E: drive, but since it was mounted by VBox, it didn't work right (it's like samba) | 12:58 |
| alecu | mandel, then I tried on the C: drive, that is fat | 12:58 |
| alecu | mandel, and that's how I got to see the different authorizations that are detailed on the mail | 12:58 |
| fagan | http://pastebin.ubuntu.com/659275 | 12:58 |
| fagan | I added in a couple of line breaks to make it more readable but you get the idea | 12:59 |
| fagan | alecu: ^ | 12:59 |
| fagan | ralsina: On that script you need to add a import os but other than that its working as expected I think | 13:00 |
| fagan | me | 13:00 |
| gatox | me | 13:00 |
| mandel | alecu: yes, we do not have a roll back to the setting, yet that is a problem with the default setting we use right? why would we want to have a roll back to previous attrs? | 13:00 |
| mandel | me | 13:00 |
| ralsina | fagan: I need the outputm though | 13:00 |
| nessita | me | 13:00 |
| fagan | ralsina: I pastebinned it look above | 13:00 |
| alecu | me too | 13:01 |
| ralsina | me | 13:01 |
| fagan | Ill go | 13:01 |
| fagan | DONE | 13:01 |
| fagan | * Found and reported a bug in Ubiquity that was blocking me actually testing dir script | 13:01 |
| fagan | * More of that report (still not done but is complicated so im taking my time on it) | 13:01 |
| fagan | TODO | 13:01 |
| fagan | * Finish the report | 13:01 |
| fagan | * What ever anyone else needs | 13:01 |
| fagan | Blocked | 13:01 |
| fagan | * not now | 13:01 |
| fagan | Oh and tested the script forgot about that | 13:01 |
| gatox | DONE: | 13:01 |
| gatox | Installer Page 19 UI complete. New "Sign in or Sing Up" UI style complete. | 13:01 |
| gatox | TODO: | 13:01 |
| gatox | Finish Installer Page 18. Fix UI bugs once Page 18 and 19 are complete. | 13:01 |
| gatox | BLOCKED: | 13:01 |
| gatox | not yet... :P | 13:01 |
| gatox | mandel, go | 13:01 |
| mandel | DONE: Fixed remarks for https://code.launchpad.net/~mandel/ubuntuone-client/fix-file-shelf-windows/+merge/70021 worked on getting fsm pass all tests on windows by skipping old metadata tests. Realized that due to RO issues more tests should be skipped until that is fixed | 13:02 |
| mandel | TODO: skip tests on test_fsm that depend on ro shares and state the reason. Find a correct working implementation for access and can_write that takes file attr into account. | 13:02 |
| mandel | BLOCKED: no, but internet seems to suck big time. | 13:02 |
| mandel | COMMENT: I'll be getting back to the morning report emails on Monday, I just realized I forgot to do it. | 13:02 |
| mandel | nessita, please! | 13:02 |
| nessita | DONE: epic branch fixes and finally landed, UI improvements to control panel, reviews | 13:02 |
| nessita | TODO: more reviews, more UI improvements | 13:02 |
| nessita | BLOCKED: nopes | 13:02 |
| nessita | NOTE: I miss the freaky friday :-( | 13:02 |
| nessita | NEXT: alecu | 13:02 |
| alecu | DONE: done huge review; worked on bug #820674: branch for review: https://code.launchpad.net/~alecu/ubuntuone-client/fix-add-watch-raceconditions/+merge/70559 | 13:02 |
| alecu | TODO: review permissions and R/O with mandel, work on new issues with bug #803672 | 13:02 |
| alecu | BLOCKED: no | 13:02 |
| alecu | NEXT: ralsina | 13:02 |
| ubot4 | Launchpad bug 820674 in ubuntuone-client "The second call to add_watch should return the same deferred that the first returns (affects: 1) (heat: 382)" [Undecided,New] https://launchpad.net/bugs/820674 | 13:02 |
| ubot4 | Launchpad bug 803672 in ubuntuone-client (Ubuntu) (and 2 other projects) "Do not start two instances of this process (affects: 2) (heat: 22)" [Undecided,Invalid] https://launchpad.net/bugs/803672 | 13:02 |
| nessita | ralsina: go? | 13:04 |
| dobey | me | 13:04 |
| fagan | dobey: go id say | 13:04 |
| ralsina | fagan: looks nice, thanks! | 13:04 |
| ralsina | gatox go | 13:04 |
| gatox | ralsina, i already went :P | 13:05 |
| nessita | ralsina: you have huge lag | 13:05 |
| ralsina | DONE: pushed branches for bug #814686, bug #820945 worked more in bug #809873, calls, IRL testing of latest stuff | 13:05 |
| ralsina | TODO: more IRL tests, merge pending branches, review diego's work, see if I can start on u1cp's bytes/unicode problems, ship build | 13:05 |
| ubot4 | Launchpad bug 814686 in ubuntu-sso-client "QT UI: 'Sign in' button can be clicked even if not values were entered, same happens with verification code (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/814686 | 13:05 |
| ubot4 | Launchpad bug 820945 in ubuntuone-client "On windows, syncdaemon needs to find the right default config files, and store settings in the right place in the correct location (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/820945 | 13:05 |
| ubot4 | Launchpad bug 809873 in ubuntuone-windows-installer "Add a script to create a bundle and installer for all the related software (affects: 1) (heat: 8)" [High,In progress] https://launchpad.net/bugs/809873 | 13:05 |
| ralsina | BLOCKED: no | 13:05 |
| dobey | λ DONE: finished initial shim work | 13:05 |
| dobey | λ TODO: releases, packaging, etc | 13:05 |
| dobey | λ BLCK: None. | 13:05 |
| gatox | ralsina, nessita about my branches... one of them has 1 approval, and the other is pending... do you think you are going to be able to review that today? | 13:06 |
| ralsina | I first lagged then got dumped out of IRC, thus my weird comment ;-) | 13:06 |
| nessita | gatox: yes, before lunch | 13:06 |
| gatox | nessita, awesome | 13:06 |
| alecu | mandel, you said "roll back to previous attrs", but these are not attrs, these are permissions. aka "access control entries (ACEs)" from the "access control list (ACL)" | 13:06 |
| gatox | nessita, yes....... i'm annoying | 13:06 |
| gatox | jeje | 13:06 |
| ralsina | nessita: I have complained to the ISP already :-( | 13:07 |
| alecu | mandel, and I found they are a bit tricky... :-( | 13:07 |
| mandel | alecu, nessita, ralsina: can I get a re-review for https://code.launchpad.net/~mandel/ubuntuone-client/fix-file-shelf-windows/+merge/70021 | 13:07 |
| mandel | alecu: sorry, true permissions for the DACL :P | 13:07 |
| mandel | alecu: and yes, DACL are terribly hard to understand and map to unix | 13:07 |
| nessita | gatox: can you please confirm if the test suite for https://code.launchpad.net/~ralsina/ubuntu-sso-client/validate-harder/+merge/70320 is passing for you? if so, ralsina, I'll approve | 13:10 |
| gatox | nessita, ok | 13:10 |
| nessita | gatox: is failing miserably for me, but is very likely i my env | 13:11 |
| nessita | is* | 13:11 |
| * gatox testing... | 13:11 | |
| alecu | mandel, to see this problem: open the windows file explorer, create a folder in your homedir, then "right-click, New, Text Document", then right click the file, "properties->security->advanced" | 13:12 |
| alecu | mandel, then close those dialogs and use os_helper.set_readonly on that file, and check the ACEs again. | 13:13 |
| alecu | mandel, and finally use os_helper.set_readwrite and check the ACEs | 13:13 |
| alecu | mandel, the problem would be that the permissions are slightly off. And we should not be hardcoding this permissions, but instead be inheriting them from the parent... | 13:14 |
| alecu | and changing them slightly when setting read only (but not creating a new set of ACEs, just copying and restricting the existing ones) | 13:14 |
| alecu | mandel, does this make sense? | 13:14 |
| alecu | mandel, ralsina, nessita: I'll be out for 30' | 13:15 |
| ralsina | alecu, mandel, nessita, gatox: confirmed os.rename() works different on windows and linux, that makes tritcask fail | 13:15 |
| nessita | alecu: ack | 13:15 |
| nessita | ralsina: ouch. different how? | 13:15 |
| mandel | alecu: we can talk in the mumble about it, I think I understand the issue in an slightly diff way | 13:15 |
| ralsina | on linux it happily overwrites existing files. On windows, that's an exception | 13:16 |
| nessita | ralsina: mandel is working on doing that | 13:16 |
| mandel | ralsina: excuse me? | 13:16 |
| nessita | mandel: right? for the commit_file partila thingy? | 13:16 |
| nessita | mandel: you said you will tweak the rename to overwrite files | 13:17 |
| nessita | gatox: approving the ussoc titles branch, it looks great! | 13:17 |
| ralsina | nessita:: OTOH, shutil.move works just fine on both platforms, so it may be a search/replace fix | 13:17 |
| nessita | ralsina: we're having exception while using shutil,move | 13:18 |
| mandel | nessita: yes, that is done with the MoveFileEx and is working, the problem we had in the commit_file is that it uses shutil.move in case we are in a diff fs but it will not be our case on winows | 13:18 |
| ralsina | nessita: but tritcask can't use os_helper, right? | 13:18 |
| mandel | ralsina: the issues is not use shutil.move, which we have to do on linux, but to use it in windows as a rename | 13:18 |
| gatox | nessita, great | 13:18 |
| mandel | ralsina: the but is not in tritcask, at leas the one 'm looking at, tritcask is doing a rename of an opened fd which brakes | 13:19 |
| nessita | mandel: is anyone working on that? | 13:19 |
| mandel | got to close it and then move it, which I dont know if it brakes tritcasks logic | 13:19 |
| nessita | mandel: that == not renaming opened files | 13:19 |
| mandel | nessita: I though verterok was on it, but we might want to remind him | 13:19 |
| gatox | nessita, about roberto's branch... tests are still running... but it is everything ok by now | 13:19 |
| nessita | mandel: ok, I'll talk to verterok | 13:20 |
| nessita | ralsina: can you show me a trace of the rename error you're having? | 13:20 |
| nessita | verterok: ping | 13:20 |
| mandel | nessita: yeah, verterok should be your man for tritcask, I know the issue but I would not dare to say how to correctly fix it | 13:20 |
| verterok | nessita: pong | 13:20 |
| nessita | verterok: hi there! we're having issues when running syncdaemon in windows since tritcask tries to renames opened files | 13:21 |
| ralsina | mandel: it's in my email from last night | 13:21 |
| nessita | verterok: mandel mentioned you may have a fix for us | 13:21 |
| verterok | nessita: if it's the make_immutable call, I'm sure the file it's closed | 13:21 |
| mandel | ralsina: yeah, that is tritcask, those tests are even failing atm | 13:22 |
| verterok | nessita: wasn't able to find the problem | 13:22 |
| nessita | verterok: yes, is in that function. The thing is that we're having this problem: | 13:22 |
| nessita | File "ubuntuone\syncdaemon\tritcask.pyc", line 654, in _rotate_and_merge | 13:22 |
| nessita | File "ubuntuone\syncdaemon\tritcask.pyc", line 844, in merge | 13:22 |
| nessita | File "ubuntuone\syncdaemon\tritcask.pyc", line 390, in make_immutable | 13:22 |
| nessita | exceptions.WindowsError: [Error 183] Cannot create a file when that file already | 13:22 |
| nessita | exists | 13:22 |
| verterok | oh, that's new | 13:22 |
| ralsina | mandel: exceptions.WindowsError: [Error 183] Cannot create a file when that file already exists. It happens in a os.rename() call :-) | 13:22 |
| ralsina | The line is in File "ubuntuone\syncdaemon\tritcask.pyc", line 390, in make_immutable | 13:22 |
| ralsina | Damn LAG | 13:22 |
| verterok | nessita: file exists? | 13:22 |
| nessita | verterok: how can we know? | 13:23 |
| gatox | nessita, confirmed... all the tests are ok | 13:23 |
| verterok | ralsina, nessita, mandel: the file shouldn't exist....at least that's the whole idea | 13:23 |
| nessita | gatox: thanks! | 13:23 |
| mandel | verterok: a nice way to test that is to get to the point where you close (or believe it was closed) and make the code wait there, then use process explorer to find who has a handle to the file | 13:24 |
| verterok | mandel: it's being close 1 line before the call to os.rename | 13:24 |
| nessita | verterok: but maybe close is failing? | 13:25 |
| verterok | nessita: failing? | 13:25 |
| verterok | mandel: anyway, this looks like a different issue. | 13:25 |
| nessita | verterok: yeap, some other <something> is accessing it an can't close it | 13:25 |
| verterok | nessita: only the tritcask instance is accesing the files...not sure what other <something> means :( | 13:26 |
| nessita | verterok: me neither, I'm trying to look for options | 13:26 |
| verterok | nessita: also, each test case run in it's own directory...so it should be a problem of cross test case issues | 13:26 |
| nessita | verterok: this is not a test issue | 13:27 |
| nessita | verterok: is IRL | 13:27 |
| verterok | *shouldn't | 13:27 |
| verterok | nessita: this problem isn't related to the file not being closed | 13:27 |
| verterok | nessita: so, we have 2 issues | 13:27 |
| verterok | nessita: 1) "the file is being used by another process.." (yes, and that process might be myself :p) | 13:28 |
| verterok | nessita: 2) this issue about os.rename I just know about | 13:28 |
| nessita | verterok: do we have fixes for 1 and 2? | 13:29 |
| mandel | verterok: what up with rename? | 13:29 |
| mandel | that you cannot replace the file? | 13:29 |
| nessita | mandel: there is a trace in roberto's emails from last inght | 13:29 |
| nessita | night* | 13:29 |
| verterok | mandel: no idea...you were talking about that | 13:29 |
| verterok | nessita: I don't have a fix for anything | 13:30 |
| mandel | verterok: I was saying that we could not d a reame because the fd is used by another process (or mine :( ) and that is the error | 13:30 |
| nessita | mandel: did you see the trace? | 13:30 |
| verterok | nessita: I need find out the reason of 1) (seems that only happens on tests) | 13:30 |
| mandel | nessita: yes, that i do not see as a big issue, verterok look at http://msdn.microsoft.com/en-us/library/aa365240(v=vs.85).aspx | 13:31 |
| mandel | that is the way we solve it in os_helper | 13:31 |
| nessita | mandel: how come is not a big issue since syncdaemon crashes IRL? :-) | 13:31 |
| mandel | we just have to use the MOVEFILE_REPLACE_EXISTING flag... | 13:31 |
| verterok | mandel: the file shouldn't exists | 13:32 |
| mandel | nessita: I mean, is a big issue yet not a hard one to fix, bot me is a big issue if we hav eno idea what to do :) | 13:32 |
| nessita | verterok: right, so self.temp_name somehow exists | 13:32 |
| verterok | mandel: it's really bad (tm) to replace an existing tritcask data file | 13:32 |
| nessita | mandel: we don't have to replace, like verterok is saying | 13:32 |
| verterok | nessita: are you sure it exists? :) | 13:32 |
| mandel | verterok: well, that is why I pointed at you for this :) | 13:33 |
| nessita | verterok: no. We can add a log entry, though | 13:33 |
| nessita | ralsina: can you reproduce the windowserror issue? | 13:33 |
| nessita | verterok: assuming the files does exists... any idea how we reached that situation? | 13:34 |
| ralsina | nessita: I bet I can | 13:35 |
| mterry | vds, I have another 500 Oops-ID if it would help: 2043appserverZJHAICCCIedIbEfIfbFJcAHHaFbfFaGcG207444 | 13:35 |
| ubot4 | https://lp-oops.canonical.com/oops.py/?oopsid=ID | 13:35 |
| verterok | nessita: time travel | 13:35 |
| nessita | ralsina: before you do | 13:35 |
| verterok | nessita: really, time travel is the only way to have a duplicate inactive tritcask data file | 13:35 |
| nessita | ralsina: can you please add a log entry before the rename in the line is failing? something like: in line 389 | 13:35 |
| ralsina | nessita: sure | 13:36 |
| ralsina | what should I log? | 13:37 |
| nessita | ralsina: logger.info('make_immutable: about to rename %r to %r (dest exists? %r).', self.filename, new_name, os.path.exists(new_name)) | 13:37 |
| ralsina | oh, right | 13:37 |
| ralsina | sure, on it | 13:37 |
| nessita | verterok: well, it will not be te first time we have a PICNIC | 13:37 |
| nessita | verterok: or a thread issue | 13:37 |
| verterok | nessita: tritcask isn't threadsafe | 13:38 |
| nessita | verterok: when does that code run? | 13:38 |
| nessita | verterok: only at startup? | 13:38 |
| verterok | nessita: it's only accesed from fsm and volume manager | 13:38 |
| verterok | nessita: the merge, yes | 13:38 |
| nessita | verterok: fsm uses threads for watchs in windows | 13:38 |
| nessita | verterok: not directly related, I know | 13:38 |
| verterok | nessita: not fsm | 13:39 |
| nessita | verterok: filesystem_monitor I mean. You mean filesystem_manager? | 13:39 |
| verterok | nessita: fsm == fileystem_manager :) | 13:39 |
| verterok | yes | 13:39 |
| mandel | verterok, nessita: all process of event occurs in the main thread of the reactor by using callFromThread, so it should be ok | 13:42 |
| mandel | unless we found an issue with that... | 13:42 |
| nessita | gatox: why you moved TITLE_STYLE out of alphabetical order? | 13:43 |
| nessita | gatox: this is the installer titles branch | 13:43 |
| verterok | mandel: this is only executed at startup...it shouldn't be affected by any threading issues | 13:43 |
| nessita | gatox: actuall, can you revert all changes to ubuntuone_installer/gui/qt/setup_account.py? I think they are not needed | 13:44 |
| mandel | verterok: ok, nice, looks ike the only way to know is my logging | 13:44 |
| gatox | nessita, ok | 13:44 |
| mandel | verterok: what is the file name policy used by tritcask? | 13:44 |
| mandel | I hope it has nothing to do with any stupid case of the windows fs... | 13:45 |
| nessita | gatox: the branch looks good, I'll test IRL and then very likely you have an approve | 13:45 |
| verterok | mandel: <file_id>.<live|inactive|dead>.tritcask-<version>.data | 13:45 |
| verterok | mandel: file_id is a timestamp | 13:46 |
| nessita | mandel, ralsina, Chipaca, alecu, gatox: mumble? | 13:46 |
| mandel | verterok: can you show me an example? | 13:46 |
| verterok | mandel: in windows is: str(int(time.clock() + 100000)) | 13:46 |
| verterok | ups | 13:46 |
| verterok | mandel: in windows is: str(int(time.clock() * 100000)) | 13:46 |
| nessita | mandel: you can look in your data dir | 13:46 |
| * mandel looks | 13:47 | |
| verterok | mandel: 131177171640160.live.tritcask-v1.data | 13:47 |
| nessita | mandel: ls .local/share/ubuntuone/syncdaemon/tritcask/ | 13:47 |
| verterok | mandel: and 131177136785606.inactive.tritcask-v1.data | 13:47 |
| nessita | ralsina, Chipaca: mumble? | 13:48 |
| gatox | nessita, changes reverted in setup_account.py | 13:49 |
| mandel | verterok: I cannot think a case when that happens to be the same... | 13:49 |
| nessita | gatox: ack | 13:49 |
| verterok | mandel: yup, that's the idea of the timestamp * 100000 :) | 13:49 |
| verterok | it should never ever, ever, ever, ever...ever be the same | 13:50 |
| nessita | verterok: what if the clock in windows is not that accurate? | 13:50 |
| verterok | nessita: in linux we use time.time() and in windows time.clock() | 13:51 |
| nessita | verterok: I know. How much we trust time.clock? | 13:51 |
| ralsina | nessita: in 5' | 13:51 |
| nessita | verterok: I'm trying to seek alternatives... | 13:51 |
| verterok | nessita: I don't trust in windows, but according to the docs, time.clock should be fine | 13:52 |
| mandel | verterok, nessita: http://stackoverflow.com/questions/85451/python-time-clock-vs-time-time-accuracy | 13:52 |
| nessita | verterok: what if the user has the time wrong? | 13:52 |
| nessita | verterok: does time.time/clock depends on that? | 13:52 |
| verterok | nessita: yes | 13:53 |
| nessita | verterok: what if: the user has the time correct, we create tritcask files, the user changes the time to th past, restart syncdaemon | 13:53 |
| nessita | I know the chances are little, but we can have issues there | 13:53 |
| ralsina_ | nessita, verterok: https://pastebin.canonical.com/50803/ | 13:54 |
| verterok | 0? | 13:54 |
| verterok | WTF? | 13:54 |
| ralsina_ | yep | 13:54 |
| nessita | oh, what a nightmare | 13:54 |
| nessita | verterok: I think we may need to have another algorithm to create filenames, such as use a random number, check filename does not exists, if so pick another random number, etc | 13:55 |
| verterok | nessita: tritcask use the order of the files | 13:55 |
| ralsina | No, we are just using time.clock wrong | 13:56 |
| verterok | ralsina: ? | 13:56 |
| nessita | verterok: ah | 13:56 |
| ralsina | trivial fix | 13:56 |
| ralsina | The first call to clock always returns "almost 0" | 13:56 |
| verterok | ralsina: please elaborate | 13:56 |
| mandel | verterok: look http://docs.python.org/library/time.html#time.clock | 13:56 |
| verterok | ahh, ok | 13:57 |
| verterok | my fault | 13:57 |
| nessita | verterok: is there any chance you help us fixing this? | 13:58 |
| ralsina_ | time.time() works just fine on windows, BTW | 13:58 |
| verterok | so, it doesn't work for what we need :( | 13:58 |
| verterok | ralsina: no it doesn't...at least not for the tests | 13:58 |
| ralsina_ | verterok, ok, we can use clock() and add a random huge integer | 13:58 |
| nessita | ralsina_: time.time() may return the same number | 13:58 |
| nessita | twice | 13:58 |
| mandel | verterok: nah, it does if you are measuring how long the process was running | 13:58 |
| mandel | verterok: ad if you call it always very early.. | 13:58 |
| ralsina_ | call time.clock() early, then use time.time()+time.clock() | 13:59 |
| verterok | ralsina_: I was thinking of that | 13:59 |
| nessita | ralsina_: mumble now? | 13:59 |
| ralsina_ | nessita: sure | 13:59 |
| mandel | verterok: fancy to use http://msdn.microsoft.com/en-us/library/ms724390(v=vs.85).aspx from pywin32? | 14:00 |
| ralsina_ | BTW: the stalled uploads in the IRL tests? same tritcask error as this one | 14:00 |
| mandel | verterok: is UTC so no problem with time zones… | 14:00 |
| nessita | Chipaca: you coming? | 14:01 |
| verterok | mandel: I'll propose a fix using time module | 14:01 |
| nessita | verterok: thanks! | 14:01 |
| verterok | mandel: I'm not going to learn how to use pywin32 extension today :) | 14:01 |
| ralsina_ | time.time()+time.clock() should be unique, monotonic, and *fast* (2 seconds per second ;-) | 14:01 |
| nessita | ralsina_: can you please file a bug for verterok? | 14:01 |
| mandel | verterok: just import and use :) | 14:01 |
| ralsina_ | and also, work on both OSs | 14:01 |
| mandel | ralsina: time.clock depends on when you called it | 14:01 |
| ralsina_ | nessita: of course! | 14:01 |
| ralsina_ | mandel: yes, but it's always increasing. monotonic+mnotonic == monotonic | 14:04 |
| ralsina_ | then again, here is a tiny chance i will repeat between runs | 14:05 |
| mandel | ralsina: estan hablando en mimble? | 14:06 |
| * mandel suspects his went a la mierda... | 14:06 | |
| ralsina_ | yes it did | 14:07 |
| ralsina_ | vertero: bug #821488 | 14:12 |
| ubot4 | Launchpad bug 821488 in ubuntuone-client "windows: tricask is using a bad timestamp for unique filenames (affects: 1) (heat: 6)" [Critical,Triaged] https://launchpad.net/bugs/821488 | 14:13 |
| mandel | ralsina: oh, did I die in mumble again? | 14:13 |
| mandel | bad internet... | 14:13 |
| verterok | mandel: GetSystemTime doesn't work for this case | 14:15 |
| mandel | verterok: no? what about using something in tempfile? | 14:17 |
| verterok | mandel: it doens't have enough resolution | 14:17 |
| mandel | verterok: I would need more time to think, so I leave it to you :) | 14:18 |
| === m_conley_away is now known as m_conley | ||
| ralsina_ | verterok, why not just use a UUID? | 14:20 |
| verterok | ralsina_: we need order | 14:21 |
| verterok | ralsina_: tritcask use the filename to read from old to new | 14:21 |
| ralsina_ | oh, ok | 14:21 |
| ralsina_ | verterok, you can take time.time() at startup, and then add clock() to it | 14:23 |
| ralsina_ | that should be increasing even between sessions | 14:23 |
| ralsina_ | of course you need a global variable ;-) | 14:24 |
| verterok | ralsina_: or just an attribute :) | 14:24 |
| ralsina_ | verterok: of course :-) | 14:24 |
| mandel | nessita, ralsina, alecu, gatox: I'm of 5 min 'til I find the dog, apparently he likes to walk around scaring the tourists, mainly the german ones... | 14:34 |
| gatox | mandel, :P | 14:34 |
| ralsina_ | ze germans! | 14:34 |
| alecu | mandel, btw: you may have already seen it, but the R/O bug is this: https://bugs.launchpad.net/ubuntuone-client/+bug/820350 | 14:35 |
| ubot4 | Launchpad bug 820350 in ubuntuone-client "WIndows: either set_dir_readwrite and/or set_dir_readonly are not doing what they should (affects: 1) (heat: 6)" [High,Triaged] | 14:35 |
| mandel | alecu: I'm back, shall we take a look at that before I get to my bugs? | 14:42 |
| alecu | mandel, the read only stuff? | 14:45 |
| mandel | alecu: si :) | 14:46 |
| alecu | mandel, I agree with nessita that we should postpone it for next week: it's important, but not critical | 14:47 |
| mandel | alecu: ok, then I move to my own little branches :) | 14:47 |
| mandel | alecu, nessita, ralsina: please can you take a look to https://code.launchpad.net/~mandel/ubuntuone-client/fix-file-shelf-windows/+merge/70021 I'd like to know if we will ignore it or not so that I base my branch on trunk or on this one | 14:49 |
| ralsina_ | mandel: I am tempted to say ignore, but I am not sufficiently familiar with the code, I am just basing it in what I have heard. | 14:49 |
| mandel | ralsina: look at the diff, there are not many change | 14:50 |
| mandel | s | 14:50 |
| ralsina_ | mandel, I have seen them, but I don' t know what they are trying to *do* :-D | 14:51 |
| nessita | mandel: looking | 14:51 |
| mandel | ralsina: use the os_helper code :) | 14:51 |
| verterok | mandel, nessita, ralsina_: https://code.launchpad.net/~verterok/ubuntuone-client/win32-no-more-time_clock/+merge/70580 | 14:51 |
| mandel | verterok: I take one review!!! | 14:52 |
| verterok | nessita, mandel: yes, not a single test. I don't have my laptop (with the windows vm) around | 14:52 |
| nessita | verterok: can you add some tests and volunteer to run them? | 14:54 |
| nessita | *please* | 14:54 |
| verterok | nessita: I can't write tests that I can't execute :( | 14:55 |
| ralsina_ | verterok, I am doing a IRL test in 5' | 14:55 |
| ralsina_ | and I can run tests for you if you want ;-) | 14:55 |
| verterok | nessita: I'ld love to write tests, and will do it. but I can't do it today :( | 14:55 |
| nessita | verterok: when would you be able to add the tests? | 14:56 |
| ralsina_ | Basically, at least test that the first call is not 0 is enough for the bug we had | 14:56 |
| verterok | ralsina_: I can add that one | 14:56 |
| verterok | nessita: as soon I get some stuff out of my todo/work queue | 14:57 |
| mandel | verterok: tine time.clock() addition in the __init__ is not really needed since if it the first one ever to be executed it will always be 0, or so I understand by this the docs: http://docs.python.org/library/time.html#time.clock | 14:57 |
| ralsina_ | verterok: that test is what TDD would require. "hey, timestamp returns 0 in every first run", test that is not 0, fix, done. | 14:57 |
| verterok | mandel: it will not be 0 :) | 14:57 |
| verterok | ralsina_: clearly I didn't fix it using tdd :) | 14:57 |
| ralsina_ | verterok: yes, I am talking about faking it ;-) | 14:58 |
| nessita | ralsina_: I propose the following: let's test this IRL, and if it works, you cna merge it in the installer, but let's wait for the merge into trunk until the tests are added | 14:58 |
| mandel | verterok: maybe adding it in a diff line and giving a comment like #start clock or something like that :) | 14:58 |
| verterok | mandel: # start counting from now isn't goof enough? :) | 15:00 |
| verterok | *good | 15:01 |
| nessita | mandel: your branch fsm looks good, but can you please restore the removed line at the end of the file ubuntuone/syncdaemon/file_shelf.py | 15:01 |
| nessita | ralsina_, verterok: I propose the following: let's test this IRL, and if it works, you cna merge it in the installer, but let's wait for the merge into trunk until the tests are added | 15:01 |
| verterok | nessita: I'll add a test, tdd like | 15:01 |
| ralsina_ | nessita: I am building the installer now, should have word about it in 5' or so | 15:02 |
| mandel | verterok: hehe I mean remove the + time.clock() that is all, but just because I had to find something, for me is more than ok | 15:02 |
| mandel | nessita: sure | 15:03 |
| verterok | mandel, nessita, ralsina_: test and fixed comment pushed | 15:03 |
| ralsina_ | verterok: awesome | 15:03 |
| ralsina_ | verterok: runnin test now | 15:03 |
| verterok | nessita: there, it haz a test | 15:03 |
| nessita | verterok: :-) | 15:03 |
| mandel | verterok: self.assertNotEqual(timer.time(), timer.time()) | 15:06 |
| mandel | self.assertTrue(int(timer.time()) > int(timer.time())) | 15:07 |
| mandel | but is not a must :P | 15:07 |
| verterok | mandel: that will probably fail :) | 15:08 |
| verterok | mandel: (in linux) | 15:09 |
| mandel | verterok: @skipIfOS('linux2') but I don't know… as I said, not a must | 15:10 |
| ralsina_ | verterok: confirmed IRL, filenames are now sane | 15:10 |
| verterok | ralsina_: cool | 15:10 |
| nessita | mandel: let me know when you push the line restore so I can run the suite | 15:13 |
| nessita | alecu: branch looks good! running tests now | 15:15 |
| mandel | nessita: waiting for the push to finish... | 15:18 |
| ralsina_ | nessita, mandel: a traceback from testing: https://pastebin.canonical.com/50820/ | 15:24 |
| nessita | ralsina_: testing what exactly? :-) (I have 3 branches running tests ATM) | 15:24 |
| mandel | nessita: push is done | 15:24 |
| ralsina_ | nessita: sorry. From running u1cp IRL | 15:24 |
| nessita | ralsina_: doing what exactly? is "everything" (sync, sso, etc) running? | 15:25 |
| nessita | mandel: ack | 15:25 |
| nessita | alecu: ping | 15:25 |
| ralsina_ | nessita: yes, everything is running, and it starts saying this hundreds of times and fails to connect to SD | 15:25 |
| alecu | nessita, pong | 15:25 |
| nessita | alecu: trunk -> (skips=13, failures=40, errors=146, successes=1982) | 15:26 |
| nessita | your branch -> (skips=13, failures=40, errors=135, successes=1996) | 15:26 |
| nessita | YEY! | 15:26 |
| alecu | :-) | 15:27 |
| nessita | ralsina_: can you give me details about what "it starts saying this hundreds of times and fails to connect to SD" means? not sure how to help debug otherwise | 15:27 |
| ralsina_ | nessita: I have SD running, and working, uploading files. If I start u1cp, it just starts printing this over and over, and the UI never displays ay data from SD. | 15:28 |
| ralsina_ | nessita: sadly, this goes so fast I can' t see the beginning of it | 15:28 |
| nessita | ralsina_: weird, CP is workign from trunk running everything 'manually' | 15:28 |
| nessita | ralsina_: 2 things | 15:28 |
| nessita | actually, 3 | 15:28 |
| ralsina_ | nessita: ok | 15:28 |
| nessita | ralsina_: can you kill you evil twin? autocompleiton is killing me :-D | 15:28 |
| ralsina_ | nessita: talk to either of us, I don' t care ;-) | 15:29 |
| alecu | ralsina_, can you try running it and capturing the output to some file? it would be useful to have the start of those errors | 15:29 |
| ralsina_ | alecu: I can try, of course | 15:30 |
| alecu | ralsina_, and also they'll probably show up as well on .cache/logs/somewhere | 15:30 |
| nessita | ralsina_: is difficult talk to any of you, both are hard to autocomplete having the other around | 15:30 |
| ralsina_ | nessita: ok, will kill the other one | 15:30 |
| nessita | ralsina_: second, yes please, capture output as alecu says | 15:30 |
| nessita | ralsina_: and third, is your tests using installed stuff or running all manually? | 15:31 |
| ralsina_ | nessita: installed stuff | 15:31 |
| alecu | ralsina_, anyway: it looks like on_request_queue_removed is not defined as it should | 15:31 |
| nessita | alecu: right, but why does this happen using the installed stuff only (apprently)? | 15:32 |
| mandel | ralsina: seems like a remove method is missing in the ipc of sd on the windows side, would be nice if you check that the method (without remote_) is present.. (I'm on a diff thing right now :P) | 15:32 |
| ralsina_ | nessita: I don't think it's just with installed stuff. It's also because I am the only one that has a working syncdaemon beyond 5 minutes (because of the timestamp fix) | 15:32 |
| nessita | ralsina_: I have syncdaemon running all the time since MOnday | 15:33 |
| nessita | ralsina_: but not from installer | 15:33 |
| ralsina_ | nessita: it runs. But does it do anything? | 15:33 |
| nessita | ralsina_: from time to time, yes | 15:33 |
| nessita | ralsina_: you suggesting that we need to coordinate opening the control panel with some sync stuff? maybe... | 15:33 |
| nessita | ralsina_: can you reproduce not using installed stuff? | 15:34 |
| ralsina_ | nessita: not trivial to reproduce that way, because of how I setup things. I am going to try to get better traces and take a short look myself. | 15:35 |
| alecu | ralsina_, is it perhaps because of the 965 files your syncdaemon still has as pending upload? | 15:35 |
| alecu | ralsina_, or have you deleted all the metadata? | 15:35 |
| ralsina_ | alecu: I deleted the metadata, started uploading that again (and seems to be working) | 15:35 |
| ralsina_ | then tried u1cp, got this. I will try to research a bit better, so I will be away a bit, on the other session. | 15:36 |
| alecu | ralsina_, so, I'm tracing the "emit_signal" method that's printing this, and it seems to be harmless | 15:37 |
| ralsina_ | alecu: good. | 15:37 |
| alecu | ralsina_, the thing is that syncdaemon is not finding that method on the ipc client, and it's just printing this as a warning | 15:37 |
| alecu | ralsina_, perhaps we should make this a bit more silent | 15:37 |
| alecu | ralsina_, but it's certainly harmless | 15:37 |
| ralsina_ | alecu: or implement a dummy so it doesn' t fail ;-) | 15:38 |
| alecu | _emit_failure() in ipc.py is the errback for this errors, and it's just logging the warnings. | 15:38 |
| alecu | ralsina_, I'm not sure it makes much sense to implement a dummy | 15:38 |
| alecu | ralsina_, since these are signals | 15:38 |
| alecu | ralsina_, and they should be ignored if there's nothing subscribed to them.. | 15:39 |
| ralsina_ | alecu: it's because it's missing on StatusClient. It's trivial to fix. | 15:39 |
| alecu | ralsina_, I think we should handle the "NoSuchMethod" exception, and log the rest | 15:39 |
| alecu | ralsina_, since this will happen for all other signals that are not implemented, I think the sensible thing would be to ignore missing signal handlers | 15:41 |
| ralsina_ | alecu: ok, makes sense | 15:41 |
| ralsina_ | alecu: it really makes following problems in u1cp difficult because of the noise | 15:41 |
| alecu | ralsina_, I'll make a branch to fix this and I'll push it in just a few minutes. | 15:42 |
| ralsina_ | alecu: awesome | 15:42 |
| * alecu loves pluging the monitor in the laptop and it *just working* | 15:44 | |
| nessita | alecu: in linux i'm getting some lint issues | 15:45 |
| nessita | ./tests/platform/windows/test_filesystem_notifications.py: | 15:45 |
| nessita | 755: local variable 'd' is assigned to but never used | 15:45 |
| nessita | 1208: local variable 'd' is assigned to but never used | 15:45 |
| nessita | alecu: can you fix and let me know? | 15:45 |
| alecu | nessita, will do | 15:46 |
| alecu | que grande lint! | 15:48 |
| alecu | I mean: | 15:48 |
| alecu | que grande, pyflakes! | 15:48 |
| alecu | nessita, pushed | 15:50 |
| nessita | alecu: thanks | 15:51 |
| alecu | ralsina_, I think that instead of logging the huge stacktrace as a WARNING, we should be just logging a line with the name of the method that was not found in the DEBUG log level. | 15:53 |
| alecu | ralsina_, would that be too noisy too? | 15:53 |
| ralsina_ | alecu: it would be a 25x improvement at least :-) | 15:53 |
| alecu | ralsina_, I think it might help for debugging if an issue like this ever happens backwards | 15:54 |
| alecu | ralsina_, ok, I'm doing it like that. | 15:54 |
| ralsina_ | alecu: +1 on that | 15:54 |
| ralsina_ | confirmed that with the timestamp fix, syncdaemon uploads like a champion. Huge folder tree with a ton of small files in it, uploaded perfect. | 15:55 |
| * mandel wants to kill himself due to his connection... | 15:57 | |
| alecu | ralsina_, !!!!!!! | 16:02 |
| alecu | ralsina_, wowowowo! | 16:02 |
| nessita | ralsina_: can I ask you to do another test? | 16:02 |
| ralsina_ | nessita: sure! | 16:02 |
| * alecu remembers that "a champion" means "a standard tennis shoe" in .uy | 16:03 | |
| alecu | and shoes do lousy uploads. | 16:03 |
| nessita | ralsina_: setup 2 clients for the same user, in one do bzr branch lp:ubuntuone-client -> wait for all the uploads and downloads in the other client to finish, run make check in the second client | 16:04 |
| ralsina_ | nessita: ok | 16:04 |
| ralsina_ | will try that, brb | 16:04 |
| alecu | nessita, you sick sadistic you. You can't stand champions, right? | 16:04 |
| nessita | alecu: :-D | 16:05 |
| nessita | alecu: you should wait for the next test I have prepared after that :-P | 16:05 |
| alecu | rotfl | 16:05 |
| * ralsina_ is about to write a thingy that creates random folders with random names with random content in it. | 16:06 | |
| nessita | ralsina_: the thing is that we need to compare those random stuff against something to check nothing is corrupt, and using random data is difficult | 16:07 |
| ralsina_ | nessita: it's actually rather trivial. | 16:07 |
| dobey | lunch time, bbiab | 16:07 |
| nessita | ralsina_: yes? please teach me! | 16:07 |
| ralsina_ | nessita: create the structure, do a os.walk recording pathnames and checksums, wait until upload, stop everything, remove metadata, move everything out of ~/Ubuntu One, start syncdaemon again, wait, run os.walk again, compare them. | 16:08 |
| ralsina_ | or use two profiles, f course | 16:09 |
| nessita | ralsina_: that is a good tests, but there is something that we need to test that that doesn't cover | 16:09 |
| ralsina_ | nessita: it' s called fuzzing, it's meant to test " stuff we didn't think about" :-) | 16:09 |
| nessita | ralsina_: that syncdaemon acts properly to server notifications, and for that, we need the 2 syncdaemon clients working simultaneously | 16:10 |
| ralsina_ | nessita: then that same thing using 2 profiles. | 16:10 |
| nessita | ralsina_: I would like to do that but having 2 syncdaemon working at the same time (2 vms will require, yes) | 16:10 |
| ralsina_ | nessita: no, just two user profiles in one | 16:10 |
| nessita | ralsina_: or that, yes :-) | 16:10 |
| * ralsina_ creates another user then | 16:10 | |
| nessita | verterok: approving your branch! | 16:11 |
| nessita | (ran tests in all platforms) | 16:11 |
| verterok | nessita: cool, thanks | 16:12 |
| ralsina_ | nessita: I currently have two sessions, one uploading the bzr branch the other downloading... seems to be evolving correctly so far :-) | 16:21 |
| nessita | ralsina_: that's GREAT news | 16:21 |
| ralsina_ | and it' s not even making the notebook slow down. f course I have a 4-core i5 ;-) | 16:22 |
| nessita | mandel: I'm about to approve your file shelf branch | 16:24 |
| nessita | mandel: when the l;inux make check finish, you get my +1 | 16:25 |
| nessita | alecu: you got my +1 already | 16:25 |
| nessita | alecu: while running review tests I found a couple of trivial thing to fix, so, can you please: https://code.launchpad.net/~nataliabidart/ubuntuone-client/bar-baz/+merge/70590 | 16:26 |
| nessita | alecu: is pretty trivial | 16:26 |
| mandel | nessita: cool, I'm right now pushing the next with the fix on the commit_partial method, there are some tests that fail on windows due to ro, I'll write the expected failures in the MP | 16:26 |
| mandel | ralsina_: with that ^ you can try to do an other IRL that will allow to download big files :) | 16:26 |
| alecu | nessita, will do, thanks | 16:26 |
| ralsina_ | mandel: will do after I finish the current torture test :-) | 16:27 |
| gatox | ralsina_, now that the qapplication is back in the windows.py (installer), do you prefer that i moved the stylesheet and font setup from gui.py to windows.py? | 16:27 |
| * nessita votes "yes please" | 16:27 | |
| mandel | ralsina_: will ping you, and _nessita when ready | 16:27 |
| ralsina_ | gatox: yes | 16:27 |
| gatox | ralsina_, ok! | 16:28 |
| alecu | nessita, "Author: Alejandro J. Cura <alecu@canonical.com>" ??? | 16:28 |
| ralsina_ | gatox: also, I get *occasional* errors about "can't parse the stylesheet" when using binaries. I hae no idea whatsoever about why. | 16:28 |
| nessita | alecu: with that branch, I get: (skips=13, failures=40, errors=93, successes=2033) | 16:28 |
| nessita | alecu: yes, is a copy of what you did | 16:28 |
| nessita | alecu: so you are the author :-D | 16:28 |
| gatox | ralsina_, do you have any particular example where i can take a look? | 16:29 |
| ralsina_ | gatox: no. it just happens every once in a while. | 16:29 |
| ralsina_ | And says exactly that in stderr | 16:29 |
| alecu | nessita, 135 -> 93... nice! | 16:29 |
| gatox | ralsina_, weird... i'll take a look at that | 16:29 |
| alecu | nessita, I'll run tests on it right away | 16:29 |
| ralsina_ | gatox: don't worry about it, really, it may happen only here for all I know. | 16:30 |
| ralsina_ | gatox: looks like a problem loading the resource to me, but I don't have any rationale for it | 16:30 |
| gatox | ralsina_, ok... let me know if it becames a problem | 16:31 |
| * mandel Error 15 (net::ERR_SOCKET_NOT_CONNECTED): Unknown error. | 16:35 | |
| mandel | nessita, ralsina_, alecu: please: https://code.launchpad.net/~mandel/ubuntuone-client/dont-use-shutil-move/+merge/70595 | 16:38 |
| nessita | mandel: on it | 16:38 |
| ralsina_ | nessita, alecu, mandel: update on the torture test. Upload and download progressing. Only errors I saw are in the uploader about files being removed before they were hashed, which is, I think, normal. | 16:38 |
| mandel | I have not run it on linux, I'm trying at the moment but I'm getting some issues :( | 16:38 |
| mandel | ralsina_: ein? | 16:39 |
| mandel | ralsina_: why is it normal? | 16:39 |
| mandel | is it realted to the tests? | 16:39 |
| ralsina_ | mandel: I am doing a bzr branch inside u1. The limbo files are there only for a fraction of a second. | 16:39 |
| ralsina_ | mandel: so, sd gets the file creation, puts it in the queue to be hashed, but when it gets to it, it's gone already | 16:40 |
| ralsina_ | mandel: and it's a nicely formatted error, not a thrown exception or anything ;-) | 16:40 |
| mandel | ralsina_: ah… nice :) | 16:40 |
| ralsina_ | u1-client is 58 freaking MBs????? | 16:41 |
| mandel | ralsina_: yeah… does bzr use desktopcouch as the backend... | 16:42 |
| mandel | hehehe | 16:42 |
| nessita | ralsina_: why are files being removed? I mean, did you remove those files? | 16:42 |
| ralsina_ | nessita: no, just the rdinary way bzr works. Files are created and removed during a branch. | 16:43 |
| nessita | mandel: file shelf approved | 16:43 |
| mandel | nessita, ralsina_, alecu: EOD here, please take a look at the branch and let me know, any comments will be fixed early my morning on monday | 16:43 |
| nessita | ralsina_: ok, please once all the torture-nessita-tests is done, send me all the logs (probably you will get more than one) | 16:43 |
| mandel | have all a great weekend!!!! that includes gatox too :P | 16:43 |
| nessita | mandel: ack | 16:43 |
| ralsina_ | mandel: you too! | 16:43 |
| gatox | mandel, byeee! | 16:43 |
| nessita | ralsina_: if you have some slot, could you give a second review to https://code.launchpad.net/~mandel/ubuntuone-client/fix-file-shelf-windows/+merge/70021 ? | 16:44 |
| ralsina_ | nessita: expect a tarazillion megabites of logs. I am running n --debug | 16:44 |
| nessita | ralsina_: --debug does not add extra debug, but logs to terminal and to a different file | 16:44 |
| ralsina_ | nessita: ok then | 16:44 |
| nessita | ralsina_: but yeah, huge log file is welcomed | 16:44 |
| === beuno is now known as beuno-lunch | ||
| alecu | nessita, with your new branch, I get: FAILED (skips=13, failures=47, errors=105, successes=2006) | 16:51 |
| nessita | alecu: may be the action queue random failing tests | 16:51 |
| nessita | alecu: you branch has not yet landed, afaik | 16:51 |
| alecu | nessita, that's right! | 16:52 |
| ralsina_ | nessita: +1 on bar/baz | 16:59 |
| nessita | greap | 16:59 |
| nessita | great :) | 16:59 |
| nessita | lunchtime! | 17:11 |
| ralsina_ | looks like u1 is really not optimized for creating and then deleting a bazillion small files in u1. The hashing of a ton of unexisting files takes forever. Then again, killing sd and starting it again clears that up. | 17:17 |
| alecu | ralsina_, gatox: if you can, please review https://code.launchpad.net/~alecu/ubuntuone-client/fix-add-watch-raceconditions/+merge/70559 | 17:17 |
| gatox | alecu, on it | 17:17 |
| alecu | ralsina_, the average user is not a developer, so it does not have a bazillon tiny sourcecode files. Nor a sysadmin, having a morzillon emaildirs. | 17:19 |
| alecu | ralsina_, our average user has lots of music and images, though :-) | 17:19 |
| ralsina_ | alecu: agreed. Just that for the test, it got stuck there for [whoknows] hours, so I had to kill it to purge that :-) | 17:19 |
| alecu | uhhhh.... I got to go to the baaaaank | 17:19 |
| ralsina_ | alecu: the many files is not even the problem. It's create/delete really quick | 17:20 |
| gatox | alecu, +1 | 17:22 |
| alecu | gatox, grax! | 17:22 |
| gatox | (branch) | 17:22 |
| gatox | alecu, ralsina_, nessita small branch for review: bzr push lp:~diegosarmentero/ubuntuone-windows-installer/icon-signin | 17:22 |
| ralsina_ | gatox: got the merge url? | 17:23 |
| gatox | clean some styleSheet and font setup stuff... add application icon, and fix the ui style for sign in page | 17:23 |
| gatox | ralsina_, sorry... wrong paste :P | 17:23 |
| gatox | ralsina_, nessita, alecu https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/icon-signin/+merge/70603 | 17:23 |
| ralsina_ | gatox: got it | 17:26 |
| alecu | gatox, I'll do it after bank and lunch | 17:26 |
| dobey | everything going well for you guys on tarmac front? just checking :) | 17:30 |
| ralsina_ | nessita: the trace I gave earlier about the unimplemented method was caused by an accepted share being deleted from the website, so that will show up again when we test shares. | 17:31 |
| nessita | ralsina_: great(ish) | 17:45 |
| nessita | gatox: on it! | 17:45 |
| ralsina_ | nessita: the torture is finished. And the trees are identical. | 17:46 |
| nessita | ralsina_: make check worked?!?!?! | 17:46 |
| ralsina_ | nessita: will have definitive answer to that in a few minutes | 17:46 |
| ralsina_ | nessita: but a tree comparison tells me this looks just like trunk | 17:47 |
| nessita | that's great! | 17:47 |
| ralsina_ | nessita: However... I had to restart syncdaemon once on the receiving side for it to finish downloading. It was sitting with an empty queue. | 17:47 |
| nessita | ralsina_: sitting with an empty queue? not sure what that means | 17:48 |
| nessita | ralsina_: you mean it will not download anything? | 17:48 |
| ralsina_ | nessita: it had downloaded about 70% of the files, and was not downloading anymore. | 17:48 |
| ralsina_ | nessita: then, I restarted it, and downloaded the rest | 17:49 |
| ralsina_ | and when it was not downloading it was logging " Queue: 0" | 17:49 |
| nessita | ralsina_: hum, you should report this to chicharreros, be sure to save those logs from the 2 runs: while sitting, and after | 17:49 |
| nessita | ralsina_: did you wait "long enough"? sometime the notifications from the server takes some time | 17:49 |
| ralsina_ | nessita: probably not long enough | 17:50 |
| ralsina_ | nessita: I wanted to check for corruption more that I wanted to check that | 17:50 |
| ralsina_ | nessita: but as soon as I started it, it started downloading, if that means anyhing. | 17:50 |
| nessita | right | 17:50 |
| nessita | ralsina_: may mean that the notification wasn't there yet, so I will not worry for now | 17:50 |
| dobey | grrrrr | 17:51 |
| dobey | brb | 17:51 |
| ralsina_ | nessita: but I think we have reason to be happy, this was pretty hardcode testing of the core, and it worked well | 17:51 |
| nessita | indeed | 17:53 |
| ralsina_ | nessita: make tests works/fails the same as the original. | 17:56 |
| ralsina_ | nessita: also, our tests fail miserably when you run them on a removable vfat drive :-) | 17:56 |
| nessita | ralsina_: got a trace? Im curious | 17:57 |
| ralsina_ | sure | 17:58 |
| ralsina_ | nessita: http://pastebin.ubuntu.com/659452/ | 18:00 |
| ralsina_ | I think that's because on vfat there are no ACLs | 18:00 |
| nessita | right | 18:02 |
| nessita | another reason to ignore read-only stuff | 18:02 |
| ralsina_ | yep | 18:03 |
| nessita | gatox: ping | 18:14 |
| gatox | nessita, pong | 18:16 |
| nessita | gatox: can you please change the qss loading code to use QResource instead of QtCore.QFile(":/ubuntuone.qss")? | 18:16 |
| gatox | nessita, ahhhh okok | 18:16 |
| ralsina_ | nessita: good catch | 18:21 |
| === beuno-lunch is now known as beuno | ||
| gatox | nessita, ralsina_ branch updated: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/icon-signin/+merge/70603 | 18:47 |
| nessita | gatox: ack | 18:48 |
| gatox | ralsina_, also... this branch is approved... but is not being merged.. (https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/titles-on-pages/+merge/70169) | 18:48 |
| gatox | i don't know why | 18:48 |
| gatox | nessita, ^ | 18:48 |
| nessita | gatox: no commit message | 18:48 |
| gatox | nessita, ohhhhhhhh..... fixing it | 18:48 |
| ralsina_ | nessita: http://ubuntuone.com/p/18bT/ -- it's justa rough draft | 18:53 |
| nessita | ralsina_: looking | 18:53 |
| ralsina_ | for example, I am not thrilled by the spacing between the two areas in the tab, and it's missing a horizontal line (which is easy to add, though) | 18:54 |
| nessita | ralsina_: you broke the 2 group boxes | 18:54 |
| ralsina_ | nessita: indeed I did | 18:54 |
| nessita | ralsina_: each group is "independent" from the other | 18:54 |
| ralsina_ | nessita: if you want the buttons to be the same size, they need to be in a single layout | 18:55 |
| ralsina_ | and a layout can't get into two groupboxes | 18:55 |
| ralsina_ | that "independence" is what made it look bad | 18:55 |
| nessita | ralsina_: semantically they are 2 different, idependent groups, so merging into one seems wrong to mw | 18:55 |
| ralsina_ | you are confusing presentation and logic | 18:55 |
| nessita | ralsina_: aux le contraire mon ami :-) | 18:56 |
| ralsina_ | hehehe | 18:56 |
| nessita | ralsina_: at least from my POV, presentation can not break logic | 18:56 |
| ralsina_ | if we were to have an arbitrary number of independent groups? I would have them. For two? It's not important, IMHO. | 18:56 |
| ralsina_ | nessita: you are getting all that data from a single dictinary. You split them yourself in u1cp ;-) | 18:57 |
| nessita | ralsina_: I "highly" disagree re "is not that important" :-). I prefer to hard code a button width | 18:57 |
| ralsina_ | nessita: NO | 18:57 |
| ralsina_ | I will disapprove any branch that hardcodes a button width | 18:57 |
| ralsina_ | sorry, but you have your standards, I have mine ;-) | 18:57 |
| nessita | ralsina_: start reverting what's in trunk then :-) | 18:58 |
| ralsina_ | nessita: I probaby should eventually | 18:58 |
| ralsina_ | nessita: hardocded widget sizes are evil. | 18:58 |
| nessita | ralsina_: conceptually, they are two different groups of information. We even had them in 2 tabs, so we can't just go an merge them visually | 18:58 |
| nessita | ralsina_: I agree, that was I was seeking another clean option | 18:59 |
| ralsina_ | nessita: add a line in the middle. | 18:59 |
| nessita | this is not clean either | 18:59 |
| ralsina_ | it looks a ton better | 18:59 |
| nessita | ralsina_: the looks doesn't matter when the insights have cellulitis :-P | 18:59 |
| ralsina_ | nessita: there is no logic change at all. Just a change in the tree structure of the widgets. | 19:00 |
| nessita | ralsina_: you're abusing the widget set to accommodate your needs. I will not do that, not easily at least | 19:00 |
| ralsina_ | nessita: and you are pushing your internal logic into the presentation. That's not good. | 19:01 |
| ralsina_ | "abusing"? Whoa. | 19:01 |
| ralsina_ | I just moved 5 widgets outside of two boxes, and removed the boxes :-) | 19:01 |
| nessita | ralsina_: conceptually they are 2 independent groups, we should be able to grab a "widget" (either profile or services) and move it to another tab, without loosing formatting nor layout | 19:01 |
| ralsina_ | nessita: and you can. | 19:02 |
| ralsina_ | nessita: just as easily as before | 19:02 |
| nessita | ralsina_: no, before you grab a groupbox and dump it wherever you like, now you have to pick a button from here, a label from there and a title from somewhere else | 19:02 |
| ralsina_ | nessita: and it looks misaligned everywhere. | 19:03 |
| nessita | ralsina_: think about each grouping to be a widget itself | 19:03 |
| nessita | actually, each grouping should be a widget itself | 19:03 |
| ralsina_ | nessita: you are showing the internal logic in the UI. That is actually *bad*. | 19:03 |
| nessita | ralsina_: you keep saying that :-), and I don't agree to that | 19:03 |
| ralsina_ | The UI has to be guided by the user experience, not by the design of your code. | 19:03 |
| ralsina_ | You can not agree and be wrong, you know. | 19:04 |
| nessita | ralsina_: 100% agreed. And this is not leacking logic into the UI, is using the right widget for the right needs | 19:04 |
| ralsina_ | nessita: it totally is leaking logic. | 19:04 |
| nessita | ralsina_: and of course, you and I and everyone can be wrong, we're humans :-) | 19:04 |
| ralsina_ | nessita: you say " they are separate groups". Says who? Your app logic. | 19:05 |
| nessita | ralsina_: that's what you think, so it would be better if you prepend "I think you're leaking logic" | 19:05 |
| ralsina_ | nessita: indeed. I think it's obvious you are leaking logic. And you also hink leaking logic is not bad :-) | 19:05 |
| nessita | ralsina_: they are conceptually 2 different groups of info, like a folder list is, oh exactly that, a list of folders | 19:05 |
| nessita | ralsina_: I agree leaking logic is bad. I don't think I'm leaking logic. | 19:06 |
| ralsina_ | nessita: yes. Now, does a list of folders consist of 50 different misaligne widgets? No. | 19:06 |
| nessita | ralsina_: exactly, that's why we use a listsomething | 19:06 |
| nessita | so, we have 2 pieces of info that has independent goals and transmit independent information | 19:06 |
| ralsina_ | nessita: good. Now, a difference is that a list of folders is of variable length. | 19:07 |
| nessita | no matter how we "logic" that | 19:07 |
| ralsina_ | This is of fixed length. | 19:07 |
| nessita | ralsina_: nopes | 19:07 |
| ralsina_ | In fact, it's displaying a fixed set of fields. | 19:07 |
| nessita | ralsina_: I agreet this is a list of 2 items: profile info and services info | 19:07 |
| nessita | that's why this is a vertical layout | 19:07 |
| nessita | with 2 items in it | 19:07 |
| ralsina_ | Problem 1: That way of laying it out looks horrible. | 19:08 |
| ralsina_ | "I think" ;-) | 19:08 |
| ralsina_ | Now, you can also consider it as a display of 2 things. Not a list of two items, because the items are heterogeneous. | 19:09 |
| nessita | not sure what you mean | 19:09 |
| ralsina_ | ie: it's not like a list of folders, because thing A (email, name) is not like thing B (list of plans) | 19:09 |
| nessita | ralsina_: when thinking of the outter layout you should not look "into" each group content | 19:10 |
| ralsina_ | nessita: we know what we want to display. | 19:10 |
| ralsina_ | nessita: ignoring that is not conducing to clean design of the UI | 19:10 |
| nessita | ralsina_: this is where I think you're "abusing" the toolkit: you depend on what each grouping has to propose this layout | 19:11 |
| ralsina_ | I intentionally flattened it so there is no " outer" and "inner" layouts. That's the whole idea. | 19:11 |
| ralsina_ | nessita: but we know that. | 19:11 |
| nessita | ralsina_: then that's where we disagree the most | 19:11 |
| ralsina_ | so, yes, I confess, I designed the layout considering what it has to display. | 19:11 |
| nessita | ralsina_: you designed the outter layout considering what each inner group has to display ;-) | 19:12 |
| nessita | which is not the same | 19:12 |
| ralsina_ | I designed the layout in its entirety that way. Ther only "inner" layout is grouping email and name. | 19:12 |
| ralsina_ | Which I would be happy to replace with a single label that accepts newlines | 19:12 |
| nessita | ralsina_: by inner layout I mean the whole content of each group | 19:13 |
| nessita | no the grouping of email and name | 19:13 |
| ralsina_ | nessita: I didn't design it in groups. I designed it in a table with one empty separating row | 19:13 |
| nessita | ralsina_: think each grouping as a widget that shows info and offers an action thru a button | 19:13 |
| ralsina_ | which I am again happy to replace with a line | 19:13 |
| nessita | so we can have 2 instance: | 19:13 |
| nessita | the profile instance, and the services instance | 19:13 |
| nessita | ralsina_: how would you solve this if each grouping is a widget | 19:14 |
| nessita | ? | 19:14 |
| ralsina_ | nessita: it would be very very difficult. That's why it makes no sense to do it that way. | 19:14 |
| ralsina_ | or, I would use a form layout | 19:15 |
| nessita | let me check what's a form layout | 19:15 |
| ralsina_ | but it's a tradeoff. If you create megawidgets (things containing other widgets), combining them in windows is very difficult. That's the bad side of them. | 19:16 |
| ralsina_ | ok, gotta pick the kid, be back in 15' | 19:16 |
| nessita | ack | 19:16 |
| gatox | nessita, can you approve this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/icon-signin/+merge/70603 please?? | 19:28 |
| nessita | gatox: I'm still reviweing, trying to run stuff in windows (I'm having some issues) | 19:29 |
| nessita | can't run the installer, I'm debuggin | 19:29 |
| nessita | g | 19:29 |
| gatox | nessita, ok..... let me know if i can help with something | 19:30 |
| nessita | sure | 19:31 |
| nessita | gatox: I have a conflict now, with trunk | 19:32 |
| nessita | Text conflict in data/qt/ubuntuone.qss | 19:32 |
| nessita | 1 conflicts encountered. | 19:32 |
| nessita | gatox: can you fix please? | 19:32 |
| gatox | nessita, on it | 19:33 |
| gatox | nessita, ready!!! it's easy when i know both versions of the file :P | 19:35 |
| nessita | re branching | 19:35 |
| nessita | gatox: you added an empty line insde | 19:36 |
| nessita | QLabel#title_label{ | 19:36 |
| nessita | font-size: 20px; | 19:36 |
| nessita | } | 19:36 |
| gatox | nessita, ....crap... sorry..... | 19:37 |
| gatox | nessita, now should be ready | 19:38 |
| ralsina | I'm back | 19:41 |
| nessita | gatox: dude | 19:42 |
| nessita | I have this in the qss | 19:42 |
| nessita | QLabel#image_label{ | 19:42 |
| nessita | border-style: dotted; | 19:42 |
| nessita | border-color: #939389; | 19:42 |
| nessita | border-bottom-width: 1px; | 19:42 |
| nessita | border-top-width: 1px; | 19:42 |
| nessita | QLabel#title_label{ | 19:42 |
| nessita | font-size: 20px; | 19:42 |
| nessita | } | 19:42 |
| nessita | there is a missing } | 19:42 |
| gatox | nessita, omg... | 19:42 |
| gatox | nessita, that's for trying to fixing it really quick | 19:43 |
| nessita | ralsina: I'm doing something in between you're proposal and my standards, but I have a question | 19:43 |
| ralsina | nessita: sure | 19:44 |
| nessita | ralsina: how can I set style so the dotted line is in place when using a grid layout? | 19:44 |
| ralsina | nessita: add a "horizontal line" widget, set it to dotted style, and make it span all columns | 19:44 |
| nessita | is not like I can have a frame or similar around the profile box and set border bottom ro it | 19:44 |
| nessita | to it* | 19:44 |
| nessita | ralsina: but this is only style, I'm not sure we should add a "line" widget. Can we set style so, for example, each row in a grid line has a border that we can customize? | 19:45 |
| nessita | in a grid form* | 19:45 |
| ralsina | No, it's not a grid widget but a grid layout, and grid layouts are not visible | 19:45 |
| ralsina | layouts in general are not visible. For visible things you need to use widgets | 19:46 |
| nessita | right | 19:46 |
| ralsina | If you add a container widget, you are back in your old layout | 19:46 |
| ralsina | I you want semantic separation, the widget for that is a line | 19:47 |
| nessita | ralsina: how can I make a widget span columns? | 19:47 |
| nessita | doesnt matter, I'll google | 19:48 |
| nessita | thanks! | 19:48 |
| ralsina | drag the edge you want to span | 19:48 |
| ralsina | ok, that was unclear. Drag the side you want to extend towards the column you want to cover | 19:48 |
| ralsina | maybe that made a bit more sense :-) | 19:48 |
| ralsina | You can only span one column on each drag, so it may take a few tries to get it right | 19:48 |
| nessita | editing the xml was easier :-P | 19:49 |
| ralsina | nessita: hehe | 19:50 |
| dobey | thisfred: ping | 19:56 |
| gatox | nessita, done... (sorry): https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/icon-signin/+merge/70603 | 19:56 |
| thisfred | dobey: pong | 19:56 |
| thisfred | what did I break now? | 19:56 |
| dobey | thisfred: mterry proposed a branch against u1couch a couple weeks ago. could you review it please? :) | 19:57 |
| gatox | nessita, ralsina also i've just submited this branch that adds some missing titles: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/missing-titles/+merge/70624 | 19:57 |
| nessita | gatox: ack | 19:57 |
| ralsina | gatox: got it | 19:57 |
| thisfred | dobey ah sure. I have been filtering pretty much all merge proposals, recently. I wish lp would put the project name in the subject | 19:57 |
| dobey | thisfred: it puts it in the headers | 19:59 |
| dobey | and technically in the subject, given it is part of the branch location strings | 20:00 |
| thisfred | dobey, yeah, in its own custom headers. Almost no email clients can filter on those | 20:00 |
| dobey | i thought notmuch was magical | 20:00 |
| dobey | you use notmuch+emacs. you don't get the "it can't filter" argument :) | 20:01 |
| thisfred | dobey: it is, and that feature is planned, but not landed ;) | 20:01 |
| dobey | you can't regex arbitrary headers? | 20:01 |
| dobey | lame. | 20:01 |
| ralsina | gatox: looks good to me | 20:02 |
| gatox | ralsina, ok! :D | 20:03 |
| thisfred | dobey: since the search is xapian, it has to index those headers before they can be searched, and currently it only indexes the usual headers | 20:04 |
| nessita | ralsina: you sure the line gets visible drawn? I get nothing IRL | 20:04 |
| thisfred | dobey: for mps as you say, the info is in the subject anyway. Where it's really annoying is bug mail. | 20:05 |
| ralsina | nessita: they should unless something weird is done using qss | 20:07 |
| ralsina | nessita: do you see it in the preview in designer? | 20:07 |
| nessita | ralsina: preview is just the designer itself? | 20:07 |
| ralsina | nessita: ctrl+r in designer | 20:07 |
| nessita | ralsina: yes, the line is there | 20:08 |
| ralsina | nessita: or the menu form -> Preview, or form -> Preview in -> a style | 20:08 |
| ralsina | nessita: then I blame gatox | 20:08 |
| dobey | thisfred: right, but you can just ignore bug mails :) | 20:08 |
| ralsina | ;-) | 20:08 |
| thisfred | dobey: belieme I do :) | 20:09 |
| ralsina | nessita: did you remember to compile it?> | 20:09 |
| nessita | ralsina: good point, but yes, I've learn to do compile always before running the ui | 20:09 |
| nessita | ralsina: I'll play with the qss then | 20:09 |
| ralsina | nessita: can you push it? I can take a look | 20:09 |
| nessita | ralsina: I'll try for a couple of minutes and then I'll seek your help if I don't succeed, sounds ok? | 20:10 |
| ralsina | nessita: cool | 20:10 |
| nessita | ralsina: did you run tests for gatox's branch re: icons? I get failures... a lot | 20:10 |
| nessita | ralsina: but maybe is my silly env | 20:11 |
| ralsina | nessita: let me re-check, I think I did | 20:11 |
| ralsina | nessita: got the link handy? | 20:11 |
| nessita | https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/icon-signin/+merge/70603 | 20:12 |
| nessita | gatox: other than the tests failing for me, +1 | 20:12 |
| ralsina | he, I have like 100 devices configured, and the devices tag seems to call find_credentials once for each | 20:13 |
| gatox | nessita, what failures?? that branch doesn't touch any code (except for setting the stylesheet... that is working...) | 20:13 |
| ralsina | My account is becoming a collection of corner cases | 20:13 |
| ralsina | nessita: indeed that's why I didn't run the tests. | 20:14 |
| ralsina | I am running them now though | 20:14 |
| nessita | gatox: I know, that's why I will approve if they run ok for ralsina :-) | 20:14 |
| gatox | nessita, ok... anyhow... weird :S | 20:15 |
| gatox | nessita, can i move both branches to approved? | 20:15 |
| nessita | gatox: both? no! I haven't look the second | 20:16 |
| nessita | :-) | 20:16 |
| alecu | ralsina, you'll like this branch: https://code.launchpad.net/~alecu/ubuntuone-client/ignore-missing-signal-handlers/+merge/70626 | 20:16 |
| gatox | nessita, ahhhhh ok | 20:16 |
| ralsina | nessita: tests pass just fine | 20:16 |
| nessita | ralsina: ack approving | 20:16 |
| ralsina | alecu: yes I will! | 20:16 |
| ralsina | alecu: anyway, that signal is triggered by removing an accepted share from the web, so it has to be implemented eventually | 20:17 |
| nessita | gatox: you can now approve the icon-signin | 20:17 |
| gatox | nessita, awesome | 20:17 |
| ralsina | alecu: OTOH it only makes a difference if you had control panel open on the folders tab when you removed the share and expect it to update, so not really important at all ;-) | 20:18 |
| ralsina | alecu: makes a *big* difference, thanks :-) | 20:19 |
| alecu | ralsina, great. It seems like the cleanest solution so far. | 20:19 |
| ralsina | alecu: indeed . +1 after IRL testing from me | 20:20 |
| ralsina | alecu, nessita, gatox: I will build the installer late tonight. I would love if each of you sends me an email with branches you want in it. For example, nessita, you may want your improve-ui branch even if it's not merged, so design can look at it and have feedback for you on monday. | 20:21 |
| nessita | gatox: can you please add tests to the last branch you proposed? | 20:21 |
| nessita | gatox: so we ensure titles are set now and always in the future | 20:22 |
| gatox | nessita, ok | 20:22 |
| gatox | ralsina, ok | 20:23 |
| ralsina | so, alecu, nessita, gatox: consider that as part of your EOD email reports :-) | 20:24 |
| alecu | ralsina, I've got only the branch you've just reviewed to include in today's installer | 20:25 |
| ralsina | nessita: also, remember https://code.launchpad.net/~ralsina/ubuntuone-client/find_config_files/+merge/70472 please | 20:26 |
| nessita | ralsina, gatox: can I set style to a Line? | 20:26 |
| alecu | ralsina, and right now I need to go fetch Amelia from kinder, and do some errands; will work a bit more tonight, but lateish | 20:26 |
| gatox | nessita, a line is a qframe | 20:26 |
| nessita | ralsina: what do you want me to prioritize? ui or the review (I have little time left) | 20:26 |
| ralsina | alecu: tha's ok | 20:26 |
| gatox | nessita, do you mean a line separator? | 20:26 |
| ralsina | nessita: I' d say the UI, I can put my branch in anyway | 20:26 |
| nessita | gatox: I mean the thingy that is called "Horizontal Line" in designer, but saying that is a qframe gave some ideas of what's wrong | 20:27 |
| gatox | nessita, yes, that line is a qframe | 20:28 |
| nessita | ralsina: there was a border: none for QFrame.... who on earth will think that a line is a qframe? | 20:28 |
| ralsina | nessita: well, there is no Line widget. That's weird | 20:28 |
| ralsina | and QLine is something completely different. Welcome to the part of Qt that is not well documented :-( | 20:29 |
| nessita | ralsina, gatox: I'm using this qss | 20:33 |
| nessita | 39 QFrame#account_separator { | 20:33 |
| nessita | 40 border-style: dotted; | 20:33 |
| nessita | 41 border-color: #939389; | 20:33 |
| nessita | 42 border-width: 1px; | 20:33 |
| nessita | 43 } | 20:33 |
| nessita | for the line, but it looks ugly, see http://ubuntuone.com/p/18cS/ | 20:33 |
| nessita | the line is "too tall" | 20:33 |
| * gatox looking... | 20:34 | |
| ralsina | use border only on the bottom edge | 20:34 |
| nessita | shall I set a border-height? that may make no sense | 20:34 |
| nessita | ah! | 20:34 |
| nessita | that makes sense | 20:34 |
| gatox | nessita, yep | 20:35 |
| nessita | ralsina: all screenshots updated in the shares | 20:40 |
| nessita | share* | 20:41 |
| ralsina | nessita: cool | 20:41 |
| gatox | nessita, tests added | 20:41 |
| nessita | ralsina: let me know if that works for you, and I'll push the changes | 20:41 |
| ralsina | nessita: looking... | 20:41 |
| ralsina | nessita: much nicer | 20:41 |
| nessita | yeap | 20:42 |
| ralsina | lisette is probably going to complain about the vertical alignment but let's wait until she does :-) | 20:42 |
| ralsina | And the labels are misaligned on the left side, if you have time to fix it. If you don't, I said nothing ;-) | 20:42 |
| nessita | ralsina: I was hoping to get feedback before and have a talk with her, I have more question about padding and aligmens | 20:43 |
| nessita | ralsina: so, before applying any style to that, I prefer talking to her | 20:43 |
| ralsina | nessita: yes, those things have to be reviewed by them, but I meant alignment between the email/name and the plan | 20:44 |
| nessita | ahy | 20:44 |
| nessita | ah* | 20:44 |
| ralsina | whatever the padding those three are going to be aligned, I think | 20:44 |
| ralsina | But yes, I'll mention in the mail for lisette that we need padding/alignment reviews all across u1cp | 20:45 |
| ralsina | nessita: but hey, good work! | 20:46 |
| nessita | thanks! | 20:46 |
| * ralsina is the crazy widget alignment guy, if that makes you feel any better | 20:46 | |
| nessita | gatox: I'm not so happy with the adding of the CurrentUserControllerValidationMockTest, but I will not make you change it | 20:47 |
| nessita | gatox: IRL tetsing and approving | 20:47 |
| gatox | nessita, i did it in that way because all the other test use mocker to test that kind of thing... :( | 20:47 |
| nessita | gatox: is ok :-) | 20:49 |
| nessita | gatox: you up for a review? | 20:49 |
| ralsina | gatox: in general we are trying to not use *more* mocker, but one more won't hurt. Too much. ;-) | 20:49 |
| gatox | nessita, ok..... lesson learned | 20:50 |
| nessita | gatox: you up for a review? | 20:50 |
| gatox | nessita, yes | 20:50 |
| nessita | gatox: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/improve-ui/+merge/70611 thanks! | 20:51 |
| gatox | nessita, did you approved the branch? | 20:52 |
| nessita | gatox: the missing-titles? running tests in windows noq | 20:52 |
| nessita | now* | 20:52 |
| gatox | nessita, ahhhhhhhhhhhh okok | 20:52 |
| nessita | gatox: hum that branch will not go thru tarmac, see: | 20:53 |
| nessita | ubuntu_sso/qt/tests/test_windows.py: | 20:53 |
| nessita | 245: [E1101, CurrentUserControllerValidationMockTest.test_setup_ui] Instance of 'CurrentUserControllerValidationMockTest' has no 'get_backend' member | 20:53 |
| nessita | 248: [E1101, CurrentUserControllerValidationMockTest.test_setup_ui] Instance of 'CurrentUserController' has no '_set_up_translated_strings' member | 20:53 |
| gatox | nessita, let me check | 20:53 |
| nessita | gatox: and I'm getting this failure in windows, not if it's legit though | 20:54 |
| nessita | http://pastebin.ubuntu.com/659537/ | 20:54 |
| dobey | have a good weekend everyone! | 20:55 |
| nessita | dobey: you yoo | 20:56 |
| nessita | you too | 20:56 |
| nessita | ralsina: no need to change, but for future reference, there should be no blank line between these twoL | 21:00 |
| nessita | 45+from twisted.trial.unittest import TestCase | 21:00 |
| nessita | 46+ | 21:00 |
| nessita | 47+from ubuntuone.devtools.testcase import skipIfOS | 21:00 |
| ralsina | really? ok | 21:01 |
| nessita | ralsina: what I will ask you to change is the duplicated import of "import os" | 21:01 |
| ralsina | nessita: sure, missed that one | 21:01 |
| nessita | ralsina: yeah, when importing modules, you need to use this layout: http://pastebin.ubuntu.com/659540/ | 21:04 |
| nessita | ralsina: and in this case, devtools is a 3rd app for us | 21:05 |
| ralsina | ok, treated it as "part of the project". Will fix it. | 21:05 |
| gatox | nessita, i've uploaded some changes in the branch for missing titles... all tests are passing for me | 21:07 |
| nessita | gatox: ack | 21:07 |
| === m_conley is now known as m_conley_away | ||
| gatox | nessita, have you updated the style of the buttons in your last branch? | 21:09 |
| nessita | gatox: nopes, I will leave that you probably :-) | 21:09 |
| gatox | nessita, ok..... just checking | 21:10 |
| ralsina | nessita: pushed with the import fixes | 21:10 |
| nessita | ralsina: ack, I will have to finish the review on Mon | 21:11 |
| nessita | ralsina: I will finish gatox's and then I have to run to a birthday party :-) | 21:11 |
| ralsina | nessita: if that's all you had, can I get the approve? If you didn't finish testing it's ok, we'll leave it for monday | 21:12 |
| nessita | ralsina: I didn't even finish looking at the diff | 21:12 |
| nessita | ralsina: I stopped at the double import | 21:13 |
| gatox | nessita, i'm finishing with your branch | 21:13 |
| ralsina | nessita: ok, monday it is | 21:13 |
| gatox | nessita, +1 | 21:13 |
| nessita | gatox: thanks! | 21:13 |
| nessita | gatox: sdid you see the failing test I have? does it make any sense? | 21:13 |
| gatox | nessita, yes, i saw the pastebin... but It doesn't make sense at least for me... i'll try to find what that is | 21:14 |
| nessita | gatox: is ok, do not waste time | 21:15 |
| nessita | gatox: my env may be funky | 21:15 |
| nessita | gatox: approving | 21:15 |
| nessita | ralsina: if you review/approve https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/improve-ui/+merge/70611, we can land this soon | 21:16 |
| === yofel_ is now known as yofel | ||
| ralsina | nessita: I am looking at it. I see weird stuff in those buttons we talked about earlier. | 21:17 |
| nessita | ralsina: weird stuff such as? | 21:18 |
| ralsina | in designer the buttons are not the same width | 21:18 |
| nessita | hum | 21:18 |
| nessita | ralsina: have a screenshot? | 21:18 |
| ralsina | nessita: uploading... | 21:19 |
| ralsina | nessita: http://screencast.com/t/regrVTSrVPkR | 21:19 |
| nessita | ralsina: wait! I was missing a commit + push :-/ | 21:19 |
| nessita | ralsina: that's the old code... sorry | 21:20 |
| ralsina | ok! np | 21:20 |
| nessita | ralsina: I just saw I had the commit-editor opened :-/ | 21:20 |
| nessita | Pushed up to revision 198. | 21:21 |
| ralsina | nessita: on windows it's worse, the commit editor goes to background automatically, so the commit message is never saved. It's -m or nothing :-) | 21:21 |
| nessita | ouch | 21:21 |
| diverse_izzue | is the evolution contact backend currently supposed to work in oneiric or not? | 21:21 |
| ralsina | nessita: I usually use a QGridLayout and then a vertical layout on the window, because if you use a grid layout on the window, you can't "see" the layout (or do things like change spans) | 21:23 |
| ralsina | but that's just a personal preference | 21:24 |
| gatox | ralsina, +1 | 21:24 |
| gatox | :P | 21:24 |
| ubuntunoob | i am having problems with the nightly ppa | 21:25 |
| ubuntunoob | can someone help? | 21:25 |
| ralsina | nessita: also, I like putting placeholder texts on the widgets, even if it means cleaning them in code, because it makes manipulation in designer easier | 21:25 |
| ralsina | nessita: so, other than those style issues, everything looks ok. | 21:27 |
| nessita | ralsina: ack to your personal preferences. Not sure if you're asking me to change something though... | 21:28 |
| ralsina | nessita: I think it makes it easier for the next person who has to touch it, so yes, I would prefer if you changed it. | 21:28 |
| ubuntunoob | hello? | 21:29 |
| ralsina | otherwise, there are invisible widgets in an invisible layout :-) | 21:29 |
| ubuntunoob | is anyone here? | 21:29 |
| ralsina | ubuntunoob: sorry, the support staff has left for the day | 21:29 |
| ubuntunoob | shoot | 21:29 |
| ubuntunoob | what do i do then | 21:29 |
| nessita | ralsina: add text to the labels, you mean? I think is out of the scope of this branch, and also my personal preference is not to set text to labels, so I would like to have that conversation in other moment, if possibe | 21:29 |
| ralsina | ubuntunoob: and we are the developers and are trying to wrap up too. Give me 5' and I will try to help | 21:29 |
| ubuntunoob | ok thanks | 21:30 |
| ralsina | nessita: yes, since that was already that way, I'm ok with not changing it. But the layout should change | 21:30 |
| nessita | ralsina: I think adding a grid on top of the form adds a layer of complexity that is not needed... | 21:30 |
| ralsina | nessita: the grid is there, it's just invisible | 21:31 |
| nessita | ralsina: right, so why adding another one? | 21:31 |
| nessita | just to be able to see it? :-/ | 21:31 |
| ralsina | nessita: because it's invisible. I don't say have two grids | 21:31 |
| ralsina | I would use a grid (visible), put the bottom expander outside of it, and use a vertical (invisible) layout on the window | 21:31 |
| nessita | ralsina: if I understand properly, you're telling me to have the form layout vertically and add a grid on top of that, right? | 21:32 |
| ralsina | nessita: yes. Because there are things you can't do with the invisible grid | 21:32 |
| ralsina | such as change spanning | 21:32 |
| nessita | I don't see any gain to that, actually I saw that stuff before and that confused me a lot | 21:32 |
| nessita | ralsina: anyways, I gotta go, I guess we'll keep talking about this on Monday | 21:33 |
| ralsina | nessita: ok, monday. | 21:33 |
| ralsina | but how an invisible grid is less confusing than a visible one is bvaffling to me :-) | 21:33 |
| nessita | ralsina: I use the tree widget a lot | 21:33 |
| nessita | ralsina: having an extra layer there is confusing, is like is adding some funct5ionality but then you realized is not needed | 21:34 |
| nessita | is not strictly needed, I mean | 21:34 |
| nessita | so it took me a long time realize that the extra layer was not needed | 21:34 |
| nessita | and that the form itself can have a layout according to the widget's need | 21:34 |
| ralsina | nessita: not having it is bad for maintainability of the thing. Could you trust me that have been doing Qt stuff for 12 years this once? ;-) | 21:34 |
| nessita | is not lack of trust, really. I don't see any gain, but confusing stuff. | 21:36 |
| ralsina | ok, I suppose you can't, I'll try to convince you on monday. Have a nice weekend! | 21:36 |
| ubuntunoob | wow 12 years? | 21:36 |
| ralsina | more like 15 but don't want to brag | 21:36 |
| ubuntunoob | oh | 21:36 |
| ralsina | ;) | 21:36 |
| ubuntunoob | thats amazing | 21:36 |
| ubuntunoob | well i think it s | 21:36 |
| nessita | ralsina: anyways, I tried to review your branch while you try to convince me, and I see that you added windows specific stuff to a directory that is multiuplatform | 21:36 |
| ralsina | no, it's what happens when you are *old* :-D | 21:36 |
| ralsina | nessita: ok, put a needsfixing, will see it on monday | 21:36 |
| nessita | ralsina: TestBaseDirectoryWindows shoudl be inside tests/platform/windows/<something> | 21:37 |
| ralsina | nessita: ok, that's an easy one, at least | 21:37 |
| ubuntunoob | i have a question for you guys | 21:37 |
| ralsina | ubuntunoob: shoot! | 21:37 |
| nessita | ok, I'm off | 21:37 |
| nessita | bye all! | 21:38 |
| ubuntunoob | why do you only make it for windows ? | 21:38 |
| ralsina | ubuntunoob: what thing? | 21:38 |
| ubuntunoob | why not make a mac client | 21:38 |
| ubuntunoob | for ubuntu one | 21:38 |
| ralsina | ubuntunoob: we haven't even released windows yet! :-D | 21:38 |
| ubuntunoob | i know its a beta | 21:38 |
| ubuntunoob | but i was just curious | 21:38 |
| ralsina | ubuntunoob: and a mac client is considered. But there are over 400 million windows users. And about 35 million mac users. | 21:39 |
| ubuntunoob | oh | 21:39 |
| ubuntunoob | so bigger userbase | 21:39 |
| ralsina | ubuntunoob: yes, pretty much | 21:39 |
| ubuntunoob | ah | 21:39 |
| ubuntunoob | do you guys support the nightly ppa here | 21:40 |
| ubuntunoob | because im having some problems installing it | 21:40 |
| ralsina | ubuntunoob: what kind of problem | 21:40 |
| ubuntunoob | ubuntuone-client-gnome: Depends: ubuntuone-client (= 1.2.2-0ubuntu2) but it is not going to be installed | 21:40 |
| ubuntunoob | E: Broken packages | 21:40 |
| ralsina | ubuntunoob: probably a broken build | 21:41 |
| ubuntunoob | oh | 21:41 |
| ralsina | ubuntunoob: you should ask dobey but he already left | 21:41 |
| ubuntunoob | well is there another ppa for the nightlies i could use? | 21:41 |
| ralsina | ubuntunoob: nope, nightlies is what it is, and occasionally it breaks | 21:41 |
| ubuntunoob | oh | 21:42 |
| ubuntunoob | ok i understand | 21:42 |
| ubuntunoob | need to backup my ipod music somehow, any suggestions? | 21:42 |
| ralsina | ubuntunoob: so, if it's not better tomorrow morning, come here, and ask for dobey, rye or duanedesign :-) | 21:43 |
| ubuntunoob | ok | 21:43 |
| ubuntunoob | thx | 21:43 |
| ralsina | ubuntunoob: you can still use the web ui | 21:43 |
| ubuntunoob | ok | 21:43 |
| ubuntunoob | good | 21:43 |
| ralsina | but of course uploading files one at a time is a pain | 21:43 |
| ubuntunoob | yes it is | 21:43 |
| ralsina | for a backup you could zip them | 21:43 |
| ubuntunoob | i just about to say that lol | 21:43 |
| ubuntunoob | i think thats what i will do | 21:44 |
| ubuntunoob | thanks | 21:44 |
| ubuntunoob | for all your help | 21:44 |
| ubuntunoob | :D | 21:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!