| karni | Good night! EOD | 00:19 |
|---|---|---|
| JamesTait | Morning all! | 08:41 |
| fagan | morning | 08:56 |
| duanedesign | o. | 09:03 |
| duanedesign | err | 09:04 |
| duanedesign | o/ | 09:04 |
| fagan | yo duanedesign | 09:04 |
| karni | Good morning! | 09:06 |
| === yofel_ is now known as yofel | ||
| mandel_ | rye, ping | 10:58 |
| rye | mandel_, pong | 10:58 |
| mandel_ | rye, do you know what is going on with shares creation? | 11:00 |
| mandel_ | rye, web or linux client do not work :( | 11:00 |
| rye | mandel_, interesting, checkign | 11:03 |
| rye | mandel_, do you get 504 Gateway Time-out on /files/ ? | 11:07 |
| rye | mandel_, are you unable to accept a share or to offer it? | 11:09 |
| mandel_ | rye, to offer a share, the web ui get stucked and nothing happens... | 11:10 |
| rye | mandel_, so, if the web ui times out so will the share creation from the client since it uses web api too | 11:11 |
| rye | mandel_, i think i shared a folder with you now | 11:11 |
| mandel_ | rye, yeah, so Iwanted to blame beuno for this :D | 11:12 |
| mandel_ | rye, let me check | 11:12 |
| gatox | ralsina, if you are there, i've made the changes you mentioned in my branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/ui-improves/+merge/71116 | 11:21 |
| gatox | nessita, i have a branch for you :P https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/ui-improves/+merge/71116 | 11:25 |
| nessita | hello everyone! | 11:26 |
| nessita | gatox: yes, I have to review it :-) | 11:26 |
| gatox | nessita, :D | 11:26 |
| mandel_ | rye, I've got no emails regarding shares | 11:27 |
| nessita | gatox: branching | 11:28 |
| nessita | mandel_: I shared 2 yesterday, one read only, one read write | 11:28 |
| nessita | (hello!) | 11:28 |
| rye | beuno, --[14:28:27.023] POST https://one.ubuntu.com/files/api/offer_share/ [HTTP/1.1 501 NOT IMPLEMENTED 326ms] | 11:28 |
| mandel_ | nessita, hello :) | 11:28 |
| rye | mandel_, ^ | 11:28 |
| gatox | nessita, and hello :P | 11:29 |
| rye | this is the first time i see this | 11:29 |
| mandel_ | rye, yeah, that sounds very | 11:29 |
| rye | mandel_, ah, trailing space makes it veery confused | 11:30 |
| rye | mandel_, shared a folder with you now | 11:30 |
| mandel_ | rye, checking | 11:30 |
| mandel_ | nessita, I did some tests with my accoing but I wanted to use a diff one, can you shre those two folders with: etil15+shares_tests@gmail.com | 11:32 |
| mandel_ | rye, which account did you share with? can you do it with etil15+shares_tests@gmail.com | 11:34 |
| === facundobatista is now known as facundo-3 | ||
| rye | beuno, ping | 11:35 |
| mandel_ | rye, I did get the share to my canonical address :) | 11:35 |
| rye | beuno, -- [14:35:45.387] POST https://one.ubuntu.com/files/api/offer_share/ [HTTP/1.1 501 NOT IMPLEMENTED 74ms] | 11:36 |
| nessita | mandel_: sure! | 11:37 |
| mandel_ | nessita, gracias! | 11:39 |
| rye | mandel_, something tells me that some appserver is unhappy | 11:39 |
| mandel_ | rye, yeah, I was trying to do test on share on windows and had issues... I did not know the reasons :P | 11:40 |
| nessita | mandel_: I can't share anymore via the web ui | 11:43 |
| nessita | the sharing will never end | 11:44 |
| mandel_ | nessita, yeah, that is one of the things I have experienced :( | 11:46 |
| mandel_ | and the reason I asked about it | 11:46 |
| mandel_ | nessita, rye : was there a web release or something? | 11:46 |
| rye | nessita, it returns NOT IMPLEMENTED for some reason | 11:50 |
| nessita | rye: maybe vds knows? | 11:50 |
| nessita | gatox: does this make sense? border: 0px solid; | 11:51 |
| nessita | gatox: shouldn't it be border: none? | 11:51 |
| rye | ping vds | 11:51 |
| teknico | rye, nessita, vds is on holiday | 11:52 |
| gatox | nessita, yes, probably... let me take a look at that | 11:55 |
| nessita | teknico: oh, thanks! | 11:55 |
| gatox | nessita, qss modified | 11:59 |
| nessita | gatox: ack | 11:59 |
| mandel_ | nessita, ok, so if we do not have vds, how do we move foward, I';m looking at changin my creds and try again to see the shares, but I really don't want to be blocked by this :) | 12:05 |
| nessita | mandel_: well, we need to debug why the shares you already have do not download, right? | 12:08 |
| nessita | mandel_: that will take some time | 12:08 |
| mandel_ | nessita, yes, on it | 12:09 |
| nessita | mandel_: if you resolve that quick (finger cross), I cna easily assign a new ticket to you | 12:09 |
| beuno | rye, right, no shares in the rest api | 12:09 |
| nessita | gatox: in ubuntuone_installer/gui/qt/gui.py, from ubuntuone_installer.gui.qt.folders import FoldersPage should go before from ubuntuone_installer.gui.qt.forgotten import ForgottenPasswordController not after :-) | 12:17 |
| gatox | nessita, ok, fixing it | 12:17 |
| nessita | gatox: and please remove the debug adding for twisted deferreds in ubuntuone_installer/gui/qt/local_folders.py | 12:17 |
| gatox | nessita, ok... | 12:18 |
| * gatox forgets about alphabetical ordeer :P | 12:18 | |
| * mandel_ goes back home | 12:18 | |
| mandel_ | nessita, I'll get back to you with the debugging as soon as I'm back home :) | 12:18 |
| gatox | nessita, fixes pushed | 12:21 |
| ralsina | hello again | 12:21 |
| nessita | hi ralsina! | 12:23 |
| ralsina | hola nessita! | 12:23 |
| ralsina | nessita: I am doing your reviews requests from yesterday | 12:23 |
| nessita | ralsina: great, alecu requested a few improvements on the first one | 12:23 |
| nessita | ralsina: I will do them when I finish gatox's review | 12:24 |
| nessita | gatox: 2 more things | 12:27 |
| nessita | gatox: the docstring for shwo_hide_offer needs a tweak, the closing """ should be in its own line. | 12:27 |
| ralsina | nessita: ack | 12:28 |
| * gatox looking... | 12:28 | |
| nessita | gatox: and question, does show_hide_offer use the d.addCallback instead of inlineCallbacks + yield for any reason? if you're not sure what I mean, I'm happy to explain what inlineCallbacks are | 12:29 |
| gatox | nessita, yes, if you can explain me that would be great, which do you consider is the best solution? | 12:30 |
| ralsina | nessita: that code was originally mine. If I used inlineCallbacks, I had to make other stuff inlineCallbacks as well, and this was more local | 12:30 |
| ralsina | nessita: so, basically was to make a smaller change, since it was not very complicated this way | 12:30 |
| nessita | ralsina: what do you mean with "I had to make other stuff inlineCallbacks as wel"? | 12:30 |
| ralsina | nessita: IIRC, I had to make the method that calls show_hide_offer inlineCallbacks too (but I may be misremembering) | 12:31 |
| ralsina | or maybe not since that one shouldn't return anything. I am fuzzy in the memories, so of course either way is fine for me ;-) | 12:32 |
| nessita | ralsina: using inlineCallbacks +yield or returning a deferred is *exactly* the same, so the caller needs to do the same either if the calling method has the d.addCallback or yielding scheme | 12:36 |
| nessita | gatox: I'll explain | 12:36 |
| ralsina | nessita: yes, you are right, and the caller is inlineCallbacks, so ... who knows :-) | 12:37 |
| nessita | ralsina, gatox: these 2 are 100% equivalent: http://pastebin.ubuntu.com/663374/ | 12:37 |
| gatox | nessita, yep..... | 12:38 |
| nessita | (except that the second calls to logger.exception instead of logger.error) | 12:38 |
| nessita | gatox: do you understand what does yield + inlineCallback do? | 12:38 |
| ralsina | Ok, my notes tell me I was trying a lot of different stuff because that was when calling u1cp was not working (when the UI was in the ussoc process) | 12:38 |
| nessita | ralsina: old times... :-) | 12:39 |
| gatox | nessita, not very much | 12:39 |
| gatox | :S | 12:39 |
| ralsina | nessita: yeah, old branch ;-) | 12:39 |
| gatox | nessita, do you have any reference doc? | 12:39 |
| gatox | nessita, here i found something | 12:40 |
| nessita | gatox: is ok! let me explain a bit, then I'll point to documentation. So, yield is the pure python builtin to code generators | 12:40 |
| gatox | yep | 12:40 |
| nessita | gatox: when combined with the inlineCallbacks decorator, what we get is a method that returns a deferred, just like the original one | 12:41 |
| nessita | gatox: and the returned deferred will be fired when the yield "returns" | 12:41 |
| nessita | gatox: so, the caller to show_hide_offer, will get a deferred returned, that will be fired sometime in the future. And inside hide_show_offer, the code that handles user_info will not be executed until the yield returns | 12:42 |
| gatox | nessita, right | 12:42 |
| nessita | gatox: and last, the way to handle errors is try-excepting around the yield, which is equivalent to d.addErrback | 12:42 |
| nessita | gatox: but I think you will agree with me that using inlineCallbaks ease the reading a lot | 12:43 |
| gatox | nessita, yes, it seems more clear | 12:43 |
| gatox | clean | 12:43 |
| gatox | nessita, ok, i'll modified it now | 12:44 |
| nessita | great | 12:44 |
| ralsina | gatox: keep in mind that once you use "call" something using inlineCallbacks, you are getting a generator, so the caller is probably going to be inlineCallbacks oo | 12:44 |
| ralsina | s/oo/too/ | 12:44 |
| ralsina | and so on | 12:44 |
| gatox | ralsina, ok, i'm going to read a little bit further about this | 12:45 |
| ralsina | gatox: for example, see who is calling show_hide_offer? | 12:45 |
| gatox | with yield | 12:46 |
| ralsina | gatox: right | 12:46 |
| gatox | ralsina, so yield in that calls is no longer necessary | 12:47 |
| gatox | is that ok? | 12:47 |
| ralsina | yes it is. Since show_hide_offer returns a generator, and the caller has to wait for it to trigger, it yields it | 12:47 |
| gatox | ralsina, ahhhhh ok | 12:47 |
| ralsina | oops. Returns A DEFERRED | 12:47 |
| ralsina | not a generator. | 12:47 |
| ralsina | so, the caller has to wait for it to trigger, so it yields it and uses inlineCallbacks | 12:48 |
| gatox | ralsina, okk | 12:48 |
| nessita | ralsina: the caller does not need to become an inlineCallbacks | 12:49 |
| ralsina | nessita: really? Goes to show I should not explain what I don't know :-) | 12:49 |
| nessita | ralsina: the caller can not wait for the deferred to be fired, if it does not care about the result | 12:49 |
| gatox | nessita, is there any other place where @defer.inlineCallbaks is being used? | 12:49 |
| ralsina | nessita: ok, in this case it does care :-) | 12:49 |
| ralsina | So, it's @inlineCallbacks up the calling chain until you don't care what the deferred does | 12:50 |
| nessita | gatox: yes, all over the control panel backend.py and the QT implementation. For example, folder.py. preferences.py, etc | 12:50 |
| nessita | ralsina: not really, let me explain | 12:50 |
| ralsina | nessita: ok | 12:50 |
| nessita | ralsina: you can "mix" inlineCallbacks with the old "scheme" of chaining callbacks with addCallback. What I mean is that you can look at a method that returns a deferred like a black box, and inside that method, the deferred can be returned explictely, with a "return d" or can be returned by the inlienCallback generator. So is transparent for the caller, which, at the same time, can ignore that result of that deferred, or can chain stu | 12:52 |
| nessita | ralsina: even more, a method that used to return the deferred explicitly, can change the implementation to inlineCallbacks and all the callers will not note the difference | 12:53 |
| ralsina | nessita: oh yes, I know that. I was trying to say that if we are using @inlineCallbacks as a matter of style, then we should use it on the caller, unless we don't care about the deferred, that's all | 12:53 |
| ralsina | I worried for a minute I had understood wrong deferreds *again* for a minute there ;-) | 12:54 |
| nessita | ralsina: :-). So, one last note: I agree we should use inlineCallbacks consistently every time we need to return a deferred, but if we don't need to wait for the deferred to be fired, we should not add the decorator... | 12:54 |
| ralsina | exactly | 12:55 |
| ralsina | propagate it as needed and no further | 12:55 |
| nessita | ralsina: another thing, you need to get used to *always* run the test suites, event for trivial branches ;-) | 12:55 |
| ralsina | which one did I break? | 12:55 |
| nessita | ralsina: https://code.launchpad.net/~ralsina/ubuntuone-control-panel/no_is_link/+merge/71132 has a needs fixing now | 12:56 |
| ralsina | ok | 12:56 |
| ralsina | ok, will skip it. | 12:56 |
| nessita | gatox: is it a little bit clearer now? | 12:56 |
| nessita | ralsina: please add the bug # in the skip message | 12:56 |
| ralsina | I ran the relevant tests on windows, but of course that one skips on windows :-) | 12:57 |
| nessita | gatox: feel free to ask, deferreds are not easy | 12:57 |
| gatox | nessita, ralsina yes... i made the change in my branch... i'm going to read a little bit further to understanded better... | 12:57 |
| * gatox is studying twisted :P | 12:57 | |
| dobey | deferreds are so deferrent | 12:57 |
| nessita | ralsina: why would that one skips in windows? | 12:57 |
| * ralsina laughs with the laughter of the guy who 3 weeks ago didn't understand the same thing | 12:57 | |
| nessita | gatox: again, please ask when you need :-) | 12:57 |
| ralsina | nessita: is_link makes no sense on windows? | 12:57 |
| gatox | nessita, yes!! thanks! | 12:58 |
| nessita | ralsina: it makes sense indeed, we can't sync .lnk paths | 12:58 |
| ralsina | a .lnk is just a file | 12:58 |
| nessita | ralsina: right, but we need to detect them and ignore them | 12:58 |
| ralsina | hmmm ok I guess | 12:58 |
| nessita | ralsina: otherwise a user with a link to a folder may expect that folder to be synced | 12:58 |
| nessita | standup in 1'! | 12:59 |
| ralsina | BTW, we have a rather bigish problem in XP. the user's "home folder" is very hard to get to, so it is very hard to get to "~/Ubuntu One" | 12:59 |
| gatox | nessita, ack | 12:59 |
| fagan | me | 13:00 |
| nessita | gatox: I found this https://confluence.oceanobservatories.org/display/CIDev/Gotchas+with+inlineCallbacks,+yield+and+returnValue not official but after a quick look looks good | 13:00 |
| fagan | ralsina: my documents is a lot easier to get to | 13:00 |
| fagan | ralsina: maybe for xp move it to my documents | 13:00 |
| ralsina | fagan: really not trivial. I would rather add it to the Desktop | 13:00 |
| nessita | fagan: no, we offer the user to sync his Document folder | 13:00 |
| ralsina | me | 13:01 |
| nessita | and we can not chain UDFs | 13:01 |
| nessita | me | 13:01 |
| fagan | nessita: ah forgot about that | 13:01 |
| mandel | me | 13:01 |
| gatox | nessita, yes, i was reading that | 13:01 |
| gatox | between other things | 13:01 |
| gatox | me | 13:01 |
| fagan | dobey? | 13:01 |
| fagan | Might as well go | 13:01 |
| dobey | que pasa?! | 13:01 |
| fagan | dobey: standup? | 13:02 |
| nessita | dobey: say me! :-) | 13:02 |
| fagan | DONE | 13:02 |
| fagan | * Tried to create a share for mandel's testing | 13:02 |
| fagan | * Found a beautiful bug in creating shares | 13:02 |
| fagan | TODO | 13:02 |
| fagan | * Help mandel test his script | 13:02 |
| fagan | BLOCKED | 13:02 |
| fagan | * by the share bug | 13:02 |
| fagan | ralsina: go | 13:02 |
| ralsina | DONE: call, released another bundle, several reviews, fixed a couple of smallish bugs, started work on the "syncdaemon expects bytes" bugs TODO: finish that bug, calls another release BLOCKED: no | 13:02 |
| ralsina | nessita? | 13:02 |
| nessita | DONE: bug #823884, bug #823895, bug #823896, bug #823903, reviews | 13:02 |
| nessita | TODO: debug timeouts in tests (probably caused by add_watch not returning), reviews | 13:02 |
| nessita | BLOCKED: nopes | 13:02 |
| nessita | NEXT: mandel | 13:02 |
| dobey | que ella eso, 'mi'! | 13:02 |
| ubot4 | Launchpad bug 823884 in ubuntuone-client "Share names and UDF suggested paths should be always unicode while testing (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/823884 | 13:02 |
| ubot4 | Launchpad bug 823895 in ubuntuone-client "Windows: test_action_queue does not clean the env properly in tearDown (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/823895 | 13:02 |
| ubot4 | Launchpad bug 823896 in ubuntuone-client "test_hashqueue should open all file with "wb" mode (affects: 1) (heat: 6)" [Medium,Fix committed] https://launchpad.net/bugs/823896 | 13:02 |
| ubot4 | Launchpad bug 823903 in ubuntuone-client "Windows: fix local rescan tests (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/823903 | 13:02 |
| nessita | dobey: you wanted to say that's what she said? :-) | 13:02 |
| nessita | "eso es lo que ella dijo" | 13:03 |
| nessita | mandel: go? | 13:03 |
| mandel | sorry, gong: | 13:03 |
| mandel | DONE: Tried to test the new shares added to my account yet they did not appear in the windows client, not even in the control panel. Created an empty account to see if it was related to my account yet I could not test it due to issues in creating shares (nessita already knows). Workd on the shutil.move branch and fixed accorindg to the reviews. Did a small bug triagging regarding the control panel UI which I sent to lissette for confirmation. | 13:03 |
| mandel | TODO: Find why shares do nt appear event though they are created. | 13:03 |
| mandel | BLOCKED: well, I need shares to work, so kinda | 13:03 |
| mandel | gatox, please | 13:04 |
| gatox | DONE: | 13:04 |
| gatox | Fixed Bug 819942, Bug 823188, Bug 823186, Bug 819966, Bug 819963, Bug 819961, Bug 819953, Bug 819952, Bug 819950, Bug 819945, Bug 819943, Bug 805296. Page 18 and 19 from Windows Installer complete. | 13:04 |
| gatox | TODO: | 13:04 |
| gatox | Keep working in several Windows Installer related bugs. | 13:04 |
| gatox | BLOCKED: | 13:04 |
| gatox | No. | 13:04 |
| gatox | dobey, go | 13:04 |
| ubot4 | Launchpad bug 819942 in ubuntuone-windows-installer "Title fonts should be regular, not bold (affects: 1) (heat: 17)" [Undecided,Confirmed] https://launchpad.net/bugs/819942 | 13:04 |
| ubot4 | gatox: Bug 823188 on http://launchpad.net/bugs/823188 is private | 13:04 |
| ubot4 | gatox: Bug 823186 on http://launchpad.net/bugs/823186 is private | 13:04 |
| ubot4 | Launchpad bug 819966 in ubuntuone-windows-installer "Modify Loading Overlay text (affects: 1) (heat: 17)" [Undecided,In progress] https://launchpad.net/bugs/819966 | 13:04 |
| ubot4 | Launchpad bug 819963 in ubuntuone-windows-installer "Fix Syncing the cloud to your computer UI style (affects: 1) (heat: 16)" [Undecided,In progress] https://launchpad.net/bugs/819963 | 13:04 |
| dobey | λ DONE: protocol release/upload, triage, bug #824143 | 13:04 |
| dobey | λ TODO: u1client-gnome/ubuntuone-installer releases/uploads, administrata | 13:04 |
| dobey | λ BLCK: None. | 13:04 |
| ubot4 | Launchpad bug 824143 in ubuntuone-storage-protocol (Ubuntu) (and 1 other project) "ubuntuone-syncdaemon crashes with error in oauth_authenticate (affects: 1) (heat: 6)" [Critical,Fix released] https://launchpad.net/bugs/824143 | 13:04 |
| nessita | any comments anyone? | 13:05 |
| gatox | nop | 13:05 |
| ralsina | not me! | 13:05 |
| fagan | Damn shares | 13:05 |
| fagan | :/ | 13:05 |
| fagan | I wonder how long it was broken | 13:05 |
| ralsina | fagan: it worked yesterday | 13:06 |
| ralsina | eom! | 13:06 |
| fagan | ralsina: oh so its something weird then | 13:06 |
| mandel | looks like a server outage or somethin :P | 13:06 |
| fagan | ah ok | 13:06 |
| ralsina | last I heard is "timeoouts" | 13:06 |
| mandel | I'm of too have lunch then, bbl | 13:06 |
| fagan | mandel: to not too :) | 13:07 |
| mandel | ralsina, we also need to know why we do not get the new shares in control panel. but it might be realted | 13:07 |
| * fagan hates things like that in the english language | 13:07 | |
| mandel | fagan, I know.. I was typing fast :P | 13:07 |
| fagan | hah :D | 13:07 |
| * mandel lunch | 13:07 | |
| ralsina | mandel: I do get a list of shares. You don't get the new ones without restarting because it's missing implementation of the bit that receives the signal when shares are added/removed | 13:10 |
| alecu | ooooh, I'm late! | 13:11 |
| alecu | Hello everybody, hello #ubuntuone! | 13:11 |
| * alecu is writing notes | 13:12 | |
| ralsina | hola alecu! | 13:12 |
| alecu | me | 13:14 |
| alecu | DONE: reviews, found a fix and made a branch to fix the last broken localrescan test (bug #824003) | 13:14 |
| alecu | TODO: test and push said branch, work on test_eq_inotify tests | 13:14 |
| alecu | BLOCKED: no | 13:14 |
| ubot4 | Launchpad bug 824003 in ubuntuone-client "Windows: test_localrescan.test_man_in_the_middle fails due to missing FS event (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/824003 | 13:14 |
| nessita | alecu: hi there! | 13:16 |
| nessita | alecu: can you please confirm if you agree with what I answer to your needs fixing request in https://code.launchpad.net/~nataliabidart/ubuntuone-client/fix-localrescan-tests/+merge/71059? | 13:17 |
| alecu | nessita, looking | 13:17 |
| nessita | alecu: so, regarding the HOME env var, right now, our tests work under windows becasue u1trial sets that env var and os.path.expanduser uses it if it's defined | 13:20 |
| nessita | alecu: and in the production code, we call os.path.expanduser | 13:20 |
| ralsina | nessita: pushed no_is_link with the skipped test | 13:20 |
| nessita | ralsina: ack | 13:20 |
| ralsina | oops, not pushed because this crap reboted and misses my public key. | 13:21 |
| alecu | nessita, ok. I agree to land this branch and create a bug to fix this when it's needed. | 13:21 |
| nessita | alecu: thanks! I'll file the bug. What env var should u1trial set, in windows? %HOME%? | 13:21 |
| === m_conley_away is now known as m_conley | ||
| nessita | alecu: USERPROFILE seems to be the HOME equivalent... | 13:24 |
| === facundo-3 is now known as facundobatista | ||
| alecu | nessita, it seems to be HOMEDRIVE, HOMEPATH and USERPROFILE, but I think the right way would be to mock the windows registry, because my feeling is that those vars are only there to help write shell scripts, and they are not really used by application code, nor the python libraries | 13:25 |
| nessita | alecu: well, os.path.expanduser uses them (and that's what we need) | 13:25 |
| nessita | alecu: the registry never gets hit within python | 13:26 |
| alecu | nessita, os.path.expanduser uses those variables? | 13:26 |
| alecu | nessita, are you sure? | 13:26 |
| nessita | looking at the source code right now, let me paste it for you | 13:26 |
| nessita | alecu: http://pastebin.ubuntu.com/663405/ | 13:26 |
| nessita | alecu: actually, HOME will work just "well" | 13:27 |
| ralsina | alecu: yes it does | 13:27 |
| ralsina | HOME works for os.path.expanduser just fine in windows | 13:27 |
| ralsina | except it's really dumb about trailing slashes | 13:27 |
| alecu | I'm shocked, I tell you. | 13:27 |
| ralsina | so expanduser("~/xx") looks like this: "C:\\whatever/xx" | 13:28 |
| ralsina | it's just a lame search/replace | 13:28 |
| alecu | nessita, then let's forget about this bug, and leave the code as is. | 13:29 |
| * alecu has not seen anything more pleasantly "unwindhonic" in months. | 13:30 | |
| nessita | alecu: ack | 13:30 |
| nessita | ralsina: the localrescan branch is being also removed by facundobatista (he's the localrescan master), so can you instead please review https://code.launchpad.net/~nataliabidart/ubuntuone-client/no-makedirs/+merge/71101 ? | 13:31 |
| ralsina | nessita: sire | 13:31 |
| nessita | ralsina: gosh, I said removed but I meant reviewed | 13:32 |
| alecu | nessita, it's being "removed"???? you mean "reviewed"???? | 13:32 |
| alecu | echo | 13:32 |
| ralsina | I meant sure, sire ;-) | 13:32 |
| nessita | alecu: yeah :-D | 13:32 |
| ralsina | I thought facundobatista was maing you throw it away and doing one himself ;-) | 13:32 |
| nessita | ralsina: he's capable, you know. But he knows I can scream very loudly and chillony | 13:33 |
| nessita | so I don't think he'd dare ;-) | 13:33 |
| ralsina | API question: should we start treating os_helper as private api? | 13:33 |
| alecu | "chillony" -> lol | 13:33 |
| ralsina | as in "control panel should not call os_helper" private | 13:33 |
| nessita | ralsina: so, I agree the control panel should not call os_helper, but the os_helper is not strictly private | 13:34 |
| ralsina | nessita: ok | 13:35 |
| nessita | mandel: is https://code.launchpad.net/~mandel/ubuntuone-client/dont-use-shutil-move/+merge/70595 ready for re-review? | 13:36 |
| nessita | gatox: you let me know when I shall re-review your branch? | 13:36 |
| * facundobatista likes to put nessita in a "chillony" state | 13:37 | |
| ralsina | dobey: I added a bit more detail to that bug so the branch makes more sense | 13:39 |
| gatox | nessita, i've modified the branch as you mention... is there any other modification i should make? | 13:39 |
| nessita | gatox: I haven't finished looking, did you push so I re branch as continue the review? | 13:39 |
| gatox | nessita, yes | 13:39 |
| nessita | gatox: ack | 13:42 |
| mandel | nessita, yes, I belive I have fixed all the issues you mentioned in the review | 13:43 |
| ralsina | nessita: boring +1 on no-makedirs ;-) | 13:43 |
| nessita | ralsina: yeah, sorry.. but it was needed | 13:44 |
| ralsina | nessita: np, I assume it was much more boring to write it than it was to read it :-) | 13:44 |
| nessita | ralsina: a little :-) | 13:44 |
| nessita | ralsina: I will land that with 1 review after the localrescan branch lands (since is prerequisite) | 13:44 |
| ralsina | nessita: yeah, sounds reasonable. That branch is mostly a no-op in the worst case | 13:45 |
| mandel | nessita, do you need an extra reviw? | 13:45 |
| mandel | review* | 13:45 |
| nessita | mandel: not atm, but thanks!!! | 13:45 |
| mandel | ok | 13:45 |
| dobey | ralsina: doesn't really help me understand. won't this introduce a regression in u1cp where it will allow using symlinks as folders for synchronizing? | 13:47 |
| ralsina | dobey: just momentarily, and just for the qt control panel. Or I could add an encode() call instead of commenting that bit | 13:47 |
| ralsina | nessita: ^? | 13:47 |
| dobey | right, if it's bytes vs. unicode issue, sending the right thing instead seems like a better solution, even if temporary, no? | 13:48 |
| nessita | dobey: well, not really, the difference is that instead of detecting this in the cp layer, syncdaemon will return an error after the udf creation was requested | 13:48 |
| nessita | dobey: u1cp should not be using is_link. Besides, the validation is only used from the QT UI, not in the GTK one | 13:48 |
| dobey | nessita: right. but sending stuff we know will fail seems like a waste of resources | 13:49 |
| nessita | dobey: I agree, we need to move the validation code to u1client and call it from our backend. But this will not be a regression since this is not used from the GTK UI | 13:49 |
| ralsina | dobey:also I want to remove the validation from u1cp because it means we have to validate exactly the same way twice, and that's not a good idea | 13:49 |
| nessita | dobey: in GTK we do not provide the "create folder" func | 13:49 |
| dobey | this seems to affect both | 13:49 |
| dobey | it's in controlpanel/backend.py | 13:50 |
| nessita | dobey: yes, but the GTK UI does not export folder creation | 13:50 |
| nessita | dobey: there is no button nor way to create a new folder in the GTK panel | 13:50 |
| dobey | ok | 13:50 |
| nessita | dobey: thanks | 13:51 |
| dobey | but still, the bug nor proposal state that. nor does the bug state what the problem really is. it states "we are doing this" and only sort of alludes to a problem existing | 13:51 |
| dobey | don't thank me yet :) | 13:51 |
| nessita | dobey: oh, you made me happy for a few seconds... | 13:51 |
| dobey | the ok was "ok, then it doesn't affect gtk+" not "ok, the branch makes sense to me" | 13:51 |
| nessita | ralsina, alecu, mandel, gatox, Chipaca: mumble? | 13:51 |
| mandel | ralsina, that log things is bloody annoying, the only way I've found to work around it is by uninstall/install | 13:52 |
| mandel | nessita, alrady there :) | 13:52 |
| ralsina | mandel: uh? | 13:52 |
| nessita | dobey: so, we're fixing this pretty soon, but adding a decode there is terrible "dirty" and misleading | 13:52 |
| ralsina | nessita: ack | 13:52 |
| nessita | dobey: the bug is "control panel should not call is_link" | 13:52 |
| dobey | nessita: so is a comment that says "look at this bug" with a bug that doesn't actually say anything about what the problem is, or why it should not do what it's doing | 13:53 |
| mandel | ralsina, the issues with pyexe and stderr | 13:53 |
| Chipaca | nessita: otp | 13:53 |
| ralsina | mandel: I know what you talk about, don't understand what the problem is with that | 13:53 |
| nessita | dobey: let's ask ralsina to improve the bug description! :-) | 13:53 |
| nessita | Chipaca: ack | 13:53 |
| ralsina | nessita, dobey: file a bug on the bug ;-) | 13:53 |
| mandel | ralsina, that is a PITA :) | 13:53 |
| ralsina | Will improve it in a minute | 13:53 |
| gatox | nessita, ack | 13:53 |
| gatox | (mumble) | 13:53 |
| dobey | it's like making a bug "control panel should make me a mate" and then adding a "exit 0" in main, because it doesn't make me mate :) | 13:53 |
| ralsina | mandel: oh come on, it's a dialog when you close ;-) | 13:53 |
| dobey | raise MateNotImplemented | 13:54 |
| nessita | dobey: will a better bug description be a good solution for you? | 13:55 |
| dobey | i would like to understand what the problem is exactly, yes; and if the calls shouldn't be there, probably just better to remove the code, than comment it out | 13:55 |
| dobey | skipping a test that you intend to just remove anyway seems a bit inane | 13:55 |
| Chipaca | nessita: on my way now | 13:59 |
| ralsina | dobey: I agree and will use an encode() instead of commenting that | 14:11 |
| mandel | @png | 14:36 |
| mandel | @ping | 14:36 |
| ubot4 | pong | 14:36 |
| dobey | ok | 14:36 |
| dobey | brb real quick | 14:38 |
| nessita | gatox: trivial fix, you should not add an empty line between these imports: | 14:47 |
| nessita | +from PyQt4 import QtCore, QtGui | 14:47 |
| nessita | + | 14:47 |
| nessita | +from ubuntu_sso.qt.gui import SSOWizardPage | 14:47 |
| nessita | + | 14:47 |
| nessita | +from ubuntuone.controlpanel.gui.qt import folders | 14:47 |
| nessita | gatox: they are all 3rd party, do you group them altogether | 14:47 |
| nessita | all together* | 14:47 |
| nessita | gatox: and initializePage has no docstring | 14:48 |
| gatox | nessita, fixing it | 14:50 |
| nessita | gatox: same for | 14:50 |
| nessita | from twisted.internet.defer import inlineCallbacks | 14:50 |
| nessita | <no blank line here> | 14:50 |
| nessita | from PyQt4 import QtCore, QtGui | 14:50 |
| gatox | nessita, ok, i'll look if there is something else like thaat | 14:52 |
| nessita | thanks! | 14:52 |
| ralsina | grmbl, my kid apparently has fever and I have to pick him up at school | 14:53 |
| nessita | gatox: so, what you did with inlineCallbacks is fine, but I want to be sure you understand there is no need to add the inlineCallbacks decorator to update_sizes and initializePage, unless some caller needs to access the deferred being returned | 14:54 |
| ralsina | nessita, gatox: this means I will prbably miss the lisette/claire meeting, which can not be rescheduled much later | 14:54 |
| ralsina | :-( | 14:54 |
| nessita | ralsina: maybe we should reschedule to tomorrow? | 14:54 |
| ralsina | nessita: tomorrow there is no more claire | 14:54 |
| nessita | ralsina: no problem then, I can lead the meeting | 14:55 |
| nessita | ralsina: I will send notes afterwards | 14:55 |
| ralsina | since you own u1cp and diego is doing installer, I think I am not really necessary but I wanted to be there :-( | 14:55 |
| nessita | gatox: so, for this thing there is no need to change anything, I just want to know you know the difference :-) | 14:55 |
| dobey | ok. muchos releasos | 14:56 |
| gatox | nessita, so... do you mean that i should revert the change on local_folders? | 14:56 |
| nessita | gatox: one sec (mumble) | 14:56 |
| ralsina | dobey, nessita: pushed no_is_link with the encode() call instead of commenting is_link (which makes the name very deceiving ;-) and... I'm off to pick up my kid | 14:57 |
| dobey | ralsina: ok, cool | 14:59 |
| clarita | nessita are lisette and I going to chat with you then?? :-) | 15:14 |
| nessita | clarita: yes, one second, I'm finishing another call | 15:15 |
| clarita | nessita okey dokey | 15:15 |
| === zyga is now known as zyga-afk | ||
| dobey | necessita comida. bbiab :) | 15:43 |
| === beuno is now known as beuno-lunch | ||
| mandel_ | alecu, ping | 15:51 |
| nessita | alecu: could you please approve https://code.launchpad.net/~nataliabidart/ubuntuone-client/fix-localrescan-tests/+merge/71059 ? all requested fixes are done | 15:58 |
| nessita | gatox: going back to the review... | 16:06 |
| nessita | gatox: no need to revert the changes, I want to be sure you understand that we could not add inlineCallbacks to initializePage and update_sizes | 16:07 |
| nessita | gatox: so, as an exercise, can you please change on_add_storage_button_clicked to use inlineCallbacks + yield instead of | 16:08 |
| nessita | credtool = CredentialsManagementTool() | 16:08 |
| nessita | d = credtool.find_credentials() | 16:08 |
| nessita | d.addCallback(open_url) | 16:08 |
| gatox | nessita, ok... i submit that in this branch or in a new one? | 16:12 |
| nessita | gatox: this one, I'm adding more needs fixing to the MP (merge proposal) | 16:12 |
| gatox | nessita, okas | 16:13 |
| alecu | nessita, approved | 16:14 |
| alecu | mandel_, pong | 16:15 |
| nessita | alecu: thanks! | 16:16 |
| nessita | gatox: needs fixing / questions added | 16:24 |
| gatox | ok | 16:34 |
| gatox | nessita, ok | 16:34 |
| nessita | lunchtime! | 16:43 |
| alecu | mandel, ping! | 16:45 |
| alecu | mandel, I think that Watch.stop_watching should return a deferred that is fired when the watch thread actually finishes | 16:45 |
| mandel | alecu, but that deferred was already fired, what is the use? | 16:46 |
| alecu | mandel, and we should wait on that for test cleanups | 16:46 |
| mandel | alecu, can you take a look at shuitl.move branch? | 16:46 |
| alecu | mandel, link? | 16:46 |
| mandel | alecu, sorry I understood the same referred as in start, sorry | 16:46 |
| mandel | alecu, returning a deffered on stop sounds like a good idea but we should check the shutdown methods of sd to use that correctly | 16:47 |
| mandel | alecu, https://code.launchpad.net/~mandel/ubuntuone-client/dont-use-shutil-move/+merge/70595 | 16:47 |
| alecu | mandel, right, it's a new one. I think we should have a new deferred, (let's call it "stopped") that means that the watch has correctly been removed. | 16:47 |
| alecu | mandel, right, we should make sure all of sd uses it. | 16:47 |
| mandel | alecu, sounds like a reasonable solutions since we have threads there | 16:48 |
| mandel | alecu, will make the solution cleaner and symetric which I like | 16:48 |
| alecu | mandel, so, right now I'm adding errbacks when a thread fails to start. I'll run the tests with this, and probably in the next branch I'll try fixing the stop to see if the rest of tests are fixed. | 16:49 |
| mandel | alecu, soudns good... I wonder, why did the thread fail to start? | 16:51 |
| mandel | alecu, do we reach a limit? | 16:51 |
| alecu | mandel, we'll find out soon! | 16:51 |
| alecu | mandel, btw: if you can, please review this: https://code.launchpad.net/~alecu/ubuntuone-client/fix-unorsai/+merge/71233 | 16:51 |
| mandel | alecu, on it! | 16:52 |
| alecu | oooh | 16:52 |
| alecu | mandel, sorry, I forgot that nessita suggested that facundobatista should review it first, to see if the approach is right. | 16:52 |
| alecu | mandel, btw: that branch fixes run_tests.bat, so now you can use it like "run_tests.bat -t [regexp]" | 16:53 |
| mandel | alecu, yeah, it was the first thing I noticed :) | 16:53 |
| alecu | facundobatista, if you can, please review the above branch ^^^^ | 16:53 |
| mandel | alecu, I think we should move the common code on runt_tests to u1.devtools | 16:53 |
| mandel | alecu, and add it as a bat for u1trial | 16:54 |
| facundobatista | alecu, I can, but not now | 16:54 |
| alecu | facundobatista, it's a very small branch, but review it when you can. | 16:54 |
| mandel | alecu, so we can call u1trial.bat tests or something like that | 16:54 |
| dobey | hmm? | 16:54 |
| mandel | dobey, adding a batch for u1trial on windows :) | 16:56 |
| dobey | mandel: the common code for run-tests is in devtools already. it's called u1trial :) | 16:56 |
| === beuno-lunch is now known as beuno | ||
| mandel | dobey, but is not a batch which means that the stupid cmd wont recognize the command :( | 16:56 |
| * mandel is scared that he knew what a dobeys 'hmm' meant | 16:57 | |
| dobey | mandel: you mean you have to run "python u1trial.exe" on windows? | 16:57 |
| mandel | dobey, yeah, ubber lazy I know, but is a pain to have to do python C:\Python27\Scripts\u1trial blah | 16:58 |
| mandel | dobey, since cmd does not recognize .py | 16:58 |
| dobey | mandel: but it's an .exe on windows right? | 16:59 |
| mandel | dobey, no, u1trial is not packaged | 17:00 |
| mandel | as an exe I mean | 17:00 |
| dobey | mandel: and how do you run syncdaemon/sso/etc? | 17:01 |
| mandel | dobey, you mean the tests or when we create the installers for the users? | 17:01 |
| dobey | mandel: i mean, when you run ubuntuone-syncdaemon to make sure it works, how do you run it? | 17:02 |
| mandel | dobey, python bin\ubuntuone-syncdaemon | 17:03 |
| mandel | but python is an exe so cmd recognizes it | 17:03 |
| dobey | mandel: right, because python is written in C | 17:08 |
| mandel | dobey, yeah, one of those tiny details ;) | 17:09 |
| mandel | dobey, so if we add a stupid batch with python u1trial in it add copy it to C:\Python27\Sripts if people add it to their cmd path they get it correctly :) | 17:09 |
| dobey | mandel: eww :( | 17:12 |
| dobey | mandel: is there no way to register interpreters some how? | 17:13 |
| mandel | dobey, is windows, eww is a common thing to say | 17:13 |
| mandel | dobey, yes there is, an you will say eww too :) | 17:14 |
| mandel | here: http://docs.python.org/faq/windows.html | 17:14 |
| dobey | mandel: install bash and just run everything under bash? :) | 17:16 |
| mandel | dobey, hahaha I use cygwin so I'm almost there :) | 17:17 |
| mandel | dobey, I really dislike python on windows, but don't tell anyone ;) | 17:17 |
| dobey | hooray, problem solved :P | 17:17 |
| dobey | i dislike python on * | 17:17 |
| dobey | so it's all good | 17:17 |
| mandel | dobey, haha nevertheless it would be nice to have the batch :) | 17:18 |
| === m_conley` is now known as m_conley_away | ||
| === m_conley_away is now known as m_conley_ | ||
| nessita | mandel: ping | 17:21 |
| mandel | nessita, pong | 17:21 |
| nessita | mandel: did you fix all the needs fixing I added to shutil-move? besides what we discusses in mumble | 17:21 |
| nessita | mandel: import out of order, invalid docstrings, etc | 17:21 |
| nessita | mandel: -> https://code.launchpad.net/~mandel/ubuntuone-client/dont-use-shutil-move/+merge/70595/comments/154631/ | 17:22 |
| mandel | nessita, yes, but looks like I did not push it, doing it now | 17:24 |
| mandel | nessita, can you create shares with mandel_shares_tests | 17:24 |
| nessita | mandel: ack | 17:24 |
| nessita | mandel: what's that? an username? or an invalid email? :-P | 17:24 |
| dobey | mandel: maybe, will think, because i don't like it | 17:24 |
| mandel | nessita, a user name :) | 17:25 |
| mandel | dobey, sure, is just a wishlist :) | 17:25 |
| nessita | mandel: you sure? how did you force a user username? | 17:25 |
| nessita | mandel: I mean, as far as I know there is no way to force a username... | 17:25 |
| mandel | nessita, oh, there is not... then I set my full name to that haha | 17:26 |
| nessita | or am I missing something? | 17:26 |
| mandel | nessita, how do you get the username? | 17:26 |
| nessita | mandel: query the rest api for the account info | 17:26 |
| nessita | mandel: https://one.ubuntu.com/developer/account_admin/account_info/ | 17:28 |
| nessita | mandel: you open the control panel and see the logs, the result is logged | 17:28 |
| mandel | nessita, the branch was pushed | 17:28 |
| mandel | nessita, ok | 17:29 |
| mandel | nessita, where are the logs then? in AppData\Local\sxdg ? | 17:29 |
| nessita | yeap | 17:30 |
| * mandel looks | 17:31 | |
| === zyga-afk is now known as zyga | ||
| mandel | nessita, which attr name should I look for in the json? | 17:32 |
| nessita | mandel: username? :-D | 17:32 |
| mandel | hehe | 17:33 |
| mandel | nessita, https://login.ubuntu.com/+id/xTcwtTw | 17:33 |
| mandel | nessita, looks as expected? | 17:33 |
| nessita | yeap | 17:34 |
| nessita | mandel: making one share now... | 17:34 |
| mandel | sweet :) | 17:34 |
| nessita | mandel: please note you will not get an email, but the share directly in your web ui | 17:34 |
| mandel | nessita, ok | 17:34 |
| mandel | nessita, got them, images-rw and images-ro | 17:35 |
| mandel | nessita, weird I also got some from alecu and ralsina | 17:36 |
| mandel | nessita, EOD here, I need to walk the dog or he will blow up :P | 17:37 |
| mandel | nessita, I have the shares so I'll run the IRL tests with both branches tom :) | 17:37 |
| nessita | mandel: ack | 17:38 |
| mandel | nessita, matt needs some one to ask for a 'feature' hehe | 17:38 |
| * alecu has left tests running, and is heading for lunch | 17:45 | |
| facundobatista | alecu, FS_FILE_OPEN? need fixing | 17:49 |
| facundobatista | nessita, ^ | 17:49 |
| nessita | facundobatista: also, my doubt was: adding a content to the sh5 in man in the middle is harmless for the test? | 17:50 |
| nessita | facundobatista: or we expect those events even if the sh5 file is empty | 17:50 |
| dobey | are there any u1client branches about to be approved soon? | 17:54 |
| nessita | dobey: yes, coming in! | 17:54 |
| nessita | dobey: I just approved one | 17:54 |
| dobey | nessita: can you try to time it so that 2 branches are aproved at the same time (that don't depend on each other)? | 17:55 |
| nessita | oh | 17:55 |
| nessita | yes, let me dessapprove this one then | 17:55 |
| nessita | dobey: I'll let you know | 17:56 |
| dobey | nessita: ok, thanks. i think the issue we discussed yesterday happens when there are 2 u1client branches approved, and stacked up for merging, so want to try and force that condition, to get some more data from tarmac :) | 17:56 |
| nessita | good | 17:56 |
| facundobatista | nessita, the events are the same | 17:56 |
| facundobatista | nessita, *should* be the same | 17:56 |
| nessita | facundobatista: but the problem is that we don't the the closewrite one if we don t write to the file | 17:57 |
| nessita | facundobatista: so I was wondering if we should fake the closewrite with an empty file | 17:57 |
| nessita | don't get* the... | 17:57 |
| facundobatista | nessita, maybe! the FS_FILE_CLOSE_WRITE is expected by the rest of SD if you do the open("foo", "w").close() | 17:58 |
| nessita | facundobatista: that is my point exactly | 17:58 |
| facundobatista | nessita, otherwise, you'd not get an Upload, for example | 17:58 |
| nessita | facundobatista: that's why I'm scared of fixing the test by adding a write to it | 17:58 |
| nessita | alecu: ^ | 17:59 |
| facundobatista | nessita, shouldn't be other tests in the notification part for this? | 17:59 |
| nessita | facundobatista: not sure what are you asking | 17:59 |
| facundobatista | nessita, I bet I had tests for all these operations! maybe those tests were tweaked? | 17:59 |
| nessita | facundobatista: well, most of test_eq_inotify is failing for us... so... probably there are tests that are failing because of that | 18:00 |
| nessita | facundobatista: so I would advice to alecu we keep having man in the middle failing and go a fix all the eq_inotify | 18:00 |
| facundobatista | nessita, OTOH, note that the events from man_in_the_middle are faked from LR | 18:03 |
| facundobatista | nessita, so, you shouldn't really get the events for the 'zz' file from the file notification part, but from LR | 18:03 |
| nessita | facundobatista: hum, man in the middle does depend on the FS events, no? | 18:04 |
| gatox_ | EOD for me! byeeeeeee | 18:04 |
| nessita | facundobatista: why is not pushing the CLOSEWRITE if is faked? | 18:05 |
| facundobatista | nessita, no idea | 18:05 |
| facundobatista | nessita, the events for 'zz' are faked in line 523 of local_rescan.py | 18:07 |
| nessita | facundobatista: maybe this is another issue related to stats? | 18:07 |
| facundobatista | nessita, when 'zz' is found as a new file | 18:07 |
| nessita | facundobatista: you mean line 498 | 18:07 |
| nessita | ? | 18:07 |
| nessita | 494 if different: | 18:07 |
| nessita | 495 # hash it to see the changes, Sync will take care | 18:07 |
| nessita | 496 log_debug("comp yield: file %r in LOCAL and changed", | 18:07 |
| nessita | 497 fullname) | 18:07 |
| nessita | 498 events.append(('FS_FILE_CLOSE_WRITE', fullname)) | 18:07 |
| facundobatista | nessita, the 'man in the middle' test is generating that case, exactly: put a file in a directory when LR is scanning that directory; LR should abort, re-scan again, and find that file as new | 18:08 |
| nessita | facundobatista: I still can't see where, I think you have an "old" trunk | 18:08 |
| facundobatista | nessita, no, I mean 527 from trunk revno 1103 | 18:09 |
| nessita | I have this in line 527 # hey, it's new! | 18:10 |
| nessita | you mean the event from line 533? | 18:10 |
| facundobatista | nessita, I mean the whole block code startnig from 527 | 18:11 |
| facundobatista | nessita, hey, 'zz' is new!! | 18:11 |
| nessita | right | 18:11 |
| nessita | let me confirm in the logs that we're going thru that branch | 18:11 |
| nessita | facundobatista: http://pastebin.ubuntu.com/663604/ <- zz does not apppear as "is new" | 18:22 |
| nessita | facundobatista: and, I'm puzzled, zz appears to be a... directory? :-/ | 18:22 |
| nessita | ah no, is not a dir | 18:22 |
| nessita | facundobatista: there are EQ events being pushed inside local rescan | 18:23 |
| facundobatista | nessita, if you run it in linux, it goes through that block | 18:23 |
| * nessita runs | 18:23 | |
| facundobatista | nessita, where the CREATE for zz comes? (line 77 in the log) | 18:24 |
| nessita | I don't know :-/ | 18:25 |
| facundobatista | nessita, ok | 18:25 |
| facundobatista | nessita, note that if LR is not going through the codeblock we said before, you're losing new files if they're created while LR is on that directory | 18:27 |
| facundobatista | nessita, LR should make two rounds on the same directory | 18:28 |
| nessita | facundobatista: right, I'm out of ideas what is going on in windows | 18:28 |
| facundobatista | nessita, the first one, when commiting, freeze_commit() (filesystem_notifications.py, line 168) should say that the process is dirty | 18:29 |
| nessita | facundobatista: can we restart the conversation when alecu returns? he will be debugging this | 18:29 |
| facundobatista | self.log.debug("Dirty by %s", self.frozen_evts) | 18:29 |
| facundobatista | nessita, ^ no "Dirty" in your log | 18:29 |
| nessita | right | 18:29 |
| nessita | so this is even more interesting | 18:29 |
| facundobatista | nessita, maybe we should mumble it? | 18:29 |
| nessita | facundobatista: definietly | 18:29 |
| facundobatista | nessita, is exactly what the test is testing :) | 18:29 |
| nessita | dobey: does this make sense? http://pastebin.ubuntu.com/663623/ can't run make under trunk in u1client | 18:30 |
| nessita | dobey: ignore me | 18:30 |
| nessita | dobey: I'm about to approve 2 branches, shall I continue? | 18:31 |
| ralsina | and hello again | 18:33 |
| nessita | hi ralsina | 18:33 |
| dobey | nessita: please | 18:33 |
| nessita | dobey: done | 18:34 |
| nessita | alecu: when you come back, let's talk about the events and LR | 18:34 |
| dobey | nessita: what was with the make error? you removed syncdaemon.conf? | 18:34 |
| nessita | dobey: yeap :-/ | 18:34 |
| nessita | dobey: I was testing a branch from roberto that adds default locations for .conf files | 18:35 |
| dobey | ah | 18:38 |
| ralsina | anyone needs reviews? | 18:39 |
| * fagan1 is available for reviews as well | 18:40 | |
| === fagan1 is now known as fagan | ||
| nessita | ralsina: we had the talk with lisette, and she still can't connect her client, can you please do the follow up with her? | 18:44 |
| ralsina | nessita: sure | 18:44 |
| ralsina | nessita: she's surely gone already, but I'll do it tomorrow early | 18:45 |
| nessita | ralsina: also, she mentioned we need some UI for the uninstall process, she files a bug and will propose some simple workflow | 18:45 |
| nessita | ralsina: yeap | 18:45 |
| nessita | ralsina: we also need to re-evaluate the payment stuff, are we gonna add that to the installer? I know before we said we won't, because server side was note ready, but maybe now is ready? would you know? | 18:46 |
| ralsina | nessita: AFAIK, it's not ready, and I am not planning it for this release | 18:46 |
| nessita | ralsina: do we know when will it be ready server side? | 18:46 |
| nessita | ralsina: she mentioned that if we don't have that, she needs to build new workflows for the sync local folders frame, since the user may run out of quota by choosing too many folders | 18:47 |
| ralsina | nessita: I'll ask beuno, but with the new accounts stuff I am not sure it's even possible | 18:47 |
| ralsina | nessita: the mockup has a "you are using too much space, click here to buy space" message | 18:47 |
| ralsina | nessita: and that's actually implemented | 18:47 |
| nessita | ralsina: right, but she mentioned we should not send the user to the web at that point | 18:48 |
| beuno | ralsina, what? | 18:48 |
| beuno | I thought the embedded thing was all ready to go? | 18:48 |
| nessita | ralsina: I think the button was suppose to take the user to the payment frame (local( | 18:48 |
| nessita | )) | 18:48 |
| ralsina | beuno: no, that button goes to the web because we were not implementing that | 18:48 |
| nessita | ralsina: well, lisette is not aware of that... did you talk to her about that? | 18:49 |
| ralsina | beuno, nessita: if we go the embedding way, we can probably do it | 18:49 |
| beuno | ralsina, what? why? what did we do that work then? | 18:49 |
| nessita | ralsina: you lost me too :-) | 18:50 |
| nessita | shall we mumble? | 18:50 |
| ralsina | beuno: we are going to use it, but we haven't had time to do it for this release :-( | 18:50 |
| beuno | oh | 18:50 |
| beuno | :( | 18:50 |
| beuno | ok | 18:50 |
| nessita | ralsina: we're going to use what where? :-) | 18:50 |
| ralsina | nessita: beuno & team created a no-header/ no-footer version of the site | 18:50 |
| dobey | magic | 18:50 |
| ralsina | nessita: so, we could embed that to do our "buy stuff" page | 18:51 |
| nessita | ralsina: the whole site? | 18:51 |
| beuno | nessita, yes, the whole site | 18:51 |
| ralsina | nessita: yes | 18:51 |
| beuno | any page will work on any size | 18:51 |
| beuno | and you can log in the user with an oauth token | 18:51 |
| ralsina | and since it has no navigation in it, you can't wander off into bad places | 18:52 |
| nessita | beuno, ralsina: can we mumble for a few minutes? I have some questions... | 18:52 |
| ralsina | nessita: sure | 18:53 |
| beuno | sure | 18:53 |
| ralsina | beuno: I admit that "si nos sobraba tiempo" is just a way to say no ;-) | 19:03 |
| ralsina | and we are/will be using the headless/footless view for TOS too | 19:03 |
| beuno | cool, np | 19:04 |
| dobey | grumble. | 19:05 |
| * alecu is catching up with the backlog | 19:31 | |
| nessita | alecu: when you're ready, let's have a mumble with facundobatista | 19:34 |
| facundobatista | nessita, alecu, I'm leaving in 20' to Felipe's doctor, so hurry up, or let's talk tomorrow | 19:35 |
| nessita | facundobatista: entering mumble | 19:35 |
| alecu | entering | 19:35 |
| nessita | facundobatista: vení! | 19:36 |
| ralsina | ugh, IRC was down and I didn't notice. Missed anything? | 19:43 |
| ralsina | dobey: did you see the canonistack announcement? How do you feel about tarmac on that? | 19:43 |
| dobey | i feel like FML right now with all the problems i'm having. and no i haven't seen anything really | 19:44 |
| ralsina | dobey: whoa, anything I can help you with? | 19:46 |
| dobey | tell me why gpg won't accept my passphrase? :) | 19:47 |
| ralsina | dobey: I have three answers for that, and they all are going to make you want to punch me, so pass ;-) | 19:50 |
| dobey | brb | 19:58 |
| fagan | joshuahoover: hey, got your email, ill go do that link change tomorrow morning | 20:06 |
| fagan | shouldnt take that long | 20:07 |
| joshuahoover | fagan: ah, cool...i just sent an update on doing redirects instead | 20:07 |
| fagan | joshuahoover: well I dont mind changing them anyway | 20:07 |
| joshuahoover | fagan: thanks! | 20:07 |
| fagan | its just a find and replace and not all pages need to be updated | 20:08 |
| joshuahoover | fagan: all faqs and tutorials on the wikis do need this | 20:08 |
| fagan | joshuahoover: yep but most of the FAQ pages dont have links luckly enough :) | 20:08 |
| ralsina | fagan: they probably have links somewhere else. Nothing is ever actually lost in the internet you know ;-) | 20:09 |
| joshuahoover | fagan: right, but they all need to be redirected to their new pages on the u1 site | 20:09 |
| fagan | joshuahoover: cool will do | 20:09 |
| fagan | Wow I didnt actually look at the FAQ and tutorials section of the site its looking great | 20:11 |
| alecu | nessita, dobey: I want to remove the "-c" from the call to u1trial in run_tests.bat in u1-client | 20:16 |
| alecu | nessita, dobey: we should be able to use "run_tests.bat -c" instead | 20:17 |
| dobey | alecu: i don't understand that exactly | 20:18 |
| nessita | alecu: I'm not sure that'll work, I mean, if we don't pass the -c tests the suite is not run under windows | 20:18 |
| alecu | nessita, -c means "run coverage tests" | 20:18 |
| nessita | alecu: really??!? | 20:18 |
| nessita | alecu: then ignore me :-) | 20:19 |
| alecu | nessita, and that's the coverage report that's shown at the end of the test run. | 20:19 |
| alecu | dobey, I don't understand what you don't understand | 20:19 |
| dobey | well -c means "show coverage report" | 20:20 |
| nessita | alecu: right, so, I don't understand how without the -c I could not run the test suite when I was first trying to run this. Maybe I had more errors that I did not notice | 20:20 |
| dobey | alecu: i don't understand why you want to require passing those args to run-tests.bat, given that run-tests.bat isn't just running u1trial i presume, but also style checks? | 20:21 |
| alecu | dobey, I want it to stop running the coverage checks, because those lines make the tests result scroll by | 20:22 |
| dobey | ah | 20:24 |
| alecu | dobey, in fact, when I run run_tests.bat with a specific regex of tests, coverage and style checks are annoying. | 20:24 |
| dobey | alecu: why don't you just run u1trial with the args you want then? | 20:24 |
| dobey | alecu: or is this "it's a pain because it's windows" ? | 20:25 |
| alecu | dobey, because the cmdline is huge. I suppose I can make a script to just run that. | 20:25 |
| alecu | but since run_tests.bat already has a way to specify parameters to u1trial, it makes sense to use it | 20:25 |
| alecu | and if run_tests changes to update some env var or anything, I won't have to update my scripts. | 20:26 |
| dobey | alecu: but it means the default is to not do all that stuff, if you modify it to only do that stuff when you say to | 20:26 |
| dobey | alecu: i think by default, it should check/report as much as possible | 20:27 |
| alecu | dobey, it's called "run_tests". Not "run_test_and_coverage_and_clean_lint_balls" | 20:28 |
| dobey | alecu: do you really want to type the latter to run everything and make sure your stuff is ready for commit? | 20:29 |
| dobey | or do you want to type run-tests | 20:29 |
| dobey | and it should be run-tests. for some reason ralsina and mandel have an underscore fetish or something :) | 20:30 |
| alecu | dobey, cmd.exe autocompletes as well. You've used windows after 2001, right? | 20:30 |
| alecu | :-) | 20:30 |
| ralsina | dobey: I don't get it, it's called run-tests.bat | 20:31 |
| dobey | ralsina: then why is everyone typing run_tests.bat in irc?! | 20:31 |
| ralsina | dobey: beats me :-) | 20:31 |
| dobey | alecu: i haven't used DOS since 1995, no :) | 20:31 |
| dobey | in windows i click on icons and then kill monsters | 20:32 |
| ralsina | dobey: let me bring you up to speed: it has the same "history automplete" as in 1993, history is more broken, but it does autocomplete filenames (but not command names ;-) | 20:32 |
| alecu | dobey, cmd.exe is NT, not DOS. anyway, I don't mind typing something long just before sending stuff to commit. I just hate typing "python c:\python27\scripts\u1trial --reactor=twisted tests -t whatever" every time I need to run some tests. | 20:33 |
| dobey | ralsina: heh | 20:34 |
| ralsina | alecu: python c:[f8] | 20:35 |
| dobey | alecu: really i'm not picky about it, but it should do everything by default. beyond that i really don't much care :) | 20:35 |
| ralsina | but yes, that would be really nice to have | 20:35 |
| nessita | ralsina: this is the bug lisette filed for the uninstaller bug #824653 | 20:35 |
| ubot4 | nessita: Bug 824653 on http://launchpad.net/bugs/824653 is private | 20:35 |
| ralsina | nessita: thans, posted a description of what's doable | 20:37 |
| alecu | ralsina, I didn't get the "[f8]" :-( | 20:42 |
| ralsina | alecu: f8 key | 20:42 |
| alecu | ralsina, I got that right. But I still don't get it | 20:43 |
| ralsina | alecu: if you have typed that command before, it will autocomplete it | 20:43 |
| ralsina | sadly, it doesn't persist through sessions | 20:43 |
| alecu | ralsina, oh, the mighty doskey | 20:43 |
| ralsina | yep | 20:44 |
| alecu | ralsina, I usually use the UP key to get at that command. But it's between sessions that's annoying. | 20:44 |
| karni | nhaines: ping | 21:09 |
| === m_conley_ is now known as m_conley_away | ||
| nhaines | karni: pong | 21:11 |
| karni | nhaines: Hi man, got a minute? | 21:11 |
| nhaines | karni: sure thing. what's up? | 21:12 |
| karni | nhaines: I made notifications, that are left *after* UBuntu One Files has uploaded/downloaded files | 21:12 |
| karni | nhaines: I've also changed the notifications during transfers (no progress bar yet, though) | 21:12 |
| karni | nhaines: And I have a question here | 21:13 |
| karni | nhaines: Assume you upload a file, then tap two files to download | 21:13 |
| karni | nhaines: You'd see "Uploading file 1 of 1" (on-going notification) | 21:13 |
| karni | nhaines: afterwards, you'd see "Downloading file 1 of 2", and "2 of 2" accordingly | 21:14 |
| karni | nhaines: After transfers have finished, you'd see a notification that you can dismiss, saying "Uploaded 1 of 1 files, Downloaded 2 of 2 files" (or 1 of 2, say, if one dowload has failed) | 21:14 |
| karni | nhaines: Now the question | 21:15 |
| nhaines | Okay. :) | 21:15 |
| karni | nhaines: Is it ok, to jump between ongoing upload and download notifications. I don't want to overwhealm the user, and post too lenthy notification texts. | 21:15 |
| dobey | cheers everyone. have good evenings | 21:15 |
| karni | bye dobey | 21:15 |
| nhaines | Good night dobey. | 21:16 |
| karni | nhaines: Instead of posting "Uploading 1 of 1 files, Downloading 0 of 2 files" (because it's uploading stuff at that moment, not downloading) | 21:16 |
| karni | nhaines: What do you think? | 21:16 |
| nhaines | I think it's better to just have one notification for that and not two separate ones. | 21:16 |
| karni | nhaines: When you have on-going transfers, you'll see it in "On-going" notification area | 21:18 |
| nhaines | I'd rather have a larger text in the notification area than constant updates across the notification bar when I'm doing other things. | 21:18 |
| karni | nhaines: Once they're done, that one will disappear, and a dismissable notification will be posted at the bottom of notificatoin area. | 21:18 |
| karni | nhaines: It's a little smarter than that. | 21:18 |
| karni | Let me explain. | 21:19 |
| nessita | dobey: have we made a release of u1cp before feature freeze? | 21:19 |
| nessita | dobey: I keep seeing the LOGFOLDER import error coming in in bugs reports | 21:19 |
| karni | nhaines: If you tap 10 files "tap tap tap ...", you'll only see first notification "Downloading file 1 of 1" | 21:19 |
| karni | nhaines: But as you tap the 2...10 files, the notificaiton will be updated, without showing it in the ticker area (you know, poping it at the top for 2 seconds) | 21:19 |
| nhaines | karni: okay, good, that's what I imagined. | 21:20 |
| karni | nhaines: So, the deal is (an extreme example), you upload some files, download some, then upload again, and download | 21:20 |
| karni | nhaines: You'd see "Uploading file 1 of 3", then "Downloading file 1 of 2", "2 of 2", "Uploading file 2 of 3", "3 of 3", "Downloading file 2 of 2", and lastly the dismissable notificaiton. | 21:21 |
| karni | nhaines: And the ticker (the visible notification in the system bar) would show: | 21:22 |
| karni | nhaines: 1) either once and then 2) second for the summary "Uploaded 3 of 3 files, Downloaded 2 of 2" | 21:23 |
| karni | nhaines: or every time it's a different type of transfer. so, 1) upload 2) download [+silent download] 3) upload [+silent upload] 4) download 5) summary | 21:24 |
| karni | nhaines: It's pretty hard to explain. Do you follow? | 21:24 |
| nhaines | I think so. | 21:25 |
| karni | nhaines: If it changes from "I'm downloading files" to "Oh, now I'm uploading some files", would you like to see a notification ticker (text in the system bar)? | 21:25 |
| karni | OR only "I'm doing stuff now" and then "I've done this and that, I'm done." | 21:25 |
| nhaines | I'd prefer the first one: once and then second for summary. | 21:25 |
| nhaines | Or 1) once for upload, 2) once for download, and 3) combined summary. | 21:25 |
| nhaines | If that makes any sense. :) | 21:26 |
| karni | nhaines: So if you've scheduled an upload after step 2) (uploading a custom file), you'd like it to be silent update of the notification then? | 21:26 |
| nhaines | Yes, I think so. | 21:27 |
| karni | nhaines: What's the time at your timezone | 21:27 |
| karni | *? | 21:27 |
| nhaines | karni: it's 14:28 PDT right now. | 21:28 |
| karni | nhaines: Oh, that's pretty cool. I can sent you an apk in the middle of the night here hahah. | 21:28 |
| nhaines | karni: haha, yup! | 21:28 |
| nhaines | U1 Files has really impressed my friends with both my Android phone and Ubuntu. It's super useful to me to be able to text short URLs of files to friends. | 21:30 |
| alecu | nessita, ralsina: please review? https://code.launchpad.net/~alecu/ubuntuone-client/errback-watches/+merge/71283 | 21:30 |
| ralsina | alecu: sure! | 21:30 |
| karni | nhaines: I'm happy to hear that! I'm working on it every day to improve it. Although some changes are (sadly) less visible than others. | 21:32 |
| nessita | alecu: looking! | 21:33 |
| nessita | ralsina: you forgot to actually approve this one, can you please? https://code.launchpad.net/~nataliabidart/ubuntuone-client/no-makedirs/+merge/71101 | 21:33 |
| ralsina | sure | 21:33 |
| ralsina | nessita: done, sorry | 21:34 |
| nessita | is ok | 21:35 |
| nessita | alecu: I think you're masquerading error from pywintypes here except Exception as error: | 21:36 |
| alecu | nessita, I explicitly removed the import of pywintypes.error (see lines 84, 85 in the diff) | 21:37 |
| nessita | alecu: you're so right | 21:37 |
| alecu | nessita, I want to catch *every* exception | 21:37 |
| nessita | alecu: I swapped read and green in my head :-/ | 21:38 |
| alecu | nessita, cool :-) | 21:38 |
| alecu | nessita, eso te pasa por juntarte con batista! | 21:38 |
| nessita | lol | 21:38 |
| ralsina | alecu: +1 on that branch | 21:47 |
| alecu | ralsina, great, thanks. | 21:47 |
| nessita | alecu: silly change, can you please capitalize """throw a fake exception.""" | 21:48 |
| alecu | Absolutely | 21:48 |
| alecu | nessita, change pushed | 21:50 |
| === yofel_ is now known as yofel | ||
| dobey | nessita: is because of new ubuntuone-client. i will do a cp release tomrrow to fix it | 21:54 |
| nessita | dobey: thanks!!! | 21:57 |
| nessita | alecu: approving | 22:05 |
| alecu | woohooohoo | 22:05 |
| nessita | bye all! see ya guys tomorrow | 22:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!