[00:16] mtaylor: hi ? === wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: wallyworld* (jtv) | Critical bugs: 234 - 0:[#######=]:256 === lifeless changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: wallyworld* (jtv) | Critical bugs: 238 - 0:[#######=]:256 [00:34] hi lifeless [00:41] mtaylor: what can I do for yo u? [00:42] lifeless: well, I was going to chat with you about the possibility of having branch links in bugs be able to point to external branches [00:42] lifeless: talked with thumper about it a little bit [00:42] lifeless: he indicated that it would not be trivial, which I kindof figured [00:42] well [00:43] so the key thing is that we currently have two sorts of remote branch [00:43] 'imports' and 'mirrors' [00:43] jelmer is -right now- nuking 'mirrors' so we will only have 'imports', which includs just-copy-a-bzr-branch [00:43] I don't think we want 'a branch we know about but cannot read the data from' [00:44] are imports one-time imports? [00:44] so it should be trivial - register the branch from your gerrit integration scripts, and reference it thereafter [00:44] mtaylor: no [00:44] ok. cool [00:44] mtaylor: but tuning the import system to deal with branches that get deleted, and or have a way to massively dial back the probing when a branch goes quiet - those are good things in their own right [00:45] yes. I imagine that they are - also probably dealing with rebases of those too, if you don't already [00:45] I need to pop out for a quick grocery trip; will respond to anything more upon my return :) [00:45] k. I'm good for now [00:47] * wallyworld_ has to go and pick up dog. back soon [00:48] rebasing should be fine [00:48] -> gone [01:20] back [01:24] mtaylor: oh there is something [01:24] lifeless: mmyesss? [01:25] mtaylor: can you pull in the fd fix for the jenkins bazaar plugin ? I haven't gotten setup on git for that yet... [01:25] bazaar-plugin/pull/6 [01:25] https://github.com/jenkinsci/bazaar-plugin/pull/6 [01:25] lifeless: it's already merged - I just need to release it [01:26] mtaylor: ... Do....It....Please...? [01:26] lifeless: a) do you need me to give you push access on that? and b) have you tested the tree sufficiently so that you are satified with me releasing it? [01:26] mtaylor: there are a couple others there too I think. Or maybe I'm thinking of platformlabeler [01:26] lifeless: I also added lightweight checkout support in the tree ... [01:26] but haven't tested extensively [01:27] mtaylor: I don't know if I do/don't have push access there. If I don't, I think I would probably be more useful with it... [01:27] rbtcollins on github [02:43] rbtcollins ?? Robert ... Bloody Terrific Collins? [02:47] yes, yes indeed [02:50] Project db-devel build #801: STILL FAILING in 6 hr 12 min: https://lpci.wedontsleep.org/job/db-devel/801/ [03:59] Project devel build #965: STILL FAILING in 6 hr 29 min: https://lpci.wedontsleep.org/job/devel/965/ [05:07] lifeless: Still getting that oops rubbish [05:07] lifeless: And wgrant hit it last night too [05:08] However, my Storm release hit devel and it's stopped whinging about that at least [05:10] cool [05:11] the oops thing is bizarre [05:11] it should be temporary - I hope to have that oops stuff fully removed earliy next week [05:12] lifeless: Can haz DB patch number? [05:14] self service! [05:14] Eh? [05:14] I can do that? [05:14] https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess [05:14] you might like to refresh your memory, cause it has been changed ;) [05:15] (and announced to tl's who were meant to point everyone at it :P) [05:15] https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess#Patch ids [05:15] is the specific bit you need [05:15] lifeless: Oh, so, should I add some indinces to this patch? [05:16] lifeless: (I'm adding SPN and BPN to SPPH and BPPH) [05:18] you'll need two patches [05:18] see https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess#Background [05:18] (yes, we will almost certainly need some indices :P) [05:19] I see that I can't do ALTER TABLE live [05:19] adding the columns is a cold patch [05:19] it will go in fastdowntime [05:19] adding the indices is hot, so will get deployed after the downtime [05:20] So, I want -1 or something with the ADD COLUMN patch? [05:20] https://dev.launchpad.net/Database/LivePatching has various bits of gory detail, but is still a work in progress [05:20] yup, exactly. [05:21] then we deploy that, then a garbo job to migrate [05:21] Yes [05:23] (ok, I'm telling you how to suck eggs... sorry :)) [05:24] I'll worry about indexes later [05:25] yup [05:33] meep [05:33] testPartnerUploadToNonReleaseOrProposedPocket [05:33] is not generating an oops for me >< [05:33] Then you broke it [05:33] :-P [05:34] prethumably, but I have no idea how [05:34] I hate how it fails by telling you a completely unrelated oops happened [05:35] StevenK: this is for my useoops branch - ec2 found some tests [just tests so far] that I'd missed updating [05:47] lifeless: https://code.launchpad.net/~stevenk/launchpad/denorm-bspph/+merge/71303 [05:47] we didn't test spph - things seemed fast on the source side anyhow [05:47] (do we need it?) [05:48] It would be handy for overrides. [05:48] StevenK: do you need to specify that those int columns are foreign keys? [05:50] *shrug* It could go either way [05:56] StevenK: imho, they should be specified as foreign keys for referential integrity but i'm sure a dba can provide definitive input [05:57] No reason for them not to be foreign keys, and they should be. [05:57] StevenK: i won't claim the review since there's already 2 highly qualified people on the review list :-) [05:58] wallyworld_: you couldn't be authoritative anyhow [05:58] wallyworld_: db patches have a different review rule [05:58] https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess#Reviews [05:59] yes, they should be FK's [06:05] lifeless: Done. So I need to wait until Monday? [06:05] I suppose it can't land until FDT anyway [06:05] yes [06:05] you can land it when its reviewed (on db-devel as all schema patches do) [06:05] we'll deploy it as soon as we can [06:06] And then how it does flow back into devel? [06:10] depends [06:10] if things are merged up, cherrypick merge. [06:10] bah [06:10] are *not* merged up [06:10] cherrypick merge [06:10] if they are merged up, a regular merge [06:10] to be merged up, all that is on db-devel before the thing being deployed must be also deployed. [06:23] g'morning [06:27] heya jelmer [06:28] ok, tests fixed. \o/ [06:28] StevenK: want to do an incremental review of test fixups ? I would say 'no' if I were you ;) [06:29] Fine, no :-P [06:30] woot, lp-land time! [06:30] Ask wallyworld_ :-P [06:31] meh, its all the same mechanical stuff you saw before [06:31] with some do-it-the-easy way stuff for extra credit [06:31] (actually, I'm ec2 landing, cause i don't want a broken trunk on friday evening, but bah) [06:34] argh, I want bandwidth. sob. [06:34] Using saved parent location: bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/ [06:34] 983kB 2kB/s / Fetching revisions:Inserting stream:Estimate 688/1174 === wallyworld_ changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 238 - 0:[#######=]:256 [07:44] good morning [07:54] hi adeuring [07:54] hi jelmer! === adeuring changed the topic of #launchpad-dev to: Das Thema für #launchpad-dev ist: https://dev.launchpad.net/ | On call reviewer: adeuring | Critical bugs: 238 - 0:[#######=]:256 [08:07] 2011-08-11 10:38:53 WARNING public.spn_lookup not in calculated lpmain replication set. Update *_SEED in replication/helpers.py [08:07] lifeless: ^^ is that you? [08:07] lifeless: Caused the staging full-update to blow up, although the appserver came back OK. [08:07] Project db-devel build #802: STILL FAILING in 5 hr 17 min: https://lpci.wedontsleep.org/job/db-devel/802/ [08:08] That would be lifeless, yes [08:10] wgrant: heh, >< [08:10] wgrant: today? [08:10] that temp table had hung around [08:10] lifeless: Around 10am. [08:10] Maybe more 11am. [08:11] My time. [08:11] dropped it now [08:11] Thanks. [08:12] We'll see in 16 hours if it worked. [08:12] Really need to turn off those jobs. [08:13] The topic is a bit more German than usual. [08:14] :-) [08:24] Yippie, build fixed! [08:24] Project db-devel build #803: FIXED in 16 min: https://lpci.wedontsleep.org/job/db-devel/803/ [08:26] WHAT? [08:26] * StevenK kicks Jenkins. In the face. [08:27] StevenK: \o/ [08:28] successful: lp.buildmaster.tests.test_manager.TestBuilddManagerScript.testBuilddManagerRuns [08:28] Killed [08:28] Hmmmmm [08:29] [67994.667699] Out of memory: kill process 13032 (xvfb-run) score 198282 or a child [08:29] Whee [08:29] Not much I can do about the OOM killer [08:31] StevenK: How big is the instance? [08:32] Morning [08:32] c1.xlarge, 2Gb of RAM [08:55] jelmer: Did you see the odd failure on https://code.launchpad.net/~doko/gcc/4.6? [08:59] wgrant, the database one? [08:59] http://launchpadlibrarian.net/77073020/doko-gcc-4.6.log [09:00] Says it took an hour, but there's only two minutes and a timeout in the log. [09:02] hmm, that's odd indeed [09:13] StevenK, wgrant: did one of you upgrade the schema on DF? [09:13] Not I. [09:13] I wanted to do my new patch myself so I could note how long it took. I guess I can;t now. >:( [09:13] DF is invalid. Use staging. [09:14] Patch number? [09:14] well also if staging actually told me how long it took that'd be nice [09:14] DF is not invalid. It's always slower. [09:14] 80-1 [09:15] ah it's in the l-d-r table [09:15] It is. [09:15] forgot about that, I was hunting logs [09:16] It's also not on staging yet. [09:16] Will be in 10ish hours. [09:16] The last few updates failed because lifeless was a bad person. [09:16] it is on staging [09:16] Huh. [09:16] was on staging yesterday [09:17] Oh, right, it applies the patches before it crashes. [09:17] Just doesn't print the times. [09:17] right [09:17] which is.... not useful [09:17] But you can still get the timing from there, since you have access. [09:22] yes, but most people can't [09:24] "Bad magic number" ... I hate pyc files [09:24] wgrant: was not [09:24] wgrant: the script considers *temporary* tables [09:24] wgrant: thats a bug :) [09:26] lifeless: That was a temp table? [09:26] Oh, right, I remember we had this problem a while ago. [09:27] Guess we should check relistemp. [09:27] wgrant: yes, 'create temp table spn...' [09:29] Bah, oops fail. [09:29] Ah, no, unrelated. [09:36] lifeless: Ah, temp tables were fixed in security.py, but replication.helpers says this: [09:36] # Ignore any tables and sequences starting with temp_. These are [09:36] # transient and not to be replicated per Bug #778338. [09:36] <_mup_> Bug #778338: restartable multitablecopier interacts badly with replication and upgrade operations < https://launchpad.net/bugs/778338 > [09:36] It doesn't check properly. [09:37] yeah [09:37] win [09:38] Should probably use the same pg_table_is_visible check that security.py has. === jkakar_ is now known as jkakar [09:53] allenap: Is bug 812583 QAable? [09:53] <_mup_> Bug #812583: IndexError in add_template_values in loggerhead annotate

< https://launchpad.net/bugs/812583 > [09:53] * allenap looks [09:54] gmb: Yeah, probably :) I'll give it a go now. [09:57] allenap: Thanks [10:01] Project devel build #966: STILL FAILING in 6 hr 2 min: https://lpci.wedontsleep.org/job/devel/966/ [10:03] gmb: Do you know how I get a branch into qastaging? [10:03] allenap: You beg a LOSA [10:03] allenap: Sodomy non sapiens, I'm afraid. [10:03] FFS. [10:04] Or land it via stable :-) [10:05] StevenK: Ah, oops, I was unclear. I mean, I want a branch to be available in codehosting in qastaging. [10:05] Oh, that use. [10:09] allenap: Also, does bug 796669 actually need QAing since it's a testing-related issue? [10:09] <_mup_> Bug #796669: The lp.registry.distroseriesdifferences_details module (javascript) is very hard to test.

< https://launchpad.net/bugs/796669 > [10:09] rvba: ^ [10:10] allenap: gmb I'm on it. [10:11] allenap, rvba: Ah, sorry, yes. I forgot that "person who filed the bug" != "person who fixed it" [10:11] Hehe. [10:23] matsubara, hi, I find that OOPS from bug 690568 doesn't really match up well with what the bug describes — do you have any idea what might be going on? [10:41] Does anyone know how I can create a revision without a commit message? bzr forbids. === vila is now known as babune [10:48] allenap: -m " " ? [10:48] StevenK: I needed a properly empty revision for QA. [10:49] s/revision/message/ [10:50] StevenK: I've done it now; wgrant suggesting bzrlib directly, which was quite straightforward with the help of Google. [10:50] allenap: Indeed, I saw, since IRC is good like that. :-) === babune is now known as vila [11:13] StevenK, wgrant: IArchive.getPublishedSources() doesn't use a default status. This seems dangerous to me, I am tempted to make it default to PUBLISHED. Thoughts? === henninge is now known as henninge-lunch [11:38] adeuring, hi, I've got a short branch up for review https://code.launchpad.net/~danilo/launchpad/bug-728220/+merge/71343 [11:38] bigjools: PUBLISHED is dangerous. [11:39] bigjools: [PUBLISHED, PENDING] is necessary but dangerous unless you're sure that you're expecting it. [11:39] Nothing is safe. [11:39] So there is no sane default. [11:39] well with a method called getPublishedSources, you'd expect published sources, no? :) [11:40] pending is assumed to be returned anyway [11:40] Published, published, or published? [11:40] There are three definitions. [11:40] Currently published. [11:40] Published. [11:40] And having been published. [11:40] I don't expect superseded sources [11:40] that's the dangerous part [11:40] Let me guess. [11:40] heh [11:41] You initialised a distroseries with the parents' entire history? [11:41] define "you" [11:41] but yes [11:41] Heh. [11:41] and does explain the IDS script memory usage [11:41] to some extent anyway [11:41] Not entirely, but it goes some way. [11:41] Right. [11:42] I still think defaulting to (pending, published) is right [11:45] Possibly. [11:48] casual users will get a big surprise [11:50] danilos: I'll look [11:51] adeuring, thanks === bac changed the topic of #launchpad-dev to: Das Thema für #launchpad-dev ist: https://dev.launchpad.net/ | On call reviewer: adeuring, bac | Critical bugs: 238 - 0:[#######=]:256 [11:52] hi adeuring -- how goes the battle? [11:53] morning bac, I must admit that I did not do many reviews this morning [11:53] henninge-lunch: Considering a deployment today? [11:53] wow, the deployments are daily now? [11:53] jelmer: We've been doing around 1.5 a day lately. [11:53] that's really exciting. [11:54] We can even deploy codehosting without downtime now, although it's slow so we don't do it normally. [11:54] This leaves librarian, ftpmaster and poppy as the only downtime services. [11:54] And librarian will be fixed in a week or two. [11:55] And we can fix ftpmaster now. [11:55] So we are just about fully nodowntime. [11:57] danilos: the branch looks good. Just one question: did you consider to treat something like SELECT 'a''b'? Not really important to fix the bug, I assume, but anyway... [12:01] adeuring: i'm starting on jtv's branch [12:01] bac: ok [12:04] adeuring, I didn't bother spending too much time considering the queries in OOPSes are all very "standard" [12:05] adeuring, I was also thinking about escaped quotes, but they can't show up in what we care about most, so no big deal [12:05] danilos: right, so r=me. [12:06] adeuring, thanks [12:07] bigjools, wgrant: how do I make a PPA private on staging? (I want to do it for https://qastaging.launchpad.net/~danilo/+archive/epiphany so I can get a fresh OOPS for bug 690568) === henninge-lunch is now known as henninge [12:20] wgrant: had not thought of that yet but sure ;-) [12:37] danilos: you need to be a commercial admin and you need an empty PPA [12:38] wgrant: requested ;) [12:38] I can do it for you if you give me an empty one [12:38] bigjools, oh, so a new one needs to be created? sure thing, just a minute [12:39] bigjools, https://qastaging.launchpad.net/~danilo/+archive/empty [12:40] danilos: done [12:40] bigjools, thanks [13:00] adeuring, bac: Which of you two wants to review a massive-oversized mostly-scripted branch? [13:01] StevenK: wow, you're a salesman at heart [13:01] Haha [13:01] StevenK: I'll look [13:01] StevenK: i'm in the middle of a mildly oversized branch ATM [13:01] but let me finish another review first [13:01] adeuring: I will owe you at least one beer, possibly more. It's 4,701 lines. [13:01] StevenK: so you'll be next whichever one of us getst there first [13:02] * adeuring runs awy [13:02] nah, it's fine [13:02] StevenK: that is 6 times the limit, so i think you'd owe him at least five beers [13:02] Haha [13:03] It's only 5.9 times the limit, so 4.9 :-P [13:07] wgrant: If you're still around: is your fix for bug 824368 QAable? [13:07] <_mup_> Bug #824368: security.py takes 6 seconds per DB < https://launchpad.net/bugs/824368 > [13:07] gmb: The next (not current) staging update will do it. [13:08] wgrant: Okay, thanks. [13:08] But it's on db-devel, so nobody should care... [13:08] Ah, fair point. [13:08] We should have a qa-yeahwhatever tag. [13:08] You tag it like that and see what the tagger does. [13:08] It would be amusing. [13:12] wow, we've got 73 bugs that are fix committed in launchpad-project [13:12] (well, bug tasks, but still) [13:34] danilos: Indeed. I'm trying to drive down the QA list to the point where we can roll a bunch of those out. [13:52] did someone break devel? [13:52] danilos, for some time we had a duplicationa on oops prefixes and then got oopses with the same oops id [13:52] s/devel/db-devel/ [14:02] bigjools, I believe check-db-revisions is not running anymore, try 'make schema' first [14:03] matsubara, oh, so you think this is just an old one (i.e. no need to worry about them still being overwritten like this)? [14:05] danilos, I'll double check, but I think it's been fixed and this is one of the old cases [14:05] matsubara, excellent, thanks [14:06] danilos: it failed in ec2 [14:06] but thanks for reminding me about that :) [14:07] Project devel build #967: STILL FAILING in 4 hr 5 min: https://lpci.wedontsleep.org/job/devel/967/ [14:20] Yippie, build fixed! [14:20] Project devel build #968: FIXED in 12 min: https://lpci.wedontsleep.org/job/devel/968/ [14:22] adeuring or bac: could you please review https://code.launchpad.net/~abentley/launchpad/push-creates-package/+merge/71366 ? [14:23] abentley: I need to finish another review; when that is finished, I'll have a look [14:24] adeuring: thanks. [14:28] danilos, just checked and we have only one config with oops_prefix: C in the configs branch. If I remember correctly that's the generic prefix used and have been changed to the REPORTIFSEEN on loganberry [14:29] if you spot an oops redirecting to the wrong oops report, let me know [14:42] adeuring: i can do abentley's review unless you've already started [14:42] bac: I was just now going to start it :) I'll do it [14:42] adeuring: ok [14:45] matsubara: Hi, looks like my branch (about improving the JS of the reports) made it into db-stable. Just to give you a heads up :). === micahg_ is now known as micahg [14:47] thanks rvba [14:48] np [14:49] rvba, the ppr branch is now on r10890. [14:52] matsubara: great, do you know how often the report generation script runs? [14:54] rvba, we have a couple of lines in the crontab. did you change only the ppr or the ppr and the dbr? [14:55] in any case here's the crontab lines: [14:55] rvba, https://pastebin.canonical.com/51172/ [14:55] Only the ppr. [14:55] so basically, once a day for the ppr and more often for the dbr [14:56] I'll kick a run of the ppr script now so you can try things. give a sec [14:56] Thanks a lot! [15:09] abentley: overall, a nice branch. The only thing that puzzled me was that you had to add the valid_name() call to SourcePackageNameSet.new(). I understand that it is necessary -- but where and how was the validity check done before? [15:10] adeuring: There's a check constraint on the database, but I wanted to get a more specific exception than the database one. [15:10] abentley: ah, ok. thanks. So, no conflicts, I assume. r=me [15:11] adeuring: thanks. [15:27] rvba, hey, I didn't forget about you. script is still running. I'll ping you when it finishes [15:28] thanks matsubara [15:39] adeuring,bac: can either of you review https://code.launchpad.net/~cjwatson/meta-lp-deps/new-apt/+merge/71386 ? [15:40] cjwatson: sure, I'll look [15:47] I don't know the process for actually getting that into the PPA, although it seems to involve recipes [15:50] cjwatson: the diff against devel is huge... [15:51] cjwatson: never mind [15:55] cjwatson: r=me. [15:56] adeuring: thanks. can you land it? I don't have access [15:56] cjwatson: sure [15:56] (it'll need to have UNRELEASED replaced with the appropriate series in debian/changelog, of course) [15:56] (if you'd like me to do that, tell me which series to use) [15:59] allenap: ta for the tracer advice [15:59] I guessed it might be pebkac [16:01] bigjools: That wasn't pebkac. It's hairy code in there; the stuff in checkwatches took a long time to get right. [16:02] allenap: that points to a bigger problem then [16:02] cjwatson: i think natty would appropriate [16:04] bigjools: Indeed. But I am not going down there until our feet start punching holes in the floorboards. [16:04] allenap: or fists in walls :) [16:05] Hehe :) [16:09] adeuring, bac: I've put a branch up for review, I'm leaving but would appreciate a review: https://code.launchpad.net/~danilo/launchpad/bug-690568/+merge/71394 [16:09] thanks :) [16:09] allenap: hah, it's timing out the txn now of course. [16:10] danilos: I'm quite close to EOD/EOW too ;) [16:10] * allenap experiences schadenfreude === adeuring changed the topic of #launchpad-dev to: Das Thema für #launchpad-dev ist: https://dev.launchpad.net/ | On call reviewer: bac | Critical bugs: 238 - 0:[#######=]:256 [16:36] how come I have to have direct team membership to have PPA access? [16:36] I'd think that being a member of a team that owned a team would give me access to the PPA of that team [16:36] team team team [16:39] mtaylor: that should work, what error are you getting? [16:39] allenap: yay, trace at last [16:39] bigjools: Signer has no upload rights to this PPA. [16:39] bigjools: Woohoo \o/ [16:39] mtaylor: can you confirm it's signed with the right key? [16:40] bigjools: to be specific - I am a member of the owning team, and I was also a direct member, and then we deactivated my direct membership - just in case that has something to do with it [16:40] bigjools: yes - when I reactivated my direct membership, it worked again [16:40] ok [16:40] you'd better file a bug then [16:41] bigjools: okie! [16:42] matsubara: I have got an OOPS file on dogfood, how do I turn it into a lovely web page that analyses repeated and long queries? [16:42] mtaylor: sorry man :( [16:43] bigjools, it should appear in the lp-oops.c.c. isn't that working? [16:44] matsubara: it's a dogfood oops, so I doubt that :) [16:44] it's supposed to work. what's the oops id? [16:44] Hi! So, I need to have a distribution renamed... apparently this is not doable through LP's admin interface... [16:46] bigjools, I think we need to ask the losas to sync dogfood oopses to devpad [16:49] matsubara: or can I just poke the tools on DF and run them there? [16:49] I only want it for a single oops [16:49] or is it not that easy? [16:49] I don't mind syncing them to devpad [16:51] SpamapS: it's not [17:04] German topic? [17:04] bigjools, not that easy. syncing would be easier and would set things up for the same in the future [17:05] matsubara: ok, I guess we need an RT [17:05]