ceramicmPackage was built successfully. Thanks for the help.08:45
FxIIIhi all08:52
FxIIII need to run the sync daemon using the command line08:53
FxIIIi started the syncdaemon --oauth but i get an error08:54
FxIIII get ubuntuone.platform.linux.dbus_interface.NoAccessToken:  Credentials Error  [...] UserCancelled [...] The user cancelled a prompt08:55
FxIIIany idea?08:55
FxIIImy network manager does not know the custom ppp connection in ppp0 may be a problem?09:02
ceramicmFxIII: Run seahorse. Do you see anything listed called "Ubuntu One"09:04
FxIIIceramicm: seahorse?09:06
FxIIIceramicm: where i can find it?09:06
ceramicmFxIII: It allows you to graphically browse keys stored in the GNOME keyring. In a terminal, type "seahorse".09:06
FxIIIceramicm: i dont have the X server active09:06
FxIIIthe problem is i cant access to the session bus because there is no DISPLAY variable set09:07
mandelfagan, ping09:09
=== gord_ is now known as gord
faganmandel: pong09:11
mandelfagan, morning, sorry I'm a little late, I had to do some errands09:13
mandelmainly get petrol to get to the other village to get popoer internet :P09:13
FxIIIhi mandel09:13
fagannp its only me here so no one noticed :)09:13
mandelFxIII, hello! did rye manage to get your u1 running without x11?09:13
mandelfagan, I think _Chipaca is here too ;)09:13
mandelfagan, shall we start with the test?09:14
faganOh forgot about him09:14
faganmandel: sure if shares are back up09:14
FxIIImandel: there is a problem on the device09:14
FxIIImandel: it has a custom internet connection that the network manager cant see09:14
mandelfagan, turns out that the issue was with the + the web ui does not handle that symbol in an email address well :)09:15
mandelfagan, whihc versions of windows do you have?09:15
faganmandel: ah ok09:15
faganI have 1 of everything09:15
mandelFxIII, oh :( but I guess we can work around it :)09:15
mandelFxIII, if we fake the event of network connect twisted will try to connect anyway and will try to do the job09:16
mandelFxIII, it involves either removing the network manager or my tellng you to edit the code, your choice :)09:16
mandelfagan, superb, lets start with xp, do you have the deps etc...09:17
faganmandel: nope lost my old VM09:17
FxIIImandel: i did not understood the second option ...09:17
faganmandel: want me to get grab them09:17
mandelfagan, would be nice yes :)09:17
faganOk cool will go do that09:18
mandelFxIII, I can send you a small patch to make syncdaemon believe that there is no network manager so that it always tries to connect09:18
mandelFxIII, and the OS should ensure that we can reach the outside world09:18
mandelFxIII, opensource for the win!09:18
faganmandel: well the connection bit is in SSO09:18
mandelfagan, no, sso does not use network manager AFAIK09:19
faganmandel: you would need to fix it there since he needs to sign in too09:19
faganmandel: its where the code is09:19
faganmandel: I had to fiddle with the code myself a while back09:19
faganbut my patch was bad09:19
mandelfagan, can you show me the code?09:19
mandelfagan, I dont think networkmanager is a dependency, if it is we can work around it09:20
faganmandel: its in /ubuntusso/networkstate09:20
mandelfagan, ok, let me look09:20
faganmandel: its a dbus thing09:20
faganit detects the network state there and sends back if its connected or not...etc09:21
FxIIImandel: good idea09:21
mandelFxIII, fagan let me take a very wuick look :)09:21
mandelfagan, FxIII does not need sso working he added the creds to the conf, right?09:21
faganmandel: just delete all of the tests and the file and have it only returning the network state online09:22
faganmandel: I think so09:22
mandelfagan, since he does have the creds the only one we have lie to is syncdaemon :)09:23
FxIIImandel: i got the cred using ubuntuone-sso-login.py by rye09:24
mandelFxIII, okis, so we only need the sync daemon running :)09:25
mandelFxIII, do you know how to apply a patch?09:25
FxIIIpatch diff?09:26
FxIIIprobably I have remember how to do09:27
FxIIIim ready mandel09:28
mandelFxIII, ok, let me make the changes and I'll paste you the patch :)09:29
mandelFxIII, if it works we should add a wishlist bug saying what is the problem, say that network manager is stupid and you will like to be able to tell syncdaemon to ignore it :)09:30
mandelmaybe an extra param would be just enough for this09:30
FxIIImandel: where i can find the developing documentation? I'm a Python developer09:31
FxIIIim not an ubuntu exper alas09:31
mandelFxIII, docs for u1?09:33
FxIIIok ty fagan09:34
mandelFxIII, try this: http://paste.ubuntu.com/664094/09:35
mandelFxIII, the idea is simple, just not check the network manager and do what sd does in the case that is not installed, that is tell the state machine we are connected!09:35
mandelFxIII, I have not tested but I think it should do the trick :)09:35
* mandel hates shares... they seem not to be getting the data09:37
mandelseriously, this windows thing is making be a bitter man...09:38
mandelFxIII, where are you located by the way?09:39
FxIIImandel: sorry located?09:39
mandelFxIII, where do you live? 'cause on september there is this: http://bit.ly/nRgoJQ and if you do python you might be interested :)09:41
FxIIIAh im in northen Italy now :D09:41
mandelstuard will be there and I'll do my best too (I'm a University of Manchester alumni :D)09:42
mandelFxIII, oh, nice! well, maybe we can convince them to do it in italy next time :)09:44
mandelFxIII, did the patch work?09:44
FxIIImandel: can you it whould be wonderfull :D09:45
FxIIImandel: no the patch failed09:45
FxIIIlet me se why09:45
mandelFxIII, please, maybe I did some stupid error... pastebin it so that I can take a look09:46
FxIII1 out of 1 hunk FAILED -- saving rejects to file dbus_interface.py.rej09:46
FxIIIi'm on /usr/lib/pymodules/python2.7/ubuntuone-client and i did patch < patchfile09:47
mandelFxIII, hmm maybe the problem is thatI did it from trunk and you have and older version :P09:50
mandelFxIII, can you open /usr/lib/pymodules/python2.7/ubuntuone-client/platfrom/linux/dbus_interface.py and do a search for the network manager bus call?09:51
mandelFxIII, or paste bin the file and I'll tell you which lines to delete :)09:51
FxIIImandel: what i have to look for?09:53
mandelFxIII, org.freedesktop.NetworkManager09:53
mandelFxIII, which will lead you to the call that asks dbus to get the network manager object09:54
mandelFxIII, there you will see that there is a try except, in the except we are focing the daemon to connect09:54
mandelFxIII, so what you want to do is remove the try and always call self.connection_state_changed(NM_STATE_CONNECTED_GLOBAL)09:54
mandelso that we do not care of the network manager :)09:55
FxIIImandel: ok09:56
mandelFxIII, if that does the trick i think we can write a nice patch so that we have an option to pass to the daemon to ignore the network manager09:58
mandelFxIII, and I/we'd love you if you propose the patch with some tests and the opts etc.. :)09:59
mandelFxIII, orcourse I'm more than happy to give you a hand with it :)09:59
FxIIIFailure: ubuntuone.platform.linux.dbus_interface.NoAccessToken: CredentialsNotFound10:02
mandelFxIII, hurray \Q/10:02
mandelFxIII, ok, that is easy, how did you pass the creds last time?10:02
FxIIIi give the creds...10:03
mandelFxIII, can I see the full trace?10:03
FxIIImand twice what i posted you10:04
mandelFxIII, ok, lets look in the logs, look in you xdg_cache10:05
mandelFxIII, it should be somwhere in your home10:05
mandelFxIII, ls -la ~ :P10:05
mandelthat ^ is just in case hehe10:06
FxIIInot found10:07
FxIIIi ran that form command line using dbus-launch10:07
FxIIII dont know if it matters10:07
ralsinagood morning!10:09
karnimorning ralsina10:09
mandelFxIII, yes I think it does, how did you use to laucnh it with rye?10:12
mandelactuall, rye are you here? we have a really cool idea for a small patch :P10:12
mandelralsina, buenos dias!10:12
ralsinabuen día mandel10:12
mandelralsina, I've taken a look at both of your branches and they are approved, I started with the shares tests, with the current trunk they will not work10:12
ralsinaboth? I think I had only one :-)10:13
mandelralsina, we need the shutil.move branch, yet is starting to look like a monster... is doing to much :(10:13
mandelralsina, hhaha true, I had a brain fuck because my email client added to links :P10:13
mandelralsina, that branch has gone from removing shutil.move from actianq to remove os.walk, shutil.rmtree and shutil.move for the full app10:14
mandelralsina, I'm making the changes, but I'd have preferred to have a diff bug for that10:14
mandelralsina, also, do you have the backlog from this morning?10:15
ralsinamandel: I do, let me read10:15
ryemandel, i am here, where's cool idea?10:15
mandelralsina, rye FxIII has problems because network manager is not ecognizing his network device and then sd does not work10:16
ryemandel, network-manager-related?10:16
ryemandel, if we brink netowkr-manager down it will work10:16
* rye has not had his tea yet, high error rate10:16
ralsinamandel: oh, that. We have had those before, and we had a fix, I think: don't install network-manager10:16
mandelrye, exactly, so I thouhg it would be nice to have an option to force to work around network manager and tell sd to connect directly10:17
mandelralsina, ^10:17
ralsinamandel: if you don't have NM installed/running it should do just that, IIRC10:17
ryemandel, well, if you stop network-manager then it will be pretty much the same, and in this case why would you need the network manager at all?10:17
mandelralsina, rye: I've ask FxIII to take a look and propose a patch (with our help) and file a bug as a wishlist10:17
ralsinamandel: the problem was having NM running and connect to the network some other way10:18
mandelrye, ralsina, so why do we even bother with network-manager?10:18
mandelI know the code does a try except and if network manager is down we force the connect10:18
ralsinamandel: because if it is running, we use it to detect if there is network10:18
mandellets make an option for that --force-connect for ubuntuone-syncdaemon for people with this issues10:18
mandelwhich could also work in windows easily10:19
mandelralsina, one question, when you do a os.rename with a non existing file, what do you get IOError or OSError?10:23
ralsinalet me check10:23
mandelralsina, with shutil.move you get IOError, yet I'm returning OSError10:23
mandelrye, can you give FxIII a hand with the creds issue he has?10:23
faganIts kinda funny that the main part of installing the dependencies is waiting for visual studio C++ to download10:23
ralsinamandel: a WindowsError10:24
* fagan takes a break while waiting10:24
mandelralsina, so OSError, is correct yet shutil returns IOError...10:24
mandelputo python!10:24
ryeFxIII, let's make dbus accessible to your shell (you're not going to run X server, right)?10:25
* rye was using this type of hack until the dev box crashed10:26
ryeFxIII, um... wait, what is actually the issue you are having, CredentialsError?10:26
gatoxralsina, your branch is not working for me, i tried that when i finished adding the qUncompressed10:43
ralsinagatox: what branch?10:44
gatoxralsina, https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/not-compressed/+merge/7129610:44
gatoxabout qUncompress10:44
gatoxi've tried that the first time10:44
ralsinawhat happens when you don't use qUncompress?10:44
ralsinagatox: ^10:45
gatoxralsina, the style is not applied10:46
ralsinagatox: and what's in data()?10:46
gatoxralsina, a lot bunch of bytes because in my case the data is compressed... maybe we can use QResource.isCompressed() and applied one or the other10:46
ralsinagatox, but why would it be compressed? That's what I don't get10:47
gatoxralsina, qt doc: A QResource that is representing a file will have data backing it, this data can possibly be compressed, in which case qUncompress() must be used to access the real data; this happens implicitly when accessed through a QFile.10:47
ralsinagatox: or, use -no-compress in pyrcc4 :-)10:47
ralsinagatox: since we are compressing with lzma anyway when shipping10:48
gatoxralsina, yes, let me tried if that works here10:49
ralsinagatox: cool, if it does, I'll add that to the setup.py and it's done10:49
ralsinaok, gotta send the boy to get educated! Be back in 71 minutes.10:50
gatoxralsina, -no-compress works just fine!10:53
* fagan needs a new keyboard :/11:10
faganJust let my keyboard fall from my table and its warped and I have to twist it to get it working11:11
faganmandel: I think I have everything11:25
faganmandel: what is it that im testing11:25
faganOh hes probably walking the monster11:28
mandelfagan, we have to test that ro shares work as expected and that a user cannot create a file in an ro share and get it to the server11:36
mandelalso modify etc..11:36
mandelfagan, monster midday walk has been delegated to my littel brother :P11:36
faganmandel: ah slavery :D11:37
mandelfagan, I call it training :P11:38
mandelfagan, so, do you have a dummy account I can make shres with?11:39
faganmandel: yeah11:39
faganmandel: slimshanyfluke@live.ie11:39
mandelfagan, cool, give me a sec while the stupid windows updates apply :(11:39
mandelwe are doomed: http://www.google.com/patents?id=26aJAAAAEBAJ11:41
faganwhat a terrible patent11:42
faganlove that US patent office sometimes11:42
* fagan needs a break 11:44
mandelfagan, I'm going to have to go home for lunch, shall we get to it in a couple of hours?11:46
faganmandel: sure after standup ill be good11:46
* fagan is just in need of supplies :D11:46
mandelfagan, well, I'll do my best to be on time... I need to fight with a windows update that seems to have broken my sd... or I broke it some other way :(11:50
faganmandel: oh weird :/11:50
faganIts cool I have something to do for josh in the meantime11:50
=== rodrigo__ is now known as rodrigo_
faganredirecting the wiki pages to the FAQ and tutorials11:51
mandelfagan, yeah... no idea WTF is going on..11:54
faganmandel: well if in doubt C411:55
* fagan hopes mandel gets the mythbusters reference 11:56
mandelyeah, hehe11:56
mandelI'm trying with trunk I'm getting handsake timeouts :(11:56
mandelok, fuck I hate windows12:01
mandelralsina, ping12:01
aquariusduanedesign, rye, did you know about http://www.omgubuntu.co.uk/2011/08/chalk-notes-ubuntu-sync-android/ ?12:01
faganaquarius: thats really nice :)12:08
* mandel is utterly confused...12:10
* duanedesign takes a five mite walk t o glar hi head, BRB12:11
mandelduanedesign, you need a dog :)12:11
aquariuskarni, it might be cool for you to have a chat with jamalta who writes chalk (see above link) about using new SSO stuff for a nicer login experience12:13
mandelfagan, have to tried ralsina installer?12:22
faganmandel: yep12:23
mandelfagan, did you manage to upload files?12:23
faganI didnt try but I can if you want12:23
mandelfagan, it works for me, but running it from trunk it does not... I wonder if we broke something at some point12:28
mandelI'm getting an unknown error :(12:28
faganmandel: Hmmmm thats weird whats in the traceback. I wonder if it was something just added that caused it12:29
mandelfagan, just that I cannot listen to localhost... smells like something that was added for the IPC... I'll talk with alecu maybe he knows...12:30
faganmandel: oh so at least you have some idea12:31
faganthats good12:31
mandelfagan, yeah, but just some idea...12:32
faganwell something ive learned from breaking things is knowing ish whats wrong is the start and after that its just debugging12:33
mandelhehehe but debugging that code is hard... is mostly black magic :P12:33
faganmandel: hehe well I just put lots of prints where I think its going wrong to say what the variables are and whats going on and it works ok to find out a lot of info about whats going on12:34
faganIm sure someone who is a better programmer wouldnt go do all that though :D12:34
mandelfagan, yeah, but in thie case there is twisted, spread.pb decorators.. is a mess12:34
faganmandel: ah well ive never had to figure out anything other than how twisted works so I wouldnt know about messes thankfully12:35
gatoxralsina, mandel -> small branch: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/header-wordwrap/+merge/71349 :D12:36
mandelfagan, it is fun to do, yet hard :)12:38
nessitabuenos días!12:38
fagannessita: hello nessita12:38
faganlol I double up on the nick just to be sure you know that hello was just for you :D12:39
mandelnessita, buenas!12:39
mandelnessita, got good news, RO shares as in truck wont create the files in the server side :)12:39
mandelnessita, I'm going to test what does the access-can-write branch adds and if it is worth it12:40
nessitamandel: before that12:40
nessitamandel: what happen client side with the ro shares?12:40
nessitamandel: I would like to see the log of a run modifying a share RO12:40
mandelnessita, the file was created in the fs, but was not updated to the server12:40
mandelnessita, and Upload object s created but I never see the file in the web ui12:41
nessitamandel: can I see the log? what about removing a file?12:41
mandelnessita, sure, let me paste them12:41
mandelnessita, there is just one thing I'm having problems with and is the IPC activation, I keep getting: http://paste.ubuntu.com/664172/12:42
mandelnessita, and I've checked and double checked that I have a single instance of the sd12:42
nessitamandel: let's go step by step12:44
nessitamandel: let's finish talking about shares12:44
nessitamandel: so, can I see the logs when you modifed RO shares?12:44
mandelnessita, yes, I generating clean ones right now12:45
nessitaah, ok12:45
nessitamandel: make sure to remove a file/dir inside a ro share :-)12:45
mandelyes :)12:46
gatoxnessita, small another: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/header-wordwrap/+merge/7134912:47
nessitagatox: sure!12:47
gatoxnessita, and it has even more tests than line of codes12:48
nessitagatox: that's what I'm seeing! big APPLAUSE for you12:49
mandelnessita, waiting for changes to reach the server and will pates the logs12:50
mandelnessita, there are exceptions due to shutil because I'm using the frozen .exe, see my issue in the email I sent12:50
mandelnessita, here: http://paste.ubuntu.com/664228/12:54
mandelnessita, the thing is, it works, yet look at the retry12:55
mandelnessita, look at the bottom12:55
nessitamandel: at the bottom there are events in the RW share... as far as I see12:58
nessitamandel: what line in the paste?12:58
nessitaalecu: ping12:59
alecunessita, pong12:59
nessitaalecu: good morning! so, I'm looking at mandel s log, and I see several13:00
nessita2011-08-12 14:48:45,019 - ubuntuone.SyncDaemon.Pb - DEBUG - No signal handler for 'on_request_queue_added' in <twisted.spread.pb.RemoteReference instance at 0x0370DF08>13:00
nessitaI was wondering if the status aggregator is involved in this13:00
nessita(I know you made this not to fail)13:00
mandelnessita, I dont like that the sd will do a retry when it fails to create the folder in a rw13:00
nessitamandel: but is ok, RW == read write13:00
nessitaI mean, it has to retry13:01
faganralsina, dobey standup :)13:01
gatoxnessita, the changes about run-tests has been submitted to my branch13:01
* fagan forgot alecu 13:01
ralsinano notes yet13:02
mandelnessita, updated log: http://paste.ubuntu.com/664231/13:02
faganmandel: you already said me :)13:02
fagan(just making sure im sure)13:02
nessitadobey: standup?13:02
faganill go and he can catch up13:02
nessitafagan: go!13:02
fagan* resetup XP dev env13:02
fagan* redirections for josh13:02
fagan* help mandel13:02
fagan* Na but my keyboard is on its last legs ordering a new one later today13:02
fagannessita: go13:02
nessitaDONE: tons of reviews and meetings, started with bug #82481513:02
nessitaTODO: land aforementioned branch, start working on branch to send platform details to the server13:02
nessitaBLOCKED: nopes13:02
nessitaNEXT: mandel13:02
ubot4Launchpad bug 824815 in ubuntu-sso-client "The url signing should support passing query params (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/82481513:02
mandelDONE: updated shutil.move to change all uses of shutil.rmtree and os.walk. Started testing sd and shares. Found issues when running the code form trunk and send an email about it.13:03
mandelTODO: look at the issue I have to run the code from trunk and other branches. Test shares with the set_dir_readonly implemented.13:03
mandelBLOCKED: no13:03
mandelCOMMENTS: wont be here next week. Got holidays \Q/13:03
mandelgatox: go go go13:03
gatoxFixing Title and Subtitle bug in SSO Client. Adding Tests for Header in SSO Client. run-tests in sso client fixed to execute UI tests.13:03
gatoxKeep working on Windows Installer UI bugs.13:03
gatoxalecu, go13:03
mandelnessita, looks like the lof rotated, I'll get you a nicer version in a min13:03
alecuDONE: reviews, lots of calls, discussed #824003 with nessita and facundo, fixed bug #824817, worked on bug #82481913:03
alecuTODO: finish big branch for bug #82481913:03
alecuBLOCKED: no13:03
alecuNEXT: mandel13:03
ubot4Launchpad bug 824817 in ubuntuone-client "Errors in the watch threads are not handled (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/82481713:03
nessitamandel: ok, be sure you play with a RO share13:03
ubot4Launchpad bug 824819 in ubuntuone-client "SD and tests need to wait until a watch is removed (affects: 1) (heat: 6)" [High,New] https://launchpad.net/bugs/82481913:03
fagannext ralsina mandel already went13:03
ralsinaDONE: took kid to the doctor, windows call, reviews, found a bit of a problem *after* merging Diego's branch. TODO: fix that bug (qUncompress causes segfault), implement uninstaller as discussed with lisette, reviews, etc.13:03
ralsinaBLOCKED: no13:04
mandelnessita, I did the changes to ro too.. weird13:04
ralsinadobey, right?13:04
dobeyλ DONE: gnome/installer releases/uploads13:04
dobeyλ TODO: hackday (tarmac), administrata13:04
dobeyλ BLCK: None.13:04
mandelI need to run home, I'm really later for lunch13:04
nessitanopes, other than I miss freaky friday13:04
nessitamandel: go13:04
mandelnessita, can we have mumble at 4 so I have a decent internet connection?13:04
nessitamandel: sure13:05
gatoxi need to leave for a while... i have to take my picture for the visa :P13:05
mandelthx! cu then!13:05
faganAnyone got any keyboard suggestions?13:05
nessitaalecu, ralsina, Chipaca, gatox: mumble in 55 minutes13:05
* fagan is looking to invest in one.13:05
nessitagatox: ack13:05
* nessita -> building mate time13:05
ralsinanessita: ok13:05
ralsinanessita: happy carving! ;-)13:05
ralsinafagan: I suggest a model-m13:05
faganralsina: pro :D13:06
ralsinafagan: the superloud click will keep you company13:06
ralsinaplus, you can use it to kill rodents up to 15kg without ill side effects13:06
faganI was looking into steelseries one since the keys are really soft and its pretty sturdy13:06
alecunessita, it's ok for some lines like the one you pasted above that to show up on the DEBUG log; they used to be a WARN followed by a stacktrace *each*13:06
faganralsina: awesome haha13:06
ralsinaworks as a cricket bat or looter deterrent, as well13:07
faganralsina: im sure it works as a keyboard too13:07
ralsinafagan: oh, sure, that too13:07
ralsinafagan: I suggest the modified one with the all-black keys (nothing written in them)13:07
faganand also im sure I can use it as a wedge for lifting stuff13:07
faganralsina: I actually think ive seen that :)13:08
ralsinagatox: pushed not-compressed with the -no-compress flag, could you test it?13:08
gatoxralsina, ok13:09
alecunessita, also, it looks like we are using a different ipc object with a new tcp connection per control panel page (or even more!) so that's why there are so many lines, and that's something we should fix.13:10
alecuralsina, I need to take Amelia to kinder, but it's raining around here, so it'll take a while to find a cab.13:11
alecuralsina, it was raining "teresos de punta" some 30 minutes ago, so that's why we didn't go earlier.13:11
alecuralsina, so, I'll probably be late for the meeting. What time are we having it?13:12
ralsinaalecu: same thing here, it took me 45 minutes to go 4 blocks :-(13:12
nessitaalecu: I read that from your email, but the control panel does not use the queue_added/removed thingy13:12
nessitaalecu: in 48 minutes13:12
alecunessita, great, thanks.13:12
ralsinanessita: when sd has an event (say, a share added), it sends that signal over every connection. If u1cp opened many, it will get that many times13:13
nessitaralsina: right, but control panel never "connects" to queue_added/queue_removed13:13
nessitaralsina: that's why I see those in the log and I'm not that sure is the control panel13:13
alecunessita, the way it works now, it connects to "every signal"13:13
nessitaralsina, alecu: +1 to also fix the control panel connection13:13
ralsinanessita: it receives it anyway. I saw them in the control panel log13:13
alecunessita, and then sd tries to send each signal13:13
nessitaok, understood13:14
alecunessita, and if there's no handler for that signal, it's logged as debug13:14
faganjoshuahoover: hey, you are missing an image on https://one.ubuntu.com/help/tutorial/install-and-setup-bookmarks-sync/13:14
faganoh its on all the tutorials13:14
* alecu rushes. ttyl13:14
gatoxralsina, +1 Approved (now i leave :P brb)13:15
ralsinagatox: +1 from me too, merging!13:16
nessitaralsina: can I have a review please?13:18
ralsinanessita: sure!13:18
ralsinanessita: I was having problems with signed URLs13:18
nessitaralsina: I'm still reviwing gatox's branch13:18
ralsinanessita: oops13:19
ralsinanessita: claim the reviews, please13:19
nessitaralsina: I claimed the review!13:19
nessitaNatalia Bidart                                                                 45 minutes ago                                           Pending                    [Review]13:19
ralsinamaybe I didn't reload it :-(13:19
nessitamaybe :-)13:19
nessitaan actually that branch will go pass tarmac13:20
* ralsina hates Visual C++ runtime with the heat of 1000 suns13:20
nessitawill not go*13:20
ralsinaso, no harm done, except to dobey's server ;-)13:20
faganralsina: you can use gcc13:20
ralsinafagan: no, I can't13:20
nessitaralsina: what can we do to have tarmac running QT tests when landing branches ?13:20
faganralsina: its hard to install but possible on windows13:20
ralsinafagan: trust me I can't13:21
dobeyralsina: no, tarmac won't do anything if there are Pending reviews, expect to complain on the proposal13:21
faganralsina: ah ok ill take your word for it :D13:21
ralsinanessita: well... if pyqt is installed and we use xvfb, I don't see  why not13:21
nessitaralsina: qtrecator13:21
dobeynessita: well qtreactor needs to be productized/packaged13:21
ralsinanessita: that too13:21
nessitadobey: how can we have that?13:21
ralsinaplus, sso-client-qt is broken on linux (needs refactoring)13:22
nessitadobey: and is there any chance you install qtreactor by hand until we can build  package for it?13:22
nessitaralsina: test for QT UI pass in linux...13:23
nessitaralsina: as long as you have the qtreactor in the PYTHONPATH13:23
ralsinanessita: then just that13:23
nessitaralsina, dobey: so I was hoping we could have tarmac landing QT branches soon... since our releases depend on that code, it will be great to know nothing gets into trunk if it does not pass the tests13:24
dobeyi'd rather avoid having things that aren't packages.13:26
nessitadobey: I know, I'm asking for an exception, or ideas about how to solve this soon13:27
nessitadobey: do you know if is there a particular issue to package qtreactor?13:28
nessitaor is just doable but no one had the time?13:28
ralsinanessita: have you actually tested signing urls lately? And has it worked?13:29
dobeythe only real issues i know of are that it's not productized (has no setup.py), and nobody has been scheduled to do it13:30
nessitaralsina: yes, I tested that branch yesterday. You can try it too: in linux, run the service with: DEBUG=True PYTHONPATH=. ./bin/ubuntu-sso-login, open the control panel, remove the current device, and authenticate again13:30
ralsinanessita: ok, thanks13:31
dobeyand i have no idea whether it's actually maintained upstream or not13:31
dobeywhich reminds me13:31
dobeywe need to discuss pyxdg13:31
nessitadobey: so, if it's not maintained upstream, we can't package it?13:31
dobeybecause it isn't really being maintained upstream :(13:31
dobeynessita: well if it's not maintained upstream, we need to make a plan to either fork and maintain it, or stop using it, i think.13:31
nessitadobey: guh13:32
joshuahooverfagan: ah, thanks, i'll fix that13:35
dobeynessita: indeed13:35
dobeynessita: qt4reactor at least seems to have had a commit on 2011-06-0413:36
faganjoshuahoover: np ill send back anything else I spot while im around13:36
joshuahooverfagan: thanks!13:36
dobeyoh right, forgot to list cp release on standup13:39
=== m_conley_away is now known as m_conley_
failureHello, i need help with all my phones gone, i installed a new client and it removed all picures from the ubuntu one cloud, is there possible to restore those ?13:51
failuremy account pb@osix.eu13:51
fagankarni: ^13:51
failureanyone know is its possible ? or is all my picures lost ?13:52
failurephones = picures btw :P13:52
faganOh then this is a job for duanedesign id presume13:53
failurefagan: ?13:53
ralsinaI can do a setup.py for qt4reactor, should be fairly trivial13:53
alecufailure, there is a temporary backup for all accidentally deleted files, so they will likely be restored13:53
alecufailure, let's ping rye and duanedesign to see if any of them can help13:54
alecufailure, are the pictures gone from the ubuntuone web too?13:55
failurealecu: yes13:55
dobeyralsina: yeah i don't think it's hard, but i don't know how responsive upstream is13:55
ralsinadobey: I will do it and submit it on my sandwich time today, see what happens.13:55
failurealecu: i did a fresh install, but i did have the some hostname as the old and some home, and connected to ubuntu one, then it sync somehow my new picures that was empty13:55
failurealecu: from 17GB down to 1.7GB13:56
failurealecu: and now i see some conflics aswell13:56
failurealecu: i think something is messed up...13:56
alecufailure, that's unfortunate, but I'm sure we'll find a way to recover the files13:56
failurealecu: are you able to help me or what to do ?13:57
alecuduanedesign, do you know about the procedure to recover files? can you help ^^?13:57
failurealecu: a restore from yesterday will work also, if you have backups13:57
failureits 10 years of my life, thats why i had it backuped at ubuntuone :P13:58
dobeyralsina: might be a good idea to move stuff around in that tree too13:59
karnifagan: failure: I'm reading13:59
failurekarni: ?13:59
ryekarni, duanedesign, me is reading too14:00
karniI'm sorry, I don't understand.14:00
failurei want to restore my ~/Pictures14:01
karni"i did a fresh install, but i did have the some hostname as the old and some home, and connected to ubuntu one, then it sync somehow my new picures that was empty"14:01
fagankarni: not your prob failure said phone on new client and I was like karni country14:01
ryefailure, it was in your ~/Pictures UDF, right?14:01
karnifailure: Could you try to rephrase this, please?14:01
ryefacundobatista, was it in "~/Pictures - $something" or in "~/Pictures" ?14:02
failurekarni: i lost my ~/Picures can you please restore it?14:02
karnifailure: "failure said phone on new client" wtf? :D14:02
ryefailure, ^14:02
karnifailure: sorry, that was to fagan :)14:02
ryefacundobatista, sorry, tab completion failed14:02
karnifagan: rephrase that, please xD ↑14:02
facundobatistarye, no worry14:02
fagankarni: failure said new client and phone but meant pictures sorry for the ping14:02
failurekarni: please restore my entire ~/Picures14:02
karnioh right, failure is a nick. sorry fagan14:02
ryefailure, duanedesign, karni, lets synchronize our conversation14:03
karnirye: Sorry.14:03
ryefailure, could you please tell the details of how the files were lost?14:03
nessitaralsina: mumble?14:03
ralsinanessita: going14:03
nessitaalecu: can I have a trivial review https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/run-qt/+merge/71362 ?14:03
failurerye: i got a new pc, installed ubuntu 11.04. with the some hostname as my old, copy /home/patbat/ to the new PC. then i started ubuntu one, to sync the rest, then i synced my ~/Pictures (i guess) from the new PC that had nothing in ~/Pictures14:04
ryefailure, understood14:05
failurerye: i have now removed the access to all my clients without the new one.14:05
failurerye: thats endlessdream14:05
ryefailure, before we proceed, could you please archive the contents of ~/.cache/ubuntuone/log/ from your new machine and send them to ubuntuone-support@canonical.com ? I am looking into the recovery now14:06
failuretar zcvf onelogs.tar.gz ~/.cache/ubuntuone/log/14:07
failuresending it now from pb@osix.eu14:07
failurethank you rye14:08
failurei hope we can restore this14:09
failuremail delivered14:09
ryeverterok, ^ we really need some sort of tying the metadata to the machine, otherwise overwriting metadata is going to cause this ^14:10
failurerye: how is it going ? :)14:15
karnirye: Before that, maybe we should add it to the FAQ "If you're moving your U1 files out of a synced machine, disconnect it first. Also, never move $metadata_dir along with your files."14:21
ryekarni, or move metadata dir along with ALL the folders. OTOH the inodes will change, but the hash will be the same so no reupload14:23
karnirye: It's not my area of expertise :) But when I had the same problem, facundobatista told me to remove metadata dir, and let U1 recalculate hashes from scatch and do it's thing. And it helped.14:24
karnirye: Although it wasn't exactly the same case.. I changed my username and renamed by home dir ;D14:24
karni(Of course, it was more than mv /home/foo /home/bar, as I had encrypted home, but it's another story.)14:25
ryekarni, yes, that is the best way, except that it will redownload all the files, but safe14:26
verterokrye: overwriting metadata is always a bad thing14:26
verterokwhat's "this"? :)14:26
karnirye: It wouldn't redownload stuff, why would it. It would only compare current file hashes with metadata from the server. Nothing to redownload.14:27
karniverterok: Hiya :) !14:27
ryekarni, ah, true14:27
alecunessita, +1 on the run-qt branch14:28
* nessita dances14:29
karnihi nessita :)14:30
nessitahi karni!14:31
gatoxi'm back...14:53
gatoxhate errands14:53
=== m_conley_ is now known as m_conley_away
ralsinaOk, solved the signed URL problem. Doesn't work in the embedded webkit, works just fine on chrome14:59
ralsinanessita: smallest branch ever! This is code we are probably going to remove as we mentioned today, but just in case we don't....15:10
nessitaralsina: I can't see the diff in LP yet, but you should know I WANT TESTS :-D15:11
ralsinanessita: the code does the exact same thing as before, I just changed a constant :-)15:11
nessitaralsina: which you should be tetsing when asserting over the params value, right? ah? right?15:12
ralsinaand the URL is encrypted in the output :-D15:12
nessitaralsina: I would expect a test that mocks oauth.OAuthRequest.from_consumer_and_token and assert over the params :-)15:13
ralsinaOk, no it's not. Sure, adding test ;-)15:13
mandelnessita, alecu: merged with trunk and fixed conflicts: https://code.launchpad.net/~mandel/ubuntuone-client/dont-use-shutil-move/+merge/7059515:17
nessitamandel: looking!15:17
ralsinanessita: pushed with the test15:19
nessitamandel: dude, in bin/ubuntuone-syncdaemon shutil comes before sys and signal imports15:20
nessitamandel: please remember alphabetical order for all the imports :-)15:21
nessitamandel: no, wait15:21
nessitamandel: I looked the diff backwards!!!15:21
nessitamandel: it used to be in the wrong order, but you removed it. Ignore my last comment!15:22
nessitamandel: I double checked this: when you merged trunk in, you duplicated this import: from ubuntuone.syncdaemon import local_rescan15:23
* mandel looks15:24
nessitamandel: and you added an empty line here:15:24
nessita    stat_path,15:24
mandelnessita, sorted, anything else?15:25
nessitamandel: you changed this, it was not in the diff yesterday:15:26
nessitainside walk:15:26
nessita        yield _unicode_to_bytes(dirpath.replace(LONG_PATH_PREFIX, '')),\15:26
nessita              fixed_dirnames, fixed_filenames15:26
nessitawhy the dirpath.replace(LONG_PATH_PREFIX, '')? does walk adds that?15:27
mandelnessita, yes, os.walk will return \\?\\rootpath which is a problem when it gets out to sd15:27
nessitamandel: you sure? sounds weird15:28
mandelnessita, now that you mention, shall I add a test?15:28
nessitamandel: let me confirm one second IRL15:29
mandelnessita, sure :D15:30
mandelnessita, http://paste.ubuntu.com/664340/15:30
mandelat least in my machine15:30
nessitamandel: yes, in mine too. Yes, add tests (note the 's') for walk, and please define a new variable for _unicode_to_bytes(dirpath.replace(LONG_PATH_PREFIX, '')) just like you did with the other fixed_*15:31
mandelnessita, makes sense, on it!15:32
* mandel there is nothing more annoyign that an 80 chars line in python...15:33
=== NickL_ is now known as NickL
=== m_conley_away is now known as m_conley_
nessitaralsina: I added an improvement to https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/sign-ui-with-query-params/+merge/71352 so we can apply .format to the url15:57
* ralsina checks15:57
nessitaralsina: we need that so we can use a ping url where the email goes "in between" the url15:57
nessitawhich will be the case now in u1client15:57
ralsinanessita: makes sense15:58
ralsinanessita: I will re-run tests and +1 after that15:59
nessitaralsina: thanks!15:59
dobeyalright lunch time for sure16:01
ralsinagatox: ping16:29
ralsinaOk, off to a short lunch break16:52
gatoxralsina, pong!! finally back from the bank17:03
nessitagatox: were you able to pay?17:12
gatoxnessita, yes!! it is everything ready now! :D17:12
nessitalunchtime for me now17:16
mandelnessita, cachis!17:17
mandelnessita, tests are runing atm will ping you when done17:17
mandelnessita, alecu ping?17:33
nessitamandel: pong17:40
mandelnessita, hola!17:42
nessitahi there17:42
nessitamandel: what can I do for you?17:42
mandelnessita, tests added for walk, both in tests\platform\test_os_hlper and tests\pltform\windows17:42
nessitamandel: why do you need custom tests in windows?17:42
mandelnessita, so a re-re-re-re-re-re-re-review would be welcome :)17:42
mandelnessita, no, I used the same idea you used for the illegal paths ones17:43
nessitaah, let's see17:43
mandelnessita, is the WalkTests one, tests the walk in both directions17:44
mandelnessita, by the way I have noticed something, the self.rmtree from testcase does no seem to work with illegal paths on windows, should we use the on in platform?17:46
nessitamandel: we might, but in another branch17:46
mandelnessita, you read my mind :)17:46
mandelnessita, this one is getting too big17:46
nessitamandel: typo:17:47
nessita        # names to bse used by the paths17:47
* mandel has to get this in before holidays no matter what17:49
nessitamandel: instead of         self.addCleanup(self._clean_paths) please use:17:49
nessita        self.addCleanup(remove_tree, self.basedir)17:49
mandelnessita, sure17:50
mandelnessita, pushing that change already17:52
mandelnessita, cool17:55
nessitamandel: what are you using self.valid_file_path_builder for, if self.walk_path has not invalid chars?17:57
mandelnessita, so that it has no utf8 chars... shall I rename that?17:58
nessitamandel: also, it seems to me that passing  _unicode_to_bytes is not the proper solution for me...17:58
nessitasince that is hidden and should not be needed ourside os_helper17:58
nessitayou may need to pass get_windows_valid_path instead?17:59
mandelnessita, well, it should not be get_windows_valid_path, walk should return a valid path for sd, but walk does not return abs paths18:00
alecumandel, pong18:00
mandelso get_syncdaemon_valid path does not work18:01
mandelalecu, can you review https://code.launchpad.net/~mandel/ubuntuone-client/dont-use-shutil-move/+merge/70595 before I go for a week :)18:01
alecumandel, sure!18:01
mandelalecu, gracias!18:01
nessitamandel: this smells to me, I will review this again18:03
mandelnessita, wait, does get_syncdaemon_valid path return an abspath?18:04
mandelnessita, 'cause if ti does not, then that is the method to use18:04
nessitamandel: you're applying self.valid_file_path_builder to self.walk_path only, and walk_path is absolute18:04
mandelnessita, hm...18:05
* mandel looks18:05
nessitaalso, this is terrible to read:18:05
nessita        flipped = all[0][1][0] != self.sub1_name18:05
nessita1 + flipped18:05
nessitayou're summing up a boolean with an int. I know it *works*, but is very confusing18:05
mandelnessita, what would you prefeR?18:06
mandelups, capital R :P18:06
nessitamandel: either don't have 2 subdirs, or when walking the subdir, assert that the item is either sub1 or sub2, and then assert over the one that was returned18:07
nessitamandel: if you're eod'd, I will recommend leaving this as is18:07
nessitamandel: I can take it over on Monday18:07
mandelnessita, give me a couple of mins18:08
mandelnessita, the best thing to do is to have both subdirs so that the tests are more real...18:08
nessitamandel: honestly, the tests are very hard to understand, at least for me18:09
dobeynessita, ralsina: what's the word on control-panel status in trunk? are there branchse pending landing now, or can i make a release?18:09
nessitamandel: let's see what alecu thinks, I may be week-tired18:09
nessitadobey: you can make a release18:09
nessitadobey: there are no queued branches18:09
ralsinadobey: what she said!18:10
nessitathat's what I said! (?)18:10
mandelnessita, I can make flipped a more cleaner thing by explaining what to do and not doing a bool + int18:12
dobeyok thanks18:12
dobeyralsina: A for effort, F for execution. :)18:12
ralsinadobey: a+ for being literally true ;-)18:13
dobeynah, my life is a metaphor18:14
nessitamandel: what about the second option I gave you?18:14
nessitamandel: assert the second "child" is either sub 1 or sub 2, and then, add a guard to check each one depending which one is first18:14
mandelnessita, yeah I was thinking in how to do something similar :)18:18
mandelnessita, let me see if I get something nice there18:18
alecunessita, mandel: I don't like the "flipped" stuff on the test either18:18
alecumandel, what about storing a set() of the elements, and comparing it with another set?18:19
nessitaalecu: good thinking!18:19
alecuwe must think inside the box!18:19
nessitagatox: ping18:20
alecumandel, I mean, a set at each directory level18:20
gatoxnessita, pong..... just the person i need! jeje18:20
gatoxnessita, i was reading your comments in my branch18:20
nessitagatox: can you please merge trunk in https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/header-wordwrap/+merge/71349 ? you will have a conflict in run-tests, please use the version from trunk18:20
nessitagatox: right, thing is that tarmac does not have the qtreactor, so we can't land that (I did not reakize that when you asked)18:21
mandelalecu, nessita Its really too late for me, can you take over this and fix the test as you wish, we really should get this landed asap18:21
nessitagatox: I improved the run-tests so we can run both suites:18:21
nessitagatox: ./run-tests and ./run-tests -qt18:21
gatoxnessita, ok, but i have to revert just run-tests..... or delete the test too?18:21
mandelnessita, alecu or give me an hour to go home and walk the dog :)18:21
nessitamandel: yes, I will fix this, but very likely next week18:21
nessitagatox: which test?18:22
gatoxnessita, ^18:22
nessitamandel: I'm leaving soon to university, so no worries, I'll take over18:22
alecumandel, if it's late, then you should eow! btw: enjoy the vacations!!!18:22
nessitagatox: why would you remove that?18:22
dobeythere are 4 revisions of control-panel since last release. and only half of them have linked bugs… but those bugs are filed against ubuntuone-client18:22
mandelalecu, well, si 8:22 pm :P18:22
nessitamandel: bye! have a great week!18:22
mandelalecu, nessita, I go now, but I might get something done later this night18:22
gatoxnessita, i missunderstood...18:22
* ralsina kicks mandel off channel18:23
dobeyoh no, one is ubuntuone-client, and one is ubuntuone-windows-installer18:23
mandelnessita, alecu, gatox, dobey, ralsina : have fun!!!!!18:23
gatoxmandel, byeeeeeee18:23
mandelralsina, try the access-can-write branch please :)18:23
ralsinamandel: try it how?18:23
* mandel holidays \o/18:23
ralsinaoh yes IRL18:23
mandelralsina, IRL :)18:23
nessitamandel: why you keep insisting on that branch? :-)18:23
mandelnessita, because is my baby :)18:24
mandelalso, because I think it works hehehe18:24
dobeymaybe i should make tarmac validate linked bugs18:25
dobeyoh right, holidays18:25
mandelom, I'm off adios :P18:25
* dobey submits some holiday request :)18:30
gatoxnessita, changes submitted in my branch18:30
nessitagatox: great18:30
dobeybut none of the changes since last release are related to the LOGFOLDER error :(18:31
nessitadobey: that was fixed by gatox during the sprint as soon as we broke it, and there was no bug for that since we were updating all project at the same time18:32
dobeynessita: right, but i'm pretty sure that was before the last release i made?18:33
nessitadobey: when was the last release you made? :-)18:33
dobeyah no18:33
dobeysomeone didn't mention it in the commit message :-/18:34
nessitagatox: approved and globally approved18:36
nessitaalecu: when you have some slot, would you please review https://code.launchpad.net/~nataliabidart/ubuntu-sso-client/sign-ui-with-query-params/+merge/71352 ?18:36
gatoxnessita, awesome!!!!!!18:37
nessitaralsina: missing slash approved and globally approved18:37
ralsinanessita: cool, thanks18:37
nessitaok, I will be leaving very soon. I will be working after university, ie after 6pm ART18:38
alecunessita, I've added a few more comments to the latest mandel branch18:46
nessitaalecu: great, I will grab that on MOnday, I need all my lights to be 100%18:46
dobeybrb, meh18:47
nessitaok I'm gone18:50
nessitabye all! see ya later18:51
dobeybzr: ERROR: These branches have diverged.  See "bzr help diverged-branches" for more information.18:51
dobey"no there aren't any branches in the queue. here have a branch."18:51
ralsinadobey: you mean missing_slash? It's unused by control panel, really18:52
dobeyralsina: it's not unused, it's in the tree. which means it's a new revision. which means it caused a diverge of the branch from the commit i just made to change the version number :)18:53
ralsinaoops, sorry!18:53
* ralsina points at nessita, sice she's not here18:54
dobeynow i have to make another tarball18:54
dobeyif the courts just struck down the "all americans must carry health insurance" thing, i wonder if that sets a precident that states requiring car insurance could be unconstitutional18:58
dobeyi guess that would be too logical though18:59
ralsinadobey: car insurance is meant mostly for the other cars you hit, isn't it? At least that's the part that's mandatory here19:00
dobeyralsina: liability is required yes. but then that would set an example that to smoke you must carry liability insurance, since you smoking, could cause harm to others. or drinking. or being alive (or even dead, since your death doesn't mean all the microbes in/on you are also dead)19:02
dobeyof course, you don't need to have liability insurance to buy a gun, either19:03
ralsinadobey, and indeed people will sue you if they believe your second-hand smoke hurts them. The thing is cars hurt enough people that there was a need for a "streamlined" "automatic" damage recovery system19:04
dobeyand yet, we still rely on oil.19:04
dobeyoh the dear great dismal swamp, spreading your ash all upon the world19:06
dobeywonder if i'll be able to get over there this weekend19:06
ralsinaoff to pick the kid from school, should be back quickish unless I am washed away by a flood or something19:15
gatoxEOD for me... i'll send a branch with some UI improves that i've been working today in the weekend because i'm not be available on monday morning, i have to go to the embassy for the VISA19:27
gatoxi'm not going to* (something was missing :P)19:28
gatoxralsina, ^19:28
dobeywon't be :P19:29
ralsinagatox: so, not coming? ok!19:47
gatoxralsina, what? yes... after the embassy19:49
* ralsina is confused. "I'm not going to" what?19:50
gatoxbut... i want to submit some branches before to have them reviewed and don't waste that time19:50
gatoxralsina, ahhhhhhhh19:50
ralsinaoh, not going to be available!19:50
ralsinaok, got it now :-)19:50
gatoxralsina, yes...19:50
alecuralsina, I'm leaving early today: we got family Smurf day.20:02
ralsinaalecu: one line review: "I've seen worse movies featuring blue people in the last three years!"20:02
alecuralsina, I'm not exactly *thrilled* about it either.20:04
alecuwell, eow for me.20:04
alecusee you guys on monday!20:04
ralsinaSo I am now at that point in the week where I still have one hour left to wrk but if I do anything, noone can review it.20:04
ralsinaSo let's merge things without reviews while noone's looking!20:04
gatoxralsina, i can review some branches later if you want, i've to go to the gym in a while... but then i'll be free and at the computer :P20:27
ralsinagatox: cool, I may have two or three small branches20:28
gatoxralsina, doing other stuff... but anyway20:28
ralsinagatox: STOP WORKING ;-)20:28
gatoxralsina, awesome, give me the ilnks20:28
gatoxralsina, por eso aclare20:28
gatox_sorry... wrong place to paste :P20:50
dobeyalright all, have a good weekend!21:09
nhainesdobey: have fun  :)21:12
nessitahello again!21:16
=== m_conley_ is now known as m_conley_away
ralsinanessita, could I get a quick review for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/start-with-overlay/+merge/71422 ?21:29
nessitaralsina: sure21:29
ralsinanessita: it's a total blocker when you start the wizard without credentials :-(21:29
nessitaralsina: how long does it take for sso to respond?21:30
ralsinanessita: usually, less than a second21:30
ralsinabut I need to block the UI because if the user clicks "next" quick he will get the "sign in" page even with credentials21:31
nessitaralsina: on error, you should not take the user to signin...21:31
nessitaralsina: you should take the user to signin only when the result is {}21:31
ralsinanessita: so what do I do in error?21:31
nessitaralsina: you should popup the "standard" error handler. Two things: 1- I think we really need tests for this, we want to make sure this behavior is not broken with future changes21:32
nessita2- Maybe is best to swicth to yielding over the find_credentials to improve the code readability?21:33
ralsinanessita: there are tests about the overlay being shown/removed, and there are tests about what the "next" page is with/without credentials21:33
nessitaralsina: so, you're adding code that was not there before, that means that flow is not tested21:33
nessitathat *particular* flow is not tested21:34
nessitaralsina: so, there should be one test for the overlay hidding in diffline  3121:34
nessitaanother test  for error_cb21:34
nessitasorry, creds_eb21:34
nessitaanother test that asserts that the overlay is hidden in diffline 5421:35
ralsinanessita: the hidden was only moved, so it's tested21:35
nessitaralsina: then you should test is hidden at he right time, for some reason you're moving it, no?21:36
nessitaralsina: or is it the same?21:36
ralsinanessita: it was tested that it was hidden before showing the first page21:36
ralsinasince the test have a faked credential, it's still the case21:36
nessitaralsina: but don't you need to assert you're hiding it on error too?21:37
ralsinanessita: ok, that's a good one21:37
ralsinaI can't switch to yielding and inlineCallbacks because __init__ can't be a generator21:38
nessitaralsina: ah, ok, makes sense21:39
ralsinanessita, one note: in case of credentials error, I am not sending the user to the next page, I am only setting that the next page will be sign in (which makes sense since we don't effectively have credentials)21:45
nessitaralsina: error does not mean there is no credentials. We can have U1 credentials and still have errors21:46
ralsinabut they are credentials we can't get21:46
nessitaempty dict as result means no credentials21:46
ralsinaso, show the error and do what? Close?21:46
nessitaralsina: if retrieving credentials failed, is very likely that trying to sign in will fail as well21:47
nessitaralsina: error should be a pretty uncommon case21:47
nessitaralsina: what I mean, error in that stage means that something is very wrong21:47
nessitaand very likely nothing related to SSO will work21:47
ralsinayes, agreed it's uncommon. I mostly added the handler to avoid crashing when we don't have the registry keys set21:47
ralsinaso, it's mostly for us, really21:47
nessitaralsina: that's good, and this matches the case were the following operations will fail as well21:48
ralsinaok, so closing makes sense21:48
nessitaralsina: so my advice is error message popup in that case21:48
ralsina"Error getting credentials: BLAH, application will close",21:48
nessitaok, I better get going22:11
karnibye nessita !22:11
nessitakarni: goshm you never sleep! :-)22:12
nessitakarni: GO TO PARTY22:12
* nessita -> eows22:12
karninessita: I sleep. I just usually start work at 10-11 AM ;>22:12
karninessita: HAve a great weekend ^_^22:12
nessitayou too!22:12
karniThank you! \o22:12
=== CardinalFang_ is now known as CardinalFang
=== yofel_ is now known as yofel

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!