karniCardinalFang: Hi! Thanks for the review. You've double-approved ubuntuone-files-java-client - was one of the approvals for u1f progressbar branch?00:00
CardinalFangkarni, no, I don't think so.00:00
karniCardinalFang: ok00:00
mthaddonU1 down for DB maintenance06:41
mthaddonand service should be back now07:11
Agravainhi guys :)07:49
Agravainis there a client for Mac OS or any other way to download the entire contents from Ubuntu One directly to my Mac?07:49
faganAgravain: nope we havent got one yet08:19
Agravainfagan: ok, thank you for replying08:56
karniGood morning!09:07
nessitagood rmoning everyone!11:06
gatoxnessita, good morning11:13
nessitahi gatox, how is it going today?11:14
gatoxnessita, nice! :P11:14
nessitaralsina: ping11:21
=== zyga is now known as zyga-doctor
=== yofel_ is now known as yofel
gatoxralsina, ping11:38
nessitagatox: if you need anything, you can ask me, I may be able to help you. Also, can I have a trivial\isima review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/dislexia-no-more ?11:50
gatoxnessita, ok..... reviewing... i was looking for ralsina because i have some question about one of his branches that need review11:50
nessitagatox: ah, I can't answer that :-D11:50
ralsinagood morning!12:14
nessitahi ralsina12:14
ralsinahi nessita12:14
ralsinagatox: good morning amd feel free to ask :-)12:14
nessitaralsina: were you able to review my "inherited" branch? :-)12:14
ralsinaand pongs12:14
ralsinanessita: almost done, only need to run tests on linux12:15
gatoxralsina, i left a comment in your branch12:19
ralsinagatox: ok!12:20
ralsinanessita: +112:22
gatoxnessita, ahhhhhh +1 to your branch..... i forgot to tell you12:23
ralsinagatox: answered your comment12:27
* gatox reading...12:27
gatoxralsina, just an idea... maybe i'm terribly wrong :P..... but couldn't this be done with a qthread... where the process is executed inside the thread and when the thread finish (emit: finished) execute that function?? so in this way it's not going to be an arbitrary number12:30
ralsinagatox: I am fairly sure we are using python threads elsewhere, and you can't mix those and QThread if I remember right12:31
gatoxralsina, ok..... was just an idea :P12:32
gatoxralsina, i'm having some problems with the installer.... the one in trunk12:33
gatoxralsina, i delete my local copy and rebranch it..... and it stills continue...... when i open the installer...... it shows me the license page....... with a finish button.... i can't go to the next page :S12:34
gatoxralsina, and i have everything up to date12:35
ralsinagatox: yes, the brach that fixes that is merging right now12:37
ralsinagatox: the problem was: if it couldn't start sso-client, it failed that way12:37
gatoxralsina, ahhhhhhhh okok12:38
nessitadobey: ping12:41
gatoxralsina, i'm looking at Bug: #823414... should i launch the uninstall when the user click Disagree or not? Was this defined?12:42
ralsinaYes, we should12:42
ralsinaWe should ask the user if he's sure (with our own dialog), then launch uninstall, then show a "it's uninstalled" message.12:43
gatoxralsina, ok12:43
ralsinabad side is, currently the uninstaller is invisible, not sure why :-)12:44
gatoxralsina, ok... i'll take a look at that12:47
ralsinagatox: ok, ask lisette for words and stuff ;-)12:48
gatoxralsina, ok12:48
lisettewords? :)12:51
faganlisette: http://www.youtube.com/watch?v=w_Rut4qm33g :D12:52
nessitalisette: give us words!!! :-P12:52
lisetteaargh, i am blind now!12:53
faganlisette: they are one of the greatest Irish bands ever12:53
faganthey were our backstreet boys12:53
nessitalisette: you mean deaf? :-D12:54
lisettenessita: and deaf!12:54
faganThe lack of musical taste in this team is terrible12:54
nessitafagan: dude, you actually like avril lavigne! :-)12:55
nessitaso, you may wanna consider the musical taste issue is the other way around :-P12:55
fagannessita: hah yeah but I was in the generation that that was acceptable12:55
nessitafagan: you, calling me, old?12:56
* nessita prepares the counterstrike12:56
fagan*cough* *cough*12:56
nessitaI'm old but with honor! and prefect musical taste ;-)12:56
* nessita runs12:56
fagannessita: na your not that old but you were in the good old generation that had power metal and nirvana12:57
=== zyga-doctor is now known as zyga
faganralsina nessita dobey alecu gatox standup13:00
gatoxfagan, ack13:00
nessitaalecu, dobey?13:01
faganIll go they can catch up13:01
fagan* Finished off the redirects13:01
fagan* Reading some books waiting for another assignment13:01
fagan* Nope13:01
fagannessita: go13:01
nessitaDONE: finished dont-shutil-move branch (waiting for alecu's review), tried and failed miserably to propose a clean solution for bug #82734313:02
nessitaTODO: propose some solution for bug #82734313:02
nessitaBLOCKED: nopes13:02
nessitaNOTES: I'm leaving at noon today to go to university13:02
nessitaNEXT: gatox13:02
ubot4Launchpad bug 827343 in ubuntuone-client "Send platform details when pinging for credentials (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/82734313:02
gatoxFixed: Bug #819965, Bug #820872, Bug #82087413:02
gatoxAdd Tests. Bug #823203, Bug #82341413:02
ubot4Launchpad bug 819965 in ubuntuone-windows-installer "Congratulations typos (affects: 1) (heat: 17)" [Undecided,New] https://launchpad.net/bugs/81996513:02
gatoxralsina, go13:02
ubot4gatox: Bug 820872 on http://launchpad.net/bugs/820872 is private13:02
ubot4gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private13:02
ralsinaDONE: closed bug #825473, merging fix for bug #825491, worked on bug #825513, small fixes on the installer-builder-branch13:02
ubot4gatox: Bug 823203 on http://launchpad.net/bugs/823203 is private13:02
ralsinaTODO: close those two bugs, autostart/credentials testing13:02
ralsinaBLOCKED: no13:02
ubot4gatox: Bug 823414 on http://launchpad.net/bugs/823414 is private13:02
ubot4Launchpad bug 825473 in ubuntuone-windows-installer "License page may show a "Finish" button (affects: 1) (heat: 36)" [Critical,Fix committed] https://launchpad.net/bugs/82547313:02
ubot4Launchpad bug 825491 in ubuntuone-windows-installer "The "Local Folders" page tries to do things without credentials (affects: 1) (heat: 6)" [Medium,In progress] https://launchpad.net/bugs/82549113:02
ubot4Launchpad bug 825513 in ubuntuone-windows-installer "The local folders page is not up to spec (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/82551313:02
dobeyλ DONE: bug #824666, bug #824669, bug #82677213:04
dobeyλ TODO: more installer fixes, deal with tech board13:04
dobeyλ BLCK: None.13:04
ubot4Launchpad bug 824666 in couchdb-glib (Ubuntu Oneiric) (and 1 other project) "ftbfs on all archs (affects: 1) (heat: 6)" [High,Fix released] https://launchpad.net/bugs/82466613:04
ubot4Launchpad bug 824669 in evolution-couchdb (Ubuntu Oneiric) (and 1 other project) "ftbfs on all archs (affects: 1) (heat: 6)" [High,Fix released] https://launchpad.net/bugs/82466913:04
ubot4Launchpad bug 826772 in ubuntuone-installer "Installer currently hardcodes 'natty' as series (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/82677213:04
ralsinadobey: I need to talk to you about bug #82034513:05
ubot4Launchpad bug 820345 in ubuntuone-client (Ubuntu) (and 1 other project) "Please remove UbuntuOne from MessagingMenu (affects: 2) (heat: 14)" [Undecided,Confirmed] https://launchpad.net/bugs/82034513:05
alecuDONE: worked on bug #824819, started re-review of nessita's branch13:06
alecuBLOCKED: by a few more broken things I found on windows while fixing tests, like http://pastebin.ubuntu.com/666883/13:06
alecuTODO: see if the above only happens to me, work on #82400313:06
ubot4Launchpad bug 824819 in ubuntuone-client "SD and tests need to wait until a watch is removed (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/82481913:06
alecunessita, ralsina, gatox: can you guys try the above pastebin?13:06
nessitaalecu: sure13:06
nessitaalecu: linux or windows?13:06
dobeyralsina: ok13:06
alecunessita, windows13:06
gatoxalecu, ok13:06
=== m_conley_away is now known as m_conley
alecugatox, make sure to do "from ubuntuone.syncdaemon import tritcask" first.13:07
nessitaalecu: I have 100 all the tiem13:07
gatoxalecu, ok13:07
nessitaalecu: but it's been ages since I rebooted this VM13:08
ralsinaalecu: I get 100 all the time too13:08
nessitaalecu: we had an issue with this, but verterok fixed it13:08
alecunessita, ralsina: 100 is perfect13:09
nessitaalecu: you 100% up to date?13:09
alecunessita, this happens after I merged trunk.13:09
alecunessita, I should try on trunk13:09
gatoxalecu, http://paste.ubuntu.com/667280/13:09
gatoxalecu, i don't get 100 all the time13:09
nessitagatox: you booted this machine today?13:09
ralsinaalecu:   len(set(len(set([tritcask.DataFile._get_next_file_id() for n in range(100)])) for i in range(1000))) == 113:09
gatoxnessita, no..... should i do that?13:09
nessitagatox: nopes13:10
alecunessita, gatox: virtualbox on 32bits or 64?13:13
nessitaalecu: 32 for me13:13
nessitaalecu: ah, sorry, I misunderstood13:13
nessitaalecu: host is 64, guest is 3213:14
alecunessita, the same on my case.13:14
gatoxalecu, 3213:14
gatoxalecu, same as nessita13:14
gatoxalecu, the vm is 32... host 6413:14
alecuanyway: this shows that time.clock is not being reliable (at least under vbox): it's returning the same value for calls near in time13:16
alecuthis broke a few of the tests, and it's been hell to debug13:16
nessitaalecu: you sure you're running latest trunk? we added a fix for this recently (bah, verterok did)13:17
* verterok looks around13:17
ralsinaalecu: hmmm... check if you have virtualbox's "fix client's clock" set13:17
ralsinaand/or windows's NTP equivalent (in control panel, date/time)13:17
nessitaverterok: hey there! alecu is having bad-bad issues with tritcask file generation, id's gets duplicated13:17
verteroknessita: yes, reading the backlog13:18
alecuralsina, windows' ntp updates the time *just* once every day13:18
ralsinaalecu: ok, so that's not it13:18
verterokalecu: tritcask is now using time.time() + time.clock() it has more resultion/accuracy than time.time on linux :p13:18
alecuralsina, also, I've tried setting the vbox time update flag, and the result is the same. Let me fetch the article that explains it...13:18
nessitaalecu: do you have a WindowsTimer inside ubuntuone/syncdaemon/tritcask.py?13:19
verteroknessita: I was about to ask that :)13:19
verterokmaybe it's using a installed tritcask?13:19
nessitaalecu: maybe your syncdaemon is loading an "old" pyc for tritcask, from an old install, for example?13:19
ralsina"print tritcask" should clear that13:20
alecunessita, verterok: let me check that.13:20
alecubtw, I tried with: vboxmanage setextradata <vmname> "VBoxInternal/Devices/VMMDev/0/Config/GetHostTimeDisabled" "1"13:21
alecuas explained here: http://the-starport.net/freelancer/forum/viewtopic.php?topic_id=410013:21
alecubut it seems to fix a different issue.13:21
alecunessita, verterok: I added a "print '*'," inside WindowsTimer.time, in trunk, and I just made sure I'm using the latest version, and I still get the same behaviour.13:29
alecuit seems that time.clock is not moving forwards :P13:30
verterokalecu: that's weird :(13:30
alecuverterok, I even tried adding three zeroes to the multiplier in _get_next_file_id13:31
verterokalecu: could you try this: python -c "import time; time.clock(); print [time.clock() for i in range(10)]"13:32
alecuverterok, !!!!13:33
alecuverterok, on the second run it was all zeroes!!! :P13:34
alecuverterok, http://pastebin.ubuntu.com/667307/13:34
alecuverterok, on the first run they were sensible values13:34
verterokyour clock is broken(?!?)13:34
verterokthis is a big WTF13:35
alecuverterok, and it happens 50%: http://pastebin.ubuntu.com/667310/13:35
verterokalecu: is this a win 7 vm, right?13:36
alecuverterok, win 7 32bits, on the latest virtualbox on a natty 64bits13:36
verterokok, I don't have the same env :(13:36
alecuverterok, gatox managed to reproduce this, but neither nessita nor ralsina were able to reproduce it.13:37
verterokmaybe virtualbox is broken?13:37
alecuverterok, yeah, it looks like it.13:37
verterokalecu: all are using the same virtualbox version?13:37
ralsinawe can switch to the timeit module, I suppose :-(13:37
nessitaralsina: your windows is not a vm but a real install, right?13:37
ralsinanessita: yes, a real one13:38
verterokralsina: no we cant :(13:38
verterokralsina: timeit uses time.clock in windows :p13:38
nessitaralsina: can you run the "test" several times with a clean reboot to see if we can reproduce this outside VB?13:39
gatoxralsina, nessita trivial branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/congratulations-typos/+merge/7169013:39
nessitagatox: looking!13:39
ralsinano, I can't reboot because I am in the management call :-(13:39
nessitaralsina: maybe later? :-/13:40
Milos_SDI have a little problem uploading 1.4 GB zip file on ubuntu one free account...13:40
ralsinain about one hour, yes13:40
alecunessita, ralsina: I need to be afk for an hour or so.13:41
Milos_SDupload was done, but "please wait" was still there, and would never go away... :S13:41
nessitaalecu: were you able to finish my review?13:41
Milos_SDis it possible to upload such a big file?13:41
alecunessita, not yet13:41
verterokMilos_SD: hi, is this using the web or the desktop client?13:41
nessitaalecu: ok, I'll share some comments with you when you get back13:41
Milos_SDverterok, web13:42
alecunessita, some comments on that branch?13:42
verterokrye: around?13:42
ryeverterok, around13:42
verterokrye: hi! Milos_SD is having some problems uploading via the web...do you know something about that? :)13:42
nessitaalecu: yeap -> confirmed that dont-shutil-move does not fail when committting a partila file that is failing in trunk. maybeBadNews is this: http://pastebin.ubuntu.com/667286/ (watch warnings over files)13:42
ryeMilos_SD, could you please try going to https://one.ubuntu.com/files/ and see whether the file has been uploaded indeed, w/o closing the first tab13:43
Milos_SDverterok, I don't even know if I can upload specific file from desktop client13:43
nessitaalecu: but if you need to go, we can talk later (but before 12ART please)13:43
Milos_SDnessita, I closed that tab a long time ago :)13:43
Milos_SDrye, I closed that tab a long time ago*13:43
alecunessita, ack.13:44
gatoxnessita, i'm changing something in my branch... let you know in a while13:44
Milos_SDthere was no network activity at my side... but "please wait" was still there :S13:44
nessitagatox: ack13:44
ryeMilos_SD, ah, and the file is not there, I supposed?13:46
Milos_SDrye, yes... there is no file there :(13:46
Milos_SDrye, maybe there is some problem with time spent uploading? I have only 512 Kbps upload, so it would take up to 7 hours to upload 1.4 GB file...13:52
ryeMilos_SD, is your IP address static? Could you please PM me your current IP address?13:53
Milos_SDrye, it is not static... but I have cable internet, so lease is very high13:53
ryeMilos_SD, well, "static enough" - I want to see whether we have reports of your upload failing13:54
gatoxnessita, branch updated13:56
nessitagatox: ack13:57
nessitagatox: this does not look right:14:06
nessita"launch the dashboard to get more information about the sync in progress". I think it should be "sync progress" and not "in progress"14:07
nessitagatox: another question, you added 2 checkboxes but the logic for those is not added?14:07
ralsinanessita "the sync in progress" is grammatically correct. So is "the sync progress", of course :-)14:08
nessitaralsina: both are gramatically correct in isolation, but in the context used I don't think "in progress" is correct14:08
nessitaah, I just read it with a different "accent" and I see the other possibility14:09
gatoxnessita, i've created another bug to add the logic of those checkboxes, because the bug says that the Congratulations page only have some typos... in order to submit that and don't delay the branch for other issue...14:09
nessita"launch the dashboard to get more information about the sync that is in progress"14:09
gatoxnessita, should i close the new bug and do it all together?14:09
nessitagatox: then don't add the checkboxes in that branch...14:09
nessitagatox: just submit the typo in this branch14:09
nessitaso you can fix that bug14:09
ralsinaalso, unless the width change is actually necessary, there is no point changing that line14:10
gatoxnessita, ok... and about the text... i copy the text from the wireframe14:10
gatoxthat was updated14:10
nessitagatox: ok then14:10
gatoxnessita, ok..... branch updated..... in the next one (later) i will add the checkboxes with the logic14:12
nessitagatox: approved and globally approved14:21
=== gatox_ is now known as gatox
=== teknico_ is now known as teknico
ralsinanessita, verterok: is it still useful if I reboot and try the tritcask thing?14:33
nessitaralsina: afaik, yes, we have no new ideas in that front14:33
ralsinaok, this is going to take a while...14:34
highvoltagehi! will there ever be an Ubuntu One appliance? I have a school district that's using iFolder and Ubuntu One would make a great replacement if they could store data locally14:46
ralsinanessita, verterok: rebooted twice, windows 7 64 bits, I always get good results14:52
nessitaalecu: just in time! see what ralsina says14:52
alecunessita, are you still available to tell me about that issue?14:52
nessitaalecu: yes sir14:52
verterokralsina: great news for tritcask, bad news for virtualbox(?)14:52
nessitaalecu: did you get any chance to look at the paste?14:52
ralsina_I will now try a VM see what happens there14:52
alecunessita, I'm looking at the paste, but I don't understand what's broken in it14:53
nessitaalecu: I'm not sure if something is broken, I saw this: 2011-08-16 10:08:59,510 - ubuntuone.SyncDaemon.filesystem_notifications.GeneralProcessor - WARNING - Ignoring path as we don't have enough permissions to track it: 'C:\\Users\\Test\\Ubuntu One\\fideos: dos?.png'14:54
nessitaalecu: and that "looks" buggy14:54
alecuverterok, I remember that you told me that tritcask cannot use an incremental numbering because of something..... what was it?14:54
nessitaalecu: the path is not readonly, but is not  dir. So I see that log warning and makes me think that maybe we have a bug in the add watcher code?14:54
verterokalecu: tritcask needs the timestamp in the data file name as it's a way to easily sort the files14:55
ralsina_verterok: on a XP vm I get much *smaller* values, but not 0: https://pastebin.canonical.com/51293/14:56
alecuverterok, what if we add a dot-numbering to the filenames?14:56
verterok we can change that, but it means a metadata migration in linux14:56
alecuverterok, as in timestamp-sequence.cask ?14:56
alecuverterok, oh, right.14:56
alecuralsina_, small is nice. Zero is plain wrong.14:57
verterokralsina_: those values looks good14:58
verterokalecu: do you have the same python version? any weird import from __future__ (like, from __future__ import round :p)?14:58
ralsina_version of virtualbox?14:59
alecuverterok, I'll take a look14:59
verterokalecu: I understand what you'r trying to solve with the sequence...but I think the problem is something outside sd implementation14:59
alecuverterok, it surely looks like it. And I'm willing to concede it's a virtualbox bug14:59
alecuverterok, but this means we will not be able to run any kind of tests in virtualbox15:00
alecunessita, I think I found it: "os.access(path, os.R_OK)"15:00
verterokalecu: also the sequence workaround might not be enough, we need to think on a more broad change15:00
alecunessita, it's using path as a byte sequence15:01
verterokalecu: use kvm? :)15:01
nessitaalecu: ack, I'll file a bug15:01
alecunessita, in is_ignored() in ubuntuone/syncdaemon/filesystem_notifications.py15:01
verterokalecu: I did the change using virtualbox, so it's working there15:01
alecuverterok, it's working for ralsina and nessita on virtualbox too... but it fails for gatox too15:02
alecuverterok, but if I was nessita or ralsina_, I would not trust it either...15:02
ralsina_alecu, gatox, nessita: what is your VBox version?15:02
alecugatox, what's you cpu? amd?15:02
verterokalecu: so, 3 - 2...we win!15:03
alecuverterok, hahahaha15:03
nessitaalecu: model name: Intel(R) Core(TM) i5 CPU         750  @ 2.67GHz15:03
alecuI'm sure nessita and ralsina and verterok are on intel15:03
alecuI'm on an amd15:03
ralsina_yes, i5 here15:03
nessitaalecu: VB is a 4.1.015:03
ralsina_I am in 4.0.4 so it's probably not the version15:04
gatoxalecu, ralsina_ vbox version: 4.0.10_ubuntu r7242615:04
gatoxalecu, sorry for the delay...... about window don't let copy the version and it closes everytime it lose the focus :P15:04
gatoxalecu, my host is intel core2duo15:04
alecu4.0.12 r7291615:05
alecugatox, :-)15:05
ralsina_hmmm... here's an idea. Alecu: on one terminal, start a "dir /s c:\"15:05
ralsina_and on another try the clock thing15:05
alecuralsina_, good point15:06
ralsina_There are some old bug reports about the clock being stuck if the VM is idle15:06
alecualso, please everybody: let's paste the version of the "virtualbox guest additions"; mine: 4.0.10 r7247915:06
alecuI should probably update them to the latest version too.15:07
ralsina_How about let's try updating everything to the latest and it may fix itself?15:07
alecuralsina_, the thing is that my vbga do not match my vbox15:08
alecuralsina_, running dir/s did not help15:08
ralsina_alecu: interesting15:08
nessitaalecu: where can I see that version?15:09
nessitaalecu: I installed VB from the website .deb, not from our repos15:09
alecunessita, me too15:09
alecunessita, in the tray bar, hover over the vbox icon15:09
alecunessita, open the traybar with the up arrow if needed.15:09
alecunessita, 4.1.0 ?15:10
alecuhmmm... then my vbox must be from the repos instead.15:10
nessitaalecu: returning to the watch issue, I also noticed in http://pastebin.ubuntu.com/667286/ that the WARNING appears twice, which sounds suspicious (specially since we have threads involved)15:11
nessitagatox: where did you install VB from?15:11
rodrigo_CardinalFang, thisfred_: I have a bug for you -> https://bugs.launchpad.net/ubuntu/+source/desktopcouch/+bug/780972 <- do you have any idea what's causing it?15:11
ubot4Launchpad bug 780972 in desktopcouch (Ubuntu) "desktopcouch-service crashed with Unauthorized in request(): ('unauthorized', 'Authentication required.') (affects: 144) (dups: 9) (heat: 698)" [High,Confirmed]15:12
gatoxnessita, from repository15:12
rodrigo_CardinalFang, thisfred_: because of that, dc doesn't work at all for me on oneiric15:12
nessitagatox: ah!15:12
alecunessita, "deb http://download.virtualbox.org/virtualbox/debian maverick contrib"15:13
nessitamaverick? hum15:13
nessitaalecu: no natty?15:13
alecunessita, so mine's from upstream15:14
nessitaalecu: can you try this one? http://download.virtualbox.org/virtualbox/4.1.0/virtualbox-4.1_4.1.0-73009~Ubuntu~natty_amd64.deb15:14
alecunessita, I very likely installed it when natty was being developed15:14
alecunessita, sure!15:14
nessitaalecu: or choose the best for you: http://download.virtualbox.org/virtualbox/4.1.0/15:14
thisfred_rodrigo, I'll have a quick look15:18
rodrigo_thisfred_, thanks!15:18
alecunessita, the duplicated logs seem to come from the loop in freeze_commit15:21
alecunessita, it seems to me that there are a pair of events coming from the same path, and being ignored there15:22
nessitaalecu: I followed the code and I'm not sure what 2 pair of events are being ignored15:26
dobeylunch time, bbiab :)15:27
alecunessita, do you have more context for this log?15:27
alecunessita, more lines above the ones you pasted?15:27
nessitaalecu: the whole run is: http://pastebin.ubuntu.com/66728215:28
alecunessita, ubuntuone/platform/windows/filesystem_notifications.py, process_IN_MOVED_TO()15:33
nessitaalecu: without checking, this code looks duplicated from linux.... is that soe?15:34
alecunessita, there are the two calls to is_ignored15:34
alecunessita, I've no idea if this is duplicated15:34
thechefCan I buy music using the phone?15:35
nessitaalecu: how did you end up checking process_IN_MOVED_TO? I don't see the "move" in the log15:36
=== kklimonda is now known as Guest54756
alecunessita, I looked at what was calling is_ignored()15:39
alecunessita, and that place looks likely, because there are two calls in a row15:39
nessitaalecu: if we're having a move event in this case, we're in problems (ie we're getting events that we should not be getting)15:40
nessitawhich brings me back to the fact that we need to fix the eq_inotify tests...15:41
nessitaalecu, ralsina_, gatox, Chipaca (if available): can we have the mumble?15:41
ralsina_nessita: fine by me15:41
gatoxnessita, ack15:43
nessitaalecu: can you join mumble please?15:44
thisfreddobey: rodrigo_: https://bugs.launchpad.net/ubuntu/+source/desktopcouch/+bug/780972 confirmed, I have no idea why though. Could be new couchdb with missing /broken patches, could be broken js in new couchdb again, could be something changed in the way we store the oauth keys. I really have no time to debug this right now.15:53
ubot4Launchpad bug 780972 in desktopcouch (Ubuntu) "desktopcouch-service crashed with Unauthorized in request(): ('unauthorized', 'Authentication required.') (affects: 144) (dups: 9) (heat: 698)" [High,Confirmed]15:53
=== Guest54756 is now known as kklimonda
thisfreddobey: rodrigo: no errors in the couchdb logs though (just 401s), so it may not be couchdb itself at all, and we're just not sending the right tokens, or not storing them in couchdb in the first place.15:57
=== beuno is now known as beuno-lunch
alecunessita, http://webchat.freenode.net/16:12
* nessita -> teaching duties16:14
nessitabye all!16:14
gatoxralsina_, it seems that it's going to be an easy fix change the messagebox for the label in all the pages16:23
dobeythisfred: pensive panda16:28
thisfredpessimistic pony16:28
dobeyponderous plato16:29
dobeynot sure why, but for some reason i am wary of products with "super quality" in their name16:41
gatoxralsina_, ping16:45
gatoxralsina_, let me know when you are back... i've a branch almost ready for revision.... but there is something i'm not quite convince17:10
=== beuno-lunch is now known as beuno
=== alecu is now known as alecu-lunch
ralsina_gatox: I'm back sorry, family things18:31
gatoxralsina_, actually when critical it's called from controller, it is called with 4 params: self.view, self.view.wizard().app_name, CAPTCHA_LOAD_ERROR19:07
gatoxralsina_, is it of if i modified that calls to just pass the string?? the other params now that it's just a simple label are no longer necessary19:08
gatox*of = ok19:08
gatoxis it ok....?19:08
ralsina_I don't really remember that code19:08
ralsina_is critical() defined on the wizard or in the page?19:09
ralsina_or is it gettig a real QMessageBox?19:09
gatoxcritical creates a qmessagebox on the wizard and show it19:09
gatoxand in controllers if the param message_box is None, it creates a QMessageBox19:10
ralsina_ok, cool then it's ok :-)19:10
gatoxralsina_, ok.... i'll keep working on that... i'm having problems with some tests, but the code seems to be ready19:11
ralsina_what tests?19:12
gatoxralsina_, they are some tests actually testing "critical", but now i changed the behavior of that function... just that19:17
ralsina_oh, ok19:17
=== alecu-lunch is now known as alecu
ralsina_I am stopping for a while. Will work some more late tonight, so please email review requests etc.20:16
gatoxralsina_, ok, i'm finishing the tests for my branch20:24
gatoxso i'll let you know20:24
gatoxralsina_, i was more time writing fixing tests than code :P20:25
ralsina_gatox: he, that's standard ;-)20:25
gatoxReady for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/bug-820872/+merge/7177320:41
dobeyhave a good evening all20:54
gatoxdobey, bye20:55
=== m_conley is now known as m_conley_away
=== yofel_ is now known as yofel
nessitahello everyone!22:01
nessitaalecu: ping22:01
nessitaralsina_: you around?22:05
ralsina_nessita: hi22:06
nessitaralsina_: hi there. Would you know if alecu finished the review of my inherited branch? LP shows no review from him22:07
ralsina_nessita: didn't hear from him after you left22:07
alecunessita, hi22:08
nessitaalecu: hi there!22:08
alecunessita, I left the test running...22:08
ralsina_and here he is :-)22:08
aleculet me approve it22:08
nessitaalecu: thanks! :-)22:08
ralsina_if noone needs anything right now, I'll go  back to playing "Battle beavers" with Tato :-)22:09
ralsina_I will do reviews late tonight though22:09
alecuralsina_, what's "Battle beavers"?22:10
ralsina_alecu: http://www.abcjuegos.net/juego/battle-beavers22:10
ralsina_not as interesting as it sounds ;-)22:10
ralsina_nessita, alecu: if I could get a review for https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/too-soon/+merge/71426 it would be great22:11
nessitaralsina_: in that branch, question:22:13
nessitaralsina_: when do you stop the timer? I mean, I would expect the timer to be turned on only when "entering" the folders page, and stopping it when leaving it22:13
ralsina_it is started when entering, but forgot to stop it, right22:14
nessitaotherwise looks like it wastes resources when is not needed...22:14
ralsina_I will add a stop when switching to the next page22:14
nessitaralsina_: also, please add tests! :-) (faking the timer, I would advice)22:14
ralsina_nessita: the function that the timer calls has tests22:14
nessitaralsina_: I hate having this conversation!!! :-)22:15
ralsina_ok, let's not have it then. I will figure out more tests, I suppose.22:15
nessitayou need to test every single line of code you add. This is new functionality, we want tests for it...22:15
ralsina_The timer is not new functionality22:15
ralsina_it has been there for a month22:16
ralsina_but sure, I will add it22:16
nessitaralsina_: also, we should have a test for the self.ui.add_folder_button.backend.account_info failing, to ensure we;'re no having errors like before22:16
ralsina_Since I already I test what the timer triggers, I could add a test that the timer is startted, I suppose. But don't worry, I will add 10 or 12 more tests.22:16
ralsina_bye, see you all tomorrow.22:17
gatoxnessita, i send you a branch for review22:34
gatox2 branches :P22:35
nessitagatox: have the links handy please?22:35
gatoxnessita, https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/bug-820872/+merge/7177322:36
gatoxnessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/bug-820872/+merge/7177422:36
gatoxnessita, they are related22:36
nessitagatox: so, one question...22:39
nessitagatox: is the sso code calling the critical method that is defined in windows installer?22:39
nessitathat is puzzling my head, shouldn't that be the other way around?22:40
nessitagatox: or critical is also defined in sso?22:40
gatoxnessita, no, it's calling the critical method in the installer, because the controller receive an instance of the wizard22:44
gatoxnessita, sorry, of the pages22:45
gatoxbut with the pages you can access the wizard22:45
nessitagatox: what if someone uses a wizard that does not have the critical method defined?22:45
nessitagatox: should the sso side send a siganl, and the other side should connect to the signal and do something in that case?22:46
gatoxnessita, sorry.... not following...... there is only one wizard.....22:46
nessitagatox: what I mean is:22:46
nessitagatox: the sso client is a generic project that can be used from any app, not only from the installer, so22:46
gatoxnessita, wait wait.... i know where is the confusino22:46
nessitayou do?22:46
nessitaI read then22:46
nessitagatox: where is the confusion?22:47
gatoxthe sso controller.... receive a message_box... this message_box is really an instance of wizard, but can also be a QMessageBox.... the critical method in the wizard works as a wrapper for create a QMessageBox and call the critical method (before)... now this method show a form error label... but the critical method, belongs to the message_box object that you give to the sso22:48
gatoxfrom the installer when you create a controller you establish what this message_box object would be..... in this case is self, because the installer wizard implement "critical"22:48
ralsinaThe message_box object is anything that has a "critical" method. By default it's a QMessageBox.22:49
gatoxnessita, yes, if you don't pass a references for something at the message_box param... it will create a QMessageBox22:50
nessitagatox: understood now!22:51
gatoxnessita, nice22:51
nessitaralsina: you're back! I was writting an email to you22:51
ralsinanessita: I thought I had to run, but it turns out I did not22:51
ralsinaso I have a little more time22:51
ralsinatherefore, pushed the branch with the test for when there is an exception on account_info()22:52
ralsinathe only "new" code is moving those lines inside the try/except so that test should cover them.22:52
ralsinaThere is no way to stop the timer yet because there is no "next page" method, that's on the next branch22:52
nessitaok, I gotta make some dinner, I'm starting to starve23:10
nessitasee ya all tomorrow23:11
gatoxnessita, bye23:11

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!