| === yofel_ is now known as yofel | ||
| karni | Good morning! | 09:01 |
|---|---|---|
| === rodrigo__ is now known as rodrigo_ | ||
| facundobatista | Hi all | 10:26 |
| nessita | hello everyone! | 11:05 |
| duanedesign | o/ | 11:13 |
| nessita | ralsina: ping | 11:34 |
| nessita | gatox: ping | 11:38 |
| gatox | nessita, pong | 11:39 |
| nessita | gatox: hi there! question | 11:39 |
| gatox | nessita, shoot | 11:40 |
| nessita | gatox: last week I made a review for you where we skipped a whole testcase because it was using the real control panel. I think you told me you were gonna fix that next, but I'm not sure. Can you please confirm? | 11:40 |
| gatox | nessita, yes, ralsina told me that he has to implement all that test from scratch | 11:41 |
| gatox | nessita, it was local_folders | 11:41 |
| nessita | gatox: what are you working on today? it may be a good exercise for you to do that ;-) | 11:42 |
| gatox | nessita, i'm working on this: https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/820874 | 11:42 |
| ubot4 | gatox: Error: Bug #820874 is private. | 11:42 |
| * nessita looks | 11:42 | |
| nessita | gatox: do you have an ETA for that? | 11:42 |
| gatox | nessita, i think it can be done for 12ART... code complete for sure... tests is another story :P | 11:44 |
| nessita | gatox: -.- | 11:44 |
| nessita | gatox: code complete means with tests. Ideally before writing the code... | 11:45 |
| nessita | gatox: so, when you're asked for an estimates, always always include the tests | 11:45 |
| gatox | nessita, i mean, i usually spend more time writing tests and fixing when are some changes... | 11:45 |
| gatox | nessita, ok.... probably it will be ready for lunch | 11:45 |
| gatox | :P | 11:46 |
| nessita | gatox: ok, so, can you please take over the fixing tests after completing that task? | 11:46 |
| gatox | nessita, OK! | 11:46 |
| nessita | gatox: great! (unless you had something else in your plate... in that case let me know and we evaluate priorities) | 11:47 |
| gatox | nessita, no, i think that fixing those test should be done before the other bugs that are not so critical | 11:47 |
| nessita | gatox: GREAT! we're in sync then | 11:48 |
| nessita | gatox: sso branch approver and globally approved, moving to windows-installer | 12:17 |
| gatox | nessita, awesome! | 12:17 |
| nessita | gatox: so, I'm not sure you're adding a test for the removal of the form errors widget. I'm talking this line added in next(): | 12:19 |
| nessita | self.currentPage().layout().removeWidget(self.form_errors_label) | 12:19 |
| gatox | nessita, yes, not directly... but that line is executed on "next" for each page that it's called a lot in the tests... but let me add some tests for that | 12:20 |
| nessita | gatox: yes please, let me explain why is necessary: from the user point of view, is important that the form-error message is cleared, once the error is "resolved" (either by retrying or moving forward) | 12:23 |
| gatox | nessita, yes, i'm writing some tests tocheck that now every time next() is called in test_gui | 12:24 |
| nessita | gatox: great | 12:24 |
| Chipaca | nessita: i'm sure you asked me for a review, but i've lost the link | 12:24 |
| Chipaca | nessita: now would be a good time | 12:24 |
| nessita | Chipaca: https://code.launchpad.net/~nataliabidart/ubuntuone-client/platform-details/+merge/71723 | 12:25 |
| nessita | Chipaca: context: we're adding platform details to the ping url in the u1client side. The moving of credentials into its own module is caused by a nightmare of cicurlar imports between code outside platform and code inside there | 12:25 |
| ralsina | nessita, gatox: good morning, and I have that test case redone in this branch: lp:~ralsina/ubuntuone-windows-installer/local-folder-fixes | 12:26 |
| gatox | ralsina, awesome! :D | 12:26 |
| nessita | ralsina: hi there! I just made another review like 30 minutes ago, you added changes after that? | 12:26 |
| ralsina | nessita: nope, just sitting down at the computer right now | 12:27 |
| Chipaca | nessita: me, I would've also logged the return value of f in log_call | 12:27 |
| nessita | Chipaca: makes perfect sense, doing it | 12:27 |
| nessita | ralsina: so, I think you removed the skip of a testcase... I added comments about that in the MP | 12:27 |
| ralsina | nessita: I removed the skip so the tests I added would run, but I can add it back and move them to another tet case. OTOH, in the next branch they would move back | 12:28 |
| nessita | ralsina: right, the thing is that everything fails for me if that testcase is enabled back | 12:28 |
| Chipaca | nessita: also, i would've used urllib.urlencode(dict_of_attrs) rather than assembling it myself | 12:28 |
| ralsina | nessita: so, maybe this branch could go in with the other tests in that testcase failing (but those succeeding) instead of adding code I would remove again later today? | 12:28 |
| Chipaca | nessita: (re PLATFORM_PARAMS) | 12:29 |
| ralsina | oh, right it breaks everything for you :-( | 12:29 |
| nessita | Chipaca: ah, that's a good one, let me fix that as well | 12:29 |
| Chipaca | nessita: in fact, looks like all you want is urllib.urlencode(PLATFORM_DATA) | 12:29 |
| nessita | Chipaca: let me read the doc and I may nod or not :-D | 12:30 |
| nessita | ralsina: not sure why fixing this branch will make you add code you will remove later today. Can you please help me understand? | 12:30 |
| nessita | Chipaca: I'm nodding! :-) | 12:31 |
| ralsina | nessita: if I move the tests to another test case and move them back into this testcase again, that means adding the testcase and removing it? | 12:32 |
| nessita | ralsina: right, but if I'm following you, the test case you will be adding now will be reused in the next branch? | 12:32 |
| nessita | I mean, you can add the test case you have in the incoming branch (without all the adding of the tests) | 12:33 |
| nessita | no? | 12:33 |
| ralsina | nessita: actually, since I reimplement most of LocalFoldersPage, the current testcase starts working, AFAIK | 12:33 |
| ralsina | the next branch has this testcase, but working :-) | 12:33 |
| nessita | ralsina: don't you want to merge that new test case only in this branch? | 12:34 |
| nessita | new == fixed | 12:34 |
| ralsina | nessita: it will not work for you because of problems in LocalFoldersPage (race conditions) | 12:34 |
| ralsina | I could just merge this branch to the next one and propose the ext one instead | 12:35 |
| nessita | ralsina: let's do that, and I'll review the next one when is ready (as soon as is ready) | 12:35 |
| ralsina | ok then | 12:35 |
| fagan | ralsina: any intern work going? | 12:40 |
| ralsina | fagan: just arrived, but I think joshua has some more work on the docs | 12:40 |
| fagan | joshuahoover: you have anything for me to work on? | 12:41 |
| fagan | ralsina: well I did a big wiki redirect thing on monday I didnt hear about anything else | 12:41 |
| joshuahoover | fagan: how about bug triage? :) | 12:41 |
| ralsina | actually that's not a bad idea. | 12:42 |
| fagan | Ill have a look at the list then :) | 12:42 |
| joshuahoover | ralsina: fagan completed the last of the big docs tasks we had | 12:42 |
| ralsina | fagan: I need all the NEW/unassigned linux bugs of u1 for the last couple of weeks checked | 12:42 |
| fagan | ralsina: kk | 12:42 |
| ralsina | joshuahoover: ok | 12:43 |
| nessita | Chipaca: merged trunk in, urlencode added, test updated, pushed to revno 1111 | 12:45 |
| Chipaca | nessita: awesome. | 12:45 |
| * Chipaca smiles at beuno | 12:45 | |
| * beuno giggles | 12:46 | |
| fagan | connect 4 :D | 12:46 |
| Chipaca | fagan: ○○○○○○○ | 12:48 |
| Chipaca | fagan: ○○○○○○○ | 12:48 |
| Chipaca | fagan: ○○○○○○○ | 12:48 |
| Chipaca | fagan: ○○○○○○○ | 12:48 |
| Chipaca | fagan: ○○○○○○○ | 12:48 |
| Chipaca | fagan: ○●●●●○○ | 12:49 |
| Chipaca | fagan: sorry, you lose | 12:49 |
| * Chipaca runs | 12:49 | |
| fagan | Chipaca: what game were you playing I was white :D | 12:49 |
| Chipaca | heh :) | 12:50 |
| * fagan is a sharp one | 12:50 | |
| * Chipaca concedes the match | 12:50 | |
| fagan | gg wp | 12:50 |
| Chipaca | nessita: urlencode will produce unordered results, and that test will randomly fail | 12:51 |
| nessita | uh | 12:51 |
| Chipaca | nessita: (because it uses a dict) | 12:51 |
| nessita | let me patch urlencode then | 12:51 |
| Chipaca | nessita: or sort platform_data, or use urlparse to compare :) | 12:52 |
| Chipaca | nessita: e.g. urlparse.parse_qsl(urlparse.urlparse(PING_URL).query) | 12:53 |
| nessita | Chipaca: urlparse will not give me a dict back, unless I'm missing something. I'm getting a ParseResult, where the "path" path looks like a string | 12:53 |
| nessita | ah, I was using urlparse.urlparse | 12:54 |
| Chipaca | yeah, urlprase.urlparse gives you a namedtuple | 12:54 |
| Chipaca | the 'query' element therein, you extract with parse_qsl | 12:54 |
| Chipaca | ... | 12:54 |
| * Chipaca just realized he was reading the code :) | 12:54 | |
| nessita | beuno: I learnt some web programming today! :-D | 12:55 |
| Chipaca | nessita: we'll have you doing Plone in no time! | 12:56 |
| * nessita fades | 12:56 | |
| fagan | moi | 13:00 |
| alecu | #nessita { opacity: 0; } | 13:00 |
| fagan | ralsina, dobey, alecu, nessita, gatox standup | 13:01 |
| gatox | me | 13:01 |
| ralsina | me | 13:01 |
| nessita | oh, standup, no notes for me yet, I will go last | 13:02 |
| fagan | ill go the others can catch up | 13:02 |
| fagan | DONE | 13:02 |
| fagan | * a bit of reading | 13:02 |
| fagan | TODO | 13:02 |
| fagan | * checking up on recent bugs | 13:02 |
| fagan | BLOCKED | 13:02 |
| fagan | * Nope | 13:02 |
| fagan | gatox: go | 13:02 |
| gatox | DONE: | 13:02 |
| gatox | https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/bug-820872/+merge/71774 and https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/bug-820872/+merge/71773 COMPLETE. Second one finishing some additional tests. | 13:02 |
| nessita | me | 13:02 |
| gatox | TODO: | 13:02 |
| gatox | finish some work in installer UI bugs | 13:03 |
| gatox | BLOCKED: | 13:03 |
| gatox | no | 13:03 |
| gatox | ralsina, go | 13:03 |
| ralsina | DONE: reviews, calls, worked some more on my pending branches. TODO: merge them, hopefully make u1cp do the right thing when there are no credentials BLOCKED: no | 13:03 |
| ralsina | nessita? | 13:03 |
| nessita | DONE: bug #827343, reviews | 13:03 |
| nessita | TODO: control panel UI tweaks, more reviews | 13:03 |
| nessita | BLOCKED: nopes | 13:03 |
| nessita | NEXT: dobey? alecu? | 13:03 |
| ubot4 | Launchpad bug 827343 in ubuntuone-client "Send platform details when pinging for credentials (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/827343 | 13:03 |
| alecu | me | 13:04 |
| alecu | DONE: chased time.clock issues on VirtualBox; worked on fixing tests for the branch for bug #824819. Started looking at eq_inotify tests | 13:04 |
| alecu | TODO: fix the f*#@!ng test that's blocking the whole testrun, work on eq_inotify | 13:04 |
| alecu | BLOCKED: yes, please | 13:04 |
| ubot4 | Launchpad bug 824819 in ubuntuone-client "SD and tests need to wait until a watch is removed (affects: 1) (heat: 6)" [High,Triaged] https://launchpad.net/bugs/824819 | 13:04 |
| nessita | alecu: did upgrading VB helped? | 13:04 |
| alecu | nessita, no, it does the same. It seems to do it less often though, but it still keeps the clock quiet sometimes | 13:05 |
| alecu | nessita, the only way I found was to add a small "time.sleep" whenever we are calling time.clock :P | 13:06 |
| nessita | alecu: can you somehow workaround this locally to unblock? I mean, what concrete symptom are you having? | 13:06 |
| alecu | nessita, but this is not the root cause of the test that's blocking. The clock issue is a sideturn I took while debugging tritcask tests that use it | 13:07 |
| dobey | me | 13:07 |
| nessita | dobey: go! | 13:07 |
| dobey | λ DONE: bug #827519, discussion on #817133 and #820345 | 13:07 |
| dobey | λ TODO: finish bug #817133, chat with lisette | 13:07 |
| dobey | λ BLCK: None. | 13:08 |
| ubot4 | Launchpad bug 827519 in ubuntuone-installer "don't add the stable ppa (affects: 1) (heat: 6)" [High,Fix committed] https://launchpad.net/bugs/827519 | 13:08 |
| ubot4 | Launchpad bug 817133 in ubuntu "[FFe] [needspackaging] ubuntuone-installer needs packaged (affects: 1) (heat: 12)" [High,Incomplete] https://launchpad.net/bugs/817133 | 13:08 |
| nessita | alecu: ok, so feel free to "drop" the tritcask issue for now | 13:08 |
| alecu | nessita, the test that blocks right now just blocks the whole test run when running "run_test.sh" | 13:08 |
| nessita | alecu: which one is it? | 13:08 |
| alecu | nessita, but it works fine if I run just that test file | 13:09 |
| nessita | alecu: is it something in test_vm? | 13:09 |
| alecu | nessita, no, it's in test_sync | 13:09 |
| alecu | nessita, most of test_vm is running fine on trunk | 13:09 |
| alecu | nessita, let me push it, and I'll ask you to run it to see if it hangs like here. | 13:10 |
| nessita | alecu: sure! | 13:10 |
| alecu | nessita, lp:~alecu/ubuntuone-client/watch-finished-deferred | 13:11 |
| nessita | branchinf | 13:11 |
| alecu | nessita, run_tests -t test_sync works | 13:11 |
| alecu | nessita, but just "run_tests" hangs up on test_sync.runTest :-( | 13:12 |
| beuno | nessita, that'll come in hadny for your rotation *wink* | 13:12 |
| dobey | _ != - | 13:12 |
| nessita | alecu: FYI: | 13:13 |
| nessita | Text conflict in tests/platform/test_os_helper.py | 13:13 |
| nessita | 1 conflicts encountered. | 13:13 |
| nessita | alecu: can you please fix to ensure we run the same? | 13:13 |
| alecu | oh, sure | 13:14 |
| nessita | Chipaca: is there a cleaner way to solve http://pastebin.ubuntu.com/668248/? I don't like using '://' explicit, but the closest thing I found from urlparse is urlunsplit, but to use it in the test I should chopped off the query content from the ParseResult, which is not cleaner nor clearer, from my POV | 13:16 |
| alecu | nessita, fixed and pushed | 13:26 |
| nessita | alecu: re-branching! | 13:27 |
| alecu | nessita, I would not mind about the "://". Just make it a constant, as it would be rare for us to change protocols to something that does not use "://" | 13:27 |
| nessita | alecu: is a test, and is used in only one place, you think is worth making a constant? | 13:28 |
| alecu | mailto:ping@url or telnet:ping.url sounds unreasonable | 13:28 |
| alecu | nessita, then don't mind about it! | 13:28 |
| * nessita does not mind then | 13:28 | |
| nessita | Chipaca: fixed and pushed to revno 1112! | 13:28 |
| Chipaca | nessita: ok | 13:29 |
| Chipaca | nessita: I +1'ed it already | 13:29 |
| nessita | great! | 13:29 |
| nessita | alecu: run_tests -t test_sync, all green, going with the whole suite now | 13:31 |
| ralsina | nessita, Chipaca: I would like a review of https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/local-folder-fixes/+merge/71857 if you have a moment please | 13:31 |
| nessita | ralsina: sure! | 13:32 |
| nessita | alecu: run-tests finished: FAILED (skips=39, failures=9, errors=42, successes=2141) | 13:34 |
| nessita | alecu: what test in particular is being blocked for you? | 13:35 |
| alecu | nessita, test_sync.runTest | 13:35 |
| alecu | nessita, yes, runTest | 13:35 |
| nessita | hum, that's a setUp or tearDown being blocked | 13:35 |
| gatox | nessita, test added https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/bug-820872/+merge/71773 | 13:35 |
| nessita | alecu: can you add prints to setUp and tearDown to see where the runTest is being blocked? | 13:36 |
| alecu | nessita, I don't think so. I have put pdb.set_trace() in setup, teardown and an overloaded runtest, and it blocks there. | 13:36 |
| alecu | nessita, I can try that too | 13:37 |
| nessita | alecu: so, the runTest is run for every TestCase, which testcase is being blocked? we may wanna check that setUp and his parents, if any | 13:37 |
| nessita | ralsina: is there a testcase for FolderItem? | 13:41 |
| nessita | I can't find it myself | 13:41 |
| ralsina | nessita: not explicitly. It's old code, but I will add one. | 13:42 |
| nessita | ralsina: thanks! | 13:42 |
| nessita | please make sure to assert that: | 13:44 |
| nessita | - the checkstate is unchecked | 13:44 |
| nessita | - the volume id is the one passed as parameter | 13:44 |
| nessita | - the thread is started if calculate is True, not started if not | 13:44 |
| nessita | - size is None if calculate, 0 if not | 13:44 |
| nessita | Also, I would advice moving the self.thread assignment outside the if-else since is the same one no matter the value of calculate | 13:44 |
| nessita | (I'm adding this to the MP) | 13:45 |
| nessita | Chipaca, ralsina: are we mumbling today? | 13:46 |
| ralsina | nessita: instead of a testcase, would it be ok if I add tests in LocalFolders testcase? FolderItem is mostly an implementation detail for that class | 13:47 |
| nessita | ralsina: recommended approach is to have at least a TestCase per each class | 13:48 |
| ralsina | ok | 13:48 |
| nessita | ralsina: so we can split it out if needed, or if we add more logic we can isolate that | 13:48 |
| nessita | also, is better for the next one who tries to find the tests | 13:48 |
| nessita | to either understand who that class is used, or add more tests, et | 13:49 |
| nessita | c | 13:49 |
| === m_conley_away is now known as m_conley | ||
| nessita | alecu: any news? | 14:00 |
| alecu | nessita, I've checked the parents, and no news. And since when running alone it passes fine, I'm suspecting one of the previous tests is leaving some broken state. | 14:01 |
| alecu | nessita, so right now I'm deleting one by one the previouses .py testfiles and running run_tests again | 14:02 |
| nessita | ralsina: I made more comments in the MP, but I paused the review so we can have some checkpoints to avoid confusion about what's fixed and what's pending. | 14:10 |
| ralsina | nessita: ok | 14:10 |
| nessita | gatox: re-reviewing yours now | 14:11 |
| gatox | nessita, ok | 14:11 |
| nessita | gatox: on a qss, shall I set font sizes in px or pts? | 14:11 |
| gatox | nessita, i do it in px | 14:12 |
| nessita | gatox: lisseeeeete asked me to set control panel font to 13px, not sure if that is correct | 14:12 |
| gatox | nessita, yes, i'm using font-size with px | 14:12 |
| ralsina | nessita: about self.assertFalse(self.ui.folders_info is None) I am asserting that because get_info is *not* finished, because it's a deferred. | 14:12 |
| nessita | ack, thanks | 14:12 |
| nessita | ralsina: but... folder_info can be None, right? | 14:13 |
| nessita | you're asserting is not None | 14:13 |
| nessita | or am I missing something? | 14:13 |
| ralsina | oops, read it the wrong way. get_info is calling a fake deferred that succeeds immediately | 14:13 |
| ralsina | so, shouldn't that always be a value? | 14:14 |
| nessita | ralsina: answer is "so". Let me explain: | 14:14 |
| ralsina | the bad part is I can't make initializePage be a generator because it's called by PyQt so can't be a generator, so I should probably go the other path you suggest | 14:14 |
| nessita | ralsina: I think that's the best option, because otherwise, someone who reads that test may think that we ensure that when initializePage ends, folder_Info is not None, which in practice is not True | 14:15 |
| ralsina | ok, makes sense | 14:15 |
| nessita | gatox: question, were the changes to the ui in the branch before? I think they weren't... | 14:18 |
| ralsina | about the join(): I am making sure the thread is not running because if it is, it will overwrite the item.size later. | 14:18 |
| nessita | gatox: but please correct me | 14:18 |
| * gatox looking... | 14:18 | |
| nessita | ralsina: what if the thread was not running and you join it? can that fail? /me does not know | 14:18 |
| ralsina | nessita: OTOH, that thread should not be started, so removing | 14:18 |
| ralsina | if a thread is not running, join returns immediately | 14:19 |
| gatox | nessita, nop....... sorry... reverting... | 14:19 |
| nessita | ralsina: can we start a thread already joined? | 14:19 |
| ralsina | nessita: sure | 14:20 |
| ralsina | yikes, I was not using the "calculate" parameter if it was a UDF, so the thread was started. | 14:21 |
| alecu | nessita, ralsina: why are we using threads in the Qt part? | 14:21 |
| ralsina | alecu: calculate disk usage of folders in a non-blocking way | 14:21 |
| alecu | ralsina, do we have the qt reactor running there? | 14:22 |
| ralsina | alecu: yes | 14:23 |
| gatox | nessita, done | 14:23 |
| alecu | ralsina, what api are we using to open that thread? | 14:23 |
| ralsina | alecu: python's threading | 14:23 |
| ralsina | alecu: I wish I could use QThread, but we can't | 14:23 |
| alecu | ralsina, perhaps it would make sense to use the twisted threading | 14:23 |
| ralsina | alecu: big point for using threading: I already wrote it ;-) | 14:24 |
| alecu | ralsina, my point is that we are not sure if threading conflicts with twisted threading on windows. | 14:24 |
| ralsina | alecu: ugh | 14:24 |
| alecu | d=reactor.deferToThread(calculate_disk_space) | 14:25 |
| alecu | d.addCallback(disk_space_returned_something) | 14:25 |
| ralsina | alecu: still ugh because I have the code here and it works :-( | 14:25 |
| alecu | d.addErrback(disk_space_failed_and_heres_the_exception) | 14:25 |
| ralsina | and it has been there for a month or so | 14:25 |
| nessita | alecu: good point! | 14:25 |
| alecu | ralsina, ok, if it works, don't fix it! | 14:26 |
| nessita | alecu, ralsina: let's file a bug for this and try to schedule this some time in the near future | 14:26 |
| nessita | alecu: can you please fill the bug? | 14:26 |
| ralsina | fine by me | 14:26 |
| alecu | nessita, ralsina: I'm pointing this, because I hate joins | 14:26 |
| ralsina | alecu: there are no more joins :-) | 14:27 |
| alecu | ralsina, cool then. | 14:27 |
| nessita | alecu: me too, and since ATM very few people is running this, we can't ensure we won t have issues there | 14:27 |
| * ralsina points out that rewriting things that are not kown to be broken is very non-TDD | 14:28 | |
| nessita | ralsina: right, but is good to know that we may have weird issues and they may be caused by threads misbehaving in windows | 14:29 |
| ralsina | nessita: sure, we can keep that in mind | 14:29 |
| nessita | gatox: looks good! though, question: you alse reverted the changes to the qss... I don't think taht's right | 14:32 |
| nessita | gatox: there was a new style for form errors? | 14:32 |
| alecu | ugh | 14:33 |
| nessita | alecu: I'm afraid to ask, but.. yes? | 14:33 |
| gatox | nessita, oh crap... yes, you are right..... | 14:33 |
| * gatox is working with form errors everywhere | 14:33 | |
| alecu | nessita, we are using python threads in syncdaemon too. | 14:33 |
| nessita | alecu: what for? | 14:33 |
| alecu | nessita, in hash_queue and the windows NetworkManager | 14:33 |
| alecu | nessita, I've already asked in #chicharra about the hash_queue, and we'll have to wait for mandel to ask about the windows NetworkManager | 14:34 |
| nessita | alecu: let's fill bug, there's much we can do right now today | 14:34 |
| nessita | there isn't much* ;-) | 14:34 |
| gatox | nessita, done | 14:34 |
| nessita | oook | 14:35 |
| nessita | gatox: approved, please seek another review | 14:37 |
| gatox | nessita, | 14:38 |
| gatox | ok | 14:38 |
| gatox | alecu, ralsina can you review this branch? https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/bug-820872/+merge/71773 | 14:39 |
| ralsina | gatox: sure! | 14:39 |
| gatox | ralsina, thanks! | 14:39 |
| ralsina | nessita: answered comment, pushed fixes | 14:57 |
| ralsina | now let's look at gatox's branch1 | 14:57 |
| nessita | ralsina: ack, I will re-review in 15 minutes~ | 14:58 |
| ralsina | gatox: shouldn't that fix for critical be done also in sso-client? | 15:00 |
| nessita | ralsina: is done and merged | 15:01 |
| gatox | ralsina, yes...... that branch was merge already | 15:01 |
| ralsina | oh, ok, forgot about it | 15:01 |
| ralsina | then it | 15:01 |
| ralsina | 's a+1 | 15:01 |
| gatox | ralsina, cool | 15:01 |
| dobey | hmm | 15:02 |
| dobey | lunch time, bbiab | 15:14 |
| nessita | ralsina: I just requested the swap day for next MOnday. gatox will do the same, but he's defining which day will swap the holiday to | 15:14 |
| ralsina | nessita: so both of you and mandel will be here on monday? | 15:15 |
| gatox | ralsina, yes | 15:16 |
| nessita | ralsina: yeap, gatox needs the holidays for pycon and/or christmas break... | 15:16 |
| ralsina | gatox, nessita: cool, I'll approve later today | 15:16 |
| nessita | great | 15:16 |
| ralsina | for pycon we can use conference days, can't we? | 15:16 |
| gatox | ralsina, i think i don't have conference days | 15:16 |
| ralsina | gatox: I am not sure you have any conference days until after the probation though | 15:16 |
| nessita | ralsina: yes, but seems like gatox has none... | 15:16 |
| ralsina | yes, on probation there are no holidays/conference days | 15:17 |
| gatox | ralsina, ahhhh, that make sense | 15:17 |
| ralsina | I'm off for a (today) shortish lunch. See you people in about 40 minutes. | 15:37 |
| nessita | alecu: you still blocked? :-/ | 15:57 |
| alecu | nessita, I found that by erasing test_filesystem_notifications.py all the tests pass, and now I'm bisecting inside that. | 16:03 |
| nessita | alecu: the windows version or the multiplatform onw? | 16:04 |
| alecu | nessita, the windows one | 16:04 |
| nessita | alecu: let me know if I can help debug | 16:05 |
| alecu | thanks | 16:05 |
| nessita | lunchtime for me! | 16:34 |
| ralsina | and back, with belly full | 16:35 |
| === beuno is now known as beuno-lunch | ||
| nessita | ralsina: for future coding (no need to change it now), is recommended to call the addCleanup right after the sentence that makes the env "dirty". What I mean is, ideally right after creating a file, for example, we would add the self.addCleanup call | 16:57 |
| ralsina | nessita: ok, I can move it before merging the branch, so I don't make the diff change | 16:57 |
| nessita | ralsina: one thing I will ask you to fix is that this call: | 16:58 |
| nessita | self.addCleanup(lambda: shutil.rmtree(self.tmpdir)) | 16:58 |
| nessita | should be: | 16:58 |
| nessita | self.addCleanup(shutil.rmtree, self.tmpdir) | 16:58 |
| nessita | you can fix that later as well | 16:58 |
| ralsina | ok, will do both things together | 16:58 |
| nessita | thanks | 16:58 |
| gatox | ralsina, please correct me if i'm wrong... but there is no chance to detect focus in and focus out event except that with eventFilter, isn't it? | 17:05 |
| gatox | (i', talking about qlineedit) | 17:05 |
| ralsina | gatox: if you set eventTracking, I think there is, let me check | 17:05 |
| ralsina | you want focus events, or mouse hover events? | 17:06 |
| gatox | focus | 17:06 |
| ralsina | focusInEvent() | 17:06 |
| ralsina | focusOutEvent() | 17:06 |
| nessita | ralsina: question: I see that the mocked info for volumes_info has 3 items in it, where 2 of them are UDFs; but the test_status_after_get_info checks against 5 top level item count. Which ones are the other 3? | 17:07 |
| alecu | I think I foooooooooound it.... | 17:07 |
| ralsina | nessita: the default folders (music docs pictures) | 17:07 |
| nessita | alecu: tell us!!! | 17:07 |
| gatox | yes...... but i'm using a simple qlineedit inside another widget....... so i should do lineEdit.installEventFilter(self)..... i ask because i know you don't like eventFilter :P | 17:07 |
| nessita | ralsina: ack | 17:07 |
| alecu | I think it was a missing "yield" in test_add_single_watch. | 17:07 |
| ralsina | gatox: which means inheriting unless it's an enhancedlineeedit | 17:07 |
| alecu | I'm testing it all together now. | 17:07 |
| ralsina | gatox: indeed I don't ;-) | 17:08 |
| nessita | ralsina: is there any test for the adding of those default folders? | 17:08 |
| nessita | (I want to follow it in the code, if there is any) | 17:08 |
| alecu | fuck | 17:08 |
| nessita | alecu: no? :-/ | 17:08 |
| ralsina | nessita: well, it's checked that they are added (or else there would be only 2), but the function that tells you what they are is going away | 17:08 |
| alecu | no, it was not a missing yield | 17:08 |
| gatox | ralsina, right..... i was reviewing my options...... because it will be inherit just for focusInEvent and focusOutEvent, and i'll need to replace the components in the UI as promotedWidgets | 17:08 |
| nessita | ralsina: not sure I understand. What function is going away? default_folders? | 17:09 |
| ralsina | gatox: let me research 5'. If I don't find an alternative, I'll give you a eventFilter exception :-) | 17:09 |
| alecu | it's an ugly monkeypatch that's not restored :-( | 17:09 |
| ralsina | nessita: yes, it will use the function that's in xdg.basedirectory instead | 17:09 |
| nessita | alecu: is a call to pacth? | 17:09 |
| alecu | nessita, no | 17:09 |
| alecu | Watch.start_watching = start_watching | 17:09 |
| nessita | guh! | 17:10 |
| nessita | ralsina: but, the default_folders will remain in place, just the implementation will change, right? | 17:10 |
| alecu | nessita, it seems mandel only learned about trial.patch pretty recently :-( | 17:10 |
| dobey | ralsina: what should we do about pyxdg? | 17:10 |
| ralsina | nessita: yes, it will just return three paths from the other function | 17:10 |
| gatox | ralsina, or i can create an enhanced lineedit..... and maybe include some generic logic inside there to check if they are valid and so..... it's not a problem | 17:11 |
| gatox | ralsina, what you think is best | 17:11 |
| ralsina | gatox: http://doc.qt.nokia.com/latest/qapplication.html#focusChanged | 17:11 |
| ralsina | so no eventFilter for you ;-) | 17:11 |
| nessita | ralsina: so we do need a test to confirm that default_folders is returning what it should, not matter what implementation has. Is that test in the suite already, or shall we add a bug for it? | 17:11 |
| alecu | damn, damn, damn the little childrens | 17:12 |
| gatox | ralsina, jeje ok | 17:12 |
| ralsina | nessita: it makes more sense to add that test in xdg when it's done, right? | 17:12 |
| ralsina | dobey: good question, didn't have time to do anything about it yet :-( | 17:12 |
| alecu | nessita, I ended up deleting every test_*.py file except the two involved: test_file_notifications.py and test_sync.py | 17:13 |
| alecu | nessita, and then commenting the test functions inside there... | 17:14 |
| nessita | ralsina: so, we need at least 2 (group of) tests: one in u1client when fixing xdg, and another (very likely not the same one) in windows-installer for the default_folders method. This ensures that no matter the implementation of default_folders, we ensure the correctness of the method in installer | 17:14 |
| alecu | this's been hell :-( | 17:14 |
| nessita | alecu: I can certainly imagine... :-( | 17:14 |
| nessita | ralsina: I meant: "no matter the implementation of xdg methods..." | 17:14 |
| ralsina | nessita: not saying not to test the pathsm but there isn't much to check in those paths, since they can be lliterally anything | 17:15 |
| nessita | ralsina: that's why inside installer we should not depend on anything in particular but we very likely patch xdg with fixed paths and assert over that | 17:15 |
| nessita | but we need test(s) for default_folders | 17:16 |
| ralsina | nessita: not sure what to test beyond "it's three strings" | 17:16 |
| nessita | ralsina: I agree we can add them in an incoming branch, but I want to be sure we're in sync | 17:16 |
| ralsina | nessita: no, I will add it I just am not sure what to test for | 17:16 |
| nessita | ralsina: so, consider this scenario: someone comes and see the default folder implementarion and removes the calls to xdg (or whatever we use) and replace that by the returning of a fixed list with 3 things in it, ['casa', 'perro', 'gato']. We need a test failing because the content of the result, despite having the proper lenght, is not the expected | 17:17 |
| nessita | ralsina: I know no one will approve such a branch, but is a silly example trying to show what you need to test | 17:18 |
| ralsina | but that is not actually a wrong result (except that they are not absolute paths) | 17:18 |
| nessita | ralsina: it's if I actually use the string 'casa', 'perro' and 'gato' | 17:18 |
| nessita | we want to ensure the contents are exactly 'My Documetns' and all, where 'My Documents' is not a literal string but something that we patch inside the underlying libraries | 17:19 |
| ralsina | nessita: you can change your documents path to be "c:\users\casa" (or pretty much any other path) | 17:19 |
| ralsina | nessita: http://www.online-tech-tips.com/computer-tips/how-to-move-or-change-the-location-of-my-documents-folder/ | 17:19 |
| nessita | ralsina: yes, but that's no the point | 17:19 |
| ralsina | nessita: sorry, I still don't get it | 17:20 |
| nessita | ralsina: assume you have not changed any document path nor name, but I go and change the implementation of default_folder to return a fixed list, always the same | 17:20 |
| nessita | no matter what system we're in, we return 'casa', 'perro' and 'gato' | 17:20 |
| ralsina | can we use "c:\casa" in your example? Because I do know those have to be absoute paths. | 17:22 |
| nessita | ralsina: no, we can't. I'm evil and I changed default_folders to return [object(), {}, urlparse.urlparse('http://example.com')] | 17:22 |
| nessita | ralsina: what test will fail in that case? | 17:23 |
| ralsina | nessita: ok, I can test that they are 3 strings that represent absolute paths. | 17:23 |
| ralsina | so it will fail that test. | 17:23 |
| nessita | ralsina: what if I change the implementation to return: | 17:23 |
| nessita | ['i', 'want', 'icecream'] | 17:24 |
| ralsina | those are not absolute paths | 17:24 |
| nessita | your test will no longer fail | 17:24 |
| nessita | ok, what if: | 17:24 |
| nessita | ['e:\i', 'f:\want', 'z:\icecream'] | 17:24 |
| nessita | ralsina: the point is you need to assert about the contents of the list | 17:25 |
| ralsina | thoat is a valid value for default_folders() so it should not fail | 17:25 |
| nessita | no, is not valid | 17:25 |
| ralsina | yes they are :-) | 17:25 |
| nessita | valid results are those returned by xdg when queried for special folders | 17:25 |
| ralsina | nessita: xdg can return that | 17:25 |
| nessita | ralsina: as long as the user has those, which in my case is not true | 17:25 |
| ralsina | nessita: no, it can return that even if they don't exist | 17:26 |
| nessita | ralsina: in which case? | 17:26 |
| ralsina | You can change your "My Documents" folder to any path. Say, on a removable drive. And then unplug it. | 17:26 |
| ralsina | It is an *unusual* value? Yes. Is it invalid? No. | 17:26 |
| nessita | ralsina: yeah, but that is not the point!!! | 17:27 |
| nessita | ralsina: let's mumble | 17:27 |
| ralsina | nessita: which is why I say I don't get the point yet | 17:27 |
| ralsina | sure | 17:27 |
| alecu | nessita, I'm not sure I get this either | 17:27 |
| alecu | nessita, can you sketch some code for how the unittest would work? | 17:28 |
| ralsina | nessita: just as a sidenote it is trivial to create a reimplementation of a function that passes all tests and does nothing useful. It should only record all side effects and return values for each set of input data of the original function, then replay them when tested. Unless you randomize your inputs, of course ;-) | 17:43 |
| ralsina | and throw exceptions on all unknown input combinatios, just for fun | 17:43 |
| nessita | ralsina: that is true for some cases, is not for some others | 17:44 |
| nessita | when TDDing "sum", is very easy not to cover all cases (almost mandatory) so you can certainly do that | 17:44 |
| ralsina | nessita: it's true for all programs written in a turing-complete language. | 17:44 |
| nessita | no, if you test some function was called with some parameters, you can not fake that in your implementation, you will have to actually call the thing | 17:45 |
| ralsina | except, if you test for all valid imput cmbinations, yes, the result is a vlid implementation | 17:45 |
| ralsina | nessita: yes, I can fake it. I will only call it when the input data is the exact data you used in the tests. If it's different, I will not call it. | 17:46 |
| ralsina | Proof: I can just embed the original function. If the input is the one used in the tests, pass it. If no, raise DivideByZero ;-) | 17:47 |
| nessita | ralsina: I would love if you could use all that energy you're investing in thinking how to break tests to build robust tests :-) | 17:48 |
| ralsina | nessita: I am writing the test, this is old stuff I know from before ;-) | 17:49 |
| ralsina | nessita: just trying to show you that "what if we change the implementation to return fluffy bunnies" has limited persuasion value ;-) | 17:49 |
| nessita | ok, duly noted | 17:50 |
| === beuno-lunch is now known as beuno | ||
| nessita | ralsina: going back to your branch: can you please explain why there is no more need to call join on the calculating threads? | 17:52 |
| ralsina | in the join you mentioned before? Because for UDFs the thread is not started. | 17:52 |
| ralsina | And there is a test that it's not started, too. | 17:52 |
| ralsina | And for non-udfs, I want to let it calculate | 17:53 |
| nessita | ralsina: no, joins in general. I understood we were no longer joining no thread... | 17:53 |
| nessita | ralsina: are we joining the threads that are run? | 17:53 |
| ralsina | nessita: they end eventually. | 17:53 |
| ralsina | nessita: when they end, they push the result into a Queue and we pick it | 17:53 |
| nessita | ralsina: but we need to join them the same, no? at least in C we need to, not sure in python | 17:54 |
| nessita | alecu: ^ | 17:54 |
| ralsina | Not on python | 17:54 |
| ralsina | join() just waits until they end | 17:54 |
| ralsina | AFAIK, that is | 17:54 |
| nessita | in C, join also releases all the resources the thread has | 17:55 |
| ralsina | these threads have no local resources | 17:55 |
| * nessita reads the python doc | 17:55 | |
| ralsina | s/local/thread-local/ up there | 17:56 |
| Chipaca | nessita: could you look at your msdn downloads page and see if it's working for you? | 17:57 |
| nessita | ralsina: what would happen if we quit the app before each thread finishes? | 17:57 |
| nessita | Chipaca: sure! | 17:57 |
| ralsina | nessita: the threads will end, because they are daemon threads | 17:57 |
| Chipaca | nessita: also what browser you use to check :) | 17:57 |
| nessita | Chipaca: argh, can't remember password, on sec | 17:59 |
| ralsina | nessita: pushed the discussed test for special_folders | 18:01 |
| nessita | Chipaca: have the url handy? | 18:01 |
| nessita | ah, I foun it | 18:01 |
| nessita | Chipaca: I can browse https://msdn.microsoft.com/en-us/subscriptions/securedownloads/default.aspx with firefox, want me to try a download? | 18:02 |
| Chipaca | nessita: but does it give you a key? | 18:02 |
| nessita | Chipaca: all downloads are "unavailable" | 18:03 |
| Chipaca | right, same here | 18:04 |
| Chipaca | sigh | 18:04 |
| nessita | did it expire? | 18:04 |
| nessita | alecu: I will be leaving to uni in 30 minutes, would you please send a report when your day finished, about accomplishments and status so we i can coordinate mandel's work on monday? (and know where things were left) | 18:06 |
| ralsina | nessita: before you leave, can we mumble 5' so you can give me some hints re: bug #828170 ? | 18:08 |
| ubot4 | Launchpad bug 828170 in ubuntuone-control-panel "On windows, the control panel fails without credentials (affects: 1) (heat: 6)" [Critical,Triaged] https://launchpad.net/bugs/828170 | 18:08 |
| nessita | ralsina: I can implement that tomorrow, if you want | 18:09 |
| ralsina | nessita: you are going to need some support on the installer's side of things, I suspect. | 18:09 |
| nessita | ralsina: why? | 18:09 |
| ralsina | So for example, you don't get the license page | 18:09 |
| nessita | ralsina: last mock from design did not involve the installer | 18:09 |
| ralsina | oh | 18:09 |
| ralsina | and what will you use? | 18:09 |
| nessita | a screen offering the user to login | 18:10 |
| nessita | with a design fitting the control panel design | 18:10 |
| ralsina | I imagined as much, but are we doing *another* sso ui? | 18:10 |
| nessita | so it stays all within the same project | 18:10 |
| nessita | ralsina: no, I will be using SSO UI | 18:10 |
| nessita | bah, what do you mean with another? | 18:11 |
| ralsina | have you seen the UI provided by SSO without tweaks? | 18:11 |
| nessita | ralsina: no, but I was planning on fixing that as well | 18:11 |
| ralsina | ok | 18:11 |
| ralsina | one thing less for me to look at then | 18:11 |
| nessita | ralsina: want a bug report as a suggestion? :-) | 18:11 |
| ralsina | nessita: sure | 18:12 |
| ralsina | nessita: if you think you are going to integrate SSO into u1cp and fix its UI in one day, I suspect you are being wildly optimistic. | 18:12 |
| nessita | I know :-) | 18:13 |
| nessita | ralsina: are we embedding payments somehow in the installer? | 18:13 |
| ralsina | No | 18:13 |
| nessita | great | 18:13 |
| ralsina | There is a button that sends you to the page | 18:13 |
| nessita | ralsina: right. I have 2 proposals: either implementing the special_folders in xdg. and/or moving the folder validation to syncdaemon | 18:14 |
| ralsina | nessita: I take the xdg thing. The other sounds painful. | 18:14 |
| ralsina | Plus, it would mean branches in u1-client u1cp and u1-installer | 18:14 |
| dobey | well *windows*-installer ;) | 18:15 |
| ralsina | dobey: good point! | 18:15 |
| nessita | gatox, ralsina: I would love to have some reviews for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/ui-style-fixes/+merge/71928 | 18:17 |
| ralsina | nessita: got it | 18:17 |
| gatox | nessita, on it | 18:17 |
| dobey | i think i need a drink | 18:20 |
| nessita | ralsina: if you have more slots, you can also do https://code.launchpad.net/bugs/827465, which is easy but High | 18:22 |
| ubot4 | nessita: Error: Bug #827465 is private. | 18:22 |
| ralsina | nessita: in line 70: instad of setting maximum heights, you should set the vertical policy to minimum | 18:22 |
| ralsina | and then set the height of the inner widgets + paddings | 18:23 |
| ralsina | nessita: usually, fixed pixel sizes on anything but padding is not a good idea | 18:23 |
| gatox | nessita, if you set the maximum size to 16px..... is it necessary to use fixed policy? | 18:25 |
| ralsina | gatox: either that r set the miimum to 16px too | 18:25 |
| ralsina | Also, ask dobey how a 13px font looks on his notebook ;-) | 18:25 |
| ralsina | but I know where that came from, so it's ok to leave it on | 18:26 |
| dobey | 13px or pt? | 18:27 |
| ralsina | px | 18:27 |
| ralsina | I am guessing it comes to between gnat and half-gnat :-) | 18:27 |
| gatox | nessita, looks fine by me! | 18:28 |
| dobey | it looks like anything else that takes up 13 pixels in the vertical direction, i guess :) | 18:28 |
| ralsina | dobey: care to offer a guss in millimeters? ;-) | 18:28 |
| ralsina | btw: 13px font glyphs usually are about 9px tall in average | 18:29 |
| dobey | i don't know how tall my screen is in mm | 18:29 |
| ralsina | I can take 256ths of inches | 18:29 |
| nessita | ralsina: that did not work, I tried it... | 18:29 |
| dobey | but i mean, 13px will look small on even my workstation | 18:29 |
| nessita | ralsina: I can try again, but later today, I'm leaving running | 18:29 |
| ralsina | nessita: will leave it in the MP then | 18:30 |
| nessita | ralsina: add those notes to the MP and I will take care of them after teaching | 18:30 |
| nessita | right | 18:30 |
| nessita | ralsina: I will also finish your review later today | 18:30 |
| nessita | bye all! | 18:30 |
| ralsina | nessita: cool, thx. Bye! | 18:30 |
| dobey | on my workstation, 9 px would be about 2.5 mm | 18:31 |
| dobey | that's on my workstation | 18:31 |
| dobey | on my laptop, maybe 1 mm if lucky | 18:33 |
| ralsina | ok, so I hope you are not planning to use ubuntu one when we switch to qt :-( | 18:35 |
| dobey | i don't even use the control panel now :) | 18:44 |
| ralsina | gatox: do you have the "uninstall on cancel" bug queued? | 18:53 |
| gatox | yes.... after this branch probably... you told me that the uninstall bug depends on something else, don't you? | 18:54 |
| gatox | ralsina, ^ | 18:55 |
| ralsina | turns out it doesn't :-) | 18:56 |
| ralsina | gatox: all you have to do is call "uninstaller --mode=qt" and it does *exactly* what we want | 18:56 |
| gatox | ralsina, ok... i'll start working on that after this branch! :D | 18:56 |
| gatox | awesome | 18:56 |
| ralsina | you don't have to code anything | 18:56 |
| gatox | ralsina, more awesome! jeje | 18:56 |
| ralsina | or nothing beyond a call to Popen :-) | 18:57 |
| gatox | ralsina, yes | 18:57 |
| gatox | :P | 18:57 |
| ralsina | If you have the bug# handy I will post that there | 18:57 |
| gatox | ralsina, ok.... i'm finishing with this, and then i'll do that | 18:57 |
| * gatox looking... | 18:57 | |
| gatox | ralsina, https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/823414 | 18:58 |
| ubot4 | gatox: Error: Bug #823414 is private. | 18:58 |
| ralsina | gatox, cool, commenting | 18:58 |
| dobey | i think maybe i should go get some snackification | 19:01 |
| nhaines | dobey: is your snack indicator blue? :) | 19:02 |
| dobey | it's NIR | 19:04 |
| dobey | brb, must get snacks | 19:06 |
| ralsina | gatox: do we still have a "start syncdaemon on login" checkbox somewhere? | 19:08 |
| gatox | ralsina, that should be added in congratulations | 19:09 |
| gatox | one of the branches i need to start too | 19:09 |
| ralsina | I will do it now then | 19:09 |
| ralsina | but ... not starting syncdaemon makes no sense :-) | 19:10 |
| gatox | ralsina, yes | 19:10 |
| ralsina | gatox: do you have a bug for it? | 19:10 |
| ralsina | I have bug #826728 for the functionality but none for the ui | 19:10 |
| ubot4 | Launchpad bug 826728 in ubuntuone-windows-installer "wizard should add syncdaemon to autostart (affects: 1) (heat: 52)" [High,Triaged] https://launchpad.net/bugs/826728 | 19:10 |
| gatox | ralsina, let me check | 19:10 |
| gatox | ralsina, https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/827365 | 19:11 |
| ubot4 | Launchpad bug 827365 in ubuntuone-windows-installer "Add functionality to Congratulations page checkboxes (affects: 1) (heat: 6)" [Undecided,New] | 19:11 |
| ralsina | ok | 19:13 |
| ralsina | thanks! | 19:13 |
| gatox | ralsina, review please: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 | 19:36 |
| gatox | ralsina, now i have to leave, but i'll leave the computer on, so if you have any comment to this branch please let me know or leave a comment in the merge proposal :D | 19:37 |
| ralsina | gatox: will do! | 19:41 |
| dobey | still no love | 19:45 |
| dobey | i hate waiting | 20:05 |
| === m_conley is now known as m_conley_away | ||
| === yofel_ is now known as yofel | ||
| nessita | ralsina: hi there! I replied to the MP... there is a spec and a bug report requesting the 30px height... what shall we do? | 21:19 |
| nessita | ralsina: I can revert that bit so we can land this | 21:19 |
| ralsina | nessita: I mailed you and lisette. We should argue a tiny bit about it tomorrow morning, and then see | 21:19 |
| ralsina | we can land it tomorrow. Or we can even land it with that, it's just that if we start setting pixel sizes everywhere it's going to be a pain in the future | 21:20 |
| nessita | ralsina: I would like to land it today so I can start a fresh branch tomorrow. I'm happy reverting the fixed size if you'd like | 21:20 |
| ralsina | nessita: nah, let's just push it accoring to spec, and later on, if we change the spec, we will have to review all .ui files anyway | 21:21 |
| ralsina | nessita: I'll change that to approved | 21:21 |
| ralsina | luckiy detecting all the things that have fixed sizes is easy :-) | 21:21 |
| nessita | yeah there are several fixed heights (I will bring them up tomorrow then) | 21:22 |
| ralsina | nessita: got a link to the MP handy? | 21:22 |
| nessita | https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/ui-style-fixes/+merge/71928 | 21:22 |
| ralsina | nessita: there, approved in general | 21:23 |
| ralsina | nessita: if you have 5' could you check an email I sent about the congratulations page? | 21:23 |
| nessita | yes, sure | 21:24 |
| dobey | have a good evening all! | 21:32 |
| ralsina | bye dobey! | 21:32 |
| nhaines | dobey: bye! | 21:34 |
| nessita | ralsina: so, I read the email, and while answering, I realized I was confused: we have 2 pending stuff to do regarding credentials and control panel: | 21:34 |
| nessita | * what you said today, about starting the control panel without credentials, that I confused with the following: | 21:34 |
| nessita | * what page to show when the user removes the current device, and for this we do have a simple workflow where we only offer to login. | 21:34 |
| nessita | So, to implement (1), I think the following: | 21:35 |
| ralsina | just login so we don't mix metadata from two accounts, right? | 21:36 |
| nessita | exactly | 21:36 |
| nessita | * we should provide a single icon in the desktop, which will execute a python script that will check if there are credentials. If there are, we can start the control panel directly, if they are not, we start the wizard. What do you think? | 21:36 |
| ralsina | nessita: that sounds easy to implement | 21:37 |
| nessita | what I mean is, the "Ubuntu One"program as such has the intelligence to show one or the other | 21:37 |
| ralsina | Right | 21:37 |
| ralsina | it will work weird if the user removes credentials manually but that's his own fault ;-) | 21:37 |
| nessita | so, to ease things, we can assume in the (windows for now) control panel that credentials are always there | 21:37 |
| nessita | shall I answer this? | 21:38 |
| ralsina | Currently, if there are credentials, the wizard jumps to the "computer to cloud" page. I could make it just exec control panel | 21:38 |
| ralsina | And then the wizard is that program already | 21:38 |
| nessita | ralsina: that would work indeed | 21:38 |
| nessita | and we never provide explictely an icon for launching the control panel | 21:39 |
| ralsina | it also has the code to exec control panel, so it's 5 lines or so | 21:39 |
| nessita | right? | 21:39 |
| ralsina | exactly | 21:39 |
| nessita | right | 21:39 |
| ralsina | how to translate that to linux is going to be a pain :-) | 21:39 |
| ralsina | or maybe not, we just have to think about that a bit | 21:39 |
| ralsina | Anyway, I think we have a plan :-) | 21:39 |
| ralsina | Yes, reply at least that we have talked about it and reached an agreement. OTOH, I really need input on the (I think) useless checkboxes. | 21:41 |
| nessita | yes, I have a answer to that | 21:42 |
| nessita | sending shortly | 21:42 |
| ralsina | And now I have to go play "Ben 10 Alien storm" on the Wii for an hour or so ;-) | 21:42 |
| alecu | nessita, ralsina: https://code.launchpad.net/~alecu/ubuntuone-client/watch-finished-deferred/+merge/71955 | 21:42 |
| alecu | ralsina, cool! | 21:42 |
| ralsina | alecu: saw it. Is that the one that made you curse mandel's ancestors? | 21:42 |
| alecu | ralsina, yup | 21:42 |
| alecu | ralsina, the whole family, not just ancestors | 21:43 |
| ralsina | alecu: it's awesome. You can transform into all the aliens, including the ultimates, and they all have signature moves:-) | 21:43 |
| ralsina | alecu: it's the one we bought in Hamley's | 21:43 |
| alecu | ralsina, sounds lovely! we've been playing toy story 3, and I was very pleasantly surprised at how good it was. | 21:43 |
| ralsina | So, alecu, have a nice long weekend, nessita, have some rest, see you tomorrow! | 21:43 |
| * ralsina needs to get that wii chipped | 21:44 | |
| alecu | ralsina, but the best so far is and has been Zelda twilight princess | 21:44 |
| alecu | ralsina, a hundred peso, but then you'll need a usb cdr | 21:44 |
| ralsina | alecu: ugh | 21:44 |
| ralsina | maybe I'll just buy the games via the wii store | 21:45 |
| * ralsina is so burgueois | 21:45 | |
| alecu | we know! | 21:45 |
| ralsina | ok, good night, send me emails about things that may need to be looked at at midnight ;-) | 21:45 |
| alecu | ralsina, night! | 21:46 |
| nhaines | I still miss Wind Waker. :) | 21:46 |
| nessita | ralsina: bye, I'm sending the email as soon as people stop distracting me :-D | 21:47 |
| alecu | nhaines, gamecube, right? it wasn't a very common console around here | 21:55 |
| alecu | but now you see wiis everywhere | 21:56 |
| nessita | alecu: you need something else from me, besides a review? | 21:57 |
| alecu | nessita, encouragement? | 21:57 |
| alecu | nessita, not really :-) | 21:57 |
| * alecu loves playing really old games, and will try to get windwaker to use in his wii | 21:58 | |
| nessita | alecu: YOU ROCK! YOU CAN DO THIS! | 21:58 |
| alecu | woohoo!!!! | 21:58 |
| nessita | alecu: KEEP BREATHING! | 21:58 |
| nessita | alecu: think about the weekend.... I'm sure you'll have a great time | 21:58 |
| nessita | and send my saludos to your wife and kid :-) | 21:58 |
| * alecu bends down and tries to catch his breath | 21:58 | |
| alecu | saludos will be dice! | 21:59 |
| nessita | LOL | 21:59 |
| nhaines | alecu: exactly! The only trouble would be finding a GameCube controller to use in your Wii to play Windwaker. :) | 22:01 |
| alecu | oh, right :/ | 22:03 |
| nhaines | alecu: I don't know why the Wii classic controllers don't work... even the L/R triggers feel analog to me (maybe not on the new CC Pros). :( | 22:04 |
| nessita | alecu: I have a question: in this code we're kind of ignoring the real exception, is that intended? self._watch_started_deferred.errback, Failure()) | 22:05 |
| alecu | nessita, the Failure() constructor with no parameters *keeps* the raised exception. | 22:06 |
| alecu | nessita, its like "just raise" | 22:06 |
| nessita | alecu: oh, I did not not know that! | 22:06 |
| nessita | you taught me something new todat | 22:07 |
| alecu | nessita, me neither, learned it for this branch :-) | 22:07 |
| nessita | alecu: the branch looks good, will run tests and then approve. I'll make sure this lands tomorrow. | 22:07 |
| alecu | nessita, what's lovely is that it keeps the original stacktrace | 22:07 |
| nessita | that is lovely indeed, and clean | 22:07 |
| ralsina | nessita: stiill around? | 23:09 |
| ralsina | ok, no she is not :-) | 23:09 |
| tntc | hey, any word on the server problem that means I can't save playlists? | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!