| lifeless | can has review ? https://code.launchpad.net/~lifeless/python-oops-wsgi/extraction/+merge/71969 | 00:50 |
|---|---|---|
| lifeless | mwhudson: btw - ^ django is wsgi based yes? you might like that :) | 00:51 |
| wallyworld | lifeless: ^^ as a drive by, did you want to fix the ordering of the imports and __all__ declaration? | 01:11 |
| lifeless | wallyworld: I can, I didn't notice they were unordered? | 02:55 |
| lifeless | wallyworld: indeed, they look ordered to me | 02:55 |
| wallyworld | lifeless: the __all__ is below the imports when it should be above? | 02:55 |
| lifeless | thats correct | 02:55 |
| lifeless | pep8 ' You should put a blank line between each group of imports. | 02:56 |
| lifeless | Put any relevant __all__ specification after the imports.' | 02:56 |
| wallyworld | al of our lp py code is the other way around then | 02:56 |
| wallyworld | ie it has __all__ first then imports | 02:56 |
| lifeless | we should fix that :) | 02:56 |
| wallyworld | that's a *lot* of fixes | 02:57 |
| lifeless | yes | 02:57 |
| lifeless | but easier than fixing all of pypi ! | 02:57 |
| wallyworld | hah | 02:57 |
| wallyworld | i like lp's way of doing it | 02:57 |
| wallyworld | easier to see what's exported | 02:58 |
| jtv | Is the error reporting utility meant to be broken? It seems to have killed dogfood. | 02:58 |
| lifeless | jtv: broken? no. Changed? yes. | 02:58 |
| lifeless | jtv: symptoms? | 02:58 |
| jtv | Hang on, still pasting | 02:58 |
| jtv | lifeless: http://paste.ubuntu.com/668808/ | 02:58 |
| jtv | Not too helpful, I'm afraid. | 02:59 |
| lifeless | bwah | 02:59 |
| lifeless | probably need to drop a pdb in there and have a peek | 02:59 |
| jtv | Ouch. | 02:59 |
| lifeless | I have just overhauled oops handling entirely | 02:59 |
| lifeless | make sure your download-cache is up to date | 03:00 |
| lifeless | and that you have bin/buildout | 03:00 |
| jtv | Does it require a config change by any chance? | 03:00 |
| jtv | I ran rocketfuel-get, which I think takes rare of the other stuff. | 03:01 |
| lifeless | no, no config changes | 03:01 |
| lifeless | jtv: can you try bin/buildout ? | 03:01 |
| jtv | Hmm the tree ended up in an unbuilt state. Rebuilding first. | 03:02 |
| lifeless | wallyworld: did you have any other comments on that mp ? | 03:03 |
| wallyworld | lifeless: no, looks ok to me. there's not much to it | 03:04 |
| === lifeless changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: - | Critical bugs: 238 - 0:[#######=]:256 | ||
| jtv | lifeless: dogfood's running now. Does rocketfuel-get not run buildout? | 03:29 |
| lifeless | not directly | 03:30 |
| lifeless | it runs make | 03:30 |
| lifeless | rocketfuel-get is unmaintained AFAIK - you're the first person I've heard using it some time | 03:31 |
| wgrant | It still works fine. | 03:33 |
| mwhudson | i imagine it gets run very roughly once per someone joining the lp/buying a new machine? | 03:37 |
| mwhudson | oh no, that would be -setup | 03:37 |
| * mwhudson hides again | 03:37 | |
| jtv | Well, -setup runs -get. | 03:38 |
| jtv | Now, why didn't "make" run buildout? | 03:39 |
| lifeless | mwhudson: hey | 03:40 |
| lifeless | mwhudson: so, did you see my oops stuff ? | 03:40 |
| mwhudson | lifeless: i didn't click the link, i'm afraid | 03:41 |
| lifeless | mwhudson: tsk! | 03:41 |
| lifeless | mwhudson: what do you do for error reporting / aggregation / analysis with your dango sites? | 03:41 |
| mwhudson | lifeless: currently embarrassingly little | 03:42 |
| lifeless | mwhudson: so the goal of oops-* is to be easy to use. | 03:42 |
| lifeless | mwhudson: *hint* *hint* | 03:42 |
| mwhudson | lifeless: i believe there's a plan to deploy http://pypi.python.org/pypi/django-sentry | 03:42 |
| lifeless | sentry is interesting | 03:51 |
| lifeless | isd are evaluating it | 03:51 |
| lifeless | it really operates on single log entries FWICT | 03:52 |
| jtv | lifeless: are you reviewing today? I've got a small one here: https://code.launchpad.net/~jtv/launchpad/bug-824553/+merge/71823 | 04:00 |
| lifeless | yes, and its done :) | 04:05 |
| lifeless | jtv: I will happily review most any day | 04:05 |
| jtv | Thanks. Yes, I know—but I also know how much other stuff you do and I wonder if you have enough clones in that closet of yours... | 04:05 |
| nigelb | lifeless: wha, rocketful-get is unmaintained? I keep using it! | 04:59 |
| StevenK | nigelb: I do as well -- but the last thing rf-setup does is copy rf-get to /usr/local/bin. If there any other changes to rf-get later, you don't get them ... | 05:00 |
| nigelb | ah. | 05:01 |
| nigelb | isn't sort of easier to just modify $PATH? | 05:02 |
| nigelb | that way the changes do get propogated. | 05:02 |
| nigelb | or alternatively, symblink instead of copy. | 05:03 |
| lifeless | grah | 05:03 |
| StevenK | nigelb: And then when devel breaks, you can't use rf-get to fix it ... | 05:03 |
| lifeless | ok, web.py is off the microservice list | 05:03 |
| nigelb | StevenK: err, why? | 05:03 |
| nigelb | or rather, why not | 05:03 |
| StevenK | lifeless: What has it done? Or not done? | 05:03 |
| lifeless | StevenK: it -very much- does not want oops_wsgi in the call tree | 05:04 |
| lifeless | StevenK: it helpfully doesn't use wsgi internally! | 05:04 |
| lifeless | StevenK: so there is nowhere in its stack to inject the middleware | 05:04 |
| lifeless | StevenK: and if you warap the stack, it does its own error handling. | 05:04 |
| lifeless | *headdesk* | 05:04 |
| nigelb | try Flask? I don't know about Flask /that/ deep to know if it will work or not. | 05:05 |
| nigelb | If there was some code without tests and I add some more code to it, do I write tests for the entire thing? | 05:12 |
| nigelb | (I'm fairly sure the answer is yes, but I could try ;) ) | 05:14 |
| StevenK | You aren't required to, but it would be awesome. | 05:15 |
| nigelb | Great! Can I bug you for help with it? ;) | 05:19 |
| StevenK | If you like | 05:19 |
| lifeless | nigelb: nope, flask is also overly clever. | 05:46 |
| lifeless | nigelb: rather than having separate concerns, its monolithic, | 05:47 |
| nigelb | yay ;) | 05:47 |
| lifeless | I will port gpgverify to paste tomorrow | 05:47 |
| nigelb | write your own wgi app then? :) | 05:47 |
| nigelb | *wsgi | 05:47 |
| lifeless | nigelb: no, we use paste for loggerhead and its great | 05:47 |
| nigelb | :) | 05:47 |
| lifeless | a little *too* bare bones in some ways, but it doesn't get in the way. | 05:47 |
| wgrant | Also, it's not CherryPy. | 05:51 |
| wgrant | That's the main thing. | 05:51 |
| nigelb | heh | 05:52 |
| wgrant | (Loggerhead used to use CherryPy. Those days were bad.) | 05:52 |
| nigelb | So, what happens to IPerson(self.request.principal) when I'm not logged in? | 05:56 |
| lifeless | None IIRC | 05:57 |
| nigelb | hm, why is my code breaking then | 05:57 |
| lifeless | ok, I'm kindof EODing, allergy injections suck :) | 05:57 |
| nigelb | user=None for search should just work right? | 05:57 |
| nigelb | halp. | 06:08 |
| nigelb | TypeError: ('Could not adapt', <zope.principalregistry.principalregistry.UnauthenticatedPrincipal object at 0xb3f028c>, <InterfaceClass lp.registry.interfaces.person.IPerson>) | 06:08 |
| nigelb | is it kosher to do a try catch? | 06:09 |
| nigelb | wallyworld__: around? :) | 06:11 |
| lifeless | should just be self.user if you're using a form, or call_with in the API | 06:11 |
| wallyworld__ | nigelb: hi | 06:11 |
| lifeless | anything else and you're doing it wrong :) | 06:11 |
| nigelb | lifeless: no no. | 06:12 |
| wallyworld__ | lifeless: it's not a form and it's not the ws api. it's a view | 06:12 |
| nigelb | You warned me about the anonymous use case, only I don't remember how to catch it :) | 06:12 |
| wallyworld__ | similar to HugeVocabularyJSONView for example | 06:12 |
| lifeless | blah, I meant view | 06:12 |
| lifeless | LaunchpadView sets an attribute to Just Work | 06:12 |
| lifeless | anyhow, I'm really not here, ciao. | 06:13 |
| wallyworld__ | nigelb: i think in the case of anon, request.prinicpal is None | 06:14 |
| wallyworld__ | nigelb: because LinkChecker doesn't extend LachpadView, there's no self.user | 06:14 |
| wallyworld__ | nigelb: perhaps you should make LinkChecker a subclass of LaunchpadView | 06:14 |
| wallyworld__ | it may then allow you to just use self.user | 06:15 |
| nigelb | let me do that then | 06:15 |
| wallyworld__ | just a guess, it may work | 06:15 |
| nigelb | wallyworld__: \o/ works :) | 06:21 |
| wallyworld__ | nigelb: excellent! | 06:21 |
| * nigelb now needs to wwite tests | 06:21 | |
| nigelb | wallyworld__: how do I test behavior with a public bug number and a privaet bug number? | 07:20 |
| nigelb | make the bug private and then try with anonymous user? | 07:20 |
| nigelb | or something. | 07:21 |
| wallyworld__ | nigelb: you need to create a private bug and log in as the user who owns the project the bug is reported against | 07:21 |
| wallyworld__ | nigelb: with_person_logged_in is one way | 07:22 |
| wallyworld__ | nigelb: i assume you are talking about a python unit test here | 07:22 |
| nigelb | so, create a person, create project with owner that person, create private bug, then logging as that user and try and try as anonymous | 07:22 |
| nigelb | yah | 07:22 |
| nigelb | wallyworld__: yeah, unit tests, I should have been further clear :) | 07:22 |
| wallyworld__ | yes what you say above sounds right. do it as 2 tests | 07:23 |
| nigelb | always the fun bit in LP | 07:25 |
| nigelb | unit testing | 07:25 |
| adeuring | good mornning | 07:35 |
| danilos | poolie, hi, if you are still around, are you familiar with our loggerhead QA/rollout setup? | 08:06 |
| poolie | hi there | 08:09 |
| poolie | danilos: slightly | 08:09 |
| poolie | what do you want to know? | 08:10 |
| danilos | poolie, well, I've landed a fix yesterday, and I would like how to best QA it, and how to ensure it gets rolled out | 08:10 |
| danilos | would like *to know* :) | 08:10 |
| poolie | oh, ok, i think i saw your mp | 08:11 |
| poolie | do you know if that revision is live on qas? | 08:11 |
| poolie | or staging? | 08:11 |
| danilos | poolie, how can I tell that? :) (I assume that means it's not) | 08:13 |
| poolie | one trick here is that there's only actually back-end storage for lp:bzr on qas and staging | 08:14 |
| poolie | i think | 08:14 |
| poolie | at any rate lots of branches are in the db but will break if you try to touch them | 08:14 |
| poolie | for disk space reasons | 08:14 |
| lifeless | pushing tp +junk is ideal | 08:15 |
| danilos | poolie, right, I know that, but I should be able to push stuff to lp://staging/, right? | 08:15 |
| poolie | danilos: so, does landing something into lp:loggerhead cause it to be rolled out? | 08:16 |
| poolie | i don't think so but i'm not sure | 08:16 |
| danilos | poolie, I have no idea, those are the things I am trying to find out, but I doubt it | 08:16 |
| poolie | let's see if there's version info | 08:17 |
| poolie | the losas are sprinting but they should be awake now | 08:17 |
| poolie | spm? | 08:17 |
| spm | poolie: hi | 08:17 |
| lifeless | poolie: no, you need to update the version ref in lp | 08:18 |
| poolie | spm, hi, can you tell me if normal deployments to qas pull in loggerhead from trunk? | 08:18 |
| poolie | oh ok, i thought so | 08:18 |
| lifeless | poolie: the qa deployment includes loggerhead, but not trunk | 08:18 |
| poolie | danilos: so, i think you need to make an additional landing into lp:launchpad for it to be live, like that | 08:18 |
| poolie | in fact it says 1.18 on the web page, and isn't trunk later than that? | 08:18 |
| poolie | danilos: does that help at all? | 08:20 |
| danilos | poolie, yeah, trunk does have a few revisions compared to what I have in sourcecode/loggerhead | 08:21 |
| poolie | ok trunk still says it's v 1.18 | 08:21 |
| danilos | poolie, yeah, I figure I might need to land to loggerhead through PQM to ~launchpad-pqm/loggerhead/devel | 08:21 |
| spm | poolie: sorry, quite distracted atm. have your questions been answered satisfactorily? | 08:22 |
| poolie | yes, thanks | 08:22 |
| poolie | enjoy your brown sauce | 08:22 |
| spm | heh | 08:22 |
| danilos | lifeless, do you know if I can just bump the LP loggerhead to trunk (I see issues like bug 826082 in a bit of indeterminate state), or if I should just include my own revision that I want rolled out? | 08:27 |
| _mup_ | Bug #826082: BadUrl from safe_open opening a branch <oops> <regression> <Launchpad itself:Triaged> < https://launchpad.net/bugs/826082 > | 08:27 |
| poolie | danilos: i would like to get lp running trunk | 08:28 |
| poolie | if necessary by reverting stuff that's unstable | 08:28 |
| poolie | i don't have an detailed opinion about that specific bug | 08:28 |
| danilos | poolie, so would I, but I ain't sure what are those | 08:28 |
| danilos | poolie, so, I followed the trail of bug 820065 and bug 812583, which got me to the above bug | 08:29 |
| _mup_ | Bug #820065: TypeError: unsupported operand type(s) for -: 'int' and 'NoneType' <oops> <qa-untestable> <Launchpad itself:In Progress> <loggerhead:Fix Committed by pr0gg3d> < https://launchpad.net/bugs/820065 > | 08:29 |
| poolie | well it looks like that might be fixed | 08:29 |
| _mup_ | Bug #812583: IndexError in add_template_values in loggerhead annotate <loggerhead> <oops> <qa-untestable> <Launchpad itself:In Progress> <loggerhead:Fix Committed by pr0gg3d> < https://launchpad.net/bugs/812583 > | 08:29 |
| lifeless | so, we rolled back loggerhead after deploying coincided with a 1000 oops a day increase. | 08:29 |
| lifeless | however | 08:29 |
| lifeless | that increase appears to be jelmers safe-open refactoring | 08:29 |
| lifeless | which he was fixing | 08:29 |
| lifeless | In the spirit of one-change-at-a-time, I think we should get that sorted, then upgrade again. | 08:30 |
| lifeless | if jelmers patch is landed, then upgraded loggerhead should be pretty straight forward | 08:30 |
| danilos | lifeless, jelmer's patch is not landed in either loggerhead trunk or Launchpad | 08:30 |
| poolie | he should be up soon and we can ask him | 08:31 |
| danilos | (that would be clearer if it was "is landed in neither...nor" :) | 08:31 |
| jelmer | it was in ec2 overnight but appears to have failed | 08:31 |
| lifeless | danilos: it would be in launchpad | 08:31 |
| danilos | poolie, lifeless, any suggestions on where should I put the docs for developers wanting to QA/deploy loggerhead? (something that'd be easy to find, I found no pages about it on dev.launchpad.net and wiki.canonical.com) | 08:33 |
| lifeless | danilos: README.txt in loggerhead ? | 08:33 |
| danilos | lifeless, I was more thinking in terms of Launchpad QA/deployment | 08:34 |
| lifeless | danilos: I know its a bit LP specific, but you could note that this is the primary place its deployed :) | 08:34 |
| lifeless | danilos: otherwise, yeah somewhere on d.l.n. | 08:34 |
| wgrant | Ew, that does not belong in the loggerhead tree. | 08:34 |
| danilos | lifeless, right, fair enough, though I'll add a few pages titled /Loggerhead to the dev wiki pointing at the readme then | 08:34 |
| poolie | i think dev.l.n | 08:35 |
| lifeless | danilos: its only a though, wiki is fine too | 08:35 |
| lifeless | *thought* | 08:35 |
| danilos | so, I guess d.l.n is the consensus choice here, thanks all for chipping in :) | 08:35 |
| poolie | how to run or deploy it in general belongs in the tree; not the quirks of lp deployment though | 08:35 |
| lifeless | the reason I think its reasonable to put it in the loggerhead tree is we want to run trunk | 08:35 |
| poolie | if you ask me | 08:35 |
| poolie | partly becaues there's much less chance losas will touch that | 08:35 |
| lifeless | if we want to keep trunk deployable, we should have the instructions for that clear and visible to all contributors | 08:36 |
| poolie | danilos: so, ping me or someone else if you want more | 08:44 |
| danilos | poolie, lifeless: any fixes/improvements welcome on https://dev.launchpad.net/Code/Loggerhead, I am sure I got some bits of the process wrong | 08:49 |
| danilos | I've also removed a reference to inactive project launchpad-loggerhead from dev.l.n/Code and pointed at this page instead | 08:53 |
| danilos | jelmer, so, I assume I'd better wait for you to land your changes and get them deployed before I try that with my changes to loggerhead | 08:57 |
| danilos | jelmer, I am sure you might have a few suggestions for https://dev.launchpad.net/Code/Loggerhead | 08:57 |
| danilos | a buildbot failure in an unrelated test :( | 09:00 |
| jelmer | danilos: Looking at the test failures right now.. | 09:05 |
| danilos | jelmer, cool, thanks | 09:05 |
| danilos | jelmer, though, I was referring to a spurious buildbot failure for my branch :) | 09:05 |
| danilos | lifeless, since I am lazy, what was the policy for triaging bugs about spurious test failures? critical? (bug 828584) | 09:06 |
| _mup_ | Bug #828584: Spurious test failure: test_sigint_exits_nicely <Launchpad itself:New> < https://launchpad.net/bugs/828584 > | 09:06 |
| poolie | vila, jam, so i wonder how we could unstack it safely | 09:09 |
| jam | poolie: reconfigure --unstacked isn't safe? | 09:10 |
| jam | If you want the quick bzrlib invocation | 09:11 |
| jam | just open the repository directly | 09:11 |
| jam | repo.fetch(basis_repo) | 09:11 |
| jam | which fills in everything | 09:11 |
| vila | jam: without unstacking right ? | 09:11 |
| jam | vila: if you do Repository.open() instead of Branch.open().repository | 09:11 |
| poolie | jam, oh, i mean it _should_ be safe | 09:11 |
| jam | the repo won't be stacked | 09:11 |
| poolie | my question was really, is it safe, and how could we mitigate any risks | 09:12 |
| jam | and .fetch() without a search recipe or target revision | 09:12 |
| jam | fetches everything | 09:12 |
| jam | poolie: I think it is safe, but if you want to do it easily Repo.fetch(repo) works just fine | 09:12 |
| poolie | danilos: that looks pretty good; though i'd like to know whetehr things automatically go onto buildbot, *staging, etc | 09:13 |
| poolie | i guess you would too :) | 09:13 |
| jam | Speaking of which, I just did: jameinel@chinstrap:~$ time bzr branch lp:gcc-linaro/4.6 lp:~jameinel/gcc-linaro/test-4.6 | 09:13 |
| jam | Using default stacking branch /+branch-id/355386 at bzr+ssh://bazaar.launchpad.net/~jameinel/gcc-linaro/ | 09:13 |
| danilos | poolie, exactly :) | 09:13 |
| jam | And it was still transferring at 500MB or so when I killed it. | 09:13 |
| jam | but you know, that could be the "created a branch and didn't populate it" or something like that. | 09:14 |
| jam | I'll try again with debug flags set | 09:14 |
| === almaisan-away is now known as al-maisan | ||
| jam | poolie: very strange "bzr branch lp:gcc-linaro/4.6 lp:~jameinel/gcc-linaro/test-4.6" is at about 1GB transferred so far. | 09:32 |
| jam | 1.2GB | 09:32 |
| jam | the discovery phase was fast, but the bytes transferred seems really wonky | 09:33 |
| jam | there is only like 100MB in /4.6, so it doesn't line up at all, unless something is broken with the target stacking. | 09:34 |
| jam | but the request says that it is trying to stack. | 09:34 |
| jam | though this is bzr-2.1.4... because it was the binary on Chinstrap | 09:35 |
| jam | not sure how much that matters or not. | 09:35 |
| jam | It had "transferred" 1.2GB (probably down and then up again), and there was 465MB in the target. Still too much. | 09:37 |
| === allenap changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: allenap | Critical bugs: 238 - 0:[#######=]:256 | ||
| rvba | allenap: Can you please review this MP https://code.launchpad.net/~rvb/launchpad/overlay-bug-827220/+merge/71915 ? | 10:16 |
| allenap | rvba: Sure. | 10:24 |
| rvba | allenap: : Thanks. | 10:24 |
| lifeless | danilos: thats fine I think | 10:25 |
| lifeless | I will look at the docs tomorrow :) | 10:25 |
| allenap | rvba: Ah, interesting, I would have suspected that you'd need to use getComputedStyle(). r=me/ | 10:25 |
| danilos | lifeless, please extend them with as much as you know how stuff gets to *staging, what gets run in the buildbot and similar :) | 10:26 |
| rvba | allenap: looks like getStyle is enough ... | 10:27 |
| allenap | rvba: Cool. | 10:27 |
| henninge | lifeless: Hi! | 10:40 |
| henninge | lifeless: about python fixtures | 10:41 |
| lifeless | hi | 10:42 |
| henninge | lifeless: I don't see where we include it | 10:45 |
| lifeless | henninge: setup.py | 10:45 |
| lifeless | henninge: or do you mean inside LP? grep 'Fixture' lib -r. | 10:46 |
| henninge | lifeless: yeah, in LP | 10:46 |
| henninge | but I just saw that it is called "fixtures", let me look | 10:46 |
| henninge | lifeless: ah ok, I was looking for python-fixtures | 10:47 |
| lifeless | henninge: grep Fixture) | 10:47 |
| henninge | it's in download-cache | 10:47 |
| lifeless | will show where its used. | 10:47 |
| henninge | no, I was not looking for that, I have used it in tests myself ... | 10:47 |
| lifeless | at least directly; it won't show indirectly like in python-gbouncer, the rabbit notifier etc | 10:47 |
| henninge | I just wanted to see which version we used | 10:47 |
| lifeless | henninge: oh, :) I get you. | 10:47 |
| henninge | lifeless: so you are saying fixtures will need an update to work with the latest testtools? | 10:48 |
| henninge | s/update/patch/ | 10:48 |
| lifeless | yes, incompatible change to gather_details | 10:48 |
| henninge | probably the same that I ran into | 10:49 |
| henninge | because the output changed | 10:49 |
| henninge | ? | 10:49 |
| lifeless | no | 10:49 |
| lifeless | rev 207 in testtools | 10:49 |
| lifeless | breaks fixtures | 10:50 |
| lifeless | fixed in rev 29 of fixtures | 10:50 |
| henninge | lifeless: that's what I was trying to get at. | 10:50 |
| henninge | so I don't need to fix fixtures, I just need to package the latest version of it. | 10:51 |
| lifeless | wgrant: yes | 10:52 |
| lifeless | bah | 10:52 |
| lifeless | henninge: yes | 10:52 |
| henninge | lifeless: thanks, that's much easier of course ;-) | 10:53 |
| === al-maisan is now known as almaisan-away | ||
| === henninge is now known as henninge-lunch | ||
| === almaisan-away is now known as al-maisan | ||
| === henninge-lunch is now known as henninge | ||
| Ursinha | guys, anyone up to help me to understand what exactly launchpad understands when I say ubuntu.searchTasks(bug_supervisor=oneteam) ? | 12:31 |
| jml | Ursinha: sure. | 12:34 |
| Ursinha | afaik, packages don't have bug supervisors, only ubuntu does | 12:35 |
| Ursinha | but using that returns me different tasks for different packages | 12:35 |
| Ursinha | I can't ubuntu.searchTasks(structural_subscriber=oneteam) to compare, because that times out | 12:36 |
| jml | Ursinha: just found http://paste.ubuntu.com/669193/ in bugtask.py | 12:37 |
| Ursinha | bdmurray: ^ | 12:38 |
| Ursinha | jml: so it should work pretty much as structural_subscriber does? | 12:38 |
| jml | Ursinha: I'm still grokking it. one sec. | 12:38 |
| Ursinha | jml: sure | 12:39 |
| jml | Ursinha: if I understand correctly, it'll match any package that oneteam is subscribed to | 12:40 |
| jml | s/any package that/any bugtask on a package that/ | 12:40 |
| jml | as well as any bug task on ubuntu itself | 12:40 |
| Ursinha | that's exactly what we need, and also what we tried to accomplish with structural_subscriber but it times out now... | 12:41 |
| Ursinha | bdmurray: so we can use bug_supervisor | 12:41 |
| jml | and it doesn't do team unrolling | 12:41 |
| jml | exact match of user ids | 12:41 |
| jml | https://bugs.launchpad.net/launchpad/+bug/191809 | 12:41 |
| _mup_ | Bug #191809: A DistributionSourcePackage needs a bug supervisor role to control permissions <lp-bugs> <Launchpad itself:Triaged> < https://launchpad.net/bugs/191809 > | 12:41 |
| nigelb | mrevell: hi | 12:42 |
| mrevell | Hey nigelb | 12:43 |
| Ursinha | cool | 12:43 |
| Ursinha | thanks jml :) | 12:43 |
| nigelb | mrevell: hey, did you get a chance to look at that bug? :) | 12:43 |
| jml | Ursinha: np | 12:43 |
| mrevell | nigelb, Not yet. I'm at an event today. I'll be back tomorrow. | 12:45 |
| nigelb | mrevell: cool, ok :) | 12:45 |
| mrevell | gary_poster, nigelb is interested in bug 816105. As your squad worked on the feature, I'd love to hear your thoughts on that bug report. | 12:46 |
| _mup_ | Bug #816105: UI for subscribing to a bug is confusing <bugs> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/816105 > | 12:46 |
| gary_poster | mrevell, any solution needs to support the new notification levels. IMO, a solution should also communicate if "[y]ou have subscriptions that may cause you to receive notifications". | 12:55 |
| gary_poster | A more perfect solution IMO (also fixing another related UI bug filed by mpt, I think) would also remove the necessity for the "Edit bug mail" link by making the notification of "[y]ou have subscriptions that may cause you to receive notifications" have a link to an in-page overlay that explains what is meant and what can be done about it other than muting. | 12:55 |
| gary_poster | Specifically, this would be the "Other subscriptions" information on the "Edit bug mail" page included as an overlay on the bug page. That information should only be loaded dynamically--it is somewhat expensive to calculate and +index is already slow enough. | 12:55 |
| gary_poster | I suspect that the "Other subscriptions" code is factored well enough that this would not be too tricky to do. | 12:55 |
| * nigelb reads the wall of text | 12:55 | |
| StevenK | nigelb: It's even more awesome when you talk to gary_poster IRL. Since then it's a wall of speech. :-P | 12:56 |
| nigelb | StevenK: haha | 12:56 |
| gary_poster | ha. ha. :-) | 12:56 |
| nigelb | gary_poster: my main irk was this. it was way more easier to find how to subscribe others than subscribe myself. | 12:57 |
| gary_poster | nigelb, I can see what you mean. | 12:57 |
| wallyworld__ | sinzui: both new picker feature flags are now on lp.net | 12:59 |
| gary_poster | nigelb, I believe it is mrevell's responsibility to actually decide how it should work, or at least delegate and approve it. The above is my take. | 12:59 |
| nigelb | gary_poster: 'm still parsing that ;) | 12:59 |
| sinzui | \o/ | 13:00 |
| wallyworld__ | seems to work well | 13:00 |
| gary_poster | the "wall" or the mention of mrevell as the responsible party as acting product mgr? | 13:00 |
| mrevell | gary_poster, nigelb: Thanks both. I'll return to this tomorrow, when I'm back from the QA CoP sprint. | 13:00 |
| gary_poster | cool | 13:00 |
| nigelb | gary_poster: heh, the wall ;) | 13:01 |
| gary_poster | nigelb, mrevell, the mistake we made IMO was not not take this part through user testing. It was at the end of the project and we were in a rush. Whatever is done, I suggest you not make our mistake, and actually produce mockups and run user tests. | 13:02 |
| nigelb | gary_poster: I agree there. I'm only helping implement. Like I said the other day, I think the code bit is probably triivial. the UX bit is not. | 13:04 |
| === jcsackett changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: allenap, jcsackett | Critical bugs: 238 - 0:[#######=]:256 | ||
| abentley | sinzui: I have a question about a distro in Launchpad: https://launchpad.net/cinux | 13:52 |
| sinzui | ask away | 13:52 |
| flacoste | hello everyone! | 13:58 |
| deryck | Hi, flacoste. Welcome back! | 14:00 |
| flacoste | hi deryck! | 14:00 |
| deryck | adeuring, hi, shall we mumble now? | 14:02 |
| adeuring | deryck: ah, sure! | 14:02 |
| bac | hi flacoste, welcome back to the land of the internets | 14:10 |
| flacoste | hi bac! | 14:10 |
| === bigjools-afk is now known as bigjools_ | ||
| stub | Bah. We can't logout from the appserver layer as it redirects through secure codehosting to clear tokens before ending up on the openid side. | 14:14 |
| stub | No tests for logout :-( | 14:14 |
| gary_poster | welcome back flacoste | 14:35 |
| flacoste | hi gary! | 14:35 |
| henninge | deryck, abentley: I am really unsure with this javascript test. I am not sure how and what to test, maybe taht's why I keep finding excuses to do something else ... ;-) | 15:04 |
| henninge | I have this now: http://paste.ubuntu.com/669304/ | 15:04 |
| abentley | henninge: looking. | 15:05 |
| henninge | It's just checking that the handler works properly. | 15:05 |
| abentley | henninge: Okay, do you want to mumble about it? | 15:06 |
| henninge | abentley: sure | 15:07 |
| === al-maisan is now known as almaisan-away | ||
| === deryck is now known as deryck[lunch] | ||
| cjwatson | Could somebody please try landing https://code.launchpad.net/~cjwatson/launchpad/dpkg-xz-support-619152/+merge/32868 ? The necessary python-apt and apt-utils packages are now installed on production | 16:32 |
| cjwatson | *try ... again | 16:32 |
| === deryck[lunch] is now known as deryck | ||
| === beuno is now known as beuno-lunch | ||
| sinzui | jcsackett, do you have time to mumble? | 17:40 |
| abentley | allenap or jcsackett: could you please review https://code.launchpad.net/~abentley/launchpad/twisted-logging/+merge/72082 ? | 17:46 |
| jcsackett | abentley: i'm otp now, but can look after that. | 17:46 |
| abentley | jcsackett: thanks. | 17:46 |
| jcsackett | abentley: looking at your branch now. | 18:02 |
| abentley | jcsackett: great. | 18:03 |
| abentley | sinzui: is bug 828493 related to your current work? | 18:05 |
| _mup_ | Bug #828493: Bogus results in package search <Launchpad itself:New> < https://launchpad.net/bugs/828493 > | 18:05 |
| cr3 | anyone know if there's a ui bug open against launchpad about the watermark and maincontent header being repetitive, like bugs.launchpad.net/checkbox showing "Checkbos System Testing" and "Bugs for Checkbox System Testing" respectively? | 18:06 |
| sinzui | No, It is a duplicate of an old bug my team will fix | 18:06 |
| sinzui | abentley, I will find the master and mark it as a dupe | 18:06 |
| abentley | sinzui: rawk. | 18:07 |
| jcsackett | abentley: looks good. r=me. | 18:09 |
| abentley | jcsackett: thanks. | 18:09 |
| === beuno-lunch is now known as beuno | ||
| === allenap changed the topic of #launchpad-dev to: https://dev.launchpad.net/ | On call reviewer: jcsackett | Critical bugs: 238 - 0:[#######=]:256 | ||
| sinzui | jcsackett, are you about to do a code review? | 21:05 |
| mtaylor | spm: around? | 21:23 |
| mtaylor | spm: if I did a staging import of bug a few weeks ago, and now I'm ready to go live, but re-ran the script to get more recent bugs - do we need to do another staging import? and do you want me to open a new ticket? or re-use the old one? | 21:24 |
| sinzui | mtaylor, Another staging import is not needed, but someone, maybe spm, needs to run out preprocessor over your data to generate the bug nicknames. You need to post the URL to the updated data or send someone an email with the attachment. | 21:29 |
| mtaylor | sinzui: k. awesome. https://answers.launchpad.net/launchpad/+question/168463 | 21:31 |
| mtaylor | sinzui: btw- I now have a script that can export bugs from a github project and generate the xml if you guys want a copy of it | 21:32 |
| mtaylor | sinzui: https://github.com/openstack/openstack-ci/blob/master/gh_issues_to_lp_bugs.py | 21:33 |
| mtaylor | sinzui: the lack of great way to map users and the lack of readily accessible email addresses sort of blows, but other than that it's workable at least | 21:33 |
| sinzui | mtaylor, thanks | 21:34 |
| sinzui | The user/email issue also happens when we import a mailing list. We can do it, but the feature was never exposed in the UI because of the troubles | 21:35 |
| sinzui | I am creating the preprocessed xml file and updating the bug so that a system admin can do the real import | 21:37 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| mtaylor | sinzui: thanks! | 21:52 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| === jcsackett changed the topic of #launchpad-dev to: https:dev.launchpad.net/ | On call reviewer: - | Critical bugs: 238 - 0:[#######=]:256 | ||
| lifeless | mtaylor: cool | 22:16 |
| lifeless | jelmer_: hi | 22:16 |
| lifeless | jelmer_: did the loggerhead fix land overhnight ? | 22:17 |
| jelmer_ | g'morning lifeless | 22:17 |
| jelmer_ | lifeless, r13726 | 22:18 |
| lifeless | excellent! | 22:18 |
| lifeless | sinzui: around ? | 22:31 |
| sinzui | I am | 22:31 |
| lifeless | I'd like to understand this 'spying' thing more | 22:31 |
| lifeless | whats the best way for me to do that ? | 22:31 |
| sinzui | Since a private team cannot subscribe to a bug or branch you cannot | 22:32 |
| sinzui | put if someone could. they could be subscribed to all of canonical's projects and the owners could not see that. | 22:32 |
| lifeless | ok, so its not a feature. Its a potential antifeature ? | 22:32 |
| sinzui | yess | 22:33 |
| lifeless | I will follow up to the bug to note that | 22:33 |
| sinzui | we talked about fixing the subscription rules for bug supervisor and security contact a few days ago. Doing that will address most of the issue. | 22:33 |
| lifeless | how does that connect? | 22:34 |
| sinzui | We would also need a rule when retargeting to a private project to change the subscribers. | 22:34 |
| lifeless | ah | 22:35 |
| lifeless | hmm | 22:35 |
| lifeless | so the structural subs won't need any handling : they are per project anyhoew | 22:35 |
| lifeless | explicit subs to the bug might need to be carried over | 22:35 |
| sinzui | Bug.setPrivate() converts the structural subscriber to a real subscriber. the private subscription would not be visible | 22:35 |
| lifeless | or ditched | 22:35 |
| lifeless | setPrivate shouldn't do that | 22:35 |
| lifeless | its a bug | 22:35 |
| sinzui | yes, that was the gist of our conversation | 22:36 |
| lifeless | ok, I'm assuming that that is fixed in this discussion :) | 22:36 |
| lifeless | beyond that, we have explicit subscriptions to consider | 22:36 |
| sinzui | I think the set-based rules to determine who should be subscribed on transitions to private/security will work. | 22:37 |
| sinzui | We need to ensure those rules are in play when a bug it retargeted to a private project | 22:37 |
| lifeless | yes | 22:38 |
| lifeless | uhm, let me look for the other bug | 22:38 |
| lifeless | it was something like 'need to ask who should be subscribed to a bug when it is made private' | 22:38 |
| lifeless | which I think was duped on the strucsub issue, but actually shouldn't have been | 22:38 |
| sinzui | The person who can make a bug private does not necessarily know who should be subscribed. I could subscribe someone who the owner do not want subscribed | 22:41 |
| lifeless | the person who makes it private gets a subscription themselves. | 22:41 |
| lifeless | they can then subscribe anyone. | 22:41 |
| lifeless | so they can violate the owners desire anyway [given the current visibility rules | 22:41 |
| lifeless | ] | 22:41 |
| lifeless | ok, but it wasn't a dupe | 22:43 |
| lifeless | it was assuming implicit subscriptions being carried across was broadly desirable. | 22:43 |
| lifeless | so | 22:43 |
| lifeless | I think there is a latent bug here but we can ignore it :) | 22:43 |
| lifeless | sinzui: bug https://bugs.launchpad.net/launchpad/+bug/827902 | 22:43 |
| _mup_ | Bug #827902: Private teams not able to subscribe to bugs or blueprints for email updates <disclosure> <privacy> <teams> <Launchpad itself:Triaged> < https://launchpad.net/bugs/827902 > | 22:43 |
| lifeless | sinzui: my comments 2 and 3 - could you confirm I understand correctly? | 22:43 |
| sinzui | lifeless, that is a good call on the rule to reveal the team's name | 22:47 |
| lifeless | thanks ! | 22:48 |
| lifeless | its nice when a plan comes together | 22:48 |
| lifeless | sinzui: and my neurons just rubbed together :) - cgregan linked the team in the report ;) | 22:53 |
| lifeless | sinzui: so the rules we had previously put together are sufficient. | 22:53 |
| lifeless | poolie: when do you want to catch up ? | 22:53 |
| sinzui | fab | 22:53 |
| lifeless | poolie: ping ;) | 23:07 |
| poolie | hi lifeless, i was on the phone | 23:26 |
| lifeless | no worries | 23:26 |
| poolie | how about if i make some coffee and we talk in 15m? | 23:26 |
| lifeless | sure | 23:26 |
| cjwatson | Could somebody please try landing https://code.launchpad.net/~cjwatson/launchpad/dpkg-xz-support-619152/+merge/32868 ? The necessary python-apt and apt-utils packages are now installed on production | 23:31 |
| StevenK | cjwatson: Certainly. | 23:34 |
| cjwatson | hurray | 23:35 |
| cjwatson | (I have another one after this, but this one is probably simpler) | 23:35 |
| sinzui | StevenK, wallyworld__ http://www.staff.uni-mainz.de/neuffer/scsi/fun.html | 23:38 |
| lifeless | nice | 23:39 |
| sinzui | wallyworld__, https://code.launchpad.net/~sinzui/launchpad/code-review-affiliation/+merge/72106 | 23:40 |
| === wallyworld__ changed the topic of #launchpad-dev to: https:dev.launchpad.net/ | On call reviewer: wallyworld* (jtv) | Critical bugs: 238 - 0:[#######=]:256 | ||
| StevenK | cjwatson: Now that I'm off the phone -- your branch is in ec2, you should get a mail in ~ 4 hours. | 23:48 |
| StevenK | cjwatson: Out of interest, has that branch been QA'd on dogfood before landing? | 23:49 |
| cjwatson | it has not AFAIK | 23:50 |
| poolie | hi lifeless | 23:50 |
| cjwatson | StevenK: ^- | 23:50 |
| cjwatson | StevenK: mawson doesn't yet seem to have the relevant apt-utils version, oddly | 23:51 |
| cjwatson | StevenK: I'll whine at RT about that | 23:51 |
| StevenK | cjwatson: mawson is a law unto itself, sadly. | 23:51 |
| StevenK | cjwatson: I would be nice to QA it on qastaging, but asuka doesn't run any of the required services. | 23:52 |
| cjwatson | (mawson == dogfood, right?) | 23:52 |
| StevenK | s/I/It/ | 23:52 |
| StevenK | cjwatson: Right | 23:52 |
| cjwatson | I've sent a whinge to RT#47132 | 23:53 |
| _mup_ | Bug #47132: Documentation index not available -- yelp confused <bzr (Ubuntu):Fix Released> <bzr (Debian):Fix Released> < https://launchpad.net/bugs/47132 > | 23:53 |
| cjwatson | TBH, for the .tar.xz branch, I can't see how it would break anything until/unless somebody uploads something .data.tar.xz-ish | 23:54 |
| StevenK | cjwatson: Right, so my QA plan for the branch on mawson was upload a 'normal' package and then a different xz-using package and see that they both get processed correctly. | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!