karninhaines: how do you like that http://ubuntuone.com/p/1B7X/00:33
karniGood night #ubuntuone!00:34
dholbachcan anyone of the U1 Couch people have a look at https://code.launchpad.net/~wibblymat/ubuntu/oneiric/couchdb/update-to-1.1.0/+merge/69702 and give their input to an update to 1.1.0 and the patches and everything?09:46
* fagan doesnt even know who is couch now 09:49
faganI mean who is working on it09:50
faganI now have a keyboard that is built like a typewriter09:58
fagannot to look like one but inside its one09:58
karniGood morning!10:01
ryekarni, i saw the screenshot - http://ubuntuone.com/p/1B7X/ - looks very related to my interests10:10
karnirye: (Im' glad!) Which are exactly :)?10:11
karniProgress indication and simultaneous up/downloads?10:11
ryekarni, yep, /me likes progress indicators!10:18
karnirye: cool :)10:18
karniPeople were asking about them.10:18
* Chipaca waves at jderose10:50
dholbachhey Chipaca - how are you doing?10:54
Chipacadholbach: hi there10:54
Chipacadholbach: a bit tired, but good. you?10:54
dholbacha bit tired as well, but doing alright - thanks :)10:55
dholbachChipaca, somebody worked on a merge of couchdb 1.1.0 from debian - it mostly looks OK from a sponsor-the-update-into-Ubuntu POV, who would be a good person on the U1 team to double check it?10:55
dholbachhttps://code.launchpad.net/~wibblymat/ubuntu/oneiric/couchdb/update-to-1.1.0/+merge/69702 is the MP in question10:56
Chipacadholbach: ok, i'll look at it (or have somebody do it)10:57
* dholbach hugs Chipaca10:57
dholbachawesome - thanks muchly10:57
Chipacaalso, wibblymat is a +2 nick10:57
dholbachah, good to know!11:05
dholbachjust as a heads-up: the new couchdb might need a feature freeze exception11:05
nessitahello everyone!11:13
karniGood day nessita !11:13
nessitahello karni!11:14
gatoxnessita, hi11:14
nessitahi gatox11:14
gatoxnessita, i'm adding some changes to a new branch... would you be able to review?? it's almost done11:14
nessitagatox: I'm always able to! I may be less or more slow in the process, but always shoot11:16
gatoxnessita, thanks! i'm adding more tests right now... i found that something wasn't being tested... so i'll let you know when it's ready :D11:17
Chipacadholbach: pedronis will try to look at that mp tomorrow11:25
Chipacadholbach: does that timing work?11:26
dholbachsure sure - we're in feature freeze anyway, so if it makes sense to get it in and we have some good justification, better get it in now than even later11:26
dholbachthanks a bunch11:26
gatoxnessita, done! https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/7193711:38
nessitagatox: can you please commit with --fixes so the bug gets linked?11:39
gatoxnessita, ok11:39
gatoxnessita, done11:40
nessitagatox: ack11:50
gatoxnessita, i have to leave in a while, if i don't return for standup, should i give you the report of my tasks to you?12:07
nessitagatox: yes please12:07
gatoxnessita, ok..... writing....12:07
ralsinagood morning!12:08
nessitahi ralsina12:08
ralsinahi nessita12:08
ralsinaany ideas on the 403?12:08
gatoxralsina, hi12:08
ralsinahi gatox12:08
gatoxnessita, this is my standup:12:12
gatoxBug #820874 = Branch ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/7193712:12
gatoxFinish uninstall issue. Start working on List Styles.12:12
ubot4gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private12:12
nessitaralsina: yes, I'm working on it (replying to your email as well)12:13
ralsinanessita: ok, cool12:13
nessitaralsina: would you know what encoding has the bytes strings returned by platform module?12:14
ralsinanessita: no idea12:14
ralsinaBTW: if anyone ever gets 30+ failing tests on sso-client? Check that it's not running. Scared the crap out of me.12:14
nessitaralsina: hum?12:15
ralsinanessita: on windows, because we are using a "real" tcp port, I think12:15
nessitaralsina: where are you getting the "error_message" from?12:20
nessitaexcept_to_errdict in main/__init__.py sends a 'message'12:20
ralsinanessita: I only saw the receiving end :-(12:20
nessitaah, I see where12:21
nessitaright, GTK side does not suffer from this12:21
nessitalet me answer the email12:21
nessitagatox says:13:00
nessita(09:12:40 AM) gatox: DONE:13:00
nessita(09:12:40 AM) gatox: Bug #820874 = Branch ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/7193713:00
nessita(09:12:40 AM) gatox: TODO:13:00
nessita(09:12:41 AM) gatox: Finish uninstall issue. Start working on List Styles.13:00
nessita(09:12:42 AM) ubot4: gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private13:00
nessita(09:12:43 AM) gatox: BLOCKED:13:00
nessita(09:12:45 AM) gatox: No13:00
ubot4nessita: Bug 820874 on http://launchpad.net/bugs/820874 is private13:00
nessitafagan, dobey, standup13:00
ubot4nessita: Error: Bug #820874 is private.13:00
ubot4nessita: Bug 820874 on http://launchpad.net/bugs/820874 is private13:00
faganfast mes today13:01
ralsinanessita: go13:01
nessitaDONE: control panel UI tweaks (several bugs were closed!), reviews13:01
nessitaTODO: more reviews, bug #828417, maybe start with the disconnect flow13:01
nessitaBLOCKED: nopes13:01
nessitaNEXT: ralsina13:01
ubot4Launchpad bug 828417 in ubuntu-sso-client "The ping URL is returning 403 FOrbidden (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/82841713:01
ralsinaDONE: reviews, calls, working on bug #828420 bug #828170 bug #827365 bug #825513 TODO: should merge all of those today, hopefully, and start no new ones BLOCKED: no13:01
ubot4Launchpad bug 828420 in ubuntu-sso-client "The CurrentUserController.on_login_error handler fails when the error has no "message" key (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/82842013:01
ubot4Launchpad bug 828170 in ubuntuone-windows-installer "On windows, the control panel fails without credentials (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/82817013:01
ubot4Launchpad bug 827365 in ubuntuone-windows-installer "Add functionality to Congratulations page checkboxes (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/82736513:01
ubot4Launchpad bug 825513 in ubuntuone-windows-installer "The local folders page is not up to spec (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/82551313:01
dobeyλ DONE: chat with lisette, filed bugs for new design, started bug #82816913:01
dobeyλ TODO: finish bug #817133, #82816913:01
dobeyλ BLCK: None.13:01
ubot4Launchpad bug 828169 in ubuntuone-installer "No "Learn more" button (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/82816913:02
ubot4Launchpad bug 817133 in ubuntu "[FFe] [needspackaging] ubuntuone-installer needs packaged (affects: 1) (heat: 12)" [High,Incomplete] https://launchpad.net/bugs/81713313:02
dobeyfagan: go13:02
fagan* had a read down through a good lot of the list of bugs13:02
fagan* reassign and merge duplicates (where needed)13:02
fagan* Nope13:02
ralsinaok, comments?13:03
nessitaralsina: have you aske Chipaca for reviews? so we can try to land all that13:03
nessitaralsina: I'm still oweing you the folders one. The error_message is done.13:03
ralsinanessita: not yet13:03
ralsinanessita: cool. I think the error_message one can land with just your review?13:03
nessitaralsina: yes, but I asked a easy fix13:04
nessitaralsina: there are a couple of cases that have no tests13:04
ralsinaI added them already :)13:04
ralsinaI should probably create a low priority bug about the qt and gtk versions getting different errordicts13:05
nessitaralsina: did you read my email?13:10
nessitaralsina: they are getting different error dicts because we have the dbus layer in between13:10
ralsinayes, maybe we should fix the windows IPC to work more like dbus13:10
ralsinabut I don't really care all that much, as long as we don't have 50 different possible keys13:11
ralsinain any case, it should work now, and we will get reports about "ugly error messages" that should be trivial to fix13:12
nessitaralsina: can I give you a branch to run as u1client and try the installer again? (the credentials part)13:14
nessitaralsina: as always, be sure to run that client and have pythonpaths using it as well13:14
nessitalet me know!13:14
ralsinanessita: sure, in 5'13:14
ralsinanessita: using that ubuntuone-client I still get the 40313:21
nessitaralsina: can I see the trace please?13:21
ralsinanessita: https://pastebin.canonical.com/51406/13:22
ralsinaI will do another run starting sso manually to see if I get a better error there13:22
nessitaralsina: do you have a sso log file?13:24
nessitaOH NO13:24
nessitaralsina: xdg does not work on windows for sso!13:24
nessitasince we migrate the code for u1client only :-/13:25
nessitaralsina: sso can't log to a file because xdg does not work on widnows, no?13:25
ralsinanessita: don't know, haven't checked.13:25
ralsinagood news, the ping now works ;-)13:25
ralsinaI was running an old sso exe13:25
ralsinawith trunk, it worked13:26
nessitathat's great news13:26
nessitabut now it worries me the xdg thingy, anyways, let's file a bug for that13:26
ralsinaconfirmed, I get logs for syncdaemon, controlpanel and installer, but not for sso13:28
nessitaralsina: I realized I did not get this issue when I performs my tests before, because I was using the dbus service, which coerces to unicode13:33
nessitaralsina, facundobatista: https://code.launchpad.net/~nataliabidart/ubuntuone-client/unicode-pingurl/+merge/7203613:34
ralsinanessita: dbus/ipc differences, twice in 24 hours. I am starting to think we will hate that when more people use it.13:35
nessitaralsina: we will :-/13:36
ralsinanessita: +1 after the IRL test and a quick core read13:37
nessitagreat, thanks13:37
gatoxi'm back13:39
nessitahi gatox, I have your review in the review queue, ralsina goes first with 213:45
ralsinagatox: I'll do yours first :-)13:45
gatoxnessita, ralsina  ack13:45
gatoxralsina, i think that is really pretty jeejjeej but you would tell me if something needs fixing13:46
ralsinagatox: I'll try to be thorough13:46
ralsinanessita: about sso and xdg... I will have to duplicate some code since I can't import u1-client13:48
nessitaralsina: yeah. Or we can move the get_special_folders to sso...13:49
nessitaand we import that from u1client13:49
nessitaralsina: but is UGLY13:49
ralsinayes, I will first copy, and then do a branch in u1-client to import from there13:49
ralsinanessita: after the rush I will fork/take wnership of/contribute to pyxdg to make it work on windows, but not right now :-(13:50
ralsinagatox: the things with the warning icons inside the lineedits look like buttons. In fact, I can click them14:06
ralsinagatox: also try this: start typing the name. Delete everything using backspace. You will see the width of the lineedits change14:08
nessitaralsina: question: shouldn't we use the new error build in on_user_registration_error?14:08
nessitainstead of14:08
nessita        errors = [v for _, v in sorted(error.iteritems())]14:08
nessita        self.message_box.critical('\n'.join(errors))14:08
nessitasame for on_email_validation_error14:08
gatoxralsina, who is adding that buttons inside the lineedits?14:08
ralsinawe should use it on all on_*_error methofs14:08
nessitaralsina: shall we change that in this branch?14:09
ralsinanessita: no preference14:09
ralsinashould be easy to do14:09
ralsinagatox: they are done by the EnhancedLineEdit class14:10
ralsinanessita: I'll do it in this branch, so it's more uniform14:10
nessitaralsina: yeah, to fix the tests as well I recommend class inheritance: so, using the newly added CurrentUserControllerErrorTestCase, have on_login_error being a class variable, that new child will override with the new on_*_error14:10
ralsinanessita: good one14:11
nessitaralsina: and in setup, you can do in the parent class:14:11
nessitaself.on_error = gettattr(self.controller, self.method_name)14:11
nessitaonly in the parent14:11
nessitaand then you're done14:11
nessita(plus some search and replace to call self.on_error in the tests)14:11
ralsinanessita: ok, I'll try to do that14:12
nessitaralsina: ask me anything you need! I will move to the folders branch now14:12
ralsinagatox: I have no idea why those would be buttons instead of labels, also14:12
nessitaralsina: silly fix: there are trailing spaces in the test_gui.py, after test_timer_is_stopped14:39
=== m_conley_away is now known as m_conley
nessitaralsina: and please change this self.assertEqual(set(folders), set(expected)) to self.assertEqual(sorted(folders), sorted(expected)), otherwise the real implementation can return [docs, music, docs, pictures] and the UI will show a duplicate, and no test will fail in that case14:40
ralsinanessita: ok, will change14:41
nessitaralsina: there are some leftover, simple comments from yesterday, would you push those as well?14:42
ralsinasure, as soon as I finish the error_message ones14:43
nessitaof course14:53
ralsinanessita: pushed error_message using the new function to generate messages. Found an unimplemented error handler, too.15:12
=== zyga is now known as zyga-afk
* jderose waves back at Chipaca :-D15:18
ralsinanessita: pushed local-folder-fixes with the fixes you mentioned now, and those from yesterday15:35
nessitaralsina: I'm having some lint issyes for error_message15:36
nessitaI added those to the MP15:36
ralsinanessita: sorry, will check them15:36
ralsinanessita: I need to fix my lint because I lose them in the noise :-(15:36
dobeyok, lunch time, and errands. bbiab15:39
ralsinanessita: de-linted15:40
nessitaralsina: error_message looks good, approving16:08
ralsinanessita: cool, thx!16:09
gatoxralsina, this branch is ready: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/7193716:16
* ralsina re-looks16:17
gatoxand you should take a look at this one too: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/improve-EnhancedLineEdit/+merge/72064 for the icon inside the lineedit16:17
ralsinagatox: on setupaccount-form-behaviour, the lineedits still change size when you edit them16:25
ralsinagatox: unless that's fixed by the other branch, of course16:25
gatoxralsina, let me check...... but that should be fixed16:25
ralsinaother than that, it looks really pretty!16:28
gatoxralsina, ahhh yes.. i know what you mean16:28
* gatox fixing16:28
=== JanC_ is now known as JanC
ralsinagatox: another problem: if you connect signals on initializePage, they can be connected more than once. So you either have to disconnect them first, or connect them on __init__ instead16:31
ralsinagatox: and if you disconnect them, make sure you put each on a try/except because disconnected a signal that has not been connected raises a KeyError16:31
gatoxralsina, right!16:32
nessitaralsina: would you know what is causing this warning? http://pastebin.ubuntu.com/669388/16:32
nessitalooks like something is not fully faked?16:32
ralsinagatox: I know this was probably wrong in code I wrote and you used ;-)16:32
gatoxralsina, i think that the best choice is to disconnect them to avoid receiving every focus changed if we are in another page16:32
ralsinagatox: that's harder than you think, because there is no "the user is now in another page" signal :-(16:33
ralsinagatox: AFAIK, at least16:33
gatoxralsina, but when you leave setup_account16:33
gatoxor don't?16:33
ralsinagatox: Oh, right, this one doesn't have a "Next" button :-D16:34
ralsinagatox: yes, you can do that in the "sign up" button's clicked slot16:34
ralsinaunless of course, the sign up fails and you don't leave the page, but I know you can handle it :-)16:34
ralsinanessita: not sure really. I ll  take a look16:35
gatoxralsina, okkk16:35
nessitaralsina: ack, I'll grab a quick lunch16:36
ralsinanessita: that error is harmless. I am only testing the error method (which is the only thingI reimplemented) but the parent class has a __del__ method that does stuff, so yes, there is a fake backend missing, but it's not used in the test.16:51
ralsinaand I stop for lunch too16:57
nessitaralsina: ok, so, not sure if you are fixing something or not :-)17:16
ralsinanessita: well, I am not sure about adding a branch for that today, but will do it eventually? ;-)17:16
dobeywell that took longer than i'd hoped for :-/17:18
gatoxralsina, done with the branch!!17:25
gatoxralsina, both of them17:25
gatoxnessita, ^17:25
nessitagatox: please let me know when both are approved by ralsina, so I can review after him :-)17:25
ralsinanessita: filed https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/82893817:25
ubot4Launchpad bug 828938 in ubuntuone-windows-installer "Error on test_forgotten_password_controller_error (affects: 1) (heat: 6)" [Low,New]17:26
gatoxnessita, ok17:26
ralsinagatox: should have the first one about 45 minutes from now, right ater milanesas ;-)17:26
gatoxralsina, jejeje17:26
gatoxi've just eat polenta y tomate :S17:26
=== beuno is now known as beuno-lunch
nhainesHmm, some time I'll have to try polenta.17:38
gatoxnhaines, is good... but... it's not a big plate of meat! jeje17:39
nhainesgatox: that must be what you eat it with!  hehe17:42
gatoxnhaines, ...... no :(....... i eat it with tomate........ to healthy for my taste17:42
nhainesTomatos are what I eat with kabab koobideh so I feel more healthy, hehehe.17:43
gatoxLOL :P17:44
dobeytomatoes are great for making catsup17:44
ralsinaI'm back17:45
nhainesralsina: how was lunch?17:45
ralsinanhaines: awesome!17:45
nhainesralsina: what did you have?17:46
ralsinagatox: the connect problem we mentioned is also for things like "textEdited.connect(self.name_assistance)". Those should move to __init__ I think17:47
ralsinanhaines: milanesas + salad17:47
gatoxralsina, oh right!17:48
nhainesralsina: oh, I've had something similar before, but without the salad.  :)  Nice!17:48
ralsinagatox: again, sorry about making you change code I wrote wrong ;-)17:48
gatoxralsina, no problem!17:48
nessitaralsina: can you please explain to me why there is a while true inside update_sizes?17:50
nessitaat first sight it does no luck so "healthy"17:50
ralsinagatox: also, you could add tests that after initializePage, calling setFocus() on each widget triggers the right method17:50
ralsinanessita: it's reading from a queue, it will be empty eventually17:50
ralsinanessita: and the number of items in the que is less or equal than the number of items17:51
ralsina"of items in the list"17:51
gatoxralsina, sorry..... don't follow about calling setFocus17:52
ralsinagatox: on initializePage you connect to watch for focus changes. Then you should test that if, for example self.ui.password_edit gets focus, password_assistance is visible17:53
gatoxralsina, ahhhhhhhh ok ok17:54
gatoxnow i understand17:54
* gatox is adding tests...17:54
nessitaralsina: what do you think of changing the implementation to the second option here? http://pastebin.ubuntu.com/669443/17:55
nessitaralsina: it was really difficult for me to read the first implementation17:55
ralsinanessita: I am not a big fan of try/except/else but if you like it better it's ok for me17:56
nessitaralsina: using else is more recommended that having a long block inside the try:ecept17:56
nessitaralsina: you may be catchihng more exception than expected (not specific to this case)17:57
ralsinaok, changing it17:57
nessitaralsina: another question, any reason to cast to long in  total = long(self.account_info['quota_used'])?17:57
ralsinanessita: yes, in some cases it's an int :-(17:57
nessitaralsina: and what's the problem with that?17:58
* nessita does not follow17:58
dobeyMAXING isn't very high17:58
dobeyerr MAXINT17:58
nessitaIn [3]: int('1234567899999999999999')17:58
nessitaOut[3]: 1234567899999999999999L17:58
ralsinanessita: I check that it's a long to decide what to do. It can be int or long, so I cast to long17:58
nessitaralsina: but why not casting to int every single time?17:59
ralsinanessita: yes, but isinstance(long(1), int) == False17:59
ralsinanessita: because sometimes it's a long17:59
ralsinaso since I have to cast, I cast to the bigger type17:59
nessitaralsina: but why not casting to int? the "isinstance(long(1), int) == False" does not gives me an answer I can understand18:00
dobeyyeah you never cast to smaller type18:00
ralsinanessita: 1GB is a long, for example18:00
dobeynessita: because you can't cast from a long to an int, for any value that is greater than MAXINT18:00
nessitaralsina: you can cast the string representing 1GB with int() and is the same18:00
nessitadobey: yes you can, I just showed you18:00
nessitaIn [3]: int('1234567899999999999999')18:00
nessitaOut[3]: 1234567899999999999999L18:00
dobeynessita: what you showed me was that int (string) will return a long :)18:01
nessitadobey: and that is what ralsina is doing18:01
ralsinanessita: int(a long > maxint) is a long18:01
nessitais ok, but having a cast to long is confusing...18:01
ralsinasince I want to convert to a long, why would I cast to an int?18:01
nessitaI never seen a cast to long() before in our code18:01
dobeyi don't think so *shrug*18:01
ralsinanessita: I had never seen a class implement a useful __del__ before today either ;-)18:01
dobeyour code doesn't generally deal with large numbers i guess18:01
dobeyralsina: tarmac has a class that does ;)18:02
nessitadobey: we always deal with large number when it comes to quota18:02
ralsinanessita: basically, I can have an int (ex: 0) a long (ex: 100000*) or a string ("calculating")18:02
ralsinaforget that, I am nt remembering the code right18:03
dobeynessita: i agree in Python it probably matters less though18:03
nessitaralsina: this18:03
nessitaif isinstance(total, long):18:03
nessitashould be18:03
nessitaif total > 0: ... humanize...18:03
dobeybut i don't see a problem with explicitly casting to long18:03
nessitadobey: me neither, other than being confusing from the rest of the code I've been reading and writing within our projects18:04
ralsinanessita: first, I set total to a number.18:04
ralsinanessita: but of there is an item that doesn't have a value, I set it to a string18:04
ralsinaso later I check if it's a long or a string18:04
ralsinaI could not do the cast and check if it's a string18:05
nessitaralsina: let's do something a bit cleaner, let me propose a code snippet18:05
ralsinanessita: ok18:05
dobeynessita: i don't think it's confusing. stop trying to extrapolate it to all the code you've read/written in our projects, and deal with only the piece of work that code needs to deal with, to understand it :)18:06
nessitaralsina: also, with your code, I think that we may be, in some cases, summing up a string with an item.size?18:07
ralsinanessita: no, we won't18:07
nessitaralsina: how do we ensure that?18:07
ralsinanessita: the only case where total becomes a string, it breaks out of the loop where we add sizes to it18:07
nessitaah, right, is a break not a continue...18:08
nessitaralsina: can we have an item with size None and another with size not None?18:08
ralsinanessita: yes18:08
ralsinaand in that case the total is not defined yet and we show a non-number string18:09
nessitaralsina: we don't show any numeric quota usage in that case? (but the string caclulating?)18:09
ralsinanessita: exactly18:09
ralsinaverterok: ping18:11
nessitaralsina: something like http://pastebin.ubuntu.com/669455/18:12
ralsinanessita: that fails if the user has no UDFs created and selects nothing (shows "calculating")18:12
nessitaah, you're right18:13
ralsinahow about I cast to int, and instead of isinstace(long) I use isinstance(unicode)?18:14
nessitaralsina: no need to change for now18:14
nessitaralsina: is there a test for the case you described? (user has no udfs and...)18:14
ralsinaI can add a # XXX not pretty ;-)18:15
nessitacan be18:15
ralsinanessita: good question. I'll check and add one if there is not18:15
nessitaralsina: I'll add that to the MP., I've added another tweaks already18:15
ralsinanessita: cool, thx18:15
dobeyyay me18:16
nessitaralsina: I added a few needs fixing, and a question/suggestion in the end18:22
ralsinanessita: cool, will get to them in 5'18:22
nessitaralsina: no rush18:22
ralsinanessita: and thanks for this review, I know it's long :-(18:22
nessitaralsina: can I have a review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/new-creds/+merge/7207718:22
ralsinanessita: sure18:22
=== beuno-lunch is now known as beuno
nessitaralsina: I just filled bug #828983, but let me know if that flow does not apply to the installer (see attachment for the installer) given what you're implementing now18:38
ubot4nessita: Bug 828983 on http://launchpad.net/bugs/828983 is private18:38
ralsinanessita: you can't really go over quota in the installer. What happens now is that if you choose too much stuff to sync, we offer a chance to buy space, but it won't stop you from continuing18:39
nessitaralsina: ok, I just filed the bug after refloating a email from lisette, fell free to add a comment and close as invalid in the installer18:43
ralsinanessita: ack18:43
nessitagatox: ping!18:52
gatoxnessita, pong18:52
nessitagatox: would you give me a hand with https://bugs.launchpad.net/ubuntuone-control-panel/+bug/822688? I would like to learn gradients in the qss. Current style for tan hover is18:52
nessita    163     background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1,18:52
nessita    164         stop: 0 #fafafa, stop: 0.4 #f4f4f4,18:52
nessita    165         stop: 0.5 #e7e7e7, stop: 1.0 #fafafa);18:52
ubot4nessita: Error: Bug #822688 is private.18:52
nessitagatox: what does the stops mean?18:52
nessitagatox: or, now that I read the bug report again, is lisette asking us to remove the gradient and add a solid color for the whole tab?18:54
gatoxnessita, it is where that color ends (if i'm no wrong)18:54
gatoxnessita, but i've never see so many stops :P18:55
nessitagatox: if your styling! :-D18:55
nessitaisn't it?18:55
gatoxnessita, really??18:55
ralsinanessita: +1 on new-creds18:55
nessitagatox: well I did not add that. Let me bzr blame it :-D18:56
gatoxnessita, jjee ok18:56
* gatox is having amnesia18:57
nessitagatox: well, I'm marked as last modifier, but I likely fixed some spacing18:57
nessitagatox: what do you think lisette is requesting there?18:57
nessitaa solid color or another gradient?18:57
gatoxnessita, ahhh no, she is asking to show a solid color on hover...... and use the same color as the start of the gradient but for all the tab18:59
gatoxnessita, that's what i'm understand18:59
gatoxi understand*18:59
nessitagatox: ok, I'll implement that (I think that she's requesting that as well)18:59
gatoxralsina, you can re-review my branch19:07
ralsinagatox: on it!19:08
gatoxralsina, awesome! thanks19:08
gatoxralsina, nessita EOD for me..... i'll be connected anyhow... please let me know if the branches are ok or need fixing19:25
ralsinagatox: ok, se you tomorrow!19:25
nessitagatox: bye!19:25
nessitatrivialisima review! https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/preferences-is-settings/+merge/7209019:32
beunonessita, +119:33
nessitabeuno: thanks!19:34
ralsinanessita: finished with the fixes for local_folders19:49
nessitaralsina: if I restart that review tomorrow, would that be too late?19:50
ralsinaIt would only mean that I would put it in tonight release manually, really19:50
nessitaI guess yes...19:50
ralsinabut I totally understand wanting to set that branch on fire :-)19:51
nessitaralsina: can we do that, so I have a more fresh mind when giving the last review? (I'm sure it will be the last :-))19:51
nessitaralsina: also, I would love if Chipacaa reviews it tomorrow his morning first, so we have another set of eyes in it. So, when I starts working tomorrow morning, I re-review it and we land it19:52
ralsinacool, will put it in tonight's mail19:52
nessitagreat, thanks19:52
ralsinanessita: do you have any pending branches you expect to finish for today?19:52
nessitaralsina: yes, the disconnect flow19:52
nessitaI'm 35% done19:52
ralsinaRight now, I am thinking of adding alecu's branches, both of diego's (they do work, mostly), my local folders branch, and probably the one that starts u1cp if there are credentials19:54
nessitaoh! alecu's branch! I need to do that review!20:03
nessitaralsina: how many alecu's branches are there?>20:03
ralsinanessita: the one about the clock, and the one for the watches20:03
dobeyi need a review. it's very easy :)20:04
nessitaralsina: I'll review those20:04
ralsinathe clock one has a review request for verterook20:04
ralsinadobey: shoot!20:05
nessitaverterok: ping20:06
nessitaralsina: I'm thinking... what about closing the app after the user removes the current device? since we already show the warning "are you sure you want to remove this device?", we could append "If you choose yes, the application will close. You can sign in again by starting Ubuntu One from the <launcher/program list>"20:10
nessitaralsina: is that too cheesy?20:10
ralsinaIt makes things much simpler20:11
ralsinaYou should remove all metadata when removing the device, though20:11
dobeyi'm not sure about that20:13
nessitaralsina: hum, that is pretty risky, we don't it anywhere so far (anywhere == not even in ubuntu). I agree that we shoudl, in all plaforms, but maybe that should be a separated bug to implement in the control panel backend (and both OS will benefit from that). I know what you're pointing out, if the user opens the installer, s/he will be able to login. BUt the same will happen if we offer only to re-signin in the controller, and they close the app and re-20:13
nessitaable to *register* I meant20:14
nessitaand s/controller/control panel20:14
ralsinahe could just login with another account of course20:14
nessitaalso that20:14
ralsinaso, it would not be more dangerous than currently. Which is pretty dangerous but people manage ;-)20:14
nessitaralsina: right. So, what do you say? (I will email lisette if you agree)20:15
dobeyeh, i don't think it's worth doing20:16
ralsinayes, ask her if that's good, it's much less work than what we had planned20:16
nessitadobey: doing what? the metadata removal or the other thing?20:16
dobeyboth, but the metadata removal is what really worries me20:16
nessitaralsina: I will pause this and do some other (tons of) bug I have left :-)20:17
ralsinanessita: cool20:17
nessitadobey: I agree is very risky and can't be done quickly nor without thinking it through20:17
nessitadobey: the other thing has to be done... users can remove the local device by design20:17
dobeyi don't see why we have to just close the control panel though20:20
dobeyit should just hide everything and go back to the join/sign-in screen20:20
nessitadobey: there is no such screen in windows control panel, is the installer who has it20:21
dobeyso what happens if i remove the local machine on windows, and then open the control panel again?20:22
dobeyor what happens if i just install, and don't sign in yet?20:22
dobeylike perhaps because i'm IT at some business and am installing it to allow my users to be able to access it20:23
nessitadobey: how would you open the control panel?20:23
nessitathe "Ubuntu One" icon runs the wizard, and if there are credentials present in the system, it launches the control panel. So for an end user, they both are the same app20:24
dobeywhat do you mean? you're proposing everything will be uninstalled when disassociating the local machine?20:24
nessitadobey: and yes, it makes sense to unify this code into the control panel source tree at some point, so we can benefit from the wizard in ubuntu20:24
dobeyi am not sure about that :-/20:25
dobeybut i don't think i want to think about it any more right now20:25
nessitais ok20:25
nessitaralsina: when we have time (JUAZ) to port the installer + qt sso to linux,  we _could_ move the installer code into the control panel source tree (just an idea)20:26
ralsinanessita: yes20:27
nessitaralsina: https://code.launchpad.net/~alecu/ubuntuone-client/watch-finished-deferred/+merge/71955 is approved, I think it needs a second review20:33
ralsinanessita: I have checked the code yesterday, but I am really shaky on what it *does* beyond generalities20:34
nessitaralsina: we can ask some chicharrero to look at, maybe lucio?20:35
ralsinaSo, I can give it an approval but it's not exactly a "hey, I know what this fixes and I love it"20:35
ralsinanessita: yeah, that would be a better idea, I think. OTOH, they will tell you they don't know what the windows code does ;-)20:35
nessitaralsina: they can ask the parts they don't understand... I guess20:35
ralsinanessita: yeah, let's ask. And if they don't see anything too obvious, let's merge it tomorrow20:36
dobeyalright, i am off20:50
dobeyhave a good evening all20:50
=== m_conley is now known as m_conley_away
=== yofel_ is now known as yofel
nessitaralsina: ping21:27
ralsinanessita: pong21:27
nessitaralsina: question: would you know why I can't pain the background of the ControlPanel widget inside the controlpanel QT UI? I'm setting a style like this21:29
nessita       ControlPanel {21:29
nessita           background-color: black;21:29
nessita      }21:29
nessitaand that will not paint the damn thing :-)21:29
nessitaControlPanel is a QWidget21:29
nessitaI also tried Qwidget#control_panel21:29
nessitaI could paint all the widgets by trying tith QWidget{background-color: black;}21:29
ralsinais controlpanel a class or the widget name?21:29
nessitaralsina: ControlPanel the class name, control_panel the instance name21:30
nessita     49 class ControlPanel(QtGui.QWidget):21:30
ralsinaok. Now, does it have any visible parts?21:30
nessitayes, it does, but let me triple check21:30
ralsinaor is all covered by other stuff?21:30
nessitaralsina: in designer I see some free sections, let me grab a screenshot21:31
ralsinanessita: I think I know what it is, give me 2' to check21:32
nessitaralsina: http://ubuntuone.com/p/1BHR/21:33
nessitaralsina: see how the margins are 5, I would expect that to be black21:33
ralsinanessita: QWidget supports only "background"21:36
ralsinacheck http://doc.qt.nokia.com/latest/stylesheet-reference.html21:37
ralsinano idea if that is the real problem though21:37
nessitaralsina: is not, I tried background as well21:37
ralsinait also says that i fyou inherit QWidget you have to implement paintEvent for stylesheets to do something21:38
nessitathat sounds like it21:40
nessitaralsina: thanks!21:40
ralsinathank me when it works ;-)21:40

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!