| alecu | eow! | 00:16 |
|---|---|---|
| karni | nhaines: how do you like that http://ubuntuone.com/p/1B7X/ | 00:33 |
| karni | Good night #ubuntuone! | 00:34 |
| dholbach | hiya | 09:45 |
| dholbach | can anyone of the U1 Couch people have a look at https://code.launchpad.net/~wibblymat/ubuntu/oneiric/couchdb/update-to-1.1.0/+merge/69702 and give their input to an update to 1.1.0 and the patches and everything? | 09:46 |
| * fagan doesnt even know who is couch now | 09:49 | |
| dholbach | couchdb | 09:49 |
| fagan | I mean who is working on it | 09:50 |
| fagan | I now have a keyboard that is built like a typewriter | 09:58 |
| fagan | not to look like one but inside its one | 09:58 |
| karni | Good morning! | 10:01 |
| rye | karni, i saw the screenshot - http://ubuntuone.com/p/1B7X/ - looks very related to my interests | 10:10 |
| karni | rye: (Im' glad!) Which are exactly :)? | 10:11 |
| karni | Progress indication and simultaneous up/downloads? | 10:11 |
| rye | karni, yep, /me likes progress indicators! | 10:18 |
| karni | rye: cool :) | 10:18 |
| karni | People were asking about them. | 10:18 |
| * Chipaca waves at jderose | 10:50 | |
| dholbach | hey Chipaca - how are you doing? | 10:54 |
| Chipaca | dholbach: hi there | 10:54 |
| Chipaca | dholbach: a bit tired, but good. you? | 10:54 |
| dholbach | a bit tired as well, but doing alright - thanks :) | 10:55 |
| dholbach | Chipaca, somebody worked on a merge of couchdb 1.1.0 from debian - it mostly looks OK from a sponsor-the-update-into-Ubuntu POV, who would be a good person on the U1 team to double check it? | 10:55 |
| dholbach | https://code.launchpad.net/~wibblymat/ubuntu/oneiric/couchdb/update-to-1.1.0/+merge/69702 is the MP in question | 10:56 |
| Chipaca | dholbach: ok, i'll look at it (or have somebody do it) | 10:57 |
| * dholbach hugs Chipaca | 10:57 | |
| dholbach | awesome - thanks muchly | 10:57 |
| Chipaca | also, wibblymat is a +2 nick | 10:57 |
| dholbach | ah, good to know! | 11:05 |
| dholbach | just as a heads-up: the new couchdb might need a feature freeze exception | 11:05 |
| nessita | hello everyone! | 11:13 |
| karni | Good day nessita ! | 11:13 |
| nessita | hello karni! | 11:14 |
| gatox | nessita, hi | 11:14 |
| nessita | hi gatox | 11:14 |
| gatox | nessita, i'm adding some changes to a new branch... would you be able to review?? it's almost done | 11:14 |
| nessita | gatox: I'm always able to! I may be less or more slow in the process, but always shoot | 11:16 |
| gatox | nessita, thanks! i'm adding more tests right now... i found that something wasn't being tested... so i'll let you know when it's ready :D | 11:17 |
| nessita | great! | 11:17 |
| Chipaca | dholbach: pedronis will try to look at that mp tomorrow | 11:25 |
| Chipaca | dholbach: does that timing work? | 11:26 |
| dholbach | sure sure - we're in feature freeze anyway, so if it makes sense to get it in and we have some good justification, better get it in now than even later | 11:26 |
| dholbach | thanks a bunch | 11:26 |
| Chipaca | cheers | 11:26 |
| gatox | nessita, done! https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 | 11:38 |
| nessita | gatox: can you please commit with --fixes so the bug gets linked? | 11:39 |
| gatox | nessita, ok | 11:39 |
| gatox | nessita, done | 11:40 |
| nessita | gatox: ack | 11:50 |
| gatox | nessita, i have to leave in a while, if i don't return for standup, should i give you the report of my tasks to you? | 12:07 |
| nessita | gatox: yes please | 12:07 |
| gatox | nessita, ok..... writing.... | 12:07 |
| ralsina | good morning! | 12:08 |
| nessita | hi ralsina | 12:08 |
| ralsina | hi nessita | 12:08 |
| ralsina | any ideas on the 403? | 12:08 |
| gatox | ralsina, hi | 12:08 |
| ralsina | hi gatox | 12:08 |
| gatox | nessita, this is my standup: | 12:12 |
| gatox | DONE: | 12:12 |
| gatox | Bug #820874 = Branch ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 | 12:12 |
| gatox | TODO: | 12:12 |
| gatox | Finish uninstall issue. Start working on List Styles. | 12:12 |
| ubot4 | gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private | 12:12 |
| gatox | BLOCKED: | 12:12 |
| gatox | No | 12:12 |
| nessita | ralsina: yes, I'm working on it (replying to your email as well) | 12:13 |
| ralsina | nessita: ok, cool | 12:13 |
| nessita | ralsina: would you know what encoding has the bytes strings returned by platform module? | 12:14 |
| ralsina | nessita: no idea | 12:14 |
| ralsina | BTW: if anyone ever gets 30+ failing tests on sso-client? Check that it's not running. Scared the crap out of me. | 12:14 |
| nessita | ralsina: hum? | 12:15 |
| ralsina | nessita: on windows, because we are using a "real" tcp port, I think | 12:15 |
| nessita | ralsina: where are you getting the "error_message" from? | 12:20 |
| nessita | except_to_errdict in main/__init__.py sends a 'message' | 12:20 |
| ralsina | nessita: I only saw the receiving end :-( | 12:20 |
| nessita | ah, I see where | 12:21 |
| nessita | right, GTK side does not suffer from this | 12:21 |
| nessita | let me answer the email | 12:21 |
| ralsina | ok | 12:21 |
| gatox | brb | 12:23 |
| nessita | me | 13:00 |
| ralsina | me | 13:00 |
| nessita | gatox says: | 13:00 |
| nessita | (09:12:40 AM) gatox: DONE: | 13:00 |
| nessita | (09:12:40 AM) gatox: Bug #820874 = Branch ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 | 13:00 |
| nessita | (09:12:40 AM) gatox: TODO: | 13:00 |
| nessita | (09:12:41 AM) gatox: Finish uninstall issue. Start working on List Styles. | 13:00 |
| nessita | (09:12:42 AM) ubot4: gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private | 13:00 |
| nessita | (09:12:43 AM) gatox: BLOCKED: | 13:00 |
| nessita | (09:12:45 AM) gatox: No | 13:00 |
| ubot4 | nessita: Bug 820874 on http://launchpad.net/bugs/820874 is private | 13:00 |
| nessita | fagan, dobey, standup | 13:00 |
| nessita | ? | 13:00 |
| ubot4 | nessita: Error: Bug #820874 is private. | 13:00 |
| dobey | me | 13:00 |
| ubot4 | nessita: Bug 820874 on http://launchpad.net/bugs/820874 is private | 13:00 |
| fagan | md | 13:00 |
| fagan | me | 13:00 |
| fagan | fast mes today | 13:01 |
| ralsina | nessita: go | 13:01 |
| nessita | DONE: control panel UI tweaks (several bugs were closed!), reviews | 13:01 |
| nessita | TODO: more reviews, bug #828417, maybe start with the disconnect flow | 13:01 |
| nessita | BLOCKED: nopes | 13:01 |
| nessita | NEXT: ralsina | 13:01 |
| ubot4 | Launchpad bug 828417 in ubuntu-sso-client "The ping URL is returning 403 FOrbidden (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/828417 | 13:01 |
| ralsina | DONE: reviews, calls, working on bug #828420 bug #828170 bug #827365 bug #825513 TODO: should merge all of those today, hopefully, and start no new ones BLOCKED: no | 13:01 |
| ubot4 | Launchpad bug 828420 in ubuntu-sso-client "The CurrentUserController.on_login_error handler fails when the error has no "message" key (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/828420 | 13:01 |
| ubot4 | Launchpad bug 828170 in ubuntuone-windows-installer "On windows, the control panel fails without credentials (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/828170 | 13:01 |
| ubot4 | Launchpad bug 827365 in ubuntuone-windows-installer "Add functionality to Congratulations page checkboxes (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/827365 | 13:01 |
| ubot4 | Launchpad bug 825513 in ubuntuone-windows-installer "The local folders page is not up to spec (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/825513 | 13:01 |
| dobey | λ DONE: chat with lisette, filed bugs for new design, started bug #828169 | 13:01 |
| dobey | λ TODO: finish bug #817133, #828169 | 13:01 |
| dobey | λ BLCK: None. | 13:01 |
| ubot4 | Launchpad bug 828169 in ubuntuone-installer "No "Learn more" button (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/828169 | 13:02 |
| ubot4 | Launchpad bug 817133 in ubuntu "[FFe] [needspackaging] ubuntuone-installer needs packaged (affects: 1) (heat: 12)" [High,Incomplete] https://launchpad.net/bugs/817133 | 13:02 |
| dobey | fagan: go | 13:02 |
| fagan | DONE | 13:02 |
| fagan | * had a read down through a good lot of the list of bugs | 13:02 |
| fagan | TODO | 13:02 |
| fagan | * reassign and merge duplicates (where needed) | 13:02 |
| fagan | BLOCKED | 13:02 |
| fagan | * Nope | 13:02 |
| ralsina | ok, comments? | 13:03 |
| nessita | ralsina: have you aske Chipaca for reviews? so we can try to land all that | 13:03 |
| nessita | ralsina: I'm still oweing you the folders one. The error_message is done. | 13:03 |
| ralsina | nessita: not yet | 13:03 |
| ralsina | nessita: cool. I think the error_message one can land with just your review? | 13:03 |
| nessita | ralsina: yes, but I asked a easy fix | 13:04 |
| nessita | ralsina: there are a couple of cases that have no tests | 13:04 |
| ralsina | I added them already :) | 13:04 |
| ralsina | I should probably create a low priority bug about the qt and gtk versions getting different errordicts | 13:05 |
| nessita | ralsina: did you read my email? | 13:10 |
| nessita | ralsina: they are getting different error dicts because we have the dbus layer in between | 13:10 |
| ralsina | yes, maybe we should fix the windows IPC to work more like dbus | 13:10 |
| nessita | ah | 13:10 |
| ralsina | but I don't really care all that much, as long as we don't have 50 different possible keys | 13:11 |
| nessita | true | 13:11 |
| ralsina | in any case, it should work now, and we will get reports about "ugly error messages" that should be trivial to fix | 13:12 |
| nessita | ralsina: can I give you a branch to run as u1client and try the installer again? (the credentials part) | 13:14 |
| ralsina | sure | 13:14 |
| nessita | lp:~nataliabidart/ubuntuone-client/unicode-pingurl | 13:14 |
| nessita | ralsina: as always, be sure to run that client and have pythonpaths using it as well | 13:14 |
| nessita | let me know! | 13:14 |
| ralsina | nessita: sure, in 5' | 13:14 |
| ralsina | nessita: using that ubuntuone-client I still get the 403 | 13:21 |
| nessita | ralsina: can I see the trace please? | 13:21 |
| ralsina | nessita: https://pastebin.canonical.com/51406/ | 13:22 |
| ralsina | I will do another run starting sso manually to see if I get a better error there | 13:22 |
| nessita | thanks | 13:22 |
| nessita | ralsina: do you have a sso log file? | 13:24 |
| nessita | wait... | 13:24 |
| nessita | OH NO | 13:24 |
| nessita | ralsina: xdg does not work on windows for sso! | 13:24 |
| ralsina | ? | 13:25 |
| nessita | since we migrate the code for u1client only :-/ | 13:25 |
| nessita | ralsina: sso can't log to a file because xdg does not work on widnows, no? | 13:25 |
| ralsina | nessita: don't know, haven't checked. | 13:25 |
| ralsina | good news, the ping now works ;-) | 13:25 |
| ralsina | I was running an old sso exe | 13:25 |
| ralsina | with trunk, it worked | 13:26 |
| nessita | ah! | 13:26 |
| nessita | that's great news | 13:26 |
| nessita | but now it worries me the xdg thingy, anyways, let's file a bug for that | 13:26 |
| ralsina | confirmed, I get logs for syncdaemon, controlpanel and installer, but not for sso | 13:28 |
| nessita | ralsina: I realized I did not get this issue when I performs my tests before, because I was using the dbus service, which coerces to unicode | 13:33 |
| nessita | ralsina, facundobatista: https://code.launchpad.net/~nataliabidart/ubuntuone-client/unicode-pingurl/+merge/72036 | 13:34 |
| ralsina | nessita: dbus/ipc differences, twice in 24 hours. I am starting to think we will hate that when more people use it. | 13:35 |
| nessita | ralsina: we will :-/ | 13:36 |
| ralsina | nessita: +1 after the IRL test and a quick core read | 13:37 |
| nessita | great, thanks | 13:37 |
| gatox | i'm back | 13:39 |
| nessita | @ping | 13:45 |
| ubot4 | pong | 13:45 |
| nessita | hi gatox, I have your review in the review queue, ralsina goes first with 2 | 13:45 |
| ralsina | gatox: I'll do yours first :-) | 13:45 |
| gatox | nessita, ralsina ack | 13:45 |
| gatox | ralsina, i think that is really pretty jeejjeej but you would tell me if something needs fixing | 13:46 |
| gatox | jejee | 13:46 |
| ralsina | gatox: I'll try to be thorough | 13:46 |
| ralsina | nessita: about sso and xdg... I will have to duplicate some code since I can't import u1-client | 13:48 |
| nessita | ralsina: yeah. Or we can move the get_special_folders to sso... | 13:49 |
| nessita | and we import that from u1client | 13:49 |
| nessita | ralsina: but is UGLY | 13:49 |
| ralsina | yes, I will first copy, and then do a branch in u1-client to import from there | 13:49 |
| ralsina | nessita: after the rush I will fork/take wnership of/contribute to pyxdg to make it work on windows, but not right now :-( | 13:50 |
| nessita | right | 13:50 |
| ralsina | gatox: the things with the warning icons inside the lineedits look like buttons. In fact, I can click them | 14:06 |
| ralsina | gatox: also try this: start typing the name. Delete everything using backspace. You will see the width of the lineedits change | 14:08 |
| nessita | ralsina: question: shouldn't we use the new error build in on_user_registration_error? | 14:08 |
| nessita | instead of | 14:08 |
| nessita | errors = [v for _, v in sorted(error.iteritems())] | 14:08 |
| nessita | self.message_box.critical('\n'.join(errors)) | 14:08 |
| nessita | same for on_email_validation_error | 14:08 |
| gatox | ralsina, who is adding that buttons inside the lineedits? | 14:08 |
| ralsina | we should use it on all on_*_error methofs | 14:08 |
| nessita | ralsina: shall we change that in this branch? | 14:09 |
| ralsina | nessita: no preference | 14:09 |
| ralsina | should be easy to do | 14:09 |
| ralsina | gatox: they are done by the EnhancedLineEdit class | 14:10 |
| ralsina | nessita: I'll do it in this branch, so it's more uniform | 14:10 |
| nessita | ralsina: yeah, to fix the tests as well I recommend class inheritance: so, using the newly added CurrentUserControllerErrorTestCase, have on_login_error being a class variable, that new child will override with the new on_*_error | 14:10 |
| ralsina | nessita: good one | 14:11 |
| nessita | ralsina: and in setup, you can do in the parent class: | 14:11 |
| nessita | self.on_error = gettattr(self.controller, self.method_name) | 14:11 |
| nessita | only in the parent | 14:11 |
| nessita | and then you're done | 14:11 |
| nessita | (plus some search and replace to call self.on_error in the tests) | 14:11 |
| ralsina | nessita: ok, I'll try to do that | 14:12 |
| nessita | ralsina: ask me anything you need! I will move to the folders branch now | 14:12 |
| ralsina | gatox: I have no idea why those would be buttons instead of labels, also | 14:12 |
| nessita | ralsina: silly fix: there are trailing spaces in the test_gui.py, after test_timer_is_stopped | 14:39 |
| === m_conley_away is now known as m_conley | ||
| nessita | ralsina: and please change this self.assertEqual(set(folders), set(expected)) to self.assertEqual(sorted(folders), sorted(expected)), otherwise the real implementation can return [docs, music, docs, pictures] and the UI will show a duplicate, and no test will fail in that case | 14:40 |
| ralsina | nessita: ok, will change | 14:41 |
| nessita | thanks | 14:41 |
| nessita | ralsina: there are some leftover, simple comments from yesterday, would you push those as well? | 14:42 |
| ralsina | sure, as soon as I finish the error_message ones | 14:43 |
| nessita | of course | 14:53 |
| ralsina | nessita: pushed error_message using the new function to generate messages. Found an unimplemented error handler, too. | 15:12 |
| nessita | great! | 15:12 |
| === zyga is now known as zyga-afk | ||
| * jderose waves back at Chipaca :-D | 15:18 | |
| ralsina | nessita: pushed local-folder-fixes with the fixes you mentioned now, and those from yesterday | 15:35 |
| nessita | ralsina: I'm having some lint issyes for error_message | 15:36 |
| nessita | I added those to the MP | 15:36 |
| ralsina | nessita: sorry, will check them | 15:36 |
| ralsina | nessita: I need to fix my lint because I lose them in the noise :-( | 15:36 |
| nessita | :-/ | 15:36 |
| dobey | ok, lunch time, and errands. bbiab | 15:39 |
| ralsina | nessita: de-linted | 15:40 |
| nessita | ralsina: error_message looks good, approving | 16:08 |
| ralsina | nessita: cool, thx! | 16:09 |
| gatox | ralsina, this branch is ready: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 | 16:16 |
| * ralsina re-looks | 16:17 | |
| gatox | and you should take a look at this one too: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/improve-EnhancedLineEdit/+merge/72064 for the icon inside the lineedit | 16:17 |
| ralsina | gatox: on setupaccount-form-behaviour, the lineedits still change size when you edit them | 16:25 |
| ralsina | gatox: unless that's fixed by the other branch, of course | 16:25 |
| gatox | ralsina, let me check...... but that should be fixed | 16:25 |
| ralsina | other than that, it looks really pretty! | 16:28 |
| gatox | ralsina, ahhh yes.. i know what you mean | 16:28 |
| * gatox fixing | 16:28 | |
| === JanC_ is now known as JanC | ||
| ralsina | gatox: another problem: if you connect signals on initializePage, they can be connected more than once. So you either have to disconnect them first, or connect them on __init__ instead | 16:31 |
| ralsina | gatox: and if you disconnect them, make sure you put each on a try/except because disconnected a signal that has not been connected raises a KeyError | 16:31 |
| gatox | ralsina, right! | 16:32 |
| nessita | ralsina: would you know what is causing this warning? http://pastebin.ubuntu.com/669388/ | 16:32 |
| nessita | looks like something is not fully faked? | 16:32 |
| ralsina | gatox: I know this was probably wrong in code I wrote and you used ;-) | 16:32 |
| gatox | ralsina, i think that the best choice is to disconnect them to avoid receiving every focus changed if we are in another page | 16:32 |
| ralsina | gatox: that's harder than you think, because there is no "the user is now in another page" signal :-( | 16:33 |
| ralsina | gatox: AFAIK, at least | 16:33 |
| gatox | ralsina, but when you leave setup_account | 16:33 |
| gatox | or don't? | 16:33 |
| ralsina | gatox: Oh, right, this one doesn't have a "Next" button :-D | 16:34 |
| ralsina | gatox: yes, you can do that in the "sign up" button's clicked slot | 16:34 |
| ralsina | unless of course, the sign up fails and you don't leave the page, but I know you can handle it :-) | 16:34 |
| ralsina | nessita: not sure really. I ll take a look | 16:35 |
| gatox | ralsina, okkk | 16:35 |
| nessita | ralsina: ack, I'll grab a quick lunch | 16:36 |
| ralsina | nessita: that error is harmless. I am only testing the error method (which is the only thingI reimplemented) but the parent class has a __del__ method that does stuff, so yes, there is a fake backend missing, but it's not used in the test. | 16:51 |
| ralsina | and I stop for lunch too | 16:57 |
| nessita | ralsina: ok, so, not sure if you are fixing something or not :-) | 17:16 |
| ralsina | nessita: well, I am not sure about adding a branch for that today, but will do it eventually? ;-) | 17:16 |
| nessita | ok | 17:16 |
| dobey | well that took longer than i'd hoped for :-/ | 17:18 |
| gatox | ralsina, done with the branch!! | 17:25 |
| gatox | ralsina, both of them | 17:25 |
| gatox | nessita, ^ | 17:25 |
| nessita | gatox: please let me know when both are approved by ralsina, so I can review after him :-) | 17:25 |
| ralsina | nessita: filed https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/828938 | 17:25 |
| ubot4 | Launchpad bug 828938 in ubuntuone-windows-installer "Error on test_forgotten_password_controller_error (affects: 1) (heat: 6)" [Low,New] | 17:26 |
| gatox | nessita, ok | 17:26 |
| ralsina | gatox: should have the first one about 45 minutes from now, right ater milanesas ;-) | 17:26 |
| gatox | ralsina, jejeje | 17:26 |
| gatox | i've just eat polenta y tomate :S | 17:26 |
| gatox | jeje | 17:26 |
| === beuno is now known as beuno-lunch | ||
| nhaines | Hmm, some time I'll have to try polenta. | 17:38 |
| dobey | heh | 17:38 |
| gatox | nhaines, is good... but... it's not a big plate of meat! jeje | 17:39 |
| nhaines | gatox: that must be what you eat it with! hehe | 17:42 |
| gatox | nhaines, ...... no :(....... i eat it with tomate........ to healthy for my taste | 17:42 |
| gatox | jejeeee | 17:42 |
| gatox | tomato | 17:43 |
| nhaines | Tomatos are what I eat with kabab koobideh so I feel more healthy, hehehe. | 17:43 |
| gatox | LOL :P | 17:44 |
| dobey | tomatoes are great for making catsup | 17:44 |
| ralsina | I'm back | 17:45 |
| nhaines | ralsina: how was lunch? | 17:45 |
| ralsina | nhaines: awesome! | 17:45 |
| nhaines | \o/ | 17:45 |
| nhaines | ralsina: what did you have? | 17:46 |
| ralsina | gatox: the connect problem we mentioned is also for things like "textEdited.connect(self.name_assistance)". Those should move to __init__ I think | 17:47 |
| ralsina | nhaines: milanesas + salad | 17:47 |
| gatox | ralsina, oh right! | 17:48 |
| nhaines | ralsina: oh, I've had something similar before, but without the salad. :) Nice! | 17:48 |
| ralsina | gatox: again, sorry about making you change code I wrote wrong ;-) | 17:48 |
| gatox | ralsina, no problem! | 17:48 |
| nessita | ralsina: can you please explain to me why there is a while true inside update_sizes? | 17:50 |
| nessita | at first sight it does no luck so "healthy" | 17:50 |
| ralsina | gatox: also, you could add tests that after initializePage, calling setFocus() on each widget triggers the right method | 17:50 |
| ralsina | nessita: it's reading from a queue, it will be empty eventually | 17:50 |
| ralsina | nessita: and the number of items in the que is less or equal than the number of items | 17:51 |
| ralsina | "of items in the list" | 17:51 |
| gatox | ralsina, sorry..... don't follow about calling setFocus | 17:52 |
| ralsina | gatox: on initializePage you connect to watch for focus changes. Then you should test that if, for example self.ui.password_edit gets focus, password_assistance is visible | 17:53 |
| gatox | ralsina, ahhhhhhhh ok ok | 17:54 |
| gatox | now i understand | 17:54 |
| * gatox is adding tests... | 17:54 | |
| nessita | ralsina: what do you think of changing the implementation to the second option here? http://pastebin.ubuntu.com/669443/ | 17:55 |
| nessita | ralsina: it was really difficult for me to read the first implementation | 17:55 |
| ralsina | nessita: I am not a big fan of try/except/else but if you like it better it's ok for me | 17:56 |
| nessita | ralsina: using else is more recommended that having a long block inside the try:ecept | 17:56 |
| nessita | ralsina: you may be catchihng more exception than expected (not specific to this case) | 17:57 |
| nessita | catching* | 17:57 |
| ralsina | ok, changing it | 17:57 |
| nessita | ralsina: another question, any reason to cast to long in total = long(self.account_info['quota_used'])? | 17:57 |
| ralsina | nessita: yes, in some cases it's an int :-( | 17:57 |
| nessita | ralsina: and what's the problem with that? | 17:58 |
| * nessita does not follow | 17:58 | |
| dobey | MAXING isn't very high | 17:58 |
| dobey | err MAXINT | 17:58 |
| nessita | In [3]: int('1234567899999999999999') | 17:58 |
| nessita | Out[3]: 1234567899999999999999L | 17:58 |
| ralsina | nessita: I check that it's a long to decide what to do. It can be int or long, so I cast to long | 17:58 |
| nessita | ralsina: but why not casting to int every single time? | 17:59 |
| ralsina | nessita: yes, but isinstance(long(1), int) == False | 17:59 |
| ralsina | nessita: because sometimes it's a long | 17:59 |
| ralsina | so since I have to cast, I cast to the bigger type | 17:59 |
| nessita | ralsina: but why not casting to int? the "isinstance(long(1), int) == False" does not gives me an answer I can understand | 18:00 |
| dobey | yeah you never cast to smaller type | 18:00 |
| ralsina | nessita: 1GB is a long, for example | 18:00 |
| dobey | nessita: because you can't cast from a long to an int, for any value that is greater than MAXINT | 18:00 |
| nessita | ralsina: you can cast the string representing 1GB with int() and is the same | 18:00 |
| nessita | dobey: yes you can, I just showed you | 18:00 |
| nessita | In [3]: int('1234567899999999999999') | 18:00 |
| nessita | Out[3]: 1234567899999999999999L | 18:00 |
| dobey | nessita: what you showed me was that int (string) will return a long :) | 18:01 |
| nessita | dobey: and that is what ralsina is doing | 18:01 |
| ralsina | nessita: int(a long > maxint) is a long | 18:01 |
| nessita | is ok, but having a cast to long is confusing... | 18:01 |
| ralsina | since I want to convert to a long, why would I cast to an int? | 18:01 |
| nessita | I never seen a cast to long() before in our code | 18:01 |
| dobey | i don't think so *shrug* | 18:01 |
| ralsina | nessita: I had never seen a class implement a useful __del__ before today either ;-) | 18:01 |
| dobey | our code doesn't generally deal with large numbers i guess | 18:01 |
| dobey | ralsina: tarmac has a class that does ;) | 18:02 |
| nessita | dobey: we always deal with large number when it comes to quota | 18:02 |
| ralsina | nessita: basically, I can have an int (ex: 0) a long (ex: 100000*) or a string ("calculating") | 18:02 |
| ralsina | forget that, I am nt remembering the code right | 18:03 |
| dobey | eh | 18:03 |
| dobey | nessita: i agree in Python it probably matters less though | 18:03 |
| nessita | ralsina: this | 18:03 |
| nessita | if isinstance(total, long): | 18:03 |
| nessita | should be | 18:03 |
| nessita | if total > 0: ... humanize... | 18:03 |
| dobey | but i don't see a problem with explicitly casting to long | 18:03 |
| nessita | dobey: me neither, other than being confusing from the rest of the code I've been reading and writing within our projects | 18:04 |
| ralsina | nessita: first, I set total to a number. | 18:04 |
| ralsina | nessita: but of there is an item that doesn't have a value, I set it to a string | 18:04 |
| ralsina | so later I check if it's a long or a string | 18:04 |
| ralsina | I could not do the cast and check if it's a string | 18:05 |
| nessita | ralsina: let's do something a bit cleaner, let me propose a code snippet | 18:05 |
| ralsina | nessita: ok | 18:05 |
| dobey | nessita: i don't think it's confusing. stop trying to extrapolate it to all the code you've read/written in our projects, and deal with only the piece of work that code needs to deal with, to understand it :) | 18:06 |
| nessita | ralsina: also, with your code, I think that we may be, in some cases, summing up a string with an item.size? | 18:07 |
| ralsina | nessita: no, we won't | 18:07 |
| nessita | ralsina: how do we ensure that? | 18:07 |
| ralsina | nessita: the only case where total becomes a string, it breaks out of the loop where we add sizes to it | 18:07 |
| nessita | ah, right, is a break not a continue... | 18:08 |
| nessita | ralsina: can we have an item with size None and another with size not None? | 18:08 |
| ralsina | nessita: yes | 18:08 |
| ralsina | and in that case the total is not defined yet and we show a non-number string | 18:09 |
| nessita | ralsina: we don't show any numeric quota usage in that case? (but the string caclulating?) | 18:09 |
| ralsina | nessita: exactly | 18:09 |
| ralsina | verterok: ping | 18:11 |
| nessita | ralsina: something like http://pastebin.ubuntu.com/669455/ | 18:12 |
| ralsina | nessita: that fails if the user has no UDFs created and selects nothing (shows "calculating") | 18:12 |
| nessita | ah, you're right | 18:13 |
| ralsina | how about I cast to int, and instead of isinstace(long) I use isinstance(unicode)? | 18:14 |
| nessita | ralsina: no need to change for now | 18:14 |
| ralsina | ok | 18:14 |
| nessita | ralsina: is there a test for the case you described? (user has no udfs and...) | 18:14 |
| ralsina | I can add a # XXX not pretty ;-) | 18:15 |
| nessita | can be | 18:15 |
| ralsina | nessita: good question. I'll check and add one if there is not | 18:15 |
| nessita | ralsina: I'll add that to the MP., I've added another tweaks already | 18:15 |
| ralsina | nessita: cool, thx | 18:15 |
| dobey | https://code.launchpad.net/~dobey/ubuntuone-installer/learn-more/+merge/72086 | 18:16 |
| dobey | yay me | 18:16 |
| nessita | ralsina: I added a few needs fixing, and a question/suggestion in the end | 18:22 |
| ralsina | nessita: cool, will get to them in 5' | 18:22 |
| nessita | ralsina: no rush | 18:22 |
| ralsina | nessita: and thanks for this review, I know it's long :-( | 18:22 |
| nessita | ralsina: can I have a review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/new-creds/+merge/72077 | 18:22 |
| ralsina | nessita: sure | 18:22 |
| nessita | :-) | 18:23 |
| === beuno-lunch is now known as beuno | ||
| nessita | ralsina: I just filled bug #828983, but let me know if that flow does not apply to the installer (see attachment for the installer) given what you're implementing now | 18:38 |
| ubot4 | nessita: Bug 828983 on http://launchpad.net/bugs/828983 is private | 18:38 |
| ralsina | nessita: you can't really go over quota in the installer. What happens now is that if you choose too much stuff to sync, we offer a chance to buy space, but it won't stop you from continuing | 18:39 |
| nessita | ralsina: ok, I just filed the bug after refloating a email from lisette, fell free to add a comment and close as invalid in the installer | 18:43 |
| ralsina | nessita: ack | 18:43 |
| nessita | gatox: ping! | 18:52 |
| gatox | nessita, pong | 18:52 |
| nessita | gatox: would you give me a hand with https://bugs.launchpad.net/ubuntuone-control-panel/+bug/822688? I would like to learn gradients in the qss. Current style for tan hover is | 18:52 |
| nessita | 163 background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1, | 18:52 |
| nessita | 164 stop: 0 #fafafa, stop: 0.4 #f4f4f4, | 18:52 |
| nessita | 165 stop: 0.5 #e7e7e7, stop: 1.0 #fafafa); | 18:52 |
| ubot4 | nessita: Error: Bug #822688 is private. | 18:52 |
| nessita | gatox: what does the stops mean? | 18:52 |
| nessita | gatox: or, now that I read the bug report again, is lisette asking us to remove the gradient and add a solid color for the whole tab? | 18:54 |
| gatox | nessita, it is where that color ends (if i'm no wrong) | 18:54 |
| gatox | nessita, but i've never see so many stops :P | 18:55 |
| nessita | gatox: if your styling! :-D | 18:55 |
| nessita | is* | 18:55 |
| nessita | isn't it? | 18:55 |
| gatox | nessita, really?? | 18:55 |
| ralsina | nessita: +1 on new-creds | 18:55 |
| nessita | gatox: well I did not add that. Let me bzr blame it :-D | 18:56 |
| gatox | nessita, jjee ok | 18:56 |
| * gatox is having amnesia | 18:57 | |
| nessita | gatox: well, I'm marked as last modifier, but I likely fixed some spacing | 18:57 |
| nessita | anyways... | 18:57 |
| nessita | gatox: what do you think lisette is requesting there? | 18:57 |
| nessita | a solid color or another gradient? | 18:57 |
| gatox | nessita, ahhh no, she is asking to show a solid color on hover...... and use the same color as the start of the gradient but for all the tab | 18:59 |
| gatox | nessita, that's what i'm understand | 18:59 |
| gatox | i understand* | 18:59 |
| nessita | gatox: ok, I'll implement that (I think that she's requesting that as well) | 18:59 |
| gatox | ralsina, you can re-review my branch | 19:07 |
| ralsina | gatox: on it! | 19:08 |
| gatox | ralsina, awesome! thanks | 19:08 |
| gatox | ralsina, nessita EOD for me..... i'll be connected anyhow... please let me know if the branches are ok or need fixing | 19:25 |
| ralsina | gatox: ok, se you tomorrow! | 19:25 |
| nessita | gatox: bye! | 19:25 |
| nessita | trivialisima review! https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/preferences-is-settings/+merge/72090 | 19:32 |
| beuno | nessita, +1 | 19:33 |
| nessita | beuno: thanks! | 19:34 |
| ralsina | nessita: finished with the fixes for local_folders | 19:49 |
| nessita | ralsina: if I restart that review tomorrow, would that be too late? | 19:50 |
| ralsina | It would only mean that I would put it in tonight release manually, really | 19:50 |
| nessita | I guess yes... | 19:50 |
| nessita | ah | 19:50 |
| ralsina | but I totally understand wanting to set that branch on fire :-) | 19:51 |
| nessita | ralsina: can we do that, so I have a more fresh mind when giving the last review? (I'm sure it will be the last :-)) | 19:51 |
| ralsina | sure | 19:51 |
| nessita | ralsina: also, I would love if Chipacaa reviews it tomorrow his morning first, so we have another set of eyes in it. So, when I starts working tomorrow morning, I re-review it and we land it | 19:52 |
| ralsina | cool, will put it in tonight's mail | 19:52 |
| nessita | great, thanks | 19:52 |
| ralsina | nessita: do you have any pending branches you expect to finish for today? | 19:52 |
| nessita | ralsina: yes, the disconnect flow | 19:52 |
| nessita | I'm 35% done | 19:52 |
| nessita | (?) | 19:52 |
| ralsina | ok | 19:52 |
| ralsina | Right now, I am thinking of adding alecu's branches, both of diego's (they do work, mostly), my local folders branch, and probably the one that starts u1cp if there are credentials | 19:54 |
| nessita | oh! alecu's branch! I need to do that review! | 20:03 |
| nessita | ralsina: how many alecu's branches are there?> | 20:03 |
| ralsina | nessita: the one about the clock, and the one for the watches | 20:03 |
| dobey | i need a review. it's very easy :) | 20:04 |
| nessita | ralsina: I'll review those | 20:04 |
| ralsina | the clock one has a review request for verterook | 20:04 |
| ralsina | dobey: shoot! | 20:05 |
| dobey | https://code.launchpad.net/~dobey/ubuntuone-installer/learn-more/+merge/72086 | 20:05 |
| nessita | verterok: ping | 20:06 |
| nessita | ralsina: I'm thinking... what about closing the app after the user removes the current device? since we already show the warning "are you sure you want to remove this device?", we could append "If you choose yes, the application will close. You can sign in again by starting Ubuntu One from the <launcher/program list>" | 20:10 |
| nessita | ralsina: is that too cheesy? | 20:10 |
| ralsina | It makes things much simpler | 20:11 |
| ralsina | You should remove all metadata when removing the device, though | 20:11 |
| dobey | i'm not sure about that | 20:13 |
| nessita | ralsina: hum, that is pretty risky, we don't it anywhere so far (anywhere == not even in ubuntu). I agree that we shoudl, in all plaforms, but maybe that should be a separated bug to implement in the control panel backend (and both OS will benefit from that). I know what you're pointing out, if the user opens the installer, s/he will be able to login. BUt the same will happen if we offer only to re-signin in the controller, and they close the app and re- | 20:13 |
| nessita | icon" | 20:13 |
| nessita | able to *register* I meant | 20:14 |
| nessita | and s/controller/control panel | 20:14 |
| ralsina | he could just login with another account of course | 20:14 |
| nessita | also that | 20:14 |
| ralsina | so, it would not be more dangerous than currently. Which is pretty dangerous but people manage ;-) | 20:14 |
| nessita | ralsina: right. So, what do you say? (I will email lisette if you agree) | 20:15 |
| dobey | eh, i don't think it's worth doing | 20:16 |
| ralsina | yes, ask her if that's good, it's much less work than what we had planned | 20:16 |
| nessita | dobey: doing what? the metadata removal or the other thing? | 20:16 |
| dobey | both, but the metadata removal is what really worries me | 20:16 |
| nessita | ralsina: I will pause this and do some other (tons of) bug I have left :-) | 20:17 |
| ralsina | nessita: cool | 20:17 |
| nessita | dobey: I agree is very risky and can't be done quickly nor without thinking it through | 20:17 |
| nessita | dobey: the other thing has to be done... users can remove the local device by design | 20:17 |
| dobey | i don't see why we have to just close the control panel though | 20:20 |
| dobey | it should just hide everything and go back to the join/sign-in screen | 20:20 |
| nessita | dobey: there is no such screen in windows control panel, is the installer who has it | 20:21 |
| dobey | so what happens if i remove the local machine on windows, and then open the control panel again? | 20:22 |
| dobey | or what happens if i just install, and don't sign in yet? | 20:22 |
| dobey | like perhaps because i'm IT at some business and am installing it to allow my users to be able to access it | 20:23 |
| nessita | dobey: how would you open the control panel? | 20:23 |
| nessita | the "Ubuntu One" icon runs the wizard, and if there are credentials present in the system, it launches the control panel. So for an end user, they both are the same app | 20:24 |
| dobey | what do you mean? you're proposing everything will be uninstalled when disassociating the local machine? | 20:24 |
| nessita | dobey: and yes, it makes sense to unify this code into the control panel source tree at some point, so we can benefit from the wizard in ubuntu | 20:24 |
| dobey | i am not sure about that :-/ | 20:25 |
| dobey | but i don't think i want to think about it any more right now | 20:25 |
| nessita | is ok | 20:25 |
| nessita | ralsina: when we have time (JUAZ) to port the installer + qt sso to linux, we _could_ move the installer code into the control panel source tree (just an idea) | 20:26 |
| ralsina | nessita: yes | 20:27 |
| nessita | ralsina: https://code.launchpad.net/~alecu/ubuntuone-client/watch-finished-deferred/+merge/71955 is approved, I think it needs a second review | 20:33 |
| ralsina | nessita: I have checked the code yesterday, but I am really shaky on what it *does* beyond generalities | 20:34 |
| nessita | ralsina: we can ask some chicharrero to look at, maybe lucio? | 20:35 |
| ralsina | So, I can give it an approval but it's not exactly a "hey, I know what this fixes and I love it" | 20:35 |
| ralsina | nessita: yeah, that would be a better idea, I think. OTOH, they will tell you they don't know what the windows code does ;-) | 20:35 |
| nessita | ralsina: they can ask the parts they don't understand... I guess | 20:35 |
| ralsina | nessita: yeah, let's ask. And if they don't see anything too obvious, let's merge it tomorrow | 20:36 |
| nessita | ack | 20:36 |
| dobey | alright, i am off | 20:50 |
| dobey | have a good evening all | 20:50 |
| === m_conley is now known as m_conley_away | ||
| === yofel_ is now known as yofel | ||
| nessita | ralsina: ping | 21:27 |
| ralsina | nessita: pong | 21:27 |
| nessita | ralsina: question: would you know why I can't pain the background of the ControlPanel widget inside the controlpanel QT UI? I'm setting a style like this | 21:29 |
| nessita | ControlPanel { | 21:29 |
| nessita | background-color: black; | 21:29 |
| nessita | } | 21:29 |
| nessita | and that will not paint the damn thing :-) | 21:29 |
| nessita | ControlPanel is a QWidget | 21:29 |
| nessita | I also tried Qwidget#control_panel | 21:29 |
| nessita | I could paint all the widgets by trying tith QWidget{background-color: black;} | 21:29 |
| ralsina | is controlpanel a class or the widget name? | 21:29 |
| nessita | ralsina: ControlPanel the class name, control_panel the instance name | 21:30 |
| nessita | 49 class ControlPanel(QtGui.QWidget): | 21:30 |
| ralsina | ok. Now, does it have any visible parts? | 21:30 |
| nessita | yes, it does, but let me triple check | 21:30 |
| ralsina | or is all covered by other stuff? | 21:30 |
| nessita | ralsina: in designer I see some free sections, let me grab a screenshot | 21:31 |
| ralsina | nessita: I think I know what it is, give me 2' to check | 21:32 |
| nessita | ok! | 21:32 |
| nessita | ralsina: http://ubuntuone.com/p/1BHR/ | 21:33 |
| nessita | ralsina: see how the margins are 5, I would expect that to be black | 21:33 |
| ralsina | nessita: QWidget supports only "background" | 21:36 |
| ralsina | check http://doc.qt.nokia.com/latest/stylesheet-reference.html | 21:37 |
| ralsina | no idea if that is the real problem though | 21:37 |
| nessita | ralsina: is not, I tried background as well | 21:37 |
| ralsina | it also says that i fyou inherit QWidget you have to implement paintEvent for stylesheets to do something | 21:38 |
| nessita | ah | 21:39 |
| nessita | that sounds like it | 21:40 |
| nessita | ralsina: thanks! | 21:40 |
| ralsina | thank me when it works ;-) | 21:40 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!