[00:16] eow! [00:33] nhaines: how do you like that http://ubuntuone.com/p/1B7X/ [00:34] Good night #ubuntuone! [09:45] hiya [09:46] can anyone of the U1 Couch people have a look at https://code.launchpad.net/~wibblymat/ubuntu/oneiric/couchdb/update-to-1.1.0/+merge/69702 and give their input to an update to 1.1.0 and the patches and everything? [09:49] * fagan doesnt even know who is couch now [09:49] couchdb [09:50] I mean who is working on it [09:58] I now have a keyboard that is built like a typewriter [09:58] not to look like one but inside its one [10:01] Good morning! [10:10] karni, i saw the screenshot - http://ubuntuone.com/p/1B7X/ - looks very related to my interests [10:11] rye: (Im' glad!) Which are exactly :)? [10:11] Progress indication and simultaneous up/downloads? [10:18] karni, yep, /me likes progress indicators! [10:18] rye: cool :) [10:18] People were asking about them. [10:50] * Chipaca waves at jderose [10:54] hey Chipaca - how are you doing? [10:54] dholbach: hi there [10:54] dholbach: a bit tired, but good. you? [10:55] a bit tired as well, but doing alright - thanks :) [10:55] Chipaca, somebody worked on a merge of couchdb 1.1.0 from debian - it mostly looks OK from a sponsor-the-update-into-Ubuntu POV, who would be a good person on the U1 team to double check it? [10:56] https://code.launchpad.net/~wibblymat/ubuntu/oneiric/couchdb/update-to-1.1.0/+merge/69702 is the MP in question [10:57] dholbach: ok, i'll look at it (or have somebody do it) [10:57] * dholbach hugs Chipaca [10:57] awesome - thanks muchly [10:57] also, wibblymat is a +2 nick [11:05] ah, good to know! [11:05] just as a heads-up: the new couchdb might need a feature freeze exception [11:13] hello everyone! [11:13] Good day nessita ! [11:14] hello karni! [11:14] nessita, hi [11:14] hi gatox [11:14] nessita, i'm adding some changes to a new branch... would you be able to review?? it's almost done [11:16] gatox: I'm always able to! I may be less or more slow in the process, but always shoot [11:17] nessita, thanks! i'm adding more tests right now... i found that something wasn't being tested... so i'll let you know when it's ready :D [11:17] great! [11:25] dholbach: pedronis will try to look at that mp tomorrow [11:26] dholbach: does that timing work? [11:26] sure sure - we're in feature freeze anyway, so if it makes sense to get it in and we have some good justification, better get it in now than even later [11:26] thanks a bunch [11:26] cheers [11:38] nessita, done! https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 [11:39] gatox: can you please commit with --fixes so the bug gets linked? [11:39] nessita, ok [11:40] nessita, done [11:50] gatox: ack [12:07] nessita, i have to leave in a while, if i don't return for standup, should i give you the report of my tasks to you? [12:07] gatox: yes please [12:07] nessita, ok..... writing.... [12:08] good morning! [12:08] hi ralsina [12:08] hi nessita [12:08] any ideas on the 403? [12:08] ralsina, hi [12:08] hi gatox [12:12] nessita, this is my standup: [12:12] DONE: [12:12] Bug #820874 = Branch ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 [12:12] TODO: [12:12] Finish uninstall issue. Start working on List Styles. [12:12] gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private [12:12] BLOCKED: [12:12] No [12:13] ralsina: yes, I'm working on it (replying to your email as well) [12:13] nessita: ok, cool [12:14] ralsina: would you know what encoding has the bytes strings returned by platform module? [12:14] nessita: no idea [12:14] BTW: if anyone ever gets 30+ failing tests on sso-client? Check that it's not running. Scared the crap out of me. [12:15] ralsina: hum? [12:15] nessita: on windows, because we are using a "real" tcp port, I think [12:20] ralsina: where are you getting the "error_message" from? [12:20] except_to_errdict in main/__init__.py sends a 'message' [12:20] nessita: I only saw the receiving end :-( [12:21] ah, I see where [12:21] right, GTK side does not suffer from this [12:21] let me answer the email [12:21] ok [12:23] brb [13:00] me [13:00] me [13:00] gatox says: [13:00] (09:12:40 AM) gatox: DONE: [13:00] (09:12:40 AM) gatox: Bug #820874 = Branch ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 [13:00] (09:12:40 AM) gatox: TODO: [13:00] (09:12:41 AM) gatox: Finish uninstall issue. Start working on List Styles. [13:00] (09:12:42 AM) ubot4: gatox: Bug 820874 on http://launchpad.net/bugs/820874 is private [13:00] (09:12:43 AM) gatox: BLOCKED: [13:00] (09:12:45 AM) gatox: No [13:00] nessita: Bug 820874 on http://launchpad.net/bugs/820874 is private [13:00] fagan, dobey, standup [13:00] ? [13:00] nessita: Error: Bug #820874 is private. [13:00] me [13:00] nessita: Bug 820874 on http://launchpad.net/bugs/820874 is private [13:00] md [13:00] me [13:01] fast mes today [13:01] nessita: go [13:01] DONE: control panel UI tweaks (several bugs were closed!), reviews [13:01] TODO: more reviews, bug #828417, maybe start with the disconnect flow [13:01] BLOCKED: nopes [13:01] NEXT: ralsina [13:01] Launchpad bug 828417 in ubuntu-sso-client "The ping URL is returning 403 FOrbidden (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/828417 [13:01] DONE: reviews, calls, working on bug #828420 bug #828170 bug #827365 bug #825513 TODO: should merge all of those today, hopefully, and start no new ones BLOCKED: no [13:01] Launchpad bug 828420 in ubuntu-sso-client "The CurrentUserController.on_login_error handler fails when the error has no "message" key (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/828420 [13:01] Launchpad bug 828170 in ubuntuone-windows-installer "On windows, the control panel fails without credentials (affects: 1) (heat: 6)" [Critical,In progress] https://launchpad.net/bugs/828170 [13:01] Launchpad bug 827365 in ubuntuone-windows-installer "Add functionality to Congratulations page checkboxes (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/827365 [13:01] Launchpad bug 825513 in ubuntuone-windows-installer "The local folders page is not up to spec (affects: 1) (heat: 6)" [High,In progress] https://launchpad.net/bugs/825513 [13:01] λ DONE: chat with lisette, filed bugs for new design, started bug #828169 [13:01] λ TODO: finish bug #817133, #828169 [13:01] λ BLCK: None. [13:02] Launchpad bug 828169 in ubuntuone-installer "No "Learn more" button (affects: 1) (heat: 6)" [Undecided,New] https://launchpad.net/bugs/828169 [13:02] Launchpad bug 817133 in ubuntu "[FFe] [needspackaging] ubuntuone-installer needs packaged (affects: 1) (heat: 12)" [High,Incomplete] https://launchpad.net/bugs/817133 [13:02] fagan: go [13:02] DONE [13:02] * had a read down through a good lot of the list of bugs [13:02] TODO [13:02] * reassign and merge duplicates (where needed) [13:02] BLOCKED [13:02] * Nope [13:03] ok, comments? [13:03] ralsina: have you aske Chipaca for reviews? so we can try to land all that [13:03] ralsina: I'm still oweing you the folders one. The error_message is done. [13:03] nessita: not yet [13:03] nessita: cool. I think the error_message one can land with just your review? [13:04] ralsina: yes, but I asked a easy fix [13:04] ralsina: there are a couple of cases that have no tests [13:04] I added them already :) [13:05] I should probably create a low priority bug about the qt and gtk versions getting different errordicts [13:10] ralsina: did you read my email? [13:10] ralsina: they are getting different error dicts because we have the dbus layer in between [13:10] yes, maybe we should fix the windows IPC to work more like dbus [13:10] ah [13:11] but I don't really care all that much, as long as we don't have 50 different possible keys [13:11] true [13:12] in any case, it should work now, and we will get reports about "ugly error messages" that should be trivial to fix [13:14] ralsina: can I give you a branch to run as u1client and try the installer again? (the credentials part) [13:14] sure [13:14] lp:~nataliabidart/ubuntuone-client/unicode-pingurl [13:14] ralsina: as always, be sure to run that client and have pythonpaths using it as well [13:14] let me know! [13:14] nessita: sure, in 5' [13:21] nessita: using that ubuntuone-client I still get the 403 [13:21] ralsina: can I see the trace please? [13:22] nessita: https://pastebin.canonical.com/51406/ [13:22] I will do another run starting sso manually to see if I get a better error there [13:22] thanks [13:24] ralsina: do you have a sso log file? [13:24] wait... [13:24] OH NO [13:24] ralsina: xdg does not work on windows for sso! [13:25] ? [13:25] since we migrate the code for u1client only :-/ [13:25] ralsina: sso can't log to a file because xdg does not work on widnows, no? [13:25] nessita: don't know, haven't checked. [13:25] good news, the ping now works ;-) [13:25] I was running an old sso exe [13:26] with trunk, it worked [13:26] ah! [13:26] that's great news [13:26] but now it worries me the xdg thingy, anyways, let's file a bug for that [13:28] confirmed, I get logs for syncdaemon, controlpanel and installer, but not for sso [13:33] ralsina: I realized I did not get this issue when I performs my tests before, because I was using the dbus service, which coerces to unicode [13:34] ralsina, facundobatista: https://code.launchpad.net/~nataliabidart/ubuntuone-client/unicode-pingurl/+merge/72036 [13:35] nessita: dbus/ipc differences, twice in 24 hours. I am starting to think we will hate that when more people use it. [13:36] ralsina: we will :-/ [13:37] nessita: +1 after the IRL test and a quick core read [13:37] great, thanks [13:39] i'm back [13:45] @ping [13:45] pong [13:45] hi gatox, I have your review in the review queue, ralsina goes first with 2 [13:45] gatox: I'll do yours first :-) [13:45] nessita, ralsina ack [13:46] ralsina, i think that is really pretty jeejjeej but you would tell me if something needs fixing [13:46] jejee [13:46] gatox: I'll try to be thorough [13:48] nessita: about sso and xdg... I will have to duplicate some code since I can't import u1-client [13:49] ralsina: yeah. Or we can move the get_special_folders to sso... [13:49] and we import that from u1client [13:49] ralsina: but is UGLY [13:49] yes, I will first copy, and then do a branch in u1-client to import from there [13:50] nessita: after the rush I will fork/take wnership of/contribute to pyxdg to make it work on windows, but not right now :-( [13:50] right [14:06] gatox: the things with the warning icons inside the lineedits look like buttons. In fact, I can click them [14:08] gatox: also try this: start typing the name. Delete everything using backspace. You will see the width of the lineedits change [14:08] ralsina: question: shouldn't we use the new error build in on_user_registration_error? [14:08] instead of [14:08] errors = [v for _, v in sorted(error.iteritems())] [14:08] self.message_box.critical('\n'.join(errors)) [14:08] same for on_email_validation_error [14:08] ralsina, who is adding that buttons inside the lineedits? [14:08] we should use it on all on_*_error methofs [14:09] ralsina: shall we change that in this branch? [14:09] nessita: no preference [14:09] should be easy to do [14:10] gatox: they are done by the EnhancedLineEdit class [14:10] nessita: I'll do it in this branch, so it's more uniform [14:10] ralsina: yeah, to fix the tests as well I recommend class inheritance: so, using the newly added CurrentUserControllerErrorTestCase, have on_login_error being a class variable, that new child will override with the new on_*_error [14:11] nessita: good one [14:11] ralsina: and in setup, you can do in the parent class: [14:11] self.on_error = gettattr(self.controller, self.method_name) [14:11] only in the parent [14:11] and then you're done [14:11] (plus some search and replace to call self.on_error in the tests) [14:12] nessita: ok, I'll try to do that [14:12] ralsina: ask me anything you need! I will move to the folders branch now [14:12] gatox: I have no idea why those would be buttons instead of labels, also [14:39] ralsina: silly fix: there are trailing spaces in the test_gui.py, after test_timer_is_stopped === m_conley_away is now known as m_conley [14:40] ralsina: and please change this self.assertEqual(set(folders), set(expected)) to self.assertEqual(sorted(folders), sorted(expected)), otherwise the real implementation can return [docs, music, docs, pictures] and the UI will show a duplicate, and no test will fail in that case [14:41] nessita: ok, will change [14:41] thanks [14:42] ralsina: there are some leftover, simple comments from yesterday, would you push those as well? [14:43] sure, as soon as I finish the error_message ones [14:53] of course [15:12] nessita: pushed error_message using the new function to generate messages. Found an unimplemented error handler, too. [15:12] great! === zyga is now known as zyga-afk [15:18] * jderose waves back at Chipaca :-D [15:35] nessita: pushed local-folder-fixes with the fixes you mentioned now, and those from yesterday [15:36] ralsina: I'm having some lint issyes for error_message [15:36] I added those to the MP [15:36] nessita: sorry, will check them [15:36] nessita: I need to fix my lint because I lose them in the noise :-( [15:36] :-/ [15:39] ok, lunch time, and errands. bbiab [15:40] nessita: de-linted [16:08] ralsina: error_message looks good, approving [16:09] nessita: cool, thx! [16:16] ralsina, this branch is ready: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 [16:17] * ralsina re-looks [16:17] and you should take a look at this one too: https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/improve-EnhancedLineEdit/+merge/72064 for the icon inside the lineedit [16:25] gatox: on setupaccount-form-behaviour, the lineedits still change size when you edit them [16:25] gatox: unless that's fixed by the other branch, of course [16:25] ralsina, let me check...... but that should be fixed [16:28] other than that, it looks really pretty! [16:28] ralsina, ahhh yes.. i know what you mean [16:28] * gatox fixing === JanC_ is now known as JanC [16:31] gatox: another problem: if you connect signals on initializePage, they can be connected more than once. So you either have to disconnect them first, or connect them on __init__ instead [16:31] gatox: and if you disconnect them, make sure you put each on a try/except because disconnected a signal that has not been connected raises a KeyError [16:32] ralsina, right! [16:32] ralsina: would you know what is causing this warning? http://pastebin.ubuntu.com/669388/ [16:32] looks like something is not fully faked? [16:32] gatox: I know this was probably wrong in code I wrote and you used ;-) [16:32] ralsina, i think that the best choice is to disconnect them to avoid receiving every focus changed if we are in another page [16:33] gatox: that's harder than you think, because there is no "the user is now in another page" signal :-( [16:33] gatox: AFAIK, at least [16:33] ralsina, but when you leave setup_account [16:33] or don't? [16:34] gatox: Oh, right, this one doesn't have a "Next" button :-D [16:34] gatox: yes, you can do that in the "sign up" button's clicked slot [16:34] unless of course, the sign up fails and you don't leave the page, but I know you can handle it :-) [16:35] nessita: not sure really. I ll take a look [16:35] ralsina, okkk [16:36] ralsina: ack, I'll grab a quick lunch [16:51] nessita: that error is harmless. I am only testing the error method (which is the only thingI reimplemented) but the parent class has a __del__ method that does stuff, so yes, there is a fake backend missing, but it's not used in the test. [16:57] and I stop for lunch too [17:16] ralsina: ok, so, not sure if you are fixing something or not :-) [17:16] nessita: well, I am not sure about adding a branch for that today, but will do it eventually? ;-) [17:16] ok [17:18] well that took longer than i'd hoped for :-/ [17:25] ralsina, done with the branch!! [17:25] ralsina, both of them [17:25] nessita, ^ [17:25] gatox: please let me know when both are approved by ralsina, so I can review after him :-) [17:25] nessita: filed https://bugs.launchpad.net/ubuntuone-windows-installer/+bug/828938 [17:26] Launchpad bug 828938 in ubuntuone-windows-installer "Error on test_forgotten_password_controller_error (affects: 1) (heat: 6)" [Low,New] [17:26] nessita, ok [17:26] gatox: should have the first one about 45 minutes from now, right ater milanesas ;-) [17:26] ralsina, jejeje [17:26] i've just eat polenta y tomate :S [17:26] jeje === beuno is now known as beuno-lunch [17:38] Hmm, some time I'll have to try polenta. [17:38] heh [17:39] nhaines, is good... but... it's not a big plate of meat! jeje [17:42] gatox: that must be what you eat it with! hehe [17:42] nhaines, ...... no :(....... i eat it with tomate........ to healthy for my taste [17:42] jejeeee [17:43] tomato [17:43] Tomatos are what I eat with kabab koobideh so I feel more healthy, hehehe. [17:44] LOL :P [17:44] tomatoes are great for making catsup [17:45] I'm back [17:45] ralsina: how was lunch? [17:45] nhaines: awesome! [17:45] \o/ [17:46] ralsina: what did you have? [17:47] gatox: the connect problem we mentioned is also for things like "textEdited.connect(self.name_assistance)". Those should move to __init__ I think [17:47] nhaines: milanesas + salad [17:48] ralsina, oh right! [17:48] ralsina: oh, I've had something similar before, but without the salad. :) Nice! [17:48] gatox: again, sorry about making you change code I wrote wrong ;-) [17:48] ralsina, no problem! [17:50] ralsina: can you please explain to me why there is a while true inside update_sizes? [17:50] at first sight it does no luck so "healthy" [17:50] gatox: also, you could add tests that after initializePage, calling setFocus() on each widget triggers the right method [17:50] nessita: it's reading from a queue, it will be empty eventually [17:51] nessita: and the number of items in the que is less or equal than the number of items [17:51] "of items in the list" [17:52] ralsina, sorry..... don't follow about calling setFocus [17:53] gatox: on initializePage you connect to watch for focus changes. Then you should test that if, for example self.ui.password_edit gets focus, password_assistance is visible [17:54] ralsina, ahhhhhhhh ok ok [17:54] now i understand [17:54] * gatox is adding tests... [17:55] ralsina: what do you think of changing the implementation to the second option here? http://pastebin.ubuntu.com/669443/ [17:55] ralsina: it was really difficult for me to read the first implementation [17:56] nessita: I am not a big fan of try/except/else but if you like it better it's ok for me [17:56] ralsina: using else is more recommended that having a long block inside the try:ecept [17:57] ralsina: you may be catchihng more exception than expected (not specific to this case) [17:57] catching* [17:57] ok, changing it [17:57] ralsina: another question, any reason to cast to long in total = long(self.account_info['quota_used'])? [17:57] nessita: yes, in some cases it's an int :-( [17:58] ralsina: and what's the problem with that? [17:58] * nessita does not follow [17:58] MAXING isn't very high [17:58] err MAXINT [17:58] In [3]: int('1234567899999999999999') [17:58] Out[3]: 1234567899999999999999L [17:58] nessita: I check that it's a long to decide what to do. It can be int or long, so I cast to long [17:59] ralsina: but why not casting to int every single time? [17:59] nessita: yes, but isinstance(long(1), int) == False [17:59] nessita: because sometimes it's a long [17:59] so since I have to cast, I cast to the bigger type [18:00] ralsina: but why not casting to int? the "isinstance(long(1), int) == False" does not gives me an answer I can understand [18:00] yeah you never cast to smaller type [18:00] nessita: 1GB is a long, for example [18:00] nessita: because you can't cast from a long to an int, for any value that is greater than MAXINT [18:00] ralsina: you can cast the string representing 1GB with int() and is the same [18:00] dobey: yes you can, I just showed you [18:00] In [3]: int('1234567899999999999999') [18:00] Out[3]: 1234567899999999999999L [18:01] nessita: what you showed me was that int (string) will return a long :) [18:01] dobey: and that is what ralsina is doing [18:01] nessita: int(a long > maxint) is a long [18:01] is ok, but having a cast to long is confusing... [18:01] since I want to convert to a long, why would I cast to an int? [18:01] I never seen a cast to long() before in our code [18:01] i don't think so *shrug* [18:01] nessita: I had never seen a class implement a useful __del__ before today either ;-) [18:01] our code doesn't generally deal with large numbers i guess [18:02] ralsina: tarmac has a class that does ;) [18:02] dobey: we always deal with large number when it comes to quota [18:02] nessita: basically, I can have an int (ex: 0) a long (ex: 100000*) or a string ("calculating") [18:03] forget that, I am nt remembering the code right [18:03] eh [18:03] nessita: i agree in Python it probably matters less though [18:03] ralsina: this [18:03] if isinstance(total, long): [18:03] should be [18:03] if total > 0: ... humanize... [18:03] but i don't see a problem with explicitly casting to long [18:04] dobey: me neither, other than being confusing from the rest of the code I've been reading and writing within our projects [18:04] nessita: first, I set total to a number. [18:04] nessita: but of there is an item that doesn't have a value, I set it to a string [18:04] so later I check if it's a long or a string [18:05] I could not do the cast and check if it's a string [18:05] ralsina: let's do something a bit cleaner, let me propose a code snippet [18:05] nessita: ok [18:06] nessita: i don't think it's confusing. stop trying to extrapolate it to all the code you've read/written in our projects, and deal with only the piece of work that code needs to deal with, to understand it :) [18:07] ralsina: also, with your code, I think that we may be, in some cases, summing up a string with an item.size? [18:07] nessita: no, we won't [18:07] ralsina: how do we ensure that? [18:07] nessita: the only case where total becomes a string, it breaks out of the loop where we add sizes to it [18:08] ah, right, is a break not a continue... [18:08] ralsina: can we have an item with size None and another with size not None? [18:08] nessita: yes [18:09] and in that case the total is not defined yet and we show a non-number string [18:09] ralsina: we don't show any numeric quota usage in that case? (but the string caclulating?) [18:09] nessita: exactly [18:11] verterok: ping [18:12] ralsina: something like http://pastebin.ubuntu.com/669455/ [18:12] nessita: that fails if the user has no UDFs created and selects nothing (shows "calculating") [18:13] ah, you're right [18:14] how about I cast to int, and instead of isinstace(long) I use isinstance(unicode)? [18:14] ralsina: no need to change for now [18:14] ok [18:14] ralsina: is there a test for the case you described? (user has no udfs and...) [18:15] I can add a # XXX not pretty ;-) [18:15] can be [18:15] nessita: good question. I'll check and add one if there is not [18:15] ralsina: I'll add that to the MP., I've added another tweaks already [18:15] nessita: cool, thx [18:16] https://code.launchpad.net/~dobey/ubuntuone-installer/learn-more/+merge/72086 [18:16] yay me [18:22] ralsina: I added a few needs fixing, and a question/suggestion in the end [18:22] nessita: cool, will get to them in 5' [18:22] ralsina: no rush [18:22] nessita: and thanks for this review, I know it's long :-( [18:22] ralsina: can I have a review for https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/new-creds/+merge/72077 [18:22] nessita: sure [18:23] :-) === beuno-lunch is now known as beuno [18:38] ralsina: I just filled bug #828983, but let me know if that flow does not apply to the installer (see attachment for the installer) given what you're implementing now [18:38] nessita: Bug 828983 on http://launchpad.net/bugs/828983 is private [18:39] nessita: you can't really go over quota in the installer. What happens now is that if you choose too much stuff to sync, we offer a chance to buy space, but it won't stop you from continuing [18:43] ralsina: ok, I just filed the bug after refloating a email from lisette, fell free to add a comment and close as invalid in the installer [18:43] nessita: ack [18:52] gatox: ping! [18:52] nessita, pong [18:52] gatox: would you give me a hand with https://bugs.launchpad.net/ubuntuone-control-panel/+bug/822688? I would like to learn gradients in the qss. Current style for tan hover is [18:52] 163 background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1, [18:52] 164 stop: 0 #fafafa, stop: 0.4 #f4f4f4, [18:52] 165 stop: 0.5 #e7e7e7, stop: 1.0 #fafafa); [18:52] nessita: Error: Bug #822688 is private. [18:52] gatox: what does the stops mean? [18:54] gatox: or, now that I read the bug report again, is lisette asking us to remove the gradient and add a solid color for the whole tab? [18:54]