* nessita -> gone | 00:11 | |
kristianpaul | Hello | 00:35 |
---|---|---|
kristianpaul | There is an automated way to backup personal folder and emails with ubuntu-one? | 00:36 |
Chipaca | kristianpaul: hi | 00:43 |
Chipaca | kristianpaul: Ubuntu One is not a backup service | 00:43 |
Chipaca | kristianpaul: it's a sync service | 00:44 |
Chipaca | kristianpaul: and we have nothing specific for emails, although some people do use it to synchronize their email folders | 00:44 |
karni | Take care everyone! | 01:01 |
tntc | Still no change on UbuntuOne playlists for me. Is there a way to be moved to a non-broken server? | 02:46 |
thomedy209 | i feel like a noob again | 03:13 |
thomedy209 | i don't know why nothing is working its starting to piss me off... | 03:13 |
thomedy209 | its probably just typos but i haven't spent anytime with my family and i really miss them | 03:13 |
tntc | ? | 03:14 |
kerouac__ | I am trying to get ubuntu one to love my headless system. | 04:50 |
kerouac__ | and been searching high and low and tried pretty much everything. | 04:51 |
kerouac__ | i have no problem whatsoever getting my consumer_key, consumer_secret, token and token_secret | 04:52 |
kerouac__ | but fetching https://one.ubuntu.com/oauth/sso-finished-so-get-tokens/mek%40pels.in always fails... | 04:52 |
kerouac__ | my headers looks like this and i have tried with and without http basic auth : {'Authorization': 'OAuth realm="", oauth_nonce="98561566", oauth_timestamp="1313729597", oauth_consumer_key="*secret*", oauth_signature_method="HMAC-SHA1", oauth_version="1.0", oauth_token="*secret*", oauth_signature="*secret*"'} | 04:55 |
kerouac__ | OAuth_nonce is of course randomized | 04:55 |
kerouac__ | I always get a status of 403 (seems like miles away from a 202 :D ) | 04:57 |
kerouac__ | the difference in time is lower than 1 second. | 04:58 |
kerouac__ | (server client diff) | 04:58 |
kerouac__ | what am i missing ? | 05:00 |
kerouac__ | is one.ubuntu.com/oauth/sso-finished-so-get-tokens/ dead? | 08:57 |
fagan | kerouac__: the current apis are on https://one.ubuntu.com/developer | 09:27 |
karni | Good morning! | 10:04 |
fagan | morning karni | 10:05 |
karni | hi fagan | 10:07 |
* fagan break | 10:42 | |
nessita | good morning everyone! | 11:16 |
nessita | gatox: can you please refresh my memory with the links that need review for you? has roberto finished with both of them? | 11:39 |
gatox | nessita, no... both are in pending.... | 11:39 |
gatox | nessita, https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/improve-EnhancedLineEdit/+merge/72064 AND https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 | 11:39 |
ralsina | good morning! | 12:12 |
gatox | ralsina, good morning | 12:13 |
ralsina | good morning gatox. Haven't forgotten your reviews, am re-starting them in a minute or two | 12:14 |
gatox | ralsina, jeje awesome | 12:14 |
ralsina | gatox: we have to do on the "reset password" page, the same thing with password hints you did on the setup new account page | 12:32 |
gatox | ralsina, ok, should i do it in this branch? | 12:33 |
ralsina | no, a new one | 12:33 |
gatox | ralsina, ok... on it | 12:33 |
cillo564 | can ubuntu one music store use other linux distro users aswell? | 12:45 |
fagan | cillo564: if they have the store then sure | 12:52 |
cillo564 | do you mean if its on example banshee , if its there installed? | 12:56 |
gatox | ralsina, do you know where the path of installation if being specified? | 12:58 |
gatox | ralsina, or i have to assume that the installer is running from there? | 12:59 |
fagan | cillo564: you need the plugins and the dependencies installed | 12:59 |
gatox | to know where the uninstall.exe is | 12:59 |
ralsina | gatox: the installation path is specified in the bitrock install builder | 12:59 |
fagan | you would have to install everything from source | 12:59 |
fagan | me | 13:00 |
ralsina | gatox: BUT check how I figure the path for the control panel? It's in the parent of that folder :-) | 13:00 |
gatox | ralsina, so... i don't have access to that from the ubuntuone-windows-installer | 13:00 |
ralsina | me | 13:00 |
gatox | ralsina, yes, that i was looking at | 13:00 |
gatox | me | 13:00 |
fagan | nessita dobey standup | 13:00 |
nessita | oh right | 13:01 |
nessita | me | 13:01 |
fagan | ill go ahead dobey can catch up | 13:01 |
fagan | DONE | 13:01 |
fagan | * a few of the bugs | 13:01 |
fagan | TODO | 13:01 |
fagan | * more bugs | 13:01 |
fagan | BLOCKED | 13:01 |
fagan | * nope | 13:01 |
fagan | ralsina: go | 13:01 |
ralsina | DONE: pushed branches, calls, made release. TODO: finish local folders branch, no-credentials branch, figure out why syncdaemon/sso only answer to the first connection :-( BLOCKED: I have a sore throat and my sinuses feel like someone punched me | 13:01 |
ralsina | gatox? | 13:01 |
gatox | DONE: | 13:01 |
gatox | Nothing new | 13:01 |
gatox | TODO: | 13:01 |
gatox | Finishing Uninstall (almost done). Apply style to Reset Password Page. Start working on List Styles. | 13:01 |
gatox | BLOCKED: | 13:01 |
gatox | No | 13:02 |
gatox | nessita, go | 13:02 |
* nessita is writting notes | 13:02 | |
fagan | ralsina: what do I do with bugs with patches in them? | 13:02 |
ralsina | fagan: you will have to ask the "owner" of the thing that is to be patched | 13:03 |
* ralsina owns only ubuntuone-windows-installer so life is easy | 13:03 | |
nessita | DONE: landed branches for Bug #822688, Bug #828707, Bug #828805, Bug #828417, reviews | 13:03 |
nessita | TODO: reviews, bug #813073, bug #800444 | 13:03 |
nessita | BLOCKED: nopes | 13:03 |
nessita | NEXT: dobey | 13:03 |
fagan | ralsina: I mean do I need to get them to sign the contrib agreement? | 13:03 |
ralsina | fagan: if the owner of the product decides it'sa good patch, and the policy of the project is contributors-only: yes | 13:04 |
ralsina | fagan: no point on making them sign if the patch is ot going in, for instance | 13:04 |
fagan | ok so nessita I have 2 bugs for you to look at | 13:04 |
nessita | fagan: shoot | 13:05 |
fagan | https://bugs.launchpad.net/ubuntuone-client/+bug/824359 https://bugs.launchpad.net/ubuntuone-client/+bug/824374 | 13:05 |
fagan | They are just small patches to fix some english | 13:05 |
dobey | me | 13:11 |
dobey | λ DONE: finished bug #817133 (waiting in source new now), finished bug #828169 | 13:11 |
dobey | λ TODO: hack day, finish bug #828195 | 13:11 |
dobey | λ BLCK: None. | 13:11 |
dobey | fagan: yes, they have to sign the contrib agreement; for anything | 13:12 |
nessita | fagan: is this user a canonical contributor? | 13:12 |
fagan | nessita: pretty sure not | 13:12 |
nessita | ok, I'll reply | 13:12 |
fagan | kk | 13:12 |
fagan | yeah I remember I had to sign it for 1 line patch to unity | 13:13 |
dobey | also needs to be branches with merge proposals | 13:14 |
dobey | but i guess nessita will say so | 13:14 |
nessita | dobey: yes, I'm replying with that | 13:14 |
fagan | nessita: there is a branch for 1 of them dont know about the other | 13:16 |
nessita | dobey: you seen this one? https://code.launchpad.net/~kelemeng/ubuntuone-client/bug786617/+merge/61900 | 13:18 |
nessita | dobey: also, question, any reason this has not be re-approved? https://code.launchpad.net/~dobey/ubuntuone-client/fix-headers-1-6/+merge/65723 | 13:19 |
dobey | nessita: yeah, i need to make a branch to fix the test failures on stable-1-6 also, and haven't done it yet. maybe i should do that today :) | 13:20 |
nessita | rye: hey there! what's the status in this MP? https://code.launchpad.net/~rye/ubuntuone-client/lucid-backport-work-lp657195/+merge/47231 | 13:20 |
nessita | dobey: ah, is that related to ^? | 13:20 |
dobey | nessita: no, the lucid backport work is different | 13:21 |
ralsina | gatox: I am concerned about QPushButton paddings (ok, I am not, but let's say I am): http://screencast.com/t/nrOGdm0g | 13:30 |
* gatox looking | 13:31 | |
gatox | ralsina, that's way i assume that control-panel doesn't have the last qss... | 13:32 |
gatox | ralsina, several changes has been made in the installer that should be migrated to the control panel | 13:32 |
ralsina | oh, ok | 13:32 |
gatox | ralsina, yes... confirmed... some styles are missing in the control panel....... if you and nessita let me... i would like to integrate that changes after my branch of reset password | 13:33 |
ralsina | gatox: no rush | 13:34 |
nessita | ralsina, gatox: yes, all buttons in control panel need gatox's love | 13:34 |
gatox | nessita, :P | 13:34 |
gatox | crap... i have to elevate the process in order to launch the uninstall process | 13:40 |
ralsina | gatox: should ask on its own | 13:44 |
ralsina | doesn't it? | 13:44 |
gatox | ralsina, no... popen fails because its need to be elevated | 13:45 |
gatox | ralsina, i'm looking if i can do it with ShellExecute | 13:45 |
nessita | ralsina: replied to your comments in MP | 13:45 |
nessita | ralsina: would you answer before me re-reviewing? | 13:45 |
ralsina | nessita: of course | 13:46 |
ralsina | nessita: replied, will add two more tests and get back to you | 13:50 |
nessita | thanks! | 13:50 |
nessita | ralsina, gatox: QT question: is there any way of replacing a widget's layout with another one? | 13:58 |
ralsina | nessita: on designer, or on runtime? | 13:58 |
nessita | ralsina: runtime | 13:59 |
ralsina | nessita: yes, but it's one of those things that usually means you are trying to do something evil :-) | 13:59 |
gatox | nessita, yes | 13:59 |
gatox | nessita, setLayout | 13:59 |
nessita | gatox: but if I already have a layout that thorws a warning | 13:59 |
nessita | I need to remove the old one first | 13:59 |
nessita | door bell! brb | 14:00 |
gatox | nessita, i don't think so... :S | 14:00 |
ralsina | nessita: you would have to remove all widgets from the old layout, remove the layout from the "outer" widget, set the new layout, add the widgets to the new layout | 14:00 |
ralsina | if you don't do it this way, where each widget will end in the new layout is undetermined, I think | 14:00 |
gatox | ralsina, but it's cool to add another layout or set a button with different text sizes :P | 14:00 |
ralsina | gatox: sometimes evil is cool ;-) | 14:01 |
gatox | ralsina, jeje | 14:01 |
gatox | ralsina, we are still using win32api in u1, don't we? | 14:03 |
ralsina | gatox: you mean via ctypes? Yes, there is one small place | 14:03 |
gatox | ralsina, no...... via import win32api | 14:03 |
ralsina | gatox: don't remember | 14:03 |
gatox | ..........please say yes...... please say yes........ jejeje | 14:03 |
ralsina | gatox: grep is your friend | 14:04 |
ralsina | what for | 14:04 |
ralsina | ? | 14:04 |
gatox | ralsina, right! | 14:04 |
* gatox checking | 14:04 | |
gatox | ralsina, to elevate the process | 14:04 |
ralsina | ok | 14:04 |
ralsina | gatox: worse case I can give you a bat that elevates | 14:06 |
gatox | ralsina, i think i found another way too.... but it's dirtier... this is a clean call to the system apis | 14:06 |
ralsina | yes, agreed ShellExecute is "the right way" | 14:07 |
ralsina | gatox: try runnig "start c:\sdfadfadsfasdfsadf\Ubuntuone uninstaller.lnk" :-) | 14:09 |
gatox | ralsina, win32api is being used in ubuntuone-client | 14:10 |
ralsina | gatox: yay! ;-) | 14:10 |
gatox | :D | 14:10 |
* nessita is back | 14:12 | |
nessita | ralsina: so, what I need is that a given widget, shows a given screen in one condition, and another in another condition. I managed to do so with no problem. But later in time, this condition may vary, so I need to morph the outter widget into something else | 14:13 |
ralsina | nessita: is the content the same? Or is the content in the two situations completely different widgets? | 14:13 |
nessita | ralsina: completely different widgets | 14:13 |
ralsina | if it's completely different, do them separately and use a QStackWidget to flip between them | 14:14 |
nessita | ralsina: ah! that may be the proper solution! /me reads about the stack widget | 14:14 |
gatox | ralsina, +1 | 14:14 |
ralsina | nessita: it's like a tab widget without tabs, if that makes sense ;-) | 14:14 |
gatox | nessita, you have QStackedLayout too | 14:15 |
* ralsina had not heard of QStackedLayout before | 14:15 | |
gatox | ralsina, is very much the same thing....... but more layout oriented, not so very much tuning capabilities :P | 14:17 |
ralsina | gatox: yeah, seems QStackedWidget is just a wrapper around it | 14:18 |
nessita | ralsina: a stacked thingy is what I need! | 14:29 |
ralsina | nessita: glad to be of assistance! | 14:29 |
dobey | brb, gotta go pick up truck from dealer | 14:37 |
ralsina | nessita: pushed local-folders with the two suggested tests added | 14:38 |
nessita | great! | 14:38 |
ralsina | nessita, gatox: since we are all going to pycon.ar ... how do you feel about a short sprint in Junin? I am just starting to think about it | 14:40 |
ralsina | I think our last one was really productive | 14:41 |
gatox | ralsina, that would be great for me | 14:41 |
nessita | ralsina: sounds great! | 14:41 |
nessita | ralsina: I would need to make it the same week than the "semana del estudiante", so I can skip teaching duties | 14:42 |
ralsina | nessita: it's that week, right? 19->23 september? | 14:42 |
nessita | ralsina: which I'm 90% sure is the week where pycon starts: so we could have 4 days of sprint at least | 14:42 |
nessita | yes | 14:42 |
ralsina | looks like a good idea to me | 14:42 |
nessita | +10 | 14:42 |
gatox | ralsina, totally agreed! :P | 14:43 |
nessita | ralsina: is there a better way to do this: | 14:43 |
nessita | self.ui.switcher.setCurrentIndex(self.ui.switcher.indexOf(self.ui.signin)) | 14:43 |
nessita | switcher is the stackedwidget | 14:43 |
ralsina | nessita: only if you keep track of the indexes yourself | 14:43 |
nessita | right | 14:43 |
ralsina | like self.siginin_id = whatever.addWidget(self.ui.signin) | 14:43 |
ralsina | or somesuch | 14:43 |
nessita | right | 14:44 |
gatox | nessita, there is a better way! | 14:44 |
nessita | gatox: SHOOT | 14:45 |
gatox | nessita, if you know the widget (self.ui.signin) | 14:45 |
nessita | I do | 14:45 |
nessita | <rachel>I dooooooooooooooo</rachel> | 14:45 |
gatox | nessita, you can do self.ui.switcher.setCurrentWidget(self.ui.signin) | 14:45 |
gatox | nessita, and it will change the current index to where that widget is | 14:45 |
nessita | nice | 14:45 |
nessita | ralsina: while I review your branch, would you take a look to a non-ready-for-review-yet branch that uses this stacked thingy, to give me some feedback? | 14:47 |
ralsina | nessita: sure | 14:48 |
tntc | hey guys. I'm still having that playlist issue on Android (presumably because I'm still on the flakey server). Is there way to get moved to another server so I can use my U1Mobile? | 14:48 |
nessita | beuno: would you please? ^ | 14:48 |
ralsina | nessita: sure, point me and I'll start reading | 14:49 |
beuno | tntc, there isn't, no :( | 14:49 |
nessita | ralsina: https://code.launchpad.net/~nataliabidart/ubuntuone-control-panel/disconnect-flow. SO, having credentials, go to the DEvice tab and remove the current device. The code has the actual call to the backend commented out due to a bug in the rest method which is, atm, failing. But the code will lead you to the signin page as per design | 14:50 |
nessita | ralsina: then, if you really remove your credentials (go to the keyring and remove), and if you start the control panel, you will get the same page as first page | 14:51 |
ralsina | ok, checking | 14:51 |
tntc | beuno: That's a huge bummer. I mean, I have 100gb of storage, and mobile for a year, and I haven't been able to save a playlist the entire time I've had it! | 14:51 |
nessita | ralsina: I'm doing this since lisete was not very happy with the simpler proposal, and I can see why: closing the app is ugly, I know... | 14:52 |
beuno | tntc, I know, we're working hard to fix that couchdb server | 14:52 |
ralsina | nessita: agreed it'snot nice, and then he gets a signup button anyway :-( | 14:52 |
ralsina | nessita: does this impact our idea of having only the wizard as entry point for the user? | 14:53 |
tntc | beuno: If I canceled my account and then re-signed up, would it still be on that server? | 14:53 |
beuno | tntc, oh, yes, that's a way to do it, cancel your account and create a new one (with a new email address and SSO account). We can refund you for the lost months you already paid for in storage and music streaming | 14:55 |
beuno | joshuahoover1, ^ | 14:55 |
tntc | beuno: I need a different e-mail address? | 14:55 |
nessita | ralsina: not at all, this is just a robust screen if the user goes and executes the .exe by its own, byt browsin the app programs, for exmaple | 14:55 |
beuno | tntc, yeah, because it's tied to SSO | 14:55 |
ralsina | nessita: ok, good idea | 14:55 |
nessita | ralsina: I still think the entry point should be the wizard | 14:55 |
nessita | ralsina: is for free if we do the disconnect flow | 14:55 |
* ralsina loves free stuff | 14:56 | |
tntc | beuno: well, that's kind of a pain, but if it works it's worth it. what happens to my data currently synced? | 14:56 |
ralsina | nessita: seems to do The Right Thing (TM) | 14:56 |
ralsina | nessita: want me to check code? | 14:56 |
nessita | ralsina: not yet, is aweful and pacthy | 14:56 |
nessita | ralsina: you like it? | 14:56 |
joshuahoover1 | duanedesign: can you help tntc? | 14:56 |
=== joshuahoover1 is now known as joshuahoover | ||
* beuno hands tntc over to duanedesign and joshuahoover | 14:56 | |
ralsina | nessita: let me look again with critical eyes ;-) | 14:57 |
nessita | please | 14:57 |
duanedesign | yes | 14:57 |
duanedesign | hello tntc | 14:57 |
tntc | hey duanedesign! | 14:58 |
tntc | wait, is there a way to just wipe my current U1 account and SSO account, and start from scratch? | 14:58 |
ralsina | nessita: if you mean aesthetically, of course everythng pushed into a corner is not a good idea | 14:59 |
ralsina | nessita: Also, the second time I tried starting it, I got stuck with the overlay showing | 14:59 |
tntc | beuno: joshuahoover: thanks guys! | 14:59 |
duanedesign | tntc: yes. You could cancel your U1 subscriptions and create a new SSO account | 14:59 |
tntc | duanedesign: is there a way to kill off my old SSO account, so I can use the same e-mail address? | 14:59 |
duanedesign | tntc: then sign up under the new SSO account | 14:59 |
ralsina | nessita: also "Forgot your password" below "sign in" and "cancel" is not nice | 14:59 |
ralsina | other than that: well, it's a login screen, functional is good. | 15:01 |
duanedesign | tntc: you sould use a free gmail account | 15:03 |
tntc | duanedesign: I currently use gmail. Are you saying I should sign up for a new gmaila account? | 15:03 |
tntc | gmail* rather than keeping my old one? | 15:03 |
tntc | I'm reluctant, but ok with that | 15:03 |
duanedesign | tntc: you can get your SSO account deleted but it has to be done manually, AFAIK. So it takes aawhile | 15:03 |
dobey | or not. meh | 15:04 |
tntc | duanedesign: how long is a while? | 15:05 |
nessita | ralsina: right, that has to be a link, and I was planning on having users being redirected to teh web site to have a password reminder | 15:05 |
duanedesign | tntc: i am pretty sure this is where you file a question to get the SSO account deleted https://answers.launchpad.net/canonical-identity-provider/+addquestion | 15:05 |
ralsina | nessita: yes, no point on doing more sso-in-u1cp than strictly needed | 15:06 |
nessita | yes | 15:06 |
tntc | duanedesign: yeah, I don't want to break that anyhow. I've set up a new e-mail address. I'll sign up with sso right now. | 15:07 |
duanedesign | tntc: ok great | 15:07 |
tntc | ok, I've got my new sso and u1 account | 15:08 |
tntc | duanedesign: how do we do this thing? :D | 15:09 |
tntc | duanedesign: there's no way to move my files over, right? | 15:13 |
nessita | ralsina: branch looks good, will run tests now | 15:14 |
ralsina | nessita: \o/ | 15:15 |
nessita | ralsina: all green, 3 minor lint issues to fix | 15:20 |
nessita | added to the MP | 15:20 |
ralsina | nessita: cool, could you approve? I don't want to bother you again after the lint fixes | 15:21 |
nessita | sure! | 15:21 |
nessita | ralsina: done. Chipaca can review it now! :-) | 15:21 |
ralsina | Chipaca: ^^ | 15:22 |
tntc | duanedesign: so I've got my new sso account, etc. how do I go about switching this around? | 15:22 |
nessita | gatox: you have some of the branches ready for review? (ie with the approval of ralsina?) | 15:22 |
ralsina | nessita: will be in a few minutes, I got derailed | 15:23 |
gatox | nessita, ralsina i'm finishing another branch........ | 15:23 |
* gatox is monkey patching :P | 15:23 | |
ralsina | nessita: other than the useless import, those were pep8-0.5-is-different-than-pep8-0.6 whitespace issues, fixed and pushed. | 15:25 |
* ralsina goes back to gatox's branches | 15:25 | |
nessita | ralsina: great | 15:27 |
ralsina | gatox: I don't understand focus_changed | 15:31 |
gatox | ralsina, mmmmmmm why? | 15:31 |
gatox | receive from which object the focus moved to which object | 15:32 |
ralsina | gatox: because I don't understand what it's trying to do :-) | 15:32 |
gatox | ralsina, so, if now (the object who receive the focus) is password_edit, so we need to show the assistance | 15:33 |
gatox | ralsina, if password_edit lost the focus | 15:33 |
ralsina | for example: it shows the password assistance when you enter password, and it will just stay shown forever? | 15:33 |
gatox | we need to run the checks to see if passwords matches | 15:33 |
Chipaca | nessita: ralsina: link again please (sorry)? | 15:34 |
gatox | ralsina, or we can hide it if everything is ok...... it wasn't specified...... do you want me to add that? | 15:34 |
ralsina | Chipaca: https://code.launchpad.net/~ralsina/ubuntuone-windows-installer/local-folder-fixes/+merge/71857 | 15:34 |
ralsina | gatox: what happens if the user clicks and starts typing on the password confirmation widget? | 15:35 |
ralsina | gatox: no, keeping it shown is ok, just asking if it was intentional | 15:35 |
* ralsina knows that's a very silly user | 15:35 | |
gatox | ralsina, yes, you are right, we should check if password_edit is losing focus OR confirmation is gaining it | 15:36 |
gatox | in the elif part | 15:36 |
ralsina | yeah, other than that, I like it | 15:36 |
gatox | that would be the proper behavior | 15:36 |
* gatox fixing | 15:36 | |
ralsina | reacting to focus changes is a pain in the butt, but hey, it's the way to do it | 15:37 |
ralsina | I am also not convinced that having the "refresh the captcha" label hidden until you try to type it is a good idea. If it's unreadable, you will not try to type it, and never see that you can refresh it. | 15:38 |
gatox | ralsina, ok..... i will leave it on | 15:39 |
ralsina | gatox: cool. | 15:39 |
ralsina | nessita: I did approve https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/improve-EnhancedLineEdit/+merge/72064 | 15:40 |
nessita | ralsina: ack, looking | 15:40 |
nessita | gatox: teeeeessssstsssss :-) | 15:48 |
nessita | gatox: we would like to cover the foillowing: | 15:49 |
* gatox reading... | 15:49 | |
nessita | show_button behaves in a given way (if the string is valid, X buttons is visible, Y is not, otherwise, X button is not visible, Y is) | 15:49 |
nessita | or label* | 15:50 |
nessita | gatox: and you may wanna assert over some of the things you're setting to self.clear_label, the most important ones | 15:50 |
nessita | by important I mean those that are key pieces to the user experience | 15:50 |
gatox | nessita, ok... copy that! :P | 15:50 |
nessita | such as setProperty("lineEditWarning", True) | 15:51 |
nessita | but the margin is not required to be tested | 15:51 |
nessita | makes sense? | 15:51 |
gatox | nessita, yes! | 15:51 |
nessita | :-) | 15:51 |
gatox | nessita, on it | 15:52 |
ralsina | nessita: are we adding tests to existing code, too? I thought we weren't which is why I didn't ask for those | 15:55 |
nessita | ralsina: not to existent code but yes to code it was there and we're changing | 15:56 |
nessita | ralsina: so, "no line of code we add/modify should end up untested" | 15:56 |
ralsina | nessita: ok | 15:56 |
gatox | ralsina, this branch is ready with the changes in focus_changed: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 | 15:56 |
gatox | ralsina, nessita also i have this branch ready for review: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/uninstall/+merge/72209 | 15:56 |
ralsina | gatox: that last ons is for after lunch, I think | 15:57 |
* gatox now is fixing sso branch | 15:57 | |
ralsina | gatox: you should add tests that after __init__ the signals are connected, to prevent regressions | 15:59 |
gatox | ralsina, ok..... fixing..... | 16:00 |
ralsina | gatox: there are FakeSignal classes that should make that one boring and easy (or maybe they are in my local_folders branch) | 16:00 |
ralsina | gatox: same about the visibility of things after __init__. You could do one test for all those asserts | 16:01 |
ralsina | other than that, the assistance methods already have tests, you added for focus_changed, I think we would be covered | 16:02 |
ralsina | And, having used my inner nessita, I go make me a sandwich | 16:02 |
nessita | :-) | 16:03 |
* gatox is shaking | 16:04 | |
fagan | ralsina: do you need an exorcist for that inner nessita? | 16:05 |
ralsina | fagan: I think the sandwich will be enough! | 16:06 |
ralsina | it has HAM in it | 16:06 |
fagan | ralsina: radios are not very nutritious | 16:07 |
* fagan is king of bad jokes | 16:07 | |
=== beuno is now known as beuno-lunch | ||
fagan | ralsina: is next week my last week? | 16:23 |
* fagan was wondering | 16:23 | |
ralsina | fagan: beats me! | 16:23 |
ralsina | fagan: I'll ask! | 16:23 |
fagan | ralsina: Ill have a check im pretty sure it is | 16:23 |
fagan | ralsina: 26th of august is my end date | 16:24 |
fagan | Anyway see you all on monday | 16:29 |
dobey | back | 16:29 |
ralsina | I am not feeling all that well (sore throat+sinusitis) I am going to take a short break, will be back in 90 minutes or so | 16:42 |
dobey | ralsina: weren't you reviewing https://code.launchpad.net/~dobey/ubuntuone-installer/learn-more/+merge/72086 yesterday btw? :) | 16:43 |
ralsina | dobey: yes I was | 16:43 |
dobey | ralsina: there's no review on it :P | 16:43 |
ralsina | I probably didn't finish it though | 16:43 |
dobey | feel better anyway | 16:43 |
dobey | maybe some fernet (or cough syrup) will help | 16:44 |
ralsina | dobey: gave you a +1, I had tried running it and it worked, and code looks simple enough | 16:44 |
dobey | thanks! | 16:44 |
nessita | ralsina, gatox: is there a way to define relative sizes in the qss? like "80%" of the default size | 16:45 |
nessita | or something similar | 16:45 |
ralsina | nessita: you can specify % and is relative to the parent | 16:45 |
nessita | nice! | 16:45 |
ralsina | works for widths and heights, not for fonts. I think. | 16:45 |
nessita | something like:L | 16:45 |
nessita | oh | 16:45 |
gatox | ralsina, yes, not for fonts | 16:45 |
nessita | I need to set a font to be smaller than the parent's | 16:45 |
nessita | the only way is using a fixed size in px? :-/ | 16:46 |
ralsina | nessita: you could use something like 0.8em | 16:46 |
ralsina | I am not sure if that works, but it's legal | 16:47 |
ralsina | font-size is defined as Number (px | pt | em | ex) | 16:47 |
nessita | 232 QLabel#email_label { | 16:47 |
nessita | 233 font-size: 0.5em; | 16:47 |
nessita | 234 } <- that is correct syntax, right? | 16:47 |
ralsina | right | 16:47 |
nessita | if so, no, it does not work | 16:47 |
ralsina | just to be sure you got the selectors and the rest right, something silly like 80px works? | 16:48 |
nessita | yes | 16:48 |
ralsina | and something sily like 50em doesn't? | 16:49 |
nessita | nopes | 16:49 |
ralsina | in that case it's an "I don't know" :-( | 16:49 |
ralsina | You can do it in code | 16:49 |
nessita | is ok :-) | 16:49 |
nessita | ralsina: I think I prefer fixed font size before doing it in the code | 16:50 |
ralsina | we could use a templated CSS (yeah, right) | 16:50 |
ralsina | ok, I'm off to see if I can clear my head :-( | 16:51 |
gatox | nessita, i added test to my sso branch........ i don't want to brag.... but i think you are going to be very happy jejeje https://code.launchpad.net/~diegosarmentero/ubuntu-sso-client/improve-EnhancedLineEdit/+merge/72064 | 16:52 |
nessita | gatox: looking! | 16:54 |
nessita | gatox: no need to add this: | 16:56 |
nessita | 82+ def setUp(self): | 16:56 |
nessita | 83+ """Set tests.""" | 16:56 |
gatox | nessita, i forgot some docstrings | 16:56 |
nessita | you always should call the parent class with super(), but since you are not doing any specific setup, just remove the method | 16:57 |
gatox | nessita, ok | 16:57 |
gatox | nessita, i'm fixing missing docstrings | 16:58 |
gatox | nessita, docstrings added | 16:59 |
gatox | nessita, and method removed | 17:00 |
nessita | gatox: ubuntu_sso/qt/tests/test_enchanced_line_edit.py: | 17:08 |
nessita | 71: [C0301] Line too long (80/79) | 17:08 |
gatox | nessita, ok | 17:08 |
gatox | nessita, done | 17:10 |
nessita | gatox: what cursor is 0? | 17:11 |
gatox | arrow | 17:11 |
nessita | gatox: I just used this for a widget in the control panel: | 17:11 |
nessita | 36 self.setCursor(QtCore.Qt.PointingHandCursor) | 17:11 |
nessita | can you do that with the arrow cursor? | 17:11 |
gatox | nessita, ok | 17:12 |
nessita | otherwise looking at 0 is kind of confusing | 17:12 |
nessita | gatox: though i haven't checked yet if that works on windows... | 17:12 |
gatox | nessita, yes, it will work, it's the same | 17:13 |
nessita | it should, maybe we need to create the QCursor as well | 17:13 |
nessita | gatox: so, instead of 0 I would advice using QtCore.Qt.ArrowCursor | 17:13 |
gatox | nessita, yes, i'm changing that | 17:14 |
nessita | gatox: I'm approving after that | 17:14 |
gatox | nessita, done | 17:15 |
gatox | ralsina, ping | 17:19 |
nessita | ok, I gotta grab some lunch and leave to the uni | 17:39 |
nessita | feel free to email me anything that you need | 17:39 |
nessita | have a great weekned weekend everyone! | 17:39 |
gatox | ralsina, are you there' | 18:06 |
gatox | ? | 18:06 |
* dobey not feeling so great today either | 18:10 | |
=== gatox_ is now known as DiegoSarmentero | ||
gatox_ | ralsina, my branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-windows-installer/setupaccount-form-behavior/+merge/71937 is ready, all the tests has been added | 18:36 |
* gatox_ needs to restart | 18:37 | |
tntc | duanedesign: same problem. can't save playlists. network error. | 18:58 |
tntc | even on the new account. did it just get created on the same broken server? | 18:59 |
=== beuno-lunch is now known as beuno | ||
* ralsina is (sort of) back | 19:31 | |
tntc | yeah, so that server with broken couchdb, are you guys still adding users to that? because my new account has the same problem as the old one. can't save playlists. | 19:35 |
tntc | so I'm a little irked. | 19:37 |
ralsina | tntc: I am really sorry to hear of all your problems. Let me see if I can still find someone who can help you. | 19:41 |
tntc | thanks ralsinaa | 19:41 |
tntc | sorry, that last "a" was supposed to be an !. imm on my cell phone. | 19:42 |
ralsina | no problem :-) | 19:43 |
tntc | on the plus side, the music controls on my headset work great with u1m | 19:44 |
ralsina | tntc: I can't get a hold of anyone right now | 19:47 |
ralsina | tntc: I will mail them to make sure they look at it first thing moday morning | 19:47 |
ralsina | and again, I'm really sorry about the troubles | 19:47 |
tntc | this would bother me less if I hadn't just moved all my subscriptions to the other account under the impression that it would work. can we at least revert that change in the mean time? | 19:52 |
ralsina | tntc: sorry, I am on the desktop development group, I have n server access | 19:55 |
ralsina | tntc: just got a response from the server-side manager, the persons to fix this are in Europe and it's late already, but they will be able to look at what happened very early monday morning | 19:56 |
tntc | I'm really frustrated. I have never managed to save a playlist the entire time I've had U1M. | 19:58 |
tntc | ralsina: do they think a solution will be found, or do they think I'm stuck? | 20:15 |
ralsina | tntc: I am sure we can find a solution | 20:15 |
tntc | ralsina: has any progress been made on the malfunctioning couchdb? | 20:16 |
tntc | what time should I be here on monday? | 20:17 |
ralsina | tntc: I am thinking 1PM UTC should be a good time | 20:18 |
tntc | ok. I'll be here! | 20:19 |
ralsina | I'm off. Can't code crap because of the sinuses :-( | 21:01 |
ralsina | I'll try to make a release late tonight, or maybe on sunday | 21:01 |
=== yofel_ is now known as yofel | ||
dobey | have a good weekend people | 21:06 |
=== gatox_ is now known as gatox |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!